Booting zImage with appended DTB without ATAGs support

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 11:20:01 Tom Rini wrote: > On Fri, Nov 05, 2021 at 04:16:46PM +0100, Pali Rohár wrote: > > So now I have a question: Do we want to support booting zImage with > > appended DTB in U-Boot when ATAGs support is now disabled by default? > > Based on your experience, yes,

[PATCH 1/1] doc: mmc rescan speed mode

2021-11-05 Thread Heinrich Schuchardt
Provide human readable descriptions of the speed nodes instead of the name of constants from the code. Signed-off-by: Heinrich Schuchardt --- doc/usage/mmc.rst | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/doc/usage/mmc.rst

[PATCH] makefile: add missing semicolons

2021-11-05 Thread Angelo Dureghello
On some distributions, as Debian GNU 11, this targets fails with errors. Signed-off-by: Angelo Dureghello --- Makefile | 2 +- scripts/Makefile.autoconf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index c45da3ad88..1a1d1b0426

Re: A38x: Broken Linux kernel booting over UART

2021-11-05 Thread Tom Rini
On Fri, Nov 05, 2021 at 04:16:46PM +0100, Pali Rohár wrote: > On Friday 05 November 2021 10:35:10 Tom Rini wrote: > > On Fri, Nov 05, 2021 at 12:38:21PM +0100, Pali Rohár wrote: > > > On Monday 11 October 2021 17:49:05 Pali Rohár wrote: > > > > On Monday 11 October 2021 10:45:44 Tom Rini wrote: >

Re: A38x: Broken Linux kernel booting over UART

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 10:35:10 Tom Rini wrote: > On Fri, Nov 05, 2021 at 12:38:21PM +0100, Pali Rohár wrote: > > On Monday 11 October 2021 17:49:05 Pali Rohár wrote: > > > On Monday 11 October 2021 10:45:44 Tom Rini wrote: > > > > On Mon, Oct 11, 2021 at 04:33:44PM +0200, Pali Rohár wrote: >

Re: [PATCH] lib: sparse: Make CHUNK_TYPE_RAW buffer aligned

2021-11-05 Thread Sean Anderson
Hi quanfan, Thanks for the patch. I had something similar in mind. On 11/5/21 1:46 AM, qianfangui...@qq.com wrote: From: qianfan Zhao CHUNK_TYPE_RAW buffer is not aligned, and flash sparse images by fastboot will report "Misaligned operation" if DCACHE is enabled. Flashing Sparse Image

Re: [PATCH 3/4] gpio: sunxi: Implement .set_flags

2021-11-05 Thread Heinrich Schuchardt
On 10/21/21 06:52, Samuel Holland wrote: This, along with gpio_flags_xlate(), allows the GPIO driver to handle pull-up/down flags provided by consumer drivers or in the device tree. Signed-off-by: Samuel Holland Reviewed-by: Simon Glass --- drivers/gpio/sunxi_gpio.c | 62

Re: A38x: Broken Linux kernel booting over UART

2021-11-05 Thread Tom Rini
On Fri, Nov 05, 2021 at 12:38:21PM +0100, Pali Rohár wrote: > On Monday 11 October 2021 17:49:05 Pali Rohár wrote: > > On Monday 11 October 2021 10:45:44 Tom Rini wrote: > > > On Mon, Oct 11, 2021 at 04:33:44PM +0200, Pali Rohár wrote: > > > > On Monday 11 October 2021 10:32:22 Tom Rini wrote: > >

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Tom Rini
On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: > Hi Andre, > > Added Tom to Cc. > > On 05.11.21 11:04, Andre Przywara wrote: > > On Thu, 4 Nov 2021 20:02:41 -0600 > > Simon Glass wrote: > > > > Hi, > > > > > On Thu, 4 Nov 2021 at 19:22, Stefan Roese wrote: > > > > > > > > Hi

Re: [PATCH 2/4] sunxi: gpio: Add per-bank drive and pull setters

2021-11-05 Thread Heinrich Schuchardt
On 10/21/21 06:52, Samuel Holland wrote: The GPIO and pinctrl drivers need these setters for pin configuration. Since they are DM drivers, they should not be using hardcoded base addresses. Factor out variants of the setter functions which take a pointer to the GPIO bank's MMIO registers.

Re: [PATCH 1/4] sunxi: gpio: Return void from setter functions

2021-11-05 Thread Heinrich Schuchardt
On 10/21/21 06:52, Samuel Holland wrote: The return values of these functions are always zero, and they are never checked. Since they are not needed, remove them. Signed-off-by: Samuel Holland Reviewed-by: Heinrich Schuchardt

[PATCH] rtc: ds1337: fix compatible string typo

2021-11-05 Thread Clemens Gruber
The driver supports the ds1339 as well, which was probably intended by the author but prevented by a typo. Fix the typo. Signed-off-by: Clemens Gruber --- drivers/rtc/ds1337.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/ds1337.c b/drivers/rtc/ds1337.c index

[PATCH] mmc: mtk-sd: implement waiting for DAT0 line state

2021-11-05 Thread Julien Masson
With the recent changes on mmc driver, we saw that the boot is ~5 secs longer compared to v2021.07 on mediatek platforms. This regression is seen during mmc_init and caused by the following patch [1]. Indeed since we did not support poll dat0, we fulfilled the condition of [1] and a delay of 500

Re: [PATCH] driver: gadget: fastboot: Link endpoint and descriptors

2021-11-05 Thread Sean Anderson
On 11/5/21 2:28 AM, qianfan wrote: 在 2021/11/4 0:53, Sean Anderson 写道: On 9/16/21 3:02 AM, qianfangui...@163.com wrote: From: qianfan Zhao If the downloading file size is equal to the partition size, "fastboot flash" can't work, at least in sunxi platform, because used an uninitalized

Re: Injecting public keys into FTDs for FIT verification

2021-11-05 Thread Jan Kiszka
On 05.11.21 13:42, Jan Kiszka wrote: > On 05.11.21 11:28, Rasmus Villemoes wrote: >> On 05/11/2021 11.16, Jan Kiszka wrote: >>> Hi all, >>> >>> in order to use CONFIG_FIT_SIGNATURE and also >>> CONFIG_SPL_FIT_SIGNATURE, a public key needs to be placed into the >>> control FDT. So far, I only found

Re: [RFC PATCH 00/23] sunxi: Add and use a pinctrl driver

2021-11-05 Thread Heinrich Schuchardt
On 10/21/21 06:55, Samuel Holland wrote: This series resolves some longstanding TODOs by implementing a pinctrl driver for sunxi platforms and converting DM drivers to use it. I am sending this as RFC because I have only tested this on a limited amount of hardware, and there are quite a few

Re: [PATCH v1 2/2] bsh: imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards

2021-11-05 Thread Ariel D'Alessandro
Hi all, On 11/3/21 4:56 PM, Ariel D'Alessandro wrote: > Introduce BSH SystemMaster (SMM) S2 board family, which consists of: > iMX8MN SMM S2 and iMX8MN SMM S2 PRO boards. > > Add support for iMX8MN BSH SMM S2 board: > > - 256 MiB DDR3 RAM > - 512MiB Nand > - USBOTG1 peripheral - fastboot. > >

Re: Injecting public keys into FTDs for FIT verification

2021-11-05 Thread Jan Kiszka
On 05.11.21 11:28, Rasmus Villemoes wrote: > On 05/11/2021 11.16, Jan Kiszka wrote: >> Hi all, >> >> in order to use CONFIG_FIT_SIGNATURE and also >> CONFIG_SPL_FIT_SIGNATURE, a public key needs to be placed into the >> control FDT. So far, I only found mkimage being able to do that during >> FIT

Re: A38x: Broken Linux kernel booting over UART

2021-11-05 Thread Pali Rohár
On Monday 11 October 2021 17:49:05 Pali Rohár wrote: > On Monday 11 October 2021 10:45:44 Tom Rini wrote: > > On Mon, Oct 11, 2021 at 04:33:44PM +0200, Pali Rohár wrote: > > > On Monday 11 October 2021 10:32:22 Tom Rini wrote: > > > > On Mon, Oct 11, 2021 at 04:25:48PM +0200, Pali Rohár wrote: > >

Re: [PATCH v2 08/12] sysinfo: Add support for iterating string list

2021-11-05 Thread Marek Behún
On Thu, 4 Nov 2021 20:02:29 -0600 Simon Glass wrote: > Better to make iter a struct sysinfo_str_list_iter, I think and > require the caller to declare it: > > sysinfo_str_list_iter iter; > char str[80]' > > p = sysinfo_str_list_first(dev, i, , sizeof(str), ); > ... > > Do you need the iter? >

Re: [PATCH v2 06/12] sysinfo: Add get_str_list() method

2021-11-05 Thread Marek Behún
On Thu, 4 Nov 2021 20:02:27 -0600 Simon Glass wrote: > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > From: Marek Behún > > > > Add get_str_list() method to sysinfo operations. > > > > The get_str_list() method is similar to get_str(), but receives one > > additional argument, @idx,

Re: [PATCH v2 04/12] sysinfo: Make sysinfo_get_str() behave like snprintf()

2021-11-05 Thread Marek Behún
On Thu, 4 Nov 2021 20:02:25 -0600 Simon Glass wrote: > Hi Marek, > > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > From: Marek Behún > > > > Currently sysinfo_get_str() returns 0 if a string is filled in the > > given buffer, and otherwise gives no simple mechanism to determine > >

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Stefan Roese
Hi Andre, Added Tom to Cc. On 05.11.21 11:04, Andre Przywara wrote: On Thu, 4 Nov 2021 20:02:41 -0600 Simon Glass wrote: Hi, On Thu, 4 Nov 2021 at 19:22, Stefan Roese wrote: Hi Andre, On 05.11.21 00:11, Andre Przywara wrote: On Thu, 4 Nov 2021 11:37:57 +0100 Stefan Roese wrote: Hi

Re: Injecting public keys into FTDs for FIT verification

2021-11-05 Thread Rasmus Villemoes
On 05/11/2021 11.16, Jan Kiszka wrote: > Hi all, > > in order to use CONFIG_FIT_SIGNATURE and also > CONFIG_SPL_FIT_SIGNATURE, a public key needs to be placed into the > control FDT. So far, I only found mkimage being able to do that during > FIT image signing. That is fairly unhandy and often

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 09:38:28 Pali Rohár wrote: > Hello! > > On Thursday 04 November 2021 23:27:32 Tony Dinh wrote: > > Hi Marek and Pali, > > > > First off all, thanks for your hughe work on this. I have a few Armada > > 38x boards that I had quite a hard time running kwboot in the past.

Injecting public keys into FTDs for FIT verification

2021-11-05 Thread Jan Kiszka
Hi all, in order to use CONFIG_FIT_SIGNATURE and also CONFIG_SPL_FIT_SIGNATURE, a public key needs to be placed into the control FDT. So far, I only found mkimage being able to do that during FIT image signing. That is fairly unhandy and often incompatible with how firmware is built & signed vs.

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Andre Przywara
On Thu, 4 Nov 2021 20:02:41 -0600 Simon Glass wrote: Hi, > On Thu, 4 Nov 2021 at 19:22, Stefan Roese wrote: > > > > Hi Andre, > > > > On 05.11.21 00:11, Andre Przywara wrote: > > > On Thu, 4 Nov 2021 11:37:57 +0100 > > > Stefan Roese wrote: > > > > > > Hi Stefan, > > > > > >> On 04.11.21

[PATCH] crypto/fsl: Fallback to SW sha1/256 is misaligned buffers

2021-11-05 Thread Christian Sørensen
Problem: With U-Boot 2021.10, we currently cannot load a fitImage on our imx7d board, due to misaligned buffers. Reason: Commit 92055e138f28 ("image: Drop if/elseif hash selection in calculate_hash()") changed the way the FIT were verified. Previously, SW sha1/256 were always used. Due to that

Re: [PATCH v5 02/11] tools: mkeficapsule: add firmwware image signing

2021-11-05 Thread AKASHI Takahiro
On Fri, Nov 05, 2021 at 11:35:00AM +0900, AKASHI Takahiro wrote: > On Thu, Nov 04, 2021 at 08:02:40PM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Thu, 4 Nov 2021 at 19:04, AKASHI Takahiro > > wrote: > > > > > > Hi, Simon, > > > > > > On Thu, Nov 04, 2021 at 09:11:59AM -0600, Simon

[PATCH 2/2] arm: imx8m: imx8mm-cl-iot-gate: detect extension board

2021-11-05 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" Extension boards can be added to Compulab's iot-gate-imx8mm. We implement extension board manager for detecting the extension boards. Signed-off-by: Uri Mashiach Signed-off-by: Ying-Chun Liu (PaulLiu) Cc: uboot-imx --- arch/arm/mach-imx/imx8m/Kconfig

[PATCH 1/2] arm: dts: imx8mm-cl-iot-gate: add Compulab's ied overlays

2021-11-05 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" add the following overlays: - IED extension board - CAN/TPM/ADC extension board on IED board. Signed-off-by: Uri Mashiach Signed-off-by: Ying-Chun Liu (PaulLiu) Cc: uboot-imx --- arch/arm/dts/Makefile| 20 -

[PATCH 0/2] arm: imx8m: imx8mm-cl-iot-gate: detect extension board

2021-11-05 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" Extension boards can be added to Compulab's iot-gate-imx8mm. We implement extension board manager for detecting the extension boards. The following overlays are added: - IED extension board - CAN/TPM/ADC extension board on IED board. Ying-Chun Liu (PaulLiu)

Re: [PATCH v2 11/12] arm: mvebu: Espressobin: Use new API for setting default env at runtime

2021-11-05 Thread Pali Rohár
On Thursday 04 November 2021 20:02:33 Simon Glass wrote: > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > From: Marek Behún > > > > ESPRESSObin's board code uses an ad-hoc solution for ensuring that > > ethaddrs are not overwritten by `env default -a` command and that the > > `fdtfile`

Re: Testing PCIe on Armada 370 (or older) in U-Boot

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 07:08:34 Stefan Roese wrote: > Hi Pali, > > On 04.11.21 16:49, Pali Rohár wrote: > > Hello! Recently I have sent more PCIe related patches for mvebu/armada > > SoCs into U-Boot. Now all were merged into U-Boot git master branch. > > I have tested everything on Armada

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Pali Rohár
Hello! On Thursday 04 November 2021 23:27:32 Tony Dinh wrote: > Hi Marek and Pali, > > First off all, thanks for your hughe work on this. I have a few Armada > 38x boards that I had quite a hard time running kwboot in the past. > Hopefully, I will have more luck with the new kwboot. > > Here is

Re: [PATCH v5 02/11] tools: mkeficapsule: add firmwware image signing

2021-11-05 Thread Mark Kettenis
> From: Simon Glass > Date: Thu, 4 Nov 2021 20:02:38 -0600 > > Hi Mark, > > On Thu, 4 Nov 2021 at 10:51, Mark Kettenis wrote: > > > > > From: Simon Glass > > > Date: Thu, 4 Nov 2021 09:11:59 -0600 > > > > > > Hi Mark, > > > > > > On Thu, 4 Nov 2021 at 08:31, Mark Kettenis > > > wrote: > > >

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-05 Thread François Ozog
On Fri, 5 Nov 2021 at 03:02, Simon Glass wrote: > Hi François, > > On Tue, 2 Nov 2021 at 10:03, François Ozog > wrote: > > > > Hi Simon, > > > > On Tue, 2 Nov 2021 at 15:59, Simon Glass wrote: > >> > >> Hi François, > >> > >> On Mon, 1 Nov 2021 at 02:53, François Ozog > wrote: > >> > > >> >

Re: [PATCH 2/6 v4] tpm2: Add a TPMv2 MMIO TIS driver

2021-11-05 Thread Ilias Apalodimas
On Fri, Nov 05, 2021 at 10:17:21AM +0200, Ilias Apalodimas wrote: > Hi Simon, > > [...] > > > > + u8 *result) > > > +{ > > > + struct tpm_tis_chip_data *drv_data = (void > > > *)dev_get_driver_data(udev); > > > + > > > + while (len--) > > > +

Re: [PATCH 2/6 v4] tpm2: Add a TPMv2 MMIO TIS driver

2021-11-05 Thread Ilias Apalodimas
Hi Simon, [...] > > + u8 *result) > > +{ > > + struct tpm_tis_chip_data *drv_data = (void > > *)dev_get_driver_data(udev); > > + > > + while (len--) > > + *result++ = ioread8(drv_data->iobase + addr); > > + return 0; > > +} > > + > >

Re: [RFC 2/2] binman: catch RunException for mkimage runtime failure

2021-11-05 Thread Heiko Thiery
Hi Simon, Am Fr., 5. Nov. 2021 um 03:02 Uhr schrieb Simon Glass : > > Hi Heiko, > > On Thu, 4 Nov 2021 at 12:53, Heiko Thiery wrote: > > > > In case mkimage exits with a return code other than zero do not stop. > > Print an error message and go on. > > > > Signed-off-by: Heiko Thiery > > --- >

Re: [PATCH 1/6 v4] tpm2: Introduce TIS tpm core

2021-11-05 Thread Ilias Apalodimas
Hi Simon, [...] > > > > +int tpm_tis_open(struct udevice *udev); > > Please add comments There are comments for all of those in drivers/tpm/tpm2_tis_core.c, isn't that enough? Thanks /Ilias > > > +int tpm_tis_close(struct udevice *udev); > > +int tpm_tis_cleanup(struct udevice *udev); > > +int

Re: [PATCH 11/14] watchdog: add support for MediaTek MT7621 SoC

2021-11-05 Thread Stefan Roese
On 04.11.21 10:50, Weijie Gao wrote: This patch makes mt7621_wdt driver available for MediaTek MT7621 SoC Signed-off-by: Weijie Gao Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 10/14] gpio: add support for MediaTek MT7621 SoC

2021-11-05 Thread Stefan Roese
On 04.11.21 10:50, Weijie Gao wrote: This patch makes mt7621_gpio driver available for MediaTek MT7621 SoC Signed-off-by: Weijie Gao Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] driver: gadget: fastboot: Link endpoint and descriptors

2021-11-05 Thread qianfan
在 2021/11/4 0:53, Sean Anderson 写道: On 9/16/21 3:02 AM, qianfangui...@163.com wrote: From: qianfan Zhao If the downloading file size is equal to the partition size, "fastboot flash" can't work, at least in sunxi platform, because used an uninitalized point: ep->desc. Hm, I think that

kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Tony Dinh
Hi Marek and Pali, First off all, thanks for your hughe work on this. I have a few Armada 38x boards that I had quite a hard time running kwboot in the past. Hopefully, I will have more luck with the new kwboot. Here is a problem I've found running kwboot on the Zyxel NSA310S NAS (Kirkwood

Re: [PATCH 1/1] sysreset: watchdog: watchdog cannot power off

2021-11-05 Thread Stefan Roese
On 04.11.21 10:31, Heinrich Schuchardt wrote: The watchdog system reset driver can reboot the device but it cannot power it off. If power off is requested, the driver should not reset the system but leave powering off to one of the other system reset drivers. As power cycling is typically not a

Re: Testing PCIe on Armada 370 (or older) in U-Boot

2021-11-05 Thread Stefan Roese
Hi Pali, On 04.11.21 16:49, Pali Rohár wrote: Hello! Recently I have sent more PCIe related patches for mvebu/armada SoCs into U-Boot. Now all were merged into U-Boot git master branch. I have tested everything on Armada 38x. I would like to ask if you have some Armada 370 board (or older,

<    1   2