Re: [PATCH v4 09/34] efi: Add EFI uclass for media

2021-11-08 Thread Simon Glass
Hi Heinrich, On Mon, 8 Nov 2021 at 08:39, Heinrich Schuchardt wrote: > > > > On 11/8/21 06:29, AKASHI Takahiro wrote: > > On Sun, Nov 07, 2021 at 09:43:22AM -0700, Simon Glass wrote: > >> Hi Heinrich, > >> > >> On Sun, 7 Nov 2021 at 01:21, Heinrich Schuchardt > >> wrote: > >>> > >>> > >>> >

Re: [PATCH 3/8 v6] tpm2: Introduce TIS tpm core

2021-11-08 Thread Simon Glass
Hi Ilias, On Sun, 7 Nov 2021 at 14:33, Ilias Apalodimas wrote: > > There's a lot of code duplication in U-Boot right now. All the TPM TIS > compatible drivers we have at the moment have their own copy of a TIS > implementation. > > So let's create a common layer which implements the core TIS

Re: [PATCH 2/8 v6] tpm: refactor function names for LPC based TPMs

2021-11-08 Thread Heinrich Schuchardt
On 11/7/21 22:33, Ilias Apalodimas wrote: With the upcoming TPM2 API, some of the function names are part of the new header file. So switch conflicting driver defined function names and defines. Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt ---

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-08 Thread Heinrich Schuchardt
On 11/8/21 17:05, Tom Rini wrote: On Mon, Nov 08, 2021 at 08:58:33AM -0700, Simon Glass wrote: Hi, On Sun, 7 Nov 2021 at 04:18, Heinrich Schuchardt wrote: On 11/6/21 14:53, Tom Rini wrote: On Sat, Nov 06, 2021 at 04:55:44AM +0100, Heinrich Schuchardt wrote: On 11/6/21 02:52, Andre

[PATCH u-boot-marvell 07/11] tools: kwbimage: Do not put final image padding to the image data size

2021-11-08 Thread Marek Behún
From: Pali Rohár This change allows to convert image from one format to another without need to include unnecessary padding (e.g. when target image format has smaller alignment requirement as source image format). Do it by storing real image data size without padding to the kwbimage header.

[PATCH u-boot-marvell 03/11] tools: kwbimage: Set BOOT_FROM by default to SPI

2021-11-08 Thread Marek Behún
From: Pali Rohár kwbimage must have valid blockid member instead of zero value. Thus if config file does not contain BOOT_FROM command, use by default the value for SPI booting (which is probably the most common). Signed-off-by: Pali Rohár Signed-off-by: Marek Behún --- tools/kwbimage.c | 32

[PATCH u-boot-marvell 01/11] tools: kwbimage: Add support for new commands UART_PORT and UART_MPP

2021-11-08 Thread Marek Behún
From: Pali Rohár These two commands allow to specify custom setting of UART port used for printing BootROM messages. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún --- tools/kwbimage.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git

[PATCH u-boot-marvell 00/11] Another kwbimage series

2021-11-08 Thread Marek Behún
From: Marek Behún Hi Stefan, Pali has prepared another series of patches for kwbimage, I have reviewed them. Marek Pali Rohár (11): tools: kwbimage: Add support for new commands UART_PORT and UART_MPP tools: kwbimage: Explicitly set version also for kwbimage v0 tools: kwbimage: Set

[PATCH u-boot-marvell 06/11] tools: kwbimage: Align final UART image to 128 bytes

2021-11-08 Thread Marek Behún
From: Pali Rohár xmodem block size is 128 bytes, therefore it is possible to transfer only images with size multiple of 128 bytes. kwboot automatically pads image with zero bytes at the end to align it to 128 bytes boundary. Do this padding when generating image to allow uploading with other

[PATCH u-boot-marvell 05/11] tools: kwbimage: Remove unused enums and prototypes

2021-11-08 Thread Marek Behún
From: Pali Rohár There are more unused enums and function prototypes. Remove them. The function kwbimage_check_params() does not return enum kwbimage_cmd_types, but a boolean value returned as int. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún --- tools/kwbimage.c | 2 +-

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-08 Thread Tom Rini
On Mon, Nov 08, 2021 at 09:09:20AM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 8 Nov 2021 at 09:05, Tom Rini wrote: > > > > On Mon, Nov 08, 2021 at 08:58:33AM -0700, Simon Glass wrote: > > > Hi, > > > > > > On Sun, 7 Nov 2021 at 04:18, Heinrich Schuchardt > > > wrote: > > > > > > > > > > >

Re: [PATCH 1/8 v6] tpm: refactor function names and macros for infineon v1.2 TPM

2021-11-08 Thread Ilias Apalodimas
Hi Heinrich On Mon, 8 Nov 2021 at 17:55, Heinrich Schuchardt wrote: > > > > On 11/7/21 22:33, Ilias Apalodimas wrote: > > With the upcoming TPM2 API, some of the function names are part of the new > > header file. So switch conflicting driver defined function names and > > defines. > > > >

[PATCH u-boot-marvell 08/11] tools: kwbimage: Align kwbimage header to proper size

2021-11-08 Thread Marek Behún
From: Pali Rohár Currently kwbimage header is always aligned to 4096 bytes. But it does not have to be aligned to such a high value. The header needs to be just 4-byte aligned, while some image types have additional alignment restrictions. This change reduces size of kwbimage binaries by

[PATCH u-boot-marvell 10/11] tools: kwbimage: Properly calculate and align kwbimage v0 header size

2021-11-08 Thread Marek Behún
From: Pali Rohár Kwbimage v0 has similar alignment requirements as v1. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún --- tools/kwbimage.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index

[PATCH u-boot-marvell 09/11] tools: kwbimage: Fill the real header size into the main header

2021-11-08 Thread Marek Behún
From: Pali Rohár Fill the real header size without padding into the main header This allows to reduce final image when converting image to another format which does not need additional padding. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún --- tools/kwbimage.c | 9 + 1 file

[PATCH u-boot-marvell 11/11] tools: kwbimage: Properly set srcaddr in kwbimage v0

2021-11-08 Thread Marek Behún
From: Pali Rohár Field srcaddr in kwbimage v0 needs to be adjusted similarly like in v1. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún --- tools/kwbimage.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index

Re: [RFC 07/22] dm: blk: add UCLASS_PARTITION

2021-11-08 Thread Ilias Apalodimas
Hi chiming in a little late but On Mon, 8 Nov 2021 at 06:46, AKASHI Takahiro wrote: > > On Fri, Nov 05, 2021 at 10:12:16AM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Thu, 4 Nov 2021 at 20:49, AKASHI Takahiro > > wrote: > > > > > > On Thu, Nov 04, 2021 at 08:02:05PM -0600, Simon

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-08 Thread François Ozog
On Fri, 5 Nov 2021 at 18:17, Simon Glass wrote: > ) to signal Hi François, > > On Fri, 5 Nov 2021 at 10:31, François Ozog > wrote: > > > > Hi Simon, > > > > Le ven. 5 nov. 2021 à 17:12, Simon Glass a écrit : > >> > >> Hi François, > >> > >> On Fri, 5 Nov 2021 at 02:27, François Ozog > wrote:

[PATCH u-boot-marvell 04/11] tools: kwbimage: Fix validation of kwbimage v0

2021-11-08 Thread Marek Behún
From: Pali Rohár kwbimage v0 sldo has 32-bit data checksum at the end like kwbimage v1. Use same data checksum validation for both v0 and v1 image types. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún --- tools/kwbimage.c | 80 ++-- 1 file

[PATCH u-boot-marvell 02/11] tools: kwbimage: Explicitly set version also for kwbimage v0

2021-11-08 Thread Marek Behún
From: Pali Rohár For documentation purposes update struct main_hdr_v0 to include information where version of the image must be stored. For kwbimage v0 it obviously must be 0. By default all image header memory is initialized to zero, therefore this change has no functional effect.

[PATCH v9 2/2] board: brcm-ns3: Load netXtreme firmware

2021-11-08 Thread Roman Bacik
From: Bharat Gooty Load NetXtreme firmware in board_init when BNXT_ETH is selected. Signed-off-by: Bharat Gooty Signed-off-by: Roman Bacik --- (no changes since v4) Changes in v4: - remove bnxt commands - load bnxt firmware in board_init Changes in v3: - remove commands set/get mac/speed

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-08 Thread Simon Glass
Hi, On Sun, 7 Nov 2021 at 04:18, Heinrich Schuchardt wrote: > > > > On 11/6/21 14:53, Tom Rini wrote: > > On Sat, Nov 06, 2021 at 04:55:44AM +0100, Heinrich Schuchardt wrote: > >> > >> > >> On 11/6/21 02:52, Andre Przywara wrote: > >>> On Fri, 5 Nov 2021 18:56:34 -0400 > >>> Tom Rini wrote: >

Re: [PATCH v5 05/11] test/py: efi_capsule: add image authentication test

2021-11-08 Thread Simon Glass
Hi Takahiro, On Sun, 7 Nov 2021 at 21:15, AKASHI Takahiro wrote: > > On Fri, Nov 05, 2021 at 10:12:20AM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Thu, 4 Nov 2021 at 21:24, AKASHI Takahiro > > wrote: > > > > > > On Thu, Nov 04, 2021 at 08:02:37PM -0600, Simon Glass wrote: > > > > Hi

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-08 Thread Simon Glass
Hi Tom, On Mon, 8 Nov 2021 at 09:05, Tom Rini wrote: > > On Mon, Nov 08, 2021 at 08:58:33AM -0700, Simon Glass wrote: > > Hi, > > > > On Sun, 7 Nov 2021 at 04:18, Heinrich Schuchardt > > wrote: > > > > > > > > > > > > On 11/6/21 14:53, Tom Rini wrote: > > > > On Sat, Nov 06, 2021 at 04:55:44AM

Re: [PATCH] cmd: pxe_utils: Check fdtcontroladdr in label_boot

2021-11-08 Thread Peter Hoyes
On 28/10/2021 19:55, Ramon Fried wrote: On Sun, Oct 24, 2021 at 10:56 PM Simon Glass wrote: Hi, On Fri, 15 Oct 2021 at 05:21, Andre Przywara wrote: On Thu, 14 Oct 2021 12:24:45 -0600 Simon Glass wrote: Hi Simon, On Thu, 14 Oct 2021 at 02:40, Peter Hoyes wrote: From: Peter Hoyes If

[PATCH v2 1/2] image: Fix typo in boot_get_kbd()

2021-11-08 Thread Andy Shevchenko
After the commit 4ed37abc49c2 ("image: Remove ifdefs around image_setup_linux() el at"): common/image-board.c: In function ‘boot_get_kbd’: common/image-board.c:902:17: error: expected ‘)’ before ‘do_bdinfo’ 902 | do_bdinfo(NULL, 0, 0, NULL); | ^

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-08 Thread Tom Rini
On Mon, Nov 08, 2021 at 08:58:33AM -0700, Simon Glass wrote: > Hi, > > On Sun, 7 Nov 2021 at 04:18, Heinrich Schuchardt > wrote: > > > > > > > > On 11/6/21 14:53, Tom Rini wrote: > > > On Sat, Nov 06, 2021 at 04:55:44AM +0100, Heinrich Schuchardt wrote: > > >> > > >> > > >> On 11/6/21 02:52,

[PATCH v2 2/2] image: Explicitly declare do_bdinfo()

2021-11-08 Thread Andy Shevchenko
Compiler is not happy: common/image-board.c: In function ‘boot_get_kbd’: common/image-board.c:902:17: warning: implicit declaration of function ‘do_bdinfo’ [-Wimplicit-function-declaration] 902 | do_bdinfo(NULL, 0, 0, NULL); | ^ Move the forward

Re: [PATCH] introduce CONFIG_DEVICE_TREE_INCLUDES

2021-11-08 Thread Simon Glass
Hi Roman, On Mon, 8 Nov 2021 at 08:43, Roman Kopytin wrote: > > Hi, I sent patches, please check. > But before correct emails I sent several test emails. OK I see them, not copied to me, but I see them in the mailing list, thank you. Regards, Simon > > -Original Message- > From:

Re: [PATCH 4/8 v6] tpm2: Add a TPMv2 MMIO TIS driver

2021-11-08 Thread Simon Glass
Hi Ilias, On Sun, 7 Nov 2021 at 14:33, Ilias Apalodimas wrote: > > Add support for devices that expose a TPMv2 though MMIO. > Apart from those devices, we can use the driver in our QEMU setups and > test TPM related code which is difficult to achieve using the sandbox > driver (e.g test the EFI

Re: [PATCH 1/8 v6] tpm: refactor function names and macros for infineon v1.2 TPM

2021-11-08 Thread Simon Glass
On Sun, 7 Nov 2021 at 14:33, Ilias Apalodimas wrote: > > With the upcoming TPM2 API, some of the function names are part of the new > header file. So switch conflicting driver defined function names and > defines. > > Signed-off-by: Ilias Apalodimas > --- > drivers/tpm/tpm_tis_infineon.c | 34

Re: [PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-08 Thread Simon Glass
Hi Andy, On Mon, 8 Nov 2021 at 01:38, Andy Shevchenko wrote: > > On Sun, Nov 7, 2021 at 6:43 PM Simon Glass wrote: > > On Sat, 6 Nov 2021 at 01:59, Andy Shevchenko > > wrote: > > > On Saturday, November 6, 2021, Simon Glass wrote: > > >> On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko > > >>

Re: [PATCH 2/8 v6] tpm: refactor function names for LPC based TPMs

2021-11-08 Thread Simon Glass
On Sun, 7 Nov 2021 at 14:33, Ilias Apalodimas wrote: > > With the upcoming TPM2 API, some of the function names are part of the new > header file. So switch conflicting driver defined function names and > defines. > > Signed-off-by: Ilias Apalodimas > --- > drivers/tpm/tpm_tis_lpc.c | 4 ++-- >

RE: [PATCH v8 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Roman Bacik
> -Original Message- > From: Pali Rohár > Sent: Sunday, November 7, 2021 1:44 AM > To: Roman Bacik > Cc: U-Boot Mailing List ; Bharat Gooty > ; Joe Hershberger > ; Ramon Fried > Subject: Re: [PATCH v8 1/2] net: brcm: netXtreme driver > > Hello! > > When sending a new version of patch,

Re: [PATCH V2 09/17] arm: j721e: Add support for selecting DT based on EEPROM

2021-11-08 Thread Tom Rini
On Tue, Nov 02, 2021 at 07:35:50PM +0530, Sinthu Raja wrote: > From: Sinthu Raja > > Enable support for selecting DTB from FIT within SPL based on the > board name read from EEPROM. This will help to use single defconfig > for both EVM and SK. > > Also print FDT model name and board name read

[PATCH u-boot-marvell 00/11] Another kwbimage series

2021-11-08 Thread Marek Behún
From: Marek Behún Hi Stefan, Pali has prepared another series of patches for kwbimage, I have reviewed them. Marek Pali Rohár (11): tools: kwbimage: Add support for new commands UART_PORT and UART_MPP tools: kwbimage: Explicitly set version also for kwbimage v0 tools: kwbimage: Set

[PATCH v9 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Roman Bacik
From: Bharat Gooty Broadcom bnxt L2 driver support. Used by the Broadcom iproc platforms. Signed-off-by: Bharat Gooty Reviewed-by: Ramon Fried Signed-off-by: Roman Bacik --- Changes in v9: - remove bnxt_ver.h - add DRIVER_VERSION_* definitions to bnxt.h - remove

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-08 Thread Pali Rohár
On Monday 08 November 2021 12:54:39 Tony Dinh wrote: > On Mon, Nov 8, 2021 at 3:11 AM Pali Rohár wrote: > > On Sunday 07 November 2021 18:08:56 Tony Dinh wrote: ... > > > > I think some more investigation is needed. Why did we need to do "pci > > > > enum", and then "usb reset", in that order, to

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-08 Thread Andre Przywara
On Mon, 8 Nov 2021 17:17:33 +0100 Heinrich Schuchardt wrote: > On 11/8/21 17:05, Tom Rini wrote: > > On Mon, Nov 08, 2021 at 08:58:33AM -0700, Simon Glass wrote: > >> Hi, > >> > >> On Sun, 7 Nov 2021 at 04:18, Heinrich Schuchardt > >> wrote: > >>> > >>> > >>> > >>> On 11/6/21 14:53, Tom

RE: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Roman Bacik
Hi Marek, > -Original Message- > From: Marek Behún > Sent: Monday, November 8, 2021 3:43 PM > To: Roman Bacik > Cc: U-Boot Mailing List ; Pali Rohar > ; Bharat Gooty ; Joe > Hershberger ; Ramon Fried > > Subject: Re: [PATCH v10 1/2] net: brcm: netXtreme driver > > Hello Roman, > > some

Re:Re: [PATCH] sf: Querying write-protect status before operating the flash

2021-11-08 Thread chaochao2021666
HI jagan and ta I might have a different view, the caller can not get the correct response even though we can not operate the device sucessfully. I think it is necessary to return a valid value. if return 0, the device cannot actually be operated but the correct results are not possible

[PATCH v10 2/2] board: brcm-ns3: Load netXtreme firmware

2021-11-08 Thread Roman Bacik
From: Bharat Gooty Load NetXtreme firmware in board_init when BNXT_ETH is selected. Signed-off-by: Bharat Gooty Signed-off-by: Roman Bacik --- (no changes since v4) Changes in v4: - remove bnxt commands - load bnxt firmware in board_init Changes in v3: - remove commands set/get mac/speed

[RFC 0/3] efi_loader: bootmgr itself should support removable media

2021-11-08 Thread AKASHI Takahiro
# This task is a bit motivated by Simon's discussion about bootflow[1]. Booting UEFI system from removable media is currently supported by distro_bootcmd script. But the behavior should be best implemented in UEFI Boot Manager. (Historically, the boot manager was added later than the support for

Re: [PATCH 02/14] mips: mtmips: add two reference boards for mt7621

2021-11-08 Thread Daniel Schwierzeck
Am Donnerstag, dem 04.11.2021 um 17:48 +0800 schrieb Weijie Gao: > The mt7621_rfb board supports integrated giga PHYs plus one external > giga PHYs. It also has up to 512MiB DDR3, 16MB SPI-NOR, 3 mini PCI-e > x1 > slots, SDXC and USB. > > The mt7621_nand_rfb board is almost the same as mt7621_rfb

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-08 Thread Marek Behún
On Mon, 8 Nov 2021 14:48:03 -0800 Tony Dinh wrote: > > So to avoid calling 'pci enum' manually, you need to put pci_init(); > > function call into your board board_early_init_r() function. > > Thanks! will do that. Don't do that. Instead enable CONFIG_PCI_INIT_R and

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Marek Behún
Hello Roman, some last requests from me. On Mon, 8 Nov 2021 14:46:10 -0800 Roman Bacik wrote: > +#define bnxt_down_chip(bp) bnxt_hwrm_run(down_chip, bp, 0) > +#define bnxt_bring_chip(bp)bnxt_hwrm_run(bring_chip, bp, 1) Could these be changed to functions instead of macros, please? >

Re: [RFC 07/22] dm: blk: add UCLASS_PARTITION

2021-11-08 Thread Simon Glass
Hi, On Mon, 8 Nov 2021 at 11:45, Ilias Apalodimas wrote: > > Hi chiming in a little late but > > On Mon, 8 Nov 2021 at 06:46, AKASHI Takahiro > wrote: > > > > On Fri, Nov 05, 2021 at 10:12:16AM -0600, Simon Glass wrote: > > > Hi Takahiro, > > > > > > On Thu, 4 Nov 2021 at 20:49, AKASHI

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-08 Thread Tom Rini
On Mon, Nov 08, 2021 at 05:09:14PM -0700, Simon Glass wrote: > Hi Heinrich, > > On Mon, 8 Nov 2021 at 09:17, Heinrich Schuchardt > wrote: > > > > On 11/8/21 17:05, Tom Rini wrote: > > > On Mon, Nov 08, 2021 at 08:58:33AM -0700, Simon Glass wrote: > > >> Hi, > > >> > > >> On Sun, 7 Nov 2021 at

[RFC 2/3] efi_loader: bootmgr: add booting from removable media

2021-11-08 Thread AKASHI Takahiro
Under the current implementation, booting from removal media using a architecture-specific default image name, say BOOTAA64.EFI, is supported only in distro_bootcmd script. See the commit 74522c898b35 ("efi_loader: Add distro boot script for removable media"). This is, however, half-baked

[RFC 3/3] cmd: efidebug: handle booting from removable media

2021-11-08 Thread AKASHI Takahiro
Support for booting from removable media is now added to UEFI boot manager. Here we should modify efidebug command in order to define a proper "Boot" variable. With this patch applied, you will be able to specify the boot order, usb and scsi: => efidebug -b 1 SCSI scsi 0:1 => efidebug boot

[RFC 1/3] efi_loader: export efi_locate_device_handle()

2021-11-08 Thread AKASHI Takahiro
This function will be used in the next commit where some behavior of EFI boot manager will be expanded. Signed-off-by: AKASHI Takahiro --- include/efi_loader.h | 4 lib/efi_loader/efi_boottime.c | 7 +++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-08 Thread Tony Dinh
Hi Pali, On Mon, Nov 8, 2021 at 3:11 AM Pali Rohár wrote: > > Hello! > > On Sunday 07 November 2021 18:08:56 Tony Dinh wrote: > > Hi Pali, > > > > On Sun, Nov 7, 2021 at 4:58 PM Tony Dinh wrote: > > > > > > Hi Pali, > > > > > > Looks like it is working! But in a weird way. Please see my

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-08 Thread Simon Glass
Hi Heinrich, On Mon, 8 Nov 2021 at 09:17, Heinrich Schuchardt wrote: > > On 11/8/21 17:05, Tom Rini wrote: > > On Mon, Nov 08, 2021 at 08:58:33AM -0700, Simon Glass wrote: > >> Hi, > >> > >> On Sun, 7 Nov 2021 at 04:18, Heinrich Schuchardt > >> wrote: > >>> > >>> > >>> > >>> On 11/6/21 14:53,

Re: [PATCH v2 2/2] image: Explicitly declare do_bdinfo()

2021-11-08 Thread Simon Glass
On Mon, 8 Nov 2021 at 11:05, Andy Shevchenko wrote: > > Compiler is not happy: > > common/image-board.c: In function ‘boot_get_kbd’: > common/image-board.c:902:17: warning: implicit declaration of function > ‘do_bdinfo’ [-Wimplicit-function-declaration] > 902 | do_bdinfo(NULL,

Re: [PATCH v2 1/2] image: Fix typo in boot_get_kbd()

2021-11-08 Thread Simon Glass
On Mon, 8 Nov 2021 at 11:04, Andy Shevchenko wrote: > > After the commit 4ed37abc49c2 ("image: Remove ifdefs around > image_setup_linux() el at"): > > common/image-board.c: In function ‘boot_get_kbd’: > common/image-board.c:902:17: error: expected ‘)’ before ‘do_bdinfo’ > 902 |

Re: [PATCH 01/14] mips: mtmips: add support for MediaTek MT7621 SoC

2021-11-08 Thread Daniel Schwierzeck
Am Donnerstag, dem 04.11.2021 um 17:48 +0800 schrieb Weijie Gao: > This patch adds support for MediaTek MT7621 SoC. > All files are dedicated for u-boot. > > Currently only ramboot is supported. > The default build target is u-boot-lzma.img. > This file can be booted using bootm command, or be

Re: [PATCH v9 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Roman Bacik
On Mon, Nov 8, 2021 at 10:40 AM Roman Bacik wrote: > > From: Bharat Gooty > > Broadcom bnxt L2 driver support. Used by the Broadcom > iproc platforms. > > Signed-off-by: Bharat Gooty > Reviewed-by: Ramon Fried > > Signed-off-by: Roman Bacik > --- > > Changes in v9: > - remove bnxt_ver.h > -

[PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Roman Bacik
From: Bharat Gooty Broadcom bnxt L2 driver support. Used by the Broadcom iproc platforms. Signed-off-by: Bharat Gooty Reviewed-by: Ramon Fried Signed-off-by: Roman Bacik --- Changes in v10: - move unnecessary code from bnxt_read_rom_hwaddr to bnxt_eth_probe Changes in v9: - remove

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-08 Thread Tony Dinh
Hi Pali, On Mon, Nov 8, 2021 at 2:02 PM Pali Rohár wrote: > > On Monday 08 November 2021 12:54:39 Tony Dinh wrote: > > On Mon, Nov 8, 2021 at 3:11 AM Pali Rohár wrote: > > > On Sunday 07 November 2021 18:08:56 Tony Dinh wrote: > ... > > > > > I think some more investigation is needed. Why did

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Marek Behún
On Mon, 8 Nov 2021 16:48:33 -0800 Roman Bacik wrote: > To be honest changing status codes coming from FW does not seem right. But > we will try to make the requested changes. I looked at kernel's implementation of this driver and these hwrm functions and they don't return STATUS_*. Marek

Re: [PATCH v8 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Pali Rohár
On Monday 08 November 2021 09:31:14 Roman Bacik wrote: > > -Original Message- > > From: Pali Rohár > > Sent: Sunday, November 7, 2021 1:44 AM > > To: Roman Bacik > > Cc: U-Boot Mailing List ; Bharat Gooty > > ; Joe Hershberger > > ; Ramon Fried > > Subject: Re: [PATCH v8 1/2] net: brcm:

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Marek Behún
On Mon, 8 Nov 2021 18:20:43 -0800 Roman Bacik wrote: > On Mon, Nov 8, 2021 at 5:12 PM Marek Behún wrote: > > > > On Mon, 8 Nov 2021 16:48:33 -0800 > > Roman Bacik wrote: > > > > > To be honest changing status codes coming from FW does not seem right. But > > > we will try to make the

[PULL] u-boot-riscv/master

2021-11-08 Thread Leo Liang
Hi Tom, The following changes since commit 52207514ba419a69a8105d16997b025f966c8879: Merge branch '2021-11-05-Kconfig-syncs' (2021-11-05 15:38:46 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-riscv.git for you to fetch changes up to

Re: [PATCH 01/14] mips: mtmips: add support for MediaTek MT7621 SoC

2021-11-08 Thread Weijie Gao
On Mon, 2021-11-08 at 22:39 +0100, Daniel Schwierzeck wrote: > Am Donnerstag, dem 04.11.2021 um 17:48 +0800 schrieb Weijie Gao: > > This patch adds support for MediaTek MT7621 SoC. > > All files are dedicated for u-boot. > > > > Currently only ramboot is supported. > > The default build target is

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Roman Bacik
On Mon, Nov 8, 2021 at 5:12 PM Marek Behún wrote: > > On Mon, 8 Nov 2021 16:48:33 -0800 > Roman Bacik wrote: > > > To be honest changing status codes coming from FW does not seem right. But > > we will try to make the requested changes. > > I looked at kernel's implementation of this driver and

[PATCH 3/8 v7] tpm2: Introduce TIS tpm core

2021-11-08 Thread Ilias Apalodimas
There's a lot of code duplication in U-Boot right now. All the TPM TIS compatible drivers we have at the moment have their own copy of a TIS implementation. So let's create a common layer which implements the core TIS functions. Any driver added from now own, which is compatible with the TIS

[PATCH 6/8 v7] configs: Enable tpmv2 mmio on qemu for arm/arm64

2021-11-08 Thread Ilias Apalodimas
A previous commit is adding an MMIO TPMv2 driver. Include in the default qemu arm configs, since we plan on using them on EFI testing Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- configs/qemu_arm64_defconfig | 2 ++ configs/qemu_arm_defconfig | 2 ++ 2 files changed, 4

[PATCH 5/8 v7] tpm: Use the new API on tpm2 spi driver

2021-11-08 Thread Ilias Apalodimas
Convert our SPI TPM driver and use the newly added API Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- drivers/tpm/Makefile | 2 +- drivers/tpm/tpm2_tis_spi.c | 447 +++-- 2 files changed, 32 insertions(+), 417 deletions(-) diff --git

[PATCH 4/8 v7] tpm2: Add a TPMv2 MMIO TIS driver

2021-11-08 Thread Ilias Apalodimas
Add support for devices that expose a TPMv2 though MMIO. Apart from those devices, we can use the driver in our QEMU setups and test TPM related code which is difficult to achieve using the sandbox driver (e.g test the EFI TCG2 protocol). It's worth noting that a previous patch added TPMv2 TIS

[PATCH 7/8 v7] doc: qemu: Add instructions for swtpm usage

2021-11-08 Thread Ilias Apalodimas
A previous patch added support for an mmio based TPM. Add an example in QEMU on it's usage Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- doc/board/emulation/qemu-arm.rst | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH 2/8 v7] tpm: refactor function names for LPC based TPMs

2021-11-08 Thread Ilias Apalodimas
With the upcoming TPM2 API, some of the functions name are part of the new header file. So switch conflicting internal function names and defines. Reviewed-by: Simon Glass Reviewed-by: Heinrich Schuchardt Signed-off-by: Ilias Apalodimas --- drivers/tpm/tpm_tis_lpc.c | 4 ++-- 1 file changed,

Re:[PATCH v2] boot: don't enable the non-secure boot commands by default if secure boot enabled

2021-11-08 Thread Rover Mo
Dear Simon Glass, > Also please do check tests (make qcheck) since sandbox enables more > options than most boards. All tests passed, please check the detailed log in the attachment. Best regards, Rover Mo At 2021-11-09 15:21:43, "Rover Mo" wrote: >To prevent booting unsigned images, don't

Re: [PATCH 1/1] doc: mmc rescan speed mode

2021-11-08 Thread Jaehoon Chung
On 11/6/21 12:39 AM, Heinrich Schuchardt wrote: > Provide human readable descriptions of the speed nodes instead of the name > of constants from the code. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > doc/usage/mmc.rst | 36

Re: [PATCH 1/2] exynos78x0: pinctrl: set const to structs

2021-11-08 Thread Jaehoon Chung
On 11/4/21 4:13 PM, Minkyu Kang wrote: > to fix following checkpatch warings. > WARNING: struct should normally be const > > Signed-off-by: Minkyu Kang > Cc: Dzmitry Sankouski Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/pinctrl/exynos/pinctrl-exynos78x0.c | 14

Re: [PATCH 2/2] exynos: mmu: use CONFIG_IS_ENABLED

2021-11-08 Thread Jaehoon Chung
On 11/4/21 4:13 PM, Minkyu Kang wrote: > to fix following checkpatch warnings. > Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where > possible > > Signed-off-by: Minkyu Kang > Cc: Dzmitry Sankouski Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- >

Re: [PATCH 06/11] mmc: fsl_esdhc_imx: fix mmc->clock with actual clock

2021-11-08 Thread Jaehoon Chung
On 11/6/21 2:39 AM, Sean Anderson wrote: > [ fsl_esdhc commit 30f6444d024a74ee48aa6969c1531aecd3c59deb ] > > Fix mmc->clock with actual clock which is divided by the > controller, and record it with priv->clock. > > Signed-off-by: Yangbo Lu > Signed-off-by: Sean Anderson > --- > >

[PATCH v2] boot: don't enable the non-secure boot commands by default if secure boot enabled

2021-11-08 Thread Rover Mo
To prevent booting unsigned images, don't enable the non-secure boot commands(booti, bootz .etc) by default if secure boot enabled. Signed-off-by: Rover Mo Cc: Heinrich Schuchardt Cc: Simon Glass --- Changes for v2: - Don't enable the non-secure boot commands too if !EFI_SECURE_BOOT

Re: [PATCH] mmc: mtk-sd: implement waiting for DAT0 line state

2021-11-08 Thread Jaehoon Chung
On 11/5/21 10:34 PM, Julien Masson wrote: > With the recent changes on mmc driver, we saw that the boot is ~5 secs > longer compared to v2021.07 on mediatek platforms. > > This regression is seen during mmc_init and caused by the following > patch [1]. > > Indeed since we did not support poll

[PATCH 8/8 v7] MAINTAINERS: Add entry for TPM drivers

2021-11-08 Thread Ilias Apalodimas
TPM drivers have currently no maintainers. Add myself since I contributed the TIS implementation. Reviewed-by: Heinrich Schuchardt Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH] cmd: pxe_utils: Check fdtcontroladdr in label_boot

2021-11-08 Thread Ramon Fried
On Mon, Nov 8, 2021 at 6:53 PM Peter Hoyes wrote: > > On 28/10/2021 19:55, Ramon Fried wrote: > > On Sun, Oct 24, 2021 at 10:56 PM Simon Glass wrote: > >> Hi, > >> > >> On Fri, 15 Oct 2021 at 05:21, Andre Przywara > >> wrote: > >>> On Thu, 14 Oct 2021 12:24:45 -0600 > >>> Simon Glass wrote: >

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-08 Thread Tony Dinh
Hi Marek and Pali, On Mon, Nov 8, 2021 at 3:04 PM Marek Behún wrote: > > On Mon, 8 Nov 2021 14:48:03 -0800 > Tony Dinh wrote: > > > > So to avoid calling 'pci enum' manually, you need to put pci_init(); > > > function call into your board board_early_init_r() function. > > > > Thanks! will do

[PATCH 1/8 v7] tpm: refactor function names and macros for infineon v1.2 TPM

2021-11-08 Thread Ilias Apalodimas
With the upcoming TPM2 API, some of the functions name are part of the new header file. So switch conflicting internal function names and defines. Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- drivers/tpm/tpm_tis_infineon.c | 34 +- 1 file

[PATCH 0/8 v7] TPM cleanups and MMIO driver

2021-11-08 Thread Ilias Apalodimas
Hi! This is the update for [1]. Changes since v6: - added a few missing @return in function documentation - switched TPM1_ defines to TPM_INFINEON_ Changes since v5: - Fixed 2 tpmv1.2 drivers. Some of the internal driver functions were conflicting with the new API Changes since v4: - renamed

Re: [PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-08 Thread Jaehoon Chung
On 11/6/21 2:39 AM, Sean Anderson wrote: > [ fsl_esdhc commit 07bae1de382723b94244096953b05225572728cd ] > > This patch is to clean up bus width setting code. > > - For DM_MMC, remove getting "bus-width" from device tree. > This has been done in mmc_of_parse(). > > - For non-DM_MMC, move bus

RE: [EXT] Re: [PATCH v4 03/16] i.MX8M: crypto: updated device tree for supporting DM in SPL

2021-11-08 Thread Gaurav Jain
Hello Andrey > -Original Message- > From: ZHIZHIKIN Andrey > Sent: Wednesday, November 3, 2021 5:05 PM > To: Adam Ford ; Gaurav Jain > Cc: U-Boot Mailing List ; Stefano Babic > ; Fabio Estevam ; Peng Fan > ; Simon Glass ; Priyanka Jain > ; Ye Li ; Horia Geanta > ; Ji Luo ; Franck

Re: [PATCH v5 02/11] tools: mkeficapsule: add firmwware image signing

2021-11-08 Thread AKASHI Takahiro
Hi Mark, On Thu, Nov 04, 2021 at 03:31:40PM +0100, Mark Kettenis wrote: > > From: Simon Glass > > Date: Wed, 3 Nov 2021 20:51:25 -0600 > > > > Hi Mark, > > > > On Tue, 2 Nov 2021 at 09:13, Mark Kettenis wrote: > > > > > > > From: Simon Glass > > > > Date: Tue, 2 Nov 2021 08:56:50 -0600 > > >

Re: [PATCH 1/5] tee: define session login identifiers

2021-11-08 Thread Patrick DELAUNAY
Hi, On 11/4/21 3:14 PM, Etienne Carriere wrote: Define identifiers for clnt_login field in struct tee_open_session_arg based in GlobalPlatform Device TEE IDs and on the REE_KERNEL identifier extension from OP-TEE OS. Cc: Jens Wiklander Signed-off-by: Etienne Carriere --- This change was

Re: [PATCH 3/5] tee: optee: define TEE error code TEE_ERROR_SHORT_BUFFER

2021-11-08 Thread Patrick DELAUNAY
Hi, On 11/4/21 3:14 PM, Etienne Carriere wrote: Adds TEE_ERROR_SHORT_BUFFER as TEE error code. This error code is commonly used by TEEs to inform caller that the buffer(s) it provided is too small for the desired operation. Cc: Jens Wiklander Signed-off-by: Etienne Carriere ---

Re: [PATCH 2/5] tee: optee: remove unused duplicated login Id macros

2021-11-08 Thread Patrick DELAUNAY
Hi, On 11/4/21 3:14 PM, Etienne Carriere wrote: Remove unused OPTEE_MSG_LOGIN_* ID macros as suitable TEE_LOGIN_* ID macros are already defined tee.h. Cc: Jens Wiklander Signed-off-by: Etienne Carriere --- This change was previously discussed in the U-Boot ML, latest is "[PATCH v2 2/2] tee:

Re: [PATCH 1/5] firmware: scmi: fix description of an API function

2021-11-08 Thread Patrick DELAUNAY
Hi On 11/8/21 8:56 AM, Etienne Carriere wrote: Correct inline comment describing API function devm_scmi_process_msg(). Signed-off-by: Etienne Carriere --- include/scmi_agent.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/scmi_agent.h

Re: [PATCH] sf: Querying write-protect status before operating the

2021-11-08 Thread Michael Walle
> On Fri, Nov 5, 2021 at 10:47 PM wrote: > > > > Hi, > > > > On 6/22/21 8:21 AM, chao zeng wrote: > > > From: Chao Zeng > > > > > > When operating the write-protection flash,spi_flash_std_write() and > > > spi_flash_std_erase() would return wrong result.The flash is protected, > > > but write or

Re: [PATCH 5/5] firmware: scmi: smccc transport: simplify probe sequence

2021-11-08 Thread Patrick DELAUNAY
Hi, On 11/8/21 8:56 AM, Etienne Carriere wrote: Minor simplification in scmi_smccc_probe() exit sequence. Cc: Simon Glass Cc: Patrice Chotard Cc: Patrick Delaunay Signed-off-by: Etienne Carriere --- Changes since v1: - No change. Patch re-send. --- drivers/firmware/scmi/smccc_agent.c |

Re: [PATCH 2/2] riscv: Enable SPI flash env for SiFive Unmatched.

2021-11-08 Thread Leo Liang
On Mon, Sep 27, 2021 at 12:59:38PM -0700, Thomas Skibo wrote: > Enable saving environment to SPI flash memory on SiFive > Unmatched. > > Signed-off-by: Thomas Skibo > --- > arch/riscv/cpu/fu740/Kconfig | 13 + > board/sifive/unmatched/Kconfig | 1 + > 2 files changed, 14

Re: [PATCH 1/2] riscv: Support booting SiFive Unmatched from SPI.

2021-11-08 Thread Leo Liang
On Mon, Sep 27, 2021 at 12:59:37PM -0700, Thomas Skibo wrote: > Configure SPI flash devices into SPL. Add SPI boot option to spl.c. > Document how to format flash for booting. > > Signed-off-by: Thomas Skibo > --- > .../dts/hifive-unmatched-a00-u-boot.dtsi | 11 +++ >

RE: [EXT] Re: [PATCH v4 03/16] i.MX8M: crypto: updated device tree for supporting DM in SPL

2021-11-08 Thread ZHIZHIKIN Andrey
Hello Gurav, I'll Cc: Michael Walle here for the reason described below. > -Original Message- > From: Gaurav Jain > Sent: Monday, November 8, 2021 9:21 AM > To: ZHIZHIKIN Andrey ; Adam Ford > > Cc: U-Boot Mailing List ; Stefano Babic > ; Fabio Estevam ; Peng Fan > ; Simon Glass ;

Re: [EXT] Re: [PATCH v4 03/16] i.MX8M: crypto: updated device tree for supporting DM in SPL

2021-11-08 Thread Michael Walle
Am 2021-11-08 09:48, schrieb ZHIZHIKIN Andrey: .. > Disabling the JR0 node in the kernel makes this error go away, and > decreases the JR count to 2 which can be observed in the NXP vendor kernel. > > I suggest you to extract the node disabling from this patch and send it to Kernel. > Once

RE: [EXT] Re: [PATCH v4 01/16] crypto/fsl: Add support for CAAM Job ring driver model

2021-11-08 Thread Gaurav Jain
Hello Simon > -Original Message- > From: Simon Glass > Sent: Tuesday, November 2, 2021 8:26 PM > To: Gaurav Jain > Cc: U-Boot Mailing List ; Stefano Babic > ; Fabio Estevam ; Peng Fan > ; Priyanka Jain ; Ye Li > ; Horia Geanta ; Ji Luo > ; Franck Lenormand ; Silvano Di > Ninno ; Sahil

Re: [PATCH 5/5] firmware: scmi: Add OP-TEE transport

2021-11-08 Thread Patrick DELAUNAY
Hi, On 11/4/21 3:14 PM, Etienne Carriere wrote: This change implements an SCMI transport for agent interfacing the OP-TEE SCMI service. OP-TEE provides an SCMI PTA (Pseudo-TA) for non-secure world to send SCMI messages over an identified channel. The driver implemented here uses a SMT shared

Re: [PATCH 2/5] firmware: scmi: mailbox transport: fix probe failure implementation

2021-11-08 Thread Patrick DELAUNAY
Hi, On 11/8/21 8:56 AM, Etienne Carriere wrote: Correct scmi mailbox probe function that can't free the scmi channel instance since its auto-allocated by the device model framework. Cc: Simon Glass Cc: Patrice Chotard Cc: Patrick Delaunay Signed-off-by: Etienne Carriere --- Changes since

Re: [PATCH 3/5] firmware: scmi: mailbox transport: use plat data, not priv data

2021-11-08 Thread Patrick DELAUNAY
Hi, On 11/8/21 8:56 AM, Etienne Carriere wrote: Change SCMI mailbox transport drivers to use platform data rather than private data for channel reference since it only stores platform data retrieved from the DT. Consequently the probe handler is replaced with a of_to_plat handler. Cc: Simon

  1   2   >