[PATCHv2] net: uclass: Save ethernet MAC address when generated

2021-11-20 Thread Tom Rini
From: Michal Simek When MAC address is randomly generated it should be also saved to variables. This step is there when MAC address is passed via pdata but not when it is randomly generated. Signed-off-by: Michal Simek Reviewed-by: Ramon Fried [trini: Update Kconfig, handle legacy networking

Re: Pull request for efi-2022-01-rc3

2021-11-20 Thread Tom Rini
On Sat, Nov 20, 2021 at 03:09:26PM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > I am still trying to reproduce the usb_stop() issue on the sandbox, to > understand what is wrong in DM. So your patch will go to next weeks pull > request. But generally you are right that usb_stop() must be

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-20 Thread Tom Rini
On Fri, Nov 19, 2021 at 01:30:06PM +0100, Michal Simek wrote: > Hi, > > On 11/18/21 20:54, Tom Rini wrote: > > On Thu, Nov 18, 2021 at 08:04:22PM +0100, Wolfgang Denk wrote: > > > Dear Tom, > > > > > > In message <2028162920.GH24579@bill-the-cat> you wrote: > > > > > > > > > It is perfectly

Re: [PATCH v3] env: Avoid using GNU features in awk

2021-11-20 Thread Tom Rini
On Sat, Nov 20, 2021 at 08:45:34AM -0700, Simon Glass wrote: > GNU has a very useful third argument to match() but this is not supported > in the POSIX awk. > > Update the code to cope, so that the script is POSIX-compliant. > > Signed-off-by: Simon Glass Thanks for rewording. Reviewed-by:

[PATCH v3] pci: Work around PCIe link training failures

2021-11-20 Thread Maciej W. Rozycki
Attempt to handle cases with a downstream port of a PCIe switch where link training never completes and the link continues switching between speeds indefinitely with the data link layer never reaching the active state. It has been observed with a downstream port of the ASMedia ASM2824 Gen 3

[PATCH v2] board: stemmy: Increase boot image to 64 MB

2021-11-20 Thread Linus Walleij
When using a recent kernel with a bunch of compiled-in stuff the kernel image easily becomes bigger than 8 MB yielding this error: Loading Kernel Image Image too large: increase CONFIG_SYS_BOOTM_LEN Must RESET board to recover Fix this by bumping to SZ_64MB. Cc: Stephan Gerhold

[PATCH v3] env: Avoid using GNU features in awk

2021-11-20 Thread Simon Glass
GNU has a very useful third argument to match() but this is not supported in the POSIX awk. Update the code to cope, so that the script is POSIX-compliant. Signed-off-by: Simon Glass --- Changes in v3: - Reword commit message and comment to avoid casting aspersions Changes in v2: - Fix the

[PATCH 1/1] efi_loader: Sphinx comments in efi_api.h

2021-11-20 Thread Heinrich Schuchardt
Fix incorrect Sphinx comments in efi_api.h: * add missing 'struct' * correct indentation Signed-off-by: Heinrich Schuchardt --- include/efi_api.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/efi_api.h b/include/efi_api.h index

Re: [PATCH] efi: Call bootm_disable_interrupts earlier in efi_exit_boot_services

2021-11-20 Thread Ilias Apalodimas
On Sat, 20 Nov 2021 at 00:09, Tom Rini wrote: > > On Fri, Nov 19, 2021 at 10:52:27PM +0100, Heinrich Schuchardt wrote: > > > > > > Am 19. November 2021 22:33:04 MEZ schrieb Tom Rini : > > >If we look at the path that bootm/booti take when preparing to boot the > > >OS, we see that as part of (or

Re: [PATCH] efi: add comment for efi_system_table and efi_configuration_table

2021-11-20 Thread Heinrich Schuchardt
On 11/12/21 08:24, Masahisa Kojima wrote: This commit adds the comment for efi_system_table and efi_configuration_table structure. Signed-off-by: Masahisa Kojima Reviewed-by: Simon Glass --- include/efi_api.h | 32 1 file changed, 32 insertions(+) diff

Fwd: [PATCH 1/3] efi_loader: Add check for event log passed from firmware

2021-11-20 Thread Heinrich Schuchardt
Hello Ilias, hello Masahisa, could you, please, review the patch available at https://patchwork.ozlabs.org/project/uboot/patch/2028061751.3334620-1-ruchika.gu...@linaro.org/ Best regards Heinrich On 11/18/21 07:17, Ruchika Gupta wrote: Platforms may have support to measure their initial

[PATCH] sandbox: poweroff in efi_system_reset()

2021-11-20 Thread Heinrich Schuchardt
efi_system_reset() should exit if called with EFI_RESET_SHUTDOWN. Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/start.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c index a74f5ec7ba..13b0731ec3 100644 ---

Pull request for efi-2022-01-rc3

2021-11-20 Thread Heinrich Schuchardt
Dear Tom, I am still trying to reproduce the usb_stop() issue on the sandbox, to understand what is wrong in DM. So your patch will go to next weeks pull request. But generally you are right that usb_stop() must be called before deleting the devices if at all. The following changes since

Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults

2021-11-20 Thread Sean Anderson
On 11/20/21 7:57 AM, Tom Rini wrote: On Sat, Nov 20, 2021 at 12:10:54PM +, Peng Fan (OSS) wrote: Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults From: Peng Fan Current code has a force clk_set_defaults in multiple stages, U-Boot reuse the same device tree and Linux Kernel

Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults

2021-11-20 Thread Tom Rini
On Sat, Nov 20, 2021 at 10:06:55AM -0500, Sean Anderson wrote: > On 11/20/21 7:57 AM, Tom Rini wrote: > > On Sat, Nov 20, 2021 at 12:10:54PM +, Peng Fan (OSS) wrote: > > > > Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > > > > > > > > From: Peng Fan > > > > > > > > Current

Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults

2021-11-20 Thread Mark Kettenis
> From: Sean Anderson > Date: Sat, 20 Nov 2021 10:06:55 -0500 > > On 11/20/21 7:57 AM, Tom Rini wrote: > > On Sat, Nov 20, 2021 at 12:10:54PM +, Peng Fan (OSS) wrote: > >>> Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > >>> > >>> From: Peng Fan > >>> > >>> Current code has

[PATCH v2] env: Avoid using GNU features in awk

2021-11-20 Thread Simon Glass
GNU has a very useful third argument to match() but this is not supported in the POSIX awk. It is a great shame. Update the code to cope. Signed-off-by: Simon Glass --- Changes in v2: - Fix the has_var match() that had left-over test code scripts/env2string.awk | 23 +++

Re: [PATCH v2] env: Avoid using GNU features in awk

2021-11-20 Thread Tom Rini
On Sat, Nov 20, 2021 at 08:20:05AM -0700, Simon Glass wrote: > GNU has a very useful third argument to match() but this is not supported > in the POSIX awk. It is a great shame. > > Update the code to cope. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Fix the has_var match()

Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults

2021-11-20 Thread Tom Rini
On Sat, Nov 20, 2021 at 04:21:12PM +0100, Mark Kettenis wrote: > > From: Sean Anderson > > Date: Sat, 20 Nov 2021 10:06:55 -0500 > > > > On 11/20/21 7:57 AM, Tom Rini wrote: > > > On Sat, Nov 20, 2021 at 12:10:54PM +, Peng Fan (OSS) wrote: > > >>> Subject: [PATCH V2] clk: introduce

[PATCH 1/1] efi_loader: segfault in efi_clear_os_indications()

2021-11-20 Thread Heinrich Schuchardt
If we call efi_clear_os_indications() before initializing the memory store for UEFI variables a NULL pointer dereference occurs. The error was observed on the sandbox with: usb start host bind 0 sandbox.img load host 0:1 $kernel_addr_r helloworld.efi bootefi $kernel_addr_r Here

RE: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults

2021-11-20 Thread Peng Fan (OSS)
> Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > > From: Peng Fan > > Current code has a force clk_set_defaults in multiple stages, U-Boot reuse the > same device tree and Linux Kernel device tree, but we not register all the > clks > as Linux Kernel, so clk_set_defaults will

[BUG] efi_loader: incorrect creation of device paths

2021-11-20 Thread Heinrich Schuchardt
Hello Takahiro, in a prior mail we have discussed the creation of device paths for USB mass storage devices. On the sand boxyou get the following devices after 'usb start': Class Index Probed DriverName --- usb

Re: [PATCH] efi: Call bootm_disable_interrupts earlier in efi_exit_boot_services

2021-11-20 Thread Mark Kettenis
> From: Ilias Apalodimas > Date: Sat, 20 Nov 2021 10:20:23 +0200 > > On Sat, 20 Nov 2021 at 00:09, Tom Rini wrote: > > > > On Fri, Nov 19, 2021 at 10:52:27PM +0100, Heinrich Schuchardt wrote: > > > > > > > > > Am 19. November 2021 22:33:04 MEZ schrieb Tom Rini : > > > >If we look at the path

[PATCH 1/1] sandbox: replace putchar(ch) by fputc(ch, stdout)

2021-11-20 Thread Heinrich Schuchardt
When compiled with -Og for better debugability u-boot ends up in a stack overflow using gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0 GNU Binutils for Ubuntu 2.37 putchar(ch) is defined as a macro which ends up calling U-Boot's putc() implementation instead of the glibc one, which calls os_putc()

Re: [PATCH v2 0/2] env: setenv add resolve value option

2021-11-20 Thread Wolfgang Denk
Dear Artem, In message you wrote: > > next examples just demonstrate how its works for already defined env > variables which contain other variables (like storred env variables) Which next examples? > sure I know about this ! see my prev message please . Which exact message are you referring

Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults

2021-11-20 Thread Tom Rini
On Sat, Nov 20, 2021 at 12:10:54PM +, Peng Fan (OSS) wrote: > > Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > > > > From: Peng Fan > > > > Current code has a force clk_set_defaults in multiple stages, U-Boot reuse > > the > > same device tree and Linux Kernel device tree,

[PATCH] efi_loader: efi_disk_register() should not fail

2021-11-20 Thread Heinrich Schuchardt
Our algorithm for creating USB device paths may lead to duplicate device paths which result in efi_disk_register() failing. Instead we should just skip devices that cannot be registered as EFI block devices. Fix a memory leak in efi_disk_add_dev() caused by the duplicate device path.

[PATCH v2 1/1] efi_loader: efi_disk_register() should not fail

2021-11-20 Thread Heinrich Schuchardt
Our algorithm for creating USB device paths may lead to duplicate device paths which result in efi_disk_register() failing. Instead we should just skip devices that cannot be registered as EFI block devices. Fix a memory leak in efi_disk_add_dev() caused by the duplicate device path.