[PATCH V3 10/16] arm: dts: k3-j721e-sk: Add initial A72 specific dts support

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja J721E Starter Kit (SK)[1] is a low cost, small form factor board designed for TI’s J721E SoC. TI’s J721E SoC comprises of dual core A72, high performance vision accelerators, video codec accelerators, latest C71x and C66x DSP, high bandwidth real-time IPs for capture and

[PATCH V3 14/16] configs: j721e_evm_a72: Align OSPI partitions on erase block boundary

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja S28HS512T on TI SK has sector size of 256KB, so update OSPI partition to align on 256KB sector size. Since the sector size for MT35XU512ABA on EVM is 128KB, partitions will remain aligned for EVM. Also, now since the sector size is 256KB ospi.env.backup will collide with

[PATCH V3 09/16] arm: dts: k3-j721e-r5-common-proc-board: Do not use power-domains for I2C

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Board ID I2C EEPROM will be probed before SYSFW is available. So drop the power-domains property for wakup_i2c0 on which board ID EEPROM is connected. Signed-off-by: Sinthu Raja --- arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 5 + 1 file changed, 5 insertions(+)

[PATCH V3 15/16] configs: j721e_evm: Store env in MMC FAT partition

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Enable defconfigs relevant for storing env on FAT partion of MMC. Signed-off-by: Sinthu Raja --- configs/j721e_evm_a72_defconfig | 5 +++-- configs/j721e_evm_r5_defconfig | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/configs/j721e_evm_a72_defconfig

[PATCH V3 13/16] configs: j721e_evm_a72: Add SK dtb as part of DTB FIT

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Add k3-j721e-sk dtb along with other dtbs inside DTB FIT image. Signed-off-by: Sinthu Raja --- configs/j721e_evm_a72_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig index 2e45273903..4fb98037ae

[PATCH V3 12/16] configs: j721e_evm_r5: Enable support for building multiple dtbs into FIT

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Enable configs for building multiple dtbs into a single fit image and load the right dtb for next stage. This will help to use same defconfig for both J721E EVM and SK boards. Signed-off-by: Sinthu Raja --- configs/j721e_evm_r5_defconfig | 3 +++ 1 file changed, 3

Re: [PATCH] arm:dts:k3-am64-sk: EMIF tool update to 0.8.0 with 1333MTs for lpddr4

2022-02-09 Thread Sinthu Raja M
On Sat, Jan 15, 2022 at 9:04 PM Tom Rini wrote: > > On Mon, Nov 29, 2021 at 05:34:49PM +0530, Sinthu Raja wrote: > > > From: Sinthu Raja > > > > EMIF tool for AM64 SK is now updated to 0.8.0 that includes > > * disabled Write DQ training > > * improve CA ODT to 60 ohms > > > > The lpddr4 enabled

[RFC] CI: enforce packages upgrade for Msys2 on Windows

2022-02-09 Thread AKASHI Takahiro
We need to install libgnutls-devel package to build the host tool, mkeficapsule, and as of now, there seems to be a depencency conflict in the current msys2 installer; :: installing libp11-kit (0.24.1-1) breaks dependency \ 'libp11-kit=0.23.22' required by p11-kit To resolve this

[PATCH V3 04/16] board: ti: j721e: Enable support for reading EEPROM at next alternate address

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja J721E EVM has EEPROM populated at 0x50. J721E SK has EEPROM populated at next address 0x51 in order to be compatible with RPi. So start looking for TI specific EEPROM at 0x50, if not found look for EEPROM at 0x51. Signed-off-by: Sinthu Raja --- Changes in V3: Updated Commit

[PATCH V3 03/16] board: ti: j721e: Guard functions with right #ifdef to avoid build warnings

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja board_late_init(), setup_board_eeprom_env() and setup_serial() is called only under CONFIG_BOARD_LATE_INIT, so guard these functions with the same. Also, reorder these functions to place it under single #ifdef Signed-off-by: Sinthu Raja --- Changes in V3: * re-order the code

[PATCH V3 00/16] Add support for J721E SK

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Hi All, This series adds support for J721E SK [1]. Below is the detailed description of the J721E SoC and the SK board supporting features. The arch/arm/dts/k3-j721e-r5-sk.dts been queued up in linux-next [2]. Changes in V3: Addressed review comments such as * Removed

[PATCH V3 02/16] drivers: power: regulator: tps65941_regulator: Add support for 3Phase buck

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Buck regulator 1, 2 and 3 of TPS6594132 on j721e-sk is in 3 Phase confguration, in-order to support this, add configuring 3 Phase buck in tps65941 while driver probing. Signed-off-by: Sinthu Raja Acked-by: Jaehoon Chung --- drivers/power/regulator/tps65941_regulator.c | 2

Re: [PATCH v4 02/11] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-02-09 Thread Sughosh Ganu
hi Masami, On Wed, 9 Feb 2022 at 10:26, Masami Hiramatsu wrote: > > Hi Sughosh, > > While porting mdata-sf driver, I'm confusing on the devicetree > usage. > > 2022年2月8日(火) 3:21 Sughosh Ganu : > > > +int fwu_get_mdata_device(struct udevice **mdata_dev) > > +{ > > + u32 phandle; > > +

[PATCH V3 01/16] drivers: power: pmic: Add support for tps659412 PMIC

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Since TPS659412 and TPS659413 are both software compatible, add a compatible string for the same inside tps65941.c. Signed-off-by: Sinthu Raja Acked-by: Jaehoon Chung --- drivers/power/pmic/tps65941.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH V3 16/16] include: configs: Update env for selecting right dtb

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Now that single defconfig can be used for booting J721E EVM and SK, default device tree will not work for selecting dtb for kernel. Update the findfdt env to select right dtb based on board_name env variable. Signed-off-by: Sinthu Raja --- include/configs/j721e_evm.h | 4

Re: ARM A53 and initial MMU mapping for EL0/1/2/3 ?

2022-02-09 Thread Joakim Tjernlund
On Wed, 2022-02-09 at 00:33 +, Andre Przywara wrote: > On Tue, 8 Feb 2022 22:05:00 + > Joakim Tjernlund wrote: > > Hi Joakim, > > > Trying to figure out how I should map the MMU for normal RAM so it acessible > > from all ELx security states. > >^^^ > > This does not make

[PATCH V3 11/16] arm: dts: k3-j721e-r5-sk: Add initial R5 specific dts support for j721e-sk

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Add R5 specific dts for J721E-SK Signed-off-by: Sinthu Raja --- arch/arm/dts/Makefile | 3 +- arch/arm/dts/k3-j721e-r5-sk-u-boot.dtsi | 31 ++ arch/arm/dts/k3-j721e-r5-sk.dts | 646 3 files changed, 679 insertions(+), 1

[PATCH V3 06/16] board: ti: j721e: Disable probing of daughtercards

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja j721e-sk doesn't have any daughter cards, so disable daughter card probing inside board_late_init() and spl_board_init() for j721e-sk. Signed-off-by: Sinthu Raja --- Changes in V3: * Updated the conditional check to be a positive check for the board(s) which may have

[PATCH V3 08/16] arm: j721e: Add support for selecting DT based on board name

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Enable support for selecting DTB from FIT within SPL based on the board name read from EEPROM. This will help to use single defconfig for both EVM and SK. Signed-off-by: Sinthu Raja --- arch/arm/mach-k3/j721e_init.c | 58 +++ 1 file changed,

[PATCH V3 07/16] board: ti: j721e: Add support for detecting multiple device trees

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Update the board_fit_config_name_match() to choose the right dtb based on the board name read from EEPROM. Also restrict multpile EEPROM reads by verifying if EEPROM is already read. Signed-off-by: Sinthu Raja --- board/ti/j721e/evm.c | 16 ++-- 1 file changed,

[PATCH V3 05/16] board: ti: j721e: Add support to update board_name for j721e-sk

2022-02-09 Thread Sinthu Raja
From: Sinthu Raja Update setup_board_eeprom_env() to choose the right board name for j721e-sk. Signed-off-by: Sinthu Raja --- board/ti/j721e/evm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c index dc1c310861..b6810eb0c9 100644 ---

Re: [PATCH] spi: dw: Fix broken dw_spi_mem_ops()

2022-02-09 Thread Pratyush Yadav
On 08/02/22 10:52PM, Niklas Cassel wrote: > From: Niklas Cassel > > The driver is currently using sizeof(op->cmd.opcode) in the op_len > calculation. Commit d15de623013c ("spi: spi-mem: allow specifying a > command's extension") changed op->cmd.opcode from one byte to two. > > Instead, a new

Re: [PATCH v3 07/18] pxe: Move pxe_utils files

2022-02-09 Thread Adam Ford
On Thu, Oct 14, 2021 at 1:50 PM Simon Glass wrote: > > Move the header file into the main include/ directory so we can use it > from the bootmethod code. Move the C file into boot/ since it relates to > booting. > +cc lokeshvu...@ti.com Simon, I can't explain why, but with git bisect, it

Re: ARM A53 and initial MMU mapping for EL0/1/2/3 ?

2022-02-09 Thread Michael Walle
>> The problem I have is that I boot a custom SOC into u-boot and when u-boot >> tries >> to boot linux I get an error exception when u-boot calls armv8_switch_to_el2 >> to enter linux. > > So that means that U-Boot runs in EL3, is that the first and only firmware > that you run? I think the EL3

Re: ARM A53 and initial MMU mapping for EL0/1/2/3 ?

2022-02-09 Thread Andre Przywara
On Wed, 9 Feb 2022 14:05:57 +0100 Michael Walle wrote: Hi, > >> The problem I have is that I boot a custom SOC into u-boot and when u-boot > >> tries > >> to boot linux I get an error exception when u-boot calls > >> armv8_switch_to_el2 to enter linux. > > > > So that means that U-Boot

[PATCH v11 3/9] tools: mkeficapsule: add man page

2022-02-09 Thread AKASHI Takahiro
Add a man page for mkeficapsule command. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- MAINTAINERS| 1 + doc/mkeficapsule.1 | 99 ++ 2 files changed, 100 insertions(+) create mode 100644

[PATCH v11 2/9] tools: mkeficapsule: add firmware image signing

2022-02-09 Thread AKASHI Takahiro
With this enhancement, mkeficapsule will be able to sign a capsule file when it is created. A signature added will be used later in the verification at FMP's SetImage() call. To do that, we need specify additional command parameters: -monotonic-cout : monotonic count -private-key : private

[PATCH v11 4/9] doc: update UEFI document for usage of mkeficapsule

2022-02-09 Thread AKASHI Takahiro
Now we can use mkeficapsule command instead of EDK-II's script to create a signed capsule file. So update the instruction for capsule authentication. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- doc/develop/uefi/uefi.rst | 151

[PATCH v11 0/9] efi_loader: capsule: improve capsule authentication support

2022-02-09 Thread AKASHI Takahiro
# In this version, the crypto library was changed from openssl to # gnutls to avoid the license issue. So the dockerfile for sandbox # CI should be updated for necessary packages as well. # See my patch, "Dockerfile: Add libgnutls package for building # mkeficapsule command", I have not tested the

[PATCH v11 1/9] tools: build mkeficapsule with tools-only_defconfig

2022-02-09 Thread AKASHI Takahiro
Add CONFIG_TOOLS_MKEFICAPSULE. Then we want to always build mkeficapsule if tools-only_defconfig is used. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- configs/tools-only_defconfig | 1 + tools/Kconfig| 8 tools/Makefile | 3 +-- 3 files

Re: [PATCH v3 07/18] pxe: Move pxe_utils files

2022-02-09 Thread Tom Rini
On Wed, Feb 09, 2022 at 05:40:03AM -0600, Adam Ford wrote: > On Thu, Oct 14, 2021 at 1:50 PM Simon Glass wrote: > > > > Move the header file into the main include/ directory so we can use it > > from the bootmethod code. Move the C file into boot/ since it relates to > > booting. > > > +cc

[PATCH v11 8/9] test/py: efi_capsule: add a test for "--guid" option

2022-02-09 Thread AKASHI Takahiro
This test scenario tests a new feature of mkeficapsule, "--guid" option, which allows us to specify FMP driver's guid explicitly at the command line. Signed-off-by: AKASHI Takahiro --- test/py/tests/test_efi_capsule/conftest.py| 3 + .../test_efi_capsule/test_capsule_firmware.py | 67

Re: ARM A53 and initial MMU mapping for EL0/1/2/3 ?

2022-02-09 Thread Andre Przywara
On Wed, 9 Feb 2022 08:35:04 + Joakim Tjernlund wrote: Hi, > On Wed, 2022-02-09 at 00:33 +, Andre Przywara wrote: > > On Tue, 8 Feb 2022 22:05:00 + > > Joakim Tjernlund wrote: > > > > Hi Joakim, > > > > > Trying to figure out how I should map the MMU for normal RAM so it > > >

Re: [PATCH v2] console: usb: kbd: Limit poll frequency to improve performance

2022-02-09 Thread Marek Vasut
On 2/8/22 22:17, Thomas Watson wrote: On Jan 8, 2022, at 8:10 AM, Peter Robinson wrote: On Wed, Dec 22, 2021 at 11:16 PM Thomas Watson mailto:twatso...@icloud.com>> wrote: Using the XHCI driver, the function `usb_kbd_poll_for_event` takes 30-40ms to run. The exact time is dependent on the

Re: [PATCH v4 02/11] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-02-09 Thread Masami Hiramatsu
Hi Sughosh, 2022年2月9日(水) 18:03 Sughosh Ganu : > > hi Masami, > > On Wed, 9 Feb 2022 at 10:26, Masami Hiramatsu > wrote: > > > > Hi Sughosh, > > > > While porting mdata-sf driver, I'm confusing on the devicetree > > usage. > > > > 2022年2月8日(火) 3:21 Sughosh Ganu : > > > > > +int

Re: ARM A53 and initial MMU mapping for EL0/1/2/3 ?

2022-02-09 Thread Joakim Tjernlund
On Wed, 2022-02-09 at 10:45 +, Andre Przywara wrote: > On Wed, 9 Feb 2022 08:35:04 + > Joakim Tjernlund wrote: > > Hi, > > > On Wed, 2022-02-09 at 00:33 +, Andre Przywara wrote: > > > On Tue, 8 Feb 2022 22:05:00 + > > > Joakim Tjernlund wrote: > > > > > > Hi Joakim, > > > >

Re: FIT image: load secure FPGA

2022-02-09 Thread Adrian Fiergolski
Hi, On 09.02.2022 08:51, Jorge Ramirez-Ortiz, Foundries wrote: I have also shared with the community a patch, on top of your changes, adding encrypted bitfile support in u-boot. awesome. btw how is the bitstream decrypted? I didnt look into that, I suppose there is probably a doc somewhere?

[PATCH v11 5/9] test/py: efi_capsule: add image authentication test

2022-02-09 Thread AKASHI Takahiro
Add a couple of test cases against capsule image authentication for capsule-on-disk, where only a signed capsule file with the verified signature will be applied to the system. Due to the difficulty of embedding a public key (esl file) in U-Boot binary during pytest setup time, all the

[PATCH v11 6/9] tools: mkeficapsule: allow for specifying GUID explicitly

2022-02-09 Thread AKASHI Takahiro
The existing options, "--fit" and "--raw," are only used to put a proper GUID in a capsule header, where GUID identifies a particular FMP (Firmware Management Protocol) driver which then would handle the firmware binary in a capsule. In fact, mkeficapsule does the exact same job in creating a

[PATCH v11 7/9] test/py: efi_capsule: align with the syntax change of mkeficapsule

2022-02-09 Thread AKASHI Takahiro
Since the syntax of mkeficapsule was changed in the previous commit, we need to modify command line arguments in a pytest script. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- test/py/tests/test_efi_capsule/conftest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v11 9/9] test/py: efi_capsule: check the results in case of CAPSULE_AUTHENTICATE

2022-02-09 Thread AKASHI Takahiro
Before the capsule authentication is supported, this test script works correctly, but with the feature enabled, most tests will fail due to unsigned capsules. So check the results depending on CAPSULE_AUTHENTICATE or not. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass ---

Re: [PATCH] arm:dts:k3-am64-sk: EMIF tool update to 0.8.0 with 1333MTs for lpddr4

2022-02-09 Thread Tom Rini
On Wed, Feb 09, 2022 at 01:35:58PM +0530, Sinthu Raja M wrote: > On Sat, Jan 15, 2022 at 9:04 PM Tom Rini wrote: > > > > On Mon, Nov 29, 2021 at 05:34:49PM +0530, Sinthu Raja wrote: > > > > > From: Sinthu Raja > > > > > > EMIF tool for AM64 SK is now updated to 0.8.0 that includes > > > *

Re: [RFC] CI: enforce packages upgrade for Msys2 on Windows

2022-02-09 Thread Tom Rini
On Wed, Feb 09, 2022 at 05:24:23PM +0900, AKASHI Takahiro wrote: > We need to install libgnutls-devel package to build the host tool, > mkeficapsule, and as of now, there seems to be a depencency conflict > in the current msys2 installer; > >:: installing libp11-kit (0.24.1-1) breaks

Re: [PATCH v5 07/13] patman: Update test_util to run doc tests

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:28AM -0700, Simon Glass wrote: > At present this function does not run the doctests. Allow the caller to > pass these modules in as strings. > > Update patman to use this. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH v5 08/13] buildman: Add a flag to control the traceback

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:29AM -0700, Simon Glass wrote: > At present the full horror of the Python traceback is shown by default. It > is normally only useful for debugging. Turn it off by default and add a > --debug flag to enable it. > > Signed-off-by: Simon Glass Applied to

Re: [PATCH v5 11/13] buildman: Provide a hint on how to debug thread crashes

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:32AM -0700, Simon Glass wrote: > If a thread crashes it is helpful to try the operation again with > threading disabled. Add a hint about that. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v5 09/13] buildman: Make use of test_util

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:30AM -0700, Simon Glass wrote: > Use test_util to run the tests, with the ability to select a single test > to run, if desired. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v5 10/13] buildman: Add helper functions for updating .config files

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:31AM -0700, Simon Glass wrote: > At present the only straightforward way to write tests that need a > slightly different configuration is to create a new board with its own > configuration. This is cumbersome. > > It would be useful if buildman could adjust the

Re: Commit 4f2e2280862a ("RFC: arm: pci: Add PCI cam support to PCI-E ecam driver")

2022-02-09 Thread Pali Rohár
On Wednesday 09 February 2022 08:24:27 Alistair Delva wrote: > On Wed, Feb 9, 2022 at 8:09 AM Pali Rohár wrote: > > > > On Monday 07 February 2022 11:48:29 Alistair Delva wrote: > > > On Mon, Feb 7, 2022 at 11:39 AM Pali Rohár wrote: > > > > > > > > PING! Could you look at this email? > > > > >

Re: [PATCH 3/3] Drop CONFIG_SYS_PIO_MODE

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:53:25AM -0700, Simon Glass wrote: > This option is not used in U-Boot. Drop it. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/3] Convert CONFIG_SYS_IDE_MAXBUS et al to Kconfig

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:53:24AM -0700, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_SYS_IDE_MAXBUS >CONFIG_SYS_IDE_MAXDEVICE >CONFIG_SYS_ATA_BASE_ADDR >CONFIG_SYS_ATA_STRIDE >CONFIG_SYS_ATA_DATA_OFFSET >CONFIG_SYS_ATA_REG_OFFSET >

Re: [PATCH 1/3] ide: Drop CONFIG_IDE_AHB

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:53:23AM -0700, Simon Glass wrote: > This is not used in U-Boot anymore. Drop it. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v5 12/13] buildman: Allow adjusting board config on the fly

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:33AM -0700, Simon Glass wrote: > Add a -a option to specify changes to the config before the build > commences. For example > >buildman -a ~CONFIG_CMDLINE > > disables CONFIG_CMDLINE before doing the build. > > This makes it easier to try things out as well as

Re: [PATCH] Convert CONFIG_REMAKE_ELF to Kconfig

2022-02-09 Thread Tom Rini
On Sat, Jan 29, 2022 at 06:25:30PM +0300, Alper Nebi Yasak wrote: > This converts the following to Kconfig: >CONFIG_REMAKE_ELF > > Signed-off-by: Alper Nebi Yasak Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH 1/2] miiphyutil: Fix inconsistent miiphy_write() error return value

2022-02-09 Thread Daniel Klauer
miiphy_write() should not directly return the error return value from bus->write(), because that is typically a -errno value, while generally miiphy_write() and other miiphy_*() functions return 1 on error. Some miiphy_write() callers only check for > 0 to detect errors. Fix it to match

[PATCH 2/2] net: phy: mv88e6352: Fix miiphy_read/miiphy_write return value checks

2022-02-09 Thread Daniel Klauer
The miiphy_read/miiphy_write functions return 1 on error, not -errno. Fix up the checks accordingly and insert -EIO as fallback error code. Signed-off-by: Daniel Klauer --- drivers/net/phy/mv88e6352.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git

Re: [PATCH v4 06/11] remoteproc: uclass: Add remoteproc resource handling helpers

2022-02-09 Thread Amjad Ouled-Ameur
Hi Simon, Thank you for your feedback. Since the patchset has already been applied, I will address your comments in follow-up patches. Kindly, Amjad On 27/01/2022 16:43, Simon Glass wrote: Hi Amjad, On Thu, 27 Jan 2022 at 05:17, Amjad Ouled-Ameur wrote: From: Keerthy Add remoteproc

Re: [PATCH v5 05/13] kconfig: Add support for conditional values

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:26AM -0700, Simon Glass wrote: > At present if an optional Kconfig value needs to be used it must be > bracketed by #ifdef. For example, with this Kconfig setup: > > config WIBBLE > bool "Support wibbles, the world needs more wibbles" > > config WIBBLE_ADDR >

Re: [PATCH v5 03/13] mmc: fsl: Use brackets around if()

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:24AM -0700, Simon Glass wrote: > At present the IS_ENABLED() macro has extra brackets, making it possible > to write: > >if IS_ENABLED(CONFIG_XXX) > > but it is a bit confusing. Add the missing brackets. > > Signed-off-by: Simon Glass > Reviewed-by: Jaehoon

Re: [PATCH v5 01/13] imx: Don't define __ASSEMBLY__ in source files

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:22AM -0700, Simon Glass wrote: > This is supposed to be a build-system flag. Move it there so we can > define it before linux/kconfig.h is included. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH v5 02/13] mips: Avoid using config_enabled() directly

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:23AM -0700, Simon Glass wrote: > Use IS_ENABLED() instead, which is the correct macro for checking a CONFIG > option. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v5 06/13] bloblist: Update to use conditional value

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:27AM -0700, Simon Glass wrote: > Use the new IF_ENABLED_INT() feature to avoid needing our own inline > function to handle this case. Tidy up the logic to ensure that the value > is only used when present. Update the 'expected' comment also. > > Signed-off-by: Simon

Re: [PATCH v5 04/13] kconfig: Update IS_ENABLED() internals

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:25AM -0700, Simon Glass wrote: > The config_enabled() macro currently uses 0 as the default value. Update > it to allow any value, so we can pass it something else, such as a > non-existent function, to produce a build error if it is not defined. > > Also tidy up

Re: [PATCH 7/8] Convert CONFIG_SCSI_AHCI_PLAT et al to Kconfig

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:37AM -0700, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_SCSI_AHCI_PLAT >CONFIG_SYS_SCSI_MAX_SCSI_ID >CONFIG_SYS_SCSI_MAX_LUN >CONFIG_SYS_SATA_MAX_DEVICE > > Drop CONFIG_SCSI for everything except the sandbox build. We only

Re: commit leads to failure while writing env to sdcard (MMC1) on my imx8mq board

2022-02-09 Thread Heiko Thiery
Hi Fabio, Am Mi., 9. Feb. 2022 um 15:20 Uhr schrieb Fabio Estevam : > > Hi Heiko, > > On Wed, Feb 9, 2022 at 11:11 AM Heiko Thiery wrote: > > > > Hi Sean, > > > > I tried the latest U-boot master and faced an issue with your commit. > > I was able to do a bisect and see that it comes from > >

Re: Commit 4f2e2280862a ("RFC: arm: pci: Add PCI cam support to PCI-E ecam driver")

2022-02-09 Thread Pali Rohár
On Monday 07 February 2022 11:48:29 Alistair Delva wrote: > On Mon, Feb 7, 2022 at 11:39 AM Pali Rohár wrote: > > > > PING! Could you look at this email? > > > > On Thursday 20 January 2022 14:48:34 Pali Rohár wrote: > > > Hello Alistair! > > > > > > On Wednesday 19 January 2022 14:48:21 Alistair

Re: [PATCH 8/8] dm: scsi: Add a migration deadline for scsi

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:38AM -0700, Simon Glass wrote: > Very few boards remain to be migrated: > >am57xx_hs_evm_usb >controlcenterdc >highbank >ls1021atsn_qspi >ls1021atsn_sdcard >ls1021atwr_sdcard_ifc_SECURE_BOOT >ls1046ardb_sdcard_SECURE_BOOT >

commit leads to failure while writing env to sdcard (MMC1) on my imx8mq board

2022-02-09 Thread Heiko Thiery
Hi Sean, I tried the latest U-boot master and faced an issue with your commit. I was able to do a bisect and see that it comes from 41c6a22fc2963bfc76fc2aa21f572ceb0c5a4e22 (mmc: fsl_esdhc_imx: simplify esdhc_setup_data() ). Is someone able to confirm that? 8< Hit any key to stop

Re: commit leads to failure while writing env to sdcard (MMC1) on my imx8mq board

2022-02-09 Thread Fabio Estevam
Hi Heiko, On Wed, Feb 9, 2022 at 11:11 AM Heiko Thiery wrote: > > Hi Sean, > > I tried the latest U-boot master and faced an issue with your commit. > I was able to do a bisect and see that it comes from > 41c6a22fc2963bfc76fc2aa21f572ceb0c5a4e22 (mmc: fsl_esdhc_imx: simplify >

Re: [PATCH V8] arm: add initial support for the Phytium Pomelo Board

2022-02-09 Thread Rob Herring
is only On Mon, Jan 10, 2022 at 7:49 PM wrote: > > From: weichangzheng > > This adds platform code and the device tree for the Phytium Pomelo Board. > The initial support comprises the UART and the PCIE. > > Signed-off-by: weichangzheng > Changes since v1: > updated to DT > Changes

Re: [PATCH v5 13/13] test: Add some tests for kconfig.h

2022-02-09 Thread Tom Rini
On Sat, Jan 22, 2022 at 05:07:34AM -0700, Simon Glass wrote: > The macros in this file are a little confusing and we currently have no > tests to check that they work as expected. > > Add some tests which check the macros in C code. Add a few tests which > check that the build errors are

[PATCH] lx2160a: Fix distroboot device list for configs without USB/SCSI/etc

2022-02-09 Thread Daniel Klauer
The BOOT_TARGET_DEVICES list for distro_bootcmd was hard-coded to assume that all boot devices are available/enabled in the configuration, thus ignoring the actual config settings. The config_distro_bootcmd.h header file specifically has compile-time checks to detect such problems. To allow

Re: [PATCH 1/8] sata: Drop Silicon Image SIL3114 SATA driver

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:31AM -0700, Simon Glass wrote: > This is not used in U-Boot and has not been converted to driver model. > Drop it. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 6/8] scsi: Drop CONFIG_SYS_SCSI_MAX_DEVICE

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:36AM -0700, Simon Glass wrote: > This is defined based on two other CONFIGs for all boards except sandbox > and durian. > > For sandbox the value does not matter. For durian the value seems > excessive. > > Drop the option completely, to simplify configuration and

Re: [PATCH 5/8] ahci: Make ahci drivers depend on AHCI

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:35AM -0700, Simon Glass wrote: > At present all ahci drivers depend on AHCI except for DWC_AHCI. But no > boards enable that without also enabling AHCI: > >/tools/moveconfig.py -f ~AHCI DWC_AHCI >0 matches > > Group them together and sort them in order by

Re: [PATCH 4/8] sata: sata_sil: Only support BLK

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:34AM -0700, Simon Glass wrote: > No boards use this driver without CONFIG_BLK, so clean up the dead code. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/8] sata: Rearrange Kconfig for SATA

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:33AM -0700, Simon Glass wrote: > Move the SATA options inside an 'if SATA' part, so they are grouped. > > Fix the 'Complient' typo while we are here. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 2/8] sata: Only support BLK

2022-02-09 Thread Tom Rini
On Mon, Jan 31, 2022 at 07:49:32AM -0700, Simon Glass wrote: > No boards currently use SATA without BLK: > >./tools/moveconfig.py -f SATA ~BLK >0 matches > > Make SATA depend on BLK to avoid any future confusion. Drop the dead code. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan

[PATCH v5 05/16] lib: crypto: allow to build crypyo in SPL

2022-02-09 Thread Philippe Reynes
This commit adds the options: - SPL_ASYMMETRIC_KEY_TYPE - SPL_ASYMMETRIC_PUBLIC_KEY_SUBTYPE - SPL_RSA_PUBLIC_KEY_PARSER Signed-off-by: Philippe Reynes --- lib/Makefile| 3 ++- lib/crypto/Kconfig | 29 + lib/crypto/Makefile | 19 +-- 3 files

[PATCH v5 01/16] arch: Kconfig: imply BINMAN for SANDBOX

2022-02-09 Thread Philippe Reynes
To be able to use BINMAN on sandbox, the config SANDBOX imply BINMAN. Signed-off-by: Philippe Reynes --- arch/Kconfig | 1 + arch/sandbox/dts/sandbox.dtsi | 3 +++ arch/sandbox/dts/test.dts | 3 +++ test/py/tests/test_fit.py | 3 +++

Re: [PATCH v4 02/11] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-02-09 Thread Sughosh Ganu
hi Masami, On Wed, 9 Feb 2022 at 17:18, Masami Hiramatsu wrote: > > Hi Sughosh, > > 2022年2月9日(水) 18:03 Sughosh Ganu : > > > > hi Masami, > > > > On Wed, 9 Feb 2022 at 10:26, Masami Hiramatsu > > wrote: > > > > > > Hi Sughosh, > > > > > > While porting mdata-sf driver, I'm confusing on the

[PATCH v2] binman: Skip processing "hash" subnodes of FIT subsections

2022-02-09 Thread Alper Nebi Yasak
Binman's FIT entry type can have image subentries with "hash" subnodes intended to be processed by mkimage, but not binman. However, the Entry class and any subclass that reuses its implementation tries to process these unconditionally. This can lead to an error when boards specify hash algorithms

[PATCH] scripts: dtc: libfdt: fdt_ro.c: always define fdt_check_full

2022-02-09 Thread Philippe Reynes
On some configs (like stm32mp15_dhcom_basic_defconfig), if configs SPL_LOAD_FIT_FULL and SPL_FIT_FULL_CHECK are enabled. Then the compilatio fails with the following error: arm-linux-gnueabi-ld.bfd: boot/image-fit.o: in function `fit_check_format': /uboot/u-boot-stm/boot/image-fit.c:1641:

[PATCH v5 06/16] lib: rsa: allow rsa verify with pkey in SPL

2022-02-09 Thread Philippe Reynes
This commit adds the option SPL_RSA_VERIFY_WITH_PKEY. Signed-off-by: Philippe Reynes --- lib/rsa/Kconfig | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index be9775bcce..b773f17c26 100644 --- a/lib/rsa/Kconfig +++ b/lib/rsa/Kconfig @@

[PATCH v5 10/16] mkimage: add public key for image pre-load stage

2022-02-09 Thread Philippe Reynes
This commit enhances mkimage to update the node /image/pre-load/sig with the public key. Signed-off-by: Philippe Reynes --- include/image.h| 15 ++ tools/fit_image.c | 3 ++ tools/image-host.c | 114 + 3 files changed, 132 insertions(+)

[PATCH v5 04/16] lib: allow to build asn1 decoder and oid registry in SPL

2022-02-09 Thread Philippe Reynes
This commit adds the options: - SPL_ASN1_DECODER - SPL_OID_REGISTRY Signed-off-by: Philippe Reynes --- lib/Kconfig | 19 +++ lib/Makefile | 7 +-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig b/lib/Kconfig index e749826f22..effe735365 100644

[PATCH v5 03/16] lib: Kconfig: enhance the help of OID_REGISTRY

2022-02-09 Thread Philippe Reynes
Enhance the help for the config OID_REGISTRY. Signed-off-by: Philippe Reynes --- lib/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig b/lib/Kconfig index b0e5d60b3d..e749826f22 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -812,6 +812,10 @@ config ASN1_DECODER config

[PATCH v5 13/16] configs: sandbox_defconfig: enable stage pre-load in bootm

2022-02-09 Thread Philippe Reynes
Enable the support of stage pre-load in bootm. For the moment, this stage allow to verify the signature of the full image with a header. Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/sandbox_defconfig

Re: ARM A53 and initial MMU mapping for EL0/1/2/3 ?

2022-02-09 Thread Joakim Tjernlund
On Wed, 2022-02-09 at 13:13 +, Andre Przywara wrote: > On Wed, 9 Feb 2022 14:05:57 +0100 > Michael Walle wrote: > > Hi, > > > > > The problem I have is that I boot a custom SOC into u-boot and when > > > > u-boot tries > > > > to boot linux I get an error exception when u-boot calls > >

lib.a in tools/env

2022-02-09 Thread rich_ogrady
Hello, It seems that lib.a doesn't get built correctly (at least for us) since u-boot-2020.10. In later versions the file is there in the folder but is rather small and unidentifiable as a valid archive. We build with options tools-only_defconfig, envtools, and NO_SDL=1 Any ideas? Regards,

Re: Commit 4f2e2280862a ("RFC: arm: pci: Add PCI cam support to PCI-E ecam driver")

2022-02-09 Thread Mark Kettenis
> Date: Wed, 9 Feb 2022 17:09:50 +0100 > From: Pali Rohár > > On Monday 07 February 2022 11:48:29 Alistair Delva wrote: > > On Mon, Feb 7, 2022 at 11:39 AM Pali Rohár wrote: > > > > > > PING! Could you look at this email? > > > > > > On Thursday 20 January 2022 14:48:34 Pali Rohár wrote: > > >

Re: [PATCH v3 07/18] pxe: Move pxe_utils files

2022-02-09 Thread Simon Glass
Hi, On Wed, 9 Feb 2022 at 05:32, Tom Rini wrote: > > On Wed, Feb 09, 2022 at 05:40:03AM -0600, Adam Ford wrote: > > On Thu, Oct 14, 2021 at 1:50 PM Simon Glass wrote: > > > > > > Move the header file into the main include/ directory so we can use it > > > from the bootmethod code. Move the C

Re: [PATCH] Replace echo -n's used in environment processing with touch

2022-02-09 Thread Simon Glass
Hi Qthedev, On Wed, 9 Feb 2022 at 08:25, qthedev wrote: > > On Monday, February 7th, 2022 at 11:22 PM, Simon Glass > wrote: > > > Hi, > > > > On Sat, 5 Feb 2022 at 06:49, qthedev qthe...@protonmail.com wrote: > > > > > echo -n does not give the intended effect when invoked in macOS through >

[PATCH v5 14/16] test: py: vboot: add test for global image signature

2022-02-09 Thread Philippe Reynes
Adds test units for the pre-load header signature. Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 123 +++--- test/py/tests/vboot/sandbox-binman-pss.dts| 25 test/py/tests/vboot/sandbox-binman.dts| 24

[PATCH v5 08/16] cmd: bootm: add a stage pre-load

2022-02-09 Thread Philippe Reynes
Add a stage pre-load to the command bootm. Right now, this stage may be used to read a header and check the signature of the full image. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- boot/bootm.c| 33 + cmd/Kconfig | 10 ++

[PATCH v5 11/16] Makefile: provide sah-key to binman

2022-02-09 Thread Philippe Reynes
Set the variable key-path with the shell variable KEY_PATH that contain the keys path (used for signature). This variable key-path is provided to binman. Signed-off-by: Philippe Reynes --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index

[PATCH v5 16/16] configs: sandbox_defconfig: enable config CMD_VERIFY

2022-02-09 Thread Philippe Reynes
Enable the command verify on sandbox. Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 2732b05ca7..483f01ef79 100644 --- a/configs/sandbox_defconfig +++

[PATCH v5 15/16] cmd: verify: initial import

2022-02-09 Thread Philippe Reynes
Add the command verify that check the signature of an image with the pre-load header. If the check succeed, the u-boot env variable 'loadaddr_verified' is set to the address of the image (without the header). It allows to run such commands: tftp script.img && verify $loadaddr && source

[PATCH v5 12/16] tools: binman: add support for pre-load header

2022-02-09 Thread Philippe Reynes
Adds the support of the pre-load header with the image signature to binman. Signed-off-by: Philippe Reynes --- tools/binman/etype/pre_load.py | 156 + 1 file changed, 156 insertions(+) create mode 100644 tools/binman/etype/pre_load.py diff --git

[PATCH v5 07/16] boot: image: add a stage pre-load

2022-02-09 Thread Philippe Reynes
Add a stage pre-load that could check or modify an image. For the moment, only a header with a signature is supported. This header has the following format: - magic : 4 bytes - version : 4 bytes - header size : 4 bytes - image size : 4 bytes - offset image signature : 4 bytes - flags : 4 bytes -

  1   2   >