Use macro to represent the RL and WL setting to ensure the PHY and
controller setting are aligned.
Signed-off-by: Dylan Hung
---
arch/arm/include/asm/arch-aspeed/sdram_ast2600.h | 4
drivers/ram/aspeed/sdram_ast2600.c | 9 +
2 files changed, 13 insertions(+)
diff
The condition "~data" in the if-statement is a typo. The original
intention is to poll if SDRAM_PHYCTRL0_INIT bit equals to 0. So use
"data == 0" for instead.
Besides, the bit[1] of "phy_status" register is hardwired to
SDRAM_PHYCTRL0_INIT (with inverse logic). Since SDRAM_PHYCTRL0_INIT has
Adjust the following settings to get better timing and signal quality.
1. write DQS/DQ delay
- 1e6e2304[0]
- 1e6e2304[15:8]
2. read DQS/DQ delay
- 0x1e6e0298[0]
- 0x1e6e0298[15:8]
3. CLK/CA timing
- 0x1e6e01a8[31]
4. Read and write termination
- change RTT_ROM from 40 ohm to 48 ohm (MR1[10:8])
This patch series fine-tunes the read & write DQS/DQ timing, CLK/CA
timing and termination (RTT_NOM, RTT_PARK and RTT_WR) for Aspeed AST26x0
SOC to get better signal quality and hence improve the stability. Also,
a typing error of the DDR-PHY status polling is fixed.
Dylan Hung (3):
ram:
Hi Tom,
Heinirch forwarded me a coverity report a few days ago regarding some
changes in the EFI subsystem and specifically the protocol management
functions.
The issues reported were:
- CID 376213
- CID 376206
- CID 376203
- CID 376200
- CID 376199
- CID 376195
The last one has been already
On Tue, 1 Nov 2022 00:08:16 -0500
Samuel Holland wrote:
> This choice is meaningless when SPL is disabled. Hide it to avoid any
> possible confusion.
>
> Signed-off-by: Samuel Holland
Reviewed-by: Andre Przywara
Cheers,
Andre
> ---
>
> board/sunxi/Kconfig | 1 +
> 1 file changed, 1
On Tue, 1 Nov 2022 00:08:15 -0500
Samuel Holland wrote:
> Some of the selected symbols have a user-visible dependency. Make the
> selections conditional on that dependency to avoid creating invalid
> configurations.
No change in any of the generated configs, so looks fine:
> Signed-off-by:
On Tue, 1 Nov 2022 00:08:14 -0500
Samuel Holland wrote:
> Two of these selections are redundant and have no effect:
> - DM_KEYBOARD is selected by USB_KEYBOARD
> - DM_MMC is selected by MMC
>
> This selection has no effect by default and is unnecessarily strong:
> - USB_STORAGE is implied
On Tue, 1 Nov 2022 00:08:13 -0500
Samuel Holland wrote:
Hi Samuel,
> We tried to enable USB_EHCI_GENERIC and USB_OHCI_GENERIC by default.
Well, I am not really sure that was the real intention, looking at
commit 29d280c88a1ff3, and the fact that those symbols are still
explicitly defined in
> From: Heinrich Schuchardt
> Sent: Tuesday, November 08, 2022 11:14 PM
> To: Bin Meng
> Cc: Rick Jian-Zhi Chen(陳建志) ; Leo Yu-Chi Liang(梁育齊)
> ; Conor Dooley ;
> u-boot@lists.denx.de
> Subject: Re: [PATCH 1/1] riscv: clarify meaning of CONFIG_SBI_V02
>
> On 11/8/22 16:05, Bin Meng wrote:
> >
Hi Heinrich
> From: Heinrich Schuchardt
> Sent: Tuesday, November 08, 2022 11:14 PM
> To: Bin Meng
> Cc: Rick Jian-Zhi Chen(陳建志) ; Leo Yu-Chi Liang(梁育齊)
> ; Conor Dooley ;
> u-boot@lists.denx.de
> Subject: Re: [PATCH 1/1] riscv: clarify meaning of CONFIG_SBI_V02
>
> On 11/8/22 16:05, Bin Meng
On Thu, Nov 10, 2022 at 01:40:35PM -0700, Simon Glass wrote:
> Hi,
>
> On Fri, 28 Oct 2022 at 13:19, Tom Rini wrote:
> >
> > On Fri, Oct 28, 2022 at 09:14:13PM +0200, Heinrich Schuchardt wrote:
> > > On 10/28/22 21:04, Tom Rini wrote:
> > > > On Sun, Oct 16, 2022 at 12:03:30PM +0200, Heinrich
Hi Tom,
On Mon, 7 Nov 2022 at 10:29, Tom Rini wrote:
>
> On Mon, Nov 07, 2022 at 04:33:28PM +, Holger Brunck wrote:
> > Hi Tom,
> >
> > > > > On Fri, 4 Nov 2022 at 08:20, Holger Brunck
> > > > > wrote:
> > > > >>
> > > > >> Hi Simon,
> > > > >> I got no time to try it yet but I have a
Hi,
On Fri, 28 Oct 2022 at 13:19, Tom Rini wrote:
>
> On Fri, Oct 28, 2022 at 09:14:13PM +0200, Heinrich Schuchardt wrote:
> > On 10/28/22 21:04, Tom Rini wrote:
> > > On Sun, Oct 16, 2022 at 12:03:30PM +0200, Heinrich Schuchardt wrote:
> > > > On 10/16/22 09:43, Heinrich Schuchardt wrote:
> > >
Hi Pali,
On Thu, 10 Nov 2022 at 01:01, Pali Rohár wrote:
>
> On Wednesday 09 November 2022 19:14:40 Simon Glass wrote:
> > This currently uses if_changed on a phony target. Use a real file as the
> > target and add FORCE at the end, as required. Drop the 'inputs' phony
> > since it is not
On Thu, 10 Nov 2022 at 10:04, Sughosh Ganu wrote:
>
> The sandbox config file is to be removed. Move the GUID declarations
> needed for capsule update functionality to the board file where they
> are used.
>
> Signed-off-by: Sughosh Ganu
> ---
> board/sandbox/sandbox.c | 13 +
>
Hi Patrick,
On Thu, 10 Nov 2022 at 03:49, Patrick Delaunay
wrote:
>
>
> Update in U-Boot env mmc backend with several cosmetic changes or
> corrections and 2 new features:
>
> 1/ CONFIG_ENV_MMC_USE_DT = no more use CONFIG_ENV_OFFSET
>in the mmc ENV backend when this config is activated.
>
>
On Fri, Oct 28, 2022 at 08:26:54PM -0400, Tom Rini wrote:
> This converts the following to Kconfig:
>CONFIG_SYS_I2C_INIT_BOARD
>
> Signed-off-by: Tom Rini
> Reviewed-by: Simon Glass
For the series, applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
The rx descriptor list is in cached memory, and there may be multiple
descriptors per cache-line. After reclaim_rx_buffers marks a descriptor
as unused it does a cache flush, which causes the entire cache-line to
be written to memory, which may override other descriptors in the same
cache-line
On Thu, Nov 10, 2022 at 10:59 AM Simon Glass wrote:
>
> Hi Rob,
>
> On Tue, 8 Nov 2022 at 10:19, Rob Herring wrote:
> >
> > On Tue, Nov 1, 2022 at 10:13 PM Simon Glass wrote:
> > >
> > > U-Boot has some particular challenges with device tree and devices:
> > >
> > > - U-Boot has multiple build
On Tue, Nov 8, 2022 at 3:39 AM Fabio Estevam wrote:
>
> From: Fabio Estevam
>
> This reverts commit c7878a0483c59c48a730123bc0f4659fd40921bf.
>
> Since commit c7878a0483c5 ("serial: mxc: have putc use the TXFIFO"),
> serial console corruption can be seen when priting inside board_init().
>
>
On 11/10/22 14:31, Ilias Apalodimas wrote:
UEFI specification requires pointers that are passed to protocol member
functions to be aligned. There's a u16_strdup in that function which
doesn't make sense otherwise Add a comment so no one removes it
accidentally
Signed-off-by: Ilias Apalodimas
The sandbox config file is to be removed. Move the GUID declarations
needed for capsule update functionality to the board file where they
are used.
Signed-off-by: Sughosh Ganu
---
board/sandbox/sandbox.c | 13 +
include/configs/sandbox.h | 13 -
2 files changed, 13
Hi Rob,
On Tue, 8 Nov 2022 at 10:19, Rob Herring wrote:
>
> On Tue, Nov 1, 2022 at 10:13 PM Simon Glass wrote:
> >
> > U-Boot has some particular challenges with device tree and devices:
> >
> > - U-Boot has multiple build phases, such as a Secondary Program Loader
> > (SPL) phase which
U-Boot has some particular challenges with device tree and devices:
- U-Boot has multiple build phases, such as a Secondary Program Loader
(SPL) phase which typically runs in a pre-SDRAM environment where code
and data space are limited. In particular, there may not be enough
space for the
On 09/11/22, Marcel Ziswiler wrote:
> Hi Oliver
>
> Thanks for working on this.
>
> On Fri, 2022-11-04 at 16:03 +0100, Oliver Graute wrote:
> > Switch to use binman to pack images
> >
> > Signed-off-by: Oliver Graute
> > ---
> > Changes for v2
> > - use common imx8qm-u-boot.dtsi
> > - guard
On Wed, Nov 09, 2022 at 02:45:10PM -0300, Fabio Estevam wrote:
> Hi Oliver and Stefano,
>
> On Wed, Nov 9, 2022 at 1:19 PM Oliver Graute wrote:
>
> > For my imx8qm boards I need to manually place these imx firmware blobs with
> > expected names for sucessfull image creation.
> >
> > As I
On 11/10/22 15:09, Ilias Apalodimas wrote:
Hi Heinrich
On Thu, 10 Nov 2022 at 15:46, Heinrich Schuchardt
wrote:
On 11/10/22 14:31, Ilias Apalodimas wrote:
UEFI specification requires pointers that are passed to protocol member
functions to be aligned. There's a u16_strdup in that function
Hi Heinrich
On Thu, 10 Nov 2022 at 15:46, Heinrich Schuchardt
wrote:
>
> On 11/10/22 14:31, Ilias Apalodimas wrote:
> > UEFI specification requires pointers that are passed to protocol member
> > functions to be aligned. There's a u16_strdup in that function which
> > doesn't make sense
On Thu, 2022-11-10 at 15:34 +0800, Macpaul Lin wrote:
> From: Fabien Parent
>
> The MediaTek MT8195 is a ARM64-based SoC with a quad-core Cortex-A73
> and
> a quad-core Cortex-A53. It is including UART, SPI, USB3.0 device and
> hosts,
> SD and MMC cards, UFS, PWM, I2C, I2S, S/PDIF, and several
On 11/10/22 14:31, Ilias Apalodimas wrote:
UEFI specification requires pointers that are passed to protocol member
functions to be aligned. There's a u16_strdup in that function which
doesn't make sense otherwise Add a comment so no one removes it
accidentally
Signed-off-by: Ilias Apalodimas
On Thu, 10 Nov 2022 at 15:14, Heinrich Schuchardt
wrote:
>
> Provide a description of the function's logic.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_loader/efi_file.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/lib/efi_loader/efi_file.c
UEFI specification requires pointers that are passed to protocol member
functions to be aligned. There's a u16_strdup in that function which
doesn't make sense otherwise Add a comment so no one removes it
accidentally
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_file.c | 5 +
1
On 11/10/22 14:11, Ilias Apalodimas wrote:
We now have internal functions for OpenVolume, EFI_FILE_PROTOCOL.Open()
and EFI_FILE_PROTOCOL.Close(). So use these instead of wrapping the
callsites with EFI_CALL()
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_file.c | 9 -
1
Provide a description of the function's logic.
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_file.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/efi_loader/efi_file.c b/lib/efi_loader/efi_file.c
index c96a7f7ca3..ae0ca6101b 100644
--- a/lib/efi_loader/efi_file.c
Heinrich
Please ignore this. As we discussed although this cleans up things
considerably, it's not exactly what the spec describes. So let's
keep the existing function.
I've sent another patch cleaning up the EFI_CALL() iterations
Thanks
/Ilias
On Thu, 10 Nov 2022 at 13:36, Ilias Apalodimas
We now have internal functions for OpenVolume, EFI_FILE_PROTOCOL.Open()
and EFI_FILE_PROTOCOL.Close(). So use these instead of wrapping the
callsites with EFI_CALL()
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_file.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
> On Sat, 2022-11-05 at 14:02 +0800, Yu Chien Peter Lin wrote:
>
> We should check the string until it hits underscore, in case it
> searches for the letters in the custom extension. For example,
> "rv64imac_xandes" will be treated as D extension support since
> there is a "d" in "andes",
On Thu, 10 Nov 2022 at 13:37, Heinrich Schuchardt
wrote:
>
> Goto for an immediately succeeding label is superfluous.
>
> Fixes: 87d791423ac6 ("eficonfig: menu-driven addition of UEFI boot option")
> Addresses-Coverity: 376202 ("Identical code for different branches")
> Signed-off-by: Heinrich
Goto for an immediately succeeding label is superfluous.
Fixes: 87d791423ac6 ("eficonfig: menu-driven addition of UEFI boot option")
Addresses-Coverity: 376202 ("Identical code for different branches")
Signed-off-by: Heinrich Schuchardt
---
cmd/eficonfig.c | 2 --
1 file changed, 2 deletions(-)
On Thu, 10 Nov 2022 at 13:29, Heinrich Schuchardt
wrote:
>
> Add the following files to EFI PAYLOAD:
>
> - cmd/bootefi.c
> - cmd/efidebug.c
> - cmd/eficonfig.c
> - cmd/nvedit_efi.c
>
> Signed-off-by: Heinrich Schuchardt
> ---
> MAINTAINERS | 4
> 1 file changed, 4 insertions(+)
>
> diff
The current implementation efi_load_from_path is a bit confusing.
First of all it tries to check the device path to make sure it contains
the path to the device plus the media path with the filename and nothing in
between. But that should already be valid since U-Boot constructs those
device
Add the following files to EFI PAYLOAD:
- cmd/bootefi.c
- cmd/efidebug.c
- cmd/eficonfig.c
- cmd/nvedit_efi.c
Signed-off-by: Heinrich Schuchardt
---
MAINTAINERS | 4
1 file changed, 4 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8d3d528650..141a00edf1 100644
---
Add the Gigadevice GD25LQ128E identifers so it can be properly
used.
Datasheet: https://www.gigadevice.com/datasheet/gd25lq128e/
Signed-off-by: Peter Robinson
---
drivers/mtd/spi/spi-nor-ids.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/mtd/spi/spi-nor-ids.c
Add a debug message to indicate a potential issue when
"u-boot,mmc-env-partition" is present in config node of device tree
but this partition name is not found in the mmc device.
Signed-off-by: Patrick Delaunay
---
env/mmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/env/mmc.c
Remove the unused macro STR(X) since the commit 2b2f727500dc ("env: mmc:
allow support of mmc_get_env_dev with OF_CONTROL")
Signed-off-by: Patrick Delaunay
---
env/mmc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/env/mmc.c b/env/mmc.c
index 8941e0f5ff39..85761417f283 100644
---
Since commit c0364ce1c695 ("doc/README.gpt: define partition type GUID for
U-Boot environment"), a specific type GUID can be used to indicate
the U-Boot environment partition on the device with GPT partition table.
This patch uses this type GUID to found the env partition as fallback
when the
Activate by default CONFIG_ENV_MMC_USE_DT as "u-boot,mmc-env-partition"
should be always use in STMicroelectronics boards device tree to locate
the environment for mmc backend. The 2 defines:
CONFIG_ENV_OFFSET=0x28
CONFIG_ENV_OFFSET_REDUND=0x2C
are only valid for spi-nor and not for
Add a new config CONFIG_ENV_MMC_USE_DT to force configuration of the
U-Boot environment offset with device tree config node.
This patch avoids issues when several CONFIG_ENV_IS_IN_XXX are activated,
the defconfig file uses the same value for CONFIG_ENV_OFFSET or
CONFIG_ENV_OFFSET_REDUND for the
This file has a lot of conditional code and much of it is unnecessary.
Clean this up to reduce the number of build combinations.
This patch replaces the test on CONFIG_ENV_OFFSET_REDUND for the
more coherent CONFIG_SYS_REDUNDAND_ENVIRONMENT.
This patch also corrects a compilation issue in
When ENV_IS_EMBEDDED is enabled, ret is not defined but is used as a
return value in env_mmc_load().
This patch correct this issue and simplify the existing code, test only
one time #if defined(ENV_IS_EMBEDDED) and not in the function.
Signed-off-by: Patrick Delaunay
---
env/mmc.c | 12
Introduce ENV_MMC_OFFSET defines.
It is a preliminary step to the next patches to simplify the code.
Signed-off-by: Patrick Delaunay
---
env/mmc.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/env/mmc.c b/env/mmc.c
index
Update in U-Boot env mmc backend with several cosmetic changes or
corrections and 2 new features:
1/ CONFIG_ENV_MMC_USE_DT = no more use CONFIG_ENV_OFFSET
in the mmc ENV backend when this config is activated.
Requested by the STM32MP STMicroelectronics boards which activate
several
Enable the UEFI capsule update functionality on the RockPi4B and
RockPi4C boards. Support is being enabled for updating the idbloader
and u-boot firmware images residing on GPT partitioned uSD card
storage device.
Signed-off-by: Sughosh Ganu
Reviewed-by: Kever Yang
---
Changes since V5: None
Add information that will be needed for enabling the UEFI capsule
update feature on the RockPi4 boards. With the feature enabled, it
would be possible to update the idbloader and u-boot.itb images on the
RockPi4B and RockPi4C variants.
Signed-off-by: Sughosh Ganu
Reviewed-by: Kever Yang
---
Add functions needed to support the UEFI capsule update feature on
rockchip boards. Currently, the feature is being enabled on the
RockPi4 boards with firmware images residing on GPT partitioned
storage media.
Signed-off-by: Sughosh Ganu
Reviewed-by: Kever Yang
---
Changes since V4:
* Get the
Add capsule update support for the RockPi4B and RockPi4C
boards. Support is being added for updating the idbloader.img and
u-boot.itb firmware images on configurations with the firmware images
stored on GPT partitioned uSD card device.
Changes since V5:
* Get the pointer to struct efi_fw_image
This commit adds the menu-driven interface to show the
signature list content.
Signed-off-by: Masahisa Kojima
---
No update since v7
Changes in v7:
- remove delete signature list feature
user can clear the signature database with signed null key
- rename function name to avoid confusion
-
This commit adds the menu-driven UEFI Secure Boot Key
enrollment interface. User can enroll PK, KEK, db
and dbx by selecting file.
Only the signed EFI Signature List(s) with an authenticated
header, typically '.auth' file, is accepted.
To clear the PK, KEK, db and dbx, user needs to enroll the
All the eficonfig menus other than "Change Boot Order"
use 'eficonfig_entry' structure for each menu entry.
This commit refactors change boot order implementation
to use 'eficonfig_entry' structure same as other menus
to have consistent menu handling.
This commit also simplifies the data->active
Following commits are adding support for UEFI variable management
via the eficonfig menu. Those functions needs to use
append_entry() and append_quit_entry() to construct the
menu, so move them out of their static declarations.
Signed-off-by: Masahisa Kojima
Reviewed-by: Ilias Apalodimas
---
No
eficonfig_select_file_handler() is commonly used to select the
file. eficonfig_display_select_file_option() adds an additional
menu to clear the selected file.
eficonfig_display_select_file_option() is not always necessary
for the file selection process, so it must be outside of
This series adds the UEFI Secure Boot key maintenance interface
to the eficonfig command.
User can enroll PK, KEK, db and dbx.
Source code can be cloned with:
$ git clone https://git.linaro.org/people/masahisa.kojima/u-boot.git -b
kojima/eficonfig_sbkey_v8
Masahisa Kojima (5):
eficonfig:
On 11/10/22 09:21, Ilias Apalodimas wrote:
If the va_list we got handed over contains no protocols we must return
EFI_SUCCESS. However in that case the current code just returns
an unintialized value.
Fix that by setting the return value in the variable definition
Addresses-Coverity: CID
If the va_list we got handed over contains no protocols we must return
EFI_SUCCESS. However in that case the current code just returns
an unintialized value.
Fix that by setting the return value in the variable definition
Addresses-Coverity: CID 376195: ("Uninitialized variables (UNINIT)")
Hi Heinrich
On Thu, 10 Nov 2022 at 10:15, Heinrich Schuchardt wrote:
>
> On 11/10/22 09:11, Ilias Apalodimas wrote:
> > If the va_list we got handed over contains no protocols we must return
> > EFI_SUCCESS. However in that case the current code just returns
> > an uninitialized value.
> > Fix
On 11/10/22 09:11, Ilias Apalodimas wrote:
If the va_list we got handed over contains no protocols we must return
EFI_SUCCESS. However in that case the current code just returns
an uninitialized value.
Fix that by setting the return value in the variable definition
Addresses-Coverity: CID
On 11/10/22 08:35, Ilias Apalodimas wrote:
If the va_list we got handed over contains no protocols we must return
EFI_INVALID_PARAMETER. However in that case the current code just returns
an unintialized value.
Addresses-Coverity: CID 376195: ("Uninitialized variables (UNINIT)")
---
If the va_list we got handed over contains no protocols we must return
EFI_SUCCESS. However in that case the current code just returns
an uninitialized value.
Fix that by setting the return value in the variable definition
Addresses-Coverity: CID 376195: ("Uninitialized variables (UNINIT)")
On Wednesday 09 November 2022 19:14:40 Simon Glass wrote:
> This currently uses if_changed on a phony target. Use a real file as the
> target and add FORCE at the end, as required. Drop the 'inputs' phony
> since it is not needed.
Hello! Just one small note. It is quite surprising that
70 matches
Mail list logo
