Re: [PATCH v4] common: avb_verify: prevent opening incorrect session

2023-02-03 Thread Jens Wiklander
On Fri, Jan 27, 2023 at 9:02 PM Ivan Khoronzhuk wrote: > > The arg->session is not valid if arg->ret != NULL, so can't be > assigned, correct this. > > Signed-off-by: Ivan Khoronzhuk > --- > common/avb_verify.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Jens

Re: [PATCH V5 09/12] arm: dts: iot2050: Optionally embed OTP programming data into image

2023-02-03 Thread Jan Kiszka
On 03.02.23 13:37, Lothar Waßmann wrote: > Hi, > > On Fri, 3 Feb 2023 13:26:38 +0100 Jan Kiszka wrote: >> From: Jan Kiszka >> >> Use external blob otpcmd.bin to replace the 0xff filled OTP programming >> command block to create a firmware image that provisions the OTP on >> first boot. This

U-Boot tools and binman build fails in macOS 13

2023-02-03 Thread Alif Ilhan
Hi, I have been trying to build U-Boot’s tools, especially binman in macOS 13 because the new hardware I am working with needs binman. I have python 3.11 installed, compiler is Apple Clang V14.0.0 and XCode is 14.1. Before enabling binman it used to compile, build and run fine. But after

Re: [PATCH 01/14] mtd: nand: brcm: switch to mtd_ooblayout_ops

2023-02-03 Thread Michael Nazzareno Trimarchi
Hi William On Thu, Jan 26, 2023 at 6:39 PM William Zhang wrote: > > > > On 01/26/2023 12:43 AM, Linus Walleij wrote: > > On Thu, Jan 26, 2023 at 2:02 AM William Zhang > > wrote: > > Can you add your review-by? Michael > >> Unfortunately the u-boot nand base code still uses nand_ecclayout >

Re: [PATCH 3/8] blk: blkmap: Add basic infrastructure

2023-02-03 Thread Tobias Waldekranz
On ons, feb 01, 2023 at 13:20, Simon Glass wrote: > Hi Tobias, Hi Simon, Thanks for the review! > On Wed, 1 Feb 2023 at 11:10, Tobias Waldekranz wrote: >> >> blkmaps are loosely modeled on Linux's device mapper subsystem. The >> basic idea is that you can create virtual block devices whose

[PATCH V5 10/12] doc: iot2050: Add a note about the watchdog firmware

2023-02-03 Thread Jan Kiszka
From: Jan Kiszka This is enabled by default, thus should be described as well. Signed-off-by: Jan Kiszka --- doc/board/siemens/iot2050.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/board/siemens/iot2050.rst b/doc/board/siemens/iot2050.rst index cb49a0e36bf..efe94a448a9

[PATCH V5 01/12] board: siemens: iot2050: Split the build for PG1 and PG2

2023-02-03 Thread Jan Kiszka
From: Su Baocheng Due to different signature keys, the PG1 and the PG2 boards can no longer use the same FSBL (tiboot3). This makes it impossible anyway to maintaine a single flash.bin for both variants, so we can also split the build. A new target is added to indicates the build is for PG1 vs.

[PATCH V5 08/12] iot2050: Add script for signing artifacts

2023-02-03 Thread Jan Kiszka
From: Jan Kiszka There are many ways to get a signed firmware for the IOT2050 devices, namely for the parts under user-control. This script documents one way of doing it, given a signing key. Augment the board documentation with the required procedure around it. Signed-off-by: Jan Kiszka ---

[PATCH V5 03/12] iot2050: Update firmware layout

2023-02-03 Thread Jan Kiszka
From: Jan Kiszka The latest version of the binary-only firmware parts come in a combined form of FSBL and sysfw containers. This implies some layout changes to the generated firmware image but also makes handling of artifacts much simpler (4 files less). The env locations will not change, just

[PATCH V5 06/12] arm: dts: iot2050: Allow verifying U-Boot proper by SPL

2023-02-03 Thread Jan Kiszka
From: Jan Kiszka Add hashes and configuration signature stubs to prepare verified boot of main U-Boot by SPL. Signed-off-by: Jan Kiszka --- arch/arm/dts/k3-am65-iot2050-boot-image.dtsi | 16 1 file changed, 16 insertions(+) diff --git

[PATCH v3 00/16] General Tegra improvements

2023-02-03 Thread Svyatoslav Ryhel
List of changes in patch set: - add missing EXTPERIPH clocks for t30 - swap host1x and disp1 clock parents (as they should be) - add clk_id_to_pll_id and clock_decode_pair helpers to use dts deeper (in tegra clocks often go in pair child - parent) - include PLLD setup in T30 (DISP1 may use

[PATCH v3 02/16] ARM: t20/t30: swap host1x and disp1 clock parents

2023-02-03 Thread Svyatoslav Ryhel
According to mainline clock tables and TRM HOST1X parent is PLLC, while DISP1 usually uses PLLP as parent clock. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav Ryhel ---

[PATCH v3 15/16] ARM: tegra30: implement BCT patching

2023-02-03 Thread Svyatoslav Ryhel
From: Ramin Khonsari This function allows updating bootloader from u-boot on production devices without need in host PC. Be aware! It works only with re-crypted BCT. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Ramin Khonsari

[PATCH v3 11/16] board: tegra124: switch to updated pre-dm i2c write

2023-02-03 Thread Svyatoslav Ryhel
Configure PMIC for early stages using updated i2c write. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Simon Glass --- board/nvidia/venice2/as3722_init.c | 65 board/nvidia/venice2/as3722_init.h | 43 - board/toradex/apalis-tk1/as3722_init.c | 85

[PATCH v3 10/16] ARM: tegra: create common pre-dm i2c write

2023-02-03 Thread Svyatoslav Ryhel
This implementation allows pwr i2c writing on early SPL stages when DM is not yet setup. Such writing is needed to configure main voltages of PMIC on early SPL for bootloader to boot properly. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20

[PATCH v3 12/16] board: tegra30: switch to updated pre-dm i2c write

2023-02-03 Thread Svyatoslav Ryhel
Configure PMIC voltages for early stages using updated early i2c write. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Simon Glass --- arch/arm/mach-tegra/tegra30/Kconfig | 8 arch/arm/mach-tegra/tegra30/cpu.c | 36 - board/avionic-design/tec-ng/Makefile

[PATCH v3 16/16] ARM: tegra20: implement BCT patching

2023-02-03 Thread Svyatoslav Ryhel
This function allows updating bootloader from u-boot on production devices without need in host PC. Be aware! It works only with re-crypt BCT. Tested-by: Robert Eckelmann # ASUS TF101 T20 Signed-off-by: Ramin Khonsari Signed-off-by: Svyatoslav Ryhel --- arch/arm/mach-tegra/Kconfig |

[PATCH v3 13/16] ARM: tegra: expose crypto module for all Tegra SoCs

2023-02-03 Thread Svyatoslav Ryhel
Move crypto module from T20 only into common Tegra dir. Signed-off-by: Svyatoslav Ryhel --- arch/arm/mach-tegra/Kconfig| 5 + arch/arm/mach-tegra/Makefile | 1 + arch/arm/mach-tegra/{tegra20 => }/crypto.c | 0 arch/arm/mach-tegra/{tegra20 => }/crypto.h | 0

[PATCH] imx: spl_imx_romapi: Get and print boot stage

2023-02-03 Thread Ye Li
Get and print boot stage through ROM API in SPL Signed-off-by: Ye Li Reviewed-by: Peng Fan --- arch/arm/include/asm/mach-imx/sys_proto.h | 7 +++ arch/arm/mach-imx/spl_imx_romapi.c| 22 +- 2 files changed, 28 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 01/14] mtd: nand: brcm: switch to mtd_ooblayout_ops

2023-02-03 Thread Linus Walleij
On Fri, Feb 3, 2023 at 9:48 AM Michael Nazzareno Trimarchi wrote: > On Thu, Jan 26, 2023 at 6:39 PM William Zhang > wrote: > > > > > > > > On 01/26/2023 12:43 AM, Linus Walleij wrote: > > > On Thu, Jan 26, 2023 at 2:02 AM William Zhang > > > wrote: > > > > > Can you add your review-by? I think

[PATCH V5 00/12] IOT2050-related enhancements

2023-02-03 Thread Jan Kiszka
(Almost) flushing our upstream queue for the IOT2050 device, this mostly brings board-specific changes such as: - updated build process and firmware layout for PG1 vs. PG2 devices - more watchdog preparations - preparations for verified boot on IOT2050 Advanced devices This series depends on

[PATCH V5 02/12] arm: dts: iot2050: Use the auto generator nodes for fdt

2023-02-03 Thread Jan Kiszka
From: Su Baocheng Refactor according to the entry `fit: Entry containing a FIT` of document tools/binman/README.entries. As the generator uses the device tree name for the config description, board_fit_config_name_match requires a small adjustment as well. Signed-off-by: Su Baocheng [Jan:

[PATCH V5 05/12] iot2050: Add CONFIG_ENV_FLAGS_LIST_STATIC

2023-02-03 Thread Jan Kiszka
From: Jan Kiszka Will be needed when CONFIG_ENV_WRITEABLE_LIST is enabled. The listed variables shall remain writable, for informational purposes - they have to be considered untrusted because the persistent U-Boot env is not protected. Signed-off-by: Jan Kiszka --- include/configs/iot2050.h

[PATCH V5 04/12] iot2050: Add watchdog start to bootcmd

2023-02-03 Thread Jan Kiszka
From: Jan Kiszka Allows run-time control over watchdog auto-start and the timeout via setting the environment variable watchdog_timeout_ms. A value of zero means "do not start". Use CONFIG_WATCHDOG_TIMEOUT_MSECS as initial value and this to zero by default. Users can then enable the watchdog

[PATCH v3 09/16] ARM: tegra: add late init support

2023-02-03 Thread Svyatoslav Ryhel
Late init function allows passing values like identifiers and perform device specific configurations of pre-boot stage. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/sys_proto.h |

[PATCH v3 08/16] ARM: tegra: provide default USB gadget setup

2023-02-03 Thread Svyatoslav Ryhel
From: Maxim Schwalm All Nvidia boards use the same manufacturer, vendor ID and product ID for the gadgets. Make them the defaults to remove some boilerplate from the defconfigs. Inspired by commit e02687bda96c ("sunxi: provide default USB gadget setup") which did the same for Allwinner boards.

[PATCH v3 06/16] ARM: tegra: Fix Tegra PWM parent clock

2023-02-03 Thread Svyatoslav Ryhel
Default parent clock for the PWM on Tegra is a 32kHz clock and is unable to support the requested PWM period. Fix PWM support on Tegra20, Tegra30, Tegra114, Tegra124 and Tegra210 by updating the parent clock for the PWM to be the PLL_P. This commit is equivalent to Linux kernel commit:

[PATCH 1/2] env: Complete generic support for writable list

2023-02-03 Thread Jan Kiszka
From: Jan Kiszka This completes what 890feecaab72 started by selecting ENV_APPEND and loading the default env before any other sources. This ensures that load operations pick up all non-writable vars from the default env and only permitted parts from other locations according to the regular

[PATCH 2/2] env: Couple networking-related variable flags to CONFIG_NET

2023-02-03 Thread Jan Kiszka
From: Jan Kiszka Boards may set networking variables programmatically, thus may have CONFIG_NET on but CONFIG_CMD_NET off. The IOT2050 is an example. CC: Joe Hershberger Signed-off-by: Jan Kiszka --- env/flags.c | 10 +- include/env_flags.h | 4 ++-- 2 files changed, 7

[PATCH] power: pmic: Add NXP PCA9451A PMIC support

2023-02-03 Thread Ye Li
PCA9451A uses similar BUCKs and LDO regulators as PCA9450B/C but has LDO2 and LDO3 removed. So reuse pca9450 PMIC and regulator driver and add new type for PCA9451A. Signed-off-by: Ye Li --- drivers/power/pmic/pca9450.c | 1 + drivers/power/regulator/pca9450.c | 11 ++-

[PATCH v2] imx8m: Select BINMAN via SoC level

2023-02-03 Thread Fabio Estevam
Since all imx8m boards have been converted to use binman, select binman via SoC level rather than making the selection for each board. Signed-off-by: Fabio Estevam Reviewed-by: Peng Fan --- Changes since v1: - Rebased against u-boot-imx tree. - Collected Peng Fan's Reviewed-by tag.

Re: [PATCH] ARM: dts: imx: Add support for Data Modul i.MX8M Plus eDM SBC

2023-02-03 Thread Stefano Babic
Hi Marek, On 18.12.22 05:35, Marek Vasut wrote: Add support for Data Modul i.MX8M Plus eDM SBC board. This is an evaluation board for various custom display units. Currently supported are serial console, ethernet, eMMC, SD, SPI NOR, USB. Some CONFIG_ were converted in Kbuild. They raise an

[PATCH v3 14/16] ARM: tegra: crypto: extend crypto functional

2023-02-03 Thread Svyatoslav Ryhel
Add support for encryption, decryption and signinig with non-zero key saving backward compatibility. Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/crypto.h | 47 ++ arch/arm/mach-tegra/crypto.c | 63 +---

[PATCH 0/2] env: Enhancements for establishing variable protection

2023-02-03 Thread Jan Kiszka
This was factored out of [1] upon request in the hope of easing the merge. Jan [1] https://lore.kernel.org/u-boot/cover.1675325279.git.jan.kis...@siemens.com CC: Joe Hershberger CC: Marek Vasut CC: Stefan Herbrechtsmeier Jan Kiszka (2): env: Complete generic support for writable list

[PATCH V5 09/12] arm: dts: iot2050: Optionally embed OTP programming data into image

2023-02-03 Thread Jan Kiszka
From: Jan Kiszka Use external blob otpcmd.bin to replace the 0xff filled OTP programming command block to create a firmware image that provisions the OTP on first boot. This otpcmd.bin is generated from the customer keys using steps described in the meta-iot2050 integration layer for the device.

[PATCH V5 07/12] tools: Add script for converting public key into device tree include

2023-02-03 Thread Jan Kiszka
From: Jan Kiszka Allows to create a public key device tree dtsi for inclusion into U-Boot SPL and proper during first build already. This can be achieved via CONFIG_DEVICE_TREE_INCLUDES. Signed-off-by: Jan Kiszka --- tools/key2dtsi.py | 64 +++ 1

[PATCH V5 11/12] board: siemens: iot2050: use the named gpio to control the user-button

2023-02-03 Thread Jan Kiszka
From: chao zeng User-button is controlled by the mcu domain gpio number 25. But main0 main1 mcu domain all have gpio number 25. To identify where the gpio is from, Using gpio controll base as the prefix to indicate the gpio resource. Signed-off-by: chao zeng --- board/siemens/iot2050/board.c

[PATCH V5 12/12] iot2050: Refresh defconfigs and activate CONFIG_EFI_SCROLL_ON_CLEAR_SCREEN

2023-02-03 Thread Jan Kiszka
From: Jan Kiszka This feature is desired on the platform. Signed-off-by: Jan Kiszka --- configs/iot2050_pg1_defconfig | 6 +++--- configs/iot2050_pg2_defconfig | 7 +++ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/configs/iot2050_pg1_defconfig

Re: [PATCH V5 09/12] arm: dts: iot2050: Optionally embed OTP programming data into image

2023-02-03 Thread Lothar Waßmann
Hi, On Fri, 3 Feb 2023 13:26:38 +0100 Jan Kiszka wrote: > From: Jan Kiszka > > Use external blob otpcmd.bin to replace the 0xff filled OTP programming > command block to create a firmware image that provisions the OTP on > first boot. This otpcmd.bin is generated from the customer keys using >

Re: [PATCH] arm64: zynqmp: Add missing ZYNQMP_FIRMWARE dependencies

2023-02-03 Thread Michal Simek
On 2/1/23 10:55, Ashok Reddy Soma wrote: From: Algapally Santosh Sagar There are missing Kconfig dependencies in the code which is using firmware interface. The commit 71efd45a5fc7 ("arm64: zynqmp: Change firmware dependency") add option to also disable ZYNQMP_FIRMWARE. But not all Kconfig

[PATCH v3 05/16] ARM: tegra30: add PLLD to pll setup

2023-02-03 Thread Svyatoslav Ryhel
On T30 unlike T20 dsi panels are wider used on devices and PLLD is used as DISP1 parent more often, so lets enable it as well for this cases. Tested-by: Andreas Westman Dorcsak # ASUS TF700T T30 Tested-by: Svyatoslav Ryhel # HTC One X T30 Signed-off-by: Svyatoslav Ryhel ---

[PATCH v3 01/16] tegra30: clock: add EXTPERIPH

2023-02-03 Thread Svyatoslav Ryhel
This mappings were missing for some reason. Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav Ryhel Reviewed-by: Simon Glass --- arch/arm/include/asm/arch-tegra30/clock-tables.h | 6 +++--- arch/arm/mach-tegra/tegra30/clock.c | 6 +++--- 2 files changed, 6

[PATCH v3 07/16] spi: tegra20_slink: accept any word length

2023-02-03 Thread Svyatoslav Ryhel
Original t20 slink could work with commands only fully divisible by 8. This patch removes such restriction, so commands of any bitlength now can be passed and processed. Tested-by: Andreas Westman Dorcsak # ASUS TF600T T30 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav

[PATCH v3 03/16] ARM: tegra: clock: add clk_id_to_pll_id helper

2023-02-03 Thread Svyatoslav Ryhel
This function allows to convert a device tree clock ID to PLL ID. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20 Tested-by: Svyatoslav Ryhel # HTC One X Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/clock.h | 8 ++

[PATCH v3 04/16] ARM: tegra: clock: add clock_decode_pair helper

2023-02-03 Thread Svyatoslav Ryhel
Get periph clock id and its parent from device tree. This works by looking up the peripheral's 'clocks' node and reading out the second and fourth cells, which are the peripheral and PLL clock numbers. Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/clock.h | 13

Re: [PATCH] imx8m: Select BINMAN via SoC level

2023-02-03 Thread Stefano Babic
Hi Fabio, On 25.10.22 16:32, Fabio Estevam wrote: From: Fabio Estevam Since all imx8m boards have been converted to use binman, select binman via SoC level rather than making the selection for each board. Everything correct, but patch is now obsolete and should be reworked / rebased. I

Re: [PATCH v4] mtd: parsers: ofpart: add workaround for #size-cells 0

2023-02-03 Thread Francesco Dolcini
Il 3 febbraio 2023 16:12:02 CET, Miquel Raynal ha scritto: >Hi Francesco, > >france...@dolcini.it wrote on Thu, 2 Feb 2023 12:33:34 +0100: > >> On Thu, Jan 26, 2023 at 10:12:04AM +0100, Miquel Raynal wrote: >> > gre...@linuxfoundation.org wrote on Thu, 26 Jan 2023 10:01:02 +0100: >> > >> >

Re: [PATCH v3 00/16] General Tegra improvements

2023-02-03 Thread Svyatoslav Ryhel
Thanks! I will shrink mailing list in the next iteration. Thierry, may you check if these patches do not break anything on your boards. I have tested them on my devices (T20 and T30) without any issues. I am especially interested in T124 pre-dm i2c changes, iirc you have a board I have changed.

Pull request: u-boot-imx u-boot-imx-20230203

2023-02-03 Thread Stefano Babic
) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git tags/u-boot-imx-20230203 for you to fetch changes up to 01f372d8d62b885f4a20a45535c545e98aafa687: udoo_neo: Select DM_SERIAL and drop iomux board level init (2023-02-03 13:10:01 +0100

Re: [PATCH v4] mtd: parsers: ofpart: add workaround for #size-cells 0

2023-02-03 Thread Miquel Raynal
Hi Francesco, france...@dolcini.it wrote on Thu, 2 Feb 2023 12:33:34 +0100: > On Thu, Jan 26, 2023 at 10:12:04AM +0100, Miquel Raynal wrote: > > gre...@linuxfoundation.org wrote on Thu, 26 Jan 2023 10:01:02 +0100: > > > > > On Wed, Jan 25, 2023 at 10:06:57PM +0100, Francesco Dolcini wrote:

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-03 Thread Tom Rini
On Thu, Feb 02, 2023 at 07:15:35PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 2 Feb 2023 at 10:22, Tom Rini wrote: > > > > On Thu, Feb 02, 2023 at 10:12:07AM -0700, Simon Glass wrote: > > > Hi, > > > > > > On Thu, 2 Feb 2023 at 01:17, Etienne Carriere > > > wrote: > > > > > > > > Hello

Re: [PATCH 01/14] mtd: nand: brcm: switch to mtd_ooblayout_ops

2023-02-03 Thread William Zhang
Hi Linus and Michael, On 02/03/2023 03:10 AM, Linus Walleij wrote: On Fri, Feb 3, 2023 at 9:48 AM Michael Nazzareno Trimarchi wrote: On Thu, Jan 26, 2023 at 6:39 PM William Zhang wrote: On 01/26/2023 12:43 AM, Linus Walleij wrote: On Thu, Jan 26, 2023 at 2:02 AM William Zhang wrote:

Re: [PATCH v2] riscv: cancel the limitation that NR_CPUS is less than or equal to 32

2023-02-03 Thread David Abdurachmanov
On Mon, Jan 3, 2022 at 1:13 PM Leo Liang wrote: > > On Thu, Dec 30, 2021 at 01:55:15AM +0800, Xiang W wrote: > > 在 2021-12-29星期三的 17:23 +0800,Leo Liang写道: > > > Hi Xiang, > > > On Wed, Dec 22, 2021 at 07:32:53AM +0800, Xiang W wrote: > > > > Various specifications of riscv allow the number of

[PATCH v2 2/2] udoo_neo: Select DM_SERIAL and drop iomux board level init

2023-02-03 Thread sbabic
> Convert to DM_SERIAL and drop the iomux board file > level init as it's handled as part of the DM serial > layer instead. > Signed-off-by: Peter Robinson > Reviewed-by: Fabio Estevam Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic --

[PATCH] ARM: imx: mx5: Convert MX53 Menlo board to DM SERIAL

2023-02-03 Thread sbabic
> Convert the board from legacy serial code to DM SERIAL. > Signed-off-by: Marek Vasut Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH,Managing Director: Erika

[PATCH v2 1/2] udoo_neo: Move to DM for REGULATOR/PMIC/I2C drivers

2023-02-03 Thread sbabic
> This moves over the PMIC power init to DM and the associated i2c and > regulator bits. > Signed-off-by: Peter Robinson > Reviewed-by: Fabio Estevam Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

RE: [PATCH v3 00/16] General Tegra improvements

2023-02-03 Thread Tom Warren
I've applied these (v3) to TOT u-boot-tegra/master OK, and 'buildman tegra' is OK. I don't have the HW to test all of these combos (T20, T30, T114, T124) - they're mothballed in favor of my current work on T210/T186/T194/T234 (the last two w/no U-Boot). So I'd appreciate any 'Tested-by's from

Re: [PATCH V5 05/12] iot2050: Add CONFIG_ENV_FLAGS_LIST_STATIC

2023-02-03 Thread Tom Rini
On Fri, Feb 03, 2023 at 01:26:34PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Will be needed when CONFIG_ENV_WRITEABLE_LIST is enabled. The listed > variables shall remain writable, for informational purposes - they have > to be considered untrusted because the persistent U-Boot env is not

Re: [PATCH u-boot 3/3] tools: imagetool: Skip autodetection of gpimage type

2023-02-03 Thread Pali Rohár
On Monday 30 January 2023 13:02:42 Tom Rini wrote: > On Mon, Jan 30, 2023 at 08:50:15AM -0700, Simon Glass wrote: > > On Sun, 29 Jan 2023 at 09:46, Pali Rohár wrote: > > > > > > gpimage type requires only that two first 32-bit words of data file are > > > non-zero. So basically every random data

Re: [PATCH 1/2] net: dhcp6: Add DHCPv6 (DHCP for IPv6)

2023-02-03 Thread Tom Rini
On Thu, Feb 02, 2023 at 10:12:04AM -0700, Simon Glass wrote: > Hi, > > On Wed, 1 Feb 2023 at 17:26, wrote: > > > > From: Sean Edmond > > > > Adds DHCPv6 protocol to u-boot. > > > > Allows for address assignement with DHCPv6 4-message exchange > > (SOLICIT->ADVERTISE->REQUEST->REPLY). Includes

[PATCH v3 1/3] net: ftmac100: change driver name from nds32_mac to ftmac100

2023-02-03 Thread Sergei Antonov
So it will be named similarly to the related ftgmac100 driver. The old name 'nds32_mac' is not referred to anywhere in U-Boot. Signed-off-by: Sergei Antonov Reviewed-by: Ramon Fried --- v2 -> v3: no change v1 -> v2: no change drivers/net/ftmac100.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3 2/3] net: ftmac100: simplify priv->iobase casting

2023-02-03 Thread Sergei Antonov
Replace 'phys_addr_t iobase' with 'struct ftmac100 *ftmac100' in struct ftmac100_data. It allows to remove casting in a number of places. Since priv->iobase is phys_addr_t, use phys_to_virt() to make a pointer from it. Signed-off-by: Sergei Antonov --- v2 -> v3: Fix the following warning by

[PATCH v3 3/3] net: ftmac100: add mii read and write callbacks

2023-02-03 Thread Sergei Antonov
Register mii_bus with read and write callbacks to allow the 'mii' command to work. Use a timeout of 10 ms to wait for the R/W operations to complete. Signed-off-by: Sergei Antonov --- v2 -> v3: no change v1 -> v2: * fix a typo in the description * add a dependency from MII to Kconfig

Re: [PATCH v4] mtd: parsers: ofpart: add workaround for #size-cells 0

2023-02-03 Thread Miquel Raynal
Hi Francesco, france...@dolcini.it wrote on Fri, 03 Feb 2023 19:03:27 +0100: > Il 3 febbraio 2023 16:12:02 CET, Miquel Raynal ha > scritto: > >Hi Francesco, > > > >france...@dolcini.it wrote on Thu, 2 Feb 2023 12:33:34 +0100: > > > >> On Thu, Jan 26, 2023 at 10:12:04AM +0100, Miquel Raynal

Re: [PATCH 2/2] env: Couple networking-related variable flags to CONFIG_NET

2023-02-03 Thread Tom Rini
On Fri, Feb 03, 2023 at 01:22:52PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Boards may set networking variables programmatically, thus may have > CONFIG_NET on but CONFIG_CMD_NET off. The IOT2050 is an example. > > CC: Joe Hershberger > Signed-off-by: Jan Kiszka Reviewed-by: Tom Rini

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-03 Thread Tony Dinh
Hi Pali, On Fri, Feb 3, 2023 at 2:05 PM Pali Rohár wrote: > > On Thursday 02 February 2023 19:04:45 Pali Rohár wrote: > > On Wednesday 01 February 2023 13:13:16 Tony Dinh wrote: > > > Hi all, > > > > > > On Wed, Feb 1, 2023 at 11:05 AM Pali Rohár wrote: > > > > > > > > On Wednesday 01 February

Re: [PATCH v2 2/3] net: ftmac100: simplify priv->iobase casting

2023-02-03 Thread Sergei Antonov
On Fri, 3 Feb 2023 at 01:05, Tom Rini wrote: > > On Thu, Jan 19, 2023 at 10:51:15PM +0300, Sergei Antonov wrote: > > > Replace 'phys_addr_t iobase' with 'struct ftmac100 *ftmac100' > > in order to cast once on assignment and remove casting in a > > number of other places. > > > > Signed-off-by:

Re: [PATCH u-boot 3/3] tools: imagetool: Skip autodetection of gpimage type

2023-02-03 Thread Tom Rini
On Fri, Feb 03, 2023 at 08:24:20PM +0100, Pali Rohár wrote: > On Monday 30 January 2023 13:02:42 Tom Rini wrote: > > On Mon, Jan 30, 2023 at 08:50:15AM -0700, Simon Glass wrote: > > > On Sun, 29 Jan 2023 at 09:46, Pali Rohár wrote: > > > > > > > > gpimage type requires only that two first 32-bit

Re: [PATCH] net: ipv6: fix alignment errors on ARM

2023-02-03 Thread Tom Rini
On Wed, Jan 18, 2023 at 08:52:18PM +0300, Sergei Antonov wrote: > Commands "ping6" and "tftpboot ... -ipv6" did not work on ARM because > machine code expects 4-byte alignment and some structures from net6.h > are not aligned in memory. > > Fix by adding __packed, since it is already used in

Re: [PATCH] net: ipv6: Fix IPv6 netmask parsing

2023-02-03 Thread Tom Rini
On Fri, Jan 06, 2023 at 02:22:55PM -0800, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > It should be possible to specify a netmask when > setting a static IPv6 address. For example: > setenv ip6addr 2001:cafe:cafe:cafe::100/64 > > The net_prefix_length and net_ip6 should be

Re: [PATCH] net: ipv6: Fixed IPv6 string to address conversion off-by-one error

2023-02-03 Thread Tom Rini
On Fri, Jan 13, 2023 at 09:27:41AM -0800, emohand...@linux.microsoft.com wrote: > From: Ehsan Mohandesi > > One extra character was being checked in the IPv6 string which caused the > last character of the address to be neither '\0' nor ':'. This raises an > error condition and causes the

Re: [PATCH] net: tftp: Fix for DATA ACK for block count out of order

2023-02-03 Thread Tom Rini
On Wed, Jan 04, 2023 at 06:16:26PM -0800, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > In rfc7440, if an ACK is not received by the server or if the > last data block in a window is dropped, the server will timeout and > retransmit the window. In this case, the block count

Re: [PATCH v9 1/8] net: mdio-uclass: scan for dm mdio children on post-bind

2023-02-03 Thread Tom Rini
On Wed, Nov 30, 2022 at 09:42:44AM -0800, Tim Harvey wrote: > If a DM_MDIO driver is used we need to scan the subnodes as well. > > Signed-off-by: Tim Harvey > Signed-off-by: Vladimir Oltean > Reviewed-by: Ramon Fried > Reviewed-by: Fabio Estevam For the series, applied to u-boot/master,

Re: [PATCH v4] mtd: parsers: ofpart: add workaround for #size-cells 0

2023-02-03 Thread Francesco Dolcini
Il 3 febbraio 2023 19:16:23 CET, Miquel Raynal ha scritto: >Hi Francesco, > >france...@dolcini.it wrote on Fri, 03 Feb 2023 19:03:27 +0100: > >> Il 3 febbraio 2023 16:12:02 CET, Miquel Raynal >> ha scritto: >> >Hi Francesco, >> > >> >france...@dolcini.it wrote on Thu, 2 Feb 2023 12:33:34

Re: Pull request: u-boot-imx u-boot-imx-20230203

2023-02-03 Thread Tom Rini
it 'refs/pipelines/15015' of > https://source.denx.de/u-boot/custodians/u-boot-tegra (2023-02-02 12:44:12 > -0500) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git > tags/u-boot-imx-20230203 > > for you to fetch cha

Re: [PATCH] drivers: net: fsl_ls_mdio: prevent a NULL pointer dereference

2023-02-03 Thread Tom Rini
On Thu, Jan 05, 2023 at 05:09:48PM +0200, Ioana Ciornei wrote: > Prevent a NULL pointer dereference in the probe path by checking the > return valud of dev_read_addr_ptr() against NULL. > > Signed-off-by: Ioana Ciornei > Reviewed-by: Ramon Fried Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 1/7] drivers: net: fsl-mc: remove useless assignment of variable

2023-02-03 Thread Tom Rini
On Thu, Jan 05, 2023 at 05:03:15PM +0200, Ioana Ciornei wrote: > The cur_ptr variable is set to the start of the log buffer but then it's > not used. Just remove the assignment altogether. > > Signed-off-by: Ioana Ciornei > Reviewed-by: Ramon Fried For the series, and except for 4/7 which

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-03 Thread Tony Dinh
Hi Stefan, On Thu, Feb 2, 2023 at 8:28 PM Tony Dinh wrote: > > Hi all, > > On Thu, Feb 2, 2023 at 3:59 PM Tony Dinh wrote: > > > > Hi all, > > > > On Thu, Feb 2, 2023 at 10:04 AM Pali Rohár wrote: > > > > > > On Wednesday 01 February 2023 13:13:16 Tony Dinh wrote: > > > > Hi all, > > > > > > >

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-03 Thread Pali Rohár
On Thursday 02 February 2023 19:04:45 Pali Rohár wrote: > On Wednesday 01 February 2023 13:13:16 Tony Dinh wrote: > > Hi all, > > > > On Wed, Feb 1, 2023 at 11:05 AM Pali Rohár wrote: > > > > > > On Wednesday 01 February 2023 09:17:15 Michael Walle wrote: > > > > > > > When DM_SERIAL is enabled,

Re: [PATCH V5 04/12] iot2050: Add watchdog start to bootcmd

2023-02-03 Thread Tom Rini
On Fri, Feb 03, 2023 at 01:26:33PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Allows run-time control over watchdog auto-start and the timeout via > setting the environment variable watchdog_timeout_ms. A value of zero > means "do not start". Use CONFIG_WATCHDOG_TIMEOUT_MSECS as initial

Re: [PATCH V5 08/12] iot2050: Add script for signing artifacts

2023-02-03 Thread Tom Rini
On Fri, Feb 03, 2023 at 01:26:37PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > There are many ways to get a signed firmware for the IOT2050 devices, > namely for the parts under user-control. This script documents one way > of doing it, given a signing key. Augment the board documentation

[PATCH] schemas: Add schema for firmware logs

2023-02-03 Thread Simon Glass
A common way to detect problems in firmware is to collect logs from the firmware, then pass them to the OS for storage and analysis. Logs can take the form of simple text output, or structured logs where the filename and line number, etc. are provided. Timestamps can sometimes be useful, too.

[RFC PATCH v2 08/56] boot: Add a Kconfig for SPL_UT_COMPRESSION

2023-02-03 Thread Simon Glass
This is implicitly used in the source and seems useful, so add it. Signed-off-by: Simon Glass --- (no changes since v1) test/Kconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/test/Kconfig b/test/Kconfig index 465028265b2..944d4eb1560 100644 --- a/test/Kconfig +++ b/test/Kconfig

[RFC PATCH v2 04/56] bootstd: Add Kconfig options for SPL

2023-02-03 Thread Simon Glass
Create new SPL options so that standard boot can be excluded for SPL. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 24 1 file changed, 24 insertions(+) diff --git a/boot/Kconfig b/boot/Kconfig index dcfbe6ae9e0..81a3dba399a 100644 ---

[RFC PATCH v2 03/56] event: Add Kconfig options for SPL

2023-02-03 Thread Simon Glass
Add options to enable events in SPL. This is mostly so the code can be excluded from SPL builds. Signed-off-by: Simon Glass --- (no changes since v1) common/Kconfig | 16 1 file changed, 16 insertions(+) diff --git a/common/Kconfig b/common/Kconfig index

[RFC PATCH v2 05/56] cmd: Add an SPL Kconfig for CMDLINE and HUSH

2023-02-03 Thread Simon Glass
At present we rely on this not existing to avoid building various command-line features. But with the new split configs this does not work. Add separates Kconfigs instead. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff

[RFC PATCH v2 07/56] cros_ec: Add SPL Kconfigs for cros_ec features

2023-02-03 Thread Simon Glass
At present we rely on this not existing to avoid building various EC features. But with the new split configs this does not work. Add separates Kconfigs instead. Signed-off-by: Simon Glass --- (no changes since v1) drivers/i2c/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff

[RFC PATCH v2 06/56] boot: Add a Kconfig for SPL_QCOM_PMIC_GPIO

2023-02-03 Thread Simon Glass
This is implicitly used in the source and seems useful, so add it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/gpio/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 365615a53f7..8a4787f4195 100644 ---

[RFC PATCH v2 14/56] lib: Fix build condition for tiny-printf

2023-02-03 Thread Simon Glass
This should be checking for any SPL build. Drop the use of SPL_TPL_ since it is not necessary and will not work with split config. Signed-off-by: Simon Glass --- (no changes since v1) lib/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile b/lib/Makefile

Re: [PATCH 3/8] blk: blkmap: Add basic infrastructure

2023-02-03 Thread Simon Glass
Hi Tobias, On Fri, 3 Feb 2023 at 02:38, Tobias Waldekranz wrote: > > On ons, feb 01, 2023 at 13:20, Simon Glass wrote: > > Hi Tobias, > > Hi Simon, > > Thanks for the review! > > > On Wed, 1 Feb 2023 at 11:10, Tobias Waldekranz > > wrote: > >> > >> blkmaps are loosely modeled on Linux's

[RFC PATCH v2 01/56] moveconfig: Various minor improvements

2023-02-03 Thread Simon Glass
It turns out that the conf_noproper file is not neeed, since if an option does not appear in U-Boot proper we can just omit it from the autoconf for that build. Drop it. Also add more control over what is output from the tool. Add this in here. It should be added to the previous series (splb).

[RFC PATCH v2 02/56] sandbox: Expand size for VPL image

2023-02-03 Thread Simon Glass
Allow this to get larger to accommodate more test code with LTO disabled. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/dts/sandbox_vpl.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/sandbox/dts/sandbox_vpl.dtsi

[RFC PATCH v2 26/56] kconfig: Support writing separate SPL files

2023-02-03 Thread Simon Glass
At present kconfig writes out several files, including: auto.conf - CONFIG settings used by make autoconf.h - header file used by C code This works well but is a bit ugly in places, for example requiring the use of a SPL_TPL_ macro in Makefiles to distinguish between options intended for

[RFC PATCH v2 29/56] Add VPL options for BLOBLIST

2023-02-03 Thread Simon Glass
We can use this feature in VPL, so add some options for it. Also fix a typo in the SPL help while we are here. Signed-off-by: Simon Glass --- (no changes since v1) common/Kconfig | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/common/Kconfig

[RFC PATCH v2 24/56] kconfig: Add a configuration file for nospl

2023-02-03 Thread Simon Glass
This file indicates which options are not for use in U-Boot SPL. It allows the kconfig tool to correctly generate its output. It was generated with ./tools/move_config.py --scan-source -u Note that this only produces sensible results when used with the current source code, as of this patch.

[RFC PATCH v2 31/56] freescale: pm9g45: Fix problems with ls1021aqds_nand et al

2023-02-03 Thread Simon Glass
These boards need to access the 'proper' symbol for NAND_BOOT, to avoid build errors in SPL. Fix this up. Also fix pm9g45 which has the same problem. Drop the unnecessary condition in fdt_support.h to avoid needing to do something clever there too. Signed-off-by: Simon Glass --- (no changes

[RFC PATCH v2 22/56] lib: Add an SPL config for LIB_UUID

2023-02-03 Thread Simon Glass
This is selected by PARTITION_UUIDS which has a separate option for SPL. Add an SPL option for LIB_UUID also, so that we can keep them consistent. Also add one for PARTITION_TYPE_GUID to avoid a build error in part_efi.c which wants to call a uuid function in SPL. Signed-off-by: Simon Glass ---

[RFC PATCH v2 13/56] x86: Use string functions for all 32-bit builds

2023-02-03 Thread Simon Glass
At present these are not included in SPL. They do add to code size but are a bit faster, so adjust the setting to add them. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/include/asm/string.h | 2 +- arch/x86/lib/Makefile | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH V5 04/12] iot2050: Add watchdog start to bootcmd

2023-02-03 Thread Jan Kiszka
On 03.02.23 19:51, Tom Rini wrote: > On Fri, Feb 03, 2023 at 01:26:33PM +0100, Jan Kiszka wrote: > >> From: Jan Kiszka >> >> Allows run-time control over watchdog auto-start and the timeout via >> setting the environment variable watchdog_timeout_ms. A value of zero >> means "do not start". Use

Re: [PATCH V5 05/12] iot2050: Add CONFIG_ENV_FLAGS_LIST_STATIC

2023-02-03 Thread Jan Kiszka
On 03.02.23 19:52, Tom Rini wrote: > On Fri, Feb 03, 2023 at 01:26:34PM +0100, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Will be needed when CONFIG_ENV_WRITEABLE_LIST is enabled. The listed >> variables shall remain writable, for informational purposes - they have >> to be considered untrusted

  1   2   >