Re: [PATCH v2 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-07 Thread Pali Rohár
Hello! See few comments below. On Wednesday 08 March 2023 13:48:31 Minda Chen wrote: > From: Mason Huo > > Add pcie driver for StarFive JH7110, the driver depends on > starfive gpio, pinctrl, clk and reset driver to do init. > > Several devices are tested: > a) M.2 NVMe SSD > b) Realtek 8169

[PATCH v8 09/10] video console: sandbox: add 12x22 font defconfigs

2023-03-07 Thread Dzmitry Sankouski
Add 12x22 font in order to write a test for it. Signed-off-by: Dzmitry Sankouski Reviewed-by: Simon Glass --- Changes in v8: - add 12X22 font in sandbox_flattree_defconfig for tests Changes in v7: none Changes in v6: N/A Changes in v5: N/A Changes in v4: N/A Changes in v3: N/A Changes in

[PATCH v3] pinctrl: rockchip: support rk3588 pinctrl

2023-03-07 Thread Eugen Hristev
From: Jianqun Xu Add support for Rockchip rk3588 variant of pinctrl. The driver is adapted from the Linux driver. Signed-off-by: Jianqun Xu [eugen.hris...@collabora.com: port to latest U-boot, bring more changes from Linux] Signed-off-by: Eugen Hristev --- Changes in v3: - change assert(i)

[PATCH v1] clk: nuvoton: add read only feature for clk driver

2023-03-07 Thread Jim Liu
Set ahb/apb/fiu clock divider as read-only Signed-off-by: Jim Liu --- drivers/clk/nuvoton/clk_npcm.c| 15 --- drivers/clk/nuvoton/clk_npcm.h| 1 + drivers/clk/nuvoton/clk_npcm8xx.c | 12 ++-- 3 files changed, 19 insertions(+), 9 deletions(-) diff --git

[PATCH 0/2] ARM: meson: Add initial support for BPI-CM4 module with BPI-CM4IO baseboard

2023-03-07 Thread Neil Armstrong
| 1 + 7 files changed, 646 insertions(+) --- base-commit: b08ffdffdce95e267e782366f4a77bf6b5537b28 change-id: 20230307-u-boot-cm4-1311815d8371 Best regards, -- Neil Armstrong

[PATCH 1/2] ARM: dts: import initial DT for BPI-CM4 module with BPI-CM4IO baseboard

2023-03-07 Thread Neil Armstrong
Import initial support for BPI-CM4 module with BPI-CM4IO baseboard from the Linux submission applied at [1]. The BananaPi BPI-CM4 module follows the CM4 specifications at [2], but with a single HDMI port and a single DSI output. The current CM4IO baseboard DT should work fine on the Raspberry

[PATCH 2/2] ARM: meson: Add initial support for BPI-CM4 module with BPI-CM4IO baseboard

2023-03-07 Thread Neil Armstrong
Add support for both the BananaPi BPI-CM4 module and the BananaPi baseboard which is compatible with the RaspberryPi CM4IO baseboard. The BananaPi BPI-CM4 module follows the CM4 specifications at [1], but with a single HDMI port and a single DSI output. The current CM4IO baseboard DT should work

[PATCH v8 01/10] video console: refactoring and optimization

2023-03-07 Thread Dzmitry Sankouski
- move common code to vidconsole_internal.h and console_core.c - unite probe functions - get rid of code duplications in switch across bpp values - extract common pixel fill logic in two functions one per horizontal and vertical filling - rearrange statements in put_xy* methods in unified way -

[PATCH v8 06/10] video console: allow font size configuration at runtime

2023-03-07 Thread Dzmitry Sankouski
Allow font size configuration at runtime for console_simple.c driver. This needed for unit testing different fonts. Configuring is done by `font` command, also used for font selection in true type console. Signed-off-by: Dzmitry Sankouski Reviewed-by: Simon Glass --- Changes in v8: none

[PATCH v8 04/10] video console: implement multiple fonts configuration

2023-03-07 Thread Dzmitry Sankouski
This needed for unit testing different fonts. Configured fonts are placed in an array of fonts. First font is selected by default upon console probe. Signed-off-by: Dzmitry Sankouski Reviewed-by: Simon Glass --- Changes in v8: none Changes in v7: - place 8x16 font first in list as default -

[PATCH v8 05/10] video console: move vidconsole_get_font_size() logic to driver ops

2023-03-07 Thread Dzmitry Sankouski
Since multiple vidconsole drivers exists, vidconsole_get_font_size() implementation cannot longer live in vidconsole_uclass.c file. Move current vidconsole_get_font_size logic to truetype driver ops. Signed-off-by: Dzmitry Sankouski Reviewed-by: Simon Glass --- Changes in v8: none Changes in

[PATCH v8 10/10] video console: add 12x22 console simple font test

2023-03-07 Thread Dzmitry Sankouski
Tests fonts wider than a byte. Signed-off-by: Dzmitry Sankouski Reviewed-by: Simon Glass --- Changes in v8: none Changes in v7: none Changes in v6: - rebase - move sandbox defconfig change to separate patch - run savedefconfig Changes in v5: N/A Changes in v4: N/A Changes in v2: N/A none

[PATCH v1] spi: npcm-fiu: add regulator feature and remove set clock

2023-03-07 Thread Jim Liu
NPCM7xx/NPCM8xx default is boot from flash. removed set clock feature due to reliability and security. the clock will set by bootblock or tip. Signed-off-by: Jim Liu --- drivers/spi/npcm_fiu_spi.c | 72 +++--- 1 file changed, 59 insertions(+), 13 deletions(-)

Re: [PATCH 1/1] efi_loader: describe term_get_char()

2023-03-07 Thread Ilias Apalodimas
On Fri, 3 Mar 2023 at 23:06, Heinrich Schuchardt wrote: > > Add a function description. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_console.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c >

[PATCH v8 02/10] video console: add support for fonts wider than 1 byte

2023-03-07 Thread Dzmitry Sankouski
Devices with high ppi may benefit from wider fonts. Current width implementation is limited by 1 byte, i.e. 8 bits. New version iterates VIDEO_FONT_BYTE_WIDTH times, to process all width bytes, thus allowing fonts wider than 1 byte. Signed-off-by: Dzmitry Sankouski Reviewed-by: Simon Glass

[PATCH v8 00/10] vidconsole: refactoring and support for wider fonts

2023-03-07 Thread Dzmitry Sankouski
Version 7 has vidconsole_get_font_size() function reworked to use driver ops. Version 6 contains entire rebased patch series. New patch 'move vidconsole_get_font_size() to test.h' added. Version 5 contain minor changes: - move common functions to console-core.c file - remove static keyword

[PATCH v8 03/10] video console: move 8x16 font data in named header

2023-03-07 Thread Dzmitry Sankouski
Consistent font data header names needed to add new fonts. Signed-off-by: Dzmitry Sankouski Reviewed-by: Simon Glass --- Changes in v8: none Changes in v7: none Changes in v6: rebase only Changes in v5: N/A Changes in v4: N/A Changes in v3: N/A Changes in v2: N/A include/video_font.h

Re: [PATCH v1] clk: nuvoton: add read only feature for clk driver

2023-03-07 Thread Sean Anderson
On 3/7/23 03:13, Jim Liu wrote: Set ahb/apb/fiu clock divider as read-only Are these read-only in hardware, or is there some other reason? --Sean Signed-off-by: Jim Liu --- drivers/clk/nuvoton/clk_npcm.c| 15 --- drivers/clk/nuvoton/clk_npcm.h| 1 +

Re: [PATCH v8 04/10] video console: implement multiple fonts configuration

2023-03-07 Thread Anatolij Gustschin
On Tue, 7 Mar 2023 13:21:14 +0300 Dzmitry Sankouski dsankou...@gmail.com wrote: ... > @@ -138,13 +139,15 @@ void splash_display_banner(void) > if (ret) > return; > > -#ifdef CONFIG_VIDEO_LOGO > - col = BMP_LOGO_WIDTH / VIDEO_FONT_WIDTH + 1; > - row = BMP_LOGO_HEIGHT

[PATCH v1 2/2] arm: dts: rockchip: rk3188-radxarock-u-boot: remove timer compatible replacement

2023-03-07 Thread Johan Jonker
The Rockchip timer driver has been renamed after the fall back compatible. There's no need to replace the timer compatible in rk3188-radxarock-u-boot.dtsi anymore, so remove. Signed-off-by: Johan Jonker --- arch/arm/dts/rk3188-radxarock-u-boot.dtsi | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH 0/4] Fix arasan nand driver issues

2023-03-07 Thread Michael Nazzareno Trimarchi
Hi On Tue, Mar 7, 2023 at 2:35 PM Michal Simek wrote: > > > On 2/24/23 06:07, Ashok Reddy Soma wrote: > > In this patch series > > - Remove hardcoding of NAND_BBT_USE_FLASH in nand->bbt_options > > - Find and update nand ofnode. > > - Fix nand node in zynqmp-zc1751-xm017-dc3.dts file > >

[PATCH v8 08/10] video console: add 16x32 Terminus font from linux

2023-03-07 Thread Dzmitry Sankouski
Modern mobile phones typically have high pixel density. Bootmenu is hardly readable on those with 8x16 font. Signed-off-by: Dzmitry Sankouski Reviewed-by: Simon Glass --- Changes in v8: none Changes in v7: none Changes in v6: rebase only Changes in v5: N/A Changes in v4: N/A Changes in

Re: [PATCH 0/4] Fix arasan nand driver issues

2023-03-07 Thread Michal Simek
Hi, On 3/7/23 15:02, Michael Nazzareno Trimarchi wrote: Hi On Tue, Mar 7, 2023 at 2:35 PM Michal Simek > wrote: On 2/24/23 06:07, Ashok Reddy Soma wrote: > In this patch series >   - Remove hardcoding of NAND_BBT_USE_FLASH in nand->bbt_options

[PATCH v1 1/2] rockchip: timer: rockchip_timer: fix compatible and driver name

2023-03-07 Thread Johan Jonker
In the binding for the Rockchip timer the compatible string consists of a SoC orientated string and a fall back string "rockchip,rk3288-timer", so remove all unneeded ones and fix driver name. Signed-off-by: Johan Jonker --- drivers/timer/rockchip_timer.c | 8 +++- 1 file changed, 3

Re: [PATCH v2] spi: xilinx_spi: Fix spi reset

2023-03-07 Thread Michal Simek
po 27. 2. 2023 v 18:17 odesílatel Jiajie Chen napsal: > > It was incorrectly using an old priv->regs pointer, which was > initialized to zero. SPI resets won't happen on first call. > > Signed-off-by: Jiajie Chen > --- > drivers/spi/xilinx_spi.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

Re: [PATCH 1/2] arm: semihosting: replace inline assembly with assembly file

2023-03-07 Thread Tom Rini
On Tue, Feb 07, 2023 at 03:21:04PM +, Andre Przywara wrote: > So far we used inline assembly to inject the actual instruction that > triggers the semihosting service. While this sounds elegant, as it's > really only about one instruction, it has some serious downsides: > - We need some

Re: [PATCH 2/2] riscv: semihosting: replace inline assembly with assembly file

2023-03-07 Thread Tom Rini
On Tue, Feb 07, 2023 at 03:21:05PM +, Andre Przywara wrote: > So far we used inline assembly to inject the actual instruction that > triggers the semihosting service. While this sounds elegant, as it's > really only about a few instructions, it has some serious downsides: > - We need some

Re: [PATCH 2/2] ARM: dts: uniphier: Sync DT with Linux v6.2

2023-03-07 Thread Tom Rini
On Tue, Feb 28, 2023 at 11:37:09AM +0900, Kunihiko Hayashi wrote: > Synchronize devicetree sources with Linux v6.2. > > - Use GIC interrupt definitions > - Add reg properties in USB-glue and SoC-glue node > - Fix node names to follow the generic names list in DT specification > - Add L2 cache

Re: [PATCH v2 1/2] configs: j721s2: merge HS and non-HS defconfigs

2023-03-07 Thread Tom Rini
On Fri, Feb 24, 2023 at 10:37:48AM +0530, Manorit Chawdhry wrote: > K3 devices have runtime type board detection. Make the default defconfig > include the secure configuration. Then remove the HS specific config. > > Non-HS devices will continue to boot due to runtime device type detection. > If

Re: [PATCH 1/2] ARM: dts: uniphier: Switch USB node to the original

2023-03-07 Thread Tom Rini
On Tue, Feb 28, 2023 at 11:37:08AM +0900, Kunihiko Hayashi wrote: > UniPhier DT applies its own USB node for U-Boot due to the USB driver > constrains. After solving this issue, u-boot allows the original USB node. > > After switching USB node, synchronization of USB node with Linux becomes >

Re: [PATCH v2 2/2] configs: j7200: Merge HS and non-HS defconfigs

2023-03-07 Thread Tom Rini
On Fri, Feb 24, 2023 at 10:37:49AM +0530, Manorit Chawdhry wrote: > K3 devices have runtime type board detection. Make the default defconfig > include the secure configuration. Then remove the HS specific config. > > Non-HS devices will continue to boot due to runtime device type detection. > If

Re: [PATCH] timer: fttmr010: return a previously deleted driver now ported to DM

2023-03-07 Thread Tom Rini
On Mon, Feb 13, 2023 at 08:34:36PM +0300, Sergei Antonov wrote: > The fttmr010 timer driver was deleted by > commit 29fc6f24926e ("ARM: remove a320evb board support") > The original source file was: arch/arm/cpu/arm920t/a320/timer.c > > Return the driver to the codebase in a DM compatible form.

Re: [PATCH] powerpc, mpc83xx: Remove CONFIG_ELBC_BRx_ORx

2023-03-07 Thread Tom Rini
On Sun, Feb 26, 2023 at 10:44:09AM +0100, Christophe Leroy wrote: > Commit fe7d654d04 ("mpc83xx: Migrate CONFIG_SYS_{BR, OR}*_PRELIM to > Kconfig") converted CONFIG_SYS_{BRx/ORx}_PRELIM to Kconfig by > implementing a fine-grained selection of every bit in Kconfig. > > But commit c7fad78ec0

Re: [PATCH] am62a7: dts: Enable full 4GB LPDDR4

2023-03-07 Thread Tom Rini
On Mon, Feb 06, 2023 at 05:04:51PM +0530, Devarsh Thakkar wrote: > AM62A7-SK board has 4GB LPDDR4 Micron MT53E2G32D4DE-046 AUT:B part > but only 2GB was enabled early. > > Enable full 4GB memory by updating the latter 2GB memory region > which gets mapped to 0x088000 i.e. DDR16SS0_SDRAM as

Re: [PATCH v2 1/2] arm: cpu: Add optional CMOs by VA

2023-03-07 Thread Tom Rini
On Thu, Feb 09, 2023 at 04:54:27AM +0800, Ying-Chun Liu (PaulLiu) wrote: > From: Marc Zyngier > > Exposing set/way cache maintenance to a virtual machine is unsafe, not > least because the instructions are not permission-checked but also > because they are not broadcast between CPUs.

Re: [PATCH 2/2] arm64: Reduce PT size estimation complexity

2023-03-07 Thread Tom Rini
On Tue, Feb 14, 2023 at 09:38:14PM +0800, Ying-Chun Liu (PaulLiu) wrote: > From: Marc Zyngier > > count_required_pts()'s complexity is high if mappings are not using the > largest possible block size (due to some other requirement such as tracking > dirty pages, for example). > > Let's switch

Re: [PATCH 1/2] arm64: Reduce add_map() complexity

2023-03-07 Thread Tom Rini
On Tue, Feb 14, 2023 at 09:38:13PM +0800, Ying-Chun Liu (PaulLiu) wrote: > From: Marc Zyngier > > In the add_map() function, for each level it populates, it iterates from > the root of the PT tree, making it ineficient if a mapping needs to occur > past level 1. > > Instead, replace it with a

Re: [PATCH v2 2/2] arm64: Initialize TLB memory if CMO_BY_VA_ONLY

2023-03-07 Thread Tom Rini
On Thu, Feb 09, 2023 at 04:54:28AM +0800, Ying-Chun Liu (PaulLiu) wrote: > From: Pierre-Clément Tosi > > Memory used to hold the page tables is allocated from the top of RAM > with no prior initialization and could therefore hold invalid data. As > invalidate_dcache_all() will be called before

Please pull u-boot-video/next

2023-03-07 Thread Anatolij Gustschin
12:48:23 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-video.git tags/next-20230307 for you to fetch changes up to 72471620e82758b6cbdb9f70d775c0c18b043794: video console: add 12x22 console simple font test (2023-03-07 16:00:18 +0100

Re: [PATCH 1/2] ram: ast2600: Keep MPLL power on

2023-03-07 Thread Tom Rini
On Tue, Feb 21, 2023 at 09:01:09PM +0800, Dylan Hung wrote: > According to the PLL vendor, we should keep the PLL power on, so we > shouldn't toggle the power-down bit during PLL initialization. > > Signed-off-by: Dylan Hung > Reviewed-by: Joel Stanley Applied to u-boot/next, thanks! -- Tom

Re: [PATCH] configs: evb-ast2600: Enable configs to store env in SPI

2023-03-07 Thread Tom Rini
On Fri, Feb 10, 2023 at 03:41:53PM +0800, Ryan Chen wrote: > Enable defconfigs relevant for storing env on SPI flash. > > Signed-off-by: Ryan Chen > Reviewed-by: Chia-Wei Wang Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/2] clk: ast2600: Keep PLL power on

2023-03-07 Thread Tom Rini
On Tue, Feb 21, 2023 at 09:01:10PM +0800, Dylan Hung wrote: > According to the PLL vendor, we should keep the PLL power on, so we > shouldn't toggle the power-down bit during PLL initialization. > > Signed-off-by: Dylan Hung > Reviewed-by: Joel Stanley Applied to u-boot/next, thanks! -- Tom

Re: [PATCH 1/2] ARM: remove SPEAR entry in makefile

2023-03-07 Thread Tom Rini
On Wed, Feb 22, 2023 at 08:19:58PM +0100, Patrick Delaunay wrote: > As the lastest spear directories are removed, delete the associated entry > in Makefile. > > Fixes: 570c3dcfc153 ("arm: Remove spear600 boards and the rest of SPEAr > support") > Signed-off-by: Patrick Delaunay Applied to

Re: [PATCH 2/2] mmc: remove SDHCI SPEAR

2023-03-07 Thread Tom Rini
On Wed, Feb 22, 2023 at 08:19:59PM +0100, Patrick Delaunay wrote: > As the file spear_sdhci.c file is already removed, delete the associated > configuration CONFIG_MMC_SDHCI_SPEAR. > > Fixes: c942fc925e7dab ("mmc: spear: remove the entire spear_sdhci.c file") > Signed-off-by: Patrick Delaunay

Re: [PATCH v3 14/17] riscv: dts: jh7110: Add initial StarFive JH7110 device tree

2023-03-07 Thread Conor Dooley
On Tue, Mar 07, 2023 at 06:30:19AM +, Conor Dooley wrote: > > > On 7 March 2023 01:59:31 GMT, yanhong wang > wrote: > > > > > >On 2023/3/4 5:16, Conor Dooley wrote: > >> On Fri, Mar 03, 2023 at 11:24:29AM +0800, Yanhong Wang wrote: > >>> Add initial device tree for the JH7110 RISC-V SoC. >

Re: [PATCH v1] clk: nuvoton: add read only feature for clk driver

2023-03-07 Thread Jim Liu
Hi Sean Thanks for your review. This is a software flag not hardware reg. It just protects the clock source and can't modify it in uboot. Best regards, Jim On Tue, Mar 7, 2023 at 9:57 PM Sean Anderson wrote: > > On 3/7/23 03:13, Jim Liu wrote: > > Set ahb/apb/fiu clock divider as read-only > >

Re: [PATCH 0/4] Fix arasan nand driver issues

2023-03-07 Thread Michal Simek
On 2/24/23 06:07, Ashok Reddy Soma wrote: In this patch series - Remove hardcoding of NAND_BBT_USE_FLASH in nand->bbt_options - Find and update nand ofnode. - Fix nand node in zynqmp-zc1751-xm017-dc3.dts file - Enable nand-on-flash-bbt flag in zynqmp DT's by default Ashok Reddy Soma

[PATCH v2 3/3] Revert "arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates"

2023-03-07 Thread Vasily Khoruzhick
This reverts commit 5bec4b0de7851a254fb4447b3599a60f95550141. Signed-off-by: Vasily Khoruzhick --- v2: revert dropping assigned-clock properties because we have stubs for CLK_PCIEPHY_REF clocks now arch/arm/dts/rk356x-u-boot.dtsi | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Vasily Khoruzhick
On Tue, Mar 7, 2023 at 1:04 PM Mark Kettenis wrote: > And implement support for the CLK_PCIEPHYn_REF clocks in > drivers/clk/rockchip/clk_rk3568.c:rk3568_pmuclk_set_rate()? > > Yes, I'd say so. > > If U-Boot doesn't actually need these clocks to run at the frequency > provided by

[PATCH v2 1/3] phy: rockchip-inno-usb2: add support for phy-supply

2023-03-07 Thread Vasily Khoruzhick
PHY driver needs to enable PHY supply, otherwise port will remain unpowered. Signed-off-by: Vasily Khoruzhick --- v2: address check_patch.pl issues drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 64 ++- 1 file changed, 61 insertions(+), 3 deletions(-) diff --git

[PATCH v2 2/3] clk: rockchip: rk3568: add stubs for CLK_PCIEPHY_REF clocks

2023-03-07 Thread Vasily Khoruzhick
Device tree contains assigned-clock-rates property for these, but default value will work just fine Signed-off-by: Vasily Khoruzhick --- v2: implement stubs for CLK_PCIEPHY_REF instead of dropping assigned-clock properties drivers/clk/rockchip/clk_rk3568.c | 3 +++ 1 file changed, 3

Re: [PATCH] nand: brcmnand: add iproc support

2023-03-07 Thread Linus Walleij
On Sun, Jan 22, 2023 at 12:45 AM Linus Walleij wrote: > Add support for the iproc Broadcom NAND controller, > used in Northstar SoCs for example. Based on the Linux > driver. > > Cc: Philippe Reynes > Signed-off-by: Linus Walleij It's been 1 1/2 month, could we apply this patch? Yours, Linus

Re: [PATCH] mtd: rawnand: nand_base: Handle algorithm selection

2023-03-07 Thread Linus Walleij
On Sun, Jan 22, 2023 at 12:43 AM Linus Walleij wrote: > For BRCMNAND with 1-bit BCH ECC (BCH-1) such as used on the > D-Link DIR-885L and DIR-890L routers, we need to explicitly > select the ECC like this in the device tree: > > nand-ecc-algo = "bch"; > nand-ecc-strength = <1>; >

Re: [PATCH V2 8/9] arm64: dts: rockchip: add gpio-ranges property to gpio nodes

2023-03-07 Thread Vasily Khoruzhick
On Wed, Mar 1, 2023 at 6:49 PM Kever Yang wrote: Hi Kever, > So I have take this patch set, and we can improve later when kernel have > a version and we have a better solution for U-Boot. My concern is that dts will be overwritten during the next dts sync with the kernel. U-boot specific

Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Mark Kettenis
> From: Vasily Khoruzhick > Date: Tue, 7 Mar 2023 11:37:48 -0800 > > combphy0 is failing to probe due to unhandled assigned-clocks and > assigned-clocks-rates. That is probably the wrong approach. It should be possible to boot an OS with the device tree provided by U-Boot. Removing these

Re: [PATCH RFC u-boot-mvebu 0/6] arm: mvebu: Fix boot mode detection

2023-03-07 Thread Pali Rohár
On Tuesday 07 March 2023 12:53:45 Tony Dinh wrote: > Hi Pali, > > On Mon, Mar 6, 2023 at 11:56 PM Pali Rohár wrote: > > > > On Monday 06 March 2023 20:15:07 Tony Dinh wrote: > > > Hi Pali, > > > > > > On Mon, Mar 6, 2023 at 4:11 PM Pali Rohár wrote: > > > > > > > > On Monday 06 March 2023

[PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Vasily Khoruzhick
combphy0 is failing to probe due to unhandled assigned-clocks and assigned-clocks-rates. commit 5bec4b0de785 ("arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates") dropped these properties for combphy1, so let's drop them for combphy0 as well. Signed-off-by: Vasily Khoruzhick ---

[PATCH 1/2] phy: rockchip-inno-usb2: add support for phy-supply

2023-03-07 Thread Vasily Khoruzhick
PHY driver needs to enable PHY supply, otherwise port will remain unpowered. Signed-off-by: Vasily Khoruzhick --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 59 ++- 1 file changed, 57 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c

Re: [PATCH RFC u-boot-mvebu 0/6] arm: mvebu: Fix boot mode detection

2023-03-07 Thread Tony Dinh
Hi Pali, On Mon, Mar 6, 2023 at 11:56 PM Pali Rohár wrote: > > On Monday 06 March 2023 20:15:07 Tony Dinh wrote: > > Hi Pali, > > > > On Mon, Mar 6, 2023 at 4:11 PM Pali Rohár wrote: > > > > > > On Monday 06 March 2023 16:01:58 Tony Dinh wrote: > > > > Hi Pali, > > > > > > > > On Sun, Mar 5,

Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Mark Kettenis
> From: Vasily Khoruzhick > Date: Tue, 7 Mar 2023 12:34:48 -0800 > > On Tue, Mar 7, 2023 at 11:53 AM Mark Kettenis wrote: > > > That is probably the wrong approach. It should be possible to boot an > > OS with the device tree provided by U-Boot. Removing these properties > > means the OS

Re: Please pull u-boot-video/next

2023-03-07 Thread Tom Rini
following changes since commit d1653548d29959a6ea6b4037a00b48a28257e6e6: > > Merge branch '2023-03-02-kconfig-and-CONFIG-cleanups' into next (2023-03-03 > 12:48:23 -0500) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-video.git

Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Vasily Khoruzhick
On Tue, Mar 7, 2023 at 11:53 AM Mark Kettenis wrote: > That is probably the wrong approach. It should be possible to boot an > OS with the device tree provided by U-Boot. Removing these properties > means the OS doesn't see them either. But if the assigned-clocks > property isn't needed it

[PATCH] rockchip: sdhci: rk3568: fix clock setting logic

2023-03-07 Thread Vasily Khoruzhick
mmc->tran_speed is max clock, but currently rk3568_sdhci_set_ios_post uses it if its != 0, regardless of mmc->clock value, and it breaks eMMC controller. Without this patch 'mmc dev 0; mmc dev 1; mmc dev 0' is enough for breaking eMMC, since first initialization sets mmc->mmc_tran speed to

Re: [PATCH v3] pinctrl: rockchip: support rk3588 pinctrl

2023-03-07 Thread Kever Yang
On 2023/3/7 19:56, Eugen Hristev wrote: From: Jianqun Xu Add support for Rockchip rk3588 variant of pinctrl. The driver is adapted from the Linux driver. Signed-off-by: Jianqun Xu [eugen.hris...@collabora.com: port to latest U-boot, bring more changes from Linux] Signed-off-by: Eugen

[PATCH 1/3] cmd: pci: Add command to set MPS of all PCIe devices

2023-03-07 Thread stcarlso
From: Stephen Carlson Enable tuning of the PCI Express MPS (Maximum Payload Size) of each device. The Maximum Read Request Size is not altered. The SAFE method uses the largest MPS value supported by all devices in the system for each device. This method is the same algorithm as used by Linux

[PATCH 2/3] drivers: pci: sandbox: Add stub sandbox PCI MPS support

2023-03-07 Thread stcarlso
From: Stephen Carlson Reports the sandbox swapcase PCI Express device to support a 256 byte Maximum Payload Size for MPS tuning tests. Signed-off-by: Stephen Carlson --- drivers/misc/swap_case.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/misc/swap_case.c

[PATCH 0/3] Add command to set MPS of all PCI Express devices

2023-03-07 Thread stcarlso
From: Stephen Carlson This patch set adds support for configuring the Maximum Payload Size (MPS) for attached PCI Express devices. Modifying the MPS can increase PCI Express performance or ensure compatibility with hot-plugged devices. New config CONFIG_CMD_PCI_MPS. If enabled, a new "pci_mps"

[PATCH 3/3] test: Add test for new command pci_mps

2023-03-07 Thread stcarlso
From: Stephen Carlson Adds a test for the new pci_mps command to ensure that it can set the Maximum Payload Size (MPS) of all devices to 256 bytes in the sandbox environment. Enables the pci_mps command in the sandbox environment so that this test can be run. Signed-off-by: Stephen Carlson ---

Re: [PATCH v2 1/3] phy: rockchip-inno-usb2: add support for phy-supply

2023-03-07 Thread Kever Yang
On 2023/3/8 06:08, Vasily Khoruzhick wrote: PHY driver needs to enable PHY supply, otherwise port will remain unpowered. Signed-off-by: Vasily Khoruzhick Reviewed-by: Kever Yang Thanks, - Kever --- v2: address check_patch.pl issues drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 64

Re: [PATCH v2 3/3] Revert "arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates"

2023-03-07 Thread Kever Yang
Hi Vasily,     Please use a new patch instead of a revert, I think I merge the patch twice by mistake, so there is another one need to remove. Thanks, - Kever On 2023/3/8 06:08, Vasily Khoruzhick wrote: This reverts commit 5bec4b0de7851a254fb4447b3599a60f95550141. Signed-off-by: Vasily

Re: [PATCH v2 2/3] clk: rockchip: rk3568: add stubs for CLK_PCIEPHY_REF clocks

2023-03-07 Thread Kever Yang
On 2023/3/8 06:08, Vasily Khoruzhick wrote: Device tree contains assigned-clock-rates property for these, but default value will work just fine Signed-off-by: Vasily Khoruzhick Reviewed-by: Kever Yang Thanks, - Kever --- v2: implement stubs for CLK_PCIEPHY_REF instead of dropping

Re: [PATCH 3/3] configs: rockchip: rock5b-rk3588: enable USB and regulators

2023-03-07 Thread Kever Yang
On 2023/3/3 15:31, Eugen Hristev wrote: Enable USB command, USB drivers, PHY and regulators, for USB host operations. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock5b-rk3588_defconfig | 18 +- 1 file changed, 17 insertions(+), 1

Re: [PATCH v2 1/3] phy: rockchip-inno-usb2: add support for phy-supply

2023-03-07 Thread Vasily Khoruzhick
On Tue, Mar 7, 2023 at 4:52 PM Kever Yang wrote: > > Hi Vasily, Hi Keven, > This patch is cover by patch[1] from Eugen, right? Yeah, I didn't notice Eugen's patch. Anyway, he sent his patch earlier, so please discard mine. Regards, Vasily

Re: [PATCH v1 1/2] rockchip: timer: rockchip_timer: fix compatible and driver name

2023-03-07 Thread Kever Yang
On 2023/3/7 23:30, Johan Jonker wrote: In the binding for the Rockchip timer the compatible string consists of a SoC orientated string and a fall back string "rockchip,rk3288-timer", so remove all unneeded ones and fix driver name. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang

Re: [PATCH v1 2/2] arm: dts: rockchip: rk3188-radxarock-u-boot: remove timer compatible replacement

2023-03-07 Thread Kever Yang
On 2023/3/7 23:32, Johan Jonker wrote: The Rockchip timer driver has been renamed after the fall back compatible. There's no need to replace the timer compatible in rk3188-radxarock-u-boot.dtsi anymore, so remove. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Kever Yang
Hi Vasily, On 2023/3/8 05:34, Vasily Khoruzhick wrote: On Tue, Mar 7, 2023 at 1:04 PM Mark Kettenis wrote: And implement support for the CLK_PCIEPHYn_REF clocks in drivers/clk/rockchip/clk_rk3568.c:rk3568_pmuclk_set_rate()? Yes, I'd say so. If U-Boot doesn't actually need these clocks to

Re: [PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-07 Thread Kever Yang
On 2023/3/3 15:31, Eugen Hristev wrote: Add initial support for the rk3588 PHY variant. The driver now looks for phy-supply and enables/disables the vbus accordingly. The lookup for the host-port reg inside the struct now does a do {} while() instead of a while() {} in order to allow a first

Re: [PATCH 1/3] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

2023-03-07 Thread Kever Yang
On 2023/3/3 15:31, Eugen Hristev wrote: Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 169 1 file

Re: [PATCH v2 1/3] phy: rockchip-inno-usb2: add support for phy-supply

2023-03-07 Thread Kever Yang
Hi Vasily,     This patch is cover by patch[1] from Eugen, right? Thanks, - Kever [1] https://patchwork.ozlabs.org/project/uboot/patch/20230303073134.282462-2-eugen.hris...@collabora.com/ On 2023/3/8 06:08, Vasily Khoruzhick wrote: PHY driver needs to enable PHY supply, otherwise port

Re: [RFC PATCH v3 5/9] ram: cadence: add driver for Cadence EDAC

2023-03-07 Thread Ralph Siemsen
On Fri, Feb 24, 2023 at 10:19:53AM -0500, Ralph Siemsen wrote: Hi Bryan, On Thu, Feb 23, 2023 at 2:54 PM Bryan Brattlof wrote: Hi Ralph! Love seeing more boards here, though I know of a few chips that use some type of cadence controller. I'm just curious if it would it make sense to name

qemu_arm_defconfig with LTO fails due to unaligned access

2023-03-07 Thread Heinrich Schuchardt
Hello Ilias, hello Tom, Tom tried to run qemu_arm_defconfig with CONFIG_LTO=y in gitlab. This failed as shown in protocol https://source.denx.de/u-boot/u-boot/-/jobs/589913/raw Executing 'HII database protocols' test_hii_database_new_package_list: data abort pc : [<7ff39b98>] lr :

[PATCH] dma: ti: k3-udma: Fix channel hang on teardown

2023-03-07 Thread Vignesh Raghavendra
Setting RX flow error handling will stall the channel until descriptors are available to move RX data. Setting this bit causes issues when tearing down ethernet DMA channel at the end of TFTP transfer as unrelated network packets can cause teardown to stall indefinitely waiting for driver to queue

Re: [PATCH v2 3/3] Revert "arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates"

2023-03-07 Thread Vasily Khoruzhick
On Tue, Mar 7, 2023 at 4:48 PM Kever Yang wrote: > > Hi Vasily, Hi Kever, > Please use a new patch instead of a revert, I think I merge the > patch twice by mistake, so there is another one need to remove. Sure, I changed the patch subject and description in v3. Regards, Vasily

[PATCH v3 1/2] clk: rockchip: rk3568: add stubs for CLK_PCIEPHY_REF clocks

2023-03-07 Thread Vasily Khoruzhick
Device tree contains assigned-clock-rates property for these, but default value will work just fine Reviewed-by: Kever Yang Signed-off-by: Vasily Khoruzhick --- v3: add r-b tag from Kever v2: implement stubs for CLK_PCIEPHY_REF instead of dropping assigned-clock properties

[PATCH v3 2/2] arm64:dts: rk356x-u-boot: do not drop combphy1 assigned-clocks/rates

2023-03-07 Thread Vasily Khoruzhick
We have stubs for CLK_PCIEPHY_REF now, so there is no reason to modify the dtsi. This essentialy reverts commit 5bec4b0de785 ("arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates"). Signed-off-by: Vasily Khoruzhick --- v3: change patch subject and description from default revert

Re: [PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-07 Thread Vasily Khoruzhick
On Thu, Mar 2, 2023 at 11:32 PM Eugen Hristev wrote: > > Add initial support for the rk3588 PHY variant. > The driver now looks for phy-supply and enables/disables the vbus > accordingly. > The lookup for the host-port reg inside the struct now does a do {} while() > instead of a while() {} in

[PATCH v2 2/3] configs: starfive-jh7110: Add support for PCIe host driver

2023-03-07 Thread Minda Chen
From: Mason Huo also add the nvme driver and rtl8169 support. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- configs/starfive_visionfive2_defconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/configs/starfive_visionfive2_defconfig

[PATCH v2 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-07 Thread Minda Chen
From: Mason Huo Add pcie driver for StarFive JH7110, the driver depends on starfive gpio, pinctrl, clk and reset driver to do init. Several devices are tested: a) M.2 NVMe SSD b) Realtek 8169 Ethernet adapter. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- drivers/pci/Kconfig

[PATCH v2 3/3] riscv: dts: starfive: Enable PCIe host controller

2023-03-07 Thread Minda Chen
From: Mason Huo Enable and add pinctrl configuration for PCIe host controller. Also add JH7110 stg syscon configuration. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- .../dts/jh7110-starfive-visionfive-2.dtsi | 99 +++ arch/riscv/dts/jh7110.dtsi

[PATCH v2 0/3] Add StarFive JH7110 PCIe drvier support

2023-03-07 Thread Minda Chen
This patchset needs to apply after patchset in [1]. These PCIe series patches are based on the JH7110 RISC-V SoC and VisionFive V2 board. [1] https://patchwork.ozlabs.org/project/uboot/cover/20230303032432.7837-1-yanhong.w...@starfivetech.com/ The PCIe driver depends on gpio, pinctrl, clk and