Re: [PATCH 5/6] cmd: net: add a 'net stats' command to dump network statistics

2023-06-10 Thread Ramon Fried
On Tue, May 23, 2023 at 4:48 PM Ioana Ciornei wrote: > > Add a new option to the 'net' command which can be used to dump network > statistics. > > To do this, 3 new callbacks are added to the eth_ops structure: > .get_sset_count(), .get_strings(), .get_stats(). These callbacks > have the same

[PULL] u-boot-sh/next_net/phy_connect_dev

2023-06-10 Thread Marek Vasut
The following changes since commit 5f41ef792c307dedc12647cdde2ade273aa11805: Merge branch '2023-06-09-fwu-updates' into next (2023-06-09 20:35:02 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-sh.git next_net/phy_connect_dev for you to fetch

[PULL] u-boot-sh/next_mtd/rpc-spi

2023-06-10 Thread Marek Vasut
The following changes since commit 5f41ef792c307dedc12647cdde2ade273aa11805: Merge branch '2023-06-09-fwu-updates' into next (2023-06-09 20:35:02 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-sh.git next_mtd/rpc-spi for you to fetch changes

Re: [PATCH] renesas: rcar: Apply ATF overlay for reserved-memory

2023-06-10 Thread Adam Ford
On Fri, Jun 9, 2023 at 10:41 AM Detlev Casanova wrote: > > The function fdtdec_board_setup() is called early and adds the overlay > from ATF to the u-boot device tree. That is necessary so that u-boot > doesn't use reserved memory. > > Linux also needs to know about that reserved memory so the

[PATCH v2 1/1] efi_selftest: ReinstallProtocolInterface test

2023-06-10 Thread Heinrich Schuchardt
Test ReinstallProtocolInterface() more rigorously. Replacing the sole installed protocol interface must not result in deleting the handle and creating a new one. Check which interface is actually installed before and after ReinstallProtocolInterface(). Signed-off-by: Heinrich Schuchardt ---

Re: [PULL] u-boot-sh/next_mtd/rpc-spi

2023-06-10 Thread Tom Rini
On Sat, Jun 10, 2023 at 03:37:23PM +0200, Marek Vasut wrote: > The following changes since commit 5f41ef792c307dedc12647cdde2ade273aa11805: > > Merge branch '2023-06-09-fwu-updates' into next (2023-06-09 20:35:02 -0400) > > are available in the Git repository at: > >

[PULL] u-boot-sh/master_reserved

2023-06-10 Thread Marek Vasut
The following changes since commit addd47379df54a3eb247c6db4f799f14af43e523: Merge https://source.denx.de/u-boot/custodians/u-boot-usb (2023-06-08 18:23:06 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-sh.git master_reserved for you to

Re: [PATCH v1 2/2] net: designware: Add bitbang feature for designware driver

2023-06-10 Thread Ramon Fried
On Tue, Feb 14, 2023 at 10:20 AM Jim Liu wrote: > > Add bb_miiphy_bus function for designware bitbang feature. > > Signed-off-by: Jim Liu > --- > drivers/net/designware.c | 109 ++- > drivers/net/designware.h | 3 ++ > 2 files changed, 111 insertions(+), 1

[PATCH 1/1] efi_selftest: ReinstallProtocolInterface test

2023-06-10 Thread Heinrich Schuchardt
Test ReinstallProtocolInterface() more rigorously. Replacing the sole installed protocol interface must not result in deleting the handle and creating a new one. Check which interface is actually installed before and after ReinstallProtocolInterface(). Signed-off-by: Heinrich Schuchardt ---

Re: [PULL] u-boot-sh/next_net/phy_connect_dev

2023-06-10 Thread Tom Rini
On Sat, Jun 10, 2023 at 03:38:07PM +0200, Marek Vasut wrote: > The following changes since commit 5f41ef792c307dedc12647cdde2ade273aa11805: > > Merge branch '2023-06-09-fwu-updates' into next (2023-06-09 20:35:02 -0400) > > are available in the Git repository at: > >

Re: [PATCH 4/6] net: ldpaa_eth: extend debug capabilities with DPMAC statistics

2023-06-10 Thread Ramon Fried
On Tue, May 23, 2023 at 4:48 PM Ioana Ciornei wrote: > > The ldpaa_eth driver already had a DPMAC statistics dump, this patch > extends the list of stats and adds a bit more structure to the code. > > For a bit more context, the DPAA2 u-boot software architecture uses a > default network

Re: [PATCH 3/6] net: ldpaa_eth: extend debug capabilities with DPNI statistics

2023-06-10 Thread Ramon Fried
On Tue, May 23, 2023 at 4:48 PM Ioana Ciornei wrote: > > The ldpaa_eth driver already had a DPNI statistics dump, this patch > extends the list of stats and adds a bit more structure to the code. > > For a bit more context, the DPAA2 u-boot software architecture uses a > default network interface

Re: [PATCH 14/14] net: sh_eth: Fix RX error handling

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > From: Valentine Barshak > > In case RX error occurs, and the RD_RFE bit is set, the descriptor > is never returned back to the queue. Make sh_eth_recv_start return > zero length in this case so that the descriptor can be released > and

Re: [PATCH 10/14] net: phy: Handle reset-delay-us/reset-post-delay-us properties

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > These two properties are used by various DTs in place of > current reset-assert-us/reset-deassert-us , handle both . > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe Hershberger > Cc: Michal Simek > Cc: Nishanth

Re: [PATCH 11/14] net: ravb: Drop reset GPIO handling in favor of common code

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > The common code is now capable of handling reset GPIO associated > with PHY. Drop the local ad-hoc code in favor of common code. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe Hershberger > Cc: Michal Simek > Cc:

Re: [PATCH 13/14] net: sh_eth: Workaround cache issues

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > From: Valentine Barshak > > U-Boot writes to RX packets when constructing replies. > This can cause stale cached data to be written to RX > buffer while we're receiving a packet. This causes RX > packet corruption because we invalidate the

Re: [PATCH 12/14] net: sh_eth: Drop reset GPIO handling in favor of common code

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > The common code is now capable of handling reset GPIO associated > with PHY. Drop the local ad-hoc code in favor of common code. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe Hershberger > Cc: Michal Simek > Cc:

Re: [PATCH 0/6] Add the 'net stats' command to dump network statistics

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 4:19 AM Peng Fan wrote: > > Hi Joe, Ramon > > I see this patchset is delegated to me, would you take care this > patchset or let me handle? > > Thanks, > Peng. > > On 5/23/2023 9:47 PM, Ioana Ciornei wrote: > > > > > > > This patch set extends the 'net' command so that it

Re: [PATCH 1/2] renesas: rcar3: Expose the board id in sysinfo

2023-06-10 Thread Marek Vasut
On 6/9/23 18:00, Detlev Casanova wrote: This is a preparation commit for selecting the correct device tree name to be loaded depending on the board id. I am not opposed to this patch itself (with a few tweaks, see below), but please see 2/2, I suspect this method of selecting the DT is not

Re: [PATCH 2/6] net: ldpaa_eth: transform dpni_statistics from a struct to a union

2023-06-10 Thread Ramon Fried
On Tue, May 23, 2023 at 4:48 PM Ioana Ciornei wrote: > > In order to simplify code, dpni_statistics can be written as a union. > Using the raw accessors we can just loop through all the statistics from > a page without trying to access each an every one independently. > Make this change to a

Re: [PATCH 2/2] renesas: rcar3: Load the correct device tree

2023-06-10 Thread Marek Vasut
On 6/9/23 18:00, Detlev Casanova wrote: The Renesas R-Car Gen3 H3e (Starter Kit Premier) uses a different device tree than the default one. This uses the sysinfo's board id to determine if the board needs a specific device tree. Signed-off-by: Detlev Casanova --- board/renesas/ulcb/ulcb.c

Re: [PATCH 6/6] net: ldpaa_eth: export DPNI and DPMAC counters through 'net stats'

2023-06-10 Thread Ramon Fried
On Tue, May 23, 2023 at 4:48 PM Ioana Ciornei wrote: > > Export the already existing DPNI and DPMAC counters through the newly > added callbacks. > > Signed-off-by: Ioana Ciornei > --- > drivers/net/ldpaa_eth/ldpaa_eth.c | 44 --- > 1 file changed, 40 insertions(+),

[PATCH] mmc: Set clock when reverting to safe bus mode

2023-06-10 Thread Marek Vasut
From: Valentine Barshak Set MMC clock when reverting to safe bus mode and speed in case current MMC mode fails. Otherwise, trying out the other modes may fail as well. Reviewed-by: Marek Vasut Signed-off-by: Valentine Barshak [hp: fallback to legacy_speed] Signed-off-by: Hai Pham --- Cc:

[PATCH 1/2] mmc: Introduce mmc_send_stop_transmission()

2023-06-10 Thread Marek Vasut
From: Hai Pham If a tuning command times out, the card could still be processing it, which will cause problems for recovery. The eMMC specification section 6.6 Data transfer mode (cont’d) claims that CMD12 can be used to stop CMD21: " The relationship between the various data transfer modes is

Re: [PATCH 1/2] net: ipv6: Fix CID 453851 and CID 436278

2023-06-10 Thread Ramon Fried
On Thu, May 18, 2023 at 10:35 PM wrote: > > From: Sean Edmond > > CID 453851 : sprintf() shouldn't copy from/to tmp > CID 436278 : DHCP6 option_len should be checked before use > > Signed-off-by: Sean Edmond > --- > cmd/net.c| 12 ++-- > net/dhcpv6.c | 5 + > 2 files changed,

Re: [PATCH] net: rtl8169: add depends on PCI

2023-06-10 Thread Ramon Fried
On Wed, May 17, 2023 at 1:41 PM Eugen Hristev wrote: > > The rtl8169 driver uses calls to dm_pci_bus_to_phys, > which are compiled under CONFIG_PCI. > > Without CONFIG_PCI, this happens: > > drivers/net/rtl8169.o: in function `rtl_recv_common': > drivers/net/rtl8169.c:555: undefined reference to

Re: [PATCH 2/2] net: dhcp6: Fix VCI string

2023-06-10 Thread Ramon Fried
On Thu, May 18, 2023 at 10:35 PM wrote: > > From: Sean Edmond > > Change VCI string from "U-boot" to "U-Boot". > > Signed-off-by: Sean Edmond > --- > net/dhcpv6.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/dhcpv6.h b/net/dhcpv6.h > index 80ca520432..65c8e4c71d

[PATCH 2/2] mmc: renesas-sdhi: Send stop when MMC tuning command fails

2023-06-10 Thread Marek Vasut
From: Hai Pham When tuning command (CMD21) fails with command error, call mmc_send_stop_transmission() to send stop command (CMD12). Reviewed-by: Takeshi Kihara Reviewed-by: Marek Vasut Signed-off-by: Hai Pham Signed-off-by: Marek Vasut [Marek: Add dev_dbg() message in case tuning abort

[RFC PATCH] i2c: mvtwsi: reinitialize controller to clear bus errors

2023-06-10 Thread Sam Edwards
Hi I²C maintainers, My target has the following devices sharing one bus: - 24C02 EEPROM - Realtek 8370 Ethernet switch - Allwinner T113-s3 (running U-Boot, interfacing via MVTWSI) The RTL8370 is configured in "EEPROM autoload" mode, so on reset it will load the full contents of the EEPROM.

Re: [PATCH 1/6] net: ldpaa_eth: fix the memory layout of the dpmac_get_counters() API

2023-06-10 Thread Ramon Fried
On Tue, May 23, 2023 at 4:48 PM Ioana Ciornei wrote: > > Each MC commands has a specific predefined memory layout that gets > interpreted by the firmware. The dpmac_get_counters() API memory layout > is wrong, thus the results returned by the command are incorrect. > > Fix this by updating the

Re: [PATCH 2/2] net: ipv6: network protocol structures should be packed

2023-06-10 Thread Ramon Fried
On Thu, May 18, 2023 at 9:24 PM wrote: > > From: Ehsan Mohandesi > > The structure icmp6_ra_prefix_info needs to be packed because it is read > from a network stream. > > Signed-off-by: Ehsan Mohandesi > --- > include/net6.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH 1/2] net: ipv6: router advertisement message length should be within limits

2023-06-10 Thread Ramon Fried
On Thu, May 18, 2023 at 9:24 PM wrote: > > From: Ehsan Mohandesi > > The argument len passed to function process_ra is the length of the IPv6 > router advertisement message and needs to be between 0 and MTU because > it is assigned to remaining_option_len and used as a loop variable. > >

Re: [PATCH 01/14] net: eth-phy: staticize eth_phy_reset()

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > The eth_phy_reset() is not used outside of this file, staticize it. > No functional change. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe Hershberger > Cc: Michal Simek > Cc: Nishanth Menon > Cc: Ramon Fried >

Re: [PATCH 02/14] net: altera_tsa: Switch to new U-Boot PHY API

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > Use new U-Boot phy_connect() API which also supports fixed PHYs. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe Hershberger > Cc: Michal Simek > Cc: Nishanth Menon > Cc: Ramon Fried > --- >

bootmenu regression

2023-06-10 Thread Mark Kettenis
Hi Simon, In commit 32bab0eae51 you added a #define ansi 0 and put the code that positions the cursor to print the "Hit any key to stop autoboot" message behind an if (ansi) condition. As a result that message is now printed in whatever place the cursor happens to be, which happens to be

Re: [PATCH 09/14] net: phy: Bind ETH_PHY uclass driver to each new PHY

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > In case a new PHY is created and DM_ETH_PHY is enabled, bind a > generic PHY driver from ETH_PHY uclass to the PHY to have a > matching DM representation of that PHY. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe

Re: [PATCH 08/14] net: phy: Unpublish phy_connect_dev()

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > The phy_connect_dev() is legacy API, now that there are no users, > make it internal to phy.c and unpublish it from headers. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe Hershberger > Cc: Michal Simek > Cc:

Re: [PATCH 04/14] net: ethoc: Switch to new U-Boot PHY API

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > Use new U-Boot phy_connect() API which also supports fixed PHYs. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe Hershberger > Cc: Michal Simek > Cc: Nishanth Menon > Cc: Ramon Fried > --- > drivers/net/ethoc.c

Re: [PATCH 07/14] net: sunxi_emac: Switch to new U-Boot PHY API

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > Use new U-Boot phy_connect() API which also supports fixed PHYs. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe Hershberger > Cc: Michal Simek > Cc: Nishanth Menon > Cc: Ramon Fried > --- >

Re: [PATCH 05/14] net: pch_gbe: Switch to new U-Boot PHY API

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > Use new U-Boot phy_connect() API which also supports fixed PHYs. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe Hershberger > Cc: Michal Simek > Cc: Nishanth Menon > Cc: Ramon Fried > --- >

Re: [PATCH 03/14] net: ave: Switch to new U-Boot PHY API

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > Use new U-Boot phy_connect() API which also supports fixed PHYs. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe Hershberger > Cc: Michal Simek > Cc: Nishanth Menon > Cc: Ramon Fried > --- >

Re: [PATCH 06/14] net: sh_eth: Switch to new U-Boot PHY API

2023-06-10 Thread Ramon Fried
On Wed, May 31, 2023 at 1:51 AM Marek Vasut wrote: > > Use new U-Boot phy_connect() API which also supports fixed PHYs. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven > Cc: Joe Hershberger > Cc: Michal Simek > Cc: Nishanth Menon > Cc: Ramon Fried > --- > drivers/net/sh_eth.c

Re: [PATCH] renesas: rcar: Apply ATF overlay for reserved-memory

2023-06-10 Thread Marek Vasut
On 6/9/23 17:19, Detlev Casanova wrote: The function fdtdec_board_setup() is called early and adds the overlay from ATF to the u-boot device tree. That is necessary so that u-boot doesn't use reserved memory. Linux also needs to know about that reserved memory so the overlay from ATF needs to