Re: [PATCH 3/5] boards: siemens: iot2050: Unify PG1 and PG2/M.2 configurations again

2023-07-28 Thread Tom Rini
On Thu, Jul 27, 2023 at 06:34:54AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > This avoids having to maintain to defconfigs that are 99% equivalent. > The approach is to use binman to generate two flash images, > flash-pg1.bin and flash-pg2.bin. With the help of a template dtsi, we > can

Re: [PATCH V3 2/3] arm: mach-k3: am62: Add timer0 id to the dev list

2023-07-28 Thread Tom Rini
On Thu, Jul 27, 2023 at 04:03:30AM -0500, Nishanth Menon wrote: > From: Sjoerd Simons > > Timer0 is used by u-boot as the tick timer; Add it to the soc devices > list so it can be enabled via the k3 power controller. > > Signed-off-by: Sjoerd Simons > Reviewed-by: Tom Rini > Reviewed-by:

Re: [PATCH 2/5] iot2050: Use binman in signing script

2023-07-28 Thread Tom Rini
On Thu, Jul 27, 2023 at 06:34:53AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > The underlying issue was fixed in the meantime. Also signing the U-Boot > proper fit image now works. Just supporting custom cert templates > remains a todo. > > Signed-off-by: Jan Kiszka Applied to

Re: [PATCH 5/5] configs: iot2050: Enabled keyed autoboot

2023-07-28 Thread Tom Rini
On Thu, Jul 27, 2023 at 06:34:56AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Only accept SPACE to stop autobooting. This is safer to avoid accidental > interruptions on unattended devices. > > Signed-off-by: Jan Kiszka Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH V3 3/3] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-28 Thread Tom Rini
On Thu, Jul 27, 2023 at 04:03:31AM -0500, Nishanth Menon wrote: > Update the am62 and am625 device-trees from linux v6.5-rc1. This needed > the following tweaks to the u-boot specific dtsi as well: > - Switch tick-timer to the main_timer as it's now defined in the main dtsi > - Secure proxies are

Re: [PATCH 4/5] doc: board: siemens: iot2050: Update build env vars

2023-07-28 Thread Tom Rini
On Thu, Jul 27, 2023 at 06:34:55AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > ATF is now called BL31, and OP-TEE since 3.21 suggests to use > tee-raw.bin instead of (the still identical) tee-pager_v2.bin. > > Signed-off-by: Jan Kiszka Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 1/5] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-28 Thread Simon Glass
Hi Bin, On Fri, 28 Jul 2023 at 10:44, Bin Meng wrote: > > Hi Simon, > > On Sat, Jul 29, 2023 at 12:03 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Fri, 28 Jul 2023 at 03:38, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Thu, Jul 27, 2023 at 8:55 AM Simon Glass wrote: > > > > > > >

[PATCH v4 1/3] toradex: tdx-cfg-block: add verdin am62 skus

2023-07-28 Thread Marcel Ziswiler
From: Marcel Ziswiler Add initial Verdin AM62 Quad 1GB WB IT prototype and launch configuration SKUs to ConfigBlock handling. 0069: Verdin AM62 Quad 1GB WB IT 0071: Verdin AM62 Solo 512MB 0072: Verdin AM62 Solo 512MB WB IT 0073: Verdin AM62 Dual 1GB ET 0074: Verdin AM62 Dual 1GB IT 0075: Verdin

[PATCH v4 2/3] arm: mach-k3: am62: fix 2nd mux option of clkout0

2023-07-28 Thread Marcel Ziswiler
From: Marcel Ziswiler Fix second mux option of clkout0 which should really be DEV_BOARD0_CLKOUT0_IN_PARENT_HSDIV4_16FFT_MAIN_2_HSDIVOUT1_CLK10 rather than twice the same according to [1]. [1] https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am62x/clocks.html#clocks-for-board0-device

Re: [PATCH 01/14] bloblist: Update the tag numbering

2023-07-28 Thread Julius Werner
> Ok, but if we do that we need to be careful with the standard. Things > like BLOBLISTT_U_BOOT_VIDEO dont feel U-Boot specific. The idea behind the Transfer List tag allocation policy is low friction allocation and organically emerging standards. You're not supposed to need to have big up-front

Re: [PATCH 6/9] x86: Correct copying of BIOS mode information

2023-07-28 Thread Bin Meng
On Mon, Jul 24, 2023 at 10:52 PM Simon Glass wrote: > > This is copying beyond the end of the destination buffer. Correct the code > by using a constant for the buffer size. > > This long-standing bug prevents virtio bootdevs working correctly on > qemu-x86 at present. Nice catch! > >

Re: [PATCH 1/5] boards: siemens: iot2050: Fix boot configuration

2023-07-28 Thread Tom Rini
On Thu, Jul 27, 2023 at 06:34:52AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > The common env bits now come via ti_armv7_common.env, include it. > Futhermore restore the board-specific boot targets and their ordering > that is now enforced k3-wide differently. Finally, enable >

Re: [PATCH v2 1/2] configs: keystone2: Unwind KERNEL_MTD_PARTS definition

2023-07-28 Thread Tom Rini
On Tue, Jul 25, 2023 at 01:15:20PM -0500, Andrew Davis wrote: > This is more complex than it needs to be and makes converting these > boards over to plain text env files more difficult. Remove setting > mtdparts as the DTS already contain the partitions. While here also > drop the conflicting

Re: [PATCH v2 2/2] configs: keystone2: Change to using env files

2023-07-28 Thread Tom Rini
On Tue, Jul 25, 2023 at 01:15:21PM -0500, Andrew Davis wrote: > Move to using .env file for setting up environment variables for K2x_evm. > > Signed-off-by: Andrew Davis > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH V3 1/3] omap: timer: add ti,am654-timer compatibility

2023-07-28 Thread Tom Rini
On Thu, Jul 27, 2023 at 04:03:29AM -0500, Nishanth Menon wrote: > From: Sjoerd Simons > > The TI AM654 timer is compatible with the omap-timer implementation, > so add it to the compatible id list. > > Signed-off-by: Sjoerd Simons > Reviewed-by: Roger Quadros > Reviewed-by: Tom Rini >

Re: [PATCH 5/5] mach-k3: security: improve the checks around authentication

2023-07-28 Thread Tom Rini
On Tue, Jul 25, 2023 at 01:09:22PM +0530, Manorit Chawdhry wrote: > The following checks are more reasonable as the previous logs were a bit > misleading as we could still get the logs that the authetication is > being skipped but still authenticate. Move the debug prints and checks > to proper

Re: [PATCH v1] arm: k3: fix fdt_del_node_path implicit declaration and a missing include

2023-07-28 Thread Tom Rini
On Wed, Jul 26, 2023 at 04:36:50PM +0200, Emanuele Ghidoli wrote: > From: Emanuele Ghidoli > > Fix missing declaration of fdt_del_node_path() while compiling am625_fdt.c and > missing common_fdt.h include in common_fdt.c > > Fixes: 70aa5a94d451 ("arm: mach-k3: am62: Fixup CPU core, gpu and pru

Re: [PATCH v2 1/4] net: ti: am65-cpsw-nuss: Use approved property to get efuse address

2023-07-28 Thread Tom Rini
On Sat, Jul 22, 2023 at 10:31:48PM +0300, Roger Quadros wrote: > The approved DT property for MAC efuse (ROM) address is > "ti,syscon-efuse". > > Use that and drop custom property "mac_efuse". > > Signed-off-by: Roger Quadros > Acked-by: Nishanth Menon Applied to u-boot/master, thanks! --

Re: Pull request: u-boot-rockchip-20230728

2023-07-28 Thread Tom Rini
in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-rockchip.git > tags/u-boot-rockchip-20230728 > > for you to fetch changes up to 94da929b933668c4b9ece7d56a2a2bb5543198c9: > > board: rockchip: Add Hardkernel ODROID-M1 (2023-07-28 18:45:03 +0800) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 2/4] net: ti: am65-cpsw-nuss: Get port mode register from standard "phys" property

2023-07-28 Thread Tom Rini
On Sat, Jul 22, 2023 at 10:31:49PM +0300, Roger Quadros wrote: > Approved DT binding has the port mode register in the > "phys" property. Get it from there instead of the custom > "cpsw-phy-sel" property. > > This will allow us to keep DT in sync with Linux. > > Signed-off-by: Roger Quadros >

Re: [PATCH] Remove unused parameters

2023-07-28 Thread Simon Glass
Hi, On Fri, 28 Jul 2023 at 06:19, Yuepeng Xing wrote: > > Remove unused parameters from function arch_env_get_location What is the motivation for this patch? I don't know for sure, but perhaps the operation is important in deciding which location to use? > > Signed-off-by: Yuepeng Xing > ---

Re: [PATCH v2 1/1] doc: update doc/sphinx/requirements.txt

2023-07-28 Thread Simon Glass
On Fri, 28 Jul 2023 at 00:20, Heinrich Schuchardt wrote: > > Update the following requirements to their latest version: > > * Pygments - syntax highlighting > * pytz - world timezone definitions > * certifi - Mozilla's CA bundle > > Signed-off-by: Heinrich Schuchardt > --- > v2: >

Re: [PATCH] Remove unused parameters

2023-07-28 Thread Simon Glass
Hi, On Fri, 28 Jul 2023 at 06:19, Shenlin Liang wrote: > > Removes unused function arguments from the riscv_cpu_setup function > > Signed-off-by: Shenlin Liang > --- > arch/riscv/cpu/cpu.c | 2 +- > arch/riscv/include/asm/system.h | 2 +- > arch/riscv/lib/spl.c | 2 +-

Re: Pull request for efi-2023-10-rc2

2023-07-28 Thread Tom Rini
On Fri, Jul 28, 2023 at 06:07:59PM +0200, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit c98c401dfb485b39c7453a4147b17cd4b8d10c67: > > Merge https://source.denx.de/u-boot/custodians/u-boot-usb (2023-07-27 > 10:35:36 -0400) > > are available in the Git

Re: [PATCH 4/5] env: ti: mmc.env: Fix overlays directory path

2023-07-28 Thread Tom Rini
On Tue, Jul 25, 2023 at 01:09:21PM +0530, Manorit Chawdhry wrote: > From: Vignesh Raghavendra > > Similar to get_fdt_mmc make get_overlays_mmc look at /boot/dtb/* path > for overlay files. > > Signed-off-by: Vignesh Raghavendra > Signed-off-by: Manorit Chawdhry > Reviewed-by: Nikhil M Jain

Re: [PATCH 3/5] env: ti: mmc.env: Move mmc related args to common place

2023-07-28 Thread Tom Rini
On Tue, Jul 25, 2023 at 01:09:20PM +0530, Manorit Chawdhry wrote: > From: Vignesh Raghavendra > > All K3 SoCs use same set of args to load kernel for MMC. So move this to > common place to avoid duplication. > > Signed-off-by: Vignesh Raghavendra > Signed-off-by: Manorit Chawdhry >

Re: [PATCH v4 1/2] net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node

2023-07-28 Thread Tom Rini
On Mon, Jul 24, 2023 at 03:57:30PM +0200, Maxime Ripard wrote: > The binding represents the MDIO controller as a child device tree > node of the MAC device tree node. > > The U-Boot driver mostly ignores that child device tree node and just > hardcodes the resources it uses to support both the

Re: [PATCH 1/5] configs: am62x: add SPL_MAX_SIZE back

2023-07-28 Thread Tom Rini
On Tue, Jul 25, 2023 at 01:09:18PM +0530, Manorit Chawdhry wrote: > This was regressed by the following commit and is required to build with > additional configs enabled. > > Fixes: 14439cd71c1a ("configs: k3: make consistent bootcmd across all k3 > socs") > > Signed-off-by: Manorit Chawdhry

[PATCH v2] gpio: Use separate bitfield array to indicate GPIO is claimed

2023-07-28 Thread Marek Vasut
The current gpio-uclass design uses name field in struct gpio_dev_priv as an indicator that GPIO is claimed by consumer. This overloads the function of name field and does not work well for named pins not configured as GPIO pins. Introduce separate bitfield array as the claim indicator. This

Re: [PATCH 5/9] board_f: Fix corruption of relocaddr

2023-07-28 Thread Simon Glass
Hi, +Tom Rini for comment On Fri, 28 Jul 2023 at 02:35, Nikhil M Jain wrote: > > Hi Simon, > > On 27/07/23 23:31, Simon Glass wrote: > > Hi Nikhil, > > > > On Wed, 26 Jul 2023 at 23:22, Nikhil M Jain wrote: > >> > >> Hi Simon, > >> > >> On 27/07/23 06:23, Simon Glass wrote: > >>> Hi Devarsh, >

[PATCH 1/1] doc: move README.falcon to HTML

2023-07-28 Thread Heinrich Schuchardt
Move the Falcon mode documentation to HTML. Signed-off-by: Heinrich Schuchardt --- doc/README.falcon | 232 doc/develop/falcon.rst | 258 + doc/develop/index.rst | 1 + 3 files changed, 259 insertions(+), 232

Re: [PATCH] doc: board: ti: Add SPDX License to svg images

2023-07-28 Thread Heinrich Schuchardt
On 7/28/23 22:05, Nishanth Menon wrote: Add Licensing to svg images to clarify the terms. Signed-off-by: Nishanth Menon Reviewed-by: Heinrich Schuchardt

Re: [PATCH 1/1] doc: move README.falcon to HTML

2023-07-28 Thread Simon Glass
On Fri, 28 Jul 2023 at 14:49, Heinrich Schuchardt wrote: > > Move the Falcon mode documentation to HTML. > > Signed-off-by: Heinrich Schuchardt > --- > doc/README.falcon | 232 > doc/develop/falcon.rst | 258 + >

Re: [PATCH v2 1/1] doc: U-Boot boot phases

2023-07-28 Thread Heinrich Schuchardt
On 7/28/23 19:32, Simon Glass wrote: Hi Heinrich, On Fri, 28 Jul 2023 at 09:58, Heinrich Schuchardt wrote: Add more detail to the description of U-Boot boot phases: * describe which steps are optional * mentions alternative boot flows Signed-off-by: Heinrich Schuchardt Reviewed-by: Bin

[PATCH] doc: board: ti: Add SPDX License to svg images

2023-07-28 Thread Nishanth Menon
Add Licensing to svg images to clarify the terms. Signed-off-by: Nishanth Menon --- doc/board/ti/img/boot_diagram_am65.svg | 4 doc/board/ti/img/boot_diagram_j721e.svg| 4 doc/board/ti/img/boot_diagram_k3_current.svg | 4 doc/board/ti/img/boot_flow_01.svg

Re: [bug report] cros_ec: Add vstore support

2023-07-28 Thread Simon Glass
Hi Dan, On Tue, 25 Jul 2023 at 00:51, Dan Carpenter wrote: > > Hello Simon Glass, > > The patch 10f746591fba: "cros_ec: Add vstore support" from Jan 16, > 2021 (linux-next), leads to the following Smatch static checker > warning: > > drivers/misc/cros_ec_sandbox.c:543 process_cmd() error: buffer

Re: [PATCHv4 1/5] net/lwip: add lwip-external submodule

2023-07-28 Thread Simon Glass
Hi Tom, On Fri, 28 Jul 2023 at 12:09, Tom Rini wrote: > > On Thu, Jul 27, 2023 at 03:34:48PM +0300, Ilias Apalodimas wrote: > > > Tom, Simon > > are you ok with submodules on this one? > > Still punting on that question and waiting for commentary from > distribution people. I really quite badly

Re: [PATCH 1/5] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-28 Thread Bin Meng
Hi Simon, On Sat, Jul 29, 2023 at 12:03 AM Simon Glass wrote: > > Hi Bin, > > On Fri, 28 Jul 2023 at 03:38, Bin Meng wrote: > > > > Hi Simon, > > > > On Thu, Jul 27, 2023 at 8:55 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Tue, 25 Jul 2023 at 07:43, Bin Meng wrote: > > > > > > >

Re: [PATCHv4 1/5] net/lwip: add lwip-external submodule

2023-07-28 Thread Tom Rini
On Thu, Jul 27, 2023 at 03:34:48PM +0300, Ilias Apalodimas wrote: > Tom, Simon > are you ok with submodules on this one? Still punting on that question and waiting for commentary from distribution people. -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 1/2] net: ti: am65-cpsw-nuss: Enforce pinctrl state on the MDIO child node

2023-07-28 Thread Marcel Ziswiler
Hi Maxime On Fri, 2023-07-28 at 15:52 +0200, mrip...@kernel.org wrote: > On Fri, Jul 28, 2023 at 01:34:38PM +, Marcel Ziswiler wrote: [snip] > > However, so far I could not make this work for our use-case [1]. It just > > keeps crashing. Any ideas? > > > > [snip] [snip] > > [1]

[PATCH v4 0/3] board: toradex: add verdin am62 support

2023-07-28 Thread Marcel Ziswiler
From: Marcel Ziswiler This series adds initial support for the Toradex Verdin AM62 SoM [1]. The first commit adds resp. PID4s to the ConfigBlock, the second one fixes an early clocking issue confirmed to be a weird bug in TI's scripting. And last but not least support for the Toradex Verdin

Re: [PATCH 1/5] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-28 Thread Simon Glass
Hi Bin, On Fri, 28 Jul 2023 at 03:38, Bin Meng wrote: > > Hi Simon, > > On Thu, Jul 27, 2023 at 8:55 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Tue, 25 Jul 2023 at 07:43, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Mon, Jul 24, 2023 at 6:14 AM Simon Glass wrote: > > > > > > > >

Pull request for efi-2023-10-rc2

2023-07-28 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit c98c401dfb485b39c7453a4147b17cd4b8d10c67: Merge https://source.denx.de/u-boot/custodians/u-boot-usb (2023-07-27 10:35:36 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git

Re: [PATCH v2] gpio: Use separate bitfield array to indicate GPIO is claimed

2023-07-28 Thread Simon Glass
Hi Marek, On Fri, 28 Jul 2023 at 11:17, Marek Vasut wrote: > > The current gpio-uclass design uses name field in struct gpio_dev_priv as > an indicator that GPIO is claimed by consumer. This overloads the function > of name field and does not work well for named pins not configured as GPIO >

Re: [PATCH v2 1/1] doc: U-Boot boot phases

2023-07-28 Thread Simon Glass
Hi Heinrich, On Fri, 28 Jul 2023 at 09:58, Heinrich Schuchardt wrote: > > Add more detail to the description of U-Boot boot phases: > > * describe which steps are optional > * mentions alternative boot flows > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Bin Meng > --- > v2: >

Re: [PATCH 2/9] video: Tidy up Makefile rule for video

2023-07-28 Thread Simon Glass
Hi Bin, On Fri, 28 Jul 2023 at 09:46, Bin Meng wrote: > > Hi Simon, > > On Mon, Jul 24, 2023 at 10:52 PM Simon Glass wrote: > > > > Drop the duplication and add a single rule which can handle SPL as well. > > > > Signed-off-by: Simon Glass > > --- > > > > drivers/Makefile | 4 ++-- > > 1 file

Re: [PATCH 4/9] Revert "x86: Switch QEMU over to use the bochs driver"

2023-07-28 Thread Simon Glass
Hi Bin, On Fri, 28 Jul 2023 at 09:46, Bin Meng wrote: > > Hi Simon, > > On Mon, Jul 24, 2023 at 10:52 PM Simon Glass wrote: > > > > Unfortunately the bochs driver does not currently work with distros. It > > causes a hang sometime between grub menu selection and the OS displaying > > something.

Re: [PATCH v4 3/5] usb: dwc3-generic: Relax unsupported dr_mode check

2023-07-28 Thread Marek Vasut
On 7/28/23 14:40, Jonas Karlman wrote: When dr_mode is peripheral or otg and U-Boot has not been built with DM_USB_GADGET support, booting such device may end up with: dwc3_glue_bind_common: subnode name: usb@fcc0 Error binding driver 'dwc3-generic-wrapper': -6 Some drivers failed

Re: [PATCH v4 4/5] usb: dwc3-generic: Add rk3568 support

2023-07-28 Thread Marek Vasut
On 7/28/23 14:40, Jonas Karlman wrote: RK3568 share glue and ctrl in a single node. Use glue_get_ctrl_dev to return the glue node as the ctrl node. Signed-off-by: Jonas Karlman Reviewed-by: Jagan Teki --- v4: - No change v3: - No change v2: - No change - Collect r-b tag

Re: [PATCH 02/16] doc: board: ti: am62x/j7200: Update with common boot flow diagram

2023-07-28 Thread Heinrich Schuchardt
On 7/27/23 11:40, Neha Malcom Francis wrote: These look nice! On 27/07/23 13:30, Nishanth Menon wrote: Update the bootflow svg diagram and reuse across the platforms as they are common. We should add SPDX license information to all the SVG files that you created. e.g. like the license

Re: [PATCH 4/8] bootstd: Correct creating of bootdev sibling

2023-07-28 Thread Mattijs Korpershoek
On jeu., juil. 27, 2023 at 20:37, Simon Glass wrote: > Use the correct function here, since there may be multiple IDE devices > available. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > drivers/block/ide.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

[PATCH v2 1/1] doc: update doc/sphinx/requirements.txt

2023-07-28 Thread Heinrich Schuchardt
Update the following requirements to their latest version: * Pygments - syntax highlighting * pytz - world timezone definitions * certifi - Mozilla's CA bundle Signed-off-by: Heinrich Schuchardt --- v2: fix typo in title --- doc/sphinx/requirements.txt | 6 +++--- 1 file changed,

Re: [PATCH v2] efi_loader: make efi_delete_handle() follow the EFI spec

2023-07-28 Thread Heinrich Schuchardt
On 7/24/23 12:17, Ilias Apalodimas wrote: The EFI doesn't allow removal of handles, unless all hosted protocols are cleanly removed. Our efi_delete_handle() is a bit intrusive. Although it does try to delete protocols before removing a handle, it doesn't care if that fails. Instead it only

Re: [PATCH 1/9] x86: spl: Drop unwanted debug()

2023-07-28 Thread Bin Meng
On Mon, Jul 24, 2023 at 10:52 PM Simon Glass wrote: > > This was left over from some previous debugging. Drop it. > > Signed-off-by: Simon Glass > --- > > arch/x86/lib/spl.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH 2/9] video: Tidy up Makefile rule for video

2023-07-28 Thread Bin Meng
Hi Simon, On Mon, Jul 24, 2023 at 10:52 PM Simon Glass wrote: > > Drop the duplication and add a single rule which can handle SPL as well. > > Signed-off-by: Simon Glass > --- > > drivers/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/Makefile

Re: [PATCH 3/9] x86: Run QEMU machine setup in SPL

2023-07-28 Thread Bin Meng
On Mon, Jul 24, 2023 at 10:52 PM Simon Glass wrote: > > Call the hardware-init function from QEMU from SPL. This allows the video > BIOS to operate correctly. > > Create an x86-wide qemu.h header to avoid having to #ifdef the header in > spl.c > > Signed-off-by: Simon Glass > --- > >

Re: [PATCH 4/9] Revert "x86: Switch QEMU over to use the bochs driver"

2023-07-28 Thread Bin Meng
Hi Simon, On Mon, Jul 24, 2023 at 10:52 PM Simon Glass wrote: > > Unfortunately the bochs driver does not currently work with distros. It > causes a hang sometime between grub menu selection and the OS displaying > something. Does this reproduce reliably? > > This reverts commit

[PATCH 1/1] doc: U-Boot boot phases

2023-07-28 Thread Heinrich Schuchardt
Add more detail to the description of U-Boot boot phases: * describe which steps are optional * mentions alternative boot flows Signed-off-by: Heinrich Schuchardt --- doc/develop/spl.rst | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/doc/develop/spl.rst

Re: [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG

2023-07-28 Thread Bin Meng
On Fri, Jul 28, 2023 at 9:54 PM Heinrich Schuchardt wrote: > > The EFI_RNG_PROTOCOL is needed for Linux' KASLR. > > QEMU can provide a virtio-rng device to emulate a hardware random number > generator which is supported by our virtio_rng driver. > > Enabling CONFIG_DM_RNG will enable

Re: [PATCH 1/1] doc: U-Boot boot phases

2023-07-28 Thread Bin Meng
On Fri, Jul 28, 2023 at 11:49 PM Heinrich Schuchardt wrote: > > Add more detail to the description of U-Boot boot phases: > > * describe which steps are optional > * mentions alternative boot flows > > Signed-off-by: Heinrich Schuchardt > --- > doc/develop/spl.rst | 13 ++--- > 1 file

Re: [PATCH 1/1] doc: U-Boot boot phases

2023-07-28 Thread Conor Dooley
Hey Heinrich, On Fri, Jul 28, 2023 at 05:48:31PM +0200, Heinrich Schuchardt wrote: > Add more detail to the description of U-Boot boot phases: > > * describe which steps are optional > * mentions alternative boot flows > > Signed-off-by: Heinrich Schuchardt > --- > doc/develop/spl.rst | 13

R: Pull request: u-boot-rockchip-20230728

2023-07-28 Thread Pegorer Massimo
Hi Kever, > Da: U-Boot Per conto di Jagan Teki > Inviato: venerdì 28 luglio 2023 14:07 > A: Kever Yang > Cc: tr...@konsulko.com; u-boot@lists.denx.de > Oggetto: Re: Pull request: u-boot-rockchip-20230728 > > Hi Kever, > > On Fri, Jul 28, 2023 at 5:04 PM Kever Ya

[PATCH v2 1/1] doc: U-Boot boot phases

2023-07-28 Thread Heinrich Schuchardt
Add more detail to the description of U-Boot boot phases: * describe which steps are optional * mentions alternative boot flows Signed-off-by: Heinrich Schuchardt Reviewed-by: Bin Meng --- v2: add missing comma --- doc/develop/spl.rst | 13 ++--- 1 file changed, 10

Re: [PATCH] docs: boards: ti: add openocd spl debugging docs

2023-07-28 Thread Heinrich Schuchardt
On 7/21/23 21:19, Jason Kacines wrote: Add documentation on how to use OpenOCD to debug U-Boot for TI K3 Generation boards. Signed-off-by: Jason Kacines Thank you for providing OpenOCD usage guidance. This patch cannot be applied to origin/master. Please, rebase it. Please, remove trailing

Re: [PATCH] configs: rock64-rk3328_defconfig: Enable ROCKCHIP_EFUSE

2023-07-28 Thread Christopher Obbard
On Thu, 2023-07-27 at 19:33 +0300, Matwey V. Kornilov wrote: > Enable missed CONFIG_ROCKCHIP_EFUSE to use fixed Ethernet MAC address. > > Signed-off-by: Matwey V. Kornilov Reviewed-by: Christopher Obbard > --- >  configs/rock64-rk3328_defconfig | 2 ++ >  1 file changed, 2 insertions(+) > >

Re: [PATCH 3/8] bootstd: Rename bootdev_setup_sibling_blk()

2023-07-28 Thread Mattijs Korpershoek
On jeu., juil. 27, 2023 at 20:37, Simon Glass wrote: > This name is a little confusing since it suggests that it sets up the > sibling block device. In fact it sets up a bootdev for it. Rename the > function to make this clearer. > > Signed-off-by: Simon Glass > --- > > boot/bootdev-uclass.c

Re: [PATCH] configs: rock64-rk3328_defconfig: Enable ROCKCHIP_EFUSE

2023-07-28 Thread Peter Robinson
On Thu, Jul 27, 2023 at 5:34 PM Matwey V. Kornilov wrote: > > Enable missed CONFIG_ROCKCHIP_EFUSE to use fixed Ethernet MAC address. I've already sent a patch to do that as part of a series for other improvements:

[PATCH v2 0/4] rockchip: rk3568: Device Tree updates

2023-07-28 Thread Jonas Karlman
This series sync rk356x.dtsi and rk3566-radxa-cm3-io.dts from linux v6.4, add bootph-all to common pinctrl nodes and relax FIT load order in rk356x-u-boot.dtsi. Patch 1-2 sync rk356x device tree from linux v6.4. Patch 3 move common pinctrl nodes to rk356x-u-boot.dtsi. Patch 4 change to try and

[PATCH v2 1/4] rockchip: rk356x: Sync dtsi from linux v6.4

2023-07-28 Thread Jonas Karlman
Sync rk356x.dtsi from linux v6.4. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - No change arch/arm/dts/rk3568-pinctrl.dtsi | 94 arch/arm/dts/rk356x.dtsi | 14 +++-- 2 files changed, 102 insertions(+), 6 deletions(-) diff --git

[PATCH v2 2/4] rockchip: rk3566-radxa-cm3-io: Sync dts from linux v6.4

2023-07-28 Thread Jonas Karlman
Sync rk3566-radxa-cm3-io.dts from linux v6.4. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - No change arch/arm/dts/rk3566-radxa-cm3-io.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/dts/rk3566-radxa-cm3-io.dts b/arch/arm/dts/rk3566-radxa-cm3-io.dts

Re: Pull request: u-boot-rockchip-20230728

2023-07-28 Thread Jagan Teki
able in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-rockchip.git > tags/u-boot-rockchip-20230728 > > for you to fetch changes up to 94da929b933668c4b9ece7d56a2a2bb5543198c9: > > board: rockchip: Add Hardkernel ODROID-M1 (2023-07-28 18:45:03 +08

[PATCH] Remove unused parameters

2023-07-28 Thread Shenlin Liang
Removes unused function arguments from the riscv_cpu_setup function Signed-off-by: Shenlin Liang --- arch/riscv/cpu/cpu.c | 2 +- arch/riscv/include/asm/system.h | 2 +- arch/riscv/lib/spl.c | 2 +- board/starfive/visionfive2/spl.c | 2 +- 4 files changed, 4

[PATCH] Remove unused parameters

2023-07-28 Thread Yuepeng Xing
Remove unused parameters from function arch_env_get_location Signed-off-by: Yuepeng Xing --- arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 2 +- arch/arm/mach-imx/imx8m/soc.c | 2 +- board/theobroma-systems/puma_rk3399/puma-rk3399.c | 2 +- env/env.c

Re: [PATCH V3 0/3] arm: dts: Sync k3-am62 with upstream kernel

2023-07-28 Thread Maxime Ripard
On Thu, 27 Jul 2023 04:03:28 -0500, Nishanth Menon wrote: > Hopefully, third time is a charm.. ;) > > I have picked up part of Sjoerd's series[1] to keep it constrained just > to dts sync at this point rather than adding newer functionality on top. > > > [ ... ] Tested-by: Maxime Ripard

Re: [PATCH V3 3/3] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-28 Thread Maxime Ripard
On Thu, 27 Jul 2023 04:03:31 -0500, Nishanth Menon wrote: > Update the am62 and am625 device-trees from linux v6.5-rc1. This needed > the following tweaks to the u-boot specific dtsi as well: > - Switch tick-timer to the main_timer as it's now defined in the main dtsi > - Secure proxies are

Re: [PATCH 0/5] board: rockchip: Add Pine64 Quartz64 and SOQuartz boards

2023-07-28 Thread Jonas Karlman
On 2023-07-28 13:02, Kever Yang wrote: > > On 2023/7/23 22:55, Jonas Karlman wrote: >> This series was created in collaboration with Nicolas Frattaroli and add >> support for Pine64 Quartz64 and SOQuartz boards with a RK3566 SoC. >> >> - Pine64 Quartz64-A Board >> - Pine64 Quartz64-B Board >> -

Pull request: u-boot-rockchip-20230728

2023-07-28 Thread Kever Yang
: Merge https://source.denx.de/u-boot/custodians/u-boot-usb (2023-07-27 10:35:36 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-rockchip.git tags/u-boot-rockchip-20230728 for you to fetch changes up to 94da929b933668c4b9ece7d56a2a2bb5543198c9

Re: [PATCH] tpm: Add TPM2_GetTestResult command support

2023-07-28 Thread Ilias Apalodimas
Hi Julia, Apologies for the late response, I was on vacation. On Mon, 3 Jul 2023 at 16:03, Julia Daxenberger wrote: > > Add TPM2_GetTestResult command support and change the command file and the > help accordingly. Add Python tests and sandbox driver functionality. > > The TPM2_GetTestResult

[PATCH v2 2/5] rockchip: rk3399-pinebook-pro: Fix SPL max size and SPI flash payload offset

2023-07-28 Thread Jonas Karlman
TPL max size is limited to 184 KB, SPL is loaded to 0x0 and TF-A is loaded to 0x4, this limit SPL max size to 256 KB. With BootRom only reading first 2 KB per 4 KB page of SPI flash, 880 KB may be needed for TPL+SPL in a worst-case scenario. (184 KB + 256 KB) x 2 = 880 KB Use 0xE (896 KB)

[PATCH v2 0/5] rockchip: Fix SPI flash SPL and payload overlap

2023-07-28 Thread Jonas Karlman
This series fixes a build issue introduced in commit 5713135ecc75 ("rockchip: rockpro64: Build u-boot-rockchip-spi.bin"), reported by Peter Robinson. Closer inspection into how SPI flash is used revealed that current payload offset, 0x6, is not enough to accommodate a worst-case scenario and

[PATCH v2 4/5] rockchip: rk3399-roc-pc: Fix SPL max size and SPI flash payload offset

2023-07-28 Thread Jonas Karlman
TPL max size is limited to 184 KB, SPL is loaded to 0x0 and TF-A is loaded to 0x4, this limit SPL max size to 256 KB. With BootRom only reading first 2 KB per 4 KB page of SPI flash, 880 KB may be needed for TPL+SPL in a worst-case scenario. (184 KB + 256 KB) x 2 = 880 KB Use 0xE (896 KB)

[PATCH v2 1/5] rockchip: rk3399-rockpro64: Fix SPL max size and SPI flash payload offset

2023-07-28 Thread Jonas Karlman
TPL max size is limited to 184 KB, SPL is loaded to 0x0 and TF-A is loaded to 0x4, this limit SPL max size to 256 KB. With BootRom only reading first 2 KB per 4 KB page of SPI flash, 880 KB may be needed for TPL+SPL in a worst-case scenario. (184 KB + 256 KB) x 2 = 880 KB Use 0xE (896 KB)

[PATCH v2 3/5] rockchip: rk3399-pinephone-pro: Fix SPL max size and SPI flash payload offset

2023-07-28 Thread Jonas Karlman
TPL max size is limited to 184 KB, SPL is loaded to 0x0 and TF-A is loaded to 0x4, this limit SPL max size to 256 KB. With BootRom only reading first 2 KB per 4 KB page of SPI flash, 880 KB may be needed for TPL+SPL in a worst-case scenario. (184 KB + 256 KB) x 2 = 880 KB Use 0xE (896 KB)

[PATCH v2 5/5] doc: rockchip: Update SPI flashing instruction

2023-07-28 Thread Jonas Karlman
Update documentation on how to write a bootable u-boot-rockchip-spi.bin image into SPI flash. This removes the reference to a hardcoded and now obsolete 0x6 payload offset. Also remove an obsolete reference to pad_cat. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz --- v2: -

[PATCH v2 4/4] rockchip: rk356x-u-boot: Use relaxed u-boot,spl-boot-order

2023-07-28 Thread Jonas Karlman
BootRom will try to load TPL+SPL from media in the following order: - SPI NOR Flash - SPI NAND Flash - NAND Flash - eMMC - SDMMC SPL will try to load FIT from media in the order defined in the device tree u-boot,spl-boot-order property. Change the default order to load FIT from to: - same media

[PATCH v2 3/4] rockchip: rk356x-u-boot: Add bootph-all to common pinctrl nodes

2023-07-28 Thread Jonas Karlman
Add bootph-all prop to common pinctrl nodes for eMMC, FSPI, SD-card and UART2 that are typically used by multiple boards. Unreferenced nodes are removed from the SPL device tree during a normal build. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Rebase on

[PATCH v2 2/2] rockchip: rk3588-rock-5b: Fix SPI Flash alias

2023-07-28 Thread Jonas Karlman
The commit fd6e425be243 ("rockchip: rk3588-rock-5b: Enable boot from SPI NOR flash") enabled SPI flash support by adding a spi0 alias. Correct this by adding spi0-spi5 aliases in rk3588s-u-boot.dtsi and SF_DEFAULT_BUS=5 and SPL_DM_SEQ_ALIAS=y in defconfig. Also enabled support for parsing and

[PATCH v2 0/2] rockchip: rk35xx: Fix SPI Flash alias

2023-07-28 Thread Jonas Karlman
The series "rockchip: rk35xx: Update defconfigs and enable boot from SPI NOR flash" enabled SPI flash boot support on ROCK 3A and ROCK 5B using a spi0 alias. This spi0 alias should be used for the spi0 device tree node and not the sfc node. Correct this by adding spi4 and spi5 aliases to

[PATCH v2 1/2] rockchip: rk3568-rock-3a: Fix SPI Flash alias

2023-07-28 Thread Jonas Karlman
The commit 64f79f88a751 ("rockchip: rk3568-rock-3a: Enable boot from SPI NOR flash") enabled SPI flash support by overriding the spi0 alias. Correct this by adding a new spi4 alias in rk356x-u-boot.dtsi and SF_DEFAULT_BUS=4 and SPL_DM_SEQ_ALIAS=y in defconfig. Also enabled support for parsing and

[PATCH] Remove unused functions

2023-07-28 Thread Shenlin Liang
Function board_switch_core_volt has not been used since it was defined Signed-off-by: Shenlin Liang --- arch/arm/cpu/armv8/fsl-layerscape/soc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c b/arch/arm/cpu/armv8/fsl-layerscape/soc.c index

[PATCH v4 0/5] rockchip: rk3568: Use dwc3-generic driver

2023-07-28 Thread Jonas Karlman
This series add support for rk3568 in dwc3-generic driver and change to use the dwc3-generic driver for rk3568 devices having usb enabled. After these changes it should be possible to support usb gadget on rk3568 with e.g.: # CONFIG_USB_FUNCTION_FASTBOOT is not set CONFIG_DM_USB_GADGET=y

Re: [PATCH RFC 1/3] tools: binman: Enable getting file from specific directory

2023-07-28 Thread Neha Malcom Francis
Hi Simon On 28/07/23 08:05, Simon Glass wrote: Hi Neha, On Thu, 27 Jul 2023 at 06:12, Neha Malcom Francis wrote: While we have the option of using '-a to grab a file from a specific directory, this is problematic when searching for a filename shared by multiple files across directories. An

[PATCH v4 2/5] usb: dwc3-generic: Return early when there is no child node

2023-07-28 Thread Jonas Karlman
The current error check for device_find_first_child is not working as expected, the documentation for device_find_first_child mention: @devp: Returns first child device, or NULL if none Return: 0 Change to return early when there is no child node to avoid any possible null pointer

[PATCH v4 1/5] Revert "arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb"

2023-07-28 Thread Jonas Karlman
Remove regulator-boot-on prop from regulators now that the phy core has support for phy-supply after the commit c57e0dcd9384 ("phy: add support for phy-supply"). This reverts commit 7911f409ff20dce5995cc1b703a6e30c94022f6b. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v4: - Rebase

[PATCH v4 5/5] rockchip: rk3568: Use dwc3-generic driver

2023-07-28 Thread Jonas Karlman
Change RK3568 devices to use the newer dwc3-generic driver instead of the old xhci-dwc3 driver for USB 3.0 support. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v4: - Rebase on u-boot-rockchip/master and include change to nanopi-r5c-rk3568 and nanopi-r5s-rk3568 - Collect r-b tag

Re: [PATCH 02/16] doc: board: ti: am62x/j7200: Update with common boot flow diagram

2023-07-28 Thread Nishanth Menon
On 09:31-20230728, Heinrich Schuchardt wrote: > > > On 7/27/23 11:40, Neha Malcom Francis wrote: > > These look nice! > > > > On 27/07/23 13:30, Nishanth Menon wrote: > > > Update the bootflow svg diagram and reuse across the platforms as they > > >

[PATCH v4 3/5] usb: dwc3-generic: Relax unsupported dr_mode check

2023-07-28 Thread Jonas Karlman
When dr_mode is peripheral or otg and U-Boot has not been built with DM_USB_GADGET support, booting such device may end up with: dwc3_glue_bind_common: subnode name: usb@fcc0 Error binding driver 'dwc3-generic-wrapper': -6 Some drivers failed to bind initcall sequence effbca08

[PATCH v4 4/5] usb: dwc3-generic: Add rk3568 support

2023-07-28 Thread Jonas Karlman
RK3568 share glue and ctrl in a single node. Use glue_get_ctrl_dev to return the glue node as the ctrl node. Signed-off-by: Jonas Karlman Reviewed-by: Jagan Teki --- v4: - No change v3: - No change v2: - No change - Collect r-b tag drivers/usb/dwc3/dwc3-generic.c | 17 + 1

Re: [PATCH] docs: boards: ti: add openocd spl debugging docs

2023-07-28 Thread Nishanth Menon
On 08:52-20230728, Heinrich Schuchardt wrote: > On 7/21/23 21:19, Jason Kacines wrote: > > Add documentation on how to use OpenOCD to debug U-Boot for TI K3 > > Generation boards. > > > > Signed-off-by: Jason Kacines > > Thank you for providing OpenOCD usage

Re: [PATCH RFC 2/3] WIP: getting signing nodes to work in FIT generator node

2023-07-28 Thread Neha Malcom Francis
Hi Simon On 28/07/23 08:05, Simon Glass wrote: Hi Neha, On Thu, 27 Jul 2023 at 06:12, Neha Malcom Francis wrote: They need to get the contents of the FIT section beforehand, process them and prepend the signing certificate to the FIT contents Signed-off-by: Neha Malcom Francis ---

  1   2   >