Re: Pull request: u-boot-rockchip-20231007

2023-10-07 Thread Kever Yang
since commit be2abe73df58a35da9e8d5afb13fccdf1b0faa8e: Merge https://source.denx.de/u-boot/custodians/u-boot-riscv (2023-10-05 13:26:44 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-rockchip.git tags/u-boot-rockchip-20231007 for you

Pull request: u-boot-rockchip-20231007

2023-10-07 Thread Kever Yang
repository at: https://source.denx.de/u-boot/custodians/u-boot-rockchip.git tags/u-boot-rockchip-20231007 for you to fetch changes up to dd8d52c934e8858264f91e8e8e2d8c7d8b059dd7: rockchip: rk356x-u-boot: Add bootph-all to i2c0_xfer pinctrl node (2023-10-07 16:52:48 +0800

Pull request: u-boot-rockchip-20231007

2023-10-07 Thread Kever Yang
repository at: https://source.denx.de/u-boot/custodians/u-boot-rockchip.git tags/u-boot-rockchip-20231007 for you to fetch changes up to a7c86c57fb404df0a807c2ad9717c510150b8ebb: configs: rockchip: rk3308: enable CONFIG_OF_LIBFDT_OVERLAY (2023-10-07 10:48:16 +0800

Re: Pull request: u-boot-rockchip-20231007

2023-10-07 Thread Jonas Karlman
> Merge https://source.denx.de/u-boot/custodians/u-boot-riscv (2023-10-05 > 13:26:44 -0400) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-rockchip.git > tags/u-boot-rockchip-20231007 > > for you to fetch changes

Re: [PATCH v3 10/27] moveconfig: Use f strings where possible

2023-10-07 Thread Simon Glass
Avoid pylint warnings by using 'f' strings where possible. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 56 ++--- 1 file changed, 28 insertions(+), 28 deletions(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm,

Re: [PATCH v3 11/27] moveconfig: Correct unused variables

2023-10-07 Thread Simon Glass
Fix pylint warnings about unused variables. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!

Re: [PATCH v3 06/27] moveconfig: Drop check_defconfig() and update_dotconfig()

2023-10-07 Thread Simon Glass
These functions are not needed anymore. Drop them. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 62 ++--- 1 file changed, 2 insertions(+), 60 deletions(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!

Re: [PATCH 16/16] board: rzg2l: Add RZ/G2L SMARC EVK board

2023-10-07 Thread Marek Vasut
On 10/5/23 22:50, Paul Barker wrote: On 03/10/2023 14:36, Marek Vasut wrote: On 9/20/23 14:42, Paul Barker wrote: The Renesas RZ/G2L SMARC Evaluation Board Kit consists of the RZ/G2L System-on-Module (SOM) based on the R9A07G044L2 SoC, and a common SMARC carrier board. The ARM TrustedFirmware

Re: [PATCH 16/16] board: rzg2l: Add RZ/G2L SMARC EVK board

2023-10-07 Thread Marek Vasut
On 10/6/23 14:51, Biju Das wrote: Hi Paul, Subject: Re: [PATCH 16/16] board: rzg2l: Add RZ/G2L SMARC EVK board On 03/10/2023 14:36, Marek Vasut wrote: On 9/20/23 14:42, Paul Barker wrote: The Renesas RZ/G2L SMARC Evaluation Board Kit consists of the RZ/G2L System-on-Module (SOM) based on

Re: [PATCH] doc: Migrate Renesas board docs to rst

2023-10-07 Thread Marek Vasut
On 10/5/23 19:07, Paul Barker wrote: [...] + * - R-Car Gen3 + - Salvator-X Salvator-X(S) + - R8A77950 (H3) These ones are actually not 77950, but 77951 , all of them. + - arm64 + - ``rcar3_salvator-x_defconfig`` + + * - + - ULCB + - R8A77950 (H3) DTTO +

[PATCH 3/3] mx28evk: Add USB Mass Storage support

2023-10-07 Thread Fabio Estevam
From: Fabio Estevam Select the USB options to allow running "ums 0 mmc 0". Signed-off-by: Fabio Estevam --- configs/mx28evk_defconfig | 14 ++ 1 file changed, 14 insertions(+) diff --git a/configs/mx28evk_defconfig b/configs/mx28evk_defconfig index df0cceaea719..15cc99684c05

[PATCH 2/3] usb: ehci: mxs: Use regulator_set_enable_if_allowed()

2023-10-07 Thread Fabio Estevam
From: Fabio Estevam Since commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable() may be EALREADY or EBUSY for fixed/GPIO regulators. Swict to using the more relaxed regulator_set_enable_if_allowed() to continue if regulator already was

[PATCH v2 14/27] env: Split out non-command code into a new file

2023-10-07 Thread Simon Glass
It is not possible to set environment variables without having CONFIG_CMD_NVEDIT enabled. When CONFIG_CMDLINE is disabled, we need a way to set variables. Split the setting code out into its own file, so that env_set() is available even when CONFIG_CMDLINE is not. If it is never called, the code

[PATCH v2 12/27] Move bootmenu_conv_key() into its own file

2023-10-07 Thread Simon Glass
This conversion function is used by expo which does not require CMDLINE. The menu feature does require CMDLINE. Move the function into a separate file so that it can be used even when CMDLINE is not enabled. Signed-off-by: Simon Glass --- (no changes since v1) common/Makefile| 2 +-

[PATCH v2 19/27] log: Allow use without CONFIG_CMDLINE

2023-10-07 Thread Simon Glass
When CONFIG_SYS_CBSIZE is not used we need an alternative. For logging it seems that CONFIG_SYS_PBSIZE is a better choice anyway, so update this. Signed-off-by: Simon Glass --- (no changes since v1) common/log.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 09/27] fastboot: Declare a dependency on CMDLINE

2023-10-07 Thread Simon Glass
When CMDLINE is not enabled, this code fails to build. Correct this by adding a condition. Signed-off-by: Simon Glass --- Changes in v2: - Change this to use a Kconfig dependency instead of code failing drivers/fastboot/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 10/27] cli: Always build cli_getch

2023-10-07 Thread Simon Glass
This module is used for user input with menus, not just with the command line. Compile it always, so it is available even when CMDLINE is disabled. Signed-off-by: Simon Glass --- (no changes since v1) common/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 11/27] cmd: Use an #ifdef around run_commandf()

2023-10-07 Thread Simon Glass
This is not available if CMDLINE is disabled, so add an #ifdef to correct this. Signed-off-by: Simon Glass --- (no changes since v1) common/cli.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/cli.c b/common/cli.c index 3916a7b10a7d..4d0fea4387f2 100644 --- a/common/cli.c +++

[PATCH v2 08/27] sifive: Change #ifdef for nop

2023-10-07 Thread Simon Glass
This code is normally compiled for sifive, but sandbox can also compile it. We should not use UNIT_TEST as a synonym for SANDBOX, since it is possible to disable UNIT_TEST for sandbox. Correct the condition. Signed-off-by: Simon Glass --- (no changes since v1) include/k210/pll.h | 2 +- 1

[PATCH v2 18/27] net: Depend on CONFIG_CMDLINE

2023-10-07 Thread Simon Glass
At present it isn't possible to use networking without the command line enabled. Add this as a condition. Signed-off-by: Simon Glass Reviewed-by: Ramon Fried --- (no changes since v1) cmd/Kconfig | 1 + net/Kconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/cmd/Kconfig

[PATCH v2 13/27] pxe: Depend on CMDLINE

2023-10-07 Thread Simon Glass
We cannot use PXE or sysboot commands without CONFIG_CMDLINE so add the required condition. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index f914da6fe1ac..f9e023730c53 100644 ---

Re: [PATCH v2 04/27] bootstd: Correct dependencies on CMDLINE

2023-10-07 Thread Tom Rini
On Sat, Oct 07, 2023 at 05:12:23PM -0600, Simon Glass wrote: > With recent changes in boot/Kconfig it is no-longer possible to disable > CMDLINE. It results in various link errors because some options which > require CMDLINE are enabled regardless of whether it is available. How "recent" is this

[PATCH] cyclic: doc: Update documentation for CONFIG_CYCLIC_MAX_CPU_TIME_US

2023-10-07 Thread Weizhao Ouyang
Cyclic now just print a warning once instead of disabling the cyclic function when the cyclic function upon exceeding CPU time usage. Fixes: ddc8d36a7455 ("cyclic: Don't disable cylic function upon exceeding CPU time") Signed-off-by: Weizhao Ouyang --- doc/develop/cyclic.rst | 4 ++-- 1 file

Re: [PATCH v2 RESEND] mmc: dw_mmc: reset controller after data error

2023-10-07 Thread Tom Fitzhenry
I am able to reproduce this on RK3588 QuartzPro64. I thought "[PATCH v2 RESEND] mmc: dw_mmc: reset controller after data error"[0] might fix this, but after applying that, I am still able to reproduce the issue. 0.

[PATCH] arm: rpi: explicitly enumerate mmc boot targets

2023-10-07 Thread Ben Wolsieffer
Using the unqualified "mmc" boot target causes the Raspberry Pi 4 to fail to boot. c771e5b explains this approach as follows: > We don't need to specify the mmc devices individually, since they are > used in order from 0 to 2, and standard boot uses that order anyway. In practice, U-Boot first

[PATCH] cmd/ti: Update Kconfig logic and Makefile recursion logic

2023-10-07 Thread Tom Rini
- Add some dependencies to CMD_DDR3 as this is only valid on some platforms (which tend to select it as well). - The proper gate for going in to cmd/ti is not CONFIG_TI_COMMON_CMD_OPTIONS as nothing under there is controlled by that symbol but the general TI architecture options.

Re: [PATCH v3 17/27] moveconfig: Only show output when there is a reason

2023-10-07 Thread Simon Glass
There is no point in listing a board if everything went well. It makes it harder to see the failures, particularly on a fast machine. Suppress output unless something actually happened. Drop the 'Syncing by savedefconfig' since this is selected by the -s and is the same for all boards in this

Re: [PATCH v3 21/27] moveconfig: Show failures in progress

2023-10-07 Thread Simon Glass
Show the number of accumulated failures when processing. Use a shorter format with colour. An unwanted space appears before the defconfig name on every item except the last. Fix that while we are here. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 26

Re: [PATCH v3 19/27] moveconfig: Avoid showing progress at the end

2023-10-07 Thread Simon Glass
When the process is finished, moveconfig leaves a line saying that all boards were processed (for better or worse). Drop this, since it is unncessary. Future work will provide a summary at the end instead. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 3 ++- 1

Re: [PATCH v3 23/27] moveconfig: Drop the initial output

2023-10-07 Thread Simon Glass
Since moveconfig now just does what it is told (build database or sync defconfigs) we don't need to print what it is doing. Drop this info, which is of very little use. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 6 -- 1 file changed, 6 deletions(-) Applied

Re: [PATCH v3 25/27] moveconfig: Rename the tool to qconfig

2023-10-07 Thread Simon Glass
This does not move configs anymore, but queries them, based on a database it can build. Rename the tool to better reflect its purpose. Signed-off-by: Simon Glass --- (no changes since v1) tools/{moveconfig.py => qconfig.py} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) rename

Re: [PATCH v3 26/27] qconfig: Rename the database file

2023-10-07 Thread Simon Glass
Use qconfig.db as the new name, to reflect the tool's purpose. Signed-off-by: Simon Glass --- (no changes since v1) .gitignore | 4 ++-- tools/qconfig.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!

Re: [PATCH v3 24/27] moveconfig: Move summaries to the end

2023-10-07 Thread Simon Glass
Write the summary for -s and -b at the end, using a unified format. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm,

Re: [PATCH v3 16/27] moveconfig: Fix misc pylint warnings

2023-10-07 Thread Simon Glass
Fix various remaining pylint warnings. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!

Re: [PATCH v3 18/27] moveconfig: Reduce the amount of output

2023-10-07 Thread Simon Glass
Output a single line in the case where the defconfig only has one line of output. Show the name without the _defconfig suffix, since that is the same for all boards. Use a list for the log so it is easier to process at the end. Signed-off-by: Simon Glass --- (no changes since v1)

Re: [PATCH v3 15/27] moveconfig: Use an encoding with open()

2023-10-07 Thread Simon Glass
Fix pylint warnings about needing an explicit character encoding. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!

Re: [PATCH v3 20/27] moveconfig: Use u_boot_pylib for terminal colour

2023-10-07 Thread Simon Glass
Use the existing terminal code to handle ANSI colours. Enable colour by default if the output is going to a terminal. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 92 +++-- 1 file changed, 38 insertions(+), 54 deletions(-)

Re: [PATCH v3 12/27] moveconfig: Correct non-snake variables names

2023-10-07 Thread Simon Glass
Correct some variable names that do not conform to snake case, with the three-character minimum. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 70 ++--- 1 file changed, 35 insertions(+), 35 deletions(-) Applied to

Re: [PATCH v3 14/27] moveconfig: Correct list-comprehension warnings

2023-10-07 Thread Simon Glass
Correct some pylint warnings about needing to use list comprehension. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!

Re: [PATCH v3 13/27] moveconfig: Correct use of members not declared in __init__()

2023-10-07 Thread Simon Glass
Fix these pylint warnings. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 4 1 file changed, 4 insertions(+) Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!

[PATCH] board: rockchip: add FriendlyElec NanoPC-T6 rk3588 board

2023-10-07 Thread John Clark
NanoPC-T6 is a Rockchip RK3588 based SBC by FriendlyElec. There are four variants depending on the DRAM size: 4G/32GB eMMC, 8G/64GB eMMC, 16G/16MB SPI NOR, and 16G/256GB eMMC/16MB SPI NOR Specifications: CPU: Rockchip RK3588, 4x Cortex-A76 (up to 2.4GHz) + 4x Cortex-A55 (up to 1.8GHz)

[PATCH 1/3] usb: ehci: mxs: Fix the USB node pointer retrieval

2023-10-07 Thread Fabio Estevam
From: Fabio Estevam Use dev_ofnode() to retrieve the USB node pointer from the udevice structure. This fixes the following build error: drivers/usb/host/ehci-mxs.c:143:38: error: 'struct udevice' has no member named 'node_' Signed-off-by: Fabio Estevam --- drivers/usb/host/ehci-mxs.c | 7

Re: [PATCH 2/5] doc: capsule: Add documentation for the capsule dump feature

2023-10-07 Thread Simon Glass
On Wed, 4 Oct 2023 at 05:27, Sughosh Ganu wrote: > > Add documentation to explain the printing of the capsule headers > through the mkeficapsule tool. > > Signed-off-by: Sughosh Ganu > --- > doc/develop/uefi/uefi.rst | 17 + > 1 file changed, 17 insertions(+) Reviewed-by: Simon

Re: [PATCH] cli: Consume invalid escape sequences early

2023-10-07 Thread Simon Glass
Hi Yurii, On Fri, 6 Oct 2023 at 15:32, Yurii Monakov wrote: > > This commit fixes some issues with extra 'Esc' keys entered by user: > > 1. Sequence right after autoboot stop gives: > => > nknown command 'ry 'help' > => > 2. Sequence gives: > => ri > Unknown command 'ri' - try 'help' > => > 3.

[PATCH v2 00/27] Tidy up use of CONFIG_CMDLINE

2023-10-07 Thread Simon Glass
It should be possible to disable CONFIG_CMDLINE and have all commands and related functionality dropped from U-Boot. This is useful when trying to reduce the size of U-Boot. Recent changes have stopped this from working. This series repairs the feature for sandbox and adds a test to stop it

Re: [PATCH RESEND 5/7] spl: riscv: add os type for next booting stage

2023-10-07 Thread Simon Glass
Hi Randolph, On Fri, 6 Oct 2023 at 05:27, Randolph wrote: > > If SPL_LOAD_FIT_OPENSBI_OS_BOOT is enabled, the function > spl_invoke_opensbi should change the target OS type to IH_OS_LINUX. > OpenSBI will load the Linux image as the next boot stage. > The os_takes_devicetree function returns a

Re: [PATCH 3/5] binman: capsule: Use dumped capsule header contents for verification

2023-10-07 Thread Simon Glass
Hi Sughosh, On Wed, 4 Oct 2023 at 05:27, Sughosh Ganu wrote: > > The various fields of a generated capsule are currently verified > through hard-coded offsets. Use the dump-capsule feature for dumping > the capsule header contents and use those for capsule verification. > > Signed-off-by:

Re: [PATCH v2 8/9] test: bdinfo: Test bdinfo -m

2023-10-07 Thread Simon Glass
On Sat, 7 Oct 2023 at 15:41, Marek Vasut wrote: > > The bdinfo -m should print only the board memory layout. > Test the expected output. > > Signed-off-by: Marek Vasut > --- > Cc: Bin Meng > Cc: Mario Six > Cc: Nikhil M Jain > Cc: Simon Glass > --- > V2: Rename bdinfo_test_mem() to

[PATCH v2 20/27] video: Allow use without CONFIG_CMDLINE

2023-10-07 Thread Simon Glass
Provide a fallback for when CONFIG_SYS_CBSIZE is not provided, so that the console can still be used. Signed-off-by: Simon Glass --- (no changes since v1) drivers/video/console_truetype.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/video/console_truetype.c

[PATCH v2 23/27] cmd: Make all commands depend on CMDLINE

2023-10-07 Thread Simon Glass
If this option is disabled, commands should not be available. Convert the CMDLINE option into a menuconfig and make every command in cmd/Kconfig depend on it. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Kconfig | 29 - 1 file changed, 8 insertions(+),

[PATCH v2 27/27] sandbox: Add a test for disabling CONFIG_CMDLINE

2023-10-07 Thread Simon Glass
Now that everything is working, add a test to make sure that this builds correctly. Signed-off-by: Simon Glass --- Changes in v2: - Rebase on Tom's LONGHELP series - Correct 'of' typo test/py/tests/test_sandbox_opts.py | 20 1 file changed, 20 insertions(+) create mode

[PATCH v2 22/27] efi: Depend on CMDLINE for efi_loader

2023-10-07 Thread Simon Glass
This features currently requires the command line, so make this explicit. Future work could adjust this, but it needs effort within the booting support first, like the bootm command. Signed-off-by: Simon Glass --- (no changes since v1) lib/efi_loader/Kconfig | 1 + 1 file changed, 1

[PATCH v2 25/27] arm: x86: Drop discarding of command linker-lists

2023-10-07 Thread Simon Glass
Since we can now cleanly disable CMDLINE when needed, drop the rules which discard the command code. It will not be built in the first place. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to drop discarding of command linker-lists arch/arm/cpu/u-boot.lds | 3 ---

[PATCH v2 26/27] mmc: env: Unify the U_BOOT_ENV_LOCATION conditions

2023-10-07 Thread Simon Glass
The declaration of U_BOOT_ENV_LOCATION() uses a different #ifdef condition from the code it calls. Use the same condition to avoid a build warning if CONFIG_CMD_SAVEENV is disabled. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to unify the U_BOOT_ENV_LOCATION conditions

[PATCH v2 21/27] video: Dont require the font command

2023-10-07 Thread Simon Glass
While it is nice to have the font command, using 'select' makes it impossible to build the console code without it. Change this to use 'imply' instead. Signed-off-by: Simon Glass --- (no changes since v1) drivers/video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 07/25] tegra: Change #ifdef for nop

2023-10-07 Thread Sean Anderson
On 10/7/23 19:10, Simon Glass wrote: Hi Tom. On Sun, 24 Sept 2023 at 18:43, Tom Rini wrote: On Sun, Sep 24, 2023 at 02:39:25PM -0600, Simon Glass wrote: This code is normally compiled for Tegra, but sandbox can also compile it. We should not use UNIT_TEST as a synonym for SANDBOX, since it

[PATCH v2 24/27] sandbox: Avoid requiring cmdline

2023-10-07 Thread Simon Glass
Use 'imply' rather than 'select' for command-related options, so that it is possible to build sandbox without CONFIG_CMDLINE enabled. Signed-off-by: Simon Glass --- (no changes since v1) arch/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/Kconfig

[PATCH v2 15/27] console: Move SYS_PBSIZE into common/

2023-10-07 Thread Simon Glass
This relates to printing output and does not need a command line. Move it next to the other console-related options. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Kconfig| 5 - common/Kconfig | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 1/3] usb: ehci: mxs: Fix the USB node pointer retrieval

2023-10-07 Thread Marek Vasut
On 10/7/23 23:56, Fabio Estevam wrote: From: Fabio Estevam Use dev_ofnode() to retrieve the USB node pointer from the udevice structure. This fixes the following build error: drivers/usb/host/ehci-mxs.c:143:38: error: 'struct udevice' has no member named 'node_' How come this was never

Re: [PATCH 3/3] mx28evk: Add USB Mass Storage support

2023-10-07 Thread Marek Vasut
On 10/7/23 23:56, Fabio Estevam wrote: From: Fabio Estevam Select the USB options to allow running "ums 0 mmc 0". Signed-off-by: Fabio Estevam --- configs/mx28evk_defconfig | 14 ++ 1 file changed, 14 insertions(+) diff --git a/configs/mx28evk_defconfig

Re: [PATCH v3 09/27] moveconfig: Correct parameter-type warnings

2023-10-07 Thread Simon Glass
Fix pylint warnings related to parameter types. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 43 ++- 1 file changed, 22 insertions(+), 21 deletions(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!

Re: [PATCH v3 07/27] moveconfig: Drop suspicious boards

2023-10-07 Thread Simon Glass
This code isn't needed anymore. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 25 - 1 file changed, 25 deletions(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!

Re: [PATCH v3 08/27] moveconfig: Correct some regular-expression strings

2023-10-07 Thread Simon Glass
Use the 'r' prefix for these strings to avoid pylint warnings. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!

Re: [PATCH v3 05/27] moveconfig: Drop CONFIG-moving code

2023-10-07 Thread Simon Glass
As a step towards cleaning out old code, drop most of the code that moves CONFIG options to Kconfig. This includes parse_one_config(). Drop the ACTION_... values as well, since they are no-longer used. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 163

[PATCH v2 1/9] cmd: bdinfo: Optionally use getopt and implement bdinfo -a

2023-10-07 Thread Marek Vasut
Add optional support for getopt() and in case this is enabled via GETOPT configuration option, implement support for 'bdinfo -a'. The 'bdinfo -a' behaves exactly like bdinfo and prints 'all' the bdinfo information. This is implemented in preparation for other more fine-grained options.

[PATCH v2 2/9] cmd: bdinfo: Implement support for printing memory layout via bdinfo -m

2023-10-07 Thread Marek Vasut
Add support for printing memory layout only via 'bdinfo -m' . Reviewed-by: Simon Glass Signed-off-by: Marek Vasut --- Cc: Bin Meng Cc: Mario Six Cc: Nikhil M Jain Cc: Simon Glass --- V2: Add RB from Simon --- cmd/bdinfo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH v2 4/9] configs: sandbox: Enable GETOPT for sandbox and sandbox64 target

2023-10-07 Thread Marek Vasut
Enable GETOPT so that 'bdinfo' command with getopt() support can be tested in CI. Reviewed-by: Simon Glass Signed-off-by: Marek Vasut --- Cc: Bin Meng Cc: Mario Six Cc: Nikhil M Jain Cc: Simon Glass --- V2: Add RB from Simon --- configs/sandbox64_defconfig | 1 + configs/sandbox_defconfig

[PATCH v2 8/9] test: bdinfo: Test bdinfo -m

2023-10-07 Thread Marek Vasut
The bdinfo -m should print only the board memory layout. Test the expected output. Signed-off-by: Marek Vasut --- Cc: Bin Meng Cc: Mario Six Cc: Nikhil M Jain Cc: Simon Glass --- V2: Rename bdinfo_test_mem() to bdinfo_check_mem() --- test/cmd/bdinfo.c | 26 +++--- 1 file

[PATCH v2 6/9] test: bdinfo: Test both bdinfo and bdinfo -a

2023-10-07 Thread Marek Vasut
Factor out the core of test for all bdinfo output into bdinfo_test_all() and then reuse it to verify that both 'bdinfo' and 'bdinfo -a' print all the bdinfo output. Reviewed-by: Simon Glass Signed-off-by: Marek Vasut --- Cc: Bin Meng Cc: Mario Six Cc: Nikhil M Jain Cc: Simon Glass --- V2:

[PATCH v2 7/9] test: bdinfo: Test bdinfo -h

2023-10-07 Thread Marek Vasut
The bdinfo -h should print error message that -h is an unknown parameter and then command help text. Test the expected output. Reviewed-by: Simon Glass Signed-off-by: Marek Vasut --- Cc: Bin Meng Cc: Mario Six Cc: Nikhil M Jain Cc: Simon Glass --- V2: Add RB from Simon ---

[PATCH v2 9/9] test: bdinfo: Test bdinfo -e

2023-10-07 Thread Marek Vasut
The bdinfo -e should print only the board ethernet settings. Test the expected output. Reviewed-by: Simon Glass Signed-off-by: Marek Vasut --- Cc: Bin Meng Cc: Mario Six Cc: Nikhil M Jain Cc: Simon Glass --- V2: Add RB from Simon --- test/cmd/bdinfo.c | 14 ++ 1 file changed,

[PATCH v2 3/9] cmd: bdinfo: Implement support for printing ethernet settings via bdinfo -e

2023-10-07 Thread Marek Vasut
Add support for printing ethernet settings only via 'bdinfo -e' . Reviewed-by: Simon Glass Signed-off-by: Marek Vasut --- Cc: Bin Meng Cc: Mario Six Cc: Nikhil M Jain Cc: Simon Glass --- V2: Add RB from Simon --- cmd/bdinfo.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

[PATCH v2 5/9] test: bdinfo: Rename bdinfo_test_move() to bdinfo_test_full()

2023-10-07 Thread Marek Vasut
Rename bdinfo_test_move() to bdinfo_test_full(). The former is a remnant of deriving this test from another test. No functional change. Reviewed-by: Simon Glass Signed-off-by: Marek Vasut --- Cc: Bin Meng Cc: Mario Six Cc: Nikhil M Jain Cc: Simon Glass --- V2: Add RB from Simon ---

[PATCH] arm: mvebu: Enable bootstd for Thecus N2350 board

2023-10-07 Thread Tony Dinh
Enable bootstd for Thecus N2350 board, and remove distroboot. Signed-off-by: Tony Dinh --- configs/n2350_defconfig | 3 ++- include/configs/n2350.h | 12 +--- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/configs/n2350_defconfig b/configs/n2350_defconfig index

Re: [PATCH 5/5] binman: capsule: Add support for generating EFI empty capsules

2023-10-07 Thread Simon Glass
Hi Sugosh, On Wed, 4 Oct 2023 at 05:27, Sughosh Ganu wrote: > > Add support in binman for generating EFI empty capsules. These > capsules are used in the FWU A/B update feature. Also add test cases > in binman for the corresponding code coverage. > > Signed-off-by: Sughosh Ganu > --- >

Re: [RESEND PATCH] bootstd: sata: bootdev scanning for ahci sata with no drive attached

2023-10-07 Thread Simon Glass
On Fri, 6 Oct 2023 at 21:34, Tony Dinh wrote: > > It's normal to have no SATA drive attached to the controller, so return a > successful status when there is no block device found after probing. > > Note: this patch depends on the previous patch >

Re: [PATCH] test: Fix SPL tests not being run

2023-10-07 Thread Simon Glass
On Thu, 5 Oct 2023 at 16:24, Sean Anderson wrote: > > On 10/2/23 14:56, Simon Glass wrote: > > Hi Sean, > > > > On Mon, 2 Oct 2023 at 08:38, Sean Anderson wrote: > >> > >> On 10/1/23 15:36, Simon Glass wrote: > >> > Hi Sean, > >> > > >> > On Fri, 29 Sept 2023 at 10:12, Sean Anderson > >> >

Re: [PATCH RESEND 1/7] riscv: dts: Introduce SPL_LOAD_FIT_CONFIG symbol

2023-10-07 Thread Simon Glass
Hi Randoph, On Fri, 6 Oct 2023 at 05:26, Randolph wrote: > > Introduce common Kconfig symbol for riscv architecture > This symbol SPL_LOAD_FIT_CONFIG for binman itb layout selection > Default is using binman.dtsi > > Signed-off-by: Randolph > --- > arch/riscv/Kconfig | 7 +++

Re: [PATCH RESEND 4/7] riscv: dts: introduce SPL_LOAD_FIT_OPENSBI_OS_BOOT symbol

2023-10-07 Thread Simon Glass
Hi Randolph, On Fri, 6 Oct 2023 at 05:27, Randolph wrote: > > Introduce common Kconfig symbol for riscv architecture. > This symbol SPL_LOAD_FIT_OPENSBI_OS_BOOT is like falcon mode on ARM, > the Falcon boot is a shortcut boot method for SD/eMMC targets. It > skips the loading the RAM version

Re: [PATCH RESEND 3/7] spl: riscv: opensbi: change the default os_type as varible

2023-10-07 Thread Simon Glass
On Fri, 6 Oct 2023 at 05:26, Randolph wrote: > > In order to introduce the Opensbi OS boot mode, the next stage boot > image of OpenSBI should be configurable. > > Signed-off-by: Randolph > --- > common/spl/spl_opensbi.c | 26 -- > 1 file changed, 16 insertions(+), 10

Re: [PATCH 1/5] tools: mkeficapsule: Add support to print capsule headers

2023-10-07 Thread Simon Glass
On Wed, 4 Oct 2023 at 05:27, Sughosh Ganu wrote: > > Add support to dump the contents of capsule headers. This is useful as > a debug feature for checking the contents of the capsule headers, and > can also be used in capsule verification. > > Signed-off-by: Sughosh Ganu > --- >

[PATCH v2 02/27] cmd: Convert existing long help messages to the new macro

2023-10-07 Thread Simon Glass
From: Tom Rini - Generally we just drop the #ifdef CONFIG_SYS_LONGHELP and endif lines and use U_BOOT_LONGHELP to declare the same variable name as before - In a few places, either rename the variable to follow convention or introduce the variable as it was being done inline before.

[PATCH v2 16/27] bootm: Allow building when cleanup functions are missing

2023-10-07 Thread Simon Glass
There are two cleanup functions needed during boot which depend on CMD_BOOTM: bootm_disable_interrupts() and board_quiesce_devices() Provide static inline versions of these for when commands are not enabled. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/lib/bootm.c | 2 ++

[PATCH v2 05/27] autoboot: Correct dependencies on CMDLINE

2023-10-07 Thread Simon Glass
Make AUTOBOOT depend on CMDLINE since it is mostly meaningless without it. Signed-off-by: Simon Glass --- Changes in v2: - Move AUTOBOOT_USE_MENUKEY under AUTOBOOT boot/Kconfig | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/boot/Kconfig

[PATCH v2 06/27] cmd: Add a few more dependencies on CMDLINE

2023-10-07 Thread Simon Glass
Add this to some more commands to avoid build errors with sandbox. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Kconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index 6470b138d2f8..f914da6fe1ac 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig

[PATCH v2 04/27] bootstd: Correct dependencies on CMDLINE

2023-10-07 Thread Simon Glass
With recent changes in boot/Kconfig it is no-longer possible to disable CMDLINE. It results in various link errors because some options which require CMDLINE are enabled regardless of whether it is available. Add the necessary conditions to fix this. Note that it would be better to have all

[PATCH v2 07/27] test: Make UNIT_TEST depend on CMDLINE

2023-10-07 Thread Simon Glass
Many tests make some use of the command line, so require it for all test code. This could be teased apart, perhaps with a test flag indicating that ut uses the command line. Leave that for later. Signed-off-by: Simon Glass --- (no changes since v1) test/Kconfig | 1 + 1 file changed, 1

[PATCH v2 03/27] buildman: Use oldconfig when adjusting the config

2023-10-07 Thread Simon Glass
We cannot be sure that the new config is consistent, particularly when changing a major item like CONFIG_CMDLINE. Use 'make oldconfig' to check that and avoid any such problems. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 2 +-

Re: [PATCH 08/25] fastboot: Avoid depending on CMDLINE

2023-10-07 Thread Simon Glass
Hi Tom, On Sun, 24 Sept 2023 at 16:59, Tom Rini wrote: > > On Sun, Sep 24, 2023 at 02:39:26PM -0600, Simon Glass wrote: > > > When CMDLINE is not enabled, this code fails to build. Correct this by > > adding conditions. > > > > Note that this should not happen in normal use, since the use of > >

[PATCH v2 17/27] fdt: Move working_fdt into fdt_support

2023-10-07 Thread Simon Glass
This can be accessed even when commands are not enabled. Move it into the fdt_support.c file, which is where most of the FDT helpers are. Signed-off-by: Simon Glass --- (no changes since v1) boot/fdt_support.c | 5 + cmd/fdt.c | 5 - 2 files changed, 5 insertions(+), 5

[PATCH v2 01/27] command.h: Add a U_BOOT_LONGHELP macro

2023-10-07 Thread Simon Glass
From: Tom Rini In order to be able to discard unused long help texts without further linker lists, add a macro for defining the long help messages which uses __maybe_unused. This allows us to discard them as unreferenced as part of the link. Signed-off-by: Tom Rini Reviewed-by: Simon Glass

Re: Pull request: u-boot-rockchip-20231007

2023-10-07 Thread Kever Yang
: Merge https://source.denx.de/u-boot/custodians/u-boot-riscv (2023-10-05 13:26:44 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-rockchip.git tags/u-boot-rockchip-20231007 for you to fetch changes up

Re: [PATCH v2 RESEND] mmc: dw_mmc: reset controller after data error

2023-10-07 Thread Kever Yang
On 2023/6/19 18:33, Eugen Hristev wrote: From: Ziyuan Xu Per dw_mmc databook, it's recommended to reset the host controller if some data-related error occurred. Implement a reset mechanism. Signed-off-by: Ziyuan Xu Co-developed-by: Jason Zhu Signed-off-by: Jason Zhu

Re: [PATCH v2 RESEND] mmc: dw_mmc: reset controller after data error

2023-10-07 Thread Kever Yang
Hi Tom,     Could you have a try with rockchip vendor U-Boot, maybe still some other fixes are missing in mainline U-Boot mmc driver. Thanks, - Kever On 2023/10/7 22:37, Tom Fitzhenry wrote: I am able to reproduce this on RK3588 QuartzPro64. I thought "[PATCH v2 RESEND] mmc: dw_mmc:

Re: [PATCH v3 02/27] moveconfig: Avoid deprecation warning for setDaemon

2023-10-07 Thread Simon Glass
Use the recommended new way of setting a thread to be a daemon. This avoids a warning: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v3 04/27] moveconfig: Drop unused cleanup options

2023-10-07 Thread Simon Glass
Cleaning up the README and config.h files are not needed now, since we don't have any CONFIG options to convert. Drop this code. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 254 +--- 1 file changed, 2 insertions(+), 252

Re: [PATCH v3 03/27] moveconfig: Correct ordering of asteval import

2023-10-07 Thread Simon Glass
This should be after the standard imports. Move it to avoid a lot of pylint warnings. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks! Applied to u-boot-dm, thanks!

Re: [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions

2023-10-07 Thread Marek Vasut
On 10/2/23 15:42, Miquel Raynal wrote: Hi Marek, ma...@denx.de wrote on Sat, 30 Sep 2023 23:11:17 +0200: On 9/27/23 15:59, Miquel Raynal wrote: Hi Marek, Hi, miquel.ray...@bootlin.com wrote on Fri, 22 Sep 2023 12:00:12 +0200: Hi Marek, I'm answering here as there is no cover

Re: [PATCH RESEND v2 1/2] cmd: bind: Try to improve the (un)bind help

2023-10-07 Thread Marek Vasut
On 10/5/23 17:54, Miquel Raynal wrote: Hi Marek, ma...@denx.de wrote on Thu, 5 Oct 2023 15:01:51 +0200: On 10/2/23 15:46, Miquel Raynal wrote: While it may sound totally obvious for the regular U-Boot developer to get the parameters of the bind/unbind commands from the output of 'dm tree',

Re: [PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-07 Thread Marek Vasut
On 10/5/23 17:51, Miquel Raynal wrote: Hi Marek, ma...@denx.de wrote on Thu, 5 Oct 2023 15:04:25 +0200: On 10/2/23 15:46, Miquel Raynal wrote: At some point when trying to use USB gadgets, two situations may arise and lead to a failure. Either the UDC (USB Device Controller) is not available

  1   2   >