[PATCH v3 4/9] fs: fat: simplify gotos from read_bootsectandvi

2023-11-15 Thread christian . taedcke-oss
From: Christian Taedcke This simplifies the code a little bit. Signed-off-by: Christian Taedcke --- (no changes since v2) Changes in v2: - Keep one goto label instead of removing both - Move changing gotos from read_bootsectandvi() into separate commit fs/fat/fat.c | 9 - 1 file

[PATCH v3 3/9] fs: fat: calculate FAT type based on cluster count

2023-11-15 Thread christian . taedcke-oss
From: Christian Taedcke This fixes an issue where the FAT type (FAT12, FAT16) is not correctly detected, e.g. when the BPB field BS_FilSysType contains the valid value "FAT ". According to the FAT spec the field BS_FilSysType has only informational character and does not determine the FAT

[PATCH v3 0/9] fs: fat: calculate FAT type based on cluster count

2023-11-15 Thread christian . taedcke-oss
From: Christian Taedcke This series fixes an issue where the FAT type (FAT12, FAT16) is not correctly detected, e.g. when the BPB field BS_FilSysType contains the valid value "FAT ". This issue occures, for example, if a partition is formatted by swupdate using its diskformat handler.

[PATCH v3 1/9] fs: fat: use get_unaligned_le16 to convert u8[2] to u16

2023-11-15 Thread christian . taedcke-oss
From: Christian Taedcke This reduces code duplications. Signed-off-by: Christian Taedcke --- (no changes since v2) Changes in v2: - Use get_unaligned_le16 instead of custom macro fs/fat/fat.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/fat/fat.c

[PATCH v3 2/9] test: spl: Remove usage of FAT32_SIGN

2023-11-15 Thread christian . taedcke-oss
From: Christian Taedcke FAT32_SIGN is removed in the following commits. Signed-off-by: Christian Taedcke --- (no changes since v2) Changes in v2: - Move code change in test/image/spl_load_fs.c into separate commit test/image/spl_load_fs.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v3 2/5] gpio: qcom_pmic: rework pwrkey driver into a button driver

2023-11-15 Thread Jaehoon Chung
Dear Caleb, On 11/14/23 22:48, Caleb Connolly wrote: > The power and resin keys were implemented as GPIOs here, but their only > use would be as buttons. Avoid the additional layer of introspection and > rework this driver into a button driver. > > While we're here, replace the

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
+Heinrich Schuchardt Hi Shantur, On Wed, 15 Nov 2023 at 05:59, Shantur Rathore wrote: > > Hi all, > > I am facing an issue with bootflow where grub efi crashes only when > bootflow is selected manually. > > Board - RockPro64 > OS - Armbian Bookworm CLI > U-boot : 2024.01-rc2 > Built and

Re: [PATCH v3 2/5] gpio: qcom_pmic: rework pwrkey driver into a button driver

2023-11-15 Thread Caleb Connolly
On 15/11/2023 12:57, Jaehoon Chung wrote: > Dear Caleb, > > On 11/14/23 22:48, Caleb Connolly wrote: >> The power and resin keys were implemented as GPIOs here, but their only >> use would be as buttons. Avoid the additional layer of introspection and >> rework this driver into a button

Re: [PATCH v4 00/16] Introduce initial TI's J784S4 and AM69 support

2023-11-15 Thread Maxime Ripard
Hi, On Sun, Oct 01, 2023 at 10:25:29PM +0530, Apurva Nandan wrote: > This series will introduce basic support (SD and UART) support for Texas > Instruments J784S4 EVM. > > The J784S4 SoC device tree patches are taken from kernel patch submissions > and will be updated as they are accepted and

Re: u-boot fails to build on sparc64 due redefinition of 'struct termio'

2023-11-15 Thread John Paul Adrian Glaubitz
Hi Simon, On Wed, 2023-11-15 at 06:40 -0700, Simon Glass wrote: > Hi Adrian, > > On Wed, 15 Nov 2023 at 00:27, John Paul Adrian Glaubitz > wrote: > > > > Hello! > > > > On Linux sparc64, building u-boot fails with [1]: > > > > cc -o tools/mkenvimage tools/mkenvimage.o tools/os_support.o >

Re: [PATCH] mtd: rawnand: omap_gpmc: fix BCH8 HW based correction

2023-11-15 Thread Michael Nazzareno Trimarchi
Hi On Wed, Nov 15, 2023 at 11:37 AM Leto, Enrico wrote: > > Patch is working by me. > > > -Original Message- > > From: Heiko Schocher > > Sent: Wednesday, November 15, 2023 6:41 AM > > To: U-Boot Mailing List ; Leto, Enrico (SI BP R ZG > > FW > > CCP) > > Cc: Schocher, Heiko (EXT)

Re: [PATCH] mmc: sdhci-cadence: Add support for Cadence sdmmc v6

2023-11-15 Thread Jaehoon Chung
On 11/15/23 12:36, KuanLim.Lee wrote: > Hi Jaehoon, > If there are no more feedback, I will send out version2 patch soon. > > On 11/7/23 14:24, Kuan Lim Lee wrote: >> >> Hi Jaehoon, >> >> On 11/1/23 08:20, Jaehoon Chung wrote: >>> From: Jaehoon Chung Hi >>> >>> On 10/3/23 16:22, Kuan Lim Lee

[PATCH 3/6] risc-v: add support for QEMU provided ACPI tables

2023-11-15 Thread Heinrich Schuchardt
If U-Boot provides ACPI tables on RISC-V QEMU, we need to copy what QEMU provides. Provide the qfw command to retrieve information from the QEMU firmware. Signed-off-by: Heinrich Schuchardt --- board/emulation/qemu-riscv/Kconfig | 2 ++ lib/Kconfig| 2 +- 2 files

[PATCH 4/6] riscv: qemu: copy ACPI tables from QEMU

2023-11-15 Thread Heinrich Schuchardt
If CONFIG_GENERATE_ACPI_TABLES=y, read the ACPI tables provided by QEMU and make them available to U-Boot. Signed-off-by: Heinrich Schuchardt --- board/emulation/qemu-riscv/qemu-riscv.c | 17 + 1 file changed, 17 insertions(+) diff --git

[PATCH 6/6] configs: defconfig for QEMU RISC-V with ACPI

2023-11-15 Thread Heinrich Schuchardt
Provide a defconfig for testing ACPI on RISC-V. Signed-off-by: Heinrich Schuchardt --- board/emulation/qemu-riscv/MAINTAINERS| 1 + configs/qemu-riscv64_acpi_smode_defconfig | 27 +++ 2 files changed, 28 insertions(+) create mode 100644

[PATCH 2/6] risc-v: add ACPI fields to global data

2023-11-15 Thread Heinrich Schuchardt
Add fields for the location of ACPI tables to the global data. Signed-off-by: Heinrich Schuchardt --- arch/riscv/include/asm/global_data.h | 4 1 file changed, 4 insertions(+) diff --git a/arch/riscv/include/asm/global_data.h b/arch/riscv/include/asm/global_data.h index

[PATCH 5/6] riscv: allow usage of ACPI

2023-11-15 Thread Heinrich Schuchardt
Select CONFIG_SUPPORT_ACPI to allow usage of ACPI tables with RISC-V. Signed-off-by: Heinrich Schuchardt --- arch/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/Kconfig b/arch/Kconfig index 4f5b75129f..d79b744bd6 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -108,6 +108,7 @@

[PATCH 2/2] arm: dts: k3-*-binman: Move to using templated FITs

2023-11-15 Thread Neha Malcom Francis
Reduce redundancy in code by using templates to generate the A72 boot binaries (tispl.bin and u-boot.img) as well as R5 boot binary sysfw.itb (for legacy boot following devices J721E and AM65x). Signed-off-by: Neha Malcom Francis --- arch/arm/dts/k3-am625-sk-binman.dtsi | 157 +

[PATCH 1/2] arm: dts: k3-binman: Add support for FIT templates

2023-11-15 Thread Neha Malcom Francis
Add templates for FIT images used extensively across K3 boards with most of the code common. This includes the FIT portions of: - tispl.bin - u-boot.img - sysfw.itb (in case of legacy boot flow) Signed-off-by: Neha Malcom Francis --- arch/arm/dts/k3-binman.dtsi | 327

[PATCH 0/2] Cleanup K3 binman FIT images

2023-11-15 Thread Neha Malcom Francis
Instead of duplicating the same FIT formats over and over again for different K3 devices, make use of the templating support to have FIT templates for the same. Note: I purposely did not add the trial to template out the non-FIT bootloader image (tiboot3.bin) as it reduces the readibility and

Re: [PATCH] bootstage: Correct exhasuted typo

2023-11-15 Thread Simon Glass
On Tue, 7 Nov 2023 at 02:18, Patrick Delaunay wrote: > > From: Simon Glass > > Correct this typo in the warning message shown when no more bootstage > records can be added. > > Signed-off-by: Simon Glass > Signed-off-by: Patrick Delaunay > --- > I just cherry-pick the Simon's patch in the

Re: [PATCH] sandbox: Close file after mmaping it

2023-11-15 Thread Simon Glass
On Sat, 4 Nov 2023 at 19:57, Sean Anderson wrote: > > After opening pathname, we must close ifd once we are done with it. > > Fixes: b9274095c2c ("sandbox: Add a way to map a file into memory") > Signed-off-by: Sean Anderson > --- > > arch/sandbox/cpu/os.c | 15 ++- > 1 file

Re: [PATCH 1/1] dm: Do not enable debug messages by default

2023-11-15 Thread Simon Glass
On Sat, 4 Nov 2023 at 18:40, Heinrich Schuchardt wrote: > > CONFIG_DM_WARN has a text indicating that these messages should only > provided when debugging. This implies that the setting must be default no. > > We should still create debug messages. > > Reported-by: Andre Przywara >

Re: [PATCH 5/5] patman: Correct Python 3.6 behaviour

2023-11-15 Thread Simon Glass
The importlib_resources import is not actually used. Fix this so that patman can run on Python 3.6 to some extent, once 'pip3 install importlib-resources' has been run. Signed-off-by: Simon Glass --- tools/patman/__main__.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Applied

Re: [PATCH 4/5] patman: Avoid using func_test at top level

2023-11-15 Thread Simon Glass
Import this only when it is needed, since it is not present when installed via 'pip install'. Signed-off-by: Simon Glass Fixes: https://source.denx.de/u-boot/u-boot/-/issues/26 --- tools/patman/__main__.py | 1 - 1 file changed, 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH 3/5] patman: Correct easy pylint warnings in __main__

2023-11-15 Thread Simon Glass
Tidy up the code a little to reduce the number of pylint warnings. Signed-off-by: Simon Glass --- tools/patman/__main__.py | 32 1 file changed, 16 insertions(+), 16 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 2/5] patman: Move the main program into a function

2023-11-15 Thread Simon Glass
Add a new run_patman() function to hold the main logic. Signed-off-by: Simon Glass --- tools/patman/__main__.py | 127 +-- 1 file changed, 67 insertions(+), 60 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 02/29] mmc: env: Unify the U_BOOT_ENV_LOCATION conditions

2023-11-15 Thread Heinrich Schuchardt
On 11/12/23 01:08, Simon Glass wrote: The declaration of U_BOOT_ENV_LOCATION() uses a different #ifdef condition from the code it calls. Use the same condition to avoid a build warning if CONFIG_CMD_SAVEENV is disabled. Signed-off-by: Simon Glass --- env/mmc.c | 2 +- 1 file changed, 1

Re: [PATCH v3 01/12] efi: Correct handling of frame buffer

2023-11-15 Thread Simon Glass
On Mon, Oct 2, 2023 at 10:23 AM Simon Glass wrote: > > The efi_gop driver uses private fields from the video uclass to obtain a > pointer to the frame buffer. Use the platform data instead. > > Check the VIDEO_COPY setting to determine which frame buffer to use. Once > the next stage is running

Re: [PATCH 1/5] patman: Split out arg parsing into its own file

2023-11-15 Thread Simon Glass
Move this code into a separate cmdline module, as is done with the other tools. Use the same HAS_TESTS check as buildman Signed-off-by: Simon Glass --- tools/patman/__main__.py | 116 +- tools/patman/cmdline.py | 147 +++ 2

Re: [PATCH v3 06/12] expo: Correct background colour

2023-11-15 Thread Simon Glass
On Mon, Oct 2, 2023 at 9:30 AM Simon Glass wrote: > > Use the correct background colour when using white-on-black. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > boot/expo.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng Applied to

Re: [PATCH v3 03/12] bootstd: Add a return code to bootflow menu

2023-11-15 Thread Simon Glass
Return an error when the user does not select an OS, so we know whether to boot or not. Move calling of bootflow_menu_run() into a separate function so we can call it from other places. Expand the test to cover these cases. Add some documentation also, while we are here. Signed-off-by: Simon

Re: [PATCH v3 02/12] bootstd: Refactor mmc prep to allow a different scan

2023-11-15 Thread Simon Glass
Adjust scan_mmc4_bootdev() and related function so that the caller can do its own 'bootflow scan' command. This allows it to change the flags if needed. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to refactor mmc prep to allow a different scan test/boot/bootflow.c | 49

Re: [PATCH 00/34] x86: expo: Add support for editing coreboot CMOS RAM settings

2023-11-15 Thread Simon Glass
Hi Bin, On Sun, 1 Oct 2023 at 19:16, Simon Glass wrote: > > U-Boot provides support for editing settings with an 'expo', as well as > reading and writing settings to CMOS RAM. > > This series integrates expo functionality with coreboot, using the > sysinfo table to get a list of settings,

Re: [PATCH] arm64: zynqmp: Do not expose usbhub nodes

2023-11-15 Thread Michal Simek
On 11/6/23 16:55, Michal Simek wrote: Upstream dwc3 U-Boot driver is not able to handle child nodes properly that's why comment them in DT for now. This patch should be reverted when dwc3 driver handles it properly. DT node itself is aligned with dt schema. Signed-off-by: Michal Simek ---

Re: [PATCH] arm64: zynqmp: Remove description for 8T49N240

2023-11-15 Thread Michal Simek
On 11/8/23 08:36, Michal Simek wrote: 8T49N240 driver was never upstreamed by IDT and there is no user of this driver that's why remove description for this chip with also remove this driver. Signed-off-by: Michal Simek Reviewed-by: Radhey Shyam Pandey ---

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Shantur Rathore
HI Simon, Thanks for the speedy reply. I can confirm patch [2] fixes the problem - at least on the USB2.0 port on RockPro64. I see some issue with the USB disk being unable to provide its size on the USB3.0 port but that might not be linked to bootflow. PS - Also tested with

Re: [PATCH 4/8] configs: am62ax_evm_a53_defconfig: Enable networking

2023-11-15 Thread Roger Quadros
On 13/11/2023 16:51, Nishanth Menon wrote: > Enable networking > > Signed-off-by: Nishanth Menon > --- > configs/am62ax_evm_a53_defconfig | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/configs/am62ax_evm_a53_defconfig > b/configs/am62ax_evm_a53_defconfig >

Re: [PATCH v5 11/20] efi: x86: Correct the condition for installing ACPI tables

2023-11-15 Thread Simon Glass
Hi Heinrich, On Wed, 15 Nov 2023 at 04:09, Heinrich Schuchardt wrote: > > On 9/20/23 05:00, Simon Glass wrote: > > It is not always the case that U-Boot builds the ACPI tables itself. For > > example, when booting from coreboot, the ACPI tables are built by > > coreboot. > > > > Correct the

Re: u-boot fails to build on sparc64 due redefinition of 'struct termio'

2023-11-15 Thread Simon Glass
Hi Adrian, On Wed, 15 Nov 2023 at 00:27, John Paul Adrian Glaubitz wrote: > > Hello! > > On Linux sparc64, building u-boot fails with [1]: > > cc -o tools/mkenvimage tools/mkenvimage.o tools/os_support.o > tools/lib/crc32.o > In file included from /<>/tools/termios_linux.h:33, >

Re: [RESEND PATCH v2] efi_loader: Fix UEFI variable error handling

2023-11-15 Thread Weizhao Ouyang
On Wed, Nov 15, 2023 at 6:15 PM Heinrich Schuchardt wrote: > > On 11/13/23 17:10, Weizhao Ouyang wrote: > > Try to catch error the earlier way. > > > > Signed-off-by: Weizhao Ouyang > > --- > > lib/efi_loader/efi_var_file.c | 4 +++- > > lib/efi_loader/efi_variable.c | 2 -- > > 2 files

Re: [PATCH] mtd: rawnand: omap_gpmc: fix BCH8 HW based correction

2023-11-15 Thread Heiko Schocher
Hello Michael, On 15.11.23 11:38, Michael Nazzareno Trimarchi wrote: > Hi > > On Wed, Nov 15, 2023 at 11:37 AM Leto, Enrico wrote: >> >> Patch is working by me. >> >>> -Original Message- >>> From: Heiko Schocher >>> Sent: Wednesday, November 15, 2023 6:41 AM >>> To: U-Boot Mailing List

Re: [PATCH v5 11/20] efi: x86: Correct the condition for installing ACPI tables

2023-11-15 Thread Heinrich Schuchardt
On 9/20/23 05:00, Simon Glass wrote: It is not always the case that U-Boot builds the ACPI tables itself. For example, when booting from coreboot, the ACPI tables are built by coreboot. Correct the Makefile condition so that U-Boot can pass on tables built by a previous firmware stage. Tidy up

Re: [PATCH] mtd: rawnand: omap_gpmc: fix BCH8 HW based correction

2023-11-15 Thread Roger Quadros
On 15/11/2023 07:40, Heiko Schocher wrote: > commit 04fcd2587321 ("mtd: rawnand: omap_gpmc: Fix BCH6/16 HW based > correction") > > broke AM335x based boards booting from NAND with ECC BCH8 code. > > Use omap_enable_hwecc() instead of omap_enable_hwecc_bch() > in SPL restores correct SPL

[PATCH 1/6] acpi: do not write ACPI tables on TARGET_QEMU_VIRT

2023-11-15 Thread Heinrich Schuchardt
RISC-V QEMU provides the ACPI tables. We do not need to generate them ourselves. Signed-off-by: Heinrich Schuchardt --- lib/acpi/Makefile | 2 +- lib/acpi/acpi_writer.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/acpi/Makefile b/lib/acpi/Makefile index

[PATCH 0/6] risc-v: add ACPI support on QEMU

2023-11-15 Thread Heinrich Schuchardt
QEMU 8.1.2 can create ACPI tables for the RISC-V architecture. Allow passing them through to the operating system. Provide a new defconfig that enables this. Heinrich Schuchardt (6): acpi: do not write ACPI tables on TARGET_QEMU_VIRT risc-v: add ACPI fields to global data risc-v: add

Re: [RESEND PATCH v2] efi_loader: Fix UEFI variable error handling

2023-11-15 Thread Heinrich Schuchardt
On 11/13/23 17:10, Weizhao Ouyang wrote: Try to catch error the earlier way. Signed-off-by: Weizhao Ouyang --- lib/efi_loader/efi_var_file.c | 4 +++- lib/efi_loader/efi_variable.c | 2 -- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_var_file.c

Re: [PATCH V2 0/4] arm: dts: k3-am625*: Upgrade kernel dts to v6.7-rc1

2023-11-15 Thread Roger Quadros
On 15/11/2023 05:28, Nishanth Menon wrote: > Hi, > rev 2 of the series to sync am62 with v6.7-rc1. > > Changes: > - picked up reviews, tested tags. > - minor commit message correction in patch #4. > > Boot logs: > https://gist.github.com/nmenon/d62c4795c6d3d40c83ba36d1cd047c42 > > WARNING:

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-15 Thread Shantur Rathore
Hi Marek, > What is the point of this growing CC list ? Apologies, this is my first time with email based patch management. I was reading articles on best practices and first one mentioned to cc people with recent commits, second one mentioned to use get_maintainer script to cc people and hence

RE: [PATCH] mtd: rawnand: omap_gpmc: fix BCH8 HW based correction

2023-11-15 Thread Leto, Enrico
Patch is working by me. > -Original Message- > From: Heiko Schocher > Sent: Wednesday, November 15, 2023 6:41 AM > To: U-Boot Mailing List ; Leto, Enrico (SI BP R ZG FW > CCP) > Cc: Schocher, Heiko (EXT) (DENX Software Engineering GmbH) ; > Dario Binacchi ; Michael Trimarchi > >

bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Shantur Rathore
Hi all, I am facing an issue with bootflow where grub efi crashes only when bootflow is selected manually. Board - RockPro64 OS - Armbian Bookworm CLI U-boot : 2024.01-rc2 Built and installed in SPI Boot Device = USB drive connected to USB 2.0 port Success scenario : => setenv boot_targets usb

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Shantur Rathore
Hi Simon, I have figured out the cause of the crash. It happens here - https://github.com/u-boot/u-boot/blob/master/boot/bootflow.c#L470 while doing - free(bflow->buf) As I understand it, - Just before starting kernel EFI binary calls usb-uclass->usb_stop() - This starts removing all devices in

Re: [PATCH 11/29] image: Document error codes from fit_image_load()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:08:56PM -0700, Simon Glass wrote: > Put a list of these in the function documentation so it is easier to > decode what went wrong. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH 12/29] bootm: Adjust boot_get_kernel() to return an error

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:08:57PM -0700, Simon Glass wrote: > This function obtains lots of error codes and then throws them away. > Update it to return the error, moving the image pointer to an > argument. > > Signed-off-by: Simon Glass [snip] > @@ -217,25 +220,28 @@ static const void

Re: [PATCH 09/29] image: Tidy up genimg_get_kernel_addr_fit()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:08:54PM -0700, Simon Glass wrote: > This function does not modify its first argument, so mark it const. Also > move the comments to the header file and expand them to provide more > useful information. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom

Re: [PATCH 08/29] bootm: Move boot_get_kernel() higher in the file

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:08:53PM -0700, Simon Glass wrote: > Move this code and image_get_kernel() higher in the file to avoid the > need for a forward declaration. > > No attempt is made to remove #ifdefs or adjust the code in any other > way. > > Signed-off-by: Simon Glass Reviewed-by:

Re: [PATCH 10/29] bootm: Reduce arguments to boot_get_kernel()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:08:55PM -0700, Simon Glass wrote: > This function only uses one argument and just needs to know the name of > the command which called it. Adjust the function to use only what it > needs. This will make it easier to call from a non-command context. > > Tidy up the

Re: [PATCH 06/29] bootm: Drop arguments from bootm_start()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:08:51PM -0700, Simon Glass wrote: > This function does not use its arguments. Drop them. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH 15/29] bootm: Move error printing out of boot_get_kernel()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:09:00PM -0700, Simon Glass wrote: > The same error message is printed in two places. Move it out to the > caller so we can avoid passing in the command name. Leave the bootstage > handling where it is. > > Signed-off-by: Simon Glass [snip] > @@ -322,9 +316,12 @@

Re: [PATCH 17/29] bootm: Reduce arguments to boot_get_ramdisk()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:09:02PM -0700, Simon Glass wrote: > This function normally only uses one argument so pass it in directly. > Move comments to the header file so could one day include these > functions in API docs. Fix up the u8 argument while here, since it > avoids the compiler having

Re: [PATCH 18/29] fdt: Allow use of fdt_support inside if() statements

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:09:03PM -0700, Simon Glass wrote: > Most of the fdt_support.h header file is included only if OF_LIBFDT or > OF_CONTROL are enabled. This means that calling functions defined in > that file must happen inside an #ifdef > > This is unnecessary, so reduce the condition

Re: [PATCH 14/29] bootstage: Drop BOOTSTAGE_ID_FIT_KERNEL_INFO

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:08:59PM -0700, Simon Glass wrote: > This is a misnomer since we don't necessarily know that the image is a > FIT. Use the existing BOOTSTAGE_ID_CHECK_IMAGETYPE instead. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP

Re: [PATCH 16/29] bootm: Reduce arguments to boot_find_os()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:09:01PM -0700, Simon Glass wrote: > This function only uses one argument so pass it in directly. > > Signed-off-by: Simon Glass Aside from a typo in the subject (boot_ not bootm_): Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH 13/29] bootm: Use the error return from boot_get_kernel()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:08:58PM -0700, Simon Glass wrote: > Rather than looking for a zero-sized image, use the error code returned > to determine if things are OK. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH 21/29] bootm: Reduce arguments to boot_get_fdt()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:09:06PM -0700, Simon Glass wrote: > This function only uses one argument from bootm (argv[2]) so pass it in > directly. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: Please pull u-boot-dm

2023-11-15 Thread Tom Rini
On Wed, Nov 15, 2023 at 06:19:26AM -0700, Simon Glass wrote: > Hi Tom, > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/18586 > > https://dev.azure.com/simon0972/u-boot/_build/results?buildId=55=results > > > The following changes since commit

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Heinrich Schuchardt
Am 15. November 2023 23:15:46 MEZ schrieb Simon Glass : >Hi Shantur, > >On Wed, 15 Nov 2023 at 15:13, Shantur Rathore wrote: >> >> Hi Simon, >> >> I have figured out the cause of the crash. >> It happens here - >> https://github.com/u-boot/u-boot/blob/master/boot/bootflow.c#L470 >> while doing

[BUG] usage of $kernel_addr_r in distro_efi_boot()

2023-11-15 Thread Heinrich Schuchardt
If $kernel_addr_r cannot be read, distro_efi_boot() falls back to address 0. This will lead to a segmentation fault on many systems. distro_efi_read_bootflow_net() has a fallback to CONFIG_SYS_LOAD_ADDR and may have loaded to that address. Shouldn't we be consistent in what we program? Please,

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Shantur, On Wed, 15 Nov 2023 at 15:13, Shantur Rathore wrote: > > Hi Simon, > > I have figured out the cause of the crash. > It happens here - > https://github.com/u-boot/u-boot/blob/master/boot/bootflow.c#L470 > while doing - free(bflow->buf) > > As I understand it, > - Just before starting

Re: [PATCH 23/29] bootm: Reduce arguments to boot_get_loadables()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:09:08PM -0700, Simon Glass wrote: > This function only uses two arguments. The 'arch' always has a constant > value, so drop it. This simplifies the function call. > > Tidy up the function comment while we are here. > > Signed-off-by: Simon Glass Reviewed-by: Tom

Re: [PATCH 28/29] bootm: Add a function to check overlap

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:09:13PM -0700, Simon Glass wrote: > Move this code into a function to reduce code size and make it easier > to understand. Drop the unnecessary 0x to help a little with code size. > > Use this in bootm_find_images() > > Signed-off-by: Simon Glass Reviewed-by: Tom

Re: [PATCH 29/29] bootm: Reduce arguments to bootm_find_other()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:09:14PM -0700, Simon Glass wrote: > Rather than passing the full list of command arguments, pass only those > which are needed. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH 24/29] bootm: Simplify Android ramdisk addr in bootm_find_images()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:09:09PM -0700, Simon Glass wrote: > The Android mechanism uses the loadaddr envrionment-variable to get the > load address, if none is provided. This is equivalent to > image_load_addr so use that instead, converting it to a string as > needed. > > This change will

Re: [PATCH 27/29] bootm: Adjust the parameters of bootm_find_images()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:09:12PM -0700, Simon Glass wrote: > Rather than passing it all the command-line args, pass in the pieces > that it needs. These are the image address, the ramdisk address/name > and the FDT address/name. > > Ultimately this will allow usage of this function without

Re: [PATCH 22/29] bootm: Reduce arguments to boot_get_fpga()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:09:07PM -0700, Simon Glass wrote: > This function only uses two arguments. The 'arch' always has a constant > value, so drop it. This simplifies the function call. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP

Re: inconsistent wget behavior

2023-11-15 Thread Fabio Estevam
Hi Paul, On Wed, Nov 8, 2023 at 10:24 PM Fabio Estevam wrote: > I was not able to see a failure when using "tftp" to transfer the same > 420MB file. > > The number of bytes transferred and md5sum always match, so this is a wget > bug. There was another user who confirmed the same issue:

Re: [PATCH 07/29] bootm: Simplify arguments for bootm_pre_load()

2023-11-15 Thread Tom Rini
On Sat, Nov 11, 2023 at 05:08:52PM -0700, Simon Glass wrote: > Move the argument decoding to the caller, to avoid needing to pass the > command-line arguments. > > Add a function comment while we are here. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc

Bug in distro_efi_boot()

2023-11-15 Thread Heinrich Schuchardt
Hello Simon, In function distro_efi_boot() the bootefi command is called. The second argument should only be passed if a device-tree has actually been loaded. But this is not what the code does: For network boot methods the value of $fdt_addr_r is passed as second parameter though possibly no

Re: [PATCH v1 0/5] Convert recently merged T30 boards to use DM PMIC

2023-11-15 Thread Thierry Reding
On Mon, Nov 13, 2023 at 04:52:22PM +, Peter Robinson wrote: > > > > > > > > Since the proposed PMIC patches have been accepted, I see the > > > > > > > > need > > > > > > > > to convert boards which I maintain to use DM drivers instead of > > > > > > > > board hacks. > > > > > > > > > > > >

Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

2023-11-15 Thread Fabio Estevam
Hi Benjamin, You should have indicated that this is v7. The subject should be: [PATCH v7] pico-imx7d: add baseboard SD card boot detect No need for adding 1/1 for a single patch. On Tue, Nov 7, 2023 at 7:16 PM wrote: > > From: Benjamin Szőke > > Technexion PICO-IMX7 SoM is supporting USDHC3

Re: [PATCH] arm: dts: k3-am625-verdin-wifi-dev-u-boot.dtsi: Fix DMA with BCDMA

2023-11-15 Thread Marcel Ziswiler
Hi Roger On Tue, 2023-11-14 at 22:28 +0200, Roger Quadros wrote: > BCDMA can be used at SPL for OSPI boot and mem-to-mem DMA > so add "bootph-all" to BCDMA node. Might not be strictly required (at least we do not support OSPI boot on our HW) but also does not hurt. > Suggested-by: Nishanth

Re: [PATCH 0/2] Cleanup K3 binman FIT images

2023-11-15 Thread Marcel Ziswiler
Hi Neha On Wed, 2023-11-15 at 15:40 +0530, Neha Malcom Francis wrote: > Instead of duplicating the same FIT formats over and over again for > different K3 devices, make use of the templating support to have FIT > templates for the same. > > Note: I purposely did not add the trial to template

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-15 Thread Marek Vasut
On 11/15/23 09:26, Shantur Rathore wrote: Hi Marek, Hi, What is the point of this growing CC list ? Apologies, this is my first time with email based patch management. I was reading articles on best practices and first one mentioned to cc people with recent commits, second one mentioned to

Re: [PATCH v1 0/5] Convert recently merged T30 boards to use DM PMIC

2023-11-15 Thread Thierry Reding
On Mon, Nov 06, 2023 at 04:04:07PM -0500, Tom Rini wrote: > On Mon, Nov 06, 2023 at 02:11:16PM +, Peter Robinson wrote: > > On Mon, Nov 6, 2023 at 1:28 PM Svyatoslav Ryhel wrote: > > > > > > пн, 6 лист. 2023 р. о 15:13 Peter Robinson пише: > > > > > > > > On Mon, Nov 6, 2023 at 11:58 AM

Re: [PATCH v4 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-15 Thread Simon Glass
Hi Heinrich, On Sun, 12 Nov 2023 at 16:35, Heinrich Schuchardt wrote: > > > > Am 12. November 2023 22:20:50 MEZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Sun, 12 Nov 2023 at 13:32, Heinrich Schuchardt wrote: > >> > >> > >> > >> Am 12. November 2023 21:02:42 MEZ schrieb Simon Glass : > >>

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Shantur, On Wed, 15 Nov 2023 at 07:50, Shantur Rathore wrote: > > Hi Simon, > > I did some testing on the USB 3.0 port and it seems like bootflow > causes something to happen to the USB. > It seems to be only reproducible on the USB3.0 port. > > I am using an AMicro AM8180 NVME to USB

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Shantur, On Wed, 15 Nov 2023 at 07:12, Shantur Rathore wrote: > > HI Simon, > > Thanks for the speedy reply. > I can confirm patch [2] fixes the problem - at least on the USB2.0 > port on RockPro64. > I see some issue with the USB disk being unable to provide its size on > the USB3.0 port but

Re: [PATCH v4 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-15 Thread Shantur Rathore
On Sun, Nov 12, 2023 at 8:04 PM Simon Glass wrote: > > When a USB device is unbound, it causes any bootflows attached to it to > be removed, via a call to bootdev_clear_bootflows() from > bootdev_pre_unbind(). This obviously makes it impossible to boot the > bootflow. > > However, when booting a

[PATCH v2 2/5] fastboot: implement "getvar all"

2023-11-15 Thread Svyatoslav Ryhel
From: Ion Agorria This commit implements "fastboot getvar all" listing by iterating the existing dispatchers that don't require parameters (as we pass NULL), uses fastboot multiresponse. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek ---

[PATCH v2 4/5] lib: membuff: fix readline not returning line in case of overflow

2023-11-15 Thread Svyatoslav Ryhel
From: Ion Agorria If line overflows readline it will not be returned, fix this behavior, make it optional and documented properly. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel --- boot/bootmeth_extlinux.c | 2 +- common/console.c | 2 +- include/membuff.h| 5

[PATCH v2 5/5] fastboot: add oem console command support

2023-11-15 Thread Svyatoslav Ryhel
From: Ion Agorria "oem console" serves to read console record buffer. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel --- doc/android/fastboot.rst | 1 + drivers/fastboot/Kconfig | 7 +++ drivers/fastboot/fb_command.c | 39 +++

Re: [PATCH v4 09/12] x86: Enable SSE in 64-bit mode

2023-11-15 Thread Mark Kettenis
> From: Simon Glass > Date: Tue, 14 Nov 2023 17:48:25 -0700 > > Hi, > > On Tue, 14 Nov 2023 at 17:44, Bin Meng wrote: > > > > Hi Tom, > > > > On Wed, Nov 15, 2023 at 12:22 AM Tom Rini wrote: > > > > > > On Tue, Nov 14, 2023 at 09:49:08AM +0800, Bin Meng wrote: > > > > Hi Tom, > > > > > > > >

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Shantur, On Wed, 15 Nov 2023 at 08:23, Shantur Rathore wrote: > > Hi Simon, > > > > > Is this the blue port on top of the USB-C connector? > > > Yes, that's correct. > For my drive I needed - > https://patchwork.ozlabs.org/project/uboot/patch/20231110141311.512334-...@shantur.com/ > > > > >

Re: [PATCH 0/6] risc-v: add ACPI support on QEMU

2023-11-15 Thread Heinrich Schuchardt
On 15.11.23 15:23, Heinrich Schuchardt wrote: QEMU 8.1.2 can create ACPI tables for the RISC-V architecture. Allow passing them through to the operating system. Provide a new defconfig that enables this. This patch is prerequisite: [PATCH] move acpi_get_rsdp_addr() to acpi/acpi_table.h

Re: [PATCH v3 0/4] arm: mach-snapdragon: Qualcomm pinctrl driver cleanup

2023-11-15 Thread Caleb Connolly
On Tue, 14 Nov 2023 12:55:39 +, Caleb Connolly wrote: > This series moves the Qualcomm pinctrl drivers from mach-snapdragon and > mach-ipq40xx to drivers/pinctrl/qcom. It then makes the necessary changes > to enable compatibility with Linux DTs. > > The pinctrl hardware on most Qualcomm

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Shantur Rathore
Hi Simon, I did some testing on the USB 3.0 port and it seems like bootflow causes something to happen to the USB. It seems to be only reproducible on the USB3.0 port. I am using an AMicro AM8180 NVME to USB adapter on the USB3.0 port of RockPro64. Booting the Armbian installation using =>

[PATCH v2 1/5] fastboot: multiresponse support

2023-11-15 Thread Svyatoslav Ryhel
From: Ion Agorria Currently u-boot fastboot can only send one message back to host, so if there is a need to print more than one line messages must be kept sending until all the required data is obtained. This behavior can be adjusted using multiresponce ability (getting multiple lines of

[PATCH v2 3/5] common: console: introduce overflow and isempty calls

2023-11-15 Thread Svyatoslav Ryhel
From: Ion Agorria Separate record overflow logic and add console_record_isempty as available calls don't serve to know output has been read fully with readline's. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel --- common/console.c | 15 --- include/console.h | 14

[PATCH v2 0/5] Implement fastboot multiresponce

2023-11-15 Thread Svyatoslav Ryhel
Currently u-boot fastboot can only send one message back to host, so if there is a need to print more than one line messages must be kept sending until all the required data is obtained. This behavior can be adjusted using multiresponce ability (getting multiple lines of response) proposed in this

Re: [PATCH v4 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-15 Thread Heinrich Schuchardt
On 11/15/23 16:50, Simon Glass wrote: Hi Heinrich, On Sun, 12 Nov 2023 at 16:35, Heinrich Schuchardt wrote: Am 12. November 2023 22:20:50 MEZ schrieb Simon Glass : Hi Heinrich, On Sun, 12 Nov 2023 at 13:32, Heinrich Schuchardt wrote: Am 12. November 2023 21:02:42 MEZ schrieb Simon

  1   2   >