Re: [PATCH 1/1] i2c: Bugfix in i2c_get_chip_by_phandle()

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 07:12:35AM +0100, Heiko Schocher wrote: > Hello Philip, > > On 24.11.23 15:04, Philip Oberfichtner wrote: > > The "i2cbcdev" sneaked in when implementing this function for the > > bootcounter use case. Obviously the intention was to use prop_name > > instead. > > > >

[PATHv11 00/43] net/lwip: add lwip library for the network stack

2023-11-27 Thread Maxim Uvarov
Hello, Please find updated version of lwip patches. Changes are in the changelog bellow. Thank you, Maxim. changelog: v11: - v11 is mosly respin of v10 patches with CI error fixes.                 Gitlab CI:                

[PATHv11 05/43] net/lwip: implement dhcp cmd

2023-11-27 Thread Maxim Uvarov
U-Boot recently got support for an alternative network stack using LWIP. Replace dhcp command with the LWIP variant while keeping the output and error messages identical. Signed-off-by: Maxim Uvarov --- include/net/lwip.h | 12 + net/lwip/Makefile | 1 +

[PATHv11 08/43] net/lwip: implement ping cmd

2023-11-27 Thread Maxim Uvarov
U-Boot recently got support for an alternative network stack using LWIP. Replace ping command with the LWIP variant while keeping the output and error messages identical. ping uses lwIP contrib/apps/ping/ping.c code. Custom timeout is used to get an error message on not modified example.

[PATHv11 06/43] net/lwip: implement tftp cmd

2023-11-27 Thread Maxim Uvarov
U-Boot recently got support for an alternative network stack using LWIP. Replace tftp command with the LWIP variant while keeping the output and error messages identical. Signed-off-by: Maxim Uvarov --- include/net/lwip.h | 13 net/lwip/Makefile | 1 +

[PATHv11 07/43] net/lwip: implement wget cmd

2023-11-27 Thread Maxim Uvarov
U-Boot recently got support for an alternative network stack using LWIP. Replace wget command with the LWIP variant while keeping the output and error messages identical. Signed-off-by: Maxim Uvarov --- include/net/lwip.h | 14 + net/lwip/Makefile | 1 +

[PATHv11 09/43] net/lwip: add lwIP configuration

2023-11-27 Thread Maxim Uvarov
lwip configuration can be tuned with header file. Signed-off-by: Maxim Uvarov --- net/lwip/lwipopts.h | 178 1 file changed, 178 insertions(+) create mode 100644 net/lwip/lwipopts.h diff --git a/net/lwip/lwipopts.h b/net/lwip/lwipopts.h new file

[PATHv11 18/43] net/smc911x: fix return from smc911x_send

2023-11-27 Thread Maxim Uvarov
return value of smc911x_send is ignored, but on sucesseful send we need return 0 and or error -ETIMEOUT, not opposite. Signed-off-by: Maxim Uvarov --- drivers/net/smc911x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index

[PATHv11 15/43] test_efi_loader.py: use $filesize var

2023-11-27 Thread Maxim Uvarov
bootefi code relays in internal variable then to filesize environment. lwip tftp do not update this variable. For not I update test to provide correct size. Signed-off-by: Maxim Uvarov --- test/py/tests/test_efi_loader.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATHv11 17/43] net: sandbox: fix NULL pointer derefences

2023-11-27 Thread Maxim Uvarov
Add additional checks for NULL pointers. Signed-off-by: Maxim Uvarov --- drivers/net/sandbox.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/sandbox.c b/drivers/net/sandbox.c index 13022addb6..75d32db3a9 100644 --- a/drivers/net/sandbox.c +++ b/drivers/net/sandbox.c @@

[PATHv11 16/43] test_net: print out net list

2023-11-27 Thread Maxim Uvarov
Printing net list is useful in CI log files. Signed-off-by: Maxim Uvarov --- test/py/tests/test_net.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/py/tests/test_net.py b/test/py/tests/test_net.py index b2241ae6a4..cd5b791a6a 100644 --- a/test/py/tests/test_net.py +++

[PATHv11 29/43] configs/am335x_boneblack_vboot_defconfig: enable LTO and increase SPL size

2023-11-27 Thread Maxim Uvarov
Increase allowed binary size to fit lwip code. Signed-off-by: Maxim Uvarov --- configs/am335x_boneblack_vboot_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/am335x_boneblack_vboot_defconfig b/configs/am335x_boneblack_vboot_defconfig index 531703010a..4f06ed1b76 100644

[PATHv11 33/43] configs/am335x_evm_defconfig: inc SPL size

2023-11-27 Thread Maxim Uvarov
Increase allowed binary size to fit lwip code. Signed-off-by: Maxim Uvarov --- configs/am335x_evm_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig index f048e60f7f..9fd608bd76 100644 --- a/configs/am335x_evm_defconfig +++

[PATHv11 31/43] configs/lschlv2_defconfig: enable LTO and inc size

2023-11-27 Thread Maxim Uvarov
Increase allowed binary size to fit lwip code. Signed-off-by: Maxim Uvarov --- configs/lschlv2_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/lschlv2_defconfig b/configs/lschlv2_defconfig index d7c77f8a88..7e0c70c6ea 100644 ---

[PATHv11 32/43] configs/lsxhl_defconfig: LTO + size

2023-11-27 Thread Maxim Uvarov
Increase allowed binary size to fit lwip code. Signed-off-by: Maxim Uvarov --- configs/lsxhl_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/lsxhl_defconfig b/configs/lsxhl_defconfig index d729bcb530..066f8b16b3 100644 --- a/configs/lsxhl_defconfig +++

Re: [PATHv11 26/43] configs/tbs2910_defconfig inc limit

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:57:09PM +0600, Maxim Uvarov wrote: > Increase allowed binary size to fit lwip code. > > Signed-off-by: Maxim Uvarov > --- > configs/tbs2910_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configs/tbs2910_defconfig

[PATHv11 42/43] configs/linkit-smart-7688_defconfig: increase board limit

2023-11-27 Thread Maxim Uvarov
Increase current board limit to fit new IP stack. mips: + linkit-smart-7688 +u-boot.img exceeds file size limit: + limit: 0x87000 bytes + actual: 0x87184 bytes + excess: 0x184 bytes Signed-off-by: Maxim Uvarov --- configs/linkit-smart-7688_defconfig | 2 +- 1 file changed, 1

[PATHv11 43/43] .gitlab-ci.yml: change ownership of the git files

2023-11-27 Thread Maxim Uvarov
Inside docker image owner of U-Boot files is different, so user doesn't have permissions to update submodules. Make the ower of git the same as current user. Signed-off-by: Maxim Uvarov --- .gitlab-ci.yml | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

Re: [PATHv11 33/43] configs/am335x_evm_defconfig: inc SPL size

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:57:16PM +0600, Maxim Uvarov wrote: > Increase allowed binary size to fit lwip code. > > Signed-off-by: Maxim Uvarov > --- > configs/am335x_evm_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/am335x_evm_defconfig

Re: [PATHv11 33/43] configs/am335x_evm_defconfig: inc SPL size

2023-11-27 Thread Peter Robinson
On Mon, Nov 27, 2023 at 1:08 PM Tom Rini wrote: > > On Mon, Nov 27, 2023 at 06:57:16PM +0600, Maxim Uvarov wrote: > > > Increase allowed binary size to fit lwip code. > > > > Signed-off-by: Maxim Uvarov > > --- > > configs/am335x_evm_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > >

Re: [PATCH] boards: Disable NET on platforms without NETDEVICES

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 02:05:35PM +, Peter Robinson wrote: > On Mon, Nov 27, 2023 at 1:06 PM Tom Rini wrote: > > > > On Mon, Nov 27, 2023 at 5:45 AM Winker Matthias (HC-CW/ENG-PJM) > > wrote: > > > > > > Hello Tom, > > > > > > Just to be sure. In the past we had NET enabled such that the

Re: Licensing discrepancies or ambiguities

2023-11-27 Thread Tom Rini
On Sat, Nov 25, 2023 at 02:39:53PM -0800, Vagrant Cascadian wrote: > On 2023-11-21, Tom Rini wrote: > > On Tue, Nov 21, 2023 at 11:10:57AM -0800, Vagrant Cascadian wrote: > > > >> I've been reviewing the copyright and license information for Das U-Boot > >> in preparation for uploading to Debian,

[PATHv11 03/43] net/lwip: integrate lwIP library

2023-11-27 Thread Maxim Uvarov
Define Makefile and Kconfig to build lwIP inside the U-Boot. We compile lwIP the same as the main code, plus we can do optimization for size at compile time with disabling not needed debug asserts, or not used protocols. So we can tune lwIP configuration specially for U-Boot environments.

[PATHv11 01/43] submodule: add lwIP as git submodule

2023-11-27 Thread Maxim Uvarov
add external lwIP library as a git submodule. Use STABLE-2_2_0_RELEASE tag. Signed-off-by: Maxim Uvarov --- .gitmodules| 4 Makefile | 8 +++- net/lwip/lwip-external | 1 + 3 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 .gitmodules

[PATHv11 02/43] net/lwip: add doc/develop/net_lwip.rst

2023-11-27 Thread Maxim Uvarov
Add initial documentation of lwIP network IP stack integration to the U-Boot (net_lwip.rst). Signed-off-by: Maxim Uvarov Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Signed-off-by: Maxim Uvarov --- doc/develop/index.rst| 1 + doc/develop/net_lwip.rst | 75

[PATHv11 04/43] net/lwip: implement dns cmd

2023-11-27 Thread Maxim Uvarov
U-Boot recently got support for an alternative network stack using LWIP. Replace dns command with the LWIP variant while keeping the output and error messages identical. Signed-off-by: Maxim Uvarov --- include/net/lwip.h | 19 +++ net/lwip/Makefile| 2 ++

[PATHv11 26/43] configs/tbs2910_defconfig inc limit

2023-11-27 Thread Maxim Uvarov
Increase allowed binary size to fit lwip code. Signed-off-by: Maxim Uvarov --- configs/tbs2910_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig index 8fbe84f1d2..ce40efa9ab 100644 --- a/configs/tbs2910_defconfig

[PATHv11 24/43] lwip: omap3: rename mem_init

2023-11-27 Thread Maxim Uvarov
Rename mem_init to solve following compilation error. +arm-linux-gnueabi-ld.bfd: net/lwip/lwip-external/src/core/mem.o: in function `mem_init': +net/lwip/lwip-external/src/core/mem.c:162: multiple definition of `mem_init'; arch/arm/mach-omap2/omap3/sdrc.o:arch/arm/mach-omap2/omap3/

[PATHv11 25/43] configs/turris_omnia_defconfig set limit to 0xf6000

2023-11-27 Thread Maxim Uvarov
Increase allowed binary size to fit lwip code. 0xf -> 0xf6000 Signed-off-by: Maxim Uvarov --- configs/turris_omnia_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig index 65d4a296e7..afcd4a1eb7

[PATHv11 28/43] configs/turris_omnia_defconfig: enable LTO

2023-11-27 Thread Maxim Uvarov
Decrease allowed binary size to fit lwip code. u-boot-with-spl.kwb exceeds file size limit: limit: 0xf6000 bytes actual: 0xf8600 bytes excess: 0x2600 bytes Signed-off-by: Maxim Uvarov --- configs/turris_omnia_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATHv11 27/43] configs/socfpga_secu1_defconfig: enable LTO

2023-11-27 Thread Maxim Uvarov
Decrease allowed binary size to fit lwip code. Signed-off-by: Maxim Uvarov --- configs/socfpga_secu1_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/socfpga_secu1_defconfig b/configs/socfpga_secu1_defconfig index b8052f1dee..4213941bcf 100644 ---

[PATHv11 30/43] configs/sheevaplug_defconfig: enable LTO and inc size

2023-11-27 Thread Maxim Uvarov
Increase allowed binary size to fit lwip code. Signed-off-by: Maxim Uvarov --- configs/sheevaplug_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/sheevaplug_defconfig b/configs/sheevaplug_defconfig index 2e4901b840..c0b256f3b0 100644 ---

[PATHv11 38/43] configs/qemu-x86_64_defconfig: increase ROM size

2023-11-27 Thread Maxim Uvarov
When lwIP compiled with debug info enabled U-Boot size overlaps with SPL. Make more room for it. binman: Node '/binman/rom/u-boot-spl-with-ucode-ptr': Offset 0xfffd8000 (4294803456) overlaps with previous entry '/binman/rom/u-boot-dtb' ending at 0xfffd8a40 (4294806080) ImagePosOffset

[PATHv11 39/43] Makefile: add dtbs to clean

2023-11-27 Thread Maxim Uvarov
CI test checks that generated dtb has to be cleaned up. Signed-off-by: Maxim Uvarov --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 769111bf09..2fc04450c6 100644 --- a/Makefile +++ b/Makefile @@ -2172,7 +2172,8 @@ CLEAN_FILES +=

[PATHv11 41/43] mach-mtmips: inc SPL size limit

2023-11-27 Thread Maxim Uvarov
Increase board limit on 0x200 to fit new IP stack. Signed-off-by: Maxim Uvarov --- arch/mips/mach-mtmips/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/mach-mtmips/Kconfig b/arch/mips/mach-mtmips/Kconfig index 15b2792e61..2f07e3a491 100644 ---

[PATHv11 40/43] .azure-pipelines: init submodules

2023-11-27 Thread Maxim Uvarov
Azure CI does make testconfig then passes U-Boot sources to docker image. Inside docker image owner of U-Boot files is different, so user doesn't have permissions to update submodules. In this case we can do init before we run test docker image. Signed-off-by: Maxim Uvarov ---

Re: [PATCH] mtd: nand: omap_gpmc: Fix NAND in SPL for AM335x

2023-11-27 Thread Heiko Schocher
Hello Roger, On 25.11.23 12:16, Roger Quadros wrote: > AM335x uses a special driver "am335x_spl_bch.c" as SPL > NAND loader. This driver expects 1 sector at a time ECC > and doesn't work well with multi-sector ECC that was implemented in > commit 04fcd2587321 ("mtd: rawnand: omap_gpmc: Fix

Re: [PATCH] mtd: nand: omap_gpmc: Fix NAND in SPL for AM335x

2023-11-27 Thread Michael Nazzareno Trimarchi
Hi dario On Mon, Nov 27, 2023 at 3:00 PM Leto, Enrico wrote: > > Hi, > > Works on my draco thuban AM335x based boards booting from NAND with ECC BCH8 > code. > > Tested-by: Enrico Leto > > Thanks > > > > -Original Message- > > From: Michael Nazzareno Trimarchi > > Sent: Saturday,

[PATHv11 13/43] net/lwip: replace original net commands with lwip

2023-11-27 Thread Maxim Uvarov
Replace original commands: ping, tftp, dhcp and wget. Signed-off-by: Maxim Uvarov --- boot/bootmeth_efi.c | 18 +++--- boot/bootmeth_pxe.c | 21 ++- cmd/net.c | 86 + cmd/pxe.c | 19 +- include/net.h | 8

[PATHv11 14/43] net/lwip: split net.h to net.h, arp.h and eth.h

2023-11-27 Thread Maxim Uvarov
current net.h has ethernet and protocol definitions. Protocol definitions overlap with lwIP protocol definitions and net.h can not be included from lwIP code. Splitting on logical blocks makes that work. Signed-off-by: Maxim Uvarov --- include/net.h | 189

[PATHv11 10/43] net/lwip: implement lwIP port to U-Boot

2023-11-27 Thread Maxim Uvarov
Implement port of lwIP stack to the U-Boot. lwIP is well known full IP stack which provides wide functionality, various examples, API closer to linux userland. Rich debug printing and possibility to run lwIP apps under linux make it easier to develop and debug apps. U-Boot implementation keeps

[PATHv11 12/43] net/lwip: connection between cmd and lwip apps

2023-11-27 Thread Maxim Uvarov
Use lwip variants of network commands. Signed-off-by: Maxim Uvarov --- cmd/Makefile | 1 + cmd/net-lwip.c | 307 + 2 files changed, 308 insertions(+) create mode 100644 cmd/net-lwip.c diff --git a/cmd/Makefile b/cmd/Makefile index

[PATHv11 11/43] net/lwip: update .gitignore with lwIP

2023-11-27 Thread Maxim Uvarov
ignore lwIP library code and reused files from the lwIP. Signed-off-by: Maxim Uvarov --- net/lwip/.gitignore | 8 1 file changed, 8 insertions(+) create mode 100644 net/lwip/.gitignore diff --git a/net/lwip/.gitignore b/net/lwip/.gitignore new file mode 100644 index

[PATHv11 19/43] sandbox: eth-raw-os: successful return code is 0

2023-11-27 Thread Maxim Uvarov
all network drivers return 0 on the successful transmission. Signed-off-by: Maxim Uvarov --- arch/sandbox/cpu/eth-raw-os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sandbox/cpu/eth-raw-os.c b/arch/sandbox/cpu/eth-raw-os.c index e59b96be5f..92c35aed95 100644 ---

[PATHv11 22/43] bcm_ns3: fix overlap define with lwip

2023-11-27 Thread Maxim Uvarov
Rename declaration to not overlap with lwip. aarch64: + bcm_ns3 +In file included from net/lwip/lwip-external/src/include/lwip/etharp.h:53, + from net/lwip/lwip-external/src/core/init.c:55: +net/lwip/lwip-external/src/include/lwip/prot/ethernet.h:69: error:

[PATHv11 21/43] mach-socfpga: do not overlap defines with lwip

2023-11-27 Thread Maxim Uvarov
Fix compilation issue with overlapping lwip and march defines. Signed-off-by: Maxim Uvarov --- arch/arm/mach-socfpga/include/mach/handoff_soc64.h | 6 -- arch/arm/mach-socfpga/wrap_handoff_soc64.c | 9 + 2 files changed, 9 insertions(+), 6 deletions(-) diff --git

[PATHv11 20/43] driver/net/rtl8139: remove debug print

2023-11-27 Thread Maxim Uvarov
debug print delays reset of the driver. Finally I see bunch of "rx error " errors in the screen. CI can not handle many prints. While network works fine there Reproduced with: make CROSS_COMPILE=sh2-linux- r2dplus_defconfig all qemu-system-sh4 -M r2d -nographic -serial null \ -serial

[PATHv11 23/43] rcar3_salvator-x_defconfig: increase binary size limit

2023-11-27 Thread Maxim Uvarov
aarch64: + rcar3_salvator-x u-boot.img exceeds file size limit: limit: 0x10 bytes actual: 0x106d6c bytes excess: 0x6d6c bytes Signed-off-by: Maxim Uvarov --- configs/rcar3_salvator-x_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATHv11 37/43] configs/rcar3_ulcb_defconfig: increase size

2023-11-27 Thread Maxim Uvarov
Increase allowed binary size to fit lwip code. u-boot.img exceeds file size limit: limit: 0x10 bytes actual: 0x106c41 bytes excess: 0x6c41 bytes Signed-off-by: Maxim Uvarov --- configs/rcar3_ulcb_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATHv11 35/43] configs/linkit-smart-7688_defconfig: increse size

2023-11-27 Thread Maxim Uvarov
Increase allowed binary size to fit lwip code. limit: 0x8 bytes actual: 0x84c58 bytes excess: 0x4c58 bytes Signed-off-by: Maxim Uvarov --- configs/linkit-smart-7688_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/linkit-smart-7688_defconfig

[PATHv11 36/43] configs/gardena-smart-gateway-mt7688_defconfig: increase size

2023-11-27 Thread Maxim Uvarov
Increase allowed binary size to fit lwip code. limit: 0xa bytes actual: 0xa0f54 bytes excess: 0xf54 bytes Signed-off-by: Maxim Uvarov --- configs/gardena-smart-gateway-mt7688_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATHv11 34/43] configs/bk4r1_defconfig: inc size

2023-11-27 Thread Maxim Uvarov
Increase allowed binary size to fit lwip code. Signed-off-by: Maxim Uvarov --- configs/bk4r1_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/bk4r1_defconfig b/configs/bk4r1_defconfig index 95f0c30cde..30ab54a849 100644 --- a/configs/bk4r1_defconfig +++

Re: [PATHv11 24/43] lwip: omap3: rename mem_init

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:57:07PM +0600, Maxim Uvarov wrote: > Rename mem_init to solve following compilation error. > +arm-linux-gnueabi-ld.bfd: net/lwip/lwip-external/src/core/mem.o: in > function `mem_init': > +net/lwip/lwip-external/src/core/mem.c:162: multiple definition > of

RE: [PATCH] mtd: nand: omap_gpmc: Fix NAND in SPL for AM335x

2023-11-27 Thread Leto, Enrico
Hi, Works on my draco thuban AM335x based boards booting from NAND with ECC BCH8 code. Tested-by: Enrico Leto Thanks > -Original Message- > From: Michael Nazzareno Trimarchi > Sent: Saturday, November 25, 2023 2:07 PM > To: Roger Quadros > Cc: dario.binac...@amarulasolutions.com;

Re: [PATCH] boards: Disable NET on platforms without NETDEVICES

2023-11-27 Thread Peter Robinson
On Mon, Nov 27, 2023 at 1:06 PM Tom Rini wrote: > > On Mon, Nov 27, 2023 at 5:45 AM Winker Matthias (HC-CW/ENG-PJM) > wrote: > > > > Hello Tom, > > > > Just to be sure. In the past we had NET enabled such that the fused MAC is > > taken over, although we don’t use NET CMD. > > With your

Re: [PATHv11 33/43] configs/am335x_evm_defconfig: inc SPL size

2023-11-27 Thread Maxim Uvarov
On Mon, 27 Nov 2023 at 19:08, Tom Rini wrote: > On Mon, Nov 27, 2023 at 06:57:16PM +0600, Maxim Uvarov wrote: > > > Increase allowed binary size to fit lwip code. > > > > Signed-off-by: Maxim Uvarov > > --- > > configs/am335x_evm_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff

Re: [PATHv11 33/43] configs/am335x_evm_defconfig: inc SPL size

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 08:06:23PM +0600, Maxim Uvarov wrote: > On Mon, 27 Nov 2023 at 19:08, Tom Rini wrote: > > > On Mon, Nov 27, 2023 at 06:57:16PM +0600, Maxim Uvarov wrote: > > > > > Increase allowed binary size to fit lwip code. > > > > > > Signed-off-by: Maxim Uvarov > > > --- > > >

Re: [PATHv11 33/43] configs/am335x_evm_defconfig: inc SPL size

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 03:52:50PM +, Peter Robinson wrote: > On Mon, Nov 27, 2023 at 3:32 PM Maxim Uvarov wrote: > > > > > > > > On Mon, 27 Nov 2023 at 20:08, Tom Rini wrote: > >> > >> On Mon, Nov 27, 2023 at 08:06:23PM +0600, Maxim Uvarov wrote: > >> > On Mon, 27 Nov 2023 at 19:08, Tom

[PATCH 2/2 v2] smbios: Fallback to the default DT if sysinfo nodes are missing

2023-11-27 Thread Ilias Apalodimas
In order to fill in the SMBIOS tables U-Boot currently relies on a "u-boot,sysinfo-smbios" compatible node. This is fine for the boards that already include such nodes. However with some recent EFI changes, the majority of boards can boot up distros, which usually rely on things like dmidecode

[PATCH 1/2 v2] smbios: Simplify reporting of unknown values

2023-11-27 Thread Ilias Apalodimas
If a value is not valid during the DT or SYSINFO parsing, we explicitly set that to "Unknown Product" and "Unknown" for the product and manufacturer respectively. It's cleaner if we move the checks insisde smbios_add_string() and always report "Unknown" regardless of the missing field.

[PATCH 0/2 v2] Provide a fallback to smbios tables

2023-11-27 Thread Ilias Apalodimas
Hi, Tom asked me to clean up and resend [0]. I've made some adjustments -- The DT nodes are tokenized and a single string is used. The DT node 'model' is used to fill the SMBIOS 'Product Name' and 'compatible' is used for 'Manufacturer'. The reason is explained in patch#2 but the tl;dr is that

Re: efi: Set Variable Runtime implementation

2023-11-27 Thread Shantur Rathore
+ Simon as he seems to have done a lot of work in the driver model. On Mon, Nov 27, 2023 at 10:12 AM Shantur Rathore wrote: > > Hi Ilias, > > On Mon, Nov 27, 2023 at 7:16 AM Ilias Apalodimas > wrote: > > > > Hi Shantur > > > > On Sun, 26 Nov 2023 at 12:33, Shantur Rathore wrote: > > > > > > Hi

Re: [PATCH v1 2/3] efi_vars: Implement SPI Flash store

2023-11-27 Thread Shantur Rathore
Hi Ilias, On Mon, Nov 27, 2023 at 7:09 AM Ilias Apalodimas wrote: > > Hi Shantur > > Please don't send a v2 unless the v1 discussion has settled. It just > makes life harder. I'll ignore v2 for now and respond here. > Sure, I'm still learning the ways around here. > [...] > > > > > > > > > > +

Re: [PATCH v2 0/9] ufs: Add a PCI UFS controller support

2023-11-27 Thread Tom Rini
On Wed, 11 Oct 2023 21:15:43 +0800, Bin Meng wrote: > This adds a PCI UFS controller support and enables the support on > QEMU RISC-V for testing. > > Requiring QEMU v8.2+. > > This series is avaiable at u-boot-x86/ufs for testing. > > [...] Applied to u-boot/next, thanks! -- Tom

Re: [PATCH 1/1] i2c: Bugfix in i2c_get_chip_by_phandle()

2023-11-27 Thread Tom Rini
On Fri, 24 Nov 2023 15:04:01 +0100, Philip Oberfichtner wrote: > The "i2cbcdev" sneaked in when implementing this function for the > bootcounter use case. Obviously the intention was to use prop_name > instead. > > Fixes: b483552773 (i2c: Implement i2c_get_chip_by_phandle()) > > > [...]

Re: [PATCH 3/3] sunxi: H616: Add OrangePi Zero 3 board support

2023-11-27 Thread Stephen Graf
Since the last test I rebuilt u-boot without the "CONFIG_DRAM_CLK=792" in the defconfig and got the wrong DRAM size problem (showing 2G instead of 1G). I had to do a power down/up to see this. Are you planning to add this parameter to your patch? U-Boot 2024.01-rc3-00012-g1fcf078f54-dirty (Nov

Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

2023-11-27 Thread Szőke Kálmán Benjamin
It was absolutely conform, i supressed the potentional warning. Once again i say, i will not remove it, if you do not liket it you can remoce as a maintainer. My patch is ready and final. Let's do something to improve i.MX family as a maintainer. I am realy sad to see in last 2-3 years there

Re: [PATHv11 26/43] configs/tbs2910_defconfig inc limit

2023-11-27 Thread Soeren Moch
On 27.11.23 14:11, Tom Rini wrote: On Mon, Nov 27, 2023 at 06:57:09PM +0600, Maxim Uvarov wrote: Increase allowed binary size to fit lwip code. Signed-off-by: Maxim Uvarov --- configs/tbs2910_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/2 v2] smbios: Simplify reporting of unknown values

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 07:10:57PM +0200, Ilias Apalodimas wrote: > If a value is not valid during the DT or SYSINFO parsing, we explicitly > set that to "Unknown Product" and "Unknown" for the product and > manufacturer respectively. It's cleaner if we move the checks insisde >

Re: [PATHv11 39/43] Makefile: add dtbs to clean

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:57:22PM +0600, Maxim Uvarov wrote: > CI test checks that generated dtb has to be cleaned up. > > Signed-off-by: Maxim Uvarov > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index

Re: [PATHv11 04/43] net/lwip: implement dns cmd

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:56:47PM +0600, Maxim Uvarov wrote: > U-Boot recently got support for an alternative network stack using LWIP. > Replace dns command with the LWIP variant while keeping the output and > error messages identical. > > Signed-off-by: Maxim Uvarov [snip] > diff --git

Re: [PATHv11 10/43] net/lwip: implement lwIP port to U-Boot

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:56:53PM +0600, Maxim Uvarov wrote: > Implement port of lwIP stack to the U-Boot. lwIP is well known full IP stack > which provides wide functionality, various examples, API closer to linux > userland. > Rich debug printing and possibility to run lwIP apps under linux

Re: [PATHv11 21/43] mach-socfpga: do not overlap defines with lwip

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:57:04PM +0600, Maxim Uvarov wrote: > Fix compilation issue with overlapping lwip and march defines. > > Signed-off-by: Maxim Uvarov > --- > arch/arm/mach-socfpga/include/mach/handoff_soc64.h | 6 -- > arch/arm/mach-socfpga/wrap_handoff_soc64.c | 9

[PATCH] arm: dts: imx8mp-venice-gw72xx: add TPM device

2023-11-27 Thread Tim Harvey
Add the TPM device found on the GW72xx revision F PCB. This hangs off of SPI2, uses gpio1_10 as a CS and gpio1_11 as RST#. Signed-off-by: Tim Harvey --- arch/arm/dts/imx8mp-venice-gw72xx-2x-u-boot.dtsi | 9 + arch/arm/dts/imx8mp-venice-gw72xx.dtsi | 9 - 2 files

[PATCH v2 01/18] bloblist: Update the tag numbering

2023-11-27 Thread Raymond Mao
From: Simon Glass Align bloblist tags with the FW handoff spec v0.9. The most common ones are from 0. TF related ones are from 0x100. All non-standard ones from 0xfff000. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao --- Changes in v2 - Align bloblist

[PATCH v2 02/18] bloblist: Adjust API to align in powers of 2

2023-11-27 Thread Raymond Mao
From: Simon Glass The updated bloblist structure stores the alignment as a power-of-two value in its structures. Adjust the API to use this, to avoid needing to calling ilog2(). Drop a stale comment while we are here. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by:

[PATCH v2 03/18] bloblist: Change the magic value

2023-11-27 Thread Raymond Mao
From: Simon Glass This uses a new value with spec v0.9 so change it. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao --- Changes in v2 - Update the bloblist alignment to align to FW handoff spec v0.9. include/bloblist.h | 2 +- 1 file changed, 1

[PATCH v2 04/18] bloblist: Set version to 1

2023-11-27 Thread Raymond Mao
From: Simon Glass The new bloblist for v0.9 has version 1 so update this value. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao --- Changes in v2 - Update the bloblist alignment to align to FW handoff spec v0.9. include/bloblist.h | 2 +- 1 file changed,

[PATCH v2 16/18] bloblist: Align bloblist used_size and total_size to spec

2023-11-27 Thread Raymond Mao
Align used_size and total_size of the bloblist header to the definition of the FW Handoff spec v0.9. Update the related bloblist APIs and UT testcases. Signed-off-by: Raymond Mao --- Changes in v2 - New patch file created for v2. common/bloblist.c | 86

[PATCH v2 18/18] bloblist: Load the bloblist from the previous loader

2023-11-27 Thread Raymond Mao
During bloblist initialization, when CONFIG_OF_BOARD is defined, invoke the platform custom function to load the bloblist via boot arguments from the previous loader. If the bloblist exists, copy it into the fixed bloblist memory region. Signed-off-by: Raymond Mao --- Changes in v2 - New patch

[PATCH v2 15/18] fdt: Allow the devicetree to come from a bloblist

2023-11-27 Thread Raymond Mao
From: Simon Glass Standard passage provides for a bloblist to be passed from one firmware phase to the next. That can be used to pass the devicetree along as well. If CONFIG_OF_BOARD is defined, a board custom routine will provide a bloblist or a specified memory address to retrieve the

[PATCH v2 17/18] qemu-arm: Get bloblist from boot arguments

2023-11-27 Thread Raymond Mao
Add platform custom function to get bloblist from boot arguments. Check whether boot arguments aligns with the register conventions defined in FW Handoff spec v0.9. Add bloblist related options into qemu default config. Signed-off-by: Raymond Mao --- Changes in v2 - New patch file created for

[PATCH v2 14/18] bloblist: Update documentation and header comment

2023-11-27 Thread Raymond Mao
From: Simon Glass Align the documentation with the v0.9 spec. Signed-off-by: Simon Glass Signed-off-by: Raymond Mao --- doc/develop/bloblist.rst | 4 +++- include/bloblist.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/develop/bloblist.rst

Re: [PATHv11 17/43] net: sandbox: fix NULL pointer derefences

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:57:00PM +0600, Maxim Uvarov wrote: > Add additional checks for NULL pointers. > > Signed-off-by: Maxim Uvarov > --- > drivers/net/sandbox.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/sandbox.c b/drivers/net/sandbox.c > index

Re: [PATHv11 18/43] net/smc911x: fix return from smc911x_send

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:57:01PM +0600, Maxim Uvarov wrote: > return value of smc911x_send is ignored, but on sucesseful > send we need return 0 and or error -ETIMEOUT, not opposite. > > Signed-off-by: Maxim Uvarov Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

[PATCH v2 1/2] common: board_f: change calculation of gd->mon_len to fix s5p4418 reloc

2023-11-27 Thread Stefan Bosch
ARM and MICROBLAZE: Change calculation of monitor length (gd->mon_len) to fix relocation at boards with s5p4418-SoC. At s5p4418, _start is after the header (NSIH) therefore the monitor length has to be calculated using __image_copy_start instead of _start in order the whole monitor code is

[PATCH v2 2/2] arm: s5p4418: fix relocation of vectors

2023-11-27 Thread Stefan Bosch
The header (NSIH) used for the s5p4418-SoC is not loaded into RAM by the 2nd-bootloader, see boot0.h. Therefore, use an adapted version of relocate_vectors which relocates the vectors after the header (at _start) instead of the 'dummy'-vectors at the start of the header (at __image_copy_start).

[PATCH v2 0/2] arm: s5p4418: fix relocation

2023-11-27 Thread Stefan Bosch
Fix relocation of u-boot for s5p4418-SoC. I.e. use __image_copy_start instead of _start to calculate the monitor length. Furthermore use an adapted version of relocate_vectors for the s5p4418-SoC. Background: The header (NSIH) used by the 2nd-bootloader (included at the begin of u-boot.bin) is

Re: [PATHv11 00/43] net/lwip: add lwip library for the network stack

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:56:43PM +0600, Maxim Uvarov wrote: > Hello, > > Please find updated version of lwip patches. Changes are in the > changelog bellow. > > Thank you, > Maxim. > > changelog: > v11: - v11 is mosly respin of v10 patches with CI error fixes. On a RPi 3: U-Boot>

[PATCH v2 09/18] bloblist: Checksum the entire bloblist

2023-11-27 Thread Raymond Mao
From: Simon Glass Spec v0.9 specifies that the entire bloblist area is checksummed, including unused portions. Update the code to follow this. Signed-off-by: Simon Glass Signed-off-by: Raymond Mao --- common/bloblist.c | 9 + test/bloblist.c | 10 -- 2 files changed, 9

[PATCH v2 11/18] bloblist: Reduce blob-header size

2023-11-27 Thread Raymond Mao
From: Simon Glass The v0.9 spec provides for an 8-byte header for each blob, with fewer fields. The blob start address should be aligned to the alignment specified by the bloblist header. Update the implementation to match this. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao

[PATCH v2 12/18] bloblist: Reduce bloblist header size

2023-11-27 Thread Raymond Mao
From: Simon Glass The v0.9 spec provides for a 16-byte header with fewer fields. Update the implementation to match this. This also adds an alignment field. Signed-off-by: Simon Glass Signed-off-by: Raymond Mao --- include/bloblist.h | 26 +- test/bloblist.c| 6

[PATCH v2 10/18] bloblist: Handle alignment with a void entry

2023-11-27 Thread Raymond Mao
From: Simon Glass Rather than setting the alignment using the header size, add an entirely new entry to cover the gap left by the alignment. Signed-off-by: Simon Glass Signed-off-by: Raymond Mao --- common/bloblist.c | 23 +++ 1 file changed, 19 insertions(+), 4

[PATCH v2 13/18] bloblist: Add alignment to bloblist_new()

2023-11-27 Thread Raymond Mao
From: Simon Glass Allow the alignment to be specified when creating a bloblist. Signed-off-by: Simon Glass Signed-off-by: Raymond Mao --- common/bloblist.c | 5 +++-- include/bloblist.h | 3 ++- test/bloblist.c| 40 ++-- 3 files changed, 27

Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

2023-11-27 Thread Fabio Estevam
On Mon, Nov 27, 2023 at 4:55 PM Szőke Kálmán Benjamin wrote: > > Unused function parameters should be removed > https://rules.sonarsource.com/c/tag/based-on-misra/RSPEC-1172/ >From this same URL: "Exceptions There are some cases when you want to have an unused parameter (usually because the

Re: [PATHv11 01/43] submodule: add lwIP as git submodule

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:56:44PM +0600, Maxim Uvarov wrote: > add external lwIP library as a git submodule. > Use STABLE-2_2_0_RELEASE tag. > > Signed-off-by: Maxim Uvarov And just for the record, we'll re-visit submodule/subtree/whatever later on, this (and the final parts for CI to be

Re: [PATHv11 00/43] net/lwip: add lwip library for the network stack

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:56:43PM +0600, Maxim Uvarov wrote: > Hello, > > Please find updated version of lwip patches. Changes are in the > changelog bellow. > > Thank you, > Maxim. > > changelog: > v11: - v11 is mosly respin of v10 patches with CI error fixes. >                 Gitlab

Re: [PATHv11 22/43] bcm_ns3: fix overlap define with lwip

2023-11-27 Thread Tom Rini
On Mon, Nov 27, 2023 at 06:57:05PM +0600, Maxim Uvarov wrote: > Rename declaration to not overlap with lwip. > > aarch64: + bcm_ns3 > +In file included from net/lwip/lwip-external/src/include/lwip/etharp.h:53, > + from net/lwip/lwip-external/src/core/init.c:55: >

[PATCH v2 06/18] bloblist: Drop the flags value

2023-11-27 Thread Raymond Mao
From: Simon Glass There is no flags value in spec v0.9 so drop it. For now it is still present in the header, with an underscore, so that tests continue to pass. Signed-off-by: Simon Glass Signed-off-by: Raymond Mao --- common/bloblist.c | 5 ++--- include/bloblist.h | 6 ++

[PATCH v2 07/18] bloblist: Drop the spare values

2023-11-27 Thread Raymond Mao
From: Simon Glass There are no spare values in spec v0.9 so drop them. For now they are still present in the headers, with an underscore, so that tests continue to pass. Signed-off-by: Simon Glass Signed-off-by: Raymond Mao --- common/bloblist.c | 1 - include/bloblist.h | 6 ++

  1   2   >