Re: [PATCH 13/18] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-01-25 Thread Quentin Schulz
Hi Kever, On 1/25/24 11:29, Kever Yang wrote: Hi Quentin, On 2024/1/24 18:50, Quentin Schulz wrote: Hi Kever, On 1/24/24 11:19, Kever Yang wrote: Hi Quentin, On 2024/1/23 22:49, Quentin Schulz wrote: From: Quentin Schulz Rockchip SoCs have some jtag/sdmmc autoswitching that simply

Re: [PATCH] toradex: tdx-cfg-block: Add new apalis and colibri pid

2024-01-25 Thread Francesco Dolcini
On Mon, Jan 22, 2024 at 05:09:30PM -0300, Joao Paulo Goncalves wrote: > From: Joao Paulo Goncalves > > Add new apalis imx6 and colibri imx6/imx7 products IDs. > > Signed-off-by: Joao Paulo Goncalves > --- > board/toradex/common/tdx-cfg-block.c | 9 + >

[PATCH v2 1/1] riscv: Support building with Clang

2024-01-25 Thread kleines Filmröllchen
The -ffixed-gp option of GCC has an exact equivalent of -ffixed-x3 in Clang. Signed-off-by: kleines Filmröllchen --- Changes in v2: - Removed copyright attribution - Use -ffixed-x3 unconditionally as it is also supported by GCC arch/riscv/config.mk | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 0/1] riscv: Support building with Clang

2024-01-25 Thread kleines Filmröllchen
Hello everyone! This is a minimal patchset for making U-Boot build with Clang on RISC-V, something I stumbled upon while writing U-Boot build scripts for SerenityOS's RISC-V port. The only change is a (for unclear reasons...) differently-named flag for fixing the global pointer. Notably, this

Re: [PATCH] board: rockchip: Add Hardkernel ODROID-M1S

2024-01-25 Thread Jonas Karlman
Hi Dongjin, On 2024-01-25 08:02, Dongjin Kim wrote: > Hardkernel ODROID-M1S is a single board computer with a RK3566 SoC, > a slightly modified version of the RK3566 SoC. > > Features tested on a ODROID-M1S 8GB v1.0 2023-08-10: > - SD-card boot > - eMMC boot > - PCIe/NVMe This board

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-25 Thread Tom Rini
On Thu, Jan 25, 2024 at 12:54:22PM +0530, Sumit Garg wrote: [snip] > But at this point we have to move away from apprehensions about DT ABI > breakages and provide real examples of the DT ABI breakages in the > past. Are you aware of any DT ABI breaking change backported to Linux > stable

[PATCH 3/3] cmd: rng: Add rng list command

2024-01-25 Thread Weizhao Ouyang
Add rng list command to list all probed RNG device. Signed-off-by: Weizhao Ouyang --- cmd/rng.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/cmd/rng.c b/cmd/rng.c index 52f722c7af..4818133f94 100644 --- a/cmd/rng.c +++ b/cmd/rng.c @@ -18,6 +18,19 @@ static int

[PATCH 1/3] firmware: psci: Fix bind_smccc_features psci check

2024-01-25 Thread Weizhao Ouyang
According to PSCI specification DEN0022F, PSCI_FEATURES is used to check whether the SMCCC is implemented by discovering SMCCC_VERSION. Signed-off-by: Weizhao Ouyang --- drivers/firmware/psci.c | 2 +- include/linux/arm-smccc.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 2/3] driver: rng: Fix SMCCC TRNG crash

2024-01-25 Thread Weizhao Ouyang
Fix a SMCCC TRNG null pointer crash due to a failed smccc feature binding. Signed-off-by: Weizhao Ouyang --- drivers/rng/smccc_trng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rng/smccc_trng.c b/drivers/rng/smccc_trng.c index 3a4bb33941..3087cb991a 100644 ---

Re: [PATCH v1 0/1] Fix booting kernels with ATAGS and extlinux

2024-01-25 Thread Tom Rini
On Thu, Jan 25, 2024 at 04:34:41PM +0200, Svyatoslav wrote: > > > 25 січня 2024 р. 16:17:34 GMT+02:00, Tom Rini > написав(-ла): > >On Thu, Jan 25, 2024 at 04:16:11PM +0200, Svyatoslav wrote: > >> > >> > >> 25 січня 2024 р. 16:12:36 GMT+02:00, Tom Rini > >> написав(-ла): > >> >On Thu, Jan

Re: [PATCH v1 0/1] Fix booting kernels with ATAGS and extlinux

2024-01-25 Thread Tom Rini
On Thu, Jan 25, 2024 at 08:51:09AM +0200, Svyatoslav wrote: > > > 25 січня 2024 р. 08:29:54 GMT+02:00, Dan Carpenter > написав(-ла): > >On Wed, Jan 24, 2024 at 10:27:30PM +0200, Svyatoslav Ryhel wrote: > >> Currently, if boot with extlinux.conf and do not set the fdt > >> U-Boot will provide

Re: [PATCH] board: rockchip: Add Hardkernel ODROID-M1S

2024-01-25 Thread Dongjin Kim
Hello Jans, Thank you for reviewing. On Thu, Jan 25, 2024 at 8:51 PM Jonas Karlman wrote: > > Hi Dongjin, > > On 2024-01-25 08:02, Dongjin Kim wrote: > > Hardkernel ODROID-M1S is a single board computer with a RK3566 SoC, > > a slightly modified version of the RK3566 SoC. > > > > Features

Re: [PATCH v1 0/1] Fix booting kernels with ATAGS and extlinux

2024-01-25 Thread Svyatoslav
25 січня 2024 р. 16:47:48 GMT+02:00, Tom Rini написав(-ла): >On Thu, Jan 25, 2024 at 04:34:41PM +0200, Svyatoslav wrote: >> >> >> 25 січня 2024 р. 16:17:34 GMT+02:00, Tom Rini >> написав(-ла): >> >On Thu, Jan 25, 2024 at 04:16:11PM +0200, Svyatoslav wrote: >> >> >> >> >> >> 25 січня 2024 

Re: [PATCH 3/3] cmd: rng: Add rng list command

2024-01-25 Thread Heinrich Schuchardt
On 25.01.24 15:05, Weizhao Ouyang wrote: Add rng list command to list all probed RNG device. Thank you for your contribution. Would the following be more accurate? The 'rng list' command probes all RNG devices and list those devices that are successfully probed. Signed-off-by: Weizhao

Re: [PATCH 13/18] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-01-25 Thread Kever Yang
Hi Quentin, On 2024/1/24 18:50, Quentin Schulz wrote: Hi Kever, On 1/24/24 11:19, Kever Yang wrote: Hi Quentin, On 2024/1/23 22:49, Quentin Schulz wrote: From: Quentin Schulz Rockchip SoCs have some jtag/sdmmc autoswitching that simply doesn't work really well.[00] The Linux kernel

Re: [PATCH v2 2/4] cmd: provide command to display SMBIOS information

2024-01-25 Thread Peter Robinson
On Thu, 25 Jan 2024 at 03:02, Heinrich Schuchardt wrote: > > On 1/24/24 22:16, Tom Rini wrote: > > On Wed, Jan 17, 2024 at 04:33:45PM +0100, Heinrich Schuchardt wrote: > > > >> U-Boot can either generated an SMBIOS table or copy it from a prior boot > >> stage, e.g. QEMU. > >> > >> Provide a

U-Boot for Terasic - Cyclone 5 - DE10-standard board

2024-01-25 Thread mauricio . penteado
For some time I have been trying to understand how to build an embedded Linux to my terasic de10-standard board, without success. After booting the provided Linux image that is available for download from the terasic website, I was able to check the following information: U-Boot: 2013.01.01

[PATCH 0/3] Random Number Generator fixes

2024-01-25 Thread Weizhao Ouyang
This series aim to fix smccc bind issue and add a list command for RNG devices. Weizhao Ouyang (3): firmware: psci: Fix bind_smccc_features psci check driver: rng: Fix SMCCC TRNG crash cmd: rng: Add rng list command cmd/rng.c | 15 +++ drivers/firmware/psci.c

Re: [PATCH v1 0/1] Fix booting kernels with ATAGS and extlinux

2024-01-25 Thread Tom Rini
On Thu, Jan 25, 2024 at 04:16:11PM +0200, Svyatoslav wrote: > > > 25 січня 2024 р. 16:12:36 GMT+02:00, Tom Rini > написав(-ла): > >On Thu, Jan 25, 2024 at 08:51:09AM +0200, Svyatoslav wrote: > >> > >> > >> 25 січня 2024 р. 08:29:54 GMT+02:00, Dan Carpenter > >> написав(-ла): > >> >On Wed,

Re: [PATCH v1 0/1] Fix booting kernels with ATAGS and extlinux

2024-01-25 Thread Svyatoslav
25 січня 2024 р. 16:17:34 GMT+02:00, Tom Rini написав(-ла): >On Thu, Jan 25, 2024 at 04:16:11PM +0200, Svyatoslav wrote: >> >> >> 25 січня 2024 р. 16:12:36 GMT+02:00, Tom Rini >> написав(-ла): >> >On Thu, Jan 25, 2024 at 08:51:09AM +0200, Svyatoslav wrote: >> >> >> >> >> >> 25 січня 2024 

Re: [PATCH 2/3] driver: rng: Fix SMCCC TRNG crash

2024-01-25 Thread Heinrich Schuchardt
On 25.01.24 15:05, Weizhao Ouyang wrote: Fix a SMCCC TRNG null pointer crash due to a failed smccc feature binding. Signed-off-by: Weizhao Ouyang Reviewed-by: Heinrich Schuchardt --- drivers/rng/smccc_trng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] Add Phytec i.MX93 support

2024-01-25 Thread Primoz Fiser
Hi Mathieu, First of all, thank you for the v2. I was able quickly build & test on the actual board. Here are my findings: - FEC ethernet doesn't work - distroboot doesn't work Did you expirience the same? Nonetheless, here are my comments for v2: On 24. 01. 24 14:42, Mathieu Othacehe

Re: [PATCH v1 0/1] Fix booting kernels with ATAGS and extlinux

2024-01-25 Thread Svyatoslav
25 січня 2024 р. 16:12:36 GMT+02:00, Tom Rini написав(-ла): >On Thu, Jan 25, 2024 at 08:51:09AM +0200, Svyatoslav wrote: >> >> >> 25 січня 2024 р. 08:29:54 GMT+02:00, Dan Carpenter >> написав(-ла): >> >On Wed, Jan 24, 2024 at 10:27:30PM +0200, Svyatoslav Ryhel wrote: >> >> Currently, if

Re: [PATCH v2 1/1] riscv: Support building with Clang

2024-01-25 Thread Tom Rini
On Thu, Jan 25, 2024 at 03:06:59PM +0100, kleines Filmröllchen wrote: > The -ffixed-gp option of GCC has an exact equivalent of -ffixed-x3 in > Clang. > > Signed-off-by: kleines Filmröllchen Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/3] firmware: psci: Fix bind_smccc_features psci check

2024-01-25 Thread Heinrich Schuchardt
On 25.01.24 15:05, Weizhao Ouyang wrote: According to PSCI specification DEN0022F, PSCI_FEATURES is used to check whether the SMCCC is implemented by discovering SMCCC_VERSION. Signed-off-by: Weizhao Ouyang 5.15.2 Implementation responsibilities PSCI_FEATURES should report the presence of

Re: [PATCH v3 6/6] configs: enable smbios command on qemu_arm64_defconfig

2024-01-25 Thread Ilias Apalodimas
On Thu, 25 Jan 2024 at 17:55, Heinrich Schuchardt wrote: > > We have a Python test the copying of SMBIOS tables from QEMU. > To make use of the test we need the smbios command. > > Signed-off-by: Heinrich Schuchardt > --- > v3: > no change > --- > configs/qemu_arm64_defconfig | 1 + > 1

Re: [PATCH v3 5/6] configs: enable smbios command on sandbox

2024-01-25 Thread Ilias Apalodimas
On Thu, 25 Jan 2024 at 17:55, Heinrich Schuchardt wrote: > > To make use of the Python smbios test we need the smbios command. > > Signed-off-by: Heinrich Schuchardt > --- > v3: > new patch > --- > configs/sandbox_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v2] Add Phytec i.MX93 support

2024-01-25 Thread Mathieu Othacehe
Hello, Thanks for having a look! > Here are my findings: > > - FEC ethernet doesn't work > - distroboot doesn't work > > Did you expirience the same? I have not tested Ethernet ports on u-boot yet. I removed distroboot support as you proposed later in the review. Note that my evaluation

Re: [PATCH 13/18] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-01-25 Thread Kever Yang
Hi Quentin, On 2024/1/25 19:02, Quentin Schulz wrote: Hi Kever, On 1/25/24 11:29, Kever Yang wrote: Hi Quentin, On 2024/1/24 18:50, Quentin Schulz wrote: Hi Kever, On 1/24/24 11:19, Kever Yang wrote: Hi Quentin, On 2024/1/23 22:49, Quentin Schulz wrote: From: Quentin Schulz Rockchip

[PATCH v2] efi_loader: migrate SMBIOS 3.0 entry point structure for measurement

2024-01-25 Thread Masahisa Kojima
Current U-Boot only supports the SMBIOS 3.0 entry point structure. TCG2 measurement code should migrate to SMBIOS 3.0 entry point structure. efi_selftest tcg2 test also needs to be updated, and expected PCR[1] result is changed since guid for SMBIOS EFI system table uses different guid

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-25 Thread Marek Vasut
On 1/26/24 00:19, Tom Rini wrote: On Thu, Jan 25, 2024 at 05:38:23PM +0100, Marek Vasut wrote: On 1/25/24 16:04, Tom Rini wrote: On Thu, Jan 25, 2024 at 12:54:22PM +0530, Sumit Garg wrote: [snip] But at this point we have to move away from apprehensions about DT ABI breakages and provide

[PATCH] mmc: dw_mmc: Don't return error if data busy timeout

2024-01-25 Thread Yang Xiwen
As described in [1], some poor hardware or cards would fail to release the bus and keep driving data lines low. Ignore it and send the next cmd directly seems okay for most cases. [1]: https://patchwork.kernel.org/project/linux-mmc/patch/1424458179-5456-1-git-send-email-diand...@chromium.org/

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-25 Thread Tom Rini
On Thu, Jan 25, 2024 at 05:38:23PM +0100, Marek Vasut wrote: > On 1/25/24 16:04, Tom Rini wrote: > > On Thu, Jan 25, 2024 at 12:54:22PM +0530, Sumit Garg wrote: > > > > [snip] > > > But at this point we have to move away from apprehensions about DT ABI > > > breakages and provide real examples of

Re: [PATCH 3/3] cmd: rng: Add rng list command

2024-01-25 Thread Weizhao Ouyang
On Thu, Jan 25, 2024 at 10:49 PM Heinrich Schuchardt wrote: > > On 25.01.24 15:05, Weizhao Ouyang wrote: > > Add rng list command to list all probed RNG device. > > Thank you for your contribution. > > Would the following be more accurate? > > The 'rng list' command probes all RNG devices and

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-25 Thread Nishanth Menon
On 10:55-20240125, Andrew Davis wrote: > I'd say since U-Boot today cannot send over secure channels anyway, > lets just drop this code and if we ever need it then we add it back > over in the right spot at that time. Chatting with manorit, the reason why we need the secure code i

Re: [PATCH v9 2/2] arm64: boot: Support Flat Image Tree

2024-01-25 Thread Simon Glass
Hi, On Wed, 17 Jan 2024 at 06:14, Simon Glass wrote: > > Hi Masahiro, Tom, > > On Tue, 9 Jan 2024 at 07:33, Tom Rini wrote: > > > > On Tue, Jan 09, 2024 at 11:01:42PM +0900, Masahiro Yamada wrote: > > > Hi Simon, > > > > > > > > > On Wed, Jan 3, 2024 at 8:47 AM Simon Glass wrote: > > > > > > >

[PATCH v3 3/6] doc: man-page for smbios command

2024-01-25 Thread Heinrich Schuchardt
Provide a man-page for the smbios command. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas --- v3: no change v2: no change --- doc/usage/cmd/smbios.rst | 93 doc/usage/index.rst | 1 + 2

[PATCH v3 2/6] cmd: provide command to display SMBIOS information

2024-01-25 Thread Heinrich Schuchardt
U-Boot can either generated an SMBIOS table or copy it from a prior boot stage, e.g. QEMU. Provide a command to display the SMBIOS information. Currently only type 1 and 2 are translated to human readable text. Other types may be added later. Currently only a hexdump and the list of strings is

[PATCH v3 4/6] test: unit test for smbios command

2024-01-25 Thread Heinrich Schuchardt
Provide a unit test for the smbios command. Provide different test functions for QEMU, sandbox, and other systems. Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- v3: no change v2: for generic boards we only can assume that a type 127 table exists

[PATCH v3 5/6] configs: enable smbios command on sandbox

2024-01-25 Thread Heinrich Schuchardt
To make use of the Python smbios test we need the smbios command. Signed-off-by: Heinrich Schuchardt --- v3: new patch --- configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index ea4e2c1ec39..a8df5e635b2

[PATCH v3 1/6] smbios: type2: contained object handles

2024-01-25 Thread Heinrich Schuchardt
The type 2 structure must include information about the contained objects. It is fine to set the number of contained object handles to 0. Add the missing field. Fixes: 721e992a8af5 ("x86: Add SMBIOS table support") Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- v3:

[PATCH v3 0/6] cmd: provide command to display SMBIOS information

2024-01-25 Thread Heinrich Schuchardt
U-Boot may supply an SMBIOS table or they may be copied from QEMU. Provide a command to display the SMBIOS information. Currently only type 1 and 2 are translated to human readable text. Other types may be added later. Currently only a hexdump and the list of strings is provided for these. The

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-25 Thread Marek Vasut
On 1/25/24 16:04, Tom Rini wrote: On Thu, Jan 25, 2024 at 12:54:22PM +0530, Sumit Garg wrote: [snip] But at this point we have to move away from apprehensions about DT ABI breakages and provide real examples of the DT ABI breakages in the past. Are you aware of any DT ABI breaking change

Re: [PATCH v3 5/6] configs: enable smbios command on sandbox

2024-01-25 Thread Ilias Apalodimas
On Thu, 25 Jan 2024 at 18:26, Heinrich Schuchardt wrote: > > On 25.01.24 17:14, Tom Rini wrote: > > On Thu, Jan 25, 2024 at 04:54:37PM +0100, Heinrich Schuchardt wrote: > > > >> To make use of the Python smbios test we need the smbios command. > >> > >> Signed-off-by: Heinrich Schuchardt > >>

[PATCH v3 6/6] configs: enable smbios command on qemu_arm64_defconfig

2024-01-25 Thread Heinrich Schuchardt
We have a Python test the copying of SMBIOS tables from QEMU. To make use of the test we need the smbios command. Signed-off-by: Heinrich Schuchardt --- v3: no change --- configs/qemu_arm64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/qemu_arm64_defconfig

[PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-25 Thread Mathieu Othacehe
Add initial support for the PHYTEC phyBOARD-Segin-i.MX93 board based on the PHYTEC phyCORE-i.MX93 SoM. Supported features: - 1GB LPDDR4 RAM - eMMC - external SD - debug UART - watchdog Signed-off-by: Mathieu Othacehe --- Hello, This new revision fixes the remarks of Primoz. It uses

Re: [PATCH v2 1/1] cmd: bootmenu: rename U-Boot console to Exit

2024-01-25 Thread Tom Rini
On Wed, Jan 17, 2024 at 12:55:46PM +0200, Svyatoslav Ryhel wrote: > It seems that the U-Boot console entry of the bootmenu has lost > its original meaning. Now, even if it is chosen, the probability > that you will enter the actual U-Boot console is quite low. > Boot env, bootflow, bootcommand

Re: [PATCH v2] common: console: Fix print complete stdio device list

2024-01-25 Thread Tom Rini
On Wed, Jan 17, 2024 at 01:37:13PM +0100, Patrice Chotard wrote: > In case CONSOLE_MUX and SYS_CONSOLE_IS_IN_ENV are on and > stdin or stdout or stderr are missing in environment, as fallback, get > these either from stdio_devices[std] or stdio_devices[std]->name. > > Fixes: 6b343ab38d

Re: [PATCH] docker: Add tools/buildman/requirements.txt to the cache

2024-01-25 Thread Tom Rini
On Thu, Jan 18, 2024 at 12:10:07PM -0500, Tom Rini wrote: > As we have had this file for a while now, we should include installing > and populating our pip cache from here as well. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] lib: add comment in utf8_to_utf32_stream()

2024-01-25 Thread Tom Rini
On Thu, Jan 18, 2024 at 06:54:50PM +0100, Heinrich Schuchardt wrote: > The logic of utf8_to_utf32_stream() is not easy to understand. > Add a comment. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] test: enhance unicode_test_utf8_to_utf32_stream()

2024-01-25 Thread Tom Rini
On Thu, Jan 18, 2024 at 06:57:12PM +0100, Heinrich Schuchardt wrote: > Additionally test a UTF-8 string where each code point translates to three > UTF-8 bytes. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] reset: reset-hisilicon: also handle #reset-cells = <2>

2024-01-25 Thread Tom Rini
On Fri, Jan 19, 2024 at 08:49:17PM +0800, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen > > It's also valid to have #reset-cells = <2> while the third arg defaults > to ASSERT_SET. > > Signed-off-by: Yang Xiwen Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH] headers: don't depend on errno.h being available

2024-01-25 Thread Tom Rini
On Thu, Jan 18, 2024 at 07:10:47PM +0100, max.oss...@gmail.com wrote: > From: Max Krummenacher > > These headers follow the pattern: > > | #if CONFIG_IS_ENABLED(FANCY_FEATURE) > | void foo(void); > | #else > | static inline void foo(void) { return -ENOSYS; } > | #endif > > In the #else

Re: [PATCH v1 1/4] board: verdin-am62: improve comment on usb phy core voltage

2024-01-25 Thread Tom Rini
On Wed, Jan 17, 2024 at 11:16:46AM +0100, Max Krummenacher wrote: > From: Max Krummenacher > > TI recommends to clear the bit independent of the used voltage. > So the comment which claims to do it due to the core voltage > at 0.85V is bogus. > > See >

Re: [PATCH v3] board: ti: common: board_detect: Fix EEPROM offset read for 1-byte

2024-01-25 Thread Tom Rini
On Mon, Oct 30, 2023 at 10:34:58PM +0530, Prasanth Babu Mantena wrote: > EEPROM detection logic in ti_i2c_eeprom_get() involves reading > the total size and the 1-byte size with an offset 1. The commit > 9f393a2d7af8 ("board: ti: common: board_detect: Fix EEPROM read > quirk for 2-byte") that

Re: [PATCH v3 5/6] configs: enable smbios command on sandbox

2024-01-25 Thread Tom Rini
On Thu, Jan 25, 2024 at 04:54:37PM +0100, Heinrich Schuchardt wrote: > To make use of the Python smbios test we need the smbios command. > > Signed-off-by: Heinrich Schuchardt > --- > v3: > new patch > --- > configs/sandbox_defconfig | 1 + > 1 file changed, 1 insertion(+) We should do

Re: [PATCH 1/1] cmd: increase default for SYS_MAXARGS

2024-01-25 Thread Tom Rini
On Mon, Jan 15, 2024 at 02:46:56PM +0100, Heinrich Schuchardt wrote: > The value of CONFIG SYS_MAXARGS limits the usability of the 'for' command. > The current default of 16 is too low for some use case. Cf. > https://bugs.launchpad.net/snap-core18/+bug/1910094 > > Increase the default to 64. >

Re: [PATCH v3 5/6] configs: enable smbios command on sandbox

2024-01-25 Thread Heinrich Schuchardt
On 25.01.24 17:14, Tom Rini wrote: On Thu, Jan 25, 2024 at 04:54:37PM +0100, Heinrich Schuchardt wrote: To make use of the Python smbios test we need the smbios command. Signed-off-by: Heinrich Schuchardt --- v3: new patch --- configs/sandbox_defconfig | 1 + 1 file changed, 1

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-25 Thread Andrew Davis
On 1/24/24 11:43 PM, Dhruva Gole wrote: On Jan 24, 2024 at 12:08:13 -0600, Nishanth Menon wrote: On 23:07-20240124, Dhruva Gole wrote: On Jan 24, 2024 at 10:39:10 -0600, Nishanth Menon wrote: On 18:38-20240124, Dhruva Gole wrote: On Jan 24, 2024 at 16:42:12 +0530, Kamlesh Gurudasani wrote:

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-25 Thread Michal Simek
On 1/26/24 03:10, Marek Vasut wrote: On 1/26/24 00:19, Tom Rini wrote: On Thu, Jan 25, 2024 at 05:38:23PM +0100, Marek Vasut wrote: On 1/25/24 16:04, Tom Rini wrote: On Thu, Jan 25, 2024 at 12:54:22PM +0530, Sumit Garg wrote: [snip] But at this point we have to move away from

Re: [PATCH v2] efi_loader: migrate SMBIOS 3.0 entry point structure for measurement

2024-01-25 Thread Heinrich Schuchardt
On 1/26/24 01:53, Masahisa Kojima wrote: Current U-Boot only supports the SMBIOS 3.0 entry point structure. TCG2 measurement code should migrate to SMBIOS 3.0 entry point structure. efi_selftest tcg2 test also needs to be updated, and expected PCR[1] result is changed since guid for SMBIOS EFI

Re: [PATCH v2 00/13] arm: exynos: Add E850-96 board

2024-01-25 Thread Minkyu Kang
Hi, On Tue, 23 Jan 2024 at 04:52, Sam Protsenko wrote: > Hey Tom, Minkyu, > > If there are no outstanding concerns about this series, can you please > apply it? > > Thanks! > > On Wed, Jan 10, 2024 at 9:09 PM Sam Protsenko > wrote: > > > > Add Exynos850 SoC and WinLink's E850-96 board support.

Re: [PATCH] efi_loader: check efi_get_variable_int return value

2024-01-25 Thread Heinrich Schuchardt
On 1/22/24 08:26, Masahisa Kojima wrote: efi_get_variable_int() may fail, the buffer should be cleared before using it. Signed-off-by: Masahisa Kojima Addresses-Coverity-ID: 478333 ("Error handling issues") --- lib/efi_loader/efi_firmware.c | 8 1 file changed, 4 insertions(+), 4

[PATCH] arm64: zynqmp: Sync clock labels with kr260 revB

2024-01-25 Thread Michal Simek
Board description describes the hard part of chip (PS) but programmable logic (PL) part is not described in this file. But clocks on the board are not only connected to PS but also wired to PL. And because two revisions are available where revA is using one si5332 and revB multiple clock chips

[PATCH 0/2] efi_loader: export efi_get_configuration_table

2024-01-25 Thread Heinrich Schuchardt
In multiple places we need a function to find an EFI configuration table. Rename get_config_table() to efi_get_configuration_table() and export it. Use the new function for the 'efidebug capsule esrt' command. Due a pending change find_smbios_table() shall be replaced separately. Heinrich

[PATCH 1/2] efi_loader: export efi_get_configuration_table

2024-01-25 Thread Heinrich Schuchardt
In multiple places we need a function to find an EFI configuration table. Rename get_config_table() to efi_get_configuration_table() and export it. Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h| 2 ++ lib/efi_loader/efi_helper.c | 6 +++--- 2 files changed, 5

[PATCH 2/2] cmd: in do_efi_capsule_esrt use efi_get_configuration_table

2024-01-25 Thread Heinrich Schuchardt
Use library function efi_get_configuration_table() to find the ESRT. Signed-off-by: Heinrich Schuchardt --- cmd/efidebug.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/cmd/efidebug.c b/cmd/efidebug.c index a3a7556ea4a..a587860e2a5 100644 --- a/cmd/efidebug.c +++

Re: [PATCH v1] tools: mkimage: Add support for i.MXRT FlexSPI Header

2024-01-25 Thread Fabio Estevam
Hi Adam, On Tue, Jan 23, 2024 at 11:15 PM Jesse Taube wrote: > > Modify imx8m Flex SPI Configuration Block to work with imxrt. > Add more Flex SPI configuration options to Kconfig. > > Signed-off-by: Jesse Taube Could you please test it on imx8mn_beacon_fspi_defconfig ?

[PATCH v2 1/1] boot: pxe_utils: skip fdt setup in case legacy kernel is booted

2024-01-25 Thread Svyatoslav Ryhel
Currently, if boot with extlinux.conf and do not set the fdt U-Boot will provide its own device tree. This behavior is beneficial if the U-Boot device tree is in sync with Linux, but it totally halts the booting of pre-dtb kernels (3.4 for example) since it uses ATAGs. To fix this, pass `-` in the

[PATCH v2 0/1] Fix booting kernels with ATAGS and extlinux

2024-01-25 Thread Svyatoslav Ryhel
Currently, if boot with extlinux.conf and do not set the fdt U-Boot will provide its own device tree. This behavior is beneficial if the U-Boot device tree is in sync with Linux, but it totally halts the booting of pre-dtb kernels (3.4 for example) since it uses ATAGs. To fix this, pass `-` in the

Re: [PATCH] net: phy: realtek: Add support for LED configuration

2024-01-25 Thread Sean Anderson
Hi Artur/Jakub, On 11/30/23 15:39, Artur Rojek wrote: > From: Jakub Klama > > Introduce an ability to configure LED and Fiber LEDs found in RTL8211F > PHYs. This is achieved through two optional Device Tree properties: > * rtl,lcr for LED control > * rtl,flcr for Fiber LED control The Linux

Re: [PATCH] smbios: use struct_table_length to get SMBIOS 2.1 total table length

2024-01-25 Thread Heinrich Schuchardt
On 1/25/24 02:11, Masahisa Kojima wrote: The current code convert the SMBIOS 2.1 entry point structure to SMBIOS 3.0 entry point structure. The max_struct_size member in SMBIOS 2.1 entry point structure indicates "Size of the largest SMBIOS structure, in bytes". We need to use

[PATCH v3] rockchip: spl: Enable caches to speed up checksum validation

2024-01-25 Thread Jonas Karlman
FIT checksum validation is very slow in SPL due to D-cache not being enabled. Enable caches in SPL on ARM64 SoCs to speed up FIT checksum validation, from seconds to milliseconds. This change enables caches in SPL on all Rockchip ARM64 boards, the Kconfig options SPL_SYS_ICACHE_OFF and

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-25 Thread Fabio Estevam
On Thu, Jan 25, 2024 at 1:45 PM Mathieu Othacehe wrote: > +ipaddr=192.168.3.11 > +serverip=192.168.3.10 > +netmask=255.255.255.0 Please remove these hardcoded IP addresses.

Re: [PATCH v3 0/3] Conclusive WHLE-LS1 support (was: Conclusive WHLE-LS1046A support)

2024-01-25 Thread Artur Rojek
Pinging to have this series reviewed. Regards, Artur

Re: [PATCH] toradex: tdx-cfg-block: Add new apalis and colibri pid

2024-01-25 Thread Fabio Estevam
On Thu, Jan 25, 2024 at 8:02 AM Francesco Dolcini wrote: > there is some trailing space here at the end of the line. > > Fabio, can you fix this up before applying? Sure, but next time just run checkpatch :-)

Re: [PATCH v1] tools: mkimage: Add support for i.MXRT FlexSPI Header

2024-01-25 Thread Adam Ford
On Thu, Jan 25, 2024 at 2:10 PM Fabio Estevam wrote: > > Hi Adam, > > On Tue, Jan 23, 2024 at 11:15 PM Jesse Taube wrote: > > > > Modify imx8m Flex SPI Configuration Block to work with imxrt. > > Add more Flex SPI configuration options to Kconfig. > > > > Signed-off-by: Jesse Taube > > Could

Re: [PATCH v1] tools: mkimage: Add support for i.MXRT FlexSPI Header

2024-01-25 Thread Adam Ford
On Tue, Jan 23, 2024 at 8:15 PM Jesse Taube wrote: > > Modify imx8m Flex SPI Configuration Block to work with imxrt. > Add more Flex SPI configuration options to Kconfig. > > Signed-off-by: Jesse Taube I had to go back in time, because it appears the current version of 'master' doesn't fully

[PATCH v2 3/3] riscv: separate .data and .text sections of EFI binaries

2024-01-25 Thread Heinrich Schuchardt
EFI binaries should not contain sections that are both writable and executable. Separate the RX .text section from the RW .data section Signed-off-by: Heinrich Schuchardt --- v2: split patches --- arch/riscv/lib/crt0_riscv_efi.S| 37 ++

[PATCH v2 1/3] riscv: conflicting SPDX license linker scripts

2024-01-25 Thread Heinrich Schuchardt
Fix conflicting SPDX license information in linker scripts introduced by commit 7215787c4ea4 ("SPDX: Convert single license tags to Linux Kernel style"). Fixes: 7215787c4ea4 ("SPDX: Convert single license tags to Linux Kernel style") Signed-off-by: Heinrich Schuchardt --- v2: split

[PATCH v2 0/3] riscv: separate .data and .text sections of EFI binaries

2024-01-25 Thread Heinrich Schuchardt
EFI binaries should not contain sections that are both writable and executable. Separate the RX .text section from the RW .data section Fix conflicting SPDX license information in linker scripts introduced by commit 7215787c4ea4 ("SPDX: Convert single license tags to Linux Kernel style"). Change

[PATCH v2 2/3] riscv: page align EFI binary section

2024-01-25 Thread Heinrich Schuchardt
Change the alignment of the relocation code in EFI binaries to match page boundaries. Signed-off-by: Heinrich Schuchardt --- v2: split patches --- arch/riscv/lib/crt0_riscv_efi.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/lib/crt0_riscv_efi.S

Re: [PATCH 1/1] efi_selftest: add missing line feed in efi_selftest_miniapp_exit

2024-01-25 Thread Ilias Apalodimas
On Wed, 24 Jan 2024 at 22:04, Heinrich Schuchardt wrote: > > If an error occurs we may see an output like: > > EFI application calling Exit > > Could not open loaded image protocolLoaded image protocol missing > > Add the missing line feed. > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [PATCH v2] mtd: nand: arasan: Print warning for unsupported ecc modes

2024-01-25 Thread Michal Simek
On 1/19/24 06:33, Venkatesh Yadav Abbarapu wrote: Currently only hw ecc is supported in U-Boot. If any other ecc mode is given in DT, it simply ignores and switches to hw ecc. So better print what is being done. Revert this patch once soft ecc support is fixed in future. Signed-off-by:

[PATCH] arm64: zynqmp: Add 'silabs, skip-recall' to all si570 clk nodes

2024-01-25 Thread Michal Simek
From: Saeed Nowshadi Without 'silabs,skip-recall' property, the driver on System Controller re-calibrates the output clock frequency at probe() time based on the NVRAM setting. This re-calibration causes a glitch on the output clock. At power-on, Versal is also booting and expecting a