Re: [PATCH] dm: core: Fix address translation in devfdt_get_addr_index()

2024-03-04 Thread Tom Rini
On Sat, Feb 17, 2024 at 01:19:41PM +, Jonas Karlman wrote: > During address translation #address/size-cells props are expected to > apply to child nodes. However, devfdt_get_addr_index() incorrectly use > the parent offset of the udevice parent instead of getting the offset of > the node

Re: [PATCH v2] pinctrl: Check pinconfig nodes pre-reloc status recursively

2024-03-04 Thread Tom Rini
On Sat, Feb 17, 2024 at 12:08:40PM +, Jonas Karlman wrote: > Pinconfig nodes normally bind recursively with PINCTRL_FULL and > PINCONF_RECURSIVE enabled. However, during U-Boot proper pre-relocation > any node marked with e.g. bootph-all will not bind unless its parent is > also marked for

Re: [PATCH v1] pci-host-ecam-generic: Convert to ofnode functions

2024-03-04 Thread Tom Rini
On Wed, Feb 14, 2024 at 11:30:01PM +0300, Maksim Kiselev wrote: > FDT functions is not working when OF_LIVE is enabled. > Convert fdt parsing functions to ofnode parsing functions > > Signed-off-by: Maksim Kiselev Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH] log: fixup log_head after relocating global data

2024-03-04 Thread Tom Rini
On Tue, Feb 13, 2024 at 06:13:28PM +0100, Thomas Weißschuh wrote: > When `gd` is relocated during `spl_relocate_stack_gd()` the > doubly-linked circular list in the `log_head` member is broken. > > The last element of the list should point back to the initial > `list_head`, but as the initial

Re: [PATCH v2] cmd: setexpr: fix no matching string in gsub return empty value

2024-03-04 Thread Tom Rini
On Thu, Feb 08, 2024 at 03:58:27PM +0100, Massimiliano Minella wrote: > From: Massimiliano Minella > > In gsub, when the destination string is empty, the string 't' is > provided and the regular expression doesn't match, then the final result > is an empty string. > > Example: > > => echo

Re: [PATCH] FWU: developerbox: read boot index from NOR flash

2024-03-04 Thread Tom Rini
On Thu, Feb 08, 2024 at 11:33:44AM +0900, Masahisa Kojima wrote: > The FWU Multi Bank Update feature allows the platform to boot the > firmware images from one of the partitions(banks). > On the Developerbox, SCP-firmware running on the SCB(Cortex-M3) > passes the value of the boot index on the

Re: [PATCH] net: macb: Add support for fixed link

2024-03-04 Thread Tom Rini
On Tue, Feb 06, 2024 at 08:04:02PM +0100, belouargamoha...@gmail.com wrote: > From: BELOUARGA Mohamed > > The actual driver does not work when there is no linked PHY. These > changes add support for fixed-link feature in the device tree. > > Signed-off-by: BELOUARGA Mohamed Applied to

Re: [PATCH v2] scripts: dtc-version: Don't show error messages

2024-03-04 Thread Tom Rini
On Tue, Feb 06, 2024 at 12:00:04PM +0100, Dragan Simic wrote: > Prevent the error messages produced by which(1), such as the one quoted > below, from being visible in the build outputs. > > which: no dtc in (./scripts/dtc) > > This makes the build outputs look a tiny bit cleaner. > >

Re: [PATCH 2/2] fs: drop reiserfs

2024-03-04 Thread Tom Rini
On Sun, Feb 18, 2024 at 11:59:35PM +, Peter Robinson wrote: > It was only included by a single board which doesn't appear to have > ever used it for any default use cases so drop the filesystem now > that isn't used by any in-tree configurations. > > Signed-off-by: Peter Robinson Applied

Re: [PATCH 1/2] configs: ethernut5: Drop reiserfs

2024-03-04 Thread Tom Rini
On Sun, Feb 18, 2024 at 11:59:34PM +, Peter Robinson wrote: > This is the only board that enables it, and looking generally I don't > believe it's used. All use cases I could fine for the board rub by > default off jffs on the nand and it doesn't enable USB storage. > > Signed-off-by: Peter

Re: [PATCH] cmd: remove common.h from exception command implementations

2024-03-04 Thread Tom Rini
On Mon, Feb 12, 2024 at 05:53:29PM +0100, Heinrich Schuchardt wrote: > The common.h should not be used anymore. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] rng: eliminate common.h include from RNG drivers

2024-03-04 Thread Tom Rini
On Tue, Feb 13, 2024 at 12:44:47AM +0100, Heinrich Schuchardt wrote: > Usage of common.h is deprecated. > > * Remove common.h from RNG drivers. > * Sort includes. > * Add time.h to sandbox driver. > * Add linux/types.h to rng.h to provide size_t. > > Signed-off-by: Heinrich Schuchardt Applied

Re: [PATCH] bootstd: support scanning a single partition

2024-03-04 Thread Tom Rini
On Wed, Feb 21, 2024 at 01:41:44PM +0100, Nam Cao wrote: > The "bootflow" command currently doesn't support scanning a single > partition. This is inconvenient in setups with multiple bootable > partitions within a single disk, but only one is desired. > > Support scanning a single disk

Re: [PATCH] bootstd: fix build error when CONFIG_MMC is disabled

2024-03-04 Thread Tom Rini
On Wed, Feb 21, 2024 at 09:26:21AM +0300, Dan Carpenter wrote: > This code assumes that CONFIG_MMC and it causes a build error when > the config is disabled. > > aarch64-linux-gnu-ld.bfd: test/boot/bootstd_common.o: in function > `bootstd_test_check_mmc_hunter': >

Re: [PATCH] bootflow: Fix build error when BOOTMETH_CROS is disabled

2024-03-04 Thread Tom Rini
On Wed, Feb 21, 2024 at 09:26:09AM +0300, Dan Carpenter wrote: > The bootflow testing assumes that BOOTMETH_CROS is enabled but it > might not be which leads to a build error. > > aarch64-linux-gnu-ld.bfd: test/boot/bootflow.o: in function > `prep_mmc_bootdev': >

Re: [PATCH] boot: Only define checksum algos when the hashes are enabled

2024-03-04 Thread Tom Rini
On Thu, Feb 15, 2024 at 12:12:18PM -0500, Sean Anderson wrote: > Don't define checksum algos when the underlying hashes are not enabled. > This allows disabling these hashes in SPL (or U-Boot). > > Fixes: d16b38f4270 ("Add support for SHA384 and SHA512") > Fixes: 646257d1f40 ("rsa: add

Re: [PATCH] bootdev: drop unnecessary assert on bootflow->bdev

2024-03-04 Thread Tom Rini
On Mon, Feb 12, 2024 at 10:35:12AM +0100, Thomas Weißschuh wrote: > Not all flows have a device and the function already contains logic to > handle this case. > > Fixes: eccb25cd5922 ("bootstd: Allow the bootdev to be optional in bootflows") > Signed-off-by: Thomas Weißschuh Applied to

Re: [PATCH v2 1/1] boot: pxe_utils: skip fdt setup in case legacy kernel is booted

2024-03-04 Thread Tom Rini
On Thu, Jan 25, 2024 at 10:16:54PM +0200, Svyatoslav Ryhel wrote: > Currently, if boot with extlinux.conf and do not set the fdt > U-Boot will provide its own device tree. This behavior is > beneficial if the U-Boot device tree is in sync with Linux, > but it totally halts the booting of pre-dtb

Re: [PATCH] test: cmd: mbr: Fix Smatch static checker warning

2024-03-04 Thread Tom Rini
On Sat, Feb 03, 2024 at 02:56:19AM +, Alexander Gendin wrote: > This patch fixes Smatch static checker warning: > test/cmd/mbr.c:243 mbr_test_run() > warn: sizeof(NUMBER)? > > Reported-by: Dan Carpenter > Signed-off-by: Alexander Gendin > Reviewed-by: Heinrich Schuchardt

Re: [PATCH v5] test/py: net: Add dhcp abort test

2024-03-04 Thread Tom Rini
On Tue, Jan 30, 2024 at 01:37:01PM +0530, Love Kumar wrote: > Abort the dhcp request in the middle by pressing ctrl + c on u-boot > prompt and validate the abort status. > > Signed-off-by: Love Kumar Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 2/2] arm: s5p4418: fix relocation of vectors

2024-03-04 Thread Tom Rini
On Fri, Jan 26, 2024 at 12:50:56PM +, Stefan Bosch wrote: > The header (NSIH) used for the s5p4418-SoC is not loaded into RAM by the > 2nd-bootloader, see boot0.h. Therefore, use an adapted version of > relocate_vectors which relocates the vectors after the header (at _start) > instead of the

Re: [PATCH v3 1/2] common: board_f: change calculation of gd->mon_len to fix s5p4418 reloc

2024-03-04 Thread Tom Rini
On Fri, Jan 26, 2024 at 12:50:55PM +, Stefan Bosch wrote: > ARCH_NEXELL: Change calculation of monitor length (gd->mon_len) to fix > relocation at boards with s5p4418-SoC (ARCH_NEXELL). At s5p4418, _start > is after the header (NSIH). Therefore the monitor length has to be > calculated using

Re: [PATCH v2] qemu-arm: round down memory to multiple of 2MB for LPAE

2024-03-04 Thread Tom Rini
On Thu, Feb 01, 2024 at 01:40:54PM +0100, Igor Opaniuk wrote: > QEMU's -m option can take fractional megabyte values, > and lowest granularity seems to be 0x2000. > For example, run qemu with amount of memory set to 15k (0x61A9400): > > $ qemu-system-arm -machine virt -cpu cortex-a15 -m

Re: [PATCH] xen: xenguest_arm64: map all VIRTIO MMIO region

2024-03-04 Thread Tom Rini
On Fri, Jan 26, 2024 at 06:29:38PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > When run `virtio scan` on i.MX95, there is abort when accessing virtio > mmio region. The issue is the mmio region is not mapped. So let's map > all virtio mmio regions. > > Signed-off-by: Peng Fan Applied

Re: [PATCH 03/60] net: mediatek: add support for XGMII interface

2024-03-04 Thread Tom Rini
On Mon, Jan 22, 2024 at 10:08:16AM +0800, Weijie Gao wrote: > This patch add XGMII support for connecting 2.5G PHY. > > Signed-off-by: Bo-Cun Chen > Signed-off-by: Weijie Gao Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 02/60] net: mediatek: add support for adjusting MDIO clock

2024-03-04 Thread Tom Rini
On Mon, Jan 22, 2024 at 10:08:11AM +0800, Weijie Gao wrote: > User can assign a specific MDC speed to the eth node as follow: > > { > ... > phy-mode = "usxgmii"; > phy-handle = <>; > > mdio { > clock-frequency = <1050>; > }; > > phy8:

Re: [PATCH 01/60] arm: dts: mt7988-sd-rfb: add SD pin driving settings

2024-03-04 Thread Tom Rini
On Mon, Jan 22, 2024 at 10:07:54AM +0800, Weijie Gao wrote: > Set SD pin driving to 4mA > > Signed-off-by: Dong Huang > Signed-off-by: Weijie Gao Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] pinctrl: aspeed: add pass-through pins and siopbi/siopbo

2024-03-04 Thread Tom Rini
On Sun, Jan 21, 2024 at 02:28:13AM +0300, Ivan Mikhaylov wrote: > Add THRU0-3 and SIOPBI/SIOPBO pin groups/functions. > > Signed-off-by: Ivan Mikhaylov Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

[PATCH] boards: Remove empty BOARD_SPECIFIC_OPTIONS

2024-03-04 Thread Tom Rini
While there are currently uses for a stanza of "config BOARD_SPECIFIC_OPTIONS" followed by "def_bool y" and a series of select/imply statements, having this option set followed by nothing else doesn't provide anything. Remove these stanzas. Signed-off-by: Tom Rini ---

[PATCH u-boot-mvebu 4/4] arm: mvebu: turris_omnia: Disable Atmel SHA node if not present

2024-03-04 Thread Marek Behún
If the FEAT_CRYPTO feature bit is present in MCU features, the board crypto is implemented by MCU and the Atmel SHA chip is not present. Disable Atmel SHA device-tree node in that case. Signed-off-by: Marek Behún --- board/CZ.NIC/turris_omnia/turris_omnia.c | 23 +++ 1 file

[PATCH u-boot-mvebu 3/4] arm: mvebu: turris_omnia: Print board ECDSA public key if available

2024-03-04 Thread Marek Behún
If MCU supports the FEAT_CRYPTO feature, read board ECDSA public key from MCU and print it. Signed-off-by: Marek Behún --- board/CZ.NIC/turris_omnia/turris_omnia.c | 29 +++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git

[PATCH u-boot-mvebu 1/4] arm: mvebu: turris_omnia: Refactor MCU status and features reading

2024-03-04 Thread Marek Behún
Refactor MCU status word and MCU firmware features reading to make it simpler to use. Signed-off-by: Marek Behún --- board/CZ.NIC/turris_omnia/turris_omnia.c | 81 1 file changed, 53 insertions(+), 28 deletions(-) diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c

[PATCH u-boot-mvebu 2/4] arm: mvebu: turris_omnia: Implement getting board information from MCU

2024-03-04 Thread Marek Behún
Implement reading board serial number, first MAC address and board version from MCU. MCU supports board information if the FEAT_BOARD_INFO feature bit is set in MCU features. Prefer getting board information from MCU if supported, fallback to Atmel SHA chip. Signed-off-by: Marek Behún ---

[PATCH u-boot-mvebu 0/4] Turris Omnia - New board revision support

2024-03-04 Thread Marek Behún
Hi Stefan, a new board revision of Omnia is coming. In this new revision the board information (serial number, MAC address) and board cryptography is implemented by the microcontroller. The ATSHA204A cryptochip is not present on this new revision. Here are some changes regarding this. Marek

Re: [PATCH v2] board: rockchip: add Rockchip Toybrick TB-RK3588X board

2024-03-04 Thread Quentin Schulz
Hi Elon, On 3/1/24 09:50, Elon Zhang wrote: [You don't often get email from zhan...@rock-chips.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] TB-RK3588X board is a Rockchip Toybrick RK3588 based development board. Specification: Rockchip Rk3588

Re: [PATCH v2] board: rockchip: add Rockchip Toybrick TB-RK3588X board

2024-03-04 Thread Weizhao Ouyang
On Fri, Mar 1, 2024 at 4:50 PM Elon Zhang wrote: > > TB-RK3588X board is a Rockchip Toybrick RK3588 based development board. > > Specification: > Rockchip Rk3588 SoC > 4x ARM Cortex-A76, 4x ARM Cortex-A55 > 8/16GB Memory LPDDR4x > Mali G610MC4 GPU > 2×

Re: [PATCH v2] net: mv88e6xxx: fix missing SMI address initialization

2024-03-04 Thread Marek Behún
Hi Stefan, On Wed, 14 Feb 2024 08:50:16 +0100 Stefan Roese wrote: > Hi Ramon, > > On 1/9/24 10:37, Stefan Roese wrote: > > On 12/18/23 17:09, Marek Behún wrote: > >> On Wed, 6 Dec 2023 15:35:56 +0100 > >> Marek Mojík wrote: > >> > >>> The mv88e6xxx driver does not currently initialize the

Re: [PATCH] cmd: sf: Fix sf probe crash

2024-03-04 Thread Weizhao Ouyang
Gentle ping. Not merged yet. BR, Weizhao On Thu, Jan 4, 2024 at 7:46 PM Weizhao Ouyang wrote: > > Handle the return value of spi_flash_probe_bus_cs() to avoid sf probe > crashes. > > Signed-off-by: Weizhao Ouyang > --- > cmd/sf.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >

Re: [PATCH v4] Makefile: remove hardcoded device tree source directory

2024-03-04 Thread Tom Rini
On Mon, 04 Mar 2024 17:42:57 +0530, Sumit Garg wrote: > Some boards that choose to utilize the OF_UPSTREAM directory for their > device tree files will need to specify that directory instead of the > traditional arch/$(ARCH)/dts/* path. > > Include the correct path to the board's dtbs depending

[PATCH v4 3/3] cmd: rng: Add rng list command

2024-03-04 Thread Weizhao Ouyang
The 'rng list' command probes all RNG devices and list those devices that are successfully probed. Also update the help info. Reviewed-by: Heinrich Schuchardt Signed-off-by: Weizhao Ouyang --- v4: update doc/usage/cmd/rng.rst --- cmd/rng.c | 23 ++-

[PATCH v4 2/3] driver: rng: Fix SMCCC TRNG crash

2024-03-04 Thread Weizhao Ouyang
Fix a SMCCC TRNG null pointer crash due to a failed smccc feature binding. Fixes: 53355bb86c25 ("drivers: rng: add smccc trng driver") Reviewed-by: Heinrich Schuchardt Signed-off-by: Weizhao Ouyang --- v3: add Fixes tag --- drivers/rng/smccc_trng.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v4 1/3] firmware: psci: Fix bind_smccc_features psci check

2024-03-04 Thread Weizhao Ouyang
According to PSCI specification DEN0022F, PSCI_FEATURES is used to check whether the SMCCC is implemented by discovering SMCCC_VERSION. Signed-off-by: Weizhao Ouyang --- v3: remove fallback smc call v2: check SMCCC_ARCH_FEATURES --- drivers/firmware/psci.c | 5 - include/linux/arm-smccc.h

[PATCH v4 0/3] Random Number Generator fixes

2024-03-04 Thread Weizhao Ouyang
This series aim to fix smccc bind issue and add a list command for RNG devices. Changelog: v3 --> v4 - update doc/usage/cmd/rng.rst v2 --> v3 - remove fallback smc call - add Fixes tag v1 --> v2 - check SMCCC_ARCH_FEATURES - update commit message and rng help info Weizhao Ouyang (3):

Re: [PATCH 1/2] board: phytec: common: phytec_som_detection: Add phytec_get_som_type

2024-03-04 Thread Fabio Estevam
On Mon, Mar 4, 2024 at 9:31 AM Benjamin Hahn wrote: > > Add a function that gets the som_type from the EEPROM. > Add an enum for the som_type. > > Signed-off-by: Benjamin Hahn Your series does not even build: board/phytec/common/phytec_som_detection.c: In function ‘phytec_get_som_type’:

Re: [PATCH v2 2/2] arm64: Enable CONFIG_64BIT for static analysis

2024-03-04 Thread Dan Carpenter
On Mon, Mar 04, 2024 at 02:44:12PM +0100, Heinrich Schuchardt wrote: > On 04.03.24 08:04, Dan Carpenter wrote: > > In the Makefile there is a line that says this: > > > > # the checker needs the correct machine size > > CHECKFLAGS += $(if $(CONFIG_64BIT),-m64,-m32) > > > > Set

Re: [PATCH v2 1/2] Kconfig: move CONFIG_32/64BIT to arch/Kconfig

2024-03-04 Thread Tom Rini
On Mon, Mar 04, 2024 at 10:04:15AM +0300, Dan Carpenter wrote: > These configs are used in multiple places so put them in a shared > Kconfig file. > > Signed-off-by: Dan Carpenter Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 2/2] arm64: Enable CONFIG_64BIT for static analysis

2024-03-04 Thread Tom Rini
On Mon, Mar 04, 2024 at 03:11:04PM +0100, Csókás Bence wrote: > 2024. 03. 04. 14:44 keltezéssel, Heinrich Schuchardt írta> How about other > 64bit architectures (sandbox64, x86_64)? > > I think that could be its own patchset. Yes, a follow-up is fine. > > > Best regards > > > > Heinrich > >

Re: [RFC PATCH v2 1/2] fastboot: introduce 'oem board' subcommand

2024-03-04 Thread Alexey Romanov
Hello, On Thu, Feb 15, 2024 at 10:14:13AM +0100, Mattijs Korpershoek wrote: > Hi Alexey, > > Thank you for the patch. > > On jeu., f'evr. 01, 2024 at 12:20, Alexey Romanov > wrote: > > > Currently, fastboot protocol in U-Boot has no opportunity > > to execute vendor custom code with verifed

Re: [PATCH v2 2/2] arm64: Enable CONFIG_64BIT for static analysis

2024-03-04 Thread Csókás Bence
2024. 03. 04. 14:44 keltezéssel, Heinrich Schuchardt írta> How about other 64bit architectures (sandbox64, x86_64)? I think that could be its own patchset. Best regards Heinrich Bence P.S., does anyone know why I'm being CC'ed here? Did I participate in this thread at some point? I only

Re: [RFC PATCH v2 2/2] board: ad401: example of fastboot oem board realization

2024-03-04 Thread Alexey Romanov
Hello Mattijs, On Thu, Feb 15, 2024 at 10:24:11AM +0100, Mattijs Korpershoek wrote: > On jeu., f'evr. 01, 2024 at 12:20, Alexey Romanov > wrote: > > > An example of how we use fastboot oeam board subcommand > > for Sean Anderson. > > > > 1 - OEM_BOARD_WRITE_BOOTLOADER_CMD: > > > > We use it

Re: [PATCH v2 2/2] arm64: Enable CONFIG_64BIT for static analysis

2024-03-04 Thread Heinrich Schuchardt
On 04.03.24 08:04, Dan Carpenter wrote: In the Makefile there is a line that says this: # the checker needs the correct machine size CHECKFLAGS += $(if $(CONFIG_64BIT),-m64,-m32) Set CONFIG_64BIT for ARM64 so that we pass -m64 to the static checkers instead of -m32. Signed-off-by:

Re: [PATCH 8/8] board: add support for Qualcomm SA8155P-ADP board

2024-03-04 Thread Stephan Gerhold
On Thu, Feb 29, 2024 at 02:21:09PM +, Volodymyr Babchuk wrote: > SA8155P Automotive Development Platform is Qualcomm SA8155-based board > for developers. The nice thing that it has unlocked loaders with test > keys support, which means that U-Boot for this platform can be > launched at earlier

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-04 Thread Fabio Estevam
On Mon, Mar 4, 2024 at 10:35 AM Tom Rini wrote: > For v2024.04 yes, this is fine. For long term, we should parse the new > timing properties that the simple panel driver takes in our simple panel > driver instead. Sounds good. Sébastien, please follow Tom's suggestion when you have a chance.

Re: [PATCH 0/8] Add support for Qualcomm SA8155-ADP board

2024-03-04 Thread Stephan Gerhold
On Fri, Mar 01, 2024 at 06:25:39PM +, Volodymyr Babchuk wrote: > Caleb Connolly writes: > > On 29/02/2024 14:21, Volodymyr Babchuk wrote: > >> This patch series adds support for Qualcomm SA8155-ADP development > >> board. Main motivation for this series is to allow running > >> virtualization

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-04 Thread Tom Rini
On Mon, Mar 04, 2024 at 10:04:28AM -0300, Fabio Estevam wrote: > Hi Tom, > > On Tue, Feb 27, 2024 at 12:42 PM Tom Rini wrote: > > > What's the long term fix here? Why aren't these needed in Linux anymore, > > and perhaps why was it OK to remove them? This is perhaps another case > > where we as

Re: [PATCH v3 02/16] regulator: rk8xx: remove unused functions

2024-03-04 Thread Dragan Simic
Hello Quentin, On 2024-03-04 12:29, Quentin Schulz wrote: From: Quentin Schulz Those two functions had their last user removed in commit f9c68a566c4d ("rockchip: phycore_rk3288: remove phycore_init() function") part of v2023.01 release, so let's do some cleanup here. These functions could

Re: [PATCH 1/1] doc: invalid escape sequences in maintainers_include.py

2024-03-04 Thread Tom Rini
On Mon, Mar 04, 2024 at 10:34:50AM +0100, Heinrich Schuchardt wrote: > On 03.03.24 15:14, Tom Rini wrote: > > On Sun, Mar 03, 2024 at 02:40:22PM +0100, Heinrich Schuchardt wrote: > > > > > Update maintainers_include.py from Linux next-20240202. > > > > Is there no better upstream tag/commit to

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-04 Thread Fabio Estevam
Hi Tom, On Tue, Feb 27, 2024 at 12:42 PM Tom Rini wrote: > What's the long term fix here? Why aren't these needed in Linux anymore, > and perhaps why was it OK to remove them? This is perhaps another case > where we as the U-Boot community need to go and talk with some Linux > Kernel community

[PATCH 2/2] board: phycore_imx8mp: Use 2GHz RAM timings for PCL-070 from pcb_rev 1

2024-03-04 Thread Benjamin Hahn
We need to differ between PCL-070 and PCM-070. PCL-070 supports 2GHz RAM timings from pcb rev 1 or newer. PCM-070 supports 2GHz RAM timings from pcb rev 3 or newer. Signed-off-by: Benjamin Hahn --- board/phytec/phycore_imx8mp/spl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH 1/2] board: phytec: common: phytec_som_detection: Add phytec_get_som_type

2024-03-04 Thread Benjamin Hahn
Add a function that gets the som_type from the EEPROM. Add an enum for the som_type. Signed-off-by: Benjamin Hahn --- board/phytec/common/phytec_som_detection.c | 10 ++ board/phytec/common/phytec_som_detection.h | 8 2 files changed, 18 insertions(+) diff --git

[PATCH 0/2] board: phytec_imx8mp: Use 2GHz RAM timings for PCL-070 from pcb_rev 1

2024-03-04 Thread Benjamin Hahn
: eac52e4be4e234d563d6911737ee7ccdc0ada1f1 change-id: 20240304-pcl-070-patches-d31b989cf5b3 Best regards, -- Benjamin Hahn

Re: [PATCH v3 11/13] Makefile: remove hardcoded device tree source directory

2024-03-04 Thread Sumit Garg
On Mon, 4 Mar 2024 at 12:10, Sumit Garg wrote: > > + Fabio > > Hi Tom, > > On Tue, 27 Feb 2024 at 02:49, Bryan Brattlof wrote: > > > > Some boards that choose to utilize the OF_UPSTREAM directory for their > > device tree files will need to specify that directory instead of the > > traditional

Re: [PATCH v6 00/11] An effort to bring DT bindings compliance within U-Boot

2024-03-04 Thread Fabio Estevam
On Mon, Mar 4, 2024 at 9:15 AM Sumit Garg wrote: > I suppose the earlier reference patch wasn't complete, can you rather > try its v4 [1] instead? > > [1] > https://patchwork.ozlabs.org/project/uboot/patch/20240304121257.3551104-1-sumit.g...@linaro.org/ This one works, thanks!

Re: [PATCH v4] Makefile: remove hardcoded device tree source directory

2024-03-04 Thread Fabio Estevam
On Mon, Mar 4, 2024 at 9:13 AM Sumit Garg wrote: > > From: Bryan Brattlof > > Some boards that choose to utilize the OF_UPSTREAM directory for their > device tree files will need to specify that directory instead of the > traditional arch/$(ARCH)/dts/* path. > > Include the correct path to the

Re: [PATCH v6 00/11] An effort to bring DT bindings compliance within U-Boot

2024-03-04 Thread Sumit Garg
On Mon, 4 Mar 2024 at 16:54, Fabio Estevam wrote: > > Hi Sumit, > > On Mon, Mar 4, 2024 at 3:33 AM Sumit Garg wrote: > > > I think you also need Bryan's patch [1] to be incorporated as well. > > Give it a try and let me know if you still see any further issues. > > > > [1] > >

[PATCH v4] Makefile: remove hardcoded device tree source directory

2024-03-04 Thread Sumit Garg
From: Bryan Brattlof Some boards that choose to utilize the OF_UPSTREAM directory for their device tree files will need to specify that directory instead of the traditional arch/$(ARCH)/dts/* path. Include the correct path to the board's dtbs depending on if OF_UPSTREAM is selected or not.

[PATCH] drivers: imx_tmu: Select polling-rate from cpu-thermal devicetree node

2024-03-04 Thread Benjamin Hahn
*)dev_read_addr_ptr(dev); --- base-commit: eac52e4be4e234d563d6911737ee7ccdc0ada1f1 change-id: 20240304-fix-thermal-driver-issue-34004526aa4f Best regards, -- Benjamin Hahn

Re: [PATCH v2] pinctrl: Check pinconfig nodes pre-reloc status recursively

2024-03-04 Thread Quentin Schulz
Hi Jonas, On 2/17/24 13:08, Jonas Karlman wrote: Pinconfig nodes normally bind recursively with PINCTRL_FULL and PINCONF_RECURSIVE enabled. However, during U-Boot proper pre-relocation any node marked with e.g. bootph-all will not bind unless its parent is also marked for pre-reloc. group1

[PATCH v3 16/16] rockchip: boot_mode: fix rockchip_dnl_key_pressed requiring ADC support

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz ADC support is implied by the Rockchip arch Kconfig but that means it should be possible to disable ADC support and still be able to build. However the weak implementation of rockchip_dnl_key_pressed() currently blindly use functions from the ADC subsystem which do not

[PATCH v3 15/16] button: add missing ADC dependency for BUTTON_ADC

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz The BUTTON_ADC symbol guards the compilation of button-adc driver whose name very well makes it explicit that it requires ADC support to be enabled. Fix build issue of button-adc driver when ADC support isn't enabled by making sure it cannot be built without ADC support.

[PATCH v3 13/16] rockchip: jaguar-rk3588: enable SARADC and derivatives

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz The SARADC is used on Jaguar for multiple things: - channel 0 is used (at runtime) as a BIOS button, - channel 2 is exposed on the Mezzanine connector for customer specific logic, - channel 5 and 6 are used for identification, Since the SARADC requires a vref-supply

[PATCH v3 12/16] power: pmic: rk8xx: fix duplicate prompt

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz SPL_PMIC_RK8XX and PMIC_RK8XX both share the same prompt making it difficult to know at first glance in menuconfig what's for what, let's fix this by adding "in SPL" at the end of the prompt for the SPL symbol. Cc: Quentin Schulz Signed-off-by: Quentin Schulz ---

[PATCH v3 14/16] adc: add missing depends on ADC for controller drivers

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz The ADC controller drivers are obviously all depending on ADC symbol being selected. While they don't seem to fail to build without, they won't be useful without that symbol selected, so let's make sure the options aren't shown in menuconfig when ADC isn't selected. Cc:

[PATCH v3 11/16] rockchip: adc: rockchip-saradc: add support for RK3588

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz This adds support for the SARADCv2 found on RK3588. There is no stop callback as it is currently configured in single conversion mode, where the ADC is powered down after a single conversion has been made. Due to what seems to be a silicon bug, a controller reset needs to

[PATCH v3 09/16] rockchip: adc: rockchip-saradc: factor out start_channel callback

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz SARADC v1 and v2 have a different way of starting a channel, therefore let's abstract this function so that it can be provided from the udevice.data pointer. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- drivers/adc/rockchip-saradc.c | 30

[PATCH v3 10/16] rockchip: adc: rockchip-saradc: factor out stop callback

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz SARADC v2 doesn't have a stop mechanism once in single mode. In series conversion, the logic is different anyway. Therefore, let's abstract this function so that it can be provided from the udevice.data pointer. Cc: Quentin Schulz Signed-off-by: Quentin Schulz ---

[PATCH v3 08/16] rockchip: adc: rockchip-saradc: factor out channel_data callback

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz SARADC v1 and v2 have a different way of reading data, therefore let's abstract this function so that it can be provided from the udevice.data pointer. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- drivers/adc/rockchip-saradc.c | 37

[PATCH v3 07/16] rockchip: adc: rockchip-saradc: use union for preparing for v2

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz The registers are entirely different between SARADC v1 and SARADC v2, so let's prepare to add another struct for accessing v2 registers by adding a union. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- drivers/adc/rockchip-saradc.c | 23 +-- 1

[PATCH v3 04/16] regulator: rk8xx: add indirection level for some ldo callbacks

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz By passing a rk8xx_reg_info directly to the internal get_value, it'd be possible to call this same function with a logic for getting the rk8xx_reg_info different from the current get_ldo_reg, e.g. for NLDO and PLDO support for RK806. No logic change is expected. Cc:

[PATCH v3 06/16] pmic: reword help text

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz Reword the help text for the pmic read and pmic write commands to better match what's expected from the user. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- cmd/pmic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/pmic.c b/cmd/pmic.c

[PATCH v3 05/16] power: rk8xx: add support for RK806

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz This adds support for RK806, only the SPI variant has been tested. The communication "protocol" over SPI is the following: - write three bytes: - 1 byte: [0:3] length of the payload, [6] Enable CRC, [7] Write - 1 byte: LSB register address - 1 byte: MSB register

[PATCH v3 02/16] regulator: rk8xx: remove unused functions

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz Those two functions had their last user removed in commit f9c68a566c4d ("rockchip: phycore_rk3288: remove phycore_init() function") part of v2023.01 release, so let's do some cleanup here. Cc: Quentin Schulz Signed-off-by: Quentin Schulz ---

[PATCH v3 03/16] regulator: rk8xx: fix SWITCH enable on RK809

2024-03-04 Thread Quentin Schulz
From: William Wu On RK809 in PMIC_POWER_ENX registers, in order to set or clear a bit N, the bit at offset N + 4 needs to be set otherwise nothing is done. This fixes the inability to modify the SWITCH state on RK809. Cc: Quentin Schulz Signed-off-by: William Wu [reworded commit log]

[PATCH v3 01/16] rockchip: spi: rk_spi: do not write bytes when in read-only mode

2024-03-04 Thread Quentin Schulz
From: Quentin Schulz The read-only mode is currently supported but only for 16b-aligned buffers. For unaligned buffers, the last byte will be read in RW mode right now, which isn't what is desired. Instead, let's put the controller back into RO mode for that last byte and skip any write in the

[PATCH v3 00/16] rockchip: add support for SARADCv2 and RK806 PMIC and regulators

2024-03-04 Thread Quentin Schulz
The RK3588 has a new IP for SARADC compared to older SoCs of the same vendor but most of the boilerplate is shared, so rockchip-saradc.c driver is adapted instead of creating a new one. Because the SARADC requires a vref-supply which is commonly coming from a regulator of the RK806 PMIC, support

Re: [PATCH v6 00/11] An effort to bring DT bindings compliance within U-Boot

2024-03-04 Thread Fabio Estevam
Hi Sumit, On Mon, Mar 4, 2024 at 3:33 AM Sumit Garg wrote: > I think you also need Bryan's patch [1] to be incorporated as well. > Give it a try and let me know if you still see any further issues. > > [1] >

Re: [PATCH v2 0/5] TEE: minor cleanup

2024-03-04 Thread Ilias Apalodimas
Hi Igor, On Sun, 3 Mar 2024 at 00:01, Igor Opaniuk wrote: > > > - Address some spelling errors and typos > - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests > - Remove common.h inclusion for drivers/tee > > Changes in v2: > - Fixed chimp_optee.c:37:9: error: implicit

Re: RE: [PATCH] net: phy: ncsi: Correct the endian of the checksum

2024-03-04 Thread Dan Carpenter
Anyway, looks good! I already gave my reviewed by. Thanks for your work on this. regards, dan carpenter

Re: [PATCH v1 2/2] rockchip: rock-pi-4-rk3399: Enable booting from SPI flash

2024-03-04 Thread Jonas Karlman
Hi Christopher, On 2024-03-02 22:15, Jonas Karlman wrote: > Hi Christopher, > > On 2024-03-02 17:12, Christopher Obbard wrote: >> Hi Jonas, >> >> On Sat, 2024-03-02 at 16:28 +0100, Jonas Karlman wrote: >>> Hi Christopher, >>> >>> On 2024-03-02 15:34, Christopher Obbard wrote: Some variants

Re: [PATCH v1 1/2] rockchip: spl-boot-order: Fix spelling succes→success

2024-03-04 Thread Quentin Schulz
Hi Christopher, On 3/2/24 15:50, Christopher Obbard wrote: [You don't often get email from chris.obb...@collabora.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Fix a simple spelling mistake in a comment. Signed-off-by: Christopher Obbard Reviewed-by:

Re: [PATCH v1 2/2] rockchip: spl-boot-order: Improve debugging message when device isn't found

2024-03-04 Thread Quentin Schulz
Hi Christopher, On 3/2/24 15:50, Christopher Obbard wrote: [You don't often get email from chris.obb...@collabora.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] When debugging the SPL boot order, the node ID of a device which hasn't been found is printed

Re: [PATCH 1/1] doc: invalid escape sequences in maintainers_include.py

2024-03-04 Thread Heinrich Schuchardt
On 03.03.24 15:14, Tom Rini wrote: On Sun, Mar 03, 2024 at 02:40:22PM +0100, Heinrich Schuchardt wrote: Update maintainers_include.py from Linux next-20240202. Is there no better upstream tag/commit to base this from? The relevant changes in Linux were in 2023 and 2021: 86a0adc029d3

RE: RE: [PATCH] net: phy: ncsi: Correct the endian of the checksum

2024-03-04 Thread Jacky Chou
> On Sun, Mar 03, 2024 at 02:14:43AM +, Jacky Chou wrote: > > Hi Dan Carpenter, > > > > I have verified it on the little-endian platform, such as ASPEED AST2600. > > Awesome. Thanks for this. > > > I think put_unaligned_be32() and htonl() functions have no effect on > big-endian platforms.

U-Boot Maintainer for StarFive VisionFive 2 board

2024-03-04 Thread Heinrich Schuchardt
Hello Kuan, hello Wei Liang, In U-Boot board/starfive/visionfive2/MAINTAINERS shows Yanhong Wang as maintainer for the VisionFive 2 board. But my mails for "riscv: add support for Milk-V Mars board" https://lore.kernel.org/u-boot/20240303130122.29983-1-heinrich.schucha...@canonical.com/T/#t

[PATCH 5/6] arm: fix __efi_runtime_start/end definitions

2024-03-04 Thread Ilias Apalodimas
__efi_runtime_start/end are defined as c variables for arm7 only in order to force the compiler emit relative references. However, defining those within a section definition will do the same thing. On top of that the v8 linker scripts define it as a symbol. So let's remove the special sections

[PATCH 3/6] arm: fix __efi_runtime_rel_start/end definitions

2024-03-04 Thread Ilias Apalodimas
__efi_runtime_rel_start/end are defined as c variables for arm7 only in order to force the compiler emit relative references. However, defining those within a section definition will do the same thing. On top of that the v8 linker scripts define it as a symbol. So let's remove the special

[PATCH 6/6] arm: move image_copy_start/end to linker symbols

2024-03-04 Thread Ilias Apalodimas
image_copy_start/end are defined as c variables in order to force the compiler emit relative references. However, defining those within a section definition will do the same thing. So let's remove the special sections from the linker scripts, the variable definitions from sections.c and define

[PATCH 4/6] arm: clean up v7 and v8 linker scripts for __rel_dyn_start/end

2024-03-04 Thread Ilias Apalodimas
commit 47bd65ef057f ("arm: make __rel_dyn_{start, end} compiler-generated") were moving the __rel_dyn_start/end on c generated variables that were injected in their own sections. The reason was that we needed relative relocations for position independent code and linker bugs back then prevented us

[PATCH 2/6] arm: clean up v7 and v8 linker scripts for bss_start/end

2024-03-04 Thread Ilias Apalodimas
commit 3ebd1cbc49f0 ("arm: make __bss_start and __bss_end__ compiler-generated") and commit f84a7b8f54db ("ARM: Fix __bss_start and __bss_end in linker scripts") were moving the bss_start/end on c generated variables that were injected in their own sections. The reason was that we needed relative

[PATCH 1/6] arm: baltos: remove custom linker script

2024-03-04 Thread Ilias Apalodimas
commit 3d74a0977f514 ("ti: am335x: Remove unused linker script") removed the linker script for the TI variant. This linker script doesn't seem to do anything special and on top of that, has no definitions for the EFI runtime sections. So let's get rid of it and use the generic linker script which

<    1   2   3   >