[U-Boot] Dear Beneficiary, It is with gladness, i write you this message, to congratulate you on the successful release of the sum of $25 Million USD to you, Credited to Online Bank ATM Card account t
Dear Beneficiary, It is with gladness, i write you this message, to congratulate you on the successful release of the sum of $25 Million USD to you, Credited to Online Bank ATM Card account that was set up for you in our bank the Intercontinental Bank Plc. The Metropolitan Courier is unable to complete the Delivery of your ATM Card with the details we received from IMF, So we require some more information in order to complete this transfer. * Your Full Names:_ * Contact Address:_ * Message Phone:_ * Mobile Phone:_ * Home Phone:_ * Fax:_ * Occupation:_ * Marital Status:_ * Age:_ In order to resolve this problem, Please email us immediately. As soon as this information is received. Reply to:sirjimmy...@yahoo.co.jp Thank you as we anticipate your prompt response. Yours Faithfully, Mr. Jimmy Isu ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V7 2/3] PMIC: Add dialog pmic support
On 05/13/2011 05:08 AM, Jason Liu wrote:
> Hi, Stefano,
Hi Jason,
>> This is not what I meant. You have duplicated the code, instead of merge
>> the two functions together. And I think the switch is wrong.
>> This file provides a general access to PMIc using SPI/I2C. There should
>> not be #ifdef related to a single PMIC. Instead of that, You need
>> additional CONFIG_ to select how to access the PMIC (8 bit or 32 bit).
>
> Then can we have the CONFIG_SYS_DIALOG_PMIC_I2C_ADDR or
> CONFIG_SYS_FSL_PMIC_I2C_ADDR in this file?
>
> Please tell clear about your mean, don't let me guess what you mean?
I thought it was already clear, but probably not enough. We do not need
special CONFIG_ to select the same attribute for different PMICs. What
is the functional difference between CONFIG_SYS_DIALOG_PMIC_I2C_ADDR and
CONFIG_SYS_FSL_PMIC_I2C_ADDR ? They set exactly the same thing. If we
add several other PMIC, should each of them have a separate CONFIG_ for
the I2C address ? Surely not.
We need only one of them. It seems to me you get confused due to the
original name, that contains the FSL_ string. But think at what this
driver provides: an API to access the PMICs using SPI or I2C, unrelated
to the specific chosen chip.
By the way, you can still use the old name CONFIG_SYS_FSL_PMIC_I2C_ADDR
for your patch. I understand that changing names here means also to
change other boards, that are not related to your patch.
I will then send a patch to reorganize the names after integrating your
patch in the tree.
>
>>
>> IMHO we can rid of the check_param() function, as this is a constraint
>> to have an implementation independent from a single PMIC.
>
> If you think we don't need check_param, then It's ok. I can remove it.
> Since this function is added by you before.
The function seemed ok when I write the first version, but it seems
overkilling now.
>
>>
>> I would prefer something like this:
>>
>> u32 pmic_reg(u32 reg, u32 val, u32 write) {
>>
>>
>> #ifdef CONFIG_SYS_PMIC_8BIT
>>
>>
>> #else
>>
>>
>> #endif
>
> Then what you prefer is function pointer or something else?
> Please tell clear, otherwise, it will cost another time to do it.
To be more clearer: this driver should not have inside different
implementations based on a chip type, but based on the specific
*features* or options that are needed to implement. As you see in my
example, it should be possible to access to a PMIC with 8bit with your
implementation also with other PMICs. If we have to add several other
chips, the code (that is real simple) becomes easy unreadable.
As I said, do not change the CONFIG_ names in your patch, as this can
create some confusion, as I see. I will do it later.
>>> +#if defined(CONFIG_FSL_PMIC_I2C) || defined(CONFIG_DIALOG_PMIC_I2C)
>>
>> Same comments apply here. We should select only between I2C and SPI, not
>> the chip.
>>
>>> +#if defined(CONFIG_FSL_PMIC)
>>> +#define PMIC_NAME "Freescale PMIC (Atlas)"
>>> +#elif defined(CONFIG_DIALOG_PMIC)
>>> +#define PMIC_NAME "Dialog PMIC (DA905x)"
>>> +#else
>>> +#error "Unkown PMIC name"
>>> +#endif
>>
>> Instead of that, we can set a general name or put the PMIC_NAME inside
>> the specific PMIC header file.
>
> Then what general name you think it's good?
It should be unrelated from the specific chip (if you chose this
solution), such as "SPI/I2C PMIC", or dropped from this file and put
into the PMIC header file if you select solution 2).
>
> I have seen the painful for restructure with the second time, another
> is the make imximage.
If the code in a review is considered wrong, it must be changed. I
cannot avoid it.
> Can we avoid it in the future?
Check in the archive, and you see that changes were requested by several
reviewers an issue was discovered. And for the LOCO the patches were
removed after beeing accepted due to issues found later in the code,
that are considered unaccetable for mainline. I cannot foresee how many
reviews one patch requires, and how many issues a single patch raises.
On the other side, feel free to ask if something is not enough clear
*before* implementing. On my site, I will do my best to explain my
position, as all other reviewers in the list.
>
> And BTW, do you have any comments about the 1/3 clock patch? If you
> have, please tell it
> as early as possible and I don't want to let the patch version goes up
> very bigger and the time endless.
The patch adds several functions that are strictly related to the
processor and I am checking with the reference manuals to understand
them. I need more time for it.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
=
[U-Boot] build breakage with - Fix building tools alone with host compiler patch
The following commit breaks building MPC8572DS_config (and a lot more): commit bbc6353c740064c8e0741b772376a1a67a1c3f01 Author: François Revol Date: Fri Mar 18 11:03:03 2011 + Fix building tools alone with host compiler - don't include config.h when building with host cc, - HOSTCFLAGS was defined with the wrong name, so wasn't used, - make sure make finds sources outside of tools/. Signed-off-by: Fran?ois Revol we get: /local/home/galak/git/u-boot-85xx/common/env_embedded.c:28:20: error: config.h: No such file or directory /local/home/galak/git/u-boot-85xx/common/env_embedded.c:30:25: error: environment.h: No such file or directory /local/home/galak/git/u-boot-85xx/common/image.c:27:20: error: common.h: No such file or directory /local/home/galak/git/u-boot-85xx/common/image.c:28:22: error: watchdog.h: No such file or directory /local/home/galak/git/u-boot-85xx/common/image.c:46:19: error: image.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/crc32.c:12:20: error: common.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/crc32.c:14:22: error: compiler.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/crc32.c:15:24: error: u-boot/crc.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/crc32.c:20:25: error: u-boot/zlib.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/md5.c:28:22: error: compiler.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/md5.c:31:20: error: common.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/md5.c:32:22: error: watchdog.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/md5.c:34:24: error: u-boot/md5.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/sha1.c:33:20: error: common.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/sha1.c:38:22: error: watchdog.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/sha1.c:39:18: error: sha1.h: No such file or directory /local/home/galak/git/u-boot-85xx/tools/bmp_logo.c:1:22: error: compiler.h: No such file or directory /local/home/galak/git/u-boot-85xx/tools/envcrc.c:35:20: error: config.h: No such file or directory In file included from /local/home/galak/git/u-boot-85xx/tools/img2srec.c:55: /local/home/galak/git/u-boot-85xx/tools/os_support.h:22:22: error: compiler.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt.c:51:24: error: libfdt_env.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt.c:54:17: error: fdt.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt.c:55:20: error: libfdt.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_ro.c:51:24: error: libfdt_env.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_ro.c:54:17: error: fdt.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_ro.c:55:20: error: libfdt.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_rw.c:51:24: error: libfdt_env.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_rw.c:54:17: error: fdt.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_rw.c:55:20: error: libfdt.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_strerror.c:51:24: error: libfdt_env.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_strerror.c:54:17: error: fdt.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_strerror.c:55:20: error: libfdt.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_wip.c:51:24: error: libfdt_env.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_wip.c:54:17: error: fdt.h: No such file or directory /local/home/galak/git/u-boot-85xx/lib/libfdt/fdt_wip.c:55:20: error: libfdt.h: No such file or directory make[1]: *** No rule to make target `.depend', needed by `_depend'. Stop. Issue looks to be with HOSTCFLAGS. Not sure if rules.mk needs updating or what. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Decreases code size of the nand_spl
On Thursday 12 May 2011 23:49:40 Wolfgang Denk wrote: > > This patch decreases the code size of the nand_spl by turning multiple > > function pointer dereferences in a single function into a single local > > function pointer. > > > > Signed-off-by: Alex Waterman > > Cc: Scott Wood > > Cc: Stefan Roese > > --- > > This works on my local board but I haven't tested it on anything else > > since I do not have access to any other hardware. I did make sure the > > canyonlands board still builds. > > > > nand_spl/nand_boot.c | 50 > > -- 1 files changed, 28 > > insertions(+), 22 deletions(-) > > Can this patch go in, please? I would like to see the build problems > fixed. > > Stefan, eventually you want to add your Tested-by: and/or Acked-by: ? Sure: Acked-by: Stefan Roese Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 2/3] km/common: simplify default environment
This is a first step to simplify the default environment. Move all
the environment variables which are only needed for debugging
purpose to textfiles in the scripts directory. In case of debugging
these files can be loaded via tftp into RAM and set via the env import
command. Other variables are identified as obsolete and were removed.
Signed-off-by: Holger Brunck
Signed-off-by: Valentin Longchamp
Acked-by: Heiko Schocher
cc: Wolfgang Denk
cc: Detlev Zundel
---
Changes for v3 and v4:
- nothing
Changes for v2:
- split up first large patch serie to three independent smaller
patch series
- no change in the content of this patch
board/keymile/scripts/README | 23 +
board/keymile/scripts/debug-arm-env.txt|2 +
board/keymile/scripts/debug-common-env.txt |9 ++
board/keymile/scripts/debug-ppc-env.txt|2 +
include/configs/km/keymile-common.h| 128 +++-
include/configs/km/km-powerpc.h| 12 +--
include/configs/km/km_arm.h|5 +-
7 files changed, 55 insertions(+), 126 deletions(-)
create mode 100644 board/keymile/scripts/README
create mode 100644 board/keymile/scripts/debug-arm-env.txt
create mode 100644 board/keymile/scripts/debug-common-env.txt
create mode 100644 board/keymile/scripts/debug-ppc-env.txt
diff --git a/board/keymile/scripts/README b/board/keymile/scripts/README
new file mode 100644
index 000..86c2b5a
--- /dev/null
+++ b/board/keymile/scripts/README
@@ -0,0 +1,23 @@
+debug-common-env.txt
+
+This file defines environment variables which are valid for powerpc boards
+and for arm boards.
+
+addramfs: add phram device for the rootfilesysten in ram
+develop: for development, laod kernel via tftp and mount rootfs via NFS
+nfsargs: default arguments for nfs boot
+ramfs: load rootfilesystem in RAM kernel
+rootfsfile: loacation of the rootfs file for ramfs
+setramfspram: compute PRAM size for ramfs target
+setrootfsaddr: compute rootfilesystem address for phram
+tftpkernel: load a kernel with tftp into ram
+tftpramfs: load rootfs with tftp into ram
+
+debug-ppc-env.txt
+
+fdt_file: location of the dtb file on the tftp server
+tftpfdt: load dtb file and set fdt address
+
+debug-arm-env.txt
+
+tftpfdt: for arm only a dummy variable, because we have no fdt on arm
diff --git a/board/keymile/scripts/debug-arm-env.txt
b/board/keymile/scripts/debug-arm-env.txt
new file mode 100644
index 000..84498af
--- /dev/null
+++ b/board/keymile/scripts/debug-arm-env.txt
@@ -0,0 +1,2 @@
+debug_env_common=tftpboot 0x20 scripts/debug-common-env.txt && env import
-t 0x20 ${filesize}
+tftpfdt=true
diff --git a/board/keymile/scripts/debug-common-env.txt
b/board/keymile/scripts/debug-common-env.txt
new file mode 100644
index 000..1fd4b0c
--- /dev/null
+++ b/board/keymile/scripts/debug-common-env.txt
@@ -0,0 +1,9 @@
+addramfs=setenv bootargs "${bootargs}
phram.phram=rootfs${boot_bank},${rootfsaddr},${rootfssize}"
+develop=setenv subbootcmds "tftpfdt tftpkernel nfsargs ${commonargs} boot " &&
setenv bootcmd 'run bootrunner' && setenv altbootcmd 'run bootcmd' &&
km_setboardid && saveenv && reset
+nfsargs=setenv bootargs ubi.mtd=ubi0 root=/dev/nfs rw
nfsroot=${serverip}:${rootpath}
+ramfs=setenv actual_bank -1 && setenv subbootcmds "tftpfdt tftpkernel
setrootfsaddr tftpramfs flashargs ${commonargs} addpanic addramfs boot " &&
setenv bootcmd 'run bootrunner' && setenv altbootcmd 'run bootcmd' && run
setboardid && run setramfspram && run setpnvramaddr && saveenv && reset
+rootfsfile=${hostname}/rootfsImage
+setramfspram=setexpr value 0 + ${reservedpram} && setexpr value 0x${value} +
${rootfssize} && setexpr value 0x${value} + ${varsize} && setexpr value
0x${value} + ${pnvramsize} && setexpr value 0x${value} / 0x400 && setenv pram
0x${value}
+tftpkernel=tftpboot ${kernel_addr_r} ${hostname}/uImage && setenv
actual_kernel_addr ${kernel_addr_r}
+tftpramfs=tftpboot ${rootfsaddr} ${hostname}/rootfsImage && setenv loadaddr
+setrootfsaddr=setexpr value ${pnvramsize} - ${rootfssize} && setenv rootfsaddr
0x${value}
diff --git a/board/keymile/scripts/debug-ppc-env.txt
b/board/keymile/scripts/debug-ppc-env.txt
new file mode 100644
index 000..3c06ff1
--- /dev/null
+++ b/board/keymile/scripts/debug-ppc-env.txt
@@ -0,0 +1,2 @@
+debug_env_common=tftpboot 0x20 scripts/debug-common-env.txt && env import
-t 0x20 ${filesize}
+tftpfdt=tftpboot ${fdt_addr_r} ${hostname}/${hostname}.dtb && setenv
actual_fdt_addr ${fdt_addr_r}
diff --git a/include/configs/km/keymile-common.h
b/include/configs/km/keymile-common.h
index 6a5ecc6..9ad2e5b 100644
--- a/include/configs/km/keymile-common.h
+++ b/include/configs/km/keymile-common.h
@@ -169,13 +169,8 @@
"break=0; " \
"for subbootcmd in ${subbootcmds}; do " \
[U-Boot] [PATCH v4 0/3] km/common mainlining remaining parts
This patch serie comprehends the missing parts of the mostly already committed patch serie "v2 km/common mainlining". See: http://lists.denx.de/pipermail/u-boot/2011-May/092323.html Holger Brunck (2): km/common: simplify default environment km/common: add pnvramsize to default environment Thomas Herzmann (1): km/common: implement boardId HWkey checks as u-boot cmd board/keymile/common/common.c | 156 +++ board/keymile/scripts/README | 23 board/keymile/scripts/debug-arm-env.txt|2 + board/keymile/scripts/debug-common-env.txt |9 ++ board/keymile/scripts/debug-ppc-env.txt|2 + include/configs/km/keymile-common.h| 159 +++- include/configs/km/km-powerpc.h| 12 +-- include/configs/km/km_arm.h|5 +- 8 files changed, 213 insertions(+), 155 deletions(-) create mode 100644 board/keymile/scripts/README create mode 100644 board/keymile/scripts/debug-arm-env.txt create mode 100644 board/keymile/scripts/debug-common-env.txt create mode 100644 board/keymile/scripts/debug-ppc-env.txt ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 3/3] km/common: add pnvramsize to default environment
The pnvram size was used later from start scripts in linux. Therefore it was added to the default environment. Signed-off-by: Holger Brunck Signed-off-by: Valentin Longchamp Acked-by: Heiko Schocher cc: Wolfgang Denk cc: Detlev Zundel --- changes for v4: - fix small bug introduced in v2, remove "0x" which is already part of the define in the header Changes for v3: - nothing Changes for v2: - split up first large patch serie to three independent smaller patch series - rework the patch with inputs from W.Denk: - move variable from c-code to default env to be present in any case when linux starts include/configs/km/keymile-common.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/configs/km/keymile-common.h b/include/configs/km/keymile-common.h index 9ad2e5b..f89a2ea 100644 --- a/include/configs/km/keymile-common.h +++ b/include/configs/km/keymile-common.h @@ -293,6 +293,7 @@ "setenv default 'run newenv; reset' && " \ "run release && saveenv; reset\0" \ "checkboardid=km_checkbidhwk\0" \ + "pnvramsize=" xstr(CONFIG_KM_PNVRAM) "\0" \ "" #ifndef CONFIG_KM_DEF_ENV -- 1.7.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 1/3] km/common: implement boardId HWkey checks as u-boot cmd
From: Thomas Herzmann
BoardId and HWKey are used to identify the HW class of a given board.
The correct values are stored in the inventory eeprom. During creation
time of a boot package the boardId and HWkey for the SW is stored in
the default environment and burned into the flash. During boottime
the values in the inventory and in the environment are compared to
avoid starting of a SW which is not authorized for this board.
Some bootpackages are allowed to run on a set of different boardId
hwKey. In this case the environment variable boardIdListHex was added
to the default environment. In this case the command iterates over the
pair values and compares them with the values read from the inventory
eeprom.
The syntax of such a boardIdListHex value is e.g.: 158_1 159_1 159_2
Signed-off-by: Thomas Herzmann
Signed-off-by: Holger Brunck
Signed-off-by: Valentin Longchamp
Acked-by: Heiko Schocher
cc: Wolfgang Denk
cc: Detlev Zundel
---
Changes for v4:
- fix small bug introduced in v3 due to the enhanced error handling,
return the return code (rc) and not 1 in any case
Changes for v3:
- add further error handling
- rework the patch with inputs from W.Denk:
- introduce emtpy line after varaiable declaration
- fix one checkpatch warning
- add comment why we use simple_strtoul
Changes for v2:
- split up first large patch series to three independent smaller
patch series
- give the cmd a more precise name
- rework the patch with inputs from W.Denk:
- adapt and enhance commit msg
- comment the code
- add error handling
board/keymile/common/common.c | 156 +++
include/configs/km/keymile-common.h | 30 +---
2 files changed, 157 insertions(+), 29 deletions(-)
diff --git a/board/keymile/common/common.c b/board/keymile/common/common.c
index 9adfefa..9be4c72 100644
--- a/board/keymile/common/common.c
+++ b/board/keymile/common/common.c
@@ -32,6 +32,7 @@
#include
#include
#include
+#include
#if defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT)
#include
@@ -716,3 +717,158 @@ static int do_setboardid(cmd_tbl_t *cmdtp, int flag, int
argc,
U_BOOT_CMD(km_setboardid, 1, 0, do_setboardid, "setboardid", "read out bid and
"
"hwkey from IVM and set in environment");
+
+/*
+ * command km_checkbidhwk
+ * if "boardid" and "hwkey" are not already set in the environment, do:
+ * if a "boardIdListHex" exists in the environment:
+ * - read ivm data for boardid and hwkey
+ * - compare each entry of the boardIdListHex with the
+ * IVM data:
+ * if match:
+ * set environment variables boardid, boardId,
+ * hwkey, hwKey to the found values
+ * both (boardid and boardId) are set because
+ * they might be used differently in the
+ * application and in the init scripts (?)
+ * return 0 in case of match, 1 if not match or error
+ */
+int do_checkboardidhwk(cmd_tbl_t *cmdtp, int flag, int argc,
+ char *const argv[])
+{
+ unsigned long ivmbid = 0, ivmhwkey = 0;
+ unsigned long envbid = 0, envhwkey = 0;
+ char *p;
+ int verbose = argc > 1 && *argv[1] == 'v';
+ int rc = 0;
+
+ /*
+* first read out the real inventory values, these values are
+* already stored in the local hush variables
+*/
+ p = get_local_var("IVM_BoardId");
+ if (p == NULL) {
+ printf("can't get the IVM_Boardid\n");
+ return 1;
+ }
+ rc = strict_strtoul(p, 16, &ivmbid);
+
+ p = get_local_var("IVM_HWKey");
+ if (p == NULL) {
+ printf("can't get the IVM_HWKey\n");
+ return 1;
+ }
+ rc = strict_strtoul(p, 16, &ivmhwkey);
+
+ if (!ivmbid || !ivmhwkey) {
+ printf("Error: IVM_BoardId and/or IVM_HWKey not set!\n");
+ return rc;
+ }
+
+ /* now try to read values from environment if available */
+ p = getenv("boardid");
+ if (p != NULL)
+ rc = strict_strtoul(p, 16, &envbid);
+ p = getenv("hwkey");
+ if (p != NULL)
+ rc = strict_strtoul(p, 16, &envhwkey);
+
+ if (rc != 0) {
+ printf("strict_strtoul returns error: %d", rc);
+ return rc;
+ }
+
+ if (!envbid || !envhwkey) {
+ /*
+* BoardId/HWkey not available in the environment, so try the
+* environment variable for BoardId/HWkey list
+*/
+ char *bidhwklist = getenv("boardIdListHex");
+
+ if (bidhwklist) {
+ int found = 0;
+ char *rest = bidhwklist;
+
Re: [U-Boot] OSE support shouldnt be enabled by default
I haven't had the time to look into this. Meanwhile, config_defaults.h can be reverted and I'll add CONFIG_BOOTM_OSE to the configs of the boards affected later. BR Torkel -Ursprungligt meddelande- Från: vapierfil...@gmail.com [mailto:vapierfil...@gmail.com] För Mike Frysinger Skickat: den 2 april 2011 01:11 Till: Torkel Lundgren Kopia: u-boot Ämne: OSE support shouldnt be enabled by default the commit below slipped in without me noticing ... could you please revert the change to this header and only enable support for this OS in whatever boards you're using ? especially considering this OS only works for specific setups (phones) and on few processors (ARM, PPC, MIPS). -mike commit 3df61957938586c512c17e72d83551d190400981 Author: Torkel Lundgren Date: Tue Sep 28 11:05:36 2010 +0200 Add support for operating system OSE Add OSE as operating system for mkimage and bootm. Signed-off-by: Torkel Lundgren diff --git a/include/config_defaults.h b/include/config_defaults.h index 0337163..abdf3be 100644 --- a/include/config_defaults.h +++ b/include/config_defaults.h @@ -12,6 +12,7 @@ /* Support bootm-ing different OSes */ #define CONFIG_BOOTM_LINUX 1 #define CONFIG_BOOTM_NETBSD 1 +#define CONFIG_BOOTM_OSE 1 #define CONFIG_BOOTM_RTEMS 1 #define CONFIG_GZIP 1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [GIT PULL] Pull request u-boot-mpc85xx
The following changes since commit 3500e9aed6e13a988f4a5ef6503112fda1c4a7fc: Nobuhiro Iwamatsu (1): kwbimage: Fix check variable of checksum are available in the git repository at: git://git.denx.de/u-boot-mpc85xx master Timur Tabi (1): powerpc/85xx: fix compatible property for the L2 cache node York Sun (1): powerpc/mpc8xxx: reword max tCKmin message arch/powerpc/cpu/mpc85xx/fdt.c | 29 +--- .../cpu/mpc8xxx/ddr/lc_common_dimm_params.c|6 ++-- 2 files changed, 22 insertions(+), 13 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] omap4: add support for gpios
On 05/13/2011 07:31 AM, John Rigby wrote: >> >> I am going to fix this and resend another round of patches. But, it this >> the only thing I should fix? >> > My comment was not a complete review only a comment about sharing. I got that, I am just trying to get more comments before I send another round of patches, in order to avoid having to send 10 rounds of patches. Maybe the patches were sent to the wrong person? -- Gilles. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] omap4: add support for gpios
> > I am going to fix this and resend another round of patches. But, it this > the only thing I should fix? > My comment was not a complete review only a comment about sharing. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] omap4: add support for gpios
On 05/10/2011 04:08 PM, John Rigby wrote: > On Mon, May 9, 2011 at 11:04 PM, Gilles Chanteperdrix > wrote: >> Copied from omap3. > I have not looked at the code but if it truly is a copy (other than > some base addresses) is there a way to share with omap3? I am going to fix this and resend another round of patches. But, it this the only thing I should fix? For instance, in part of the patch, I used hardcoded hardware addresses, in other part, I put some #define for register addresses in the .c file, in other part, the #define are in a common header. What is the policy in u-boot for this particular point? -- Gilles. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Be Informed
You Are A Recipient Of $530,000.00!! Our Movie company have chosen you via your e-mail to receive $530,000.00 and to attend our movie event holding in (Malaysia) 20th July, 2011 in commemoration of our 25th movie anniversary. You can receive amount before event date. Answer this: Name, Phone, Have you traveled outside your country, Have the requested information emailed to: j...@comcbd.co.cc Best Regards, Movie World Inc. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix variable flavor in examples/standalone/Makefile
Thanks, Wolfgang. On Fri, May 13, 2011 at 4:30 AM, Wolfgang Denk wrote: > Dear Che-liang Chiou, > > In message you > wrote: >> GNU Makefile have two flavors of variables, recursively expanded that is >> defined by using '=', and simply expanded that is defined by using ':='. >> >> The bug is caused by using recursively expanded flavor for BIN and SREC. >> As you can see below, they are prepended by $(obj) twice. >> >> We can reproduce this bug with a simplified version of this Makefile: >> $ cat > Makefile <> obj := /path/to/obj/ >> ELF := hello_world >> >> BIN_rec = $(addsuffix .bin,$(ELF)) # recursively expanded >> BIN_sim := $(addsuffix .bin,$(ELF)) # simply expanded >> >> ELF := $(addprefix $(obj),$(ELF)) >> BIN_rec := $(addprefix $(obj),$(BIN_rec)) >> BIN_sim := $(addprefix $(obj),$(BIN_sim)) >> >> show: >> @echo BIN_rec=$(BIN_rec) >> @echo BIN_sim=$(BIN_sim) >> >> .PHONY: show >> EOF >> $ make show >> BIN_rec=/path/to/obj//path/to/obj/hello_world.bin >> BIN_sim=/path/to/obj/hello_world.bin >> >> Signed-off-by: Che-Liang Chiou >> --- >> >> examples/standalone/Makefile | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) > > Applied, thanks. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > It all seemed, he thought, to be rather a lot of trouble to go to > just sharpen a razor blade. - Terry Pratchett, _The Light Fantastic_ > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Good day
Am Mrs Annabel Laura am going on a cancer surgery today.contact my lawyer,Tell him that I have WILLED 14.258M to you.quoting my personal reference number BB/AMZ/900/2015/SWYI/316uk My lawyer Name barrister Lio Bacon. Attorney at-Law. Lio Bacon & Associates LLP E-mail; barrliobaconlawfi...@lawyer.com Tell; +44-7031-864-662 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V7 3/3] MX53: support for freescale MX53LOCO board
Hi, Stefano, On Thu, May 12, 2011 at 5:03 PM, Stefano Babic wrote: > On 05/12/2011 08:13 AM, Jason Liu wrote: >> Hi, Stefano, >> > > Hi Jason, > u32 get_cpu_rev(void); #define is_soc_rev(rev) ((get_cpu_rev() & 0xFF) - rev) void sdelay(unsigned long); +void pmic_reg_write(u32 reg, u32 value); +u32 pmic_reg_read(u32 reg); >>> >>> The pmic_ prototypes have nothing to do with the Soc prototype, as they >>> are specific for a driver. You should move them in the dialog header. >>> >> >> I think I need create one head file named: include/dlg_pmic.h to include the >> pmic_reg_write/read declaration and not just put the declaration to >> da9053.h file, what's your idea? > > You are right, I have only concerns to add a new file only to put three > prototypes Anyway, it seems to me also a cleaner solution. > > However, the name of file should be general, as the prototypes are used > for all PMICs using the SPI/I2C interfaces. Probably spi_i2c_pmic.h to > stay coherent with the driver name. Then for more cleaner, I will remove the duplicated declaration from fsl_pmic.h Jason > > Best regards, > Stefano Babic > > -- > = > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de > = > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V7 2/3] PMIC: Add dialog pmic support
Hi, Stefano,
2011/5/12 Stefano Babic :
> On 05/11/2011 10:03 AM, Jason Liu wrote:
>> This patch add dialog pmic(DA9053) driver with I2C interface support
>> In order to not duplicate code and according to the discussion on the
>> mail-list, change fsl_pmic.c to spi_i2c_pmic.c.Actaully,spi_i2c_pmic.c
>> is just a wrapper for PMIC communication when SPI or I2C is used.
>>
>> Signed-off-by: Jason Liu
>> Cc: sba...@denx.de
>> Cc: Detlev Zundel
>
> Hi Jason,
>
>> --- a/drivers/misc/fsl_pmic.c
>> +++ b/drivers/misc/spi_i2c_pmic.c
>> @@ -22,13 +22,16 @@
>>
>> #include
>> #include
>> +#include
>> #include
>> #include
>> +#if defined(CONFIG_FSL_PMIC)
>> #include
>> +#endif
>>
>> -static int check_param(u32 reg, u32 write)
>> +static int check_param(u32 reg, u32 write, u32 max_reg)
>> {
>> - if (reg > 63 || write > 1) {
>> + if (reg > max_reg || write > 1) {
>> printf(" = %d is invalid. Should be less then 63\n",
>> reg);
>> return -1;
>> @@ -37,15 +40,13 @@ static int check_param(u32 reg, u32 write)
>> return 0;
>> }
>>
>> -#ifdef CONFIG_FSL_PMIC_I2C
>> -#include
>> -
>> -u32 pmic_reg(u32 reg, u32 val, u32 write)
>> +#if defined(CONFIG_FSL_PMIC_I2C)
>> +u32 fsl_pmic_reg(u32 reg, u32 val, u32 write)
>> {
>> - unsigned char buf[4] = { 0 };
>> u32 ret_val = 0;
>> + unsigned char buf[4] = { 0 };
>>
>> - if (check_param(reg, write))
>> + if (check_param(reg, write, 63))
>> return -1;
>>
>> if (write) {
>> @@ -62,7 +63,44 @@ u32 pmic_reg(u32 reg, u32 val, u32 write)
>>
>> return ret_val;
>> }
>> -#else /* SPI interface */
>> +#endif
>> +
>> +#if defined(CONFIG_DIALOG_PMIC_I2C)
>> +u32 dlg_pmic_reg(u32 reg, u32 val, u32 write)
>> +{
>> + u32 ret_val = 0;
>> + unsigned char buf[1] = { 0 };
>> +
>> + if (check_param(reg, write, 142))
>> + return -1;
>> +
>> + if (write) {
>> + buf[0] = (val) & 0xff;
>> + if (i2c_write(CONFIG_SYS_DIALOG_PMIC_I2C_ADDR, reg, 1, buf, 1))
>> + return -1;
>> + } else {
>> + if (i2c_read(CONFIG_SYS_DIALOG_PMIC_I2C_ADDR, reg, 1, buf, 1))
>> + return -1;
>> + ret_val = buf[0];
>> + }
>> +
>> + return ret_val;
>
> This is not what I meant. You have duplicated the code, instead of merge
> the two functions together. And I think the switch is wrong.
> This file provides a general access to PMIc using SPI/I2C. There should
> not be #ifdef related to a single PMIC. Instead of that, You need
> additional CONFIG_ to select how to access the PMIC (8 bit or 32 bit).
Then can we have the CONFIG_SYS_DIALOG_PMIC_I2C_ADDR or
CONFIG_SYS_FSL_PMIC_I2C_ADDR in this file?
Please tell clear about your mean, don't let me guess what you mean?
>
> IMHO we can rid of the check_param() function, as this is a constraint
> to have an implementation independent from a single PMIC.
If you think we don't need check_param, then It's ok. I can remove it.
Since this function is added by you before.
>
> I would prefer something like this:
>
> u32 pmic_reg(u32 reg, u32 val, u32 write) {
>
>
> #ifdef CONFIG_SYS_PMIC_8BIT
>
>
> #else
>
>
> #endif
Then what you prefer is function pointer or something else?
Please tell clear, otherwise, it will cost another time to do it.
>
>
>> +#if defined(CONFIG_FSL_PMIC_I2C) || defined(CONFIG_DIALOG_PMIC_I2C)
>
> Same comments apply here. We should select only between I2C and SPI, not
> the chip.
>
>> +#if defined(CONFIG_FSL_PMIC)
>> +#define PMIC_NAME "Freescale PMIC (Atlas)"
>> +#elif defined(CONFIG_DIALOG_PMIC)
>> +#define PMIC_NAME "Dialog PMIC (DA905x)"
>> +#else
>> +#error "Unkown PMIC name"
>> +#endif
>
> Instead of that, we can set a general name or put the PMIC_NAME inside
> the specific PMIC header file.
Then what general name you think it's good?
I have seen the painful for restructure with the second time, another
is the make imximage.
Can we avoid it in the future?
And BTW, do you have any comments about the 1/3 clock patch? If you
have, please tell it
as early as possible and I don't want to let the patch version goes up
very bigger and the time endless.
Thanks,
Jason
>
> Best regards,
> Stefano
>
> --
> =
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
> =
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] serial_device member functions don't know their serial port
On Thursday, May 12, 2011 20:35:39 Simon Glass wrote: > I am taking a look at serial ports in U-Boot and it seems that the various > functions in 'struct serial_device' do not include a pointer to the device > they are talking about. Therefore for devices with multiple ports there is > no way for these functions to know what to do. yep > The workaround in drivers/serial/serial.c (at least for NS16550) seems to > be to declare stub functions which have the port number built in: that tends to be how they all support multi instances. it's how i recently implemented support for multiple Blackfin UARTs. > Would it not be better to pass the port number (or better the serial_device > *) to each of the functions putc(), puts(), etc? What am I missing here? i'm assuming you mean only the func pointers and not the common api. we wouldnt want general code to have to do this. the device<->serial glue is awful. you can only output to one serial device at a time due to the global serial_current pointer. so if you set stdout to uart0 and then set stderr to uart1, both stdout and stderr will go to uart1. all silently and without warning of course. i'd like to see the device<->serial glue thrown out, as well as the serial layer itself. all the serial devices should simply be another stdio_dev. once we do that, we could update the stdio_dev api to pass a handle to its own stdio_dev->priv state to all of its func pointer. this, ultimately, should satisfy your original query. i'm guessing the serial_* funcs exist for historical/relocation purposes, but i'm not terribly familiar with either, so i dont know how viable it is to kill them off completely. if we do want to keep them around, i think it'd be easy to provide common stubs on top of the stdio_dev api ... a fairly large undertaking of code grind/shuffle, so i havent embarked on it, nor do i have plans to do so. maybe you're more masochistic than i :). -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/3] sntp: avoid use of uninitialized variable
From: Luuk Paulussen
When we use the ntpserverip environment variable argv[1] may not be set.
Printing the error message using the NetNtpServerIP variable ensures the
correct output in both cases.
Signed-off-by: Luuk Paulussen
Acked-by: Chris Packham
Cc: Ben Warren
---
common/cmd_net.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/common/cmd_net.c b/common/cmd_net.c
index 8c6f5c8..e0d7d23 100644
--- a/common/cmd_net.c
+++ b/common/cmd_net.c
@@ -324,7 +324,7 @@ int do_sntp (cmd_tbl_t *cmdtp, int flag, int argc, char *
const argv[])
else NetTimeOffset = simple_strtol (toff, NULL, 10);
if (NetLoop(SNTP) < 0) {
- printf("SNTP failed: host %s not responding\n", argv[1]);
+ printf("SNTP failed: host %pI4 not responding\n",
&NetNtpServerIP);
return 1;
}
--
1.7.4.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] sntp: avoid use of uninitialized variable
On Fri, May 13, 2011 at 1:29 PM, Chris Packham wrote: > From: Luuk Paulussen > > When we use the ntpserverip environment variable argv[1] may not be set. > Printing the error message using the NetNtpServerIP variable ensures the > correct output in both cases. > > Signed-off-by: Luuk Paulussen > Acked-by: Chris Packham > Cc: Ben Warren > --- Sorry for the spam. I was just trying (and failing) to get git to add the Cc. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] bootp: add ntpserver option to bootp request
On Fri, May 13, 2011 at 1:29 PM, Chris Packham wrote: > From: Luuk Paulussen > > Signed-off-by: Luuk Paulussen > Acked-by: Chris Packham > Cc: Ben Warren Sorry for the spam. I was just trying (and failing) to get git to add the Cc. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] rtc: add driver for internal RTC on kirkwood SoC
On Fri, May 13, 2011 at 1:29 PM, Chris Packham wrote: > From: Luuk Paulussen > > Signed-off-by: Luuk Paulussen > Acked-by: Chris Packham > Cc: Prafulla Wadaskar Sorry for the spam. I was just trying (and failing) to get git to add the Cc. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/3] bootp: add ntpserver option to bootp request
From: Luuk Paulussen
Signed-off-by: Luuk Paulussen
Acked-by: Chris Packham
Cc: Ben Warren
---
net/bootp.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/net/bootp.c b/net/bootp.c
index 4db63cb..53f37d0 100644
--- a/net/bootp.c
+++ b/net/bootp.c
@@ -228,6 +228,11 @@ static void BootpVendorFieldProcess (u8 * ext)
NetOurNISDomain[size] = 0;
}
break;
+#if defined(CONFIG_CMD_SNTP) && defined(CONFIG_BOOTP_NTPSERVER)
+ case 42:/* NTP server IP */
+ NetCopyIP (&NetNtpServerIP, (IPaddr_t *) (ext + 2));
+ break;
+#endif
/* Application layer fields */
case 43:/* Vendor specific info - Not yet supported
*/
/*
@@ -278,6 +283,9 @@ static void BootpVendorProcess (u8 * ext, int size)
if (NetBootFileSize)
debug("NetBootFileSize: %d\n", NetBootFileSize);
+
+ if (NetNtpServerIP)
+ debug("NetNtpServerIP : %pI4\n", &NetNtpServerIP);
}
/*
* Handle a BOOTP received packet.
@@ -538,6 +546,11 @@ static int BootpExtended (u8 * e)
*e++ = 32;
e += 32;
#endif
+#if defined(CONFIG_BOOTP_NTPSERVER)
+ *e++ = 42;
+ *e++ = 4;
+ e += 4;
+#endif
*e++ = 255; /* End of the list */
--
1.7.4.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/3] rtc: add driver for internal RTC on kirkwood SoC
From: Luuk Paulussen
Signed-off-by: Luuk Paulussen
Acked-by: Chris Packham
Cc: Prafulla Wadaskar
---
arch/arm/include/asm/arch-kirkwood/kirkwood.h |2 +
drivers/rtc/Makefile |1 +
drivers/rtc/kirkwood.c| 76 +
3 files changed, 79 insertions(+), 0 deletions(-)
create mode 100644 drivers/rtc/kirkwood.c
diff --git a/arch/arm/include/asm/arch-kirkwood/kirkwood.h
b/arch/arm/include/asm/arch-kirkwood/kirkwood.h
index 0104418..15922eb 100644
--- a/arch/arm/include/asm/arch-kirkwood/kirkwood.h
+++ b/arch/arm/include/asm/arch-kirkwood/kirkwood.h
@@ -50,6 +50,8 @@
#define KW_MPP_BASE(KW_REGISTER(0x1))
#define KW_GPIO0_BASE (KW_REGISTER(0x10100))
#define KW_GPIO1_BASE (KW_REGISTER(0x10140))
+#define KW_RTC_TIME(KW_REGISTER(0x10300))
+#define KW_RTC_DATE(KW_REGISTER(0x10304))
#define KW_NANDF_BASE (KW_REGISTER(0x10418))
#define KW_SPI_BASE(KW_REGISTER(0x10600))
#define KW_CPU_WIN_BASE(KW_REGISTER(0x2))
diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
index e4be4a4..ec064d9 100644
--- a/drivers/rtc/Makefile
+++ b/drivers/rtc/Makefile
@@ -43,6 +43,7 @@ COBJS-$(CONFIG_RTC_DS174x) += ds174x.o
COBJS-$(CONFIG_RTC_DS3231) += ds3231.o
COBJS-$(CONFIG_RTC_FTRTC010) += ftrtc010.o
COBJS-$(CONFIG_RTC_ISL1208) += isl1208.o
+COBJS-$(CONFIG_RTC_KIRKWOOD) += kirkwood.o
COBJS-$(CONFIG_RTC_M41T11) += m41t11.o
COBJS-$(CONFIG_RTC_M41T60) += m41t60.o
COBJS-$(CONFIG_RTC_M41T62) += m41t62.o
diff --git a/drivers/rtc/kirkwood.c b/drivers/rtc/kirkwood.c
new file mode 100644
index 000..5c9bc81
--- /dev/null
+++ b/drivers/rtc/kirkwood.c
@@ -0,0 +1,76 @@
+/*
+ * Driver for the RTC in Marvell SoCs.
+ *
+ * Based on Linux Kernel driver.
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include
+#include
+#include
+#include
+#include
+
+#if defined(CONFIG_CMD_DATE)
+
+#define RTC_TIME_REG_OFFS 0
+#define RTC_SECONDS_OFFS 0
+#define RTC_MINUTES_OFFS 8
+#define RTC_HOURS_OFFS 16
+#define RTC_WDAY_OFFS 24
+#define RTC_HOURS_12H_MODE (1 << 22) /* 12 hours mode */
+
+#define RTC_DATE_REG_OFFS 4
+#define RTC_MDAY_OFFS 0
+#define RTC_MONTH_OFFS 8
+#define RTC_YEAR_OFFS 16
+#define KIRKWOOD_YEAR_BASE 2000
+
+int rtc_set(struct rtc_time *tmp)
+{
+ ulong rtc_reg;
+
+ GregorianDay (tmp);
+
+ rtc_reg = (bin2bcd(tmp->tm_sec) << RTC_SECONDS_OFFS) |
+ (bin2bcd(tmp->tm_min) << RTC_MINUTES_OFFS) |
+ (bin2bcd(tmp->tm_hour) << RTC_HOURS_OFFS) |
+ (bin2bcd(tmp->tm_wday) << RTC_WDAY_OFFS);
+ writel(rtc_reg, KW_RTC_TIME);
+
+ rtc_reg = (bin2bcd(tmp->tm_mday) << RTC_MDAY_OFFS) |
+ (bin2bcd(tmp->tm_mon + 1) << RTC_MONTH_OFFS) |
+ (bin2bcd(tmp->tm_year - KIRKWOOD_YEAR_BASE) <<
RTC_YEAR_OFFS);
+ writel(rtc_reg, KW_RTC_DATE);
+
+ return 0;
+}
+
+int rtc_get(struct rtc_time *tmp)
+{
+ ulong rtc_time, rtc_date;
+
+ rtc_time = readl(KW_RTC_TIME);
+ rtc_date = readl(KW_RTC_DATE);
+
+ tmp->tm_sec = bcd2bin(rtc_time & 0x7f);
+ tmp->tm_min = bcd2bin((rtc_time >> RTC_MINUTES_OFFS) & 0x7f);
+ tmp->tm_hour = bcd2bin((rtc_time >> RTC_HOURS_OFFS) & 0x3f); /* assume
24 hours mode */
+ tmp->tm_mday = bcd2bin(rtc_date & 0x3f);
+ tmp->tm_wday = bcd2bin((rtc_time >> RTC_WDAY_OFFS) & 0x7);
+ tmp->tm_mon = bcd2bin((rtc_date >> RTC_MONTH_OFFS) & 0x3f) - 1;
+ /* hw counts from year 2000, but tm_year is relative to 0 */
+ tmp->tm_year = bcd2bin((rtc_date >> RTC_YEAR_OFFS) & 0xff) +
KIRKWOOD_YEAR_BASE;
+
+ return 0;
+}
+
+void rtc_reset(void)
+{
+ return;
+}
+
+#endif /* CONFIG_CMD_DATE */
--
1.7.4.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/3] bootp: add ntpserver option to bootp request
From: Luuk Paulussen
Signed-off-by: Luuk Paulussen
Acked-by: Chris Packham
Cc: Ben Warren
---
net/bootp.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/net/bootp.c b/net/bootp.c
index 4db63cb..53f37d0 100644
--- a/net/bootp.c
+++ b/net/bootp.c
@@ -228,6 +228,11 @@ static void BootpVendorFieldProcess (u8 * ext)
NetOurNISDomain[size] = 0;
}
break;
+#if defined(CONFIG_CMD_SNTP) && defined(CONFIG_BOOTP_NTPSERVER)
+ case 42:/* NTP server IP */
+ NetCopyIP (&NetNtpServerIP, (IPaddr_t *) (ext + 2));
+ break;
+#endif
/* Application layer fields */
case 43:/* Vendor specific info - Not yet supported
*/
/*
@@ -278,6 +283,9 @@ static void BootpVendorProcess (u8 * ext, int size)
if (NetBootFileSize)
debug("NetBootFileSize: %d\n", NetBootFileSize);
+
+ if (NetNtpServerIP)
+ debug("NetNtpServerIP : %pI4\n", &NetNtpServerIP);
}
/*
* Handle a BOOTP received packet.
@@ -538,6 +546,11 @@ static int BootpExtended (u8 * e)
*e++ = 32;
e += 32;
#endif
+#if defined(CONFIG_BOOTP_NTPSERVER)
+ *e++ = 42;
+ *e++ = 4;
+ e += 4;
+#endif
*e++ = 255; /* End of the list */
--
1.7.4.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/3] rtc: add driver for internal RTC on kirkwood SoC
From: Luuk Paulussen
Signed-off-by: Luuk Paulussen
Acked-by: Chris Packham
Cc: Prafulla Wadaskar
---
arch/arm/include/asm/arch-kirkwood/kirkwood.h |2 +
drivers/rtc/Makefile |1 +
drivers/rtc/kirkwood.c| 76 +
3 files changed, 79 insertions(+), 0 deletions(-)
create mode 100644 drivers/rtc/kirkwood.c
diff --git a/arch/arm/include/asm/arch-kirkwood/kirkwood.h
b/arch/arm/include/asm/arch-kirkwood/kirkwood.h
index 0104418..15922eb 100644
--- a/arch/arm/include/asm/arch-kirkwood/kirkwood.h
+++ b/arch/arm/include/asm/arch-kirkwood/kirkwood.h
@@ -50,6 +50,8 @@
#define KW_MPP_BASE(KW_REGISTER(0x1))
#define KW_GPIO0_BASE (KW_REGISTER(0x10100))
#define KW_GPIO1_BASE (KW_REGISTER(0x10140))
+#define KW_RTC_TIME(KW_REGISTER(0x10300))
+#define KW_RTC_DATE(KW_REGISTER(0x10304))
#define KW_NANDF_BASE (KW_REGISTER(0x10418))
#define KW_SPI_BASE(KW_REGISTER(0x10600))
#define KW_CPU_WIN_BASE(KW_REGISTER(0x2))
diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
index e4be4a4..ec064d9 100644
--- a/drivers/rtc/Makefile
+++ b/drivers/rtc/Makefile
@@ -43,6 +43,7 @@ COBJS-$(CONFIG_RTC_DS174x) += ds174x.o
COBJS-$(CONFIG_RTC_DS3231) += ds3231.o
COBJS-$(CONFIG_RTC_FTRTC010) += ftrtc010.o
COBJS-$(CONFIG_RTC_ISL1208) += isl1208.o
+COBJS-$(CONFIG_RTC_KIRKWOOD) += kirkwood.o
COBJS-$(CONFIG_RTC_M41T11) += m41t11.o
COBJS-$(CONFIG_RTC_M41T60) += m41t60.o
COBJS-$(CONFIG_RTC_M41T62) += m41t62.o
diff --git a/drivers/rtc/kirkwood.c b/drivers/rtc/kirkwood.c
new file mode 100644
index 000..5c9bc81
--- /dev/null
+++ b/drivers/rtc/kirkwood.c
@@ -0,0 +1,76 @@
+/*
+ * Driver for the RTC in Marvell SoCs.
+ *
+ * Based on Linux Kernel driver.
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include
+#include
+#include
+#include
+#include
+
+#if defined(CONFIG_CMD_DATE)
+
+#define RTC_TIME_REG_OFFS 0
+#define RTC_SECONDS_OFFS 0
+#define RTC_MINUTES_OFFS 8
+#define RTC_HOURS_OFFS 16
+#define RTC_WDAY_OFFS 24
+#define RTC_HOURS_12H_MODE (1 << 22) /* 12 hours mode */
+
+#define RTC_DATE_REG_OFFS 4
+#define RTC_MDAY_OFFS 0
+#define RTC_MONTH_OFFS 8
+#define RTC_YEAR_OFFS 16
+#define KIRKWOOD_YEAR_BASE 2000
+
+int rtc_set(struct rtc_time *tmp)
+{
+ ulong rtc_reg;
+
+ GregorianDay (tmp);
+
+ rtc_reg = (bin2bcd(tmp->tm_sec) << RTC_SECONDS_OFFS) |
+ (bin2bcd(tmp->tm_min) << RTC_MINUTES_OFFS) |
+ (bin2bcd(tmp->tm_hour) << RTC_HOURS_OFFS) |
+ (bin2bcd(tmp->tm_wday) << RTC_WDAY_OFFS);
+ writel(rtc_reg, KW_RTC_TIME);
+
+ rtc_reg = (bin2bcd(tmp->tm_mday) << RTC_MDAY_OFFS) |
+ (bin2bcd(tmp->tm_mon + 1) << RTC_MONTH_OFFS) |
+ (bin2bcd(tmp->tm_year - KIRKWOOD_YEAR_BASE) <<
RTC_YEAR_OFFS);
+ writel(rtc_reg, KW_RTC_DATE);
+
+ return 0;
+}
+
+int rtc_get(struct rtc_time *tmp)
+{
+ ulong rtc_time, rtc_date;
+
+ rtc_time = readl(KW_RTC_TIME);
+ rtc_date = readl(KW_RTC_DATE);
+
+ tmp->tm_sec = bcd2bin(rtc_time & 0x7f);
+ tmp->tm_min = bcd2bin((rtc_time >> RTC_MINUTES_OFFS) & 0x7f);
+ tmp->tm_hour = bcd2bin((rtc_time >> RTC_HOURS_OFFS) & 0x3f); /* assume
24 hours mode */
+ tmp->tm_mday = bcd2bin(rtc_date & 0x3f);
+ tmp->tm_wday = bcd2bin((rtc_time >> RTC_WDAY_OFFS) & 0x7);
+ tmp->tm_mon = bcd2bin((rtc_date >> RTC_MONTH_OFFS) & 0x3f) - 1;
+ /* hw counts from year 2000, but tm_year is relative to 0 */
+ tmp->tm_year = bcd2bin((rtc_date >> RTC_YEAR_OFFS) & 0xff) +
KIRKWOOD_YEAR_BASE;
+
+ return 0;
+}
+
+void rtc_reset(void)
+{
+ return;
+}
+
+#endif /* CONFIG_CMD_DATE */
--
1.7.4.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/3] sntp: avoid use of uninitialized variable
From: Luuk Paulussen
When we use the ntpserverip environment variable argv[1] may not be set.
Printing the error message using the NetNtpServerIP variable ensures the
correct output in both cases.
Signed-off-by: Luuk Paulussen
Acked-by: Chris Packham
Cc: Ben Warren
---
common/cmd_net.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/common/cmd_net.c b/common/cmd_net.c
index 8c6f5c8..e0d7d23 100644
--- a/common/cmd_net.c
+++ b/common/cmd_net.c
@@ -324,7 +324,7 @@ int do_sntp (cmd_tbl_t *cmdtp, int flag, int argc, char *
const argv[])
else NetTimeOffset = simple_strtol (toff, NULL, 10);
if (NetLoop(SNTP) < 0) {
- printf("SNTP failed: host %s not responding\n", argv[1]);
+ printf("SNTP failed: host %pI4 not responding\n",
&NetNtpServerIP);
return 1;
}
--
1.7.4.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] serial_device member functions don't know their serial port
Hi,
I am taking a look at serial ports in U-Boot and it seems that the various
functions in 'struct serial_device' do not include a pointer to the device
they are talking about. Therefore for devices with multiple ports there is
no way for these functions to know what to do.
The workaround in drivers/serial/serial.c (at least for NS16550) seems to be
to declare stub functions which have the port number built in:
/* Multi serial device functions */
#define DECLARE_ESERIAL_FUNCTIONS(port) \
int eserial##port##_init (void) {\
int clock_divisor; \
clock_divisor = calc_divisor(serial_ports[port-1]); \
NS16550_init(serial_ports[port-1], clock_divisor); \
return(0);}\
void eserial##port##_setbrg (void) {\
serial_setbrg_dev(port);}\
int eserial##port##_getc (void) {\
return serial_getc_dev(port);}\
int eserial##port##_tstc (void) {\
return serial_tstc_dev(port);}\
void eserial##port##_putc (const char c) {\
serial_putc_dev(port, c);}\
void eserial##port##_puts (const char *s) {\
serial_puts_dev(port, s);}
...
DECLARE_ESERIAL_FUNCTIONS(1);
struct serial_device eserial1_device =
INIT_ESERIAL_STRUCTURE(1,"eserial0","EUART1");
DECLARE_ESERIAL_FUNCTIONS(2);
struct serial_device eserial2_device =
INIT_ESERIAL_STRUCTURE(2,"eserial1","EUART2");
Would it not be better to pass the port number (or better the serial_device
*) to each of the functions putc(), puts(), etc? What am I missing here?
Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 6/7] Tegra2: Add USB support
On Thu, May 12, 2011 at 12:43 PM, Remy Bohmer wrote: > Hi, > > 2011/5/5 Simon Glass : > > This adds basic USB support for port 0. The other port is not supported > by this CL. > > > > Signed-off-by: Simon Glass > > --- > > arch/arm/include/asm/arch-tegra2/tegra2.h |2 + > > arch/arm/include/asm/arch-tegra2/usb.h| 217 > > board/nvidia/common/Makefile | 53 + > > board/nvidia/common/board.c |5 + > > board/nvidia/common/usb.c | 313 > + > > drivers/usb/host/Makefile |1 + > > drivers/usb/host/ehci-hcd.c | 39 > > drivers/usb/host/ehci-tegra.c | 73 +++ > > drivers/usb/host/ehci.h |6 +- > > include/configs/harmony.h |7 + > > include/configs/seaboard.h| 10 + > > include/configs/tegra2-common.h | 30 +++ > > This patch touches a lot of files in different subsystems. > Please split it up. For example start with a patch series modifying > the generic USB code in drivers/usb, followed by a series that > modifies board files. > Hi Remy, Thanks for the response. The series has 7 patches in all. Do you mean that I should split this patch (number 6) in to several patches so that there are, say, 10 in all? I can see how to do that easily enough. When you say 'series' I wonder if you mean that you want this series split into several series... which I am less sure about. Regards, Simon > > Kind regards, > > Remy > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Decreases code size of the nand_spl
Dear Scott, In message <20110512165759.06923...@schlenkerla.am.freescale.net> you wrote: > > > Can this patch go in, please? I would like to see the build problems > > fixed. > > Yes, sorry for the delay -- I'll try to get to it tomorrow. Thanks. Guess you guys are as busy as evryone else ;-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The use of COBOL cripples the mind; its teaching should, therefore, be regarded as a criminal offense. - E. W. Dijkstra ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] OSE support shouldnt be enabled by default
Dear Mike Frysinger, In message <201105121739.51157.vap...@gentoo.org> you wrote: > > i did send out an actual patch to revert this, and you picked it up. Torkel > didnt comment on that either though (he was cc-ed) ... > > see commit 0aca983e058d6205962b3c09cb6ece520b6ea218 Ah, thanks. Forgot to unmakr this, then. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Vulcans never bluff. -- Spock, "The Doomsday Machine", stardate 4202.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Decreases code size of the nand_spl
On Thu, 12 May 2011 23:49:40 +0200 Wolfgang Denk wrote: > Dear Scott, > > In message <4dc1a7f1.7000...@dawning.com> Alex Waterman wrote: > > This patch decreases the code size of the nand_spl by turning multiple > > function > > pointer dereferences in a single function into a single local function > > pointer. > > > > Signed-off-by: Alex Waterman > > Cc: Scott Wood > > Cc: Stefan Roese > > --- > > This works on my local board but I haven't tested it on anything else since > > I > > do not have access to any other hardware. I did make sure the canyonlands > > board > > still builds. > > > > nand_spl/nand_boot.c | 50 > > -- > > 1 files changed, 28 insertions(+), 22 deletions(-) > > Can this patch go in, please? I would like to see the build problems > fixed. Yes, sorry for the delay -- I'll try to get to it tomorrow. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] kwbimage: Fix check variable of checksum
Dear Nobuhiro Iwamatsu, In message <1305084788-19689-1-git-send-email-nobuhiro.iwamatsu...@renesas.com> you wrote: > From: Nobuhiro Iwamatsu > > calc_hdrcsum two times are checked. checksumi of exthdr is not checked. > > Signed-off-by: Nobuhiro Iwamatsu > CC: Prafulla Wadaskar > --- > tools/kwbimage.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The typical page layout program is nothing more than an electronic light table for cutting and pasting documents. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] examples: add smc911x_eeprom to clean target
Dear Mike Frysinger, In message <1304805930-15654-1-git-send-email-vap...@gentoo.org> you wrote: > Signed-off-by: Mike Frysinger > --- > Makefile |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The use of Microsoft crippleware systems is a sin that carries with it its own punishment. -- Tom Christiansen in <6bo3fr$pj8$5...@csnews.cs.colorado.edu> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Decreases code size of the nand_spl
Dear Scott, In message <4dc1a7f1.7000...@dawning.com> Alex Waterman wrote: > This patch decreases the code size of the nand_spl by turning multiple > function > pointer dereferences in a single function into a single local function > pointer. > > Signed-off-by: Alex Waterman > Cc: Scott Wood > Cc: Stefan Roese > --- > This works on my local board but I haven't tested it on anything else since I > do not have access to any other hardware. I did make sure the canyonlands > board > still builds. > > nand_spl/nand_boot.c | 50 > -- > 1 files changed, 28 insertions(+), 22 deletions(-) Can this patch go in, please? I would like to see the build problems fixed. Stefan, eventually you want to add your Tested-by: and/or Acked-by: ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I think it's a new feature. Don't tell anyone it was an accident. :-) -- Larry Wall on s/foo/bar/eieio in <10...@jpl-devvax.jpl.nasa.gov> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ftpmu010.h: fix some missing declaration in header
Dear Macpaul Lin, In message <1304335727-25723-1-git-send-email-macp...@andestech.com> you wrote: > Fix some missing declaration in header. > > Signed-off-by: Macpaul Lin > --- > include/faraday/ftpmu010.h |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The use of anthropomorphic terminology when dealing with computing systems is a symptom of professional immaturity. -- Edsger Dijkstra ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 3/3] ftsmc020: add missing definitions
Dear Macpaul Lin, In message <1304324251-15293-3-git-send-email-macp...@andestech.com> you wrote: > Add missing definitions in header file according to datasheet. > > Signed-off-by: Macpaul Lin > --- > Changes for v2: > - Remove assembly register offsets for support lowlevel_init.S. > - The nested structure of register offsets has been rewrote. > - Fix relocation related declaration. > Changes for v3: > - Split this patch into 3 different patches according to Wolfgang's > suggestion >- Fix gloable declarations to avoid problem in relocation. >- Un-nested the register structure. >- Add missing definitions in header according to datasheet. > > include/faraday/ftsmc020.h |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Tactical? TACTICAL!?!? Hey, buddy, we went from kilotons to megatons several minutes ago. We don't need no stinkin' tactical nukes. (By the way, do you have change for 10 million people?) - lwall ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 2/3] ftsmc020: un-nest the register structure in header
Dear Macpaul Lin, In message <1304324251-15293-2-git-send-email-macp...@andestech.com> you wrote: > Un-nestted the register structure in ftsmc020.h > > Signed-off-by: Macpaul Lin > --- > Changes for v2: > - Remove assembly register offsets for support lowlevel_init.S. > - The nested structure of register offsets has been rewrote. > - Fix relocation related declaration. > Changes for v3: > - Split this patch into 3 different patches according to Wolfgang's > suggestion >- Fix gloable declarations to avoid problem in relocation. >- Un-nested the register structure. >- Add missing definitions in header according to datasheet. > > include/faraday/ftsmc020.h | 14 -- > 1 files changed, 8 insertions(+), 6 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Men will always be men -- no matter where they are. -- Harry Mudd, "Mudd's Women", stardate 1329.8 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 1/3] ftsmc020: fix relocation
Dear Macpaul Lin, In message <1304324251-15293-1-git-send-email-macp...@andestech.com> you wrote: > Avoid relocation problem by fix global declaration. > > Signed-off-by: Macpaul Lin > --- > Changes for v2: > - Remove assembly register offsets for support lowlevel_init.S. > - The nested structure of register offsets has been rewrote. > - Fix relocation related declaration. > Changes for v3: > - Split this patch into 3 different patches according to Wolfgang's > suggestion >- Fix gloable declarations to avoid problem in relocation. >- Un-nested the register structure. >- Add missing definitions in header according to datasheet. > > drivers/mtd/ftsmc020.c |7 +++ > 1 files changed, 3 insertions(+), 4 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I really hate this damned machine It never does quite what I want I wish that they would sell it. But only what I tell it. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] ftide020: add faraday ide ahb controller
Dear Macpaul Lin, In message <1304321336-16693-1-git-send-email-macp...@andestech.com> you wrote: > Faraday's ftide020_s is an IDE-AHB controller for SoC design. > This patch add the u-boot driver (PIO) of ftide020 ATA (IDE) driver. > IDE commands include read, info, and other functions has been implemented. > > Because this IDE controller support AHB interface only which is differ > from other most IDE controller supports PCI interface. Some registers > access is required during CMD/DATA I/O. Hence a configuration > "CONFIG_IDE_AHB" is required to be defined according to the feature in > cmd_ide.c. > > Signed-off-by: Macpaul Lin > --- > Changes for v2: > - replace default PIO mode from 0 to 4. > - clean up lines exceed 80 charecters as could as possible. > - Since the Linux driver of ftide020 hasn't been send to kernel mailing > list, > we fixed the GPL statement in this driver. > - clean up space before tab problem. > Changes for v3: > - Clean up remaining lines over 80 characters in ftide020.h. > - Remove useless driver version define. > - Remove redundant TRUE/FALSE define. > - Replace P_DEBUG marco to debug(). > > drivers/block/Makefile |1 + > drivers/block/ftide020.c | 367 > ++ > drivers/block/ftide020.h | 283 +++ > 3 files changed, 651 insertions(+), 0 deletions(-) > create mode 100644 drivers/block/ftide020.c > create mode 100644 drivers/block/ftide020.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Philosophy: A route of many roads leading from nowhere to nothing. - Ambrose Bierce ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] OSE support shouldnt be enabled by default
On Thursday, May 12, 2011 16:52:47 Wolfgang Denk wrote: > Mike Frysinger wrote: > > the commit below slipped in without me noticing ... could you please > > revert the change to this header and only enable support for this OS > > in whatever boards you're using ? especially considering this OS only > > works for specific setups (phones) and on few processors (ARM, PPC, > > MIPS). > > -mike > > > > commit 3df61957938586c512c17e72d83551d190400981 > > Author: Torkel Lundgren > > Date: Tue Sep 28 11:05:36 2010 +0200 > > > > Add support for operating system OSE > > > > Add OSE as operating system for mkimage and bootm. > > > > Signed-off-by: Torkel Lundgren > > > > diff --git a/include/config_defaults.h b/include/config_defaults.h > > index 0337163..abdf3be 100644 > > --- a/include/config_defaults.h > > +++ b/include/config_defaults.h > > @@ -12,6 +12,7 @@ > > > > /* Support bootm-ing different OSes */ > > #define CONFIG_BOOTM_LINUX 1 > > #define CONFIG_BOOTM_NETBSD 1 > > > > +#define CONFIG_BOOTM_OSE 1 > > > > #define CONFIG_BOOTM_RTEMS 1 > > > > #define CONFIG_GZIP 1 > > Please comment? i did send out an actual patch to revert this, and you picked it up. Torkel didnt comment on that either though (he was cc-ed) ... see commit 0aca983e058d6205962b3c09cb6ece520b6ea218 -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 2/2] README.arm-relocation: get relocated address in gdb
Dear Ben Gardiner, In message <7ed11e02b0db005231f5c6baa299761f3aa04f6f.1304024417.git.bengardi...@nanometrics.ca> you wrote: > When your emulator is connected at reset (or is used to load u-boot) > it is possible to get the relocation address from the gd->relocaddr > since gd is always in r8 (on ARM) it is addressable before the > gdb has remapped symbols. > > Document this alternate method in-line with the original method > written by Heiko Schocher. > > Signed-off-by: Ben Gardiner > CC: Heiko Schocher > CC: Wolfgang Denk > > --- > Changes since V2: > * add gd->relocaddr as a secondary method of obtaining the symbol-file >gdb argument > Changes since V1: > * update to reflect proposed changes to existing debug instructions: >renumber steps, remove note about -DDEBUG > --- > doc/README.arm-relocation |8 > 1 files changed, 8 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Military secrets are the most fleeting of all. -- Spock, "The Enterprise Incident", stardate 5027.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 1/2] README.arm-relocation: get relocated address from bdinfo
Dear Ben Gardiner, In message <787a04417ee0eb01c6eb3a7a1edff7ee9a8f825e.1304024417.git.bengardi...@nanometrics.ca> you wrote: > The bdinfo command prints the relocaddr on ARM as it does > on PPC. > > Update the debugging instructions for arm relocation to > reflect this fact rather than requiring that the user > rebuild the u-boot image using -DDEBUG. > > Signed-off-by: Ben Gardiner > CC: Wolfgang Denk > > --- > > Changes since V1: none; introduced in V2 > > doc/README.arm-relocation | 53 ++-- > 1 files changed, 22 insertions(+), 31 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "In matrimony, to hesitate is sometimes to be saved."- Butler ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] README.arm-relocation: get relocated address in gdb
Dear Ben Gardiner, In message <713eaea232693cd6775d409b17c2e187328d1598.1304008866.git.bengardi...@nanometrics.ca> you wrote: > When your emulator is connected at reset (or is used to load u-boot) > it is possible to get the relocation address from the parameter > passed to relocate_code() instead of building with -DDEBUG and > extracting from the console messages. > > Document this alternate method following the style of the original > method written by Heiko Schocher. > > Signed-off-by: Ben Gardiner > CC: Heiko Schocher > CC: Wolfgang Denk > > --- > > Changes since V1: > * update to reflect proposed changes to existing debug instructions: > renumber seteps, remove note about -DDEBUG > > --- > doc/README.arm-relocation | 51 > + > 1 files changed, 51 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Only two things are infinite, the universe and human stupidity, and I'm not sure about the former. -- Albert Einstein ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/2] README.arm-relocation: get relocated address from bdinfo
Dear Ben Gardiner, In message <787a04417ee0eb01c6eb3a7a1edff7ee9a8f825e.1304008866.git.bengardi...@nanometrics.ca> you wrote: > The bdinfo command prints the relocaddr on ARM as it does > on PPC. > > Update the debugging instructions for arm relocation to > reflect this fact rather than requiring that the user > rebuild the u-boot image using -DDEBUG. > > Signed-off-by: Ben Gardiner > CC: Wolfgang Denk > > --- > > No changes since V1 / introduced in this version > > --- > doc/README.arm-relocation | 53 ++-- > 1 files changed, 22 insertions(+), 31 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The flow chart is a most thoroughly oversold piece of program docu- mentation. -- Frederick Brooks, "The Mythical Man Month" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] cosmetic: cmd_bdinfo.c: clean up by using checkpatch.pl
Dear Macpaul Lin, In message <1303957715-10873-1-git-send-email-macp...@andestech.com> you wrote: > cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl > > Signed-off-by: Macpaul Lin > --- > Changes for v2: > - Correct the subject field to single patch. > Changes for v3: > - 405XX, 440XX, XILINX_405 are sorted according to the reviewing >suggestion. > - Replace the subject field according to the new rules. > > common/cmd_bdinfo.c | 296 > ++- > 1 files changed, 149 insertions(+), 147 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A failure will not appear until a unit has passed final inspection. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mp2usb: finish the removal
Dear =?UTF-8?q?Eric=20B=C3=A9nard?=, In message <1303935504-4918-1-git-send-email-e...@eukrea.com> you wrote: > - remove from boards.cfg > - add to doc/README.scrapyard > > Signed-off-by: Eric Bénard > --- > boards.cfg |1 - > doc/README.scrapyard |1 + > 2 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Any excuse will serve a tyrant." - Aesop ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] README: Clarify difference of CONFIG_WATCHDOG and CONFIG_HW_WATCHDOG
Dear Detlev Zundel, In message <1303917959-32324-1-git-send-email-...@denx.de> you wrote: > Now that we have the documentation, the code should be changed to reflect > it ;) > > Asd far as I can see, these are the places where HW_WATCHDOG is used > instead of WATCHDOG: > > arch/blackfin/cpu/blackfin/watchdog.c > arch/m68k/cpu/mcf547x_8x/cpu.c > > The relevant maintainers are on CC. > > Signed-off-by: Detlev Zundel > Cc: Mike Frysinger > Cc: TsiChungLiew > --- > README | 17 - > 1 files changed, 12 insertions(+), 5 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Be careful what you wish for. You never know who will be listening. - Terry Pratchett, _Soul Music_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] ftsdmc021: add register definitions of ftsdmc021
Dear Macpaul Lin, In message <1303817387-9472-2-git-send-email-macp...@andestech.com> you wrote: > Support registers definitions of ftsdmc021 SDRAM controller. > > Signed-off-by: Macpaul Lin > --- > Changes for v2: > - Add __ASSEMBLY__ protecton to register offset for supporting lowlevel_init > Changes for v3: > - Patch: no change. Changed a mail server to resend this patch > Changes for v4: > - Cleanup. > - Replace lines over 80 chararters with proper statement. > - Add some bit-field description about important registers. > - Replace the define of constant which is power of 2 to (ffs(x - 1)) > Changes for v5: > - Replace all CAPS variable into lower case. > > include/faraday/ftsdmc021.h | 151 > +++ > 1 files changed, 151 insertions(+), 0 deletions(-) > create mode 100644 include/faraday/ftsdmc021.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Let the programmers be many and the managers few -- then all will be productive. -- Geoffrey James, "The Tao of Programming" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 1/2] ftahbc020s: Faraday FTAHBC020s AHB Bus Controller
Dear Macpaul Lin, In message <1303817387-9472-1-git-send-email-macp...@andestech.com> you wrote: > ftahbc020s.h provides basic definitions of this controller > to help a SoC which use this AHB Controller could > do scalable software settings in lowlevel_init.S. > > Signed-off-by: Macpaul Lin > --- > Changes for v2: > - Add __ASSEMBLY__ protecton to register offset for supporting lowlevel_init > Changes for v3: > - Patch: no change. Changed a mail server to resend this patch > Changes for v4: > - Fix BSR according to datasheet. > - Replace offset define into structure. > - Replace the constant of power of 2 define into (ffs(x) - 1) > - Replace redundant define of PCR into simple version. > Changes for v5: > - No Change > > include/faraday/ftahbc020s.h | 59 > ++ > 1 files changed, 59 insertions(+), 0 deletions(-) > create mode 100644 include/faraday/ftahbc020s.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Success in marriage is not so much finding the right person as it is being the right person. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix a few gcc warnings.
Dear Joakim Tjernlund, In message <1303731583-11353-1-git-send-email-joakim.tjernl...@transmode.se> you wrote: > Noticed while building all of mpc8xx. Also > constify usage string in timer.c > Warnings fixed are: > timer.c: In function 'timer': > timer.c:189: warning: format not a string literal and no format arguments > timer.c:258: warning: format not a string literal and no format arguments > atm.c: In function 'atmUnload': > atm.c:99: warning: array subscript is above array bounds > atm.c: In function 'atmLoad': > atm.c:65: warning: array subscript is above array bounds > codec.c: In function 'codsp_write_pop_int': > codec.c:678: warning: array subscript is above array bounds > codec.c: In function 'codsp_write_cop_short': > codec.c:585: warning: array subscript is above array bounds > codec.c: In function 'codsp_write_sop_int': > codec.c:512: warning: array subscript is above array bounds > > Signed-off-by: Joakim Tjernlund > --- > > -V3 use puts() and constify usage string in timer.c > > board/netta/codec.c |6 +++--- > board/siemens/IAD210/atm.c |4 ++-- > examples/standalone/timer.c |6 +++--- > 3 files changed, 8 insertions(+), 8 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de EARTH smog | bricks AIR -- mud -- FIRE soda water | tequila WATER ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Remove remnants of obsolete CONFIG_SYS_GBL_DATA_SIZE comments
Dear Michael Jones, In message <1303200753-9360-1-git-send-email-michael.jo...@matrix-vision.de> you wrote: > commit 25ddd1fb0a2281b182529afbc8fda5de2dc16d96 left remnants of > many comments about CONFIG_SYS_GBL_DATA_SIZE. > > Signed-off-by: Michael Jones > --- > include/configs/CPC45.h|3 --- > include/configs/CU824.h|3 --- > include/configs/MigoR.h|1 - > include/configs/PCIPPC2.h |3 --- > include/configs/PCIPPC6.h |3 --- > include/configs/PMC405.h |1 - > include/configs/a320evb.h |4 > include/configs/actux1.h |1 - > include/configs/actux2.h |1 - > include/configs/actux3.h |1 - > include/configs/actux4.h |1 - > include/configs/am3517_evm.h |1 - > include/configs/ap325rxa.h |1 - > include/configs/apollon.h |1 - > include/configs/at91rm9200ek.h |1 - > include/configs/cm_t35.h |1 - > include/configs/devkit8000.h |1 - > include/configs/edminiv2.h |1 - > include/configs/espt.h |1 - > include/configs/galaxy5200.h |2 -- > include/configs/imx27lite-common.h |1 - > include/configs/ipek01.h |2 -- > include/configs/km_arm.h |2 -- > include/configs/mv-common.h|1 - > include/configs/mx31pdk.h |1 - > include/configs/ns9750dev.h|1 - > include/configs/omap3_beagle.h |1 - > include/configs/omap3_evm.h|1 - > include/configs/omap3_overo.h |1 - > include/configs/omap3_sdp3430.h|1 - > include/configs/omap3_zoom1.h |1 - > include/configs/omap3_zoom2.h |1 - > include/configs/omap4_panda.h |1 - > include/configs/omap4_sdp4430.h|1 - > include/configs/pcm030.h |1 - > include/configs/qong.h |1 - > include/configs/r2dplus.h |1 - > include/configs/r7780mp.h |1 - > include/configs/s5p_goni.h |1 - > include/configs/sbc8240.h |3 --- > include/configs/sc3.h |1 - > include/configs/sh7763rdp.h|1 - > include/configs/smdkc100.h |1 - > include/configs/tx25.h |1 - > include/configs/versatile.h|1 - > include/configs/vision2.h |2 -- > 46 files changed, 0 insertions(+), 63 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Never put off until tomorrow what you can put off indefinitely. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] hwmon: Extend lm63.c to support LM64
Dear Dirk Eibach, In message <1303116194-32076-1-git-send-email-eib...@gdsys.de> you wrote: > This patch adds support for the National LM64 temperature > sensor with integrated fan control to lm63.c. > Main difference between LM63 and LM64 is 16°C offset in sensor > readings. > > Signed-off-by: Dirk Eibach > --- > drivers/hwmon/lm63.c | 28 > 1 files changed, 24 insertions(+), 4 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de We have found all life forms in the galaxy are capable of superior development. -- Kirk, "The Gamesters of Triskelion", stardate 3211.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] OSE support shouldnt be enabled by default
Dear Torkel, In message Mike Frysinger wrote: > the commit below slipped in without me noticing ... could you please > revert the change to this header and only enable support for this OS > in whatever boards you're using ? especially considering this OS only > works for specific setups (phones) and on few processors (ARM, PPC, > MIPS). > -mike > > commit 3df61957938586c512c17e72d83551d190400981 > Author: Torkel Lundgren > Date: Tue Sep 28 11:05:36 2010 +0200 > > Add support for operating system OSE > > Add OSE as operating system for mkimage and bootm. > > Signed-off-by: Torkel Lundgren > > diff --git a/include/config_defaults.h b/include/config_defaults.h > index 0337163..abdf3be 100644 > --- a/include/config_defaults.h > +++ b/include/config_defaults.h > @@ -12,6 +12,7 @@ > /* Support bootm-ing different OSes */ > #define CONFIG_BOOTM_LINUX 1 > #define CONFIG_BOOTM_NETBSD 1 > +#define CONFIG_BOOTM_OSE 1 > #define CONFIG_BOOTM_RTEMS 1 > > #define CONFIG_GZIP 1 Please comment? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The flow chart is a most thoroughly oversold piece of program docu- mentation. -- Frederick Brooks, "The Mythical Man Month" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix building tools alone with host compiler
Dear =?UTF-8?q?Fran=C3=A7ois=20Revol?=, In message <1300482183-17836-1-git-send-email-re...@free.fr> you wrote: > - don't include config.h when building with host cc, > - HOSTCFLAGS was defined with the wrong name, so wasn't used, > - make sure make finds sources outside of tools/. > > Signed-off-by: François Revol > --- > tools/Makefile |6 +++--- > tools/imximage.h |2 ++ > 2 files changed, 5 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Behind every great man, there is a woman -- urging him on. -- Harry Mudd, "I, Mudd", stardate 4513.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] net: axi_ethernet: Add driver to u-boot v3
Dear Michal Simek, In message <1299660422-25452-1-git-send-email-mon...@monstr.eu> you wrote: > Add the first axi_ethernet driver for little-endian Microblaze. > > Signed-off-by: Michal Simek > > --- > v2: > - Fix return addreses > - Fix NULL pointer defer for priv structure > > v3: > - Freeing allocated memory when initialization failed > --- > .../xilinx/microblaze-generic/microblaze-generic.c |4 + > drivers/net/Makefile |1 + > drivers/net/xilinx_axi_emac.c | 537 > > include/configs/microblaze-generic.h |3 + > 4 files changed, 545 insertions(+), 0 deletions(-) > create mode 100644 drivers/net/xilinx_axi_emac.c Sorry, this does not apply. Please rebase and resubmit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de WARNING: This Product Attracts Every Other Piece of Matter in the Universe, Including the Products of Other Manufacturers, with a Force Proportional to the Product of the Masses and Inversely Proportional to the Distance Between Them. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix variable flavor in examples/standalone/Makefile
Dear Che-liang Chiou, In message you wrote: > GNU Makefile have two flavors of variables, recursively expanded that is > defined by using '=', and simply expanded that is defined by using ':='. > > The bug is caused by using recursively expanded flavor for BIN and SREC. > As you can see below, they are prepended by $(obj) twice. > > We can reproduce this bug with a simplified version of this Makefile: > $ cat > Makefile < obj := /path/to/obj/ > ELF := hello_world > > BIN_rec = $(addsuffix .bin,$(ELF)) # recursively expanded > BIN_sim := $(addsuffix .bin,$(ELF)) # simply expanded > > ELF := $(addprefix $(obj),$(ELF)) > BIN_rec := $(addprefix $(obj),$(BIN_rec)) > BIN_sim := $(addprefix $(obj),$(BIN_sim)) > > show: > @echo BIN_rec=$(BIN_rec) > @echo BIN_sim=$(BIN_sim) > > .PHONY: show > EOF > $ make show > BIN_rec=/path/to/obj//path/to/obj/hello_world.bin > BIN_sim=/path/to/obj/hello_world.bin > > Signed-off-by: Che-Liang Chiou > --- > > examples/standalone/Makefile |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It all seemed, he thought, to be rather a lot of trouble to go to just sharpen a razor blade. - Terry Pratchett, _The Light Fantastic_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] net: xilinx emaclite: Fix return values
Dear Michal Simek, In message <1299594353-15887-2-git-send-email-mon...@monstr.eu> you wrote: > Fix return values for initialize/init/recv/send functions > > Signed-off-by: Michal Simek > --- > drivers/net/xilinx_emaclite.c | 14 +++--- > 1 files changed, 7 insertions(+), 7 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Were there fewer fools, knaves would starve. - Anonymous ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 8/8] net/net.c: cosmetic: do not use assignment in if condition
Dear Luca Ceresoli, In message <1305122401-14967-9-git-send-email-luca.ceres...@comelit.it> you wrote: > This removes the following checkpatch issue: > - ERROR: do not use assignment in if condition > > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > Cc: Ben Warren > Cc: Mike Frysinger > > --- > Changes since v1: none. > > net/net.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You humans have that emotional need to express gratitude. "You're welcome," I believe, is the correct response. -- Spock, "Bread and Circuses", stardate 4041.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/8] net/net.c: cosmetic: fix indentation
Dear Luca Ceresoli, In message <1305122401-14967-8-git-send-email-luca.ceres...@comelit.it> you wrote: > This removes the following checkpatch issues: > - ERROR: switch and case should be at the same indent > - WARNING: suspect code indent for conditional statements > - WARNING: labels should not be indented > > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > Cc: Ben Warren > Cc: Mike Frysinger > > --- > Changes since v1: none. > > net/net.c | 85 > ++--- > 1 files changed, 42 insertions(+), 43 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Do you suppose the reason the ends of the `Intel Inside' logo don't match up is that it was drawn on a Pentium? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 6/8] net/net.c: cosmetic: parentheses not required for return
Dear Luca Ceresoli, In message <1305122401-14967-7-git-send-email-luca.ceres...@comelit.it> you wrote: > This removes the following checkpatch issue: > - ERROR: return is not a function, parentheses are not required > > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > Cc: Ben Warren > Cc: Mike Frysinger > > --- > Changes since v1: none. > > net/net.c | 30 +++--- > 1 files changed, 15 insertions(+), 15 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The first 90% of a project takes 90% of the time, the last 10% takes the other 90% of the time. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 5/8] net/net.c: cosmetic: fix pointer syntax issues
Dear Luca Ceresoli, In message <1305122401-14967-6-git-send-email-luca.ceres...@comelit.it> you wrote: > This removes the following checkpatch issues: > - ERROR: "foo * bar" should be "foo *bar" > - ERROR: "(foo*)" should be "(foo *)" > > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > Cc: Ben Warren > Cc: Mike Frysinger > > --- > Changes since v1: none. > > net/net.c | 36 ++-- > 1 files changed, 18 insertions(+), 18 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I wrote my name at the top of the page. I wrote down the number of the question ``1''. After much reflection I put a bracket round it thus ``(1)''. But thereafter I could not think of anything connected with it that was either relevant or true. - Sir Winston Churchill _My Early Life_ ch. 2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 4/8] net/net.c: cosmetic: fix brace issues
Dear Luca Ceresoli,
In message <1305122401-14967-5-git-send-email-luca.ceres...@comelit.it> you
wrote:
> This removes the following checkpatch issues:
> - WARNING: braces {} are not necessary for single statement blocks
> - WARNING: braces {} are not necessary for any arm of this statement
>
> Signed-off-by: Luca Ceresoli
> Cc: Wolfgang Denk
> Cc: Ben Warren
> Cc: Mike Frysinger
>
> ---
> Changes since v1: none.
>
> net/net.c | 38 +-
> 1 files changed, 13 insertions(+), 25 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
All repairs tend to destroy the structure, to increase the entropy
and disorder of the system. Less and less effort is spent on fixing
original design flaws; more and more is spent on fixing flaws intro-
duced by earlier fixes. - Fred Brooks, "The Mythical Man Month"
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 3/8] net/net.c: cosmetic: fix whitespace issues
Dear Luca Ceresoli,
In message <1305122401-14967-4-git-send-email-luca.ceres...@comelit.it> you
wrote:
> This removes the following checkpatch issues:
> - ERROR: space prohibited after that open parenthesis '('
> - ERROR: space prohibited before that close parenthesis ')'
> - ERROR: space prohibited after that open square bracket '['
> - ERROR: space prohibited after that '&' (ctx:WxW)
> - ERROR: spaces required around that '=' (ctx:VxW)
> - ERROR: space required before the open parenthesis '('
> - ERROR: space required after that ',' (ctx:VxV)
> - ERROR: need consistent spacing around '+' (ctx:WxV)
> - WARNING: unnecessary whitespace before a quoted newline
> - WARNING: please, no spaces at the start of a line
> - WARNING: space prohibited between function name and open
>parenthesis '('
>
> Signed-off-by: Luca Ceresoli
> Cc: Wolfgang Denk
> Cc: Ben Warren
> Cc: Mike Frysinger
>
> ---
> Changes since v1: none.
>
> net/net.c | 192 ++--
> 1 files changed, 96 insertions(+), 96 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Disobedience: The silver lining to the cloud of servitude.
- Ambrose Bierce
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 2/8] net/net.c: cosmetic: variable initializations
Dear Luca Ceresoli,
In message <1305122401-14967-3-git-send-email-luca.ceres...@comelit.it> you
wrote:
> This removes the following checkpatch errors:
> - ERROR: do not initialise globals to 0 or NULL
> - ERROR: spaces required around that '=' (ctx:VxV)
> - ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Luca Ceresoli
> Cc: Wolfgang Denk
> Cc: Ben Warren
> Cc: Mike Frysinger
>
> ---
> Changes since v1:
> - re-fix array initializations (the fix in v1 was worse than the original).
>
> net/net.c | 40 ++--
> 1 files changed, 18 insertions(+), 22 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Let's say the docs present a simplified view of reality...:-)
- Larry Wall in <6...@jpl-devvax.jpl.nasa.gov>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/8] net/net.c: cosmetic: fix lines over 80 characters
Dear Luca Ceresoli, In message <1305122401-14967-2-git-send-email-luca.ceres...@comelit.it> you wrote: > This removes the following checkpatch warning: > - WARNING: line over 80 characters > > There are three such warnings left. > > The first is hard to fix with cosmetic-only changes without compromising code > readability, so I'm leaving it as it is for now: > WARNING: line over 80 characters > #1537: FILE: net.c:1537: > + [4 tabs] memcpy(((Ethernet_t *)NetArpWaitTxPacket)->et_dest, ... > > The other two cannot be fixed without splitting string literals, so it is > preferred to keep them longer than 80 characters. > > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > Cc: Ben Warren > Cc: Mike Frysinger Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You can't have everything... where would you put it? - Steven Wright ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ehci-pci: Fix PCI EHCI driver for 36-bit
Hi, 2011/4/19 Zhao Chenhui : > Convert the PCI base address into a virtual address. > > Signed-off-by: Zhao Chenhui > Signed-off-by: Li Yang > --- > drivers/usb/host/ehci-pci.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) Applied to u-boot-usb. Thanks. Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] musb: process control messages after roothub accepted it
Hi, 2011/4/21 Mike Frysinger : > From: Cliff Cai > > When dealing with non-multipoint devices, if the software root hub code > accepted the message, then we still need to process it normally. So only > return quickly when the root hub skipped the message or is otherwise in > an error state. > > Signed-off-by: Cliff Cai > Signed-off-by: Mike Frysinger Applied to u-boot-usb Thanks. Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 6/7] Tegra2: Add USB support
Hi, 2011/5/5 Simon Glass : > This adds basic USB support for port 0. The other port is not supported by > this CL. > > Signed-off-by: Simon Glass > --- > arch/arm/include/asm/arch-tegra2/tegra2.h | 2 + > arch/arm/include/asm/arch-tegra2/usb.h | 217 > board/nvidia/common/Makefile | 53 + > board/nvidia/common/board.c | 5 + > board/nvidia/common/usb.c | 313 > + > drivers/usb/host/Makefile | 1 + > drivers/usb/host/ehci-hcd.c | 39 > drivers/usb/host/ehci-tegra.c | 73 +++ > drivers/usb/host/ehci.h | 6 +- > include/configs/harmony.h | 7 + > include/configs/seaboard.h | 10 + > include/configs/tegra2-common.h | 30 +++ This patch touches a lot of files in different subsystems. Please split it up. For example start with a patch series modifying the generic USB code in drivers/usb, followed by a series that modifies board files. Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] fsl_esdhc: Initialize mmc->b_max
commit 262951(MMC: make b_max unconditional) missed to update fsl_esdhc. Signed-off-by: Fabio Estevam --- drivers/mmc/fsl_esdhc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index d2355be..ec953f0 100644 --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -525,6 +525,7 @@ int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg) mmc->f_min = 40; mmc->f_max = MIN(gd->sdhc_clk, 5200); + mmc->b_max = 0; mmc_register(mmc); return 0; -- 1.6.0.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] lib, vsprintf: introduce strict_strtoul
Dear Heiko Schocher, In message <1304408029-16785-1-git-send-email...@denx.de> you wrote: > as checkpatch proposes to use strict_strtoul instead of > simple_strtoul, introduce it. > > Ported this function from Linux 2.6.38 commit ID: > 521cb40b0c44418a4fd36dc633f575813d59a43d > > Signed-off-by: Heiko Schocher > cc: Wolfgang Denk > cc: Detlev Zundel > cc: Valentin Longchamp > cc: Holger Brunck > Signed-off-by: Valentin Longchamp > --- > changes for v2: > - added origin source for this new function, as Wolfgang > Denk suggested. > - Patch no longer in the patchserie, as it is an independent > change. > > include/_exports.h |1 + > include/common.h |1 + > include/exports.h |1 + > lib/vsprintf.c | 51 +++ > 4 files changed, 54 insertions(+), 0 deletions(-) Appplied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de So we follow our wandering paths, and the very darkness acts as our guide and our doubts serve to reassure us. - Jean-Pierre de Caussade, eighteenth-century Jesuit priest ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] SD 3.0 support in uboot
Dear Trivedi Anish-R6AAKA, In message <02b259ebc9134a47b143131fcaf2fea30e2...@039-sn1mpn1-004.039d.mgd.msft.net> you wrote: > > Is there a plan to add SD 3.0 support to uboot's mmc driver, including the > use of UHS modes? As soon as anybody submits patches :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Oh, that sound of male ego. You travel halfway across the galaxy and it's still the same song. -- Eve McHuron, "Mudd's Women", stardate 1330.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] MX53: Add initial support for MX53SMD board.
Signed-off-by: Fabio Estevam --- MAINTAINERS |1 + board/freescale/mx53smd/Makefile | 48 board/freescale/mx53smd/imximage.cfg | 96 +++ board/freescale/mx53smd/mx53smd.c| 222 ++ boards.cfg |1 + include/configs/mx53smd.h| 190 + 6 files changed, 558 insertions(+), 0 deletions(-) create mode 100644 board/freescale/mx53smd/Makefile create mode 100644 board/freescale/mx53smd/imximage.cfg create mode 100644 board/freescale/mx53smd/mx53smd.c create mode 100644 include/configs/mx53smd.h diff --git a/MAINTAINERS b/MAINTAINERS index e2a4ba9..d99896d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -638,6 +638,7 @@ Kristoffer Ericson Fabio Estevam mx31pdk i.MX31 + mx53smd i.MX53 Peter Figuli diff --git a/board/freescale/mx53smd/Makefile b/board/freescale/mx53smd/Makefile new file mode 100644 index 000..ee60f34 --- /dev/null +++ b/board/freescale/mx53smd/Makefile @@ -0,0 +1,48 @@ +# +# Copyright (C) 2007, Guennadi Liakhovetski +# +# (C) Copyright 2011 Freescale Semiconductor, Inc. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).o + +COBJS := mx53smd.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB):$(obj).depend $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/freescale/mx53smd/imximage.cfg b/board/freescale/mx53smd/imximage.cfg new file mode 100644 index 000..921f2d9 --- /dev/null +++ b/board/freescale/mx53smd/imximage.cfg @@ -0,0 +1,96 @@ +# +# (C Copyright 2009 +# Stefano Babic DENX Software Engineering sba...@denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not write to the Free Software +# Foundation Inc. 51 Franklin Street Fifth Floor Boston, +# MA 02110-1301 USA +# +# Refer docs/README.imxmage for more details about how-to configure +# and create imximage boot image +# +# The syntax is taken as close as possible with the kwbimage + +# image version + +IMAGE_VERSION 2 + +# Boot Device : one of +# spi, sd (the board has no nand neither onenand) + +BOOT_FROM sd + +# Device Configuration Data (DCD) +# +# Each entry must have the format: +# Addr-type AddressValue +# +# where: +# Addr-type register length (1,2 or 4 bytes) +# Address absolute address of the register +# value value to be stored in the register +DATA 4 0x53fa8554 0x0030 +DATA 4 0x53fa8558 0x00300040 +DATA 4 0x53fa8560 0x0030 +DATA 4 0x53fa8564 0x00300040 +DATA 4 0x53fa8568 0x00300040 +DATA 4 0x53fa8570 0x0030 +DATA 4 0x53fa8574 0x0030 +DATA 4 0x53fa8578 0x0030 +DATA 4 0x53fa857c 0x00300040 +DATA 4 0x53fa8580 0x00300040 +DATA 4 0x53fa8584 0x0030 +DATA 4 0x53fa8588 0x0030 +DATA 4 0x53fa8590 0x00300040 +DATA 4 0x53fa8594 0x0030 +DATA 4 0x53fa86f0 0x0030 +DATA 4 0x53fa86f4 0x +DATA 4 0x53fa86fc 0x +DATA 4 0x53fa8714 0x +DATA 4 0x53fa8718 0x0030 +DATA 4 0x53fa871c 0x0030 +DATA 4 0x53fa8720 0x0030 +DATA 4 0x53fa8724 0x0400 +DATA 4 0x53fa8728 0x0030 +DATA 4 0x53fa872c 0x0030 +DATA 4 0x63fd9088
[U-Boot] SD 3.0 support in uboot
Hi, Is there a plan to add SD 3.0 support to uboot's mmc driver, including the use of UHS modes? Thanks, Anish ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix incorrect use of getenv() before relocation
Dear Wolfgang Denk, In message <1304541148-11038-1-git-send-email...@denx.de> you wrote: > A large number of boards incorrectly used getenv() in their board init > code running before relocation. In some cases this caused U-Boot to > hang when certain environment variables grew too long. > Fix the code to use getenv_r(). > > Signed-off-by: Wolfgang Denk > Cc: Stefan Roese > Cc: The LEOX team > Cc: Michael Schwingen > Cc: Georg Schardt > Cc: Werner Pfister > Cc: Dirk Eibach > Cc: Peter De Schrijver > Cc: John Zhan > Cc: Rishi Bhattacharya > Cc: Peter Tyser > --- > board/LEOX/elpt860/elpt860.c |5 +++-- > board/RRvision/RRvision.c | 10 ++ > board/actux1/actux1.c |9 + > board/actux2/actux2.c |9 + > board/actux3/actux3.c |7 --- > board/amcc/acadia/acadia.c|7 --- > board/amcc/bamboo/bamboo.c|7 --- > board/amcc/bluestone/bluestone.c |7 --- > board/amcc/bubinga/bubinga.c |7 --- > board/amcc/canyonlands/canyonlands.c |7 --- > board/amcc/ebony/ebony.c |7 --- > board/amcc/katmai/katmai.c|7 --- > board/amcc/kilauea/kilauea.c |7 --- > board/amcc/luan/luan.c|7 --- > board/amcc/makalu/makalu.c|7 --- > board/amcc/ocotea/ocotea.c|9 + > board/amcc/redwood/redwood.c |7 --- > board/amcc/sequoia/sequoia.c |7 --- > board/amcc/taihu/taihu.c |7 --- > board/amcc/taishan/taishan.c |9 + > board/amcc/walnut/walnut.c|7 --- > board/amcc/yosemite/yosemite.c|7 --- > board/amcc/yucca/yucca.c |7 --- > board/amirix/ap1000/ap1000.c | 24 ++-- > board/avnet/fx12mm/fx12mm.c | 17 - > board/c2mon/c2mon.c | 10 ++ > board/digsy_mtc/digsy_mtc.c |9 + > board/etx094/etx094.c | 16 +++- > board/gdsys/405ep/dlvision-10g.c |7 --- > board/gdsys/405ep/io.c|7 --- > board/gdsys/405ep/iocon.c |7 --- > board/gdsys/dlvision/dlvision.c |7 --- > board/gdsys/gdppc440etx/gdppc440etx.c |7 --- > board/gdsys/intip/intip.c |7 --- > board/gdsys/neo/neo.c |7 --- > board/gw8260/gw8260.c |8 > board/hermes/hermes.c | 16 +++- > board/ixdp425/ixdp425.c |7 --- > board/lwmon5/lwmon5.c |7 --- > board/micronas/vct/vct.c |7 --- > board/ml2/ml2.c | 18 +++--- > board/mosaixtech/icon/icon.c |7 --- > board/pcs440ep/pcs440ep.c |7 --- > board/prodrive/alpr/alpr.c|9 + > board/prodrive/p3mx/p3mx.c|7 --- > board/prodrive/p3p440/p3p440.c|7 --- > board/prodrive/pdnb3/pdnb3.c |7 --- > board/quad100hd/quad100hd.c |7 --- > board/quantum/quantum.c | 10 ++ > board/rbc823/rbc823.c |9 + > board/socrates/socrates.c | 12 +++- > board/svm_sc8xx/svm_sc8xx.c | 32 +--- > board/t3corp/t3corp.c |7 --- > board/ti/omap5912osk/omap5912osk.c|7 --- > board/tqc/tqm8260/tqm8260.c |8 > board/tqc/tqm8272/tqm8272.c |8 ++-- > board/tqc/tqm85xx/tqm85xx.c | 19 +++ > board/tqc/tqm8xx/tqm8xx.c | 18 ++ > board/xes/common/board.c | 17 +++-- > board/xes/xpedite1000/xpedite1000.c | 21 +++-- > board/zeus/zeus.c |7 --- > 61 files changed, 324 insertions(+), 260 deletions(-) Applied (with fix for board/digsy_mtc/digsy_mtc.c as pointed out by Detlev). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de In the beginning, there was nothing, which exploded. - Terry Pratchett, _Lords and Ladies_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] cmd_nvedit.c: make error message more helpful
Dear Wolfgang Denk, In message <1304540989-10450-1-git-send-email...@denx.de> you wrote: > When calling getenv_f() with a too small buffer, it would print an > error message like this: > > env_buf too small [32] > > This is not really helpful as it does not give any indication which of > the calls might have failed. Change this into: > > env_buf [32 bytes] too small for value of "hwconfig" > > so we know at least which variable caused the overflow; this usually > allows to quickly find the related code as well. > > Signed-off-by: Wolfgang Denk > --- > common/cmd_nvedit.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "The X11 source code style is ATROCIOUS and should not be used as a model." - Doug Gwyn ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"
Dear Luca Ceresoli, In message <1303143594-5345-4-git-send-email-luca.ceres...@comelit.it> you wrote: > With the upcoming TFTP server implementation, the remote node can be > either a client or a server, so avoid ambiguities. > > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > --- > Changes in v2: > - fixed checkpatch issues. > > net/tftp.c | 42 +- > 1 files changed, 21 insertions(+), 21 deletions(-) How do we proceed now? I've applied paches 1 + 2 of this series, but for patch 3 we had changes requested, and the following patche sdepend on it. I understand you are now waiting for the "net/net.c: cosmetic:" patches to go in? Normally these would be stuff for the next branch... I'd even be willing to pull these in now, if you then would re-post the remaining patches of the tftpserver code soon? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Diplomacy is the art of saying "nice doggy" until you can find a rock. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 2/6] NET: pass source IP address to packet handlers
Dear Luca Ceresoli, In message <1303143594-5345-3-git-send-email-luca.ceres...@comelit.it> you wrote: > This is needed for the upcoming TFTP server implementation. > > This also simplifies PingHandler() and fixes rxhand_f documentation. > > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > --- > Changes in v2: > - fixed checkpatch issues. > > drivers/net/netconsole.c |5 +++-- > include/net.h| 15 ++- > net/bootp.c |9 ++--- > net/dns.c|2 +- > net/net.c| 30 +- > net/nfs.c|2 +- > net/rarp.c |3 ++- > net/sntp.c |3 ++- > net/tftp.c |3 ++- > 9 files changed, 44 insertions(+), 28 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de HEALTH WARNING: Care Should Be Taken When Lifting This Product, Since Its Mass, and Thus Its Weight, Is Dependent on Its Velocity Relative to the User. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] part_dos: allocate sector buffer dynamically
Dear Sergei Shtylyov, In message <4dbff9fd.1070...@mvista.com> you wrote: > > > Umm... you _are_ aware that you can put dynamically sized arrays on > > the stack, aren't you? > > No, it seems I'm not. Is it a standard C now? It's been a GCC extension forever (well, I have to admit that I don't remember before GCC v1.39 or so). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When a man sits with a pretty girl for an hour, it seems like a minute. But let him sit on a hot stove for a minute -- and it's lon- ger than any hour. That's relativity. -- Albert Einstein ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MPC8260: Fix compile problems with "hymod" board
Dear Wolfgang Denk, In message <1304260506-1456-1-git-send-email...@denx.de> you wrote: > Commit 9d8fbd1 "powerpc, 8xx: Fixup all 8xx u-boot.lds scripts" broke > building of the MPC8260 based "hymod" board. Fix this. > > Signed-off-by: Wolfgang Denk > Cc: Murray Jensen > Cc: Joakim Tjernlund > --- > board/hymod/u-boot.lds |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Quotation, n. The act of repeating erroneously the words of another. The words erroneously repeated. - Ambrose Bierce _The Devil's Dictionary_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] zlib: fix DEBUG build
Dear Mike Frysinger, In message <1304289062-25727-1-git-send-email-vap...@gentoo.org> you wrote: > The previous commit imported a little too much from upstream. We need > to disable stdio.h when using U-Boot. > > Reported-by: Wolfgang Denk > Signed-off-by: Mike Frysinger > --- > lib/zlib/zutil.h |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de What we anticipate seldom occurs; what we least expect generally happens. - Bengamin Disraeli ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-ppc4xx/master
Dear Stefan Roese, In message <201105121617.47525...@denx.de> you wrote: > Hi Wolfgang, > > please pull the following fix: > > The following changes since commit 264eaa0ea967bac32214b87d60cfc86c8b22cac6: > > keymile boards: move keymile specific header in subdir (2011-05-10 23:22:49 > +0200) > > are available in the git repository at: > git://www.denx.de/git/u-boot-ppc4xx.git master > > Steven A. Falco (1): > PPC405EX CHIP_21 erratum > > arch/powerpc/cpu/ppc4xx/cpu_init.c | 64 > ++ > arch/powerpc/include/asm/ppc405ex.h |5 +++ > arch/powerpc/include/asm/processor.h | 31 > include/configs/kilauea.h| 14 +++ > 4 files changed, 114 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Successful and fortunate crime is called virtue. - Seneca ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request: u-boot-arm/master
Dear Albert ARIBAUD,
In message <4dcafa98.2020...@aribaud.net> you wrote:
> Hi Wolfgang,
>
> The following changes since commit 264eaa0ea967bac32214b87d60cfc86c8b22cac6:
>
>keymile boards: move keymile specific header in subdir (2011-05-10
> 23:22:49 +0200)
>
> are available in the git repository at:
>git://git.denx.de/u-boot-arm master
>
> Ben Gardiner (1):
>da850evm: fix NAND WSTROBE and TA timings
>
> Clint Adams (4):
>Rename openrd_base files to openrd
>Add definitions for OpenRD-Client and OpenRD-Ultimate
>Initialize second PHY on OpenRD-Client and OpenRD-Ultimate
>Enable multiple fs options for Marvell SoC family on OpenRD boards
>
> Fabio Estevam (2):
>MX31: mx31pdk: Add watchdog support
>gpio: imx: Fix return value on error
>
> Simon Guinot (2):
>Kirkwood: allow to override CONFIG_SYS_TCLK
>mv-common.h: fix DRAM banks configuration
>
> Stefano Babic (2):
>MX31: removed warning due to missing prototype
>MX31: change return value of get_cpu_rev
>
> MAKEALL|2 +
> arch/arm/cpu/arm1136/mx31/generic.c| 31
> +++
> arch/arm/include/asm/arch-kirkwood/kw88f6281.h |8 +++--
> arch/arm/include/asm/arch-mx31/clock.h |1 +
> arch/arm/include/asm/arch-mx31/imx-regs.h |2 +-
> board/Marvell/{openrd_base => openrd}/Makefile |2 +-
> board/Marvell/{openrd_base => openrd}/kwbimage.cfg |0
> .../{openrd_base/openrd_base.c => openrd/openrd.c} | 33
> +---
> .../{openrd_base/openrd_base.h => openrd/openrd.h} |0
> board/davinci/da8xxevm/da850evm.c |4 +-
> board/freescale/mx31pdk/mx31pdk.c | 16 +
> boards.cfg |4 ++-
> drivers/gpio/mxc_gpio.c|5 ++-
> include/configs/mv-common.h|8 ++--
> include/configs/mx31pdk.h |3 ++
> include/configs/{openrd_base.h => openrd.h}| 33
> +---
> 16 files changed, 115 insertions(+), 37 deletions(-)
> rename board/Marvell/{openrd_base => openrd}/Makefile (98%)
> rename board/Marvell/{openrd_base => openrd}/kwbimage.cfg (100%)
> rename board/Marvell/{openrd_base/openrd_base.c => openrd/openrd.c} (80%)
> rename board/Marvell/{openrd_base/openrd_base.h => openrd/openrd.h} (100%)
> rename include/configs/{openrd_base.h => openrd.h} (81%)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A student of probability soon realizes that by its nature the
billion-to-one chance crops up nine times out of ten, and that the
greatest odds boil down to a double-sided statement: it will happen,
or it will not. - Terry Pratchett, _The Dark Side of the Sun_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 5/5] Add support for Network Space v2
Dear Simon Guinot, In message <20110503131942.gu19...@kw.sim.vm.gnt> you wrote: > > I have failed to find an entry for this patch in the U-Boot patchwork > (and any previous version except the very first). I don't see it either. > Have I missed something and/or done something wrong ? Unlikely. Can you please ask Jeremy Kerr on the patchwork mailing list? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de God may be subtle, but He isn't plain mean. - Albert Einstein ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATH v7 1/2] netconsole: remove `serverip' check
Dear Simon Guinot, In message <1305193737-5952-2-git-send-email-simon.gui...@sequanux.org> you wrote: > This patch allows to enable the netconsole even if `serverip' is not set. > > Because netconsole use the environment variable `ncip' to configure the > destination IP, `serverip' don't need to be defined. > > Signed-off-by: Simon Guinot > --- > Changes for v2: > - restore NetOurIP check > > Changes for v3: > - add a "/* Fall through */" comment before the NETCONS case label > > Changes for v4,5: none > > Changes for v6: > - enhance commit message > > Changes for v7: none > > net/net.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de In an organization, each person rises to the level of his own incom- petency - The Peter Principle ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] Serial: pl011: new vendor init options
Dear John Rigby, In message <1305187511-8455-1-git-send-email-john.ri...@linaro.org> you wrote: > Two new options: > > CONFIG_PL011_SERIAL_RLCR > > Some vendor versions of PL011 serial ports (e.g. ST-Ericsson U8500) > have separate receive and transmit line control registers. Set > this variable to initialize the extra register. > > CONFIG_PL011_SERIAL_FLUSH_ON_INIT > > On some platforms (e.g. U8500) U-Boot is loaded by a second stage > boot loader that has already initialized the UART. Define this > variable to flush the UART at init time. > empty fifo on init > > Signed-off-by: John Rigby > Signed-off-by: Rabin Vincent > --- > v2: No changes > v3: Enable changes with new CONFIG_* options instead of platform. > Document new CONFIG_* options in README. > v4: Added delay before writing to RLCR. > Removed Rabin as author at his request. > v5: Fixed commit message p1011 to pl011 > > README| 12 > drivers/serial/serial_pl01x.c | 30 +++--- > drivers/serial/serial_pl01x.h |4 > 3 files changed, 43 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "We don't have to protect the environment -- the Second Coming is at hand." - James Watt ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] USB only works in Linux if started in UBoot
hi of course I forgot to mention my platform, sorry about that CPU: MPC5200b Kernel: 2.6.33-rc6 Uboot: U-Boot 2009.03 regards Einar From: u-boot-boun...@lists.denx.de [u-boot-boun...@lists.denx.de] on behalf of Peter Tyser [pty...@xes-inc.com] Sent: Thursday, May 12, 2011 4:28 PM To: Einar Már Björgvinsson Cc: U-Boot@lists.denx.de Subject: Re: [U-Boot] USB only works in Linux if started in UBoot On Thu, 2011-05-12 at 15:36 +, Einar Már Björgvinsson wrote: > hi > > I was wondering what I was doing wrong here ! > > The USB functionality in Linux only works if I run 'usb start' in UBoot > before starting the kernel. > > Not sure what will resolve this, of course I can make automatic start command > during starting of the bootloader but I think that's not optimal. > > Any thoughts on this ? What hardware are you running on? What kernel version are you using? What U-Boot version are you using? This issue was present on some Freescale CPUs, but has been fixed in the mainline kernel by the following commit in case you're running on one of their CPUs: http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=cc604ddd118cf4a699c12bc41a5fa2d2f225f702;hp=ad84e4a9efb7c8ed322bafb6ebdb9c3a49a3d3a8 Best, Peter ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] USB only works in Linux if started in UBoot
On Thu, 2011-05-12 at 15:36 +, Einar Már Björgvinsson wrote: > hi > > I was wondering what I was doing wrong here ! > > The USB functionality in Linux only works if I run 'usb start' in UBoot > before starting the kernel. > > Not sure what will resolve this, of course I can make automatic start command > during starting of the bootloader but I think that's not optimal. > > Any thoughts on this ? What hardware are you running on? What kernel version are you using? What U-Boot version are you using? This issue was present on some Freescale CPUs, but has been fixed in the mainline kernel by the following commit in case you're running on one of their CPUs: http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=cc604ddd118cf4a699c12bc41a5fa2d2f225f702;hp=ad84e4a9efb7c8ed322bafb6ebdb9c3a49a3d3a8 Best, Peter ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATH v7 1/2] netconsole: remove `serverip' check
Dear Simon Guinot, In message <20110512115521.gd6...@kw.sim.vm.gnt> you wrote: > > > This patch looks to be independent. > > I don't have any comments for this. > > Should be applied to u-boot-net.git. > > The patch itself is independent but the Network Space v2 board setup > rely on it. Without this patch, the netconsole is not usable and the > netconsole is needed to update the stock U-Boot. > > IMHO, this two patches should go in the same tree, to avoid a breakage > situation. No. This will go into master. Soon. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Yes, it is written. Good shall always destroy evil. -- Sirah the Yang, "The Omega Glory", stardate unknown ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATH v7 2/2] Add support for Network Space v2
Dear Simon Guinot, In message <20110512114727.gc6...@kw.sim.vm.gnt> you wrote: > > > > +#define CONFIG_IDENT_STRING " LaCie Network Space v2" > > > +#elif defined(CONFIG_NETSPACE_MAX_V2) > > > +#define CONFIG_MACH_TYPE MACH_TYPE_NETSPACE_MAX_V2 > > > +#define CONFIG_IDENT_STRING " LaCie Network Space Max v2" > > > +#endif > > > > There should be #elif for third board and #error for #else part > > I have noticed this #error in the other board include files. Is it > really needed ? This file is only included if one machine is selected. Defensive programming is a Good Thing. Today you remember that there are only three boards. Next year somebody adds another one and fails to update all relevant places. > > > +#define CONFIG_CMD_EXT2 > > > +#define CONFIG_CMD_FAT > > > > Get rid of this, use CONFIG_SYS_MVFS > > Outch. Please no :) Agreed. Leave as is. > > > + "ipaddr=192.168.1.111\0"\ > > > > NAK for ipaddr, no ip address should be defined by default. > > I understand, but I need a known IP address. > > I want people to be able to update the stock U-Boot using netconsole > (without a serial link which require to open the case). At restart, > right after the update, a user must be able to figure out the board IP. > > An alternative could be using a DHCP configuration. Yes, that would be much better. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It is easier to change the specification to fit the program than vice versa. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] USB only works in Linux if started in UBoot
On Thursday, May 12, 2011 11:36:19 Einar Már Björgvinsson wrote: > The USB functionality in Linux only works if I run 'usb start' in UBoot > before starting the kernel. file a bug with the Linux maintainers -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] USB only works in Linux if started in UBoot
hi I was wondering what I was doing wrong here ! The USB functionality in Linux only works if I run 'usb start' in UBoot before starting the kernel. Not sure what will resolve this, of course I can make automatic start command during starting of the bootloader but I think that's not optimal. Any thoughts on this ? Regards Einar M. Bjorgvinsson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATH v7 1/2] netconsole: remove `serverip' check
On Thursday, May 12, 2011 06:17:24 Prafulla Wadaskar wrote: > Hi Ben/Wolfgang > Can you pls review/comment/pull it ? Ben is no longer here, and the u-boot-net tree is dead. Wolfgang is currently covering things. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] post: add gpio hotkey support
On Thursday, May 12, 2011 08:47:56 Sergei Shtylyov wrote:
> On 11-05-2011 18:54, Mike Frysinger wrote:
> >>>int __post_hotkeys_pressed(void)
> >>>{
> >>> +#ifdef CONFIG_SYS_POST_HOTKEYS_GPIO
> >>> + return ret;
> >>> +#endif
> >>>
> >> You surely meant #else here?
> >>>
> >>> return 0; /* No hotkeys supported */
> >
> > not really what i was going for. it's fine either way though.
>
> I don't think 2 returns in a row is fine...
if there were no CPP here, then obviously you'd be right. but there is, and i
dont see much point now in adding a little more wrapping. gcc doesnt warn
about it.
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-ppc4xx/master
Hi Wolfgang, please pull the following fix: The following changes since commit 264eaa0ea967bac32214b87d60cfc86c8b22cac6: keymile boards: move keymile specific header in subdir (2011-05-10 23:22:49 +0200) are available in the git repository at: git://www.denx.de/git/u-boot-ppc4xx.git master Steven A. Falco (1): PPC405EX CHIP_21 erratum arch/powerpc/cpu/ppc4xx/cpu_init.c | 64 ++ arch/powerpc/include/asm/ppc405ex.h |5 +++ arch/powerpc/include/asm/processor.h | 31 include/configs/kilauea.h| 14 +++ 4 files changed, 114 insertions(+), 0 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH][v2]qoriq/p1_p2_rdb: Add Dual Role USB support macro for P1020RDB
Add CONFIG_HAS_FSL_DR_USB macro for P1020RDB Signed-off-by: Ramneek Mehresh --- Changes for v2: - rebased on http://git.denx.de/u-boot.git include/configs/P1_P2_RDB.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/configs/P1_P2_RDB.h b/include/configs/P1_P2_RDB.h index 59f9755..4f1bdfe 100644 --- a/include/configs/P1_P2_RDB.h +++ b/include/configs/P1_P2_RDB.h @@ -601,6 +601,7 @@ extern unsigned long get_board_sys_clk(unsigned long dummy); #define CONFIG_EHCI_HCD_INIT_AFTER_RESET #define CONFIG_USB_EHCI_FSL #define CONFIG_USB_STORAGE +#define CONFIG_HAS_FSL_DR_USB #endif #if defined(CONFIG_MMC) || defined(CONFIG_USB_EHCI) -- 1.6.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH][v2] qoriq/p1_p2_rdb: USB device-tree fixups for P1020
Resolve P1020 second USB controller multiplexing with eLBC
- mandatory to mention USB2 in hwconfig string to select it
over eLBC, otherwise USB2 node is removed
- works only for SPI and SD boot
Signed-off-by: Ramneek Mehresh
---
Changes for v2:
- Incorporated Wolfgang's comments
- rebased patch on http://git.denx.de/u-boot.git
- top commit:
commit 264eaa0ea967bac32214b87d60cfc86c8b22cac6
Author: Valentin Longchamp
Date: Wed May 4 01:47:33 2011 +
board/freescale/p1_p2_rdb/p1_p2_rdb.c | 47 +
1 files changed, 47 insertions(+), 0 deletions(-)
diff --git a/board/freescale/p1_p2_rdb/p1_p2_rdb.c
b/board/freescale/p1_p2_rdb/p1_p2_rdb.c
index d66b130..514e55d 100644
--- a/board/freescale/p1_p2_rdb/p1_p2_rdb.c
+++ b/board/freescale/p1_p2_rdb/p1_p2_rdb.c
@@ -37,6 +37,7 @@
#include
#include
#include
+#include
DECLARE_GLOBAL_DATA_PTR;
@@ -247,6 +248,8 @@ extern void ft_pci_board_setup(void *blob);
void ft_board_setup(void *blob, bd_t *bd)
{
+ const char *soc_usb_compat = "fsl-usb2-dr";
+ int off, err, usb1_off, usb2_off;
phys_addr_t base;
phys_size_t size;
@@ -260,5 +263,49 @@ void ft_board_setup(void *blob, bd_t *bd)
#endif /* #if defined(CONFIG_PCI) */
fdt_fixup_memory(blob, (u64)base, (u64)size);
+
+ fdt_fixup_dr_usb(blob, bd);
+
+#if defined(CONFIG_SDCARD) || defined(CONFIG_SPIFLASH)
+ /* Delete eLBC node as it is muxed with USB2 controller */
+ if (hwconfig("usb2")) {
+ const char *soc_elbc_compat = "fsl,p1020-elbc";
+ off = fdt_node_offset_by_compatible(blob, -1,
+ soc_elbc_compat);
+ if (off < 0) {
+ printf("WARNING: could not find compatible node"
+ " %s: %s.\n", soc_elbc_compat,
+ fdt_strerror(off));
+ return;
+ }
+ err = fdt_del_node(blob, off);
+ if (err < 0) {
+ printf("WARNING: could not remove %s: %s.\n",
+ soc_elbc_compat, fdt_strerror(err));
+ }
+ return;
+ }
+#endif
+ /* Delete USB2 node as it is muxed with eLBC */
+ usb1_off = fdt_node_offset_by_compatible(blob, -1,
+ soc_usb_compat);
+ if (usb1_off < 0) {
+ printf("WARNING: could not find compatible node"
+ " %s: %s.\n", soc_usb_compat,
+ fdt_strerror(usb1_off));
+ return;
+ }
+ usb2_off = fdt_node_offset_by_compatible(blob, usb1_off,
+soc_usb_compat);
+ if (usb2_off < 0) {
+ printf("WARNING: could not find compatible node"
+ " %s: %s.\n", soc_usb_compat,
+ fdt_strerror(usb2_off));
+ return;
+ }
+ err = fdt_del_node(blob, usb2_off);
+ if (err < 0)
+ printf("WARNING: could not remove %s: %s.\n",
+ soc_usb_compat, fdt_strerror(err));
}
#endif
--
1.6.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] PPC405EX CHIP_21 erratum
On Thursday 05 May 2011 16:08:35 Steven A. Falco wrote: > APM errata CHIP_21 for the 405EX/EXr (from the rev 1.09 document dated > 4/27/11) states that rev D processors may wake up with the wrong feature > set. This patch implements the APM-proposed workaround. > > To enable this patch for your board, add the appropriate define for your > CPU to your board header file. See kilauea.h for more information. The > following variants are supported: > > #define CONFIG_SYS_4xx_CHIP_21_405EX_NO_SECURITY > #define CONFIG_SYS_4xx_CHIP_21_405EX_SECURITY > #define CONFIG_SYS_4xx_CHIP_21_405EXr_NO_SECURITY > #define CONFIG_SYS_4xx_CHIP_21_405EXr_SECURITY > > Please note that if you select the wrong define, your board will not > boot, and JTAG will be required to recover. > > Tested on custom boards using: > > CONFIG_SYS_4xx_CHIP_21_405EX_NO_SECURITY > CONFIG_SYS_4xx_CHIP_21_405EX_SECURITY > > Signed-off-by: Steve Falco > Acked-by: Dirk Eibach checkpatch has some minor problems with your patch: checkpatch.pl patches_misc/\[U-Boot\]\ \[PATCH\ v3\]\ PPC405EX\ CHIP_21\ erratum.mbox ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 #122: FILE: arch/powerpc/cpu/ppc4xx/cpu_init.c:241: +* SDR0_ECID3[12:15] is different from PVR[28:31], then � processor is ^ ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 #124: FILE: arch/powerpc/cpu/ppc4xx/cpu_init.c:243: +* required). else � go to step 3. ^ ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 #127: FILE: arch/powerpc/cpu/ppc4xx/cpu_init.c:246: +* SDR0_ECID3[10:11] matches its expected value, then � continue ^ ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 #128: FILE: arch/powerpc/cpu/ppc4xx/cpu_init.c:247: +* executing initialization code, no reset required. else � write ^ total: 4 errors, 0 warnings, 144 lines checked No need to resend, I fixed this manually. Applied to u-boot-ppc4xx/master. Thanks. Best regards, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] PPC405EX CHIP_21 erratum
On 05/05/2011 10:08 AM, Steven A. Falco wrote:
> APM errata CHIP_21 for the 405EX/EXr (from the rev 1.09 document dated
> 4/27/11) states that rev D processors may wake up with the wrong feature
> set. This patch implements the APM-proposed workaround.
I have not seen any further comments on this patch. Is it acceptable, or
are additional changes required?
Steve
>
> To enable this patch for your board, add the appropriate define for your
> CPU to your board header file. See kilauea.h for more information. The
> following variants are supported:
>
> #define CONFIG_SYS_4xx_CHIP_21_405EX_NO_SECURITY
> #define CONFIG_SYS_4xx_CHIP_21_405EX_SECURITY
> #define CONFIG_SYS_4xx_CHIP_21_405EXr_NO_SECURITY
> #define CONFIG_SYS_4xx_CHIP_21_405EXr_SECURITY
>
> Please note that if you select the wrong define, your board will not
> boot, and JTAG will be required to recover.
>
> Tested on custom boards using:
>
> CONFIG_SYS_4xx_CHIP_21_405EX_NO_SECURITY
> CONFIG_SYS_4xx_CHIP_21_405EX_SECURITY
>
> Signed-off-by: Steve Falco
> Acked-by: Dirk Eibach
>
> ---
>
> v3:
> Remove enable of workaround for Kilauea/Haleakala. Instead, all
> variants are listed with a detailed comment explaining proper usage.
> This is necessary because the same u-boot binary is used on boards
> with different processors. Since there is currently no known way
> to distinguish those processors, there is no way to universally work
> around the errata. Each Kilauea/Haleakala owner must build a unique
> version of u-boot tailored to their particular board.
>
> v2:
> Correct checkpatch errors/warnings re: whitespace, comment style, etc.
> Move PVR logic out of board config file.
> Simplify ifdef structure.
>
> diff --git a/arch/powerpc/cpu/ppc4xx/cpu_init.c
> b/arch/powerpc/cpu/ppc4xx/cpu_init.c
> index bf208ad..2f3a802 100644
> --- a/arch/powerpc/cpu/ppc4xx/cpu_init.c
> +++ b/arch/powerpc/cpu/ppc4xx/cpu_init.c
> @@ -221,6 +221,66 @@ void reconfigure_pll(u32 new_cpu_freq)
> #endif
> }
>
> +#ifdef CONFIG_SYS_4xx_CHIP_21_ERRATA
> +void
> +chip_21_errata(void)
> +{
> + /*
> + * See rev 1.09 of the 405EX/405EXr errata. CHIP_21 says that
> + * sometimes reading the PVR and/or SDR0_ECID results in incorrect
> + * values. Since the rev-D chip uses the SDR0_ECID bits to control
> + * internal features, that means the second PCIe or ethernet of an EX
> + * variant could fail to work. Also, security features of both EX and
> + * EXr might be incorrectly disabled.
> + *
> + * The suggested workaround is as follows (covering rev-C and rev-D):
> + *
> + * 1.Read the PVR and SDR0_ECID3.
> + *
> + * 2.If the PVR matches an expected Revision C PVR value AND if
> + * SDR0_ECID3[12:15] is different from PVR[28:31], then – processor is
> + * Revision C: continue executing the initialization code (no reset
> + * required). else – go to step 3.
> + *
> + * 3.If the PVR matches an expected Revision D PVR value AND if
> + * SDR0_ECID3[10:11] matches its expected value, then – continue
> + * executing initialization code, no reset required. else – write
> + * DBCR0[RST] = 0b11 to generate a SysReset.
> + */
> +
> + u32 pvr;
> + u32 pvr_28_31;
> + u32 ecid3;
> + u32 ecid3_10_11;
> + u32 ecid3_12_15;
> +
> + /* Step 1: */
> + pvr = get_pvr();
> + mfsdr(SDR0_ECID3, ecid3);
> +
> + /* Step 2: */
> + pvr_28_31 = pvr & 0xf;
> + ecid3_10_11 = (ecid3 >> 20) & 0x3;
> + ecid3_12_15 = (ecid3 >> 16) & 0xf;
> + if ((pvr == CONFIG_405EX_CHIP21_PVR_REV_C) &&
> + (pvr_28_31 != ecid3_12_15)) {
> + /* No reset required. */
> + return;
> + }
> +
> + /* Step 3: */
> + if ((pvr == CONFIG_405EX_CHIP21_PVR_REV_D) &&
> + (ecid3_10_11 == CONFIG_405EX_CHIP21_ECID3_REV_D)) {
> + /* No reset required. */
> + return;
> + }
> +
> + /* Reset required. */
> + __asm__ __volatile__ ("sync; isync");
> + mtspr(SPRN_DBCR0, 0x3000);
> +}
> +#endif
> +
> /*
> * Breath some life into the CPU...
> *
> @@ -235,6 +295,10 @@ cpu_init_f (void)
> u32 val;
> #endif
>
> +#ifdef CONFIG_SYS_4xx_CHIP_21_ERRATA
> + chip_21_errata();
> +#endif
> +
> reconfigure_pll(CONFIG_SYS_PLL_RECONFIG);
>
> #if (defined(CONFIG_405EP) || defined (CONFIG_405EX)) && \
> diff --git a/arch/powerpc/include/asm/ppc405ex.h
> b/arch/powerpc/include/asm/ppc405ex.h
> index 36d3149..8070385 100644
> --- a/arch/powerpc/include/asm/ppc405ex.h
> +++ b/arch/powerpc/include/asm/ppc405ex.h
> @@ -43,6 +43,11 @@
> #define SDR0_PFC10x4101
> #define SDR0_MFR 0x4300 /* SDR0_MFR reg */
>
> +#define SDR0_ECID0 0x0080
> +#define SDR0_ECID1 0x0081
> +#define SDR0_ECID2 0x0082
> +#define SDR0_ECID3 0x0083
> +
> #define SDR0_SDCS_SDD(0x80
