Timeout variable is decremented once more when while condition is not met.
Following if does not detect correctly that timeout has occurred.
Because of this bug the usb start command on AM335X-EVM board did not detect
correctly that USB device was not attached.
timeout =
Hi Tom,
On Sat, 18 Aug 2012 13:53:16 -0700, Tom Rini tr...@ti.com wrote:
On Sat, Aug 18, 2012 at 07:15:56AM -0700, Tom Rini wrote:
On Sat, Aug 18, 2012 at 08:28:55AM +0200, Albert ARIBAUD wrote:
Hi Tom,
On Fri, 17 Aug 2012 14:52:01 -0700, Tom Rini tr...@ti.com wrote:
Hello,
Hi Tom,
On Wed, 29 Aug 2012 14:10:19 -0700, Tom Warren twar...@nvidia.com
wrote:
Lucas,
-Original Message-
From: Lucas Stach [mailto:d...@lynxeye.de]
Sent: Wednesday, August 29, 2012 1:54 PM
To: Tom Warren
Cc: Allen Martin; swar...@wwwdotorg.org; s...@chromium.org;
Hi.
We have a new board which we are suing with U-boot. The CPU is a P2020.
I am having a few minor problems, and I was hoping to get some help.
- Boot Count. We are keen to use the boot counter feature, but I
am struggling to find a suitable register in the P2020. The file
Hi.
We have a new board which we are suing with U-boot. The CPU is a P2020.
I am having a few minor problems, and I was hoping to get some help.
- Boot Count. We are keen to use the boot counter feature, but I
am struggling to find a suitable register in the P2020. The file
On 08/30/2012 03:12 PM, Joakim Tjernlund wrote:
- Boot Count. We are keen to use the boot counter feature, but I
am struggling to find a suitable register in the P2020. The file
arch/powerpc/lib/bootcount.c list a few locations that work with
other PowerPC chips, but I can't find any
Hi,
hope somebody here might help:
I have tried with many combinations of
u-boot: 2011.09 / 2011.07
kernel 3.2.19 / 3.5 / 3.6rc3
gumstix OveroWater (TI OMAP 3530) / OveroFireStorm (TI DM3730))
All tested combinations share the same bug: As soon as I activate
governor 'ondemand' and try to
This is clearly some sort of debug output and should not
be printed during normal operation.
Signed-off-by: Lucas Stach d...@lynxeye.de
---
drivers/usb/host/ehci-hcd.c | 2 +-
1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
diff --git a/drivers/usb/host/ehci-hcd.c
We don't actually need to pack those structs, as they
are not used to do actual hardware access.
This avoids some unaligned accesses and therefore makes
the EHCI stack work on ARMv7 without compiler workarounds.
Signed-off-by: Lucas Stach d...@lynxeye.de
---
drivers/usb/host/ehci-hcd.c | 2 +-
Jaehoon,
I get timeouts on multiblock mmc reads with v2012.07 u-boot. I did a
bisect and found that it is broken back to
442d55685e1e2310d546044a6519ae73e4ba348a mmc: support the sdhci
instead of s5p_mmc for samsung-soc
and
236bfecff8091356d81e79da3281b9e4af967468 mmc: add the quirk to use
Albert,
-Original Message-
From: Albert ARIBAUD [mailto:albert.u.b...@aribaud.net]
Sent: Thursday, August 30, 2012 1:41 AM
To: Tom Warren
Cc: Lucas Stach; Allen Martin; swar...@wwwdotorg.org; s...@chromium.org;
thierry.red...@avionic-design.de; u-boot@lists.denx.de
Subject: Re:
Dear Lucas Stach,
This is clearly some sort of debug output and should not
be printed during normal operation.
Signed-off-by: Lucas Stach d...@lynxeye.de
I think we should apply this ... yet it's been in uboot for so long, so I'd
like
to hear other people opinion :)
---
Dear Lucas Stach,
We don't actually need to pack those structs, as they
are not used to do actual hardware access.
This avoids some unaligned accesses and therefore makes
the EHCI stack work on ARMv7 without compiler workarounds.
Signed-off-by: Lucas Stach d...@lynxeye.de
I need to
On Thu, Aug 30, 2012 at 09:44:54AM +0200, Albert ARIBAUD wrote:
Hi Tom,
On Sat, 18 Aug 2012 13:53:16 -0700, Tom Rini tr...@ti.com wrote:
On Sat, Aug 18, 2012 at 07:15:56AM -0700, Tom Rini wrote:
On Sat, Aug 18, 2012 at 08:28:55AM +0200, Albert ARIBAUD wrote:
Hi Tom,
On Fri,
That's odd, I thought I fixed that.
+#define EFIKAMX_USB_HUB_RESET IMX_GPIO_NR(1, 5)
+#define EFIKAMX_USB_PHY_RESET IMX_GPIO_NR(2, 9)
I copied the above two lines from my patch to the ML.. what happened here? :(
--
Matt Sealey m...@genesi-usa.com
Product Development Analyst, Genesi USA, Inc.
Hi all,
this is a follow up on the patch USB: EHCI: Initialize multiple
USB controllers at once from Jim Lin. It takes some of the
code but has undergone some heavy reworking.
When we remove the ifdef horror from the above mentioned patch it's
mostly a big interface change to the usb subsystem.
Carry an index in the lowlevel usb functions to make specify the
respective usb controller.
Also pass through an controller struct from lowlevel_init to the
creation of the root usb device of this controller.
Signed-off-by: Lucas Stach d...@lynxeye.de
---
arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c
Allows to initialize more than one USB controller at once.
Signed-off-by: Lucas Stach d...@lynxeye.de
---
common/cmd_usb.c| 16 +--
common/usb.c| 104 +++-
common/usb_storage.c| 2 +-
drivers/usb/eth/usb_ether.c |
Kill off ehci-core.h
It was used to specify some static controller data. To support more than
one controller being active at any time we have to carry the controller
data ourselfes. Change the ehci interface accordingly.
NOTE: OMAP implemented the ehci stuff a bit backwards and should be fixed
to
EHCI interface now supports more than one controller. Wire up our usb functions
to use this new interface.
Signed-off-by: Lucas Stach d...@lynxeye.de
---
arch/arm/cpu/armv7/tegra20/usb.c| 15 ---
arch/arm/include/asm/arch-tegra20/usb.h | 4 ++--
drivers/usb/host/ehci-tegra.c
On Thu, Aug 30, 2012 at 01:41:02AM -0700, Albert ARIBAUD wrote:
Hi Tom,
On Wed, 29 Aug 2012 14:10:19 -0700, Tom Warren twar...@nvidia.com
wrote:
Lucas,
-Original Message-
From: Lucas Stach [mailto:d...@lynxeye.de]
Sent: Wednesday, August 29, 2012 1:54 PM
To: Tom
On Thu, Jun 14, 2012 at 6:36 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi Rajeshwari,
This patch has too many dependence with other patches.
(Pinmux and PeripID, patches for MSHCI setting).
And as i mentioned, designWare controller isn't exynos specific.
I think good that separate two
Hi!
I took oportunity to cleanup whitespace in
arch/arm/cpu/armv7/omap-common/u-boot-spl.lds. Perhaps someone can
merge that...
Argh ... what about using git send-email for the patch submission please?
I'm not supposed to submit patches here, these are just requests for
review ;-).
On Thursday 30 of August 2012 00:18:18 Marek Vasut wrote:
...snip...
+extern block_dev_desc_t sata_dev_desc[];
+
+int init_sata(int dev)
+{
+ block_dev_desc_t *pdev = (sata_dev_desc[dev]);
Superfluous braces ... Actually, I think sata_dev_desc as it would work very
well too.
Hi!
I think once you get the answers you should be able to re-post the
series cleanly and depend on my v5 (or v6) branch. Thanks!
Ok, figuring the .lds might be tricky. But... that's mostly additional
(safety) feature. Would it be possible to merge it without that and
add it later?
On Wed 2012-08-29 17:03:22, Tom Rini wrote:
On 08/29/2012 04:34 PM, Pavel Machek wrote:
On Wed 2012-08-29 11:26:45, Tom Rini wrote:
On Wed, Aug 29, 2012 at 03:41:54PM +0200, Pavel Machek wrote:
Hi!
diff --git a/arch/arm/cpu/armv7/socfpga/u-boot-spl.lds
On 08/30/2012 10:18 AM, Pavel Machek wrote:
+ * miscellaneous platform dependent initialisations
+ */
+int misc_init_r(void)
+{
+ /* Set to n for not verifying the uImage */
+ setenv(verify, n);
+ return 0;
+}
Not good to enforce policy like this. Just don't set it in the config
On 08/30/2012 10:34 AM, Tom Rini wrote:
On 08/30/2012 10:18 AM, Pavel Machek wrote:
+ * miscellaneous platform dependent initialisations
+ */
+int misc_init_r(void)
+{
+ /* Set to n for not verifying the uImage */
+ setenv(verify, n);
+ return 0;
+}
Not good to enforce policy like
Dear Pavel Machek,
Hi!
I took oportunity to cleanup whitespace in
arch/arm/cpu/armv7/omap-common/u-boot-spl.lds. Perhaps someone can
merge that...
Argh ... what about using git send-email for the patch submission please?
I'm not supposed to submit patches here, these are just
Hi!
diff --git a/common/spl/spl.c b/common/spl/spl.c
index eaea1c8..5adbf0e 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -78,6 +78,7 @@ void spl_parse_image_header(const struct image_header
*header)
u32 header_size = sizeof(struct image_header);
if
On Wed, Aug 29, 2012 at 02:08:59PM -0700, Allen Martin wrote:
The LIST_arm rule included the Atmel boards twice (by virtue of
including both LIST_at91 and LIST_ARM9) and was missing all the
arm720t, arm946es, and arm1176 boards. Change this list to use
boards_by_arch() which is less error
Hi!
+ writel(TIMER_LOAD_VAL, timer_base-load_val);
+ writel(TIMER_LOAD_VAL, timer_base-curr_val);
+ writel((readl((timer_base-ctrl)) | 0x3),
I think you should stick to programming in C here, not LISP, so
try cutting down on the ((braces)) :-)
Dear Pavel Machek,
Hi!
+ writel(TIMER_LOAD_VAL, timer_base-load_val);
+ writel(TIMER_LOAD_VAL, timer_base-curr_val);
+ writel((readl((timer_base-ctrl)) | 0x3),
I think you should stick to programming in C here, not LISP,
so try cutting down on
On Thu, Aug 30, 2012 at 09:24:39AM +0200, Matej Fran?e?kin wrote:
Timeout variable is decremented once more when while condition is not met.
Following if does not detect correctly that timeout has occurred.
Because of this bug the usb start command on AM335X-EVM board did not
detect
On 08/30/2012 11:05 AM, Pavel Machek wrote:
Hi!
diff --git a/common/spl/spl.c b/common/spl/spl.c
index eaea1c8..5adbf0e 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -78,6 +78,7 @@ void spl_parse_image_header(const struct image_header
*header)
u32 header_size = sizeof(struct
Dear Matej Frančeškin,
Timeout variable is decremented once more when while condition is not met.
Following if does not detect correctly that timeout has occurred.
Because of this bug the usb start command on AM335X-EVM board did not
detect correctly that USB device was not attached.
Dear Pavel Herrmann,
On Thursday 30 of August 2012 00:18:18 Marek Vasut wrote:
...snip...
+extern block_dev_desc_t sata_dev_desc[];
+
+int init_sata(int dev)
+{
+ block_dev_desc_t *pdev = (sata_dev_desc[dev]);
Superfluous braces ... Actually, I think sata_dev_desc as it
On Thursday 30 of August 2012 20:45:13 Marek Vasut wrote:
Dear Pavel Herrmann,
On Thursday 30 of August 2012 00:18:18 Marek Vasut wrote:
...snip...
+extern block_dev_desc_t sata_dev_desc[];
+
+int init_sata(int dev)
+{
+ block_dev_desc_t *pdev =
Dear Łukasz Dałek,
I've moved cpu revision detection to arch/arm/cpu/pxa as you suggest.
Cleaned ethernet driver. Soon I would also send patches for
drivers/usb/gadget/ether.c to work correctly with this pxa driver.
Łukasz Dałek (2):
pxa: Add some stuff to examine cpu model and rev
On Wed, Aug 29, 2012 at 9:23 PM, Ilya Yanok
ilya.ya...@cogentembedded.com wrote:
Hi Stefan,
Stefan Roese sr at denx.de writes:
Or does patman not even try to send, once checkpatch warning/errors are
detected?
That's it. Normally you don't want to send patches that are not
Hi!
spl_ram_load_image... will I need to create some kind of #ifdef? Or
would #ifdef BOOT_DEVICE_RAM do the trick?
Good point, yes, we should add CONFIG_SPL_RAM_DEVICE and document it in
docs/README.SPL and the toplevel README.
Ok, something like this? Posting separately, maybe it
Dear Marek Vasut,
Dear Lucas Stach,
We don't actually need to pack those structs, as they
are not used to do actual hardware access.
This avoids some unaligned accesses and therefore makes
the EHCI stack work on ARMv7 without compiler workarounds.
Signed-off-by: Lucas Stach
Dear Lucas Stach,
Carry an index in the lowlevel usb functions to make specify the
respective usb controller.
Also pass through an controller struct from lowlevel_init to the
creation of the root usb device of this controller.
Signed-off-by: Lucas Stach d...@lynxeye.de
[...]
WFM,
Dear Lucas Stach,
Kill off ehci-core.h
It was used to specify some static controller data. To support more than
one controller being active at any time we have to carry the controller
data ourselfes. Change the ehci interface accordingly.
NOTE: OMAP implemented the ehci stuff a bit
On Tue, Jul 3, 2012 at 12:58 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
This patch is supported DesginWare MMC Controller.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Signed-off-by: Rajeshawari Shinde rajeshwar...@samsung.com
Dear Lucas Stach,
Allows to initialize more than one USB controller at once.
Signed-off-by: Lucas Stach d...@lynxeye.de
[...]
int usb_stop(void)
{
- int res = 0;
+ int i;
if (usb_started) {
asynch_allowed = 1;
usb_started = 0;
On Tue, Jul 3, 2012 at 12:58 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
To get more exactly sclk value, used the get_mmc_clk.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/cpu/armv7/exynos/clock.c | 78
On Tue, Jul 3, 2012 at 12:58 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Support DesignWare MMC Controller for Samsung Specific.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Signed-off-by: Rajeshawari Shinde
Dear Marek,
it seems you are right. Though it works for me this may be pure luck. So
please disregard this patch, I'll fix this up more properly.
Thanks,
Lucas
Am Donnerstag, den 30.08.2012, 22:59 +0200 schrieb Marek Vasut:
Dear Marek Vasut,
Dear Lucas Stach,
We don't actually need
On Thu, Jul 26, 2012 at 7:33 PM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Useless code is removed, and get buswidth value.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
---
arch/arm/include/asm/arch-exynos/mmc.h |4 ++--
arch/arm/include/asm/arch-s5pc1xx/mmc.h |4 ++--
Am Donnerstag, den 30.08.2012, 23:09 +0200 schrieb Marek Vasut:
Dear Lucas Stach,
Kill off ehci-core.h
It was used to specify some static controller data. To support more than
one controller being active at any time we have to carry the controller
data ourselfes. Change the ehci
Dear Pavel Herrmann,
On Thursday 30 of August 2012 20:45:13 Marek Vasut wrote:
Dear Pavel Herrmann,
On Thursday 30 of August 2012 00:18:18 Marek Vasut wrote:
...snip...
+extern block_dev_desc_t sata_dev_desc[];
+
+int init_sata(int dev)
+{
+
On Thu, Jul 26, 2012 at 7:33 PM, Jaehoon Chung jh80.ch...@samsung.com wrote:
To ensure that complete the request, add udelay(100).
Also increased the timeout value to 1.
(Because timeout value is short, there is the case that didn't transfer data)
Signed-off-by: Jaehoon Chung
Dear Lucas Stach,
Am Donnerstag, den 30.08.2012, 23:09 +0200 schrieb Marek Vasut:
Dear Lucas Stach,
Kill off ehci-core.h
It was used to specify some static controller data. To support more
than one controller being active at any time we have to carry the
controller data
Dear Lucas Stach,
Dear Marek,
it seems you are right. Though it works for me this may be pure luck. So
please disregard this patch, I'll fix this up more properly.
Cool thing we caught it :-)
http://www.denx.de/wiki/U-Boot/Patches btw read up here ... don't top-post ...
you know the
On 30.08.2012 21:09, Marek Vasut wrote:
Dear Łukasz Dałek,
I've moved cpu revision detection to arch/arm/cpu/pxa as you suggest.
Cleaned ethernet driver. Soon I would also send patches for
drivers/usb/gadget/ether.c to work correctly with this pxa driver.
Łukasz Dałek (2):
pxa: Add some
Dear Łukasz Dałek,
On 30.08.2012 21:09, Marek Vasut wrote:
Dear Łukasz Dałek,
I've moved cpu revision detection to arch/arm/cpu/pxa as you suggest.
Cleaned ethernet driver. Soon I would also send patches for
drivers/usb/gadget/ether.c to work correctly with this pxa driver.
On 31.08.2012 00:04, Marek Vasut wrote:
Dear Łukasz Dałek,
On 30.08.2012 21:09, Marek Vasut wrote:
Dear Łukasz Dałek,
I've moved cpu revision detection to arch/arm/cpu/pxa as you suggest.
Cleaned ethernet driver. Soon I would also send patches for
drivers/usb/gadget/ether.c to work
On Thu, Aug 30, 2012 at 10:42:11PM +0200, Pavel Machek wrote:
Hi!
spl_ram_load_image... will I need to create some kind of #ifdef? Or
would #ifdef BOOT_DEVICE_RAM do the trick?
Good point, yes, we should add CONFIG_SPL_RAM_DEVICE and document it in
docs/README.SPL and the
usb_hub_descriptor has to be packed as it's used for
communication with the device. Member wHubCharacteristics
violates the natural alignment rules.
Use explicit unaligned access functions for this member.
Fixes ARMv7 traping while using USB.
Signed-off-by: Lucas Stach d...@lynxeye.de
---
Dear Lucas Stach,
usb_hub_descriptor has to be packed as it's used for
communication with the device. Member wHubCharacteristics
violates the natural alignment rules.
Use explicit unaligned access functions for this member.
Fixes ARMv7 traping while using USB.
Shouldn't a properly
This is based on Linux kernel -next:
commit a1256b0e087ed3cdb584c683acb966ee885f733c
Author: Brian Norris computersforpe...@gmail.com
Date: Fri Jul 13 09:28:24 2012 -0700
mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver
The NAND_CHIPOPTIONS_MSK has limited utility and is
Enable caches, make it faster!
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Stefano Babic sba...@denx.de
Cc: Detlev Zundel d...@denx.de
---
include/configs/sc_sps_1.h |2 --
1 file changed, 2 deletions(-)
diff --git a/include/configs/sc_sps_1.h b/include/configs/sc_sps_1.h
index
Dear Marek Vasut,
This is based on Linux kernel -next:
commit a1256b0e087ed3cdb584c683acb966ee885f733c
Author: Brian Norris computersforpe...@gmail.com
Date: Fri Jul 13 09:28:24 2012 -0700
mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver
The NAND_CHIPOPTIONS_MSK
Hi John,
Did you apply this patch?
http://www.mail-archive.com/u-boot@lists.denx.de/msg88515.html
Best Regards,
Jaehoon Chung
On 08/31/2012 12:42 AM, John Rigby wrote:
Jaehoon,
I get timeouts on multiblock mmc reads with v2012.07 u-boot. I did a
bisect and found that it is broken back to
Dear Łukasz Dałek,
On 31.08.2012 00:04, Marek Vasut wrote:
Dear Łukasz Dałek,
On 30.08.2012 21:09, Marek Vasut wrote:
Dear Łukasz Dałek,
I've moved cpu revision detection to arch/arm/cpu/pxa as you suggest.
Cleaned ethernet driver. Soon I would also send patches for
Hi Andy,
@@ -80,12 +80,11 @@ int s5p_sdhci_init(u32 regbase, u32 max_clk, u32
min_clk, u32 quirks)
host-name = S5P_NAME;
host-ioaddr = (void *)regbase;
- host-quirks = quirks;
I'm very confused by this line. quirks is the 4th argument to the
original version of
Samsung SoC is broken busy waiting for R1b type.
And clk delay control value is modified the previosuly value.
(that value used at the s5p_mmc.c)
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/s5p_sdhci.c | 10
Samsung SoC use the cmu control to set clock.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/s5p_sdhci.c |3 +++
drivers/mmc/sdhci.c |3 +++
include/configs/trats.h |1 +
include/sdhci.h |2 ++
To use SDHCI for Samsung-SoC, Some problem is fixed.(read/write problem)
See the below mmcinfo message:
1. eMMC card:
Device: SAMSUNG SDHCI
Manufacturer ID: 15
OEM: 100
Name: VYL00
Tran Speed: 5200
Rd Block Len: 512
MMC version 4.0
High Capacity: Yes
Capacity: 14.7 GiB
Bus Width: 4-bit
2.
Useless code is removed, and get buswidth value.
buswidth value will be used to choice the 4bit or 8bit.
(Now used 4bit mode in sdhci.c by default)
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungin.p...@samsung.com
---
arch/arm/include/asm/arch-exynos/mmc.h
Samsung-SoC is taken the too late to changing the interrupt status register.
This patch is ensure to check the interrupt status register for Samsung-SoC.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/sdhci.c |4 ++--
Hi Lei,
On 08/31/2012 11:28 AM, Lei Wen wrote:
Hi Jaehoon,
-Original Message-
From: Jaehoon Chung [mailto:jh80.ch...@samsung.com]
Sent: Friday, August 31, 2012 10:24 AM
To: u-boot@lists.denx.de
Cc: Andy Fleming; Kyungmin Park; Lei Wen; John Rigby; Tushar Behera
Subject: [PATCH v3
Hi, All
Is any feedback for this rev3 patch series.
Best Regards,
Josh Wu
On 8/23/2012 6:05 PM, Josh Wu wrote:
This patch series will add PMECC support for atmel at91sam9x5ek in u-boot.
The NAND flash driver patch is ported from kernel patch. The main different
from kernel patch is
the
74 matches
Mail list logo
