Re: [U-Boot] [PATCH v3 2/5] drivers: video: Add ld9040 video driver

2012-09-26 Thread Minkyu Kang
Dear Piotr, On 24 September 2012 22:04, Piotr Wilczek wrote: > This patch add ld9040 video driver: > new file: drivers/video/ld9040.c > new file: include/ld9040.h > modified: drivers/video/Makefile It's a unnecessary information. Please remove it. > > Signed-off-by: Piotr Wilczek > Signe

Re: [U-Boot] KernelDoc

2012-09-26 Thread Stefan Roese
On 09/26/2012 09:54 PM, Wolfgang Denk wrote: >>> If I change the calling interface, must I add documentation then? >> >> Of course, yes. > > Didn't we agree that we want to make it easier for people to > contribute code? If somebody who just wants to improve a small detail > in the code is n

Re: [U-Boot] [PATCH v3 3/5] arm: exynos4: cpu: Add definition for display

2012-09-26 Thread Piotr Wilczek
Dear Minkyu, > -Original Message- > From: Minkyu Kang [mailto:proms...@gmail.com] > Sent: Thursday, September 27, 2012 2:21 AM > To: Piotr Wilczek > Cc: u-boot@lists.denx.de; Kyungmin Park; Donghwa Lee > Subject: Re: [U-Boot] [PATCH v3 3/5] arm: exynos4: cpu: Add definition > for display >

Re: [U-Boot] [PATCH] common/i2c: Add i2c write command

2012-09-26 Thread Heiko Schocher
Hello Tom, York, On 25.09.2012 22:21, Tom Rini wrote: [...] Tom, Do I need to change this patch in any way? I see it is still "under review" in patchwork. I am fine with it. This falls to Heiko now, thanks. It looks good to me too. I add it in the next merge window. bye, Heiko -- DENX Sof

[U-Boot] [PATCH] fsl espi: Fix reading from device

2012-09-26 Thread Dale P. Smith
Return the actual bytes read from the device. --- drivers/spi/fsl_espi.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/spi/fsl_espi.c b/drivers/spi/fsl_espi.c index a1ebd33..c0348db 100644 --- a/drivers/spi/fsl_espi.c +++ b/drivers/spi/fsl_espi.c @@ -291

Re: [U-Boot] [PATCH 0/6] add zip command support for uboot

2012-09-26 Thread Lei Wen
Hi Marek, On Wed, Sep 26, 2012 at 11:34 PM, Marek Vasut wrote: > Dear Lei Wen, > > > On Thu, Sep 6, 2012 at 6:49 PM, Marek Vasut wrote: > > > Dear Lukasz Majewski, > > > > > > [...] > > > > > > > > Ok, that means we can make use of this command ? > > > > > > > > I cannot promise, that I will pr

Re: [U-Boot] [PATCH 0/6] add zip command support for uboot

2012-09-26 Thread Lei Wen
Hi Tom, On Thu, Sep 27, 2012 at 12:20 AM, Tom Rini wrote: > On Wed, Sep 26, 2012 at 05:34:25PM +0200, Marek Vasut wrote: > > Dear Lei Wen, > > > > > On Thu, Sep 6, 2012 at 6:49 PM, Marek Vasut wrote: > > > > Dear Lukasz Majewski, > > > > > > > > [...] > > > > > > > > > > Ok, that means we can m

Re: [U-Boot] [PATCH v1 2/4] mpc83xx: add support for mpc8309

2012-09-26 Thread Kim Phillips
On Wed, 26 Sep 2012 10:28:08 +0200 Gerlando Falauto wrote: > This processor, though very similar to other members of the > PowerQUICC II Pro family (namely 8308, 8360 and 832x), provides > yet another feature set than any supported sibling. > > So we add a bunch of new #ifdefs (or complicate the

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Marek Vasut
Dear Łukasz Dałek, > On 27.09.2012 02:31, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 27.09.2012 02:07, Marek Vasut wrote: > >>> Dear Łukasz Dałek, > >>> > On 27.09.2012 01:58, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 27.09.2012 01:32, Marek Vasut wrote:

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Łukasz Dałek
On 27.09.2012 02:31, Marek Vasut wrote: Dear Łukasz Dałek, On 27.09.2012 02:07, Marek Vasut wrote: Dear Łukasz Dałek, On 27.09.2012 01:58, Marek Vasut wrote: Dear Łukasz Dałek, On 27.09.2012 01:32, Marek Vasut wrote: Dear Łukasz Dałek, On 26.09.2012 18:13, Marek Vasut wrote: Dear Łuka

Re: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

2012-09-26 Thread Łukasz Dałek
On 27.09.2012 02:30, Marek Vasut wrote: Dear Łukasz Dałek, On 27.09.2012 02:06, Marek Vasut wrote: Dear Łukasz Dałek, On 27.09.2012 01:58, Marek Vasut wrote: Dear Łukasz Dałek, On 26.09.2012 17:31, Marek Vasut wrote: Dear Lukasz Dalek, PXA25x gadget implements common function usb_disco

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Marek Vasut
Dear Łukasz Dałek, > On 27.09.2012 02:07, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 27.09.2012 01:58, Marek Vasut wrote: > >>> Dear Łukasz Dałek, > >>> > On 27.09.2012 01:32, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 26.09.2012 18:13, Marek Vasut wrote:

Re: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

2012-09-26 Thread Marek Vasut
Dear Łukasz Dałek, > On 27.09.2012 02:06, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 27.09.2012 01:58, Marek Vasut wrote: > >>> Dear Łukasz Dałek, > >>> > On 26.09.2012 17:31, Marek Vasut wrote: > > Dear Lukasz Dalek, > > > >> PXA25x gadget implements common function

Re: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

2012-09-26 Thread Łukasz Dałek
On 27.09.2012 02:06, Marek Vasut wrote: Dear Łukasz Dałek, On 27.09.2012 01:58, Marek Vasut wrote: Dear Łukasz Dałek, On 26.09.2012 17:31, Marek Vasut wrote: Dear Lukasz Dalek, PXA25x gadget implements common function usb_disconnect(). This patch adds this function prototype into usb.h fo

Re: [U-Boot] [PATCH v3 3/5] arm: exynos4: cpu: Add definition for display

2012-09-26 Thread Minkyu Kang
Dear Piotr, On 24 September 2012 22:04, Piotr Wilczek wrote: > Add EXYNOS4_DISPLAY_CONTROL definition > > Signed-off-by: Piotr Wilczek > Signed-off-by: Kyungmin Park > CC: Minkyu Kang > --- > Changes in v2: > - removed definions for fimd. > Changes in v3: > - none. > > arch/arm/include/asm/ar

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Łukasz Dałek
On 27.09.2012 02:07, Marek Vasut wrote: Dear Łukasz Dałek, On 27.09.2012 01:58, Marek Vasut wrote: Dear Łukasz Dałek, On 27.09.2012 01:32, Marek Vasut wrote: Dear Łukasz Dałek, On 26.09.2012 18:13, Marek Vasut wrote: Dear Łukasz Dałek, On 26.09.2012 17:29, Marek Vasut wrote: Dear Luka

Re: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

2012-09-26 Thread Łukasz Dałek
On 27.09.2012 01:58, Marek Vasut wrote: Dear Łukasz Dałek, On 26.09.2012 17:31, Marek Vasut wrote: Dear Lukasz Dalek, PXA25x gadget implements common function usb_disconnect(). This patch adds this function prototype into usb.h for boards using it. [...] +/* + * This isn't host + */ The

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Marek Vasut
Dear Łukasz Dałek, > On 27.09.2012 01:58, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 27.09.2012 01:32, Marek Vasut wrote: > >>> Dear Łukasz Dałek, > >>> > On 26.09.2012 18:13, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 26.09.2012 17:29, Marek Vasut wrote:

Re: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

2012-09-26 Thread Marek Vasut
Dear Łukasz Dałek, > On 27.09.2012 01:58, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 26.09.2012 17:31, Marek Vasut wrote: > >>> Dear Lukasz Dalek, > >>> > PXA25x gadget implements common function usb_disconnect(). > This patch adds this function prototype into usb.h for boar

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Łukasz Dałek
On 27.09.2012 01:58, Marek Vasut wrote: Dear Łukasz Dałek, On 27.09.2012 01:32, Marek Vasut wrote: Dear Łukasz Dałek, On 26.09.2012 18:13, Marek Vasut wrote: Dear Łukasz Dałek, On 26.09.2012 17:29, Marek Vasut wrote: Dear Lukasz Dalek, Basic support of HP iPAQ h2200 palmtop. Support in

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Marek Vasut
Dear Łukasz Dałek, > On 27.09.2012 01:32, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 26.09.2012 18:13, Marek Vasut wrote: > >>> Dear Łukasz Dałek, > >>> > On 26.09.2012 17:29, Marek Vasut wrote: > > Dear Lukasz Dalek, > > > >> Basic support of HP iPAQ h2200 palmtop.

Re: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

2012-09-26 Thread Marek Vasut
Dear Łukasz Dałek, > On 26.09.2012 17:31, Marek Vasut wrote: > > Dear Lukasz Dalek, > > > >> PXA25x gadget implements common function usb_disconnect(). > >> This patch adds this function prototype into usb.h for boards using it. > > > > [...] > > > >> +/* > >> + * This isn't host > >> + */ > >

Re: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

2012-09-26 Thread Łukasz Dałek
On 26.09.2012 17:31, Marek Vasut wrote: Dear Lukasz Dalek, PXA25x gadget implements common function usb_disconnect(). This patch adds this function prototype into usb.h for boards using it. [...] +/* + * This isn't host + */ The comment doesn't need to be multiline. It'd be cool if it was m

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Łukasz Dałek
On 27.09.2012 01:32, Marek Vasut wrote: Dear Łukasz Dałek, On 26.09.2012 18:13, Marek Vasut wrote: Dear Łukasz Dałek, On 26.09.2012 17:29, Marek Vasut wrote: Dear Lukasz Dalek, Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget. Two minor nits ... can you e

Re: [U-Boot] KernelDoc

2012-09-26 Thread Marek Vasut
Dear Tom Rini, > On 09/26/12 12:10, Marek Vasut wrote: > > Dear Tom Rini, > > > >> On Tue, Sep 25, 2012 at 10:46:10PM +0200, Marek Vasut wrote: > >>> Hi all! > >>> > >>> I've had a discussion with Wolfgang just now about U-Boot > >>> coding style. I tried using KernelDoc in a patch, which is not

Re: [U-Boot] KernelDoc

2012-09-26 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek, > > In message <201209262158.48495.ma...@denx.de> you wrote: > > > Or if you want to get your critical bug fix > > > in now, but the custodian promises a doc patch for half a year later? > > > > I cannot parse this. I agree the critical fix has a high-prio. > >

Re: [U-Boot] KernelDoc

2012-09-26 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek, > > In message <201209262154.59207.ma...@denx.de> you wrote: > > OT: I would hate to rework the patches that already follow that style and > > then rework them again. Maybe we can do a compromise, drop the initial > > double- asterisk and otherwise follow the ker

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Marek Vasut
Dear Łukasz Dałek, > On 26.09.2012 18:13, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 26.09.2012 17:29, Marek Vasut wrote: > >>> Dear Lukasz Dalek, > >>> > Basic support of HP iPAQ h2200 palmtop. Support includes also USB > ethernet gadget. > >>> > >>> Two minor nits ... can

Re: [U-Boot] [PATCH v8] [RFC] early_malloc for DM added.

2012-09-26 Thread Graeme Russ
Hi Tomas, On Wed, Sep 26, 2012 at 8:16 PM, Tomas Hlavacek wrote: > Hello Graeme, > > On Wed, Sep 26, 2012 at 1:04 AM, Graeme Russ wrote: >> Hi Tomas >> >> On Tue, Sep 25, 2012 at 7:09 PM, Graeme Russ wrote: >> >>> We should implement each of malloc(), free(), calloc(), and realloc(). >>> >>> Do

[U-Boot] [PATCH] powerpc: delete Wind River SBC8560/8540 support

2012-09-26 Thread Paul Gortmaker
The sbc8548/60 (both similar, just variations in UART hardware) support has been removed from the linux kernel as of v3.6-rc1~132 so lets also now remove it from the u-boot tree as well. Signed-off-by: Paul Gortmaker --- MAINTAINERS | 2 - board/sbc8560/Makefile| 50 - b

[U-Boot] [PATCH 0/1] Delete sbc8650 / sbc8540 support.

2012-09-26 Thread Paul Gortmaker
This old board has already been deleted from the linux kernel. Sending this 0/1 so that I can include a pull request. The following patch has been formatted with "--irreversible-delete" so that it does not contain all the meaningless deleted lines in the mailout to the list. However "git-am" doe

[U-Boot] [PATCH] mx6qsabreauto: Use ttymxc3 as console

2012-09-26 Thread Otavio Salvador
The mx6qsabreauto console is different than mx6qsabresd so the console configuration is now set in the board file. Signed-off-by: Otavio Salvador --- include/configs/mx6qsabre_common.h |2 +- include/configs/mx6qsabreauto.h|4 +++- include/configs/mx6qsabresd.h |4 +++- 3 fi

[U-Boot] [PATCH] FSL SPI read fix.

2012-09-26 Thread Dale Smith
The fsl spi engine is non functional when reading from a device. This patch fixes it. Note that none of the other spi interfaces parse through the datastream looking for 0x0b bytes. -Dale diff --git a/drivers/spi/fsl_espi.c b/drivers/spi/fsl_espi.c index a1ebd33..737719b 100644 --- a/drivers/sp

Re: [U-Boot] KernelDoc

2012-09-26 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/26/12 13:57, Wolfgang Denk wrote: [snip] >>> Can such checking (all functions have a kernel-doc comment, >>> which covers the return value and all arguments) be done >>> automatically, say throuch checkpatch? >> >> I would love to see this. >

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Łukasz Dałek
On 26.09.2012 18:13, Marek Vasut wrote: Dear Łukasz Dałek, On 26.09.2012 17:29, Marek Vasut wrote: Dear Lukasz Dalek, Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget. Two minor nits ... can you extend the patch description? Signed-off-by: Lukasz Dalek [..

[U-Boot] [PATCH 4/6] console & omap-common/spl: Enable use of eserial

2012-09-26 Thread Andrew Bradford
Enable use of eserial devices for common and omap-common/spl. This probably isn't the right way to do this as the changes aren't needed for 'common' configurations, just for one case. Signed-off-by: Andrew Bradford --- arch/arm/cpu/armv7/omap-common/spl.c |7 ++- common/console.c

[U-Boot] [PATCH 2/6] am33xx: Enable UART{1,2,4,5} pin-mux

2012-09-26 Thread Andrew Bradford
If configured to use UART{1,2,4,5}, such as on the Beaglebone RS232 cape, enable the proper pin-muxing as per the RS232 cape configuration. Signed-off-by: Andrew Bradford --- arch/arm/cpu/armv7/am33xx/board.c| 14 + arch/arm/include/asm/arch-am33xx/sys_proto.h |6 +++-

[U-Boot] [PATCH 5/6] am33xx: Enable eserial device usage for ns16550

2012-09-26 Thread Andrew Bradford
Signed-off-by: Andrew Bradford --- include/serial.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/serial.h b/include/serial.h index dcb2d97..079655f 100644 --- a/include/serial.h +++ b/include/serial.h @@ -32,7 +32,7 @@ extern struct serial_device *default_serial_

[U-Boot] [PATCH 0/6] am335x_evm: Enable UART{1,2,4,5}

2012-09-26 Thread Andrew Bradford
To support serial ports other than UART0 on am335x based systems like the Beaglebone with the RS232 cape. Patch 4 is not the proper way to do what I want to accomplish but should give the idea I was going after. If someone could give me some pointers on the best way to do this, I'd welcome it. T

[U-Boot] [PATCH 3/6] serial: Enable up to 6 eserial devices

2012-09-26 Thread Andrew Bradford
Increase the number of possible eserial devices from 4 to 6. Signed-off-by: Andrew Bradford --- common/serial.c |6 ++ drivers/serial/serial.c | 39 +++ include/serial.h|2 ++ 3 files changed, 43 insertions(+), 4 deletions(-) dif

[U-Boot] [PATCH 6/6] am335x_evm: Enable use of UART{1,2,4,5}

2012-09-26 Thread Andrew Bradford
Add targets of am335x_evm_uart{1,2,4,5} to have serial input/output on UART{1,2,4,5} for use with the Beaglebone RS232 cape and other custom configurations. Signed-off-by: Andrew Bradford --- boards.cfg |4 include/configs/am335x_evm.h | 28 ++

[U-Boot] [PATCH 1/6] am33xx: Enable UART{1,2,4,5} clocks

2012-09-26 Thread Andrew Bradford
If configured to use UART{1,2,4,5}, such as on the Beaglebone RS232 cape, enable the required clocks for the UART in use. Signed-off-by: Andrew Bradford --- arch/arm/cpu/armv7/am33xx/clock.c | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm/cpu/armv7/am

Re: [U-Boot] KernelDoc

2012-09-26 Thread Wolfgang Denk
Dear Marek, In message <201209262158.48495.ma...@denx.de> you wrote: > > > Or if you want to get your critical bug fix > > in now, but the custodian promises a doc patch for half a year later? > > I cannot parse this. I agree the critical fix has a high-prio. You suggested that including kernel

Re: [U-Boot] KernelDoc

2012-09-26 Thread Wolfgang Denk
Dear Marek, In message <201209262154.59207.ma...@denx.de> you wrote: > > OT: I would hate to rework the patches that already follow that style and > then > rework them again. Maybe we can do a compromise, drop the initial double- > asterisk and otherwise follow the kernel-doc? That is always po

Re: [U-Boot] KernelDoc

2012-09-26 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/26/12 12:54, Wolfgang Denk wrote: > Can such checking (all functions have a kernel-doc comment, which > covers the return value and all arguments) be done automatically, > say throuch checkpatch? It's been a long time but I believe you see tho

Re: [U-Boot] KernelDoc

2012-09-26 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek, > > In message <201209261726.55611.ma...@denx.de> you wrote: > > > - Will we make this mandatory? So that we will reject all new code > > > > > > that is not documented according to kernel-doc rules? > > > > Yes please, make it mandatory. Otherwise people wo

Re: [U-Boot] KernelDoc

2012-09-26 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/26/12 12:10, Marek Vasut wrote: > Dear Tom Rini, > >> On Tue, Sep 25, 2012 at 10:46:10PM +0200, Marek Vasut wrote: >>> Hi all! >>> >>> I've had a discussion with Wolfgang just now about U-Boot >>> coding style. I tried using KernelDoc in a patc

Re: [U-Boot] KernelDoc

2012-09-26 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek, > > In message <201209262110.18172.ma...@denx.de> you wrote: > > > But we need to borrow the Documentation/DocBook > > > Makefile and logic and so on from the kernel first. And add template > > > files for the DM sections so something can be spit out. > > > > I

Re: [U-Boot] KernelDoc

2012-09-26 Thread Wolfgang Denk
Dear Marek, In message <201209261726.55611.ma...@denx.de> you wrote: > > > - Will we make this mandatory? So that we will reject all new code > > that is not documented according to kernel-doc rules? > > Yes please, make it mandatory. Otherwise people won't obey and the > documentation > wi

Re: [U-Boot] KernelDoc

2012-09-26 Thread Wolfgang Denk
Dear Marek, In message <201209262110.18172.ma...@denx.de> you wrote: > > > But we need to borrow the Documentation/DocBook > > Makefile and logic and so on from the kernel first. And add template > > files for the DM sections so something can be spit out. > > I'd leave that for step 2 (document

Re: [U-Boot] [RFC PATCH 1/5] env: Add support for callbacks to environment vars

2012-09-26 Thread Wolfgang Denk
Dear Joe Hershberger, In message <1348264998-27323-2-git-send-email-joe.hershber...@ni.com> you wrote: > Add support for callbacks to the "hashtable" functions. ... > +/* > + * Iterate through the whole list calling the callback for each found > element. > + */ > +int env_attr_walk(const char *at

Re: [U-Boot] KernelDoc

2012-09-26 Thread Marek Vasut
Dear Tom Rini, > On Tue, Sep 25, 2012 at 10:46:10PM +0200, Marek Vasut wrote: > > Hi all! > > > > I've had a discussion with Wolfgang just now about U-Boot coding > > style. I tried using KernelDoc in a patch, which is not part of the > > U-Boot Coding Style now, thus it was rejected. > > > > I

Re: [U-Boot] KernelDoc

2012-09-26 Thread Tom Rini
On Tue, Sep 25, 2012 at 10:46:10PM +0200, Marek Vasut wrote: > Hi all! > > I've had a discussion with Wolfgang just now about U-Boot coding > style. I tried using KernelDoc in a patch, which is not part of the > U-Boot Coding Style now, thus it was rejected. > > I really like the idea of annotat

Re: [U-Boot] KernelDoc

2012-09-26 Thread Marek Vasut
Dear Joe Hershberger, [..] > > Yes please, make it mandatory. Otherwise people won't obey and the > > documentation will suffer ... and all this would be meaningless. > > I think mandatory should only be for newly added functions. Pardon my wording, this is what I had in mind. > There is > alr

Re: [U-Boot] KernelDoc

2012-09-26 Thread Joe Hershberger
Hi Marek, On Wed, Sep 26, 2012 at 10:26 AM, Marek Vasut wrote: > Dear Wolfgang Denk, > >> Dear Marek, >> >> In message <201209252246.10322.ma...@denx.de> you wrote: >> > I've had a discussion with Wolfgang just now about U-Boot coding style. I >> > tried using KernelDoc in a patch, which is not p

[U-Boot] problem

2012-09-26 Thread 林子丁
I have a problem when I compiled u-boot-2012.07 in my am335x.Can you help me? u-boot-2012.07/include/configs/mybeaglebone.h:31:26: asm/arch/cpu.h:没有那个文件或目录 u-boot-2012.07/include/configs/mybeaglebone.h:32:31: asm/arch/hardware.h:没有那个文件或目录 ___ U-Boot maili

[U-Boot] [PATCH] am335x-evm config: decrease bootdelay to 1s and mount rootfs RO

2012-09-26 Thread Koen Kooi
A fast boot is important to the beaglebone, so save 2 seconds here by decreasing bootdelay. This is still plenty time to break into the prompt, I do that at least once a day. Mount the rootfs RO by default, this is needed to make fsck succeed without resorting to an initramfs. Signed-off-by: Koen

[U-Boot] [PATCH] ARM: arm1176: Define arch_cpu_init() for s3c64xx

2012-09-26 Thread Ashok Kumar Reddy
>From 0de61b9690c5f136ba5d3028be43877ea455d843 Mon Sep 17 00:00:00 2001 From: Ashok Kumar Reddy Date: Wed, 26 Sep 2012 23:44:59 +0530 Subject: [PATCH] ARM: arm1176: Define arch_cpu_init() for s3c64xx arch_cpu_init() is removed from cpu level to SOC level for arm1176 in commit 4ea6d6b,the same is

Re: [U-Boot] [PATCH V1 1/3] phy: add phy_connect_by_mask

2012-09-26 Thread Troy Kisky
On 9/26/2012 10:26 AM, Joe Hershberger wrote: Hi Troy, On Wed, Aug 22, 2012 at 4:21 PM, Troy Kisky wrote: On 8/22/2012 1:40 PM, Andy Fleming wrote: 1) Modify the driver so that the PHY address is passed in from board initialization code programmatically. As a nod to the effort of doing so f

Re: [U-Boot] [PATCH] am33xx: Enable DDR3 for DDR3 version of beaglebone

2012-09-26 Thread Jason Kridner
On Tue, Sep 25, 2012 at 12:49 PM, Joel A Fernandes wrote: > DDR3 support is tested and working with beaglebone hardware. Include a check > for this board type and configure DDR3. The timings and other configuration > match EVM SK. > > Signed-off-by: Joel A Fernandes Acked-by: Jason Kridner > -

Re: [U-Boot] [PATCH V1 1/3] phy: add phy_connect_by_mask

2012-09-26 Thread Joe Hershberger
Hi Troy, On Wed, Aug 22, 2012 at 4:21 PM, Troy Kisky wrote: > On 8/22/2012 1:40 PM, Andy Fleming wrote: >> >> >> >> 1) Modify the driver so that the PHY address is passed in from board >> initialization code programmatically. As a nod to the effort of doing >> so for all boards, you can create a

Re: [U-Boot] [PATCH 2/3 V2] common: Implement support for linker-generated arrays

2012-09-26 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek, > > In message <201209252224.32686.ma...@denx.de> you wrote: > > > > ... Such array though can > > > > > > > > later be accessed and used via special accessor. > > > > > > Can you please translate this to me? I don't get

Re: [U-Boot] [PATCH 0/6] add zip command support for uboot

2012-09-26 Thread Tom Rini
On Wed, Sep 26, 2012 at 05:34:25PM +0200, Marek Vasut wrote: > Dear Lei Wen, > > > On Thu, Sep 6, 2012 at 6:49 PM, Marek Vasut wrote: > > > Dear Lukasz Majewski, > > > > > > [...] > > > > > > > > Ok, that means we can make use of this command ? > > > > > > > > I cannot promise, that I will pro

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Marek Vasut
Dear Łukasz Dałek, > On 26.09.2012 17:29, Marek Vasut wrote: > > Dear Lukasz Dalek, > > > >> Basic support of HP iPAQ h2200 palmtop. Support includes also USB > >> ethernet gadget. > > > > Two minor nits ... can you extend the patch description? > > > >> Signed-off-by: Lukasz Dalek > >> [...] >

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Łukasz Dałek
On 26.09.2012 17:29, Marek Vasut wrote: Dear Lukasz Dalek, Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget. Two minor nits ... can you extend the patch description? Signed-off-by: Lukasz Dalek [...] +h2200arm pxa +h2200_usbeth

Re: [U-Boot] [PATCH 0/6] add zip command support for uboot

2012-09-26 Thread Marek Vasut
Dear Lei Wen, > On Thu, Sep 6, 2012 at 6:49 PM, Marek Vasut wrote: > > Dear Lukasz Majewski, > > > > [...] > > > > > > Ok, that means we can make use of this command ? > > > > > > I cannot promise, that I will provide the "zip" support straightaway in > > > the DFU. > > > > > > On the one han

Re: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Marek Vasut
Dear Lukasz Dalek, > Basic support of HP iPAQ h2200 palmtop. Support includes also USB > ethernet gadget. Two minor nits ... can you extend the patch description? > Signed-off-by: Lukasz Dalek > [...] > +h2200arm pxa > +h2200_usbeth arm p

Re: [U-Boot] KernelDoc

2012-09-26 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek, > > In message <201209252246.10322.ma...@denx.de> you wrote: > > I've had a discussion with Wolfgang just now about U-Boot coding style. I > > tried using KernelDoc in a patch, which is not part of the U-Boot Coding > > Style now, thus it was rejected. > > > > I

Re: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

2012-09-26 Thread Marek Vasut
Dear Lukasz Dalek, > PXA25x gadget implements common function usb_disconnect(). > This patch adds this function prototype into usb.h for boards using it. [...] > +/* > + * This isn't host > + */ The comment doesn't need to be multiline. It'd be cool if it was meaningful ... like "pxa25x can on

[U-Boot] R: Configure a Numonyx Axcell M29EW on a MPC8323 board

2012-09-26 Thread SETTE AGOSTINO - technolabs
Hi Stefano, yes, the macro MEG_TO_AM () should work on my SOC (I see it is used on MPC8323RDB, my hw is quite similar to this one). Thanks for your support Best regards, Agostino -Messaggio originale- Da: Stefano Babic [mailto:sba...@denx.de] Inviato: mercoledì 26 settembre 2012 16.4

Re: [U-Boot] Configure a Numonyx Axcell M29EW on a MPC8323 board

2012-09-26 Thread Stefano Babic
On 25/09/2012 08:59, SETTE AGOSTINO - technolabs wrote: > Hi all, > > > (2 << BR_PS_SHIFT) | /* 16 bit port size */ \ > > BR_V) /* valid */ > > @ > > #define CONFIG_SYS_OR0_PRELIM 0x7ff7 /* 512MB Flash size */ Without checking the manual, this seems wrong. It seems to me that the timing i

Re: [U-Boot] Problems with a P2020 board

2012-09-26 Thread Joakim Tjernlund
Kumar Gala wrote on 2012/09/26 15:39:48: > > > On Sep 26, 2012, at 7:09 AM, Joakim Tjernlund wrote: > > > Joakim Tjernlund/Transmode wrote on 2012/08/30 15:12:08: > >> > >>> > >>> Hi. > >>> > >>> We have a new board which we are suing with U-boot. The CPU is a P2020. > >>> I am having a few mino

Re: [U-Boot] [PATCH v3 6/8] fdt: cmd_fdt: Call fdt_chosen() from "fdt boardsetup"

2012-09-26 Thread Stefan Roese
Hi Kumar, On 09/26/2012 03:36 PM, Kumar Gala wrote: >> By calling fdt_chosen(), the chosen node will be updated / >> created by the "fdt boardsetup" command. This is useful for >> setting of the kernel commandline via the "bootargs" >> env variable. >> >> With this change, the "fdt boardsetup" can

Re: [U-Boot] bootm command in U-boot

2012-09-26 Thread Wolfgang Denk
Dear Manukumar, [excessive Cc: list truncated] In message <1348656159.2591.4.camel@Manukumar> you wrote: > > bootm command will modify the dts/dtb file's memory section, and pass > the memory size into Kernel by dts/dtb file. It does this, and more things, depending on architecture and board.

[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

2012-09-26 Thread Lukasz Dalek
PXA25x gadget implements common function usb_disconnect(). This patch adds this function prototype into usb.h for boards using it. Signed-off-by: Lukasz Dalek --- include/usb.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/usb.h b/include/usb.h index ba3d

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

2012-09-26 Thread Lukasz Dalek
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget. Signed-off-by: Lukasz Dalek --- board/h2200/Makefile | 51 board/h2200/h2200-header.S | 27 ++ board/h2200/h2200.c| 66 +++ boards.cfg |2 + inc

Re: [U-Boot] Problems with a P2020 board

2012-09-26 Thread Kumar Gala
On Aug 30, 2012, at 2:56 AM, Mark Marshall wrote: > - Timer Interrupts seem to stop. Once U-boot has started the timer > interrupts seem to stop. I have added a test command that prints out > the timestamp variable (from arch/powerpc/lib/interrupts.c). I can > see that when we enter the

Re: [U-Boot] Problems with a P2020 board

2012-09-26 Thread Kumar Gala
On Sep 26, 2012, at 7:09 AM, Joakim Tjernlund wrote: > Joakim Tjernlund/Transmode wrote on 2012/08/30 15:12:08: >> >>> >>> Hi. >>> >>> We have a new board which we are suing with U-boot. The CPU is a P2020. >>> I am having a few minor problems, and I was hoping to get some help. >>> >>> -

Re: [U-Boot] [PATCH v3 6/8] fdt: cmd_fdt: Call fdt_chosen() from "fdt boardsetup"

2012-09-26 Thread Kumar Gala
On Sep 26, 2012, at 4:11 AM, Stefan Roese wrote: > By calling fdt_chosen(), the chosen node will be updated / > created by the "fdt boardsetup" command. This is useful for > setting of the kernel commandline via the "bootargs" > env variable. > > With this change, the "fdt boardsetup" can be use

Re: [U-Boot] Problems with a P2020 board

2012-09-26 Thread Joakim Tjernlund
Joakim Tjernlund/Transmode wrote on 2012/08/30 15:12:08: > > > > > Hi. > > > > We have a new board which we are suing with U-boot. The CPU is a P2020. > > I am having a few minor problems, and I was hoping to get some help. > > > > - Boot Count. We are keen to use the boot counter feature,

[U-Boot] [PATCH v4 3/8] env: Enable getenv_f() for SPL_BUILD

2012-09-26 Thread Stefan Roese
With this patch, getenv_f() can be included easily into the SPL binary. With this, SPL boards can now use getenv_f() to read environment variables (e.g. to detect if the OS or U-Boot shall be executed). In the approach this is done for env stored in NOR flash, as this will be used by an upcoming M

Re: [U-Boot] [PATCH v3 3/8] env: Extract getenv_f() into separate source file

2012-09-26 Thread Stefan Roese
On 09/26/2012 11:01 AM, Stefan Roese wrote: > By extracting getenv_f and envmatch() from cmd_nvedit.c into a > separate file, getenv_f() can be included easily into the SPL > binary. With this, SPL boards can now use getenv_f() to read > environment variables (e.g. to detect if the OS or U-Boot sha

[U-Boot] bootm command in U-boot

2012-09-26 Thread Manukumar
Dear all I have a query on bootm command. In the link provided below: http://www.linuxquestions.org/questions/linux-kernel-70/how-kernel-figure-out-ddr-ram-size-when-bootargss-mem-not-specified-948165/ They have given: bootm command will modify the dts/dtb file's memory section, and pass the memo

Re: [U-Boot] [PATCH v8] [RFC] early_malloc for DM added.

2012-09-26 Thread Tomas Hlavacek
Hello Graeme, On Wed, Sep 26, 2012 at 1:04 AM, Graeme Russ wrote: > Hi Tomas > > On Tue, Sep 25, 2012 at 7:09 PM, Graeme Russ wrote: > >> We should implement each of malloc(), free(), calloc(), and realloc(). >> >> Don't worry about reclaiming and reusing space with a proper free() >> implementa

Re: [U-Boot] KernelDoc

2012-09-26 Thread Wolfgang Denk
Dear Prabhakar Lad, In message you wrote: > > > Could you please explain what exactly your vote is supposed to mean? > > > My vote was for using kerneldoc to annotate functions and generate > documentation ... > Readability of the code will increase. Which sort of documentation would you want

[U-Boot] [PATCH v3 8/8] Makefile: Add target for combined spl/u-boot.bin & u-boot.img

2012-09-26 Thread Stefan Roese
This new make target "u-boot-img.bin" consists of the U-Boot SPL image with the real, full-blown U-Boot image directly attached to it. The full-blown U-Boot image has the mkimage header included, with its load-address and entry-point. This will be used by the upcoming a3m071 MPC5200 board port. S

[U-Boot] [PATCH v3 7/8] Makefile: Add possibility to set entry-point for u-boot.img

2012-09-26 Thread Stefan Roese
This patch enabled boards using the SPL framework to set an entry point in the U-Boot mkimage image "u-boot.img". Until now the entry point in the header has been set to 0. By setting CONFIG_SYS_UBOOT_START in the board header, boards can override this default location. This will be used by the up

[U-Boot] [PATCH v3 6/8] fdt: cmd_fdt: Call fdt_chosen() from "fdt boardsetup"

2012-09-26 Thread Stefan Roese
By calling fdt_chosen(), the chosen node will be updated / created by the "fdt boardsetup" command. This is useful for setting of the kernel commandline via the "bootargs" env variable. With this change, the "fdt boardsetup" can be used to prepare the DT blob for SPL booting. The patched DT blob c

[U-Boot] [PATCH v3 5/8] mpc5200: Add a3m071 board support

2012-09-26 Thread Stefan Roese
This patch adds support for the a3m071 board based on the MPC5200. Signed-off-by: Stefan Roese --- Changes in v2: - Rebased on Tom's SPL framework patches v4 - a3m071 build: Concat SPL binary and u-boot.img directly (no padding) MAINTAINERS | 2 + board/a3m071/Makefile

[U-Boot] [PATCH v3 4/8] mpc5200: Add SPL support

2012-09-26 Thread Stefan Roese
This patch adds SPL booting support (NOR flash) for the MPC5200 platforms. Signed-off-by: Stefan Roese --- Changes in v2: - Rebased on Tom's SPL framework patches v4 Changes in v3: - Don't use special MPC5xxx memcpy in SPL - Move linker symbols to header spl.h (checkpatch) arch/powerpc/cpu/mpc

[U-Boot] [PATCH v3 3/8] env: Extract getenv_f() into separate source file

2012-09-26 Thread Stefan Roese
By extracting getenv_f and envmatch() from cmd_nvedit.c into a separate file, getenv_f() can be included easily into the SPL binary. With this, SPL boards can now use getenv_f() to read environment variables (e.g. to detect if the OS or U-Boot shall be executed). In the approach this is done for e

[U-Boot] [PATCH v3 2/8] SPL: Port SPL framework to powerpc

2012-09-26 Thread Stefan Roese
This patch enables the SPL framework to be used on powerpc platforms and not only ARM. Signed-off-by: Stefan Roese --- Changes in v2: - Rebased on Tom's SPL framework patches v4 - Add option to skip copying of the mkimage header arch/powerpc/lib/Makefile | 1 + arch/powerpc/lib/spl.c| 42 +

[U-Boot] [PATCH v3 1/8] powerpc: Extract EPAPR_MAGIC constants into processor.h

2012-09-26 Thread Stefan Roese
By extracting these defines into a header, they can be re-used by other C sources as well. This will be done by the SPL framework OS boot support. Signed-off-by: Stefan Roese --- arch/powerpc/include/asm/processor.h | 6 ++ arch/powerpc/lib/bootm.c | 6 -- 2 files changed, 6

[U-Boot] [PATCH v3 0/8] SPL: Port SPL framework to powerpc

2012-09-26 Thread Stefan Roese
This patchset ports the SPL framework to powerpc. Its based on the SPL generalization lately done by Tom Rini. The patches can be applied on top of his 7th version located here: http://github.com/trini/u-boot WIP/spl-improvements Additionally, a new MPC5200 board port is included, the a3m071 boa

[U-Boot] [PATCH v1 3/4] km83xx: add common support for km8309 boards

2012-09-26 Thread Gerlando Falauto
Add support for Keymile boards based on mpc8309 (it would be only kmvect1 for now) Signed-off-by: Gerlando Falauto --- board/keymile/km83xx/km83xx.c |2 +- include/configs/km/km8309-common.h | 174 include/configs/km/km83xx-common.h |6 ++ 3 fil

[U-Boot] [PATCH v1 2/4] mpc83xx: add support for mpc8309

2012-09-26 Thread Gerlando Falauto
This processor, though very similar to other members of the PowerQUICC II Pro family (namely 8308, 8360 and 832x), provides yet another feature set than any supported sibling. So we add a bunch of new #ifdefs (or complicate the existing ones) to arch/powerpc/cpu/mpc83xx/speed.c. Perhaps it would

[U-Boot] [PATCH v1 4/4] km83xx: add kmvect1 board

2012-09-26 Thread Gerlando Falauto
Add support for the new kmvect1 board powered by the mpc8309 processor. As this board is very similar to the existing suvd3, instead of adding a new config header file, just add a new config option to suvd3.h Signed-off-by: Gerlando Falauto --- boards.cfg |3 ++- include/configs

[U-Boot] [PATCH v1 1/4] cosmetic: suvd3: align #defines

2012-09-26 Thread Gerlando Falauto
Signed-off-by: Gerlando Falauto --- include/configs/km/km8321-common.h |2 +- include/configs/suvd3.h|4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/configs/km/km8321-common.h b/include/configs/km/km8321-common.h index 580b72f..8ad6fc3 100644 -

[U-Boot] [PATCH v1 0/4] introducing vect1: mpc8309 keymile board

2012-09-26 Thread Gerlando Falauto
This patch series adds support for VECT1, an mpc8309-powered Keymile board. MPC8309 is not currently supported by u-boot, so we first add support for this processor. VECT1 is somewhat similar to suvd3, albeit powered by a different processor, so we use its config file as opposed to introducing a ne

Re: [U-Boot] [PATCH v4 2/2] ARM: kirkwood/orion5x: Use reset_cpu definition in include/common.h

2012-09-26 Thread Prafulla Wadaskar
> -Original Message- > From: u-boot-boun...@lists.denx.de [mailto:u-boot- > boun...@lists.denx.de] On Behalf Of Pavel Machek > Sent: 25 September 2012 17:57 > To: dingu...@altera.com > Cc: ma...@denx.de; dinh.li...@gmail.com; cl...@altera.com; u- > b...@lists.denx.de; tr...@ti.com; s...@d

  1   2   >