Re: [U-Boot] [PATCH resend 2/2] arm/boards: Define a new config option CONFIG_BOOT_PARAMS_P

2012-12-17 Thread Vipin Kumar
On 12/7/2012 8:17 PM, Wolfgang Denk wrote: Dear Vipin Kumar, In message50c1b9a6.1020...@st.com you wrote: Can you please suggest what is the best way here. Wolfgang, Albert ? I don't like this patch at all. It introduces yet more architecture specific stuff to lib/board.c, while we

Re: [U-Boot] [STATUS] v2013.01-rc2 released

2012-12-17 Thread Christian Riesch
Hi Tom, On Fri, Dec 14, 2012 at 10:52 PM, Tom Rini tr...@ti.com wrote: Hey all, I've tagged and pushed v2013.01-rc2 now. The next branch has been open for a little bit, and is still open now, and in sync. Here's where we're at: - I expect a USB pull request from Marek soon. - I've

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-17 Thread Vipin Kumar
On 12/15/2012 12:29 AM, Scott Wood wrote: On 12/14/2012 03:23:26 AM, Vipin Kumar wrote: On 12/14/2012 3:22 AM, Scott Wood wrote: On 12/13/2012 12:10:58 AM, Vipin Kumar wrote: + imgdata = malloc(read_size); + if (!imgdata) { +

[U-Boot] [PATCH v4] imls: Add support to list images in NAND device

2012-12-17 Thread Vipin Kumar
This patch adds support to list images in NAND flash through imls Signed-off-by: Vipin Kumar vipin.ku...@st.com --- Changes in v4 - Keep stdout dumps in one line - Continue even after read errors for all the blocks README | 3 +- common/cmd_bootm.c | 167

Re: [U-Boot] UBI Fixable bit-flip issue.

2012-12-17 Thread Holger Brunck
Hi, On 12/15/2012 04:14 AM, Vikram Narayanan wrote: On 12/14/2012 11:33 PM, Vikram Narayanan wrote: I'm seeing a fixable bit-flip in the current u-boot (v2012.10) on a i.Mx6 Solo based custom board. The problem is similar to the one explained here [1]. As observed by the thread's author,

[U-Boot] [PATCH] usb/host/ehci: Add support for EHCI on spear

2012-12-17 Thread Vipin Kumar
Add EHCI support for spear boards Signed-off-by: Armando Visconti armando.visco...@st.com Signed-off-by: Vipin Kumar vipin.ku...@st.com --- drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci-spear.c | 59 +++ 2 files changed, 60 insertions(+)

[U-Boot] [PATCH] usbtty: adapt buffers for large packet support

2012-12-17 Thread Vipin Kumar
From: Shiraz Hashim shiraz.has...@st.com Increase buffer sizes at driver and tty level to accommodate kermit large packet support. Signed-off-by: Shiraz Hashim shiraz.has...@st.com --- drivers/serial/usbtty.c | 2 +- include/usbdevice.h | 4 +++- 2 files changed, 4 insertions(+), 2

Re: [U-Boot] [STATUS] v2013.01-rc2 released

2012-12-17 Thread Jens Scharsig
Am 2012-12-14 22:52, schrieb Tom Rini: In my TODO list in patchwork, nothing strikes me as new feature posted before the merge window closed. I see a few bug fixes I might pull in, or might sit on to make sure they don't cause surprises. It's of course possible I missed something, or

Re: [U-Boot] [PATCH resend] armv7/ltimer: Add support for local timer on armv7 cpus

2012-12-17 Thread Armando Visconti
Ciao Vipin, Yes, I agree about the need to have the generic local_timer support in u-boot. Internally I was not able to give comment about this part. So, see my comments now. On 12/06/2012 10:22 AM, Vipin KUMAR wrote: Certain ARMV7 cpus eg. CortexA9 contains a local and a global timer within

[U-Boot] [PATCH 5/9] EXYNOS5: DWMMC: API to set mmc clock divisor

2012-12-17 Thread Amar
This API computes the divisor value based on MPLL clock and writes it into the FSYS1 register. Signed-off-by: Amar amarendra...@samsung.com --- arch/arm/cpu/armv7/exynos/clock.c | 39 ++- arch/arm/include/asm/arch-exynos/clk.h |1 + 2 files changed, 38

[U-Boot] [PATCH 6/9] SMDK5250: Enable DWMMC

2012-12-17 Thread Amar
This patch enables DWMMC for SMDK5250. Support both dt and non-dt versions. Signed-off-by: Amar amarendra...@samsung.com --- board/samsung/smdk5250/smdk5250.c | 36 include/configs/exynos5250-dt.h |9 + 2 files changed, 41 insertions(+), 4

[U-Boot] [PATCH 7/9] MMC: APIs to support creation of boot partition

2012-12-17 Thread Amar
This pathc adds APIs to open, close and to create boot partiton for eMMC. Signed-off-by: Amar amarendra...@samsung.com --- drivers/mmc/mmc.c | 118 + include/mmc.h | 16 +++ 2 files changed, 134 insertions(+), 0 deletions(-) diff

[U-Boot] [PATCH 8/9] SMDK5250: Enable eMMC booting

2012-12-17 Thread Amar
This patch adds support for eMMC booting on SMDK5250 Signed-off-by: Amar amarendra...@samsung.com --- board/samsung/smdk5250/spl_boot.c | 38 - 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/board/samsung/smdk5250/spl_boot.c

[U-Boot] [PATCH 9/9] COMMON: MMC: Command to support eMMC booting

2012-12-17 Thread Amar
This patch adds commands to open, close and create partitions on eMMC Signed-off-by: Amar amarendra...@samsung.com --- common/cmd_mmc.c | 101 +- 1 files changed, 100 insertions(+), 1 deletions(-) diff --git a/common/cmd_mmc.c

[U-Boot] [PATCH 1/9] FDT: Add compatible string for DWMMC

2012-12-17 Thread Amar
Add required compatible information for DWMMC driver. Signed-off-by: Amar amarendra...@samsung.com --- include/fdtdec.h |1 + lib/fdtdec.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/fdtdec.h b/include/fdtdec.h index 539bb1b..f09c281 100644 ---

[U-Boot] [PATCH 0/9] EXYNOS5: Enable dwmmc

2012-12-17 Thread Amar
This patch set enables and initialises dwmmc for Exynos5250 on SMDK5250. Adds driver changes required for dwmmc. Adds dt support for dwmmc. Adds eMMC booting feature for SMDK5250. This patch set is based on: EXYNOS: mmc: support DesignWare Controller for Samsung-SoC, which is merged in

[U-Boot] [PATCH 2/9] EXYNOS5: FDT: Add DWMMC device node data

2012-12-17 Thread Amar
Add DWMMC device node data for exynos5 Signed-off-by: Amar amarendra...@samsung.com --- arch/arm/dts/exynos5250.dtsi | 32 + board/samsung/dts/exynos5250-smdk5250.dts | 24 + 2 files changed, 56 insertions(+), 0 deletions(-) diff

[U-Boot] [PATCH 4/9] EXYNOS5: DWMMC: Added dt support for DWMMC

2012-12-17 Thread Amar
Signed-off-by: Amar amarendra...@samsung.com --- arch/arm/include/asm/arch-exynos/dwmmc.h |4 + drivers/mmc/exynos_dw_mmc.c | 117 -- include/dwmmc.h |4 + 3 files changed, 119 insertions(+), 6 deletions(-) diff --git

Re: [U-Boot] [PULL] u-boot-usb/master

2012-12-17 Thread Lukasz Majewski
Hi Marek, Pantelis Antoniou (9): g_dnl: Issue connect/disconnect as appropriate g_dnl: Properly terminate string list. dfu: Only perform DFU board_usb_init() for TRATS dfu: Fix crash when wrong number of arguments given dfu: Send correct DFU response from

Re: [U-Boot] [PULL] u-boot-usb/master

2012-12-17 Thread Pantelis Antoniou
Lukasz, I'll sent the dump in a couple of hours. Been busy with other work items... Regards -- Pantelis On Dec 17, 2012, at 1:00 PM, Lukasz Majewski wrote: Hi Marek, Pantelis Antoniou (9): g_dnl: Issue connect/disconnect as appropriate g_dnl: Properly terminate string list.

Re: [U-Boot] [PATCH 1/4] arm/km: fix memory settings

2012-12-17 Thread Holger Brunck
Hi Prafulla, On 11/02/2012 11:15 AM, Holger Brunck wrote: On kmcoge5un we faced some serious problems with the memory during temperature tests. Reason was that we overwrite some registers for memory settings which have to leave untouched. These where registers 0x20148 , 0x2014c and 0x20154.

Re: [U-Boot] [PATCH 1/4] arm/km: fix memory settings

2012-12-17 Thread Prafulla Wadaskar
-Original Message- From: Holger Brunck [mailto:holger.bru...@keymile.com] Sent: 17 December 2012 18:13 To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; albert.u.b...@aribaud.net; Longchamp, Valentin Subject: Re: [PATCH 1/4] arm/km: fix memory settings Hi Prafulla, On

Re: [U-Boot] [PULL] u-boot-usb/master

2012-12-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/17/12 06:00, Lukasz Majewski wrote: Hi Marek, Pantelis Antoniou (9): g_dnl: Issue connect/disconnect as appropriate g_dnl: Properly terminate string list. dfu: Only perform DFU board_usb_init() for TRATS dfu: Fix crash when wrong number

Re: [U-Boot] [PATCH 05/10] dfu: Only perform DFU board_usb_init() for TRATS

2012-12-17 Thread Tom Rini
On Wed, Nov 28, 2012 at 03:47:43PM +0100, Lukasz Majewski wrote: Hi Pantelis, USB initialization shouldn't happen for all the boards. The board_usb_init() follows u-boot policy, that SoC IPs (USB) are enabled and configured just before their usage. Going back to this old thread as I

Re: [U-Boot] [PULL] u-boot-usb/master

2012-12-17 Thread Pantelis Antoniou
Hi Lukasz, Sorry for the slight delay, setting up the usb capture took a bit longer. So we have two captures; one named bad (which is the tip of our internal tree with the commit reverted. cee8b859fdb9edc68c67624b2fa1c97a65d121e7 dfu: Send correct DFU response from composite_setup With the

Re: [U-Boot] [PULL] u-boot-usb/master

2012-12-17 Thread Marek Vasut
Dear Tom Rini, On 12/17/12 06:00, Lukasz Majewski wrote: Hi Marek, Pantelis Antoniou (9): g_dnl: Issue connect/disconnect as appropriate g_dnl: Properly terminate string list. dfu: Only perform DFU board_usb_init() for TRATS dfu: Fix crash when wrong number of arguments given dfu:

Re: [U-Boot] [PATCH] usb/host/ehci: Add support for EHCI on spear

2012-12-17 Thread Marek Vasut
Dear Vipin Kumar, Add EHCI support for spear boards Signed-off-by: Armando Visconti armando.visco...@st.com Signed-off-by: Vipin Kumar vipin.ku...@st.com [...] Applied, thanks! Best regards, Marek Vasut ___ U-Boot mailing list

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Tom Rini
On Fri, Dec 14, 2012 at 06:54:05PM -0600, Scott Wood wrote: SPL doesn't use the environment. These list entries prevent the functions from being garbage-collected, even though nothing will look at the list. This caused several SPL builds (e.g. P2020RDB-PC_NAND) to break due to size

Re: [U-Boot] please pull u-boot-samsung/resolve

2012-12-17 Thread Minkyu Kang
Dear Albert, On Saturday, December 15, 2012, Albert ARIBAUD wrote: Hi Minkyu, On Fri, 14 Dec 2012 09:14:11 +0900, Minkyu Kang mk7.k...@samsung.comjavascript:; wrote: On 14/12/12 04:56, Albert ARIBAUD wrote: Hi Minkyu, On Tue, 11 Dec 2012 20:10:06 +0900, Minkyu Kang

Re: [U-Boot] [PATCH] input: Add MELFAS mms144 touchscreen driver

2012-12-17 Thread Wolfgang Denk
Dear Donghwa Lee, In message 50ce7957.6070...@samsung.com you wrote: From: Sanggun Leesg0724@samsung.com This is a TSP driver for touchscreen chip mms144 of MELFAS. It uses soft I2C interface and supports single touch. This driver uses polling method. If there are touch events,

Re: [U-Boot] [PULL] u-boot-usb/master

2012-12-17 Thread Lukasz Majewski
Hi Pantelis, Thanks for logs. I will go through them and let you know. First thing, which I see, that needs to be done is upgrading dfu-util (from dfu-util version 0.1+svnexported to dfu-util 0.7) Hi Lukasz, Sorry for the slight delay, setting up the usb capture took a bit longer. So

Re: [U-Boot] [PATCH 05/10] dfu: Only perform DFU board_usb_init() for TRATS

2012-12-17 Thread Lukasz Majewski
Hi Tom, On Wed, Nov 28, 2012 at 03:47:43PM +0100, Lukasz Majewski wrote: Hi Pantelis, USB initialization shouldn't happen for all the boards. The board_usb_init() follows u-boot policy, that SoC IPs (USB) are enabled and configured just before their usage. Going back to

Re: [U-Boot] [PATCH 05/10] dfu: Only perform DFU board_usb_init() for TRATS

2012-12-17 Thread Tom Rini
On Mon, Dec 17, 2012 at 12:37 PM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Tom, On Wed, Nov 28, 2012 at 03:47:43PM +0100, Lukasz Majewski wrote: Hi Pantelis, USB initialization shouldn't happen for all the boards. The board_usb_init() follows u-boot policy, that SoC IPs

Re: [U-Boot] [PULL] u-boot-usb/master

2012-12-17 Thread Pantelis Antoniou
Hi Lukasz, Absolutely no chance with a different version of dfu-util: $ sudo ./src/dfu-util -v -D ~/test.img -a rootfs dfu-util 0.7 Copyright 2005-2008 Weston Schmidt, Harald Welte and OpenMoko Inc. Copyright 2010-2012 Tormod Volden and Stefan Schmidt This program is Free Software and has

Re: [U-Boot] [PATCH resend] armv7/ltimer: Add support for local timer on armv7 cpus

2012-12-17 Thread Wolfgang Denk
Dear Dennis Lan (dlan), In message CAF1ZMEcVWc3DNdcb7gQ60D-8Nx-MHOpkLs=ey0ph2w_lgco...@mail.gmail.com you wrote: What would be the use of such timer support? Is there any code that actually needs it, and why does it need anything beyond the existing timer support we have? I think

Re: [U-Boot] [PATCH resend] armv7/ltimer: Add support for local timer on armv7 cpus

2012-12-17 Thread Wolfgang Denk
Dear Vipin Kumar, In message 50ce9e90.1090...@st.com you wrote: Dennis is right. I am trying to provide the armv7 local timer support. Why would we need such? And how is the term local defined here? Local to what? Well, actually the local timer was used in the spear13xx support which is

Re: [U-Boot] UBI Fixable bit-flip issue.

2012-12-17 Thread Vikram Narayanan
Hi, On 12/17/2012 2:14 PM, Holger Brunck wrote: Hi, On 12/15/2012 04:14 AM, Vikram Narayanan wrote: On 12/14/2012 11:33 PM, Vikram Narayanan wrote: I'm seeing a fixable bit-flip in the current u-boot (v2012.10) on a i.Mx6 Solo based custom board. The problem is similar to the one explained

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Scott Wood
On 12/17/2012 08:52:59 AM, Tom Rini wrote: On Fri, Dec 14, 2012 at 06:54:05PM -0600, Scott Wood wrote: SPL doesn't use the environment. These list entries prevent the functions from being garbage-collected, even though nothing will look at the list. This caused several SPL builds (e.g.

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/17/12 13:53, Scott Wood wrote: On 12/17/2012 08:52:59 AM, Tom Rini wrote: On Fri, Dec 14, 2012 at 06:54:05PM -0600, Scott Wood wrote: SPL doesn't use the environment. These list entries prevent the functions from being garbage-collected,

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Wolfgang Denk
Dear Tom, In message 50cf6ea8.4050...@ti.com you wrote: Since I'd assume 'sort' in make isn't sort -u, I'm not sure how it's filtering out the dupes unless we don't really need it afterall, am335x_evm builds with CONFIG_SPL_NET_SUPPORT enabled. I'm curious now, so I'm poking it. Wrong

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/17/12 14:55, Wolfgang Denk wrote: Dear Tom, In message 50cf6ea8.4050...@ti.com you wrote: Since I'd assume 'sort' in make isn't sort -u, I'm not sure how it's filtering out the dupes unless we don't really need it afterall, am335x_evm

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Joe Hershberger
Hi Tom, On Mon, Dec 17, 2012 at 1:58 PM, Tom Rini tr...@ti.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/17/12 14:55, Wolfgang Denk wrote: Dear Tom, In message 50cf6ea8.4050...@ti.com you wrote: Since I'd assume 'sort' in make isn't sort -u, I'm not sure how it's

Re: [U-Boot] [PATCH v2 08/58] ixp: Move timestamp to arch_global_data

2012-12-17 Thread Simon Glass
Hi Marek, On Fri, Dec 14, 2012 at 5:31 AM, Marek Vasut ma...@denx.de wrote: Dear Simon Glass, Move this field into arch_global_data and tidy up. Signed-off-by: Simon Glass s...@chromium.org I think we should kill IXP. Did the IXP custodian show any activity? If not, let's just remove this

Re: [U-Boot] [PATCH] ns16550: allow UART address to be set dynamically

2012-12-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/14/12 17:26, Wolfgang Denk wrote: Dear Tom Rini, In message 50cb8ed1.7020...@ti.com you wrote: The other part is, take a look at the Allwinner thread from a week or so ago. We really need to define how we want early board specific data

Re: [U-Boot] [PATCH] ns16550: allow UART address to be set dynamically

2012-12-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/14/12 17:45, Stephen Warren wrote: On 12/14/2012 03:22 PM, Simon Glass wrote: Hi Stephen, ... Perhaps I can make the point another way. Assuming that the SOC in question is ARM-based and has Linux support it either supports FDT now or

Re: [U-Boot] [PATCH] ns16550: allow UART address to be set dynamically

2012-12-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/14/12 17:22, Simon Glass wrote: [snip] Perhaps I can make the point another way. Assuming that the SOC in question is ARM-based and has Linux support it either supports FDT now or presumably will fairly soon. We found that some of the

Re: [U-Boot] Conflicting commits for seaboard USB keyboard handling

2012-12-17 Thread Tom Warren
Allen, If you come up with patches to fix the seaboard config files, I can add them to my copy of u-boot-tegra/master, push it to denx, and generate a pull request for Albert if you want. Tom On Sat, Dec 15, 2012 at 9:41 AM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hi Allen, On Tue,

Re: [U-Boot] Conflicting commits for seaboard USB keyboard handling

2012-12-17 Thread Allen Martin
On Mon, Dec 17, 2012 at 02:13:29PM -0800, Tom Warren wrote: Allen, If you come up with patches to fix the seaboard config files, I can add them to my copy of u-boot-tegra/master, push it to denx, and generate a pull request for Albert if you want. The conflicting changes have already been

Re: [U-Boot] [PATCH] ns16550: allow UART address to be set dynamically

2012-12-17 Thread Stephen Warren
On 12/17/2012 02:09 PM, Tom Rini wrote: On 12/14/12 17:45, Stephen Warren wrote: On 12/14/2012 03:22 PM, Simon Glass wrote: Hi Stephen, ... Perhaps I can make the point another way. Assuming that the SOC in question is ARM-based and has Linux support it either supports FDT now or presumably

Re: [U-Boot] [PATCH] ns16550: allow UART address to be set dynamically

2012-12-17 Thread Wolfgang Denk
Dear Stephen Warren, In message 50cf9baa.3050...@wwwdotorg.org you wrote: There are many ways besides device tree to enumerate hardware. For example, consider PCI or USB (albeit USB isn't memory mapped). I don't Yes, there are. But your console port cannot be compred against dynamically

Re: [U-Boot] [PATCH] ns16550: allow UART address to be set dynamically

2012-12-17 Thread Stephen Warren
On 12/17/2012 03:37 PM, Wolfgang Denk wrote: Dear Stephen Warren, In message 50cf9baa.3050...@wwwdotorg.org you wrote: There are many ways besides device tree to enumerate hardware. For example, consider PCI or USB (albeit USB isn't memory mapped). I don't Yes, there are. But your

Re: [U-Boot] [PATCH v3] imls: Add support to list images in NAND device

2012-12-17 Thread Scott Wood
On 12/17/2012 02:22:40 AM, Vipin Kumar wrote: On 12/14/2012 11:40 PM, Scott Wood wrote: On 12/14/2012 03:32:04 AM, Vipin Kumar wrote: + + switch (genimg_get_format(buffer)) { + case IMAGE_FORMAT_LEGACY: + header = (const

Re: [U-Boot] [PATCH v3] imls: Add support to list images in NAND device

2012-12-17 Thread Vipin Kumar
On 12/18/2012 5:35 AM, Scott Wood wrote: On 12/17/2012 02:22:40 AM, Vipin Kumar wrote: On 12/14/2012 11:40 PM, Scott Wood wrote: On 12/14/2012 03:32:04 AM, Vipin Kumar wrote: + + switch (genimg_get_format(buffer)) { + case IMAGE_FORMAT_LEGACY: + header = (const image_header_t *)buffer; + len

[U-Boot] RFC: Secure boot framework

2012-12-17 Thread Fernandes, Joel A
Hi, Can anyone comment on what has been discussed about a framework for secure boot and authentication, if there has been such a discussion, in the community? I have some U-boot code that is based off of a slightly older U-boot which does authentication and/or decryption. The main code that

Re: [U-Boot] [PATCH] ns16550: allow UART address to be set dynamically

2012-12-17 Thread Wolfgang Denk
Dear Stephen, In message 50cfa394.40...@wwwdotorg.org you wrote: Yes, there are. But your console port cannot be compred against dynamically populated and scannable bus interfaces like USB or PCI, and I think you are aware of that. I honestly don't know why you couldn't have a

[U-Boot] [PATCH] net/phy: fix select line for TN80xx

2012-12-17 Thread Shaohui Xie
TN80xx has same PHY ID as TN2020, but it needs different setting to register 30.93 which used to select line, so we read register 30.32 which has bit 15:12 to indicate PHY hardware version, for TN20xx we will get 3 or 2, for TN80xx we will get 5 or 4. Signed-off-by: Shaohui Xie

Re: [U-Boot] RFC: Secure boot framework

2012-12-17 Thread Simon Glass
Hi Joel, On Mon, Dec 17, 2012 at 9:11 PM, Fernandes, Joel A joelag...@ti.com wrote: Hi, Can anyone comment on what has been discussed about a framework for secure boot and authentication, if there has been such a discussion, in the community? I have some U-boot code that is based off of a

Re: [U-Boot] [PATCH 0/7] omap mmc: implement card detect and write protection

2012-12-17 Thread Nikita Kiryanov
Gentle ping. On 12/03/2012 02:19 PM, Nikita Kiryanov wrote: This patchset implements card detection and write protection check for omap mmc. The write protect implementation also adds generic code that is usable by other mmc drivers. The first 3 patches are preparation patches that contain