Re: [U-Boot] [PATCH v3 05/13] sf: Make flash->flags use for generic usage

2015-09-14 Thread Bin Meng
Hi Jagan, On Wed, Sep 2, 2015 at 2:09 PM, Jagan Teki wrote: > Use the flash->flags for generic usage, not only for dm-spi-flash, > this will be used for future flag additions. > > Signed-off-by: Jagan Teki > Cc: Bin Meng > --- This v3 commit still breaks Intel Crown Bay. I've tested on latest

Re: [U-Boot] [PATCH 27/28] video: input: Clean up after i8042 conversion

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > Now that i8042 uses driver model, adjust other mentions of it and remove old > code that is no-longer used. Update the README and unify the keyboard text > into one place. > > Signed-off-by: Simon Glass > --- > > README |

Re: [U-Boot] [PATCH 12/28] i8042: Adjust kbd_reset() to collect all failures

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > Rather than lots of 'return' statements, use goto to a single return. > > Signed-off-by: Simon Glass > --- > > drivers/input/i8042.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/input/i8042.c

Re: [U-Boot] [PATCH 10/28] i8042: Use functions to handle register access

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > At present the register access in kbd_reset() is quite primitive. This makes > it hard to follow. > > Create functions to read and write data, both to a single register, and via > the command/data approach. > > Signed-off-by: Simon Glass > ---

Re: [U-Boot] [PATCH 09/28] video: Drop unused console functions

2015-09-14 Thread Bin Meng
Hi Simon, On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > CONFIG_CONSOLE_CURSOR, CONFIG_SYS_CONSOLE_BLINK_COUNT and > CONFIG_CONSOLE_TIME are not used by any board. The implementation is not > great and stands in the way of a refactor of i8042. Drop these for now. > They can be re-introduce

Re: [U-Boot] [PATCH 26/28] input: Convert i8042 to driver model

2015-09-14 Thread Bin Meng
Hi Simon, On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > Adjust this driver to support driver model. The only users are x86 boards > so this should be safe. > > Signed-off-by: Simon Glass > --- After updating QEMU to use the DM i8042 driver below: diff --git a/arch/x86/dts/qemu-x86_i440

Re: [U-Boot] [PATCH 03/28] input: Return -ENOSPC when there is not space

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > Return a useful error instead of -1 when something goes wrong. > > Signed-off-by: Simon Glass > --- > > drivers/input/input.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/input.c b/drivers/input/inp

Re: [U-Boot] [PATCH 25/28] Drop CONFIG_ISA_KEYBOARD

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > This option is mentioned but does not do anything. Drop it. > > Signed-off-by: Simon Glass > --- > > README | 11 ++- > board/mpl/pip405/README | 4 > include/configs/MIP405.h | 5 - > include/configs/PIP

Re: [U-Boot] [PATCH 24/28] x86: Add an i8042 device for boards that have it

2015-09-14 Thread Bin Meng
Hi Simon, On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > Some boards have an i8042 device. Enable the driver for all x86 boards, and > add a device tree node for those which may have this keyboard. > > Also adjust the configuration so that i8042 is always separate from the VGA, > and renam

Re: [U-Boot] [PATCH 23/28] input: Add a Kconfig option for the i8042 keyboard

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > Add a new option CONFIG_I8042_KEYB which will replace the current > CONFIG_I8042_KBD. This new name fits better with existing drivers. > > Signed-off-by: Simon Glass > --- > > drivers/input/Kconfig | 10 ++ > 1 file changed, 10 insert

Re: [U-Boot] [PATCH 18/28] input: Support the German keymap

2015-09-14 Thread Bin Meng
Hi Simon, On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > Add support for the German keymap, taken from i8042.c. This can be selected > when the input library it initialised. > > Signed-off-by: Simon Glass > --- > > board/kosagi/novena/novena.c | 2 +- > drivers/input/cros_ec_keyb.c | 2

Re: [U-Boot] [PATCH 22/28] input: i8042: Convert to use the input library

2015-09-14 Thread Bin Meng
Hi Simon, On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > At present the i8042 driver has its own logic and keymaps. In an effort to > unify the code, move it over to use the input library. This changes most of > the keycode-processing logic since it is now in that library. The main > respo

Re: [U-Boot] [PATCH 13/28] i8042: Adjust keyboard init to assume success

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > Modify i8042_kbd_init() so that the normal pass is sucessful init and > failure exits early. This will make the code easier to extend and is easier > to read. > > Signed-off-by: Simon Glass > --- > > drivers/input/i8042.c | 19 +--

Re: [U-Boot] [PATCH 15/28] input: Add a few more keyboard keycodes

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > The slash and * are missing from the keycode tables. Add these so that nits: there are two spaces before 'slash' > these keypad keys can be used. > > Signed-off-by: Simon Glass > --- > > drivers/input/input.c | 6 +++--- > 1 file changed,

Re: [U-Boot] [PATCH 11/28] i8042: Handle a duplicate power-on-reset response

2015-09-14 Thread Bin Meng
Hi Simon, On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > Sometimes we seem to get 0xaa twice which causes the config read to fail. > This causes chromebook_link to fail to set up the keyboard. > > Add a check for this and read the config again when detected. > > Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH 06/28] dm: stdio: Plumb in the new keyboard uclass

2015-09-14 Thread Bin Meng
Hi Simon, On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > When driver model is used for keyboards we must scan the available keyboards > and register them with stdio. Add code to do this. > > At some point (once LCD/video is converted) we should be able to convert > stdio to driver model an

Re: [U-Boot] [PATCH 04/28] input: Add the keycode translation tables separately

2015-09-14 Thread Bin Meng
Hi Simon, On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > Require the caller to add the keycode translation tables separately so that > it can select which ones to use. In a later patch we will add the option to > add German tables. > > Signed-off-by: Simon Glass > --- > > board/kosagi/no

Re: [U-Boot] [PATCH 01/28] dm: input: Create a keyboard uclass

2015-09-14 Thread Bin Meng
Hi Simon, On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > Add a uclass for keyboard input, mirroring the existing stdio methods. > This is enabled by a new CONFIG_DM_KEYBOARD option. > > Signed-off-by: Simon Glass > --- > > common/usb_kbd.c| 6 --- > drivers/input/Kconfig

Re: [U-Boot] [PATCH 02/28] input: Add a device pointer to the input config

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: > The read_keys() method in input is passed a struct input_config. Add a > device pointer there so that we can find out the device that is referred > to with driver model. > > Once all drivers are converted we can update the input structure to us

[U-Boot] [PATCH v2 1/4] imx: mx7: discard unused global variable

2015-09-14 Thread Peng Fan
Discard unused global variable. Signed-off-by: Peng Fan Cc: Stefano Babic --- Changes V2: none arch/arm/cpu/armv7/mx7/soc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/cpu/armv7/mx7/soc.c b/arch/arm/cpu/armv7/mx7/soc.c index 8d50149..af16ba7 100644 --- a/arch/arm/cpu/armv7/

[U-Boot] [PATCH v2 4/4] imx: fix coding style

2015-09-14 Thread Peng Fan
Fix coding style. Signed-off-by: Peng Fan Cc: Stefano Babic --- Changes v2: none arch/arm/cpu/armv7/mx7/soc.c | 2 +- arch/arm/imx-common/init.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/cpu/armv7/mx7/soc.c b/arch/arm/cpu/armv7/mx7/soc.c index af16ba7

[U-Boot] [PATCH v2 3/4] imx: mx7dsabresd: drop code for CONFIG_CMD_BMODE

2015-09-14 Thread Peng Fan
We use outer pmic reset and drop internal reset signal, bmode will not work as expected, so drop boot mode code for 7dsabresd board. Signed-off-by: Peng Fan Cc: Stefano Babic Cc: Adrian Alonso --- Changes v2: refine commit msg. board/freescale/mx7dsabresd/mx7dsabresd.c | 14 --

[U-Boot] [PATCH v2 2/4] imx-common: wrap boot_mode_apply with CONFIG_CMD_BMODE

2015-09-14 Thread Peng Fan
boot_mode_apply should be applied only with CONFIG_CMD_BMODE enabled. Signed-off-by: Peng Fan Cc: Stefano Babic --- Changes v2: none arch/arm/imx-common/init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/imx-common/init.c b/arch/arm/imx-common/init.c index 56d5010..058cf79

Re: [U-Boot] [PATCH 1/2] nios2: remap and translate reg address in device tree

2015-09-14 Thread Thomas Chou
Hi Marek, On 09/13/2015 09:39 PM, Marek Vasut wrote: btw. It might be just about time to split the DT bits into nios2.dtsi and nios2_3c120_devboard.dts , where the former would contain the generic bits of the binding and the later would only fill in the necessary address ranges and such. I do un

Re: [U-Boot] [PATCH 1/3] mmc: fsl_esdhc: enable dat[4:7] for eMMC4.5

2015-09-14 Thread Lu Y . B .
> On 09/14/2015 07:22 PM, Lu Yangbo-B47093 wrote: > > Hi York, > > > > Please see my comments below. > > > >> -Original Message- > >> From: Sun York-R58495 > >> Sent: Monday, September 14, 2015 11:57 PM > >> To: Lu Yangbo-B47093; u-boot@lists.denx.de > >> Subject: Re: [PATCH 1/3] mmc: fsl_e

Re: [U-Boot] [PATCH 1/3] mmc: fsl_esdhc: enable dat[4:7] for eMMC4.5

2015-09-14 Thread Lu Y . B .
Hi York, Please see my comments below. > -Original Message- > From: Sun York-R58495 > Sent: Monday, September 14, 2015 11:57 PM > To: Lu Yangbo-B47093; u-boot@lists.denx.de > Subject: Re: [PATCH 1/3] mmc: fsl_esdhc: enable dat[4:7] for eMMC4.5 > > Yangbo, > > On 09/13/2015 08:04 PM, Yan

[U-Boot] Trouble configuring DHCP vs. BOOTP

2015-09-14 Thread Michael Binder
Hi, I am brand new to U-Boot, sorry for what may be basic questions. I am also new to my company - 2 months. I am an experienced embedded C/C++ developer. I have never worked with Android. I have some network experience, like configuring my home system, etc. I have some experience with Linux/Unix

[U-Boot] [PATCH] kbuild: fixdep: drop meaningless hash table initialization

2015-09-14 Thread Masahiro Yamada
The clear_config() is called just once at the beginning of this program, but the global variable hashtab[] is already zero-filled at the start-up. [ Linux commit: d179e22762fd38414c4108acedd5feca4cf7e0d8 ] Signed-off-by: Masahiro Yamada Signed-off-by: Michal Marek --- This is imported from Li

Re: [U-Boot] [PATCH 1/3] net: phy: Don't create phy device when there is no phy

2015-09-14 Thread Bin Meng
Hi Joe, On Sat, Sep 12, 2015 at 3:44 AM, Joe Hershberger wrote: > Hi Bin, > > On Fri, Sep 4, 2015 at 6:56 AM, Bin Meng wrote: >> In get_phy_device_by_mask(), when no phy is found, we should not >> create any phy device. >> >> Signed-off-by: Bin Meng > > Acked-by: Joe Hershberger What about th

Re: [U-Boot] Galileo instructions

2015-09-14 Thread Bin Meng
Hi Simon, On Tue, Sep 15, 2015 at 10:15 AM, Simon Glass wrote: > Hi Bin, > > On 14 September 2015 at 20:06, Bin Meng wrote: >> >> Hi Simon, >> >> On Tue, Sep 15, 2015 at 9:52 AM, Simon Glass wrote: >> > Hi Bin, >> > >> > On 14 September 2015 at 08:32, Bin Meng wrote: >> >> Hi Simon, >> >> >> >

Re: [U-Boot] [PATCH 1/3] mmc: fsl_esdhc: enable dat[4:7] for eMMC4.5

2015-09-14 Thread York Sun
On 09/14/2015 07:22 PM, Lu Yangbo-B47093 wrote: > Hi York, > > Please see my comments below. > >> -Original Message- >> From: Sun York-R58495 >> Sent: Monday, September 14, 2015 11:57 PM >> To: Lu Yangbo-B47093; u-boot@lists.denx.de >> Subject: Re: [PATCH 1/3] mmc: fsl_esdhc: enable dat

Re: [U-Boot] Galileo instructions

2015-09-14 Thread Simon Glass
Hi Bin, On 14 September 2015 at 20:06, Bin Meng wrote: > > Hi Simon, > > On Tue, Sep 15, 2015 at 9:52 AM, Simon Glass wrote: > > Hi Bin, > > > > On 14 September 2015 at 08:32, Bin Meng wrote: > >> Hi Simon, > >> > >> On Mon, Sep 14, 2015 at 9:59 PM, Bin Meng wrote: > >>> Hi Simon, > >>> > >>>

Re: [U-Boot] Galileo instructions

2015-09-14 Thread Bin Meng
Hi Simon, On Tue, Sep 15, 2015 at 9:52 AM, Simon Glass wrote: > Hi Bin, > > On 14 September 2015 at 08:32, Bin Meng wrote: >> Hi Simon, >> >> On Mon, Sep 14, 2015 at 9:59 PM, Bin Meng wrote: >>> Hi Simon, >>> >>> On Mon, Sep 14, 2015 at 8:51 PM, Simon Glass wrote: Hi Bin, On 14

Re: [U-Boot] Galileo instructions

2015-09-14 Thread Simon Glass
Hi Bin, On 14 September 2015 at 08:32, Bin Meng wrote: > Hi Simon, > > On Mon, Sep 14, 2015 at 9:59 PM, Bin Meng wrote: >> Hi Simon, >> >> On Mon, Sep 14, 2015 at 8:51 PM, Simon Glass wrote: >>> Hi Bin, >>> >>> On 14 September 2015 at 06:49, Bin Meng wrote: Hi Simon, On Mon

Re: [U-Boot] [PATCH] x86: quark: Configure MTRR to enable cache

2015-09-14 Thread Simon Glass
On 14 September 2015 at 01:07, Bin Meng wrote: > Quark SoC does not support MSR MTRRs. Fixed and variable range MTRRs > are accessed indirectly via the message port and not the traditional > MSR mechanism. Only UC, WT and WB cache types are supported. > > We configure all the fixed range MTRRs wit

Re: [U-Boot] [PATCH 3/4] imx: mx7dsabresd: drop code for CONFIG_CMD_BMODE

2015-09-14 Thread Fabio Estevam
Hi Peng, On Mon, Sep 14, 2015 at 9:31 PM, Peng Fan wrote: > Hi Fabio, > On Mon, Sep 14, 2015 at 03:09:24PM -0300, Fabio Estevam wrote: >>Hi Peng, >> >>On Mon, Sep 14, 2015 at 6:08 AM, Peng Fan wrote: >>> Since i.MX7D does not support warm reset, so boot_mode_apply >>> actually will not work. Als

Re: [U-Boot] [PATCH 3/4] imx: mx7dsabresd: drop code for CONFIG_CMD_BMODE

2015-09-14 Thread Peng Fan
Hi Fabio, On Mon, Sep 14, 2015 at 03:09:24PM -0300, Fabio Estevam wrote: >Hi Peng, > >On Mon, Sep 14, 2015 at 6:08 AM, Peng Fan wrote: >> Since i.MX7D does not support warm reset, so boot_mode_apply >> actually will not work. Also we use outer pmic reset and drop >> internal reset signal, so drop

Re: [U-Boot] [PATCH] imximage: fix commands other than write_data

2015-09-14 Thread Fabio Estevam
On Mon, Sep 14, 2015 at 10:06 PM, Troy Kisky wrote: > When CHECK_BITS_SET was added, they forgot to add > a new command table, and instead overwrote the > previous table. > > Signed-off-by: Troy Kisky > > --- > > Note: this needs tested to make sure imx7dsabresd still boots > as its dcd header ha

[U-Boot] [PATCH] imximage: fix commands other than write_data

2015-09-14 Thread Troy Kisky
When CHECK_BITS_SET was added, they forgot to add a new command table, and instead overwrote the previous table. Signed-off-by: Troy Kisky --- Note: this needs tested to make sure imx7dsabresd still boots as its dcd header has changed diff --git a/tools/imximage.c b/tools/imximage.c index 0da

Re: [U-Boot] [PATCH 1/2] nios2: remap and translate reg address in device tree

2015-09-14 Thread Thomas Chou
Hi Stefan, On 09/14/2015 01:39 PM, Stefan Roese wrote: So you are changing the DT sources for your platform because the U-Boot implementation does support the bus translation correctly (ranges properties)? I think this is the wrong approach. We need to make sure that U-Boot supports DT correctly

Re: [U-Boot] [PATCH 09/14] armv8/ls1043ardb: Add nand boot support

2015-09-14 Thread Scott Wood
On Fri, 2015-09-11 at 19:07 +0800, Gong Qianyu wrote: > Signed-off-by: Gong Qianyu > Signed-off-by: Hou Zhiqiang > Signed-off-by: Shaohui Xie > Signed-off-by: Mingkai Hu > --- > arch/arm/Kconfig | 1 + > arch/arm/cpu/armv8/fsl-lsch2/Makefile | 1

Re: [U-Boot] [PATCH] smsc95xx: Use zero length packets when RX fifo is empty

2015-09-14 Thread Joe Hershberger
Hi Stefan, On Sun, Sep 13, 2015 at 11:45 AM, Stefan Bruens wrote: > On Tuesday 08 September 2015 08:56:12 Joe Hershberger wrote: >> On Mon, Sep 7, 2015 at 10:12 PM, Stefan Brüns >> >> wrote: >> > Using NAKs on empty RX fifo for bulk in transfers is the right choice >> > for a interrupt driven mo

Re: [U-Boot] [RESEND PATCH v3 1/5] net: expose eth_is_active() function to test network device state

2015-09-14 Thread Joe Hershberger
Hi Bernhard, On Mon, Sep 14, 2015 at 8:29 AM, Bernhard Nortmann wrote: > The previous eth_device struct returned by eth_get_dev() allowed > code to directly query the state member field. However, with > CONFIG_DM_ETH this data gets encapsulated (i.e. private), and > eth_get_dev() returns a udevic

Re: [U-Boot] [PATCH 12/13] sunxi: A13-Olinuxino: Enable the USB OTG controller

2015-09-14 Thread Maxime Ripard
On Sun, Sep 13, 2015 at 07:38:27PM +0200, Hans de Goede wrote: > >>The policy I'm thinking of (and which we are currently sorta following > >>wrt enabling USB_MUSB_HOST) is that on devices with no normal usb > >>ports we use USB_MUSB_HOST, so that people can interact with u-boot > >>without needing

Re: [U-Boot] [PATCH 3/4] imx: mx7dsabresd: drop code for CONFIG_CMD_BMODE

2015-09-14 Thread Fabio Estevam
Hi Peng, On Mon, Sep 14, 2015 at 6:08 AM, Peng Fan wrote: > Since i.MX7D does not support warm reset, so boot_mode_apply > actually will not work. Also we use outer pmic reset and drop > internal reset signal, so drop boot mode code for 7dsabresd board. Booting via bmode is working fine here. R

Re: [U-Boot] [PATCH v2 4/4] distro_bootcmd: Add support for booting from ubifs

2015-09-14 Thread Hans de Goede
Hi, On 01-09-15 22:13, Stephen Warren wrote: On 08/22/2015 11:04 AM, Hans de Goede wrote: From: Roy Spliet Under the assumptions of having a UBI volume called boot, containing a ubifs filesystem. Signed-off-by: Hans de Goede I'd expect the person in the "From:" line above to have an s-o-b

Re: [U-Boot] [PATCH v2 3/4] ubifs: Add generic fs support

2015-09-14 Thread Hans de Goede
Hi, On 01-09-15 22:03, Stephen Warren wrote: On 08/22/2015 11:04 AM, Hans de Goede wrote: Add generic fs support, so that commands like ls, load and test -e can be used on ubifs. @@ -530,6 +531,28 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str,

Re: [U-Boot] [PATCH v2 2/4] ubifs: Add functions for generic fs use

2015-09-14 Thread Hans de Goede
Hi, On 01-09-15 21:57, Stephen Warren wrote: On 08/22/2015 11:04 AM, Hans de Goede wrote: Implement the necessary functions for implementing generic fs support for ubifs. diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c +int ubifs_set_blk_dev(block_dev_desc_t *rbdd, disk_partition_t *info

[U-Boot] [PATCH v2 2/2] sunxi: Switch to using malloc_simple for the spl

2015-09-14 Thread Hans de Goede
common/dlmalloc.c is quite big, both in .text and .data usage. E.g. for a Mele_M9 sun6i board build this reduces .text from 0x4214 to 0x3b94 bytes, and .data from 0x54c to 0x144 bytes. Signed-off-by: Hans de Goede --- Changes in v2: -Call spl_init from board_init_f, so that it does not get called

[U-Boot] [PATCH v2 1/2] sunxi: Enable CONFIG_SPL_STACK_R

2015-09-14 Thread Hans de Goede
Select CONFIG_SPL_STACK_R for sunxi boards, this gives us much more room on the stack once we've the DRAM running. Besides being a good change to have on itself, this also paves the way for switching to using malloc_simple in the SPL which cuts of close to 4KiB of the SPL size. Signed-off-by: Han

Re: [U-Boot] [PATCH 1/3] mmc: fsl_esdhc: enable dat[4:7] for eMMC4.5

2015-09-14 Thread York Sun
Yangbo, On 09/13/2015 08:04 PM, Yangbo Lu wrote: > If adapter card type identification is supported for platform, we would > enable dat[4:7] for eMMC4.5 card. > > Signed-off-by: Yangbo Lu > Cc: York Sun > --- > board/freescale/common/qixis.h | 2 ++ > drivers/mmc/fsl_esdhc.c| 3 +++ >

[U-Boot] [PATCH 1/3] mx6ul_14x14_evk: Remove dead code

2015-09-14 Thread Fabio Estevam
iox74lv_set() is not used anywhere, so let's remove it. Signed-off-by: Fabio Estevam --- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 43 --- 1 file changed, 43 deletions(-) diff --git a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c b/board/freescale/mx6ul_14x14_

Re: [U-Boot] arm: mvebu: u-boot does not start on db-88f6820-gp

2015-09-14 Thread Stefan Eichenberger
Hi Stefan, On 09/11/2015 05:02 PM, Stefan Eichenberger wrote: Hi Stefan, On 09/11/2015 04:24 PM, Stefan Roese wrote: Hi Stefan, On 11.09.2015 15:50, Stefan Eichenberger wrote: On 09/04/2015 06:44 PM, Stefan Roese wrote: Unfortunately u-boot now hangs if I try to load an image from the SD-C

Re: [U-Boot] [PATCH] mtd: nand: fsmc: Fixes and cleanup for fsmc_nand_switch_ecc()

2015-09-14 Thread Scott Wood
On Mon, 2015-09-14 at 08:47 +0200, Stefan Roese wrote: > This patch addresses some comments raised by Scott in the last versions. > Here the changes in detail: > > - Removed __maybe_unused as its not needed > - Added check for strength == 4 and error out for the unsupported > ECC strength values

Re: [U-Boot] Galileo instructions

2015-09-14 Thread Bin Meng
Hi Simon, On Mon, Sep 14, 2015 at 9:59 PM, Bin Meng wrote: > Hi Simon, > > On Mon, Sep 14, 2015 at 8:51 PM, Simon Glass wrote: >> Hi Bin, >> >> On 14 September 2015 at 06:49, Bin Meng wrote: >>> >>> Hi Simon, >>> >>> On Mon, Sep 14, 2015 at 8:45 PM, Simon Glass wrote: >>> > Hi Bin, >>> > >>> >

[U-Boot] [PATCH v2] malloc_simple: Add support for switching to DRAM heap

2015-09-14 Thread Hans de Goede
malloc_simple uses a part of the stack as heap, initially it uses SYS_MALLOC_F_LEN bytes which typically is quite small as the initial stacks sits in SRAM and we do not have that much SRAM to work with. When DRAM becomes available we may switch the stack from SRAM to DRAM to give use more room. Th

Re: [U-Boot] [PATCH 1/2] mmc: dw_mmc: Increase timeout to 20 seconds

2015-09-14 Thread Marek Vasut
On Monday, September 14, 2015 at 01:22:20 PM, Lukasz Majewski wrote: > Hi Alexey, > > > Hi Marek, Lukasz, > > > > On Sun, 2015-09-13 at 16:00 +0200, Marek Vasut wrote: > > > On Sunday, September 13, 2015 at 12:03:18 PM, Lukasz Majewski wrote: > > > > Hi Marek, > > > > > > Hi, > > > > > > [...]

[U-Boot] [PATCH 1/2] imx: mx7: drop select CPU_V7 for board target

2015-09-14 Thread Peng Fan
drop select CPU_V7 for board target, since ARCH_MX7 selects CPU_V7. Signed-off-by: Peng Fan Cc: Stefano Babic --- arch/arm/cpu/armv7/mx7/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/cpu/armv7/mx7/Kconfig b/arch/arm/cpu/armv7/mx7/Kconfig index 892ffae..ea19e5c 100644 --- a

[U-Boot] [PATCH 2/2] imx: mx7dsabresd: drom SYS_SOC from board Kconfig

2015-09-14 Thread Peng Fan
We have defined this kconfig entry in arch/arm/cpu/armv7/mx7/Kconfig, no need to redefine it in board Kconfig. Signed-off-by: Peng Fan Cc: Stefano Babic --- board/freescale/mx7dsabresd/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/board/freescale/mx7dsabresd/Kconfig b/board/fre

Re: [U-Boot] [PATCH v2 0/3] sunxi: support FEL-provided environment vars and "fel" boot target

2015-09-14 Thread Hans de Goede
Hi, On 14-09-15 15:15, Bernhard Nortmann wrote: This patch series builds upon http://lists.denx.de/pipermail/u-boot/2015-September/226515.html http://lists.denx.de/pipermail/u-boot/2015-September/226688.html v2 combines the previous submissions, and adds some suggested fixes/changes. The sunxi

[U-Boot] [PATCH 2/3] mx6ul_14x14_evk: Staticize when possible

2015-09-14 Thread Fabio Estevam
Make the internal symbols static when possible. This prevents sparse build warnings. Signed-off-by: Fabio Estevam --- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c b/bo

[U-Boot] [PATCH 3/3] mx6ul_14x14_evk: Remove get_board_rev()

2015-09-14 Thread Fabio Estevam
get_board_rev() is not actually providing the board revision. It just returns the CPU revision instead. As the CPU revision is already printed on boot, there is no reason to have get_board_rev(), so let's remove it. Signed-off-by: Fabio Estevam --- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_e

Re: [U-Boot] Galileo instructions

2015-09-14 Thread Bin Meng
Hi Simon, On Mon, Sep 14, 2015 at 8:51 PM, Simon Glass wrote: > Hi Bin, > > On 14 September 2015 at 06:49, Bin Meng wrote: >> >> Hi Simon, >> >> On Mon, Sep 14, 2015 at 8:45 PM, Simon Glass wrote: >> > Hi Bin, >> > >> > On 13 September 2015 at 03:28, Bin Meng wrote: >> >> Hi Simon, >> >> >> >>

[U-Boot] [RESEND PATCH v3 3/5] net: avoid eth_unregister() call when function is unavailable

2015-09-14 Thread Bernhard Nortmann
CONFIG_NETCONSOLE causes common/bootm.c to call eth_unregister() for network device shutdown. However, with CONFIG_DM_ETH this function is no longer defined. This is a workaround to avoid the call in that case, and solely rely on eth_halt(). In case this is insufficient, a proper way to unregister

[U-Boot] [RESEND PATCH v3 5/5] sunxi: add NetConsole by default for Banana Pi/Pro

2015-09-14 Thread Bernhard Nortmann
Simon Glass and Joe Hershberger suggested adding at least one test case for the CONFIG_DM_ETH plus CONFIG_NETCONSOLE options. This patch enables NetConsole as a default for the "Banana Pi/Pro" sunxi boards. (By the nature of this patch it could probably be extended later to include all sunxi boar

[U-Boot] [RESEND PATCH v3 0/5] fix NetConsole for CONFIG_DM_ETH

2015-09-14 Thread Bernhard Nortmann
(I'm resending this as patch 1/5 is still requiring an ACK/NAK.) With the introduction of driver model and accompanying changes, outdated code in netconsole.c leads to compilation errors when both CONFIG_NETCONSOLE and CONFIG_DM_ETH are set. This is a series of patches to fix these issues and get

[U-Boot] [RESEND PATCH v3 4/5] net: support NETCONSOLE option via Kconfig

2015-09-14 Thread Bernhard Nortmann
This patch introduces CONFIG_NETCONSOLE as an option to the Kconfig system. Joe Hershberger pointed out that it may not be entirely free of problems, as many boards predating the driver model define this symbol directly via include files. In case they're not properly migrated, their NetConsole mig

[U-Boot] [RESEND PATCH v3 1/5] net: expose eth_is_active() function to test network device state

2015-09-14 Thread Bernhard Nortmann
The previous eth_device struct returned by eth_get_dev() allowed code to directly query the state member field. However, with CONFIG_DM_ETH this data gets encapsulated (i.e. private), and eth_get_dev() returns a udevice struct 'abstraction' instead. This breaks legacy code relying on the former be

[U-Boot] [RESEND PATCH v3 2/5] net: fix netconsole when CONFIG_DM_ETH is set

2015-09-14 Thread Bernhard Nortmann
This patch uses the eth_is_active() function to work around issues that prevented compilation with the newer driver model. Signed-off-by: Bernhard Nortmann Acked-by: Joe Hershberger --- Changes in v3: None Changes in v2: - add "net:" prefix to commit message drivers/net/netconsole.c | 14

[U-Boot] [PATCH v2 0/3] sunxi: support FEL-provided environment vars and "fel" boot target

2015-09-14 Thread Bernhard Nortmann
This patch series builds upon http://lists.denx.de/pipermail/u-boot/2015-September/226515.html http://lists.denx.de/pipermail/u-boot/2015-September/226688.html v2 combines the previous submissions, and adds some suggested fixes/changes. The sunxi-tool side of things is discussed here: https://www

[U-Boot] [PATCH v2 3/3] sunxi: add "fel" boot target

2015-09-14 Thread Bernhard Nortmann
This patch makes use of the previous changes to add a new "fel" boot target for sunxi boards. When booting via FEL, it's often desirable to work around the absence of other (usable) boot devices - or to be able to override them, deviating from the standard boot sequence. To achieve this, the "fel"

[U-Boot] [PATCH v2 2/3] sunxi: retrieve FEL-provided values to environment variables

2015-09-14 Thread Bernhard Nortmann
This patch extends the misc_init_r() function on sunxi boards to test for the presence of a suitable "sunxi" SPL header. If found, and the loader ("fel" utility) provided a non-zero value for the boot.scr address, then the corresponding environment variable fel_scriptaddr gets set. misc_init_r() a

[U-Boot] [PATCH v2 1/3] sunxi: (mksunxiboot) signature to indicate "sunxi" SPL variant

2015-09-14 Thread Bernhard Nortmann
This patch follows up on a discussion of ways to improve support for the sunxi FEL ("USB boot") mechanism, especially with regard to boot scripts, see: https://groups.google.com/d/msg/linux-sunxi/wBEGUoLNRro/rHGq6nSYCQAJ The idea is to convert the (currently unused) "pad" bytes in the SPL header i

Re: [U-Boot] [RFC PATCH 1/2] sunxi: retrieve FEL-provided values to environment variables

2015-09-14 Thread Bernhard Nortmann
Hi Ian, hello Hans! That's an interesting find, Ian - thank you. Unfortunately it seems that flagging our environment vars accordingly isn't enough (on its own) to prevent them from being written by "saveenv". I've been testing #define CONFIG_ENV_FLAGS_LIST_STATIC "fel_booted:bo,fel_scriptaddr:

Re: [U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings

2015-09-14 Thread Peng Fan
On Mon, Sep 14, 2015 at 09:11:30AM -0300, Fabio Estevam wrote: >On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: >> We should not simple use "writew(WCR_WDE, &wdog->wcr)" to set >> wcr, since this will override bits set before reset_cpu. >> >> Use clrsetbits_le32 instead of writew to fix this issu

Re: [U-Boot] Galileo instructions

2015-09-14 Thread Simon Glass
Hi Bin, On 14 September 2015 at 06:49, Bin Meng wrote: > > Hi Simon, > > On Mon, Sep 14, 2015 at 8:45 PM, Simon Glass wrote: > > Hi Bin, > > > > On 13 September 2015 at 03:28, Bin Meng wrote: > >> Hi Simon, > >> > >> On Sun, Sep 13, 2015 at 5:06 AM, Simon Glass wrote: > >>> Hi Bin, > >>> > >>>

Re: [U-Boot] Galileo instructions

2015-09-14 Thread Bin Meng
Hi Simon, On Mon, Sep 14, 2015 at 8:45 PM, Simon Glass wrote: > Hi Bin, > > On 13 September 2015 at 03:28, Bin Meng wrote: >> Hi Simon, >> >> On Sun, Sep 13, 2015 at 5:06 AM, Simon Glass wrote: >>> Hi Bin, >>> >>> I have a Galileo Gen 2 and am trying to get U-Boot to start on it. The >>> first

Re: [U-Boot] Galileo instructions

2015-09-14 Thread Simon Glass
Hi Bin, On 13 September 2015 at 03:28, Bin Meng wrote: > Hi Simon, > > On Sun, Sep 13, 2015 at 5:06 AM, Simon Glass wrote: >> Hi Bin, >> >> I have a Galileo Gen 2 and am trying to get U-Boot to start on it. The >> first problem I have is that the schematic says the chip is a W25Q64FV >> which I

Re: [U-Boot] [PATCH 1/2] nios2: remap and translate reg address in device tree

2015-09-14 Thread Simon Glass
+Stefan Hi, On 13 September 2015 at 07:39, Marek Vasut wrote: > On Sunday, September 13, 2015 at 10:32:09 AM, Thomas Chou wrote: >> As the io space remapping ioremap() and bridge address >> translation fdt_translate_address() are not usually used >> in u-boot driver model by dev_get_addr(). We w

Re: [U-Boot] [PATCH 07/10] debug_uart: Support board-specific UART initialisation

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass wrote: > Some boards need to set things up before the debug UART can be used. On > these boards a call to debug_uart_init() is insufficient. When this option > is enabled, the function board_debug_uart_init() will be called when > debug_uart_init() is ca

Re: [U-Boot] [PATCH 09/10] x86: Init the debug UART if enabled

2015-09-14 Thread Bin Meng
Hi Simon, On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass wrote: > If the debug UART is enabled, get it ready for use at the earliest possible > opportunity. This is not actually very early, but until we have a stack it > is difficult to make it work. > > Signed-off-by: Simon Glass > --- > > arch/x

Re: [U-Boot] [PATCH 10/10] x86: chromebook_link: Enable the debug UART

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass wrote: > Add support for the debug UART on link. This is useful for early debugging. > > Signed-off-by: Simon Glass > --- > > arch/x86/cpu/ivybridge/cpu.c | 7 +++ > configs/chromebook_link_defconfig | 10 +++--- > 2 files changed, 14 ins

Re: [U-Boot] [PATCH 08/10] debug_uart: Add an option to announce the debug UART

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass wrote: > It is useful to see a message from the debug UART early during boot so that > you know things are working. Add an option to enable this. The message will > be displayed as soon as debug_uart_init() is called. > > Signed-off-by: Simon Glass > --

Re: [U-Boot] [PATCH 05/10] dm: pci: Adjust pci_find_and_bind_driver() to return -EPERM

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass wrote: > The current code returns 0 even if it failed to find or bind a driver. The > caller then has to check the returned device to see if it is NULL. It is > better to return an error code in this case so that it is clear what > happened. > > Adjust t

Re: [U-Boot] [PATCH 06/10] debug_uart: Adjust the declaration of debug_uart_init()

2015-09-14 Thread Bin Meng
Hi Simon, On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass wrote: > We want to be able to add other common code to this function. So change the > driver's version to have an underscore before it, just like > _debug_uart_putc(). Define debug_uart_init() to call this version. > > Update all drivers to t

Re: [U-Boot] [PATCH 01/10] x86: chromebook_link: Expand early malloc() memory

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass wrote: > Now that PCI bridges are probed before relocation we need additional memory. > Each PCI bridge takes 240 bytes at present since it uses the same uclass as > the PCI controller. Probably we should split this out so that bridges have > their own u

Re: [U-Boot] [PATCH 04/10] dm: pci: Correct a few debug() statements

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass wrote: > One debug() statement is missing a newline. The other has a repeated word. > Fix these. > > Signed-off-by: Simon Glass > --- > > drivers/pci/pci-uclass.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/

Re: [U-Boot] [PATCH 02/10] malloc_simple: Add debug() information

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass wrote: > It's useful to get a a trace of memory allocations in early init. Add a > debug() call to provide that. It can be enabled by adding '#define DEBUG' > to the top of the file. > > Signed-off-by: Simon Glass > --- > > common/malloc_simple.c | 4 +

Re: [U-Boot] [PATCH 03/10] dm: pci: Tidy up auto-config error handling

2015-09-14 Thread Bin Meng
On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass wrote: > When the auto-configuration process fails for a device (generally due to > lack of memory) we should return the error correctly so that we don't > continue to try memory allocations which will fail. > > Adjust the code to check for errors and ab

Re: [U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings

2015-09-14 Thread Fabio Estevam
On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: > We should not simple use "writew(WCR_WDE, &wdog->wcr)" to set > wcr, since this will override bits set before reset_cpu. > > Use clrsetbits_le32 instead of writew to fix this issue. There is a typo here: it should be clrsetbits_le16.

Re: [U-Boot] [PATCH 3/3] imx: mx7dsabresd set wdog SRS bit

2015-09-14 Thread Fabio Estevam
On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: > We use trigger pmic reset to reset the board, so set bit SRS to > disable internal WDOG_RESET_B_DEB to make reset stable. > > Signed-off-by: Peng Fan > Cc: Stefano Babic > Cc: Fabio Estevam > Cc: Adrian Alonso Tested-by: Fabio Estevam __

Re: [U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings

2015-09-14 Thread Fabio Estevam
On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: > We should not simple use "writew(WCR_WDE, &wdog->wcr)" to set > wcr, since this will override bits set before reset_cpu. > > Use clrsetbits_le32 instead of writew to fix this issue. > > Signed-off-by: Peng Fan > Cc: Stefano Babic > Cc: Fabio Est

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-14 Thread Fabio Estevam
On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: > When setting iomux for a pin mux, there is no need to check mux_ctrl_ofs. > Also If still checking mux_ctrl_ofs, we have no chance to set iomux > for i.MX7D IOMUXC_LPSR_SW_MUX_CTL_PAD_GPIO1_IO00, because the mux_ctrl_ofs > for this register is 0.

Re: [U-Boot] mx7dsabresd board does not reset

2015-09-14 Thread Fabio Estevam
Hi Peng, On Mon, Sep 14, 2015 at 1:29 AM, Peng Fan wrote: > Hi Fabio, > > On Sun, Sep 13, 2015 at 01:11:57PM -0300, Fabio Estevam wrote: >>Hi Adrian, >> >>I noticed that the reset command fails on mx7sabresd board: >> >>=> reset >>resetting ... >>(it gets stuck here). > > I have patches to fix th

Re: [U-Boot] [RFC PATCH 2/2] sunxi: add "fel" boot target

2015-09-14 Thread Hans de Goede
Hi, On 14-09-15 13:42, Hans de Goede wrote: Supporting both boot.scr and uEnv.txt for FEL boot seems to be reasonably simple to me. You can even do it in a single patch series. As Hans suggests, please take care of the boot.scr case first. Then maybe introduce uEnv.txt support with an additiona

Re: [U-Boot] [RFC PATCH 2/2] sunxi: add "fel" boot target

2015-09-14 Thread Hans de Goede
Hi, On 14-09-15 12:33, Siarhei Siamashka wrote: On Fri, 11 Sep 2015 11:31:50 +0200 Bernhard Nortmann wrote: Hi! Am 10.09.2015 um 20:36 schrieb Hans de Goede: Hi, I would prefer to have this like this: "bootcmd_fel=" \ "if test -n ${fel_booted} && test -n ${fel_data_addr}; th

Re: [U-Boot] [PATCH 1/2] mmc: dw_mmc: Increase timeout to 20 seconds

2015-09-14 Thread Lukasz Majewski
Hi Alexey, > Hi Marek, Lukasz, > > On Sun, 2015-09-13 at 16:00 +0200, Marek Vasut wrote: > > On Sunday, September 13, 2015 at 12:03:18 PM, Lukasz Majewski wrote: > > > Hi Marek, > > > > Hi, > > > > [...] > > > > > > > > > Still we need to fix regression first with virtually > > > > > > infini

Re: [U-Boot] [PATCH 1/2] mmc: dw_mmc: Increase timeout to 20 seconds

2015-09-14 Thread Przemyslaw Marczak
Hi Alexey, On 09/14/2015 12:30 PM, Alexey Brodkin wrote: On Fri, 2015-09-11 at 23:45 +0200, Lukasz Majewski wrote: Hi Alexey, FWIW I faced similar problem even reading data. At least on one of my boards reading of ~8Mb file took ~1.7 seconds and so 1 second timeout was interrupting data exch

Re: [U-Boot] [RFC PATCH 2/2] sunxi: add "fel" boot target

2015-09-14 Thread Siarhei Siamashka
On Fri, 11 Sep 2015 11:31:50 +0200 Bernhard Nortmann wrote: > Hi! > > Am 10.09.2015 um 20:36 schrieb Hans de Goede: > > Hi, > > > > I would prefer to have this like this: > > > > "bootcmd_fel=" \ > > "if test -n ${fel_booted} && test -n ${fel_data_addr}; then " \ > > "ech

[U-Boot] [PATCH] api_storage: Fix non-first storage device enumeration

2015-09-14 Thread Andreas Färber
When enabling CONFIG_API and chain-loading GRUB2 on jetson-tk1, only the eMMC would show up as (hd0), but not the SD card, leading to GRUB not finding its configuration and modules, falling back to a rescue shell. This is because enum_ended would get set for !more after returning a cookie for the

  1   2   >