Re: [U-Boot] [PATCH v2] common: board_f: Dont relocate FDT incase of CONFIG_OF_EMBED

2015-11-26 Thread Bin Meng
On Fri, Nov 27, 2015 at 3:28 PM, Michal Simek wrote: > From: Siva Durga Prasad Paladugu > > Don't relocate fdt in case of CONFIG_OF EMBED as the fdt is > already embedded with u-boot image. Also update the fdt_blob > correctly in this case > > Signed-off-by: Siva Durga Prasad Paladugu > Signed-o

Re: [U-Boot] [PATCH v3 10/13] pci: Use a separate 'dev' variable for the PCI device

2015-11-26 Thread Bin Meng
On Fri, Nov 27, 2015 at 10:51 AM, Simon Glass wrote: > In the 'pci' command, add a separate variable to hold the PCI device. When > this code is converted to driver model, this variable will be used to hold a > struct udevice instead. > > Signed-off-by: Simon Glass > --- > > Changes in v3: > - Fi

Re: [U-Boot] [PATCH v3 09/13] pci: Use common functions to read/write config

2015-11-26 Thread Bin Meng
On Fri, Nov 27, 2015 at 10:51 AM, Simon Glass wrote: > Currently we use switch() and access PCI configuration via several > functions, one for each data size. Adjust the code to use generic functions, > where the data size is a parameter. > > Signed-off-by: Simon Glass > --- > > Changes in v3: >

Re: [U-Boot] [PATCH v3 08/13] pci: Tidy up function comments in cmd_pci.c

2015-11-26 Thread Bin Meng
Hi Simon, On Fri, Nov 27, 2015 at 10:51 AM, Simon Glass wrote: > The function comments use an old style and some are incorrect. Update them. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: > - Use 'Show' instead of 'Shows' in the the pci_header_show() function co

[U-Boot] [PATCH v2] common: board_f: Dont relocate FDT incase of CONFIG_OF_EMBED

2015-11-26 Thread Michal Simek
From: Siva Durga Prasad Paladugu Don't relocate fdt in case of CONFIG_OF EMBED as the fdt is already embedded with u-boot image. Also update the fdt_blob correctly in this case Signed-off-by: Siva Durga Prasad Paladugu Signed-off-by: Michal Simek Reviewed-by: Alexey Brodkin --- Changes in v2

[U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-11-26 Thread Chin Liang See
Enable SDMMC calibration to determine the best setting for drvsel and smplsel. Calibration will be triggered if the drvsel and smplsel node are not available in DTS. Signed-off-by: Chin Liang See Cc: Dinh Nguyen Cc: Dinh Nguyen Cc: Pavel Machek Cc: Marek Vasut Cc: Stefan Roese Cc: Pantelis A

[U-Boot] [PATCH v2 2/3] rockchip: mkimage: use imagename to select spl hdr & spl size

2015-11-26 Thread Jeffy Chen
Our chips may have different spl size and spl header, so use imagename(passed by "mkimage -n") to select them now. Signed-off-by: Jeffy Chen --- Changes in v2: None tools/rkcommon.c | 72 ++-- tools/rkcommon.h | 32 -

[U-Boot] [PATCH v2 0/3] Fix rockchip spl loader mkimage flow

2015-11-26 Thread Jeffy Chen
This series patch fix rockchip spl loader mkimage flow, use imagename to select spl loader size & tag for different chip. Changes in v2: - Fix some coding style Jeffy Chen (3): Revert "rockchip: Add max spl size & spl header configs" rockchip: mkimage: use imagename to select spl hdr & spl si

[U-Boot] [PATCH v2 3/3] rockchip: doc: add imagename

2015-11-26 Thread Jeffy Chen
We now using imagename to select rockchip's spl hdr & spl size. Signed-off-by: Jeffy Chen Acked-by: Simon Glass --- Changes in v2: None doc/README.rockchip | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/README.rockchip b/doc/README.rockchip index 874441c..b455

[U-Boot] [PATCH v2 1/3] Revert "rockchip: Add max spl size & spl header configs"

2015-11-26 Thread Jeffy Chen
This reverts commit 10b4615f9d7e177ec7fe644fbb2616e0e0956f6e Conflicts: tools/rkcommon.h Signed-off-by: Jeffy Chen --- Changes in v2: - Fix some coding style arch/arm/mach-rockchip/Kconfig| 15 --- arch/arm/mach-rockchip/rk3036/Kconfig | 6 -- arch/arm/mach-r

[U-Boot] [PATCH v1 2/3] rockchip: mkimage: use imagename to select spl hdr & spl size

2015-11-26 Thread Jeffy Chen
Our chips may have different spl size and spl header, so use imagename(passed by "mkimage -n") to select them now. Signed-off-by: Jeffy Chen --- tools/rkcommon.c | 69 ++-- tools/rkcommon.h | 32 +- tools/rkimage.c |

[U-Boot] [PATCH v1 1/3] Revert "rockchip: Add max spl size & spl header configs"

2015-11-26 Thread Jeffy Chen
This reverts commit 10b4615f9d7e177ec7fe644fbb2616e0e0956f6e Conflicts: tools/rkcommon.h Signed-off-by: Jeffy Chen --- arch/arm/mach-rockchip/Kconfig| 15 --- arch/arm/mach-rockchip/rk3036/Kconfig | 6 -- arch/arm/mach-rockchip/rk3288/Kconfig | 6 -- tool

[U-Boot] [PATCH v1 3/3] rockchip: doc: add imagename

2015-11-26 Thread Jeffy Chen
We now using imagename to select rockchip's spl hdr & spl size. Signed-off-by: Jeffy Chen --- doc/README.rockchip | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/README.rockchip b/doc/README.rockchip index 874441c..b455f6f 100644 --- a/doc/README.rockchip +++ b/d

[U-Boot] [PATCH v1 0/3] Fix rockchip spl loader mkimage flow

2015-11-26 Thread Jeffy Chen
This series patch fix rockchip spl loader mkimage flow, use imagename to select spl loader size & tag for different chip. Jeffy Chen (3): Revert "rockchip: Add max spl size & spl header configs" rockchip: mkimage: use imagename to select spl hdr & spl size rockchip: doc: add imagename ar

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Stefan Roese
Hi Simon, On 27.11.2015 05:01, Stefan Roese wrote: Hi Simon, On 26.11.2015 19:22, Simon Glass wrote: Hi Stefan, On 26 November 2015 at 10:12, Stefan Roese wrote: Hi Simon, On 26.11.2015 18:55, Simon Glass wrote: Hi Stefan, On 26 November 2015 at 09:47, Stefan Roese wrote: Hi Simon, On

[U-Boot] zynq: ps7_init_gpl.c

2015-11-26 Thread Hannes Schmelzer
hello, The ps7_init_gpl.c is some output from the xilinix vivado tool as hardware handoff. We compile this into our SPL. My question is how to deal with "scripts/checkpatch.pl" on this file. The scripts throughs a lot of errors. # scripts/checkpatch.pl -f board/xilinx/zynq/ZC702_hw_platform/

Re: [U-Boot] [PATCH] powerpc, mpc5xxx: fix missing bootflag init

2015-11-26 Thread Heiko Schocher
Hello Simon, Am 26.11.2015 um 18:49 schrieb Simon Glass: On 25 November 2015 at 01:46, Heiko Schocher wrote: since: commit: f05ad9ba "Add a way to skip relocation" tqm5200s board fails to boot. Reason is that board_init_f has a function parameter bootflag, which is not setup in in arch/powerp

Re: [U-Boot] [PATCH] common: mmc: unsigned char compared against 0

2015-11-26 Thread Peng Fan
Hi Simon, On Thu, Nov 26, 2015 at 06:51:58PM -0800, Simon Glass wrote: >Hi Peng, > >On 25 November 2015 at 01:16, Peng Fan wrote: >> "enable" is unsigned char type and its value will not be >> negative, so discard "enable < 0". >> >> Signed-off-by: Peng Fan >> Cc: Diego Santa Cruz >> Cc: Panteli

[U-Boot] Please pull from u-boot-i2c

2015-11-26 Thread Heiko Schocher
Hello Tom, please pull from u-boot-i2c master: The following changes since commit 71cbed31f4f123708b8b3397cb166155c4a71f66: am33xx: Remove serial_init in s_init for QSPI/NOR XIP boot (2015-11-23 11:01:53 -0500) are available in the git repository at: git://git.denx.de/u-boot-i2c.git mast

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Stefan Roese
Hi Simon, On 26.11.2015 19:22, Simon Glass wrote: Hi Stefan, On 26 November 2015 at 10:12, Stefan Roese wrote: Hi Simon, On 26.11.2015 18:55, Simon Glass wrote: Hi Stefan, On 26 November 2015 at 09:47, Stefan Roese wrote: Hi Simon, On 26.11.2015 17:48, Simon Glass wrote: Yes. I'm t

Re: [U-Boot] [PATCH v1 3/3] rockchip: doc: add imagename

2015-11-26 Thread Simon Glass
On 26 November 2015 at 16:43, Jeffy Chen wrote: > We now using imagename to select rockchip's spl hdr & spl size. > > Signed-off-by: Jeffy Chen > --- > > doc/README.rockchip | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Acked-by: Simon Glass __

Re: [U-Boot] [PATCH v1 2/3] rockchip: mkimage: use imagename to select spl hdr & spl size

2015-11-26 Thread Simon Glass
Hi Jeffy, On 26 November 2015 at 16:43, Jeffy Chen wrote: > Our chips may have different spl size and spl header, so > use imagename(passed by "mkimage -n") to select them now. > > Signed-off-by: Jeffy Chen > --- > > tools/rkcommon.c | 69 > +

Re: [U-Boot] [PATCH 1/2] rockchip: add CONFIG_SPL_ROCKCHIP_SERIAL

2015-11-26 Thread Simon Glass
Hi Lin, On 26 November 2015 at 19:35, Simon Glass wrote: > Hi Lin, > > On 19 November 2015 at 22:58, Lin Huang wrote: >> we can use this config to disable rockchip serial driver in SPL stage, >> since some rockchip soc sram size is small(rk3036 etc), so we don't >> want rockchip serial driver bu

Re: [U-Boot] [PATCH 2/2] rockchip: rk3036: enable CONFIG_DEBUG_UART, and use ns16550 uart driver

2015-11-26 Thread Simon Glass
On 19 November 2015 at 22:58, Lin Huang wrote: > enable this config so we use common uart function in SPL stage > > Signed-off-by: Lin Huang > --- > arch/arm/mach-rockchip/rk3036-board-spl.c | 6 ++ > configs/evb-rk3036_defconfig | 5 + > include/configs/rk3036_common.h

Re: [U-Boot] [PATCH 1/2] Revert "rockchip: Reconfigure the malloc based to point to system memory"

2015-11-26 Thread Simon Glass
On 22 November 2015 at 08:11, Simon Glass wrote: > On 22 November 2015 at 00:21, Sjoerd Simons > wrote: >> This patch was merged shortly before the v2015.10 as a minimal fix for >> booting on rockchip. Now that the patch series from Hans to do the >> relocation in generic code has been merged it

Re: [U-Boot] [PATCH 2/2] rockchip: Explicitely set CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN

2015-11-26 Thread Simon Glass
On 23 November 2015 at 01:50, Sjoerd Simons wrote: > On Sun, 2015-11-22 at 09:11 -0700, Simon Glass wrote: >> On 22 November 2015 at 00:21, Sjoerd Simons >> wrote: >> > Now that u-boot relocates the malloc area in SPL to SDRAM, with the >> > malloc area sitting below the SPL_STACK_R_ADDR the >> >

Re: [U-Boot] [PATCH 1/2] rockchip: add CONFIG_SPL_ROCKCHIP_SERIAL

2015-11-26 Thread Simon Glass
Hi Lin, On 19 November 2015 at 22:58, Lin Huang wrote: > we can use this config to disable rockchip serial driver in SPL stage, > since some rockchip soc sram size is small(rk3036 etc), so we don't > want rockchip serial driver build in SPL, but we still want use common > debug driver in SPL. > >

Re: [U-Boot] [PATCH] arm: socfpga: Remove fsloadcmd from environment

2015-11-26 Thread Stefan Roese
On 27.11.2015 03:27, Chin Liang See wrote: Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command. Signed-off-by: Chin Liang See Cc: Dinh Nguyen Cc: Dinh Nguyen Cc: Pavel Machek Cc: Marek Vasut Cc: Stefan Roese --- include/configs/

Re: [U-Boot] [PATCH v2] arm: socfpga: Enable load zImage and Linux DTB from USB

2015-11-26 Thread Stefan Roese
On 27.11.2015 03:36, Chin Liang See wrote: Adding new environment usbload which will load zImage and Linux DTB from USB mass storage through FAT file system. Signed-off-by: Chin Liang See Cc: Dinh Nguyen Cc: Dinh Nguyen Cc: Pavel Machek Cc: Marek Vasut Cc: Stefan Roese --- Changes for v2 -

[U-Boot] [PATCH v3 05/13] dm: pci: Rename pci_auto.c to pci_auto_old.c

2015-11-26 Thread Simon Glass
This file should not be used with driver model as it has lots of legacy/ compatibility functions. Rename it to make this clear. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: None Changes in v2: None drivers/pci/Makefile | 2 +- drivers/pci/{pci_auto

Re: [U-Boot] [PATCH] Implement pytest-based test infrastructure

2015-11-26 Thread Simon Glass
Hi Stephen, On 24 November 2015 at 13:28, Stephen Warren wrote: > On 11/24/2015 12:04 PM, Simon Glass wrote: >> >> Hi Stephen, >> >> On 23 November 2015 at 21:44, Stephen Warren >> wrote: >>> >>> On 11/23/2015 06:45 PM, Simon Glass wrote: On 22 November 2015 at 10:30, Stephen Warren >

Re: [U-Boot] [PATCH V2] common: cli_hush: avoid memory leak

2015-11-26 Thread Simon Glass
On 26 November 2015 at 18:12, Peng Fan wrote: > Need to free memory avoid memory leak, when error. > > Signed-off-by: Peng Fan > Reviewed-by: Simon Glass > Cc: Simon Glass > Cc: Tom Rini > --- > > Changes V2: > Take Simon's comments, fix another memory leak when child->argv is NULL. > Add Si

Re: [U-Boot] [PATCH] common: mmc: unsigned char compared against 0

2015-11-26 Thread Simon Glass
Hi Peng, On 25 November 2015 at 01:16, Peng Fan wrote: > "enable" is unsigned char type and its value will not be > negative, so discard "enable < 0". > > Signed-off-by: Peng Fan > Cc: Diego Santa Cruz > Cc: Pantelis Antoniou > Cc: Andrew Gabbasov > Cc: Simon Glass > Cc: Stefano Babic > Cc:

Re: [U-Boot] [PATCH v7 2/2] arm: move gd handling outside of C code

2015-11-26 Thread Simon Glass
On 25 November 2015 at 08:56, Albert ARIBAUD wrote: > As of gcc 5.2.1 for Thumb-1, it is not possible any > more to assign gd from C code, as gd is mapped to r9, > and r9 may now be saved in the prolog sequence, and > restored in the epilog sequence, of any C functions. > > Therefore arch_setup_gd

[U-Boot] [PATCH v3 07/13] dm: pci: Reorder functions in cmd_pci.c

2015-11-26 Thread Simon Glass
Before converting this to driver model, reorder the code to avoid forward function declarations. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: None Changes in v2: None common/cmd_pci.c | 216 +++ 1 file changed, 106 ins

Re: [U-Boot] [PATCH v7 1/2] Fix board init code to respect the C runtime environment

2015-11-26 Thread Simon Glass
Hi Albert, On 25 November 2015 at 08:56, Albert ARIBAUD wrote: > board_init_f_mem() alters the C runtime environment's > stack it is actually already using. This is not a valid > behaviour within a C runtime environment. > > Split board_init_f_mem into C functions which do not alter > their own s

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Simon Glass
Hi Jagan, On 26 November 2015 at 10:54, Jagan Teki wrote: > Hi Simon, > > Some how I'm unclear about your comments in previous series probably I > my misunderstanding or something. let me explain about my plan on > spi-nor development. > > The entire spi-flash code is generic for all means there

[U-Boot] [PATCH v3 11/13] pci: Move PCI header output code into its own function

2015-11-26 Thread Simon Glass
We want to share this code with the driver model version, so put it in a separate function. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: None Changes in v2: None common/cmd_pci.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/comm

[U-Boot] [PATCH v3 06/13] dm: pci: Move common auto-config functions to a common file

2015-11-26 Thread Simon Glass
Some functions will be used by driver model and legacy PCI code. To avoid duplication, put these in a separate, shared file. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: None Changes in v2: - Fix 'autoconfiguration' typo - Fix merge error in pciauto_setup_device() which r

[U-Boot] [PATCH v3 10/13] pci: Use a separate 'dev' variable for the PCI device

2015-11-26 Thread Simon Glass
In the 'pci' command, add a separate variable to hold the PCI device. When this code is converted to driver model, this variable will be used to hold a struct udevice instead. Signed-off-by: Simon Glass --- Changes in v3: - Fix 'switch (cmd)' merge error Changes in v2: - Refactor the patch base

[U-Boot] [PATCH v3 12/13] dm: pci: Convert 'pci' command to driver model

2015-11-26 Thread Simon Glass
Adjust this command to use the correct PCI functions, instead of the compatibility layer. Signed-off-by: Simon Glass Reviewed-by: Bin Meng Tested-by: Bin Meng --- Changes in v3: None Changes in v2: - Make pciinfo() static common/cmd_pci.c | 133 +++

[U-Boot] [PATCH v3 13/13] dm: pci: Disable PCI compatibility functions by default

2015-11-26 Thread Simon Glass
We eventually need to drop the compatibility functions for driver model. As a first step, create a configuration option to enable them and hide them when the option is disabled. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: None Changes in v2: - Drop patch: pci: Move 'pci

[U-Boot] [PATCH v3 09/13] pci: Use common functions to read/write config

2015-11-26 Thread Simon Glass
Currently we use switch() and access PCI configuration via several functions, one for each data size. Adjust the code to use generic functions, where the data size is a parameter. Signed-off-by: Simon Glass --- Changes in v3: - Fix mix-up between PCI_SIZE_xx and byte size Changes in v2: - Add b

[U-Boot] [PATCH v3 03/13] pci: Refactor the pciinfo() function

2015-11-26 Thread Simon Glass
This function uses macros to output data. It seems better to use a table of registers rather than macro-based code generation. It also reduces the code/data size by 2KB on ARM. Signed-off-by: Simon Glass Reviewed-by: Bin Meng Tested-by: Bin Meng --- Changes in v3: None Changes in v2: - Squash

[U-Boot] [PATCH v3 08/13] pci: Tidy up function comments in cmd_pci.c

2015-11-26 Thread Simon Glass
The function comments use an old style and some are incorrect. Update them. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: - Use 'Show' instead of 'Shows' in the the pci_header_show() function comment Changes in v2: - Add a new patch to update the function comments commo

[U-Boot] [PATCH v3 00/13] dm: pci: Support native driver model calls

2015-11-26 Thread Simon Glass
At present driver model supports PCI, but most of the code in U-Boot still uses the old API. This series changes the 'pci' command so that the new API is used. The old API is placed behind a 'compatibility' option. The overall goal is to deprecate the old API and remove all use of it. The auto-con

[U-Boot] [PATCH v3 01/13] pci: Use a common return in command processing

2015-11-26 Thread Simon Glass
Adjust the commands to return from the same place. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: None Changes in v2: None common/cmd_pci.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/common/cmd_pci.c b/common/cmd_pci.c index 2

[U-Boot] [PATCH v3 04/13] dm: pci: Add a comment about how to find struct pci_controller

2015-11-26 Thread Simon Glass
With driver mode, struct pci_controller is stored as uclass-private data. Add a comment to that effect. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: None Changes in v2: None include/pci.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/pci.h b/include/pci.

[U-Boot] [PATCH v3 02/13] pci: Use a separate variable for the bus number

2015-11-26 Thread Simon Glass
At present in do_pci(), bdf can either mean a bus number or a PCI bus number. Use separate variables instead to reduce confusion. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: None Changes in v2: None common/cmd_pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deleti

[U-Boot] [PATCH v2] arm: socfpga: Enable load zImage and Linux DTB from USB

2015-11-26 Thread Chin Liang See
Adding new environment usbload which will load zImage and Linux DTB from USB mass storage through FAT file system. Signed-off-by: Chin Liang See Cc: Dinh Nguyen Cc: Dinh Nguyen Cc: Pavel Machek Cc: Marek Vasut Cc: Stefan Roese --- Changes for v2 - Using load command instead of fatload --- i

[U-Boot] [PATCH] arm: socfpga: Remove fsloadcmd from environment

2015-11-26 Thread Chin Liang See
Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command. Signed-off-by: Chin Liang See Cc: Dinh Nguyen Cc: Dinh Nguyen Cc: Pavel Machek Cc: Marek Vasut Cc: Stefan Roese --- include/configs/socfpga_arria5_socdk.h | 1 - include/config

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Bin Meng
Hi Jagan, On Fri, Nov 27, 2015 at 2:54 AM, Jagan Teki wrote: > Hi Simon, > > Some how I'm unclear about your comments in previous series probably I > my misunderstanding or something. let me explain about my plan on > spi-nor development. > > The entire spi-flash code is generic for all means the

Re: [U-Boot] [PATCH] common: cli_hush: avoid memory leak

2015-11-26 Thread Peng Fan
Hi Simon, On Thu, Nov 26, 2015 at 09:49:38AM -0800, Simon Glass wrote: >Hi Peng, > >On 25 November 2015 at 02:16, Peng Fan wrote: >> Need to free memory avoid memory leak, when error. >> >> Signed-off-by: Peng Fan >> Cc: Simon Glass >> Cc: Tom Rini >> --- >> common/cli_hush.c | 4 +++- >> 1 fi

[U-Boot] [PATCH V2] common: cli_hush: avoid memory leak

2015-11-26 Thread Peng Fan
Need to free memory avoid memory leak, when error. Signed-off-by: Peng Fan Reviewed-by: Simon Glass Cc: Simon Glass Cc: Tom Rini --- Changes V2: Take Simon's comments, fix another memory leak when child->argv is NULL. Add Simon's review tag. common/cli_hush.c | 9 +++-- 1 file changed

[U-Boot] [PATCH] video: ipu: fix out of bounds access

2015-11-26 Thread Peng Fan
We need to access reg stp_rep9, but not stp_rep[(9 - 1) / 2]. If using "__raw_writel(0, DI_STP_REP(disp, 9))", this will exceeds the size of stp_rep array. Signed-off-by: Peng Fan Acked-by: Liu Ying Cc: Stefano Babic Cc: Anatolij Gustschin --- drivers/video/ipu_disp.c | 2 +- drivers/video/ip

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Bin Meng
Hi Jagan, On Thu, Nov 26, 2015 at 8:03 PM, Jagan Teki wrote: > This series is combination of mtd and sf tunning stuff in previous > version patches.[1][2] > > This is whole patch series for add mtd support to spi-flash > framework and related stuff. > > The idea is to introduce the spi-nor flash

Re: [U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from USB

2015-11-26 Thread Chin Liang See
Hi Stefan, On Thu, 2015-11-26 at 07:14 +0100, Stefan Roese wrote: > On 26.11.2015 04:17, Chin Liang See wrote: > > Adding new environment usbload which will load zImage and > > Linux DTB from USB mass storage through FAT file system. > > > > Signed-off-by: Chin Liang See > > Cc: Dinh Nguyen > >

Re: [U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from USB

2015-11-26 Thread Chin Liang See
Hi Marek, On Thu, 2015-11-26 at 12:04 +0100, Marek Vasut wrote: > On Thursday, November 26, 2015 at 07:14:56 AM, Stefan Roese wrote: > > On 26.11.2015 04:17, Chin Liang See wrote: > > > Adding new environment usbload which will load zImage and > > > Linux DTB from USB mass storage through FAT file

Re: [U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

2015-11-26 Thread Chin Liang See
Hi Marek, On Fri, 2015-11-27 at 02:27 +0100, Marek Vasut wrote: > On Friday, November 27, 2015 at 02:24:49 AM, Chin Liang See wrote: > > Hi Pavel, > > > > On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote: > > > Hi! > > > > > > > Adding new environment qspiload which will load zImage and > >

Re: [U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

2015-11-26 Thread Marek Vasut
On Friday, November 27, 2015 at 02:24:49 AM, Chin Liang See wrote: > Hi Pavel, > > On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote: > > Hi! > > > > > Adding new environment qspiload which will load zImage and > > > Linux DTB from serial NOR flash. The default flash offset for > > > the imag

Re: [U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

2015-11-26 Thread Chin Liang See
Hi Stefan, On Thu, 2015-11-26 at 07:12 +0100, Stefan Roese wrote: > On 26.11.2015 03:32, Chin Liang See wrote: > > Adding new environment qspiload which will load zImage and > > Linux DTB from serial NOR flash. The default flash offset for > > the images as below and they are configurable during r

Re: [U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

2015-11-26 Thread Chin Liang See
Hi Pavel, On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote: > Hi! > > > Adding new environment qspiload which will load zImage and > > Linux DTB from serial NOR flash. The default flash offset for > > the images as below and they are configurable during run time. > > > > - zImage located at

Re: [U-Boot] [PATCH v7 16/34] sf: Add MTD support to spi_flash

2015-11-26 Thread Jagan Teki
Hi Simon, On 26 November 2015 at 23:20, Simon Glass wrote: > Hi Jagan, > > On 26 November 2015 at 04:04, Jagan Teki wrote: >> This patch adds mtd_info support to spi_flash layer, MTD has >> proven core for flash operations so adding MTD to spi_flash >> will extends more functionality. >> >> Revi

Re: [U-Boot] [PATCH v7 12/34] sf: probe: Use spi_flash_scan in dm-spi-flash

2015-11-26 Thread Jagan Teki
Hi Simon, On 26 November 2015 at 23:20, Simon Glass wrote: > Hi Jagan, > > On 26 November 2015 at 04:03, Jagan Teki wrote: >> This patch add support to use spi_flash_scan in >> dm-spi-flash probe, so-that it can access >> the spi_flash functionalities same as non-dm sf probe. >> >> Signed-off-by

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Jagan Teki
Hi Simon, Some how I'm unclear about your comments in previous series probably I my misunderstanding or something. let me explain about my plan on spi-nor development. The entire spi-flash code is generic for all means there is no separate code for any platform or device. So I call it as spi-flas

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Simon Glass
Hi Stefan, On 26 November 2015 at 10:12, Stefan Roese wrote: > Hi Simon, > > On 26.11.2015 18:55, Simon Glass wrote: >> Hi Stefan, >> >> On 26 November 2015 at 09:47, Stefan Roese wrote: >>> Hi Simon, >>> >>> On 26.11.2015 17:48, Simon Glass wrote: >>> >>> >>> >>> > Yes. I'm trying to enabl

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Stefan Roese
Hi Simon, On 26.11.2015 18:55, Simon Glass wrote: > Hi Stefan, > > On 26 November 2015 at 09:47, Stefan Roese wrote: >> Hi Simon, >> >> On 26.11.2015 17:48, Simon Glass wrote: >> >> >> >> Yes. I'm trying to enable SPL_DM on MVEBU. And this with DM_SPI and DM_SPI_FLASH enabled as well.

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Simon Glass
Hi Stefan, On 26 November 2015 at 09:47, Stefan Roese wrote: > Hi Simon, > > On 26.11.2015 17:48, Simon Glass wrote: > > > > >>> Yes. I'm trying to enable SPL_DM on MVEBU. And this with >>> DM_SPI and DM_SPI_FLASH enabled as well. I've the kirkwood >>> SPI driver ported to DM here for this (patc

Re: [U-Boot] [PATCH v7 15/34] zynq: Enable CONFIG_SPL_MTD_SUPPORT

2015-11-26 Thread Simon Glass
Hi Jagan, On 26 November 2015 at 04:03, Jagan Teki wrote: > Add SPL_MTD_SUPPORT to ZYNQ_QSPI SPL. > > Cc: Michal Simek > Signed-off-by: Jagan Teki > --- > include/configs/zynq-common.h | 1 + > 1 file changed, 1 insertion(+) This should be done with Kconfig. Regards, Simon __

Re: [U-Boot] [PATCH v7 22/34] sf: Add MTD support for non-dm spi_flash interface

2015-11-26 Thread Simon Glass
Hi Jagan, On 26 November 2015 at 04:04, Jagan Teki wrote: > This patch adds MTD support to non-dm spi_flash > interface code. Why add new support to the non-DM SPI flash? You should first make MTD support driver model, then try to drop the old non-DM SPI flash code. > > Reviewed-by: Heiko Schoc

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Simon Glass
+Fabio Hi Jagan, On 26 November 2015 at 04:03, Jagan Teki wrote: > This series is combination of mtd and sf tunning stuff in previous > version patches.[1][2] > > This is whole patch series for add mtd support to spi-flash > framework and related stuff. > > The idea is to introduce the spi-nor f

Re: [U-Boot] [PATCH v7 20/34] dm-sf: use mtd_ops, drop dm_spi_flash_ops

2015-11-26 Thread Simon Glass
Hi Jagan, On 26 November 2015 at 04:04, Jagan Teki wrote: > Since mtd_info ops got introduced, just drop the unneeded > dm_spi_flash operations. > > Reviewed-by: Heiko Schocher > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/sf-uclass.c | 39 > include/spi_flash.h

Re: [U-Boot] [PATCH v7 16/34] sf: Add MTD support to spi_flash

2015-11-26 Thread Simon Glass
Hi Jagan, On 26 November 2015 at 04:04, Jagan Teki wrote: > This patch adds mtd_info support to spi_flash layer, MTD has > proven core for flash operations so adding MTD to spi_flash > will extends more functionality. > > Reviewed-by: Heiko Schocher > Signed-off-by: Jagan Teki > --- > drivers/

Re: [U-Boot] [PATCH v7 13/34] sf: Re-factorize spi_flash_probe_tail code

2015-11-26 Thread Simon Glass
Hi Jagan, On 26 November 2015 at 04:03, Jagan Teki wrote: > spi_flash_probe_tail code looks not in proper shape > to add more functionalities. hence refactorized > so-that it's more readable and hence we may extend > more functionalies to it. > > Cc: Bin Meng > Cc: Troy Kisky > Signed-off-by: J

Re: [U-Boot] [PATCH v7 14/34] dm-sf: Re-factorize spi_flash_std_probe code

2015-11-26 Thread Simon Glass
Hi Jagan, On 26 November 2015 at 04:03, Jagan Teki wrote: > spi_flash_probe_tail code looks not in proper shape > to add more functionalities. hence refactorized > so-that it's more readable and hence we may extend > more functionalies to it. > > Cc: Bin Meng > Cc: Troy Kisky > Signed-off-by: J

Re: [U-Boot] [PATCH v7 10/34] sf: Use static for file-scope functions

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:03, Jagan Teki wrote: > Use static for file-scope functions and removed > them from header files. > > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/sf_internal.h | 21 - > drivers/mtd/spi/sf_ops.c | 11 ++- > 2 files changed, 6 inser

Re: [U-Boot] [PATCH v7 12/34] sf: probe: Use spi_flash_scan in dm-spi-flash

2015-11-26 Thread Simon Glass
Hi Jagan, On 26 November 2015 at 04:03, Jagan Teki wrote: > This patch add support to use spi_flash_scan in > dm-spi-flash probe, so-that it can access > the spi_flash functionalities same as non-dm sf probe. > > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/sf_probe.c | 28

Re: [U-Boot] [PATCH v7 09/34] sf: Flash power up read-only based on idcode0

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:03, Jagan Teki wrote: > Using macro's for flash power up read-only access code > leads wrong behaviour hence use idcode0 for runtime > detection, hence the flash which require this functionality > gets detected at runtime. > > Signed-off-by: Jagan Teki > --- > drivers/m

Re: [U-Boot] [PATCH v7 07/34] sf: Use simple name for register access functions

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:03, Jagan Teki wrote: > Most of the register access function are static, > so used simple name to represent each. > > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/sf_ops.c | 52 > > 1 file changed, 26 insertions(+),

Re: [U-Boot] [PATCH v7 11/34] sf: Remove unneeded header includes

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:03, Jagan Teki wrote: > Removed unneeded header includes in sf_ops and sf_probe > > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/sf_ops.c | 2 -- > drivers/mtd/spi/sf_probe.c | 3 --- > 2 files changed, 5 deletions(-) Reviewed-by: Simon Glass __

Re: [U-Boot] [PATCH v7 04/34] sf: probe: Code cleanup

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:03, Jagan Teki wrote: > - Move bar read code below the bar write hance both > at once place, hence it easy for #ifdef macro only > once and readable. > - Move read_cmd_array at top > > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/sf_ops.c | 80 > ++

Re: [U-Boot] [PATCH v7 03/34] sf: Move read_id code to sf_ops

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:03, Jagan Teki wrote: > read_id code is related to spi_flash stuff > hence moved to sf_ops. > > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/sf_internal.h | 3 +-- > drivers/mtd/spi/sf_ops.c | 21 ++--- > drivers/mtd/spi/sf_probe.c| 15 +--

Re: [U-Boot] [PATCH v7 06/34] sf: Fix Makefile

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:03, Jagan Teki wrote: > This patch removes unneeded ifdef and fixed accordingly. > > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/Makefile | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Simon Glass __

Re: [U-Boot] [PATCH v7 08/34] sf: Use flash function pointers in dm_spi_flash_ops

2015-11-26 Thread Simon Glass
Hi Jagan, On 26 November 2015 at 04:03, Jagan Teki wrote: > flash operations are defined as static and reuse them > with function-pointers so call them with generic > function pounters instead of calling like normal functions. > > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/sf_ops.c |

Re: [U-Boot] [PATCH v7 02/34] sf: Move spi_flash_scan code to sf_ops

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:03, Jagan Teki wrote: > Intension is that sf_ops should deals all spi_flash > related stuff and sf_probe (which should renamed future) > should be an interface layer for spi_flash versus spi drivers. > > sf_ops => spi_flash interface > sf_probe => interface layer vs spi_f

Re: [U-Boot] [PATCH v7 01/34] sf: spi_flash_validate_params => spi_flash_scan

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:03, Jagan Teki wrote: > Rename spi_flash_validate_params to spi_flash_scan > as this code not only deals with params setup but > also configure all spi_flash attributes. > > And also moved all flash related code into > spi_flash_scan for future functionality addition. > >

Re: [U-Boot] [PATCH] dm: serial: Minor coding style cleanup of some comments

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:44, Bin Meng wrote: > On Thu, Nov 26, 2015 at 8:38 PM, Stefan Roese wrote: >> Fix incorrect comment alignments. >> >> Signed-off-by: Stefan Roese >> Cc: Simon Glass >> --- >> drivers/serial/serial-uclass.c | 20 ++-- >> 1 file changed, 10 insertions(+)

Re: [U-Boot] [PATCH 2/2] defconfig: dra74_evm: enable serial driver model

2015-11-26 Thread Simon Glass
On 26 November 2015 at 03:55, Mugunthan V N wrote: > Enable serial driver model for dra74_evm as ns16550 supports > driver model. > > Signed-off-by: Mugunthan V N > --- > configs/dra74_evm_defconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass __

Re: [U-Boot] [PATCH] arm: dts: omap: add reg-shift to serial device tree node

2015-11-26 Thread Simon Glass
On 26 November 2015 at 01:19, Mugunthan V N wrote: > With the commit 'c7b9686d5d48 ("ns16550: unify serial_omap")' all > TI platforms are broken with DM/DT boot as ns16550 driver expects > reg-shift from DT which is not populated for TI platforms. > Earlier it worked as it was hard coded to 2 in s

Re: [U-Boot] [PATCH 1/2] arm: dts: dra7-evm: add chosen node to specify serial console device

2015-11-26 Thread Simon Glass
On 26 November 2015 at 03:55, Mugunthan V N wrote: > Introduce chosen node and specify uart0 to be used as serial console. > > Signed-off-by: Mugunthan V N > --- > arch/arm/dts/dra7-evm.dts | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Simon Glass ___

Re: [U-Boot] [PATCH] common/Makefile: Compile fdt_support is enabled in SPL

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:38, Stefan Roese wrote: > When CONFIG_SPL_OF_TRANSLATE is enabled fdt_support.c needs to get > compiled. Otherwise fdt_translate_address() is missing which is needed > in dev_get_addr(). > > Signed-off-by: Stefan Roese > Cc: Simon Glass > --- > common/Makefile | 1 + >

Re: [U-Boot] [PATCH] i2c: Fix the comment to match the function described

2015-11-26 Thread Simon Glass
On 24 November 2015 at 23:41, Stefan Roese wrote: > Use the correct function name in the function description. > > Signed-off-by: Stefan Roese > Cc: Simon Glass > Cc: Heiko Schocher > --- > include/i2c.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass _

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-26 Thread Simon Glass
On 25 November 2015 at 09:51, Simon Glass wrote: > Hi, > > On 24 November 2015 at 23:44, Bin Meng wrote: >> On Wed, Nov 25, 2015 at 11:20 AM, Thomas Chou wrote: >>> Hi Simon, >>> >>> On 2015年11月25日 02:23, Simon Glass wrote: Please try u-boot-dm/testing. This seems to be a differen

Re: [U-Boot] [PATCH] powerpc, mpc5xxx: fix missing bootflag init

2015-11-26 Thread Simon Glass
On 25 November 2015 at 01:46, Heiko Schocher wrote: > since: > commit: f05ad9ba "Add a way to skip relocation" > > tqm5200s board fails to boot. Reason is that > board_init_f has a function parameter bootflag, > which is not setup in > in arch/powerpc/cpu/mpc5xxx/start.S _start > > So board_init_f

Re: [U-Boot] [PATCH] dm: core: Fix Kconfig text to mention SPL in SPL_OF_TRANSLATE

2015-11-26 Thread Simon Glass
On 26 November 2015 at 04:38, Stefan Roese wrote: > Add a remark about SPL to this Kconfig option. Otherwise its identitcal > to the non-SPL version, which is confusing. > > Signed-off-by: Stefan Roese > Cc: Simon Glass > --- > drivers/core/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [U-Boot] [PATCH] common: cli_hush: avoid memory leak

2015-11-26 Thread Simon Glass
Hi Peng, On 25 November 2015 at 02:16, Peng Fan wrote: > Need to free memory avoid memory leak, when error. > > Signed-off-by: Peng Fan > Cc: Simon Glass > Cc: Tom Rini > --- > common/cli_hush.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/common/cli_hush.c b/co

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Stefan Roese
Hi Simon, On 26.11.2015 17:48, Simon Glass wrote: Yes. I'm trying to enable SPL_DM on MVEBU. And this with DM_SPI and DM_SPI_FLASH enabled as well. I've the kirkwood SPI driver ported to DM here for this (patches will follow). what kind of issue? is it failed to probe device or something?

Re: [U-Boot] [PATCH v2 2/2] usb: eth: add Realtek RTL8152B/RTL8153 driver

2015-11-26 Thread Marek Vasut
On Wednesday, November 25, 2015 at 06:30:54 AM, Ted Chen wrote: > From: Ted Chen > > This patch adds driver support for the Realtek RTL8152B/RTL8153 USB > network adapters. > > Signed-off-by: Ted Chen > [swarren, fixed a few compiler warnings] > [swarren, with permission, converted license head

Re: [U-Boot] [PATCH v2 1/4] x86: ivybridge: Remove NORTHBRIDGE_INTEL_SANDYBRIDGE

2015-11-26 Thread Simon Glass
Hi Bin, On 25 November 2015 at 17:46, Bin Meng wrote: > NORTHBRIDGE_INTEL_SANDYBRIDGE is for sandybridge, not ivybridge. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - Remove NORTHBRIDGE_INTEL_SANDYBRIDGE in Makefile too. > > arch/x86/cpu/Makefile | 1 - > arch/x86/cpu/ivy

Re: [U-Boot] [PATCH v7 00/34] sf: MTD support

2015-11-26 Thread Simon Glass
Hi Stefan, On 26 November 2015 at 05:04, Stefan Roese wrote: > Hi Jagan, > > (added Simon, as he's the DM guru) > > On 26.11.2015 13:46, Jagan Teki wrote: >> Hi Stefan, >> >> On 26 November 2015 at 18:02, Stefan Roese wrote: >>> Hi Jagan, >>> >>> >>> On 26.11.2015 13:24, Jagan Teki wrote: >

  1   2   >