On 20/01/2020 17.44, Wolfgang Denk wrote:
> Dear Rasmus Villemoes,
>
> In message <20200108134247.31443-1-rasmus.villem...@prevas.dk> you wrote:
>> The printenv command already by default hides variables beginning with
>> a dot. It can be useful to take that convention even further, and
>>
On Tue, Dec 3, 2019 at 2:15 PM Andre Heider wrote:
>
> Taken from the kernel tag v5.4.
> Drop the /omit-if-no-ref/ keyword as it's not supported by u-boot.
Please sync it from v5.6
98d25b0b266d Merge branch 'sunxi/dt-for-5.6' into sunxi/for-next
On Tue, Dec 3, 2019 at 2:15 PM Andre Heider wrote:
>
> Some Bluetooth controllers, like the BCM4345C5 of the Orange Pi 3,
> ship with the controller default address.
>
> Add a config option to fix it up so it can function properly.
You mean that the default factory address can't make
On Tue, Jan 21, 2020 at 3:29 PM Jagan Teki wrote:
>
> On Sun, Jan 12, 2020 at 9:06 PM Chen-Yu Tsai wrote:
> >
> > From: Chen-Yu Tsai
> >
> > The Libre Computer ALL-H3-IT board is a small single board computer that
> > is roughly the same size as the Raspberry Pi Zero, or around 20% smaller
> >
On 20.01.20 13:20, Baruch Siach wrote:
Read RAM die capacity from the EEPROM TLV.
Follow the ONIE standard that defines the Vendor Extension entry type
for vendor specific data. We have no Private Enterprise Number at the
moment as the standard requires. Use the dummy all 0xff value for now.
On 20.01.20 13:20, Baruch Siach wrote:
Signed-off-by: Baruch Siach
---
configs/clearfog_defconfig | 4
1 file changed, 4 insertions(+)
diff --git a/configs/clearfog_defconfig b/configs/clearfog_defconfig
index 28ce0715926f..e2399a97391d 100644
--- a/configs/clearfog_defconfig
+++
On 20.01.20 13:20, Baruch Siach wrote:
Add support for read/write of ONIE "Tlvinfo" EEPROM data format. TLV
stands for Type-Length-Value. The data format is described here:
https://opencomputeproject.github.io/onie/design-spec/hw_requirements.html#board-eeprom-information-format
Based on
On Tue, Dec 3, 2019 at 2:15 PM Andre Heider wrote:
>
> Signed-off-by: Andre Heider
> ---
Please add commit message, it looks hard to get what this patch is doing?
On Mon, Jan 20, 2020 at 11:53 PM Tom Rini wrote:
>
> New analysis by the tool has shown that we have some cases where we
> weren't handling the error exit condition correctly. When we ran into
> the ENOMEM case we wouldn't exit the function and thus incorrect things
> could happen. Rework the
The default reserved memory for CMA is high memory. If LPAE is enabled,
highmem pages are non-remapped and can not be used with
dma_alloc_coherent. This patch will reserve low memory for CMA and fix
the issue on LS1021A.
Signed-off-by: Peng Ma
Signed-off-by: Shengzhou Liu
Signed-off-by: Alison
On Sun, Jan 12, 2020 at 9:06 PM Chen-Yu Tsai wrote:
>
> From: Chen-Yu Tsai
>
> Sync the device tree files and device tree header files from upstream
> Linux kernel, as of 2020-01-08. The commit synced to in the sunxi repo
>
> 98d25b0b266d Merge branch 'sunxi/dt-for-5.6' into sunxi/for-next
>
On Sun, Jan 12, 2020 at 9:06 PM Chen-Yu Tsai wrote:
>
> From: Chen-Yu Tsai
>
> The Libre Computer ALL-H3-IT board is a small single board computer that
> is roughly the same size as the Raspberry Pi Zero, or around 20% smaller
> than a credit card.
>
> The board features:
>
> - H2, H3, or H5
On 1/21/20 7:12 AM, AKASHI Takahiro wrote:
On Fri, Jan 17, 2020 at 06:51:50AM +0100, Heinrich Schuchardt wrote:
On 1/17/20 6:11 AM, AKASHI Takahiro wrote:
On Thu, Jan 09, 2020 at 12:55:17AM +0100, Heinrich Schuchardt wrote:
On 12/18/19 1:45 AM, AKASHI Takahiro wrote:
With this commit, image
On 12/18/19 1:45 AM, AKASHI Takahiro wrote:
A signature database variable is associated with a specific guid.
For convenience, if user doesn't supply any guid info, "env set|print -e"
should complement it.
Signed-off-by: AKASHI Takahiro
---
cmd/nvedit_efi.c | 18 ++
1 file
On Fri, Jan 17, 2020 at 06:51:50AM +0100, Heinrich Schuchardt wrote:
> On 1/17/20 6:11 AM, AKASHI Takahiro wrote:
> >On Thu, Jan 09, 2020 at 12:55:17AM +0100, Heinrich Schuchardt wrote:
> >>On 12/18/19 1:45 AM, AKASHI Takahiro wrote:
> >>>With this commit, image validation can be enforced, as UEFI
On Fri, Jan 17, 2020 at 06:37:39AM +0100, Heinrich Schuchardt wrote:
> On 1/17/20 3:20 AM, AKASHI Takahiro wrote:
> >On Wed, Jan 15, 2020 at 01:13:36AM +0100, Heinrich Schuchardt wrote:
> >>On 1/15/20 12:43 AM, Heinrich Schuchardt wrote:
> >>>On 12/18/19 1:44 AM, AKASHI Takahiro wrote:
> >(snip)
>
On Fri, Jan 17, 2020 at 06:26:34AM +0100, Heinrich Schuchardt wrote:
> On 1/17/20 2:53 AM, AKASHI Takahiro wrote:
> >On Tue, Jan 14, 2020 at 01:04:58PM +0100, Heinrich Schuchardt wrote:
> >>On 1/14/20 8:33 AM, AKASHI Takahiro wrote:
> >>>On Wed, Jan 08, 2020 at 06:43:51PM +0100, Heinrich
Tom, Simon,
On Fri, Jan 17, 2020 at 06:59:44AM +0100, Heinrich Schuchardt wrote:
> On 1/17/20 3:24 AM, AKASHI Takahiro wrote:
> >On Tue, Jan 14, 2020 at 12:43:40PM +0100, Heinrich Schuchardt wrote:
> >>On 1/14/20 8:45 AM, AKASHI Takahiro wrote:
> >>>On Wed, Jan 08, 2020 at 01:35:13PM +0100,
There is a mirror of ram located at 0x400 which is un-cached. This is
probably useful for DMA, but I am unsure of how to describe it in this device
tree.
The cache-line size is undocumented. Emphirical tests suggest that it is 32
bytes, but I've used 64-bytes to be on the safe side.
Where
On Tue, 2020-01-21 at 00:55 +0100, Mauro Condarelli wrote:
> Hi Weijie,
> I attach my, apparently working, port to VoCore2 SoM.
>
> These patchsets are on top of Your 21 patch rewrite of MT7628 board,
>
> While the first patchset is relatively straightforward, but does not include
> MMC
> I am not sure the modifications of clk are ok for other people.
> It will be better to send pure riscv relative patch-sets.
Hm, well at the moment removing the dependency on these two patches
would probably require a substantial rewrite of patch 11, which would
primarily consist of duplicating
Hi Sean,
> From: Sean Anderson [mailto:sean...@gmail.com]
> Sent: Thursday, January 16, 2020 7:18 AM
> To: U-Boot Mailing List
> Cc: Rick Jian-Zhi Chen(陳建志)
> Subject: [PATCH v2 08/11] riscv: Add device tree for K210
>
> The subject for this patch should be
>
> Subject: [PATCH v2 08/11] riscv:
Hi Sean,
> > This patch is clock relative patch, if it is not a necessary patch for
> > Sipeed Maix support.
> > Please remove patch 1/11 and 2/11, and send them in another patch-sets.
>
> Patches 10 and 11 rely on these first two patches. Should I just
> reference the split off patches in the
Hi Sean,
> From: Sean Anderson [mailto:sean...@gmail.com]
> Sent: Thursday, January 16, 2020 6:52 AM
> To: U-Boot Mailing List; Rick Jian-Zhi Chen(陳建志)
> Subject: [PATCH v2 04/11] riscv: Add an option to default to RV64I
>
> This allows 64-bit boards to default to the 64-bit instruction set
> I wonder why the compiling is OK without those appropriate headers.
It's likely that all the uses looked like
#include
#include
So it wasn't noticed until it was included first in some file.
Hi Sean,
> From: Sean Anderson [mailto:sean...@gmail.com]
> Sent: Thursday, January 16, 2020 6:51 AM
> To: U-Boot Mailing List
> Cc: Rick Jian-Zhi Chen(陳建志)
> Subject: [PATCH v2 03/11] riscv: Add headers for asm/global_data.h
>
> This header depended on bd_t and ulong, but did not include the
> This patch is clock relative patch, if it is not a necessary patch for
> Sipeed Maix support.
> Please remove patch 1/11 and 2/11, and send them in another patch-sets.
Patches 10 and 11 rely on these first two patches. Should I just
reference the split off patches in the cover letter?
Hi Sean
> From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Sean Anderson
> Sent: Thursday, January 16, 2020 6:48 AM
> To: U-Boot Mailing List
> Subject: [PATCH v2 01/11] clk: Always use the supplied struct clk
>
> CCF clocks should always use the struct clock passed to their
On Mon, Jan 20, 2020 at 08:35:00AM +, Patrick DELAUNAY wrote:
> Hi Tom
>
> Please pull the first STM32 related patches for v2020.04
>
> Gitlab CI status:
> https://gitlab.denx.de/u-boot/custodians/u-boot-stm/pipelines/1900
>
> With the following fixes:
> - stm32mp1: split SOC and
On Mon, Jan 20, 2020 at 02:36:26PM +0530, Lokesh Vutla wrote:
> Hi Tom,
>
> Please find the pull request for v2020.04 merge window containing TI
> specific changes.
>
> Travis-CI tests: https://travis-ci.org/lokeshvutla/u-boot/builds/639323217
>
> Thanks and regards,
> Lokesh
>
>
> The
On Fri, Jan 17, 2020 at 11:47:03AM +0200, Andy Shevchenko wrote:
> On Fri, Jan 17, 2020 at 8:13 AM AKASHI Takahiro
> wrote:
> > On Thu, Jan 16, 2020 at 10:31:49PM +0200, Andy Shevchenko wrote:
>
> ...
>
> > > Prerequisites:
> > > - the board with U-Boot and installed Linux OS on eMMC
> > > -
Hi Weijie,
I attach my, apparently working, port to VoCore2 SoM.
These patchsets are on top of Your 21 patch rewrite of MT7628 board,
While the first patchset is relatively straightforward, but does not include
MMC handling, to enable it I had to backport from Linux Kernel several
pieces,
On 1/20/20 8:50 PM, Peter Robinson wrote:
>> RPI4's SDHCI controller is supported SDMA mode. (Checked on kernel side)
>> But It doesn't use on u-boot side. Then it's too slow about read/write
>> performance.
>> This patchset is supported SDMA mode on RPI4 target(32bit).
>> - I didn't test on RPI4
New analysis by the tool has shown that we have some cases where we
weren't handling the error exit condition correctly. When we ran into
the ENOMEM case we wouldn't exit the function and thus incorrect things
could happen. Rework the unwinding such that we don't need a helper
function now and
On Fri, Jan 17, 2020 at 05:41:31PM +0100, Simon Goldschmidt wrote:
> + Jordy, who just found a bug here...
>
> Am 08.11.2019 um 17:24 schrieb Tom Rini:
> > New analysis by the tool has shown that we have some cases where we
> > weren't handling the error exit condition correctly. When we ran
From: Arkadiusz Karas
Add iMX6ULL VisionSOM SoM and VisionCB-RT-STD evaluation board support.
The SoM has an iMX6ULL, 512 MiB of DRAM and microSD slot. The carrier
board has Ethernet, USB host port, USB OTG port.
Signed-off-by: Arkadiusz Karas
Signed-off-by: Marek Vasut
Cc: Stefano Babic
---
On Mon, Jan 20, 2020 at 03:43:27PM +0300, Alexey Brodkin wrote:
> The following bitops are implemented pretty similarly for many
> arches and now when we faced a need in them on ARC I guess there's
> no point in copy-pasting them yet another time but instead it might
> be better re-use generic
Hi Joris,
On Mon, Jan 20, 2020 at 5:32 PM Joris Offouga wrote:
> This thread :
> https://lists.denx.de/pipermail/u-boot/2020-January/395560.html
This is an unrelated issue. wandboard support several versions and
this issue happens with imx6dl-wandboard-revd1.
Ethernet does not work because
Hi Fabio,
Le 20/01/2020 à 21:28, Fabio Estevam a écrit :
Hi Joris,
On Mon, Jan 20, 2020 at 5:26 PM Joris Offouga wrote:
I think this bug is similar to the wandboard, I looked at this thread
fairly quickly, did you finally fix it?
Which wandboard issue are you referring to?
This thread :
Hi Joris,
On Mon, Jan 20, 2020 at 5:26 PM Joris Offouga wrote:
> I think this bug is similar to the wandboard, I looked at this thread
> fairly quickly, did you finally fix it?
Which wandboard issue are you referring to?
Hi Fabio,
Le 20/01/2020 à 21:22, Fabio Estevam a écrit :
Hi Joris,
On Mon, Jan 20, 2020 at 5:21 PM Joris Offouga wrote:
Sorry for that indeed I should have made two different commit for this,
I have the idea to revert the commit and I will send it split in two
No need to revert. Let's
Hi Joris,
On Mon, Jan 20, 2020 at 5:21 PM Joris Offouga wrote:
> Sorry for that indeed I should have made two different commit for this,
> I have the idea to revert the commit and I will send it split in two
No need to revert. Let's focus on getting Ethernet to work again :-)
Thanks
> detail_board_ddr_info() is not used anywhere, so simply remove it.
> This function is only used by Layerscape, not by i.MX.
> This was detected by the following sparse warning:
> board/toradex/apalis-imx8/apalis-imx8.c:92:6: warning: no previous
> prototype for ‘detail_board_ddr_info’
Hi Fabio,
Le 20/01/2020 à 19:48, Fabio Estevam a écrit :
Hi Joris,
Has this patch been tested on the real hardware?
I tested and validate it before sending it, there must have been a
problem with the merge.
This is what we currently see:
U-Boot 2020.01-00620-g2d2f91a480 (Jan 20 2020 -
On 1/17/20 5:32 PM, Patrick DELAUNAY wrote:
> Hi Marek,
Hi,
>> From: Patrick DELAUNAY
>> Sent: lundi 13 janvier 2020 15:05
>>
>> Hi Marek,
>>
>>> From: Marek Vasut
>>> Sent: vendredi 10 janvier 2020 01:29
>>>
>>> Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board.
>>> This
> Fix dtb building warnings:
> Warning (cooling_device_property):
> /thermal-zones/cpu-thermal0/cooling-maps/map0:
> Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle
> (referred from cooling-device[0])
> Signed-off-by: Anatolij Gustschin
> Reviewed-by: Stefano Babic
>
> The PFUZE100 and PFUZE200 PMICs can be discerned by bit 0 in DeviceID
> register. Print the correct identification of the PMICs.
> Signed-off-by: Marek Vasut
> Cc: Fabio Estevam
> Cc: Silvio Fricke
> Cc: Stefano Babic
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
> Functions fracpll_configure(), decode_intpll(), decode_fracpll(),
> get_root_src_clk() and get_root_clk() are used only in the scope of this
> file, so make them static to fix the following sparse warnings:
> arch/arm/mach-imx/imx8m/clock_imx8mm.c:50:5: warning: no previous
> prototype for
> Currently the following build warning is seen:
> = WARNING ==
> This board does not use CONFIG_DM_ETH (Driver Model
> for Ethernet drivers). Please update the board to use
> CONFIG_DM_ETH before the v2020.07 release. Failure to
> update by the deadline may
> Functions spl_dram_init() and power_init_board() are used only in
> the scope of this file, so make them static to fix the following sparse
> warnings:
> board/freescale/imx8mm_evk/spl.c:40:6: warning: no previous prototype
> for ‘spl_dram_init’ [-Wmissing-prototypes]
>
> detail_board_ddr_info() is not used anywhere, so simply remove it.
> This function is only used by Layerscape, not by i.MX.
> This was detected by the following sparse warning:
> board/freescale/imx8qxp_mek/imx8qxp_mek.c:115:6: warning: no previous
> prototype for ‘detail_board_ddr_info’
> The imx8mm doesn't require the hdmi firmware.
> Update also the fw version.
> Signed-off-by: Flavio Suligoi
> Reviewed-by: Peng Fan
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=
DENX Software
> Signed-off-by: Flavio Suligoi
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
> detail_board_ddr_info() is not used anywhere, so simply remove it.
> This function is only used by Layerscape, not by i.MX.
> This was detected by the following sparse warning:
> board/toradex/colibri-imx8x/colibri-imx8x.c:104:6: warning: no previous
> prototype for ‘detail_board_ddr_info’
> With commit mx7dsabre: Enable DM_ETH 0d52bab4
> Device Tree has been update and change pfuze3000 node
> Signed-off-by: Joris Offouga
> Reviewed-by: Fabio Estevam
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
> On SPL enabled systems, the current s_init code (wdog, clock and ldo
> init) is executed twice (by SPL and u-boot). This is not necessary and
> might lead to boot issues (ie, starting PMC1 when it is already running).
> Signed-off-by: Jorge Ramirez-Ortiz
> Reviewed-by: Fabio Estevam
Applied to
> Include fdt_support.h header file to fix the following sparse warning:
> board/freescale/imx8qxp_mek/imx8qxp_mek.c:129:5: warning: no previous
> prototype for ‘ft_board_setup’ [-Wmissing-prototypes]
> Signed-off-by: Alifer Moraes
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano
> Enable SPL SDP fallback boot option in default build.
> Signed-off-by: Marek Vasut
> Cc: Fabio Estevam
> Cc: Silvio Fricke
> Cc: Stefano Babic
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=
DENX
> Add sys_proto.h header file to fix the following sparse warning:
> board/freescale/imx8mm_evk/imx8mm_evk.c:59:5: warning: no previous
> prototype for ‘board_mmc_get_env_dev’ [-Wmissing-prototypes]
> Signed-off-by: Alifer Moraes
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano
> Signed-off-by: Flavio Suligoi
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
> The mux mode is embedded in the PAD definition and therefore there is
> no need to repeat it in the PAD configuration value (more over since
> this information will be masked out when the configuration value is
> applied).
> Signed-off-by: Jorge Ramirez-Ortiz
> Reviewed-by: Fabio Estevam
> detail_board_ddr_info() is not used anywhere, so simply remove it.
> This function is only used by Layerscape, not by i.MX.
> This was detected by the following sparse warning:
> board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c:110:6: warning: no
> previous
> prototype for
> Simplify the uSDHC4 eMMC controller setup. This is the only eMMC
> present on the system and only controller that is used, so drop
> the extra logic.
> Signed-off-by: Marek Vasut
> Cc: Fabio Estevam
> Cc: Silvio Fricke
> Cc: Stefano Babic
> Reviewed-by: Stefano Babic
Applied to u-boot-imx,
> Add prototype to function spl_board_boot_device to fix the following
> sparse warning:
> board/freescale/imx8mm_evk/spl.c:26:5: warning: no previous prototype
> for ‘spl_board_boot_device’ [-Wmissing-prototypes]
> Signed-off-by: Alifer Moraes
Applied to u-boot-imx, master, thanks !
Best
> Include fdt_support.h header file to fix the following sparse warning:
> board/freescale/imx8qm_mek/imx8qm_mek.c:116:5: warning: no previous
> prototype for ‘ft_board_setup’ [-Wmissing-prototypes]
> Signed-off-by: Alifer Moraes
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano
> detail_board_ddr_info() is not used anywhere, so simply remove it.
> This function is only used by Layerscape, not by i.MX.
> This was detected by the following sparse warning:
> board/freescale/imx8qm_mek/imx8qm_mek.c:102:6: warning: no previous
> prototype for ‘detail_board_ddr_info’
On 1/20/20 9:40 AM, Wolfgang Denk wrote:
> Hi,
>
> I noticed that block device commands like "ls" fail to give any error
> messages in some cases. For example, something like
>
> -> ls FOOBAR 1:1 /
> ->
>
> will terminate without the slightest hint that FOOBAR is some device
> type
Dear Joel,
In message <7cac871967a1317cea251e78d67a3...@lixil.net> you wrote:
>
> >> +config USER_ENV_SETTINGS
> >> + string "User build-time additional environment entries"
> >> + help
> >> +This value is reserved for the building user to provide custom
> >> +environment entries to be
On Sat, Dec 28, 2019 at 10:45:12AM -0700, Simon Glass wrote:
> This file doesn't include any declarations anymore but it does include
> other headers. Update the header comment to mention this.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
On Sat, Dec 28, 2019 at 10:45:10AM -0700, Simon Glass wrote:
> This is not really a CONFIG since it is not intended to be set by boards.
> Move it into the compiler header with other similar defines, and rename
> it.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
On Sat, Dec 28, 2019 at 10:45:11AM -0700, Simon Glass wrote:
> There are many header files included here. Put them all together since the
> blank lines are not useful.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:45:08AM -0700, Simon Glass wrote:
> The kernel.h file has a number of useful macros including a few related
> to structures. Move check_member() there too.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP
On Sat, Dec 28, 2019 at 10:45:09AM -0700, Simon Glass wrote:
> Move this macro in with all the other rounding macros.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:45:07AM -0700, Simon Glass wrote:
> At present panic() is in the vsprintf.h header file. That does not seem
> like an obvious choice for hang(), even though it relates to panic(). So
> let's put hang() in its own header.
>
> Signed-off-by: Simon Glass
Applied to
On Sat, Dec 28, 2019 at 10:45:06AM -0700, Simon Glass wrote:
> This function is called during init so move it to the init header file.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:45:03AM -0700, Simon Glass wrote:
> These three globals relate to image handling. Move them to the image
> header file.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:45:05AM -0700, Simon Glass wrote:
> These functions relate to memory init so move them into the init
> header.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:45:04AM -0700, Simon Glass wrote:
> This function has a very generic name which does not adequately describe
> its purpose. Rename it and move it to image.h, since it relates to reading
> a script from an image.
>
> Signed-off-by: Simon Glass
Applied to
On Sat, Dec 28, 2019 at 10:45:02AM -0700, Simon Glass wrote:
> These global variables are quite short and generic. In fact the same name
> is more often used locally for struct members and function arguments.
>
> Add a image_ prefix to make them easier to distinguish.
>
> Signed-off-by: Simon
On Sat, Dec 28, 2019 at 10:44:57AM -0700, Simon Glass wrote:
> This file is only used by PowerPC so move it to an arch-specific header
> file.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:44:59AM -0700, Simon Glass wrote:
> This function related to timer and most of the timer functions are in
> time.h, so move this function there.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:44:56AM -0700, Simon Glass wrote:
> This is an init-related function so belongs in that file. Move it.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:45:01AM -0700, Simon Glass wrote:
> Move this function out of common.h and into a relevant header file.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:44:58AM -0700, Simon Glass wrote:
> These three clock functions don't use driver model and should be migrated.
> In the meantime, create a new file to hold them.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description:
On Sat, Dec 28, 2019 at 10:45:00AM -0700, Simon Glass wrote:
> This function is only used on ARM devices. Move it out of the common file
> and to a arch-specific header.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:44:55AM -0700, Simon Glass wrote:
> This function is only used on ARM devices so does not belong in the global
> common header file. Move it to an ARM header.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP
On Sat, Dec 28, 2019 at 10:44:50AM -0700, Simon Glass wrote:
> These CONFIG options are not used anymore. CONFIG_POST_ALT_LIST just
> causes CONFIG_POST_STD_LIST to be set and it causes tests.c to be
> compiled. So just make compiling tests.c unconditional.
>
> Signed-off-by: Simon Glass
On Sat, Dec 28, 2019 at 10:44:52AM -0700, Simon Glass wrote:
> This function is not called anywhere so we can drop the declaration. If
> it is needed one day, it should be added in its own header file.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
On Sat, Dec 28, 2019 at 10:44:54AM -0700, Simon Glass wrote:
> These functions relate to setting up the device tree for booting the OS.
> The fdt_support.h header file supports similar functions, so move these
> there.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
On Sat, Dec 28, 2019 at 10:44:51AM -0700, Simon Glass wrote:
> This only exists to control whether the post/ directory is build. It is
> just as easy to check this in the Makefile. Remove CONFIG_HAS_POST and use
> an ifdef in the Makefile instead.
>
> Signed-off-by: Simon Glass
Applied to
On Sat, Dec 28, 2019 at 10:44:53AM -0700, Simon Glass wrote:
> This file already has lots of type declarations so it seems better to put
> all of them there.
>
> Move them.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:44:47AM -0700, Simon Glass wrote:
> This seems pretty old now. It has not been converted to driver model and
> is not used by any boards.
>
> Drop it.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP
On Sat, Dec 28, 2019 at 10:44:48AM -0700, Simon Glass wrote:
> This is a network function so let's move it into that header.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:44:45AM -0700, Simon Glass wrote:
> This is an init function so move it out of the common header. Avoid using
> the typedef so that we don't have to include the global_data header file.
>
> Also tidy up the function style in comments while we are here.
>
>
On Sat, Dec 28, 2019 at 10:44:49AM -0700, Simon Glass wrote:
> This define seems better suited to the eeprom header file, particularly
> as it is only used in the eeprom.c file.
>
> Move it.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description:
On Sat, Dec 28, 2019 at 10:44:46AM -0700, Simon Glass wrote:
> This function is defined in exports.c so move it to its header file.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Heinrich Schuchardt
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:44:41AM -0700, Simon Glass wrote:
> These functions are not used in U-Boot. Drop them.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:44:44AM -0700, Simon Glass wrote:
> These are filesystem functions and belong in the filesystem header file.
> Move them.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:44:42AM -0700, Simon Glass wrote:
> These declarations are only used in fdtdec.c so move them to its header
> file.
>
> Signed-off-by: Simon Glass
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Sat, Dec 28, 2019 at 10:44:39AM -0700, Simon Glass wrote:
> Move this function out of common.h and into a better place.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Simon Goldschmidt
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
1 - 100 of 195 matches
Mail list logo
