Re: [PATCH] spi: cadence-qspi: Move ref clock calculation to probe

2020-02-25 Thread Simon Goldschmidt
Vignesh Raghavendra schrieb am Mi., 26. Feb. 2020, 08:29: > +Simon who converted driver to use clk_get* APIs > > On 24/02/20 12:40 pm, Pratyush Yadav wrote: > > "assigned-clock-parents" and "assigned-clock-rates" DT properties take > > effect only after ofdata_to_platdata() when

Re: [PATCH] spi: cadence-qspi: Move ref clock calculation to probe

2020-02-25 Thread Vignesh Raghavendra
+Simon who converted driver to use clk_get* APIs On 24/02/20 12:40 pm, Pratyush Yadav wrote: > "assigned-clock-parents" and "assigned-clock-rates" DT properties take > effect only after ofdata_to_platdata() when clk_set_defaults() is called > in device_probe(). Therefore clk get rate() would

[PATCH 1/1] block: ide: use definitions from include/libata.h

2020-02-25 Thread Heinrich Schuchardt
Currently ATA commands are defined both in include/libata.h and include/ata.h. libata.h is included in ata.h. So this duplication does not make much sense. Use the command definitions from include/libata.h where applicable. Signed-off-by: Heinrich Schuchardt --- drivers/block/ide.c | 8

[PATCH v2] arm: mvebu: update RTC values for PCIe memory wrappers

2020-02-25 Thread Chris Packham
From: Chris Packham Update the RTC (Read Timing Control) values for PCIe memory wrappers following an ERRATA (ERRATA# TDB). This means the PCIe accesses will used slower memory Read Timing, to allow more efficient energy consumption, in order to lower the minimum VDD of the memory. Will lead to

Re: [PATCH] arm: mvebu: update RTC values for PCIe memory wrappers

2020-02-25 Thread Chris Packham
On Wed, 2020-02-26 at 19:46 +1300, Chris Packham wrote: > Hi Baruch, > > On Wed, 2020-02-26 at 06:49 +0200, Baruch Siach wrote: > > Hi Chris, > > > > On Wed, Feb 26 2020, Chris Packham wrote: > > > From: Chris Packham > > > > > > Update the RTC (Read Timing Control) values for PCIe memory > >

Re: [PATCH] arm: mvebu: update RTC values for PCIe memory wrappers

2020-02-25 Thread Chris Packham
Hi Baruch, On Wed, 2020-02-26 at 06:49 +0200, Baruch Siach wrote: > Hi Chris, > > On Wed, Feb 26 2020, Chris Packham wrote: > > From: Chris Packham > > > > Update the RTC (Read Timing Control) values for PCIe memory > > wrappers > > following an ERRATA (ERRATA# TDB). This means the PCIe

[PATCH 1/1] cmd: fat: remove unused includes

2020-02-25 Thread Heinrich Schuchardt
Remove unused includes from cmd/fat.c. Signed-off-by: Heinrich Schuchardt --- cmd/fat.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/cmd/fat.c b/cmd/fat.c index 50df127f6d..abce2f1e0c 100644 --- a/cmd/fat.c +++ b/cmd/fat.c @@ -8,13 +8,7 @@ * Boot support */ #include -#include

[PATCH 1/1] ata: sort ATA commands

2020-02-25 Thread Heinrich Schuchardt
Sort the ATA commands in include/libata.h by number. Add a few more comments. Signed-off-by: Heinrich Schuchardt --- include/libata.h | 84 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/include/libata.h b/include/libata.h index

[PATCH] lx2160a : Remove default VID setting

2020-02-25 Thread Meenakshi Aggarwal
Set VID to 800 mV for Rev1 and set VID as per switch settings for Rev2. Signed-off-by: Meenakshi Aggarwal --- board/freescale/lx2160a/lx2160a.c | 9 - include/configs/lx2160aqds.h | 1 - include/configs/lx2160ardb.h | 1 - 3 files changed, 8 insertions(+), 3 deletions(-) diff

[PATCH v6 15/16] sandbox: add extra configurations for UEFI and related tests

2020-02-25 Thread AKASHI Takahiro
Adding those extra configurations allows us to successfully run UEFI secure boot pytest on Travis CI. Signed-off-by: AKASHI Takahiro --- configs/sandbox64_defconfig | 3 +++ configs/sandbox_defconfig | 3 +++ 2 files changed, 6 insertions(+) diff --git a/configs/sandbox64_defconfig

[PATCH v6 16/16] travis: add packages for UEFI secure boot test

2020-02-25 Thread AKASHI Takahiro
Pytest for UEFI secure boot will use several host commands. In particular, Test setup relies on efitools, whose version must be v1.5.2 or later. So fetch a new version of deb package directly. Please note it has a dependency on mtools, which must also be installed along wih efitools. In addition,

[PATCH v6 13/16] efi_loader, pytest: add UEFI secure boot tests (authenticated variables)

2020-02-25 Thread AKASHI Takahiro
Provide a couple of test cases for variable authentication. Signed-off-by: AKASHI Takahiro --- .../py/tests/test_efi_secboot/test_authvar.py | 282 ++ 1 file changed, 282 insertions(+) create mode 100644 test/py/tests/test_efi_secboot/test_authvar.py diff --git

[PATCH v6 14/16] efi_loader, pytest: add UEFI secure boot tests (image)

2020-02-25 Thread AKASHI Takahiro
Provide test cases for * image authentication for signed images (test_efi_secboot/test_signed.py) * image authentication for unsigned images (test_efi_secboot/test_unsigned.py) Signed-off-by: AKASHI Takahiro --- test/py/tests/test_efi_secboot/test_signed.py | 117 +

[PATCH v6 12/16] efi_loader, pytest: set up secure boot environment

2020-02-25 Thread AKASHI Takahiro
A fixture for UEFI secure boot tests (image authentication and variable authentication) is defined. A small file system with test data in a single partition formatted in fat is created. This test requires efitools v1.5.2 or later. If the system's efitools is older, you have to build it on your

[PATCH v6 11/16] cmd: efidebug: add "test bootmgr" sub-command

2020-02-25 Thread AKASHI Takahiro
This sub-command will be used to test image authentication, in particular, a case where efi_load_image() failed with EFI_SECURITY_VIOLATION but we still want to try efi_start_image(). We won't run such a case under normal bootmgr because it simply refuses to call efi_start_image() if anything but

[PATCH v6 04/16] efi_loader: variable: support variable authentication

2020-02-25 Thread AKASHI Takahiro
With this commit, EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS is supported for authenticated variables and the system secure state will transfer between setup mode and user mode as UEFI specification section 32.3 describes. Internally, authentication data is stored as part of authenticated

[PATCH v6 09/16] cmd: env: use appropriate guid for authenticated UEFI variable

2020-02-25 Thread AKASHI Takahiro
A signature database variable is associated with a specific guid. For convenience, if user doesn't supply any guid info, "env set|print -e" should complement it. Signed-off-by: AKASHI Takahiro --- cmd/nvedit_efi.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff

[PATCH v6 07/16] efi_loader: image_loader: support image authentication

2020-02-25 Thread AKASHI Takahiro
With this commit, image validation can be enforced, as UEFI specification section 32.5 describes, if CONFIG_EFI_SECURE_BOOT is enabled. Currently we support * authentication based on db and dbx, so dbx-validated image will always be rejected. * following signature types:

[PATCH v6 10/16] cmd: env: add "-at" option to "env set -e" command

2020-02-25 Thread AKASHI Takahiro
With "-at" option, EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS will be passed to SetVariable() to authenticate the variable. Signed-off-by: AKASHI Takahiro --- cmd/nvedit.c | 5 +++-- cmd/nvedit_efi.c | 5 - 2 files changed, 7 insertions(+), 3 deletions(-) diff --git

[PATCH v6 05/16] efi_loader: variable: add secure boot state transition

2020-02-25 Thread AKASHI Takahiro
UEFI specification defines several global variables which are related to the current secure boot state. In this commit, those values will be maintained according to operations. Currently, AuditMode and DeployedMode are defined but not implemented. Signed-off-by: AKASHI Takahiro ---

[PATCH v6 08/16] efi_loader: set up secure boot

2020-02-25 Thread AKASHI Takahiro
The following variable is exported as UEFI specification defines: SignatureSupport: array of GUIDs representing the type of signatures supported by the platform firmware Signed-off-by: AKASHI Takahiro --- lib/efi_loader/efi_setup.c | 38

[PATCH v6 03/16] efi_loader: add signature database parser

2020-02-25 Thread AKASHI Takahiro
efi_signature_parse_sigdb() is a helper function will be used to parse signature database variable and instantiate a signature store structure in later patches. Signed-off-by: AKASHI Takahiro --- include/efi_loader.h | 3 + lib/efi_loader/efi_signature.c | 226

[PATCH v6 00/16] efi_loader: add secure boot support

2020-02-25 Thread AKASHI Takahiro
# Documentation for UEFI secure boot on U-Boot will be submitted in # a separate patch in near future. One of major missing features in current UEFI implementation is "secure boot." The ultimate goal of my attempt is to implement image authentication based on signature and provide UEFI secure

[PATCH v6 01/16] efi_loader: add CONFIG_EFI_SECURE_BOOT config option

2020-02-25 Thread AKASHI Takahiro
Under this configuration, UEFI secure boot support will be added in later patches. Signed-off-by: AKASHI Takahiro --- lib/efi_loader/Kconfig | 18 ++ 1 file changed, 18 insertions(+) diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index a7afa3f29e88..4b09a07f1b0a

[PATCH v6 06/16] efi_loader: variable: add VendorKeys variable

2020-02-25 Thread AKASHI Takahiro
The following variable is exported as UEFI specification defines: VendorKeys: whether the system is configured to use only vendor-provided keys or not The value will have to be modified if a platform has its own way of initializing signature database, in particular, PK. Signed-off-by:

[PATCH v6 02/16] efi_loader: add signature verification functions

2020-02-25 Thread AKASHI Takahiro
In this commit, implemented are a couple of helper functions which will be used to materialize variable authentication as well as image authentication in later patches. Signed-off-by: AKASHI Takahiro --- include/efi_api.h | 87 + include/efi_loader.h | 72

Re: [PATCH] arm: mvebu: update RTC values for PCIe memory wrappers

2020-02-25 Thread Baruch Siach
Hi Chris, On Wed, Feb 26 2020, Chris Packham wrote: > From: Chris Packham > > Update the RTC (Read Timing Control) values for PCIe memory wrappers > following an ERRATA (ERRATA# TDB). This means the PCIe accesses will > used slower memory Read Timing, to allow more efficient energy >

RE: [PATCH] ls1043a: Remove "fdt_high" environment variable

2020-02-25 Thread Priyanka Jain (OSS)
>-Original Message- >From: U-Boot On Behalf Of Tom Rini >Sent: Tuesday, February 4, 2020 9:44 AM >To: Wen He >Cc: u-boot@lists.denx.de; u-b...@linux.freescale.net >Subject: Re: [PATCH] ls1043a: Remove "fdt_high" environment variable > >On Mon, Feb 03, 2020 at 05:32:27PM +0800, Wen He

RE: [v4 1/4] Revert "ata: fsl_ahci: Add sata DM support for Freescale powerpc socs"

2020-02-25 Thread Priyanka Jain
>-Original Message- >From: Peng Ma >Sent: Monday, December 23, 2019 2:58 PM >To: s...@chromium.org; Priyanka Jain ; Marcel Ziswiler >; Andy Tang >Cc: u-boot@lists.denx.de; Peng Ma >Subject: [v4 1/4] Revert "ata: fsl_ahci: Add sata DM support for Freescale >powerpc socs" > >This reverts

pull request of u-boot-fsl-mpc85xx

2020-02-25 Thread Priyanka Jain
Dear Tom, Please find my pull-request for u-boot-mpc85xx/master https://travis-ci.org/p-priyanka-jain/u-boot/builds/654734910 Summary Update Sata node for T2080QDS and revert Sata related unrequired patches. priyankajain -- The following changes since commit

[PATCH v2 1/1] include/ata.h: remove invalid links

2020-02-25 Thread Heinrich Schuchardt
Remove invalid URLs for "Information Technology - AT Attachment-3 Interface (ATA-3)", point to ANSI X3.298-1997. Signed-off-by: Heinrich Schuchardt --- v2: refer to the ANSI standard --- include/ata.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 1/1] include/ata.h: remove invalid links

2020-02-25 Thread Tom Rini
On Wed, Feb 26, 2020 at 04:57:51AM +0100, Heinrich Schuchardt wrote: > On 2/25/20 10:30 PM, Tom Rini wrote: > > On Tue, Feb 25, 2020 at 10:04:53PM +0100, Heinrich Schuchardt wrote: > > > > > Remove invalid URLs for "Information Technology - AT Attachment-3 > > > Interface > > > (ATA-3)". > > >

Re: [PATCH 1/1] include/ata.h: remove invalid links

2020-02-25 Thread Heinrich Schuchardt
On 2/25/20 10:30 PM, Tom Rini wrote: On Tue, Feb 25, 2020 at 10:04:53PM +0100, Heinrich Schuchardt wrote: Remove invalid URLs for "Information Technology - AT Attachment-3 Interface (ATA-3)". Signed-off-by: Heinrich Schuchardt --- include/ata.h | 4 1 file changed, 4 deletions(-)

Re: [PATCH 7/7] kconfig / kbuild: re-sync with Linux 4.18

2020-02-25 Thread Tom Rini
On Wed, Feb 26, 2020 at 10:04:10AM +0900, Masahiro Yamada wrote: > Hi Tom, > > On Tue, Feb 25, 2020 at 3:05 AM Tom Rini wrote: > > > > Align Kconfig and Kbuild logic to Linux 4.18 release with minimal impact > > on files outside of this scope. > > > > Our previous Kconfig sync was done by commit

Re: [PATCH 5/7] Azure / GitLab / Travis: Add Kconfig unit tests to a job

2020-02-25 Thread Masahiro Yamada
On Tue, Feb 25, 2020 at 3:06 AM Tom Rini wrote: > > The Kconfig language provides a unit test that can be run. As these > require pytest to be installed and run very quickly, bundle them in to > an existing CI job. > > Signed-off-by: Tom Rini Reviewed-by: Masahiro Yamada > --- >

Re: [PATCH 4/7] Kconfig: Remove redundant variable sets

2020-02-25 Thread Masahiro Yamada
On Tue, Feb 25, 2020 at 3:06 AM Tom Rini wrote: > > In a few places we have Kconfig entries that set SPL_LDSCRIPT to what is > the default value anyways. Drop these. > > Cc: Michal Simek > Cc: Rick Chen > Cc: Philippe Reynes > Cc: Eric Jarrige > Signed-off-by: Tom Rini > --- I see more in

Re: [PATCH 3/7] Kconfig: Escape variables to make in default strings

2020-02-25 Thread Masahiro Yamada
On Tue, Feb 25, 2020 at 3:05 AM Tom Rini wrote: > > We have some variables that need to include a variable to pass to make > to evaluate later, typically ARCH and BOARDDIR, to find a file to use. > The way we're doing this today isn't correct but works. With an update > to Kconfig we will need

Re: [PATCH 7/7] kconfig / kbuild: re-sync with Linux 4.18

2020-02-25 Thread Masahiro Yamada
Hi Tom, On Tue, Feb 25, 2020 at 3:05 AM Tom Rini wrote: > > Align Kconfig and Kbuild logic to Linux 4.18 release with minimal impact > on files outside of this scope. > > Our previous Kconfig sync was done by commit e91610da7c8a ("kconfig: > re-sync with Linux 4.17-rc4"). > > A very small number

Re: [PATCH] efi_selftest: Ensure we include the object directory for generated headers

2020-02-25 Thread Masahiro Yamada
Hi Tom, On Sat, Feb 22, 2020 at 6:52 AM Tom Rini wrote: > > On Fri, Feb 21, 2020 at 10:34:01PM +0100, Heinrich Schuchardt wrote: > > On 2/21/20 9:48 PM, Tom Rini wrote: > > > The current rules for generating -I lines for objects gives us both > > > -I/full/src/path/lib/efi_selftest and

Re: [PATCH v5 04/16] efi_loader: variable: support variable authentication

2020-02-25 Thread AKASHI Takahiro
On Tue, Feb 25, 2020 at 07:46:44AM +0100, Heinrich Schuchardt wrote: > On 1/28/20 9:25 AM, AKASHI Takahiro wrote: > > With this commit, EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS > > is supported for authenticated variables and the system secure state > > will transfer between setup mode

Re: [PATCH v5 07/16] efi_loader: image_loader: support image authentication

2020-02-25 Thread AKASHI Takahiro
On Tue, Feb 25, 2020 at 07:44:10AM +0100, Heinrich Schuchardt wrote: > On 1/28/20 9:25 AM, AKASHI Takahiro wrote: > > With this commit, image validation can be enforced, as UEFI specification > > section 32.5 describes, if CONFIG_EFI_SECURE_BOOT is enabled. > > > > Currently we support > > *

RE: [PATCH v2 10/21] arm: socfpga: Add secure register access helper functions for SoC 64bits

2020-02-25 Thread Ang, Chee Hong
> On 2/24/20 3:21 AM, Ang, Chee Hong wrote: > [...] > > > Currently, we have like 20+ secure registers allowed access by > > drivers running in non-secure mode (U-Boot proper / Linux). > > I don't think we want to define and maintain those high level > > interfaces for each of

[PATCH] arm: mvebu: update RTC values for PCIe memory wrappers

2020-02-25 Thread Chris Packham
From: Chris Packham Update the RTC (Read Timing Control) values for PCIe memory wrappers following an ERRATA (ERRATA# TDB). This means the PCIe accesses will used slower memory Read Timing, to allow more efficient energy consumption, in order to lower the minimum VDD of the memory. Will lead to

Re: [PATCHv2 4/4] scripts/Makefile.lib: Re-add -Wno-simple_bus_reg to DTC_FLAGS

2020-02-25 Thread Masahiro Yamada
On Tue, Feb 25, 2020 at 2:51 AM Tom Rini wrote: > > This exists in Linux Kernel with commit 70523a3ce5ff so put it in the > list of DTC_FLAGS that mirror Linux as we will catch up there. > > Signed-off-by: Tom Rini Reviewed-by: Masahiro Yamada > --- > scripts/Makefile.lib | 1 + > 1 file

Re: [PATCHv2 3/4] scripts/Makefile.lib: Restore PCI related warnings to DTC_FLAGS

2020-02-25 Thread Masahiro Yamada
On Tue, Feb 25, 2020 at 2:51 AM Tom Rini wrote: > > While we are working on correcting usage related to the pci_bridge and > pci_device_bus_num warnings, disable these flags for now. > > Signed-off-by: Tom Rini Reviewed-by: Masahiro Yamada > --- > scripts/Makefile.lib | 4 > 1 file

Re: [PATCHv2 1/4] kbuild: fixdep: Resync this with v4.17

2020-02-25 Thread Masahiro Yamada
On Tue, Feb 25, 2020 at 2:50 AM Tom Rini wrote: > > The previous kbuild resync of e91610da7c8a ("kconfig: re-sync with Linux > 4.17-rc4") accidentally did not sync the fixdep program. This commit > brings fixdep in line with the rest of that previous resync. > > This includes all of the

Re: [PATCHv2 2/4] kbuild: Re-sync DTC flag logic with v4.17

2020-02-25 Thread Masahiro Yamada
Hi Tom, On Tue, Feb 25, 2020 at 2:50 AM Tom Rini wrote: > > The way that we have been handling additional DTC warning flags hasn't > matched the way the Linux Kernel does. Resync this logic with v4.17. > > Signed-off-by: Tom Rini If you entirely move DTC_FLAGS to scripts/Makefile.lib, you

[PATCH] kbuild: remove unused dtc-version.sh script

2020-02-25 Thread Masahiro Yamada
This is U-Boot own code, and no longer used since commit 36dd5f1b8abc ("dtc: Switch to building and using our own dtc unless provided"). Prior to that commit, U-Boot relied on an external dtc, so this script was used to check the dtc version. Now U-Boot bundles our own dtc in script/dtc/dtc like

Re: [PATCH] mmc: make self-contained

2020-02-25 Thread Jaehoon Chung
On 2/25/20 2:25 AM, Masahiro Yamada wrote: > This header uses bd_t without including its definition. > > Change it to (struct bd_info), and add the forward declaration > to specify it as a structure. > > Signed-off-by: Masahiro Yamada Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung >

Re: [PATCH 1/1] include/ata.h: remove invalid links

2020-02-25 Thread Tom Rini
On Tue, Feb 25, 2020 at 10:04:53PM +0100, Heinrich Schuchardt wrote: > Remove invalid URLs for "Information Technology - AT Attachment-3 Interface > (ATA-3)". > > Signed-off-by: Heinrich Schuchardt > --- > include/ata.h | 4 > 1 file changed, 4 deletions(-) > > diff --git a/include/ata.h

[PATCH 1/1] include/ata.h: remove invalid links

2020-02-25 Thread Heinrich Schuchardt
Remove invalid URLs for "Information Technology - AT Attachment-3 Interface (ATA-3)". Signed-off-by: Heinrich Schuchardt --- include/ata.h | 4 1 file changed, 4 deletions(-) diff --git a/include/ata.h b/include/ata.h index 3f4e4a0234..aecb9cd589 100644 --- a/include/ata.h +++

[PATCH 1/1] Kconfig: fix typos in CMD_BEDBUG description

2020-02-25 Thread Heinrich Schuchardt
Fix documentation bug reported by 'make refcheckdocs'. Signed-off-by: Heinrich Schuchardt --- cmd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index 6403bc45a5..c9ea11 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -2095,7 +2095,7 @@

[PATCH 1/1] doc: fix references to driver-model

2020-02-25 Thread Heinrich Schuchardt
Fix some errors pointed out by 'make refcheckdocs'. Signed-off-by: Heinrich Schuchardt --- doc/README.drivers.eth | 2 +- doc/README.fdt-control | 2 +- drivers/i2c/davinci_i2c.c | 2 +- drivers/i2c/kona_i2c.c | 2 +- drivers/i2c/sh_i2c.c | 2 +- drivers/i2c/soft_i2c.c |

Fixing low-speed USB keyboard detection

2020-02-25 Thread Stefan
Hello! I own a D-Link DBT-120 Bluetooth Adapter, which has a CSR firmware running in a so called “HID proxy mode”. This firmware pretends to be a USB keyboard (and mouse) and thus allows to use a Bluetooth keyboard in U-Boot. Unfortunately it acts as a low-speed device and there seems to be

[PATCH 1/1] scripts: add documentation-file-ref-check

2020-02-25 Thread Heinrich Schuchardt
'make refcheckdocs' requires scripts/documentation-file-ref-check. Adopt script from Linux v5.6-rc3. Signed-off-by: Heinrich Schuchardt --- scripts/documentation-file-ref-check | 226 +++ 1 file changed, 226 insertions(+) create mode 100755

Re: [RFC PATCH 00/10] arm: add support for SoC S5P4418

2020-02-25 Thread Stefan B.
Hi Amit, Am 22.02.20 um 14:06 schrieb Amit Tomer: Hi, On Tue, Feb 4, 2020 at 1:12 AM Stefan Bosch wrote: This patch adds support for SAMSUNG's/NEXELL's ARM Cortex-A9 based S5P4418 SoC, especially FriendlyARM's NanoPi2 and NanoPC-T2 boards. It is based on the following FriendlyARM's U-Boot

Re: [PATCH] tools: image-host.c: remove uboot_aes.h

2020-02-25 Thread Tom Rini
On Tue, Feb 18, 2020 at 05:23:20PM +0100, Philippe Reynes wrote: > The include uboot_aes.h is not usefull and > it breaks the compilation on android, so > we remove it. > > Signed-off-by: Philippe Reynes > Reported-by: Praneeth Bajjuri Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 1/1] MAINTAINERS: set maintainer for doc/api/efi.rst

2020-02-25 Thread Tom Rini
On Sat, Feb 22, 2020 at 07:45:50AM +0100, Heinrich Schuchardt wrote: > doc/api/efi.rst belongs to the UEFI sub-system documentation. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/2] moveconfig: replace unsafe eval with asteval

2020-02-25 Thread Tom Rini
On Wed, Feb 12, 2020 at 08:46:44PM +0100, Markus Klotzbuecher wrote: > Commit b237d358b "moveconfig: expand simple expressions" added support > for expanding expressions in configs, but used the unsafe python > built-in "eval". This patch fixes this by replacing eval with the > asteval module. >

Re: [PATCH 2/2] moveconfig: convert ps.stderr to string

2020-02-25 Thread Tom Rini
On Wed, Feb 12, 2020 at 08:46:45PM +0100, Markus Klotzbuecher wrote: > Printing the error message in verbose mode fails, since python3 > doesn't implicitely convert bytes to strings. > > Signed-off-by: Markus Klotzbuecher > Cc: Simon Glass > Cc: Tom Rini > Cc: Masahiro Yamada > Reviewed-by:

Re: [PATCH] arch: arm: Fix SZ_64K undeclared compilation error

2020-02-25 Thread Tom Rini
On Fri, Feb 14, 2020 at 11:00:52AM +0530, Wasim Khan wrote: > Macro SZ_64K is undeclared. Include sizes.h to fix the compilation > error. > > Signed-off-by: Wasim Khan > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] board: novtech: meerkat96: use correct mmc driver

2020-02-25 Thread Tom Rini
On Wed, Jan 22, 2020 at 04:03:02PM -0500, Carl Gelfand wrote: > When the board was originally submitted, it was attempting to use the > ESDHC driver. The board uses the USDHC driver. > > Signed-off-by: Carl Gelfand > Cc: Shawn Guo (maintainer:MEERKAT96 BOARD) > Acked-by: Shawn Guo Applied to

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

2020-02-25 Thread Westergreen, Dalon
On Tue, 2020-02-25 at 18:55 +0100, Marek Vasut wrote: > On 2/24/20 3:26 AM, Ang, Chee Hong wrote: > > > On 2/21/20 7:15 PM, Ang, Chee Hong wrote: > > > > > On 2/20/20 6:04 PM, Westergreen, Dalon wrote: > > > > > > > > > > Please fix your mailer, it makes your reply completely unreadable. > > >

Re: [PATCH] doc: Makefile: remove target refcheckdocs

2020-02-25 Thread Tom Rini
On Tue, Feb 25, 2020 at 07:10:01PM +0100, Heinrich Schuchardt wrote: > On 2/25/20 7:00 PM, Patrick Delaunay wrote: > > Remove the target refcheckdocs, based on the missing script > > scripts/documentation-file-ref-check. > > > > This script exists in Linux tree but wasn't imported when 'doc' move

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

2020-02-25 Thread Marek Vasut
On 2/25/20 7:26 PM, Westergreen, Dalon wrote: > > > On Tue, 2020-02-25 at 18:55 +0100, Marek Vasut wrote: > > On 2/24/20 3:26 AM, Ang, Chee Hong wrote: > > On 2/21/20 7:15 PM, Ang, Chee Hong wrote: > > On 2/20/20 6:04 PM, Westergreen, Dalon wrote: > > > Please fix your mailer, it makes your

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

2020-02-25 Thread Westergreen, Dalon
On Tue, 2020-02-25 at 18:55 +0100, Marek Vasut wrote: On 2/24/20 3:26 AM, Ang, Chee Hong wrote: On 2/21/20 7:15 PM, Ang, Chee Hong wrote: On 2/20/20 6:04 PM, Westergreen, Dalon wrote: Please fix your mailer, it makes your reply completely unreadable. On Thu, 2020-02-20 at 17:44 +0100,

[PATCH] tiny-printf: revert patch to fix spl eth boot

2020-02-25 Thread Moses Christopher
From: Moses Christopher Bollavarapu - Revert commit 831c16111959 ("tiny-printf: Reorder code to support %p") The mentioned commit does not handle the ethaddr properly. Hence, I tried to disable SPL_TINY_PRINTF, but then it was suggested to keep using the tiny-printf library in SPL

Re: [U-Boot] [PATCH] usb: ehci-mx5: Fix bus enumeration for DM case

2020-02-25 Thread Marek Vasut
On 2/24/20 4:28 PM, Lukasz Majewski wrote: > Hi Marek, Hi, >> On Thu, 20 Jun 2019 22:53:58 +0200 >> Marek Vasut wrote: >> >>> It is likely that the DM conversion of EHCI iMX5 driver was a >>> derivative of EHCI VF, however the conversion is incomplete and is >>> missing the bind workaround,

Re: [PATCH v2 10/21] arm: socfpga: Add secure register access helper functions for SoC 64bits

2020-02-25 Thread Marek Vasut
On 2/24/20 3:21 AM, Ang, Chee Hong wrote: [...] > Currently, we have like 20+ secure registers allowed access by > drivers running in non-secure mode (U-Boot proper / Linux). > I don't think we want to define and maintain those high level > interfaces for each of those secure

Re: [PATCH v2 01/21] configs: agilex: Remove CONFIG_OF_EMBED

2020-02-25 Thread Marek Vasut
On 2/24/20 3:26 AM, Ang, Chee Hong wrote: >> On 2/21/20 7:15 PM, Ang, Chee Hong wrote: On 2/20/20 6:04 PM, Westergreen, Dalon wrote: Please fix your mailer, it makes your reply completely unreadable. > On Thu, 2020-02-20 at 17:44 +0100, Marek Vasut wrote: > > On

Re: [PATCH] doc: Makefile: remove target refcheckdocs

2020-02-25 Thread Heinrich Schuchardt
On 2/25/20 7:00 PM, Patrick Delaunay wrote: Remove the target refcheckdocs, based on the missing script scripts/documentation-file-ref-check. This script exists in Linux tree but wasn't imported when 'doc' move to SPHINX in commit 78a88f7930be ("doc: Replace DocBook with sphinx-based docs")

[PATCH v3] doc: add board documentation for stm32mp1

2020-02-25 Thread Patrick Delaunay
Change plain test README to rst format and move this file in documentation directory. Signed-off-by: Patrick Delaunay Tested-by: Heinrich Schuchardt Reviewed-by: Patrice Chotard --- Hi, it is V3 for the previous patch http://patchwork.ozlabs.org/patch/1239891/ I check output with $> make

[PATCH] doc: Makefile: remove target refcheckdocs

2020-02-25 Thread Patrick Delaunay
Remove the target refcheckdocs, based on the missing script scripts/documentation-file-ref-check. This script exists in Linux tree but wasn't imported when 'doc' move to SPHINX in commit 78a88f7930be ("doc: Replace DocBook with sphinx-based docs") This patch avoids the error: make refcheckdocs

[PATCH 1/1] vexpress_ca9x4: Enable use of correct DTB file and restore EFI loader.

2020-02-25 Thread Kristian Amlie
EFI was disabled in f95b8a4b5f64f because of the missing DTB file, and indeed, the DTB file is required to load recent versions of GRUB (2.04) correctly. Signed-off-by: Kristian Amlie --- configs/vexpress_ca9x4_defconfig | 2 +- include/configs/vexpress_common.h | 3 ++- 2 files changed, 3

Re: [PATCH] watchdog: mpc8xx: Revert the 8xx watchdog back to CONFIG_HW_WATCHDOG

2020-02-25 Thread Tom Rini
On Thu, Feb 20, 2020 at 07:39:51AM +, Christophe Leroy wrote: > Commit f3729ba6e7b2 ("watchdog: mpc8xx_wdt: Watchdog driver and macros > cleanup") switched the watchdog to CONFIG_WATCHDOG. But this is not > compatible with the 8xx because it starts the watchdog HW timer at > reset and must be

[PATCH] env: Make mmc as default option for CONFIG_ENV_FAT_INTERFACE

2020-02-25 Thread Michal Simek
All configs are using mmc as default fat interface. That's why make it default for everybody. The reason for this patch is to make it default for Xilinx Zynq platform which is not listed there. Signed-off-by: Michal Simek --- Defconfig resync will remove some lines when this patch is applied.

[PATCH 3/4] ARM: zynq: Do not report NOR flash detection failure

2020-02-25 Thread Michal Simek
With multi defconfig targeting several board configurations bug report like below is so verbose. Flash: ## Unknown flash on Bank 1 - Size = 0x = 0 MB 0 Bytes Do not report that message and simply say "Flash: 0 Bytes" because most of Zynq boards are using different type of flashes than

[PATCH 2/4] nand: raw: zynq: Do not try to probe driver if nand flash is disabled

2020-02-25 Thread Michal Simek
There is no reason to continue when DT status property indicates that NAND flash is disabled. But that means that NOR flash should be present that's why try it find it out. Signed-off-by: Michal Simek --- drivers/mtd/nand/raw/zynq_nand.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH 1/4] nand: raw: Do not free xnand structure

2020-02-25 Thread Michal Simek
xnand structure is private data structure and it is handled by core and probe shouldn't touch it. Signed-off-by: Michal Simek --- drivers/mtd/nand/raw/zynq_nand.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/mtd/nand/raw/zynq_nand.c

[PATCH 4/4] ARM: zynq: Enable DM for CFI NOR flash

2020-02-25 Thread Michal Simek
With multi defconfig NOR flash information about NOR should be taken from DT that's why there is no reason to specify address and sizes via fixed config. Signed-off-by: Michal Simek --- configs/xilinx_zynq_virt_defconfig | 1 + include/configs/zynq-common.h | 2 -- 2 files changed, 1

[PATCH] ARM: zynq: Remove single comment about QSPI

2020-02-25 Thread Michal Simek
Very likely configs have been moved to Kconfig by scripts and this just remains there that's why remove it. Signed-off-by: Michal Simek --- include/configs/zynq-common.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h index

Re: [PATCH v2 4/5] azure: build HTML documentation

2020-02-25 Thread Tom Rini
On Fri, Feb 21, 2020 at 06:24:02PM +0100, Heinrich Schuchardt wrote: > Several patches delivered incorrect restructured text as documentation. We > should be able to discover this in Azure CI. > > Provide a build step for 'make htmldocs'. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by:

Re: [PATCH v2 3/5] gitlab: build HTML documentation

2020-02-25 Thread Tom Rini
On Fri, Feb 21, 2020 at 06:24:01PM +0100, Heinrich Schuchardt wrote: > Several patches delivered incorrect restructured text as documentation. We > should be able to discover this in Gitlab CI. > > Provide a build step for 'make htmldocs'. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by:

Re: [PATCH v2 5/5] doc/Makefile: turn warnings into errors

2020-02-25 Thread Tom Rini
On Fri, Feb 21, 2020 at 06:24:03PM +0100, Heinrich Schuchardt wrote: > Several patches delivered incorrect restructured text as documentation. We > should be able to discover this in Travis CI, Gitlab CI, or Azure CI. > > So let us turn all build warnings into errors. > > Signed-off-by:

Re: [PATCH v2 2/5] travis: build HTML docs

2020-02-25 Thread Tom Rini
On Fri, Feb 21, 2020 at 06:24:00PM +0100, Heinrich Schuchardt wrote: > Several patches delivered incorrect restructured text as documentation. > We should be able to discover this in Travis CI. > > Provide a build step for 'make htmldocs'. > > Add required package graphviz. > > Signed-off-by:

Re: [PATCH] Azure / GitLab: Update Docker image

2020-02-25 Thread Tom Rini
On Mon, Feb 24, 2020 at 11:04:58AM -0500, Tom Rini wrote: > Bring in a newer Docker image to build on that has everything required > for running 'make htmldocs'. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 1/5] doc: update doc/sphinx/kerneldoc.py

2020-02-25 Thread Tom Rini
On Fri, Feb 21, 2020 at 06:23:59PM +0100, Heinrich Schuchardt wrote: > Update doc/sphinx/kerneldoc.py from Linux next-20200219 to avoid warnings > like: > > doc/sphinx/kerneldoc.py:125: RemovedInSphinx20Warning: > AutodocReporter is now deprecated. Use >

Re: [PATCH 4/5] dt-bindings: pinctrl: add i.MXRT1020 pins definition

2020-02-25 Thread Giulio Benetti
On 2/20/20 11:51 PM, Lukasz Majewski wrote: On Tue, 18 Feb 2020 20:02:54 +0100 Giulio Benetti wrote: Add i.MXRT1020 pins definition. Are those definitions ported from Linux kernel? Signed-off-by: Giulio Benetti --- include/dt-bindings/pinctrl/pins-imxrt1020.h | 763 +++

Re: [PATCH] doc: Chromebook Coral: Fix typo for "Top of CAR region"

2020-02-25 Thread Bin Meng
On Fri, Feb 21, 2020 at 7:20 PM Wolfgang Wallner wrote: > > The value for "Top of CAR region" should be fefc, not > fefc000. This matches the Kconfig default values, as > SYS_CAR_ADDR and SYS_CAR_SIZE are 0xfef0 and 0xc > respectively. > > Signed-off-by: Wolfgang Wallner > > --- > >

Re: [PATCH 2/2] x86: apl: Use cpu_x86_get_count() for cpu_ops.get_count

2020-02-25 Thread Bin Meng
On Tue, Feb 25, 2020 at 8:19 PM Wolfgang Wallner wrote: > > Use cpu_x86_get_count() to read the number of cores. > > cpu_x86_get_count() reads the number of CPUs from the device tree. > Using this function we can support multiple Apollo Lake > variants, e.g.: E3940 (4 cores) and E3930 (2 cores).

Re: [PATCH 1/2] x86: cpu_x86: Make cpu_x86_get_count() non-static

2020-02-25 Thread Bin Meng
On Tue, Feb 25, 2020 at 8:19 PM Wolfgang Wallner wrote: > > The function cpu_x86_get_count() is also useful for other modules. > Make it non-static and add a prototype + description. > > Signed-off-by: Wolfgang Wallner > --- > > arch/x86/cpu/cpu_x86.c | 2 +- >

[PATCH] configs: stm32mp1: Resync with savedefconfig

2020-02-25 Thread Patrick Delaunay
Rsync all stm32mp1 defconfig files using moveconfig.py Signed-off-by: Patrick Delaunay --- configs/stm32mp15_basic_defconfig | 2 +- configs/stm32mp15_optee_defconfig | 2 +- configs/stm32mp15_trusted_defconfig | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 2/2] x86: apl: Use cpu_x86_get_count() for cpu_ops.get_count

2020-02-25 Thread Wolfgang Wallner
Use cpu_x86_get_count() to read the number of cores. cpu_x86_get_count() reads the number of CPUs from the device tree. Using this function we can support multiple Apollo Lake variants, e.g.: E3940 (4 cores) and E3930 (2 cores). This was tested on the E3940 and E3930 Apollo Lake variants.

[PATCH 0/2] x86: apl: Add support for different number of cores

2020-02-25 Thread Wolfgang Wallner
Currently the Apollo Lake implementation of cpu_ops.get_count returns a hardcoded value of 4. The function cpu_x86_get_count() provides a more generic implementation that reads the number of cores from device tree. But this function is currently static. This series: - makes

[PATCH 1/2] x86: cpu_x86: Make cpu_x86_get_count() non-static

2020-02-25 Thread Wolfgang Wallner
The function cpu_x86_get_count() is also useful for other modules. Make it non-static and add a prototype + description. Signed-off-by: Wolfgang Wallner --- arch/x86/cpu/cpu_x86.c | 2 +- arch/x86/include/asm/cpu_x86.h | 12 2 files changed, 13 insertions(+), 1

RE: [PATCH v4 01/14] misc: add driver for the SiFive otp controller

2020-02-25 Thread Pragnesh Patel
Hi Patrick, >-Original Message- >From: Patrick DELAUNAY >Sent: 24 February 2020 23:34 >To: Pragnesh Patel ; u-boot@lists.denx.de >Cc: atish.pa...@wdc.com; palmerdabb...@google.com; >bmeng...@gmail.com; Paul Walmsley ( Sifive) ; >ja...@amarulasolutions.com; Troy Benjegerdes ( Sifive) >;

[PATCH] net: zynq_gem: Add cache flush to zynq_gem_free_pkt

2020-02-25 Thread Michal Simek
From: Ashok Reddy Soma Add cache flush to zynq_gem_free_pkt. This is necessary because some net routines would modify this buffer in place. The cache_invalidate in the zynq_gem_recv function would cause the modifications to the buffer to overwrite the DMA from the GEM, if cache coherency is not

RE: [PATCH v4 02/14] riscv: sifive: fu540: Use OTP DM driver for serial environment variable

2020-02-25 Thread Pragnesh Patel
Hi Patrick, >-Original Message- >From: Patrick DELAUNAY >Sent: 24 February 2020 23:30 >To: Pragnesh Patel ; u-boot@lists.denx.de >Cc: atish.pa...@wdc.com; palmerdabb...@google.com; >bmeng...@gmail.com; Paul Walmsley ( Sifive) ; >ja...@amarulasolutions.com; Troy Benjegerdes ( Sifive) >;

Re: [PATCH v2] arm: imx6: configure NoC on i.MX6DQP

2020-02-25 Thread Filip Brozović
On Mon, Feb 24, 2020 at 10:38 AM Bernhard Messerklinger wrote: > My assumption would be that this can be solved by adding "Co-Developed-by:" > and > "Signed-off-by:" lines to this patch for Filip Brozovic (see [1] for a > discussion of this topic on LKML). Filip, would this be ok for you?

RE: [U-Boot Patch v2 3/4] dts: u-boot.dtsi: override flash tx-rx width

2020-02-25 Thread Sagar Kadam
Hello Jagan, > -Original Message- > From: Bin Meng > Sent: Wednesday, February 19, 2020 9:59 PM > To: Sagar Kadam > Cc: U-Boot Mailing List ; Rick Chen > ; Paul Walmsley ( Sifive) ; > Jagan Teki ; Anup Patel > > Subject: Re: [U-Boot Patch v2 3/4] dts: u-boot.dtsi: override flash tx-rx

  1   2   >