Re: [PATCH] checkpatch: fix a false check against wchar/utf-16 string

2020-07-02 Thread AKASHI Takahiro
On Thu, Jul 02, 2020 at 04:26:34PM -0400, Tom Rini wrote: > On Thu, Jul 02, 2020 at 07:00:04PM +0200, Heinrich Schuchardt wrote: > > On 16.06.20 16:17, Tom Rini wrote: > > > On Tue, Jun 16, 2020 at 02:43:07PM +0900, AKASHI Takahiro wrote: > > > > > >> UEFI subsystem uses utf-16 string, but

Re: [PATCH v5 1/3] gpio-uclass.c: save the GPIOD flags also in the gpio descriptor

2020-07-02 Thread Heiko Schocher
Hello Baruch, Am 02.07.2020 um 21:05 schrieb Baruch Siach: Hi Heiko, On Fri, May 15 2020, Heiko Schocher wrote: save the GPIOD_ flags also in the gpio descriptor. Signed-off-by: Heiko Schocher Reviewed-by: Patrick Delaunay Reviewed-by: Simon Glass This fixes SD card access on

Re: [PATCH v1 07/43] dm: acpi: Add support for the NHLT table

2020-07-02 Thread Bin Meng
Hi Simon, On Fri, Jul 3, 2020 at 11:50 AM Simon Glass wrote: > > Hi Bin, > > On Thu, 2 Jul 2020 at 18:54, Bin Meng wrote: > > > > Hi Simon, > > > > On Fri, Jul 3, 2020 at 8:46 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Mon, 29 Jun 2020 at 20:49, Bin Meng wrote: > > > > > > > >

Re: [PATCH 07/17] serial: serial_xen: Add Xen PV serial driver

2020-07-02 Thread Simon Glass
Hi Anastasiia, On Wed, 1 Jul 2020 at 10:30, Anastasiia Lukianenko wrote: > > From: Peng Fan > > Add support for Xen para-virtualized serial driver. This > driver fully supports serial console for the virtual machine. > > Please note that as the driver is initialized late, so no banner > nor

Re: [PATCH] Add information for skipped commit options

2020-07-02 Thread Simon Glass
On Thu, 2 Jul 2020 at 11:53, Patrick Delaunay wrote: > > The unsupported Commit-xxx option are silently skipped > and removed as 're_remove=Commit-\w*', this patch adds > warning message in this case to detect misspelled issue > for the 2 supported options: > Commit-notes: > Commit-changes: >

Re: [PATCH] video: restore CONFIG_VIDCONSOLE_AS_LCD as boolean

2020-07-02 Thread Simon Glass
On Wed, 1 Jul 2020 at 06:56, Patrick Delaunay wrote: > > This patch restores CONFIG_VIDCONSOLE_AS_LCD as boolean > and introduce a separate sting as CONFIG_VIDCONSOLE_AS_NAME > to search this string in stdout used as videoconsole. > > This patch avoid issue with board defconfig or code expecting

Re: [PATCH 14/17] xen: pvblock: Read XenStore configuration and initialize

2020-07-02 Thread Simon Glass
Hi Anastasiia, On Wed, 1 Jul 2020 at 10:30, Anastasiia Lukianenko wrote: > > From: Anastasiia Lukianenko > > Read essential virtual block device configuration data from XenStore, > initialize front ring and event channel. > Update block device description with actual block size. > > Use code

Re: [PATCH 13/17] xen: pvblock: Enumerate virtual block devices

2020-07-02 Thread Simon Glass
On Wed, 1 Jul 2020 at 10:30, Anastasiia Lukianenko wrote: > > From: Anastasiia Lukianenko > > Enumerate Xen virtual block devices found in XenStore and > instantiate pvblock devices. > > Signed-off-by: Oleksandr Andrushchenko > Signed-off-by: Anastasiia Lukianenko > --- >

Re: [PATCH] lib: libfdt: fdt_region: avoid NULL pointer access

2020-07-02 Thread Simon Glass
On Thu, 2 Jul 2020 at 11:31, Philippe Reynes wrote: > > The function fdt_find_regions look in the exclude list for each > property, even if the name is NULL. It could happen if the fit > image is corrupted. On sandbox, it generates a segfault. > > To avoid this issue, if the name of a property is

Re: [PATCH 15/17] xen: pvblock: Implement front-back protocol and do IO

2020-07-02 Thread Simon Glass
On Wed, 1 Jul 2020 at 10:30, Anastasiia Lukianenko wrote: > > From: Anastasiia Lukianenko > > Implement Xen para-virtual frontend to backend communication > and actually read/write disk data. > > This is based on mini-os implementation of the para-virtual block > frontend driver. > >

Re: [PATCH 16/17] xen: pvblock: Print found devices indices

2020-07-02 Thread Simon Glass
On Wed, 1 Jul 2020 at 10:30, Anastasiia Lukianenko wrote: > > From: Anastasiia Lukianenko > > Signed-off-by: Oleksandr Andrushchenko > Signed-off-by: Anastasiia Lukianenko > --- > drivers/xen/pvblock.c | 20 > 1 file changed, 20 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH 17/17] board: xen: De-initialize before jumping to Linux

2020-07-02 Thread Simon Glass
On Wed, 1 Jul 2020 at 10:30, Anastasiia Lukianenko wrote: > > From: Oleksandr Andrushchenko > > Free resources used by Xen board before jumping to Linux kernel. > > Signed-off-by: Oleksandr Andrushchenko > Signed-off-by: Anastasiia Lukianenko > --- > board/xen/xenguest_arm64/xenguest_arm64.c

Re: [PATCH 06/17] xen: Port Xen event channel driver from mini-os

2020-07-02 Thread Simon Glass
Hi, On Wed, 1 Jul 2020 at 10:30, Anastasiia Lukianenko wrote: > > From: Oleksandr Andrushchenko > > Make required updates to run on u-boot. Strip functionality > not needed by U-boot. > > Signed-off-by: Oleksandr Andrushchenko > Signed-off-by: Anastasiia Lukianenko > --- >

Re: [PATCH] patman: Detect unexpected END

2020-07-02 Thread Simon Glass
On Thu, 2 Jul 2020 at 11:08, Patrick Delaunay wrote: > > Detect unexpected 'END' line when a section is not detected. > > This patch detect issue when tag name for section start is misspelled, > for example 'Commit-note:' for 'Commit-notes:' > > Commit-note: > > END > > Then

Re: [PATCH v9 1/2] led: led_cortina: Add CAxxx LED support

2020-07-02 Thread Simon Glass
On Tue, 30 Jun 2020 at 22:08, Alex Nemirovsky wrote: > > From: Jway Lin > > Add Cortina Access LED controller support for CA SOCs > > Signed-off-by: Jway Lin > Signed-off-by: Alex Nemirovsky > CC: Simon Glass > > Add head file fixed link error and remove unused flashing function > > --- >

Re: [PATCH 1/2] drivers: p2sb: replace Primary-to-Sideband Bus with Primary to Sideband Bridge

2020-07-02 Thread Simon Glass
On Wed, 1 Jul 2020 at 03:00, Wolfgang Wallner wrote: > > In Intel's documentation the term P2SB stands for "Primary to Sideband > Bridge". > > Signed-off-by: Wolfgang Wallner > --- > > drivers/misc/Kconfig | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v3 2/2] x86: p2sb: make P2SB driver depend on P2SB uclass

2020-07-02 Thread Simon Glass
On Wed, 1 Jul 2020 at 05:37, Wolfgang Wallner wrote: > > Currently it is possible to select the P2SB driver without selecting the > P2SB uclass, which can't work. Fix this by adding a "depends on" in > Kconfig. > > Signed-off-by: Wolfgang Wallner > > --- > > (no changes since v2) > > Changes in

Re: [PATCH 02/17] Kconfig: Introduce CONFIG_XEN

2020-07-02 Thread Simon Glass
Hi Anastasiia, On Wed, 1 Jul 2020 at 10:30, Anastasiia Lukianenko wrote: > > From: Peng Fan > > Introduce CONFIG_XEN to make U-Boot could be used as bootloader > for a virtual machine. > > Without bootloader, we could successfully boot up android on XEN, but > we need need bootloader to support

Re: [PATCH v3 1/2] drivers: p2sb: replace Primary-to-Sideband Bus with Primary to Sideband Bridge

2020-07-02 Thread Simon Glass
On Wed, 1 Jul 2020 at 05:37, Wolfgang Wallner wrote: > > In Intel's documentation the term P2SB stands for "Primary to Sideband > Bridge". > > Signed-off-by: Wolfgang Wallner > --- > > Changes in v3: > - Replaced the term in two more places > > drivers/misc/Kconfig | 12 ++-- > 1 file

Re: [PATCH 1/8] dm: soc: Introduce UCLASS_SOC for SOC ID and attribute matching

2020-07-02 Thread Simon Glass
On Mon, 29 Jun 2020 at 22:38, Dave Gerlach wrote: > > Introduce UCLASS_SOC to be used for SOC identification and attribute > matching based on the SoC ID info. This allows drivers to be provided > for SoCs to retrieve SoC identifying information and also for matching > device attributes for

Re: [PATCH 2/8] test: Add tests for SOC uclass

2020-07-02 Thread Simon Glass
On Mon, 29 Jun 2020 at 22:38, Dave Gerlach wrote: > > Add a sandbox SOC driver, and some tests for the SOC uclass. > > Signed-off-by: Dave Gerlach > --- > arch/sandbox/dts/test.dts | 4 + > configs/sandbox64_defconfig| 1 + > configs/sandbox_defconfig | 1 + >

Re: [PATCH v1 07/43] dm: acpi: Add support for the NHLT table

2020-07-02 Thread Simon Glass
Hi Bin, On Thu, 2 Jul 2020 at 18:54, Bin Meng wrote: > > Hi Simon, > > On Fri, Jul 3, 2020 at 8:46 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Mon, 29 Jun 2020 at 20:49, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Mon, Jun 15, 2020 at 11:57 AM Simon Glass wrote: > > > > > > > >

[RESEND PATCH v3 21/26] video: Correctly handle multiple framebuffers

2020-07-02 Thread Simon Glass
At present video_bottom is set to the bottom of each framebuffer when it is allocated. This is not correct, since it should hold the bottom of the entire area available for framebuffers. Fix this by adding a private address in the uclass which keeps track of the next available spot for a

[RESEND PATCH v3 20/26] x86: fsp: video: Allocate a frame buffer when needed

2020-07-02 Thread Simon Glass
When the copy framebuffer is in use, we must also have the standard U-Boot framebuffer available. Update the FSP driver to support this. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- (no changes since v1) arch/x86/lib/fsp/fsp_graphics.c | 12 1 file changed, 12

[RESEND PATCH v3 26/26] x86: minnowmax: Drop screen resolution to 1024x768

2020-07-02 Thread Simon Glass
This seems like a more reasonable resolution for this board, since it is quite slow. It also allows it to work with a 5" LCD display in my lab. Signed-off-by: Simon Glass --- (no changes since v1) configs/minnowmax_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[RESEND PATCH v3 16/26] video: Update the copy framebuffer when writing bitmaps

2020-07-02 Thread Simon Glass
Adjust the bitmap code to sync to the copy framebuffer when done. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- (no changes since v1) drivers/video/video_bmp.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/video/video_bmp.c

[RESEND PATCH v3 22/26] x86: video: Support copy framebuffer with probed devices

2020-07-02 Thread Simon Glass
For PCI video devices that are not mentioned in the devicetree, U-Boot does not bind a driver before relocation, since PCI is not fully probed at that point. Furthermore it is possible for the video device to be on a secondary bus which is not even scanned. This is fine if the framebuffer is

[RESEND PATCH v3 19/26] video: pci: Set up the copy framebuffer

2020-07-02 Thread Simon Glass
When using a copy framebuffer we need to tell the video subsystem its address. U-Boot's normally allocated framebuffer is used as the working buffer, but nothing is displayed until it is copied to the copy framebuffer. For this to work the video driver must request that a framebuffer be allocated

[RESEND PATCH v3 17/26] video: Add comments to struct sandbox_sdl_plat

2020-07-02 Thread Simon Glass
This struct is not commented but needs it. Also fix the comment in check_vidconsole_output() about the encoding for the rotation value. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- (no changes since v1) include/dm/test.h | 14 +- test/dm/video.c | 3 ++- 2

[RESEND PATCH v3 14/26] video: Update truetype console to support copy buffer

2020-07-02 Thread Simon Glass
Update the implementation to keep a track of what it changes in the frame buffer and then tell the copy buffer about it. Use the special vidconsole_memmove() helper so that memmove() operations are also reflected in the copy buffer. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin ---

[RESEND PATCH v3 12/26] video: Add helpers for vidconsole for the copy framebuffer

2020-07-02 Thread Simon Glass
Add a convenience function to call video_sync_copy() for a vidconsole. Also add a memmove() helper, which does the memmove() as well as the sync. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- Changes in v3: - Drop unnecessary variable Changes in v2: - Simplify return sequence

[RESEND PATCH v3 18/26] video: sandbox: Add support for the copy framebuffer

2020-07-02 Thread Simon Glass
Enable this feature on sandbox by updating the SDL driver to have two framebuffers. Update the video tests to check that the copy framebuffer is kept in sync. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- (no changes since v1) configs/sandbox_defconfig | 1 +

[RESEND PATCH v3 15/26] video: Update rotated console to support copy buffer

2020-07-02 Thread Simon Glass
Update the implementation to keep a track of what it changes in the frame buffer and then tell the copy buffer about it. Use the special vidconsole_memmove() helper so that memmove() operations are also reflected in the copy buffer. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin ---

[RESEND PATCH v3 08/26] video: Add a comment for struct video_uc_platdata

2020-07-02 Thread Simon Glass
Add a few notes to explain the purpose of each member of this struct. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- (no changes since v1) include/video.h | 12 1 file changed, 12 insertions(+) diff --git a/include/video.h b/include/video.h index

[RESEND PATCH v3 10/26] video: Set up the copy framebuffer when enabled

2020-07-02 Thread Simon Glass
This framebuffer is separately mapped. Update the video post-probe function to set this up. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- (no changes since v1) drivers/video/video-uclass.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/video-uclass.c

[RESEND PATCH v3 13/26] video: Update normal console to support copy buffer

2020-07-02 Thread Simon Glass
Update the implementation to keep a track of what it changes in the frame buffer and then tell the copy buffer about it. Use the special vidconsole_memmove() helper so that memmove() operations are also reflected in the copy buffer. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin ---

[RESEND PATCH v3 07/26] video: Drop unnecessary #ifdef around vid_console_color()

2020-07-02 Thread Simon Glass
All of the functions in this file only apply if DM_VIDEO is enabled. Drop the #ifdef as it just clutters things up. Add the needed forward declaration. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- (no changes since v1) include/video_console.h | 6 ++ 1 file changed, 2

[RESEND PATCH v3 11/26] video: Clear the copy framebuffer when clearing the screen

2020-07-02 Thread Simon Glass
Update video_clear() to also sync to the copy framebuffer. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- (no changes since v1) drivers/video/video-uclass.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c

[RESEND PATCH v3 09/26] video: Add support for copying to a hardware framebuffer

2020-07-02 Thread Simon Glass
Some architectures use a cached framebuffer and flush the cache as needed so that changes are visible. This is supported by U-Boot. However x86 uses an uncached framebuffer with a 'write-combining' feature to speed up writes. Reads are permitted but they are extremely expensive. Unfortunately,

[RESEND PATCH v3 06/26] video: Adjust rotated console to start at right edge

2020-07-02 Thread Simon Glass
At present when the console is rotated 180 degrees it starts almost a whole character to the left of the right edge (typically 7 pixels with an 8-pixel-wide font). On a display which aligns with the font width, this just wastes space. On a display that does not this can result in x_frac going

[RESEND PATCH v3 04/26] sandbox: video: Allow selection of rotated console

2020-07-02 Thread Simon Glass
Add a devicetree property to select a rotated console. This uses the same encoding as vidconsole itself: 0=normal; 1=90 degrees clockwise, 2=upside down, 3=90 degrees anticlockwise. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- (no changes since v1)

[RESEND PATCH v3 03/26] video: Show an error when a vidconsole function fails

2020-07-02 Thread Simon Glass
At present these functions fail silently even when debugging, which is not very helpful. Add a way to print a message to the serial output when an error is detected. Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin --- (no changes since v1) drivers/video/vidconsole-uclass.c | 22

[RESEND PATCH v3 05/26] video: Split out expression parts into variables

2020-07-02 Thread Simon Glass
The functions in this file do similar things but not always in the same way. To make the code easier to read and compare, use a separate 'linenum' variable in every function. This is then multiplied by the line length to get the offset within the frame buffer to modify. Also use an 'x' variable to

[RESEND PATCH v3 01/26] x86: fsp: Reinit the FPU after FSP meminit

2020-07-02 Thread Simon Glass
The APL FSP appears to leave the FPU in a bad state in that it has registers in use. This causes an error when the next FPU operation is performed. Work around this by re-resetting the FPU after calling FSP-M. This allows the freetype console to work correctly. Signed-off-by: Simon Glass ---

[RESEND PATCH v3 00/26] x86: video: Speed up the framebuffer

2020-07-02 Thread Simon Glass
(resent for Bin, rebased to u-boot/next) Some architectures use a cached framebuffer and flush the cache as needed so that changes are visible. This is supported by U-Boot. However x86 uses an uncached framebuffer with a 'write-combining' feature to speed up writes. Reads are permitted but they

Re: [RFC PATCH v2 0/3] RFC: tiny-dm: Proposal for using driver model in SPL

2020-07-02 Thread Simon Glass
Hi Heinrich, On Thu, 2 Jul 2020 at 20:24, Heinrich Schuchardt wrote: > > > > Am 2. Juli 2020 23:10:01 MESZ schrieb Simon Glass : > >This series provides a proposed enhancement to driver model to reduce > >overhead in SPL. > > > >These patches should not be reviewed other than to comment on the >

Re: [RFC PATCH v2 0/3] RFC: tiny-dm: Proposal for using driver model in SPL

2020-07-02 Thread Heinrich Schuchardt
Am 2. Juli 2020 23:10:01 MESZ schrieb Simon Glass : >This series provides a proposed enhancement to driver model to reduce >overhead in SPL. > >These patches should not be reviewed other than to comment on the >approach. The code is all lumped together in a few patches and so >cannot >be

Re: [PATCH v1 18/43] x86: pinctrl: Update comment for intel_pinctrl_get_pad()

2020-07-02 Thread Bin Meng
Hi Simon, On Fri, Jul 3, 2020 at 8:46 AM Simon Glass wrote: > > Hi Bin, > > On Tue, 30 Jun 2020 at 00:43, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Jun 15, 2020 at 11:58 AM Simon Glass wrote: > > > > > > Add information about what is returned on error. > > > > > > Signed-off-by: Simon

Re: [PATCH v1 07/43] dm: acpi: Add support for the NHLT table

2020-07-02 Thread Bin Meng
Hi Simon, On Fri, Jul 3, 2020 at 8:46 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 29 Jun 2020 at 20:49, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Jun 15, 2020 at 11:57 AM Simon Glass wrote: > > > > > > The Intel Non-High-Definition-Audio Link Table (NHLT) table describes the > > >

Re: [PATCH v4 11/12] riscv: Add pinmux and gpio bindings for Kendryte K210

2020-07-02 Thread Simon Glass
On Wed, 24 Jun 2020 at 04:30, Sean Anderson wrote: > > This patch adds the necessary device tree bindings. > > Signed-off-by: Sean Anderson > > --- > > (no changes since v2) > > Changes in v2: > - Convert to use pinmux property > - Don't hog ISP on boot > - Re-order GPIOs to match the defaults

Re: [PATCH v1 07/43] dm: acpi: Add support for the NHLT table

2020-07-02 Thread Simon Glass
Hi Bin, On Mon, 29 Jun 2020 at 20:49, Bin Meng wrote: > > Hi Simon, > > On Mon, Jun 15, 2020 at 11:57 AM Simon Glass wrote: > > > > The Intel Non-High-Definition-Audio Link Table (NHLT) table describes the > > audio codecs and connections in a system. Various devices can contribute > >

Re: [PATCH v4 07/12] gpio: dw: Add a trailing underscore to generated name

2020-07-02 Thread Simon Glass
On Wed, 24 Jun 2020 at 04:30, Sean Anderson wrote: > > Previously, if there was no bank-name property, it was easy to have > confusing gpio names like "gpio1@08", instead of "gpio1@0_8". This patch > follows the example of the sifive gpio driver. > > Signed-off-by: Sean Anderson > --- > This

Re: [PATCH v4 02/12] pinctrl: Reformat documentation in dm/pinctrl.h

2020-07-02 Thread Simon Glass
On Wed, 24 Jun 2020 at 04:30, Sean Anderson wrote: > > This normalizes the documentatation to conform to kernel-doc style [1]. It > also moves the documentation for pinctrl_ops inline, and adds argument and > return-value documentation. I have kept the usual function style for these > comments. I

Re: [PATCH v4 10/12] test: dm: Test for default led naming

2020-07-02 Thread Simon Glass
On Wed, 24 Jun 2020 at 04:30, Sean Anderson wrote: > > This modifies the existing led test to check for default led naming as > added in the previous patch. > > Signed-off-by: Sean Anderson > --- > > Changes in v4: > - New > > arch/sandbox/dts/test.dts | 2 +- > test/dm/led.c | 3

Re: [PATCH v4 03/12] test: pinmux: Add test for pin muxing

2020-07-02 Thread Simon Glass
On Wed, 24 Jun 2020 at 04:30, Sean Anderson wrote: > > This extends the pinctrl-sandbox driver to support pin muxing, and adds a > test for that behaviour. The test is done in C and not python (like the > existing tests for the pinctrl uclass) because it needs to call > pinctrl_select_state.

Re: [PATCH v4 04/12] pinctrl: Add support for Kendryte K210 FPIOA

2020-07-02 Thread Simon Glass
On Wed, 24 Jun 2020 at 04:30, Sean Anderson wrote: > > The Fully-Programmable Input/Output Array (FPIOA) device controls pin > multiplexing on the K210. The FPIOA can remap any supported function to any > multifunctional IO pin. It can also perform basic GPIO functions, such as > reading the

Re: [PATCH v4 05/12] gpio: sifive: Use generic reg read function

2020-07-02 Thread Simon Glass
On Wed, 24 Jun 2020 at 04:30, Sean Anderson wrote: > > Using an fdt-specific function causes problems with a live tree. > > Signed-off-by: Sean Anderson > Reviewed-by: Bin Meng > --- > This patch was previously submitted as part of >

Re: [PATCH v1 20/43] x86: pinctrl: Set up itss in the probe() method

2020-07-02 Thread Simon Glass
Hi Bin, On Tue, 30 Jun 2020 at 00:43, Bin Meng wrote: > > Hi Simon, > > On Mon, Jun 15, 2020 at 11:58 AM Simon Glass wrote: > > > > At present the itss is probed in the ofdata_to_platdata() method. This is > > incorrect since itss is a child of p2sb which itself needs to probe the > > pinctrl

Re: [PATCH v3 06/15] board: ns3: default reset type to L3

2020-07-02 Thread Simon Glass
Hi Rayagonda, On Mon, 29 Jun 2020 at 22:43, Rayagonda Kokatanur wrote: > > Hi Simon, > > On Fri, Jun 26, 2020 at 6:42 AM Simon Glass wrote: > > > > Hi Rayagonda, > > > > On Wed, 10 Jun 2020 at 04:42, Rayagonda Kokatanur > > wrote: > > > > > > Default "reset" from u-boot to L3 reset. > > > >

Re: [PATCH v1 18/43] x86: pinctrl: Update comment for intel_pinctrl_get_pad()

2020-07-02 Thread Simon Glass
Hi Bin, On Tue, 30 Jun 2020 at 00:43, Bin Meng wrote: > > Hi Simon, > > On Mon, Jun 15, 2020 at 11:58 AM Simon Glass wrote: > > > > Add information about what is returned on error. > > > > Signed-off-by: Simon Glass > > --- > > > > arch/x86/include/asm/intel_pinctrl.h | 1 + > > 1 file

Re: [PATCH v2 1/1] fs: error handling in do_load()

2020-07-02 Thread Simon Glass
On Mon, 29 Jun 2020 at 12:08, Heinrich Schuchardt wrote: > > If a file cannot be loaded, show an error message. > Set the EFI boot device only after successfully loading a file. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > use if() instead of #ifdef > --- > fs/fs.c | 12

[RFC PATCH v2 1/3] dm: Driver and uclass changes for tiny-dm

2020-07-02 Thread Simon Glass
This includes various changes to support tiny-dm in serial, ram, clock, spi, SPI flash, syscon and sysreset drivers. Signed-off-by: Simon Glass --- (no changes since v1) drivers/clk/Kconfig | 54 + drivers/clk/Makefile | 4 +- drivers/clk/clk-uclass.c

[RFC PATCH v2 3/3] dm: Core changes for tiny-dm

2020-07-02 Thread Simon Glass
This patch includes changes to support tiny-dm in driver model and dtoc. Signed-off-by: Simon Glass --- Changes in v2: - Various updates, and ported to chromebook_jerry (rockchip) board/Synology/ds109/ds109.c| 3 +- common/console.c| 2 +- common/log.c

[RFC PATCH v2 2/3] dm: Arch-specific changes for tiny-dm

2020-07-02 Thread Simon Glass
Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/dts/rk3288-u-boot.dtsi | 17 -- arch/arm/dts/rk3288-veyron.dtsi | 26 - arch/arm/dts/rk3288.dtsi | 3 + arch/arm/include/asm/arch-rockchip/clock.h| 9 +++

[RFC PATCH v2 0/3] RFC: tiny-dm: Proposal for using driver model in SPL

2020-07-02 Thread Simon Glass
This series provides a proposed enhancement to driver model to reduce overhead in SPL. These patches should not be reviewed other than to comment on the approach. The code is all lumped together in a few patches and so cannot be applied as is. For now, the source tree is available at:

Re: [PATCH] checkpatch: fix a false check against wchar/utf-16 string

2020-07-02 Thread Tom Rini
On Thu, Jul 02, 2020 at 07:00:04PM +0200, Heinrich Schuchardt wrote: > On 16.06.20 16:17, Tom Rini wrote: > > On Tue, Jun 16, 2020 at 02:43:07PM +0900, AKASHI Takahiro wrote: > > > >> UEFI subsystem uses utf-16 string, but checkpatch.pl complains > >> about any occurrences of L"xxx" which is

Re: [PATCH v4 04/14] dtoc: add support to scan drivers

2020-07-02 Thread Simon Glass
Hi Walter, On Thu, 25 Jun 2020 at 19:43, Simon Glass wrote: > > On Wed, 24 Jun 2020 at 22:10, Walter Lozano > wrote: > > > > Currently dtoc scans dtbs to convert them to struct platdata and > > to generate U_BOOT_DEVICE entries. These entries need to be filled > > with the driver name, but at

Re: [PATCH v5 1/3] gpio-uclass.c: save the GPIOD flags also in the gpio descriptor

2020-07-02 Thread Baruch Siach
Hi Heiko, On Fri, May 15 2020, Heiko Schocher wrote: > save the GPIOD_ flags also in the gpio descriptor. > > Signed-off-by: Heiko Schocher > Reviewed-by: Patrick Delaunay > Reviewed-by: Simon Glass This fixes SD card access on Hummingboard2. Current master uses the wrong out polarity to

[PATCH v2 4/4] ram: stm32mp1: add size and addr parameter to test all

2020-07-02 Thread Patrick Delaunay
Add size and addr parameter to test "All" to override the default value (4kB and STM32_DDR_BASE) used in tests with these optional parameters: [size] or [addr]. When other optional parameters are present before [addr], they are replaced by default value: - [loop] = "1" - [pattern] = "-" (new:

[PATCH v2 3/4] ram: stm32mp1: use the DDR size by default in the test addressBus

2020-07-02 Thread Patrick Delaunay
The test 4 = "AddressBus [size] [addr]" without parameter detects alias for any address bit only when: - size = real size of DDR - addr = start of DDR = 0xC000 These value must be the default value when parameters are absent. This patch sets bufsize to STM32_DDR_SIZE and get_bufsize()

[PATCH v2 1/4] ram: stm32mp1: protect minimum value in get_bufsize

2020-07-02 Thread Patrick Delaunay
Add protection on minimum value for result of get_bufsize and check the alignment of buffer size: only multiple min_size is allowed; only 4 bytes alignment was checked previously (value & 0x3). For example the "Random" test raises an issue when size is not 8 bytes aligned because address for

[PATCH v2 2/4] ram: stm32mp1: add parameter addr in test FrequencySelectivePattern

2020-07-02 Thread Patrick Delaunay
Add a parameter addr in test FrequencySelectivePattern to select the base address used to execute the tests. Default value (when the parameter is absent) is STM32_DDR_BASE, selected in get_addr() function. Reviewed-by: Patrice Chotard Signed-off-by: Patrick Delaunay --- (no changes since v1)

[PATCH] Add information for skipped commit options

2020-07-02 Thread Patrick Delaunay
The unsupported Commit-xxx option are silently skipped and removed as 're_remove=Commit-\w*', this patch adds warning message in this case to detect misspelled issue for the 2 supported options: Commit-notes: Commit-changes: For example: the final 's' is missing (Commit-note:) NB: no issue

Re: [PATCH] sunxi: Add support for using UART4 as console on A64

2020-07-02 Thread Maxime Ripard
Hi, On Mon, Jun 29, 2020 at 07:12:04PM +, Nazım Gediz AYDINDOĞMUŞ wrote: > Hi. > > If I've understood it well, you're pointing out for the following part, > right? Yep > > /* CPU */ > > #define COUNTER_FREQUENCY 2400 > > @@ -248,6 +252,8 @@ extern int soft_i2c_gpio_scl; > >

[PATCH] lib: libfdt: fdt_region: avoid NULL pointer access

2020-07-02 Thread Philippe Reynes
The function fdt_find_regions look in the exclude list for each property, even if the name is NULL. It could happen if the fit image is corrupted. On sandbox, it generates a segfault. To avoid this issue, if the name of a property is NULL, we report an error and avoid looking in the exclude list.

[PATCH] patman: Detect unexpected END

2020-07-02 Thread Patrick Delaunay
Detect unexpected 'END' line when a section is not detected. This patch detect issue when tag name for section start is misspelled, for example 'Commit-note:' for 'Commit-notes:' Commit-note: END Then 'Commit-note:' is removed silently by re_remove = "Commit-\w*:" but 'END' is kept

Re: [PATCH] checkpatch: fix a false check against wchar/utf-16 string

2020-07-02 Thread Heinrich Schuchardt
On 16.06.20 16:17, Tom Rini wrote: > On Tue, Jun 16, 2020 at 02:43:07PM +0900, AKASHI Takahiro wrote: > >> UEFI subsystem uses utf-16 string, but checkpatch.pl complains >> about any occurrences of L"xxx" which is definitely legal. >> So just suppress this kind of warning. >> Precautiously, we

[PATCH v2] stm32mp1: use the command env info -q in env_check

2020-07-02 Thread Patrick Delaunay
Activate the new option -q in command "env info" to avoid unnecessary trace during boot. Signed-off-by: Patrick Delaunay Reviewed-by: Patrice Chotard --- Hi, This patch was previous included in V3 serie 158105. This patch have dependency with serie 184539 for -q option and with serie 187232

Re: [PATCH 09/13] test/py: efi_secboot: fix test case 1g of test_authvar

2020-07-02 Thread Heinrich Schuchardt
On 29.05.20 08:41, AKASHI Takahiro wrote: > In the test case (1g) of test_authvar, "db" is mistakenly used, > and it ends up being the exact same as (1f). > So correct it as "dbx" test case. > > Signed-off-by: AKASHI Takahiro Reviewed-by: Heinrich Schuchardt

Re: [PATCH 08/13] test/py: efi_secboot: remove all "re.search"

2020-07-02 Thread Heinrich Schuchardt
On 29.05.20 08:41, AKASHI Takahiro wrote: > Currently, we don't use any regular expression in matching outputs from > U-Boot. Since its use is just redundant, we can remove all. > > Signed-off-by: AKASHI Takahiro Reviewed-by: Heinrich Schuchardt

Re: [PATCH v2 2/2] stm32mp1: use the command env info in env_check

2020-07-02 Thread Patrice CHOTARD
Hi Patrick On 7/2/20 5:43 PM, Patrick Delaunay wrote: > Activate CMD_NVEDIT_INFO and use the new command "env info -d -p -q" > to automatically save the environment on first boot. > > This patch allows to remove the env_default variable. > > > Signed-off-by: Patrick Delaunay > --- > > Previously

[PATCH v2 1/2] cmd: env: use ENV_IS_IN_DEVICE in env info

2020-07-02 Thread Patrick Delaunay
Use the define ENV_IS_IN_DEVICE to test if one the CONFIG_ENV_IS_IN_... is defined and correct the detection of persistent storage support in the command "env info" if CONFIG_ENV_IS_NOWHERE is activated. Since commit 60d5ed2593c9 ("env: allow ENV_IS_NOWHERE with other storage target") test

[PATCH v2 2/2] stm32mp1: use the command env info in env_check

2020-07-02 Thread Patrick Delaunay
Activate CMD_NVEDIT_INFO and use the new command "env info -d -p -q" to automatically save the environment on first boot. This patch allows to remove the env_default variable. Signed-off-by: Patrick Delaunay --- Previously sent in serie cmd: env: add option for quiet output on env info

Re: [PATCH] rockchip: rk3288: Add OF board setup

2020-07-02 Thread Robin Murphy
On 2020-07-02 09:48, Jagan Teki wrote: The new rk3288 revision rk3288w has some changes with respect to legacy rk3288 like hclk_vio and usb host0 ohci. In order to work these on the same in Linux kernel update the compatible the root compatible with rockchip,rk3288w before booting. So, this

Re: [U-Boot] Pull request: u-boot-riscv/master

2020-07-02 Thread Tom Rini
On Thu, Jul 02, 2020 at 10:51:48AM +0800, ub...@andestech.com wrote: > Hi Tom, > > Please pull some riscv updates: > > - sbi: Add newline to error message > - fu540: dts: Correct reg size of otp and dmc nodes > - Enhance reserved memory fixup about PMP information passed from OpenSbi > -

[PATCH v2] board: dh_stm32mp1: update the gpio hog support

2020-07-02 Thread Patrick Delaunay
This patch update the current gpio hog implementation with the new API gpio_hog_probe_all() activated with CONFIG_GPIO_HOG. Signed-off-by: Patrick Delaunay Reviewed-by: Patrice Chotard --- Changes in v2: - correct commit message and add review by Patrice

[PATCH v2] cmd: add clone command

2020-07-02 Thread John Chau
From: John Chau This patch adds a feature for block device cloning similar to dd command, this should be useful for boot-strapping a device where usb gadget or networking is not available. For instance one can clone a factory image into a blank emmc from an external sd card. Signed-off-by: John

[PATCH v3] cmd: add clone command

2020-07-02 Thread John Chau
From: John Chau This patch adds a feature for block device cloning similar to dd command, this should be useful for boot-strapping a device where usb gadget or networking is not available. For instance one can clone a factory image into a blank emmc from an external sd card. Signed-off-by: John

RE: [PATCH 04/17] xen: Add essential and required interface headers

2020-07-02 Thread Peng Fan
> Subject: [PATCH 04/17] xen: Add essential and required interface headers > > From: Oleksandr Andrushchenko > > Add essential and required Xen interface headers only taken from > the stable Linux kernel stable/linux-5.7.y at commit > 66dfe45221605e11f38a0bf5eb2ee808cea7cfe7. Please use commit

[PATCH v4] ARM: dts: stm32: add seeed studio odyssey-stm32mp157c board

2020-07-02 Thread Marcin Sloniewski
This commit adds device tree files supporting SBC from Seeed Studio based on STM32MP157C. This works with generic stm32mp1 config. Right now only booting from SD card is supported. Signed-off-by: Marcin Sloniewski --- Changes in v4: - removed unnecessary pull up on uart4 rx Changes in v3: -

[PATCH 11/12] board: ge: common: vpd: separate I2C specific code

2020-07-02 Thread Sebastian Reichel
This separates the I2C specific code from the generic GE vital product data code, so that the generic parts can be used on hardware with VPD stored in SPI flash memory. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/bx50v3.c | 2 +- board/ge/common/vpd_reader.c | 12 ++--

[PATCH 10/12] board: ge: common: add config option for RTC and VPD feature

2020-07-02 Thread Sebastian Reichel
While this code is being used by all GE platforms its useful to have it behind a config option for hardware bringup of new platforms. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/Kconfig | 2 ++ board/ge/common/Kconfig | 7 +++ board/ge/common/Makefile | 3 ++-

[PATCH 12/12] board: ge: b1x5v2: Add GE B1x5v2 and B1x5Pv2

2020-07-02 Thread Sebastian Reichel
GE B1x5v2 patient monitor series is similar to the CARESCAPE Monitor series (GE Bx50). It consists of a carrier PCB used in combination with a Congatec QMX6 SoM. This adds U-Boot support using device model everywhere and SPL for memory initialization. Proper configuration is provided as

Re: [PATCH 05/17] xen: Port Xen hypervizor related code from mini-os

2020-07-02 Thread Julien Grall
Title: s/hypervizor/hypervisor/ On 01/07/2020 17:29, Anastasiia Lukianenko wrote: From: Oleksandr Andrushchenko Port hypervizor related code from mini-os. Update essential Ditto. But I would be quite cautious to import code from mini-OS in order to support Arm. The port has always been

[PATCH 04/12] rtc: m41t62: reset SQW in m41t62_rtc_reset

2020-07-02 Thread Sebastian Reichel
This takes care of resetting the 32kHz square wave, which is used by some boards as clock source for the SoC. Signed-off-by: Sebastian Reichel --- drivers/rtc/m41t62.c | 89 +--- 1 file changed, 83 insertions(+), 6 deletions(-) diff --git

[PATCH 06/12] imx6: allow usage of disable_ldb_di_clock_sources for CONFIG_MX6QDL

2020-07-02 Thread Sebastian Reichel
Allow using disable_ldb_di_clock_sources with just the combined CONFIG_MX6QDL being enabled. Signed-off-by: Sebastian Reichel --- arch/arm/mach-imx/mx6/clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/mx6/clock.c b/arch/arm/mach-imx/mx6/clock.c index

[PATCH 09/12] board: ge: common: rename ge_common.c to ge_rtc.c

2020-07-02 Thread Sebastian Reichel
The file only contains RTC related code, so let's name it accordingly. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/bx50v3.c | 2 +- board/ge/common/Makefile | 2 +- board/ge/common/{ge_common.c => ge_rtc.c} | 0 board/ge/common/{ge_common.h =>

[PATCH 05/12] rtc: m41t62: add oscillator fail bit reset support

2020-07-02 Thread Sebastian Reichel
In case of empty battery or glitches the oscillator fail bit might be set. This will reset the bit in the reset routine. Signed-off-by: Sebastian Reichel --- drivers/rtc/m41t62.c | 50 1 file changed, 50 insertions(+) diff --git

[PATCH 08/12] poweroff: Add poweroff-gpio driver

2020-07-02 Thread Sebastian Reichel
Add GPIO poweroff driver, which is based on the Linux driver and uses the same DT binding. Signed-off-by: Sebastian Reichel --- drivers/power/Kconfig | 8 drivers/power/Makefile| 1 + drivers/power/poweroff-gpio.c | 87 +++ 3 files changed,

[PATCH 01/12] treewide: Replace CONFIG_DM_SPI_FLASH with CONFIG_IS_ENABLED(DM_SPI_FLASH)

2020-07-02 Thread Sebastian Reichel
From: Marek Vasut Perform the replacement to allow platforms use non-DM SPI flash access in SPL/TPL. This is thus far needed on platforms with size constraints. Signed-off-by: Marek Vasut Signed-off-by: Sebastian Reichel --- cmd/sf.c | 4 ++-- drivers/mtd/spi/sf_probe.c | 2

  1   2   3   >