Re: [PATCH] fixdep: fix CONFIG_IS_ENABLED etc. handling

2020-07-17 Thread Masahiro Yamada
On Thu, Jul 9, 2020 at 6:53 AM Stephen Warren wrote: > > From: Stephen Warren > > When fixdep detects CONFIG_IS_ENABLED and other similar macros, it must > parse the macro parameter to determine which actual CONFIG_ option is > being referenced. This involves moving a pointer forward through the

Re: [PATCH v3 4/6] rock-pi-4: Enable HDMI output

2020-07-17 Thread Kever Yang
On 2020/7/7 下午9:50, Jagan Teki wrote: Enable config options to get HDMI output on RockPI-4 boards. Signed-off-by: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever --- Changes for v3: - fix configs configs/rock-pi-4-rk3399_defconfig | 5 + 1 file changed, 5 insertions(+) diff --g

Re: [PATCH v3 6/6] roc-rk3399-pc: Update ENV offset, size

2020-07-17 Thread Kever Yang
On 2020/7/7 下午9:50, Jagan Teki wrote: Adjust the ENV offset, size to fit into all images on 16MB flash. Signed-off-by: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever --- Changes for v3: - fix configs configs/roc-pc-mezzanine-rk3399_defconfig | 4 ++-- configs/roc-pc-rk3399_defconfi

[PATCH v2 2/3] test: vboot: add tests for multiple required keys

2020-07-17 Thread Thirupathaiah Annapureddy
This patch adds vboot tests to verify the support for multiple required keys using new required-mode DTB policy. This patch also fixes existing test where dev key is assumed to be marked as not required, although it is marked as required. Note that this patch re-added sign_fit_norequire(). sign_f

[PATCH v2 3/3] doc: verified-boot: add required-mode information

2020-07-17 Thread Thirupathaiah Annapureddy
Signed-off-by: Thirupathaiah Annapureddy --- Changes in v2: - New doc/uImage.FIT/signature.txt | 14 ++ 1 file changed, 14 insertions(+) diff --git a/doc/uImage.FIT/signature.txt b/doc/uImage.FIT/signature.txt index d4afd755e9..a3455889ed 100644 --- a/doc/uImage.FIT/signature.txt +

[PATCH v2 0/3] Add support for multiple required keys

2020-07-17 Thread Thirupathaiah Annapureddy
This patch series adds the support for multiple required keys in U-Boot DTB with test support. Changes in v2 (thanks for the feedback Simon and Rasmus): - Introduce a policy variable in U-boot DTB to control whether any or all required keys must have signed configuration. - Added tests to cover an

[PATCH v2 1/3] vboot: add DTB policy for supporting multiple required conf keys

2020-07-17 Thread Thirupathaiah Annapureddy
Currently FIT image must be signed by all required conf keys. This means Verified Boot fails if there is a signature verification failure using any required key in U-boot DTB. This patch introduces a new policy in DTB that can be set to any required conf key. This means if verified boot passes wit

Re: [PATCH v2 1/2] rockchip: Add SoC detection helper

2020-07-17 Thread Kever Yang
On 2020/7/8 下午6:29, Jagan Teki wrote: On Wed, Jul 8, 2020 at 3:43 PM Kever Yang wrote: Hi Jagan, This is all for rk3288, please just put it into rk3288.c instead of make a new cpu.h. Yes, I have used cpu.h since rk3308 also has revision, if not to consider than I will move to rk3288

Re: [PATCH] rockchip: sdram: fix dram_init_banksize

2020-07-17 Thread Kever Yang
Hi Alex, Tanks for your fix. On 2020/7/15 上午7:03, Alex Bee wrote: Currently 2.5 GB is calculated as DRAM size for a 1 GB RK322x board if CONFIG_SPL_OPTEE is set. This is troublesome when booting a linux kernel since this size will be injected in FDT of the kernel. gd->bd->bi_dram[0].start (whi

Re: [PATCH 2/2] configs: rock64-rk3328_defconfig: Add SPI Flash support

2020-07-17 Thread Kever Yang
On 2020/7/9 上午6:50, Johannes Krottmayer wrote: Add U-Boot SPI Flash support for the PINE64 Rock64 board Signed-off-by: Johannes Krottmayer Cc: Matwey V. Kornilov Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock64-rk3328_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --

Re: [PATCH 1/2] ARM: dts: rk3328-rock64: Add SPI Flash support

2020-07-17 Thread Kever Yang
On 2020/7/9 上午6:50, Johannes Krottmayer wrote: Add U-Boot SPI Flash support for the PINE64 Rock64 board Signed-off-by: Johannes Krottmayer Cc: Matwey V. Kornilov Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3328-rock64-u-boot.dtsi | 6 ++ 1 file changed, 6 insertions(

Re: [PATCH 2/3] drivers: spi: rk_spi: Add support for RK3328

2020-07-17 Thread Kever Yang
On 2020/7/9 上午5:57, Johannes Krottmayer wrote: Add support for the RK3328 SPI controller Signed-off-by: Johannes Krottmayer Cc: Kever Yang Cc: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever --- I don't know if "rk3399_spi_params" is also required for the RK3328 SPI controller. Probi

Re: [PATCH 3/3] ARM: dts: rk3328: Add SPI support

2020-07-17 Thread Kever Yang
On 2020/7/9 上午5:57, Johannes Krottmayer wrote: Add U-Boot SPI support for the RK3328 Signed-off-by: Johannes Krottmayer Cc: Kever Yang Cc: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3328-u-boot.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/ar

Re: [PATCH 1/3] drivers: clk: rockchip: clk_rk3328: Add SPI support

2020-07-17 Thread Kever Yang
On 2020/7/9 上午5:57, Johannes Krottmayer wrote: Add SPI support for the RK3328 clock driver Signed-off-by: Johannes Krottmayer Cc: Kever Yang Cc: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/clk_rk3328.c | 31 +++ 1 file change

[PATCH 6/6] stdio: Tidy up the coding style

2020-07-17 Thread Simon Glass
Bring the coding style in this file up to the current level. Signed-off-by: Simon Glass --- common/stdio.c | 37 - include/stdio_dev.h | 9 + 2 files changed, 25 insertions(+), 21 deletions(-) diff --git a/common/stdio.c b/common/stdio.c index

[PATCH 2/6] stdio: Tidy up use of CONFIG_SYS_DEVICE_NULLDEV

2020-07-17 Thread Simon Glass
Now that this is in Kconfig we can move the logic at the top of the file to Kconfig, and use if() instead of #if. Update the file with these changes. Signed-off-by: Simon Glass --- common/Kconfig | 1 + common/stdio.c | 30 ++ 2 files changed, 11 insertions(+), 20 d

[PATCH 4/6] stdio: Update to use compiler for Kconfig checks

2020-07-17 Thread Simon Glass
Drop use of the preprocessor where possible. Signed-off-by: Simon Glass --- common/stdio.c | 172 - 1 file changed, 83 insertions(+), 89 deletions(-) diff --git a/common/stdio.c b/common/stdio.c index 33a795e7bb..1921dc6719 100644 --- a/common/st

u-boot@lists.denx.de

2020-07-17 Thread Simon Glass
These brackets are not needed. Drop them. Signed-off-by: Simon Glass --- common/stdio.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/common/stdio.c b/common/stdio.c index 1921dc6719..d67ea60d6c 100644 --- a/common/stdio.c +++ b/common/stdio.c @@ -103,7 +103,7

[PATCH 1/6] Convert CONFIG_SYS_DEVICE_NULLDEV to Kconfig

2020-07-17 Thread Simon Glass
This converts the following to Kconfig: CONFIG_SYS_DEVICE_NULLDEV Signed-off-by: Simon Glass --- common/Kconfig | 16 configs/M5249EVB_defconfig | 3 ++- configs/colibri_pxa270_defconfig | 2 +- doc/README.silent| 2 +- include/conf

[PATCH 3/6] stdio: Drop #ifdefs in the header file

2020-07-17 Thread Simon Glass
These prevent the use of IS_ENABLED() and are unnecessary. Drop them and fix a few code-style nits nearby. Signed-off-by: Simon Glass --- include/stdio_dev.h | 40 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/include/stdio_dev.h b/incl

[PATCH 0/6] stdio: Clean up stdio.c

2020-07-17 Thread Simon Glass
This file is quite old and has some crufty code. This series converts a few things to Kconfig and updates the file. Simon Glass (6): Convert CONFIG_SYS_DEVICE_NULLDEV to Kconfig stdio: Tidy up use of CONFIG_SYS_DEVICE_NULLDEV stdio: Drop #ifdefs in the header file stdio: Update to use com

Re: [PATCH] rockchip: rk3328: Add SPI support

2020-07-17 Thread Kever Yang
Hi Johannes,     Do you have plan to update for this patch? Thanks, - Kever On 2020/7/8 下午6:08, Kever Yang wrote: Hi Johannes, The changes look good to me, but you need to split the patch into 3 patches: - rk3328 clock driver; - rkspi driver; - rk3328-u-boot.dtsi BTW: the patch no nee

Re: [PATCH 0/9] mmc: fsl_esdhc: support eMMC HS200/HS400 modes

2020-07-17 Thread Jaehoon Chung
On 7/17/20 5:48 PM, Y.b. Lu wrote: > Hi Jaehoon, > > Below is the full log of the performance and function tests for eMMC HS400 > mode. Since I used date to record time, there must be some error more or less. > I tested the r/w performance with 4G data size at 175MHz bus speed. The > results wer

Re: [GIT PULL] Pull request: u-boot-imx u-boot-imx-20200716

2020-07-17 Thread Tom Rini
On Fri, Jul 17, 2020 at 06:05:57PM -0300, Fabio Estevam wrote: > Hi Tom, > > On Fri, Jul 17, 2020 at 11:55 AM Tom Rini wrote: > > > Please note there's a bunch of whitespace errors in > > drivers/ddr/imx/imx8m/ddrphy_utils.c, a single one in > > arch/arm/mach-imx/imx8m/soc.c and > > drivers/pin

Re: [GIT PULL] Pull request: u-boot-imx u-boot-imx-20200716

2020-07-17 Thread Fabio Estevam
Hi Tom, On Fri, Jul 17, 2020 at 11:55 AM Tom Rini wrote: > Please note there's a bunch of whitespace errors in > drivers/ddr/imx/imx8m/ddrphy_utils.c, a single one in > arch/arm/mach-imx/imx8m/soc.c and > drivers/pinctrl/nxp/pinctrl-imx*.c has some warnings about using > __section(..) vs __attri

Re: [PATCH] doc: fit: Write hex address as hex instead of int

2020-07-17 Thread Tom Rini
On Wed, Jul 15, 2020 at 03:10:17PM +0200, Michal Simek wrote: > When update_uboot.its is used directly there is syntax error for no reason. > > Error report: > mkimage -f update_uboot.its boot > Error: update_uboot.its:18.12-13 syntax error > FATAL ERROR: Unable to parse input tree > mkimage: Can

Re: [PATCH v1] include: pci_ids: Add Cavium devices

2020-07-17 Thread Tom Rini
On Fri, Jul 17, 2020 at 08:06:22AM +0200, Stefan Roese wrote: > From: Suneel Garapati > > Add VendorID and DeviceID for supported devices on OcteonTX/TX2 > platforms. > > Signed-off-by: Suneel Garapati > Reviewed-by: Stefan Roese > Cc: Simon Glass > Cc: Daniel Schwierzeck Applied to u-boot

Re: [PATCH] mtd: mtdpart: use uint64_t instead of int for cur_off

2020-07-17 Thread Tom Rini
On Mon, Jul 13, 2020 at 02:40:02PM +0200, Martin Kaistra wrote: > The types of "offset" and "size" of "struct mtd_partition" are uint64_t, > while mtd_parse_partitions() uses int to work with these values. When > the offset reaches 2GB, it is interpreted as a negative value, which > leads to error

Re: [PATCH] board/km: update MAINTAINERS email

2020-07-17 Thread Tom Rini
On Thu, Jul 09, 2020 at 05:31:23PM +0200, Holger Brunck wrote: > Signed-off-by: Holger Brunck > CC: Valentin Longchamp Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2] mkimage: Fix error message if write less data then expected

2020-07-17 Thread Tom Rini
On Wed, Jul 08, 2020 at 11:52:50AM +0200, Mylène Josserand wrote: > Add a new error message in case the size of data written > are shorter than the one expected. > > Currently, it will lead to the following error message: > > "mkimage: Write error on uImage: Success" > > This is not explicit wh

Re: [PATCH 1/1] doc: correct description of crash dumps

2020-07-17 Thread Tom Rini
On Thu, Jul 09, 2020 at 08:12:06AM +0200, Heinrich Schuchardt wrote: > Correct the description of the ESR register. > > Fix a typo. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] fixdep: fix CONFIG_IS_ENABLED etc. handling

2020-07-17 Thread Tom Rini
On Wed, Jul 08, 2020 at 03:45:56PM -0600, Stephen Warren wrote: > From: Stephen Warren > > When fixdep detects CONFIG_IS_ENABLED and other similar macros, it must > parse the macro parameter to determine which actual CONFIG_ option is > being referenced. This involves moving a pointer forward th

Re: [PATCH] remove include/config_defaults.h

2020-07-17 Thread Tom Rini
On Tue, Jul 07, 2020 at 10:40:26AM +0200, Rasmus Villemoes wrote: > Since commit 4b0bcfa7c4ec (Kconfig: Migrate CONFIG_BOOTM_* options), > the config_defaults.h file has been void of any actual content - and > these days, "sane defaults for everyone" is achieved by appropriate > default values in

Re: [PATCH] doc: multi-dtb-fit: Remove double underscores

2020-07-17 Thread Tom Rini
On Sun, Jul 05, 2020 at 07:04:50PM -0300, Fabio Estevam wrote: > Remove the incorrect usage of double underscores for the > CONFIG_OF_LIST and CONFIG_SPL_OF_LIST symbols. > > Signed-off-by: Fabio Estevam Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 1/1] fs: error handling in do_load()

2020-07-17 Thread Tom Rini
On Mon, Jun 29, 2020 at 08:08:49PM +0200, Heinrich Schuchardt wrote: > If a file cannot be loaded, show an error message. > Set the EFI boot device only after successfully loading a file. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- T

Re: [PATCH 1/3] treewide: convert bd_t to struct bd_info by coccinelle

2020-07-17 Thread Tom Rini
On Fri, Jun 26, 2020 at 03:13:33PM +0900, Masahiro Yamada wrote: > The Linux coding style guide (Documentation/process/coding-style.rst) > clearly says: > > It's a **mistake** to use typedef for structures and pointers. > > Besides, using typedef for structures is annoying when you try to make

Re: [PATCH 3/3] asm/u-boot.h: remove bd_t definitions

2020-07-17 Thread Tom Rini
On Fri, Jun 26, 2020 at 03:13:35PM +0900, Masahiro Yamada wrote: > All the users of bd_t were converted to struct bd_info. > > Remove the definitions. > > Signed-off-by: Masahiro Yamada Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/3] treewide: convert bd_t to struct bd_info manually

2020-07-17 Thread Tom Rini
On Fri, Jun 26, 2020 at 03:13:34PM +0900, Masahiro Yamada wrote: > Some code was not converted by coccinelle, somehow. > > I manually fixed up the remaining, and comments, README docs. > > Signed-off-by: Masahiro Yamada Applied to u-boot/master, thanks! -- Tom signature.asc Description: PG

Re: [PATCH] arm64: Remove CONFIG_SYS_FULL_VA macro

2020-07-17 Thread Tom Rini
On Thu, Jun 25, 2020 at 09:26:57AM +0200, Michal Simek wrote: > All configurations have been removed in 2016 by commit 7985cdf74b28 > ("arm64: Remove non-full-va map code"). > > Signed-off-by: Michal Simek Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] lib: zlib: Remove offset pointer optimization in inftrees.c

2020-07-17 Thread Tom Rini
On Wed, Jun 24, 2020 at 04:31:08PM +0800, Ley Foon Tan wrote: > From: Chin Liang See > > This fixes the CVE-2016-9840. Commit imported from [1]. > > inftrees.c was subtracting an offset from a pointer to an array, > in order to provide a pointer that allowed indexing starting at > the offset. T

Re: [PATCH] Convert CONFIG_ARMV7_PSCI_1_0 and CONFIG_ARMV7_PSCI_0_2 to Kconfig

2020-07-17 Thread Tom Rini
On Wed, Jun 17, 2020 at 06:19:18PM +0200, Patrick Delaunay wrote: > This converts the following to Kconfig: > CONFIG_ARMV7_PSCI_1_0 > CONFIG_ARMV7_PSCI_0_2 > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] Makefile: Silence relocate-rela call

2020-07-17 Thread Tom Rini
On Thu, Jun 25, 2020 at 08:39:45AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Signed-off-by: Jan Kiszka Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 1/1] spl: fix ext4fs_mount return code handling

2020-07-17 Thread Tom Rini
On Tue, Jun 16, 2020 at 10:03:52PM +0200, Heiko Thiery wrote: > From: Thomas Schaefer > > - Despite other ext4 filesystem functions, ext4fs_mount returns > 0 in case of error. > - This leads to u-boot crash in case that an SD card > with valid partition table but without ext4 filesystem crea

Re: [PATCH 4/4] cmd: booti: convert the debug print about image move to printf

2020-07-17 Thread Tom Rini
On Fri, Jun 12, 2020 at 03:41:21PM +0300, Tero Kristo wrote: > Moving of the OS image may have some nasty side effects like corrupting > DTB. Convert the current debug print to printf so that the relocation of > the OS is always obvious to the user. > > Signed-off-by: Tero Kristo Applied to u-b

Re: [PATCH 2/4] image: fdt: bail out with error if no boot time FDT image found

2020-07-17 Thread Tom Rini
On Fri, Jun 12, 2020 at 03:41:19PM +0300, Tero Kristo wrote: > Currently the boot continues if the FDT image is clearly corrupted, > which just causes the loaded OS to hang. Abort boot properly if the FDT > is corrupted. > > Signed-off-by: Tero Kristo Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 3/4] common: bootm: add checks to verify if ramdisk / fdtimage overlaps OS image

2020-07-17 Thread Tom Rini
On Fri, Jun 12, 2020 at 03:41:20PM +0300, Tero Kristo wrote: > These cases are typically fatal and are difficult to debug for random > users. Add checks for detecting overlapping images and abort if overlap > is detected. > > Signed-off-by: Tero Kristo Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v2] lz4: fix decompressor on big-endian powerpc

2020-07-17 Thread Tom Rini
On Sun, Jun 07, 2020 at 02:29:18PM +0200, Rasmus Villemoes wrote: > Booting an lz4-compressed kernel image fails on our powerpc board with > -EPROTONOSUPPORT. Adding a bit of debug prints, we get > > magic: 0x184d2204 > flags: 0x64 > reserved0: 1 > has_content_checksum: 1 > has_content_

Re: [PATCH] Convert CONFIG_MXC_UART to Kconfig

2020-07-17 Thread Tom Rini
On Tue, Jun 09, 2020 at 10:46:46AM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_MXC_UART > > Signed-off-by: Tom Rini > Acked-by: Peng Fan Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] doc: Coccinelle: move to HTML doc

2020-07-17 Thread Tom Rini
On Fri, Jun 05, 2020 at 05:13:44AM +0200, Heinrich Schuchardt wrote: > Move doc/README.coccinelle to doc/develop/coccinelle.rst using the current > linux-next version of the text. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 1/2] imx8m: ddrphy_utils: Improve coding style

2020-07-17 Thread Tom Rini
On Fri, Jul 17, 2020 at 04:36:53PM -0300, Fabio Estevam wrote: > Currently checkpatch is not happy about this file: > > total: 14 errors, 2 warnings, 7 checks, 359 lines checked > > Improve the coding style so that it can now report: > > total: 0 errors, 0 warnings, 6 checks, 360 lines checked

Re: [PATCH 2/2] imx8m: soc: Remove unneeded space

2020-07-17 Thread Tom Rini
On Fri, Jul 17, 2020 at 04:36:54PM -0300, Fabio Estevam wrote: > Checkpatch reports the following issue: > > ERROR: space prohibited before that ',' (ctx:WxW) > #936: FILE: arch/arm/mach-imx/imx8m/soc.c:936: > + 0, 0 , 0, 0, 0, 0, &res); > > Remove the unneeded space. >

Re: [GIT PULL] Pull request: u-boot-imx u-boot-imx-20200716

2020-07-17 Thread Fabio Estevam
Hi Tom, On Fri, Jul 17, 2020 at 11:55 AM Tom Rini wrote: > Please note there's a bunch of whitespace errors in > drivers/ddr/imx/imx8m/ddrphy_utils.c, a single one in > arch/arm/mach-imx/imx8m/soc.c and > drivers/pinctrl/nxp/pinctrl-imx*.c has some warnings about using > __section(..) vs __attri

[PATCH 1/2] imx8m: ddrphy_utils: Improve coding style

2020-07-17 Thread Fabio Estevam
Currently checkpatch is not happy about this file: total: 14 errors, 2 warnings, 7 checks, 359 lines checked Improve the coding style so that it can now report: total: 0 errors, 0 warnings, 6 checks, 360 lines checked Reported-by: Tom Rini Signed-off-by: Fabio Estevam --- drivers/ddr/imx/imx

[PATCH 2/2] imx8m: soc: Remove unneeded space

2020-07-17 Thread Fabio Estevam
Checkpatch reports the following issue: ERROR: space prohibited before that ',' (ctx:WxW) #936: FILE: arch/arm/mach-imx/imx8m/soc.c:936: + 0, 0 , 0, 0, 0, 0, &res); Remove the unneeded space. ^ Reported-by: Tom Rini Signed-off-by: Fabio Estevam ---

Re: [PATCH 1/1] clk: ICS8N3QV01 remove superfluous code

2020-07-17 Thread Heinrich Schuchardt
On 2/16/20 9:50 AM, Lukasz Majewski wrote: > On Sat, 15 Feb 2020 21:27:38 +0100 > Heinrich Schuchardt wrote: > >> Do not calculate a unused value of n which is overwritten in both >> branches of the subsequent if statement. >> >> Identified by cppcheck. >> >> Signed-off-by: Heinrich Schuchardt >>

[PATCH] efi_loader: use logging for block device messages

2020-07-17 Thread Heinrich Schuchardt
Use logging instead of printf() for messages occurring when scanning block devices during the initialization of the UEFI sub-system. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_disk.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/lib/

[PATCH 1/1] efi_loader: use logging for bootefi command

2020-07-17 Thread Heinrich Schuchardt
Log messages of the bootefi command instead of simply printing them to the console. Do not show "## Application terminated" message when the UEFI binary completed successfully. Signed-off-by: Heinrich Schuchardt --- cmd/bootefi.c | 42 -- 1 file changed,

Re: [PATCH v2 1/4] usb: xhci: Add missing endian conversions (cpu_to_leXX / leXX_to_cpu)

2020-07-17 Thread Stefan Roese
Hi Bin, On 17.07.20 16:14, Bin Meng wrote: Hi Stefan, On Fri, Jul 17, 2020 at 10:04 PM Stefan Roese wrote: While trying to use the U-Boot xHCI driver on the MIPS Octeon platform, which is big endian, I noticed that the driver is missing a few endian conversion calls. This patch adds these mi

[PATCH 1/1] dfu: fix typo parameteres

2020-07-17 Thread Heinrich Schuchardt
%s/parameteres/parameters/g Even if a line exceeds 80 characters we should not split output strings to make debugging easier. Signed-off-by: Heinrich Schuchardt --- common/update.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/common/update.c b/common/update.c index 5ffa

[PATCH 3/4] clk: add clock driver for SCMI agents

2020-07-17 Thread Etienne Carriere
This change introduces a clock driver for SCMI agent devices. When SCMI agent and SCMI clock drivers are enabled, SCMI agent binds a clock device for each SCMI clock protocol devices enabled in the FDT. SCMI clock driver is embedded upon CONFIG_CLK_SCMI=y. If enabled, CONFIG_SCMI_AGENT is also ena

[PATCH 1/4] firmware: add new driver for SCMI firmwares

2020-07-17 Thread Etienne Carriere
This change introduces SCMI agent driver in U-Boot in the firmware U-class. SCMI agent driver is designed for platforms that embed a SCMI server in a firmware hosted for example by a companion co-processor or the secure world of the executing processor. SCMI protocols allow an SCMI agent to disco

[PATCH 4/4] reset: add reset controller driver for SCMI agents

2020-07-17 Thread Etienne Carriere
This change introduces a reset controller driver for SCMI agent devices. When SCMI agent and SCMI reset domain drivers are enabled, SCMI agent binds a reset controller device for each SCMI reset domain protocol devices enabled in the FDT. SCMI reset driver is embedded upon CONFIG_RESET_SCMI=y. If

[PATCH 2/4] dt-bindings: arm: SCMI bindings documentation

2020-07-17 Thread Etienne Carriere
Dump SCMI DT bindings documentation from Linux kernel source tree v5.8-rc1. Signed-off-by: Etienne Carriere --- doc/device-tree-bindings/arm/arm,scmi.txt | 197 ++ 1 file changed, 197 insertions(+) create mode 100644 doc/device-tree-bindings/arm/arm,scmi.txt diff --git a/d

Re: [PATCH] dm: core: Don't show an ACPI warning if there is no ordering

2020-07-17 Thread Bin Meng
On Fri, Jul 17, 2020 at 10:49 PM Simon Glass wrote: > > Some boards don't care about the ordering of ACPI code fragments. Change > the warning to a debug message. > > Signed-off-by: Simon Glass > --- > > drivers/core/acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by:

[PATCH v6 20/25] x86: mtrr: Add support for writing to MTRRs on any CPU

2020-07-17 Thread Simon Glass
To enable support for the 'mtrr' command, add a way to perform MTRR operations on selected CPUs. This works by setting up a little 'operation' structure and sending it around the CPUs for action. Signed-off-by: Simon Glass Reviewed-by: Bin Meng Reviewed-by: Wolfgang Wallner --- (no changes si

[PATCH v6 16/25] x86: mtrr: Use MP calls to list the MTRRs

2020-07-17 Thread Simon Glass
Update the mtrr command to use mp_run_on_cpus() to obtain its information. Since the selected CPU is the boot CPU this does not change the result, but it sets the stage for supporting other CPUs. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner Reviewed-by: Bin Meng --- (no changes sin

[PATCH v6 18/25] x86: coral: Update the memory map

2020-07-17 Thread Simon Glass
This currently excludes the temporary memory used to start up the APs. Add it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng Reviewed-by: Wolfgang Wallner --- (no changes since v2) Changes in v2: - Add new patch to add AP_DEFAULT_BASE to coral's memory map doc/board/google/chromebook_cor

Re: [GIT PULL] Pull request: u-boot-imx u-boot-imx-20200716

2020-07-17 Thread Tom Rini
On Thu, Jul 16, 2020 at 10:01:19PM +0200, Stefano Babic wrote: > Hi Tom, > > please pull from u-boot-imx, thanks ! > > The following changes since commit 497c7598c4e713eb9ad88fd7963e57b21b8b35e1: > > Merge branch 'master' of > https://gitlab.denx.de/u-boot/custodians/u-boot-spi (2020-07-11 17

[PATCH] dm: core: Don't show an ACPI warning if there is no ordering

2020-07-17 Thread Simon Glass
Some boards don't care about the ordering of ACPI code fragments. Change the warning to a debug message. Signed-off-by: Simon Glass --- drivers/core/acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/core/acpi.c b/drivers/core/acpi.c index cdbc2c5cf5..7fe93992b5

[PATCH v6 25/25] x86: mtrr: Enhance 'mtrr' command to list MTRRs on any CPU

2020-07-17 Thread Simon Glass
Update this command so it can list the MTRRs on a selected CPU. If '-c all' is used, then all CPUs are listed. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner --- Changes in v6: - Rebase to x86/master cmd/x86/mtrr.c | 22 +- 1 file changed, 21 insertions(+), 1 del

[PATCH v6 24/25] x86: mp: Add more comments to the module

2020-07-17 Thread Simon Glass
Add a description of how this module works and also some missing function comments. Reviewed-by: Wolfgang Wallner Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v3) Changes in v3: - Remove stray asterisk from comments - Drop mention of cpu_map which was handled in a pr

[PATCH v6 14/25] x86: mp: Park CPUs before running the OS

2020-07-17 Thread Simon Glass
With the new MP features the CPUs are no-longer parked when the OS is run. Fix this by calling a special function to park them, just before the OS is started. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner --- (no changes since v5) Changes in v5: - Drop timing in mp_park_aps() Chang

[PATCH v6 23/25] x86: mtrr: Update 'mtrr' to allow setting MTRRs on any CPU

2020-07-17 Thread Simon Glass
Add a -c option to mtrr to allow any CPU to be updated with this command. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner Reviewed-by: Bin Meng --- (no changes since v3) Changes in v3: - Mention that the CPU number is in hex cmd/x86/mtrr.c | 18 -- 1 file changed, 1

Re: Please pull u-boot-x86

2020-07-17 Thread Tom Rini
On Fri, Jul 17, 2020 at 06:15:17PM +0800, Bin Meng wrote: > Hi Tom, > > This PR includes the following changes for v2020.10 release: > > - New timer API to allow delays with a 32-bit microsecond timer > - Add dynamic ACPI structs (DSDT/SSDT) generations to the DM core > - x86: Enable ACPI table

[PATCH v6 19/25] x86: mtrr: Update MTRRs on all CPUs

2020-07-17 Thread Simon Glass
When the boot CPU MTRRs are updated, perform the same update on all other CPUs so they are kept in sync. This avoids kernel warnings about mismatched MTRRs. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner --- (no changes since v2) Changes in v2: - Rename function to mtrr_write_all()

[PATCH v6 22/25] x86: mtrr: Restructure so command execution is in one place

2020-07-17 Thread Simon Glass
At present do_mtrr() does the 'list' subcommand at the top and the rest below. Update it to do them all in the same place so we can (in a later patch) add parsing of the CPU number for all subcommands. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner Reviewed-by: Bin Meng --- (no chang

[PATCH v6 21/25] x86: mtrr: Update the command to use the new mtrr calls

2020-07-17 Thread Simon Glass
Use the multi-CPU calls to set the MTRR values. This still supports only the boot CPU for now. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Drop the renamed mtrr_set_valid_() instead of mtrr_set_valid() cmd/x86/mtr

[PATCH v6 15/25] x86: mp: Add iterators for CPUs

2020-07-17 Thread Simon Glass
It is convenient to iterate through the CPUs performing work on each one and processing the result. Add a few iterator functions which handle this. These can be used by any client code. It can call mp_run_on_cpus() on each CPU that is returned, handling them one at a time. Signed-off-by: Simon Gla

[PATCH v6 17/25] x86: Don't enable SMP in SPL

2020-07-17 Thread Simon Glass
SMP should be set up in U-Boot where possible, not SPL. Disable it in SPL. For 64-bit U-Boot we should find a way to allow SMP operations in U-Boot, but this is somewhat more complicated. For now that is disabled too. Signed-off-by: Simon Glass Reviewed-by: Bin Meng Reviewed-by: Wolfgang Wallner

[PATCH v6 11/25] global_data: Add a generic global_data flag for SMP state

2020-07-17 Thread Simon Glass
Allow keeping track of whether all CPUs have been enabled yet. This allows us to know whether other CPUs need to be considered when updating CPU-specific settings such as MTRRs on x86. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner --- (no changes since v3) Changes in v3: - Rename fl

[PATCH v6 13/25] x86: mp: Allow running functions on multiple CPUs

2020-07-17 Thread Simon Glass
Add a way to run a function on a selection of CPUs. This supports either a single CPU, all CPUs, just the main CPU or just the 'APs', in Intel terminology. It works by writing into a mailbox and then waiting for the CPUs to notice it, take action and indicate they are done. When SMP is not yet en

[PATCH v6 12/25] x86: Set the SMP flag when MP init is complete

2020-07-17 Thread Simon Glass
Set this flag so we can track when it is safe to use CPUs other than the main one. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner Reviewed-by: Bin Meng --- (no changes since v3) Changes in v3: - Rename flag to GD_FLG_SMP_READY arch/x86/cpu/mp_init.c | 1 + 1 file changed, 1 insert

[PATCH v6 10/25] x86: mp: Support APs waiting for instructions

2020-07-17 Thread Simon Glass
At present the APs (non-boot CPUs) are inited once and then parked ready for the OS to use them. However in some cases we want to send new requests through, such as to change MTRRs and keep them consistent across CPUs. Change the last state of the flight plan to go into a wait loop, accepting inst

[PATCH v6 07/25] x86: mp_init: Set up the CPU numbers at the start

2020-07-17 Thread Simon Glass
At present each CPU is given a number when it starts itself up. While this saves a tiny amount of time by doing the device-tree read in parallel, it is confusing that the numbering happens on the fly. Move this code into mp_init() and do it at the start. Signed-off-by: Simon Glass Reviewed-by: W

[PATCH v6 06/25] x86: mtrr: Fix 'ensable' typo

2020-07-17 Thread Simon Glass
Fix a typo in the command help. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner Reviewed-by: Bin Meng --- (no changes since v1) cmd/x86/mtrr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/x86/mtrr.c b/cmd/x86/mtrr.c index 084d7315f4..5d25c5802a 100644 ---

[PATCH v6 09/25] x86: cpu: Remove unnecessary #ifdefs

2020-07-17 Thread Simon Glass
Drop some #ifdefs that are not needed or can be converted to compile-time checks. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/cpu/cpu.c | 53 - arch/x86/cpu/i386/cpu.c | 2 --

[PATCH v6 08/25] x86: mp_init: Adjust bsp_init() to return more information

2020-07-17 Thread Simon Glass
This function is misnamed since it does not actually init the BSP. Also it is convenient to adjust it to return a little more information. Rename and update the function, to allow it to return the BSP CPU device and number, as well as the total number of CPUs. Signed-off-by: Simon Glass Reviewed

[PATCH v6 04/25] x86: mp_init: Switch parameter names in start_aps()

2020-07-17 Thread Simon Glass
These parameters are named differently from elsewhere in this file. Switch them to avoid confusion. Also add comments to this function. Signed-off-by: Simon Glass Reviewed-by: Bin Meng Reviewed-by: Wolfgang Wallner --- (no changes since v2) Changes in v2: - Add comments to explain what start

[PATCH v6 02/25] x86: Move MP code into mp_init

2020-07-17 Thread Simon Glass
At present the 'flight plan' for CPUs is passed into mp_init. But it is always the same. Move it into the mp_init file so everything is in one place. Also drop the SMI function since it does nothing. If we implement SMIs, more refactoring will be needed anyway. Signed-off-by: Simon Glass Reviewed

[PATCH v6 03/25] x86: mp_init: Avoid declarations in header files

2020-07-17 Thread Simon Glass
The functions used by the flight plan are declared in the header file but are not used in any other file. Move the flight plan steps down to just above where it is used so that we can make these function static. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner Reviewed-by: Bin Meng ---

[PATCH v6 05/25] x86: mp_init: Drop the num_cpus static variable

2020-07-17 Thread Simon Glass
This does not need to be global across all functions in this file. Pass a parameter instead. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner Reviewed-by: Bin Meng --- (no changes since v3) Changes in v3: - Update bsp_do_flight_plan() to say 'on the BSP' arch/x86/cpu/mp_init.c | 22

[PATCH v6 01/25] x86: mp_init: Switch to livetree

2020-07-17 Thread Simon Glass
Update this code to use livetree calls instead of flat-tree. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/cpu/mp_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/cpu/mp_init.c b/arch/x86

[PATCH v6 00/25] x86: Enhance MTRR functionality to support multiple CPUs

2020-07-17 Thread Simon Glass
At present MTRRs are mirrored to the secondary CPUs only once, as those CPUs are started up. But U-Boot may add more MTRRs later, e.g. if it decides that a video console must be set up. This series enhances the x86 multi-processor support to allow MTRRs to be updated at any time. It also updates t

Re: [PATCH v2 1/4] usb: xhci: Add missing endian conversions (cpu_to_leXX / leXX_to_cpu)

2020-07-17 Thread Bin Meng
Hi Stefan, On Fri, Jul 17, 2020 at 10:04 PM Stefan Roese wrote: > > While trying to use the U-Boot xHCI driver on the MIPS Octeon platform, > which is big endian, I noticed that the driver is missing a few endian > conversion calls. This patch adds these missing endian conversion > calls. > > Sig

[PATCH v2 1/4] usb: xhci: Add missing endian conversions (cpu_to_leXX / leXX_to_cpu)

2020-07-17 Thread Stefan Roese
While trying to use the U-Boot xHCI driver on the MIPS Octeon platform, which is big endian, I noticed that the driver is missing a few endian conversion calls. This patch adds these missing endian conversion calls. Signed-off-by: Stefan Roese Reviewed-by: Bin Meng Cc: Bin Meng Cc: Marek Vasut

Re: [PATCH v1 1/4] usb: xhci: Add missing endian conversions (cpu_to_leXX / leXX_to_cpu)

2020-07-17 Thread Bin Meng
Hi Stefan, On Fri, Jul 17, 2020 at 7:34 PM Stefan Roese wrote: > > Hi Bin, > > On 17.07.20 13:18, Bin Meng wrote: > > Hi Stefan, > > > > On Thu, Jul 2, 2020 at 4:47 PM Stefan Roese wrote: > >> > >> While trying to use the U-Boot xHCI driver on the MIPS Octeon platform, > >> which is big endian,

Re: [PATCH 1/4] lmb/bdinfo: dump lmb info via bdinfo

2020-07-17 Thread Tero Kristo
On 17/07/2020 16:29, Tom Rini wrote: On Fri, Jun 12, 2020 at 03:41:18PM +0300, Tero Kristo wrote: Dump lmb status from the bdinfo command. This is useful for seeing the reserved memory regions from the u-boot cmdline. Signed-off-by: Tero Kristo --- cmd/bdinfo.c | 8 +++- include/lmb.

[PATCH 1/2] bcmgenet: fix DMA buffer management

2020-07-17 Thread Jason Wessel
This commit fixes a serious issue occurring when several network commands are run on a raspberry pi 4 board: for instance a "dhcp" command and then one or several "tftp" commands. In this case, packet recv callbacks were called several times on the same packets, and send function was failing most o

[PATCH 2/2] bcmgenet: Add support for rgmii-rxid

2020-07-17 Thread Jason Wessel
The commit 57805f2270c4 ("net: bcmgenet: Don't set ID_MODE_DIS when not using RGMII") needed to be extended for the case of using the rgmii-rxid. The latest version of the Rasbperry Pi4 dtb files for the 5.4 now specify the rgmii-rxid. Signed-off-by: Jason Wessel --- drivers/net/bcmgenet.c | 3

Re: [PATCH] lib: zlib: Use post-increment only in inffast.c

2020-07-17 Thread Tom Rini
On Wed, Jun 24, 2020 at 04:34:03PM +0800, Ley Foon Tan wrote: > From: Chin Liang See > > This fixes CVE-2016-9841. Changes integrated from [1], with changes > make for Uboot code base. > > An old inffast.c optimization turns out to not be optimal anymore > with modern compilers, and furthermore

  1   2   >