Re: [PATCH 7/7] riscv: Add some comments to start.S

On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > This adds comments regarding the ordering and purpose of certain > instructions as I understand them. > > Signed-off-by: Sean Anderson > --- > > arch/riscv/cpu/start.S | 19 +-- > 1 file changed, 17 insertions(+), 2

Re: [PATCH 6/7] riscv: Ensure gp is NULL or points to valid data

On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > This allows code to use a construct like `if (gd & gd->...) { ... }` when > accessing the global data pointer. Without this change, it was possible for > a very early trap to cause _exit_trap to read arbitrary memory. This could > cause a

Re: [PATCH 3/7] riscv: Use NULL as a sentinel value for smp_call_function

Hi Sean > On 9/9/20 5:01 AM, Rick Chen wrote: > > Hi Sean > > > >> Hi Sean > >> > >>> Some IPIs may already be pending when U-Boot is started. This could be a > >>> problem if a secondary hart tries to handle an IPI before the boot hart > >>> has > >>> initialized the IPI device. > >>> > >>>

Re: [PATCH 1/7] Revert "riscv: Clear pending interrupts before enabling IPIs"

HI Sean > On 9/11/20 10:45 AM, Bin Meng wrote: > > On Fri, Sep 11, 2020 at 6:22 PM Sean Anderson wrote: > >> > >> On 9/11/20 3:38 AM, Bin Meng wrote: > >>> Hi Sean, > >>> > >>> On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > Clearing MIP doesn't do anything. Whoops. The

[PATCH v2 2/4] xhci.c: Add polling support for USB keyboards

The xhci driver was causing intermittent 5 second delays from the USB keyboard polling hook. Executing something like a "sleep 1" for example would sleep for 5 seconds, unless an event occurred on the USB bus to shorten the delay. Modeled after the code in the DWC2 driver, a nonblock state was

[PATCH v2 3/4] xhci-ring.c: Add poll pending state to properly abort transactions

Both xhci_ctrl_tx() and xhci_bulk_tx() can be called synchronously by other drivers such as the usb storage or network, while the keyboard driver exclusively uses the polling mode. The reason the abort needs to happen is for the case when a keyboard poll was issue but there was no response

[PATCH 0/4][v2] xhci fixes for rpi4

This is the second iteration of the xhci patch set for making USB keyboards usable on the rpi4 board. Patch 1 is new to deal with the USB device not responding immediately after a port reset. Patch 3 is refactored after the review from Bin Meng.

[PATCH v2 1/4] xhci.c: Add retry in xhci_address_device()

After a port reset some usb keyboard devices do not respond immediately, and instead the controller reports COMP_TX_ERR. Adding a retry after the first TX error is returned resolves the issue. Without the patch u-boot prints: Starting the controller USB XHCI 1.00 scanning bus xhci_pci

[PATCH v2 4/4] xhci-ring.c: Fix crash when issuing "usb reset"

When TRB_TRANSFER is set for a call to xhci_wait_for_event, it can return null, which causes u-boot to crash. This is an intermittent problem found during "usb reset" testing. If the null return occurs it means there was a timeout, and the abort_td() should return immediately vs crashing u-boot

Re: [PATCH 4/7] riscv: Clear pending IPIs on initialization

On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > Even though we no longer call smp_function if an IPI was not sent by > U-Boot, we still need to clear any IPIs which were pending from the > execution environment. Otherwise, secondary harts will busy-wait in > secondary_hart_loop, instead

Re: [PATCH 3/7] riscv: Use NULL as a sentinel value for smp_call_function

Hi Leo, On Mon, Sep 14, 2020 at 9:58 AM Leo Liang wrote: > > On Fri, Sep 11, 2020 at 04:04:13PM +0800, Bin Meng wrote: > > On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > > > > > Some IPIs may already be pending when U-Boot is started. This could be a > > > problem if a secondary hart

Re: [PATCH] Add support for Davicom DM96xx based USB 10/100 ethernet devices

On Sat, Sep 12, 2020 at 10:46:37PM +0800, hyyoxhk wrote: > Ported from Linux driver - drivers/net/usb9601.c > > Signed-off-by: hyyoxhk > --- > drivers/usb/eth/Kconfig | 8 > drivers/usb/eth/Makefile | 1 + > 2 files changed, 9 insertions(+) You forgot to add the driver file. --

RE: SPL FIT configuration signature verification

Yes, it is possible to do this. The SPL will check its own DTB to check which signatures are required. When the FIT that the SPL will load is created with mkimage, you also pass the SPL's dtb file, which will be patched to include the required signatures. I am not sure if the config system has

Re: [PATCH 0/3] log: Fix segfault in sandbox when LOG_LEVEL_DEFAULT >= LOGL_DEBUG

On 9/12/20 5:45 PM, Sean Anderson wrote: > Since the syslog feature has been introduced, sandbox no longer boots when > LOG_LEVEL_DEFAULT prints cdebug messages. This is because it tries to call > net_init before initf_dm. > > > Sean Anderson (3): > dev: Disambiguate errors in uclass_find >

[PATCH] pci: layerscape: Fixup PCIe EP mode DT nodes for LX2160A rev2

From: Hou Zhiqiang LX2160A rev2 uses different PCIe controller, so EP mode DT nodes also need to be fixed up. Signed-off-by: Hou Zhiqiang --- drivers/pci/pcie_layerscape_fixup_common.c | 26 ++ 1 file changed, 26 insertions(+) diff --git

Re: [PATCH 4/4] log: Disable the syslog driver by default

Hi Heinrich, On Sun, 13 Sep 2020 at 00:47, Heinrich Schuchardt wrote: > > Am 13. September 2020 03:24:02 MESZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Sat, 12 Sep 2020 at 14:34, Heinrich Schuchardt > >wrote: > >> > >> Am 12. September 2020 22:24:24 MESZ schrieb Simon Glass > >: > >> >Hi

RE: [EXT] Re: [PATCH] defconfig: espressobin: enable NET_RANDOM_ETHADDR

Hello, > -Original Message- > From: Dennis Gilmore > Sent: Friday, September 11, 2020 20:16 > To: Tom Rini > Cc: Andre Heider ; Marek Behún > ; Pali Rohár ; Stefan Roese > ; Kostya Porotchkin ; U-Boot Mailing > List > Subject: [EXT] Re: [PATCH] defconfig: espressobin: enable >

Re: [PATCH 3/3] net: tftp: Fix load_block offset calculation

On Tue, Aug 25, 2020 at 5:27 AM Ley Foon Tan wrote: > > When load the last block, the "len" might not be a block size. This cause > loading the incorrect last block data. > > The fix change "len" to tftp_block_size and minus one tftp_block_size > for offset calculation. > > Use same offset

Re: [PATCH 4/4] log: Disable the syslog driver by default

Am 13. September 2020 03:24:02 MESZ schrieb Simon Glass : >Hi Heinrich, > >On Sat, 12 Sep 2020 at 14:34, Heinrich Schuchardt >wrote: >> >> Am 12. September 2020 22:24:24 MESZ schrieb Simon Glass >: >> >Hi Heinrich, >> > >> >On Sat, 12 Sep 2020 at 14:16, Heinrich Schuchardt > >> >wrote: >> >> >>

Re: [PATCH 2/3] net: tftp: Fix store_block offset calculation

On Tue, Aug 25, 2020 at 5:27 AM Ley Foon Tan wrote: > > tftp_cur_block start with 1 for first block, but tftp_cur_block counter is > start with zero when block number is rollover. The existing code > "tftp_cur_block - 1" will cause the block number become -1 in store_block() > when tftp_cur_block

Re: [PATCH 1/3] net: tftp: Fix tftp_prev_block counter update

On Tue, Aug 25, 2020 at 5:27 AM Ley Foon Tan wrote: > > Fixes missing update to tftp_prev_block counter before increase > tftp_cur_block counter when do the tftpput operation. > > tftp_prev_block counter is used in update_block_number() function to > check whether block number (sequence number)