Re: [PATCH 4/4] efi_selftest: print CRC32 of initrd as hexadecimal

On Sat, Oct 03, 2020 at 01:57:16PM +0200, Heinrich Schuchardt wrote: > Print the CRC32 loaded via the EFI_LOAD_FILE2_PROTOCOL as a hexadecimal > number. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest_load_initrd.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 2/4] efi_loader: illegal free in EFI_LOAD_FILE2_PROTOCOL

On Sat, Oct 03, 2020 at 01:57:14PM +0200, Heinrich Schuchardt wrote: > strsep() changes the address that its first argument points to. > We cannot use the changed address as argument of free(). > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_load_initrd.c | 17

Re: [PATCH 1/4] efi_loader: description EFI_LOAD_FILE2_PROTOCOL

On Sat, Oct 03, 2020 at 01:57:13PM +0200, Heinrich Schuchardt wrote: > U-Boot offers a EFI_LOAD_FILE2_PROTOCOL which the Linux EFI stub can use to > load an initial RAM disk. Update the function comments of the > implementation. > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [PATCH v2 4/4] smbios: Add documentation and devicetree binding

Hi Heinrich, On Sat, 3 Oct 2020 at 11:54, Heinrich Schuchardt wrote: > > On 10/3/20 5:40 PM, Simon Glass wrote: > > Hi Heinrich, > > > > On Fri, 2 Oct 2020 at 08:57, Heinrich Schuchardt wrote: > >> > >> On 02.10.20 16:23, Simon Glass wrote: > >>> Add information about how to set SMBIOS

RE: [PATCH v2] spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2 fallback compatibility string

Hi Marek, Thank you Cheers, Biju > Subject: Re: [PATCH v2] spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2 > fallback compatibility string > > On 9/30/20 2:19 PM, Biju Das wrote: > > Add fallback compatibility string for R-Car Gen3 and RZ/G2. > > > > Also sorted the compatible string as per SoC

RE: [PATCH v4 1/2] arm: rmobile: Add PRR CPU ID macros for RZ/G2[HMNE]

Hi Marek, Thanks for the feedback. > Subject: Re: [PATCH v4 1/2] arm: rmobile: Add PRR CPU ID macros for > RZ/G2[HMNE] > > On 10/1/20 12:36 PM, Biju Das wrote: > [...] > > > diff --git a/arch/arm/mach-rmobile/include/mach/rmobile.h > > b/arch/arm/mach-rmobile/include/mach/rmobile.h > > index

Re: [PATCH v2] spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2 fallback compatibility string

On 9/30/20 2:19 PM, Biju Das wrote: > Add fallback compatibility string for R-Car Gen3 and RZ/G2. > > Also sorted the compatible string as per SoC ID. > > Signed-off-by: Biju Das Applied to sh/next, thanks

Re: [PATCH v4 1/2] arm: rmobile: Add PRR CPU ID macros for RZ/G2[HMNE]

On 10/1/20 12:36 PM, Biju Das wrote: [...] > diff --git a/arch/arm/mach-rmobile/include/mach/rmobile.h > b/arch/arm/mach-rmobile/include/mach/rmobile.h > index a50249dc96..bd4bd01b75 100644 > --- a/arch/arm/mach-rmobile/include/mach/rmobile.h > +++ b/arch/arm/mach-rmobile/include/mach/rmobile.h

Re: [PATCH] clk: renesas: r8a774a1-cpg-mssr: Add R8A774A1 RPC clock

On 9/29/20 12:09 PM, Biju Das wrote: > Add RPC entry into the R8A774A1 clock driver tables. > > Signed-off-by: Biju Das Applied to sh/next, thanks

Re: [PATCH v2 4/4] smbios: Add documentation and devicetree binding

On 10/3/20 5:40 PM, Simon Glass wrote: > Hi Heinrich, > > On Fri, 2 Oct 2020 at 08:57, Heinrich Schuchardt wrote: >> >> On 02.10.20 16:23, Simon Glass wrote: >>> Add information about how to set SMBIOS properties using the devicetree. >>> >>> Signed-off-by: Simon Glass >>> --- >>> >>> (no

[PATCH 18/20] dm: Use driver_info index instead of pointer

At present we use a 'node' pointer in the of-platadata phandle_n_arg structs. This is a pointer to the struct driver_info for a particular device, and we can use it to obtain the struct udevice pointer itself. Since we don't know the struct udevice pointer until it is allocated in memory, we have

[PATCH 19/20] dm: Don't allow U_BOOT_DEVICE() when of-platdata is used

With of-platdata, the devicetree is supposed to specify all the devices in the system. So far this hasn't really mattered since of-platdata still works correctly. However, new of-platdata features rely on numbering the devices in a particular order so that they can be referenced by a single

[PATCH 20/20] dm: doc: Update the of-platadata documentation

Update this to incorporate the parent feature as well as other recent developments. Signed-off-by: Simon Glass --- doc/driver-model/of-plat.rst | 42 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/doc/driver-model/of-plat.rst

[PATCH 17/20] x86: apl: Take advantage of the of-platdata parent support

Now that parent devices are supported with of-platadata, we don't need the messy code to fix up the parent pointers and allocations on Apollo Lake. Put the code behind a condition. Signed-off-by: Simon Glass --- arch/x86/cpu/apollolake/spl.c | 3 ++- drivers/misc/p2sb-uclass.c| 27

[PATCH 16/20] x86: apl: Enable SPI flash in TPL with APL_SPI_FLASH_BOOT

At present, enabling CONFIG_APL_SPI_FLASH_BOOT does not build since SPI and SPI flash are not enabled for TPL. Add a condition to fix this and tidy up a build warning in the SPI-flash driver. Signed-off-by: Simon Glass --- arch/x86/cpu/apollolake/Kconfig | 2 ++ drivers/spi/ich.c

[PATCH 12/20] sandbox: Fix up building for of-platdata

There is no devicetree with of-platdata. Update a few uclasses to allow them to be built for sandbox_spl. Also drop the i2c-gpio from SPL to avoid build errors, since it does not support of-platdata. Signed-off-by: Simon Glass --- drivers/i2c/Makefile | 2 +-

[PATCH 13/20] dm: Support parent devices with of-platdata

At present of-platdata does not provide parent information. But this is useful for I2C devices, for example, since it allows them to determine which bus they are on. Add support for setting the parent correctly, by storing the parent driver_info index in dtoc and reading this in

[PATCH 14/20] dm: Add a test for of-platdata parent information

Add a simple test that we can obtain the correct parent for an I2C device. This requires updating the driver names to match the compatible strings, adding them to the devicetree and enabling a few options. Signed-off-by: Simon Glass --- arch/sandbox/dts/sandbox.dts | 1 +

[PATCH 11/20] dm: Use an allocated array for run-time device info

At present we update the driver_info struct with a pointer to the device that it created (i.e. caused to be bound). This works fine when U-Boot SPL is stored in read-write memory. But on some platforms, such as Intel Apollo Lake, it is not possible to update the data memory. In any case, it is

[PATCH 15/20] dm: core: Convert #ifdef to if() in root.c

Convert a few conditions to use compile-time checks to reduce the number of build paths. Signed-off-by: Simon Glass --- drivers/core/root.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/core/root.c b/drivers/core/root.c index

[PATCH 10/20] dm: test: Add a test for of-platdata phandles

We have a test in dtoc for this feature, but not one in U-Boot itself. Add a simple test that checks that the information comes through correctly. Signed-off-by: Simon Glass --- arch/sandbox/dts/sandbox.dtsi | 26 configs/sandbox_spl_defconfig | 1 +

[PATCH 06/20] dm: Add a C test for of-platdata properties

At present properties are tested in a roundabout way. The driver's probe() method writes out the values of the properties and the Python test checks the output from U-Boot SPL. Add a C test which checks these values more directly. Signed-off-by: Simon Glass --- test/dm/of_platdata.c | 69

[PATCH 09/20] dm: test: Add a check that all devices have a dev value

With of-platdata, the driver_info struct is updated with the device pointer when it is bound. This makes it easy for a device to be found by its driver info with the device_get_by_driver_info() function. Add a test that all devices (except the root device) have such an entry. Fix a bug that the

[PATCH 07/20] sandbox: Allow selection of SPL unit tests

Now that we have more than one test, add a way to select the test to run. Signed-off-by: Simon Glass --- arch/sandbox/cpu/spl.c | 2 +- arch/sandbox/cpu/start.c | 9 + arch/sandbox/include/asm/state.h | 1 + 3 files changed, 11 insertions(+), 1 deletion(-) diff --git

[PATCH 08/20] dm: test: Drop of-platdata pytest

Now that we have a C version of this test, drop the Python implementation. Signed-off-by: Simon Glass --- arch/sandbox/cpu/spl.c | 12 arch/sandbox/cpu/start.c | 9 -- arch/sandbox/include/asm/state.h | 1 - drivers/misc/spltest_sandbox.c | 35

[PATCH 04/20] dm: core: Allow dm_warn() to be used in SPL

At present this option is disabled in SPL, meaning that warnings are not displayed. It is sometimes useful to see warnings in SPL for debugging purposes. Add a new Kconfig option to permit this. Signed-off-by: Simon Glass --- drivers/core/Kconfig | 18 --

[PATCH 05/20] dtoc: Fix widening of int to bytes

At present an integer is converted to bytes incorrectly. The whole 32-bit integer is inserted as the first element of the byte array, and the other three bytes are skipped. This was not noticed because the unit test did not check it, and the functional test was checking for wrong values. Update

[PATCH 03/20] dtoc: Order the structures internally by name

At present the structures are written in name order, but parents have to be written before their children, so the file does not end up being in order. The order of nodes in _valid_nodes matches the order of the devicetree. Update the code so that _valid_nodes is in sorted order, by C name of the

[PATCH 02/20] dtoc: Document the return value of scan_structs()

Add documentation to this function as well as generate_structs(), where the return value is ultimately passed in. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tools/dtoc/dtb_platdata.py

[PATCH 00/20] dm: Enhance of-platdata to support parent devices

At present dev_get_parent() always returns the root device with of-platdata. This means that it is not possible to find the I2C bus for an I2C device easily. In many cases this does not cause problems as there is only a single I2C bus, but it is still inconsistent with U-Boot proper. Worse is

[PATCH 01/20] sandbox: Drop ad-hoc device declarations in SPL

Since sandbox's SPL is build with of-platadata, we should not use U_BOOT_DEVICE() declarations as well. Drop them. Signed-off-by: Simon Glass --- board/sandbox/sandbox.c | 2 ++ drivers/serial/sandbox.c| 3 +++ drivers/sysreset/sysreset_sandbox.c | 2 ++ 3 files

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

On Sat, 3 Oct 2020 at 18:35, Heinrich Schuchardt wrote: > > On 10/3/20 3:12 PM, Ard Biesheuvel wrote: > > > > > > On Sat, 3 Oct 2020 at 13:16, François Ozog > > wrote: > > > > > > > > Le sam. 3 oct. 2020 à 13:14, François Ozog >

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

On 10/3/20 3:12 PM, Ard Biesheuvel wrote: > > > On Sat, 3 Oct 2020 at 13:16, François Ozog > wrote: > > > > Le sam. 3 oct. 2020 à 13:14, François Ozog > a écrit : > > > > Le sam. 3 oct. 2020 à 10:51, Heinrich

[PATCH 00/17] dm: test: Add unit tests for SPL

U-Boot has about 700 tests but only a handful of these target SPL. This is partly because SPL has limited functionality and does not have a command interface to initiate tests. The current SPL tests are targeted at sandbox_spl and are initiated from pytest. With SPL tests written in C, we can

Re: [PATCH v2 4/4] smbios: Add documentation and devicetree binding

Hi Heinrich, On Fri, 2 Oct 2020 at 08:57, Heinrich Schuchardt wrote: > > On 02.10.20 16:23, Simon Glass wrote: > > Add information about how to set SMBIOS properties using the devicetree. > > > > Signed-off-by: Simon Glass > > --- > > > > (no changes since v1) > > > > doc/arch/x86.rst

[PATCH 17/17] Azure/GitLab/Travis: Add SPL unit tests

Run SPL unit tests in all test environments. Signed-off-by: Simon Glass --- .azure-pipelines.yml | 2 +- .gitlab-ci.yml | 2 +- .travis.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml index

[PATCH 16/17] test: Run SPL unit tests

Update the 'run' script to include SPL unit tests. Signed-off-by: Simon Glass --- test/run | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/run b/test/run index de87e7530b1..735628e7e37 100755 --- a/test/run +++ b/test/run @@ -28,7 +28,7 @@ fi # Run tests which

[PATCH 15/17] pytest: Collect SPL unit tests

Add a new test_spl fixture to handle running SPL unit tests. Signed-off-by: Simon Glass --- test/py/conftest.py | 14 +- test/py/tests/test_spl.py | 29 + 2 files changed, 38 insertions(+), 5 deletions(-) create mode 100644

[PATCH 14/17] Makefile: Generate a symbol file for u-boot-spl

Add a rule to generate u-boot-spl.sym so that pytest can discover the available unit tests. Signed-off-by: Simon Glass --- scripts/Makefile.spl | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 2e3a443035c..9f1f7445d71

[PATCH 13/17] dm: test: Add a very simple of-platadata test

At present we have a pytest that covers of-platadata. Add a very simple unit test that just checks that a device can be found. This shows the ability to write these tests in C. Signed-off-by: Simon Glass --- test/dm/Makefile | 4 +++- test/dm/of_platdata.c | 19 +++ 2

[PATCH 11/17] dm: test: Update the test runner to support of-platdata

At present DM tests assume that a devicetree is available. This is not the case with of-platadata. Update the code to add this condition. Signed-off-by: Simon Glass --- test/dm/test-main.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git

[PATCH 12/17] dm: test: Add a way to run SPL tests

Add a -u flag for U-Boot SPL which requests that unit tests be run. To make this work, export dm_test_main() and update it to skip test features that are not used with of-platdata. To run the tests: $ spl/u-boot-spl -u U-Boot SPL 2020.10-rc5 (Oct 01 2020 - 07:35:39 -0600) Running 0

[PATCH 10/17] dm: test: Build tests for SPL

We want to run unit tests in SPL. Add a new Kconfig to control this and enable it for sandbox_spl Signed-off-by: Simon Glass --- configs/sandbox_spl_defconfig | 2 +- scripts/Makefile.spl | 1 + test/Kconfig | 10 ++ 3 files changed, 12 insertions(+), 1

[PATCH 06/17] dm: test: Sort the Makefile

Move everything into alphabetical order. Signed-off-by: Simon Glass --- test/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/Makefile b/test/Makefile index 7c4039964e1..13ee661f50e 100644 --- a/test/Makefile +++ b/test/Makefile @@ -5,12 +5,12 @@

[PATCH 09/17] dm: test: Disable some tests that should not run in SPL

Tests are easier to run in U-Boot proper. Running them in SPL does not add test coverage in most cases. Also some tests use features that are not available in SPL. Update the build rules to disable these tests in SPL. We still need test-main to be able to actually run SPL tests. Signed-off-by:

[PATCH 08/17] dm: test: Make use of CONFIG_UNIT_TEST

At present we always include test/dm from the main Makefile. We have a CONFIG_UNIT_TEST that should control whether the test/ directory is built, so rely on that instead. Signed-off-by: Simon Glass --- Makefile | 2 +- test/Makefile | 3 ++- 2 files changed, 3 insertions(+), 2

[PATCH 07/17] dm: test: Update Makefile conditions

At present most of the tests in test/Makefile are dependent on CONFIG_SANDBOX. But this is not ideal since they rely on commands being available and SPL does not support commands. Use CONFIG_COMMAND instead. This has the dual purpose of allowing these tests to be used on other boards and allowing

[PATCH 03/17] dm: core: Expand the comment for DM_GET_DEVICE()

The current documentation for this is not particularly enlightening. Add a little more detail. Signed-off-by: Simon Glass --- include/dm/platdata.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/include/dm/platdata.h b/include/dm/platdata.h index

[PATCH 02/17] dtoc: Use a namedtuple for _links

The use of strings to access a dict is a bit ugly. Use a namedtuple for this instead. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py index

[PATCH 05/17] dm: Avoid using #ifdef for CONFIG_OF_LIVE

At present this option results in a number of #ifdefs due to the presence or absence of the global_data of_root member. Add a few macros to global_data.h to work around this. Update the code accordingly. Signed-off-by: Simon Glass --- common/board_r.c | 19 +--

[PATCH 04/17] dm: core: Avoid void * in the of-platdata structs

These pointers point to drivers. Update the definition to make this clear. Signed-off-by: Simon Glass --- include/dt-structs.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/include/dt-structs.h b/include/dt-structs.h index 924d51fc522..eed8273d18e 100644 ---

[PATCH 01/17] dtoc: Extract inner loop from output_node()

This function is very long. Put the inner loop in a separate function to enhance readability. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 89 +- 1 file changed, 49 insertions(+), 40 deletions(-) diff --git a/tools/dtoc/dtb_platdata.py

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

On Sat, 3 Oct 2020 at 13:16, François Ozog wrote: > > > Le sam. 3 oct. 2020 à 13:14, François Ozog a > écrit : > >> >> >> Le sam. 3 oct. 2020 à 10:51, Heinrich Schuchardt a >> écrit : >> >>> Hello Ilias, hello Christian, >>> >>> >>> >>> with commit ec80b4735a59 ("efi_loader: Implement

[PATCH 4/4] efi_selftest: print CRC32 of initrd as hexadecimal

Print the CRC32 loaded via the EFI_LOAD_FILE2_PROTOCOL as a hexadecimal number. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_load_initrd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_selftest/efi_selftest_load_initrd.c

[PATCH 2/4] efi_loader: illegal free in EFI_LOAD_FILE2_PROTOCOL

strsep() changes the address that its first argument points to. We cannot use the changed address as argument of free(). Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_load_initrd.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH 3/4] efi_selftest: enable printing hexadecimal numbers

Add code to use %x in efi_st_print(). Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_console.c | 35 - 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/lib/efi_selftest/efi_selftest_console.c b/lib/efi_selftest/efi_selftest_console.c

[PATCH 1/4] efi_loader: description EFI_LOAD_FILE2_PROTOCOL

U-Boot offers a EFI_LOAD_FILE2_PROTOCOL which the Linux EFI stub can use to load an initial RAM disk. Update the function comments of the implementation. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_load_initrd.c | 42 +--- 1 file changed, 23

[PATCH 0/4] efi_loader: fix EFI_LOAD_FILE2_PROTOCOL

The EFI_LOAD_FILE2_PROTOCOL is used to provide an initial RAM disk to the Linux EFI stub. The following problems in the implementation are addressed: * illegal free() * insufficient function descriptions * CRC32 in unit test printed as decimal instead of hexadecimal Heinrich Schuchardt (4):

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

Le sam. 3 oct. 2020 à 13:14, François Ozog a écrit : > > > Le sam. 3 oct. 2020 à 10:51, Heinrich Schuchardt a > écrit : > >> Hello Ilias, hello Christian, >> >> >> >> with commit ec80b4735a59 ("efi_loader: Implement FileLoad2 for initramfs >> >> loading") Ilias provided the possibility to

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

Le sam. 3 oct. 2020 à 10:51, Heinrich Schuchardt a écrit : > Hello Ilias, hello Christian, > > > > with commit ec80b4735a59 ("efi_loader: Implement FileLoad2 for initramfs > > loading") Ilias provided the possibility to specify a device path > > (CONFIG_EFI_INITRD_FILESPEC) from which an initial

Fit images and EFI_LOAD_FILE2_PROTOCOL

Hello Ilias, hello Christian, with commit ec80b4735a59 ("efi_loader: Implement FileLoad2 for initramfs loading") Ilias provided the possibility to specify a device path (CONFIG_EFI_INITRD_FILESPEC) from which an initial RAM disk can be served via the EFI_FILE_LOAD2_PROTOCOL. Ard extended the

Re: [PATCH v2] arm: mvebu: Espressobin: Set environment variable fdtfile

On Saturday 03 October 2020 09:17:35 Andre Heider wrote: > On 02/10/2020 12:49, Pali Rohár wrote: > > On Saturday 26 September 2020 11:09:59 Andre Heider wrote: > > > On 25/09/2020 09:46, Pali Rohár wrote: > > > > On Friday 11 September 2020 06:35:10 Andre Heider wrote: > > > ... > > > > > +#ifdef

Re: [PATCH v2] arm: mvebu: Espressobin: Set environment variable fdtfile

On 02/10/2020 12:49, Pali Rohár wrote: On Saturday 26 September 2020 11:09:59 Andre Heider wrote: On 25/09/2020 09:46, Pali Rohár wrote: On Friday 11 September 2020 06:35:10 Andre Heider wrote: ... +#ifdef CONFIG_BOARD_LATE_INIT +int board_late_init(void) +{ + bool ddr4, emmc; + +