Re: [PATCH 0/5] configs: ti: am65x/j721e: Use DEFAULT_LINUX_BOOT_ENV

2020-10-06 Thread Lokesh Vutla
On 07/10/20 12:35 am, Nishanth Menon wrote: > Use the common defaults from ./include/configs/ti_armv7_common.h > > This saves us from rediscovering the same painful lessons learnt from > ARMv7 (kernel dtbs ramdisks overlays stomping on each other etc..) If PATCH 3 is made as PATCH 1, then

Re: [PATCH] dm: ofnode: Fix compile breakage with OF_CHECKS enabled

2020-10-06 Thread Stefan Roese
Hi Simon, On 05.10.20 23:32, Simon Glass wrote: Hi Stefan, On Wed, 23 Sep 2020 at 00:23, Stefan Roese wrote: Include missing log.h and change _ofnode_to_np() to ofnode_to_np() so that compiling with OF_CHECKS enabled does not break. Signed-off-by: Stefan Roese Cc: Simon Glass ---

Re: [PATCH v3] arm64: dts: armada-3720-espressobin: use Linux model/compatible strings

2020-10-06 Thread Stefan Roese
On 02.10.20 07:51, Andre Heider wrote: Fix the actual board vendor and ease synching dts files from Linux. Signed-off-by: Andre Heider Reviewed-by: Stefan Roese Thanks, Stefan --- v3: rebase on master arch/arm/dts/armada-3720-espressobin.dts | 4 ++--

Re: [PATCH] arm: mvebu: Remove old comments from configs/mvebu_armada-37xx.h file

2020-10-06 Thread Stefan Roese
On 05.10.20 12:17, Pali Rohár wrote: These comments are relict for old, now removed config options. So remove these obsoleted comments too. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- include/configs/mvebu_armada-37xx.h | 7 --- 1 file changed, 7

Re: [PATCH 0/2] mtd: cfi_mtd: Add DMA support for reads

2020-10-06 Thread Stefan Roese
Hi Vignesh, On 05.10.20 20:42, Vignesh Raghavendra wrote: Hi Stefan On 9/17/20 4:53 PM, Vignesh Raghavendra wrote: This series adds DMA support to read from memory mapped CFI flashes First patch reduces noise from DMA APIs Second patch adds DMA support for cfi_mtd. Tested on J721e that has

Pre-built (and tested) images

2020-10-06 Thread Naoki Hayama
Dear Tom, Wolfgang, I have a question about Pre-built (and tested) images. README says: Pre-built (and tested) images are available from ftp://ftp.denx.de/pub/u-boot/images/ However, this link is broken. It seems that ftp.denx.de/pub/u-boot/ doesn't have images/ directory. Are

[PATCH 3/3] cosmetic: image: Fix comments and the order of definitions

2020-10-06 Thread Naoki Hayama
Fix some comments about functions. Move genimg_get_comp_name() above genimg_get_short_name() because genimg_get_comp_name() is related to get_table_entry_name(). Signed-off-by: Naoki Hayama --- common/image.c | 20 ++-- include/image.h | 1 + 2 files changed, 11

[PATCH 2/3] mkimage: Skip adding non-existent IDs to a list

2020-10-06 Thread Naoki Hayama
In show_valid_options(), this patch introduces checking whether a category has an entry ID. If not, adding it to a list for output is skipped before calling qsort(). This patch will affect all kinds of image header categories (-A, -C, -O and -T flags). Signed-off-by: Naoki Hayama ---

[PATCH 1/3] image: Add a function to modify category information

2020-10-06 Thread Naoki Hayama
Add a generic function which can check whether a category has an entry ID. Signed-off-by: Naoki Hayama --- common/image.c | 18 ++ include/image.h | 9 + 2 files changed, 27 insertions(+) diff --git a/common/image.c b/common/image.c index 645bfef169..4fc4a0f1c4

[PATCH 0/3] mkimage: modify show_valid_options for usability

2020-10-06 Thread Naoki Hayama
Currently, show_valid_options() shows "Unknown ***" lines. For example: $ ./tools/mkimage -A hoge Invalid architecture, supported are: Unknown architecture Unknown architecture Unknown architecture Unknown architecture alpha

[PATCH v2 2/2] efi_loader: fix use after free in receive path

2020-10-06 Thread Patrick Wildt
With DM enabled the ethernet code will receive a packet, call the push method that's set by the EFI network implementation and then free the packet. Unfortunately the push methods only sets a flag that the packet needs to be handled, but the code that provides the packet to an EFI application

[PATCH v2 1/2] net: add a define for the number of packets received as batch

2020-10-06 Thread Patrick Wildt
With a define for the magic number of packets received as batch we can make sure that the EFI network stack caches the same amount of packets. Signed-off-by: Patrick Wildt --- include/net.h| 3 +++ net/eth-uclass.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] efi_loader: fix use after free in receive path

2020-10-06 Thread Patrick Wildt
On Wed, Oct 07, 2020 at 12:45:17AM +0200, Heinrich Schuchardt wrote: > Am 7. Oktober 2020 00:30:51 MESZ schrieb Patrick Wildt : > >With DM enabled the ethernet code will receive a packet, call > >the push method that's set by the EFI network implementation > >and then free the packet.

Re: [PATCH] efi_loader: fix use after free in receive path

2020-10-06 Thread Heinrich Schuchardt
Am 7. Oktober 2020 00:30:51 MESZ schrieb Patrick Wildt : >With DM enabled the ethernet code will receive a packet, call >the push method that's set by the EFI network implementation >and then free the packet. Unfortunately the push methods only >sets a flag that the packet needs to be handled,

[PATCH] efi_loader: fix use after free in receive path

2020-10-06 Thread Patrick Wildt
With DM enabled the ethernet code will receive a packet, call the push method that's set by the EFI network implementation and then free the packet. Unfortunately the push methods only sets a flag that the packet needs to be handled, but the code that provides the packet to an EFI application

Re: efi_loader: fix free() before use in RX path

2020-10-06 Thread Patrick Wildt
On Tue, Oct 06, 2020 at 10:26:44PM +0200, Heinrich Schuchardt wrote: > On 10/6/20 6:32 PM, Patrick Wildt wrote: > > On Tue, Oct 06, 2020 at 04:56:31PM +0200, Patrick Wildt wrote: > >> Hi, > >> > >> I have an EFI application doing TFTP on an i.MX8MM board. The EFI > >> application uses the Simple

Re: [PATCH 1/1] rsa: fix retrieving public exponent on big-endian systems

2020-10-06 Thread Rasmus Villemoes
On 07/10/2020 00.02, Simon Glass wrote: > Hi Rasmus, > > On Tue, 6 Oct 2020 at 04:10, Rasmus Villemoes > wrote: >> >> Commit fdf0819afb (rsa: fix alignment issue when getting public >> exponent) changed the logic to avoid doing an 8-byte access to a >> possibly-not-8-byte-aligned address. >> >>

[PATCH 1/1] efi_loader: separate device-tree handling

2020-10-06 Thread Heinrich Schuchardt
Put UEFI related device tree handling into a separate C module. Signed-off-by: Heinrich Schuchardt --- cmd/bootefi.c | 277 ++--- common/bootm_os.c | 15 +- lib/efi_loader/Makefile| 3 + lib/efi_loader/efi_fdt_fixup.c | 258

Re: [PATCH 16/18] test: py: Add a test for log filter-*

2020-10-06 Thread Sean Anderson
On 10/6/20 6:07 PM, Simon Glass wrote: > Hi Sean, > > On Tue, 6 Oct 2020 at 13:16, Sean Anderson wrote: >> >> This exercises a few success and failure modes of the log filter-* >> commands. >> >> Signed-off-by: Sean Anderson >> --- >> >> test/py/tests/test_log.py | 39

Re: [PATCH 16/18] test: py: Add a test for log filter-*

2020-10-06 Thread Simon Glass
Hi Sean, On Tue, 6 Oct 2020 at 13:16, Sean Anderson wrote: > > This exercises a few success and failure modes of the log filter-* > commands. > > Signed-off-by: Sean Anderson > --- > > test/py/tests/test_log.py | 39 +++ > 1 file changed, 39 insertions(+) >

Re: [PATCH 15/18] cmd: log: Add commands to manipulate filters

2020-10-06 Thread Sean Anderson
On 10/6/20 6:02 PM, Simon Glass wrote: > Hi Sean, > > On Tue, 6 Oct 2020 at 13:16, Sean Anderson wrote: >> >> This adds several commands to add, list, and remove log filters. Due to the >> complexity of adding a filter, `log filter-list` uses options instead of >> positional arguments. >> >>

Re: [PATCH 15/18] cmd: log: Add commands to manipulate filters

2020-10-06 Thread Simon Glass
Hi Sean, On Tue, 6 Oct 2020 at 13:16, Sean Anderson wrote: > > This adds several commands to add, list, and remove log filters. Due to the > complexity of adding a filter, `log filter-list` uses options instead of > positional arguments. > > These commands have been added as subcommands to log

Re: [PATCH 1/1] rsa: fix retrieving public exponent on big-endian systems

2020-10-06 Thread Simon Glass
Hi Rasmus, On Tue, 6 Oct 2020 at 04:10, Rasmus Villemoes wrote: > > Commit fdf0819afb (rsa: fix alignment issue when getting public > exponent) changed the logic to avoid doing an 8-byte access to a > possibly-not-8-byte-aligned address. > > However, using rsa_convert_big_endian is wrong: That

Re: [PATCH 3/5] bloblist: Tidy up the data alignment

2020-10-06 Thread Simon Glass
Hi Rasmus, On Mon, 5 Oct 2020 at 23:41, Rasmus Villemoes wrote: > > On 20/09/2020 02.49, Simon Glass wrote: > > The intention which bloblists is that each blob's data is aligned in > > memory. At present it is only the headers that are aligned. > > > > Update the code to correct this and add a

Re: [PATCH 18/18] doc: Update logging documentation

2020-10-06 Thread Sean Anderson
On 10/6/20 5:28 PM, Heinrich Schuchardt wrote: > On 10/6/20 10:38 PM, Sean Anderson wrote: >> On 10/6/20 4:34 PM, Heinrich Schuchardt wrote: >>> On 10/6/20 9:16 PM, Sean Anderson wrote: This updates logging documentation with some examples of the new commands added in the previous

Re: [PATCH 15/18] cmd: log: Add commands to manipulate filters

2020-10-06 Thread Sean Anderson
On 10/6/20 5:14 PM, Heinrich Schuchardt wrote: > On 10/6/20 9:16 PM, Sean Anderson wrote: >> This adds several commands to add, list, and remove log filters. Due to the >> complexity of adding a filter, `log filter-list` uses options instead of >> positional arguments. >> >> These commands have

Re: [PATCH 18/18] doc: Update logging documentation

2020-10-06 Thread Heinrich Schuchardt
On 10/6/20 10:38 PM, Sean Anderson wrote: > On 10/6/20 4:34 PM, Heinrich Schuchardt wrote: >> On 10/6/20 9:16 PM, Sean Anderson wrote: >>> This updates logging documentation with some examples of the new commands >>> added in the previous commits. It also removes some items from the to-do >>> list

Re: [PATCH 15/18] cmd: log: Add commands to manipulate filters

2020-10-06 Thread Heinrich Schuchardt
On 10/6/20 9:16 PM, Sean Anderson wrote: > This adds several commands to add, list, and remove log filters. Due to the > complexity of adding a filter, `log filter-list` uses options instead of > positional arguments. > > These commands have been added as subcommands to log by using a dash to >

Re: [PATCH 03/18] log: Add new category names to log_cat_name

2020-10-06 Thread Heinrich Schuchardt
On 10/6/20 9:15 PM, Sean Anderson wrote: > Without every category between LOGC_NONE and LOGC_COUNT present in > log_cat_name, log_get_cat_by_name will dereference NULL pointers if it > doesn't find a name early enough. > > Fixes: c3aed5db59 ("sandbox: spi: Add more logging") > Fixes: a5c13b68e7

Re: [PATCH 02/18] log: Fix incorrect documentation of log_filter.cat_list

2020-10-06 Thread Heinrich Schuchardt
On 10/6/20 9:15 PM, Sean Anderson wrote: > This list is expected to be terminated by LOGC_END, not LOGC_NONE. %s/This list is expected to be/Logging category lists are/ > > Fixes: e9c8d49d54 ("log: Add an implementation of logging") > > Signed-off-by: Sean Anderson > --- > > include/log.h | 2

[PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-06 Thread Alper Nebi Yasak
Found this by comparing it to the coreboot driver, a form of this call was introduced there in their commit b9a7877568cf ("rockchip/*: refactor edp driver"). This is copy-pasted from U-Boot's link_train_cr() slightly above it. Without this on a gru-kevin chromebook, I have: clock recovery at

Re: [PATCH 18/18] doc: Update logging documentation

2020-10-06 Thread Sean Anderson
On 10/6/20 4:34 PM, Heinrich Schuchardt wrote: > On 10/6/20 9:16 PM, Sean Anderson wrote: >> This updates logging documentation with some examples of the new commands >> added in the previous commits. It also removes some items from the to-do >> list which have been implemented. >> >>

Re: [PATCH 01/18] log: Fix missing negation of ENOMEM

2020-10-06 Thread Heinrich Schuchardt
On 10/6/20 9:15 PM, Sean Anderson wrote: > Errors returned should be negative. > > Fixes: 45fac9fc18 ("log: Correct missing free() on error in log_add_filter()") > > Signed-off-by: Sean Anderson > --- > > common/log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 18/18] doc: Update logging documentation

2020-10-06 Thread Heinrich Schuchardt
On 10/6/20 9:16 PM, Sean Anderson wrote: > This updates logging documentation with some examples of the new commands > added in the previous commits. It also removes some items from the to-do > list which have been implemented. > > Signed-off-by: Sean Anderson > --- > > doc/develop/logging.rst |

Re: efi_loader: fix free() before use in RX path

2020-10-06 Thread Heinrich Schuchardt
On 10/6/20 6:32 PM, Patrick Wildt wrote: > On Tue, Oct 06, 2020 at 04:56:31PM +0200, Patrick Wildt wrote: >> Hi, >> >> I have an EFI application doing TFTP on an i.MX8MM board. The EFI >> application uses the Simple Network Protocol and does ARP itself. >> ARP didn't work, and I saw that the

[PATCH 15/18] cmd: log: Add commands to manipulate filters

2020-10-06 Thread Sean Anderson
This adds several commands to add, list, and remove log filters. Due to the complexity of adding a filter, `log filter-list` uses options instead of positional arguments. These commands have been added as subcommands to log by using a dash to join the subcommand and subsubcommand. This is

[PATCH 18/18] doc: Update logging documentation

2020-10-06 Thread Sean Anderson
This updates logging documentation with some examples of the new commands added in the previous commits. It also removes some items from the to-do list which have been implemented. Signed-off-by: Sean Anderson --- doc/develop/logging.rst | 42 + 1 file

[PATCH 16/18] test: py: Add a test for log filter-*

2020-10-06 Thread Sean Anderson
This exercises a few success and failure modes of the log filter-* commands. Signed-off-by: Sean Anderson --- test/py/tests/test_log.py | 39 +++ 1 file changed, 39 insertions(+) diff --git a/test/py/tests/test_log.py b/test/py/tests/test_log.py index

[PATCH 13/18] lib: Add getopt

2020-10-06 Thread Sean Anderson
Some commands can get very unweildy if they have too many positional arguments. Adding options makes them easier to read, remember, and understand. This implementation of getopt has been taken from barebox, which has had option support for quite a while. I have made a few modifications to their

[PATCH 17/18] doc: Add log kerneldocs to documentation

2020-10-06 Thread Sean Anderson
The functions in log.h are already mostly documented, so add them to the generated documentation. This commit adds no new documentation, so several enum members are left undocumented. Signed-off-by: Sean Anderson --- doc/develop/logging.rst | 5 ++ include/log.h | 118

[PATCH 10/18] test: Add test for LOGFF_MIN

2020-10-06 Thread Sean Anderson
This tests log filters matching on a minimum level. Signed-off-by: Sean Anderson --- test/log/log_test.c | 23 +++ test/py/tests/test_log.py | 5 + 2 files changed, 28 insertions(+) diff --git a/test/log/log_test.c b/test/log/log_test.c index

[PATCH 12/18] cmd: log: Split off log level parsing

2020-10-06 Thread Sean Anderson
Move parsing of log level into its own function so it can be re-used. This also adds support for using log level names instead of just the integer equivalent. Signed-off-by: Sean Anderson --- cmd/log.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git

[PATCH 14/18] test: Add a test for getopt

2020-10-06 Thread Sean Anderson
A few of these tests were inspired by those in glibc. The syntax for invoking test_getopt is a bit funky, but it's necessary so that the CPP can parse the arguments correctly. Signed-off-by: Sean Anderson --- test/lib/Makefile | 1 + test/lib/getopt.c | 123

[PATCH 09/18] log: Add filter flag to match greater than a log level

2020-10-06 Thread Sean Anderson
This is the compliment of the existing behavior to match only messages with a log level less than a threshold. This is primarily useful in conjunction with LOGFF_DENY. Signed-off-by: Sean Anderson --- common/log.c | 12 +--- include/log.h | 10 ++ 2 files changed, 15

[PATCH 11/18] cmd: log: Use sub-commands for log

2020-10-06 Thread Sean Anderson
This reduces duplicate code, and makes adding new sub-commands easier. Signed-off-by: Sean Anderson --- cmd/log.c | 37 +++-- 1 file changed, 7 insertions(+), 30 deletions(-) diff --git a/cmd/log.c b/cmd/log.c index 16a6ef7539..e55ace9e14 100644 --- a/cmd/log.c

[PATCH 07/18] log: Add filter flag to deny on match

2020-10-06 Thread Sean Anderson
Without this flag, log filters can only explicitly accept messages. Allowing denial makes it easier to filter certain subsystems. Unlike allow-ing filters, deny-ing filters are added to the beginning of the filter list. This should do the Right Thing most of the time, but it's less-universal than

[PATCH 08/18] test: Add tests for LOGFF_DENY

2020-10-06 Thread Sean Anderson
This adds some tests for log filters which deny if they match. Signed-off-by: Sean Anderson --- test/log/log_test.c | 69 +++ test/py/tests/test_log.py | 21 ++-- 2 files changed, 88 insertions(+), 2 deletions(-) diff --git

[PATCH 06/18] log: Add function to create a filter with flags

2020-10-06 Thread Sean Anderson
This function exposes a way to specify flags when creating a filter. Signed-off-by: Sean Anderson --- common/log.c | 6 -- include/log.h | 29 +++-- 2 files changed, 31 insertions(+), 4 deletions(-) diff --git a/common/log.c b/common/log.c index

[PATCH 05/18] log: Expose log_device_find_by_name

2020-10-06 Thread Sean Anderson
This function is required by "cmd: log: Add commands to manipulate filters". Signed-off-by: Sean Anderson --- common/log.c | 2 +- include/log.h | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/common/log.c b/common/log.c index 09e39b0eca..bcb9e2634a 100644 ---

[PATCH 00/18] log: Add commands for manipulating filters

2020-10-06 Thread Sean Anderson
This series adds several commands for adding, listing, and removing log filters. It also adds getopt, since the filter-add command needs to have several optional arguments to be complete, and positional specification of those arguments would have been difficult. Sean Anderson (18): log: Fix

[PATCH 02/18] log: Fix incorrect documentation of log_filter.cat_list

2020-10-06 Thread Sean Anderson
This list is expected to be terminated by LOGC_END, not LOGC_NONE. Fixes: e9c8d49d54 ("log: Add an implementation of logging") Signed-off-by: Sean Anderson --- include/log.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/log.h b/include/log.h index

[PATCH 04/18] log: Use CONFIG_IS_ENABLED() for LOG_TEST

2020-10-06 Thread Sean Anderson
Checkpatch complains about using #ifdef for CONFIG variables. Signed-off-by: Sean Anderson --- cmd/log.c | 4 ++-- test/log/log_test.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/log.c b/cmd/log.c index 6afe6ead25..16a6ef7539 100644 --- a/cmd/log.c +++

[PATCH 01/18] log: Fix missing negation of ENOMEM

2020-10-06 Thread Sean Anderson
Errors returned should be negative. Fixes: 45fac9fc18 ("log: Correct missing free() on error in log_add_filter()") Signed-off-by: Sean Anderson --- common/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/log.c b/common/log.c index 9a5f100da3..3f6f4bdc2a 100644

[PATCH 03/18] log: Add new category names to log_cat_name

2020-10-06 Thread Sean Anderson
Without every category between LOGC_NONE and LOGC_COUNT present in log_cat_name, log_get_cat_by_name will dereference NULL pointers if it doesn't find a name early enough. Fixes: c3aed5db59 ("sandbox: spi: Add more logging") Fixes: a5c13b68e7 ("sandbox: log: Add a category for sandbox") Fixes:

[PATCH 1/5] configs: am65x_evm: Use DEFAULT_LINUX_BOOT_ENV

2020-10-06 Thread Nishanth Menon
Use DEFAULT_LINUX_BOOT_ENV to define the standard addresses used in rest of TI platforms as defined in ti_armv7_common.h This avoids the standard pitfalls we've had with kernel images and fdt addresses stomping on each other. As part of this process, redefine overlayaddr to be dtboaddr (defined

[PATCH 3/5] env: ti: ufs: Use dtboaddr instead of overlayaddr

2020-10-06 Thread Nishanth Menon
Use dtboaddr to define the overlay address common to all TI platforms instead of creating a new overlayaddr for the purpose. Signed-off-by: Nishanth Menon --- include/environment/ti/ufs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/environment/ti/ufs.h

[PATCH 4/5] configs: am65x_evm: Get rid of overlayaddr

2020-10-06 Thread Nishanth Menon
Now that we are all clear of users of overlayaddr, get rid of it. Signed-off-by: Nishanth Menon --- include/configs/am65x_evm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/configs/am65x_evm.h b/include/configs/am65x_evm.h index 19dc1a537e6a..9eed0ea203a9 100644 ---

[PATCH 5/5] configs: j721e_evm: Get rid of overlayaddr

2020-10-06 Thread Nishanth Menon
Now that we dont have any further users of overlayaddr, get rid of it. Signed-off-by: Nishanth Menon --- include/configs/j721e_evm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/configs/j721e_evm.h b/include/configs/j721e_evm.h index 820e51378260..b707fc4e899f 100644 ---

[PATCH 0/5] configs: ti: am65x/j721e: Use DEFAULT_LINUX_BOOT_ENV

2020-10-06 Thread Nishanth Menon
Use the common defaults from ./include/configs/ti_armv7_common.h This saves us from rediscovering the same painful lessons learnt from ARMv7 (kernel dtbs ramdisks overlays stomping on each other etc..) Nishanth Menon (5): configs: am65x_evm: Use DEFAULT_LINUX_BOOT_ENV configs: j721e_evm:

[PATCH 2/5] configs: j721e_evm: Use DEFAULT_LINUX_BOOT_ENV

2020-10-06 Thread Nishanth Menon
Use DEFAULT_LINUX_BOOT_ENV to define the standard addresses used in rest of TI platforms as defined in ti_armv7_common.h This avoids the standard pitfalls we've had with kernel images and fdt addresses stomping on each other. As part of this process, redefine overlayaddr to be dtboaddr (defined

Re: Pull request for UEFI sub-system for efi-2021-01-rc1

2020-10-06 Thread Tom Rini
On Tue, Oct 06, 2020 at 12:17:29PM +0200, Heinrich Schuchardt wrote: > The following changes since commit b24550accd7e3a62c6da773a9096dfd1471403d5: > > configs: Resync with savedefconfig (2020-10-05 14:11:16 -0400) > > are available in the Git repository at: > >

Re: [PULL u-boot] Please pull u-boot-amlogic-20201005

2020-10-06 Thread Tom Rini
On Tue, Oct 06, 2020 at 08:56:12AM +0200, Neil Armstrong wrote: > Hi Tom, > > This PR adds proper USB OTG support for GXL/GXM and AXG based boards with > Linux 5.8 DT sync, > adds dynamic PCIe enable in OS DT for the VIM3/VIM3L boards with Linux 5.9 DT > sync, > AXG pinctrl fixes, introduces

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread Ard Biesheuvel
On Tue, 6 Oct 2020 at 17:09, François Ozog wrote: > > > On Tue, 6 Oct 2020 at 16:46, Ard Biesheuvel wrote: > >> >> >> On Tue, 6 Oct 2020 at 16:22, François Ozog >> wrote: >> >>> Ard, there is a question for you in the below thread ;-) >>> >>> On Tue, 6 Oct 2020 at 15:02, Grant Likely wrote:

Please pull u-boot-dm

2020-10-06 Thread Simon Glass
Hi Tom, build result here: https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/4934 The following changes since commit b24550accd7e3a62c6da773a9096dfd1471403d5: configs: Resync with savedefconfig (2020-10-05 14:11:16 -0400) are available in the Git repository at:

[PATCH 3/7] lmb: remove lmb_region.size

2020-10-06 Thread Patrick Delaunay
Remove the unused field size of struct lmb_region as it is initialized to 0 and never used after in lmb library. See Linux kernel commit 4734b594c6ca ("memblock: Remove memblock_type.size and add memblock.memory_size instead") Signed-off-by: Patrick Delaunay --- include/lmb.h | 1 - lib/lmb.c

[PATCH 7/7] arm: cache: cp15: don't map the reserved region with no-map property

2020-10-06 Thread Patrick Delaunay
No more map the reserved region with "no-map" property by marking the corresponding TLB entries with invalid entry (=0) to avoid speculative access. This patch fixes an issue on STM32MP15x where predictive read access on secure DDR area are caught by OP-TEE. Signed-off-by: Patrick Delaunay ---

[PATCH 6/7] image-fdt: save no-map parameter of reserve-memory

2020-10-06 Thread Patrick Delaunay
Save the no-map information present in reserve-memory node to allow correct handling when the MMU is configured in board to avoid speculative access. Signed-off-by: Patrick Delaunay --- common/image-fdt.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff

[PATCH 1/7] lmb: Add support of flags for no-map properties

2020-10-06 Thread Patrick Delaunay
Add "flags" in lmp_property to save the "no-map" property of reserved region and a new function lmb_reserve_flags() to check this flag. The default allocation use flags = LMB_NONE. The adjacent reserved memory region are merged only when they have the same flags value. This patch is partially

[PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-06 Thread Patrick Delaunay
Hi, On STM32MP15x platform we can use OP-TEE, loaded in DDR in a region protected by a firewall. This region is reserved in device with "no-map" property. But sometime the platform boot failed in U-boot on a Cortex A7 access to this region (depending of the binary and the issue can change with

[PATCH 4/7] lmb: add lmb_dump_region() function

2020-10-06 Thread Patrick Delaunay
Add lmb_dump_region() function, to simplify lmb_dump_all_force(). This patch is based on Linux memblock dump function. A example of bdinfo output is: . fdt_size= 0x000146a0 FB base = 0xfdd0 lmb_dump_all: memory.cnt = 0x1 memory[0] [0xc000-0x], 0x4000 bytes

[PATCH 2/7] lmb: add lmb_is_reserved_flags

2020-10-06 Thread Patrick Delaunay
Add a new function lmb_is_reserved_flags to check is a address is reserved with a specific flags. This function can be used to check if an address had be reserved with no-map flags with: lmb_is_reserved_flags(lmb, addr, LMB_NOMAP); Signed-off-by: Patrick Delaunay --- include/lmb.h | 1 +

[PATCH 5/7] test: lmb: add test for lmb_reserve_flags

2020-10-06 Thread Patrick Delaunay
Add a test to check the management of reserved region with flags. Signed-off-by: Patrick Delaunay --- test/lib/lmb.c | 89 ++ 1 file changed, 89 insertions(+) diff --git a/test/lib/lmb.c b/test/lib/lmb.c index 644ee78758..d7bd826190 100644 ---

Re: efi_loader: fix free() before use in RX path

2020-10-06 Thread Patrick Wildt
On Tue, Oct 06, 2020 at 04:56:31PM +0200, Patrick Wildt wrote: > Hi, > > I have an EFI application doing TFTP on an i.MX8MM board. The EFI > application uses the Simple Network Protocol and does ARP itself. > ARP didn't work, and I saw that the replies that were received on > the board were

[PATCH v2] doc: Sphinx.override_domain() deprecated

2020-10-06 Thread Heinrich Schuchardt
Sphinx.override_domain() is deprecated since Sphinx 1.8 and removed in Sphinx 3. Use Sphinx.add_domain(, override=True) instead. Signed-off-by: Heinrich Schuchardt --- v2: Ubuntu 18.04 still uses Sphinx 1.6.7 So use the same version check as Linux. --- doc/sphinx/cdomain.py | 2

[PATCH] doc: Sphinx.override_domain() deprecated

2020-10-06 Thread Heinrich Schuchardt
Sphinx.override_domain() is deprecated since Sphinx 1.8 and removed in Sphinx 3. Use Sphinx.add_domain(, override=True) instead. Signed-off-by: Heinrich Schuchardt --- doc/sphinx/cdomain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/sphinx/cdomain.py

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread François Ozog
On Tue, 6 Oct 2020 at 17:08, François Ozog wrote: > > > On Tue, 6 Oct 2020 at 16:46, Ard Biesheuvel wrote: > >> >> >> On Tue, 6 Oct 2020 at 16:22, François Ozog >> wrote: >> >>> Ard, there is a question for you in the below thread ;-) >>> >>> On Tue, 6 Oct 2020 at 15:02, Grant Likely wrote:

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread François Ozog
On Tue, 6 Oct 2020 at 16:46, Ard Biesheuvel wrote: > > > On Tue, 6 Oct 2020 at 16:22, François Ozog > wrote: > >> Ard, there is a question for you in the below thread ;-) >> >> On Tue, 6 Oct 2020 at 15:02, Grant Likely wrote: >> >>> >>> >>> On 06/10/2020 13:52, Heinrich Schuchardt wrote: >>> >

efi_loader: fix free() before use in RX path

2020-10-06 Thread Patrick Wildt
Hi, I have an EFI application doing TFTP on an i.MX8MM board. The EFI application uses the Simple Network Protocol and does ARP itself. ARP didn't work, and I saw that the replies that were received on the board were broken. Good, as seen from the sending host:

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread Ard Biesheuvel
On Tue, 6 Oct 2020 at 16:22, François Ozog wrote: > Ard, there is a question for you in the below thread ;-) > > On Tue, 6 Oct 2020 at 15:02, Grant Likely wrote: > >> >> >> On 06/10/2020 13:52, Heinrich Schuchardt wrote: >> > On 06.10.20 14:43, Grant Likely wrote: >> > >> >> >> >> Current

Re: [PATCH 1/1] Create codeql-analysis.yml

2020-10-06 Thread Tom Rini
On Tue, Oct 06, 2020 at 08:39:16AM +0200, Heinrich Schuchardt wrote: > Enable CodeQL Analysis on Github. > CodeQL produces a static code analysis. > > Signed-off-by: Heinrich Schuchardt > --- > I am not sure that everybody wants this enabled on his Github repository. > But we should look into

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread François Ozog
Ard, there is a question for you in the below thread ;-) On Tue, 6 Oct 2020 at 15:02, Grant Likely wrote: > > > On 06/10/2020 13:52, Heinrich Schuchardt wrote: > > On 06.10.20 14:43, Grant Likely wrote: > > > >> > >> Current U-Boot by default uses the same DT image for both U-Boot > >> internal

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread François Ozog
On Tue, 6 Oct 2020 at 15:12, Heinrich Schuchardt wrote: > On 06.10.20 14:46, Grant Likely wrote: > > > > > > On 06/10/2020 13:41, Ilias Apalodimas wrote: > >> Hi Grant, > >> > >> [...] > > > > Hi Heinrich, > > > > I've got concerns about this approach. Even though it uses the

Re: [PATCH] net: e1000: add defaults for i210 TX/RX PBSIZE

2020-10-06 Thread Christian Gmeiner
Hi Tom Am Mi., 30. Sept. 2020 um 22:54 Uhr schrieb Tom Rini : > > On Wed, Sep 23, 2020 at 05:05:44PM +0200, Christian Gmeiner wrote: > > > Set the defaults on probe for the packet buffer size registers > > for the i210. > > > > The TXPBSIZE register of the i210 resets to its default value only

[PATCH v2] net: e1000: add defaults for i210 TX/RX PBSIZE

2020-10-06 Thread Christian Gmeiner
Set the defaults on probe for the packet buffer size registers for the i210. The TX/RX PBSIZE register of the i210 resets to its default value only at power-on - see Intel Ethernet Controller I210 Datasheet rev 3.5 chapter 8.3 'Internal Packet Buffer Size Registers'. If something (another

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread Heinrich Schuchardt
On 06.10.20 14:46, Grant Likely wrote: > > > On 06/10/2020 13:41, Ilias Apalodimas wrote: >> Hi Grant, >> >> [...] > > Hi Heinrich, > > I've got concerns about this approach. Even though it uses the UEFI > infrastructure, images deployed in this way are U-Boot specific and

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread Grant Likely
On 06/10/2020 13:52, Heinrich Schuchardt wrote: On 06.10.20 14:43, Grant Likely wrote: Current U-Boot by default uses the same DT image for both U-Boot internal setup and to provide to the OS. This should be split so that the U-Boot internal version has what U-Boot needs without needs to

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread François Ozog
On Tue, 6 Oct 2020 at 14:36, Heinrich Schuchardt wrote: > On 06.10.20 14:04, François Ozog wrote: > > As always, Ard made a good point, and I feel compelled to top post and > > restate stuff. > > > > Here is the supporting deck: > > >

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread Heinrich Schuchardt
On 06.10.20 14:43, Grant Likely wrote: > > Current U-Boot by default uses the same DT image for both U-Boot > internal setup and to provide to the OS. This should be split so that > the U-Boot internal version has what U-Boot needs without needs to track > mainline Linux DTB schema. > > I've been

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread Grant Likely
On 06/10/2020 13:41, Ilias Apalodimas wrote: Hi Grant, [...] Hi Heinrich, I've got concerns about this approach. Even though it uses the UEFI infrastructure, images deployed in this way are U-Boot specific and won't ever be applicable on EDK2 or other UEFI implementations. However there

RE: [PATCH 1/3] arm: renesas: Add config option for R8A774B1 SoC

2020-10-06 Thread Biju Das
Hi Marek, I found that this patch doesn't apply cleanly on u-boot-sh/next. I will rebase and post V2 . Sorry for the inconvenience. Thanks and regards, Biju > -Original Message- > From: Biju Das > Sent: 25 September 2020 17:41 > To: Nobuhiro Iwamatsu ; Marek Vasut > > Cc: Biju Das

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread Grant Likely
On 06/10/2020 13:36, Heinrich Schuchardt wrote: On 06.10.20 14:04, François Ozog wrote: As always, Ard made a good point, and I feel compelled to top post and restate stuff. Here is the supporting deck:

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread Ilias Apalodimas
Hi Grant, [...] > > > > > > Hi Heinrich, > > > > > > I've got concerns about this approach. Even though it uses the UEFI > > > infrastructure, images deployed in this way are U-Boot specific and > > > won't ever be applicable on EDK2 or other UEFI implementations. > > > > > > However there is

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread Grant Likely
On 06/10/2020 13:04, François Ozog wrote: As always, Ard made a good point, and I feel compelled to top post and restate stuff. Here is the supporting deck: https://docs.google.com/presentation/d/1JK00su6e7vt8lRfwSt2C9EuuzwcBHLyoLRRrdcYfVWY/edit?usp=sharing We have two boot flows under

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread Heinrich Schuchardt
On 06.10.20 14:04, François Ozog wrote: > As always, Ard made a good point, and I feel compelled to top post and > restate stuff. > > Here is the supporting deck: > https://docs.google.com/presentation/d/1JK00su6e7vt8lRfwSt2C9EuuzwcBHLyoLRRrdcYfVWY/edit?usp=sharing >   > We have two boot flows

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread François Ozog
On Tue, 6 Oct 2020 at 14:05, Heinrich Schuchardt wrote: > On 06.10.20 12:38, Grant Likely wrote: > > > > > > On 06/10/2020 05:35, Heinrich Schuchardt wrote: > >> Am 6. Oktober 2020 00:37:58 MESZ schrieb Grant Likely > >> : > >>> > >>> > >>> On 03/10/2020 09:51, Heinrich Schuchardt wrote: >

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread Heinrich Schuchardt
On 06.10.20 12:38, Grant Likely wrote: > > > On 06/10/2020 05:35, Heinrich Schuchardt wrote: >> Am 6. Oktober 2020 00:37:58 MESZ schrieb Grant Likely >> : >>> >>> >>> On 03/10/2020 09:51, Heinrich Schuchardt wrote: Hello Ilias, hello Christian, with commit ec80b4735a59 ("efi_loader:

Re: Fit images and EFI_LOAD_FILE2_PROTOCOL

2020-10-06 Thread François Ozog
As always, Ard made a good point, and I feel compelled to top post and restate stuff. Here is the supporting deck: https://docs.google.com/presentation/d/1JK00su6e7vt8lRfwSt2C9EuuzwcBHLyoLRRrdcYfVWY/edit?usp=sharing We have two boot flows under consideration (not saying others are bad, just to

[PATCH] MAINTAINERS: Add stm32 and stm regexp for ARM STM STM32MP platform

2020-10-06 Thread Patrick Delaunay
Add files and directories regex "stm32" and "stm" in "ARM STM STM32MP" platform to avoid missing files or drivers supported by the STMicroelectronics series STM32MP15x. This patch adds the rules already used in Linux kernel for ARM/STM32 ARCHITECTURE. Signed-off-by: Patrick Delaunay ---

[PATCH] MAINTAINERS: Add STM32MP1 RNG driver in stm32mp platform

2020-10-06 Thread Patrick Delaunay
Add the STM32MP1 RNG driver in the list of drivers supported by the STMicroelectronics STM32MP15x series. Signed-off-by: Patrick Delaunay --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 85babd1908..8628ffd2a3 100644 --- a/MAINTAINERS +++

Re: [PATCH 2/7] clk: at91: sam9x60: add support compatible with CCF

2020-10-06 Thread Eugen.Hristev
On 06.10.2020 09:59, Claudiu Beznea - M18063 wrote: > Hi Eugen, > > > On 06.10.2020 09:32, Eugen Hristev - M18282 wrote: >> On 05.10.2020 17:58, Claudiu Beznea wrote: >>> Add SAM9X60 clock support compatible with CCF. >>> >>> Signed-off-by: Claudiu Beznea >>> --- >> >> Hi Claudiu, >> >>>

  1   2   >