Re: [PATCH v2 3/3] PowerPC: keymile: Add support for kmcent2 board

2021-01-24 Thread Stefan Roese
On 21.01.21 13:19, Niel Fourie wrote: Add basic support for the Hitachi Power Grids kmcent2 board, based on the NXP QorIQ T1040 SoC. Signed-off-by: Valentin Longchamp Signed-off-by: Rainer Boschung Signed-off-by: Niel Fourie Cc: Holger Brunck Cc: Heiko Schocher Cc: Priyanka Jain Cc:

Re: [PATCH v2 2/3] keymile: common: update to set_env_hex(), fix "pram" radix

2021-01-24 Thread Stefan Roese
On 21.01.21 13:19, Niel Fourie wrote: Replace instances of sprintf()/set_env() for setting hexadecimal values with set_env_hex(). In set_km_env() the "pram" variable was set to an hexadecimal value, while initr_mem() expects an unsigned decimal, so use set_env_ulong() instead. Signed-off-by:

[PATCH] MAINTAINERS: Add a co-maintainer for RISC-V

2021-01-24 Thread Andes
From: Rick Chen Add Leo as co-maintainer for RISC-V. Signed-off-by: Rick Chen --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a7a62df..ee89d50 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -947,6 +947,7 @@ F: arch/powerpc/cpu/mpc86xx/

Re: [PATCH 1/3] mem: spi-mem: define spi_mem_default_supports_op

2021-01-24 Thread Mathew McBride
Hello Pratyush, On Tue, Jan 19, 2021, at 11:06 PM, Pratyush Yadav wrote: > Hi Matthew, > > > Subject: [PATCH 1/3] mem: spi-mem: define spi_mem_default_supports_op > > Nitpick: You are declaring spi_mem_default_supports_op() here. It is > already defined. > [snip] > > This block of code was

[PATCH v2 3/3] spi: fsl_qspi: apply the same settings for LS1088 as LS208x

2021-01-24 Thread Mathew McBride
The LS1088 requires the same QUADSPI_QURIK_BASE_INTERNAL workaround as the LS208x and also has a 64 byte TX buffer. With the previous settings SPI-NAND reads over AHB were corrupted. Fixes: 91afd36f3802 ("spi: Transform the FSL QuadSPI driver to use the SPI MEM API") Signed-off-by: Mathew

[PATCH v2 2/3] spi: fsl_qspi: Ensure width is respected in spi-mem operations

2021-01-24 Thread Mathew McBride
Adapted from kernel commit b0177aca7aea From: Michael Walle Make use of a core helper to ensure the desired width is respected when calling spi-mem operators. Otherwise only the SPI controller will be matched with the flash chip, which might lead to wrong widths. Also consider the width

[PATCH v2 1/3] mem: spi-mem: add declaration for spi_mem_default_supports_op

2021-01-24 Thread Mathew McBride
spi_mem_default_supports_op is used internally by controller drivers to verify operation semantics are correct. It is used internally inside spi-mem but has not (in U-Boot) been declared in spi-mem.h for external use. Signed-off-by: Mathew McBride --- include/spi-mem.h | 3 +++ 1 file changed,

[PATCH v2 0/3] Fixes for SPI-NAND issues on LS1088A

2021-01-24 Thread Mathew McBride
This patchset resolves issues seen when using SPI-NAND with the LS1088A's qspi controller. The main issue seen is data corruption when reading SPI-NAND, due to a controller quirk not being applied. Using the same settings as the LS2088A (the bigger brother of LS1088A) solves this issue. In the

Re: [PATCH 1/1] doc: update Kernel documentation build system

2021-01-24 Thread Simon Glass
Hi, On Sun, 24 Jan 2021 at 18:37, Tom Rini wrote: > > On Mon, Jan 25, 2021 at 01:41:18AM +0100, Heinrich Schuchardt wrote: > > On 1/25/21 12:59 AM, Tom Rini wrote: > > > On Sun, Jan 24, 2021 at 10:05:27PM +0100, Heinrich Schuchardt wrote: > > > > On 1/23/21 6:53 PM, Tom Rini wrote: > > > > > On

Re: [PATCH 1/1] doc: update Kernel documentation build system

2021-01-24 Thread Tom Rini
On Mon, Jan 25, 2021 at 01:41:18AM +0100, Heinrich Schuchardt wrote: > On 1/25/21 12:59 AM, Tom Rini wrote: > > On Sun, Jan 24, 2021 at 10:05:27PM +0100, Heinrich Schuchardt wrote: > > > On 1/23/21 6:53 PM, Tom Rini wrote: > > > > On Sat, Jan 23, 2021 at 12:46:23PM -0500, Tom Rini wrote: > > > > >

Re: [PATCH 1/1] doc: update Kernel documentation build system

2021-01-24 Thread Sean Anderson
On 1/24/21 7:41 PM, Heinrich Schuchardt wrote: On 1/25/21 12:59 AM, Tom Rini wrote: On Sun, Jan 24, 2021 at 10:05:27PM +0100, Heinrich Schuchardt wrote: On 1/23/21 6:53 PM, Tom Rini wrote: On Sat, Jan 23, 2021 at 12:46:23PM -0500, Tom Rini wrote: On Fri, Jan 01, 2021 at 01:21:11AM +0100,

Re: [PATCH 1/1] doc: update Kernel documentation build system

2021-01-24 Thread Heinrich Schuchardt
On 1/25/21 12:59 AM, Tom Rini wrote: On Sun, Jan 24, 2021 at 10:05:27PM +0100, Heinrich Schuchardt wrote: On 1/23/21 6:53 PM, Tom Rini wrote: On Sat, Jan 23, 2021 at 12:46:23PM -0500, Tom Rini wrote: On Fri, Jan 01, 2021 at 01:21:11AM +0100, Heinrich Schuchardt wrote: Update the

[PATCH 1/1] doc: describe command conitrace

2021-01-24 Thread Heinrich Schuchardt
Provide a man-page for the conitrace command. Signed-off-by: Heinrich Schuchardt --- doc/usage/conitrace.rst | 54 + doc/usage/index.rst | 1 + 2 files changed, 55 insertions(+) create mode 100644 doc/usage/conitrace.rst diff --git

Re: [PATCH 1/1] doc: update Kernel documentation build system

2021-01-24 Thread Tom Rini
On Sun, Jan 24, 2021 at 10:05:27PM +0100, Heinrich Schuchardt wrote: > On 1/23/21 6:53 PM, Tom Rini wrote: > > On Sat, Jan 23, 2021 at 12:46:23PM -0500, Tom Rini wrote: > > > On Fri, Jan 01, 2021 at 01:21:11AM +0100, Heinrich Schuchardt wrote: > > > > > > > Update the docomentation build system

Re: [linux-sunxi] Re: [RFC PATCH] arm: EFI: Disallow EFI bootmgr when providing PSCI

2021-01-24 Thread Andre Przywara
On Sun, 24 Jan 2021 15:45:23 +0100 Heinrich Schuchardt wrote: > On 1/24/21 2:07 PM, Andre Przywara wrote: > > On Sun, 24 Jan 2021 11:44:35 +0100 > > Heinrich Schuchardt wrote: > > > > Hi Heinrich, > > > > many thanks for digging into this! > > > >> On 1/24/21 9:47 AM, Jernej Škrabec wrote:

Re: [PATCH 1/5] arm: dts: r8a774a1: Import DTS queued for Linux 5.12-rc1

2021-01-24 Thread Adam Ford
On Sun, Jan 24, 2021 at 11:10 AM Marek Vasut wrote: > > On 1/13/21 12:52 AM, Adam Ford wrote: > > Update the RZ/G2M dtsi and r8a774a1-beacon-rzg2m-kit kit > > from Renesas repo destined to become 5.12-rc1. > > I picked a DT sync for Linux 5.10 from Biju (on CC), does your board > need something

Re: [PATCH v2 3/8] doc: Add a note about how to produce 'md' output using hexdump

2021-01-24 Thread Heinrich Schuchardt
On 1/23/21 6:36 PM, Simon Glass wrote: Comparing a hex dump on the U-Boot command line with the contents of a file on the host system is fairly easy and convenient to do manually if it is small. But the format used hexdump by default differs from that shown by U-Boot. Add a note about how to

Re: [PATCH v2 5/8] sandbox: Add os_realloc()

2021-01-24 Thread Heinrich Schuchardt
On 1/23/21 6:36 PM, Simon Glass wrote: We provide os_malloc() and os_free() but not os_realloc(). Add this, following the usual semantics. Also update os_malloc() to behave correctly when passed a zero size. Signed-off-by: Simon Glass In the code I am missing a comment why we are not simply

[PATCH v5 9/9] dm: core: Add documentation about device removal

2021-01-24 Thread Simon Glass
Make mention of this feature in the core documentation so people can discover it without looking at a header file. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Revised and updated based on discussion doc/driver-model/design.rst | 20 1 file

[PATCH v5 8/9] arm: Remove vital devices last

2021-01-24 Thread Simon Glass
Update announce_and_cleanup() to remove all devices, with the vital ones being removed last. This is an extra patch on top of the recent RFC: http://patchwork.ozlabs.org/project/uboot/list/?series=223280 Signed-off-by: Simon Glass --- Changes in v5: - Add patch to remove vital devices last

[PATCH v5 7/9] dm: core: Add late driver remove option

2021-01-24 Thread Simon Glass
From: Marek Vasut Add another flag to the DM core which could be assigned to drivers and which makes those drivers call their remove callbacks last, just before booting OS and after all the other drivers finished with their remove callbacks. This is necessary for things like clock drivers, where

[PATCH v5 6/9] dm: core: Avoid partially removing devices

2021-01-24 Thread Simon Glass
At present if device_remove() decides that the device should not actually be removed, it still calls the uclass pre_remove() method and powers the device down. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/device-remove.c | 59

[PATCH v5 5/9] dm: core: Remove children before advising uclass

2021-01-24 Thread Simon Glass
At present the uclass pre-remove method is called before the children are removed. But the children may refused to be removed, in whch case the uclass is in a tricky situation. At present we handle this by calling the uclass' post_probe() method. But it seems better to avoid doing anything with

[PATCH v5 4/9] dm: pci: Correct use of wrong flag name

2021-01-24 Thread Simon Glass
Update a driver that uses the incorrect flag. Add a comment to hopefully prevent furture mistakes. Signed-off-by: Simon Glass --- (no changes since v1) drivers/pci/pcie_iproc.c | 2 +- include/dm/device.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v5 3/9] dm: Rename DM_FLAG_REMOVE_WITH_PD_ON

2021-01-24 Thread Simon Glass
This flag has the word 'REMOVE' in it which means it conflicts with the DM_REMOVE flags. Rename it to DM_FLAG_LEAVE_PD_ON which seems to indicate its purpose well enough. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/device-remove.c| 2 +-

[PATCH v5 2/9] nand: brcmnand: Don't use -EPROBE_DEFER

2021-01-24 Thread Simon Glass
This has no useful meaning in U-Boot and will never be returned. We want to reserve this flag for internal driver model use. Drop the code. Signed-off-by: Simon Glass --- (no changes since v1) drivers/mtd/nand/raw/brcmnand/brcmnand.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)

[PATCH v5 1/9] smem: Don't use -EPROBE_DEFER

2021-01-24 Thread Simon Glass
This has no useful meaning in U-Boot. Use -ENOMEM since that appears to be what has gone wrong in this case. We want to reserve this flag for internal driver model use. Signed-off-by: Simon Glass --- (no changes since v1) drivers/smem/msm_smem.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v5 0/9] dm: core: Add support for vital devices

2021-01-24 Thread Simon Glass
This is an attempt to come up with a 'late removal' feature, as implemented by Marek, but using different terminology and trying to fit in with the existing removal flags. I have taken the opportunity to clean up a few related things. The series is available at u-boot-dm/late-working The

[PATCH 1/1] doc: describe the false command

2021-01-24 Thread Heinrich Schuchardt
Provide a man-page for the false command. Signed-off-by: Heinrich Schuchardt --- doc/usage/false.rst | 28 doc/usage/index.rst | 1 + 2 files changed, 29 insertions(+) create mode 100644 doc/usage/false.rst diff --git a/doc/usage/false.rst b/doc/usage/false.rst

[PATCH v3 15/16] gpio: Define the log category in the uclass

2021-01-24 Thread Simon Glass
This uses log_debug(), etc. but does not define the category. Fix this. Signed-off-by: Simon Glass --- Changes in v3: - Split out the log-category change to a separate patch drivers/gpio/gpio-uclass.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpio-uclass.c

[PATCH v3 16/16] gpio: Add a way to read 3-way strapping pins

2021-01-24 Thread Simon Glass
Using the internal vs. external pull resistors it is possible to get 27 different combinations from 3 strapping pins. Add an implementation of this. This involves updating the sandbox GPIO driver to model external and (weaker) internal pull resistors. The get_value() method now takes account of

[PATCH v3 14/16] gpio: sandbox: Track whether a GPIO is driven

2021-01-24 Thread Simon Glass
Add a new flag to keep track of whether sandbox is driving the pin, or whether it is expecting an input signal. If it is driving, then the value of the pin is the value being driven (0 or 1). If not driving, then we consider the value 0, since we don't currently handle things like pull-ups yet.

[PATCH v3 13/16] gpio: x86: Drop the deprecated methods in intel_gpio

2021-01-24 Thread Simon Glass
We don't need to implement direction_input() and direction_output() anymore. Drop them and use update_flags() instead. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/include/asm/intel_pinctrl_defs.h | 5 ++ drivers/gpio/intel_gpio.c | 72 ---

[PATCH v3 12/16] gpio: Use an 'ops' variable everywhere

2021-01-24 Thread Simon Glass
Update this driver to use the common method of putting the driver operations in an 'ops' variable install of calling gpio_get_ops() repeatedly. Make it const since operations do not change. Signed-off-by: Simon Glass Reviewed-by: Patrick Delaunay --- (no changes since v1)

[PATCH v3 11/16] gpio: Replace direction_input() and direction_output()

2021-01-24 Thread Simon Glass
The new update_flags() method is more flexible since it allows the driver to see the full flags all at once. Use that in preference to these two functions. Add comments to that effect. Signed-off-by: Simon Glass Reviewed-by: Patrick Delaunay --- (no changes since v1)

[PATCH v3 10/16] dm: gpio: Add a way to update flags

2021-01-24 Thread Simon Glass
It is convenient to be able to adjust some of the flags for a GPIO while leaving others alone. Add a function for this. Update dm_gpio_set_dir_flags() to make use of this. Also update dm_gpio_set_value() to use this also, since this allows the open-drain / open-source features to be implemented

[PATCH v3 09/16] gpio: sandbox: Make sandbox_gpio_set_flags() set all flags

2021-01-24 Thread Simon Glass
Allow this function to see all flags, including the internal sandbox ones. This allows the tests to fully control the behaviour of the driver. To make this work, move the setting of GPIOD_EXT_HIGH -to where the flags are updated via driver model, rather than the sandbox 'back door'.

[PATCH v3 08/16] gpio: sandbox: Fully separate pin value from output value

2021-01-24 Thread Simon Glass
At present we have the concept of a pin's external value. This is what is used when getting the value of a pin. But we still set the GPIOD_IS_OUT_ACTIVE flag when changing the value. This is not actually correct, since if the pin changes from output to input, the external value need not change.

[PATCH v3 07/16] gpio: sandbox: Use a separate flag for the value

2021-01-24 Thread Simon Glass
At present with the sandbox GPIO driver it is not possible to change the value of GPIOD_IS_OUT_ACTIVE unless the GPIO is an output. This makes it hard to test changing the flags since we need to be aware of the internal workings of the driver. The feature is designed to aid testing. Split this

[PATCH v3 06/16] gpio: sandbox: Rename GPIO dir_flags to flags

2021-01-24 Thread Simon Glass
Adjust the terminology in this driver to reflect that fact that all flags are handled, not just direction flags. Create a new access function to get the full GPIO state, not just the direction flags. Drop the static invalid_dir_flags since we can rely on a segfault if something is wrong.

[PATCH v3 05/16] gpio: Drop dm_gpio_set_dir()

2021-01-24 Thread Simon Glass
This function is not used. Drop it. Signed-off-by: Simon Glass Reviewed-by: Patrick Delaunay --- (no changes since v1) drivers/gpio/gpio-uclass.c | 11 --- include/asm-generic/gpio.h | 11 --- 2 files changed, 22 deletions(-) diff --git a/drivers/gpio/gpio-uclass.c

[PATCH v3 04/16] gpio: Rename dm_gpio_get_dir_flags() to dm_gpio_get_flags()

2021-01-24 Thread Simon Glass
This function can be used to get any flags, not just direction flags. Rename it to avoid confusion. Signed-off-by: Simon Glass Reviewed-by: Patrick Delaunay Reviewed-by: Pratyush Yadav --- Changes in v3: - Drop the word 'direction' in comments also drivers/gpio/gpio-uclass.c | 2 +-

[PATCH v3 03/16] dm: gpio: Rename get_dir_flags() method to get_flags()

2021-01-24 Thread Simon Glass
It is more useful to be able to read all the flags, not just the direction ones. In fact this is what the STM32 driver does. Update the method name to reflect this. Tweak the docs a little and use 'flagsp' as the return argument, as is common in driver model, to indicate it returns a value.

[PATCH v3 02/16] dm: gpio: Rename set_dir_flags() method to update_flags()

2021-01-24 Thread Simon Glass
The current method is a misnomer since it is also used (e.g. by stm32) to update pull settings and open source/open drain. Rename it and expand the documentation to cover a few more details. Signed-off-by: Simon Glass Reviewed-by: Pratyush Yadav Reviewed-by: Patrick Delaunay --- (no changes

[PATCH v3 01/16] gpio: Disable functions not used with of-platdata

2021-01-24 Thread Simon Glass
These functions use devicetree and cannot work with of-platdata, which has no runtime devicetree. If they are used, the current linker error is confusing, since it talks about missing functions in the bowels of driver model. Avoid compiling these functions at all with of-platdata, so that a

[PATCH v3 00/16] gpio: Update and simplify the uclass API

2021-01-24 Thread Simon Glass
At present the GPIO uclass mirrors what was in U-Boot before driver model. It works well in most cases but is becoming cumbersome with things like pull-up/down and drive strength. In those cases it is easier for the driver to deal with all the flags at one, rather than piece by piece. In fact the

Re: [PATCH 1/1] doc: update Kernel documentation build system

2021-01-24 Thread Heinrich Schuchardt
On 1/23/21 6:53 PM, Tom Rini wrote: On Sat, Jan 23, 2021 at 12:46:23PM -0500, Tom Rini wrote: On Fri, Jan 01, 2021 at 01:21:11AM +0100, Heinrich Schuchardt wrote: Update the docomentation build system according to Linux v5.11-rc1. With this patch we can build the HTML documentation using

[PATCH v2 1/1] dm: core: describe uclass_root_s

2021-01-24 Thread Heinrich Schuchardt
make htmldocs creates a warning: ./include/asm-generic/global_data.h:443: warning: Function parameter or member 'uclass_root_s' not described in 'global_data' Correct the member descriptions. Cc: Simon Glass Signed-off-by: Heinrich Schuchardt --- v2: include information provided by

Re: [PATCH] gpio-uclass: fix gpio flags save condition

2021-01-24 Thread Simon Glass
Hi Kory, On Fri, 22 Jan 2021 at 08:23, Kory Maincent wrote: > > The commit cd2faeba1a moves the location where we save the flags to the gpio > descriptor but it adds a "!" character. > This breaks the condition we expect to save the flags. > > Signed-off-by: Kory Maincent > --- >

Re: [PATCH 01/10] cros_ec: Add a function for the hello message

2021-01-24 Thread Simon Glass
This is used several times in this file. Put it in a function to avoid code duplication. Also add a test for this function. There are no cros_ec tests at present, so it is time to update the code. Signed-off-by: Simon Glass --- arch/sandbox/include/asm/test.h | 14 ++

Re: [PATCH 02/10] cros_ec: Tidy up a few delays

2021-01-24 Thread Simon Glass
Allow a longer time for the EC to reboot. Also use a constant for the hash delay time, so it is clear what it is for. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 04/10] cros_ec: Add support for reading the SKU ID

2021-01-24 Thread Simon Glass
This allows reading strapping pins attached to the EC. Add an implementation for this. Signed-off-by: Simon Glass --- cmd/cros_ec.c | 10 ++ drivers/misc/cros_ec.c | 13 + drivers/misc/cros_ec_sandbox.c | 7 +++ include/cros_ec.h |

Re: [PATCH 03/10] cros_ec: Add run-time check for input buffer overflow

2021-01-24 Thread Simon Glass
This should not happen in normal operation, but the EC might have a bug, so add a run-time check just in case. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 2 ++ 1 file changed, 2 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 05/10] cros_ec: Support reading EC features

2021-01-24 Thread Simon Glass
The EC can support a variety of features and provides a way to find out what is available. Add support for this. Also update the feature list to the lastest available while we are here. This is at:

Re: [PATCH 06/10] cros_ec: Add documentation for cros_ec driver operations

2021-01-24 Thread Simon Glass
Add comments to these methods so it is documented in this central place, not just in each driver. Signed-off-by: Simon Glass --- include/cros_ec.h | 40 1 file changed, 40 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 07/10] cros_ec: Add support for switches

2021-01-24 Thread Simon Glass
On x86 platforms the EC provides a way to read 'switches', which are on/off values determined by the EC. Add a new driver method for this and implement it for LPC. Signed-off-by: Simon Glass --- arch/sandbox/include/asm/test.h | 1 + cmd/cros_ec.c | 41

Re: [PATCH 08/10] cros_ec: Show events in human-readable form

2021-01-24 Thread Simon Glass
Add a command to show the current events as a list of names. This is easier to decipher than a bit mask. Signed-off-by: Simon Glass --- cmd/cros_ec.c | 70 +++--- drivers/misc/cros_ec_sandbox.c | 12 +- test/dm/cros_ec.c | 37

Re: [PATCH 09/10] cros_ec: Allow use with of-platdata

2021-01-24 Thread Simon Glass
Avoid reading the device tree when of-platdata is in use. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 2 ++ 1 file changed, 2 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 10/10] cros_ec: Add vstore support

2021-01-24 Thread Simon Glass
The EC can store small amounts of data for the benefit of the verified boot process. Since the EC is seldom reset, this can allow the AP to store data that survives a reboot or a suspend/resume cycle. Add support for this. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 71

[PATCH] sunxi: board: Splitting CHIP defconfig for nand.

2021-01-24 Thread Alexandre GRIVEAUX
This patch split CHIP defconfig to add nand 4G and 8G support. Some CONFIG was put at the end of defconfig to ease comparison between: - CHIP Pro - CHIP with Toshiba 4G - CHIP with Hynix 8G Witch are essentialy the same board with differents nand and memory. Values was taken from now defunct

[PATCH] ata: sunxi: fix debug messages

2021-01-24 Thread Dario Binacchi
It is useless and misleading to print the ret variable that is not set by the dev_read_addr routine. Also, move the '\n' character after the round bracket that contains the error code. Signed-off-by: Dario Binacchi --- drivers/ata/ahci_sunxi.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH 07/11] pinctrl: single: use function pointer for register access

2021-01-24 Thread Simon Glass
Hi Dario, On Sun, 24 Jan 2021 at 09:50, Dario Binacchi wrote: > > > Hi Simon, > > > Il 24/01/2021 03:03 Simon Glass ha scritto: > > > > > > Hi Dario, > > > > On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > > > > > The patch allows you to call the read/write functions set during probing

[PATCH v3 12/12] smbios: Allow a few values to come from sysinfo

2021-01-24 Thread Simon Glass
While static configuration is useful it cannot cover every case. Sometimes board revisions are encoded in resistor straps and must be read at runtime. The easiest way to provide this information is via sysinfo, since the board can then provide a driver to read whatever is needed. Add some

[PATCH v3 11/12] x86: coral: Add sysinfo ops

2021-01-24 Thread Simon Glass
These ops are missing at present which is not permitted. Add an empty operation struct. Note: If the uclass requires operations then the drivers should provide them. Otherwise, checking for missing operations must be done in every uclass operation, so it adds to code size. Signed-off-by: Simon

[PATCH v3 10/12] sysinfo: Move #ifdef so that operations are always defined

2021-01-24 Thread Simon Glass
At present the struct is not available unless SYSINFO is enabled. This is annoying since code it is not possible to use compile-time checks like CONFIG_IS_ENABLED(SYSINFO) with this header. Fix it by moving the #ifdef. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since

[PATCH v3 09/12] smbios: Add more options for the BIOS version string

2021-01-24 Thread Simon Glass
At present the version string is obtained from PLAIN_VERSION. Some boards may want to configure this using the device tree, since the build system can more easily insert things there after U-Boot itself is built. Add this option to the code. Also in some cases the version needs to be generated

[PATCH v3 08/12] smbios: Track the end of the string table

2021-01-24 Thread Simon Glass
Add a new member to the context struct which tracks the end of the string table. This allows us to avoid recalculating this at the end. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) lib/smbios.c | 32 +++- 1 file changed, 15

[PATCH v3 06/12] smbios: Use a struct to keep track of context

2021-01-24 Thread Simon Glass
At present we pass the ofnode to each function. We also pass the 'eos' pointer for adding new strings. We don't track the current end of the string table, so have smbios_string_table_len() to find that. The code can be made more efficient if it keeps information in a context struct. This also

[PATCH v3 07/12] smbios: Drop the eos parameter

2021-01-24 Thread Simon Glass
We can store this in the context and avoid passing it to each function. This makes it easier to follow and will also allow keeping track of the end of the string table (in future patches). Add an 'eos' field to the context and create a function to set it up. Signed-off-by: Simon Glass ---

[PATCH v3 05/12] smbios: Set BIOS release version

2021-01-24 Thread Simon Glass
We may as well include the U-Boot release information in the type-0 table since it is designed for that purpose. U-Boot uses release versions based on the year and month. The year cannot fit in a byte, so drop the century. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since

[PATCH v3 04/12] smbios: Use char consistently for the eos member

2021-01-24 Thread Simon Glass
At present a few of the structs use u8 instead of char. This is a string, so char is better. Update them. Signed-off-by: Simon Glass Reviewed-by: Christian Gmeiner Reviewed-by: Bin Meng --- (no changes since v1) include/smbios.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v3 03/12] smbios: Move smbios_write_type to the C file

2021-01-24 Thread Simon Glass
This type is not used outside the smbios.c file so there is no need for it to be in the header file. Move it. Signed-off-by: Simon Glass Reviewed-by: Christian Gmeiner Reviewed-by: Bin Meng --- (no changes since v1) include/smbios.h | 10 -- lib/smbios.c | 10 ++ 2 files

[PATCH v3 02/12] Makefile: Provide numeric versions

2021-01-24 Thread Simon Glass
For SMBIOS we want to store the numeric version numbers in the tables. It does not make sense to parse the strings. Instead, add new #defines with the version and patchlevel. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: - Use .rst file instead of README Makefile

[PATCH v3 01/12] README: Add doumentation for version information

2021-01-24 Thread Simon Glass
There are quite a few available version options in U-Boot. Add a list of the available Makefile variables and #defines, along with examples. Signed-off-by: Simon Glass --- Changes in v3: - Move to doc/ and .rst format - Add examples for converting epoch values doc/Makefile| 1 -

[PATCH v3 00/12] smbios: Enhancements for more flexibility

2021-01-24 Thread Simon Glass
This series includes various patches to allow more flexibility as to where the data for SMBIOS tables comes from: - introduces some standard sysinfo options as a source, e.g. to read strapping pins to determine the board revision - allows the U-Boot version number to be included - allows the

Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-24 Thread Oleksandr Suvorov
Hi Marek, On Sun, Jan 24, 2021 at 4:52 PM Marek Vasut wrote: > > On 1/24/21 3:35 PM, Oleksandr Suvorov wrote: > > On Sun, Jan 24, 2021 at 12:04 AM Stefano Babic wrote: > >> > >> Hi Marek, > >> > >> On 23.01.21 20:57, Marek Vasut wrote: > >>> On 1/23/21 8:54 PM, sba...@denx.de wrote: > > The

Re: [PATCH 1/5] arm: dts: r8a774a1: Import DTS queued for Linux 5.12-rc1

2021-01-24 Thread Marek Vasut
On 1/13/21 12:52 AM, Adam Ford wrote: Update the RZ/G2M dtsi and r8a774a1-beacon-rzg2m-kit kit from Renesas repo destined to become 5.12-rc1. I picked a DT sync for Linux 5.10 from Biju (on CC), does your board need something from 5.12-rc1 or can it be based on 5.10 too ?

[PATCH v2 12/12] x86: coral: Show memory config and SKU ID on startup

2021-01-24 Thread Simon Glass
Provide the model information through sysinfo so that it shows up on boot. For memconfig 4 pins are provided, for 16 combinations. For SKU ID there are two options: - two pins provided in a ternary arrangement, for 9 combinations. - reading from the EC Add a binding doc and drop the unused

[PATCH v2 11/12] sysinfo: Allow showing model info from sysinfo

2021-01-24 Thread Simon Glass
Some boards may want to show the SKU ID or other information obtained at runtime. Allow this to come from sysinfo. The board can then provide a sysinfo driver to provide it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) common/board_info.c | 37

[PATCH v2 10/12] x86: tpl: Show next stage being booted

2021-01-24 Thread Simon Glass
Enhance the debugging to show the next stage being booted as well as a dump of the start of the image. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/tpl.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/x86/lib/tpl.c

[PATCH v2 09/12] x86: spl: Clear BSS unconditionally

2021-01-24 Thread Simon Glass
This should be done even if not using TPL, since BSS may be in use or boards that only use SPL. Fix it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/spl.c

[PATCH v2 08/12] x86: zimage: Improve command-line debug handling

2021-01-24 Thread Simon Glass
At present if the command line is very long it is truncated by the printf() statement, which works within a limited buffer. Use puts() instead. Also show better debugging with the command-line setup fails. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1)

[PATCH v2 07/12] x86: zimage: Allow dumping the image from outside the module

2021-01-24 Thread Simon Glass
At present it is possible to dump an image within the zimage command, but it is also useful to be able to dump it from elsewhere, for example in a loader that has special handling for the different zimage stages. Export this feature as a new function. Signed-off-by: Simon Glass Reviewed-by: Bin

[PATCH v2 06/12] x86: Update Chromium OS GNVS names

2021-01-24 Thread Simon Glass
The Global Non-Volatile Storage struct has some fields with particular meanings. Rename these to make things easier to follow. Also add a few more boot flags. GNVS should not be confused with GNVQ (Going Nowhere Very Quickly). Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes

[PATCH v2 05/12] x86: spl: Make moving BSS conditional

2021-01-24 Thread Simon Glass
At present BSS is always placed in SDRAM. If a separate BSS is not in use this means that BSS doesn't work as expected. Make the setting conditional on the SEPARATE_BSS option. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/cpu/u-boot-spl.lds | 2 ++ 1

[PATCH v2 04/12] x86: Make sure the SPL image ends on a suitable boundary

2021-01-24 Thread Simon Glass
The part of U-Boot that actually ends up in u-boot-nodtb.bin is not built with any particular alignment. It ends at the start of the BSS section. The BSS section selects its own alignment, which may larger. This means that there can be a gap of a few bytes between the image ending and BSS

[PATCH v2 03/12] x86: apl: Enhance debugging in the SPL loader

2021-01-24 Thread Simon Glass
Move to log_debug() and make use of the new SPL function to find the text base. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/cpu/apollolake/spl.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[PATCH v2 02/12] x86: spl: Add a function to find the text base

2021-01-24 Thread Simon Glass
It is useful to know the TEXT_BASE value for the image being loaded in TPL/SPL. Add a new spl_get_image_text_base() function to handle this. Make use of this in the x86 SPL handler, instead of having the logic there. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1)

[PATCH v2 01/12] x86: acpi_gpe: Update driver name to match devicetree

2021-01-24 Thread Simon Glass
Use a driver name in line with the compatible string so that of-platdata can use this driver. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/cpu/acpi_gpe.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/cpu/acpi_gpe.c

[PATCH v2 00/12] x86: Minor improvements mostly for image loading

2021-01-24 Thread Simon Glass
This series provides a few improvements for loading of images. It also provides a way to show more detailed model information as well as an of-platdata fix noticed recently. Changes in v2: - Add comment to .lds file - Add more notes to the commit - Fix two missing asterisks in comments Simon

Re: [PATCH 04/12] x86: Make sure the SPL image ends on a suitable boundary

2021-01-24 Thread Simon Glass
Hi Bin, On Wed, 20 Jan 2021 at 22:35, Bin Meng wrote: > > Hi Simon, > > On Sun, Jan 17, 2021 at 5:54 AM Simon Glass wrote: > > > > The part of U-Boot that actually ends up in u-boot-nodtb.bin is not built > > with any particular alignment. It ends at the start of the BSS section. > > The BSS

Re: [PATCH 07/11] pinctrl: single: use function pointer for register access

2021-01-24 Thread Dario Binacchi
Hi Simon, > Il 24/01/2021 03:03 Simon Glass ha scritto: > > > Hi Dario, > > On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > > > The patch allows you to call the read/write functions set during probing > > without having to check the type of access at runtime. It also adds > >

Re: [GIT] Pull request: u-boot-dfu (23.01.2021)

2021-01-24 Thread Marek Vasut
On 1/23/21 8:11 PM, Lukasz Majewski wrote: Dear Marek, Hi, Please find a set of DFU/Gadget related fixes and improvements. This is a first batch of them as I was not able to prepare the PR earlier (and yes I do apologize for the delay/lack of PRs sent earlier). More patches will be pulled in

Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-24 Thread Marek Vasut
On 1/24/21 3:35 PM, Oleksandr Suvorov wrote: On Sun, Jan 24, 2021 at 12:04 AM Stefano Babic wrote: Hi Marek, On 23.01.21 20:57, Marek Vasut wrote: On 1/23/21 8:54 PM, sba...@denx.de wrote: The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly

[PATCH V2] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-24 Thread Marek Vasut
The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC internal delay based on the PHY mode. Signed-off-by: Marek Vasut Cc: Oleksandr Suvorov Cc:

Re: [linux-sunxi] Re: [RFC PATCH] arm: EFI: Disallow EFI bootmgr when providing PSCI

2021-01-24 Thread Heinrich Schuchardt
On 1/24/21 2:07 PM, Andre Przywara wrote: On Sun, 24 Jan 2021 11:44:35 +0100 Heinrich Schuchardt wrote: Hi Heinrich, many thanks for digging into this! On 1/24/21 9:47 AM, Jernej Škrabec wrote: Dne nedelja, 24. januar 2021 ob 09:33:15 CET je Jernej Škrabec napisal(a): Hi! Dne nedelja,

[PATCH 1/1] efi_loader: switch to non-secure mode later

2021-01-24 Thread Heinrich Schuchardt
Some ARMv7 boards using PSCI require to be in secure-mode when booted via 'bootz' or 'bootm'. During distro-boot 'bootefi bootmgr' is called to check if booting via UEFI is possible. With the change we change the switch from secure mode to non-secure mode is moved from the UEFI subsystem setup to

Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-24 Thread Oleksandr Suvorov
On Sun, Jan 24, 2021 at 12:04 AM Stefano Babic wrote: > > Hi Marek, > > On 23.01.21 20:57, Marek Vasut wrote: > > On 1/23/21 8:54 PM, sba...@denx.de wrote: > >>> The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which > >>> supports OF control, correctly set the rgmii-id PHY mode

Re: Pull request for UEFI sub-system for efi-2021-04-rc1-3

2021-01-24 Thread Tom Rini
On Sat, Jan 23, 2021 at 03:39:26PM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > this pull request fixes a bunch of the recent Coverity CIDs. > > The following changes since commit 184aa6504143b452132e28cd3ebecc7b941cdfa1: > > Merge tag 'u-boot-rockchip-20210121' of >

RE: [PATCH] mmc: mmc_spi: Do not drop first RX byte after CMD TX

2021-01-24 Thread Meng, Bin
It looks somehow this email did not arrive the mailing list? As for the patch, U-Boot mms_spi driver does nothing wrong. The dropped byte is for Ncr as required by the spec. The issue you mentioned in QEMU is fixed by the following patch:

  1   2   >