Re: [RFC PATCH 01/23] sunxi: pinctrl: Create the driver skeleton

2021-10-21 Thread Samuel Holland
Hi, On 10/21/21 12:13 AM, Sean Anderson wrote: > > On 10/21/21 12:55 AM, Samuel Holland wrote: >> Create a do-nothing driver for each sunxi pin controller variant. >> >> Since only one driver can automatically bind to a DT node, since the >> GPIO driver already requires a manual binding process,

[PATCH v10 3/9] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Simon Glass
At present U-Boot environment variables, and thus scripts, are defined by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text to this file and dealing with quoting and newlines is harder than it should be. It would be better if we could just type the script into a text file and

[PATCH v10 5/9] doc: Mention CONFIG_DEFAULT_ENV_FILE

2021-10-21 Thread Simon Glass
Add mention of this option since it does a similar thing to the text environment. Signed-off-by: Simon Glass Suggested-by: Rasmus Villemoes Reviewed-by: Marek Behún --- (no changes since v9) Changes in v9: - Fix blank line between tags - Fix typo in commit message Changes in v8: - Fix

[PATCH v10 2/9] doc: Move environment documentation to rST

2021-10-21 Thread Simon Glass
Move this from the README to rST format. Drop i2cfast since it is obviously obsolete and breaks the formatting. Other changes and improvements are in a following patch. Signed-off-by: Simon Glass Acked-by: Marek Behún --- (no changes since v6) Changes in v6: - Move all updates to a separate

[PATCH v10 4/9] sandbox: Use a text-based environment

2021-10-21 Thread Simon Glass
Use a text file for the environment instead of the #define settings. Signed-off-by: Simon Glass Reviewed-by: Marek Behún --- (no changes since v3) Changes in v3: - Add new patch to use a text-based environment for sandbox board/sandbox/sandbox.env | 25 +

[PATCH v10 7/9] doc: Improve environment documentation further

2021-10-21 Thread Simon Glass
Make various other updates suggested during review of the rST conversion. Signed-off-by: Simon Glass Suggested-by: Heinrich Schuchardt --- Changes in v10: - Add updates as suggested by Heinrich doc/develop/environment.rst | 51 doc/develop/index.rst | 1 +

[PATCH v10 9/9] bootm: Tidy up use of autostart env var

2021-10-21 Thread Simon Glass
This has different semantics in different places. Go with the bootm method and put it in a common function so that the behaviour is consistent in U-Boot. Update the docs. To be clear, this changes the way that 'bootelf' and standalone boot work. Before, if autostart was set to "fred" or "YES",

[PATCH v10 8/9] sandbox: Update the test MAC/IP addresses

2021-10-21 Thread Simon Glass
These conflict with real-word addresses. Use locally administered MAC addresses and a suitable IPv4 address from 192.0.2.0/24 (TEST-NET-1). Signed-off-by: Simon Glass Suggested-by: Alexander Dahl --- Changes in v10: - Add new patch to update the test MAC/IP addresses

[PATCH v10 6/9] doc: Improve environment documentation

2021-10-21 Thread Simon Glass
Make various updates suggested during review of the rST conversion. Signed-off-by: Simon Glass Reviewed-by: Marek Behún Suggested-by: Wolfgang Denk --- (no changes since v7) Changes in v7: - A few more tweaks Changes in v6: - Move all updates to a separate patch - More updates and

[PATCH v10 1/9] sandbox: Drop distro_boot

2021-10-21 Thread Simon Glass
This is a complicated set of #defines and it is painful to convert to a text file. We can (once pending patches are applied) provide the same functionality with bootmethod. Drop this for sandbox to allow conversion to a text-file environment. Signed-off-by: Simon Glass Reviewed-by: Marek Behún

[PATCH v10 0/9] env: Allow environment in text files

2021-10-21 Thread Simon Glass
One barrier to completing the 7-year-long Kconfig migration is that the default environment is implemented using ad-hoc CONFIG options. At present U-Boot environment variables, and thus scripts, are defined by CONFIG_EXTRA_ENV_SETTINGS. It is not really feasible to move the environment to Kconfig

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Simon Glass
Hi Stefano, On Thu, 21 Oct 2021 at 10:35, Stefano Babic wrote: > > Hi Simon, > > On 21.10.21 18:15, Tom Rini wrote: > > On Thu, Oct 21, 2021 at 10:09:56AM -0600, Simon Glass wrote: > >> Hi Tom, > >> > >> On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: > >>> > >>> On Tue, Oct 19, 2021 at

Re: [PATCH v9 2/7] doc: Move environment documentation to rST

2021-10-21 Thread Simon Glass
Hi Heinrich, On Wed, 20 Oct 2021 at 00:38, Heinrich Schuchardt wrote: > > On 10/20/21 00:44, Simon Glass wrote: > > Move this from the README to rST format. > > > > Drop i2cfast since it is obviously obsolete and breaks the formatting. > > Other changes and improvements are in a following patch.

Re: [PATCH v2 3/3] RFC: doc: Add documentation about devicetree usage

2021-10-21 Thread Simon Glass
Hi Tom, On Fri, 10 Sept 2021 at 08:00, Tom Rini wrote: > > On Fri, Sep 03, 2021 at 02:53:46AM -0600, Simon Glass wrote: > > Hi, > > > > On Mon, 30 Aug 2021 at 08:48, Tom Rini wrote: > [snip] > > > We should, when applicable, submit our bindings upstream just like any > > > other project. We

[PATCH V3 4/5] imx: imx8mq use common imximage.cfg

2021-10-21 Thread Peng Fan (OSS)
From: Peng Fan After all these board switch to binman, we could use common imximage.cfg Signed-off-by: Peng Fan --- arch/arm/mach-imx/imx8m/imximage.cfg | 12 +++- board/freescale/imx8mq_evk/Kconfig| 2 +- board/freescale/imx8mq_evk/imximage.cfg | 11 ---

[PATCH V3 5/5] doc: imx8mq_evk: update doc after using binman

2021-10-21 Thread Peng Fan (OSS)
From: Peng Fan Update doc after using binman to pack images Signed-off-by: Peng Fan --- doc/board/nxp/imx8mq_evk.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/board/nxp/imx8mq_evk.rst b/doc/board/nxp/imx8mq_evk.rst index c269fdebe3..92eeda79aa 100644 ---

[PATCH V3 3/5] imx: pico-imx8mq: switch to use binman

2021-10-21 Thread Peng Fan (OSS)
From: Peng Fan Switch to use binman to pack images Signed-off-by: Peng Fan --- arch/arm/dts/imx8mq-pico-pi.dts | 1 + arch/arm/mach-imx/imx8m/Kconfig | 1 + board/technexion/pico-imx8mq/Kconfig | 2 +- board/technexion/pico-imx8mq/imximage.cfg | 11 +++

[PATCH V3 2/5] imx: imx8mq_phanbell: switch to binman

2021-10-21 Thread Peng Fan (OSS)
From: Peng Fan Switch to binman to pack images Signed-off-by: Peng Fan --- arch/arm/dts/imx8mq-phanbell-u-boot.dtsi | 2 ++ arch/arm/mach-imx/imx8m/Kconfig | 7 --- board/google/imx8mq_phanbell/Kconfig | 2 +- board/google/imx8mq_phanbell/imximage.cfg | 11 +++

[PATCH V3 1/5] imx: imx8mq_evk: switch to binman

2021-10-21 Thread Peng Fan (OSS)
From: Peng Fan Switch to use binman to pack images Signed-off-by: Peng Fan --- arch/arm/dts/imx8mq-evk-u-boot.dtsi | 2 + arch/arm/dts/imx8mq-u-boot.dtsi | 122 arch/arm/mach-imx/imx8m/Kconfig | 1 + board/freescale/imx8mq_evk/Kconfig |

[PATCH V3 0/5] imx8mq: switch to binman

2021-10-21 Thread Peng Fan (OSS)
From: Peng Fan V3: Rebased due to IMX_CONFIG moved to Kconfig drop two patches which applied to imx/master V2: Add cover-letter Rebased to latest master to avoid apply failure. Peng Fan (5): imx: imx8mq_evk: switch to binman imx: imx8mq_phanbell: switch to binman imx: pico-imx8mq:

Re: [RFC PATCH] tools: kwbimage: Allow to disable compilation of kwbimage on non-mvebu platforms

2021-10-21 Thread Samuel Holland
Hi, Thanks for sending this patch! On 10/21/21 4:33 AM, Pali Rohár wrote: > kwbimage depends on libcrypto. 32-bit mvebu platforms (except Orion and > Discovery, which are not in mach-mvebu) require kwimage for building SPL. > > Some users want to compile u-boot tools without libcrypto. > >

Please pull u-boot-dm

2021-10-21 Thread Simon Glass
Hi Tom, https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/9563 The following changes since commit f200a4bcecf1be6d8b546f0eb6af6403c93d80dd: Merge https://source.denx.de/u-boot/custodians/u-boot-marvell (2021-10-21 07:52:15 -0400) are available in the Git repository at:

RE: please help, "Ram disk image is corrupt or invalid" (qemu virt machine, arm64)

2021-10-21 Thread Chan Kim
Hi, Jaehoon, I followed your suggestion and used CONFIG_INITRAMFS_SOURCE to include the initramfs.cpio.gz in the 'Image' and could see the shell coming up with booti command. Thanks! Chan Kim > -Original Message- > From: Jaehoon Chung > Sent: Wednesday, October 20, 2021 7:41 AM > To:

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-21 Thread Samuel Holland
On 10/21/21 8:00 AM, Marek Behún wrote: > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu > platform in Kconfig? No, that would not do anything. For example: config ARMADA_32BIT imply TOOLS_LIBCRYPTO is equivalent to: config TOOLS_LIBCRYPTO

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-10-21 Thread Jaehoon Chung
Hi, On 10/21/21 1:52 PM, Samuel Holland wrote: > Now that the sunxi_gpio driver handles pull-up/down via the driver > model, pin configuration does not need a platform-specific function. > > Signed-off-by: Samuel Holland > --- > > drivers/mmc/sunxi_mmc.c | 8 ++-- > 1 file changed, 2

Re: [PATCH] x86: Fix linking u-boot with ld.lld

2021-10-21 Thread Simon Glass
On Wed, 20 Oct 2021 at 15:31, Alistair Delva wrote: > > When linking the final u-boot binary with LLD, the following link errors > are seen: > > ld.lld: error: can't create dynamic relocation R_386_32 against local >symbol in readonly segment; recompile object files with >

Re: [PATCH] x86: Fix i8254 ifdef include guard

2021-10-21 Thread Simon Glass
On Wed, 20 Oct 2021 at 15:31, Alistair Delva wrote: > > When building U-Boot with clang, it notices that the i8254.h include > guard does not work correctly due to a typo. Fix it. > > Signed-off-by: Alistair Delva > Cc: Simon Glass > Cc: Bin Meng > --- > arch/x86/include/asm/i8254.h | 2 +- >

Re: [PATCH] x86: chromebook_coral: fix C block comment

2021-10-21 Thread Simon Glass
On Wed, 20 Oct 2021 at 15:31, Alistair Delva wrote: > > Fix a warning seen when compiling this dts file. > > Signed-off-by: Alistair Delva > Cc: Simon Glass > Cc: Bin Meng > --- > arch/x86/dts/chromebook_coral.dts | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass > diff

Re: [PATCH] Makefile: Add a warning about ad-hoc CONFIG options

2021-10-21 Thread Simon Glass
Hi Tom, On Tue, 21 Sept 2021 at 08:49, Tom Rini wrote: > > On Mon, Sep 20, 2021 at 07:11:26PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 20 Sept 2021 at 09:20, Tom Rini wrote: > > > > > > On Sat, Sep 18, 2021 at 12:21:21PM -0600, Simon Glass wrote: > > > > > > > The Kconfig feature

Re: [PATCH 10/11] sandbox: mmc: Support a backing file

2021-10-21 Thread Simon Glass
Hi Tom, On Sun, 19 Sept 2021 at 21:18, Simon Glass wrote: > > Hi Tom, > > On Sat, 18 Sept 2021 at 10:31, Simon Glass wrote: > > > > Hi Tom, > > > > On Sat, 18 Sept 2021 at 07:16, Tom Rini wrote: > > > > > > On Sat, Sep 18, 2021 at 03:34:54AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > >

Re: [PATCH] arm: dts: sun50i-h6-orangepi-3: disable aldo2 regulator

2021-10-21 Thread Maxim Karasev
>What are you packaging, exactly? (And for what distro?) I guess it's some >kind of U-Boot/firmware package [1]? Yes, it's U-Boot + ATF at Alpine and Linux + WiFi/BT firmware at postmarketOS. >So you build this per device then? Well, not exactly. Alpine builds one shared ATF package that

Re: [PATCH] CI: Switch running the nokia_rx51 test with in-container toolchain

2021-10-21 Thread Simon Glass
On Thu, 14 Oct 2021 at 20:21, Tom Rini wrote: > > Instead of fetching an arm toolchain to use, run the test with the one > that's already in the container image. > > Signed-off-by: Tom Rini > --- > .azure-pipelines.yml | 3 +-- > .gitlab-ci.yml | 3 +-- > 2 files changed, 2 insertions(+),

Re: [PATCH 2/2] sandbox: provide /chosen/boot-hartid property

2021-10-21 Thread Simon Glass
On 10/20/21 00:54, Simon Glass wrote: > Hi Heinrich, > > On Sat, 28 Aug 2021 at 03:42, Heinrich Schuchardt wrote: >> >> On RISC-V the sandbox must provide the /chosen/boot-hartid in the >> devicetree. >> >> Signed-off-by: Heinrich Schuchardt >> --- >> arch/sandbox/lib/Makefile| 2 +- >>

Re: [PATCH v3 03/13] examples: api: glue: Remove comment that does not apply anymore

2021-10-21 Thread Simon Glass
From: Marek Behún This comment is not true since commit 6215bd4c1fd6 ("api: Use hashtable function for API_env_enum"). Signed-off-by: Marek Behún Reviewed-by: Simon Glass --- examples/api/glue.c | 5 - 1 file changed, 5 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 01/13] env: Fix documentation for env_get_f()

2021-10-21 Thread Simon Glass
From: Marek Behún This function actually returns: - the number of bytes written into @buf excluding the terminating NULL-byte, if there was enough space in @buf - the number of bytes written into @buf including the terminating NULL-byte, if there wasn't enough space in @buf - -1 if the

Re: [PATCH v3 08/13] env: Don't match empty variable name in env_match()

2021-10-21 Thread Simon Glass
From: Marek Behún Do we really allow zero-length variable name? I guess not. Signed-off-by: Marek Behún Reviewed-by: Simon Glass --- cmd/nvedit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 05/13] env: Inline env_get_char() into its only user

2021-10-21 Thread Simon Glass
From: Marek Behún This function is a relic from the past when environment was read from underlying device one character at a time. It is used only in the case when getting an environemnt variable prior relocation, and the function is simple enough to be inlined there. Since env_get_char() is

Re: [PATCH v3 04/13] env: Change env_match() to static and remove from header

2021-10-21 Thread Simon Glass
From: Marek Behún This function was used by other parts of U-Boot in the past when environment was read from underlying device one character at a time. This is not the case anymore. Signed-off-by: Marek Behún Reviewed-by: Simon Glass --- cmd/nvedit.c | 30 +++---

Re: [PATCH v3 02/13] env: Drop env_get_char_spec() and old, unused .get_char() implementations

2021-10-21 Thread Simon Glass
From: Marek Behún Commit b2cdef4861be ("env: restore old env_get_char() behaviour") dropped the .get_char() method from struct env_driver, but left the two existing implementations (eeprom and nvram) in case someone would use them by overwriting weak function env_get_char_spec(). Since this was

Re: [PATCH] dm: Fix util.h's broken include guard

2021-10-21 Thread Simon Glass
Fix up the header's include guard to contain the definition of dm_priv_to_rw(), which was erroneously added outside of it, by moving its #endif to the end of the file (i.e. where it belongs). This removes the risk of compilation errors resulting from the redefinition of that function where the

Re: [PATCH] buildman: Add gcc-11.1.0 to the directory list

2021-10-21 Thread Simon Glass
On Thu, Oct 14, 2021 at 07:25:24PM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 14 Oct 2021 at 19:12, Tom Rini wrote: > > > > On Thu, Oct 14, 2021 at 07:05:33PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 5 Oct 2021 at 10:20, Tom Rini wrote: > > > > > > > > While CI has been

Re: [PATCH v3 06/13] env: Use string pointer instead of indexes in env_get_f()

2021-10-21 Thread Simon Glass
From: Marek Behún Since we no longer use env_get_char() to access n-th character of linearized environment data, but rather access the arrays themselves, we can convert the iteration to use string pointers instead of position indexes. Signed-off-by: Marek Behún Reviewed-by: Simon Glass ---

Re: [PATCH v3 07/13] env: Use better name for variable in env_get_f()

2021-10-21 Thread Simon Glass
From: Marek Behún The `nxt` variable actually points to the terminating null-byte of the current env var, and the next env var is at `nxt + 1`, not `nxt`. So a better name for this variable is `end`. Signed-off-by: Marek Behún Reviewed-by: Simon Glass --- cmd/nvedit.c | 8 1 file

Re: [PATCH v3 09/13] env: Early return from env_get_f() on NULL name

2021-10-21 Thread Simon Glass
From: Marek Behún Test non-NULL name immediately, not in env_match(). Signed-off-by: Marek Behún Reviewed-by: Simon Glass --- cmd/nvedit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 11/13] env: Use memcpy() instead of ad-hoc code to copy variable value

2021-10-21 Thread Simon Glass
From: Marek Behún Copy the value of the found variable into given buffer with memcpy() instead of ad-hoc code. Signed-off-by: Marek Behún Reviewed-by: Simon Glass --- cmd/nvedit.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 10/13] env: Make return value of env_get_f() behave like sprintf() on success

2021-10-21 Thread Simon Glass
From: Marek Behún Currently the env_get_f() function's return value behaves weirdly: it returns the number of bytes written into `buf`, but whether this is excluding the terminating NULL-byte or including it depends on whether there was enough space in `buf`. Change the function to always

Re: [PATCH v3 13/13] env: Move non-cli env functions to env/common.c

2021-10-21 Thread Simon Glass
From: Marek Behún Move the following functions from cmd/nvedit.c to env/common.c: env_set_ulong() env_set_hex() env_get_hex() eth_env_get_enetaddr() eth_env_set_enetaddr() env_get() from_env() env_get_f() env_get_ulong() since these functions are not specific for U-Boot's CLI.

Re: [PATCH v3 12/13] env: Simplify env_match() and inline into env_get_f()

2021-10-21 Thread Simon Glass
Hi Marek, On Mon, 18 Oct 2021 at 18:50, Marek Behún wrote: > > > Reviewed-by: Simon Glass > > Simon, thanks. Will you be taking this through your tree or should I > change delegate to Tom? I see it in my queue so I'll pick it up. Regards, Simon Applied to u-boot-dm, thanks!

[PATCH] rockchip: Add initial support for the PinePhone Pro

2021-10-21 Thread Martijn Braam
This is a new device by PINE64 that's very similar to the Pinebook Pro that's already supported. Specification: - Rockchip RK3399 - 4GB Dual-Channel LPDDR4 - 128GB eMMC - mSD card slot - AP6255 for 802.11ac WiFi and Bluetooth - 6 inch 720*1440 DSI display - Quectel EG25g usb modem - Type-C port

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Simon Glass
Hi Tom, On Thu, 21 Oct 2021 at 10:03, Tom Rini wrote: > > On Thu, Oct 21, 2021 at 09:59:38AM -0600, Simon Glass wrote: > > Hi Marek, > > > > On Thu, 21 Oct 2021 at 07:28, Marek Behún wrote: > > > > > > On Thu, 21 Oct 2021 15:25:37 +0200 > > > Marek Behún wrote: > > > > > > > Hello, > > > > > >

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Stefano Babic
Hi Simon, On 21.10.21 18:15, Tom Rini wrote: On Thu, Oct 21, 2021 at 10:09:56AM -0600, Simon Glass wrote: Hi Tom, On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: Hex and int Kconfig options are supposed to have defaults. This is

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 10:09:56AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: > > > > On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: > > > > > Hex and int Kconfig options are supposed to have defaults. This is so we > > > can configure

Re: [PATCH] cmd: nand biterr - Add support for nand biterr command

2021-10-21 Thread Balamanikandan.Gunasundar
Hello, Can you please provide your comments on this patch. Thanks, Balamanikandan On 29/06/21 12:46 pm, Balamanikandan Gunasundar wrote: > The command shall be used to induce bit errors in the nand page > manually. The code flips a bit in the specified offset without > changing the ECC. This

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Simon Glass
Hi Tom, On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: > > On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: > > > Hex and int Kconfig options are supposed to have defaults. This is so we > > can configure U-Boot without having to enter particular values for the > > items that don't

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 09:59:38AM -0600, Simon Glass wrote: > Hi Marek, > > On Thu, 21 Oct 2021 at 07:28, Marek Behún wrote: > > > > On Thu, 21 Oct 2021 15:25:37 +0200 > > Marek Behún wrote: > > > > > Hello, > > > > > > On Thu, 21 Oct 2021 15:06:51 +0200 > > > Wolfgang Denk wrote: > > > > > >

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Simon Glass
Hi Marek, On Thu, 21 Oct 2021 at 07:28, Marek Behún wrote: > > On Thu, 21 Oct 2021 15:25:37 +0200 > Marek Behún wrote: > > > Hello, > > > > On Thu, 21 Oct 2021 15:06:51 +0200 > > Wolfgang Denk wrote: > > > > > I confirm that '+=' looks better. But '+=" is technically broken. > > > > a bit of

[PATCH] arm: mvebu: turris_omnia: Fix MTD partitions order for Linux

2021-10-21 Thread Pali Rohár
Linux enumerates MTD partitions in DTB order, while the fdt_add_subnode() function puts a new subnode at the beginning. To fix this, put MTD partitions into DTB in reverse order. Fixes: 92f36c8e74c1 ("arm: mvebu: turris_omnia: fixup MTD partitions in Linux' DTB") Signed-off-by: Pali Rohár

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 05:12:26PM +0200, Wolfgang Denk wrote: > Dear Marek, > > In message <20211021152831.15524883@thinkpad> you wrote: > > > > > > > I think =+ will confuse far more people than + as last character of var > > I still fail to see why '=+' could be confusing if properly >

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
Dear Marek, In message <20211021152831.15524883@thinkpad> you wrote: > > > > I think =+ will confuse far more people than + as last character of var I still fail to see why '=+' could be confusing if properly documented to be the append operator. I mean, it is not a new invention of mine.

Commit 76c2ff3e broke backlight on Chromebook snow

2021-10-21 Thread Guillaume GARDET
Hi, Commit 76c2ff3e [0] broke backlight on Chromebook snow. A revert on top of 2021.10 restores the backlight. Not sure why it breaks on Chromebook snow yet. Dario, any idea how to fix this? Cheers, Guillaume

[PATCH 4/4] arm: mvebu: Remove dummy BIN header arguments for SPL binary

2021-10-21 Thread Pali Rohár
U-Boot SPL binary does not read BIN header arguments, so passing some dummy values 005b and 0068 has no effect for U-Boot SPL code. Probably these two values comes from old Marvell DDR training code which was separated from U-Boot and used it for some configuration. Seems that two 32-bit

[PATCH 1/4] tools: kwboot: Align UART baudrate change code in BIN header to 128-bit boundary

2021-10-21 Thread Pali Rohár
ARM executable code inside the BIN header on some mvebu platforms (e.g. A370, AXP) must always be aligned with the 128-bit boundary. This requirement can be met by inserting dummy arguments into BIN header. Signed-off-by: Pali Rohár --- tools/kwboot.c | 22 +- 1 file

[PATCH 2/4] tools: kwbimage: Align BIN header executable code to 128-bit boundary

2021-10-21 Thread Pali Rohár
ARM executable code inside the BIN header on some mvebu platforms (e.g. A370, AXP) must always be aligned with the 128-bit boundary. This requirement can be met by inserting dummy arguments into BIN header. Signed-off-by: Pali Rohár --- tools/kwbimage.c | 51

[PATCH 3/4] arm: mvebu: Add documentation for save_boot_params() function

2021-10-21 Thread Pali Rohár
Important detail is availability of kwbimage BIN header arguments passed via r0 and r1 registers by BootROM. Signed-off-by: Pali Rohár --- arch/arm/mach-mvebu/lowlevel_spl.S | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/mach-mvebu/lowlevel_spl.S

[PATCH 0/4] arm: mvebu: Fix usage of BIN header arguments

2021-10-21 Thread Pali Rohár
BIN header arguments are used only for aligning ARM executable code to 128-bit boundary. This patch series document this behavior and fix kwbimage and kwboot code to properly generate BIN headers. Pali Rohár (4): tools: kwboot: Align UART baudrate change code in BIN header to 128-bit

Re: [PATCH] xilinx: zynqmp: Save multiboot as variable

2021-10-21 Thread Oleksandr Suvorov
On Thu, Oct 21, 2021 at 9:59 AM Michal Simek wrote: > > Save multiboot register as u-boot variable. And use it as primary source > for composing dfu_alt_info for capsule update. If variable is not defined > > Signed-off-by: Michal Simek > --- > > board/xilinx/zynqmp/zynqmp.c | 4 +++- > 1 file

Re: Please pull u-boot-marvell/master

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 09:53:56AM +0200, Stefan Roese wrote: > Hi Tom, > > please pull this next batch of Marvell MVEBU related patches: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH v2] mx7ulp: add getting a board serial number

2021-10-21 Thread sbabic
> From: Ricardo Salveti > Get Unique ID of SoC iMX7ULP, using the logic described in Fusemap > (IMX7ULPRMB2_Rev0_Fusemap) attached in the i.MX 7ULP APRM [1]. > [1] > https://www.nxp.com/docs/en/reference-manual/IMX7ULPRMB2.pdf > Signed-off-by: Ricardo Salveti > Co-developed-by: Oleksandr Suvorov

[PATCH 2/7] arm: mach-imx: Allow to build mac.c for EQoS driver

2021-10-21 Thread sbabic
> i.MX8MP has one DWC EQoS controller, so allow to build mac.c when > only this driver is enabled. > Signed-off-by: Ye Li Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH,

[PATCH 6/7] imx8mp_evk: Delete noncached memory config

2021-10-21 Thread sbabic
> DWC EQOS driver has removed to use noncached memory, so delete > the configuration from iMX8MP EVK head file. > Signed-off-by: Ye Li Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software

[PATCH 1/7] arm: mach-imx: Update MAC fuse for i.MX8MP

2021-10-21 Thread sbabic
> i.MX8MP has two ENET controllers, have to update the function to > enable loading two MAC addresses. > Signed-off-by: Ye Li > Tested-by: Marcel Ziswiler Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic --

[PATCH] tools: imx8m_image: Support ddr3 firmware

2021-10-21 Thread sbabic
> Some boards use ddr3, not ddr4, so we need to check ddr3 firmware. > Signed-off-by: Ariel D'Alessandro Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, Managing

[PATCH v2] board: ea: mx7ulp_com: allocate specific region of memory to OP-TEE

2021-10-21 Thread sbabic
> From: Ricardo Salveti > On the iMX7ULP uCOM board, OP-TEE uses the memory region defined by the > maximum DRAM address minus CONFIG_OPTEE_TZDRAM_SIZE, so subtract > CONFIG_OPTEE_TZDRAM_SIZE from the available DRAM size to avoid > conflicts. > Note the OPTEE boot process itself subtracts the

[PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node

2021-10-21 Thread sbabic
> Since SPL has initialized clocks for bus and core. We don't need to > set the default clocks for clock controller node. > Signed-off-by: Ye Li > Tested-by: Teresa Remmet > Tested-by: Andrey Zhizhikin > Acked-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic

[PATCH 3/7] arm: dts: imx8mp-evk: Enable the EQoS ethernet port

2021-10-21 Thread sbabic
> i.MX8MP EVK has two ethernet ports. Add relevant nodes and properties > for EQoS port to the EVK DTS file. > In -u-boot.dtsi, change the u-boot eqos compatible string, add PHY > reset gpio and remove assigned clocks as not supported in CCF. > Signed-off-by: Ye Li Applied to u-boot-imx, master,

[PATCH 5/7] imx8mp_evk: Remove EQoS PHY reset codes

2021-10-21 Thread sbabic
> Since we uses the DTS and PHY reset gpio in EQoS driver to do the > reset, remove the duplicated codes from board file. > Signed-off-by: Ye Li Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX

[PATCH 4/7] imx8mp_evk: Fix incorrect cascade for FEC and EQOS setup

2021-10-21 Thread sbabic
> The setup functions should be independent for two ethernet controllers > Signed-off-by: Ye Li Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, Managing Director:

[PATCH 7/7] imx8mp_evk: Enable the DWC EQoS iMX driver

2021-10-21 Thread sbabic
> Enable the EQoS i.MX driver in defconfig, also enable the PHYLIB > to facilitate the case that only has FEC enabled. > Signed-off-by: Ye Li Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX

Re: [PATCH v9 0/7] env: Allow environment in text files

2021-10-21 Thread Tom Rini
On Tue, Oct 19, 2021 at 04:44:15PM -0600, Simon Glass wrote: > One barrier to completing the 7-year-long Kconfig migration is that > the default environment is implemented using ad-hoc CONFIG options. > At present U-Boot environment variables, and thus scripts, are defined > by

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-21 Thread Heiko Thiery
Hi Stefano, Hi Simon, Am Do., 21. Okt. 2021 um 15:29 Uhr schrieb Stefano Babic : > > On 21.10.21 15:17, Heiko Thiery wrote: > > Hi Stefano, > > > > > > Am Do., 21. Okt. 2021 um 13:31 Uhr schrieb Stefano Babic : > >> > >> Hi Heiko, > >> > >> On 14.10.21 20:08, Heiko Thiery wrote: > >>> The

Re: [PATCH v3 1/3] efi_loader: add SMBIOS table measurement

2021-10-21 Thread Masahisa Kojima
is On Thu, 21 Oct 2021 at 22:04, Heinrich Schuchardt wrote: > > > > On 10/21/21 14:52, Masahisa Kojima wrote: > > On Thu, 21 Oct 2021 at 17:49, Heinrich Schuchardt > > wrote: > >> > >> > >> > >> On 10/21/21 10:38, Masahisa Kojima wrote: > >>> On Thu, 21 Oct 2021 at 09:17, Heinrich Schuchardt

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-21 Thread Stefano Babic
On 21.10.21 15:17, Heiko Thiery wrote: Hi Stefano, Am Do., 21. Okt. 2021 um 13:31 Uhr schrieb Stefano Babic : Hi Heiko, On 14.10.21 20:08, Heiko Thiery wrote: The Kontron pitx-imx8m is an NXP i.MX8MQ based board in the pITX form factor. There is still something using binman that does

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Marek Behún
On Thu, 21 Oct 2021 15:25:37 +0200 Marek Behún wrote: > Hello, > > On Thu, 21 Oct 2021 15:06:51 +0200 > Wolfgang Denk wrote: > > > I confirm that '+=' looks better. But '+=" is technically broken. > > a bit of my opinion: > I think =+ will confuse far more people than + as last character

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Marek Behún
Hello, On Thu, 21 Oct 2021 15:06:51 +0200 Wolfgang Denk wrote: > I confirm that '+=' looks better. But '+=" is technically broken. a bit of my opinion: I think =+ will confuse far more people than + as last character of var name working weirdly. But I also think that + should be supported as

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-21 Thread Heiko Thiery
Hi Stefano, Am Do., 21. Okt. 2021 um 13:31 Uhr schrieb Stefano Babic : > > Hi Heiko, > > On 14.10.21 20:08, Heiko Thiery wrote: > > The Kontron pitx-imx8m is an NXP i.MX8MQ based board in the pITX > > form factor. > > > > There is still something using binman that does not work with CI. >

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
Dear Tom, In message <20211021122325.GX7964@bill-the-cat> you wrote: > > Do you have any other feedback on the entire rest of the series? I already wrote that I support the concept, and the few nit I saw have been fixed, I think. Except this unneeded breaking of backward compatibility. >

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-21 Thread Pali Rohár
On Thursday 21 October 2021 15:00:48 Marek Behún wrote: > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu > platform in Kconfig? FYI https://lore.kernel.org/u-boot/20211021093304.25399-1-p...@kernel.org/ (forgot to CC)

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-21 Thread Marek Behún
BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu platform in Kconfig?

Re: [PATCH v3 1/3] efi_loader: add SMBIOS table measurement

2021-10-21 Thread Heinrich Schuchardt
On 10/21/21 14:52, Masahisa Kojima wrote: On Thu, 21 Oct 2021 at 17:49, Heinrich Schuchardt wrote: On 10/21/21 10:38, Masahisa Kojima wrote: On Thu, 21 Oct 2021 at 09:17, Heinrich Schuchardt wrote: On 10/1/21 1:18 PM, Masahisa Kojima wrote: TCG PC Client spec requires to measure the

Re: [PATCH v3 1/3] efi_loader: add SMBIOS table measurement

2021-10-21 Thread Masahisa Kojima
On Thu, 21 Oct 2021 at 17:49, Heinrich Schuchardt wrote: > > > > On 10/21/21 10:38, Masahisa Kojima wrote: > > On Thu, 21 Oct 2021 at 09:17, Heinrich Schuchardt > > wrote: > >> > >> On 10/1/21 1:18 PM, Masahisa Kojima wrote: > >>> TCG PC Client spec requires to measure the SMBIOS > >> > >> I

Re: [PATCH] stm32mp: stm32prog: Normalise newlines

2021-10-21 Thread Patrick DELAUNAY
On 10/13/21 11:56 AM, William Grant wrote: The missing trailing newline could confuse check-config.sh if the definition of an option was on the first line of the next file that find(1) happened to return. Signed-off-by: William Grant --- arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig | 3 +--

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-21 Thread Marek Behún
Hi Samuel, On Wed, 20 Oct 2021 09:14:11 -0500 Samuel Holland wrote: > Andre is correct. No version of this patch makes *any* change to *any* > in-tree defconfig build, because TOOLS_LIBCRYPTO=y in all defconfigs. > Even if I was to accept your assertion that it hides a possible error on >

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 11:50:02AM +0200, Wolfgang Denk wrote: > Dear Simon, > > In message > <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you > wrote: > > At present U-Boot environment variables, and thus scripts, are defined > > by CONFIG_EXTRA_ENV_SETTINGS. It is

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-21 Thread Stefano Babic
Hi Heiko, On 14.10.21 20:08, Heiko Thiery wrote: The Kontron pitx-imx8m is an NXP i.MX8MQ based board in the pITX form factor. There is still something using binman that does not work with CI. Without CI, we load all firmware including signed_hdmi_imx8m.bin. But on CI, file is not loaded,

Re: [PATCH] doc: Remove obsolete README.440-DDR-performance file

2021-10-21 Thread Thomas Huth
On 21/10/2021 08.00, Thomas Huth wrote: On 21/10/2021 07.16, Stefan Roese wrote: On 21.10.21 00:32, Heinrich Schuchardt wrote: On 10/19/21 9:25 AM, Thomas Huth wrote: The PPC 440 support has been removed in commit 98f705c9ce ("powerpc: remove 4xx support") already, so this file is certainly

Re: [PATCH] doc: Remove obsolete doc/README.nand-boot-ppc440

2021-10-21 Thread Thomas Huth
On 21/10/2021 07.20, Stefan Roese wrote: The PPC440 support has been removed in commit 98f705c9ce ("powerpc: remove 4xx support"). This patch removes this obsolete file as well. Signed-off-by: Stefan Roese Cc: Heinrich Schuchardt Cc: Thomas Huth --- doc/README.nand-boot-ppc440 | 60

Re: [PATCH] doc: Remove obsolete README.440-DDR-performance file

2021-10-21 Thread Thomas Huth
On 21/10/2021 07.16, Stefan Roese wrote: On 21.10.21 00:32, Heinrich Schuchardt wrote: On 10/19/21 9:25 AM, Thomas Huth wrote: The PPC 440 support has been removed in commit 98f705c9ce ("powerpc: remove 4xx support") already, so this file is certainly not required anymore. Signed-off-by:

Re: [PATCH] arm: dts: sun50i-h6-orangepi-3: disable aldo2 regulator

2021-10-21 Thread Andre Przywara
On Wed, 20 Oct 2021 21:31:09 +0300 Maxim Karasev wrote: Hi Maxim, > Hi. Thanks for explanation, I'm new to mailing lists, so I appreciate this. > > Also I'm happy to hear that any work is done to address that issue. > > >I was thinking about adding a TF-A build option that would skip

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Tom Rini
On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: > Hex and int Kconfig options are supposed to have defaults. This is so we > can configure U-Boot without having to enter particular values for the > items that don't have specific values in the board's defconfig file. That's not true.

Re: [PATCH v3 12/16] Layerscape: Add crypto node in device tree

2021-10-21 Thread Vladimir Oltean
On Thu, Oct 21, 2021 at 07:50:46AM -0400, Tom Rini wrote: > On Thu, Oct 21, 2021 at 09:07:42AM +0200, Michael Walle wrote: > > Hi, > > > > > LS(1021/1012/1028/1043/1046/1088/2088), LX2160 - updated device tree > > > > > > Signed-off-by: Gaurav Jain > > > Reviewed-by: Priyanka Jain > > > --- >

  1   2   >