Re: [PATCH v6 01/25] doc: Add documentation about devicetree usage

2021-12-04 Thread François Ozog
Hi Simon Le sam. 4 déc. 2021 à 18:42, Simon Glass a écrit : > Hi François, > > On Sat, 4 Dec 2021 at 04:06, François Ozog > wrote: > > > > Hi Simon > > > > Le sam. 4 déc. 2021 à 02:02, Simon Glass a écrit : > >> > >> Hi Heinrich, > >> > >> On Fri, 3 Dec 2021 at 13:28, Heinrich Schuchardt >

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread François Ozog
Hi Simon Le sam. 4 déc. 2021 à 18:35, Simon Glass a écrit : > Hi François, > > On Sat, 4 Dec 2021 at 09:55, François Ozog > wrote: > > > > Hi Simon > > > > Le sam. 4 déc. 2021 à 16:21, Simon Glass a écrit : > >> > >> Hi Tom, > >> > >> On Sat, 4 Dec 2021 at 06:52, Tom Rini wrote: > >> > > >>

[PATCH 2/2] net: dsa: sja1105: fix device id detection

2021-12-04 Thread Vladimir Oltean
The sja1105_check_device_id() function contains logic to work without changing the device tree on reworked boards, one of which I have (the NXP LS1021A-TSN normally has a SJA1105T, but I have a version with a resoldered SJA1105Q which is pin compatible). This logic is taken from the Linux driver.

[PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

2021-12-04 Thread Vladimir Oltean
If the DSA API is going to allow drivers to do things such as: - phy_config in dsa_ops :: port_probe - phy_startup in dsa_ops :: port_enable then it would actually be good if the ->port_probe() method would actually be called in all cases before the ->port_enable() is. Currently this is true

[PATCH 0/2] DSA switch fixes

2021-12-04 Thread Vladimir Oltean
This small patch set contains some bug fixes. The first is for the recently introduced ->port_probe() DSA switch method, and the second is for the recently introduced SJA1105 driver. Vladimir Oltean (2): net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY net: dsa:

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread Simon Glass
Hi Tom, On Sat, 4 Dec 2021 at 11:03, Tom Rini wrote: > > On Sat, Dec 04, 2021 at 08:20:55AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Sat, 4 Dec 2021 at 06:52, Tom Rini wrote: > > > > > > On Fri, Dec 03, 2021 at 06:01:56PM -0700, Simon Glass wrote: > > > > > > [huge snip] > > > > >

Re: [PATCH v5 15/28] efi: Move exit_boot_services into a function

2021-12-04 Thread Heinrich Schuchardt
On 12/4/21 16:56, Simon Glass wrote: At present this code is inline in the app and stub. But they do the same thing. The difference is that the stub does it immediately and the app doesn't want to do it until the end (when it boots a kernel) or not at all, if returning to UEFI. Move it into a

Re: [PATCH v5 13/28] efi: Add a few comments to the stub

2021-12-04 Thread Heinrich Schuchardt
On 12/4/21 16:56, Simon Glass wrote: Comment some functions that need more information. Signed-off-by: Simon Glass --- (no changes since v1) lib/efi/efi_stub.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/efi/efi_stub.c b/lib/efi/efi_stub.c index

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread Ilias Apalodimas
Hi Simon, On Sat, Dec 04, 2021 at 10:25:29AM -0700, Simon Glass wrote: > Hi Ilias, > > On Sat, 4 Dec 2021 at 08:58, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > [...] > > > > [huge snip] > > > > > > There's things that need to be cleaned up because we have some small > > > > > > number

Re: [PATCH v5 04/28] efi: Locate all block devices in the app

2021-12-04 Thread Heinrich Schuchardt
On 12/4/21 16:56, Simon Glass wrote: When starting the app, locate all block devices and make them available to U-Boot. This allows listing partitions and accessing files in filesystems. EFI also has the concept of 'disks', meaning boot media. For now, this is not obviously useful in U-Boot,

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread Tom Rini
On Sat, Dec 04, 2021 at 08:20:55AM -0700, Simon Glass wrote: > Hi Tom, > > On Sat, 4 Dec 2021 at 06:52, Tom Rini wrote: > > > > On Fri, Dec 03, 2021 at 06:01:56PM -0700, Simon Glass wrote: > > > > [huge snip] > > > > There's things that need to be cleaned up because we have some small > > > >

Re: [PULL] u-boot-riscv/master

2021-12-04 Thread Tom Rini
On Fri, Dec 03, 2021 at 02:19:32PM +0800, Leo Liang wrote: > Hi Tom, > > The following changes since commit 4a14bfffd42f968ed9d72a780a8d44a9053c5b95: > > Merge https://source.denx.de/u-boot/custodians/u-boot-marvell (2021-11-30 > 08:59:22 -0500) > > are available in the Git repository at: >

Re: [PATCH v6 01/25] doc: Add documentation about devicetree usage

2021-12-04 Thread Simon Glass
Hi François, On Sat, 4 Dec 2021 at 04:06, François Ozog wrote: > > Hi Simon > > Le sam. 4 déc. 2021 à 02:02, Simon Glass a écrit : >> >> Hi Heinrich, >> >> On Fri, 3 Dec 2021 at 13:28, Heinrich Schuchardt wrote: >> > >> > On 12/3/21 9:13 PM, Simon Glass wrote: >> > > Hi Heinrich, >> > > >> > >

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread Simon Glass
Hi François, On Sat, 4 Dec 2021 at 09:55, François Ozog wrote: > > Hi Simon > > Le sam. 4 déc. 2021 à 16:21, Simon Glass a écrit : >> >> Hi Tom, >> >> On Sat, 4 Dec 2021 at 06:52, Tom Rini wrote: >> > >> > On Fri, Dec 03, 2021 at 06:01:56PM -0700, Simon Glass wrote: >> > >> > [huge snip] >> >

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread Simon Glass
Hi Mark, On Sat, 4 Dec 2021 at 09:09, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Sat, 4 Dec 2021 08:20:55 -0700 > > > > Hi Tom, > > > > On Sat, 4 Dec 2021 at 06:52, Tom Rini wrote: > > > > > > On Fri, Dec 03, 2021 at 06:01:56PM -0700, Simon Glass wrote: > > > > > > [huge snip] > >

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread Simon Glass
Hi Ilias, On Sat, 4 Dec 2021 at 08:58, Ilias Apalodimas wrote: > > Hi Simon, > > [...] > > > [huge snip] > > > > > There's things that need to be cleaned up because we have some small > > > > > number of platforms that went off and did their own thing. But > > > > > largely > > > > > yes,

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread François Ozog
Hi Simon Le sam. 4 déc. 2021 à 16:21, Simon Glass a écrit : > Hi Tom, > > On Sat, 4 Dec 2021 at 06:52, Tom Rini wrote: > > > > On Fri, Dec 03, 2021 at 06:01:56PM -0700, Simon Glass wrote: > > > > [huge snip] > > > > There's things that need to be cleaned up because we have some small > > > >

[PATCH v5 27/28] x86: efi: Set the correct link flags for the 64-bit EFI app

2021-12-04 Thread Simon Glass
At present some 32-bit settings are used with the 64-bit app. Fix this by separating out the two cases. Be careful not to break the 64-bit payload, which needs to build a 64-bit EFI stub with a 32-bit U-Boot. Signed-off-by: Simon Glass --- Changes in v5: - Add new patch to set the correct link

[PATCH v5 21/28] efi: Support the efi command in the app

2021-12-04 Thread Simon Glass
At present the 'efi' command only works in the EFI payload. Update it to work in the app too, so the memory map can be examined. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Makefile | 2 +- cmd/efi.c | 48 ---

[PATCH v5 25/28] x86: efi: Round out the link script for 64-bit EFI

2021-12-04 Thread Simon Glass
Make sure the linker lists are in the right place and drop the eh_frame section, which is not needed. Signed-off-by: Simon Glass --- Changes in v5: - Add new patch to round out the link script for 64-bit EFI arch/x86/lib/elf_x86_64_efi.lds | 5 - 1 file changed, 4 insertions(+), 1

[PATCH v5 23/28] x86: efi: Don't set up global_data again with EFI

2021-12-04 Thread Simon Glass
Since EFI does not relocate and uses the same global_data pointer throughout the board-init process, drop this unnecessary setup, to avoid a hang. Signed-off-by: Simon Glass --- Changes in v5: - Add new patch to avoid setting up global_data again with EFI common/board_r.c | 5 ++--- 1 file

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread Mark Kettenis
> From: Simon Glass > Date: Sat, 4 Dec 2021 08:20:55 -0700 > > Hi Tom, > > On Sat, 4 Dec 2021 at 06:52, Tom Rini wrote: > > > > On Fri, Dec 03, 2021 at 06:01:56PM -0700, Simon Glass wrote: > > > > [huge snip] > > > > There's things that need to be cleaned up because we have some small > > > >

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread Ilias Apalodimas
Hi Simon, [...] > > [huge snip] > > > > There's things that need to be cleaned up because we have some small > > > > number of platforms that went off and did their own thing. But largely > > > > yes, things make sense to me. We have: > > > > - We embedded the device tree that will configure

[PATCH v5 26/28] x86: efi: Don't use the 64-bit link script for the EFI app

2021-12-04 Thread Simon Glass
That script is not intended for use with EFI, so update the logic to avoid using it. Signed-off-by: Simon Glass --- Changes in v5: - Add new patch to avoid using the 64-bit link script for the EFI app arch/x86/cpu/config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v5 28/28] efi: Build the 64-bit app properly

2021-12-04 Thread Simon Glass
Now that the linker crash is resolved, build the 64-bit EFI app, including all the required code. Signed-off-by: Simon Glass --- Changes in v5: - Add new patch to build the 64-bit app properly - Add various patches to fix up the 64-bit app so that it boots Changes in v2: - Add new patch to

[PATCH v5 20/28] x86: efi: Update efi_get_next_mem_desc() to avoid needing a map

2021-12-04 Thread Simon Glass
At present this function requires a pointer to struct efi_entry_memmap but the only field used in there is the desc_size. We want to be able to use it from the app, so update it to use desc_size directly. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/efi/payload.c | 8

[PATCH v5 24/28] x86: efi: Tweak the code used for the 64-bit EFI app

2021-12-04 Thread Simon Glass
Add an empty CPU init function to avoid fiddling with low-level CPU features in the app. Set up the C runtime correctly for 64-bit use and avoid clearing BSS, since this is done by EFI when U-Boot is loaded. Signed-off-by: Simon Glass --- Changes in v5: - Add new patch to tweak the code used

[PATCH v5 22/28] x86: efi: Show the system-table revision

2021-12-04 Thread Simon Glass
Show the revision of this table as it can be important. Alo update the 'efi table' entry to show the actual address of the EFI table rather than our table that points to it. This saves a step and the intermediate table has nothing else in it. Signed-off-by: Simon Glass --- Changes in v5: - Fix

[PATCH v5 18/28] efi: Show when allocated pages are used

2021-12-04 Thread Simon Glass
Add a message here so that both paths of memory allocation are reported. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Use log_info() instead of printf() lib/efi/efi_app.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/efi/efi_app.c

[PATCH v5 19/28] efi: Allow easy selection of serial-only operation

2021-12-04 Thread Simon Glass
Add info about how to select vidconsole or serial. Also set up a demo boot command. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add a better boot command too include/configs/efi-x86_app.h | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH v5 17/28] efi: Mention that efi_info_get() is only used in the stub

2021-12-04 Thread Simon Glass
This provides access to EFI tables after U-Boot has exited boot services. It is not needed in the app since boot services remain alive and we can just call them whenever needed. Add a comment to explain this. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Fix 'as' typo

[PATCH v5 16/28] efi: Check for failure when initing the app

2021-12-04 Thread Simon Glass
The stub checks for failure with efi_init(). Add this for the app as well. It is unlikely that anything can be done, but we may as well stop. Signed-off-by: Simon Glass --- (no changes since v1) lib/efi/efi_app.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH v5 15/28] efi: Move exit_boot_services into a function

2021-12-04 Thread Simon Glass
At present this code is inline in the app and stub. But they do the same thing. The difference is that the stub does it immediately and the app doesn't want to do it until the end (when it boots a kernel) or not at all, if returning to UEFI. Move it into a function so it can be called as needed.

[PATCH v5 10/28] efi: Drop device_path from struct efi_priv

2021-12-04 Thread Simon Glass
This is not used anywhere drop it. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Move device_path path change to its own patch include/efi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/efi.h b/include/efi.h index 908c5dc6ebd..77e599c256e 100644 ---

[PATCH v5 14/28] efi: Share struct efi_priv between the app and stub code

2021-12-04 Thread Simon Glass
At present each of these has its own static variable and helper functions. Move them into a shared file. Signed-off-by: Simon Glass --- (no changes since v1) include/efi.h | 21 + lib/efi/efi.c | 29 + lib/efi/efi_app.c | 21

[PATCH v5 11/28] efi: Add comments to struct efi_priv

2021-12-04 Thread Simon Glass
This structure is uncommented. Fix it. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Drop comments that confuse sphinx - Move device_path path change to its own patch include/efi.h | 23 +++ 1 file changed, 23 insertions(+) diff --git

[PATCH v5 13/28] efi: Add a few comments to the stub

2021-12-04 Thread Simon Glass
Comment some functions that need more information. Signed-off-by: Simon Glass --- (no changes since v1) lib/efi/efi_stub.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/efi/efi_stub.c b/lib/efi/efi_stub.c index b3393e47fae..156cbf0b928 100644 ---

[PATCH v5 12/28] efi: Fix ll_boot_init() operation with the app

2021-12-04 Thread Simon Glass
This should return false when the EFI app is running, since UEFI has done the required low-level init. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) include/init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/init.h b/include/init.h index

[PATCH v5 09/28] x86: efi: Add room for the binman definition in the dtb

2021-12-04 Thread Simon Glass
At present only 4KB of spare space is left in the DTB when building the EFI app. Increase this to 32KB so there is plenty of space to insert the binman definition. This cannot be expanded later (as with OF_SEPARATE) because the ELF image has already been built. Signed-off-by: Simon Glass ---

[PATCH v5 08/28] x86: Don't process the kernel command line unless enabled

2021-12-04 Thread Simon Glass
If the 'bootm' command is not enabled then this code is not available and this causes a link error. Fix it. Note that for the EFI app, there is no indication of missing code. It just hangs! Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/zimage.c | 13 - 1 file

[PATCH v5 04/28] efi: Locate all block devices in the app

2021-12-04 Thread Simon Glass
When starting the app, locate all block devices and make them available to U-Boot. This allows listing partitions and accessing files in filesystems. EFI also has the concept of 'disks', meaning boot media. For now, this is not obviously useful in U-Boot, but add code to at least locate these.

[PATCH v5 06/28] bloblist: Support allocating the bloblist

2021-12-04 Thread Simon Glass
Typically the bloblist is positioned at a fixed address in memory until relocation. This is convenient when it is set up in SPL or before relocation. But for EFI we want to set it up only when U-Boot proper is running. Add a way to allocate it using malloc() and update the documentation to cover

[PATCH v5 03/28] efi: Add a media/block driver for EFI block devices

2021-12-04 Thread Simon Glass
Add a block driver which handles read/write for EFI block devices. This driver actually already exists ('efi_block') but is not really suitable for use as a real U-Boot driver: - The operations do not provide a udevice - The code is designed for running as part of EFI loader, so uses

[PATCH v5 05/28] efi: serial: Support arrow keys

2021-12-04 Thread Simon Glass
At present only the backspace key is supported in U-Boot, when running as an EFI app. Add support for arrows, home and end as well, to make the CLI more friendly. Signed-off-by: Simon Glass --- (no changes since v1) drivers/serial/serial_efi.c | 11 +-- 1 file changed, 9

[PATCH v5 07/28] x86: Allow booting a kernel from the EFI app

2021-12-04 Thread Simon Glass
At present this is disabled, but it should work so long as the kernel does not need EFI services. Enable it and add a note about remaining work. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Update documentation arch/x86/lib/bootm.c | 11 +++

[PATCH v5 02/28] efi: Add EFI uclass for media

2021-12-04 Thread Simon Glass
At present UCLASS_EFI is used to represent an EFI filesystem among other things. The description of this uclass is "EFI managed devices" which is pretty vague. The only driver that uses this uclass is in fact not a real U-Boot driver, since its operations do not include a struct udevice. Rather

[PATCH v5 01/28] efi: Rename UCLASS_EFI and IF_TYPE_EFI

2021-12-04 Thread Simon Glass
These names are better used for access to devices provided by an EFI layer. Use EFI_LOADER instead here, since these are only available in U-Boot's EFI_LOADER layer. Signed-off-by: Simon Glass --- Changes in v5: - Add new patch to resolve EFI/EFI_LOADER conflict doc/develop/uefi/uefi.rst

[PATCH v5 00/28] efi: Improvements to U-Boot running on top of UEFI

2021-12-04 Thread Simon Glass
At present U-Boot can be built as an EFI app, but it is really just for testing, with very few features. Instead, the payload build is used for booting on top of UEFI, where U-Boot takes over the machine immediately and supplies its own drivers. But the app could be made more useful. This series

Re: [PATCH v4 09/34] efi: Add EFI uclass for media

2021-12-04 Thread Simon Glass
Hi Heinrich, On Sat, 13 Nov 2021 at 02:29, Heinrich Schuchardt wrote: > > > > On 11/8/21 06:29, AKASHI Takahiro wrote: > > On Sun, Nov 07, 2021 at 09:43:22AM -0700, Simon Glass wrote: > >> Hi Heinrich, > >> > >> On Sun, 7 Nov 2021 at 01:21, Heinrich Schuchardt > >> wrote: > >>> > >>> > >>> >

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread Simon Glass
Hi Tom, On Sat, 4 Dec 2021 at 06:52, Tom Rini wrote: > > On Fri, Dec 03, 2021 at 06:01:56PM -0700, Simon Glass wrote: > > [huge snip] > > > There's things that need to be cleaned up because we have some small > > > number of platforms that went off and did their own thing. But largely > > >

Re: Question/issues about i.MX6 DDR configuration

2021-12-04 Thread Fabio Estevam
Hi Francesco, On Fri, Dec 3, 2021 at 5:47 AM Francesco Dolcini wrote: > I think that this applies even with just one chip select, it is just > prescribing a procedure and explicitly saying that it must be done for > all the chip select in use, either 1 or 2. According to the NXP application

Re: [PATCH v6 00/25] fdt: Make OF_BOARD a boolean option

2021-12-04 Thread Tom Rini
On Fri, Dec 03, 2021 at 06:01:56PM -0700, Simon Glass wrote: [huge snip] > > There's things that need to be cleaned up because we have some small > > number of platforms that went off and did their own thing. But largely > > yes, things make sense to me. We have: > > - We embedded the device

Re: [PATCH 0/2] binman: Add support for ATF Firmware Image Package (FIP)

2021-12-04 Thread François Ozog
Hi Simon and Sandrine Le jeu. 2 déc. 2021 à 08:10, Sandrine Bailleux a écrit : > Hi Simon, > > On 12/1/21 5:51 PM, Simon Glass wrote: > > Hi Sandrine, > > > > On Wed, 1 Dec 2021 at 03:32, Sandrine Bailleux > > wrote: > >> > >> Hi everyone, > >> > >> I am Sandrine Bailleux, from the Trusted

Re: [PATCH v6 01/25] doc: Add documentation about devicetree usage

2021-12-04 Thread François Ozog
Hi Simon Le sam. 4 déc. 2021 à 02:02, Simon Glass a écrit : > Hi Heinrich, > > On Fri, 3 Dec 2021 at 13:28, Heinrich Schuchardt > wrote: > > > > On 12/3/21 9:13 PM, Simon Glass wrote: > > > Hi Heinrich, > > > > > > On Fri, 3 Dec 2021 at 06:09, Heinrich Schuchardt > wrote: > > >> > > >> On