Re: [PATCH 1/1] The riscv spec has breaking change from 2.2 to 20191213. ...

2022-09-02 Thread Heinrich Schuchardt
On 8/30/22 01:51, Pan Li wrote: > The riscv spec has breaking change from 2.2 to 20191213. > Both ZICSR and ZIFENCEI are separated extension since 20191213. > Gcc bump up the riscv spec to 20191213 since 12.x. > So add below 4 build option for compatibility:: Hello Pan, thank you for addressing

Re: [PATCH v7 0/8] migrate u-boot-rockchip.bin to binman and generate an image for SPI

2022-09-02 Thread Kever Yang
Hi Quentin, I got below error for SoCs other than rk3399, eg. rk3308, rk3568, rk3328 and etc. +binman: Device tree 'u-boot.dtb' does not have a 'binman' node +make[1]: *** [Makefile:1113: all] Error 1 +make: *** [Makefile:177: sub-make] Error 2 Thanks, - Kever On 2022/9/2 21:10, Quentin

Re: [PATCH 1/5] dm: rtc: Make use of ut_assertnonnull()

2022-09-02 Thread Tom Rini
On Mon, Aug 01, 2022 at 07:58:44AM -0600, Simon Glass wrote: > Use this (newish) macro since it is designed for the purpose of making > sure things are non-NULL. > > Signed-off-by: Simon Glass For the series, applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2] arm: ARMv4 assembly compatibility

2022-09-02 Thread Tom Rini
On Sun, Aug 21, 2022 at 04:34:20PM +0300, Sergei Antonov wrote: > There is currently a problem that U-Boot can not work on ARMv4 > because assembly imlementations of memcpy() and some other functions > use "bx lr" instruction that is not available on ARMv4 ("mov pc, lr" > should be used instead).

Re: [PATCH v4 1/3] cmd: bcb: introduce optional interface parameter to bcb

2022-09-02 Thread Tom Rini
On Mon, Aug 01, 2022 at 11:07:15AM +0300, Andrii Chepurnyi wrote: > From: Andrii Chepurnyi > > From: Andrii Chepurnyi > > Originally, bcb implementation relay on mmc block devices. > The interface parameter will give the ability to use bcb with > various block devices by choosing the exact

Re: [PATCH v4] cmd: Add pause command

2022-09-02 Thread Tom Rini
On Thu, Aug 18, 2022 at 03:44:04PM -0400, Samuel Dionne-Riel wrote: > This command is being introduced with the goal of allowing user-friendly > "generic use case" U-Boot builds to pause until user input under some > situations. > > The main use case would be when a boot failure happens, to

Re: [PATCH] distro_bootcmd: Introduce support for extension command

2022-09-02 Thread Tom Rini
On Tue, Aug 09, 2022 at 06:54:07PM +0300, Matwey V. Kornilov wrote: > Try to load required DTB overlays if the board supports extensions and > CONFIG_CMD_EXTENSION is enabled. > > Signed-off-by: Matwey V. Kornilov Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH v3 2/2] ci: Add a test for a non-LTO build

2022-09-02 Thread Tom Rini
On Wed, Aug 03, 2022 at 12:13:09PM -0600, Simon Glass wrote: > Check that sandbox builds and runs tests OK with LTO disabled. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 1/2] Makefile: Allow LTO to be disabled for a build

2022-09-02 Thread Tom Rini
On Wed, Aug 03, 2022 at 12:13:08PM -0600, Simon Glass wrote: > LTO (Link-Time Optimisation) is an very useful feature which can > significantly reduce the size of U-Boot binaries. So far it has been > made available for selected ARM boards and sandbox. > > However, incremental builds are much

Re: [PATCH v2 4/4] test: cmd: add test for temperature command

2022-09-02 Thread Tom Rini
On Fri, Aug 12, 2022 at 08:15:50PM +0200, Robert Marko wrote: > Add simple test for the temperature command. > > Signed-off-by: Robert Marko > Reviewed-by: Simon Glass > --- > test/cmd/Makefile | 1 + > test/cmd/temperature.c | 39 +++ > 2 files

Re: [PATCH v5] cmd: cat: add new command

2022-09-02 Thread Tom Rini
On Sun, Aug 21, 2022 at 02:54:13PM +, Roger Knecht wrote: > Add cat command to print file content to standard out > > Reviewed-by: Simon Glass > Signed-off-by: Roger Knecht Two problems: https://source.denx.de/u-boot/u-boot/-/jobs/490480 https://source.denx.de/u-boot/u-boot/-/jobs/490473

Re: [PATCH v2 0/8] Enable CONFIG_TIMER for all Kirkwood / MVEBU boards

2022-09-02 Thread Tony Dinh
Hi Stefan, On Thu, Sep 1, 2022 at 11:25 PM Stefan Roese wrote: > > This patchset enhaces the recently added Orion Timer driver to support > all other Kirkwood & 32bit MVEBU Armada platforms. Additionally, this > timer support is then enabled per default for those platforms, so that > the board

Re: [PATCH v2] net: enetc: Fix use after free issue in fsl_enetc.c

2022-09-02 Thread Ramon Fried
On Fri, Sep 2, 2022 at 9:35 AM Siarhei Yasinski wrote: > > If ethernet connected to SFP, like this: > > _port0 { > phy-connection-type = "sgmii"; > sfp = <>; > managed = "in-band-status"; > status = "okay"; > }; > > Then enetc_config_phy returns -ENODEV and memory

Re: [PATCH v2] binman: bintool: remove btool_ prefix from btool names

2022-09-02 Thread Simon Glass
Hi Quentin, On Thu, 1 Sept 2022 at 08:44, Quentin Schulz wrote: > > From: Quentin Schulz > > The binary is looked on the system by the suffix of the packer class. > This means binman was looking for btool_gzip on the system and not gzip. > > Since a btool can have its btool_ prefix missing but

Re: [PATCH 1/1] sandbox: unblock signal before calling execv()

2022-09-02 Thread Simon Glass
On Thu, 1 Sept 2022 at 18:32, Heinrich Schuchardt wrote: > > The following faulty behavior was observed. The sandbox configured with > CONFIG_SANDBOX_CRASH_RESET=y was invoked with > > ./u-boot -T -S > > After executing `exception undefined' the sandbox reboots. > When executing `exception

Re: [PATCH v7 5/8] rockchip: generate u-boot-rockchip.bin with binman for ARM64 boards

2022-09-02 Thread Simon Glass
On Fri, 2 Sept 2022 at 07:11, Quentin Schulz wrote: > > From: Quentin Schulz > > This allows to build u-boot-rockchip.bin binary with binman for Rockchip > ARM64 boards instead of the legacy Makefile way. > > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz > --- > > v7: > - Removed

Re: [PATCH 1/1] efi_selftest: on sandbox use host specific assembly

2022-09-02 Thread Simon Glass
Hi Heinrich, On Thu, 1 Sept 2022 at 19:01, Heinrich Schuchardt wrote: > > The selftest checking the handling of exceptions in UEFI binaries is using > assembly to provide an undefined instruction. On the sandbox the correct > form of the instruction depends on the host architecture. > >

Re: [PATCH 1/1] efi_loader: compliance Simple Text Input Ex Protocol

2022-09-02 Thread Simon Glass
Hi Heinrich, On Thu, 1 Sept 2022 at 18:36, Heinrich Schuchardt wrote: > > > > On 9/2/22 01:52, Simon Glass wrote: > > On Thu, 1 Sept 2022 at 16:07, Heinrich Schuchardt > > wrote: > >> > >> We cannot expect the buffers passed to the input protocols to be zero > >> filled. If only modifier keys

Re: [PATCH] fdt_support: add optional board_rng_seed() hook

2022-09-02 Thread Simon Glass
Hi Rasmus, On Fri, 2 Sept 2022 at 01:00, Rasmus Villemoes wrote: > > On 02/09/2022 01.52, Simon Glass wrote: > > Hi Rasmus, > > > > On Sat, 27 Aug 2022 at 19:52, Simon Glass wrote: > >> > >> Hi Rasmus, > >> > >> On Wed, 24 Aug 2022 at 19:25, Simon Glass wrote: > > >> I'm looking at adding full

Re: [PATCH v1 1/6] watchdog: Integrate watchdog triggering into the cyclic framework

2022-09-02 Thread Simon Glass
Hi Stefan, On Fri, 2 Sept 2022 at 06:11, Stefan Roese wrote: > > This patch integrates the watchdog triggering into the recently added > cyclic infrastructure. Each watchdog device that shall be triggered > registers it's own cyclic function. This way, multiple watchdog devices > are still

Re: [PATCH 4/4] arm: dts: chameleonv3: Add 270-2 variant

2022-09-02 Thread Simon Glass
Hi Paweł, On Fri, 2 Sept 2022 at 07:16, Paweł Anikiel wrote: > > On Tue, Aug 30, 2022 at 5:57 PM Simon Glass wrote: > > > > Hi Paweł, > > > > On Tue, 30 Aug 2022 at 05:51, Paweł Anikiel wrote: > > > > > > On Tue, Aug 30, 2022 at 5:13 AM Alexandru M Stan > > > wrote: > > > > > > > > Hey

Re: [PATCH 1/1] efi_loader: printing UEFI revision in helloworld.efi

2022-09-02 Thread Simon Glass
Hi Heinrich, On Thu, 1 Sept 2022 at 19:09, Heinrich Schuchardt wrote: > > > > On 9/2/22 01:52, Simon Glass wrote: > > Hi Heinrich, > > > > > > On Thu, 1 Sept 2022 at 14:44, Heinrich Schuchardt > > wrote: > >> > >> We need to support multiple digits in the parts of the UEFI verision > >> number.

Re: [PATCH] gpio: renesas: Simplify .request/.rfree callbacks

2022-09-02 Thread Pali Rohár
On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote: > On 02.08.22 12:06, Pali Rohár wrote: > > Remove identify wrapper functions. > > > > Signed-off-by: Pali Rohár > > Reviewed-by: Stefan Roese Any more comments? Or could it be merged? > Thanks, > Stefan > > > --- > >

Re: [PATCH v2] tee: optee: rework TA bus scanning code

2022-09-02 Thread Ilias Apalodimas
Thanks Jens On Wed, 31 Aug 2022 at 08:59, Jens Wiklander wrote: > > On Mon, Aug 29, 2022 at 8:34 AM Ilias Apalodimas > wrote: > > > > Late versions of OP-TEE support a pseudo bus. TAs that behave as > > hardware blocks (e.g TPM, RNG etc) present themselves on a bus which we can > > scan.

[PATCH] doc: socfpga_arria10_qspi_socdk: Document for running SPL/U-Boot on the kit

2022-09-02 Thread sieu . mun . tang
From: Tien Fong Chee This document would describe the steps for building SPL and U-Boot, and showing the proposed layout for the QSPI flash. Signed-off-by: Tien Fong Chee Signed-off-by: Sieu Mun Tang --- doc/README.socfpga_arria10_qspi_socdk | 56 +++ 1 file changed,

Re: [PATCH 3/5] net: tftp: add IPv6 support for tftpboot

2022-09-02 Thread Vyacheslav Mitrofanov V
On Fri, 2022-09-02 at 17:48 +0300, Ramon Fried wrote: > «Внимание! Данное письмо от внешнего адресата!» > > On Mon, Aug 22, 2022 at 9:36 AM Vyacheslav Mitrofanov V > wrote: > > On Fri, 2022-08-19 at 21:01 +0300, Ramon Fried wrote: > > > On Fri, Aug 19, 2022 at 2:30 PM Vyacheslav Mitrofanov V > >

Re: [PATCH] net: enetc: Fix use after free issue in fsl_enetc.c

2022-09-02 Thread Ramon Fried
On Wed, Aug 31, 2022 at 4:49 PM Simon Glass wrote: > > On Wed, 31 Aug 2022 at 05:20, Siarhei Yasinski > wrote: > > > > If ethernet connected to SFP, like this: > > > > _port0 { > > phy-connection-type = "sgmii"; > > sfp = <>; > > managed = "in-band-status"; >

Re: [PATCH 3/5] net: tftp: add IPv6 support for tftpboot

2022-09-02 Thread Ramon Fried
On Mon, Aug 22, 2022 at 9:36 AM Vyacheslav Mitrofanov V wrote: > > On Fri, 2022-08-19 at 21:01 +0300, Ramon Fried wrote: > > > > On Fri, Aug 19, 2022 at 2:30 PM Vyacheslav Mitrofanov V > > wrote: > > > On Fri, 2022-08-19 at 14:00 +0300, Ramon Fried wrote: > > > > On Fri, Aug 19, 2022 at 11:10 AM

[PATCH v15 10/10] test: unit test for eficonfig

2022-09-02 Thread Masahisa Kojima
Provide a unit test for the eficonfig command. Signed-off-by: Masahisa Kojima Acked-by: Ilias Apalodimas --- No update since v15 Changes in v14: - update to support media device enumeration in eficonfig startup - move no block device test to the last test case Changes in v12: - update menu

[PATCH v15 09/10] doc:eficonfig: add documentation for eficonfig command

2022-09-02 Thread Masahisa Kojima
Add documentation for eficonfig command. Signed-off-by: Masahisa Kojima Reviewed-by: Ilias Apalodimas --- No update since v15 Changes in v14: - fix typos Changes in v13: - describe how to auto boot according to the UEFI Boot option Changes in v12: - CONFIG_BOOTMENU_DISABLE_UBOOT_CONSOLE

[PATCH v15 08/10] doc:bootmenu: add description for UEFI boot support

2022-09-02 Thread Masahisa Kojima
The bootmenu enumerates the UEFI boot options for boot device selection. This commit adds the description how the UEFI boot work in bootmenu. This commit also adds "Synopsis", "Description" and "Configuration" sections to follow the U-Boot command documentation format. Signed-off-by: Masahisa

[PATCH v15 07/10] eficonfig: add "Change Boot Order" menu entry

2022-09-02 Thread Masahisa Kojima
This commit adds the menu entry to update UEFI BootOrder variable. User moves the entry with UP/DOWN key, changes the order with PLUS/MINUS key, press SPACE to activate or deactivate the entry, then finalizes the order by ENTER key. If the entry is activated, the boot index is added into the

[PATCH v15 06/10] eficonfig: scan media device in eficonfig startup

2022-09-02 Thread Masahisa Kojima
In eficonfig startup, scan media devices and update the UEFI boot option. Signed-off-by: Masahisa Kojima --- No update since v14 Newly created in v14 cmd/eficonfig.c | 4 1 file changed, 4 insertions(+) diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c index 21d9bd3e23..dda45a8364 100644

[PATCH v15 05/10] bootmenu: add removable media entries

2022-09-02 Thread Masahisa Kojima
UEFI specification requires booting from removal media using a architecture-specific default image name such as BOOTAA64.EFI. This commit adds the removable media entries into bootmenu, so that user can select the removable media and boot with default image. The bootmenu automatically enumerates

[PATCH v15 04/10] eficonfig: add "Delete Boot Option" menu entry

2022-09-02 Thread Masahisa Kojima
This commit adds the menu entry to delete the UEFI boot option. User moves the entry with UP/DOWN key, changes, then presses ENTER key to delete the selected boot option. Signed-off-by: Masahisa Kojima --- No update since v11 Changes in v11: - update function interface to show boot selection

[PATCH v15 03/10] menu: add KEY_PLUS, KEY_MINUS and KEY_SPACE handling

2022-09-02 Thread Masahisa Kojima
This is preparation to support menu-driven UEFI BootOrder variable updated by KEY_PLUS, KEY_MINUS and KEY_SPACE. Signed-off-by: Masahisa Kojima Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- No update since v11 Changes in v11: - add SPACE key handling Newly created in v7

[PATCH v15 01/10] eficonfig: menu-driven addition of UEFI boot option

2022-09-02 Thread Masahisa Kojima
This commit add the "eficonfig" command. The "eficonfig" command implements the menu-driven UEFI boot option maintenance feature. This commit implements the addition of new boot option. User can select the block device volume having efi_simple_file_system_protocol and select the file corresponding

[PATCH v15 02/10] eficonfig: add "Edit Boot Option" menu entry

2022-09-02 Thread Masahisa Kojima
This commit adds the menu entry to edit the existing BOOT variable contents. User selects the item from the boot option list, then user can edit the description, file path and optional_data. Note that automatically generated boot option entry by bootmenu to support the removable media device

[PATCH v15 00/10] enable menu-driven UEFI variable maintenance

2022-09-02 Thread Masahisa Kojima
This series adds the menu-driven UEFI boot variable maintenance through the "eficonfig" new command. This series also adds the removable media support in bootmenu. Source code can be cloned with: $ git clone https://git.linaro.org/people/masahisa.kojima/u-boot.git -b

Re: [PATCH 4/4] arm: dts: chameleonv3: Add 270-2 variant

2022-09-02 Thread Paweł Anikiel
On Tue, Aug 30, 2022 at 5:57 PM Simon Glass wrote: > > Hi Paweł, > > On Tue, 30 Aug 2022 at 05:51, Paweł Anikiel wrote: > > > > On Tue, Aug 30, 2022 at 5:13 AM Alexandru M Stan > > wrote: > > > > > > Hey Simon, > > > > > > On Mon, Aug 29, 2022 at 7:29 PM Simon Glass wrote: > > > > > > > > Hi

[PATCH v7 8/8] rockchip: add u-boot-rockchip-spi.bin image for booting from SPI-NOR flash

2022-09-02 Thread Quentin Schulz
From: Quentin Schulz This new image is similar to u-boot-rockchip.bin except that it's destined to be flashed on SPI-NOR flashes. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Reviewed-by: Simon Glass --- v6: - added Rb, v3: - added filename property so that

[PATCH v7 7/8] rockchip: allow to build SPI images even without HAS_ROM option

2022-09-02 Thread Quentin Schulz
From: Quentin Schulz This prepares for the creation of a u-boot-rockchip-spi.bin image similar to u-boot-rockchip.bin to the exception it's destined for SPI-NOR flashes instead of MMC storage medium. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Simon Glass Reviewed-by: Kever

[PATCH v7 6/8] rockchip: simplify binman image dependencies addition to INPUTS

2022-09-02 Thread Quentin Schulz
From: Quentin Schulz By factoring SPL check in the first condition, this makes the checks a bit less convoluted and more readable. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Reviewed-by: Simon Glass --- v6: - added Rb, v4: - fixed wrong place for endif for

[PATCH v7 5/8] rockchip: generate u-boot-rockchip.bin with binman for ARM64 boards

2022-09-02 Thread Quentin Schulz
From: Quentin Schulz This allows to build u-boot-rockchip.bin binary with binman for Rockchip ARM64 boards instead of the legacy Makefile way. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- v7: - Removed reviewed-by, - added missing includes for rockchip-u-boot.dtsi so that binman

[PATCH v7 4/8] rockchip: generate idbloader.img content for u-boot-rockchip.bin with binman for ARM

2022-09-02 Thread Quentin Schulz
From: Quentin Schulz idbloader.img content - currently created by way of Makefile - can be created by binman directly. So let's do that for Rockchip ARM platforms. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Simon Glass Reviewed-by: Kever Yang --- v6: - added Rb, v4:

[PATCH v7 3/8] rockchip: remove binman temporary files when cleaning

2022-09-02 Thread Quentin Schulz
From: Quentin Schulz Binman mkimage entry generates temporary files so let's remove them when calling `make clean`. Fixes: 9b312e26fc77 ("rockchip: Enable building a SPI ROM image on jerry") Cc: Quentin Schulz Reported-by: Johan Jonker Signed-off-by: Quentin Schulz Reviewed-by: Simon Glass

[PATCH v7 2/8] binman: allow user-defined filenames for mkimage entry

2022-09-02 Thread Quentin Schulz
From: Quentin Schulz mkimage entry currently creates a file whose name is derived from the section name containing said entry. Let's allow the user to define a filename for the mkimage-generated binary by using the 'filename' DT property. Cc: Quentin Schulz Signed-off-by: Quentin Schulz

[PATCH v7 1/8] binman: add support for skipping file concatenation for mkimage

2022-09-02 Thread Quentin Schulz
From: Quentin Schulz Some image types handled by mkimage require the datafiles to be passed independently (-d data1:data2) for specific handling of each. A concatenation of datafiles prior to passing them to mkimage wouldn't work. That is the case for rkspi for example which requires page

[PATCH v7 0/8] migrate u-boot-rockchip.bin to binman and generate an image for SPI

2022-09-02 Thread Quentin Schulz
From: Quentin Schulz This migrates the generation of u-boot-rockchip.bin from Makefile to binman completely. This also adds support for generating the same kind of image than u-boot-rockchip.bin but for SPI flashes (specifically, a different image type generated by mkimage is necessary, in

Re: [PATCH v6 3/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL

2022-09-02 Thread Tom Rini
On Wed, Aug 17, 2022 at 03:07:14PM +0200, Philip Oberfichtner wrote: > From: Marek Vasut > > Enable d-cache early in SPL right after DRAM is started up. > This reduces U-Boot proper load time by 650ms when loaded > from SPI NOR. > > Signed-off-by: Marek Vasut > Signed-off-by: Philip

Re: [PATCH v6 2/3] ARM: cache: Allow SPL to build cache-pl310.c

2022-09-02 Thread Tom Rini
On Wed, Aug 17, 2022 at 03:07:13PM +0200, Philip Oberfichtner wrote: > Introduce the new Kconfig symbol CONFIG_SPL_SYS_L2_PL310 to allow the > SPL to build cache-pl310.c. > > Before this commit, the SPL could enable the PL310 L2 cache [1], but the > cache maintenance functions from cache-pl310.c

Re: [PATCH v6 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-09-02 Thread Tom Rini
On Wed, Aug 17, 2022 at 03:07:12PM +0200, Philip Oberfichtner wrote: > This converts CONFIG_SYS_L2_PL310 to Kconfig. > > For omap2 and mvebu the 'select SYS_L2_PL310' locations were > determined using ./tools/moveconfig -i CONFIG_SYS_L2_PL310. > > For mx6 I manually chose ARCH_MX6 as 'select'

Re: [PATCH 2/2] Remove CONFIG_SYS_I2C_EEPROM_PAGE_WRITE_BITS et al

2022-09-02 Thread Tom Rini
On Wed, Aug 10, 2022 at 10:29:28AM -0400, Tom Rini wrote: > This removes the following symbols: >CONFIG_SYS_I2C_EEPROM_PAGE_WRITE_BITS >CONFIG_SYS_I2C_EEPROM_PAGE_WRITE_DELAY_MS >CONFIG_SYS_I2C_LDI_ADDR >CONFIG_SYS_I2C_DVI_ADDR >CONFIG_SYS_I2C_DVI_BUS_NUM > > They are unused

Re: [PATCH 1/2] Convert CONFIG_SYS_I2C_EEPROM_CCID et al to Kconfig

2022-09-02 Thread Tom Rini
On Wed, Aug 10, 2022 at 10:29:27AM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_SYS_I2C_EEPROM_CCID >CONFIG_SYS_I2C_EEPROM_NXID >CONFIG_SYS_EEPROM_BUS_NUM > > Signed-off-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description:

[PATCH v1 3/6] cyclic: Use schedule() instead of WATCHDOG_RESET()

2022-09-02 Thread Stefan Roese
Globally replace all occurances of WATCHDOG_RESET() with schedule(), which handles the HW_WATCHDOG functionality and the cyclic infrastructure. Signed-off-by: Stefan Roese Reviewed-by: Simon Glass --- v1: - Add Simon's SoB tag arch/arm/mach-at91/phy.c | 2 +-

[PATCH v1 6/6] watchdog: Further cleanup

2022-09-02 Thread Stefan Roese
Remove some now unused macros and #ifdef's. Signed-off-by: Stefan Roese Reviewed-by: Simon Glass --- v1: - Add Simon's SoB tag include/watchdog.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/watchdog.h b/include/watchdog.h index 91506d3327a8..ac5f11e376fa

[PATCH v1 4/6] watchdog: Get rid of ASSEMBLY hacks

2022-09-02 Thread Stefan Roese
Only one occurance of WATCHDOG_RESET is left in one assembler file. This patch changes this occurance to a direct call to watchdog_reset and then removes all the ASSEMBLY ifdef'ery in watchdog.h, as it's not needed any more to clean this mess a bit up. Signed-off-by: Stefan Roese --- v1: - No

[PATCH v1 5/6] watchdog: Remove WATCHDOG_RESET macro

2022-09-02 Thread Stefan Roese
Now that we've globally replaced all WATCHDOG_RESET occurances, let's remove the ugly macro itself in the header. Signed-off-by: Stefan Roese Reviewed-by: Simon Glass --- v1: - Add Simon's SoB tag include/watchdog.h | 36 1 file changed, 36 deletions(-)

[PATCH v1 2/6] cyclic: Introduce schedule() function

2022-09-02 Thread Stefan Roese
This patch introduces a schedule() function, which shall be used instead of the old WATCHDOG_RESET. Follow-up patches will make sure, that this new function is used. Signed-off-by: Stefan Roese Reviewed-by: Simon Glass --- v1: - Add Simon's SoB tag - Add more comments in the header to fully

[PATCH v1 0/6] Migrate watchdog reset to cyclic infrastructure

2022-09-02 Thread Stefan Roese
This patchset migrates the watchdog triggering (WATCHDOG_RESET calls) to the newly introduced cyclic execution framework. For this, the watchdog driver now registers a cyclic execution function for each WDT device that needs to get serviced. Additionally the cyclic IF is a bit extended to also

[PATCH v1 1/6] watchdog: Integrate watchdog triggering into the cyclic framework

2022-09-02 Thread Stefan Roese
This patch integrates the watchdog triggering into the recently added cyclic infrastructure. Each watchdog device that shall be triggered registers it's own cyclic function. This way, multiple watchdog devices are still supported, each via a cyclic function with separate trigger intervals.

[PATCH v6 8/8] cyclic: Add a simple test

2022-09-02 Thread Stefan Roese
Add a test for cyclic function registration and activation. Signed-off-by: Stefan Roese Reviewed-by: Simon Glass --- v6: - No change v5: - Set 'cyclic_active' to false before registering the test - Use WATCHDOG_RESET() instead of mdelay() - Use COMMON_TEST() - Added Simon's RB tag v4: - New

[PATCH v6 7/8] cyclic: Add documentation

2022-09-02 Thread Stefan Roese
Add documentation for the cyclic function infrastructure, including the cyclic command. Signed-off-by: Stefan Roese Reviewed-by: Simon Glass --- v6: - No change v5: - No change v4: - Minor spelling fix - Added Simon's RB tag v3: - New patch doc/develop/cyclic.rst | 50

[PATCH v6 2/8] cyclic: Add basic support for cyclic function execution infrastruture

2022-09-02 Thread Stefan Roese
Add the basic infrastructure to periodically execute code, e.g. all 100ms. Examples for such functions might be LED blinking etc. The functions that are hooked into this cyclic list should be small timewise as otherwise the execution of the other code that relies on a high frequent polling (e.g.

[PATCH v6 5/8] cyclic: Add 'cyclic list' and 'cyclic demo' commands

2022-09-02 Thread Stefan Roese
This patch adds the cyclic command, which currently only supports the 'list' subcommand, to list all currently registered cyclic functions. Here an example: => cyclic list function: cyclic_demo, cpu-time: 7010 us, frequency: 99.80 times/s function: cyclic_demo2, cpu-time: 1 us, frequency: 1.13

[PATCH v6 3/8] cyclic: Integrate cyclic infrastructure into WATCHDOG_RESET

2022-09-02 Thread Stefan Roese
This patch integrates the main function responsible for calling all registered cyclic functions cyclic_run() into the common WATCHDOG_RESET macro. This guarantees that cyclic_run() is executed very often, which is necessary for the cyclic functions to get scheduled and executed at their configured

[PATCH v6 4/8] cyclic: Integrate cyclic functionality at bootup in board_r/f

2022-09-02 Thread Stefan Roese
This patch adds a call to cyclic_init() to board_f/r.c, enabling the common cyclic infrastructure. After this it's possible to add cyclic functions via cyclic_register(). Signed-off-by: Stefan Roese Reviewed-by: Simon Glass --- v6: - Move cyclic_init() in board_r.c after initr_malloc, as we now

[PATCH v6 6/8] mips: octeon_nic23: Add PCIe FLR fixup via cyclic infrastructure

2022-09-02 Thread Stefan Roese
From: Aaron Williams This patch adds a fixup function related to a PCIe FLR (Function Level Reset) problem on the NIC23 PCIe board. This function is imported from the Marvell Octeon 2013 U-Boot version as a (nearly) verbatim copy. It uses the newly introduced cyclic infrastructure, so that this

[PATCH v6 0/8] Add support for cyclic function execution infrastruture

2022-09-02 Thread Stefan Roese
This patchset adds the basic infrastructure to periodically execute code, e.g. all 100ms. Examples for such functions might be LED blinking etc. The functions that are hooked into this cyclic list should be small timewise as otherwise the execution of the other code that relies on a high frequent

[PATCH v6 1/8] time: Import time_after64() and friends from Linux

2022-09-02 Thread Stefan Roese
When using us times it makes sense to use 64bit variables for storage. The currently implemented time_after() and friends functions only handle 32bit variables. This patch now includes the 64bit variants as well from Linux. This will be used by the upcoming generic cyclic function infrastructure.

Re: [PATCH] ddr: socfpga: Fix integer overflow

2022-09-02 Thread Marek Vasut
On 8/30/22 08:42, Jit Loon Lim wrote: From: Tien Fong Chee dramaddrw data structure are defined as u32. Compiler assume 32-bit arithmetic on expression and the shifting operation to be done on a 32-bit value. So, the expression would overflow if the shifting is more than 32-bit.

[PATCH 4/4] configs: roc-pc-rk3399:Set the maximum slave SPI speed to 30MHz

2022-09-02 Thread Manoj Sai
-While the SPI controller speed is defined by DTS, the maximum slave speed (connected devices) is limited by the pre-defined configuration value CONFIG_SF_DEFAULT_SPEED from 10 MHz to 30Mhz. -set the Value of SPI flash max frequency for environment to 30Mhz. This patch increases this maximum SPI

[PATCH 3/4] configs:roc-pc-rk3399 :Enable crypto RNG support

2022-09-02 Thread Manoj Sai
enable crypto RNG support for roc-pc-rk3399. Signed-off-by: Manoj Sai Signed-off-by: Da Xue Signed-off-by: dsx724

[PATCH 2/4] configs: roc-pc-rk3399:fix up USB support

2022-09-02 Thread Manoj Sai
- Fix up USB config options so keyboards and other USB devices work . - Update the number of ports of the Usb root hub to configuration of CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS . USB device tree: 1 Hub (12 Mb/s, 0mA) U-Boot Root Hub 1 Hub (12 Mb/s, 0mA) | U-Boot Root Hub | +-2

[PATCH 1/4] configs:roc-pc-rk3399 :Enable CONFIG_USE_PREBOOT

2022-09-02 Thread Manoj Sai
use preboot configuration to enable usb devices Signed-off-by: Manoj Sai Signed-off-by: Da Xue --- configs/roc-pc-rk3399_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/roc-pc-rk3399_defconfig b/configs/roc-pc-rk3399_defconfig index 4625e47537..84e82da3cf 100644 ---

[PATCH 0/4] addition of configs for rockchip based roc-pc-rk3399 board

2022-09-02 Thread Manoj Sai
Patch 1/4 use preboot configuration to enable usb devices Patch 2/4 fix up USB support which can recognize any USB1.1 devices Patch 3/4 Enable crypto RNG support Patch 4/4 Set the maximum slave SPI speed to 30MHz Manoj Sai (4): configs: roc-pc-rk3399 :Enable preboot config . configs:

[PATCH] distro_bootcmd: Always check for custom boot scripts first

2022-09-02 Thread Andrey Skvortsov
If extlinux.conf is used, then it's not possible to customize boot environment, because scripts are not loaded. Usually it's possible to make some changes manually using command line and save boot environment. But if exlinux.conf is loaded from ext4 partition (for example on PinePhone), then

Re: [RFC PATCH 1/1] net: xilinx: handle internal PHY/PCS

2022-09-02 Thread Nikita Shubin
Hello Harini! Sorry for long response time. On Wed, 24 Aug 2022 12:51:08 + "Katakam, Harini" wrote: > Hi Nikita, > > > -Original Message- > > From: Simek, Michal > > Sent: Thursday, August 11, 2022 1:16 PM > > To: Nikita Shubin ; Agarwal, Swati > > ; Pandey, Radhey Shyam > > >

[PATCH v3] spl: introduce SPL_XIP to config

2022-09-02 Thread Nikita Shubin
From: Nikita Shubin U-Boot and SPL don't necessary share the same location, so we might end with U-Boot SPL in read-only memory (XIP) and U-Boot in read-write memory. In case of non XIP boot mode, we rely on such variables as "hart_lottery" and "available_harts_lock" which we use as atomics.

Re: [PATCH v2] spl: introduce SPL_XIP to config

2022-09-02 Thread Nikita Shubin
On Fri, 2 Sep 2022 15:25:06 +0800 Rick Chen wrote: Hello Rick! > Hi Nikita, > > > From: Nikita Shubin > > Sent: Wednesday, August 31, 2022 3:25 PM > > To: u-boot@lists.denx.de > > Cc: li...@yadro.com; Nikita Shubin ; Rick > > Jian-Zhi Chen(陳建志) ; Leo Yu-Chi > > Liang(梁育齊) ; Simon Glass > > ;

Re: [PATCH] RockPi4: Add UEFI capsule update support

2022-09-02 Thread Sughosh Ganu
hi Kever, On Wed, 29 Jun 2022 at 09:11, Kever Yang wrote: > > Hi Sughosh, > > Thanks for your patch. > > On 2022/5/16 14:12, Sughosh Ganu wrote: > > hi Peter, > > > > On Sat, 14 May 2022 at 13:44, Peter Robinson wrote: > >> On Fri, May 13, 2022 at 7:50 AM Sughosh Ganu > >> wrote: > >>>

Re: [PATCH v2 1/8] timer: orion-timer: Use timer_conv_64() to fix timer wrap around

2022-09-02 Thread Stefan Roese
On 02.09.22 09:44, Michael Walle wrote: Am 2022-09-02 08:25, schrieb Stefan Roese: While testing on some Kirkwood platforms it was noticed that the timer did not function correctly all the time. The driver did not correctly handle 32bit timer value wrap arounds. Using the timer_conv_64()

Re: [RFC PATCH 8/8] WIP: .azure-pipelines.yml: Remove evb-ast2600

2022-09-02 Thread Stefan Roese
Hi Joel, On 02.09.22 08:14, Stefan Roese wrote: Hi Joel, On 02.09.22 08:00, Joel Stanley wrote: On Fri, 2 Sept 2022 at 04:09, Joel Stanley wrote: On Mon, 29 Aug 2022 at 06:23, Stefan Roese wrote: The evb-ast2600 target always runs into an timeout error when run via Azure CI. For test

Re: [PATCH v2 1/8] timer: orion-timer: Use timer_conv_64() to fix timer wrap around

2022-09-02 Thread Michael Walle
Am 2022-09-02 08:25, schrieb Stefan Roese: While testing on some Kirkwood platforms it was noticed that the timer did not function correctly all the time. The driver did not correctly handle 32bit timer value wrap arounds. Using the timer_conv_64() conversion function fixes this issue. Fixes:

[PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment

2022-09-02 Thread Sergei Antonov
Get rid of discrepancy beween comment /* 250 ms */ and code which shifts by 4 thus dividing by 16. So change code to shift by 2 and make the timeout value 250 ms. Signed-off-by: Sergei Antonov --- drivers/mmc/ftsdc010_mci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] spl: introduce SPL_XIP to config

2022-09-02 Thread Rick Chen
Hi Nikita, > From: Nikita Shubin > Sent: Wednesday, August 31, 2022 3:25 PM > To: u-boot@lists.denx.de > Cc: li...@yadro.com; Nikita Shubin ; Rick Jian-Zhi > Chen(陳建志) ; Leo Yu-Chi Liang(梁育齊) > ; Simon Glass ; Bin Meng > ; Heinrich Schuchardt ; Ilias > Apalodimas ; Alexandru Gagniuc > ;

Re: [PATCH] fdt_support: add optional board_rng_seed() hook

2022-09-02 Thread Rasmus Villemoes
On 02/09/2022 01.52, Simon Glass wrote: > Hi Rasmus, > > On Sat, 27 Aug 2022 at 19:52, Simon Glass wrote: >> >> Hi Rasmus, >> >> On Wed, 24 Aug 2022 at 19:25, Simon Glass wrote: >> I'm looking at adding full support to ofnode for reading/writing any >> tree, not just the control FDT. I should

[PATCH v3] net: enetc: Fix use after free issue in fsl_enetc.c

2022-09-02 Thread Siarhei Yasinski
If ethernet connected to SFP, like this: _port0 { phy-connection-type = "sgmii"; sfp = <>; managed = "in-band-status"; status = "okay"; }; Then enetc_config_phy returns -ENODEV and memory containing mdio interface is freeing. It's better to unregister and free

[PATCH] misc: fs_loader: Add QSPI RAW partition loading support

2022-09-02 Thread Jit Loon Lim
From: Tien Fong Chee Enhanced the generic firmware loader to support QSPI RAW partition loading. This would enable FPGA configuration bitstream loading from QSPI RAW partition to program FPGA. Signed-off-by: Tien Fong Chee Signed-off-by: Jit Loon Lim --- drivers/misc/fs_loader.c | 92

Re: [PATCH v2 03/28] tools: rkcommon: Correct SPL size for px30

2022-09-02 Thread Jagan Teki
On Fri, 2 Sept 2022 at 08:36, Kever Yang wrote: > > > On 2022/8/18 22:52, Jagan Teki wrote: > > Rockchip PX30 has 16KB sram, bootrom reserved 4KB as stack. > > NAK, the origin code is correct, do not modify this. SPL size increment due to updating high row detection code - so patch indeed that

[PATCH v2] net: enetc: Fix use after free issue in fsl_enetc.c

2022-09-02 Thread Siarhei Yasinski
If ethernet connected to SFP, like this: _port0 { phy-connection-type = "sgmii"; sfp = <>; managed = "in-band-status"; status = "okay"; }; Then enetc_config_phy returns -ENODEV and memory containing mdio interface is freeing. It's better to unregister and free

[PATCH v2 8/8] kirkwood: lsxl: Sync defconfigs

2022-09-02 Thread Stefan Roese
With the recent changes in the Orion timer driver Kconfig setup, the board specific enabling is not needed any more. This patch sync's these 2 boards with their current defconfig version. Signed-off-by: Stefan Roese Cc: Michael Walle --- v2: - New patch configs/lschlv2_defconfig | 3 ---

[PATCH v2 7/8] arm: mvebu: dts: mvebu-u-boot.dtsi: Add "u-boot, dm-pre-reloc" to timer DT node

2022-09-02 Thread Stefan Roese
Adding the "u-boot,dm-pre-reloc" DT property to the timer node is necesssary to support the timer in the early boot phases (e.g. SPL & pre-reloc). Signed-off-by: Stefan Roese --- v2: - No change arch/arm/dts/mvebu-u-boot.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH v2 6/8] arm: mvebu: dts: armada-375.dtsi: Add timer0 & timer1

2022-09-02 Thread Stefan Roese
Add the DT bindings / descriptions for timer0 & timer1, exactly as done in mainline Linux. Signed-off-by: Stefan Roese --- v2: - No change arch/arm/dts/armada-375.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/armada-375.dtsi

[PATCH v2 3/8] timer: orion-timer: Add timer_get_boot_us() for BOOTSTAGE support

2022-09-02 Thread Stefan Roese
Add timer_get_boot_us() to support boards, that have CONFIG_BOOTSTAGE enabled, like pogo_v4. Signed-off-by: Stefan Roese --- v2: - Change timer_get_boot_us() to use the timer_early functions - Remove #if CONFIG_IS_ENABLED(BOOTSTAGE) Simon, I'm currently looking into this timer_get_boot_us() to

[PATCH v2 2/8] timer: orion-timer: Add support for other Armada SoC's

2022-09-02 Thread Stefan Roese
This patch adds support for other Marvell Armada SoC's, supporting the 25MHz fixed clock operation, like the Armada XP etc. Signed-off-by: Stefan Roese --- v2: - Use timer_conv_64() in timer_early_get_count() drivers/timer/Kconfig | 5 - drivers/timer/orion-timer.c | 42

[PATCH v2 4/8] arm: mvebu: Use CONFIG_TIMER on all MVEBU & KIRKWOOD platforms

2022-09-02 Thread Stefan Roese
Now that the new timer support is available for these platforms, let's select this IF for all these platforms. This way it's not necessary that each board changes it's config header. Signed-off-by: Stefan Roese --- v2: - No change arch/arm/Kconfig | 4

[PATCH v2 5/8] arm: mvebu: dts: Makefile: Compile Armada 375 dtb in a separate step

2022-09-02 Thread Stefan Roese
This patch changes the compilation, so that the Armada 375 board(s) are compiled in a separate step. This is necessary for the timer dts conversion, as A375 has a different / timer description in the dts. Signed-off-by: Stefan Roese --- v2: - No change arch/arm/dts/Makefile | 6 +- 1 file

[PATCH v2 1/8] timer: orion-timer: Use timer_conv_64() to fix timer wrap around

2022-09-02 Thread Stefan Roese
While testing on some Kirkwood platforms it was noticed that the timer did not function correctly all the time. The driver did not correctly handle 32bit timer value wrap arounds. Using the timer_conv_64() conversion function fixes this issue. Suggested-by: Stefan Herbrechtsmeier Signed-off-by:

[PATCH v2 0/8] Enable CONFIG_TIMER for all Kirkwood / MVEBU boards

2022-09-02 Thread Stefan Roese
This patchset enhaces the recently added Orion Timer driver to support all other Kirkwood & 32bit MVEBU Armada platforms. Additionally, this timer support is then enabled per default for those platforms, so that the board config files don't need to be changed. Also necessary is some dts hacking,

  1   2   >