Re: [PATCH 1/1] efi_loader: remove duplicate assignment

2023-04-02 Thread Ilias Apalodimas
On Sun, 2 Apr 2023 at 05:38, Simon Glass wrote: > > On Sat, 1 Apr 2023 at 18:31, Heinrich Schuchardt > wrote: > > > > Assigning the value of a variable to itself should be avoided. > > > > Addresses-Coverity-ID: 451089 ("Evaluation order violation") > > Fixes: 180b7118bed8 ("efi_loader: fix

Re: [PATCH 1/1] cmd: missing break in test_write_limit()

2023-04-02 Thread Ilias Apalodimas
On Sun, 2 Apr 2023 at 21:45, Simon Glass wrote: > > On Sun, 2 Apr 2023 at 16:51, Heinrich Schuchardt > wrote: > > > > In test_write_limit() an unintended fall-through occurs. > > > > Suggested-by: Simon Glass > > Signed-off-by: Heinrich Schuchardt > > --- > > cmd/tpm_test.c | 1 + > > 1 file

Re: [PATCH v2 1/1] MAINTAINERS: assign include/tpm*, cmd/tpm*

2023-04-02 Thread Ilias Apalodimas
On Sun, 2 Apr 2023 at 21:45, Simon Glass wrote: > > On Sun, 2 Apr 2023 at 16:51, Heinrich Schuchardt > wrote: > > > > The files include/tpm* are an integral part of the TPM drivers. > > The tpm* commands are used to access TPM devices. > > > > Both should be managed by the TPM DRIVERS

[PATCH] ddr: marvell: a38x: Perform DDR training sequence again for 2nd boot

2023-04-02 Thread Tony Dinh
- DDR Training sequence happens very fast. The speedup in boot time is negligible by skipping the training sequence during 2nd boot or after. So remove the check and skip. - This change improves the robustness of DDR training. If u-boot crashed during DDR training, the training could be left in a

Re: [PATCH v2] disk: Use a helper function to reduce duplication

2023-04-02 Thread Simon Glass
Hi, On Mon, 3 Apr 2023, 12:06 AKASHI Takahiro, wrote: > Hi Tom, > > On Fri, Mar 31, 2023 at 10:17:03AM -0400, Tom Rini wrote: > > On Mon, Mar 20, 2023 at 08:29:57AM +1300, Simon Glass wrote: > > > > > Reduce the duplicated code slightly by using a helper function to > handle > > > the common

Re: [PATCH v2] disk: Use a helper function to reduce duplication

2023-04-02 Thread AKASHI Takahiro
Hi Tom, On Fri, Mar 31, 2023 at 10:17:03AM -0400, Tom Rini wrote: > On Mon, Mar 20, 2023 at 08:29:57AM +1300, Simon Glass wrote: > > > Reduce the duplicated code slightly by using a helper function to handle > > the common code. > > > > This reduces the code size very slightly. > > > >

[PATCH v2 2/5] arm: dts: sync am62ax dtbs with linux v6.3-rc4

2023-04-02 Thread Bryan Brattlof
To enable Ethernet support at the uboot level, pull the device tree files from the v6.3-rc4 version of the Linux kernel. Signed-off-by: Bryan Brattlof --- arch/arm/dts/k3-am62a-main.dtsi | 365 ++ arch/arm/dts/k3-am62a-mcu.dtsi| 51 +

[PATCH v2 1/5] dma: ti: k3-udma: Introduce DMA support for the am62ax

2023-04-02 Thread Bryan Brattlof
From: Vignesh Raghavendra In preparation for enabling ethernet for the am62ax family of SoCs, introduce the initial DMA channel settings for the am62ax Signed-off-by: Vignesh Raghavendra [b...@ti.com: expanded on commit message] Signed-off-by: Bryan Brattlof --- drivers/dma/ti/Makefile

[PATCH v2 0/5] enable DMA and CPSW nodes for am62ax SoC family

2023-04-02 Thread Bryan Brattlof
Hello again everyone! This patch series syncs TI's am62ax device tree files with what has been merged in the v6.3-rc4 of the Linux Kernel. This series will also enable YMODEM support to make automated testing (which uses the UART boot method to load the bootloaders) Thanks for reviewing ~Bryan

[PATCH v2 3/5] arm: dts: add DMA and CPSW nodes for uboot

2023-04-02 Thread Bryan Brattlof
Update the uboot dtsi to enable DMA and CPSW at the uboot level Signed-off-by: Bryan Brattlof --- arch/arm/dts/k3-am62a7-r5-sk.dts | 8 arch/arm/dts/k3-am62a7-sk-u-boot.dtsi | 26 +- 2 files changed, 33 insertions(+), 1 deletion(-) diff --git

[PATCH v2 5/5] configs: am62ax: enable ymodem support for a53 spl

2023-04-02 Thread Bryan Brattlof
Automated testing inside TI currently relies on loading the boot-loaders into the SoC via UART. Enable SPL_YMODEM_SUPPORT so our testing infrastructure can boot (and test) our boards. Fixes: 719bd650c30e8 ("configs: introduce configs for the am62a") Signed-off-by: Bryan Brattlof ---

[PATCH v2 4/5] configs: enable net features for am62ax

2023-04-02 Thread Bryan Brattlof
Enable DMA and CPSW options we now support for the am62ax SoC family Signed-off-by: Bryan Brattlof --- configs/am62ax_evm_a53_defconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configs/am62ax_evm_a53_defconfig b/configs/am62ax_evm_a53_defconfig index

Please pull u-boot-dm/next

2023-04-02 Thread Simon Glass
Hi Tom, This is for the -next branch. https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/15866 The following changes since commit 942ac73afc37fb98695af4489ea1549c21615a5e: Merge tag 'u-boot-imx-next-20230331' of https://gitlab.denx.de/u-boot/custodians/u-boot-imx into next

Re: [PATCH v3] cmd: fdt: Use env_set_hex() for "get addr" and "get size"

2023-04-02 Thread Simon Glass
On Sat, 11 Mar 2023 at 09:29, Marek Vasut wrote: > > The 'fdt get addr' and 'env get size' is always assumed to be hex > value, drop the prefix, and outright switch to env_set_hex(). Since > this might break existing users who depend on the existing behavior > with 0x prefix, this is a separate

Re: [PATCH v2] fdt: Make fdt addr -q quieter

2023-04-02 Thread Simon Glass
On Wed, 22 Mar 2023 at 04:19, Marek Vasut wrote: > > On 3/21/23 14:01, Peter Hoyes wrote: > > From: Peter Hoyes > > > > 64597346 "fdt: Add -q option to fdt addr for distro_bootcmd" introduced > > the -q option for fdt addr, which sets the current working fdt address > > without printing any

Re: [PATCH] pinctrl: fix pinctrl_gpio_get_pinctrl_and_offset for gpio-ranges array

2023-04-02 Thread Simon Glass
From: Quanyang Wang Sometimes a multi-element array is used for "gpio-ranges" property in dts file: qe_pio_e: gpio-controller@1460 { .. gpio-ranges = < 0 20 10>, < 10 50 20>; .. }; But the function pinctrl_gpio_get_pinctrl_and_offset can't handle this

Re: [PATCH] doc: sandbox: replace sgdisk input with options

2023-04-02 Thread Simon Glass
The input provided to sgdisk is in fact aimed for sfdisk. The use of sgdisk and sfdisk, coming from different projects, is not the same. So, this commit translates the sfdisk-formatted input into sgdisk-compatible options. Partitions are not modified. Signed-off-by: Corentin Guillevic ---

Re: [PATCH v2 1/4] sandbox: Update the VBE firmware location

2023-04-02 Thread Simon Glass
The image size was increased but the firmware-update part was not updated. Correct this so that VBE firmware update can succeed with sandbox_vpl. Signed-off-by: Simon Glass Fixes: 85c66dc95c2 ("sandbox: Expand size for VPL image") --- Changes in v2: - Add new patch to update the VBE firmware

Re: [PATCH v2 2/4] vbe: Use the correct image filename in the test

2023-04-02 Thread Simon Glass
At present this inadvertently relies on having a symlink to the correct file from the current directory. Use the correct path to fix this. Signed-off-by: Simon Glass --- (no changes since v1) test/py/tests/test_vbe_vpl.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Applied to

Re: [PATCH v2 3/4] CI: Ensure that vpl test is run

2023-04-02 Thread Simon Glass
This is actually skipped at present due to the condition in the file. Fix this by running all vpl tests. Signed-off-by: Simon Glass --- (no changes since v1) .azure-pipelines.yml | 2 +- .gitlab-ci.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm/next,

Re: [PATCH v2 4/4] test: Run the VPL tests with 'make check'

2023-04-02 Thread Simon Glass
Update the script to run VPL tests as well as the others. Signed-off-by: Simon Glass --- (no changes since v1) test/run | 5 + 1 file changed, 5 insertions(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH 3/5] arm: dts: add DMA and CPSW nodes for uboot

2023-04-02 Thread Bryan Brattlof
Hi Ravi! On March 31, 2023 thus sayeth Ravi Gunasekaran: > Hi Bryan, > > On 28/03/23 12:10 am, Bryan Brattlof wrote: > > Update the uboot dtsi to enable DMA and CPSW at the uboot level > > > > Signed-off-by: Bryan Brattlof > > --- > > arch/arm/dts/k3-am62a7-r5-sk.dts | 8 > >

[PATCH v2] netconsole: various improvements

2023-04-02 Thread Tony Dinh
Use CONFIG_CONSOLE_MUX for netconsole. When netconsole is running, stdin/stdout/stder must be set to some primary console, in addtion to nc. For example, stdin=serial,nc. Some recent Linux kernels will not boot with only nc on the stdout list, ie. stdout=nc. When netconsole exits, remove nc from

[PATCH v2 2/3] rpi: Disable DISTRO_DEFAULTS

2023-04-02 Thread Simon Glass
Disable this option to reclaim some space, since bootstd requires less functionality to operate (e.g. hush parser). Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to disable DISTRO_DEFAULTS configs/rpi_0_w_defconfig | 1 - configs/rpi_2_defconfig| 1 -

[PATCH v2 1/3] arm: rpi: Switch to standard boot

2023-04-02 Thread Simon Glass
Drop use of the distro scripts and use standard boot instead. We don't need to specify the mmc devices individually, since they are used in order from 0 to 2, and standard boot uses that order anyway. Signed-off-by: Simon Glass --- Changes in v2: - Rebase to -next configs/rpi_0_w_defconfig

[PATCH v2 3/3] arm: rpi: Switch to a text environment

2023-04-02 Thread Simon Glass
Use the new environment format so we can drop most of the config.h file. Signed-off-by: Simon Glass --- (no changes since v1) board/raspberrypi/rpi/rpi.env | 77 ++ include/configs/rpi.h | 100 -- 2 files changed, 77

[PATCH v2 0/3] rpi: Convert to standard boot

2023-04-02 Thread Simon Glass
This series moves Raspberry Pi boards over to use standard boot. It also moves rpi over to use a text-based environment. Unfortunately it is not possible to empty the header file due to several CFG options. Fix the repeated "and and" while we are here. Note that this reduces rodata size by

[PATCH] riscv: Add a 64-bit image type

2023-04-02 Thread Simon Glass
At present it is not possible to know whether an image can be booted by a 32- or 64-bit bootloader. This means that U-Boot may attempt to boot the wrong image. This may cause a crash which might be hard to debug. Add a new property to make this explicit. The existing 'RISC-V' is now taken to

Re: [PATCH v6 09/11] xilinx: Disable CONFIG_BOOTSTD_DEFAULTS for some xilinx boards

2023-04-02 Thread Simon Glass
Hi Tom, On Mon, 3 Apr 2023 at 02:42, Tom Rini wrote: > > On Sun, Apr 02, 2023 at 02:41:46PM +1200, Simon Glass wrote: > > Hi Mark, > > > > On Sun, 2 Apr 2023 at 10:31, Mark Kettenis wrote: > > > > > > > From: Simon Glass > > > > Date: Sun, 2 Apr 2023 09:45:33 +1200 > > > > > > > > Since

Re: [PATCH 1/1] usb: gadget: missing fallthrough in composite_setup()

2023-04-02 Thread Marek Vasut
On 4/1/23 09:06, Heinrich Schuchardt wrote: Add a missing fallthrough macro. This fixes a -Wimplicit-fallthrough warning. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/composite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/composite.c

Re: WIP: Signing TI x509 certificates using binman

2023-04-02 Thread Simon Glass
Hi Neha, On Mon, 3 Apr 2023 at 02:19, Neha Malcom Francis wrote: > > Hi Simon > > On 02/04/23 18:00, Neha Malcom Francis wrote: > > Hi Simon > > > > On 01/04/23 12:02, Simon Glass wrote: > >> Hi Neha, > >> > >> On Sat, 1 Apr 2023 at 00:14, Neha Malcom Francis > >> wrote: > >>> > >>> Hi Simon >

Re: [PATCH v2 1/1] MAINTAINERS: assign include/tpm*, cmd/tpm*

2023-04-02 Thread Simon Glass
On Sun, 2 Apr 2023 at 16:51, Heinrich Schuchardt wrote: > > The files include/tpm* are an integral part of the TPM drivers. > The tpm* commands are used to access TPM devices. > > Both should be managed by the TPM DRIVERS maintainer. > > Signed-off-by: Heinrich Schuchardt > --- > v2: >

Re: [PATCH 1/1] cmd: missing break in test_write_limit()

2023-04-02 Thread Simon Glass
On Sun, 2 Apr 2023 at 16:51, Heinrich Schuchardt wrote: > > In test_write_limit() an unintended fall-through occurs. > > Suggested-by: Simon Glass > Signed-off-by: Heinrich Schuchardt > --- > cmd/tpm_test.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Simon Glass

Re: Newer U-Boot version throwing "Bootstage space exhasuted" with FIT image

2023-04-02 Thread Simon Glass
Hi, On Mon, 3 Apr 2023 at 00:43, wrote: > > Hi Simon, > > it's an STM32MP1, here's a bdinfo and the full boot log. Btw, OPTEE OS is > active: > > STM32MP> bdinfo > boot_params = 0x > DRAM bank = 0x > -> start= 0xc000 > -> size = 0x4000 > flashstart =

Re: [PATCH 1/1] rockchip: Fix incorrect constant name in RAM init code

2023-04-02 Thread Tom Rini
On Thu, 30 Mar 2023 17:51:14 -0400, David Sebek wrote: > A condition in the rk3399 RAM initialization code used the old > CONFIG_RAM_RK3399_LPDDR4 constant name. This commit changes the > condition to use the correct CONFIG_RAM_ROCKCHIP_LPDDR4 constant. > > Applied to u-boot/master, thanks!

Re: BUG: pta_scp03_invoke_func() in drivers/tee/sandbox.c

2023-04-02 Thread jorge . ramirez . ortiz
sorry i am out of the office for a couple of days but that commit looks horrible. not sure what happened there. i'll propose something before thursday. > On 2 Apr 2023, at 04:41, Simon Glass wrote: > > Hi Heinrich, > >> On Sat, 1 Apr 2023 at 20:58, Heinrich Schuchardt < >>

[PATCH] clk: rockchip: rk3568: Add dummy I2S1_MCLKOUT_TX clock support

2023-04-02 Thread Jonas Karlman
A RK3568 device tree pmic node can reference the I2S1_MCLKOUT_TX clock in assigned-clocks, add dummy support to set parent of this clock to the rk3568 cru driver. Fixes probe of pmic driver and missing regulators on affected boards, rk3568-evb and rk3568-rock-3a. Signed-off-by: Jonas Karlman

Re: Newer U-Boot version throwing "Bootstage space exhasuted" with FIT image

2023-04-02 Thread deffo
Hi Simon, it's an STM32MP1, here's a bdinfo and the full boot log. Btw, OPTEE OS is active: STM32MP> bdinfo boot_params = 0x DRAM bank = 0x -> start= 0xc000 -> size = 0x4000 flashstart = 0x flashsize = 0x flashoffset = 0x baudrate

Re: [PATCH v6 09/11] xilinx: Disable CONFIG_BOOTSTD_DEFAULTS for some xilinx boards

2023-04-02 Thread Tom Rini
On Sun, Apr 02, 2023 at 02:41:46PM +1200, Simon Glass wrote: > Hi Mark, > > On Sun, 2 Apr 2023 at 10:31, Mark Kettenis wrote: > > > > > From: Simon Glass > > > Date: Sun, 2 Apr 2023 09:45:33 +1200 > > > > > > Since CONFIG_BOOTSTD_DEFAULTS now selects ENV_VARS_UBOOT_CONFIG we > cannot > > >

Re: [PATCH] travis-ci: Add m68k M5208EVBE machine

2023-04-02 Thread Tom Rini
On Sun, Apr 02, 2023 at 07:37:29AM +0200, Angelo Dureghello wrote: > Hi Marek, > > On 26/03/23 4:33 PM, Tom Rini wrote: > > > > On Mon, 20 Mar 2023 20:46:47 +0100, Marek Vasut wrote: > > > Add m68k M5208EVBE machine configured to test U-Boot m68k support. > > > > > > > > > > Applied, thanks!

Re: [PATCH] Revert 9f62a472dfb2 ("video: Remove duplicate cursor-positioning function")

2023-04-02 Thread Tom Rini
On Sun, Apr 02, 2023 at 05:22:52PM +1200, Simon Glass wrote: > Hi Tom, > > On Thu, 16 Mar 2023 at 05:01, Tom Rini wrote: > > > > This reverts commit 9f62a472dfb26ec14408a27938ddd2a2579d. > > > > The changes here aren't quite right, and on platforms such as Raspberry > > Pi where we can have

Re: WIP: Signing TI x509 certificates using binman

2023-04-02 Thread Neha Malcom Francis
Hi Simon On 02/04/23 18:00, Neha Malcom Francis wrote: Hi Simon On 01/04/23 12:02, Simon Glass wrote: Hi Neha, On Sat, 1 Apr 2023 at 00:14, Neha Malcom Francis wrote: Hi Simon On 31/03/23 02:01, Simon Glass wrote: Hi Neha, On Fri, 24 Mar 2023 at 22:28, Neha Malcom Francis wrote:

Re: WIP: Signing TI x509 certificates using binman

2023-04-02 Thread Neha Malcom Francis
Hi Simon On 01/04/23 12:02, Simon Glass wrote: Hi Neha, On Sat, 1 Apr 2023 at 00:14, Neha Malcom Francis wrote: Hi Simon On 31/03/23 02:01, Simon Glass wrote: Hi Neha, On Fri, 24 Mar 2023 at 22:28, Neha Malcom Francis wrote: Hi Simon, Before I roll out the entire series that works

Re: [PATCH v4] pinctrl: rockchip: support rk3588 pinctrl

2023-04-02 Thread Jonas Karlman
Hi Eugen, On 2023-03-15 16:32, Eugen Hristev wrote: > From: Jianqun Xu > > Add support for Rockchip rk3588 variant of pinctrl. > > The driver is adapted from the Linux driver. > > Signed-off-by: Jianqun Xu > [eugen.hris...@collabora.com: > port to latest U-boot, bring more changes from Linux

Re: [PATCH v3 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-04-02 Thread Jonas Karlman
Hi Eugen, On 2023-03-31 11:40, Eugen Hristev wrote: > Add initial support for the rk3588 PHY variant. > The driver now looks for phy-supply and enables/disables the vbus > accordingly. Maybe this should be added to core phy uclass to closer match linux? Look like e.g. meson phy drivers also

Re: [PATCH v3 1/3] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

2023-04-02 Thread Jonas Karlman
Hi Eugen, On 2023-03-31 11:40, Eugen Hristev wrote: > Add USB 2.0 host nodes and PHYs. > > Co-developed-by: William Wu > Signed-off-by: William Wu > Signed-off-by: Eugen Hristev > --- > Changes in v2,v3: > - none > > arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 169 >

Re: [PATCH v3 08/16] pci: coreboot: Don't read regions when booting

2023-04-02 Thread Christian Gmeiner
> > When U-Boot is the second-stage bootloader, PCI is already set up. We > cannot read the regions from the device tree. There is no point anyway, > since PCI devices have already been allocated according to the regions > and it is not safe for U-Boot to make any changes. > > Signed-off-by: Simon

Re: [PATCH] mmc: dw_mmc: reset controller after data error

2023-04-02 Thread Jonas Karlman
Hi Eugen, On 2023-03-13 15:58, Eugen Hristev wrote: > From: Ziyuan Xu > > Per dw_mmc databook, it's recommended to reset the host controller if > some data-related error occurred. > Implement a reset mechanism. > > Signed-off-by: Ziyuan Xu > Co-developed-by: Jason Zhu > Signed-off-by: Jason

Re: [PATCH 01/12] arm: mach-k3: Move MSMC fixup to SoC level

2023-04-02 Thread Christian Gmeiner
Am Do., 30. März 2023 um 22:31 Uhr schrieb Andrew Davis : > > The MSMC fixup is something we do based on SoC, not based on the board. > So this fixup does not belong in the board files. Move this to the > mach-k3 common file so that it does not have to be done in each board > that uses these SoCs.

Re: [PATCH v4 1/2] regulator: implement basic reference counter

2023-04-02 Thread Jonas Karlman
Hi Eugen, On 2023-03-31 11:15, Eugen Hristev wrote: > Some devices share a regulator supply, when the first one will request > regulator disable, the second device will have it's supply cut off before > graciously shutting down. Hence there will be timeouts and other failed > operations. >

Re: [PATCH 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-02 Thread Christian Gmeiner
Hi Andrew Am Do., 30. März 2023 um 22:30 Uhr schrieb Andrew Davis : > > This matches how it was done for pre-K3 TI platforms and it allows > us to move the forward declaration out of sys_proto.h. > > It also removes the need to check for TI_I2C_BOARD_DETECT before > calling this function, which

Re: [RFC PATCH v1] arm: lib: add __gnu_thumb1_case_si

2023-04-02 Thread Pali Rohár
On Saturday 01 April 2023 15:17:59 Tony Dinh wrote: > Hi Francis, > > On Sat, Apr 1, 2023 at 2:55 PM Francis Laniel > wrote: > > > > The assembly for __gnu_thumb1_case_si was taken from upstream gcc and > > adapted > > as width suffix was removed for the add instruction [1]. > > > >

Re: [PATCH] net: ravb: Support fixed PHY in R-Car

2023-04-02 Thread Ramon Fried
On Tue, Feb 28, 2023 at 1:04 AM Marek Vasut wrote: > > From: Mikhail Lappo > > Calling old U-Boot API doesn't allow to use fixed PHY. > Searching by mask is the part of new function, after > scanning FDT for a fixed PHY definition > > Fixes: e821a7bdb13 ("net: ravb: Detect PHY correctly") >

Re: [PATCH v2 1/5] net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy

2023-04-02 Thread Ramon Fried
On Wed, Mar 29, 2023 at 1:27 PM Yanhong Wang wrote: > > Add a driver for the motorcomm yt8531 gigabit ethernet phy. We have > verified the driver on StarFive VisionFive2 board. > > Signed-off-by: Yanhong Wang > --- > drivers/net/phy/Kconfig | 6 + > drivers/net/phy/Makefile| 1 + >