Re: [PATCH] tools: mxsboot: pre-fill buffer with 0xff, not 0

2023-12-03 Thread Marek Vasut
On 12/4/23 02:35, Fabio Estevam wrote: Hi Alessandro, [Adding Marek and Rogan] On Sun, Dec 3, 2023 at 9:24 PM Alessandro Rubini wrote: The tool works for me, with imx28 and NAND memory, but the resulting blocks are reported as bad, both by u-boot and the kernel. This makes it impossible to

Re: [PATCH v2 17/18] qemu-arm: Get bloblist from boot arguments

2023-12-03 Thread Michal Simek
On 11/27/23 20:50, Raymond Mao wrote: Add platform custom function to get bloblist from boot arguments. Check whether boot arguments aligns with the register conventions defined in FW Handoff spec v0.9. Add bloblist related options into qemu default config. Signed-off-by: Raymond Mao ---

Re: [PATCH] mtd: spi-nor: Add IS25LP02G flash support

2023-12-03 Thread Michal Simek
On 12/4/23 04:27, Venkatesh Yadav Abbarapu wrote: Add support for ISSI 256MB flash IS25LP02G. This part supports 4byte opcodes. It also supports dual and quad read. Signed-off-by: sreekanth sunnam Likely Sreekanth Sunnam here too? M

Re: [PATCH] clk: zynqmp: enable topsw_lsbus clock

2023-12-03 Thread Michal Simek
On 12/4/23 04:12, Venkatesh Yadav Abbarapu wrote: Display port is using topsw_lsbus clock, it is failing while enabling the clock, so enable the topsw_lsbus clock. Signed-off-by: sreekanth sunnam Likely Sreekanth Sunnam M

Re: [PATCH 1/5] cyclic: Disable in SPL builds

2023-12-03 Thread Stefan Roese
Hi Simon, On 11/19/23 19:23, Simon Glass wrote: Hi Tom, On Sun, 19 Nov 2023 at 08:59, Tom Rini wrote: On Sun, Nov 19, 2023 at 07:46:39AM -0700, Simon Glass wrote: The cyclic subsystem is currently enabled in all build phases or none. So far it doesn't have any purpose within SPL builds,

Re: [PATCH v2 1/5] cyclic: Add a symbol for SPL

2023-12-03 Thread Stefan Roese
On 12/2/23 16:33, Simon Glass wrote: The cyclic subsystem is currently enabled either in all build phases or none. For tools this should not be enabled, but since lib/shc256.c and other files include watchdog.h in the host build, we must make sure that it is not enabled there. Add an SPL symbol

Re: [PATCH] mmc: Poll CD in case cyclic framework is enabled

2023-12-03 Thread Stefan Roese
On 12/4/23 02:05, Marek Vasut wrote: On 12/4/23 01:44, Simon Glass wrote: Hi Marek, On Sun, 3 Dec 2023 at 14:01, Marek Vasut wrote: On 12/3/23 18:44, Simon Glass wrote: Hi Marek, On Sat, 2 Dec 2023 at 16:41, Marek Vasut wrote: In case the cyclic framework is enabled, poll the card

Re: [PATCH 1/4] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-12-03 Thread Sughosh Ganu
hi Simon, On Sat, 2 Dec 2023 at 00:02, Simon Glass wrote: > > Hi Sughosh, > > On Thu, 30 Nov 2023 at 23:39, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Thu, 30 Nov 2023 at 08:16, Simon Glass wrote: > > > > > > Hi Sughosh, > > > > > > On Wed, 22 Nov 2023 at 00:40, Sughosh Ganu > > >

Re: [PATCH v2] watchdog: Correct watchdog timeout print message

2023-12-03 Thread Stefan Roese
On 12/3/23 09:30, Chanho Park wrote: The wdt_start function takes timeout_ms as a parameter and starts the watchdog with this value. However, when you output the message, it shows the default timeout value for the watchdog device. So this patch fixes that part to output the correct timeout

Re: [PATCH v2 00/12] cmd: bootefi: refactor the code for bootmgr

2023-12-03 Thread Ilias Apalodimas
Akashi-san On Mon, 4 Dec 2023 at 03:58, AKASHI Takahiro wrote: > > Hi Heinrich, Ilias > > On Tue, Nov 21, 2023 at 10:29:38AM +0900, AKASHI Takahiro wrote: > > This patch set is motivated by the discussion[1] regarding > > CONFIG_BOOTEFI_BOOTMGR option. > > > > At the end, bootefi.c will be

Re: [PATCH v2 0/3] sunxi: add OrangePi Zero 3 board support

2023-12-03 Thread Stephen Graf
I have tested a newly built u-boot with the patches you provided and it works well. It is the same configuration as what I have been testing with for the last few weeks. I loaded the U-boot to SPI flash and tested with the SD card removed from the system and put in a USB card reader. The

Re: [PATCH 00/21] Qualcomm generic board support

2023-12-03 Thread Sumit Garg
+ Linux kernel DT bindings maintainers, EBBR ML On Thu, 30 Nov 2023 at 20:05, Tom Rini wrote: > > On Thu, Nov 30, 2023 at 01:02:25PM +0530, Sumit Garg wrote: > > On Wed, 29 Nov 2023 at 22:06, Neil Armstrong > > wrote: > > > > > > On 29/11/2023 16:34, Caleb Connolly wrote: > > > > > > > > > > >

[PATCH] efi_loader: use event callback for initrd deregistration

2023-12-03 Thread Masahisa Kojima
Currently efi_initrd_deregister() is called in bootefi.c when the image started from bootefi command returns. Since efi_guid_event_group_return_to_efibootmgr event is implemented, so let's use this event for invoking initrd deregistration. Signed-off-by: Masahisa Kojima --- Note that this patch

[PATCH] mtd: spi-nor: Add IS25LP02G flash support

2023-12-03 Thread Venkatesh Yadav Abbarapu
Add support for ISSI 256MB flash IS25LP02G. This part supports 4byte opcodes. It also supports dual and quad read. Signed-off-by: sreekanth sunnam Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/mtd/spi/spi-nor-ids.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH] clk: zynqmp: enable topsw_lsbus clock

2023-12-03 Thread Venkatesh Yadav Abbarapu
Display port is using topsw_lsbus clock, it is failing while enabling the clock, so enable the topsw_lsbus clock. Signed-off-by: sreekanth sunnam Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/clk/clk_zynqmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/clk_zynqmp.c

Re: [PATCH v2 00/12] cmd: bootefi: refactor the code for bootmgr

2023-12-03 Thread AKASHI Takahiro
Hi Heinrich, Ilias On Tue, Nov 21, 2023 at 10:29:38AM +0900, AKASHI Takahiro wrote: > This patch set is motivated by the discussion[1] regarding > CONFIG_BOOTEFI_BOOTMGR option. > > At the end, bootefi.c will be decomposed into two parts, one for > providing the command itself and one for

Re: [PATCH] tools: mxsboot: pre-fill buffer with 0xff, not 0

2023-12-03 Thread Fabio Estevam
Hi Alessandro, [Adding Marek and Rogan] On Sun, Dec 3, 2023 at 9:24 PM Alessandro Rubini wrote: > > The tool works for me, with imx28 and NAND memory, but the resulting > blocks are reported as bad, both by u-boot and the kernel. > > This makes it impossible to erase from Linux (for an upgrade

Re: [PATCH v2] net: designware: Support high memory nodes

2023-12-03 Thread Andre Przywara
On Sat, 2 Dec 2023 10:39:49 +0100 Nils Le Roux wrote: Hi Nils, > Some platforms (such as the Lichee Pi 4A) have their dwmac device > addressable only in high memory space. Storing the node's base address > on 32 bits is not possible in such case. > > Use platform's physical address type to

Re: [PATCH] mmc: Poll CD in case cyclic framework is enabled

2023-12-03 Thread Marek Vasut
On 12/4/23 01:44, Simon Glass wrote: Hi Marek, On Sun, 3 Dec 2023 at 14:01, Marek Vasut wrote: On 12/3/23 18:44, Simon Glass wrote: Hi Marek, On Sat, 2 Dec 2023 at 16:41, Marek Vasut wrote: In case the cyclic framework is enabled, poll the card detect of already initialized cards and

[PATCH v2 3/3] sunxi: H616: Add OrangePi Zero 3 board support

2023-12-03 Thread Andre Przywara
The OrangePi Zero 3 is a small development board featuring the Allwinner H618 SoC, shipping with up to 4GB of DRAM, Gigabit Ethernet, a micro-HDMI connector and two USB sockets. The board uses LPDDR4 DRAM and an X-Powers AXP313a PMIC, support for which was recently added to U-Boot. Add a

[PATCH v2 2/3] sunxi: H616: remove default AXP305 selection

2023-12-03 Thread Andre Przywara
The original H616 devices released about three years ago were typically paired with an X-Powers AXP305 PMIC. Newer devices uses the smaller AXP313, and there seem to be far more systems with this PMIC around now. Remove the default AXP305 selection for the H616 SoC from the Kconfig, and move the

[PATCH v2 1/3] mtd: spi-nor: Add support for zBIT ZB25VQ128

2023-12-03 Thread Andre Przywara
Add support for the zBIT ZB25VQ128 (128M-bit) SPI NOR flash memory chip, as used on the Xunlong Orange Pi Zero 3 board. Signed-off-by: Andre Przywara --- drivers/mtd/spi/Kconfig | 5 + drivers/mtd/spi/spi-nor-ids.c | 5 + 2 files changed, 10 insertions(+) diff --git

[PATCH v2 0/3] sunxi: add OrangePi Zero 3 board support

2023-12-03 Thread Andre Przywara
A small update for the OrangePi Zero 3 support series. This fixes USB support, and upgrades the DRAM clock to 792, for better stability (as the other DRAM parameters were tailored to that frequency). I added the tags on the way. Please test! = The OrangePi Zero 3 is a small

[PATCH 00/14] pxe: Allow extlinux booting without CMDLINE enabled

2023-12-03 Thread Simon Glass
This series is the culmanation of the current line of refactoring series. It adjusts pxe to call the booting functionality directly rather than going through the command-line interface. With this is is possible to boot using the extlinux bootmeth without the command line enabled. It also updates

[PATCH 00/18] Complete decoupling of bootm logic from commands

2023-12-03 Thread Simon Glass
This series continues refactoring the bootm code to allow it to be used with CONFIG_COMMAND disabled. The OS-handling code is refactored and a new bootm_run() function is created to run through the bootm stages. This completes the work. A booti_go() function is created also, in case it proves

Re: efi: Set Variable Runtime implementation

2023-12-03 Thread Simon Glass
Hi Shantur, On Sun, 3 Dec 2023 at 14:51, Shantur Rathore wrote: > > Hi Simon, > > On Sun, Dec 3, 2023 at 5:44 PM Simon Glass wrote: > > > > Hi Shantur, > > > > On Sat, 2 Dec 2023 at 16:03, Shantur Rathore wrote: > > > > > > Hi Simon, > > > > > > On Fri, Dec 1, 2023 at 6:44 PM Simon Glass

Re: [u-boot-gitdm PATCH 2/2] Add some more employers

2023-12-03 Thread Simon Glass
Hi Tom, Would it be worth be resending this as individual patches and copying the people for each domain? Or perhaps we could have a way to encourage people to add the details? Regards, Simon On Sun, 3 Dec 2023 at 14:32, Tom Rini wrote: > > On Sun, Dec 03, 2023 at 09:49:49AM +0100, Jonas

Re: [PATCH v3 3/3] defconfig: rockpro64: Enable SF EFI var store

2023-12-03 Thread Simon Glass
Hi Shantur, On Sun, 3 Dec 2023 at 14:49, Shantur Rathore wrote: > > Hi Simon, > > On Sun, Dec 3, 2023 at 5:44 PM Simon Glass wrote: > > > > Hi Shantur, > > > > On Sat, 2 Dec 2023 at 16:12, Shantur Rathore wrote: > > > > > > Hi Simon, > > > > > > On Fri, Dec 1, 2023 at 6:44 PM Simon Glass

Re: [PATCH] mmc: Poll CD in case cyclic framework is enabled

2023-12-03 Thread Simon Glass
Hi Marek, On Sun, 3 Dec 2023 at 14:01, Marek Vasut wrote: > > On 12/3/23 18:44, Simon Glass wrote: > > Hi Marek, > > > > On Sat, 2 Dec 2023 at 16:41, Marek Vasut > > wrote: > >> > >> In case the cyclic framework is enabled, poll the card detect of already > >> initialized cards and deinitialize

[PATCH 14/14] x86: Drop message about features being missing with 64-bit

2023-12-03 Thread Simon Glass
At this point most things work, including booting a distro, so drop this message. Signed-off-by: Simon Glass --- arch/x86/lib/spl.c | 2 +- doc/board/emulation/qemu-x86.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/lib/spl.c

[PATCH 13/14] pxe: Allow booting without CMDLINE for the zboot method

2023-12-03 Thread Simon Glass
Use zboot_run() to boot rather than the command line. This allows extlinux to be used (on x86) without CMDLINE being enabled. Collect any error but do not return it, to match the existing code. Signed-off-by: Simon Glass --- boot/pxe_utils.c | 19 --- 1 file changed, 8

[PATCH 12/14] pxe: Allow booting without CMDLINE for bootm methods

2023-12-03 Thread Simon Glass
Use bootm_run() to boot rather than the command line. This allows extlinux to be used without CMDLINE being enabled. Collect any error but do not return it, to match the existing code. Signed-off-by: Simon Glass --- boot/pxe_utils.c | 33 - 1 file changed, 16

[PATCH 11/14] pxe: Move calculation of FDT file into a function

2023-12-03 Thread Simon Glass
This code undertakes a separate task from the main logic of label_run_boot() so move it into its own function. Signed-off-by: Simon Glass --- boot/pxe_utils.c | 112 +++ 1 file changed, 64 insertions(+), 48 deletions(-) diff --git a/boot/pxe_utils.c

[PATCH 10/14] pxe: Refactor to avoid over-using bootm_argv

2023-12-03 Thread Simon Glass
The bootm_argv[3] expression is used in many places. It is the FDT address, so use that name throughout. Assign it to bootm_argv[3] only at the end, when all the conditions are resolved. Signed-off-by: Simon Glass --- boot/pxe_utils.c | 22 -- 1 file changed, 12

[PATCH 09/14] pxe: Refactor to reduce the size of label_boot()

2023-12-03 Thread Simon Glass
This function is far too long and complicated. Split out the part which actually calls the boot commands into a separate function. Change a strncpy() to strlcpy() to keep checkpatch happy. No functional change is intended. Signed-off-by: Simon Glass --- boot/pxe_utils.c | 301

[PATCH 08/14] fastboot: Remove dependencies on CMDLINE

2023-12-03 Thread Simon Glass
It is possible to boot a kernel without CMDLINE being enabled. Update the implementation to handle this, and drop the condition from the FASTBOOT config. Signed-off-by: Simon Glass --- drivers/fastboot/Kconfig | 1 - drivers/fastboot/fb_common.c | 26 -- 2 files

[PATCH 07/14] bootm: Make cmdline optional with bootm_boot_start()

2023-12-03 Thread Simon Glass
Allow the default command line to be used when booting the OS. This is needed by fastboot. Signed-off-by: Simon Glass --- boot/bootm.c| 10 ++ include/bootm.h | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index

[PATCH 06/14] fastboot: Change fastboot_buf_addr to an address

2023-12-03 Thread Simon Glass
Given the name of this variable, it should be an address, not a pointer. Update this, to make it easier to use with sandbox. Signed-off-by: Simon Glass --- cmd/fastboot.c| 2 +- drivers/fastboot/fb_command.c | 13 - drivers/fastboot/fb_common.c | 15

[PATCH 05/14] boot: Update SYS_BOOTM_LEN to depend on BOOTM

2023-12-03 Thread Simon Glass
Use the new CONFIG_BOOTM symbol to determine whether SYS_BOOT_LEN is visible or not, since we want to support decompression when CMDLINE is disabled. Signed-off-by: Simon Glass --- boot/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/Kconfig b/boot/Kconfig

[PATCH 04/14] treewide: Make arch-specific bootm code depend on BOOTM

2023-12-03 Thread Simon Glass
Allow these functions to be compiled in when CONFIG_BOOTM is enabled, even if CONFIG_CMD_BOOTM is not. Signed-off-by: Simon Glass --- arch/arc/lib/Makefile| 2 +- arch/arm/lib/Makefile| 2 +- arch/m68k/lib/Makefile | 2 +- arch/microblaze/lib/Makefile | 2 +-

[PATCH 03/14] bootm: Make OS booting dependent on BOOTM

2023-12-03 Thread Simon Glass
Booting an OS does not require the 'bootm' command, so change the condition for these options. Move them into boot/ so they don't depend on CMDLINE Note that CMD_BOOTM_PRE_LOAD has been put directly into the bootm code so will need some additional refactoring (and a test!) to allow it to change

[PATCH 02/14] bootm: Add a Kconfig option for bootm functionality

2023-12-03 Thread Simon Glass
Create a separate Kconfig option which enables the bootm logic, separate from the 'bootm' command. This will eventually allow booting without CMDLINE enabled. Update boards which disable CMD_BOOTM to disable BOOTM instead, since CMD_BOOTM now depends on BOOTM Signed-off-by: Simon Glass ---

[PATCH 01/14] boot: Reorder FIT and BOOTSTD to be first

2023-12-03 Thread Simon Glass
The boot menu shows Android first and then a timestamp option. Move these later since they are less commonly used. Signed-off-by: Simon Glass --- boot/Kconfig | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig

[PATCH 13/13] x86: zboot: Tidy up the comment for zboot_run()

2023-12-03 Thread Simon Glass
The current use case (ChromeOS) is the uncommon case. Document how this function is more normally used, where base is 0 and cmdline is NULL Signed-off-by: Simon Glass --- include/bootm.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/include/bootm.h

[PATCH 12/13] x86: zboot: Use zboot_start() in zboot_run()

2023-12-03 Thread Simon Glass
Now that we have a function to start the process of booting a zimage, use it in zboot_run() to avoid duplicated logic. Signed-off-by: Simon Glass --- arch/x86/lib/zimage.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/arch/x86/lib/zimage.c

[PATCH 11/13] x86: zboot: Separate logic functions from commands

2023-12-03 Thread Simon Glass
Move zboot_start() and zboot_info() in with the other logic functions. Signed-off-by: Simon Glass --- arch/x86/include/asm/zimage.h | 25 + arch/x86/lib/zimage.c | 23 +++ cmd/x86/zboot.c | 32 3

[PATCH 10/13] x86: zboot: Rename zboot_start() to zboot_run()

2023-12-03 Thread Simon Glass
The term 'start' is used withint bootm and zboot to indicate the first phase of booting an image. Since zboot_start() does the whole boot, rename it to zboot_run() to align with bootm_run() etc. Fix a log message while we are here. Signed-off-by: Simon Glass --- arch/x86/lib/zimage.c | 6

[PATCH 09/13] x86: zboot: Move argument processing outside zboot_start()

2023-12-03 Thread Simon Glass
Process the arguments before calling zboot_start() so that we can separate the command line from the internal logic. Signed-off-by: Simon Glass --- cmd/x86/zboot.c | 67 + 1 file changed, 28 insertions(+), 39 deletions(-) diff --git

[PATCH 08/13] x86: zboot: Drop intermediate zboot_go() function

2023-12-03 Thread Simon Glass
This function only calls zboot_go() so drop it. Signed-off-by: Simon Glass --- cmd/x86/zboot.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/cmd/x86/zboot.c b/cmd/x86/zboot.c index f392b6b3e493..f49cdd91a1f8 100644 --- a/cmd/x86/zboot.c +++ b/cmd/x86/zboot.c

[PATCH 07/13] x86: zboot: Drop intermediate zboot_setup() function

2023-12-03 Thread Simon Glass
Move error checking into the caller so that do_zboot_setup() can call zboot_setup() directly. Signed-off-by: Simon Glass --- cmd/x86/zboot.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/cmd/x86/zboot.c b/cmd/x86/zboot.c index d39ab6a9698f..f392b6b3e493

[PATCH 06/13] x86: zboot: Move environment setting into zboot_load()

2023-12-03 Thread Simon Glass
The only difference between the command and the underlying logic is the setting of envrionment variables. Move this out of the command processing since it needs to be done in any case. Signed-off-by: Simon Glass --- arch/x86/lib/zimage.c | 7 +++ cmd/x86/zboot.c | 16

[PATCH 05/13] x86: zboot: Create separate functions for the logic

2023-12-03 Thread Simon Glass
Separate out the commands from the logic. This will eventually allow the logic to be used when CONFIG_CMDLINE is not enabled. Signed-off-by: Simon Glass --- cmd/x86/zboot.c | 66 ++--- 1 file changed, 52 insertions(+), 14 deletions(-) diff --git

[PATCH 02/13] x86: zboot: Move command code into its own file

2023-12-03 Thread Simon Glass
Much of the code in zimage.c deals with the zboot command. Move it into a sepatate zboot.c file within the cmd/ directory. This will eventually allow use of the zimage logic without the command being enabled. Signed-off-by: Simon Glass --- arch/x86/include/asm/zimage.h | 31 ++

[PATCH 04/13] x86: zboot: Avoid iteration in do_zboot_states()

2023-12-03 Thread Simon Glass
Drop the iteration and write out each state in full. This will allow the arguments to be reduced and adjusted in future patches. Signed-off-by: Simon Glass --- cmd/x86/zboot.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/cmd/x86/zboot.c

[PATCH 03/13] x86: zboot: Create a separate ZBOOT option for zboot logic

2023-12-03 Thread Simon Glass
Most of the functionality of zboot is contained in the logic which handles a zimage. Create a separate Kconfig for the logic so that it can (later) be used without the command itself being enabled. Enable ZBOOT by default on x86, with the command depending on that. The existing 'imply' can

[PATCH 01/13] x86: zboot: Move zimage definitions to the header file

2023-12-03 Thread Simon Glass
In preparation for splitting the zboot-command code into a separate file, move the definitions into the header file. While we are here, mention when load_address and base_ptr are set up and explain bzimage_addr better. Make cmdline const since it cannot be changed. Signed-off-by: Simon Glass

[PATCH 00/13] Complete decoupling of zboot logic from commands

2023-12-03 Thread Simon Glass
This series refactors the zboot code to allow it to be used with CONFIG_COMMAND disabled. A new zboot_run() function is used to boot a zimage. This is cmde (part e of CMDLINE refactoring) It depends on dm/cmdd-working which depends on dm/bootstda-working which depends on dm/cmdc-working Simon

[PATCH 18/18] bootm: Create a function to run through the booti states

2023-12-03 Thread Simon Glass
In a few places, the booti command is used to handle a boot. We want these to be done without needing CONFIG_CMDLINE, so add a new booti_run() function to handle this. So far this is not used. Signed-off-by: Simon Glass --- boot/bootm.c| 13 + include/bootm.h | 13

[PATCH 17/18] stm32: Use bootm_run() and bootz_run()

2023-12-03 Thread Simon Glass
Use the new bootm/z_run() functions to avoid having to create an argument list for the stm32prog code. Signed-off-by: Simon Glass --- .../cmd_stm32prog/cmd_stm32prog.c | 22 +++ 1 file changed, 13 insertions(+), 9 deletions(-) diff --git

[PATCH 16/18] bootm: Create a function to run through the bootz states

2023-12-03 Thread Simon Glass
In a few places, the bootz command is used to handle a boot. We want these to be done without needing CONFIG_CMDLINE, so add a new bootz_run() function to handle this. Signed-off-by: Simon Glass --- boot/bootm.c| 13 + cmd/bootz.c | 9 ++--- include/bootm.h | 13

[PATCH 15/18] stm32: Use local vars in stm32prog for initrd and fdt

2023-12-03 Thread Simon Glass
Rather than assigning to the bootm_argv[] array multiple times, use local variables for the two things that can change and assign them at the end. This makes it easier to drop the array eventually. Tidu up an overly short line while we are here. Signed-off-by: Simon Glass ---

[PATCH 14/18] bootm: Create a function to run through the bootm states

2023-12-03 Thread Simon Glass
In quite a few places, the bootm command is used to handle a boot. We want these to be done without needing CONFIG_CMDLINE, so add a new bootm_run() function to handle this. Signed-off-by: Simon Glass --- boot/bootm.c| 19 +++ cmd/bootm.c | 14 +-

[PATCH 13/18] bootm: Drop arguments from do_bootm_states() and rename

2023-12-03 Thread Simon Glass
Create a new struct which holds the information required by bootm. Set this up for each existing caller. Now that none of the functions called from do_bootm_states() need an argv[] list, change the arguments of do_bootm_states() as well. For booti make sure it only uses argv[] and argc at the

[PATCH 12/18] bootm: Adjust how the board is reset

2023-12-03 Thread Simon Glass
Use reset_cpu() to reset the board, copying the logic from the 'reset' command. This makes more sense than directly calling the do_reset() function with the arguments passsed to the bootm command. Signed-off-by: Simon Glass --- boot/bootm.c | 8 +--- 1 file changed, 5 insertions(+), 3

[PATCH 11/18] riscv: Add a reset_cpu() function

2023-12-03 Thread Simon Glass
The current do_reset() is called from a command context. Add a function which can be used from anywhere, as is done on ARM. Adjust do_reset() to call it. Note that reset_cpu() is normally provided by SYSRESET so make this declaration conditional on that being disabled. Signed-off-by: Simon Glass

[PATCH 10/18] nios2: Add a reset_cpu() function

2023-12-03 Thread Simon Glass
The current do_reset() is called from a command context. Add a function which can be used from anywhere, as is done on ARM. Signed-off-by: Simon Glass --- arch/nios2/cpu/cpu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/nios2/cpu/cpu.c b/arch/nios2/cpu/cpu.c

[PATCH 09/18] ppc: Add a reset_cpu() function

2023-12-03 Thread Simon Glass
The current do_reset() is called from a command context. Add a function which can be used from anywhere, as is done on ARM. This is only needed if CONFIG_SYSRESET is disabled. Since there are lots of reset functions, this one actually just calls do_reset(). Future refactoring could correct this.

[PATCH 08/18] m68k: Add a reset_cpu() function

2023-12-03 Thread Simon Glass
The current do_reset() is called from a command context. Add a function which can be used from anywhere, as is done on ARM. Since there are lots of reset functions, this one actually just calls do_reset(). Future refactoring could correct this. Signed-off-by: Simon Glass ---

[PATCH 07/18] mips: Add a reset_cpu() function

2023-12-03 Thread Simon Glass
The current do_reset() is called from a command context. Add a function which can be used from anywhere, as is done on ARM. Signed-off-by: Simon Glass --- arch/mips/cpu/cpu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/mips/cpu/cpu.c b/arch/mips/cpu/cpu.c

[PATCH 06/18] bootm: Drop arguments from boot_selected_os()

2023-12-03 Thread Simon Glass
The argc and argv parameters are not used now, so drop them. Signed-off-by: Simon Glass --- boot/bootm.c| 6 ++ boot/bootm_os.c | 4 ++-- include/bootm.h | 4 ++-- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index

[PATCH 05/18] treewide: bootm: Drop command-line args to boot_os_fn

2023-12-03 Thread Simon Glass
These arguments are not used now. They cannot be provided when there is no bootm command invoked to provide arguments. Drop the argc and argv parameters. Signed-off-by: Simon Glass --- arch/arc/lib/bootm.c| 2 +- arch/arm/lib/bootm.c| 3 +-- arch/m68k/lib/bootm.c | 3

[PATCH 04/18] nios2: Drop separate parsing of bootm args

2023-12-03 Thread Simon Glass
This function is supposed to boot the OS. Parsing of the arguments is done in easier phases. The code to handle this is already here, behind an #ifdef on CONFIG_OF_LIBFDT so rely on that. Signed-off-by: Simon Glass --- arch/nios2/lib/bootm.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 03/18] bootm: qnxelf: Drop passing of arguments

2023-12-03 Thread Simon Glass
It isn't clear how useful it is to pass the arguments of bootm to the OS. For example, if "bootm 1000 2000 3000" is used, the '1000' argument is passed to QNX. This seems like a strange approach, since the argument have already been parsed by U-Boot and processed. Rely instead on the "bootargs"

[PATCH 02/18] bootm: plan: Drop passing of arguments

2023-12-03 Thread Simon Glass
It isn't clear how useful it is to pass the arguments of bootm to the OS. For example, if "bootm 1000 2000 3000" is used, the three arguments at the end are passed to the OS. This seems like a strange approach, since the argument have already been parsed by U-Boot and processed. Rely instead on

[PATCH 01/18] bootm: netbds: Drop passing of arguments

2023-12-03 Thread Simon Glass
It isn't clear how useful it is to pass the arguments of bootm to the OS. For example, if "bootm 1000 2000 3000" is used, the three arguments at the end are passed to the OS. This seems like a strange approach, since the argument have already been parsed by U-Boot and processed. Rely instead on

rk3328 gmac does U-Boot erroneously not set RSF?

2023-12-03 Thread ubroot37
Hi all, I suspect U-Boot is not setting the RSF bit in GMAC_OP_MODE register. This can result in allowing to receive frames with bad CRC. I suspect the Linux driver may be similarly affected, but I have not checked it out. Unfortunately all my spare time is taken up by development on my own

[PATCH] tools: mxsboot: pre-fill buffer with 0xff, not 0

2023-12-03 Thread Alessandro Rubini
The tool works for me, with imx28 and NAND memory, but the resulting blocks are reported as bad, both by u-boot and the kernel. This makes it impossible to erase from Linux (for an upgrade without console access, for example -- u-boot can "nand scrub" but linux can't). pre-filling with 0xff

Re: [PATCH 1/1] correct documentation for SPI flashing

2023-12-03 Thread Andre Przywara
On Fri, 1 Dec 2023 10:50:39 -0800 Stephen Graf wrote: Hi Stephen, thanks for the patch, and you almost nailed it, some little things: - The patch should start a new thread on the list, so do not reply to an existing discussion or (un)related patch. This avoids the patch getting buried in

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-03 Thread Marek Vasut
On 12/3/23 22:42, Shantur Rathore wrote: Hi Marek, On Sun, Dec 3, 2023 at 8:42 PM Marek Vasut wrote: On 11/24/23 01:37, Shantur Rathore wrote: Hi Marek, Hi, sorry for the late reply. In my case RockPro64, the power to usb ports onboard is controlled by a regulator. This regulator is

Re: [PATCH v3 3/3] defconfig: rockpro64: Enable SF EFI var store

2023-12-03 Thread Dragan Simic
On 2023-12-03 22:49, Shantur Rathore wrote: On Sun, Dec 3, 2023 at 5:44 PM Simon Glass wrote: In fact, I wonder if we should add something like: u-boot-env { offset = ; }; so the environment gets filled into the SPI flash when we write the image? Do we want to reset the environment to

Re: efi: Set Variable Runtime implementation

2023-12-03 Thread Shantur Rathore
Hi Simon, On Sun, Dec 3, 2023 at 5:44 PM Simon Glass wrote: > > Hi Shantur, > > On Sat, 2 Dec 2023 at 16:03, Shantur Rathore wrote: > > > > Hi Simon, > > > > On Fri, Dec 1, 2023 at 6:44 PM Simon Glass wrote: > > > > > > Hi Shantur, > > > > > > On Mon, 27 Nov 2023 at 10:27, Shantur Rathore

Re: [PATCH v3 3/3] defconfig: rockpro64: Enable SF EFI var store

2023-12-03 Thread Shantur Rathore
Hi Simon, On Sun, Dec 3, 2023 at 5:44 PM Simon Glass wrote: > > Hi Shantur, > > On Sat, 2 Dec 2023 at 16:12, Shantur Rathore wrote: > > > > Hi Simon, > > > > On Fri, Dec 1, 2023 at 6:44 PM Simon Glass wrote: > > > > > > Hi Shantur, > > > > > > On Sun, 26 Nov 2023 at 15:09, Shantur Rathore

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-03 Thread Shantur Rathore
Hi Marek, On Sun, Dec 3, 2023 at 8:42 PM Marek Vasut wrote: > > On 11/24/23 01:37, Shantur Rathore wrote: > > Hi Marek, > > Hi, > > sorry for the late reply. > > > In my case RockPro64, the power to usb ports onboard is controlled by > > a regulator. > > This regulator is enabled as

Re: [u-boot-gitdm PATCH 2/2] Add some more employers

2023-12-03 Thread Tom Rini
On Sun, Dec 03, 2023 at 09:49:49AM +0100, Jonas Karlman wrote: > Hi Simon, > > On 2023-12-03 05:46, Simon Glass wrote: > > This looks at the top unknowns: > > > >git log --pretty=%ae v2023.01.. |sed 's/.*@//' |sort |uniq -c | > > sort -nr | > >(while read count email; do > >

Re: [PULL] u-boot-sh/master-rpc-off

2023-12-03 Thread Tom Rini
On Sat, Dec 02, 2023 at 08:08:40PM +0100, Marek Vasut wrote: > The following changes since commit 43f2873fa98b1da6eb56d756315c7bd7db63db27: > > MAINTAINERS: Step up as co-maintainer of Tegra SOC platform (2023-11-28 > 11:23:02 -0500) > > are available in the Git repository at: > >

Re: [PULL] u-boot-usb/master

2023-12-03 Thread Tom Rini
On Sat, Dec 02, 2023 at 07:25:14AM +0100, Marek Vasut wrote: > The following changes since commit 43f2873fa98b1da6eb56d756315c7bd7db63db27: > > MAINTAINERS: Step up as co-maintainer of Tegra SOC platform (2023-11-28 > 11:23:02 -0500) > > are available in the Git repository at: > >

Re: [PATCH] mmc: Poll CD in case cyclic framework is enabled

2023-12-03 Thread Marek Vasut
On 12/3/23 18:44, Simon Glass wrote: Hi Marek, On Sat, 2 Dec 2023 at 16:41, Marek Vasut wrote: In case the cyclic framework is enabled, poll the card detect of already initialized cards and deinitialize them in case they are removed. Since the card initialization is a longer process and card

Re: [PATCH 1/2] command: Allocate history buffer using calloc()

2023-12-03 Thread Marek Vasut
On 12/3/23 18:44, Simon Glass wrote: Hi Marek, On Sat, 2 Dec 2023 at 13:53, Marek Vasut wrote: The history buffer is currently a static array which can be some 10-40 kiB depending on configuration, and so adds considerably to the U-Boot binary size. Allocate it dynamically instead to reduce

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-03 Thread Marek Vasut
On 11/24/23 01:37, Shantur Rathore wrote: Hi Marek, Hi, sorry for the late reply. In my case RockPro64, the power to usb ports onboard is controlled by a regulator. This regulator is enabled as part of init as here

Re: [PATCH] usb: xhci: Replace terrible formatting with different terrible formatting

2023-12-03 Thread Marek Vasut
On 11/27/23 06:57, Hector Martin wrote: On 2023/11/23 8:50, Marek Vasut wrote: Replace one type of terrible code formatting with a different type of terrible code formatting. No functional change. Signed-off-by: Marek Vasut --- Cc: Bin Meng Cc: Hector Martin ---

Re: bootstd: Support for distro specific EFI folders

2023-12-03 Thread Simon Glass
Hi Heinrich, On Sun, 3 Dec 2023 at 13:00, Heinrich Schuchardt wrote: > > On 12/3/23 20:50, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 3 Dec 2023 at 11:33, Heinrich Schuchardt > > wrote: > >> > >> On 12/3/23 19:22, Simon Glass wrote: > >>> Hi Heinrich, > >>> > >>> On Sun, 3 Dec 2023 at

Re: bootstd: Support for distro specific EFI folders

2023-12-03 Thread Heinrich Schuchardt
On 12/3/23 20:50, Simon Glass wrote: Hi Heinrich, On Sun, 3 Dec 2023 at 11:33, Heinrich Schuchardt wrote: On 12/3/23 19:22, Simon Glass wrote: Hi Heinrich, On Sun, 3 Dec 2023 at 10:53, Heinrich Schuchardt wrote: On 12/3/23 18:44, Simon Glass wrote: Hi Heinrich, On Sun, 3 Dec 2023 at

Re: bootstd: Support for distro specific EFI folders

2023-12-03 Thread Simon Glass
Hi Heinrich, On Sun, 3 Dec 2023 at 11:33, Heinrich Schuchardt wrote: > > On 12/3/23 19:22, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 3 Dec 2023 at 10:53, Heinrich Schuchardt > > wrote: > >> > >> On 12/3/23 18:44, Simon Glass wrote: > >>> Hi Heinrich, > >>> > >>> On Sun, 3 Dec 2023 at

Re: bootstd: Support for distro specific EFI folders

2023-12-03 Thread Heinrich Schuchardt
On 12/3/23 19:22, Simon Glass wrote: Hi Heinrich, On Sun, 3 Dec 2023 at 10:53, Heinrich Schuchardt wrote: On 12/3/23 18:44, Simon Glass wrote: Hi Heinrich, On Sun, 3 Dec 2023 at 03:55, Heinrich Schuchardt wrote: On 12/3/23 00:38, Shantur Rathore wrote: Hi Simon, On Sat, Dec 2, 2023 at

Re: bootstd: Support for distro specific EFI folders

2023-12-03 Thread Simon Glass
Hi Heinrich, On Sun, 3 Dec 2023 at 10:53, Heinrich Schuchardt wrote: > > On 12/3/23 18:44, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 3 Dec 2023 at 03:55, Heinrich Schuchardt > > wrote: > >> > >> On 12/3/23 00:38, Shantur Rathore wrote: > >>> Hi Simon, > >>> > >>> On Sat, Dec 2, 2023

Re: bootstd: Support for distro specific EFI folders

2023-12-03 Thread Heinrich Schuchardt
On 12/3/23 18:44, Simon Glass wrote: Hi Heinrich, On Sun, 3 Dec 2023 at 03:55, Heinrich Schuchardt wrote: On 12/3/23 00:38, Shantur Rathore wrote: Hi Simon, On Sat, Dec 2, 2023 at 6:33 PM Simon Glass wrote: Hi, On Mon, 20 Nov 2023 at 00:02, Ilias Apalodimas wrote: Hi Mark, On Sun,

Re: bootstd: Support for distro specific EFI folders

2023-12-03 Thread Simon Glass
Hi Heinrich, On Sun, 3 Dec 2023 at 03:55, Heinrich Schuchardt wrote: > > On 12/3/23 00:38, Shantur Rathore wrote: > > Hi Simon, > > > > On Sat, Dec 2, 2023 at 6:33 PM Simon Glass wrote: > >> > >> Hi, > >> > >> On Mon, 20 Nov 2023 at 00:02, Ilias Apalodimas > >> wrote: > >>> > >>> Hi Mark, >

Re: [PATCH] mmc: Poll CD in case cyclic framework is enabled

2023-12-03 Thread Simon Glass
Hi Marek, On Sat, 2 Dec 2023 at 16:41, Marek Vasut wrote: > > In case the cyclic framework is enabled, poll the card detect of already > initialized cards and deinitialize them in case they are removed. Since > the card initialization is a longer process and card initialization is > done on

Re: [PATCH 2/2] command: Move command completion temporary buffer to stack

2023-12-03 Thread Simon Glass
On Sat, 2 Dec 2023 at 13:53, Marek Vasut wrote: > > The command completion temporary buffer seems to be only > used by the argv tokenizer, move it to stack. This saves > 2 kiB from the binary size (depends on configuration) per: > $ aarch64-linux-gnu-readelf -s u-boot | sort -n -k 3 > >

Re: [PATCH] doc: Replace examples of MD5 and SHA1 with SHA256

2023-12-03 Thread Simon Glass
Hi Sean, On Sat, 2 Dec 2023 at 12:38, Sean Anderson wrote: > > On 12/2/23 14:33, Sean Anderson wrote: > > Both SHA1 and (especially) MD5 are no longer as safe as they once were for > > cryptographic use. Replaces examples which use them with examples using > > SHA256 instead. This will provide

  1   2   >