Re: [RFC PATCH 1/1] eficonfig: Add a 'scan-only' mode in eficonfig

2023-03-01 Thread AKASHI Takahiro
On Thu, Mar 02, 2023 at 11:21:05AM +0900, Masahisa Kojima wrote: > Hi Ilias, > > On Wed, 1 Mar 2023 at 23:44, Ilias Apalodimas > wrote: > > > > eficonfig will automatically scan and add Boot variables on launch. > > It will also perform automatic management of the automatically added > > vari

Re: [PATCH v2] disk: Use a helper function to reduce duplication

2023-03-20 Thread AKASHI Takahiro
On Mon, Mar 20, 2023 at 09:31:58AM +0200, Ilias Apalodimas wrote: > Hi Simon, > > Patch looks good, but isn't the new function name a bit misleading? > Something like blk_part_find_start() sounds a bit more descriptive, or am I > missing something? I don't think that the helper function works as

Re: [PATCH 01/10] firmware: scmi: implement SCMI base protocol

2023-07-02 Thread AKASHI Takahiro
On Thu, Jun 29, 2023 at 08:09:45PM +0100, Simon Glass wrote: > Hi AKASHI, > > On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro > wrote: > > > > SCMI base protocol is mandatory according to the SCMI specification. > > > > With this patch, SCMI base protoco

Re: [PATCH 08/10] cmd: add scmi command for SCMI firmware

2023-07-02 Thread AKASHI Takahiro
On Thu, Jun 29, 2023 at 08:10:00PM +0100, Simon Glass wrote: > Hi AKASHI, > > On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro > wrote: > > > > This command, "scmi", provides a command line interface to various SCMI > > protocols. It supports at least i

Re: [PATCH 07/10] test: dm: add SCMI base protocol test

2023-07-02 Thread AKASHI Takahiro
On Thu, Jun 29, 2023 at 08:09:58PM +0100, Simon Glass wrote: > Hi AKASHI, > > On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro > wrote: > > > > Added is a new unit test for SCMI base protocol, which will exercise all > > the commands provided by the protocol,

Re: [PATCH 09/10] doc: cmd: add documentation for scmi

2023-07-02 Thread AKASHI Takahiro
On Thu, Jun 29, 2023 at 08:10:02PM +0100, Simon Glass wrote: > Hi AKASHI, > > On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro > wrote: > > > > This is a help text for scmi command. > > > > Signed-off-by: AKASHI Takahiro >

Re: [PATCH] efi_driver: fix duplicate efiblk#0 issue

2023-07-02 Thread AKASHI Takahiro
On Mon, Jul 03, 2023 at 11:47:18AM +0900, Masahisa Kojima wrote: > The devnum value of the blk_desc structure starts from 0, > current efi_bl_create_block_device() function creates > two "efiblk#0" devices for the cases that blk_find_max_devnum() > returns -ENODEV and blk_find_max_devnum() returns

Re: [PATCH 08/10] cmd: add scmi command for SCMI firmware

2023-07-03 Thread AKASHI Takahiro
On Mon, Jul 03, 2023 at 02:30:54PM +0100, Simon Glass wrote: > Hi, > > On Mon, 3 Jul 2023 at 01:55, AKASHI Takahiro > wrote: > > > > On Thu, Jun 29, 2023 at 08:10:00PM +0100, Simon Glass wrote: > > > Hi AKASHI, > > > > > > On Wed,

Re: [PATCH 09/10] doc: cmd: add documentation for scmi

2023-07-03 Thread AKASHI Takahiro
Hi Simon, On Mon, Jul 03, 2023 at 02:30:55PM +0100, Simon Glass wrote: > Hi , > > On Mon, 3 Jul 2023 at 02:19, AKASHI Takahiro > wrote: > > > > On Thu, Jun 29, 2023 at 08:10:02PM +0100, Simon Glass wrote: > > > Hi AKASHI, > > > > > > On Wed,

Re: [PATCH 07/10] test: dm: add SCMI base protocol test

2023-07-03 Thread AKASHI Takahiro
Hi Simon, On Mon, Jul 03, 2023 at 02:30:57PM +0100, Simon Glass wrote: > Hi, > > On Mon, 3 Jul 2023 at 01:57, AKASHI Takahiro > wrote: > > > > On Thu, Jun 29, 2023 at 08:09:58PM +0100, Simon Glass wrote: > > > Hi AKASHI, > > > > > > On Wed,

Re: EFI Secure boot default keys

2023-07-05 Thread AKASHI Takahiro
Anyhow, please try to enable CONFIG_EFI_VARIABLES_PRESEED with EFI_VAR_FILE_NAME set. Otherwise, those variables will never be restored. (This is another topic that are not described in doc/develop/uefi.) Thanks, -Takahiro Akashi > => efidebug boot order 2 1 > => fatls mmc 0:1 >

Re: EFI Secure boot default keys

2023-07-06 Thread AKASHI Takahiro
          > setenv -e -nv -bs -rt -at -i ${loadaddr}:$filesize db  > > > Failing: > > setenv -e -nv -bs -rt -at -i ${loadaddr}:$filesize PK > fatload mmc 0:1 ${loadaddr} KEK.aut                   > setenv -e -nv -bs -rt -at -i ${loadaddr}:$filesize KEK > fatload mmc 0:

Re: [PATCH 0/4] introduce EFI_RAM_DISK_PROTOCOL

2023-07-06 Thread AKASHI Takahiro
On Fri, Jul 07, 2023 at 01:00:40PM +0900, Masahisa Kojima wrote: > This series introduces the EFI_RAM_DISK_PROTOCOL implementation. > The major purpose of this series is a preparation for EFI HTTP(S) boot. > > Now U-Boot can download the distro installer ISO image > via wget or tftpboot commands,

Re: [PATCH 0/4] introduce EFI_RAM_DISK_PROTOCOL

2023-07-07 Thread AKASHI Takahiro
On Fri, Jul 07, 2023 at 08:29:12AM +0200, Heinrich Schuchardt wrote: > On 7/7/23 06:00, Masahisa Kojima wrote: > > This series introduces the EFI_RAM_DISK_PROTOCOL implementation. > > The major purpose of this series is a preparation for EFI HTTP(S) boot. > > > > Now U-Boot can download the distro

Re: [PATCH 0/4] introduce EFI_RAM_DISK_PROTOCOL

2023-07-07 Thread AKASHI Takahiro
On Fri, Jul 07, 2023 at 05:19:33PM +0900, Masahisa Kojima wrote: > Hi Akashi-san, > > On Fri, 7 Jul 2023 at 16:16, AKASHI Takahiro > wrote: > > > > On Fri, Jul 07, 2023 at 08:29:12AM +0200, Heinrich Schuchardt wrote: > > > On 7/7/23 06:00, Masahisa Kojima wrot

Re: [PATCH 08/10] cmd: add scmi command for SCMI firmware

2023-07-09 Thread AKASHI Takahiro
On Fri, Jul 07, 2023 at 11:35:52AM -0600, Simon Glass wrote: > Hi, > > On Tue, 4 Jul 2023 at 02:26, AKASHI Takahiro > wrote: > > > > On Mon, Jul 03, 2023 at 02:30:54PM +0100, Simon Glass wrote: > > > Hi, > > > > > > On Mon, 3 Jul 2023 at 01:55

Re: [PATCH 07/10] test: dm: add SCMI base protocol test

2023-07-09 Thread AKASHI Takahiro
On Fri, Jul 07, 2023 at 11:35:49AM -0600, Simon Glass wrote: > Hi, > > On Tue, 4 Jul 2023 at 03:35, AKASHI Takahiro > wrote: > > > > Hi Simon, > > > > On Mon, Jul 03, 2023 at 02:30:57PM +0100, Simon Glass wrote: > > > Hi, > > > > >

Re: [PATCH 0/4] introduce EFI_RAM_DISK_PROTOCOL

2023-07-09 Thread AKASHI Takahiro
On Mon, Jul 10, 2023 at 11:13:12AM +0900, Masahisa Kojima wrote: > On Fri, 7 Jul 2023 at 18:12, AKASHI Takahiro > wrote: > > > > On Fri, Jul 07, 2023 at 05:19:33PM +0900, Masahisa Kojima wrote: > > > Hi Akashi-san, > > > > > > On Fri, 7 Jul

Re: [PATCH v1] mkeficapsule: fix efi_firmware_management_capsule_header data type

2023-07-09 Thread AKASHI Takahiro
On Sun, Jul 09, 2023 at 10:31:55AM +0200, Heinrich Schuchardt wrote: > On 6/16/23 10:28, Stefan Herbrechtsmeier wrote: > > From: Malte Schmidt > > > > The data type of item_offset_list shall be UINT64 according to the UEFI [1] > > specifications. > > > > In include/efi_api.h the correct data typ

Re: [PATCH 07/10] test: dm: add SCMI base protocol test

2023-07-10 Thread AKASHI Takahiro
Hi Simon, On Mon, Jul 10, 2023 at 01:45:58PM -0600, Simon Glass wrote: > Hi, > > On Sun, 9 Jul 2023 at 20:04, AKASHI Takahiro > wrote: > > > > On Fri, Jul 07, 2023 at 11:35:49AM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Tue,

Re: [PATCH 07/10] test: dm: add SCMI base protocol test

2023-07-13 Thread AKASHI Takahiro
Hi Simon, On Tue, Jul 11, 2023 at 12:41:58PM -0600, Simon Glass wrote: > Hi Takahiro, > > On Mon, 10 Jul 2023 at 19:02, AKASHI Takahiro > wrote: > > > > Hi Simon, > > > > On Mon, Jul 10, 2023 at 01:45:58PM -0600, Simon Glass wrote: > > > Hi, &g

Reminder, Re: [PATCH] clk: scmi: claim the dependency on CONFIG_CLK

2023-07-13 Thread AKASHI Takahiro
Hi Lukasz, Sean, Can you review this patch, please? -Takahiro Akashi On Mon, Jun 12, 2023 at 10:14:49AM +0900, AKASHI Takahiro wrote: > Without CONFIG_CLK, the build fails with the following message: > LD u-boot > aarch64-none-linux-gnu-ld.bfd: drivers/firmware/scmi/scmi_agent

Re: [PATCH] firmware: scmi: return a right errno for SCMI status code

2023-07-13 Thread AKASHI Takahiro
Hi Tom, Can you pick up this patch, please? It's an easy bugfix. -Takahiro Akashi On Tue, Jun 13, 2023 at 10:30:45AM +0900, AKASHI Takahiro wrote: > scmi_to_linux_errno() is set to return an appropriate errno > which corresponds to a given SCMI status code. > But the current

Re: [PATCH v1 1/2] drivers: firmware: introduce Meson Secure Monitor driver

2023-07-13 Thread AKASHI Takahiro
On Tue, Jul 11, 2023 at 01:13:29PM -0600, Simon Glass wrote: > +AKASHI Takahiro Me? > Hi Alexey, > > On Tue, 11 Jul 2023 at 04:25, Alexey Romanov wrote: > > > > Hi Simon, > > > > On Mon, Jul 10, 2023 at 01:45:53PM -0600, Simon Glass wrote: > > > Hi

[RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-18 Thread AKASHI Takahiro
partition 0 [ + ] blk_partition `-- efiblk#0:1 => ls efiloader 0:1 13 hello.txt 7 u-boot.txt 2 file(s), 0 dir(s) ===>8=== Signed-off-by: AKASHI Takahiro --- include/efi_driver.h | 2 +- lib/efi_driver/efi_b

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-18 Thread AKASHI Takahiro
Hi Simon, On Tue, Jul 18, 2023 at 07:08:45PM -0600, Simon Glass wrote: > Hi AKASHI, > > On Tue, 18 Jul 2023 at 18:22, AKASHI Takahiro > wrote: > > > > An EFI application may create an EFI block device (EFI_BLOCK_IO_PROTOCOL) in > > EFI world, which in turn generate

Re: [PATCH 1/1] efi_loader: support all uclasses in device path

2023-07-18 Thread AKASHI Takahiro
On Wed, Jul 19, 2023 at 06:43:08AM +0200, Heinrich Schuchardt wrote: > On devices with multiple USB mass storage devices errors like > > Path /../USB(0x0,0x0)/USB(0x1,0x0)/Ctrl(0x0) > already installed. > > are seen. This is due to creating non-unique device paths. To uniquely > identify

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-19 Thread AKASHI Takahiro
On Wed, Jul 19, 2023 at 03:15:10PM +0200, Heinrich Schuchardt wrote: > On 19.07.23 15:04, Simon Glass wrote: > > Hi, > > > > On Tue, 18 Jul 2023 at 19:54, AKASHI Takahiro > > wrote: > > > > > > Hi Simon, > > > > > > On Tue, Jul 18,

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-19 Thread AKASHI Takahiro
Hi Simon, On Wed, Jul 19, 2023 at 07:04:06AM -0600, Simon Glass wrote: > Hi, > > On Tue, 18 Jul 2023 at 19:54, AKASHI Takahiro > wrote: > > > > Hi Simon, > > > > On Tue, Jul 18, 2023 at 07:08:45PM -0600, Simon Glass wrote: > > > Hi AKASHI, >

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-19 Thread AKASHI Takahiro
On Wed, Jul 19, 2023 at 07:29:57PM -0600, Simon Glass wrote: > Hi, > > On Wed, 19 Jul 2023 at 18:14, AKASHI Takahiro > wrote: > > > > On Wed, Jul 19, 2023 at 03:15:10PM +0200, Heinrich Schuchardt wrote: > > > On 19.07.23 15:04, Simon Glass wrote: > > >

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-19 Thread AKASHI Takahiro
Hi, On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote: > > > On 7/18/23 17:41, Heinrich Schuchardt wrote: > > On 13.07.23 16:35, Michal Simek wrote: > > > Empty capsule are also allowed to be process. Without it updated images > > > can't change their Image Acceptance state from no to

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread AKASHI Takahiro
t; > On Thu, 20 Jul 2023 at 13:26, Michal Simek wrote: > > > > > > > > > > > > > > > > > > > > On 7/20/23 08:36, Sughosh Ganu wrote: > > > > > > On Thu, 20 Jul 2023 at 11:37, Michal Simek >

Re: [PATCH v6 08/14] firmware: scmi: add a version check against base protocol

2023-10-11 Thread AKASHI Takahiro
Hi Etienne, Thank you again for your review. On Wed, Oct 11, 2023 at 03:44:36PM +, Etienne CARRIERE - foss wrote: > > From: U-Boot on behalf of AKASHI Takahiro > > > > Sent: Wednesday, October 11, 2023 12:07 PM > > > > In SCMI base protocol versi

Re: [PATCH 4/4] test: dm: add SCMI power domain protocol test

2023-10-15 Thread AKASHI Takahiro
Hi Tom, On Fri, Oct 13, 2023 at 09:20:48PM -0400, Tom Rini wrote: > On Tue, Sep 26, 2023 at 04:00:43PM +0900, AKASHI Takahiro wrote: > > > This ut has tests for the SCMI power domain protocol as well as DM > > interfaces for power domain devices. > > > >

[PATCH v2 0/4] firmware: scmi: add SCMI power domain protocol support

2023-10-15 Thread AKASHI Takahiro
l helpers Patch#2: Add power domain driver Patch#3-#4: Test related Change history: === v2 (Oct 16, 2023) * remove a change on "test_scmi_cmd" because "scmi" command is no longer provided with base protocol v6 * some cleanup v1 (Sep 26, 2023) * initial release AK

[PATCH v2 2/4] power: domain: add SCMI driver

2023-10-15 Thread AKASHI Takahiro
Add power domain driver based on SCMI power domain management protocol. Signed-off-by: AKASHI Takahiro --- v2 * remove tentative code which was enclosed by "#if 0" * free allocated memory at the failure of probe function --- drivers/firmware/scmi/scmi_agent-uclass.c | 11 ++ dri

[PATCH v2 3/4] sandbox: add SCMI power domain protocol support for testing

2023-10-15 Thread AKASHI Takahiro
SCMI power domain management protocol is supported on sandbox for test purpose. Add fake agent interfaces and associated power domain devices. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- v2 * add a comment for a member, pstate, of struct sandbox_scmi_pwd --- arch/sandbox/dts

[PATCH v2 4/4] test: dm: add SCMI power domain protocol test

2023-10-15 Thread AKASHI Takahiro
This ut has tests for the SCMI power domain protocol as well as DM interfaces for power domain devices. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- v2 * remove a change at "test_scmi_cmd" because "scmi" command is no longer provided ---

[PATCH v2 1/4] firmware: scmi: add power domain protocol support

2023-10-15 Thread AKASHI Takahiro
In this patch, added are helper functions to directly manipulate SCMI power domain management protocol. DM compliant power domain driver will be implemented on top of those interfaces in a succeeding patch. Signed-off-by: AKASHI Takahiro --- drivers/firmware/scmi/Makefile | 1 + drivers

Re: [PATCH v3 21/32] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-16 Thread AKASHI Takahiro
; Signed-off-by: Simon Glass > Suggested-by: AKASHI Takahiro > --- > > Changes in v3: > - Add new patch to rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR > > cmd/Kconfig | 9 + > lib/efi_loader/Kconfig | 7 +++ > lib/efi_loader/Makefile | 2

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-19 Thread AKASHI Takahiro
On Thu, Oct 19, 2023 at 08:01:11AM -0600, Simon Glass wrote: > Hi Heinrich, > > On Wed, 18 Oct 2023 at 06:55, Heinrich Schuchardt wrote: > > > > On 10/17/23 16:09, Tom Rini wrote: > > > On Mon, Oct 16, 2023 at 04:28:13PM -0600, Simon Glass wrote: > > > > > >> Since efi_device_path.c calls eth_get

Re: [v4 11/24] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-20 Thread AKASHI Takahiro
brary functionality. Add a > > > new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the > > > same code is built. > > > > > > Signed-off-by: Simon Glass > > > Suggested-by: AKASHI Takahiro > > > --- > > > Cc: Heinrich Schuchardt

Re: [PATCH v5 14/16] cmd: add scmi command for SCMI firmware

2023-10-24 Thread AKASHI Takahiro
Hi Tom, Michal, On Tue, Oct 24, 2023 at 06:24:07PM -0400, Tom Rini wrote: > On Tue, Oct 24, 2023 at 10:27:44AM +0200, Michal Simek wrote: > > Hi Takahiro, > > > > ?t 26. 9. 2023 v 9:00 odes?latel AKASHI Takahiro > > napsal: > > > > > > This command,

[PATCH 0/5] cmd: add scmi command

2023-10-24 Thread AKASHI Takahiro
protocol for test purpose. Each commit may have some change history inherited from the preceding patch series. Test The patch series was tested on the following platforms: * sandbox Prerequisite: = * This patch series is based on the latest master. AKASHI Takahiro (5):

[PATCH 1/5] test: dm: skip scmi tests against disabled protocols

2023-10-24 Thread AKASHI Takahiro
This is a precautious change to make scmi tests workable whether or not a specific protocol be enabled. Signed-off-by: AKASHI Takahiro --- test/dm/scmi.c | 12 1 file changed, 12 insertions(+) diff --git a/test/dm/scmi.c b/test/dm/scmi.c index da45314f2e4c..2f63f2da16fb 100644

[PATCH 2/5] firmware: scmi: support protocols on sandbox only if enabled

2023-10-24 Thread AKASHI Takahiro
This change will be useful when we manually test SCMI on sandbox by enabling/disabling a specific SCMI protocol. Signed-off-by: AKASHI Takahiro --- drivers/firmware/scmi/sandbox-scmi_agent.c | 27 ++- drivers/firmware/scmi/sandbox-scmi_devices.c | 78 2 files changed

[PATCH 3/5] cmd: add scmi command for SCMI firmware

2023-10-24 Thread AKASHI Takahiro
This command, "scmi", may provide a command line interface to various SCMI protocols. It supports at least initially SCMI base protocol and is intended mainly for debug purpose. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v3 * des

[PATCH 4/5] doc: cmd: add documentation for scmi

2023-10-24 Thread AKASHI Takahiro
This is a help text for scmi command. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v6 * add the manual to doc/usage/index.rst v4 * s/tranport/transport/ v2 * add more descriptions about SCMI --- doc/usage/cmd/scmi.rst | 126

[PATCH 5/5] test: dm: add scmi command test

2023-10-24 Thread AKASHI Takahiro
In this test, "scmi" command is tested against different sub-commands. Please note that scmi command is for debug purpose and is not intended in production system. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v7 * make test assertions mor

Re: [PATCH 3/5] cmd: add scmi command for SCMI firmware

2023-10-25 Thread AKASHI Takahiro
Hi Michal, On Wed, Oct 25, 2023 at 09:29:04AM +0200, Michal Simek wrote: > > > On 10/25/23 07:14, AKASHI Takahiro wrote: > > This command, "scmi", may provide a command line interface to various SCMI > > protocols. It supports at least initially SCMI base protocol

[RFC 00/13] cmd: bootefi: refactor the code for bootmgr

2023-10-25 Thread AKASHI Takahiro
not directly related to the patch's aim, but they are necessary to compile U-Boot on sandbox (sandbox_defconfig) without CONFIG_CMDLINE. [1] https://lists.denx.de/pipermail/u-boot/2023-October/534598.html [2] origin/TEST/v4.1-tidy-up-use-of-CONFIG_CMDLINE AKASHI Takahiro (13):

[RFC 01/13] cmd: bootefi: unfold do_bootefi_image()

2023-10-25 Thread AKASHI Takahiro
Unfold do_bootefi_image() into do_bootefi() for the sake of the succeeding refactor work. Signed-off-by: AKASHI Takahiro --- cmd/bootefi.c | 101 ++ 1 file changed, 37 insertions(+), 64 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c

[RFC 02/13] cmd: bootefi: re-organize do_bootefi_image()

2023-10-25 Thread AKASHI Takahiro
Decompose and re-organize do_bootefi_image() into three parts for the succeeding refactor work. Signed-off-by: AKASHI Takahiro --- cmd/Kconfig | 15 ++-- cmd/bootefi.c| 82 ++-- include/efi_loader.h | 2 -- 3 files changed, 69

[RFC 03/13] cmd: bootefi: carve out EFI boot manager interface

2023-10-25 Thread AKASHI Takahiro
Carve EFI boot manager related code out of do_bootefi_image(). Signed-off-by: AKASHI Takahiro --- cmd/bootefi.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index ae00bba3b4f0..899ed90f6817 100644

[RFC 04/13] cmd: bootefi: carve out binary execution interface

2023-10-25 Thread AKASHI Takahiro
Carve binary execution code out of do_bootefi_image(). Signed-off-by: AKASHI Takahiro --- cmd/bootefi.c | 46 -- 1 file changed, 32 insertions(+), 14 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index 899ed90f6817..8b0bd07f1ff8 100644

[RFC 06/13] cmd: efidebug: ease efi configuration dependency

2023-10-25 Thread AKASHI Takahiro
Now it is clear that the command actually depends on interfaces, not "bootefi bootmgr" command. Signed-off-by: AKASHI Takahiro --- cmd/efidebug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/efidebug.c b/cmd/efidebug.c index 201531ac19fc..c2b2b074e094 10

[RFC 07/13] bootmeth: use efi_loader interfaces instead of bootefi command

2023-10-25 Thread AKASHI Takahiro
Now that efi_loader subsystem provides interfaces that are equivalent with bootefi command, we can replace command invocations with APIs. Signed-off-by: AKASHI Takahiro --- boot/Kconfig| 4 ++-- boot/Makefile | 2 +- boot/bootm_os.c | 31

[RFC 05/13] cmd: bootefi: move library interfaces under lib/efi_loader

2023-10-25 Thread AKASHI Takahiro
In the prior commits, interfaces for executing EFI binary or boot manager were carved out. Move them under efi_loader directory so that they can be called from other places without depending on bootefi command. Signed-off-by: AKASHI Takahiro --- cmd/bootefi.c| 546

[RFC 08/13] efi_loader: split unrelated code from efi_bootmgr.c

2023-10-25 Thread AKASHI Takahiro
ow how EFI boot manager is implemented. So introduce a new configuration, CONFIG_EFI_BINARY_EXEC, to enforce theem opted out explicitly. Signed-off-by: AKASHI Takahiro --- boot/Kconfig | 4 +- cmd/Kconfig | 6 +- include/efi_loader.h | 28 +-

[RFC 09/13] efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR

2023-10-25 Thread AKASHI Takahiro
At this point, EFI boot manager interfaces is fully independent from bootefi command. So just rename the configuration parameter. Signed-off-by: AKASHI Takahiro --- boot/Makefile | 2 +- cmd/Kconfig | 4 ++-- cmd/efidebug.c | 4 ++-- lib/efi_loader/Kconfig | 2

[RFC 10/13] net: tftp: remove explicit efi configuration dependency

2023-10-25 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro --- net/tftp.c | 10 -- 1 file changed, 4 insertions(+), 6

[RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-25 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro --- fs/fs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletion

[RFC 12/13] lib: uuid: move CONFIG_RANDOM_UUID

2023-10-25 Thread AKASHI Takahiro
This option is independent from any commands and should be managed under lib. For instance, drivers/block/rkmtd.c is a user. It would be better to remove this configuration. Signed-off-by: AKASHI Takahiro --- cmd/Kconfig | 7 --- lib/Kconfig | 7 +++ 2 files changed, 7 insertions(+), 7

[RFC 13/13] block: rkmtd: select CONFIG_RANDOM_UUID explicitly

2023-10-25 Thread AKASHI Takahiro
This option is necessary to compile any way. Signed-off-by: AKASHI Takahiro --- drivers/block/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index 048a6caef00f..5cda21551043 100644 --- a/drivers/block/Kconfig +++ b/drivers/block/Kconfig

Re: [RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 09:58:53AM +0200, Heinrich Schuchardt wrote: > > > Am 26. Oktober 2023 07:30:50 MESZ schrieb AKASHI Takahiro > : > >Now it is clear that the feature actually depends on efi interfaces, > >not "bootefi" command. efi_set_bootdev() wil

Re: [RFC 01/13] cmd: bootefi: unfold do_bootefi_image()

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 01:01:52PM +0200, Heinrich Schuchardt wrote: > On 10/26/23 07:30, AKASHI Takahiro wrote: > > Unfold do_bootefi_image() into do_bootefi() for the sake of the succeeding > > refactor work. > > > > Signed-off-by: AKASHI Takahiro > &

Re: [RFC 02/13] cmd: bootefi: re-organize do_bootefi_image()

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 12:44:00PM +0200, Heinrich Schuchardt wrote: > On 10/26/23 07:30, AKASHI Takahiro wrote: > > Decompose and re-organize do_bootefi_image() into three parts for > > the succeeding refactor work. > > > > Signed-off-by: AKASHI Takahiro > > --

Re: [RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 08:47:52AM -0400, Tom Rini wrote: > On Thu, Oct 26, 2023 at 05:48:30PM +0900, AKASHI Takahiro wrote: > > On Thu, Oct 26, 2023 at 09:58:53AM +0200, Heinrich Schuchardt wrote: > > > > > > > > > Am 26. Oktober 2023 07:30:50 MESZ schrieb AK

Re: [RFC 01/13] cmd: bootefi: unfold do_bootefi_image()

2023-10-29 Thread AKASHI Takahiro
Hi Ilias, On Fri, Oct 27, 2023 at 03:23:07PM +0300, Ilias Apalodimas wrote: > Akashi-san > > On Fri, 27 Oct 2023 at 04:00, Tom Rini wrote: > > > > On Fri, Oct 27, 2023 at 09:25:44AM +0900, AKASHI Takahiro wrote: > > > On Thu, Oct 26, 2023 at 01:01:52PM +0

[PATCH] cmd: dm: allow for selecting uclass and device

2023-08-21 Thread AKASHI Takahiro
lash |-- flash-stick@2 usb_emul 4 [ ] usb_sandbox_keyb `-- keyb@3 Please note that, at "dm tree", the uclass name (usb) as well as the device name (usb@1) is required. Signed-off-by: AKASHI Takahiro --- cmd/dm.c| 30 ++

Re: [PATCH] cmd: dm: allow for selecting uclass and device

2023-08-22 Thread AKASHI Takahiro
Hi Simon, On Mon, Aug 21, 2023 at 09:22:54PM -0600, Simon Glass wrote: > Hi AKASHI, > > On Mon, 21 Aug 2023 at 20:46, AKASHI Takahiro > wrote: > > > > The output from "dm tree" or "dm uclass" is a bit annoying > > if the number of devices availa

[PATCH v2] cmd: dm: allow for selecting uclass and device

2023-08-22 Thread AKASHI Takahiro
eyb `-- keyb@3 Signed-off-by: AKASHI Takahiro --- v2 - allow for forward-matching against the name - update command doc --- cmd/dm.c | 48 ++ doc/usage/cmd/dm.rst | 30 ++- drivers/core/dump.c | 116 ---

Re: [PATCH 1/2] cmd: efidebug: add uri device path

2023-08-23 Thread AKASHI Takahiro
Hi Kojima-san, On Wed, Aug 23, 2023 at 05:37:19PM +0900, Masahisa Kojima wrote: > This adds the URI device path option for 'boot add' subcommand. > User can add the URI load option for downloading ISO image file > or EFI application through network(e.g. HTTP). > > Signed-off-by: Masahisa Kojima

Re: [PATCH 2/2] efi_loader: support boot from URI device path

2023-08-23 Thread AKASHI Takahiro
Kojima-san, On Wed, Aug 23, 2023 at 05:37:20PM +0900, Masahisa Kojima wrote: > This supports to boot from the URI device path. > When user selects the URI device path, bootmgr downloads > the file using wget into the address specified by loadaddr > env variable. > If the file is .iso or .img file,

Re: [PATCH 2/2] efi_loader: support boot from URI device path

2023-08-23 Thread AKASHI Takahiro
On Thu, Aug 24, 2023 at 11:24:31AM +0900, AKASHI Takahiro wrote: > Kojima-san, > > On Wed, Aug 23, 2023 at 05:37:20PM +0900, Masahisa Kojima wrote: > > This supports to boot from the URI device path. > > When user selects the URI device path, bootmgr downloads > > t

[RFC] make sandbox UT more generic

2023-08-30 Thread AKASHI Takahiro
Hi, I'm working on implementing SCMI-based pinctrl/gpio driver, and want to re-use sandbox UT to test the code. However, It is somehow sandbox-specific (with additional DT nodes). How can/should we make it more generic for other targets/drivers rather than just by copying the test code? (I have al

Re: [PATCH v2] cmd: dm: allow for selecting uclass and device

2023-08-30 Thread AKASHI Takahiro
On Wed, Aug 30, 2023 at 09:48:48PM -0600, Simon Glass wrote: > Hi AKASHI, > > On Tue, 22 Aug 2023 at 19:50, AKASHI Takahiro > wrote: > > > > The output from "dm tree" or "dm uclass" is a bit annoying > > if the number of devices available on t

Re: [RFC] make sandbox UT more generic

2023-08-30 Thread AKASHI Takahiro
Hi Simon, On Wed, Aug 30, 2023 at 08:49:05PM -0600, Simon Glass wrote: > Hi, > > On Wed, 30 Aug 2023 at 18:38, AKASHI Takahiro > wrote: > > > > Hi, > > > > I'm working on implementing SCMI-based pinctrl/gpio driver, > > and want to re-use sandbox

[RFC 0/6] firmware: scmi: add SCMI pinctrl protocol support

2023-09-05 Thread AKASHI Takahiro
Prerequisite: = * This patch series is based on my WIP "Base protocol support" patches on v2023.10-rc3. You can fetch the whole code from [4]. [4] https://git.linaro.org/people/takahiro.akashi/u-boot.git branch:scmi/pinctrl Patches: Patch#1: Add SCMI base protocol d

[RFC 1/6] firmware: scmi: fix protocol enumeration logic

2023-09-05 Thread AKASHI Takahiro
The original logic in enumerating all the protocols accidentally modifies a *loop* variable, node, at Voltage domain protocol. So subsequent protocol nodes in a device tree won't be detected. Signed-off-by: AKASHI Takahiro --- drivers/firmware/scmi/scmi_agent-uclass.c | 7 +-- 1

[RFC 2/6] firmware: scmi: add pinctrl protocol support

2023-09-05 Thread AKASHI Takahiro
With this patch, transport-level utility functions for SCMI pinctrl protocol are added. DM-compliant device drivers, pinctrl and gpio, are added in the following patches. Signed-off-by: AKASHI Takahiro --- cmd/scmi.c| 1 + drivers/firmware/scmi/Kconfig

[RFC 3/6] pinctrl: add scmi driver

2023-09-05 Thread AKASHI Takahiro
This DM-compliant driver deals with SCMI pinctrl protocol and presents pinctrl devices exposed by SCMI firmware (server). Signed-off-by: AKASHI Takahiro --- drivers/pinctrl/Kconfig| 11 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-scmi.c | 537

[RFC 4/6] gpio: add scmi driver based on pinctrl

2023-09-05 Thread AKASHI Takahiro
This DM-compliant driver deals with SCMI pinctrl protocol and presents gpio devices exposed by SCMI firmware (server). Signed-off-by: AKASHI Takahiro --- drivers/pinctrl/pinctrl-scmi.c | 544 - 1 file changed, 539 insertions(+), 5 deletions(-) diff --git a

[RFC 5/6] firmware: scmi: add pseudo pinctrl protocol support on sandbox

2023-09-05 Thread AKASHI Takahiro
With this patch, sandbox SCMI agent can handle pinctrl protocol. This feature is used in an unit test for SCMI pinctrl. Signed-off-by: AKASHI Takahiro --- arch/sandbox/dts/test.dts | 115 drivers/firmware/scmi/sandbox-scmi_agent.c | 722 + 2 files

[RFC 6/6] test: dm: add SCMI pinctrl test

2023-09-05 Thread AKASHI Takahiro
In this test, SCMI-based pinmux feature is exercised. Signed-off-by: AKASHI Takahiro --- test/dm/scmi.c | 62 ++ 1 file changed, 62 insertions(+) diff --git a/test/dm/scmi.c b/test/dm/scmi.c index 423b6ef70b29..ca5a2e9c781e 100644 --- a/test/dm

Re: [RFC] make sandbox UT more generic

2023-09-05 Thread AKASHI Takahiro
Hi Simon, On Thu, Aug 31, 2023 at 09:04:43AM -0600, Simon Glass wrote: > Hi, > > On Wed, 30 Aug 2023 at 23:28, AKASHI Takahiro > wrote: > > > > Hi Simon, > > > > On Wed, Aug 30, 2023 at 08:49:05PM -0600, Simon Glass wrote: > > > Hi, > > &g

Re: [RFC 4/6] gpio: add scmi driver based on pinctrl

2023-09-06 Thread AKASHI Takahiro
On Wed, Sep 06, 2023 at 04:56:56PM +0200, Michal Simek wrote: > > > On 9/6/23 04:40, AKASHI Takahiro wrote: > > This DM-compliant driver deals with SCMI pinctrl protocol and presents > > gpio devices exposed by SCMI firmware (server). > > > &g

Re: [RFC 0/6] firmware: scmi: add SCMI pinctrl protocol support

2023-09-07 Thread AKASHI Takahiro
n control protocol at SCMI firmware(server)? Is it public available? -Takahiro Akashi > On Tue, Sep 5, 2023 at 11:41 PM AKASHI Takahiro > wrote: > > > > This is an RFC and meant to get feedback from other developers as > > - the specification (pinctrl part) is still in a d

[PATCH v3 00/13] firmware: scmi: add SCMI base protocol support

2023-09-07 Thread AKASHI Takahiro
(Jun, 28, 2023) * initial release AKASHI Takahiro (13): scmi: refactor the code to hide a channel from devices firmware: scmi: implement SCMI base protocol firmware: scmi: move scmi_bind_protocols() backward firmware: scmi: framework for installing additional protocols firmware: scm

[PATCH v3 01/13] scmi: refactor the code to hide a channel from devices

2023-09-07 Thread AKASHI Takahiro
ater patch. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- v3 * fix an issue on ST board (reported by Etienne) by taking care of cases where probed devices are children of SCMI protocol device (i.e. clock devices under CCF) See find_scmi_protocol_device(). * move "per_de

[PATCH v3 02/13] firmware: scmi: implement SCMI base protocol

2023-09-07 Thread AKASHI Takahiro
ayers are not able to handle asynchronous messages properly. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- v3 * strncpy (TODO) * remove a duplicated function prototype * use newly-allocated memory when return vendor name or agent name * revise function descriptions in a header v2

[PATCH v3 03/13] firmware: scmi: move scmi_bind_protocols() backward

2023-09-07 Thread AKASHI Takahiro
Move the location of scmi_bind_protocols() backward for changes in later patches. There is no change in functionality. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- drivers/firmware/scmi/scmi_agent-uclass.c | 59 +++ 1 file

[PATCH v3 04/13] firmware: scmi: framework for installing additional protocols

2023-09-07 Thread AKASHI Takahiro
This framework allows SCMI protocols to be installed and bound to the agent so that the agent can manage and utilize them later. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v3 * move "per_device_plat_auto" from a earlier patch * fix c

[PATCH v3 05/13] firmware: scmi: install base protocol to SCMI agent

2023-09-07 Thread AKASHI Takahiro
ff-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v3 * typo fix: add '@' for argument name in function description * eliminate dev_get_uclass_plat()'s repeated in inline * modify the code for dynamically allocated sub-vendor/agent names v2 * use helper

[PATCH v3 06/13] firmware: scmi: add a check against availability of protocols

2023-09-07 Thread AKASHI Takahiro
Now that we have Base protocol support, we will be able to check if a given protocol is really supported by the SCMI server (firmware). Signed-off-by: AKASHI Takahiro Reviewed-by: Etienne Carriere --- v3 * new; import this patch from my followup patch set --- drivers/firmware/scmi/scmi_agent

[PATCH v3 07/13] sandbox: remove SCMI base node definition from test.dts

2023-09-07 Thread AKASHI Takahiro
SCMI base protocol is mandatory and doesn't need to be listed in a device tree. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- arch/sandbox/dts/test.dts | 4 1 file changed, 4 deletions(-) diff --git a/arch/sandbox/dts/test.dts b/arch/sa

[PATCH v3 08/13] firmware: scmi: fake base protocol commands on sandbox

2023-09-07 Thread AKASHI Takahiro
This is a simple implementation of SCMI base protocol for sandbox. The main use is in SCMI unit test. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v3 * type fixes: s/udevice/dev/ in function descriptions --- drivers/firmware/scmi/sandbox

[PATCH v3 09/13] test: dm: simplify SCMI unit test on sandbox

2023-09-07 Thread AKASHI Takahiro
Adding SCMI base protocol makes it inconvenient to hold the agent instance (udevice) locally since the agent device will be re-created per each test. Just remove it and simplify the test flows. The test scenario is not changed at all. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass

[PATCH v3 10/13] test: dm: add SCMI base protocol test

2023-09-07 Thread AKASHI Takahiro
Added is a new unit test for SCMI base protocol, which will exercise all the commands provided by the protocol, except SCMI_BASE_NOTIFY_ERRORS. $ ut dm scmi_base It is assumed that test.dtb is used as sandbox's device tree. Signed-off-by: AKASHI Takahiro Reviewed-by: Etienne Carriere -

[PATCH v3 11/13] cmd: add scmi command for SCMI firmware

2023-09-07 Thread AKASHI Takahiro
This command, "scmi", may provide a command line interface to various SCMI protocols. It supports at least initially SCMI base protocol and is intended mainly for debug purpose. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v3 * des

  1   2   3   4   5   6   7   8   9   10   >