[U-Boot] [PATCH v6 18/18] fastboot: Update fastboot documentation

2018-05-22 Thread Alex Kiernan
Update fastboot documentation to reflect merged USB/UDP implementation. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v6: - new Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None doc/README.android-fastboot

[U-Boot] [PATCH v6 08/18] fastboot: Rename fb_set_reboot_flag to fastboot_set_reboot_flag

2018-05-22 Thread Alex Kiernan
call it from non-USB fastboot code. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - new Changes

Re: [U-Boot] [PATCH v6 17/18] usb: fastboot: Convert USB f_fastboot to shared fastboot

2018-05-22 Thread Alex Kiernan
On Tue, May 22, 2018 at 4:29 PM Sam Protsenko <semen.protse...@linaro.org> wrote: > On 22 May 2018 at 18:21, Sam Protsenko <semen.protse...@linaro.org> wrote: > > On 22 May 2018 at 12:23, Alex Kiernan <alex.kier...@gmail.com> wrote: > >> Convert USB fastboot

Re: [U-Boot] [PATCH v1 1/2] buildman: Extract environment as part of each build

2018-05-25 Thread Alex Kiernan
ed blob. Of course I can't now find the one I tripped over to point at :( > > > > Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> > > --- > > > > tools/buildman/builderthread.py | 10 ++ > > 1 file changed, 10 insertions(+) > > > >

Re: [U-Boot] [PATCH v1 1/2] buildman: Extract environment as part of each build

2018-05-25 Thread Alex Kiernan
On Fri, May 25, 2018 at 9:56 AM Alex Kiernan <alex.kier...@gmail.com> wrote: > On Fri, May 25, 2018 at 9:05 AM Lukasz Majewski <lu...@denx.de> wrote: > > Hi Alex, > > > As we're building the boards, extract the default U-Boot environment > > > to u

Re: [U-Boot] [PATCH v7 14/18] mmc: Separate "mmc swrite" from fastboot

2018-05-25 Thread Alex Kiernan
On Fri, May 25, 2018 at 3:42 AM Simon Glass <s...@chromium.org> wrote: > Hi Alex, > On 24 May 2018 at 07:29, Alex Kiernan <alex.kier...@gmail.com> wrote: > > > > Introduce CONFIG_IMAGE_SPARSE and CONFIG_CMD_MMC_SWRITE so the "mmc > > swrite&quo

Re: [U-Boot] [PATCH v3 1/2] cmd: nvedit: env import can now import only variables passed as parameters

2018-05-25 Thread Alex Kiernan
iled: errno = %d\n", errno); > + > return 1; > } > gd->flags |= GD_FLG_ENV_READY; > @@ -1242,7 +1252,7 @@ static char env_help_text[] = > #endif > #endif > #if defined(CONFIG_CMD_IMPOR

Re: [U-Boot] [PATCH v3 1/2] cmd: nvedit: env import can now import only variables passed as parameters

2018-05-25 Thread Alex Kiernan
On Fri, May 25, 2018 at 12:26 PM Lothar Waßmann <l...@karo-electronics.de> wrote: > Hi, > On Fri, 25 May 2018 11:52:17 +0100 Alex Kiernan wrote: > > On Fri, May 25, 2018 at 9:38 AM Quentin Schulz < quentin.sch...@bootlin.com> > > wrote: > > > > >

Re: [U-Boot] [PATCH v1 1/2] buildman: Extract environment as part of each build

2018-05-25 Thread Alex Kiernan
On Sat, May 26, 2018 at 3:07 AM Simon Glass <s...@chromium.org> wrote: > Hi Alex, > On 24 May 2018 at 22:57, Alex Kiernan <alex.kier...@gmail.com> wrote: > > As we're building the boards, extract the default U-Boot environment to > > uboot.env so we can interrogat

Re: [U-Boot] [PATCH v6 17/18] usb: fastboot: Convert USB f_fastboot to shared fastboot

2018-05-24 Thread Alex Kiernan
Hi Sam On Tue, May 22, 2018 at 8:16 PM Alex Kiernan <alex.kier...@gmail.com> wrote: > On Tue, May 22, 2018 at 7:41 PM Sam Protsenko <semen.protse...@linaro.org> > wrote: > > On 22 May 2018 at 18:53, Alex Kiernan <alex.kier...@gmail.com> wrote: > > &

[U-Boot] [PATCH v7 13/18] fastboot: Migrate FASTBOOT_FLASH_NAND_TRIMFFS to Kconfig

2018-05-24 Thread Alex Kiernan
Add FASTBOOT_FLASH_NAND_TRIMFFS to Kconfig; note there are no in-tree users of it. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v7: None Changes in v6: None Changes in v5: - new Changes in v4: None Changes in v3:

[U-Boot] [PATCH v7 18/18] fastboot: Update fastboot documentation

2018-05-24 Thread Alex Kiernan
Update fastboot documentation to reflect merged USB/UDP implementation. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v7: None Changes in v6: - new Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None doc/README.android-fastboot

[U-Boot] [PATCH v7 03/18] fastboot: Extract fastboot_okay/fail to fb_common.c

2018-05-24 Thread Alex Kiernan
-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v7: None Changes in v6: None Changes in v5: - fix docbook formatting Changes in v4: - add docbook comments Changes in v3: - Merge subsequent patch for formatting resp

[U-Boot] [PATCH v7 15/18] net: fastboot: Merge AOSP UDP fastboot

2018-05-24 Thread Alex Kiernan
Merge UDP fastboot support from AOSP: https://android.googlesource.com/platform/external/u-boot/+/android-o-mr1-iot-preview-8 Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Signed-off-by: Alex Deymo <de...@google.com> Signed-off-by: Jocelyn Bohr <b...@google.com>

[U-Boot] [PATCH v7 14/18] mmc: Separate "mmc swrite" from fastboot

2018-05-24 Thread Alex Kiernan
to Kconfig. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Acked-by: Jassi Brar <jaswinder.si...@linaro.org> --- Changes in v7: None Changes in v6: None Changes in v5: - rename CONFIG_FASTBOOT_FLASH_FILLBUF_SIZE to CONFIG_IMAGE_SPARSE_FILLBUF_SIZE and migrate it to Kconfig.

[U-Boot] [PATCH v7 09/18] fastboot: Extract common definitions from USB fastboot

2018-05-24 Thread Alex Kiernan
Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code we only have one definition. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v7: None C

[U-Boot] [PATCH v7 16/18] fastboot: Add support for 'oem format' command

2018-05-24 Thread Alex Kiernan
Introduce 'oem format' which matches the USB implementation, guard this with CONFIG_FASTBOOT_CMD_OEM_FORMAT so that you can configure it out. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v7: None Changes in v6:

[U-Boot] [PATCH v7 02/18] fastboot: Refactor fastboot_okay/fail to take response

2018-05-24 Thread Alex Kiernan
Add the response string as a parameter to fastboot_okay/fail, instead of modifying a global, to match the contract expected by the AOSP U-Boot code. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v7: None C

[U-Boot] [PATCH v7 12/18] fs: Add fs_get_type_name to return current filesystem name

2018-05-24 Thread Alex Kiernan
Add fs_get_type_name so we can get the current filesystem type. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Reviewed-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v7: None Changes in v6: None Changes in v5:

[U-Boot] [PATCH v7 10/18] fastboot: Rename public fb_ functions to fastboot_

2018-05-24 Thread Alex Kiernan
Rename fb_mmc_flash_write/fb_mmc_erase/fb_nand_flash_write/fb_nand_erase to fastboot_... as they form a public interface Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v7: None Changes in v6: - add docbook comments C

[U-Boot] [PATCH v7 05/18] fastboot: Add missing newlines

2018-05-24 Thread Alex Kiernan
Add newlines so we format our output correctly. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Acked-by: Joe Hershberger <joe.hershber...@ni.com> Reviewed-by: Jocelyn Bohr <b...@google.com> --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4:

[U-Boot] [PATCH v7 17/18] usb: fastboot: Convert USB f_fastboot to shared fastboot

2018-05-24 Thread Alex Kiernan
Convert USB fastboot code to use shared fastboot protocol. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v7: - set FASTBOOT_CMD_OEM_FORMAT for all existing users of FASTBOOT_FLASH_MMC_DEV that also have CMD_GPT Changes in v6: - merged from RFC USB fastboot series

[U-Boot] [PATCH v7 00/18] Add fastboot UDP support

2018-05-24 Thread Alex Kiernan
e USB code. Changes in v2: - ensure fastboot syntax is backward compatible - 'fastboot 0' means 'fastboot usb 0' Alex Kiernan (18): fastboot: Move fastboot to drivers/fastboot fastboot: Refactor fastboot_okay/fail to take response fastboot: Extract fastboot_okay/fail to fb_common.c

[U-Boot] [PATCH v7 01/18] fastboot: Move fastboot to drivers/fastboot

2018-05-24 Thread Alex Kiernan
behaviour. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v7: None Changes in v6: - accomodate master change and switch dependency on imx6dl_mam

[U-Boot] [PATCH v7 08/18] fastboot: Rename fb_set_reboot_flag to fastboot_set_reboot_flag

2018-05-24 Thread Alex Kiernan
call it from non-USB fastboot code. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Ch

[U-Boot] [PATCH v7 11/18] ti: fastboot: Move weak overrides to board files

2018-05-24 Thread Alex Kiernan
Overriding fastboot_set_reboot_flag() in arch/arm/mach-omap2/boot-common.c leaves it applying all boards that derive from this, not just the ones which have support for Android bootloader flow. Move the weak function override to the relevant board files. Signed-off-by: Alex Kiernan <alex.k

[U-Boot] [PATCH v1 0/2] Add bootlimit to Kconfig

2018-05-24 Thread Alex Kiernan
This patch series adds the bootlimit environment variable to Kconfig and migrates users to it. Alex Kiernan (2): Add BOOTCOUNT_BOOTLIMIT to set reboot limit Migrate bootlimit to Kconfig configs/brppt1_mmc_defconfig | 1 + configs/brppt1_nand_defconfig | 1 + configs

[U-Boot] [PATCH v1 2/2] Migrate bootlimit to Kconfig

2018-05-24 Thread Alex Kiernan
, so we'd fail to set bootlimit= in display5_factory_defconfig if we moved it to Kconfig. gurnard_defconfig includes a bootlimit=, but doesn't set CONFIG_BOOTCOUNT_LIMIT, so again we'd fail to include a bootlimit setting if we migrated it. Signed-off-by: Alex Kiernan <alex.kier...@gmail.

[U-Boot] [PATCH v1 1/2] Add BOOTCOUNT_BOOTLIMIT to set reboot limit

2018-05-24 Thread Alex Kiernan
Add ability to set environment bootlimit from Kconfig Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- drivers/bootcount/Kconfig | 8 include/env_default.h | 3 +++ 2 files changed, 11 insertions(+) diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig

[U-Boot] [PATCH v7 04/18] fastboot: Correct dependencies in FASTBOOT_FLASH

2018-05-24 Thread Alex Kiernan
/DOS_PARTITION enabled. Delete redundant FASTBOOT_FLASH_NAND_DEV from Kconfig - it was only ever used as a guard and the value was ignored in all cases, we're using FASTBOOT_FLASH_NAND as the guard now. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Joe Hershberger <joe

[U-Boot] [PATCH v7 07/18] fastboot: Fix parameter types in _fb_nand_write

2018-05-24 Thread Alex Kiernan
(struct mtd_info *mtd, loff_t offset, size_t *length, ^~~ Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v7: None Changes in v6: None Changes i

[U-Boot] [PATCH v7 06/18] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME

2018-05-24 Thread Alex Kiernan
CONFIG_FASTBOOT_GPT_NAME and CONFIG_FASTBOOT_MBR_NAME are always defined by Kconfig if you're compiling this code, so remove these redundant defaults. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger &

Re: [U-Boot] [PATCH v1 2/2] Migrate bootlimit to Kconfig

2018-05-24 Thread Alex Kiernan
t was something like that. I'll swap it over. > > > > gurnard_defconfig includes a bootlimit=, but doesn't set > > CONFIG_BOOTCOUNT_LIMIT, so again we'd fail to include a bootlimit > > setting if we migrated it. > > > > Signed-off-by: Alex Kiernan <alex.kier...@gma

[U-Boot] [PATCH v1 2/2] buildman: Add support for environment delta in summary

2018-05-24 Thread Alex Kiernan
When summarising the builds, add the -U option to emit delta lines for the default environment built into U-Boot at each commit. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- tools/buildman/builder.py | 128 +- tools/buildman/cmdline.py

[U-Boot] [PATCH v1 1/2] buildman: Extract environment as part of each build

2018-05-24 Thread Alex Kiernan
As we're building the boards, extract the default U-Boot environment to uboot.env so we can interrogate it later. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- tools/buildman/builderthread.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/bu

Re: [U-Boot] [PATCH v4 14/14] net: fastboot: Merge AOSP UDP fastboot

2018-05-16 Thread Alex Kiernan
On Wed, May 16, 2018 at 8:15 PM Joe Hershberger <joe.hershber...@ni.com> wrote: > On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan <alex.kier...@gmail.com> wrote: > > Merge UDP fastboot support from AOSP: > > > > https://android.googlesource.com/platform/external/u-b

Re: [U-Boot] [PATCH v4 13/14] mmc: Separate "mmc swrite" from fastboot

2018-05-15 Thread Alex Kiernan
On Wed, May 16, 2018 at 12:20 AM Joe Hershberger <joe.hershber...@ni.com> wrote: > On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan <alex.kier...@gmail.com> wrote: > > Introduce CONFIG_IMAGE_SPARSE and CONFIG_CMD_MMC_SWRITE so the "mmc > > swrite" comman

Re: [U-Boot] [PATCH v6 17/18] usb: fastboot: Convert USB f_fastboot to shared fastboot

2018-05-22 Thread Alex Kiernan
On Tue, May 22, 2018 at 7:41 PM Sam Protsenko <semen.protse...@linaro.org> wrote: > On 22 May 2018 at 18:53, Alex Kiernan <alex.kier...@gmail.com> wrote: > > On Tue, May 22, 2018 at 4:29 PM Sam Protsenko < semen.protse...@linaro.org> > > wrote: > > >

[U-Boot] [PATCH v5 01/16] fastboot: Move fastboot to drivers/fastboot

2018-05-17 Thread Alex Kiernan
behaviour. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v5: - don't depend on UDP_FUNCTION_FASTBOOT until it exists - squash in subsequent patch which updates defc

[U-Boot] [PATCH v5 14/16] mmc: Separate "mmc swrite" from fastboot

2018-05-17 Thread Alex Kiernan
to Kconfig. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v5: - rename CONFIG_FASTBOOT_FLASH_FILLBUF_SIZE to CONFIG_IMAGE_SPARSE_FILLBUF_SIZE and migrate it to Kconfig. Changes in v4: - new Changes in v3: None Changes in v2: None cmd/Kconfig|

[U-Boot] [PATCH v5 00/16] Add fastboot UDP support

2018-05-17 Thread Alex Kiernan
s ends. - Separate the fastboot protocol handling from the fastboot UDP code in preparation for reusing it in the USB code. Changes in v2: - ensure fastboot syntax is backward compatible - 'fastboot 0' means 'fastboot usb 0' Alex Kiernan (16): fastboot: Move fastboot to drivers/fastboot

Re: [U-Boot] [RFC PATCH v2 1/2] usb: fastboot: Convert USB f_fastboot to shared fastboot

2018-05-18 Thread Alex Kiernan
Hi Sam On Fri, May 18, 2018 at 7:32 PM Sam Protsenko <semen.protse...@linaro.org> wrote: > On 17 May 2018 at 19:13, Alex Kiernan <alex.kier...@gmail.com> wrote: > > Convert USB fastboot code to use shared fastboot protocol. > > > > Signed-off-by: Ale

Re: [U-Boot] [PATCH] block: Add SPL_BLOCK_CACHE and default n

2018-06-10 Thread Alex Kiernan
&& !CONFIG_IS_ENABLED(SPL_BUILD)) || \ > +(CONFIG_IS_ENABLED(SPL_BLOCK_CACHE) && CONFIG_IS_ENABLED(SPL_BUILD)) Assuming I read it right, you shouldn't need all the &&/|| gyrations, just: #if CONFIG_IS_ENABLED(BLOCK_CACHE) Should get you what you want. > /** > * blkcache_read() - attempt to read a set of blocks from cache > * > -- > 2.17.1 > -- Alex Kiernan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] block: Add SPL_BLOCK_CACHE and default n

2018-06-09 Thread Alex Kiernan
On Sat, Jun 9, 2018 at 3:04 PM Adam Ford wrote: > > On Sat, Jun 9, 2018 at 8:26 AM Alex Kiernan wrote: > > > > On Fri, Jun 8, 2018 at 9:48 PM Adam Ford wrote: > > > > > > When enabling BLOCK_CACHE on devices with limited RAM during SPL, > > > some

Re: [U-Boot] [PATCH] block: Add SPL_BLOCK_CACHE and default n

2018-06-09 Thread Alex Kiernan
| \ > +(defined(CONFIG_SPL_BLOCK_CACHE) && defined(CONFIG_SPL_BUILD)) > /** Replace with CONFIG_IS_ENABLED? > * blkcache_read() - attempt to read a set of blocks from cache > * > -- > 2.17.1 > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot -- Alex Kiernan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] tools: env: Use getline rather than fgets when reading config/script

2018-06-07 Thread Alex Kiernan
When reading the config file, or a script file, use getline rather than fgets so line lengths aren't limited by the size of a compiled in buffer (128 characters for config, 1024 for scripts). Rename 'dump' to 'line' so it's clear we're working with a line of text. Signed-off-by: Alex Kiernan

[U-Boot] [PATCH] env: Add !ENV_IS_IN_EXT4 dependency to ENV_IS_NOWHERE

2018-06-08 Thread Alex Kiernan
If ENV_IS_IN_EXT4 is set you shouldn't be able to select ENV_IS_NOWHERE. Signed-off-by: Alex Kiernan --- env/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/env/Kconfig b/env/Kconfig index f403906b6f..c1d6a9ab57 100644 --- a/env/Kconfig +++ b/env/Kconfig @@ -3,6 +3,7 @@ menu

[U-Boot] Default script entry using FIT format scripts

2018-06-18 Thread Alex Kiernan
inside /configurations for bootable images) be a reasonable approach? Trying to add the full configuration machinery feels over the top (though I'm wondering if down the road we want signed scripts if that might preclude it). -- Alex Kiernan ___ U-Boot

[U-Boot] Duplicate description in Kconfig for SPL_LOAD_FIT/SPL_LOAD_FIT_FULL

2018-06-15 Thread Alex Kiernan
something different? -- Alex Kiernan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] net: fastboot: Fix build when FASTBOOT_FLASH is disabled

2018-06-14 Thread Alex Kiernan
When building without FASTBOOT_FLASH we don't include the intermediate update callback to keep the client alive, so ensure we don't try setting it here. Signed-off-by: Alex Kiernan --- net/fastboot.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/fastboot.c b/net/fastboot.c index

[U-Boot] [PATCH] mmc: Remove hwpartition help text when command is disabled

2018-06-11 Thread Alex Kiernan
When the `mmc hwpartition` command is disabled, remove the associated help text. Signed-off-by: Alex Kiernan --- cmd/mmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/mmc.c b/cmd/mmc.c index c2ee2d9c0a..3920a1836a 100644 --- a/cmd/mmc.c +++ b/cmd/mmc.c @@ -935,6 +935,7

Re: [U-Boot] [PATCH v2 1/2] buildman: Extract environment as part of each build

2018-05-30 Thread Alex Kiernan
On Wed, May 30, 2018 at 8:18 PM Simon Glass wrote: > > On 30 May 2018 at 04:07, Alex Kiernan wrote: > > On Tue, May 29, 2018 at 5:24 PM Alex Kiernan wrote: > > > >> As we're building the boards, extract the default U-Boot environment to > >> uboo

[U-Boot] [PATCH v2 2/2] Migrate bootlimit to Kconfig

2018-05-30 Thread Alex Kiernan
a SYS_CONFIG_NAME, but only display5_defconfig enables CONFIG_BOOTCOUNT_LIMIT, so we fail to set bootlimit= in display5_factory_defconfig. This is okay because the display5_factory_defconfig doesn't need to have it set, as it is only meant to prepare the board in the factory. Signed-off-by: Alex Kiernan

[U-Boot] [PATCH v2 0/2] Add bootlimit to Kconfig

2018-05-30 Thread Alex Kiernan
This patch series adds the bootlimit environment variable to Kconfig and migrates users to it. Changes in v2: - include display5 in the migration to Kconfig Alex Kiernan (2): Add BOOTCOUNT_BOOTLIMIT to set reboot limit Migrate bootlimit to Kconfig configs/brppt1_mmc_defconfig

[U-Boot] [PATCH v3 1/2] buildman: Extract environment as part of each build

2018-05-30 Thread Alex Kiernan
As we're building the boards, extract the default U-Boot environment to uboot.env so we can interrogate it later. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass --- Changes in v3: - update tests for our usage of objcopy Changes in v2: - capture stderr/stdout so when the build fails we

[U-Boot] [PATCH v2 1/2] Add BOOTCOUNT_BOOTLIMIT to set reboot limit

2018-05-30 Thread Alex Kiernan
Add ability to set environment bootlimit from Kconfig Signed-off-by: Alex Kiernan --- Changes in v2: None drivers/bootcount/Kconfig | 8 include/env_default.h | 3 +++ 2 files changed, 11 insertions(+) diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig index

[U-Boot] [PATCH v3 2/2] buildman: Add support for environment delta in summary

2018-05-30 Thread Alex Kiernan
When summarising the builds, add the -U option to emit delta lines for the default environment built into U-Boot at each commit. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: - update buildman README to cover -U option tools/buildman/README

Re: [U-Boot] [PATCH v2 1/2] buildman: Extract environment as part of each build

2018-05-30 Thread Alex Kiernan
On Tue, May 29, 2018 at 5:24 PM Alex Kiernan wrote: > As we're building the boards, extract the default U-Boot environment to > uboot.env so we can interrogate it later. > Signed-off-by: Alex Kiernan > --- > Changes in v2: > - capture stderr/stdout so when the build fail

Re: [U-Boot] [PATCH v7 00/18] Add fastboot UDP support

2018-05-29 Thread Alex Kiernan
gt; CONFIG_FASTBOOT_BUF_ADDR for use as a marker on reboot (the AOSP code > > in common/android-bootloader.c uses this marker - this code could be > > reinstated there if that gets merged). > > - Merge USB and UDP boot code. The USB implementation stays the > > same, but UD

Re: [U-Boot] [PATCH] configs: Remove empty #ifdef/#ifndef blocks from configs

2018-06-03 Thread Alex Kiernan
On Sun, Jun 3, 2018 at 12:18 PM Chris Packham wrote: > > > > On Sun, 3 Jun 2018, 8:15 AM Alex Kiernan, wrote: >> >> Remove empty #ifdef/#ifndef..#endif blocks where the configuration they >> guarded has been completely removed. >> >> Signed-off-by: Al

Re: [U-Boot] [PATCH] patman: Fix unit tests for SPDX

2018-05-31 Thread Alex Kiernan
On Wed, May 16, 2018 at 7:48 AM Simon Glass wrote: > > The format of this line has changed. Update the patman test to suit. > > Signed-off-by: Simon Glass Tested-by: Alex Kiernan > --- > > tools/patman/test.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

[U-Boot] flex, bison needed

2018-06-02 Thread Alex Kiernan
Not a problem per-se, but it tripped up my builds running against master... It looks like we now need flex and bison installed in order to build, whereas previously we shipped the generated files as part of the tree. -- Alex Kiernan ___ U-Boot mailing

[U-Boot] [PATCH] configs: Remove empty #ifdef/#ifndef blocks from configs

2018-06-02 Thread Alex Kiernan
Remove empty #ifdef/#ifndef..#endif blocks where the configuration they guarded has been completely removed. Signed-off-by: Alex Kiernan --- arch/powerpc/include/asm/config.h| 3 --- include/configs/MPC8610HPCD.h| 2 -- include/configs/P1022DS.h| 3 --- include/configs

[U-Boot] Rewriting fw_{printenv,getenv} to not use fgets

2018-06-06 Thread Alex Kiernan
as a library, so I'm guessing I need to make linking of getline.c conditional somehow. Does that make sense? Or should I be attempting it some other way. -- Alex Kiernan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Rewriting fw_{printenv,getenv} to not use fgets

2018-06-07 Thread Alex Kiernan
Hi Stefano On Thu, Jun 7, 2018 at 8:16 AM Stefano Babic wrote: > > Hi Alex, > > On 06/06/2018 18:33, Alex Kiernan wrote: > > The line length limit that fw_{printenv,setenv} impose (1024 > > characters) has tripped me up twice in as many days, so I figured I'd > > r

Re: [U-Boot] Rewriting fw_{printenv,getenv} to not use fgets

2018-06-07 Thread Alex Kiernan
Hi Stefano On Thu, Jun 7, 2018 at 9:15 AM Stefano Babic wrote: > > Hi Alex, > > On 07/06/2018 10:07, Alex Kiernan wrote: > > Hi Stefano > > > > On Thu, Jun 7, 2018 at 8:16 AM Stefano Babic wrote: > >> > >> Hi Alex, > >> > >> On

[U-Boot] [PATCH v2 2/2] buildman: Add support for environment delta in summary

2018-05-29 Thread Alex Kiernan
When summarising the builds, add the -U option to emit delta lines for the default environment built into U-Boot at each commit. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass --- Changes in v2: - update buildman README to cover -U option tools/buildman/README | 28

[U-Boot] [PATCH v2 1/2] buildman: Extract environment as part of each build

2018-05-29 Thread Alex Kiernan
As we're building the boards, extract the default U-Boot environment to uboot.env so we can interrogate it later. Signed-off-by: Alex Kiernan --- Changes in v2: - capture stderr/stdout so when the build fails we don't produce spurious output as part of the build tools/buildman

[U-Boot] [PATCH v8 02/18] fastboot: Refactor fastboot_okay/fail to take response

2018-05-29 Thread Alex Kiernan
Add the response string as a parameter to fastboot_okay/fail, instead of modifying a global, to match the contract expected by the AOSP U-Boot code. Signed-off-by: Alex Kiernan Reviewed-by: Joe Hershberger --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None

[U-Boot] [PATCH v8 04/18] fastboot: Correct dependencies in FASTBOOT_FLASH

2018-05-29 Thread Alex Kiernan
/DOS_PARTITION enabled. Delete redundant FASTBOOT_FLASH_NAND_DEV from Kconfig - it was only ever used as a guard and the value was ignored in all cases, we're using FASTBOOT_FLASH_NAND as the guard now. Signed-off-by: Alex Kiernan Reviewed-by: Joe Hershberger --- Changes in v8: None Changes

[U-Boot] [PATCH v8 11/18] ti: fastboot: Move weak overrides to board files

2018-05-29 Thread Alex Kiernan
Overriding fastboot_set_reboot_flag() in arch/arm/mach-omap2/boot-common.c leaves it applying all boards that derive from this, not just the ones which have support for Android bootloader flow. Move the weak function override to the relevant board files. Signed-off-by: Alex Kiernan Reviewed

[U-Boot] [PATCH v8 06/18] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME

2018-05-29 Thread Alex Kiernan
CONFIG_FASTBOOT_GPT_NAME and CONFIG_FASTBOOT_MBR_NAME are always defined by Kconfig if you're compiling this code, so remove these redundant defaults. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass Acked-by: Joe Hershberger --- Changes in v8: None Changes in v7: None Changes in v6: None

[U-Boot] [PATCH v8 05/18] fastboot: Add missing newlines

2018-05-29 Thread Alex Kiernan
Add newlines so we format our output correctly. Signed-off-by: Alex Kiernan Acked-by: Joe Hershberger Reviewed-by: Jocelyn Bohr --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/fastboot

[U-Boot] [PATCH v8 08/18] fastboot: Rename fb_set_reboot_flag to fastboot_set_reboot_flag

2018-05-29 Thread Alex Kiernan
call it from non-USB fastboot code. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass Acked-by: Joe Hershberger --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - new Changes in v2: None arch/arm/mach-omap2/boot

[U-Boot] [PATCH v8 10/18] fastboot: Rename public fb_ functions to fastboot_

2018-05-29 Thread Alex Kiernan
Rename fb_mmc_flash_write/fb_mmc_erase/fb_nand_flash_write/fb_nand_erase to fastboot_... as they form a public interface Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass --- Changes in v8: None Changes in v7: None Changes in v6: - add docbook comments Changes in v5: - new Changes in v4

[U-Boot] [PATCH v8 13/18] fastboot: Migrate FASTBOOT_FLASH_NAND_TRIMFFS to Kconfig

2018-05-29 Thread Alex Kiernan
Add FASTBOOT_FLASH_NAND_TRIMFFS to Kconfig; note there are no in-tree users of it. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: - new Changes in v4: None Changes in v3: None Changes in v2: None drivers

[U-Boot] [PATCH v8 15/18] net: fastboot: Merge AOSP UDP fastboot

2018-05-29 Thread Alex Kiernan
Merge UDP fastboot support from AOSP: https://android.googlesource.com/platform/external/u-boot/+/android-o-mr1-iot-preview-8 Signed-off-by: Alex Kiernan Signed-off-by: Alex Deymo Signed-off-by: Jocelyn Bohr Reviewed-by: Simon Glass --- Changes in v8: None Changes in v7: None Changes

[U-Boot] [PATCH v8 09/18] fastboot: Extract common definitions from USB fastboot

2018-05-29 Thread Alex Kiernan
Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code we only have one definition. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass Acked-by: Joe Hershberger --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - leave

[U-Boot] [PATCH v8 01/18] fastboot: Move fastboot to drivers/fastboot

2018-05-29 Thread Alex Kiernan
behaviour. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass Acked-by: Joe Hershberger --- Changes in v8: None Changes in v7: None Changes in v6: - accomodate master change and switch dependency on imx6dl_mamoj from FASTBOOT to USB_FUNCTION_FASTBOOT Changes in v5: - don't depend

[U-Boot] [PATCH v8 03/18] fastboot: Extract fastboot_okay/fail to fb_common.c

2018-05-29 Thread Alex Kiernan
-by: Alex Kiernan Reviewed-by: Joe Hershberger --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: - fix docbook formatting Changes in v4: - add docbook comments Changes in v3: - Merge subsequent patch for formatting response strings into this one - allow NULL

[U-Boot] [PATCH v8 12/18] fs: Add fs_get_type_name to return current filesystem name

2018-05-29 Thread Alex Kiernan
Add fs_get_type_name so we can get the current filesystem type. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass Reviewed-by: Joe Hershberger --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - add docbook comments Changes in v3: - new

[U-Boot] [PATCH v8 07/18] fastboot: Fix parameter types in _fb_nand_write

2018-05-29 Thread Alex Kiernan
(struct mtd_info *mtd, loff_t offset, size_t *length, ^~~ Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass Acked-by: Joe Hershberger --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - new Changes in v2

[U-Boot] [PATCH v8 18/18] fastboot: Update fastboot documentation

2018-05-29 Thread Alex Kiernan
Update fastboot documentation to reflect merged USB/UDP implementation. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass --- Changes in v8: - add Reviewed-by: tag Changes in v7: None Changes in v6: - new Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None

[U-Boot] [PATCH v8 16/18] fastboot: Add support for 'oem format' command

2018-05-29 Thread Alex Kiernan
Introduce 'oem format' which matches the USB implementation, guard this with CONFIG_FASTBOOT_CMD_OEM_FORMAT so that you can configure it out. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: - new Changes in v4

[U-Boot] [PATCH v8 00/18] Add fastboot UDP support

2018-05-29 Thread Alex Kiernan
otocol handling from the fastboot UDP code in preparation for reusing it in the USB code. Changes in v2: - ensure fastboot syntax is backward compatible - 'fastboot 0' means 'fastboot usb 0' Alex Kiernan (18): fastboot: Move fastboot to drivers/fastboot fastboot: Refactor fastboot_okay/f

[U-Boot] [PATCH v8 17/18] usb: fastboot: Convert USB f_fastboot to shared fastboot

2018-05-29 Thread Alex Kiernan
Convert USB fastboot code to use shared fastboot protocol. Signed-off-by: Alex Kiernan Reviewed-by: Simon Glass --- Changes in v8: - add Reviewed-by: tag Changes in v7: - set FASTBOOT_CMD_OEM_FORMAT for all existing users of FASTBOOT_FLASH_MMC_DEV that also have CMD_GPT Changes in v6

[U-Boot] [PATCH v8 14/18] mmc: Separate "mmc swrite" from fastboot

2018-05-29 Thread Alex Kiernan
to Kconfig. Signed-off-by: Alex Kiernan Acked-by: Jassi Brar Reviewed-by: Simon Glass --- Changes in v8: - add Reviewed-by: tag Changes in v7: None Changes in v6: None Changes in v5: - rename CONFIG_FASTBOOT_FLASH_FILLBUF_SIZE to CONFIG_IMAGE_SPARSE_FILLBUF_SIZE and migrate it to Kconfig. Cha

Re: [U-Boot] CONFIG_BOOTDELAY and env_default.h

2018-07-02 Thread Alex Kiernan
On Mon, Jul 2, 2018 at 3:25 AM Tom Rini wrote: > > On Fri, Jun 29, 2018 at 09:19:34PM -0700, Simon Glass wrote: > > +Tom > > > > Hi Alex, > > > > On 29 June 2018 at 02:31, Alex Kiernan wrote: > > > > > > I've just been digging into a probl

[U-Boot] [PATCH 1/2] mkimage: Refactor imagetool_get_source_date to take command name

2018-06-20 Thread Alex Kiernan
So we can use imagetool_get_source_date() from callers who do not have the image tool params struct, just pass in the command name for the error message. Signed-off-by: Alex Kiernan --- tools/default_image.c | 2 +- tools/fit_image.c | 3 ++- tools/imagetool.c | 4 ++-- tools

[U-Boot] [PATCH 2/2] mkimage: fit_image: Add support for SOURCE_DATE_EPOCH in signatures

2018-06-20 Thread Alex Kiernan
When generating timestamps in signatures, use imagetool_get_source_date() so we can be overridden by SOURCE_DATE_EPOCH to generate reproducible images. Signed-off-by: Alex Kiernan --- include/image.h| 3 ++- tools/fit_image.c | 3 ++- tools/image-host.c | 34

Re: [U-Boot] [PATCH v5 4/5] cmd: nvedit: env import can now import only variables passed as parameters

2018-07-02 Thread Alex Kiernan
gt; the example for this is basically: env import 0xaddr varA varB varC > > What I suggested is to modify 3 and 4) to the following: > 3) himport_r WITH a list of variables (vars!=NULL) and with flag = 0: > = import the variables vars from the environnement to be imported, IF > a v

Re: [U-Boot] [RFC PATCH v2 00/20] Add fastboot UDP support

2018-05-02 Thread Alex Kiernan
tches should I add a "Reviewed-by:" line if > the change looks good to me? Yes please! > Thanks, > Jocelyn > On Mon, Apr 30, 2018 at 1:33 AM Alex Kiernan <alex.kier...@gmail.com> wrote: >> This series merges the fastboot UDP support from AOSP into mainline &

Re: [U-Boot] [RFC PATCH v2 13/20] fastboot: Merge reboot-bootloader handling

2018-05-02 Thread Alex Kiernan
On Wed, May 2, 2018 at 6:51 AM Jocelyn Bohr <b...@verily.com> wrote: > On Tue, May 1, 2018 at 10:46 PM Jocelyn Bohr <b...@google.com> wrote: >> On Tue, May 1, 2018 at 1:21 AM Alex Kiernan <alex.kier...@gmail.com> wrote: >>> On Tue, May 1, 2018 at 8:22 AM

Re: [U-Boot] [RFC PATCH v2 13/20] fastboot: Merge reboot-bootloader handling

2018-05-01 Thread Alex Kiernan
On Tue, May 1, 2018 at 8:22 AM Alex Kiernan <alex.kier...@gmail.com> wrote: > On Tue, May 1, 2018 at 7:50 AM Jocelyn Bohr <b...@google.com> wrote: > > On Mon, Apr 30, 2018 at 1:33 AM Alex Kiernan <alex.kier...@gmail.com> > wrote: > >> Extract fb_set_reb

Re: [U-Boot] [RFC PATCH v2 13/20] fastboot: Merge reboot-bootloader handling

2018-05-01 Thread Alex Kiernan
On Tue, May 1, 2018 at 7:50 AM Jocelyn Bohr <b...@google.com> wrote: > On Mon, Apr 30, 2018 at 1:33 AM Alex Kiernan <alex.kier...@gmail.com> wrote: >> Extract fb_set_reboot_flag() from USB code and ensure all the overides >> are included, then make the UDP fastboo

[U-Boot] [RFC PATCH v2 00/20] Add fastboot UDP support

2018-04-30 Thread Alex Kiernan
the basis of a consolidated implementation, but I'm inclined to address that as a clearly separate patch so it can be tested in isolation (I have no USB hardware I can try this on). Changes in v2: - ensure fastboot syntax is backward compatible - 'fastboot 0' means 'fastboot usb 0' Alex Kiernan (20

[U-Boot] [RFC PATCH v2 02/20] fastboot: Switch dependencies on FASTBOOT to USB_FUNCTION_FASTBOOT

2018-04-30 Thread Alex Kiernan
Anyone who wants FASTBOOT before this series wants USB_FUNCTION_FASTBOOT. Split USB_FUNCTION_FASTBOOT from FASTBOOT so they retain their existing behaviour. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v2: None arch/arm/Kconfig

[U-Boot] [RFC PATCH v2 01/20] fastboot: Move fastboot to drivers/fastboot

2018-04-30 Thread Alex Kiernan
Separate CMD_FASTBOOT from FASTBOOT and move code and configuration to drivers/fastboot. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v2: None cmd/Kconfig | 14 -- common/Makefile

[U-Boot] [RFC PATCH v2 07/20] net: fastboot: Merge AOSP UDP fastboot

2018-04-30 Thread Alex Kiernan
Merge UDP fastboot support from AOSP: https://android.googlesource.com/platform/external/u-boot/+/android-o-mr1-iot-preview-8 Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Signed-off-by: Alex Deymo <de...@google.com> --- Changes in v2: - ensure fastboot syntax is backwar

[U-Boot] [RFC PATCH v2 17/20] fastboot: Guard getvar:partition-type/size with MMC

2018-04-30 Thread Alex Kiernan
Add guard for partition-type/size against MMC as we need that in order to lookup partitions. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> --- Changes in v2: None drivers/fastboot/fb_getvar.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/fastboot/fb_getvar.c b/d

<    1   2   3   4   5   >