[U-Boot] [PATCH] beagleboard: Remove side effects of i2c2 pullup resisters initialization code

affect following: * disable i2c1 pullup resisters * increase far end load setting for many modules * setup invalid SC/LB combination Signed-off-by: Alexander Kochetkov al.koc...@gmail.com CC: Tom Rini tr...@ti.com CC: Steve Kipisz s-kipi...@ti.com --- board/ti/beagle/beagle.c |5 - 1 file

Re: [U-Boot] [PATCH] mmc: fix off-by-one bug in mmc_startup_v4()

> Do you mean SD-card or MMC-card? :) > SD doesn't have EXT_CSD register. I see now. MMC-card. So, send v2? or you can simple fix SD with MMC in commit msg. > > - Removed Pantelis's mail account. Instead, add my account, plz. I took it from here: https://www.denx.de/wiki/U-Boot/Custodians

Re: [U-Boot] [PATCH] mmc: fix off-by-one bug in mmc_startup_v4()

> 21 февр. 2018 г., в 9:37, Jaehoon Chung написал(а): > > I'm confusing about commit-msg. "SD-card with EXT_CSD_REV"? > > Best Regards, > Jaehoon Chung I glad to write better, but don’t know. Would this one better? In future, SD-cards with revision 9 (with REV value 9

Re: [U-Boot] [PATCH] mmc: fix eMMC v5.1 incorrect version detection

> 20 февр. 2018 г., в 13:02, Jaehoon Chung написал(а): > >> Also the patch fix mmc_versions array bounds check. Value 8 >> produced out of array access. > > It was already fixed. > >

[U-Boot] [PATCH] mmc: fix eMMC v5.1 incorrect version detection

array bounds check. Value 8 produced out of array access. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/mmc/mmc.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 255310a..c8c13bd 100644 --- a/drive

[U-Boot] [PATCH] mmc: fix off-by-one bug in mmc_startup_v4()

SD-card with EXT_CSD_REV value 9 will trigger off-by-one bug while accessing mmc_versions array. The patch fix that. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/mmc/mmc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/mmc.c b/d

[U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

In order to make I2C work on rk3066 and rk3188 boards GFR must be updated. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/i2c/rk_i2c.c | 85 +++--- 1 file changed, 80 insertions(+), 5 deletions(-) diff --git a/drive

Re: [U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

Hello, Philipp! > > What exactly are you trying to configure here? > > Do you need to bring these out of reset, is this some IO config or > are these clock gates? Note that if it’s any of these, then the > respective drivers (i.e. reset, pinctrl, clock) should be modified > instead of putting

[U-Boot] [PATCH v2] rockchip: i2c: enable new I2C controller for rk3066 and rk3188

-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/i2c/rk_i2c.c | 90 +++--- 1 file changed, 85 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/rk_i2c.c b/drivers/i2c/rk_i2c.c index 332280c..ce6b441 100644 --- a/drivers/i2c/rk

Re: [U-Boot] [PATCH v2] rockchip: i2c: enable new I2C controller for rk3066 and rk3188

> 26 февр. 2018 г., в 23:26, Dr. Philipp Tomsich > написал(а): > > I wonder if this is really necessary (or if there’s something going wrong in > the > device framework)… The way I always understood our device framework was > that if there’s a pinctrl

[U-Boot] [PATCH v2 1/2] dm: i2c: dts: Add gpios and pinctrl device tree properties

The commit describe usage of gpios and pinctrl device tree properties in order to enable gpio-based software deblocking. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- doc/device-tree-bindings/i2c/i2c.txt | 13 + 1 file changed, 13 insertions(+) diff --git

[U-Boot] [PATCH v2 0/2] dm: i2c: implement gpio-based I2C deblock

, PIN_COUNT constants for i2c-uclass.c. The same constants exist in the i2c-gpio.c. Should I place them into i2c.h or may leave as is? [1] https://lists.denx.de/pipermail/u-boot/2018-March/thread.html#321755 Alexander Kochetkov (2): dm: i2c: dts: Add gpios and pinctrl device tree properties dm

[U-Boot] [PATCH v2 2/2] dm: i2c: implement gpio-based I2C deblock

The commit implement a gpio-based software deblocking. The code extract I2C pins description from device tree, switch pins to GPIO mode, toggle SCL until slave release SDA, send I2C stop and switch I2C pins back to I2C mode. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- d

Re: [U-Boot] [PATCH 26/36] rockchip: rk1108: remove rockchip timer for sys timer

The question is: does rk3066 and rk3188 have arch timer? If no, than removing rk_timer will break u-boot for these chips. And my comment was about global timer, not arch timer. And I failed to enable arch timer for rk3188 in the kernel. Alexander. > 27 марта 2018 г., в 19:07, Alexan

Re: [U-Boot] [PATCH 26/36] rockchip: rk1108: remove rockchip timer for sys timer

> 27 марта 2018 г., в 12:29, Kever Yang написал(а): > > We use ARM arch timer instead. Hi, Kever! Just let you know, that arch timer rate on rk3066 and rk3188 depends on CPU frequency. I’ve made patch[1] for fixing that in kernel. If u-boot do arm clock changes

Re: [U-Boot] [PATCH 26/36] rockchip: rk1108: remove rockchip timer for sys timer

9ffb05e4 r5 : 9ffb0658 r4 : 3ff75000 r3 : 10001000 r2 : 8000 r1 : 20008000 r0 : 20008000 Flags: nzcv IRQs off FIQs off Mode SVC_32 Regards, Alexander. > 28 марта 2018 г., в 5:33, Kever Yang <kever.y...@rock-chips.com> написал(а): > > Hi Alexander, > > &g

Re: [U-Boot] Moving the rk_board_late_init() hook to a device-model based implementation.

> 20 марта 2018 г., в 17:03, Kever Yang написал(а): > > Maybe we can discuss this again after I send my patches. Hello, Kever! Please cc me on your patch series. Regards, Alexander. ___ U-Boot mailing list

Re: [U-Boot] [PATCH] dm: i2c: implement gpio-based I2C deblock

> 23 марта 2018 г., в 10:35, Heiko Schocher написал(а): > > Just triggered an travis build (not finsihed yet), and your patch drops > errors for arm926ejs boards: > > https://travis-ci.org/hsdenx/u-boot-i2c/jobs/357258790 > > So, can you do a full travis build for your patch

Re: [U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

> 26 февр. 2018 г., в 12:43, Dr. Philipp Tomsich > написал(а): > > However, the GRF drivers first need to be cleaned up (i.e. the enums for the > IOMUX definitions need to move into the pinctrl drivers), so only the > structure > definitions remain in

[U-Boot] [PATCH] rockchip: clk: rk3188: update dpll settings to make EMAC work

rock. EMAC sends packets to network, but it doesn't receive anything. ifconfig shows a lot of framing errors. [1] https://github.com/linux-rockchip/u-boot-rockchip/blob/u-boot-rk3288/ tools/rk_tools/3188_LPDDR2_300MHz_DDR3_300MHz_20130830.bin Signed-off-by: Alexander Kochetkov <al.

[U-Boot] [PATCH 1/2] rockchip: pinctrl: rk3036: Move the iomux definitions into pinctrl-driver

Clean the iomux definitions at grf_rk3036.h, and move them into pinctrl-driver for resolving the compiling error of redefinition. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- arch/arm/include/asm/arch-rockchip/grf_rk3036.h | 409 -- drivers/pinctrl/ro

[U-Boot] [PATCH 0/2] Move the iomux definitions into pinctrl-driver

Two patches similar to commit 301fff4e574d373a139dd47aceabc5b4259873da. Alexander Kochetkov (2): rockchip: pinctrl: rk3036: Move the iomux definitions into pinctrl-driver rockchip: pinctrl: rk3188: Move the iomux definitions into pinctrl-driver arch/arm/include/asm/arch-rockchip

[U-Boot] [PATCH 2/2] rockchip: pinctrl: rk3188: Move the iomux definitions into pinctrl-driver

Clean the iomux definitions at grf_rk3188.h, and move them into pinctrl-driver for resolving the compiling error of redefinition. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- arch/arm/include/asm/arch-rockchip/grf_rk3188.h | 380 --- drivers/pinctrl/ro

Re: [U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

This one patch not needed. Just found, that the code already implemented in the pinctrl_rk3188_i2c_config(). It’s mystery for me why pinctrl is not called for i2c DT nodes automatically. If I do explicit call "ret = pinctrl_request_noflags(pinctrl, PERIPH_ID_I2C0);» all will work. Is this

[U-Boot] [PATCH] rockchip: rk3188: add rk_board_late_init() hook

All other rockchip boards have rk_board_late_init() hook, so add it to rk3188 boards also. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- arch/arm/mach-rockchip/rk3188-board.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-rockchip/

[U-Boot] [PATCH] dm: i2c: implement gpio-based I2C deblock

The commit extract gpio description from device tree, setup pins and toggle them until I2C slave device release SDA. Any comments? Ideas? Could someone review the patch and tell that should I do with it in order to bring the patch to u-boot? Signed-off-by: Alexander Kochetkov <al.

Re: [U-Boot] [PATCH 32/36] rockchip: remove rk_timer

Hello, Kever! Please keep rk_timer.c for rk3188 and other legacy chips. There is no ARM generic timer in this SoC. This SoC only have private timers. see https://community.arm.com/developer/ip-products/processors/f/cortex-a-forum/1449/generic-timer-on-cortex-a7-cortex-a9 > 27 марта 2018 г., в

Re: [PATCH 2/2] rockchip: clk: rk3188: enable bwadj for rk3188 DPLL

z before: 2018: con2=10b, clr=fff, set=24 after: 2018: con2=24 > 27 июня 2020 г., в 18:17, Kever Yang написал(а): > > Hi Alex, > > I think it will be better to update the rk3188_clk_probe() function > instead of > > what you have modified if the RK3188 and RK3188A has the

Re: [PATCH] rockchip: i2c: fix switch to new implementation for rk3188

this? > > > Hi Alex, > > Thanks for your patch. > > On 2020/6/22 下午9:06, Alexander Kochetkov wrote: >> The commit e7ae4cf27a6d 'pinctrl: rockchip: Add common rockchip >> pinctrl driver' dropped rk3188_pinctrl_request operation, that >> did switching t

[PATCH 0/2] v2: rr3188: change APP to 600MHz and enable bwadj for DPLL

Hello! Here are two patches I found usefull for rk3188. Changes in v2: Add u-boot@lists.denx.de as addressee. Alexander Kochetkov (2): rockchip: clk: rk3188: change APLL to safe 600MHz rockchip: clk: rk3188: enable bwadj for rk3188 DPLL drivers/clk/rockchip/clk_rk3188.c | 11 ++- 1

[PATCH 1/2] rockchip: clk: rk3188: change APLL to safe 600MHz

e armclk in spl"). Fixes commit 84a6a27ae3ff ("rockchip: rk3188: init CPU freq in clock driver"). Signed-off-by: Alexander Kochetkov --- drivers/clk/rockchip/clk_rk3188.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/rockchip/clk_rk3188.c b/dri

[PATCH 2/2] rockchip: clk: rk3188: enable bwadj for rk3188 DPLL

Empirically, I found that DPLL on rk3188 has bwadj registers. Configuring DPLL with bwadj increase DPLL stability. Because of DPLL provide clock for ethernet, enabling bwaj reduces the number of errors on the ethernet. Signed-off-by: Alexander Kochetkov --- drivers/clk/rockchip/clk_rk3188.c | 8

[PATCH] rockchip: i2c: fix switch to new implementation for rk3188

implemented as a stub returning -ENOSYS. Signed-off-by: Alexander Kochetkov --- drivers/i2c/rk_i2c.c | 42 +++--- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/rk_i2c.c b/drivers/i2c/rk_i2c.c index 32b2ee8578..ad3c66843b 100644

[PATCH] rockchip: rk3188: Fix back to BROM boot

Move the setting for noc remap out of SPL code. Changing noc remap inside SPL results in breaking back to BROM boot. Fixes commit c14fe2a8e192 ("rockchip: rk3188: Move SoC one time setting into arch_cpu_init()"). Signed-off-by: Alexander Kochetkov --- arch/arm/mach-rockchip/rk318

Re: [PATCH] i2c: correct I2C deblock logic

Hello Haibo Chen! Setting GPIOD_ACTIVE_LOW has no effect. It filtered out by dm_gpio_set_dir_flags(). > > > if (bit) > - dm_gpio_set_dir_flags(pin, GPIOD_IS_IN); > + dm_gpio_set_dir_flags(pin, GPIOD_IS_IN | > +GPIOD_ACTIVE_LOW); Here in original code GPIOD_ACTIVE_LOW has not effect. else

Re: [PATCH] i2c: correct I2C deblock logic

_IN); } else { dm_gpio_set_dir_flags(pin, GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE); } } static int i2c_gpio_get_pin(struct gpio_desc *pin) { return !dm_gpio_get_value(pin); } > 23 марта 2023 г., в 11:43, Alexander Kochetkov > написал(а): > > Hello Haibo Chen! > > Set

Re: [PATCH] i2c: correct I2C deblock logic

s-> dm_gpio_clrset_flags, it only > clear GPIOD_MASK_DIR, this has no impact with GPIOD_ACTIVE_LOW. So this > GPIOD_ACTIVE_LOW keep in flags. > 23 марта 2023 г., в 13:41, Bough Chen написал(а): > >> -Original Message- >> From: Alexander Kochetkov mailto:al.ko

Re: [PATCH] i2c: correct I2C deblock logic

г., в 11:37, Bough Chen написал(а): > >> -Original Message----- >> From: Alexander Kochetkov >> Sent: 2023年3月20日 16:03 >> To: h...@denx.de >> Cc: Bough Chen ; ma...@denx.de; >> u-boot@lists.denx.de; dl-uboot-imx ; >> xypron.g...@gmx.de; Simon Glas

Re: [PATCH] gpio: add GPIOD_ACTIVE_LOW into GPIOD_MASK_DIR

Reviewed-by: Alexander Kochetkov > 22 марта 2023 г., в 14:26, haibo.c...@nxp.com написал(а): > > From: Haibo Chen > > dm_gpio_set_dir_flags() will clear GPIOD_MASK_DIR and set new flags. > But there are cases like i2c_deblock_gpio_loop() will do like this: > > -first

Re: [PATCH] i2c: correct I2C deblock logic

Hello! The patch doesn’t add new functionality to the code. May be it makes code more readable. But in later case the patch description should be corrected and Fixes tag removed. The flag GPIOD_ACTIVE_LOW affects return value dm_gpio_get_value(). And return value doesn’t depends on the DTS

Re: [PATCH v3] i2c: correct I2C deblock logic

Hello Haibo Chen. The patch looks fine! Reviewed-by: Alexander Kochetkov mailto:al.koc...@gmail.com>> > 27 марта 2023 г., в 14:21, haibo.c...@nxp.com написал(а): > > From: Haibo Chen > > Current code use dm_gpio_get_value() to get SDA and SCL value, and the > valu