Re: [PATCH v2] common: console: Fix print complete stdio device list

2024-01-17 Thread Bin Meng
b38d ("console: Print out complete stdio device list") > > Signed-off-by: Patrice Chotard > > --- > > Changes in v2: > - simplify code suggested by Bin Meng > > common/console.c | 27 --- > 1 file changed, 12 insertions(+), 15 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH] common: console: Fix print complete stdio device list

2024-01-16 Thread Bin Meng
On Wed, Jan 17, 2024 at 12:13 AM Patrice Chotard wrote: > > In case CONSOLE_MUX and SYS_CONSOLE_IS_IN_ENV are on and > stdin or stdout or stderr are missing in environment, as fallback, get > these either from stdio_devices[std] or stdio_devices[std]->name. > > Fixes: 6b343ab38d ("console: Print

Re: [PATCH 2/2] coreboot: Switch to a monospaced font

2024-01-08 Thread Bin Meng
+ Tom and Anatolij, On Mon, Jan 8, 2024 at 5:33 PM Dragan Simic wrote: > > On 2024-01-08 10:29, Mark Kettenis wrote: > >> From: Simon Glass > >> Date: Sun, 7 Jan 2024 17:14:55 -0700 > >> > >> The default font is proportional, with different character widths. > >> Select a monospace font for

Re: [PATCH v2 00/19] x86: expo: Add support for editing coreboot CMOS RAM settings

2024-01-05 Thread Bin Meng
Hi Simon, On Sat, Jan 6, 2024 at 9:38 AM Simon Glass wrote: > > Hi Bin, > > On Fri, Jan 5, 2024 at 4:06 PM Bin Meng wrote: > > > > Hi Simon, > > > > On Sat, Jan 6, 2024 at 4:12 AM Simon Glass wrote: > > > > > > Hi Bin, >

Re: [PATCH v2 00/19] x86: expo: Add support for editing coreboot CMOS RAM settings

2024-01-05 Thread Bin Meng
Hi Simon, On Sat, Jan 6, 2024 at 4:12 AM Simon Glass wrote: > > Hi Bin, > > On Thu, Jan 4, 2024 at 4:02 PM Bin Meng wrote: > > > > Hi Simon, > > > > On Thu, Jan 4, 2024 at 11:11 PM Simon Glass wrote: > > > > > > U-Boot provide

[PATCH] doc: coreboot: Update stale graphics enabling instructions

2024-01-04 Thread Bin Meng
From: Bin Meng With latest coreboot (e.g.: v4.22.01), the instructions to enable graphics support has changed. Refresh the doc. Signed-off-by: Bin Meng --- doc/board/coreboot/coreboot.rst | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/doc/board/coreboot

Re: [PATCH v2 00/19] x86: expo: Add support for editing coreboot CMOS RAM settings

2024-01-04 Thread Bin Meng
Hi Simon, On Thu, Jan 4, 2024 at 11:11 PM Simon Glass wrote: > > U-Boot provides support for editing settings with an 'expo', as well as > reading and writing settings to CMOS RAM. > > This series integrates expo functionality with coreboot, using the > sysinfo table to get a list of settings,

[PATCH] tools: docker: Drop the git user name and email configuration

2024-01-04 Thread Bin Meng
Since commit b45ab9ca6621 ("CI: Update to QEMU 8.0.3"), the manual patch applying was removed, hence there is no need to do a git user name and email configuration. Signed-off-by: Bin Meng --- tools/docker/Dockerfile | 3 --- 1 file changed, 3 deletions(-) diff --git a/to

Re: [PATCH 00/34] x86: expo: Add support for editing coreboot CMOS RAM settings

2024-01-04 Thread Bin Meng
Hi Simon, On Sun, Dec 31, 2023 at 8:43 PM Simon Glass wrote: > > Hi Bin, > > On Sun, Dec 31, 2023 at 2:59 AM Bin Meng wrote: > > > > Hi Simon, > > > > On Wed, Nov 15, 2023 at 9:24 PM Simon Glass wrote: > > > > > > Hi Bin, >

Re: [PATCH 00/34] x86: expo: Add support for editing coreboot CMOS RAM settings

2023-12-31 Thread Bin Meng
Hi Simon, On Wed, Nov 15, 2023 at 9:24 PM Simon Glass wrote: > > Hi Bin, > > On Sun, 1 Oct 2023 at 19:16, Simon Glass wrote: > > > > U-Boot provides support for editing settings with an 'expo', as well as > > reading and writing settings to CMOS RAM. > > > > This series integrates expo

Re: [PATCH 2/2] smbios: copy QEMU tables

2023-12-21 Thread Bin Meng
Hi Heinrich, On Thu, Dec 21, 2023 at 6:50 PM Heinrich Schuchardt wrote: > > QEMU provides SMBIOS tables with detailed information. We should not try to > replicate them in U-Boot. > > If we want to inform about U-Boot, we can add a Firmware Inventory > Information (type 45) table in future. > >

Re: [PATCH v3 4/9] risc-v: add ACPI fields to global data

2023-12-19 Thread Bin Meng
> let tables in global data depend on CONFIG_(SPL_)ACPI > v2: > no change > --- > arch/riscv/include/asm/global_data.h | 6 ++ > 1 file changed, 6 insertions(+) > Otherwise, Reviewed-by: Bin Meng

Re: [PATCH v3 8/9] configs: qemu: add config fragment for ACPI

2023-12-19 Thread Bin Meng
Hi Heinrich, On Tue, Dec 19, 2023 at 8:25 PM Heinrich Schuchardt wrote: > > Provide a configuration fragment to enable ACPI on QEMU. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Ilias Apalodimas > Reviewed-by: Simon Glass > --- > v3: > no change > v2: > no change > --- >

Re: [PATCH v4 09/12] x86: Enable SSE in 64-bit mode

2023-11-14 Thread Bin Meng
Hi Tom, On Wed, Nov 15, 2023 at 12:22 AM Tom Rini wrote: > > On Tue, Nov 14, 2023 at 09:49:08AM +0800, Bin Meng wrote: > > Hi Tom, > > > > On Tue, Nov 14, 2023 at 7:52 AM Tom Rini wrote: > > > > > > On Tue, Nov 14, 2023 at 07:46:36AM +0800, Bin Meng wro

Re: [PATCH v4 09/12] x86: Enable SSE in 64-bit mode

2023-11-13 Thread Bin Meng
Hi Tom, On Tue, Nov 14, 2023 at 7:52 AM Tom Rini wrote: > > On Tue, Nov 14, 2023 at 07:46:36AM +0800, Bin Meng wrote: > > Hi Tom, > > > > On Tue, Nov 14, 2023 at 6:59 AM Tom Rini wrote: > > > > > > On Mon, Nov 13, 2023 at 03:28:13P

Re: [PATCH v4 09/12] x86: Enable SSE in 64-bit mode

2023-11-13 Thread Bin Meng
Hi Tom, On Tue, Nov 14, 2023 at 6:59 AM Tom Rini wrote: > > On Mon, Nov 13, 2023 at 03:28:13PM -0700, Simon Glass wrote: > > Hi Bin, > > > > On Mon, 13 Nov 2023 at 15:08, Bin Meng wrote: > > > > > > Hi Simon, > > > >

Re: [PATCH v4 09/12] x86: Enable SSE in 64-bit mode

2023-11-13 Thread Bin Meng
ff-by: Simon Glass > Suggested-by: Bin Meng > --- > > Changes in v4: > - Use a Kconfig option > > arch/x86/Kconfig | 8 > arch/x86/config.mk| 4 > arch/x86/cpu/x86_64/cpu.c | 12 > drivers/video/Kconfig | 1 + > 4 fi

Re: [PATCH v3 09/12] x86: Enable SSE in 64-bit mode

2023-11-13 Thread Bin Meng
Hi Simon, On Mon, Nov 13, 2023 at 4:02 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 6 Nov 2023 at 08:36, Tom Rini wrote: > > > > On Mon, Nov 06, 2023 at 06:26:15PM +0800, Bin Meng wrote: > > > + Tom, > > > > > > Hi Simon, > > &

Re: [PATCH v3 09/12] x86: Enable SSE in 64-bit mode

2023-11-06 Thread Bin Meng
+ Tom, Hi Simon, On Mon, Nov 6, 2023 at 12:29 AM Simon Glass wrote: > > Hi Bin, > > On Sun, 5 Nov 2023 at 14:05, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Oct 2, 2023 at 9:15 AM Simon Glass wrote: > > > > > > This is neede

Re: [PATCH v2] x86: serial: ns16550: Allow the UART to be silently disabled

2023-11-05 Thread Bin Meng
Hi Simon, On Thu, Nov 2, 2023 at 2:04 AM Simon Glass wrote: > > U-Boot normally requires a UART. When booting from coreboot it is > sometimes just not available, e.g. when no sysinfo or DBG2 information > is provided. > > In this case we need to continue running, since the display can be used. >

Re: [PATCH v3 08/12] video: Drop unnecessary truetype operations from SPL

2023-11-05 Thread Bin Meng
ry truetype operations from SPL > > drivers/video/console_truetype.c | 10 ++ > 1 file changed, 10 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v3 06/12] expo: Correct background colour

2023-11-05 Thread Bin Meng
On Mon, Oct 2, 2023 at 9:30 AM Simon Glass wrote: > > Use the correct background colour when using white-on-black. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > boot/expo.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 01/12] efi: Correct handling of frame buffer

2023-11-05 Thread Bin Meng
> Fixes: 8f661a5b662 ("efi_loader: gop: Expose fb when 32bpp") > --- > > (no changes since v2) > > Changes in v2: > - Rebase to -next > - Add some more comments to the header file > - Add fixes tag > > include/video.h | 9 ++--- > lib/efi_

Re: [PATCH v3 04/12] x86: coreboot: Add a boot script

2023-11-05 Thread Bin Meng
in v3: > - Clear the screen before booting > > Changes in v2: > - Add new patch to add a coreboot boot script > > configs/coreboot64_defconfig | 1 + > configs/coreboot_defconfig | 1 + > 2 files changed, 2 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v3 09/12] x86: Enable SSE in 64-bit mode

2023-11-05 Thread Bin Meng
Hi Simon, On Mon, Oct 2, 2023 at 9:15 AM Simon Glass wrote: > > This is needed to support Truetype fonts. In any case, the compiler > expects SSE to be available in 64-bit mode. Enable it. > > Signed-off-by: Simon Glass > Suggested-by: Bin Meng > --- > > (no chan

Re: [PATCH v2 0/9] ufs: Add a PCI UFS controller support

2023-10-18 Thread Bin Meng
+ Marek, On Wed, Oct 11, 2023 at 9:16 PM Bin Meng wrote: > > This adds a PCI UFS controller support and enables the support on > QEMU RISC-V for testing. > > Requiring QEMU v8.2+. > > This series is avaiable at u-boot-x86/ufs for testing. > > Changes in v2: > - fi

[PATCH v2 1/9] ufs: Correct the UFS terminlogy

2023-10-11 Thread Bin Meng
UFS stands for Universal Flash Storage, not Subsytem. Signed-off-by: Bin Meng --- (no changes since v1) cmd/Kconfig | 2 +- drivers/ufs/ufs-uclass.c | 2 +- drivers/ufs/ufs.c| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/Kconfig b/cmd/Kconfig

[PATCH v2 8/9] ufs: Handle UFS 3.1 controllers

2023-10-11 Thread Bin Meng
Extend the version check to handle UFS 3.1 controllers as well. Tested on QEMU emulated UFS 3.1 controller. Signed-off-by: Bin Meng --- (no changes since v1) drivers/ufs/ufs.c | 3 ++- drivers/ufs/ufs.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/ufs.c b

[PATCH v2 4/9] cmd: ufs: Correct the help text

2023-10-11 Thread Bin Meng
Remove the additional space and use "sub-system" for consistency with other commands like "scsi" and "usb". Signed-off-by: Bin Meng --- (no changes since v1) cmd/ufs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/ufs.c b/cmd/ufs.c index

[PATCH v2 5/9] pci_ids: Add Red Hat vendor and device IDs

2023-10-11 Thread Bin Meng
Red Hat, Inc. donates a part of its device ID range [1] to QEMU, to be used for virtual devices. This commit adds several typical devices that are useful in U-Boot. [1] https://www.qemu.org/docs/master/specs/pci-ids.html Signed-off-by: Bin Meng --- (no changes since v1) include/pci_ids.h | 7

[PATCH v2 6/9] ufs: Allow mmio registers on the PCI bus

2023-10-11 Thread Bin Meng
Check if the UFS controller is on the PCI bus, and get its register base address accordingly. Signed-off-by: Bin Meng --- (no changes since v1) drivers/ufs/ufs.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/ufs.c b/drivers/ufs/ufs.c index

[PATCH v2 7/9] ufs: Add a PCI based UFS controller driver

2023-10-11 Thread Bin Meng
This adds a simple PCI based UFS controller driver with a QEMU emulated UFS controller on the PCI bus. Requiring QEMU v8.2+. Signed-off-by: Bin Meng --- Changes in v2: - fix a build warning drivers/ufs/Kconfig | 11 +++ drivers/ufs/Makefile | 1 + drivers/ufs/ufs-pci.c | 45

[PATCH v2 9/9] qemu: riscv: Enable UFS support

2023-10-11 Thread Bin Meng
This enables UFS support for QEMU RISC-V 'virt' machine. Signed-off-by: Bin Meng --- (no changes since v1) board/emulation/qemu-riscv/Kconfig | 2 ++ doc/board/emulation/qemu-riscv.rst | 8 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/board/emulation/qemu-riscv

[PATCH v2 3/9] cmd: kconfig: Make ufs prompt look similar to other commands

2023-10-11 Thread Bin Meng
At present the 'ufs' command prompt does not look similar like other commands. Update it. Signed-off-by: Bin Meng --- (no changes since v1) cmd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index a59c67e333..0b4e76c262 100644 --- a/cmd

[PATCH v2 2/9] ufs: Add a line feed to the end of some dev_xxx() messages

2023-10-11 Thread Bin Meng
Add a line feed to improve readability of some dev_xxx() messages. Signed-off-by: Bin Meng --- (no changes since v1) drivers/ufs/ufs.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/ufs/ufs.c b/drivers/ufs/ufs.c index f534d6e29f..96801866d3 100644

[PATCH v2 0/9] ufs: Add a PCI UFS controller support

2023-10-11 Thread Bin Meng
This adds a PCI UFS controller support and enables the support on QEMU RISC-V for testing. Requiring QEMU v8.2+. This series is avaiable at u-boot-x86/ufs for testing. Changes in v2: - fix a build warning Bin Meng (9): ufs: Correct the UFS terminlogy ufs: Add a line feed to the end of some

[PATCH 9/9] qemu: riscv: Enable UFS support

2023-10-11 Thread Bin Meng
This enables UFS support for QEMU RISC-V 'virt' machine. Signed-off-by: Bin Meng --- board/emulation/qemu-riscv/Kconfig | 2 ++ doc/board/emulation/qemu-riscv.rst | 8 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation

[PATCH 8/9] ufs: Handle UFS 3.1 controllers

2023-10-11 Thread Bin Meng
Extend the version check to handle UFS 3.1 controllers as well. Tested on QEMU emulated UFS 3.1 controller. Signed-off-by: Bin Meng --- drivers/ufs/ufs.c | 3 ++- drivers/ufs/ufs.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/ufs.c b/drivers/ufs/ufs.c index

[PATCH 7/9] ufs: Add a PCI based UFS controller driver

2023-10-11 Thread Bin Meng
This adds a simple PCI based UFS controller driver with a QEMU emulated UFS controller on the PCI bus. Requiring QEMU v8.2+. Signed-off-by: Bin Meng --- drivers/ufs/Kconfig | 11 +++ drivers/ufs/Makefile | 1 + drivers/ufs/ufs-pci.c | 45

[PATCH 5/9] pci_ids: Add Red Hat vendor and device IDs

2023-10-11 Thread Bin Meng
Red Hat, Inc. donates a part of its device ID range [1] to QEMU, to be used for virtual devices. This commit adds several typical devices that are useful in U-Boot. [1] https://www.qemu.org/docs/master/specs/pci-ids.html Signed-off-by: Bin Meng --- include/pci_ids.h | 7 +++ 1 file

[PATCH 6/9] ufs: Allow mmio registers on the PCI bus

2023-10-11 Thread Bin Meng
Check if the UFS controller is on the PCI bus, and get its register base address accordingly. Signed-off-by: Bin Meng --- drivers/ufs/ufs.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/ufs.c b/drivers/ufs/ufs.c index 96801866d3..fb2a607ef1 100644

[PATCH 4/9] cmd: ufs: Correct the help text

2023-10-11 Thread Bin Meng
Remove the additional space and use "sub-system" for consistency with other commands like "scsi" and "usb". Signed-off-by: Bin Meng --- cmd/ufs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/ufs.c b/cmd/ufs.c index 143e946370..2c8d88df1

[PATCH 1/9] ufs: Correct the UFS terminlogy

2023-10-11 Thread Bin Meng
UFS stands for Universal Flash Storage, not Subsytem. Signed-off-by: Bin Meng --- cmd/Kconfig | 2 +- drivers/ufs/ufs-uclass.c | 2 +- drivers/ufs/ufs.c| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index 6470b138d2

[PATCH 0/9] ufs: Add a PCI UFS controller support

2023-10-11 Thread Bin Meng
This adds a PCI UFS controller support and enables the support on QEMU RISC-V for testing. Requiring QEMU v8.2+. This series is avaiable at u-boot-x86/ufs for testing. Bin Meng (9): ufs: Correct the UFS terminlogy ufs: Add a line feed to the end of some dev_xxx() messages cmd: kconfig

[PATCH 3/9] cmd: kconfig: Make ufs prompt look similar to other commands

2023-10-11 Thread Bin Meng
At present the 'ufs' command prompt does not look similar like other commands. Update it. Signed-off-by: Bin Meng --- cmd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index a59c67e333..0b4e76c262 100644 --- a/cmd/Kconfig +++ b/cmd

[PATCH 2/9] ufs: Add a line feed to the end of some dev_xxx() messages

2023-10-11 Thread Bin Meng
Add a line feed to improve readability of some dev_xxx() messages. Signed-off-by: Bin Meng --- drivers/ufs/ufs.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/ufs/ufs.c b/drivers/ufs/ufs.c index f534d6e29f..96801866d3 100644 --- a/drivers/ufs

[PATCH] mmc: pci: Drop the superfluous cast

2023-10-11 Thread Bin Meng
dm_pci_map_bar() return a value of (void *) already, hence no need to cast it again before assigning to host->ioaddr. Signed-off-by: Bin Meng --- drivers/mmc/pci_mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/pci_mmc.c b/drivers/mmc/pci_mmc.c in

[PATCH] net: e1000: Drop e1000_eth_ids[]

2023-10-11 Thread Bin Meng
e1000_eth_ids holds compatible strings for e1000 devices, but it is meaningless as e1000 is a PCI device and there is no such compatible string assigned to e1000 by the DT bindings community. Drop it. Signed-off-by: Bin Meng --- drivers/net/e1000.c | 6 -- 1 file changed, 6 deletions

Re: [PATCH 10/15] cmd: blk_common: Use macros for the return values

2023-10-10 Thread Bin Meng
Hi Simon, On Mon, Oct 2, 2023 at 9:42 AM Simon Glass wrote: > > Hi Bin, > > On Tue, 26 Sept 2023 at 02:54, Bin Meng wrote: > > > > Avoid using magic number 0/1 for the command result. > > > > Signed-off-by: Bin Meng > > --- > > > > cmd/b

Re: SSE instructions

2023-09-28 Thread Bin Meng
Hi Simon, On Thu, Sep 28, 2023 at 10:20 PM Simon Glass wrote: > > Hi Bin, > > On Thu, 28 Sept 2023 at 08:15, Bin Meng wrote: > > > > Hi Simon, > > > > On Thu, Sep 28, 2023 at 10:41 AM Simon Glass wrote: > > > > > > Hi Bin, > >

Re: SSE instructions

2023-09-28 Thread Bin Meng
Hi Simon, On Thu, Sep 28, 2023 at 10:41 AM Simon Glass wrote: > > Hi Bin, > > U-Boot 64-bit on x86 disables sse, but when enabling Truetype I get a > compiler error: > > drivers/video/console_truetype.c: In function 'frac': > drivers/video/console_truetype.c:30:15: error: SSE register return >

Re: [PATCH 09/15] blk: blkmap: Support mapping to device of any block size

2023-09-26 Thread Bin Meng
Hi Tobias, On Wed, Sep 27, 2023 at 3:29 AM Tobias Waldekranz wrote: > > On tis, sep 26, 2023 at 16:43, Bin Meng wrote: > > At present if a device to map has a block size other than 512, > > the blkmap map process just fails. There is no reason why we > > can't

Re: [PATCH 00/15] blk: sandbox: Support binding a device with a given logical block size

2023-09-26 Thread Bin Meng
Hi Heinrich, On Tue, Sep 26, 2023 at 4:58 PM Heinrich Schuchardt wrote: > > On 9/26/23 10:43, Bin Meng wrote: > > At present on Sandbox when binding to a host backing file, the host > > block device is created with a hard-coded 512 bytes block size. > > > > Such a

[PATCH 15/15] disk: part: Handle blkmap device in print_part_header()

2023-09-26 Thread Bin Meng
Print out the blkmap device type when showing partition header for a blkmap device. Signed-off-by: Bin Meng --- disk/part.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/disk/part.c b/disk/part.c index 493e04943b..6997a89775 100644 --- a/disk/part.c +++ b/disk/part.c @@ -309,6 +309,9

[PATCH 14/15] disk: part: Print out the unknown device uclass id

2023-09-26 Thread Bin Meng
It's helpful to output the device uclass id for unknown devices during the debugging process. Signed-off-by: Bin Meng --- disk/part.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disk/part.c b/disk/part.c index eec02f5898..493e04943b 100644 --- a/disk/part.c +++ b/disk

[PATCH 13/15] dm: blk: Drop blk_{read,write}_devnum()

2023-09-26 Thread Bin Meng
blk_{read,write}_devnum() are no longer used by anywhere in the source tree. Drop them. Signed-off-by: Bin Meng --- drivers/block/blk-uclass.c | 29 - include/blk.h | 26 -- 2 files changed, 55 deletions(-) diff --git a/drivers

[PATCH 12/15] cmd: blk_common: Stop using hard-coded block size for Sandbox operations

2023-09-26 Thread Bin Meng
g the hard-coded block size. Signed-off-by: Bin Meng --- cmd/blk_common.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/cmd/blk_common.c b/cmd/blk_common.c index ad9b16dc09..02ac92837b 100644 --- a/cmd/blk_common.c +++ b/cmd/blk_common.c @@ -67,15 +67

[PATCH 11/15] dm: blk: Rename get_desc() and make it externally visible

2023-09-26 Thread Bin Meng
get_desc() can be useful outside blk-uclass.c. Let's change it to an API and make it externally visible. Signed-off-by: Bin Meng --- drivers/block/blk-uclass.c | 26 -- include/blk.h | 12 2 files changed, 20 insertions(+), 18 deletions

[PATCH 10/15] cmd: blk_common: Use macros for the return values

2023-09-26 Thread Bin Meng
Avoid using magic number 0/1 for the command result. Signed-off-by: Bin Meng --- cmd/blk_common.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/cmd/blk_common.c b/cmd/blk_common.c index 9f9d4327a9..ad9b16dc09 100644 --- a/cmd/blk_common.c +++ b/cmd

[PATCH 09/15] blk: blkmap: Support mapping to device of any block size

2023-09-26 Thread Bin Meng
At present if a device to map has a block size other than 512, the blkmap map process just fails. There is no reason why we can't just use the block size of the mapped device. Signed-off-by: Bin Meng --- drivers/block/blkmap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions

[PATCH 06/15] cmd: host: Print out the block size of the host device

2023-09-26 Thread Bin Meng
It's useful if we can print out the block size of the host device in the "host info" command. Signed-off-by: Bin Meng --- cmd/host.c | 7 --- test/dm/host.c | 20 ++-- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/cmd/host.c b/cmd/ho

[PATCH 08/15] cmd: blkmap: Make map_handlers[] and its .fn static

2023-09-26 Thread Bin Meng
These are only used in cmd/blkmap.c. Signed-off-by: Bin Meng --- cmd/blkmap.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cmd/blkmap.c b/cmd/blkmap.c index b34c013072..ef74ebc003 100644 --- a/cmd/blkmap.c +++ b/cmd/blkmap.c @@ -25,7 +25,8 @@ struct map_handler

[PATCH 07/15] blk: blkmap: Make bind/unbind routines static

2023-09-26 Thread Bin Meng
These 2 are only used in drivers/block/blkmap.c. Signed-off-by: Bin Meng --- drivers/block/blkmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/blkmap.c b/drivers/block/blkmap.c index 409aa46de2..f6acfa8927 100644 --- a/drivers/block/blkmap.c +++ b

[PATCH 05/15] blk: host_dev: Sanity check on the size of host backing file

2023-09-26 Thread Bin Meng
Since we are emulating a block device, its size should be multiple of the configured block size. Signed-off-by: Bin Meng --- drivers/block/host_dev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/block/host_dev.c b/drivers/block/host_dev.c index 0b43f80a86..30c7415793 100644

[PATCH 04/15] blk: host_dev: Make host_sb_detach_file() and host_sb_ops static

2023-09-26 Thread Bin Meng
They are only used in drivers/block/host_dev.c. Signed-off-by: Bin Meng --- drivers/block/host_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/host_dev.c b/drivers/block/host_dev.c index 31c7814054..0b43f80a86 100644 --- a/drivers/block/host_dev.c

[PATCH 03/15] blk: sandbox: Support binding a device with a given logical block size

2023-09-26 Thread Bin Meng
Allow optionally set the logical block size of the host device to bind in the "host bind" command. If not given, defaults to 512. Signed-off-by: Bin Meng --- cmd/host.c | 16 +--- drivers/block/host-uclass.c | 15 --- include/sandbox_host.h

[PATCH 02/15] cmd: host: Mandate the filename parameter in the 'bind' command

2023-09-26 Thread Bin Meng
At present the host bind command does not require filename to be provided. When it is not given NULL is passed to the host device driver, which ends up failure afterwards. Change to mandate the filename so that it is useful. Signed-off-by: Bin Meng --- cmd/host.c | 6 +++--- 1 file changed, 3

[PATCH 01/15] blk: Use a macro for the typical block size

2023-09-26 Thread Bin Meng
Avoid using the magic number 512 directly. Signed-off-by: Bin Meng --- common/usb_storage.c | 4 ++-- drivers/ata/dwc_ahsata.c | 3 ++- drivers/ata/fsl_sata.c | 3 ++- drivers/ata/sata_mv.c| 3 ++- drivers/ata/sata_sil.c | 3 ++- drivers/block/blkmap.c | 2 +- drivers/block

[PATCH 00/15] blk: sandbox: Support binding a device with a given logical block size

2023-09-26 Thread Bin Meng
7de4 (linux) guid: eba904d7-72c1-4dbd-bb4e-36be49cba5e3 2 0x2000 0x7ffa "primary" attrs: 0x00000000 type: 0fc63daf-8483-4772-8e79-3d69d8477de4 (linux) guid: c48c360e-db47-46da-

Please pull u-boot-x86 into -next

2023-09-22 Thread Bin Meng
Hi Tom, The following changes since commit 5d2fae79c7d60eaf7f50322e4ec125d2f58544e9: Merge tag 'xilinx-for-v2024.01-rc1-v2' of https://source.denx.de/u-boot/custodians/u-boot-microblaze into next (2023-09-21 10:51:58 -0400) are available in the Git repository at:

Re: [NEW FEATURE] RFC: Add Intel GMBUS support

2023-09-21 Thread Bin Meng
+Simon Hi Eric, On Fri, Sep 22, 2023 at 6:10 AM Eric Schikschneit wrote: > > I have begun working on adding support for the Intel Graphics Management bus > to U-Boot. Currently the x86 bring up process (as explored on the Baytrail > series of Atom SOCs) relys on the Intel Video BIOS to do all

Re: [PATCH v7 2/3] x86: coreboot: Drop USB init on startup

2023-09-21 Thread Bin Meng
/Kconfig| 1 + > arch/x86/cpu/coreboot/coreboot.c | 4 > doc/board/coreboot/coreboot.rst | 7 +++ > 3 files changed, 8 insertions(+), 4 deletions(-) > Reviewed-by: Bin Meng series applied to u-boot-x86/next, thanks!

Re: [PATCH v7 1/3] fixup: Move python control earlier in Makefile

2023-09-21 Thread Bin Meng
On Thu, Sep 21, 2023 at 9:37 PM Simon Glass wrote: > > Move this control into the common area of the main Makefile, so it > applies to non-build rules as well. This allows 'make mrproper' to handle > python files as it should. > > This should be squashed into: > >65a33eba10d Allow Python

Re: [PATCH v5 00/20] x86: efi: Fixes and improvements for coreboot

2023-09-21 Thread Bin Meng
Hi Simon, On Thu, Sep 21, 2023 at 1:27 PM Bin Meng wrote: > > Hi Simon, > > On Wed, Sep 20, 2023 at 11:00 AM Simon Glass wrote: > > > > This little series fixes various bugs and annoyances in coreboot and > > coreboot64. > > > > With this both

Re: [PATCH v5 00/20] x86: efi: Fixes and improvements for coreboot

2023-09-20 Thread Bin Meng
Hi Simon, On Wed, Sep 20, 2023 at 11:00 AM Simon Glass wrote: > > This little series fixes various bugs and annoyances in coreboot and > coreboot64. > > With this both coreboot and coreboot64 start up and work reasonably well > on Brya (x86 Chromebook) and U-Boot can boot common Linux distros. >

Re: [PATCH v5 08/20] x86: coreboot: Drop USB init on startup

2023-09-20 Thread Bin Meng
Hi Simon, On Wed, Sep 20, 2023 at 9:37 PM Heinrich Schuchardt wrote: > > On 20.09.23 13:50, Marek Vasut wrote: > > On 9/20/23 09:19, Heinrich Schuchardt wrote: > >> On 9/20/23 05:00, Simon Glass wrote: > >>> This is very annoying as it is quite slow on many machines. Also, U-Boot > >>> has an

Re: [PATCH v5 07/20] x86: coreboot: Enable CONFIG_SYS_NS16550_MEM32

2023-09-20 Thread Bin Meng
it access to avoid this trap. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > configs/coreboot64_defconfig | 1 + > configs/coreboot_defconfig | 1 + > 2 files changed, 2 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v4 2/2] x86: Update cbmem driver

2023-09-20 Thread Bin Meng
Hi Simon, On Wed, Sep 20, 2023 at 10:59 AM Simon Glass wrote: > > Hi Bin, > > On Tue, 19 Sept 2023 at 02:47, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Sep 11, 2023 at 3:13 AM Simon Glass wrote: > > > > > > This driver i

Re: [PATCH v4 1/2] x86: coreboot: Document cbmem console struct

2023-09-19 Thread Bin Meng
t;) > > Note: There are several implementations of this in coreboot. I have chosen > to follow the one in src/lib/cbmem_console.c > > Signed-off-by: Simon Glass > --- > > Changes in v4: > - Reword commit and change title > > Changes in v3: > - Drop __packed as it does nothing useful > Reviewed-by: Bin Meng

Re: [PATCH v4 2/2] x86: Update cbmem driver

2023-09-19 Thread Bin Meng
Hi Simon, On Mon, Sep 11, 2023 at 3:13 AM Simon Glass wrote: > > This driver is not actually built since a Kconfig was never created for > it. > > Add a Kconfig (which is already implied by COREBOOT) and update the > implementation to avoid using unnecessary memory. Drop the #ifdef at the > top

Re: [PATCH v2 0/9] x86: Fixes for chromebook_link64 and chromebook_samus_tpl

2023-09-19 Thread Bin Meng
On Thu, Sep 7, 2023 at 11:58 PM Simon Glass wrote: > > These boards have various problems which prevent them from booting. In > the case of link there was a recent regression with PCI probing added to > SPL. For samus_tpl it needs a few tweaks to get things back up and > running. > > This series

Re: [PATCH v2 7/9] x86: broadwell: Set up MTRRs

2023-09-19 Thread Bin Meng
d-off-by: Simon Glass > --- > > (no changes since v1) > > arch/x86/lib/init_helpers.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 8/9] x86: dm: Mark driver model as dead when disabling CAR

2023-09-19 Thread Bin Meng
: > - Add new patch to mark driver model as dead when disabling CAR > > arch/x86/lib/spl.c | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v2 1/9] dm: core: Allow marking driver model as dead

2023-09-19 Thread Bin Meng
> common/spl/spl.c | 2 +- > include/asm-generic/global_data.h | 5 +++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH] x86: doc: Document the -cdrom issues I ran into

2023-09-19 Thread Bin Meng
On Sat, Sep 2, 2023 at 2:08 AM Simon Glass wrote: > > Add a note about using -cdrom with QEMU. > > Suggested-by: Bin Meng > Signed-off-by: Simon Glass > --- > > doc/board/emulation/qemu-x86.rst | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Bin Me

Re: [PATCH v3 1/2] Reland "x86: Move FACP table into separate functions""

2023-09-19 Thread Bin Meng
On Sat, Sep 2, 2023 at 1:27 AM Simon Glass wrote: > > Each board has its own way of creating this table. Rather than calling the > acpi_create_fadt() function for each one from a common acpi_write_fadt() > function, just move the writer into the board-specific code. > > Co-developed-by: Andy

Re: [PATCH v3 2/2] x86: Prevent from missing the FADT chaining

2023-09-19 Thread Bin Meng
e.h | 7 +++ > 5 files changed, 11 insertions(+), 20 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v1 1/2] TO BE FOLDED: x86: tangier: Add FADT to the chain

2023-09-19 Thread Bin Meng
On Tue, Sep 19, 2023 at 3:28 PM Bin Meng wrote: > > Hi Andy, > > On Fri, Aug 25, 2023 at 9:52 PM Andy Shevchenko > wrote: > > > > The Simon's patch missed the FADT to be added to the chain, hence all > > the issues on Intel Tangier. > > > > Signed-o

Re: [PATCH 1/2] Allow Python packages to be dropped

2023-09-19 Thread Bin Meng
On Fri, Sep 1, 2023 at 3:13 AM Simon Glass wrote: > > Hi Tom, > > On Thu, 31 Aug 2023 at 11:48, Tom Rini wrote: > > > > On Thu, Aug 31, 2023 at 11:20:52AM -0600, Simon Glass wrote: > > > > > When building in a portage chroot, we do not have the environment needed > > > to build pylibfdt. It is

Re: [PATCH v1 1/2] TO BE FOLDED: x86: tangier: Add FADT to the chain

2023-09-19 Thread Bin Meng
Hi Andy, On Fri, Aug 25, 2023 at 9:52 PM Andy Shevchenko wrote: > > The Simon's patch missed the FADT to be added to the chain, hence all > the issues on Intel Tangier. > > Signed-off-by: Andy Shevchenko > --- > arch/x86/cpu/tangier/acpi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH v4 20/20] x86: doc: coreboot: Mention 64-bit Linux distros

2023-09-19 Thread Bin Meng
/coreboot/coreboot.rst | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v4 11/20] efi: x86: Correct the condition for installing ACPI tables

2023-09-19 Thread Bin Meng
oader/Makefile| 2 +- > lib/efi_loader/efi_setup.c | 10 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 19/20] x86: doc: Split out manual booting into its own file

2023-09-19 Thread Bin Meng
gt; doc/arch/x86/index.rst | 1 + > doc/arch/x86/manual_boot.rst | 276 +++ > doc/arch/x86/x86.rst | 272 +- > 3 files changed, 280 insertions(+), 269 deletions(-) > create mode 100644 doc/arch/x86/manual_boot.rst > Reviewed-by: Bin Meng

Re: [PATCH v4 18/20] x86: doc: Update summaries and add links

2023-09-19 Thread Bin Meng
ch > > doc/arch/x86/x86.rst | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 17/20] x86: doc: Move into its own directory

2023-09-19 Thread Bin Meng
gt; - Add new patch > > doc/arch/index.rst | 2 +- > doc/arch/x86/index.rst | 11 +++ > doc/arch/{ => x86}/x86.rst | 6 +++--- > 3 files changed, 15 insertions(+), 4 deletions(-) > create mode 100644 doc/arch/x86/index.rst > rename doc/arch/{ => x86}/x86.rst (99%) > Reviewed-by: Bin Meng

Re: [PATCH v4 16/20] x86: coreboot: Record the position of the SMBIOS tables

2023-09-19 Thread Bin Meng
p_to_sysmem() too? > gd->flags |= GD_FLG_SKIP_LL_INIT; > > return 0; > -- Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH v4 14/20] Record the position of the SMBIOS tables

2023-09-19 Thread Bin Meng
ata.h | 8 ++++ > 6 files changed, 19 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v4 12/20] x86: smbios: Add a Kconfig indicating SMBIOS-table presence

2023-09-19 Thread Bin Meng
ow SMBIOS if EFI_LOADER is enabled > - Reword the help > > Changes in v2: > - Add new patch > > lib/Kconfig | 15 ++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 10/20] x86: coreboot: Enable VIDEO_COPY

2023-09-19 Thread Bin Meng
roblem. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/x86/dts/coreboot.dts| 1 + > configs/coreboot64_defconfig | 1 + > configs/coreboot_defconfig | 1 + > drivers/video/coreboot.c | 12 > 4 files changed, 15 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v4 09/20] x86: coreboot: Align options between coreboot and coreboot64

2023-09-19 Thread Bin Meng
> - Update the malloc size too > > configs/coreboot64_defconfig | 7 +++ > configs/coreboot_defconfig | 9 - > 2 files changed, 7 insertions(+), 9 deletions(-) > Reviewed-by: Bin Meng

  1   2   3   4   5   6   7   8   9   10   >