Re: [PATCH v3 04/16] acpi: Create a new Kconfig for ACPI

2023-05-04 Thread Bin Meng
lib/Makefile | 2 +- > lib/acpi/Makefile| 4 > 7 files changed, 22 insertions(+), 3 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 02/16] x86: Adjust search range for sysinfo table

2023-05-04 Thread Bin Meng
t; > arch/x86/cpu/cpu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 01/16] mtrr: Don't show an invalid CPU number

2023-05-04 Thread Bin Meng
ow an invalid CPU number on error > > cmd/x86/mtrr.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 30/30] CI: Enable sandbox build for Windows

2023-05-03 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Add a new rule to build sandbox for Windows. For now, no tests are run in > this configuration. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Update the cover letter to better explain the motivation > >

Re: [PATCH v2 26/30] build: Disable weak symbols for MSYS2

2023-05-03 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Weak symbols are not well supported by the PE format, so disable them. > We need to manually ensure that only one function is present in the source > code. > > Add a Kconfig option to control this and enable it when building for >

Re: [PATCH v2 24/30] sandbox: Provide an EFI link script for PE

2023-05-02 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Add another case for sandbox, when it is built on Windows. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/sandbox/config.mk | 4 +- > arch/x86/lib/crt0_x86_64_efi.S | 2 + >

Re: [PATCH v2 23/30] sandbox: Augment the linker script for MSYS2

2023-05-02 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > We need to place the linker lists, etc. in the .rdata section but this > is not possible with the default linker script. We can only add new > sections, which causes Windows to give an "Exec format error" error. > > Add a rule to

Re: [PATCH v2 22/30] Makefile: Correct the ans1_compiler rule for MSYS2

2023-05-02 Thread Bin Meng
%.asn1.c $(obj)/%.asn1.h: $(src)/%.asn1 $(objtree)/tools/asn1_compiler > +$(obj)/%.asn1.c $(obj)/%.asn1.h: $(src)/%.asn1 > $(objtree)/tools/asn1_compiler$(EXEEXT) > $(call cmd,asn1_compiler) > > # Build the compiled-in targets > -- Otherwise, Reviewed-by: Bin Meng

Re: [PATCH v2 21/30] Makefile: Disable unsupported compiler options with PE

2023-05-02 Thread Bin Meng
DFLAGS := -nostdlib > +KBUILD_EFILDFLAGS += $(call ld-option,-zexecstack) > +KBUILD_EFILDFLAGS += $(call ld-option,-znocombreloc) > +KBUILD_EFILDFLAGS += $(call ld-option,-znorelro) > KBUILD_EFILDFLAGS += $(call ld-option,--no-warn-rwx-segments) > quiet_cmd_efi_ld = LD $@ > cmd_efi_ld = $(LD) $(KBUILD_EFILDFLAGS) -T $(EFI_LDS_PATH) \ > -- Otherwise, Reviewed-by: Bin Meng

Re: [PATCH v2 20/30] sandbox: Fix up setting of monitor_len on MSYS2

2023-05-02 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > The required linker symbols are not present. For now just return 0 in > this case. Is it possible to add _end in the Sandbox linker script? > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > common/board_f.c | 2

Re: [PATCH v2 19/30] sandbox: Drop signal handling for MSYS2

2023-05-02 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > The Linux register format used on Linux (and perhaps other OSes) is not > used on Windows, so disable this feature. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Update commit message to mention other OSes > - Check

Re: [PATCH] cmd/fdt: fix conf node lookup failure check

2023-05-01 Thread Bin Meng
Hi, On Mon, May 1, 2023 at 4:19 PM Baruch Siach wrote: > > fit_conf_get_node() returns negative value on error. > > Signed-off-by: Baruch Siach > --- > cmd/fdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > There is already a patch on the ML before:

Re: [PATCH v2 18/30] sandbox: Disable raw Ethernet on MSYS2

2023-05-01 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > This relies on Linux features so cannot be built for Windows. Drop it. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/sandbox/cpu/Makefile | 2 ++ > drivers/net/Makefile | 2 ++ > 2 files changed, 4

Re: [PATCH v2 17/30] Kbuild: Detect including an MSYS2 path

2023-05-01 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > The source-tree directory is prepended to relative include paths, but this > does not work on Windows, where a path may have a drive letter like C: at > the start of it. > > This breaks SDL which includes an absolute path to the

Re: [PATCH v2 16/30] Makefile: Disable LTO when not building with gcc

2023-05-01 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > For MSYS2 this creates a lot of errors of the form: > > `__stack_chk_fail' referenced in section `.text' of ...ltrans.o: defined >in discarded section `.text' of common/stackprot.o (symbol from plugin) > > For clang it doesn't

Re: [PATCH v2 15/30] ctype: Avoid using a symlink

2023-05-01 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Windows doesn't really support symlinks so fails to build this file. Use > a single-line #include instead. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > include/ctype.h | 7 ++- > 1 file changed, 6

Re: [PATCH v2 14/30] test: Avoid strange symbols in the assembler file

2023-05-01 Thread Bin Meng
e we have no tests starting with $ and none starting with > 'zz' at present. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Update comment and use zz to make it less likely we have a problem > > include/test/test.h | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [PATCH v2 13/30] sandbox: Drop inclusion of os.h in sscanf.c

2023-04-30 Thread Bin Meng
On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > There is no need for this file and it should not be included unless > sandbox is being used. Drop it. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > lib/sscanf.c | 1 - > 1 file changed,

Re: [PATCH v2 12/30] sandbox: Drop incorrect inclusion of linux/types.h

2023-04-30 Thread Bin Meng
uld not be used. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/sandbox/cpu/os.c | 1 - > include/os.h | 2 -- > 2 files changed, 3 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 11/30] sections: Drop use of linux/types.h

2023-04-30 Thread Bin Meng
1) > > include/asm-generic/sections.h | 16 +++- > 1 file changed, 7 insertions(+), 9 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 10/30] sandbox: Include errno.h in the test header

2023-04-30 Thread Bin Meng
anged, 1 insertion(+) > Reviewed-by: Bin Meng

Re: [PATCH v2 09/30] sandbox: Correct SDL.h header inclusion

2023-04-30 Thread Bin Meng
; --- > > (no changes since v1) > > arch/sandbox/cpu/sdl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 08/30] sandbox: Drop dead code from Makefile

2023-04-30 Thread Bin Meng
On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > This is not used, since the same code appears in cpu/Makefile > > Drop it. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/sandbox/Makefile | 7 --- > 1 file changed, 7 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 07/30] mkimage: Correct checking of configuration node

2023-04-30 Thread Bin Meng
| 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

[PATCH 1/2] cmd: fdt: Correct checking of configuration node

2023-04-30 Thread Bin Meng
fit_conf_get_node() returns a negative value on error. Signed-off-by: Bin Meng --- cmd/fdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/fdt.c b/cmd/fdt.c index aae3278526..2401ea8b44 100644 --- a/cmd/fdt.c +++ b/cmd/fdt.c @@ -733,7 +733,7 @@ static int do_fdt

[PATCH 2/2] spl: Correct checking of configuration node

2023-04-30 Thread Bin Meng
Per the fit_conf_get_node() API doc, it returns configuration node offset when found (>=0). Signed-off-by: Bin Meng --- common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index a630e79866..7c0aff93e7 100644 --- a/common/

Re: [PATCH v2 06/30] Fix Makefile warning about parallel targets

2023-04-30 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > These targets are not really parallel; they are handled one at a time > when invoked by other rules. Some recent versions of make (e.g. on MSYS2) > give a warning about this. Split out the rules to avoid the warning. I did not see

Re: [PATCH v2 05/30] pylibfdt: Allow building on Windows

2023-04-30 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Handle the different shared-object extension with MSYS2 by creating a new > SOEXT variable. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Use LIBEXT instead of SOEXT > > Makefile | 11

Re: [PATCH v2 04/30] binman: Avoid using a symlink

2023-04-30 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Use a small Python script instead of a symlink to avoid problems with > Windows. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > tools/binman/binman | 11 ++- > 1 file changed, 10 insertions(+), 1

Re: [PATCH v2 28/30] doc: Show how to build sandbox for MSYS2

2023-04-30 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Add instructions for building u-boot.exe to run on Windows. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Clearify the documentation to explain the environment better > > doc/build/gcc.rst | 40

Re: [PATCH 17/31] sandbox: Allow weak symbols to be dropped

2023-04-30 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 2:41 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 24 Apr 2023 at 20:44, Bin Meng wrote: > > > > Hi Simon, > > > > On Tue, Apr 25, 2023 at 7:09 AM Simon Glass wrote: > > > > > > The sandbox bu

Re: [PATCH 29/31] doc: Show how to build sandbox for MSYS2

2023-04-24 Thread Bin Meng
On Tue, Apr 25, 2023 at 10:54 AM Heinrich Schuchardt wrote: > > > > Am 25. April 2023 01:08:34 MESZ schrieb Simon Glass : > >Add instructions for building u-boot.exe to run on Windows. > > > >Signed-off-by: Simon Glass > >--- > > > > doc/build/gcc.rst | 35 +++ > >

Re: [PATCH 17/31] sandbox: Allow weak symbols to be dropped

2023-04-24 Thread Bin Meng
Hi Simon, On Tue, Apr 25, 2023 at 7:09 AM Simon Glass wrote: > > The sandbox build makes use of a small number of weak symbols. Allow these > to be dropped when building for the PE format, since its support for weak > symbols is poor. > > Signed-off-by: Simon Glass > --- > > cmd/bootefi.c

Re: [PATCH] riscv: Add a 64-bit image type

2023-04-17 Thread Bin Meng
Hi Leo, On Mon, Apr 17, 2023 at 1:22 PM Leo Liang wrote: > > Hi Bin, > > On Thu, Apr 13, 2023 at 06:06:29PM +0800, Bin Meng wrote: > > On Mon, Apr 10, 2023 at 3:25 PM Rick Chen wrote: > > > > > > > From: Simon Glass > > > > Sent: Monday, Apr

Re: [PATCH] riscv: Add a 64-bit image type

2023-04-13 Thread Bin Meng
On Mon, Apr 10, 2023 at 3:25 PM Rick Chen wrote: > > > From: Simon Glass > > Sent: Monday, April 03, 2023 4:28 AM > > To: U-Boot Mailing List > > Cc: Sean Anderson ; Bin Meng ; Rick > > Jian-Zhi Chen(陳建志) ; Leo Yu-Chi Liang(梁育齊) > > ; Simon Glass ;

[PATCH v2 8/9] riscv: spl: Remove relocation sections

2023-04-13 Thread Bin Meng
U-Boot SPL is not relocable. Drop these relocation sections. Signed-off-by: Bin Meng --- Changes in v2: - fix SPL build error arch/riscv/cpu/start.S| 2 ++ arch/riscv/cpu/u-boot-spl.lds | 25 - 2 files changed, 2 insertions(+), 25 deletions(-) diff --git

[PATCH v2 5/9] makefile: riscv: Drop useless argument of prelink-riscv

2023-04-13 Thread Bin Meng
The argv[2] is never used in prelink-riscv. Drop it. Signed-off-by: Bin Meng Reviewed-by: Rick Chen --- (no changes since v1) Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5083beae35..eaaf7d267d 100644 --- a/Makefile +++ b/Makefile

[PATCH v2 9/9] riscv: Update alignment for some sections in linker scripts

2023-04-13 Thread Bin Meng
Some sections in the linker scripts are aligned to 4 bytes, which may cause misaligned exception on some platforms, e.g.: clearing the bss section on 64-bit hardware if __bss_start does not start from a naturally 8 bytes aligned address. Signed-off-by: Bin Meng --- (no changes since v1) arch

[PATCH v2 7/9] riscv: Avoid updating the link register

2023-04-13 Thread Bin Meng
board_init_r does not return for U-Boot SPL hence there is no need to update the link register when jumping to board_init_r. Signed-off-by: Bin Meng --- Changes in v2: - new patch: "riscv: Avoid updating the link register" arch/riscv/cpu/start.S | 2 +- 1 file changed, 1 inser

[PATCH v2 6/9] riscv: Change to use positive offset to access relocation entries

2023-04-13 Thread Bin Meng
offset so that there is no need to skip the first relocation entry. Signed-off-by: Bin Meng --- (no changes since v1) arch/riscv/cpu/start.S | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/arch/riscv/cpu/start.S b/arch/riscv/cpu/start.S index 879bdc1803..c09d1cb

[PATCH v2 4/9] tools: prelink-riscv: Unmap the ELF image when done

2023-04-13 Thread Bin Meng
The codes forget to call munmap() to unmap the ELF image that was mapped by previous mmap(). Signed-off-by: Bin Meng Reviewed-by: Rick Chen --- (no changes since v1) tools/prelink-riscv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/prelink-riscv.c b/tools/prelink-riscv.c

[PATCH v2 2/9] riscv: Optimize loading relocation type

2023-04-13 Thread Bin Meng
't5' already contains relocation type so don't bother reloading it. Signed-off-by: Bin Meng Reviewed-by: Rick Chen --- (no changes since v1) arch/riscv/cpu/start.S | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/riscv/cpu/start.S b/arch/riscv/cpu/start.S index 3c8344c345..879bdc1803

[PATCH v2 3/9] tools: prelink-riscv: Cosmetic style fixes

2023-04-13 Thread Bin Meng
Some coding convention fixes. Signed-off-by: Bin Meng Reviewed-by: Rick Chen --- (no changes since v1) tools/prelink-riscv.inc | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/prelink-riscv.inc b/tools/prelink-riscv.inc index f2b5467f5b..57c0f655d4

[PATCH v2 1/9] riscv: Optimize source end address calculation in start.S

2023-04-13 Thread Bin Meng
The __bss_start is the source end address hence load its address directly into register 't2' for optimization. Signed-off-by: Bin Meng Reviewed-by: Rick Chen --- (no changes since v1) arch/riscv/cpu/start.S | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/riscv/cpu

Re: [PATCH v2] ata: pci: enable bus mastering

2023-04-11 Thread Bin Meng
ding '.' from comment. The changelog should go below --- otherwise it shows up in the commit message :) > > Signed-off-by: Christian Gmeiner > Reviewed-by: Bin Meng > --- > drivers/ata/ahci.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/dr

Re: [PATCH] ata: pci: enable bus mastering

2023-04-11 Thread Bin Meng
_pci_read_config16(dev, PCI_COMMAND, ); > + cmd |= PCI_COMMAND_MASTER; > + dm_pci_write_config16(dev, PCI_COMMAND, cmd); > > base = (ulong)dm_pci_map_bar(ahci_dev, PCI_BASE_ADDRESS_5, 0, 0, > PCI_REGION_TYPE, PCI_REGION_MEM); > -- Reviewed-by: Bin Meng

Re: [PATCH v4 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-04-10 Thread Bin Meng
On Tue, Apr 11, 2023 at 11:53 AM Minda Chen wrote: > > > > On 2023/4/11 10:55, Bin Meng wrote: > > On Tue, Apr 11, 2023 at 9:03 AM Minda Chen > > wrote: > >> > >> From: Mason Huo > >> > >> Add pcie driver for StarFive JH7110, the

Re: [PATCH v4 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-04-10 Thread Bin Meng
On Tue, Apr 11, 2023 at 9:03 AM Minda Chen wrote: > > From: Mason Huo > > Add pcie driver for StarFive JH7110, the driver depends on > starfive gpio, pinctrl, clk and reset driver to do init. > > Several devices are tested: > a) M.2 NVMe SSD > b) Realtek 8169 Ethernet adapter. > > Signed-off-by:

[PATCH] riscv: Enforce DWARF4 output

2023-04-06 Thread Bin Meng
Since commit 409e4b547872 ("Makefile: Enforce DWARF4 output") the whole U-Boot build switched to enforce DWARF4 output, but RISC-V is still on its own setting. Let's switch to use U-Boot's setting. Signed-off-by: Bin Meng --- arch/riscv/config.mk | 3 +-- 1 file changed, 1 inser

Re: [PATCH 1/8] riscv: Optimize source end address calculation in start.S

2023-04-06 Thread Bin Meng
On Thu, Mar 30, 2023 at 8:36 PM Bin Meng wrote: > > The __bss_start is the source end address hence load its address > directly into register 't2' for optimization. > > Signed-off-by: Bin Meng > --- > > arch/riscv/cpu/start.S | 4 +--- > 1 file changed, 1 insertion(

[PATCH] fs: yaffs2: Make yaffsfs_deviceList static

2023-04-05 Thread Bin Meng
yaffsfs_deviceList is only referenced in yaffsfs.c Signed-off-by: Bin Meng --- fs/yaffs2/yaffsfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/yaffs2/yaffsfs.c b/fs/yaffs2/yaffsfs.c index 510faaeed1..d615f02d3f 100644 --- a/fs/yaffs2/yaffsfs.c +++ b/fs/yaffs2

[PATCH] nand: raw: octeontx: Make list static

2023-04-05 Thread Bin Meng
octeontx_bch_devices and octeontx_pci_nand_deferred_devices are only referenced in the files where they are defined. Make them static. Signed-off-by: Bin Meng --- drivers/mtd/nand/raw/octeontx_bch.c | 2 +- drivers/mtd/nand/raw/octeontx_nand.c | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH] dm: core: Make aliases_lookup static

2023-04-05 Thread Bin Meng
aliases_lookup is only referenced in of_access.c Signed-off-by: Bin Meng --- drivers/core/of_access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/core/of_access.c b/drivers/core/of_access.c index 85f7da5a49..81a307992c 100644 --- a/drivers/core/of_access.c +++ b

[PATCH 5/5] efi: loader: Make efi_runtime_mmio static

2023-04-05 Thread Bin Meng
efi_runtime_mmio is only referenced in efi_boottime.c Signed-off-by: Bin Meng --- lib/efi_loader/efi_runtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c index cee96bfc7f..bf54d6ad87 100644 --- a/lib

[PATCH 4/5] efi: loader: Make efi_mem static

2023-04-05 Thread Bin Meng
efi_mem is only referenced in efi_memory.c Signed-off-by: Bin Meng --- lib/efi_loader/efi_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index b7bee98f79..219b520a0d 100644 --- a/lib/efi_loader/efi_memory.c

[PATCH 3/5] efi: loader: Make efi_event_queue and efi_register_notify_events static

2023-04-05 Thread Bin Meng
efi_event_queue and efi_register_notify_events are only referenced in efi_boottime.c Signed-off-by: Bin Meng --- include/efi_loader.h | 3 --- lib/efi_loader/efi_boottime.c | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/include/efi_loader.h b/include

[PATCH 2/5] efi: selftest: Make load_file() and load_file2() static

2023-04-05 Thread Bin Meng
load_file() and load_file2() are only referenced in efi_selftest_load_file.c Signed-off-by: Bin Meng --- lib/efi_selftest/efi_selftest_load_file.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/efi_selftest/efi_selftest_load_file.c b/lib

[PATCH 1/5] efi: selftest: Make record static

2023-04-05 Thread Bin Meng
record is only referenced in efi_selftest_exitbootservices.c Signed-off-by: Bin Meng --- lib/efi_selftest/efi_selftest_exitbootservices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_selftest/efi_selftest_exitbootservices.c b/lib/efi_selftest

[PATCH] boot: vbe_simple: Fix vbe_simple_read_bootflow() dependency

2023-04-03 Thread Bin Meng
vbe_simple_read_bootflow() calls vbe_simple_read_bootflow_fw() which is only available when BOOTMETH_VBE_SIMPLE_FW is on. Signed-off-by: Bin Meng --- boot/vbe_simple.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/boot/vbe_simple.c b/boot/vbe_simple.c index

[PATCH] riscv: Correct a comment in io.h

2023-04-03 Thread Bin Meng
Replace NDS32 with RISC-V in the comments. Signed-off-by: Bin Meng --- arch/riscv/include/asm/io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/include/asm/io.h b/arch/riscv/include/asm/io.h index 220266e76f..b16e6dfa37 100644 --- a/arch/riscv/include/asm/io.h

Re: RISC-V FIT image type

2023-04-01 Thread Bin Meng
Hi Simon, On Sat, Apr 1, 2023 at 2:31 PM Simon Glass wrote: > > Hi Bin, > > On Fri, 31 Mar 2023 at 19:22, Bin Meng wrote: > > > > On Fri, Mar 31, 2023 at 5:36 AM Simon Glass wrote: > > > > > > Hi, > > > > > > I

Re: RISC-V FIT image type

2023-03-31 Thread Bin Meng
On Fri, Mar 31, 2023 at 5:36 AM Simon Glass wrote: > > Hi, > > I notice that in image.h we have IH_ARCH_RISCV but no mention of > IH_ARCH_RISCV64. Should we not have two separate image types, as we do > with ARM and x86? Otherwise, how would a loader know the word size of > the target machine? I

[PATCH 8/8] riscv: Update alignment for some sections in linker scripts

2023-03-30 Thread Bin Meng
Some sections in the linker scripts are aligned to 4 bytes, which may cause misaligned exception on some platforms, e.g.: clearing the bss section on 64-bit hardware if __bss_start does not start from a naturally 8 bytes aligned address. Signed-off-by: Bin Meng --- arch/riscv/cpu/u-boot

[PATCH 5/8] makefile: riscv: Drop useless argument of prelink-riscv

2023-03-30 Thread Bin Meng
The argv[2] is never used in prelink-riscv. Drop it. Signed-off-by: Bin Meng --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index ab93f29fc5..33e54bfa3d 100644 --- a/Makefile +++ b/Makefile @@ -1758,7 +1758,7 @@ ifeq ($(CONFIG_KALLSYMS),y

[PATCH 7/8] riscv: spl: Remove relocation sections

2023-03-30 Thread Bin Meng
U-Boot SPL is not relocable. Drop these relocation sections. Signed-off-by: Bin Meng --- arch/riscv/cpu/u-boot-spl.lds | 25 - 1 file changed, 25 deletions(-) diff --git a/arch/riscv/cpu/u-boot-spl.lds b/arch/riscv/cpu/u-boot-spl.lds index 993536302a..c3b4907905 100644

[PATCH 6/8] riscv: Change to use positive offset to access relocation entries

2023-03-30 Thread Bin Meng
offset so that there is no need to skip the first relocation entry. Signed-off-by: Bin Meng --- arch/riscv/cpu/start.S | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/arch/riscv/cpu/start.S b/arch/riscv/cpu/start.S index 879bdc1803..c09d1cb412 100644 --- a/arch

[PATCH 2/8] riscv: Optimize loading relocation type

2023-03-30 Thread Bin Meng
't5' already contains relocation type so don't bother reloading it. Signed-off-by: Bin Meng --- arch/riscv/cpu/start.S | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/riscv/cpu/start.S b/arch/riscv/cpu/start.S index 3c8344c345..879bdc1803 100644 --- a/arch/riscv/cpu/start.S +++ b/arch

[PATCH 4/8] tools: prelink-riscv: Unmap the ELF image when done

2023-03-30 Thread Bin Meng
The codes forget to call munmap() to unmap the ELF image that was mapped by previous mmap(). Signed-off-by: Bin Meng --- tools/prelink-riscv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/prelink-riscv.c b/tools/prelink-riscv.c index b0467949eb..43d6412ee9 100644 --- a/tools

[PATCH 3/8] tools: prelink-riscv: Cosmetic style fixes

2023-03-30 Thread Bin Meng
Some coding convention fixes. Signed-off-by: Bin Meng --- tools/prelink-riscv.inc | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/prelink-riscv.inc b/tools/prelink-riscv.inc index f2b5467f5b..d6a58929e9 100644 --- a/tools/prelink-riscv.inc +++ b/tools

[PATCH 1/8] riscv: Optimize source end address calculation in start.S

2023-03-30 Thread Bin Meng
The __bss_start is the source end address hence load its address directly into register 't2' for optimization. Signed-off-by: Bin Meng --- arch/riscv/cpu/start.S | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/riscv/cpu/start.S b/arch/riscv/cpu/start.S index

Re: [PATCH v2 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-27 Thread Bin Meng
On Wed, Mar 8, 2023 at 1:49 PM Minda Chen wrote: > > From: Mason Huo > > Add pcie driver for StarFive JH7110, the driver depends on > starfive gpio, pinctrl, clk and reset driver to do init. > > Several devices are tested: > a) M.2 NVMe SSD > b) Realtek 8169 Ethernet adapter. > > Signed-off-by:

Please pull u-boot-x86

2023-03-26 Thread Bin Meng
Hi Tom, This PR contains the following x86 changes for v2023.04 release: - x86: Bug fixes of previous BayTrail platform CONFIG_TEXT_BASE changes The following changes since commit 8be7b4629e87ff8db08dd087c81d58129d029bad: Merge tag 'efi-2023.04-rc5' of

Re: [PATCH 03/13] input: Only reset the keyboard when running bare metal

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Mar 21, 2023 at 2:40 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 20 Mar 2023 at 19:32, Bin Meng wrote: > > > > Hi Simon, > > > > On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > > > > > If U-Boot is not the first-

Re: [PATCH 13/13] x86: coreboot: Show unimplemented sysinfo tags

2023-03-20 Thread Bin Meng
asm/cb_sysinfo.h | 6 ++ > arch/x86/lib/coreboot/cb_sysinfo.c | 2 ++ > cmd/x86/cbsysinfo.c | 8 > 3 files changed, 16 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 12/13] x86: coreboot: Log function names and line numbers

2023-03-20 Thread Bin Meng
1 file changed, 4 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 11/13] x86: coreboot: Scan PCI after relocation

2023-03-20 Thread Bin Meng
On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > Enable this so that PCI devices can be used correctly without needing > to do a manual scan. > > Signed-off-by: Simon Glass > --- > > configs/coreboot_defconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bin Meng

Re: [PATCH 10/13] x86: coreboot: Document how to enable the debug UART

2023-03-20 Thread Bin Meng
On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > This is not obvious so add a little note about how it works. > > Signed-off-by: Simon Glass > --- > > doc/board/coreboot/coreboot.rst | 29 + > 1 file changed, 29 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 09/13] x86: coreboot: Use a memory-mapped UART

2023-03-20 Thread Bin Meng
On Mon, Mar 20, 2023 at 4:08 PM Bin Meng wrote: > > Hi Simon, > > On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > > > This is much more common on modern hardware, so default to using it. > > > > Signed-off-by: Simon Glass > > --- > > &g

Re: [PATCH 09/13] x86: coreboot: Use a memory-mapped UART

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > This is much more common on modern hardware, so default to using it. > > Signed-off-by: Simon Glass > --- > > include/configs/coreboot.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/configs/coreboot.h

Re: [PATCH 07/13] pci: coreboot: Don't read regions when booting

2023-03-20 Thread Bin Meng
it is not safe for U-Boot to make any changes. > > Signed-off-by: Simon Glass > --- > > drivers/pci/pci-uclass.c | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 06/13] x86: Allow locating UARTs by device ID

2023-03-20 Thread Bin Meng
+Andy Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > When coreboot does not pass a UART in its sysinfo struct, there is no > easy way to find it out. Add a way to specify known UARTs so we can > find them without needing help from coreboot. > > Since coreboot does not actually

Re: [PATCH 05/13] x86: coreboot: Collect the address of the ACPI tables

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > Pick this up from the sysinfo tables and display it with the cbsysinfo > command. This allows the 'acpi list' command to work when booting from > coreboot. > > Signed-off-by: Simon Glass > --- > >

Re: [PATCH 03/13] input: Only reset the keyboard when running bare metal

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > If U-Boot is not the first-stage bootloader we should not init the > keyboard, since it has already been done. Check for this. But re-init does no harm, right? > > Signed-off-by: Simon Glass > --- > > drivers/input/i8042.c | 13

Re: [PATCH 02/13] x86: Adjust search range for sysinfo table

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > Avoid searching starting at 0 since this memory may not be available Please describe in more detail why memory address 0 is not available? > and the table cannot be there anyway. Start at 0x400 instead. > > Signed-off-by: Simon

Re: [PATCH 01/13] mtrr: Don't show an invalid CPU number

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > When U-Boot did not do the MP init, we don't get an actual CPU number > here. Skip printing it in that case. > > Signed-off-by: Simon Glass > --- > > cmd/x86/mtrr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

Re: [PATCH v3 1/5] x86: minnowmax: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
On Thu, Mar 16, 2023 at 3:27 PM Bin Meng wrote: > > On Wed, Mar 15, 2023 at 8:00 AM Simon Glass wrote: > > > > With recent CONFIG_TEXT_BASE changes, there are inconsistencies between > > several settings. > > > > Adjust CONFIG_SYS_MONITOR_LEN to allow more co

Re: [PATCH v3 5/5] x86: som-db5800-som-6867: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
by: Simon Glass > Fixes: e23cae30801 ("x86: som-db5800-som-6867: Adjust CONFIG_TEXT_BASE") > --- > > Changes in v3: > - Add new patch > > arch/x86/dts/baytrail_som-db5800-som-6867.dts | 2 +- > configs/som-db5800-som-6867_defconfig | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 4/5] x86: dfi-bt700: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
fconfig | 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 3/5] x86: conga-qeval20-qa3-e3845: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
onfig | 1 + > configs/conga-qeval20-qa3-e3845_defconfig | 1 + > configs/theadorable-x86-conga-qa3-e3845-pcie-x4_defconfig | 1 + > configs/theadorable-x86-conga-qa3-e3845_defconfig | 1 + > 5 files changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 2/5] x86: bayleybay: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
by: Simon Glass > Fixes: f38be308683 ("x86: bayleybay: Adjust CONFIG_TEXT_BASE") > --- > > Changes in v3: > - Add new patch > > arch/x86/dts/bayleybay.dts | 2 +- > configs/bayleybay_defconfig | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 1/5] x86: minnowmax: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
Change the commit message and subject > > Changes in v2: > - Add new patch which boots while still enabling EFI_LOADER > > arch/x86/dts/minnowmax.dts| 2 +- > configs/minnowmax_defconfig | 1 + > doc/board/intel/minnowmax.rst | 15 +++++-- > 3 files changed, 15 insertions(+), 3 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 1/2] x86: Revert "x86: minnowmax: Adjust CONFIG_TEXT_BASE"

2023-03-13 Thread Bin Meng
Hi Simon, On Sat, Mar 11, 2023 at 7:33 AM Simon Glass wrote: > > This causes Minnowmax to stop booting. Revert it so we have a good > example of how to do this fully. > > This reverts commit 66e2c665f3b60d726e1c26ad44ac97aa76ead6f5. > > Signed-off-by: Simon Glass > --- > > (no changes since v1)

Re: [PATCH v2 2/2] x86: minnowmax: Adjust CONFIG_TEXT_BASE et at

2023-03-13 Thread Bin Meng
Hi Simon, On Sat, Mar 11, 2023 at 7:33 AM Simon Glass wrote: > > At present U-Boot no longer builds as a complete rom for minnowmaxs since > it is too big for the section. > > Adjust CONFIG_TEXT_BASE and CONFIG_SYS_MONITOR_LEN to allow more code > space. Move the MRC cache out of the way too. >

Re: [RFC PATCH 2/2] kconfig: U-Boot additions

2023-03-12 Thread Bin Meng
> 1 file changed, 10 insertions(+) > Tested building qemu-x86 and qemu-riscv_spl, and boot on QEMU Tested-by: Bin Meng

Re: [RFC PATCH 1/2] kconfig: Bring in from Linux v6.2

2023-03-12 Thread Bin Meng
00644 scripts/kconfig/tests/preprocess/variable/expected_stderr > delete mode 100644 scripts/kconfig/tests/rand_nested_choice/Kconfig > delete mode 100644 scripts/kconfig/tests/rand_nested_choice/__init__.py > delete mode 100644 scripts/kconfig/tests/rand_nested_choice/expected_stdout0 > delete mode 100644 scripts/kconfig/tests/rand_nested_choice/expected_stdout1 > delete mode 100644 scripts/kconfig/tests/rand_nested_choice/expected_stdout2 > Tested building qemu-x86 and qemu-riscv_spl, and boot on QEMU Tested-by: Bin Meng

Re: [PATCH v2 00/17] Basic StarFive JH7110 RISC-V SoC support

2023-02-07 Thread Bin Meng
On Mon, Feb 6, 2023 at 3:39 PM Jan Kiszka wrote: > > On 18.01.23 09:11, Yanhong Wang wrote: > > This series of patches base on the latest branch/master, and add support > > for the StarFive JH7110 RISC-V SoC and VisionFive V2 board. In order for > > this to be achieved, the respective DT nodes

Re: [PATCH] x86: Revert "x86: minnowmax: Adjust CONFIG_TEXT_BASE"

2023-02-05 Thread Bin Meng
Hi Simon, On Mon, Feb 6, 2023 at 8:54 AM Simon Glass wrote: > > This causes Minnowmax to stop booting. I am not sure why though. > > Drop the EFI_LOADER feature instead, since it is not needed. > > This reverts commit 66e2c665f3b60d726e1c26ad44ac97aa76ead6f5. > > Signed-off-by: Simon Glass >

Re: U-Boot v2023.01 broken on riscv64 qemu virt platform: "fdt fixup event failed"

2023-01-12 Thread Bin Meng
On Thu, Jan 12, 2023 at 8:18 AM Tom Rini wrote: > > On Thu, Jan 12, 2023 at 01:16:43AM +0100, Heinrich Schuchardt wrote: > > On 1/12/23 01:04, Tom Rini wrote: > > > On Thu, Jan 12, 2023 at 01:01:55AM +0100, Heinrich Schuchardt wrote: > > > > On 1/12/23 00:59, Tom Rini wrote: > > > > > On Thu, Jan

Re: [PATCH v3] riscv: ae350: support openSBI 1.0+ which enable FW_PIC

2023-01-03 Thread Bin Meng
dex 36b67f0b52..4bb33b0793 100644 > --- a/board/AndesTech/ax25-ae350/Kconfig > +++ b/board/AndesTech/ax25-ae350/Kconfig > @@ -25,7 +25,7 @@ config SPL_TEXT_BASE > default 0x80 > > config SPL_OPENSBI_LOAD_ADDR > - default 0x0100 > + default 0x > > config SYS_FDT_BASE > hex > -- > 2.17.1 > Otherwise, Reviewed-by: Bin Meng

Re: [PATCH v1 01/17] riscv: cpu: jh7110: Add support for jh7110 SoC

2022-12-28 Thread Bin Meng
On Wed, Dec 28, 2022 at 2:39 PM yanhong wang wrote: > > > > On 2022/12/26 21:54, Bin Meng wrote: > > On Mon, Dec 26, 2022 at 3:32 PM yanhong wang > > wrote: > >> > >> > >> > >> On 2022/12/22 17:22, Bin Meng wrote: > &

<    1   2   3   4   5   6   7   8   9   10   >