Re: [PATCH v2 1/1] cmd: provide command sbi

2020-08-19 Thread Bin Meng
Hi Heinrich, On Wed, Aug 19, 2020 at 1:01 AM Heinrich Schuchardt wrote: > > Provide a command to display information about the SBI implementation. > > The output might look like: > > => sbi > SBI 0.2 > OpenSBI > Extensions: > sbi_set_timer > sbi_console_putchar > sbi_console_getchar > sbi

Re: [PATCH v3 1/1] cmd: provide command sbi

2020-08-19 Thread Bin Meng
se 1: > + printf("OpenSBI\n"); > + break; > + case 2: > + printf("Xvisor\n"); > + break; > + case 3: > + printf("KVM\n

Re: [PATCH v2 1/7] riscv: Rework riscv timer driver to only support S-mode

2020-08-20 Thread Bin Meng
lib/rdtime.c | 38 > drivers/timer/Kconfig | 6 +++--- > drivers/timer/riscv_timer.c | 39 +++-- > 5 files changed, 23 insertions(+), 69 deletions(-) > delete mode 100644 arch/riscv/lib/rdtime.c > Reviewed-by: Bin Meng

Re: [PATCH v2 2/7] riscv: Rework Andes PLMT as a UCLASS_TIMER driver

2020-08-20 Thread Bin Meng
On Wed, Jul 29, 2020 at 5:56 PM Sean Anderson wrote: > > This converts the PLMT driver from the riscv-specific timer interface to be > a DM-based UCLASS_TIMER driver. > > Signed-off-by: Sean Anderson > --- > This patch builds but has NOT been tested. > > (no changes since v1) > > arch/riscv/Kcon

Re: [PATCH v2 3/7] riscv: Clean up initialization in Andes PLIC

2020-08-20 Thread Bin Meng
ch/riscv/lib/andes_plic.c | 58 - > 1 file changed, 25 insertions(+), 33 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 4/7] riscv: Rework Sifive CLINT as UCLASS_TIMER driver

2020-08-20 Thread Bin Meng
On Wed, Jul 29, 2020 at 5:56 PM Sean Anderson wrote: > > This converts the clint driver from the riscv-specific interface to be a > DM-based UCLASS_TIMER driver. We also need to re-add the initialization for > IPI back into the SPL code. This was previously implicitly done when the > timer was ini

Re: [PATCH v2 0/7] riscv: Clean up timer drivers

2020-08-20 Thread Bin Meng
Hi Sean, On Wed, Jul 29, 2020 at 5:56 PM Sean Anderson wrote: > > This series cleans up the timer drivers in RISC-V and converts them to DM. > > This series depends on [1]. This series needs to be tested! I have only tested > it on QEMU and the K210. Notably, this means that the HiFive and anythi

Re: [PATCH v2 6/7] riscv: Update Kendryte device tree for new CLINT driver

2020-08-20 Thread Bin Meng
On Wed, Jul 29, 2020 at 5:57 PM Sean Anderson wrote: > > AFAIK because the K210 clock driver does not come up until after > relocation, the clint will always use the clock-frequency parameter. > Ideally, it should update itself after relocation to take into account the > actual CPU frequency. > >

Re: [PATCH 5/9] xhci-ring.c: Add the poll_pend state to properly abort transactions

2020-08-20 Thread Bin Meng
Hi Jason, On Sat, Jul 25, 2020 at 5:51 AM Jason Wessel wrote: > > xhci_trl_tx and xhchi_bulk_tx can be called synchronously by other > drivers such as the usb storage or network, while the keyboard driver > exclusively uses the polling mode. > Could you provide more details as to when this will

Re: [PATCH v2 1/8] usb: xhci: xhci-dwc3.c: Use dev_remap_addr() instead of dev_get_addr()

2020-08-20 Thread Bin Meng
On Thu, Aug 20, 2020 at 1:35 PM Stefan Roese wrote: > > On MIPS platforms, mapping of the base address is needed. This patch > switches from dev_get_addr() to dev_remap_addr() to get the mapped base > address of the xHCI controller. > > Signed-off-by: Stefan Roese > Cc:

Re: [PATCH v2 2/8] usb: xhci: xhci_bulk_tx: Don't "BUG" when comparing addresses

2020-08-20 Thread Bin Meng
really helpful. it's > > Please also note, that BUG_ON() is not recommended any more in the Linux > kernel. > > Signed-off-by: Stefan Roese > Cc: Bin Meng > Cc: Marek Vasut > > --- > > Changes in v2: > - Completely remove BUG_ON() for this trans_event.buffer

Re: [PATCH v2 3/8] usb: xhci: octeon: Add DWC3 glue layer for Octeon

2020-08-20 Thread Bin Meng
Hi Stefan, On Thu, Aug 20, 2020 at 1:35 PM Stefan Roese wrote: > > This patch adds the glue layer for the MIPS Octeon SoCs. Its ported nits: It's > mainly from the Linux code. > > Signed-off-by: Stefan Roese > Cc: Bin Meng > Cc: Marek Vasut > --- > > (no

Re: [PATCH v2 7/8] mips: octeon: Add USB DT nodes

2020-08-20 Thread Bin Meng
ts > @@ -113,3 +113,25 @@ > reg = <0>; > }; > }; > + > +/* USB 0 */ > +&usb0 { > + status = "okay"; > + /* Power is specified by three parts: > +* 1) GPIO handle (must be &gpio) > +* 2) GPIO pin number > +* 3) Active high (0) or active low (1) > +*/ > + power = <&gpio 20 0>; > +}; > + > +/* USB 1 */ > +&usb1 { > + status = "okay"; > + /* Power is specified by three parts: > +* 1) GPIO handle (must be &gpio) > +* 2) GPIO pin number > +* 3) Active high (0) or active low (1) > +*/ > + power = <&gpio 21 0>; > +}; Otherwise, Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH v7 01/10] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

2020-08-20 Thread Bin Meng
- > drivers/pci/pci-uclass.c | 18 ++- > include/asm-generic/u-boot.h | 2 -- > include/handoff.h | 2 -- > lib/fdtdec.c | 5 > lib/lmb.c | 9 ++-- > 11 files changed, 19 insertions(+), 66 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v7 03/10] board_f: Add default values for bi_dram[] in dram_init_banksize()

2020-08-20 Thread Bin Meng
Hi Stefan, On Thu, Aug 20, 2020 at 12:45 PM Stefan Roese wrote: > > Remove the bi_memstart / bi_memsize assignment in setup_bdinfo() and > make sure, that bd_dram[] is always configured in the weak default > implementation of dram_init_banksize(), when CONFIG_SYS_SDRAM_BASE is > not set. > > Sign

Re: [PATCH v2 3/8] usb: xhci: octeon: Add DWC3 glue layer for Octeon

2020-08-20 Thread Bin Meng
Hi Stefan, On Thu, Aug 20, 2020 at 7:45 PM Stefan Roese wrote: > > Hi Bin, > > On 20.08.20 11:07, Bin Meng wrote: > > Hi Stefan, > > > > On Thu, Aug 20, 2020 at 1:35 PM Stefan Roese wrote: > >> > >> This patch adds the glue layer for the MIPS O

Re: [PATCH v3 2/8] usb: xhci: xhci_bulk_tx: Don't "BUG" when comparing addresses

2020-08-20 Thread Bin Meng
e also note, that BUG_ON() is not recommended any more in the Linux > kernel. > > Signed-off-by: Stefan Roese > Cc: Bin Meng > Cc: Marek Vasut > > --- > > Changes in v3: > - Minor corrections to the commit text as suggested by Bin > > Changes in v2: > -

Re: [PATCH v3 7/8] mips: octeon: Add USB DT nodes

2020-08-20 Thread Bin Meng
Hi Stefan, On Fri, Aug 21, 2020 at 1:34 PM Stefan Roese wrote: > > Add the USB device tree nodes to the Octeon dts/dtsi files. > > Signed-off-by: Stefan Roese > Reviewed-by: Bin Meng > > --- > > Changes in v3: > - Add Reviewed-by tag from Bin > - Correct multi-

Re: [PATCH v3 3/8] usb: xhci: octeon: Add DWC3 glue layer for Octeon

2020-08-20 Thread Bin Meng
On Fri, Aug 21, 2020 at 1:34 PM Stefan Roese wrote: > > This patch adds the glue layer for the MIPS Octeon SoCs. It's ported > mainly from the Linux code. > > Signed-off-by: Stefan Roese > Cc: Bin Meng > Cc: Marek Vasut > > --- > > Changes in v3: >

Re: [PATCH] cmd: irq: disable CMD_IRQ for riscv arch

2020-08-25 Thread Bin Meng
On Mon, Aug 24, 2020 at 11:09 PM Pragnesh Patel wrote: > > For RISC-V arch, no need for CMD_IRQ so disable the same. > > Signed-off-by: Pragnesh Patel > --- > cmd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: NVMe boot issues on RockPro64

2020-08-29 Thread Bin Meng
Hi Punit, On Sat, Aug 29, 2020 at 8:30 AM Punit Agrawal wrote: > > Hi, > > I get the following errors when booting Linux from an ADATA XPG SX8200 > NVMe on a RockPro64. > > [3.705205] rockchip-pcie f800.pcie: unexpected IRQ, INT0 > [3.705226] rockchip-pcie f800.pcie: unexpected IR

Re: [PATCH] x86: mtrr: Fix parsing of "mtrr list" command

2020-08-31 Thread Bin Meng
ds to a "return > CMD_RET_USAGE" in the else-branch. > > Fix this by changing the else-branch to explicitly checking for > if (cmd != 'l'). > > Fixes: b2a76b3fe75a ("x86: mtrr: Restructure so command execution is in one > place") > > Signed-of

Re: [PATCH] x86: mtrr: Fix parsing of "mtrr list" command

2020-08-31 Thread Bin Meng
On Tue, Sep 1, 2020 at 1:23 PM Bin Meng wrote: > > On Fri, Aug 14, 2020 at 3:55 PM Wolfgang Wallner > wrote: > > > > The command 'mtrr' does not recognize the 'list' subcommand any more > > since the code restructuring in commit b2a76b3fe75a (&quo

Re: [PATCH v2 01/15] x86: Introduce USE_EARLY_BOARD_INIT option

2020-08-31 Thread Bin Meng
> board/google/chromebook_link/Kconfig | 1 + > board/google/chromebook_samus/Kconfig | 1 + > 5 files changed, 9 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v2 02/15] x86: advantech: som-db5800-som-6867: Remove dead code

2020-08-31 Thread Bin Meng
mon Glass > --- > v2: added Rb tag(s) > board/advantech/som-db5800-som-6867/Makefile | 2 +- > board/advantech/som-db5800-som-6867/start.S | 8 > 2 files changed, 1 insertion(+), 9 deletions(-) > delete mode 100644 board/advantech/som-db5800-som-6867/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 04/15] x86: coreboot: Remove dead code

2020-08-31 Thread Bin Meng
added Rb tag(s) > board/coreboot/coreboot/Makefile | 2 +- > board/coreboot/coreboot/start.S | 12 > 2 files changed, 1 insertion(+), 13 deletions(-) > delete mode 100644 board/coreboot/coreboot/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 03/15] x86: congatec: conga-qeval20-qa3-e3845: Remove dead code

2020-08-31 Thread Bin Meng
added Rb tag(s) > board/congatec/conga-qeval20-qa3-e3845/Makefile | 2 +- > board/congatec/conga-qeval20-qa3-e3845/start.S | 8 > 2 files changed, 1 insertion(+), 9 deletions(-) > delete mode 100644 board/congatec/conga-qeval20-qa3-e3845/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 05/15] x86: dfi: dfi-bt700: Remove dead code

2020-08-31 Thread Bin Meng
d Rb tag(s) > board/dfi/dfi-bt700/Makefile | 2 +- > board/dfi/dfi-bt700/start.S | 8 > 2 files changed, 1 insertion(+), 9 deletions(-) > delete mode 100644 board/dfi/dfi-bt700/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 08/15] x86: intel: cherryhill: Remove dead code

2020-08-31 Thread Bin Meng
added Rb tag(s) > board/intel/cherryhill/Makefile | 2 +- > board/intel/cherryhill/start.S | 8 > 2 files changed, 1 insertion(+), 9 deletions(-) > delete mode 100644 board/intel/cherryhill/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 06/15] x86: efi: efi-x86_payload: Remove dead code

2020-08-31 Thread Bin Meng
ded Rb tag(s) > > board/efi/efi-x86_payload/Makefile | 2 +- > board/efi/efi-x86_payload/start.S | 8 > 2 files changed, 1 insertion(+), 9 deletions(-) > delete mode 100644 board/efi/efi-x86_payload/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 09/15] x86: intel: cougarcanyon2: Remove dead code

2020-08-31 Thread Bin Meng
added Rb tag(s) > board/intel/cougarcanyon2/Makefile | 2 +- > board/intel/cougarcanyon2/start.S | 8 > 2 files changed, 1 insertion(+), 9 deletions(-) > delete mode 100644 board/intel/cougarcanyon2/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 10/15] x86: intel: crownbay: Remove dead code

2020-08-31 Thread Bin Meng
added Rb tag(s) > board/intel/crownbay/Makefile | 2 +- > board/intel/crownbay/start.S | 8 > 2 files changed, 1 insertion(+), 9 deletions(-) > delete mode 100644 board/intel/crownbay/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 11/15] x86: intel: edison: Remove dead code

2020-08-31 Thread Bin Meng
ded Rb tag(s) > > board/intel/edison/Makefile | 2 +- > board/intel/edison/start.S | 12 > 2 files changed, 1 insertion(+), 13 deletions(-) > delete mode 100644 board/intel/edison/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 07/15] x86: intel: bayleybay: Remove dead code

2020-08-31 Thread Bin Meng
added Rb tag(s) > board/intel/bayleybay/Makefile | 2 +- > board/intel/bayleybay/start.S | 8 > 2 files changed, 1 insertion(+), 9 deletions(-) > delete mode 100644 board/intel/bayleybay/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 13/15] x86: intel: minnowmax: Remove dead code

2020-08-31 Thread Bin Meng
ded Rb tag(s) > > board/intel/minnowmax/Makefile | 2 +- > board/intel/minnowmax/start.S | 8 > 2 files changed, 1 insertion(+), 9 deletions(-) > delete mode 100644 board/intel/minnowmax/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 14/15] x86: intel: slimbootloader: Remove dead code

2020-08-31 Thread Bin Meng
iden Park > --- > v2: added Rb tag(s) > > board/intel/slimbootloader/Makefile | 2 +- > board/intel/slimbootloader/start.S | 9 - > 2 files changed, 1 insertion(+), 10 deletions(-) > delete mode 100644 board/intel/slimbootloader/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 15/15] x86: qemu: Remove dead code

2020-08-31 Thread Bin Meng
ded Rb tag(s) > > board/emulation/qemu-x86/Makefile | 2 -- > board/emulation/qemu-x86/start.S | 8 > 2 files changed, 10 deletions(-) > delete mode 100644 board/emulation/qemu-x86/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 12/15] x86: intel: galileo: Remove dead code

2020-08-31 Thread Bin Meng
ded Rb tag(s) > > board/intel/galileo/Makefile | 2 +- > board/intel/galileo/start.S | 8 > 2 files changed, 1 insertion(+), 9 deletions(-) > delete mode 100644 board/intel/galileo/start.S > Reviewed-by: Bin Meng

Re: [PATCH v2 01/15] x86: Introduce USE_EARLY_BOARD_INIT option

2020-08-31 Thread Bin Meng
On Tue, Sep 1, 2020 at 1:33 PM Bin Meng wrote: > > On Thu, Aug 20, 2020 at 6:02 PM Andy Shevchenko > wrote: > > > > Introduce USE_EARLY_BOARD_INIT option and select it by the actual users. > > > > Cc: George McCollister > > Signed-off-by: Andy Sh

Re: [PATCH 2/2] x86: Drop nhlt_serialise()

2020-08-31 Thread Bin Meng
On Sun, Aug 30, 2020 at 5:23 AM Simon Glass wrote: > > This function is not actually used in U-Boot. Drop it. > > Suggested-by: Bin Meng > > Signed-off-by: Simon Glass > --- > > arch/x86/include/asm/acpi_nhlt.h | 8 > 1 file changed, 8 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 1/2] x86: pinctrl: Fix 'relatove' typo

2020-08-31 Thread Bin Meng
relative to a particular pinctrl device. If disabled, there is a > single ACPI pinctrl device which includes all U-Boot pinctrl devices > and the pin 'offset' is in effect a global pin number. > > -- Reviewed-by: Bin Meng

Re: [PATCH 1/2] x86: pinctrl: Fix 'relatove' typo

2020-08-31 Thread Bin Meng
On Tue, Sep 1, 2020 at 1:45 PM Bin Meng wrote: > > On Sun, Aug 30, 2020 at 5:23 AM Simon Glass wrote: > > > > Fix this typo in the Kconfig help. > > > > Signed-off-by: Simon Glass > > Suggested-by: Wolfgang Wallner > > --- > > > > drive

Re: [PATCH 2/2] x86: Drop nhlt_serialise()

2020-08-31 Thread Bin Meng
On Tue, Sep 1, 2020 at 1:45 PM Bin Meng wrote: > > On Sun, Aug 30, 2020 at 5:23 AM Simon Glass wrote: > > > > This function is not actually used in U-Boot. Drop it. > > > > Suggested-by: Bin Meng > > > > Signed-off-by: Simon Glass > > -

Re: [PATCH v2 15/15] x86: qemu: Remove dead code

2020-08-31 Thread Bin Meng
emulation/qemu-x86/Makefile > index 782e298b74ce..5af8d31d5840 100644 > --- a/board/emulation/qemu-x86/Makefile > +++ b/board/emulation/qemu-x86/Makefile > @@ -1,5 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0+ > # > # Copyright (C) 2015, Bin Meng > - > -obj-y += start.o

Re: [PATCH v2 01/16] x86: Update the bootparam header

2020-09-01 Thread Bin Meng
+Andy Shevchenko On Sun, Aug 30, 2020 at 5:42 AM Simon Glass wrote: > > This header is missing a few of the newer features from the specification. > Add these as well as a link to the spec. Also use the BIT() macros where > appropriate. > > Signed-off-by: Simon Glass > Reviewed-by: Wolfgang Wall

Re: [PATCH v2 02/16] x86: zimage: Use a state struct to hold the state

2020-09-01 Thread Bin Meng
--- > 1 file changed, 29 insertions(+), 15 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 03/16] x86: zimage: Avoid using #ifdef

2020-09-01 Thread Bin Meng
ged, 5 insertions(+), 9 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 04/16] x86: zboot: Move kernel-version code into a function

2020-09-01 Thread Bin Meng
nce, under control of its callers. > > Signed-off-by: Simon Glass > Reviewed-by: Wolfgang Wallner > --- > > (no changes since v1) > > arch/x86/lib/zimage.c | 43 +++ > 1 file changed, 27 insertions(+), 16 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 05/16] x86: zboot: Correct image type

2020-09-01 Thread Bin Meng
allner > --- > > (no changes since v1) > > arch/x86/lib/zimage.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v3] x86: qemu: Remove dead code

2020-09-01 Thread Bin Meng
evchenko > Reviewed-by: Simon Glass > Reviewed-by: Bin Meng > --- > v3: fixed linker error (Bin) > board/emulation/qemu-x86/Makefile | 2 +- > board/emulation/qemu-x86/qemu-x86.c | 0 > board/emulation/qemu-x86/start.S| 8 > 3 files changed, 1 insertion

Re: [PATCH v2 07/16] x86: zboot: Set up a sub-command structure

2020-09-01 Thread Bin Meng
Hi Simon, On Sun, Aug 30, 2020 at 5:42 AM Simon Glass wrote: > > Add subcommands to zboot. At present there is only one called 'start' > which does the whole boot. It is the default command so is optional. > > Change the 's' string variable to const while we are here. > Signed-off-by: Simon Glass

Re: [PATCH v2 08/16] x86: zboot: Add a 'go' subcommand

2020-09-01 Thread Bin Meng
t; Reviewed-by: Wolfgang Wallner > --- > > (no changes since v1) > > arch/x86/lib/zimage.c | 26 +++--- > 1 file changed, 23 insertions(+), 3 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 10/16] x86: zboot: Add an 'setup' subcommand

2020-09-01 Thread Bin Meng
Hi Simon, On Sun, Aug 30, 2020 at 5:42 AM Simon Glass wrote: > > Add a subcommand that sets up the kernel ready for execution. This commit actually adds 2 subcommands. > > Signed-off-by: Simon Glass > Reviewed-by: Wolfgang Wallner > --- > > (no changes since v1) > > arch/x86/lib/zimage.c | 5

Re: [PATCH v2 06/16] x86: zimage: Disable interrupts just before booting

2020-09-01 Thread Bin Meng
> > (no changes since v1) > > arch/x86/lib/zimage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 09/16] x86: zboot: Add an 'info' subcommand

2020-09-01 Thread Bin Meng
ges since v1) > > arch/x86/lib/zimage.c | 17 ++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 11/16] x86: zboot: Set environment variables for image locations

2020-09-01 Thread Bin Meng
zboot_load(struct cmd_tbl *cmdtp, int flag, > int argc, > return CMD_RET_FAILURE; > } > state.base_ptr = base_ptr; > + if (env_set_hex("zbootbase", (ulong)base_ptr) || > + env_set_hex("zbootaddr", state.load_address)) > + return CMD_RET_FAILURE; > > return 0; > } > -- Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH v2 13/16] x86: zboot: Add an option to dump the setup information

2020-09-01 Thread Bin Meng
On Sun, Aug 30, 2020 at 5:42 AM Simon Glass wrote: > > There is a lot of information in the setup block and it is quite hard to > decode manually. Add a 'zboot dump' command to decode it into a > human-readable format. > > Signed-off-by: Simon Glass > Reviewed-by: Wolfgang Wallner > --- > > (no

Re: [PATCH v2 12/16] x86: zboot: Allow setting a separate setup base address

2020-09-01 Thread Bin Meng
++-- > 1 file changed, 33 insertions(+), 6 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 16/16] cros: Add information about booting Chrome OS on x86

2020-09-01 Thread Bin Meng
structions on how to do this. > > Signed-off-by: Simon Glass > Reviewed-by: Wolfgang Wallner > --- > > (no changes since v1) > > doc/README.chromium | 32 > 1 file changed, 32 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v2 14/16] x86: zboot: Allow overriding the command line

2020-09-01 Thread Bin Meng
Simon Glass > Reviewed-by: Wolfgang Wallner > --- > > (no changes since v1) > > arch/x86/include/asm/zimage.h | 30 +- > arch/x86/lib/bootm.c | 2 +- > arch/x86/lib/zimage.c | 21 - > 3 files changed, 4

Re: [PATCH v2 15/16] cros: Update chromium documentation

2020-09-01 Thread Bin Meng
.chromium | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > Reviewed-by: Bin Meng

Please pull u-boot-x86

2020-09-01 Thread Bin Meng
Hi Tom, This PR includes the following x86 changes for v2020.10: - Fix parsing of "mtrr list" command - Introduce USE_EARLY_BOARD_INIT option and remove dead codes for most x86 boards Azure results : PASS https://dev.azure.com/bmeng/GitHub/_build/results?buildId=290&view=results The following c

Re: [RESEND PATCH v2 01/11] usb: xhci: add a member hci_version in xhci_ctrl struct

2020-09-02 Thread Bin Meng
On Wed, Sep 2, 2020 at 6:38 PM Marek Vasut wrote: > > On 9/2/20 8:13 AM, Frank Wunderlich wrote: > > From: Chunfeng Yun > > > > Add a member to save xHCI version, it's used some times. > > > > Signed-off-by: Chunfeng Yun > > --- > > drivers/usb/host/xhci-ring.c | 4 ++-- > > drivers/usb/host/xh

Re: [PATCH v2 7/7] riscv: Update SiFive device tree for new CLINT driver

2020-09-02 Thread Bin Meng
Hi Anup, On Tue, Aug 18, 2020 at 6:03 PM Sean Anderson wrote: > > On 8/18/20 5:22 AM, Bin Meng wrote: > > +Anup Patel > > > > On Wed, Jul 29, 2020 at 5:57 PM Sean Anderson wrote: > >> > >> We may need to add a clock-frequency binding like for the K2

Re: [PATCH v2 7/7] riscv: Update SiFive device tree for new CLINT driver

2020-09-02 Thread Bin Meng
Hi Anup, On Thu, Sep 3, 2020 at 10:46 AM Anup Patel wrote: > > On Thu, Sep 3, 2020 at 7:32 AM Bin Meng wrote: > > > > Hi Anup, > > > > On Tue, Aug 18, 2020 at 6:03 PM Sean Anderson wrote: > > > > > > On 8/18/20 5:22 AM, Bin Meng wrote: > >

Re: [RESEND PATCH v2 01/11] usb: xhci: add a member hci_version in xhci_ctrl struct

2020-09-03 Thread Bin Meng
; include/usb/xhci.h | 1 + > 3 files changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng

Re: RPi4 U-Boot freeze

2020-09-03 Thread Bin Meng
On Thu, Sep 3, 2020 at 7:23 PM Stefan Agner wrote: > > Any thoughts on this issue? > > Just to be sure, I did some memory testing on the 2GB module, but no > issues found. > > I still somehow suspected that something else might be wrong with my > hardware, so I bought a new RPi4 (this time with 4G

Re: [PATCH RESEND v2 05/11] usb: xhci: convert to TRB_TYPE()

2020-09-03 Thread Bin Meng
; include/usb/xhci.h | 1 - > 3 files changed, 6 insertions(+), 9 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH RESEND v2 03/11] usb: xhci: add quirks flag to support MediaTek xHCI 0.96

2020-09-03 Thread Bin Meng
P_BPKTS(1) | EP_BBM(1)); > } > diff --git a/include/usb/xhci.h b/include/usb/xhci.h > index 15926eb..3de46cd 100644 > --- a/include/usb/xhci.h > +++ b/include/usb/xhci.h > @@ -1230,6 +1230,8 @@ struct xhci_ctrl { > struct xhci_virt_device *devs[MAX_HC_SLOTS]; > int rootdev; > u16 hci_version; > + u32 quirks; > +#define XHCI_MTK_HOST BIT(0) > }; > > unsigned long trb_addr(struct xhci_segment *seg, union xhci_trb *trb); > -- Reviewed-by: Bin Meng

Re: [RESEND PATCH v2 04/11] usb: xhci: convert to HCS_MAX_PORTS()

2020-09-03 Thread Bin Meng
xhci.h | 2 -- > 2 files changed, 1 insertion(+), 4 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH RESEND v2 05/11] usb: xhci: convert to TRB_TYPE()

2020-09-04 Thread Bin Meng
Hi Marek, On Fri, Sep 4, 2020 at 3:05 PM Marek Vasut wrote: > > On 9/4/20 8:54 AM, Bin Meng wrote: > > On Wed, Aug 26, 2020 at 5:31 PM Chunfeng Yun > > wrote: > >> > >> Use TRB_TYPE(p) instead of ((p) << TRB_TYPE_SHIFT) > >> > >&g

Re: [RESEND PATCH v2 05/11] usb: xhci: convert to TRB_TYPE()

2020-09-04 Thread Bin Meng
+-- > include/usb/xhci.h | 1 - > 3 files changed, 6 insertions(+), 9 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH RESEND v2 05/11] usb: xhci: convert to TRB_TYPE()

2020-09-07 Thread Bin Meng
Hi Chunfeng, On Mon, Sep 7, 2020 at 3:20 PM Chunfeng Yun wrote: > > Hi Bin, > > On Fri, 2020-09-04 at 15:19 +0800, Bin Meng wrote: > > Hi Marek, > > > > On Fri, Sep 4, 2020 at 3:05 PM Marek Vasut wrote: > > > > > > On 9/4/20 8:54 AM, Bin Men

Re: [PATCH v3 6/9] usb: xhci: convert to TRB_LEN() and TRB_INTR_TARGET()

2020-09-07 Thread Bin Meng
) > -#defineTRB_LEN_MASK(0x1) > /* TD Size, packets remaining in this TD, bits 21:17 (5 bits, so max 31) */ > #define TRB_TD_SIZE(p) (min((p), (u32)31) << 17) > /* Interrupter Target - which MSI-X vector to target the completion event at > */ > -#defineTRB_INTR_TARGET_SHIFT (22) > -#defineTRB_INTR_TARGET_MASK(0x3ff) > #define TRB_INTR_TARGET(p) (((p) & 0x3ff) << 22) > #define GET_INTR_TARGET(p) (((p) >> 22) & 0x3ff) > #define TRB_TBC(p) (((p) & 0x3) << 7) > -- Reviewed-by: Bin Meng

Re: [PATCH v3 7/9] usb: xhci: convert to TRB_TX_TYPE()

2020-09-07 Thread Bin Meng
> 2 files changed, 2 insertions(+), 3 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 8/9] usb: xhci: use macros with parameter to fill ep_info2

2020-09-07 Thread Bin Meng
no changes > --- > drivers/usb/host/xhci-mem.c | 15 +-- > drivers/usb/host/xhci.c | 6 ++ > include/usb/xhci.h | 6 -- > 3 files changed, 7 insertions(+), 20 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 9/9] usb: xhci: convert to readx_poll_sleep_timeout()

2020-09-07 Thread Bin Meng
> 1 file changed, 11 insertions(+), 14 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 2/9] usb: xhci: create one unified function to calculate TRB TD remainder.

2020-09-07 Thread Bin Meng
xhci_td_remainder(length), 0); > + TRB_TD_SIZE(remainder), 0); > > if (length > 0) { > if (req->requesttype & USB_DIR_IN) > diff --git a/include/usb/xhci.h b/include/usb/xhci.h > index a3e5914..15926eb 100644 > --- a/include/usb/xhci.h > +++ b/include/usb/xhci.h > @@ -850,6 +850,8 @@ struct xhci_event_cmd { > /* transfer_len bitmasks - bits 0:16 */ > #defineTRB_LEN(p) ((p) & 0x1) > #defineTRB_LEN_MASK(0x1) > +/* TD Size, packets remaining in this TD, bits 21:17 (5 bits, so max 31) */ > +#define TRB_TD_SIZE(p) (min((p), (u32)31) << 17) > /* Interrupter Target - which MSI-X vector to target the completion event at > */ > #defineTRB_INTR_TARGET_SHIFT (22) > #defineTRB_INTR_TARGET_MASK(0x3ff) Otherwise, Reviewed-by: Bin Meng

Re: [PATCH v3 9/9] usb: xhci: convert to readx_poll_sleep_timeout()

2020-09-08 Thread Bin Meng
Hi Marek, On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut wrote: > > On 9/8/20 3:44 AM, Bin Meng wrote: > > On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun > > wrote: > >> > >> Use readx_poll_sleep_timeout() to poll the register status > >> > >> Sig

Re: [PATCH v3 9/9] usb: xhci: convert to readx_poll_sleep_timeout()

2020-09-08 Thread Bin Meng
Hi Marek, On Wed, Sep 9, 2020 at 12:15 AM Marek Vasut wrote: > > On 9/8/20 5:45 PM, Bin Meng wrote: > > Hi Marek, > > Hi, > > > On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut wrote: > >> > >> On 9/8/20 3:44 AM, Bin Meng wrote: > >>>

Re: [PATCH v3 9/9] usb: xhci: convert to readx_poll_sleep_timeout()

2020-09-09 Thread Bin Meng
On Wed, Sep 9, 2020 at 7:05 PM Marek Vasut wrote: > > On 9/9/20 3:55 AM, Bin Meng wrote: > > Hi Marek, > > Hi, > > > On Wed, Sep 9, 2020 at 12:15 AM Marek Vasut wrote: > >> > >> On 9/8/20 5:45 PM, Bin Meng wrote: > >>> Hi Marek, > >&

Re: [PATCH v3 9/9] usb: xhci: convert to readx_poll_sleep_timeout()

2020-09-09 Thread Bin Meng
On Wed, Sep 9, 2020 at 10:02 PM Marek Vasut wrote: > > On 9/9/20 3:46 PM, Bin Meng wrote: > > On Wed, Sep 9, 2020 at 7:05 PM Marek Vasut wrote: > >> > >> On 9/9/20 3:55 AM, Bin Meng wrote: > >>> Hi Marek, > >> > >> Hi, &

Re: [PATCH 1/3] riscv: Add timer_get_us() for tracing

2020-09-10 Thread Bin Meng
Hi Pragnesh, On Mon, Aug 24, 2020 at 10:45 PM Pragnesh Patel wrote: > > timer_get_us() will use timer_ops->get_count() function for timer counter. > For S-mode U-Boot, CSR_TIMEH and CSR_TIME will provide a timer counter and > For M-mode U-Boot, mtime register will provide the same. > > Signed-off

Re: [PATCH 1/1] riscv: add DT binding for BOOT button on Maix board

2020-09-11 Thread Bin Meng
On Thu, Sep 3, 2020 at 4:12 AM Heinrich Schuchardt wrote: > > Add a device tree binding for the BOOT button on the Maix board. > > Signed-off-by: Heinrich Schuchardt > --- > Together with > [PATCH 1/1] cmd/button: return button status > https://lists.denx.de/pipermail/u-boot/2020-September/425221

Re: [PATCH] riscv: Only enable OF_BOARD_FIXUP for S-Mode

2020-09-11 Thread Bin Meng
Hi Sean, On Sat, Sep 5, 2020 at 9:22 PM Sean Anderson wrote: > > It is unsafe to enable OF_BOARD_FIXUP only based on OF_SEPARATE. > OF_SEPARATE may indicate that the user wishes U-Boot to use a different > device tree than one obtained via OF_PRIOR_STAGE. However, OF_SEPARATE may > also indicate

Re: [PATCH 1/7] Revert "riscv: Clear pending interrupts before enabling IPIs"

2020-09-11 Thread Bin Meng
Hi Sean, On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > Clearing MIP doesn't do anything. Whoops. The following commits should Which following commits? > tackle this problem in a more robust manner. > > This reverts commit 9472630337e7c4ac442066b5a752aaa8c3b4d4a6. > > Signed-off-by: Se

Re: [PATCH 2/7] riscv: Match memory barriers between send_ipi_many and handle_ipi

2020-09-11 Thread Bin Meng
ipi->arg1; > > + __smp_mb(); > + > ret = riscv_send_ipi(reg); > if (ret) { > pr_err("Cannot send IPI to hart %d\n", reg); Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH 3/7] riscv: Use NULL as a sentinel value for smp_call_function

2020-09-11 Thread Bin Meng
++ > 1 file changed, 22 insertions(+), 4 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH] riscv: Only enable OF_BOARD_FIXUP for S-Mode

2020-09-11 Thread Bin Meng
On Fri, Sep 11, 2020 at 6:20 PM Sean Anderson wrote: > > On 9/11/20 3:29 AM, Bin Meng wrote: > > Hi Sean, > > > > On Sat, Sep 5, 2020 at 9:22 PM Sean Anderson wrote: > >> > >> It is unsafe to enable OF_BOARD_FIXUP only based on OF_SEPARATE. > >&

Re: [PATCH 1/7] Revert "riscv: Clear pending interrupts before enabling IPIs"

2020-09-11 Thread Bin Meng
On Fri, Sep 11, 2020 at 6:22 PM Sean Anderson wrote: > > On 9/11/20 3:38 AM, Bin Meng wrote: > > Hi Sean, > > > > On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > >> > >> Clearing MIP doesn't do anything. Whoops. The following commits should &

Re: [PATCH 5/7] riscv: Add fence to available_harts_lock

2020-09-11 Thread Bin Meng
On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > Without these fences, it is perfectly valid for an out-of-order core to > re-order memory accesses to outside of the available_harts_lock critical > section. The commit message should be reworded, because current codes do nothing wrong as "f

Re: [PATCH] RFC: tegra: xhci: Allocate from non-cached memory

2020-09-11 Thread Bin Meng
Hi Tom, On Sat, Sep 12, 2020 at 3:43 AM wrote: > > From: Tom Warren > > This fixes the XHCI driver on T210 boards (TX1, Nano). I was seeing > that Set_Address wasn't completing, returning with a Context Parameter > error. Examining the slot context, etc. showed that the correct info was > there

Re: [PATCH 3/7] riscv: Use NULL as a sentinel value for smp_call_function

2020-09-13 Thread Bin Meng
Hi Leo, On Mon, Sep 14, 2020 at 9:58 AM Leo Liang wrote: > > On Fri, Sep 11, 2020 at 04:04:13PM +0800, Bin Meng wrote: > > On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > > > > > Some IPIs may already be pending when U-Boot is started. This could be a >

Re: [PATCH 4/7] riscv: Clear pending IPIs on initialization

2020-09-13 Thread Bin Meng
t_loop, instead of relaxing. > > Signed-off-by: Sean Anderson > --- > > arch/riscv/cpu/cpu.c | 18 ++ > 1 file changed, 18 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 6/7] riscv: Ensure gp is NULL or points to valid data

2020-09-13 Thread Bin Meng
On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > This allows code to use a construct like `if (gd & gd->...) { ... }` when > accessing the global data pointer. Without this change, it was possible for > a very early trap to cause _exit_trap to read arbitrary memory. This could > cause a sec

Re: [PATCH 7/7] riscv: Add some comments to start.S

2020-09-13 Thread Bin Meng
On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > This adds comments regarding the ordering and purpose of certain > instructions as I understand them. > > Signed-off-by: Sean Anderson > --- > > arch/riscv/cpu/start.S | 19 +-- > 1 file changed, 17 insertions(+), 2 deletion

Re: [PATCH 3/7] riscv: Use NULL as a sentinel value for smp_call_function

2020-09-13 Thread Bin Meng
Hi Leo, On Mon, Sep 14, 2020 at 2:10 PM Leo Liang wrote: > > Hi, Bin > On Mon, Sep 14, 2020 at 10:07:57AM +0800, Bin Meng wrote: > > Hi Leo, > > > > On Mon, Sep 14, 2020 at 9:58 AM Leo Liang wrote: > > > > > > On Fri, Sep 11, 2020 at 04:04:13PM +0800

Re: [PATCH] riscv: Only enable OF_BOARD_FIXUP for S-Mode

2020-09-13 Thread Bin Meng
On Sat, Sep 12, 2020 at 2:25 AM Sean Anderson wrote: > > On 9/11/20 10:43 AM, Bin Meng wrote: > > On Fri, Sep 11, 2020 at 6:20 PM Sean Anderson wrote: > >> > >> On 9/11/20 3:29 AM, Bin Meng wrote: > >>> Hi Sean, > >>> > >>> On Sat

Re: [PATCH] doc: icicle: Fix incorrect board name in HSS docs

2021-03-10 Thread Bin Meng
; 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 2/4] net: phy: drop #ifdef CONFIG_DM_ETH around phy_connect_fixed

2021-03-11 Thread Bin Meng
r reachable, since > the whole function is already under #ifdef CONFIG_PHY_FIXED (which > again, as I said, depends on CONFIG_DM_ETH=y). > > Signed-off-by: Vladimir Oltean > --- > drivers/net/phy/phy.c | 6 -- > 1 file changed, 6 deletions(-) > Reviewed-by: Bin Meng

<    3   4   5   6   7   8   9   10   11   12   >