[U-Boot] [PATCH v3 5/8] arm: dts: imx7s-warp: Create alias for mmc0 to

2019-01-09 Thread Bryan O'Donoghue
that rely on mmc 0. Setup the alias of mmc0 and usdhc3 so that existing warp7 boot code will work unmodified. Signed-off-by: Bryan O'Donoghue Cc: Albert Aribaud Cc: Peng Fan Cc: Fabio Estevam Cc: Stefano Babic --- arch/arm/dts/imx7s-warp.dts | 4 1 file changed, 4 insertions(+) diff

Re: [U-Boot] [PATCH] crypto: fsl: jr: Make job-rings assignment non-Secure dependent

2019-04-06 Thread Bryan O'Donoghue
On 05/04/2019 17:16, Breno Matheus Lima wrote: + if ((IS_ENABLED(CONFIG_OPTEE) || +!IS_ENABLED(CONFIG_ARMV7_BOOT_SEC_DEFAULT)) && +!IS_ENABLED(CONFIG_CMD_DEKBLOB)) { So. How does this patch work if you want to do HABv4 encrypted authentication of an OP-TEE

Re: [U-Boot] [PATCH] crypto: fsl: jr: Make job-rings assignment non-Secure dependent

2019-04-06 Thread Bryan O'Donoghue
On 06/04/2019 16:21, Bryan O'Donoghue wrote: 1. I notice somebody has already added a save_gd()/restore_gd() pair I'm referring to save_gd()/restore_gd() here : https://source.codeaurora.org/external/imx/uboot-imx/tree/arch/arm/mach-imx/hab.c?h=imx_v2018.03_4.14.78_1.0.0_ga but... it's

Re: [U-Boot] [PATCH] crypto: fsl: jr: Make job-rings assignment non-Secure dependent

2019-04-08 Thread Bryan O'Donoghue
On 07/04/2019 19:56, Breno Matheus Lima wrote: Hi Bryan, Em dom, 7 de abr de 2019 às 05:05, Bryan O'Donoghue escreveu: On 06/04/2019 22:41, Breno Matheus Lima wrote: save_jr_context(); setup_some_new_jr_context(); hab_authenticate_something(); restore_jr_context(); This can only work

[U-Boot] [RESEND] [PATCH] cmd: image_info: Add checking of default FIT config

2019-03-11 Thread Bryan O'Donoghue
@1): sha1+ Hash(es) for Image 3 (bootscr): sha1+ Hash for default configuration: sha1,rsa2048:mbl-fit-rot-key+ Signed-off-by: Bryan O'Donoghue Cc: Jun Nie Cc: Simon Glass Cc: Tom Rini Reviewed-by: Simon Glass --- cmd/bootm.c | 17 + 1 file changed, 17 insertions(+) diff

Re: [U-Boot] [PATCH v2] warp7: README: Adjust the binary name after DM conversion

2019-02-13 Thread Bryan O'Donoghue
On 09/02/2019 14:01, Fabio Estevam wrote: After the conversion to DM the U-Boot binary is called u-boot-dtb.imx, so fix the README file accordingly. Signed-off-by: Fabio Estevam oops send RB from wrong address - one more time Reviewed-by: Bryan O'Donoghue

Re: [U-Boot] [PATCH v2] warp7: README: Adjust the binary name after DM conversion

2019-02-13 Thread Bryan O'Donoghue
On 09/02/2019 14:01, Fabio Estevam wrote: After the conversion to DM the U-Boot binary is called u-boot-dtb.imx, so fix the README file accordingly. Signed-off-by: Fabio Estevam Reviewed-by: Bryan O'Donoghue ___ U-Boot mailing list U-Boot

Re: [U-Boot] [PATCH] crypto: fsl: jr: Make job-rings assignment non-Secure dependent

2019-04-07 Thread Bryan O'Donoghue
On 06/04/2019 22:41, Breno Matheus Lima wrote: Hi Bryan, Em sáb, 6 de abr de 2019 às 12:21, Bryan O'Donoghue escreveu: On 05/04/2019 17:16, Breno Matheus Lima wrote: Basically you've described and additional dependency the BootROM has, so lets just "switch context" prior

Re: [U-Boot] [PATCH] crypto: fsl: jr: Make job-rings assignment non-Secure dependent

2019-04-15 Thread Bryan O'Donoghue
On 08/04/2019 13:58, Fabio Estevam wrote: Hi Bryan, On Mon, Apr 8, 2019 at 5:10 AM Bryan O'Donoghue wrote: DTB is the way to go. Could you please submit a patch that fixes the regression? I can publish something soon, sure. ___ U-Boot

Re: [U-Boot] [PATCH] Revert "drivers/crypto/fsl: assign job-rings to non-TrustZone"

2019-06-04 Thread Bryan O'Donoghue
com/OP-TEE/optee_os/pull/2986 This reverts commit 22191ac353445ad8fafc5a78aefcd94e78963041. Signed-off-by: Breno Lima Acked-by: Bryan O'Donoghue as this change has been applied https://github.com/OP-TEE/optee_os/pull/2986 --- bod ___ U-Boot mail

Re: [U-Boot] [PATCH 3/7] warp7: include: configs: Differentiate bootscript address from loadaddr

2019-05-09 Thread Bryan O'Donoghue
On 08/05/2019 20:33, Pierre-Jean Texier wrote: Hi Bryan, Le 08/05/2019 à 20:14, Bryan O'Donoghue a écrit : Reusing the loadaddr to load the boot script breaks some of the logic we want to have around the bootscript/FIT load addresses. Making a dedicated bootscript address allows us

Re: [U-Boot] [PATCH 3/7] warp7: include: configs: Differentiate bootscript address from loadaddr

2019-05-13 Thread Bryan O'Donoghue
On 09/05/2019 16:32, Bryan O'Donoghue wrote: On 08/05/2019 20:33, Pierre-Jean Texier wrote: Hi Bryan, Le 08/05/2019 à 20:14, Bryan O'Donoghue a écrit : Reusing the loadaddr to load the boot script breaks some of the logic we want to have around the bootscript/FIT load addresses. Making

Re: [U-Boot] [PATCH 3/7] warp7: include: configs: Differentiate bootscript address from loadaddr

2019-05-15 Thread Bryan O'Donoghue
On 14/05/2019 21:27, Pierre-Jean Texier wrote: should this apply in isolation ? Not necessarily, on my side everything working well on-top of master, for example: Hit any key to stop autoboot:  0 => run bootcmd_mmc0 switch to partitions #0, OK mmc0(part 0) is current device Scanning mmc

Re: [U-Boot] [PATCH 3/7] warp7: include: configs: Differentiate bootscript address from loadaddr

2019-05-20 Thread Bryan O'Donoghue
On 15/05/2019 20:13, Pierre-Jean Texier wrote: Regarding your question, it seems that is now the standard on many platforms [2]. In fact, instead of keeping a custom environment, it is better to use a more generic approach by switching to disto config (with boot.scr, extlinux, and so on).

[U-Boot] [PATCH 1/7] warp7_bl33: configs: Enable FIT as the boot.scr format

2019-05-08 Thread Bryan O'Donoghue
This patch switches on FIT verification of boot.scr. After this commit your boot.scr must be in the FIT format. Signed-off-by: Bryan O'Donoghue --- configs/warp7_bl33_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/warp7_bl33_defconfig b/configs/warp7_bl33_defconfig

[U-Boot] [PATCH 6/7] warp7: include: configs: Specify an fdtovaddr

2019-05-08 Thread Bryan O'Donoghue
In the Mbed Linux OS bootflow OP-TEE runs before u-boot and provides a DTB overlay at 0x8310. This overlay should subsequently be merged into the main DTB before handing over to the kernel. This patch defines fdtovaddr at 0x8310. Signed-off-by: Bryan O'Donoghue --- include/configs

[U-Boot] [PATCH 5/7] warp7_bl33: configs: Enable CONFIG_OF_LIBFDT_OVERLAY

2019-05-08 Thread Bryan O'Donoghue
This commit enables CONFIG_OF_LIBFDT_OVERLAY a requirement to perform a merge of an OPTEE provided DTB overlay into our main kernel DTB image. Signed-off-by: Bryan O'Donoghue --- configs/warp7_bl33_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/warp7_bl33_defconfig b

Re: [U-Boot] [PATCH 0/4] Tidy up some dangling OP-TEE gotchas

2019-04-29 Thread Bryan O'Donoghue
On 24/04/2019 01:43, Bryan O'Donoghue wrote: Rober P Day rightly pointed out that some odd OP-TEE specific defines were appearing in his defconfig, despite not having CONFIG_OPTEE=y set in his defconfig. Ping, Robert, Rui, Fabio - do you guys want changes here ? --- bod

Re: [U-Boot] [PATCH 2/4] crypto/fsl: Use __sec_set_jr_context_normal

2019-04-29 Thread Bryan O'Donoghue
On 25/04/2019 04:24, Breno Matheus Lima wrote: I couldn't get encrypted boot working in my first attempt, doing the exact same procedure with commit 22191ac35344 ("drivers/crypto/fsl: assign job-rings to non-TrustZone") reverted works fine. Hi Breno, I noticed another patch from you re: dek

Re: [U-Boot] [PATCH 2/4] crypto/fsl: Use __sec_set_jr_context_normal

2019-04-30 Thread Bryan O'Donoghue
On 30/04/2019 02:28, Bryan O'Donoghue wrote: On 25/04/2019 04:24, Breno Matheus Lima wrote: I couldn't get encrypted boot working in my first attempt, doing the exact same procedure with commit 22191ac35344 ("drivers/crypto/fsl: assign job-rings to non-TrustZone") reverted works

Re: [U-Boot] [PATCH 1/4] crypto/fsl: Introduce API to save/restore job-ring context

2019-04-30 Thread Bryan O'Donoghue
On 25/04/2019 23:13, Breno Matheus Lima wrote: Hi Bryan, Em ter, 23 de abr de 2019 às 07:20, Bryan O'Donoghue escreveu: We need to handle the case where DEK blobs are passed to the BootROM. In this case, unlike in HAB authentication the BootROM checks job-ring ownership set to secure world

[U-Boot] [PATCH v2 2/4] warp7: include: configs: Skip low-level init if BOOTM_OPTEE false

2019-05-03 Thread Bryan O'Donoghue
oad OP-TEE not if u-boot has already been loaded by OP-TEE. Signed-off-by: Bryan O'Donoghue Cc: Fabio Estevam Cc: Breno Lima Cc: Rui Miguel Silva Acked-by: Rui Miguel Silva --- include/configs/warp7.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/configs/warp7.h

[U-Boot] [PATCH v2 1/4] optee: Make TZDRAM config options contingent on CONFIG_OPTEE

2019-05-03 Thread Bryan O'Donoghue
ZDRAM_BASE CONFIG_OPTEE_TZDRAM_SIZE Rightly, if you don't have CONFIG_OPTEE=y you don't care about the above two defines. Signed-off-by: Bryan O'Donoghue Cc: Rui Miguel Silva Acked-by: Rui Miguel Silva --- lib/optee/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/optee/Kco

[U-Boot] [PATCH v2 4/4] MAINTAINERS: Update lib/optee with my details

2019-05-03 Thread Bryan O'Donoghue
Commit 32ce6179fb99 ("optee: Add lib entries for sharing OPTEE code across ports") adds code into lib/optee but neglects to update MAINTAINERS to make me buggable for questions and maintenance. Signed-off-by: Bryan O'Donoghue Suggested-by: Jens Wiklander --- MAINTAINERS | 5 +++

[U-Boot] [PATCH v2 3/4] warp7: configs: bl33: Tidy up OPTEE defines

2019-05-03 Thread Bryan O'Donoghue
. Signed-off-by: Bryan O'Donoghue Cc: Fabio Estevam --- configs/warp7_bl33_defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configs/warp7_bl33_defconfig b/configs/warp7_bl33_defconfig index 300dc3805a..735c85c0a3 100644 --- a/configs/warp7_bl33_defconfig +++ b

[U-Boot] [PATCH v2 0/4] Tidy up some dangling OP-TEE gotchas

2019-05-03 Thread Bryan O'Donoghue
details so that questions pertaining to lib/optee comes my way. Bryan O'Donoghue (4): optee: Make TZDRAM config options contingent on CONFIG_OPTEE warp7: include: configs: Skip low-level init if BOOTM_OPTEE false warp7: configs: bl33: Tidy up OPTEE defines MAINTAINERS: Update lib/optee

Re: [U-Boot] [PATCH v2] imx: Use a convenient default value for SYS_MALLOC_F_LEN

2019-05-03 Thread Bryan O'Donoghue
LOC_F_LEN. Reported-by: Pierre-Jean Texier Suggested-by: Lukas Auer Signed-off-by: Fabio Estevam Good work. Tested: warp7_bl33, warp7 Tested-by: Bryan O'Donoghue ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 7/7] warp7: Specify a default CONFIG_OPTEE_LOAD_ADDR if non provided

2019-05-08 Thread Bryan O'Donoghue
If no CONFIG_OPTEE_LOAD_ADDR is provided i.e. you are not loading OPTEE into memory in u-boot, then just set the non-existent CONFIG option to zero, elsewise stringify(CONFIG_OPTEE_LOAD_ADDR) will return "CONFIG_OPTEE_LOAD_ADDR" - which looks weird in the u-boot environment. Signed-off

[U-Boot] [PATCH 2/7] warp7: include: configs: Specify image name of bootscript in FIT

2019-05-08 Thread Bryan O'Donoghue
to enable others to use a different name than "bootscr" as the image name of the boot script in their FIT. Signed-off-by: Bryan O'Donoghue --- include/configs/warp7.h | 8 1 file changed, 8 insertions(+) diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 0e

[U-Boot] [PATCH 3/7] warp7: include: configs: Differentiate bootscript address from loadaddr

2019-05-08 Thread Bryan O'Donoghue
what the load sequence the bootscript and Kernel/OPTEE binary load addresses do not conflict. Signed-off-by: Bryan O'Donoghue --- include/configs/warp7.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 95955fd626

[U-Boot] [PATCH 0/7] Switch WaRP7 BL33 to mbed Linux specific bootflow

2019-05-08 Thread Bryan O'Donoghue
l DTB, prior to hand-off to Linux. Some updates to warp7_bl33 and some minor updates to the shared WaRP7/WaRP7_bl33 code are included. Bryan O'Donoghue (7): warp7_bl33: configs: Enable FIT as the boot.scr format warp7: include: configs: Specify image name of bootscript in FIT warp7: incl

[U-Boot] [PATCH 4/7] warp7_bl33: configs: Enable CONFIG_OF_LIBFDT

2019-05-08 Thread Bryan O'Donoghue
In order to switch on DTB overlay support in WaRP7 BL33 we first need to switch on LIBFDT support. Do that now. Signed-off-by: Bryan O'Donoghue --- configs/warp7_bl33_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/warp7_bl33_defconfig b/configs/warp7_bl33_defconfig index

[U-Boot] [PATCH 2/2] efi_loader: Return non-zero for error in efi_add_memory_map()

2019-07-08 Thread Bryan O'Donoghue
Heinrich Schuchardt Cc: Alexander Graf Signed-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index 27379381e8..7d6aab255c 100644 --- a/lib/efi_loader/ef

[U-Boot] [PATCH 0/2] efi_loader: Fix inconsistencies in efi_add_memory_map usage

2019-07-08 Thread Bryan O'Donoghue
() does not properly parse the result code. The second patch fixes the result code returned by efi_add_memory_map() in two instances. Returing zero is the same as returning EFI_SUCCESS, we should return one of the error codes from include/efi.h only, not zero to indicate failure. Bryan O'Donoghue (2

[U-Boot] [PATCH 1/2] efi_loader: Check the result of efi_add_memory_map against input addr

2019-07-08 Thread Bryan O'Donoghue
Cc: Alexander Graf Signed-off-by: Bryan O'Donoghue --- cmd/bootefi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index c19256e00d..0b404ccbd1 100644 --- a/cmd/bootefi.c +++ b/cmd/bootefi.c @@ -169,8 +169,8 @@ static void efi_carve_

Re: [U-Boot] [PATCH 0/2] efi_loader: Fix inconsistencies in efi_add_memory_map usage

2019-07-09 Thread Bryan O'Donoghue
On 09/07/2019 07:02, Heinrich Schuchardt wrote: On 7/9/19 1:10 AM, Bryan O'Donoghue wrote: These two patches fix some inconsistent usage around efi_add_memory_map(). The first patch fixes the case where there is a mapping for an address starting at 0 as is the case on RPI3. We should

[U-Boot] [PATCH v3 8/8] efi_loader: Capture efi_add_memory_map() result efi_add_runtime_mmio()

2019-07-14 Thread Bryan O'Donoghue
-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_runtime.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c index 40fdc0ea92..12ee6faadd 100644 --- a/lib/efi_loader/efi_runtime.c +++ b/lib/efi_loader/efi_runtime.c

[U-Boot] [PATCH v3 7/8] efi_loader: Treat the result of efi_add_memory_map as efi_status_t

2019-07-14 Thread Bryan O'Donoghue
emrsv map 0: Failed to add to map". Fixes: 416e07e2cfcf ("efi: Drop error return in efi_carve_out_dt_rsv()") Cc: Heinrich Schuchardt Cc: Alexander Graf Signed-off-by: Bryan O'Donoghue --- cmd/bootefi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/boote

[U-Boot] [PATCH v3 3/8] efi_loader: Change efi_add_memory_map() to return EFI_SUCCESS

2019-07-14 Thread Bryan O'Donoghue
efi_add_memory_map() wants to return 0 to indicate success in two places. Instead of returning zero we should return the defined efi_status_t return value EFI_SUCCESS. Signed-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [U-Boot] [PATCH 1/1] efi_loader: allow adding mapped memory at 0x00000000

2019-07-14 Thread Bryan O'Donoghue
On 13/07/2019 21:02, Heinrich Schuchardt wrote: As efi_add_memory_map() signals an error by returning NULL and correct function by returning the requested address we cannot discern an error from correct functioning for address 0x. This leads to unexpected warnings on the Raspberry 3.

Re: [U-Boot] [PATCH v3 6/8] efi_loader: Update efi_free_pages() to new efi_add_memory_map()

2019-07-14 Thread Bryan O'Donoghue
On 15/07/2019 00:57, Heinrich Schuchardt wrote: Reviewed-by: Heinrich Schuchardt NP I'll squash these down in the morning. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v3 4/8] efi_loader: Return non-zero for error in efi_add_memory_map()

2019-07-14 Thread Bryan O'Donoghue
d map") Fixes: 74c16acce30b ("efi_loader: Don't allocate from memory holes") Cc: Heinrich Schuchardt Cc: Alexander Graf Signed-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_memor

[U-Boot] [PATCH v3 6/8] efi_loader: Update efi_free_pages() to new efi_add_memory_map()

2019-07-14 Thread Bryan O'Donoghue
efi_add_memory_map() now returns efi_status_t not the passed uint64_t address on success. We need to capture that change in efi_free_pages(). Signed-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_memory.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/lib

[U-Boot] [PATCH v3 5/8] efi_loader: Update efi_allocate_pages() to new efi_add_memory_map()

2019-07-14 Thread Bryan O'Donoghue
efi_add_memory_map() now returns efi_status_t not the passed uint64_t address on success. We need to capture that change in efi_allocate_pages(). Signed-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader

[U-Boot] [PATCH v3 1/8] efi_loader: Change return type of efi_add_memory_map()

2019-07-14 Thread Bryan O'Donoghue
will change the internal values themselves and finally the users of efi_add_memory_map(). Signed-off-by: Bryan O'Donoghue Suggested-by: Heinrich Schuchardt --- include/efi_loader.h| 4 ++-- lib/efi_loader/efi_memory.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[U-Boot] [PATCH v3 0/8] efi_loader: Fix inconsistencies in efi_add_memory_map usage

2019-07-14 Thread Bryan O'Donoghue
_rsv() does not properly parse the result code. The second patch fixes the result code returned by efi_add_memory_map() in two instances. Returing zero is the same as returning EFI_SUCCESS, we should return one of the error codes from include/efi.h only, not zero to indicate failure. Bryan O'Donoghue (7

[U-Boot] [PATCH v3 2/8] efi_loader: Add a method description to efi_add_memory_map

2019-07-14 Thread Bryan O'Donoghue
From: Heinrich Schuchardt Adds a method description of efi_add_memory_map(). Signed-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_memory.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index c5a8f3ab29..8625968396

[U-Boot] [PATCH v2 0/7] efi_loader: Fix inconsistencies in efi_add_memory_map usage

2019-07-14 Thread Bryan O'Donoghue
the result code returned by efi_add_memory_map() in two instances. Returing zero is the same as returning EFI_SUCCESS, we should return one of the error codes from include/efi.h only, not zero to indicate failure. Bryan O'Donoghue (7): efi_loader: Change return type of efi_add_memory_map

[U-Boot] [PATCH v2 1/7] efi_loader: Change return type of efi_add_memory_map()

2019-07-14 Thread Bryan O'Donoghue
will change the internal values themselves and finally the users of efi_add_memory_map(). Signed-off-by: Bryan O'Donoghue Suggested-by: Heinrich Schuchardt --- include/efi_loader.h| 4 ++-- lib/efi_loader/efi_memory.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[U-Boot] [PATCH v2 7/7] efi_loader: Capture efi_add_memory_map() result efi_add_runtime_mmio()

2019-07-14 Thread Bryan O'Donoghue
-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_runtime.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c index 40fdc0ea92..12ee6faadd 100644 --- a/lib/efi_loader/efi_runtime.c +++ b/lib/efi_loader/efi_runtime.c

[U-Boot] [PATCH v2 2/7] efi_loader: Change efi_add_memory_map() to return EFI_SUCCESS

2019-07-14 Thread Bryan O'Donoghue
efi_add_memory_map() wants to return 0 to indicate success in two places. Instead of returning zero we should return the defined efi_status_t return value EFI_SUCCESS. Signed-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[U-Boot] [PATCH v2 4/7] efi_loader: Update efi_allocate_pages() to new efi_add_memory_map()

2019-07-14 Thread Bryan O'Donoghue
efi_add_memory_map() now returns efi_status_t not the passed uint64_t address on success. We need to capture that change in efi_allocate_pages(). Signed-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader

[U-Boot] [PATCH v2 5/7] efi_loader: Update efi_free_pages() to new efi_add_memory_map()

2019-07-14 Thread Bryan O'Donoghue
efi_add_memory_map() now returns efi_status_t not the passed uint64_t address on success. We need to capture that change in efi_free_pages(). Signed-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_memory.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib

[U-Boot] [PATCH v2 3/7] efi_loader: Return non-zero for error in efi_add_memory_map()

2019-07-14 Thread Bryan O'Donoghue
d map") Fixes: 74c16acce30b ("efi_loader: Don't allocate from memory holes") Cc: Heinrich Schuchardt Cc: Alexander Graf Signed-off-by: Bryan O'Donoghue --- lib/efi_loader/efi_memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_memor

[U-Boot] [PATCH v2 6/7] efi_loader: Treat the result of efi_add_memory_map as efi_status_t

2019-07-14 Thread Bryan O'Donoghue
emrsv map 0: Failed to add to map". Fixes: 416e07e2cfcf ("efi: Drop error return in efi_carve_out_dt_rsv()") Cc: Heinrich Schuchardt Cc: Alexander Graf Signed-off-by: Bryan O'Donoghue --- cmd/bootefi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/boote

[U-Boot] [PATCH v4 0/1] efi_loader: Fix inconsistencies in efi_add_memory_map usage

2019-07-15 Thread Bryan O'Donoghue
return one of the error codes from include/efi.h only, not zero to indicate failure. Bryan O'Donoghue (1): efi_loader: Change return type of efi_add_memory_map() cmd/bootefi.c| 4 ++-- include/efi_loader.h | 4 ++-- lib/efi_loader/efi_memory.c | 32 ++

[U-Boot] [PATCH v4 1/1] efi_loader: Change return type of efi_add_memory_map()

2019-07-15 Thread Bryan O'Donoghue
eviewed-by: Heinrich Schuchardt Cc: Alexander Graf Signed-off-by: Bryan O'Donoghue --- cmd/bootefi.c| 4 ++-- include/efi_loader.h | 4 ++-- lib/efi_loader/efi_memory.c | 32 lib/efi_loader/efi_runtime.c | 6 +++--- 4 files changed, 27 inserti

Re: [U-Boot] "optee" Kbuild seems to have weird dependencies

2019-04-23 Thread Bryan O'Donoghue
On 23/04/2019 10:22, Jens Wiklander wrote: Hi Robert, On Thu, Apr 18, 2019 at 10:19 PM Robert P. J. Day wrote: going over the u-boot.cfg generated from zynq_zed_defconfig, and noticed the following: #define CONFIG_OPTEE_TZDRAM_BASE 0x #define CONFIG_OPTEE_TZDRAM_SIZE

[U-Boot] [PATCH 0/4 RFC] imx: Implement job-ring context switching

2019-04-23 Thread Bryan O'Donoghue
. Please note: compile tested but not runtime tested, I don't currently have DEK blob encrypted images to test against - hence RFC on this patchset. Bryan O'Donoghue (4): crypto/fsl: Introduce API to save/restore job-ring context crypto/fsl: Use __sec_set_jr_context_normal powerpc: mpc85xx

[U-Boot] [PATCH 2/4] crypto/fsl: Use __sec_set_jr_context_normal

2019-04-23 Thread Bryan O'Donoghue
Use __sec_set_jr_context_normal() to set job-ring ownership rather than the current in-line array walk. Signed-off-by: Bryan O'Donoghue --- drivers/crypto/fsl/jr.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/crypto/fsl/jr.c b/drivers/crypto/fsl/jr.c index

[U-Boot] [PATCH 4/4] crypto/fsl: Wrapper run_descriptor_jr_idx() to set jr permissions

2019-04-23 Thread Bryan O'Donoghue
run_descriptor_jr_idx() is complete we switch back to normal-world ownership. Normal world job-ring ownership allows Linux to run in either secure or normal world when using the CAAM, irrespective which is ultimately what we want to support. Signed-off-by: Bryan O'Donoghue --- drivers/crypto/fsl/jr.c

[U-Boot] [PATCH 3/4] powerpc: mpc85xx: crypto: Implement mpc85xxx specific job-ring fix

2019-04-23 Thread Bryan O'Donoghue
The mpc85xxx has more than one sec block. As a result we need to have an architecture specific version of: void sec_set_jr_context_secure(void); void sec_set_jr_context_normal(void); This patch implements those functions. Signed-off-by: Bryan O'Donoghue --- arch/powerpc/cpu/mpc85xx/cpu_init.c

[U-Boot] [PATCH 1/4] crypto/fsl: Introduce API to save/restore job-ring context

2019-04-23 Thread Bryan O'Donoghue
sec_set_jr_context_normal(void); This can be over-ridden for a given architecture, as will be necessary for the MPC85xxx Signed-off-by: Bryan O'Donoghue --- drivers/crypto/fsl/jr.c | 38 ++ include/fsl_sec.h | 3 +++ 2 files changed, 41 insertions(+) diff --git

[U-Boot] [PATCH 2/4] warp7: include: configs: Skip low-level init if BOOTM_OPTEE false

2019-04-23 Thread Bryan O'Donoghue
oad OP-TEE not if u-boot has already been loaded by OP-TEE. Signed-off-by: Bryan O'Donoghue Cc: Fabio Estevam Cc: Breno Lima Cc: Rui Miguel Silva --- include/configs/warp7.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/configs/warp7.h b/include/configs/war

[U-Boot] [PATCH 4/4] MAINTAINERS: Update lib/optee with my details

2019-04-23 Thread Bryan O'Donoghue
Commit 32ce6179fb99 ("optee: Add lib entries for sharing OPTEE code across ports") adds code into lib/optee but neglects to update MAINTAINERS to make me buggable for questions and maintenance. Signed-off-by: Bryan O'Donoghue Suggested-by: Jens Wiklander --- MAINTAINERS | 5 +++

[U-Boot] [PATCH 3/4] warp7: configs: bl33: Tidy up OPTEE defines

2019-04-23 Thread Bryan O'Donoghue
. Signed-off-by: Bryan O'Donoghue Cc: Fabio Estevam --- configs/warp7_bl33_defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configs/warp7_bl33_defconfig b/configs/warp7_bl33_defconfig index 6eaf152bac..8cc622fe47 100644 --- a/configs/warp7_bl33_defconfig +++ b

[U-Boot] [PATCH 0/4] Tidy up some dangling OP-TEE gotchas

2019-04-23 Thread Bryan O'Donoghue
are compiling for OPTEE - Fix WaRP7 BL33 so that the low-level init skipping routines can tolerate the afore mentioned change. - Update MAINTAINERS with my own details so that questions pertaining to lib/optee comes my way. Bryan O'Donoghue (4): optee: Make TZDRAM config options contingent

[U-Boot] [PATCH 1/4] optee: Make TZDRAM config options contingent on CONFIG_OPTEE

2019-04-23 Thread Bryan O'Donoghue
ZDRAM_BASE CONFIG_OPTEE_TZDRAM_SIZE Rightly, if you don't have CONFIG_OPTEE=y you don't care about the above two defines. Signed-off-by: Bryan O'Donoghue Cc: Rui Miguel Silva --- lib/optee/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/optee/Kconfig b/lib/optee/Kconfig index

Re: [U-Boot] nxp: HABv4 secure boot on iMX7 NAND broken

2019-07-30 Thread Bryan O'Donoghue
On 30/07/2019 14:56, Igor Opaniuk wrote: Does that happen ? Yes, it does. And the board is closed ? ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] nxp: HABv4 secure boot on iMX7 NAND broken

2019-07-30 Thread Bryan O'Donoghue
On 30/07/2019 15:26, Igor Opaniuk wrote: Anyway, let me go through this article one more time, and I'll get back to you. If I've understood you, you are using the same binary for serial download and flash booting. Won't work unfortunately - there's an extra DCD directive in the recovery

Re: [U-Boot] nxp: HABv4 secure boot on iMX7 NAND broken

2019-07-30 Thread Bryan O'Donoghue
On 30/07/2019 12:00, Igor Opaniuk wrote: Hi folks, Just curious if you ever faced any issues with HABv4 based secure boot on iMX7 SoC-based boards + NAND + mainline U-Boot (although it works perfectly when booting from eMMC). I'm currently playing with it on Colibri iMX7 NAND version,

Re: [U-Boot] nxp: HABv4 secure boot on iMX7 NAND broken

2019-07-30 Thread Bryan O'Donoghue
On 30/07/2019 15:02, Bryan O'Donoghue wrote: On 30/07/2019 14:56, Igor Opaniuk wrote: Does that happen ? Yes, it does. And the board is closed ? Obviously yes it is. You have to sign the binary differently for serial download versus boot from eMMC - I guess this holds for NAND too

[PATCH] env: sf: Don't call spi_flash_free when CONFIG_DM_SPI_FLASH=y

2019-12-22 Thread Bryan O'Donoghue
TD devices will be found because spi_free_flash() will have removed the MTD device from mtd_idr. Fix this case by avoiding the spi_free_flash() call when DM_SPI_FLASH is true as we already do in cmd/sf.c. Signed-off-by: Bryan O'Donoghue --- env/sf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

[PATCH] net: phy: micrel: ksz8061 implement errata 80000688A fix

2020-03-26 Thread Bryan O'Donoghue
Linux commit 232ba3a51cc2 ('net: phy: Micrel KSZ8061: link failure after cable connect') implements a fix for the above errata. This patch replicates that errata fix in an ksz8061 specific init routine. Signed-off-by: Bryan O'Donoghue --- drivers/net/phy/micrel_ksz8xxx.c | 16

<    1   2   3   4   5   6