scmi/scmi_agent-uclass.c | 118 +++---
> 1 file changed, 59 insertions(+), 59 deletions(-)
>
Reviewed-by: Etienne Carriere
> diff --git a/drivers/firmware/scmi/scmi_agent-uclass.c
> b/drivers/firmware/scmi/scmi_agent-uclass.c
> index 39cf15c88f75..8693e4c447b7 100644
>
> From: AKASHI Takahiro
> Sent: Wednesday, July 26, 2023 10:38
>
> SCMI base protocol is mandatory and doesn't need to be listed in a device
> tree.
>
> Signed-off-by: AKASHI Takahiro
> Reviewed-by: Simon Glass
Reviewed-by: Etienne Carriere
> ---
> arch/sand
gt; The test scenario is not changed at all.
>
> Signed-off-by: AKASHI Takahiro
> Reviewed-by: Simon Glass
> ---
Reviewed-by: Etienne Carriere
> arch/sandbox/include/asm/scmi_test.h | 7 ++-
> drivers/firmware/scmi/sandbox-scmi_agent.c | 20 +--
> drivers/firmware/s
> From: AKASHI Takahiro
> Sent: Wednesday, July 26, 2023 10:38
>
> This is a simple implementation of SCMI base protocol for sandbox.
> The main use is in SCMI unit test.
>
> Signed-off-by: AKASHI Takahiro
> Reviewed-by: Simon Glass
Reviewed-by: Etienne Carr
gt; Signed-off-by: AKASHI Takahiro
> ---
> v2
> * remove sub command category, 'scmi base', for simplicity
Reviewed-by: Etienne Carriere
> ---
> cmd/Kconfig | 9 ++
> cmd/Makefile | 1 +
> cmd/scmi.c | 334 +++
> 3 files c
> From: AKASHI Takahiro
> Sent: Wednesday, July 26, 2023 10:38
>
> This is a help text for scmi command.
>
> Signed-off-by: AKASHI Takahiro
> ---
> v2
> * add more descriptions about SCMI
Reviewed-by: Etienne Carriere
> ---
&
d as sandbox's device tree.
>
> Signed-off-by: AKASHI Takahiro
> ---
> v2
> * use helper functions, removing direct uses of ops
> ---
Reviewed-by: Etienne Carriere
with reported issue fixed.
> test/dm/scmi.c | 109 +
> 1 fi
and the version check will be introduced.
> To finish "ut dm scmi_[clocks|resets|voltage_domains]" tests, sandbox SCMI
> agent should also implement/mimic this command.
>
> Signed-off-by: AKASHI Takahiro
Aside the typos, inherited from previous patch series, the patch looks all good
to me.
SHI Takahiro
> Reviewed-by: Simon Glass
> ---
> v2
> * use helper functions, removing direct uses of ops
Reviewed-by: Etienne Carriere
with patch on dm_test_scmi_base() squashed in patch 9/12.
> ---
> test/dm/scmi.c | 59 +++
ed by the SCMI server (firmware).
>
> Signed-off-by: AKASHI Takahiro
> ---
Reviewed-by: Etienne Carriere
> drivers/firmware/scmi/scmi_agent-uclass.c | 41 +--
> 1 file changed, 38 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/scmi/scmi
> From: AKASHI Takahiro
> Sent: Friday, July 28, 2023 02:33
> Subject: [RFC 3/3] firmware: scmi: add a sanity check against protocol version
>
> SCMI_PROTOCOL_VERSION is a mandatory command for all the SCMI protocols.
> With this patch, this command is implemented on each protocol.
> Then, we
address of offset 0 of a physical 4kB page. In such case, OP-TEE
secure world refuses to register the zero-sized shared memory
area and makes U-Boot optee service enumeration to fail.
Fixes: 94ccfb78a4d6 ("drivers: tee: optee: discover OP-TEE services")
Signed-off-by: Etienn
Signed-off-by: Etienne Carriere
---
drivers/tee/optee/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index 9a9b697e91..5308dd58ce 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers/tee/optee/core.c
@@ -841,7 +841,7
return ret;
> + }
> + if (version < SCMI_BASE_PROTOCOL_VERSION)
> + return -EINVAL;
LGTM. The open source SCMI server implementations I'm aware of (scp-firmware,
tf-a and optee-os) all report SCMI Base protocol version v2.0.
Reviewed-by: Etienne Carriere
each of functions in ops
> ---
This patch v5 looks good to me. 2 suggestions.
Reviewed-by: Etienne Carriere with comments
addressed or not.
I have successfully tested the whole PATCH v5 series on my platform.
> drivers/firmware/scmi/Makefile | 1 +
> drivers/firmware/scmi/base.c | 65
--
> drivers/power/regulator/scmi_regulator.c | 26 ++
> drivers/reset/reset-scmi.c| 19 +---
> include/scmi_agent.h | 15 ++--
> 5 files changed, 104 insertions(+), 88 deletions(-)
>
Reviewed-by: Etienne Carriere
i_agent-uclass.h | 8 +---
> 5 files changed, 18 insertions(+), 12 deletions(-)
>
Reviewed-by: Etienne Carriere
Thanks for addressing this protocol channel issue.
BR,
Etienne
+
> > 2 files changed, 103 insertions(+)
> >
>
> Reviewed-by: Simon Glass
>
Reviewed-by: Etienne Carriere
work was added
> > in a prior commit.
> >
> > Signed-off-by: AKASHI Takahiro
> > ---
> > v5
> > * new commit
> > ---
> > arch/sandbox/dts/test.dts | 1 +
> > test/dm/scmi.c| 20 ++--
> > 2 files changed, 19 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Simon Glass
>
Reviewed-by: Etienne Carriere
Hello Takahiro-san,
> From: U-Boot on behalf of Simon Glass
>
> Sent: Thursday, July 27, 2023 2:50 AM
>
> On Wed, 26 Jul 2023 at 02:38, AKASHI Takahiro
> wrote:
> >
> > The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channel
> > reference") added an explicit parameter,
Hello Akashi-san,
> From: AKASHI Takahiro
> Sent: Monday, August 7, 2023 12:03 PM
>
> Hi Etienne,
>
> On Thu, Aug 03, 2023 at 09:24:51AM +, Etienne CARRIERE wrote:
> > Hello Takahiro-san,
> >
> > Sorry again for this late feedback.
> > Testing the
Hello Sughosh,
Sorry for this very late reply especially since I have a quite negative
feedback on the proposed changes.
I don't think FWU metadata version 1 should be removed from U-Boot support.
There are existing immutable boot agent relying on format v1, starting from the
Synquacer boards
301 - 322 of 322 matches
Mail list logo
