[PATCH] phycore_pcl063: Drop leading zero from USB vendor number

2024-03-25 Thread Fabio Estevam
CONFIG_USB_GADGET_VENDOR_NUM is a 16-bit number, so remove the leading zero. Reported-by: Marek Vasut Signed-off-by: Fabio Estevam --- configs/phycore_pcl063_defconfig | 2 +- configs/phycore_pcl063_ull_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v1 1/3] crypto/fsl: allow accessing Job Ring from non-TrustZone

2024-03-25 Thread Fabio Estevam
Hi Emanuele, On Mon, Mar 25, 2024 at 8:47 AM Emanuele Ghidoli wrote: > +config FSL_CAAM_JR_NTZ_ACCESS > + bool "Give caam Job Ring access to non-secure world" Please spell CAAM instead. > + default n 'default n' is already the default, please drop this line.

Re: [PATCH] board: phytec: phycore_imx8mp.env fix netboot issues

2024-03-24 Thread Fabio Estevam
On Fri, Mar 22, 2024 at 9:55 AM Yannic Moog wrote: > > The "run netargs" command should come later in the "netboot" command > order when using dhcp since it sets the server and client ip addresses. > The previous order led to misconfigured kernel boot params and thus > kernel panic when serverip

Re: [PATCH v3 2/3] configs: imx93-phyboard-segin: Add USB support

2024-03-24 Thread Fabio Estevam
On Thu, Mar 21, 2024 at 4:17 PM Marek Vasut wrote: > $ git grep -i usb.*phytec configs > configs/phycore_pcl063_defconfig:CONFIG_USB_GADGET_MANUFACTURER="Phytec" > configs/phycore_pcl063_ull_defconfig:CONFIG_USB_GADGET_MANUFACTURER="Phytec" > > It would be good to be consistent. > > Also, what

Re: [PATCH v3 1/3] arm: dts: imx93-phyboard-segin: Add USB support

2024-03-24 Thread Fabio Estevam
On Thu, Mar 21, 2024 at 4:17 PM Marek Vasut wrote: > > On 3/21/24 3:45 PM, Mathieu Othacehe wrote: > > Enable both usbotg1 and usbotg2 ports. Disable over-current as OC pins are > > not connected to the SoC. > > > > This > > "This addition to ...-u-boot.dtsi is temporary, ..." would be clearer.

Re: [PATCH] imx: ele_ahab: Add ahab_commit command support

2024-03-24 Thread Fabio Estevam
On Thu, Mar 21, 2024 at 4:20 AM Mathieu Othacehe wrote: > > This message is used to commit into the fuses any new SRK revocation and > FW version information that have been found into the NXP (ELE FW) and > OEM containers. > > Signed-off-by: Mathieu Othacehe Applied to u-boot-imx/next, thanks.

Re: [PATCH v4 00/11] imx8mp: Enable PCIe/NVMe support

2024-03-24 Thread Fabio Estevam
On Fri, Mar 22, 2024 at 10:51 AM Fabio Estevam wrote: > > Hi Sumit, > > On Thu, Mar 21, 2024 at 11:55 AM Sumit Garg wrote: > > > Changes in v4: > > - Incorporated misc comments from Marek and added his review tag. > > - Dropped patch #4 (imx8mp: power-domain: Do

[GIT PULL] Please pull u-boot-imx-next-20240324

2024-03-24 Thread Fabio Estevam
Hi Tom, Please pull this material for next from u-boot-imx, thanks. The following changes since commit fb49d6c289d942ff7de309a5c5eaa37a7f4235db: remoteproc: uclass: Add methods to load firmware to rproc and boot rproc (2024-03-22 15:50:28 -0400) are available in the Git repository at:

Re: [PATCH] arm64: Fix map_range() not splitting mapped blocks

2024-03-22 Thread Fabio Estevam
On Fri, Mar 22, 2024 at 4:31 PM Fabio Estevam wrote: > As Pierre's explanation addresses Marc's concern, > do you think this can go to 2024.01 to fix the boot regression on imx8qxp/8qm? I meant 2024.04, sorry.

Re: [PATCH] arm64: Fix map_range() not splitting mapped blocks

2024-03-22 Thread Fabio Estevam
Hi Tom, On Tue, Mar 19, 2024 at 9:39 AM Pierre-Clément Tosi wrote: > For most AArch64 U-Boot ports (including the i.MX family), the answer is > trivial > because they use the arch code i.e. setup_all_pgtables(). However, as > fsl-layerscape re-implements mmu_setup(), it had to be looked at

Re: inconsistent wget behavior

2024-03-22 Thread Fabio Estevam
Hi Paul, On Sun, Feb 11, 2024 at 4:42 PM Paul Liu wrote: > > Hi Fabio, > > I'm on vacation now (Chinese new year). I hope I'll find some time to revive > my imx8 board. > I've tried sandbox and qemu. Both of them are not reproducible. I'm wondering > if it could be some packet loss that causes

Re: [PATCH v4 00/11] imx8mp: Enable PCIe/NVMe support

2024-03-22 Thread Fabio Estevam
Hi Sumit, On Thu, Mar 21, 2024 at 11:55 AM Sumit Garg wrote: > Changes in v4: > - Incorporated misc comments from Marek and added his review tag. > - Dropped patch #4 (imx8mp: power-domain: Don't power off pd_bus) > since power domain off path is never excercised for DT based devices. > -

Re: [PATCH 00/12] arm: xea: Provide support for different XEA board HW versions

2024-03-22 Thread Fabio Estevam
Hi Lukasz, On Fri, Mar 22, 2024 at 8:43 AM Lukasz Majewski wrote: > arch/arm/dts/Makefile | 3 +- > arch/arm/dts/imx28-xea-1-u-boot.dtsi | 11 > arch/arm/dts/imx28-xea-1.dts | 8 +++ > arch/arm/dts/imx28-xea-2-u-boot.dtsi | 11

Re: [PATCH v3 1/3] arm: dts: imx93-phyboard-segin: Add USB support

2024-03-21 Thread Fabio Estevam
; Signed-off-by: Mathieu Othacehe Thanks, this looks better: Reviewed-by: Fabio Estevam

Re: [PATCH v2 0/3] imx93-phyboard-segin: Add USB support.

2024-03-21 Thread Fabio Estevam
Hi Mathieu, On Thu, Mar 21, 2024 at 3:57 AM Mathieu Othacehe wrote: > Mathieu Othacehe (3): > arm: dts: imx93-phyboard-segin: Add USB support > configs: imx93-phyboard-segin: Add USB support > configs: imx93-phyboard-segin: Add fastboot support > > arch/arm/dts/imx93-phyboard-segin.dts

Re: [PATCH] arm64: Fix map_range() not splitting mapped blocks

2024-03-19 Thread Fabio Estevam
1088A, LS2080A, LX2162A and LX2160A I saw the original boot problem with the i.MX8QX. The i.MX8QX is part of the i.MX family, not the Layerscape family. > I suppose Fabio and Stefano can answer this and/or help with ensuring that > setup_pgtables() is never called on live PTs. Let me know if you need any clarification. Thanks, Fabio Estevam

Re: [PATCH 1/2] clk: clk-imx8qxp: Add LPUART IPG entries

2024-03-18 Thread Fabio Estevam
Hi Tom and Sean, On Fri, Mar 8, 2024 at 5:13 PM Fabio Estevam wrote: > > Since commit cc7df0b9e8bc ("serial: lpuart: Enable IPG clock") > the colibri-imx8qxp board no longer boots. > > The reason is that the imx8qxp clock driver does not handle the > LPUART IPG clocks

Re: [PATCH 1/2] arm64: Reduce add_map() complexity

2024-03-18 Thread Fabio Estevam
the > issue? Your patch fixed the boot regression. Thanks for your fix, appreciated it! I have replied with my Tested-by tag. Cheers, Fabio Estevam

Re: [PATCH] arm64: Fix map_range() not splitting mapped blocks

2024-03-18 Thread Fabio Estevam
ensures that it actually was a block mapping (calls panic() otherwise) > before splitting it. > > Fixes: 41e2787f5ec4 ("arm64: Reduce add_map() complexity") > Signed-off-by: Pierre-Clément Tosi This fixes the boot regression on colibri-imx8x. Thanks a lot for your fix! Tested-by: Fabio Estevam

Re: [PATCH 1/2] arm64: Reduce add_map() complexity

2024-03-18 Thread Fabio Estevam
On Mon, Mar 18, 2024 at 10:31 AM Fabio Estevam wrote: > I tried dumping the page table entries, but could not notice anything > that looked suspicious. This looks suspicious: With 41e2787f5ec4 reverted: Checking if pte fits for virt=1c00 size=6400 blocksize=4000 Checking

Re: [PATCH 1/2] arm64: Reduce add_map() complexity

2024-03-18 Thread Fabio Estevam
Hi Pierre, On Fri, Mar 15, 2024 at 12:13 PM Pierre-Clément Tosi wrote: > I had a quick look through your logs and notice that U-Boot master attempts to > map addresses in the high VA range e.g. > > Checking if pte fits for virt=e400 [...] > > while the logs that boot successfully

Re: [PATCH v1] arm: imx: imx8m: soc: Fix NPU/VPU fdt disable fixup

2024-03-17 Thread Fabio Estevam
On Fri, Mar 15, 2024 at 11:45 AM Vitor Soares wrote: > > From: Vitor Soares > > On imx8m[m|p|q].dtsi, upstream Linux uses different names for NPU/VPU > IP block nodes. It leads variants without such HW block having it > enabled by default. > > This patch adds the upstream Linux node's paths to

Re: [PATCH] apalis-imx8: Fix sc_misc_otp_fuse_read() error check

2024-03-17 Thread Fabio Estevam
On Tue, Mar 12, 2024 at 9:59 PM Fabio Estevam wrote: > > Commit bfb3409d676f ("imx: toradex/apalis-imx8: correct SCU API usage") > made an incorrect logic change in the error code check of > sc_misc_otp_fuse_read(): > > - if (scierr == SC_ERR_

Re: [PATCH] colibri-imx8x: Fix sc_misc_otp_fuse_read() error check

2024-03-17 Thread Fabio Estevam
On Tue, Mar 12, 2024 at 9:36 PM Fabio Estevam wrote: > > Commit aa6e698a7acd ("imx: toradex/colibri-imx8x: correct SCU API usage") > made an incorrect logic change in the error code check of > sc_misc_otp_fuse_read(): > > - if (sc_err == SC_ERR_

Re: [PATCH] imx8m*_venice: move venice to OF_UPSTREAM

2024-03-17 Thread Fabio Estevam
On Tue, Mar 12, 2024 at 10:16 PM Fabio Estevam wrote: > > Hi Tim, > > On Tue, Mar 12, 2024 at 4:05 PM Tim Harvey wrote: > > > > Move to imx8m{m,n,p}-venice to OF_UPSTREAM: > > - replace the non-upstream generic imx8m{m,n,p}-venice dt with one of the > >

Re: [PATCH v2 0/5] Add RAUC boot logic for phycore_imx8mp

2024-03-17 Thread Fabio Estevam
On Tue, Mar 12, 2024 at 6:00 AM Leonard Anderweit wrote: > > This series adds RAUC boot logic for the phycore_imx8mp. > The first patch converts the environment from a CFG_EXTRA_ENV_SETTINGS #define > to a text environment for better readability and maintainability. > The second patch moves the

Re: [PATCH] board: phytec: define get_som_type also when SoM detection is disabled

2024-03-17 Thread Fabio Estevam
On Tue, Mar 12, 2024 at 6:39 AM Benjamin Hahn wrote: > > define the phytec_get_som_type function also when the SoM detection is > disabled. > > Fixes: > commit 110d321a56c3 ("board: phytec: common: phytec_som_detection: Add > phytec_get_som_type") > > Signed-off-by: Benjamin Hahn Applied for

Re: [PATCH v1] configs: colibri-imx7: enable watchdog

2024-03-17 Thread Fabio Estevam
On Thu, Mar 7, 2024 at 12:23 PM Parth Pancholi wrote: > > From: Parth Pancholi > > Enable watchdog functionality for Toradex's Colibri iMX7 (NAND/EMMC) > modules. > > Signed-off-by: Parth Pancholi Applied for u-boot-imx/next, thanks.

Re: [PATCH] drivers: imx_tmu: Select polling-rate from cpu-thermal devicetree node

2024-03-17 Thread Fabio Estevam
On Mon, Mar 4, 2024 at 8:49 AM Benjamin Hahn wrote: > > The polling rate is already specified in some devicetrees, like > imx8mp.dtsi for example, but was not selected so far. For the > trippoints, the cpu-thermal node is used. Also get the polling rate from > this node. Use the default of 5000ms

[GIT PULL] Please pull u-boot-imx-next-20240317

2024-03-17 Thread Fabio Estevam
Hi Tom, Please pull this material for next from u-boot-imx, thank The following changes since commit 099c94b7613bb10d97936447f5136f3a36694325: Merge tag 'u-boot-rockchip-20240315' of https://source.denx.de/u-boot/custodians/u-boot-rockchip into next (2024-03-15 09:15:31 -0400) are

[GIT PULL] Please pull u-boot-imx-master-20240317

2024-03-17 Thread Fabio Estevam
. Benjamin Hahn (1): board: phytec: define get_som_type also when SoM detection is disabled Fabio Estevam (2): colibri-imx8x: Fix sc_misc_otp_fuse_read() error check apalis-imx8: Fix sc_misc_otp_fuse_read() error check Vitor Soares (1): arm: imx: imx8m: soc: Fix NPU

Re: [PATCH v1] doc: board: colibri-imx8x: Update and improve documentation

2024-03-15 Thread Fabio Estevam
Hi Hiago, On Fri, Mar 15, 2024 at 11:39 AM Hiago De Franco wrote: > > From: Hiago De Franco > > Update and improve the building documentation of Colibri iMX8X. > The following changes were made: > - imx-atf repository changed to nxp-imx GitHub. > - imx-atf branch updated to 'lf_v2.6'. > -

Re: [PATCH 1/2] arm64: Reduce add_map() complexity

2024-03-15 Thread Fabio Estevam
Hi Marc, On Sat, Mar 9, 2024 at 11:36 AM Fabio Estevam wrote: > Does the log below help? > > https://pastebin.com/raw/1i1VBA0a > > If not, please send me a debug patch and I will be glad to run it here. I'm sorry to bother you, but have you had a chance to look at the log I

Re: [PATCH] imx8m*_venice: move venice to OF_UPSTREAM

2024-03-12 Thread Fabio Estevam
imply OF_UPSTREAM > - remove rudundant files from arch/arm/dts leaving only the >*-u-boot.dtsi files > > Signed-off-by: Tim Harvey ... > 33 files changed, 13 insertions(+), 10658 deletions(-) This diff looks great :-) Reviewed-by: Fabio Estevam I will queue it to u-boot-imx/next soon.

[PATCH] apalis-imx8: Fix sc_misc_otp_fuse_read() error check

2024-03-12 Thread Fabio Estevam
Fixes: bfb3409d676f ("imx: toradex/apalis-imx8: correct SCU API usage") Signed-off-by: Fabio Estevam --- board/toradex/apalis-imx8/apalis-imx8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/toradex/apalis-imx8/apalis-imx8.c b/board/toradex/apalis-imx8/ap

Re: [PATCH] ARM: imx: stm32: Test whether ethernet node is enabled before reading MAC EEPROM on DHSOM

2024-03-12 Thread Fabio Estevam
Hi Marek, On Tue, Mar 12, 2024 at 6:16 PM Marek Vasut wrote: > NOTE: It is probably best if this goes in via either imx or stm32 tree, > I can break the patch up, but that would introduce dependency > between two PRs in different trees. Let me know what you prefer. I can apply it

[PATCH] colibri-imx8x: Fix sc_misc_otp_fuse_read() error check

2024-03-12 Thread Fabio Estevam
698a7acd ("imx: toradex/colibri-imx8x: correct SCU API usage") Reported-by: Hiago De Franco Signed-off-by: Fabio Estevam --- board/toradex/colibri-imx8x/colibri-imx8x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/toradex/colibri-imx8x/colibri-imx8x.c b/boa

Re: [PATCH 3/5] configs: phycore-imx8mp_defconfig: Use redundant environment

2024-03-11 Thread Fabio Estevam
Hi Leonard, On Mon, Mar 11, 2024 at 11:32 AM Leonard Anderweit wrote: > I also got an error while applying this to next. To apply cleanly this > series requires the commit 19f657600781 (configs: Resync with > savedefconfig) which is on master but not on next. > > If this missing commit is

Re: [PATCH 3/5] configs: phycore-imx8mp_defconfig: Use redundant environment

2024-03-11 Thread Fabio Estevam
Hi Leonard, On Mon, Mar 11, 2024 at 10:04 AM Leonard Anderweit wrote: > > Add support for the redundant environment. > > Signed-off-by: Leonard Anderweit Please rebase this series against U-Boot next branch and resend. There is an error while applying this patch against next. Thanks

Re: [PATCH] arm: dts: imx8mp-beacon-kit: Resync DTS with Linux 6.8

2024-03-11 Thread Fabio Estevam
On Sun, Mar 10, 2024 at 1:59 PM Adam Ford wrote: > > The device tree has evolved over time, so re-sync. This also > partial reverts one change on the PCIe, because U-Boot doesn't > have a proper driver. However, since the clock is configured > to generate a 100MHz reference clock by default, a

Re: [PATCH] toradex: tdx-cfg-block: add 0087 i.mx8m mini product variant

2024-03-11 Thread Fabio Estevam
On Fri, Mar 8, 2024 at 11:18 AM Joao Paulo Goncalves wrote: > > From: Joao Paulo Goncalves > > Add new product id 0087 Verdin iMX8M Mini Quad 2GB IT. > > Signed-off-by: Joao Paulo Goncalves Applied, thanks.

Re: [PATCH] configs: imx8mp_beacon: Fall back to using TF-A

2024-03-11 Thread Fabio Estevam
On Thu, Mar 7, 2024 at 8:59 AM Adam Ford wrote: > > When the board was originally added, it enabled some features which > allowed it to bypass Trusted Firmware, but as the feature set of > Linux grew and more features became available, the U-Boot config > options which bypassed TF-A caused

Re: [PATCH v3 0/2] board: phytec_imx8mp: Use 2GHz RAM timings for PCL-070 from pcb_rev 1

2024-03-11 Thread Fabio Estevam
On Wed, Mar 6, 2024 at 1:18 PM Benjamin Hahn wrote: > > PCL-070 supports 2GHz RAM-timings from pcb_rev 1 and newer. PCM-070 > supports 2GHz RAM-timings only from pcb_rev 3 and newer. > > Signed-off-by: Benjamin Hahn Applied all, thanks.

[GIT PULL] Please pull u-boot-imx-master-20240311

2024-03-11 Thread Fabio Estevam
Hi Tom, Please pull from u-boot-imx, thanks. The following changes since commit 0981f8900f2b1f45a3f282b704012b5374fdd7a6: Merge https://source.denx.de/u-boot/custodians/u-boot-usb (2024-03-09 11:29:48 -0500) are available in the Git repository at:

Re: [PATCH v1] configs: colibri-imx7: enable watchdog

2024-03-11 Thread Fabio Estevam
Hi Francesco, On Mon, Mar 11, 2024 at 8:34 AM Francesco Dolcini wrote: > No, on colibri-imx7 the reset is already working, it uses the PMIC so > it's not affected by the issue that was affecting most of our other > boards. > > The reason for enabling the watchdog here is just an improvement to

Re: [PATCH v1] configs: colibri-imx7: enable watchdog

2024-03-11 Thread Fabio Estevam
Hi Parth, On Thu, Mar 7, 2024 at 12:23 PM Parth Pancholi wrote: > > From: Parth Pancholi > > Enable watchdog functionality for Toradex's Colibri iMX7 (NAND/EMMC) > modules. You described what the patch does, but the reason is missing. Is the reason for this patch to fix the 'reset' command

Re: [PATCH 1/2] arm64: Reduce add_map() complexity

2024-03-09 Thread Fabio Estevam
On Sat, Mar 9, 2024 at 9:39 AM Marc Zyngier wrote: > Can you figure out what memory access is triggering it? Even at > narrowing it to the subsystem level would be a good indication. The problem happens so early that I am not able to narrow it down at subsystem level. > You could just dump the

Re: [PATCH 1/2] arm64: Reduce add_map() complexity

2024-03-09 Thread Fabio Estevam
the page tables and comparing them before and after would > help. Yes, I am sure the error is due to this change. It is 100% reproducible. I am not familiar with this part of the code, so I would appreciate it if you could tell me how to dump the page tables so I can compare them before and after. Thanks, Fabio Estevam

Re: [PATCH 1/2] arm64: Reduce add_map() complexity

2024-03-08 Thread Fabio Estevam
Hi Paul and Tom, On Tue, Feb 14, 2023 at 10:38 AM Ying-Chun Liu (PaulLiu) wrote: > > From: Marc Zyngier > > In the add_map() function, for each level it populates, it iterates from > the root of the PT tree, making it ineficient if a mapping needs to occur > past level 1. > > Instead, replace

[PATCH 2/2] clk: clk-imx8qm: Add LPUART IPG entries

2024-03-08 Thread Fabio Estevam
PG entries. Fixes: cc7df0b9e8bc ("serial: lpuart: Enable IPG clock") Reported-by: Marcel Ziswiler Signed-off-by: Fabio Estevam --- drivers/clk/imx/clk-imx8qm.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx8qm.c b/drivers/

[PATCH 1/2] clk: clk-imx8qxp: Add LPUART IPG entries

2024-03-08 Thread Fabio Estevam
LPUART IPG entries. Fixes: cc7df0b9e8bc ("serial: lpuart: Enable IPG clock") Reported-by: Marcel Ziswiler Signed-off-by: Fabio Estevam --- drivers/clk/imx/clk-imx8qxp.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx8qxp.c b

Re: U-boot fails for khadas-edge -v

2024-03-07 Thread Fabio Estevam
On Thu, Mar 7, 2024 at 2:43 PM Vivek Jaiswal wrote: > are you saying to use this one? > https://github.com/u-boot/u-boot/blob/master/configs/khadas-edge-v-rk3399_defconfig Yes, this one.

Re: [PATCH] configs: imx8mp_beacon: Fall back to using TF-A

2024-03-07 Thread Fabio Estevam
ich bypassed TF-A caused issues, so it needs to return > to the standard operating mode of using TF-A or the system no > longer boots. > > Fixes: ab53bd43dbde ("arm64: imx: Add support for imx8mp-beacon-kit") > Signed-off-by: Adam Ford Reviewed-by: Fabio Estevam I will queue it as a fix soon.

Re: [PATCH v3 0/2] board: phytec_imx8mp: Use 2GHz RAM timings for PCL-070 from pcb_rev 1

2024-03-07 Thread Fabio Estevam
Hi Benjamin, On Wed, Mar 6, 2024 at 1:18 PM Benjamin Hahn wrote: > > PCL-070 supports 2GHz RAM-timings from pcb_rev 1 and newer. PCM-070 > supports 2GHz RAM-timings only from pcb_rev 3 and newer. > > Signed-off-by: Benjamin Hahn v3 looks good. Is this material for U-Boot 2024.04 or 2024.07?

Re: U-boot fails for khadas-edge -v

2024-03-07 Thread Fabio Estevam
Hi Vivek, On Thu, Mar 7, 2024 at 11:56 AM Vivek Jaiswal wrote: > > Hello U-boot Team, > I am using the u-boot for Khadas Edge-v rk3399 rockchip: > https://github.com/khadas/u-boot/tree/khadas-edges-v2017.09-release-v1.0.0?tab=readme-ov-file > And I am using configuration file : >

Re: FEAT_CCIDX not tested when parsing ccsidr_el1

2024-03-07 Thread Fabio Estevam
Hi Łukasz, On Wed, Mar 6, 2024 at 3:21 PM Łukasz Więcaszek wrote: > I have already prepared a patch for our work related product and now I > am thinking of mainstreaming that piece of work. What do you think > about that? Please send a formal patch via git send-email.

Re: [PATCH v2 2/2] board: phycore_imx8mp: Use 2GHz RAM timings for PCL-070 from pcb_rev 1

2024-03-05 Thread Fabio Estevam
On Mon, Mar 4, 2024 at 1:04 PM Benjamin Hahn wrote: > - ret = phytec_get_rev(NULL); > - if (ret >= 3 && ret != PHYTEC_EEPROM_INVAL) { > + u8 rev = phytec_get_rev(NULL); > + u8 somtyp = phytec_get_som_type(NULL); Nitpick: Better to spell out 'somtype' or 'som_type' to

Re: [PATCH v2 1/2] board: phytec: common: phytec_som_detection: Add phytec_get_som_type

2024-03-05 Thread Fabio Estevam
On Mon, Mar 4, 2024 at 1:04 PM Benjamin Hahn wrote: > +enum phytec_som_type_str { > + PCM = 0, > + PCL, > + KSM, > + KSP, > +}; To avoid potential name clashes in the future, I suggest adding a prefix like: SOM_TYPE_PCM = 0, SOM_TYPE_PCL, ... > + > static const

Re: [PATCH] drivers: imx_tmu: Select polling-rate from cpu-thermal devicetree node

2024-03-05 Thread Fabio Estevam
fault of 5000ms if the polling rate should not be > specified in the devicetree. > > NOTE: The polling rate from the devicetree will be used after this > patch. In imx8*.dtsi devicetrees the polling delay is set to 2000ms for > example. > > Signed-off-by: Benjamin Hahn Reviewed-by: Fabio Estevam

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-04 Thread Fabio Estevam
On Tue, Feb 27, 2024 at 12:40 PM Sébastien Szymanski wrote: > > Commit 5d7a95f4 ("imx6ul/imx6ull: synchronise device trees with > linux") removed the display timings from the board device tree whereas > they are still needed by the mxsfb driver. > Add the timings back (the correct ones) in

Re: [PATCH] imx9: Update to mx93 A1 chip revision.

2024-03-04 Thread Fabio Estevam
On Mon, Feb 26, 2024 at 2:48 PM Mathieu Othacehe wrote: > > Use the latest, mx93a1-ahab-container.img that is compatible with the > i.MX93 A1 revision. > > Using mx93a1-ahab-container.img on an A0 chip and conversely causes a boot > failure without any traces on the UART. > > Signed-off-by:

Re: [PATCH 0/2] Fix OP-TEE support

2024-03-04 Thread Fabio Estevam
On Mon, Feb 26, 2024 at 2:37 PM Mathieu Othacehe wrote: > > Hello, > > This series fixes OP-TEE support on all imx9 boards by starting the ELE RNG > and adding the optional tee.bin binary to the ATF container. > > Thanks, > > Mathieu > > Mathieu Othacehe (2): > imx9: Fix OP-TEE support >

[GIT PULL] Please pull u-boot-imx-master-20240304

2024-03-04 Thread Fabio Estevam
Hi Tom, Please pull from u-boot-imx, thanks. The following changes since commit eac52e4be4e234d563d6911737ee7ccdc0ada1f1: Merge patch series "ARM: renesas: Rename R-Mobile to Renesas" (2024-03-02 14:30:25 -0500) are available in the Git repository at:

Re: [PATCH 1/2] board: phytec: common: phytec_som_detection: Add phytec_get_som_type

2024-03-04 Thread Fabio Estevam
On Mon, Mar 4, 2024 at 9:31 AM Benjamin Hahn wrote: > > Add a function that gets the som_type from the EEPROM. > Add an enum for the som_type. > > Signed-off-by: Benjamin Hahn Your series does not even build: board/phytec/common/phytec_som_detection.c: In function ‘phytec_get_som_type’:

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-04 Thread Fabio Estevam
On Mon, Mar 4, 2024 at 10:35 AM Tom Rini wrote: > For v2024.04 yes, this is fine. For long term, we should parse the new > timing properties that the simple panel driver takes in our simple panel > driver instead. Sounds good. Sébastien, please follow Tom's suggestion when you have a chance.

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-04 Thread Fabio Estevam
Hi Tom, On Tue, Feb 27, 2024 at 12:42 PM Tom Rini wrote: > What's the long term fix here? Why aren't these needed in Linux anymore, > and perhaps why was it OK to remove them? This is perhaps another case > where we as the U-Boot community need to go and talk with some Linux > Kernel community

Re: [PATCH v6 00/11] An effort to bring DT bindings compliance within U-Boot

2024-03-04 Thread Fabio Estevam
On Mon, Mar 4, 2024 at 9:15 AM Sumit Garg wrote: > I suppose the earlier reference patch wasn't complete, can you rather > try its v4 [1] instead? > > [1] > https://patchwork.ozlabs.org/project/uboot/patch/20240304121257.3551104-1-sumit.g...@linaro.org/ This one works, thanks!

Re: [PATCH v4] Makefile: remove hardcoded device tree source directory

2024-03-04 Thread Fabio Estevam
Include the correct path to the board's dtbs depending on if OF_UPSTREAM > is selected or not. > > Signed-off-by: Bryan Brattlof > Signed-off-by: Sumit Garg Tested-by: Fabio Estevam

Re: [PATCH v6 00/11] An effort to bring DT bindings compliance within U-Boot

2024-03-04 Thread Fabio Estevam
Hi Sumit, On Mon, Mar 4, 2024 at 3:33 AM Sumit Garg wrote: > I think you also need Bryan's patch [1] to be incorporated as well. > Give it a try and let me know if you still see any further issues. > > [1] >

Re: [PATCH v6 00/11] An effort to bring DT bindings compliance within U-Boot

2024-03-01 Thread Fabio Estevam
Hi Sumit, On Fri, Mar 1, 2024 at 9:57 AM Tom Rini wrote: > > On Thu, 22 Feb 2024 15:05:56 +0530, Sumit Garg wrote: > > > Changes in v6: > > -- > > - v6_dt: https://github.com/b49020/u-boot/tree/v6_dt > > - Patch #3: Incorporate fix for sandbox CI failure. > > - Patch #6: Incorporate

[GIT PULL] Please pull u-boot-imx-master-20240224

2024-02-24 Thread Fabio Estevam
CONFIG_IMX_TMU Fabio Estevam (1): imx53-qsb: Convert to watchdog driver model Frieder Schrempf (1): board: imx6dl-sielaff: spl.c: Remove multiline string Jesse Taube (2): imx: imxrt1050-evk: Add support for SPI flash booting imx: imxrt1050-evk: Add documentation for SPI boot

Re: [PATCH 1/1] opos6uldev: Convert to watchdog driver model

2024-02-24 Thread Fabio Estevam
On Fri, Feb 23, 2024 at 8:28 AM Sébastien Szymanski wrote: > > Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused > the 'reset' command in U-Boot to not cause a board reset. > > Fix it by switching to the watchdog driver model via sysreset, which > is the preferred method for

Re: [PATCH] imx53-qsb: Convert to watchdog driver model

2024-02-24 Thread Fabio Estevam
On Wed, Feb 21, 2024 at 2:39 PM Fabio Estevam wrote: > > Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused > the 'reset' command in U-Boot to not cause a board reset. > > Fix it by switching to the watchdog driver model via sysreset, which

Re: [PATCH 0/3] Enable IMX_TMU driver for PHYTEC boards

2024-02-24 Thread Fabio Estevam
On Tue, Feb 20, 2024 at 7:43 AM Benjamin Hahn wrote: > > Enable IMX_TMU driver to prevent the system from booting when it is too > hot. > > Signed-off-by: Benjamin Hahn > --- > Benjamin Hahn (3): > phycore-imx8mp_defconfig: Enable CONFIG_IMX_TMU > phycore-imx8mm_defconfig: Enable

Re: [PATCH 0/5] imx93_var_som: Add USB support.

2024-02-24 Thread Fabio Estevam
On Tue, Feb 20, 2024 at 7:35 AM Mathieu Othacehe wrote: > > Hello, > > This series adds USB support for the imx93_var_som board. It depends on: > https://lists.denx.de/pipermail/u-boot/2024-February/546203.html > > It also adds support for fastboot and EFI partitions. > > Thanks, > > Mathieu > >

Re: [PATCH] board: imx6dl-sielaff: spl.c: Remove multiline string

2024-02-24 Thread Fabio Estevam
On Tue, Feb 20, 2024 at 6:01 AM Frieder Schrempf wrote: > > From: Frieder Schrempf > > Remove the malformed multiline string and fix the checkpatch warning. > > Reported-by: Dan Carpenter > Signed-off-by: Frieder Schrempf Applied, thanks.

Re: [PATCH v4 1/2] imx: imxrt1050-evk: Add support for SPI flash booting

2024-02-24 Thread Fabio Estevam
On Tue, Feb 20, 2024 at 2:20 PM Fabio Estevam wrote: > Please fix both issues and submit a v5. I have fixed these issues myself and applied it, thanks.

Re: [PATCH v2 0/7] toradex: fix reset and hardware detection regressions

2024-02-23 Thread Fabio Estevam
: Francesco Dolcini > Closes: https://lore.kernel.org/all/ZY2ZDWAQuTlRjV9H@francesco-nb/ For the series: Reviewed-by: Fabio Estevam

Re: [PATCH 1/1] opos6uldev: Convert to watchdog driver model

2024-02-23 Thread Fabio Estevam
> is the preferred method for implementing the watchdog reset. > > Signed-off-by: Sébastien Szymanski Reviewed-by: Fabio Estevam

Re: [PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Fabio Estevam
On Thu, Feb 22, 2024 at 1:53 PM Sean Anderson wrote: > > From: Sean Anderson ... > Signed-off-by: Sean Anderson > --- > I'm resending this from my linux.dev email as my regular email is > mangling my patches. That's OK, but you need to make sure that the From and Signed-off-by fields match.

[PATCH] imx53-qsb: Convert to watchdog driver model

2024-02-21 Thread Fabio Estevam
Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset. Signed-off-by: Fab

Re: ECDSA related PRs

2024-02-21 Thread Fabio Estevam
Hi Bob, On Wed, Feb 21, 2024 at 8:30 AM Bob Wolff wrote: > > Hi there, > I have two separate but related pull requests I'd like to contribute. They > both have to do with ECDSA support. > - The simple one is a lack of null-pointer check that can cause a crash in > certain situations. Easy peasy.

Re: [PATCH v4 1/2] imx: imxrt1050-evk: Add support for SPI flash booting

2024-02-20 Thread Fabio Estevam
On Mon, Feb 19, 2024 at 11:50 PM Jesse T wrote: > Huh, this is very interesting and I haven't noticed before. > When sending git send-email lowercases my email. > It seems like all my commits are like this. > Do you want this fixed? Please fix both issues and submit a v5.

Re: [PATCH 7/7] verdin-imx8mp_defconfig: Enable PCIe/NVMe support

2024-02-20 Thread Fabio Estevam
On Tue, Feb 20, 2024 at 10:51 AM Sumit Garg wrote: > > Also, enable reset driver which is a prerequisite for PCIe support. > > Signed-off-by: Sumit Garg > --- > configs/verdin-imx8mp_defconfig | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/configs/verdin-imx8mp_defconfig

Re: [PATCH v4 1/2] imx: imxrt1050-evk: Add support for SPI flash booting

2024-02-19 Thread Fabio Estevam
On Mon, Feb 19, 2024 at 8:01 PM Jesse Taube wrote: > > Add support for booting the imxrt1050-evk from spi. > Add imximage config and the ability for SPL to boot from NOR. > Enable binman in Kconfig and device tree for imxrt* as it is used to > prepend fspi_header.bin to SPL and u-boot.img. > >

Re: [PATCH v3 1/3] arm: dts: imxrt: Add binman support

2024-02-19 Thread Fabio Estevam
On Mon, Feb 19, 2024 at 5:18 PM Jesse T wrote: > Shall I send a V4 with them squashed then? Yes, please send a v4 with them squashed and with a nice commit log :-)

Re: [PATCH v2] usb: ehci-mx6: Add i.MX93 support

2024-02-19 Thread Fabio Estevam
On Mon, Feb 19, 2024 at 2:05 PM Mathieu Othacehe wrote: > > i.MX93 uses the same USB IP as i.MX8MM. It can then reuse the ehci-mx6 > driver. > > Reviewed-by: Marek Vasut > Signed-off-by: Mathieu Othacehe Reviewed-by: Fabio Estevam I assume you will add USB support to some i.MX93 boards later.

Re: [PATCH] usb: ehci-mx6: Add i.MX93 support

2024-02-19 Thread Fabio Estevam
Hi Mathieu, On Mon, Feb 19, 2024 at 5:43 AM Mathieu Othacehe wrote: > > i.MX93 uses the same USB IP as i.MX8MM. It can then reuse the ehci-mx6 > driver. > > Signed-off-by: Mathieu Othacehe You missed copying Marek Vasut, who is the USB maintainer. > --- > drivers/usb/host/Kconfig| 6

Re: EXT: [PATCH 1/5] msc_sm2s_imx8mp: Convert to DM_SERIAL

2024-02-19 Thread Fabio Estevam
On Thu, Feb 15, 2024 at 9:05 AM Ian Ray wrote: > > On Tue, Feb 13, 2024 at 08:43:38AM -0300, Fabio Estevam wrote: > > > > From: Fabio Estevam > > > > The conversion to DM_SERIAL is mandatory, so do the conversion. > > > > Signed-off-by: Fabio Estev

Re: [PATCH v4 1/3] mtd: spi-nor-ids: Add support for ESMT/EON EN25Q80B

2024-02-19 Thread Fabio Estevam
On Thu, Feb 15, 2024 at 11:00 AM Frieder Schrempf wrote: > > From: Frieder Schrempf > > The datasheet can be found here: > https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/EN25Q80B_Ver.E.pdf > > Signed-off-by: Frieder Schrempf > Reviewed-by: Fabio Estevam Applied all, thanks.

Re: [PATCH] MAINTAINERS: Update after GEHC spin-off

2024-02-19 Thread Fabio Estevam
On Tue, Feb 13, 2024 at 11:08 AM Ian Ray wrote: > > Update our email addresses, from @ge.com to @gehealthcare.com, after GE > HealthCare was spun-off from GE. > > Remove Antti, who no longer works on the project. > > Signed-off-by: Ian Ray Applied, thanks.

[GIT PULL] Please pull u-boot-imx-master-20240219

2024-02-19 Thread Fabio Estevam
addresses. Fabio Estevam (5): msc_sm2s_imx8mp: Convert to DM_SERIAL msc_sm2s_imx8mp: Make Ethernet functional imx8mp-msc-sm2s: Add mmc aliases msc_sm2s_imx8mp: Add redundant environment support

Re: [PATCH v3 1/3] arm: dts: imxrt: Add binman support

2024-02-18 Thread Fabio Estevam
On Sun, Feb 18, 2024 at 10:39 PM Fabio Estevam wrote: > > Hi Jesse, > > On Sun, Feb 18, 2024 at 6:20 PM Jesse Taube wrote: > > > > Enable binman in Kconfig and in device tree. > > Please explain the rationale for doing this. Also, it seems that this patch alo

Re: [PATCH v3 1/3] arm: dts: imxrt: Add binman support

2024-02-18 Thread Fabio Estevam
Hi Jesse, On Sun, Feb 18, 2024 at 6:20 PM Jesse Taube wrote: > > Enable binman in Kconfig and in device tree. Please explain the rationale for doing this.

Re: [PATCH v2 2/3] board: Add support for Sielaff i.MX6 Solo board

2024-02-15 Thread Fabio Estevam
Hi Frieder, On Tue, Feb 13, 2024 at 2:22 PM Frieder Schrempf wrote: > > From: Frieder Schrempf > > The Sielaff i.MX6 Solo board is a control and HMI board for vending > machines. Add support for this board. > > The devicetree files are taken from pending changes in the Linux > kernel that are

Re: [PATCH v2 3/3] doc: board: Add minimal documentation for Sielaff i.MX6 Solo board

2024-02-14 Thread Fabio Estevam
On Tue, Feb 13, 2024 at 2:33 PM Frieder Schrempf wrote: > > From: Frieder Schrempf > > Describe how to build and boot for the Sielaff i.MX6 Solo board. > > Signed-off-by: Frieder Schrempf Reviewed-by: Fabio Estevam

Re: [PATCH v2 2/3] board: Add support for Sielaff i.MX6 Solo board

2024-02-14 Thread Fabio Estevam
that are available from linux-next and will likely be > part of Linux v6.9. > > Signed-off-by: Frieder Schrempf Reviewed-by: Fabio Estevam

Re: [PATCH 2/3] board: Add support for Sielaff i.MX6 Solo board

2024-02-13 Thread Fabio Estevam
Hi Frieder, On Tue, Feb 13, 2024 at 1:58 PM Frieder Schrempf wrote: > I understand the reasoning and I can change that if you insist. But I'm > not really happy about it as we already use the flash.bin as common name > for the binary across all platforms downstream. Also in our upstream >

[PATCH 5/5] msc_sm2s_imx8mp: Fix CONFIG_DEFAULT_FDT_FILE

2024-02-13 Thread Fabio Estevam
From: Fabio Estevam There is no imx8mp-msc-sm2s.dtb file in upstream Linux. Change it to imx8mp-msc-sm2s-ep1.dtb. Signed-off-by: Fabio Estevam --- configs/msc_sm2s_imx8mp_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/msc_sm2s_imx8mp_defconfig b

[PATCH 4/5] msc_sm2s_imx8mp: Add redundant environment support

2024-02-13 Thread Fabio Estevam
From: Fabio Estevam Redundant environment support is required for software updates. Add support for it. Signed-off-by: Fabio Estevam --- configs/msc_sm2s_imx8mp_defconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configs/msc_sm2s_imx8mp_defconfig b/configs

<    1   2   3   4   5   6   7   8   9   10   >