Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash()

2022-06-08 Thread Fabio Estevam
t least for the i.MX8MM case, is that mainline TF-A does not support HAB, so the NXP TF-A should be used if HAB support is required. Please check: https://lists.trustedfirmware.org/archives/list/t...@lists.trustedfirmware.org/message/5UYYI4CNLQ5OWWHU466JBK6I5QIQ2VRS/ Does the board boot with IMX_HAB=y with NXP TF-A? Regards, Fabio Estevam

Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash()

2022-06-07 Thread Fabio Estevam
On Tue, Jun 7, 2022 at 2:27 PM Fabio Estevam wrote: > > Hi Heiko, > > On Tue, Jun 7, 2022 at 4:48 AM Heiko Thiery wrote: > > >> Thomas Schäfer sees this behavior also on an imx8mn NXP evk board. > >> Thus I added him to this thread. > > Thanks for t

Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash()

2022-06-07 Thread Fabio Estevam
Hi Heiko, On Tue, Jun 7, 2022 at 4:48 AM Heiko Thiery wrote: >> Thomas Schäfer sees this behavior also on an imx8mn NXP evk board. >> Thus I added him to this thread. Thanks for the feedback. I managed to reproduce the problem on an imx8mm-evk board. On top of tree U-Boot I added: ---

Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash()

2022-06-06 Thread Fabio Estevam
a4 If CONFIG_IMX_HAB=y is not selected, then sha256 is calculated by software and the fitImage boots. Does anyone have any suggestions? Thanks, Fabio Estevam

Re: [PATCH 3/5] configs: Add config for enabling FSPI boot option for i.MX8m

2022-06-04 Thread Fabio Estevam
On Fri, Jun 3, 2022 at 8:39 AM Mamta Shukla wrote: > > Add imx8mm_evk_fspi_defconfig to build QSPI boot image. > This config is based on imx8mm_evk_defconfig with addtional config options for > FSPI Header,SPL offset and imx-image config to boot from FSPI. > > > Signed-off-by: Mamta Shukla >

Re: [PATCH 0/5] Add support for FLexSPI Boot for i.MX8m

2022-06-03 Thread Fabio Estevam
some minor comments. The series looks good: Reviewed-by: Fabio Estevam

Re: [PATCH 3/5] configs: Add config for enabling FSPI boot option for i.MX8m

2022-06-03 Thread Fabio Estevam
Hi Mamta, On Fri, Jun 3, 2022 at 8:39 AM Mamta Shukla wrote: > > Add imx8mm_evk_fspi_defconfig to build QSPI boot image. > This config is based on imx8mm_evk_defconfig with addtional config options for > FSPI Header,SPL offset and imx-image config to boot from FSPI. > > Unneeded blank line.

Re: [PATCH 1/5] tools: mkimage: Add support to generate FlexSPI Header for i.MX8m

2022-06-03 Thread Fabio Estevam
Hi Mamta, On Fri, Jun 3, 2022 at 8:39 AM Mamta Shukla wrote: > void build_image(int ofd) > { > - int file_off, header_hdmi_off = 0, header_image_off; > - int hdmi_fd, ap_fd, sld_fd; > + int file_off, header_hdmi_off = 0, header_image_off, fspi_off; > + int hdmi_fd,

Re: [PATCH 2/2] clk: imx8mp: use usb_core_ref for usb_root_clk

2022-06-03 Thread Fabio Estevam
ing boot log message: "clk_register: failed to get osc_32k device (parent of usb_root_clk)" Fix the USB controller clock source by using usb_core_ref instead of osc_32k. Fixes: 7a2c3be95a50 ("clk: imx8mp: Fill in DWC3 USB, USB PHY, HSIOMIX clock") Signed-off-by: Andrey Zhizhi

Re: [PATCH 1/2] clk: imx8mp: fix root clock names for ecspi

2022-06-03 Thread Fabio Estevam
On 03/06/2022 12:15, Andrey Zhizhikin wrote: Root clock name contained underscore, which does not match to the actual clock name. Correct the name to match what is present in the FDT. Fixes: 87f958810fcb ("clk: imx8mp: Add ECSPI clocks") Signed-off-by: Andrey Zhizhikin Cc: Fabio E

Re: Serial Download Boot on i.MX8MN EVK Board

2022-05-30 Thread Fabio Estevam
sed by TF-A. Regards, Fabio Estevam

Re: Serial Download Boot on i.MX8MN EVK Board

2022-05-30 Thread Fabio Estevam
to boot in > serial download mode? Yes, I confirm these variants boot fine via "uuu flash.bin". Regards, Fabio Estevam

Re: [PATCH v3] net: Check for the minimum IP header total length

2022-05-26 Thread Fabio Estevam
Hi Michael, On Thu, May 26, 2022 at 2:24 PM Michael Nazzareno Trimarchi wrote: >> +#define IP_MIN_TOTAL_LENGTH(IP_HDR_SIZE + 1) >> + > Not needed Thanks for reviewing it. Please ignore v3. It is v2 that has the correct logic.

Re: [PATCH v2] net: Check for the minimum IP fragmented datagram size

2022-05-26 Thread Fabio Estevam
On Thu, May 26, 2022 at 1:10 PM Fabio Estevam wrote: > > On 26/05/2022 11:14, Fabio Estevam wrote: > > > Add a check for ip_len lesser than 28 and stop processing the packet > > in this case. > > > > Such a check covers the two reported bugs. > > Ops

[PATCH v3] net: Check for the minimum IP header total length

2022-05-26 Thread Fabio Estevam
From: Fabio Estevam Nicolas Bidron and Nicolas Guigo reported the two bugs below: " --BUG 1-- In compiled versions of U-Boot that define CONFIG_IP_DEFRAG, a value of `ip->ip_len` (IP packet header's Total Length) higher than `IP_HDR_SIZE` and strictly lower than `IP_HD

Re: [PATCH v2] net: Check for the minimum IP fragmented datagram size

2022-05-26 Thread Fabio Estevam
On 26/05/2022 11:14, Fabio Estevam wrote: Add a check for ip_len lesser than 28 and stop processing the packet in this case. Such a check covers the two reported bugs. Ops, it is (ip->ip_len < 21) the condition that satisfies both cases. I will send a v3.

[PATCH v2] net: Check for the minimum IP fragmented datagram size

2022-05-26 Thread Fabio Estevam
From: Fabio Estevam Nicolas Bidron and Nicolas Guigo reported the two bugs below: " --BUG 1-- In compiled versions of U-Boot that define CONFIG_IP_DEFRAG, a value of `ip->ip_len` (IP packet header's Total Length) higher than `IP_HDR_SIZE` and strictly lower than `IP_HD

[PATCH] net: Check for the minimum IP fragmented datagram size

2022-05-26 Thread Fabio Estevam
From: Fabio Estevam Nicolas Bidron and Nicolas Guigo reported the two bugs below: " --BUG 1-- In compiled versions of U-Boot that define CONFIG_IP_DEFRAG, a value of `ip->ip_len` (IP packet header's Total Length) higher than `IP_HDR_SIZE` and strictly lower than `IP_HD

Re: Vulnerability Disclosure in net/

2022-05-26 Thread Fabio Estevam
Hi Ramon, On Wed, May 25, 2022 at 11:46 PM Ramon Fried wrote: > Hi Nicolas, > Thanks for the research. > I have read your description thoroughly, very interesting. > I will implement fixes to the findings. Is it enough to add the check below? --- a/net/net.c +++ b/net/net.c @@ -906,6 +906,9

Re: [PATCH] board: gateowrks: venice: add GW7903 PMIC

2022-05-20 Thread Fabio Estevam
Hi Tim, On Fri, May 20, 2022 at 12:55 PM Tim Harvey wrote: > > The GW7903 has a BD71847 PMIC on I2C1. Adjust the model compare strings > to add it. > > Signed-off-by: Tim Harvey There is a typo in the Subject: s/gateowrks/gateworks Reviewed-by: Fabio Estevam

Re: [PATCH v2 0/8] ARM: imx: Add support for iMX6QDL DHCOM DRC02 and DH picoITX

2022-05-20 Thread Fabio Estevam
file For the series: Reviewed-by: Fabio Estevam

Re: [PATCH 8/8] ARM: imx6: Adapt device tree selection in DH board file

2022-05-19 Thread Fabio Estevam
On 19/05/2022 08:08, Philip Oberfichtner wrote: return 0; - } + /* Determine carrier board at compile time and SoM at runtime */ + const size_t size = 32; + char *car, *som, dt[size]; + + car = strchr(CONFIG_DEFAULT_DEVICE_TREE, '-'); /* i.e. -dhcom-drc02

[PATCH] usb: ehci-mx6: Remove MX6Q_ARM2 related ifdefery

2022-05-19 Thread Fabio Estevam
From: Fabio Estevam The imx6q arm2 board support has been removed from U-Boot as it did not get converted to DM. Remove the MX6Q_ARM2 related ifdefery in the driver. Signed-off-by: Fabio Estevam --- drivers/usb/host/ehci-mx6.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers

[PATCH 2/3] cgtqmx8: Enable cache in SPL

2022-05-19 Thread Fabio Estevam
From: Fabio Estevam There is no reason for disabling I-cache and D-cache in SPL. Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and CONFIG_SPL_SYS_DCACHE_OFF options. Signed-off-by: Fabio Estevam --- configs/cgtqmx8_defconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/configs

[PATCH 3/3] imx8mp_rsb3720a1: Enable cache in SPL

2022-05-19 Thread Fabio Estevam
From: Fabio Estevam There is no reason for disabling I-cache and D-cache in SPL. Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and CONFIG_SPL_SYS_DCACHE_OFF options. Signed-off-by: Fabio Estevam --- configs/imx8mp_rsb3720a1_4G_defconfig | 2 -- configs/imx8mp_rsb3720a1_6G_defconfig | 2

[PATCH 1/3] imx8mm-cl-iot-gate: Enable cache in SPL

2022-05-19 Thread Fabio Estevam
From: Fabio Estevam There is no reason for disabling I-cache and D-cache in SPL. Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and CONFIG_SPL_SYS_DCACHE_OFF options. Signed-off-by: Fabio Estevam --- configs/imx8mm-cl-iot-gate-optee_defconfig | 2 -- configs/imx8mm-cl-iot-gate_defconfig

Re: i.MX8MP usb status

2022-05-18 Thread Fabio Estevam
Hi Tim, On Wed, May 18, 2022 at 1:26 PM Tim Harvey wrote: > This keeps coming up and many of us are just carrying this patch > series in downstream repos which is horrible. > > The problem patch in this series [1] is 'imx8mm: Fix USB reg addresses > for i.MX8MM' [2] as we all want to get

[PATCH] imx8mn_evk: Add Ethernet support to the LPDDR4 variant

2022-05-17 Thread Fabio Estevam
From: Fabio Estevam The imx8mn-ddr4-evk board has Ethernet support already, but the lpddr4 board does not. Add Ethernet support for the LPDDR4 variant too. Signed-off-by: Fabio Estevam --- configs/imx8mn_evk_defconfig | 8 1 file changed, 8 insertions(+) diff --git a/configs

Re: i.MX8MP usb status

2022-05-16 Thread Fabio Estevam
Someone needs to rework this series and resubmit it. Regards, Fabio Estevam -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email: feste...@denx.de

Re: [PATCH V4 0/5] MXS nand fixes in SPL

2022-05-15 Thread Fabio Estevam
d: raw: mxs_nand: Fix specific hook registration > mtd: nand: mxs_nand_spl: Fix bad block skipping > arm: mach-imx: cmd_nandbcb fix bad block handling > spl: spl_nand: Fix bad block handling in fitImage > board: bsh: Switch to nand spl load instead of romapi For the series: Reviewed-by: Fabio Estevam

Re: imx6ull: NAND boot fails when block 0x00000000 is bad

2022-05-13 Thread Fabio Estevam
[Adding some more folks] On Fri, May 13, 2022 at 2:41 PM Thierry Bultel wrote: > > Hi, > > I have a imx6ull module from Toradex, with NAND flash. U-boot does not > have SPL. > I does not boot from NAND flash anymore, I was able to flash it several > times with tezi, as well as with > nandbcb

[PATCH] kontron-sl-mx8mm: Select the CONFIG_CMD_UNZIP option

2022-05-10 Thread Fabio Estevam
From: Fabio Estevam Select the CMD_UNZIP option so that the 'gzwrite' command can be used to flash wic.gz image into the eMMC. Signed-off-by: Fabio Estevam --- configs/kontron-sl-mx8mm_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/kontron-sl

[PATCH] imx8mn_evk: Add the missing spl.bin entry

2022-05-03 Thread Fabio Estevam
From: Fabio Estevam The generated flash.bin does not boot the imx8mn evk LPDDR4 variant as it misses the spl.bin description in binman. Add its entry to fix the boot on the imx8mn evk LPDDR4 variant. Signed-off-by: Fabio Estevam --- arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++- 1 file

Re: [PATCH 00/15] imx8m: convert to DM_SERIAL

2022-04-30 Thread Fabio Estevam
imx8mn_bsh_smm_s2: drop CONFIG_MXC_UART_BASE > imx: dts: move common changes to imx8mq-u-boot.dtsi > imx: imx8mq-cm: enable CONFIG_DM_SERIAL > imx: imx8mq-pico: enable CONFIG_DM_SERIAL > imx: imx8mq-phandle: enable CONFIG_DM_SERIAL In the Subject: s/phandle/phanbell Reviewed-by: Fabio Estevam

Re: U-Boot and ethernet regression on mx6cuboxi

2022-04-29 Thread Fabio Estevam
Hi Tom, On Fri, Apr 29, 2022 at 9:44 AM Tom Rini wrote: > Thanks for the hint, Tim! Fabio, the dts needs to be re-synced with > Linux as upstream it says: > /* > * The PHY seems to require a long-enough reset duration to avoid > * some rare issues where the PHY gets

Re: [PATCH] imx: drop CONFIG_MXC_UART_BASE

2022-04-29 Thread Fabio Estevam
Hi Peng, On Fri, Apr 29, 2022 at 9:28 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Since these boards has CONFIG_DM_SERIAL and/or CONFIG_SPL_DM_SERIAL, > the legacy macro no need to be defined. > > Signed-off-by: Peng Fan Thanks for the cleanup: Reviewed-by: Fabio Estevam

Re: [PATCH] ls10xxx: Use a sane SPL_SYS_MALLOC_F_LEN default

2022-04-28 Thread Fabio Estevam
for this family was to set it to 0x6000 for some ls2 (ls3?) SoCs (e.g. ls1088). My original patch only touched imx8m, but Tom suggested I also bump Layerscape too. Please send a v2 with my suggestion and feel free to add a: Reviewed-by: Fabio Estevam 989-80 Email: feste...@denx.de

Re: [PATCH] ls10xxx: Use a sane SPL_SYS_MALLOC_F_LEN default

2022-04-28 Thread Fabio Estevam
Hi Sean, On Thu, Apr 28, 2022 at 1:02 PM Sean Anderson wrote: > > SPL_SYS_MALLOC_F_LEN defaults to SYS_MALLOC_F_LEN. 0x1 (the new > default) is 64 KiB, or around half of the total OCRAM size. Revert to > the previous default of 0x2000. This fixes SPL boot. > > Fixes: 545eceb520

Re: [PATCH] imx8m: fix reading of DDR4 MR registers

2022-04-27 Thread Fabio Estevam
Hi Paul, On 27/04/2022 03:48, Paul Liu wrote: Hi Fabio, I tested. It works. Tested-by: Ying-Chun Liu (PaulLiu) Thanks for testing. Reviewed-by: Fabio Estevam

Re: [PATCH v1] ARM: dts: imx: Fix iMX6QDL DHCOM PDK2 DTC Warnings

2022-04-26 Thread Fabio Estevam
Hi Marek, On Tue, Apr 26, 2022 at 8:55 PM Marek Vasut wrote: > Ouch ... so what did Linux do about that breakage ? Linux treats the third pwm cell as optional. Please see:

Re: [PATCH] imx8*_venice_defconfig: configure default MMC env device

2022-04-26 Thread Fabio Estevam
devno=2) as all Gateworks Venice > boards use SDHC3 as eMMC so that persistant env works when botting from > USB/SDP. > > Signed-off-by: Tim Harvey Reviewed-by: Fabio Estevam

Re: [PATCH] imx8m: fix reading of DDR4 MR registers

2022-04-26 Thread Fabio Estevam
Hi Paul, On Mon, Apr 25, 2022 at 11:23 AM Rasmus Villemoes wrote: > > I was trying to employ lpddr4_mr_read() to something similar to what > the imx8mm-cl-iot-gate board is doing for auto-detecting the RAM > type. However, the version in drivers/ddr/imx/imx8m/ddrphy_utils.c > differs from the

Re: [PATCH 2/2] mtd: nand: mxs_nand_spl: Fix bad block skipping

2022-04-26 Thread Fabio Estevam
Adding Han Xu. On Mon, Apr 25, 2022 at 8:45 AM Michael Nazzareno Trimarchi wrote: > > Hi > > +cc Stefano Babic > > We have right now a while (1) if we find a badblock > > On Sat, Apr 23, 2022 at 10:12 AM Michael Trimarchi > wrote: > > > > The file was fill of problems and bugs. The bad block

Re: [PATCH v3 2/2] imx8mn/8mp: Allow booting via USB

2022-04-25 Thread Fabio Estevam
Hi Tim, On Mon, Apr 25, 2022 at 8:15 PM Tim Harvey wrote: > Tested-By: Tim Harvey Thanks. > agreed it would be a separate issue... just curious if you knew where > that was coming from. It certainly isn't a common behavior to boot via > USB then expect 'saveenv' to save to a specific eMMC

Re: [PATCH v3 2/2] imx8mn/8mp: Allow booting via USB

2022-04-25 Thread Fabio Estevam
Hi Tim, On 25/04/2022 16:41, Tim Harvey wrote: Fabio, Thanks - this at least allows me to boot on imx8mp-venice-gw74xx without needing to enable CONFIG_ENV_IS_NOWHERE. Care to reply with your Tested-by? I do however notice when I do so env is attempted to load from MMC dev 0

Re: [PATCH] ARM: dts: imx: Use 100 kHz I2C2 on Data Modul i.MX8M Mini eDM SBC

2022-04-25 Thread Fabio Estevam
On 25/04/2022 19:16, Marek Vasut wrote: The I2C2 has SMBus device SMSC USB2514Bi connected to it, the device is capable of up to 100 kHz operation. Reduce the bus frequency to 100 kHz to guarantee this I2C device can work correctly. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan

Re: [PATCH 1/4] ARM: imx: imx8m: Introduce and use UART_BASE_ADDR(n)

2022-04-25 Thread Fabio Estevam
of CONFIG namespace since it's not configurable, it's part of the SoC) and perhaps the path for imx8* is to drop the references since it's all DM? Correct. In the defconfigs where CONFIG_DM_SERIAL=y and CONFIG_SPL_DM=y are selected the CONFIG_MXC_UART_BASE can be safely dropped. Regards, Fabio

Re: [PATCH 1/4] ARM: imx: imx8m: Introduce and use UART_BASE_ADDR(n)

2022-04-25 Thread Fabio Estevam
change. As DM_SERIAL is mandatory now, we should get rid of CONFIG_MXC_UART_BASE. I would prefer a patch that removes CONFIG_MXC_UART_BASE instead. Regards, Fabio Estevam

[PATCH 1/2] mx6slevk: Remove duplicated "mmc dev" command

2022-04-22 Thread Fabio Estevam
From: Fabio Estevam The "mmc dev ${mmcdev}" command is done twice. Remove one ocurrence to avoid the duplication. Signed-off-by: Fabio Estevam --- configs/mx6slevk_defconfig| 2 +- configs/mx6slevk_spinor_defconfig | 2 +- configs/mx6slevk_spl_defconfig| 2 +- 3 files

[PATCH 2/2] mx6sllevk: Remove duplicated "mmc dev" command

2022-04-22 Thread Fabio Estevam
From: Fabio Estevam The "mmc dev ${mmcdev}" command is done twice. Remove one ocurrence to avoid the duplication. Signed-off-by: Fabio Estevam --- configs/mx6sllevk_defconfig| 2 +- configs/mx6sllevk_plugin_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletion

[PATCH v3 2/2] imx8mn/8mp: Allow booting via USB

2022-04-21 Thread Fabio Estevam
From: Fabio Estevam When trying to boot via USB on i.MX8MN it is necessary to specify the U-Boot environment location, otherwise the boot process simply hangs. Specify the environment location when booting from USB. Tested on a imx8mn-evk. Suggested-by: Michael Nazzareno Trimarchi Signed-off

[PATCH v3 1/2] imx8mn_ddr4_evk: Add USB Mass Storage support

2022-04-21 Thread Fabio Estevam
From: Fabio Estevam Add USB Mass Storage support, which is a convenient way to flash the eMMC card, for example. Signed-off-by: Fabio Estevam --- Changes since v2: - None configs/imx8mn_ddr4_evk_defconfig | 12 1 file changed, 12 insertions(+) diff --git a/configs

[PATCH v2 2/2] imx8mn/8mp: Allow booting via USB

2022-04-21 Thread Fabio Estevam
From: Fabio Estevam When trying to boot via USB on i.MX8MN it is necessary to specify the U-Boot environment location, otherwise the boot process simply hangs. Specify the environment location when booting from USB. Tested on a imx8mn-evk. Suggested-by: Michael Nazzareno Trimarchi Signed-off

[PATCH v2 1/2] imx8mn_ddr4_evk: Add USB Mass Storage support

2022-04-21 Thread Fabio Estevam
From: Fabio Estevam Add USB Mass Storage support, which is a convenient way to flash the eMMC card, for example. Signed-off-by: Fabio Estevam --- Changes since v1: - None configs/imx8mn_ddr4_evk_defconfig | 12 1 file changed, 12 insertions(+) diff --git a/configs

Re: [PATCH 2/2] imx8mn/8mp: Select ENV_IS_NOWHERE

2022-04-21 Thread Fabio Estevam
On 21/04/2022 14:10, Michael Nazzareno Trimarchi wrote: The uboot has no problem, the problem is that the function is wrong ;). When you boot from USB you should inform where to pick the environment. You can force ENV_EVERYWHERE for those architectures, you can decide to change the switch as I

Re: [PATCH 2/2] imx8mn/8mp: Select ENV_IS_NOWHERE

2022-04-21 Thread Fabio Estevam
On 21/04/2022 14:01, Michael Nazzareno Trimarchi wrote: I have seen those patches already but the cost of a function pointer and a call is more readable. If they get applied, I will be fine with them ;) They are already in master. How do we proceed to fix the U-Boot load via USB?

Re: [PATCH 2/2] imx8mn/8mp: Select ENV_IS_NOWHERE

2022-04-21 Thread Fabio Estevam
Hi Michael, On 21/04/2022 13:34, Michael Nazzareno Trimarchi wrote: That function should drop. There is not other architecture that does it. What about: I implemented your suggestion like this: --- a/arch/arm/mach-imx/imx8m/soc.c +++ b/arch/arm/mach-imx/imx8m/soc.c @@ -1536,6 +1536,14 @@

Re: [PATCH 2/2] imx8mn/8mp: Select ENV_IS_NOWHERE

2022-04-21 Thread Fabio Estevam
will prepare v2. Thanks, Fabio Estevam -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email: feste...@denx.de

Re: [PATCH 2/2] imx8mn/8mp: Select ENV_IS_NOWHERE

2022-04-21 Thread Fabio Estevam
Hi Marek, On Wed, Apr 20, 2022 at 7:15 PM Marek Vasut wrote: > Did you actually hit the USB_BOOT case or did you fall into the default: > case ? It does hit the USB_BOOT case. I also tested forcing to return ENVL_UNKNOWN: --- a/arch/arm/mach-imx/imx8m/soc.c +++

[PATCH] spl_imx_romapi: Remove extraneous character

2022-04-21 Thread Fabio Estevam
From: Fabio Estevam Currently the following output is shown: ... Trying to boot from BOOTROM Find img info 0x&48020a00, size 872 ... Remove the extraneous "&" character, so that the correct output can be seen. Signed-off-by: Fabio Estevam --- arch/arm/mach-imx/spl_imx_romap

Re: [PATCH 2/2] imx8mn/8mp: Select ENV_IS_NOWHERE

2022-04-20 Thread Fabio Estevam
Hi Marek, On Wed, Apr 20, 2022 at 6:42 PM Marek Vasut wrote: > I suspect this happens because > > arch/arm/mach-imx/imx8m/soc.c env_get_location() > > contains > " > ... > default: > return ENVL_NOWHERE; > " > > right ? > > I wonder what would happen if you were to add: > > case USB_BOOT: >

[PATCH 2/2] imx8mn/8mp: Select ENV_IS_NOWHERE

2022-04-20 Thread Fabio Estevam
From: Fabio Estevam Currently, on i.MX8MN/i.MX8MP (Bootrom version 2) it is not possible to load U-Boot via serial download mode, unless CONFIG_ENV_IS_NOWHERE is selected. This was noticed before by Adam Ford and fixed on the imx8mn beacon board in commit 2c7ebf7778cf ("imx: imx8mn_beacon

[PATCH 1/2] imx8mn_ddr4_evk: Add USB Mass Storage support

2022-04-20 Thread Fabio Estevam
From: Fabio Estevam Add USB Mass Storage support, which is a convenient way to flash the eMMC card, for example. Signed-off-by: Fabio Estevam --- configs/imx8mn_ddr4_evk_defconfig | 12 1 file changed, 12 insertions(+) diff --git a/configs/imx8mn_ddr4_evk_defconfig b/configs

Re: im8mn: Loading U-Boot via serial download mode

2022-04-20 Thread Fabio Estevam
Hi Michael, On Wed, Apr 20, 2022 at 4:53 PM Michael Nazzareno Trimarchi wrote: >> Set CONFIG_ENV_IS_NOWHERE=y and rebuild. It will likely boot. > > > That code should be dropped because it's really buggy. We already sent > several patches. I prefer some registered mechanism and not those

Re: im8mn: Loading U-Boot via serial download mode

2022-04-20 Thread Fabio Estevam
Hi Adam, On Wed, Apr 20, 2022 at 4:49 PM Adam Ford wrote: > I had to set the environmental variable for ENV is nowhere. There was > a bunch of discussion about the fact that the 8MN and 8MP have some > special code which makes the environmental variable location depend on > the boot device. A

im8mn: Loading U-Boot via serial download mode

2022-04-20 Thread Fabio Estevam
er uuu command that needs to be run so that U-Boot proper can be loaded? Thanks, Fabio Estevam

Re: [PATCH v2 1/1] imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

2022-04-20 Thread Fabio Estevam
ld from source when enabling > CONFIG_OF_BOARD_FIXUP. > > Signed-off-by: Ying-Chun Liu (PaulLiu) > Cc: Fabio Estevam > Cc: uboot-imx > --- > v2: reword commit comment This version looks good: Reviewed-by: Fabio Estevam

Re: [PATCH 1/1] imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

2022-04-20 Thread Fabio Estevam
Hi Paul, On Wed, Apr 20, 2022 at 11:23 AM Ying-Chun Liu wrote: > > From: "Ying-Chun Liu (PaulLiu)" > > In arch/arm/mach-imx/imx8m/soc.c there's an implementation of Please mention that commit 35bb60787b88 ("imx: imx8mp: disable fused IP for UltraLite") was the one that introduced

Re: [PATCH] crypto/fsl: add invalidate_dcache_range for hash output buffer

2022-04-18 Thread Fabio Estevam
return -EINVAL; > } > > + debug("\ncaam hash\n"); Minor nit: please remove this line. Reviewed-by: Fabio Estevam

[PATCH 2/2] doc: imx8mn_evk: Do not export ATF_LOAD_ADDR

2022-04-18 Thread Fabio Estevam
From: Fabio Estevam The imx8mn_evk target have been converted to use binman. With the binman approach the ATF load address is described via devicetree, so remove the now unneeded instruction of exporting ATF_LOAD_ADDR. Signed-off-by: Fabio Estevam --- doc/board/nxp/imx8mn_evk.rst | 1 - 1

[PATCH 1/2] imx8mn_evk: Enable cache in SPL

2022-04-18 Thread Fabio Estevam
From: Fabio Estevam There is no reason for disabling I-cache and D-cache in SPL. Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and CONFIG_SPL_SYS_DCACHE_OFF options. Signed-off-by: Fabio Estevam --- configs/imx8mn_evk_defconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/configs

Re: [PATCH] arm: imx8m: Enable CLK_IMX8M[MNQP] where applicable

2022-04-17 Thread Fabio Estevam
espective clock drivers when a given imx8m SoC > is selected. This will also shink the board defconfig files a bit. s/shink/shrink > Suggested-by: Marek Vasut > Signed-off-by: Adam Ford Reviewed-by: Fabio Estevam

Re: [PATCH] crypto/fsl: Clear the memory when blob decapsulation fails

2022-04-16 Thread Fabio Estevam
ecapsulating > blobs) > Signed-off-by: Gaurav Jain > Reviewed-by: Kshitiz Varshney > Tested-by: Kshitiz Varshney Reviewed-by: Fabio Estevam

Re: [PATCH] i.MX6SX: crypto/fsl: fix entropy delay value

2022-04-16 Thread Fabio Estevam
ted via self-test method. > + * self-test are run across different volatge, temp. s/volatge/voltage Reviewed-by: Fabio Estevam

Re: [PATCH V2] board: bsh: imx8mn_bsh_smm_s2/s2pro: enable DM_SERIAL

2022-04-16 Thread Fabio Estevam
gt; as dm can't be used until after spl_init(). > > Remove the manual config of the UART pinmux now that it is no longer > needed. > > Signed-off-by: Michael Trimarchi > Cc: Tim Harvey Reviewed-by: Fabio Estevam

Re: [PATCH v3] imx: add i.MX8MN DDR3L evk board support

2022-04-16 Thread Fabio Estevam
2 > Loading Environment from MMC... OK > In:serial@3089 > Out: serial@3089 > Err: serial@3089 > > BuildInfo: > - ATF > > Net: eth0: ethernet@30be0000 > u-boot=> > > Signed-off-by: Heiko Thiery Reviewed-by: Fabio Estevam

Re: [PATCH v3 2/2] board: gateworks: venice: add imx8mp-venice-gw740x support

2022-04-16 Thread Fabio Estevam
Hi Tim, On Thu, Apr 14, 2022 at 5:00 PM Tim Harvey wrote: > +/* UART */ > +#define CONFIG_MXC_UART_BASE UART2_BASE_ADDR Since you use DM_SERIAL, this can be removed, right? Reviewed-by: Fabio Estevam

Re: [PATCH v3 1/2] board: gateworks: venice: add additional levels for dtb name match

2022-04-16 Thread Fabio Estevam
Harvey Reviewed-by: Fabio Estevam

Re: [PATCH] arm: dts: imx8mp: add of-list support to common imx8mp-u-boot.dtsi

2022-04-16 Thread Fabio Estevam
Hi Tim, On Fri, Apr 15, 2022 at 5:41 PM Tim Harvey wrote: > > Add support for OF-LIST to common imx8mp-u-boot.dtsi so that it can > be used with boards that have multiple DTB's. > > Signed-off-by: Tim Harvey > Cc: Fabio Estevam > Cc: NXP i.MX U-Boot Team > Cc: Peng

Re: [PATCH V4 0/4] imx: imx8m: enable DM SERIAL

2022-04-16 Thread Fabio Estevam
usage. > > > Peng Fan (4): > imx: imx8mp_evk: enable CONFIG_DM_SERIAL > imx: imx8mm_evk: enable CONFIG_DM_SERIAL > imx: imx8mn_evk: enable CONFIG_DM_SERIAL > imx: imx8mq-evk: enable CONFIG_DM_SERIAL For the series: Reviewed-by: Fabio Estevam

Re: [PATCH v3] board: gateworks: venice: enable DM_SERIAL

2022-04-14 Thread Fabio Estevam
gt; as dm can't be used until after spl_early_init(). This preloader_console_init() comment is what I was expecting when I went trough Peng's patches. It looks good now: Reviewed-by: Fabio Estevam

Re: [PATCH] ARM: imx: imx8m: Fix board_get_usable_ram_top()

2022-04-14 Thread Fabio Estevam
, but rather a physical address marking the topmost allowed DRAM address. Fixes: e27bddff4b9 ("imx8m: Restrict usable memory to space below 4G boundary") Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Frieder Schrempf Cc: Peng Fan Cc: Stefano Babic Good catch! Reviewed-by: Fabio Estevam

Re: [PATCH 3/5] imx8mm-cl-iot-gate: Retrieve the MAC address from EEPROM

2022-04-12 Thread Fabio Estevam
Hi Sean, On 12/04/2022 12:56, Sean Anderson wrote: Hi Fabio, On 3/19/22 8:22 AM, Fabio Estevam wrote: From: Fabio Estevam Currently the eth0 MAC address is randomly assigned. Retrieve the MAC address from EEPROM. A bit of a plug, but can you try [1]? For your board, I believe your device

Re: [PATCH 3/5] imx8mm-cl-iot-gate: Retrieve the MAC address from EEPROM

2022-04-12 Thread Fabio Estevam
Hi Stefano, On 12/04/2022 12:33, Stefano Babic wrote: Hi Fabio, I get an error by applying your patches: aarch64: + imx8mm-cl-iot-gate-optee Ops, I missed to update imx8mm-cl-iot-gate-optee_defconfig. I have sent v2 with the correction. Thanks, Fabio Estevam

[PATCH v2 5/5] imx8mm-cl-iot-gate: Add redundand environment support

2022-04-12 Thread Fabio Estevam
From: Fabio Estevam Add redundand environment support as it is required by SWUpdate. While at it, also adjust the CONFIG_ENV_OFFSET to a more appropriate larger offset as done on other i.MX8M defconfigs. Signed-off-by: Fabio Estevam --- Changes since v1: - None configs/imx8mm-cl-iot

[PATCH v2 4/5] imx8mm-cl-iot-gate: Retrieve the serial number from EEPROM

2022-04-12 Thread Fabio Estevam
From: Fabio Estevam The serial number is located at offset 0x14 of the EEPROM under i2c0 bus at address 0x54. To print the serial number in Linux: SERNUM=$(cat /proc/device-tree/serial-number) echo $SERNUM Signed-off-by: Fabio Estevam --- Changes since v1: - None .../imx8mm-cl-iot-gate

[PATCH v2 3/5] imx8mm-cl-iot-gate: Retrieve the MAC address from EEPROM

2022-04-12 Thread Fabio Estevam
From: Fabio Estevam Currently the eth0 MAC address is randomly assigned. Retrieve the MAC address from EEPROM. Signed-off-by: Fabio Estevam --- Changes since v1: - Also update imx8mm-cl-iot-gate-optee_defconfig to fix the build (Stefano). arch/arm/dts/imx8mm-cl-iot-gate.dts | 12

[PATCH v2 2/5] imx8mm-cl-iot-gate: Retrieve the DDR type from EEPROM

2022-04-12 Thread Fabio Estevam
From: Fabio Estevam Currently, the DDR type is retrieved by iteracting inside an array of possible DDR types. This may take saveral attempts, which slows the overall U-Boot process and does not provide a good user experience: U-Boot SPL 2021.07 (Feb 28 2022 - 06:39:32 +) DDRINFO: Cfg

[PATCH v2 1/5] imx8mm-cl-iot-gate: Add SPL EEPROM support

2022-04-12 Thread Fabio Estevam
From: Fabio Estevam imx8mm-cl-iot-gate supports multiple DDR sizes and models. The DDR type can be retrieved from the EEPROM, so add SPL code that can be used to get the DDR information. Based on the original code from Compulab's U-Boot. Signed-off-by: Fabio Estevam --- Changes since v1

[PATCH] warp7: Remove duplicated "mmc dev" command

2022-04-12 Thread Fabio Estevam
From: Fabio Estevam The "mmc dev ${mmcdev}" command is done twice. Remove one ocurrence to avoid the duplication. Signed-off-by: Fabio Estevam --- configs/warp7_bl33_defconfig | 2 +- configs/warp7_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH V2] imx: mx7dsabresd: enable DM_SERIAL

2022-04-12 Thread Fabio Estevam
On Mon, Apr 11, 2022 at 10:32 PM Peng Fan (OSS) wrote: > + { > + u-boot,dm-pre-reloc; > +}; > + > +&{/soc/bus@3080/spba-bus@3080} { would be easier to read. > +_lpsr { > + u-boot,dm-pre-reloc; > +}; > + > +&{/soc/bus@3000/iomuxc@3033/imx7d-sdb} { would be easier

Re: [PATCH V2 3/4] imx: imx8mn_evk: enable CONFIG_DM_SERIAL

2022-04-12 Thread Fabio Estevam
On Tue, Apr 12, 2022 at 12:33 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Enable CONFIG_DM_SERIAL. uart2 and its pinmux was already > marked with u-boot,dm-spl. > > File generated with make savedefconfig Same comment about mixing savedefconfig changes into the same patch applies. You

Re: [PATCH V2 1/4] imx: imx8mp_evk: enable CONFIG_DM_SERIAL

2022-04-12 Thread Fabio Estevam
Hi Peng, Thanks for reworking this series. On Tue, Apr 12, 2022 at 12:33 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Enable CONFIG_DM_SERIAL. uart2 and its pinmux was already > marked with u-boot,dm-spl. > > File generated with make savedefconfig IMHO, running savedefconfig in the same

Re: [PATCH] imx: mx7dsabresd: enable DM_SERIAL

2022-04-11 Thread Fabio Estevam
Hi Peng, On Mon, Apr 11, 2022 at 6:21 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Enable CONFIG_DM_SERIAL, and `dm tree` could show: > serial1 [ ] serial_mxc| |-- serial@30a8 > > Signed-off-by: Peng Fan > --- > configs/mx7dsabresd_defconfig | 1 + >

Re: [PATCH] Kconfig: Fix SYS_MALLOC_F_LEN for i.MX8MQ

2022-04-11 Thread Fabio Estevam
_LS1021A || ARCH_LS1043A || \ + ARCH_LS1046A) + default 0x2000 if IMX8MQ Thanks for the fix: Reviewed-by: Fabio Estevam -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Pho

Re: [PATCH 00/13] configs: clean up SDHC marco and MMCROOT

2022-04-08 Thread Fabio Estevam
cleanup: Reviewed-by: Fabio Estevam

Re: [PATCH] clk: imx8mp: Add ECSPI clocks

2022-04-06 Thread Fabio Estevam
Hi Elmar, On 06/04/2022 08:39, Elmar Albert wrote: Add clock tables required for bing up ECSPI interfaces nit: s/bing/bring Signed-off-by: Elmar Albert Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: uboot-imx Signed-off-by: Elmar Albert Reviewed-by: Fabio Esteva,

Re: [PATCH v1 2/2] mx6: ddr: Wait before issuing the first MRS cmd

2022-04-06 Thread Fabio Estevam
n failures > with about 2% boot failure rate on specific problematic boards, after > this change we were able to do more than 10.000 power-cycle without a > single failure. Glad you fixed this problem. Not an easy one! Reviewed-by: Fabio Estevam

Re: [PATCH v1 1/2] mx6: ddr: Restore ralat/walat in write level calibration

2022-04-06 Thread Fabio Estevam
e to not overwrite the mdmisc register in > the first place, since this is not present in the write_level_calib() example > in NXP AN4467 nor in the i.MX6 RM (44.11.6.1 Hardware Write Leveling > Calibration). > > Fixes: d339f16911c7 ("arm: imx6: Add DDR3 calibration code for MX6 Q/D/DL") > Signed-off-by: Francesco Dolcini > Reviewed-by: Marek Vasut Reviewed-by: Fabio Estevam

Re: [PATCH 3/3] imx: power-domain: Get rid of SMCCC dependency

2022-04-06 Thread Fabio Estevam
Hi Adam, On Wed, Apr 6, 2022 at 9:22 AM Adam Ford wrote: > I tried to build the imx8mq last night, but I ran into issues. I > never built an imx8mq bootloader before, so I think I'm missing > something. I'll try to get to it again this week. Sorry for the > delays. Please check

<    7   8   9   10   11   12   13   14   15   16   >