[PATCH] ls1021atsn: Suggest the NXP RCW github repo

2023-01-12 Thread Fabio Estevam
Signed-off-by: Fabio Estevam --- board/freescale/ls1021atsn/README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/freescale/ls1021atsn/README.rst b/board/freescale/ls1021atsn/README.rst index cdec02f1a3..cd12291d8a 100644 --- a/board/freescale/ls1021atsn/README.rst +

[PATCH] imx: Suggest the NXP ATF github repo

2023-01-12 Thread Fabio Estevam
As explained in the text at the bottom of the page https://source.codeaurora.org/external/imx/imx-atf: "QUIC repositories on this site will not receive any updates after March 31, 2022, and will be deleted on March 31, 2023." Point to the NXP ATF github repo instead. Signed-off

Re: [PATCH v4 2/2] serial: mxc: Speed-up character transmission

2023-01-12 Thread Fabio Estevam
On Thu, Jan 12, 2023 at 2:52 PM Fabio Estevam wrote: > > On Thu, Jan 12, 2023 at 2:19 PM Loic Poulain wrote: > > > > Instead of waiting for empty FIFO condition before writing a > > character, wait for non-full FIFO condition. > > > > This helps in saving seve

Re: [PATCH v4 2/2] serial: mxc: Speed-up character transmission

2023-01-12 Thread Fabio Estevam
: Loic Poulain > Tested-by: Lothar Waßmann > Acked-by: Pali Rohár Reviewed-by: Fabio Estevam

Re: [PATCH v4 1/2] serial: mxc: Wait for TX completion before reset

2023-01-12 Thread Fabio Estevam
n > enough to consume the FIFO @ low baudrate (9600bps). > > Signed-off-by: Loic Poulain > Tested-by: Lothar Waßmann Reviewed-by: Fabio Estevam

[PATCH] pico-imx7d: Add support for the 2GB variant

2023-01-11 Thread Fabio Estevam
Add the board detection mechanism to be able to support the 2GB variant. Based on the code from TechNexion U-Boot downstream tree. Signed-off-by: Fabio Estevam --- board/technexion/pico-imx7d/spl.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff

Re: [PATCH v3 2/2] serial: mxc: Speed-up character transmission

2023-01-10 Thread Fabio Estevam
: Loic Poulain > Tested-by: Lothar Waßmann > --- > v2: fixing transfert abort & char corruption commit > v3: Reordering commits for good bisectability Reviewed-by: Fabio Estevam Thanks

Re: [PATCH v3 1/2] serial: mxc: Wait for TX completion before reset

2023-01-10 Thread Fabio Estevam
than > enough to consume the FIFO @ low baudrate (9600bps). > > Signed-off-by: Loic Poulain > Tested-by: Lothar Waßmann > --- > v2: Add this commit to the series > v3: Fix typo & reordering commits for good bisectability Reviewed-by: Fabio Estevam Thanks

[PATCH v3] imx8mm-phg: Add board support

2023-01-10 Thread Fabio Estevam
Add the board support for the i.MX8MM Cloos PHG board. This board uses a imx8mm-tqma8mqml SoM from TQ-Group. imx8mm-phg.dts and imx8mm-tqma8mqml.dtsi are taken directly from Linux 6.2-rc3. Signed-off-by: Fabio Estevam --- Changes since v2: - Convert to a text environment file (Tom). arch

Re: [PATCH v2] imx8mm-phg: Add board support

2023-01-10 Thread Fabio Estevam
Hi Tom, On Tue, Jan 10, 2023 at 1:33 PM Tom Rini wrote: > We're not yet to the point of nak'ing new boards over this, but if you > look at something like board/kontron/sl-mx8mm/sl-mx8mm.env the above > is trivially done that way instead. Is there something blocking doing > that? Thanks for the

Re: [PATCH v2 2/2] serial: mxc: Wait for TX completion before reset

2023-01-10 Thread Fabio Estevam
Hi Loic, On Tue, Jan 10, 2023 at 9:41 AM Loic Poulain wrote: > > The u-boot console may show some corrupted characters when > printing in board_init() due to reset of the UART (probe) > before the TX FIFO has been completely drained. > > To fix this issue, and in case UART is still running, we

[PATCH v2] imx8mm-phg: Add board support

2023-01-10 Thread Fabio Estevam
Add the board support for the i.MX8MM Cloos PHG board. This board uses a imx8mm-tqma8mqml SoM from TQ-Group. imx8mm-phg.dts and imx8mm-tqma8mqml.dtsi are taken directly from Linux 6.2-rc3. Signed-off-by: Fabio Estevam --- Changes since v1: - Rebased on top of current master (Tom

Re: [PATCH] imx8mm-phg: Add board support

2023-01-09 Thread Fabio Estevam
RAM 0x4000 +#define PHYS_SDRAM_SIZE0x8000 /* 2GB DDR */ Please make sure we need to define PHYS_SDRAM* at all. Thanks! Sorry, I don't understand this comment. PHYS_SDRAM and PHYS_SDRAM_SIZE are used by arch/arm/mach-imx/imx8m/soc.c. Regards, Fabio Este

[PATCH] imx8mm-phg: Add board support

2023-01-09 Thread Fabio Estevam
Add the board support for the i.MX8MM Cloos PHG board. This board uses a imx8mm-tqma8mqml SoM from TQ-Group. imx8mm-phg.dts and imx8mm-tqma8mqml.dtsi are taken directly from Linux 6.2-rc3. Signed-off-by: Fabio Estevam --- arch/arm/dts/Makefile |1 + arch/arm

Re: [PATCH] arm64: dts: imx8mm-kontron: Add RTC aliases

2023-01-09 Thread Fabio Estevam
-next. Signed-off-by: Frieder Schrempf Signed-off-by: Shawn Guo Reviewed-by: Fabio Estevam

Re: [PATCH v2 1/2] wandboard: Pass mmc aliases

2023-01-08 Thread Fabio Estevam
On Sun, Jan 8, 2023 at 11:58 AM Tom Rini wrote: > It's already been merged: > commit f827f84d3f5607d0b33e927f6127a888e7bd664f Ok, great! I haven't received any message saying it has been applied, so that's why I missed it. Thanks

Re: [PATCH v2 1/2] wandboard: Pass mmc aliases

2023-01-08 Thread Fabio Estevam
Hi Tom, On Tue, Jan 3, 2023 at 8:00 AM Fabio Estevam wrote: > > Hi Tom and Stefano, > > On Fri, Nov 4, 2022 at 8:13 AM Fabio Estevam wrote: > > > > From: Fabio Estevam > > > > Originally, the mmc aliases node was present in imx6qdl-wandboard.dtsi. > &g

Re: [u-boot][master][PATCH 1/3] pico-imx7d: add support for 2GB memory SoMs

2023-01-07 Thread Fabio Estevam
Hi Benjamin, Please don't top post. On Sat, Jan 7, 2023 at 2:15 PM Szőke Kálmán Benjamin wrote: > > My last three patches were tested in my company's custom i.MX7D pico SoMs > carrier board, it was workd well with 512MB and 1 GB SoM variants in U-boot > v2022.10. I have no any 2GB variants

Re: [regression] 2023.01 breaks u-boot-initial-env for aarch64

2023-01-07 Thread Fabio Estevam
Hi Otavio, On Sat, Jan 7, 2023 at 10:22 AM Otavio Salvador wrote: > I didn't enable it explicitly. I enable LTO in this commit: https://source.denx.de/u-boot/u-boot/-/commit/750d7ddf2c514949228d991e6dd4f7982bfb27f6 > > Does 486aef08de ("u-boot-initial-env: rework make target") fix things? > >

Re: [u-boot][master][PATCH 1/3] pico-imx7d: add support for 2GB memory SoMs

2023-01-07 Thread Fabio Estevam
Hi Benjamin, On Sat, Jan 7, 2023 at 8:22 AM Szőke Kálmán Benjamin wrote: > > Original code was a nested if statement for checking 1g() and 2g(). > https://github.com/TechNexion/u-boot-tn-imx/blob/tn-imx_v2021.04_5.10.72_2.2.0-stable/board/technexion/pico-imx7d/pico-imx7d_spl.c#L106 Yes, I saw

Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"

2023-01-06 Thread Fabio Estevam
On Fri, Jan 6, 2023 at 12:51 PM Tom Rini wrote: > > This reverts commit 777706bcfe08c284aed06886db7d482af3f8. > > The changes to this generic function, which is intended to help with > 32bit platforms with large amounts of memory has unintended side effects > (which in turn lead to boot

[PATCH] i2c: mxc_i2c: Use hex notation for the base address

2023-01-03 Thread Fabio Estevam
Printing the I2C controller base address in decimal notation is not helpful. Change it to hex notation, which is the standard format found in the Reference Manual and devicetree. Signed-off-by: Fabio Estevam --- drivers/i2c/mxc_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 3/3] pico-imx7d: Convert to DM_I2C and DM_PMIC

2023-01-03 Thread Fabio Estevam
The conversion to DM_I2C is mandatory, so convert to it and also to DM_PMIC. Signed-off-by: Fabio Estevam --- To test this, it is necessary to apply the following patch first: https://lore.kernel.org/u-boot/20221231183427.GI3787616@bill-the-cat/T/#t board/technexion/pico-imx7d/pico-imx7d.c

[PATCH 2/3] mx7: clock: Use 60MHz for the I2C clocks

2023-01-03 Thread Fabio Estevam
for the I2C clock. This provides a workaround for the imx7d-pico board, where I2C4 is connected to the PMIC. With this change, it is possible to convert the imx7d-pico board to DM_I2C and DM_PMIC. Signed-off-by: Fabio Estevam --- arch/arm/mach-imx/mx7/clock.c | 2 +- 1 file changed, 1 insertion

[PATCH 1/3] pico-imx7d: Convert to CONFIG_DM_SERIAL

2023-01-03 Thread Fabio Estevam
The conversion to CONFIG_DM_SERIAL is mandatory, so select this option. Signed-off-by: Fabio Estevam --- To test this, it is necessary to apply the following patch first: https://lore.kernel.org/u-boot/20221231183427.GI3787616@bill-the-cat/T/#t configs/pico-dwarf-imx7d_defconfig | 1

Re: [PATCH v2 1/2] wandboard: Pass mmc aliases

2023-01-03 Thread Fabio Estevam
Hi Tom and Stefano, On Fri, Nov 4, 2022 at 8:13 AM Fabio Estevam wrote: > > From: Fabio Estevam > > Originally, the mmc aliases node was present in imx6qdl-wandboard.dtsi. > > After the sync with Linux in commit d0399a46e7cd ("imx6dl/imx6qdl: > synchronise device trees

Re: [PATCH] ddr: imx: Save the FW loading if it hasn't changed

2023-01-02 Thread Fabio Estevam
helps to > reduce DDRPHY training time from 269 ms down to 212 ms, and thus speed > up boot time ~ 50 ms. > > Signed-off-by: Shawn Guo Reviewed-by: Fabio Estevam

Re: [u-boot][master][PATCH 1/3] pico-imx7d: add support for 2GB memory SoMs

2022-12-31 Thread Fabio Estevam
test it myself. You also need to apply the following patch to fix the boot against U-Boot top of tree: https://lore.kernel.org/u-boot/20221231162514.334303-1-feste...@denx.de/T/#u From 1777fa36f9b1e93284969b49037daa3871e99a77 Mon Sep 17 00:00:00 2001 From: Fabio Estevam Date: Sat, 31 Dec 2022 13:14:02

[PATCH] imx7d-pico: Fix the name of the u-boot.dtsi file

2022-12-31 Thread Fabio Estevam
x upstream dtsi, this u-boot.dtsi inclusion is gone and the board fails to boot. U-Boot uses the imx7d-pico-pi.dtb file, so rename the u-boot.dtsi to imx7d-pico-pi-u-boot.dtsi which gets included automatically by U-Boot standard make logic and makes the board boot again. Signed-off-by: Fabio Estev

Re: [PATCH v2 0/3] Data Co-processor RNG Driver

2022-12-22 Thread Fabio Estevam
Hi Heinrich, On Thu, Dec 22, 2022 at 9:52 PM Heinrich Schuchardt wrote: > > configs/mx6ull_14x14_evk_defconfig| 4 + > > configs/mx6ull_14x14_evk_plugin_defconfig | 4 + > > Do these boards lack the CAAM RNG supported by drivers/crypto/fsl/rng.c? imx6ull does not have CAAM.

Re: [u-boot][master][PATCH 1/3] pico-imx7d: add support for 2GB memory SoMs

2022-12-19 Thread Fabio Estevam
On Mon, Dec 19, 2022 at 9:12 PM Szőke Kálmán Benjamin wrote: > > Technexion did that renaming, it is better to keep in synchronized. > https://github.com/TechNexion/u-boot-tn-imx/tree/tn-imx_v2021.04_5.10.72_2.2.0-stable/board/technexion/pico-imx7d Sorry, that's not a good justification. Just

Re: [u-boot][master][PATCH 2/3] pico-imx7d: add baseboard SD card boot detect

2022-12-19 Thread Fabio Estevam
On Sun, Dec 18, 2022 at 9:53 AM wrote: > + for (index = 0; index < CONFIG_SYS_FSL_USDHC_NUM; ++index) { > + ret = fsl_esdhc_initialize(bis, _cfg[index]); > + if (ret) > + return ret; In patch 3/3, CONFIG_SPL_DM_MMC=y, so can't the driver

Re: [u-boot][master][PATCH 1/3] pico-imx7d: add support for 2GB memory SoMs

2022-12-19 Thread Fabio Estevam
On Sun, Dec 18, 2022 at 9:52 AM wrote: > > From: Benjamin Szőke > > Take over codes from Techenxion to support SoMs with 2GB DDR3. > > Signed-off-by: Benjamin Szőke > --- > board/technexion/pico-imx7d/Makefile | 2 +- > .../pico-imx7d/{spl.c => pico-imx7d_spl.c}| 30

Re: [u-boot][master][PATCH 1/3] pico-imx7d: add support for 2GB memory SoMs

2022-12-19 Thread Fabio Estevam
On Sun, Dec 18, 2022 at 9:52 AM wrote: > +static void ddr_init(void) > +{ > + if (is_1g()) { > + if (is_2g()) { This logic is confusing. It would be better to read the two GPIOs and then do a switch case to handle the possible values.

Re: [PATCH] engicam: imx6: migrate to DM_SERIAL

2022-12-16 Thread Fabio Estevam
Hi Suniel, On Fri, Dec 9, 2022 at 6:36 AM Suniel Mahesh wrote: > > From: Michael Trimarchi > > Add the needed DT overrides and configs to enable UART in SPL. > > Cc: Fabio Estevam > Signed-off-by: Michael Trimarchi > Tested-by: Suniel Mahesh You missed

Re: [PATCH] imx8mq_pins: fix configuration for UART4 on ECSPI2 pads

2022-12-15 Thread Fabio Estevam
es, the DT definition does the same: #define MX8MQ_IOMUXC_ECSPI2_MOSI_UART4_DCE_TX 0x208 0x470 0x000 0x1 0x0 #define MX8MQ_IOMUXC_ECSPI2_MOSI_UART4_DTE_RX 0x208 0x470 0x50C 0x1 0x1 Reviewed-by: Fabio Estevam

Re: [PATCH] net: Fix memory corruption in eth_halt() if the stop handler frees the priv member

2022-12-12 Thread Fabio Estevam
Hi Bernhard, On Mon, Dec 12, 2022 at 6:12 PM Bernhard Rosenkränzer wrote: > > Calling eth_halt() could result in memory corruption if the stop() > handler frees or modifies the priv member. > > A stored value of dev_get_uclass_priv() is assumed to remain valid > after the stop() handler has been

[PATCH] imx6qdl-sabresd: Pass mmc alias

2022-12-10 Thread Fabio Estevam
From: Fabio Estevam Originally, the mmc aliases node was present in imx6qdl-sabresd.dtsi. After the sync with Linux in commit d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with linux"), the aliases node is gone as the upstream version does not have it. This causes a

Re: [PATCH] ARM: imx: Reinstate decode ECSPI env location from i.MX8M ROMAPI tables

2022-12-10 Thread Fabio Estevam
ecode ECSPI env location from i.MX8M ROMAPI tables") which has been dropped in commit: b0a284a7c94 ("imx: move get_boot_device to common file") Fixes: b0a284a7c94 ("imx: move get_boot_device to common file") Signed-off-by: Marek Vasut Reviewed-by: Fabio Estevam

Re: [PATCH 2/2] ARM: imx: Remove PMIC reset configuration from board files

2022-12-10 Thread Fabio Estevam
grep -l PCA9450_RESET_CTRL.*0xA1 board/) ``` Venice and i.MX93 EVK required slight manual fix up. Signed-off-by: Marek Vasut Reviewed-by: Fabio Estevam

Re: [PATCH 1/2] pmic: pca9450: Make warm reset on WDOG_B assertion

2022-12-10 Thread Fabio Estevam
this patch is created. The implementation is taken almost verbatim from Linux commit 2364a64d0673f ("regulator: pca9450: Make warm reset on WDOG_B assertion") Signed-off-by: Marek Vasut Reviewed-by: Fabio Estevam

Re: [PATCH v3] imx6q-sabrelite: Re-add mmc aliases

2022-12-08 Thread Fabio Estevam
. > > This should never be done for new boards as we want to keep linux and > u-boot with the same aliases as much as possible. > This patch is only necessary to avoid breaking existing setups. > > Signed-off-by: Detlev Casanova Reviewed-by: Fabio Estevam

Re: [PATCH v2] imx6: Re-add mmc aliases

2022-12-08 Thread Fabio Estevam
Hi Detlev, [Please keep Troy on Cc as he is the board maintainer] Subject should be: imx6q-sabrelite: Re-add mmc aliases On Thu, Dec 8, 2022 at 12:23 PM Detlev Casanova wrote: > > In commit d0399a46e7cda63c07e3eb8558bef84cfb068028, the device tree was > synchronized from linux and the aliases

Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices

2022-12-05 Thread Fabio Estevam
On Mon, Dec 5, 2022 at 12:37 PM Tom Rini wrote: > I'm not really happy with this approach. It's not that upstream doesn't > have aliases now, it's that it has different aliases, right? That's why > they won't accept these? imx6q.dtsi does have the default mmc aliases: mmc0 = mmc1 = mmc2 =

Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices

2022-12-03 Thread Fabio Estevam
dboard in the following commit: commit f827f84d3f5607d0b33e927f6127a888e7bd664f Author: Fabio Estevam Date: Fri Nov 4 08:12:54 2022 -0300 wandboard: Pass mmc aliases Originally, the mmc aliases node was present in imx6qdl-wandboard.dtsi. After the sync with Linux in commit d0399a

Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices

2022-12-02 Thread Fabio Estevam
[Adding Troy] On Fri, Dec 2, 2022 at 4:06 PM Detlev Casanova wrote: > Upstream linux won't apply it as they want to keep the already established > order in linux (the SD card has to stay at mmc2). See > https://lore.kernel.org/all/a13c2e92-cfa6-04fd-c32a-c4d444894...@pengutronix.de/ > > > I

Re: [PATCH 1/2] arm: dts: imx8m*-venice-*: add I2C GPIO bus recovery support

2022-12-02 Thread Fabio Estevam
On Fri, Nov 11, 2022 at 1:03 PM Tim Harvey wrote: > > Add I2C GPIO bus recovery support by adding scl-gpios and sda-gpios for the > various I2C busses on Gateworks Venice boards. > > Signed-off-by: Tim Harvey Reviewed-by: Fabio Estevam

Re: [PATCH 2/2] board: gateworks: venice: poll I2C lines to wait for GSC firmware

2022-12-01 Thread Fabio Estevam
ines to wait until they are > released to avoid the I2C drivers 'Arbitation lost' error message. > > Signed-off-by: Tim Harvey > --- > v2: move u-boot,dm-spl to *-u-boot.dtsi where it belongs Reviewed-by: Fabio Estevam

Re: [PATCH 1/2] arm: dts: imx8m*-venice-*: add I2C GPIO bus recovery support

2022-12-01 Thread Fabio Estevam
Hi Tim, On Fri, Nov 11, 2022 at 1:03 PM Tim Harvey wrote: > > Add I2C GPIO bus recovery support by adding scl-gpios and sda-gpios for the > various I2C busses on Gateworks Venice boards. > > Signed-off-by: Tim Harvey > --- > Note this is taken from an upstream Linux commit Why not syncing the

Re: [PATCH] imx: imx6ul: kontron-sl-mx6ul: Disable CONFIG_FSL_QSPI_AHB_FULL_MAP to fix SPI NAND read access

2022-12-01 Thread Fabio Estevam
NAND read access on the Kontron SL i.MX6UL/ULL boards. > Reading data from the flash returns garbage instead of the actual > content. Fix this for now by disabling the introduced option. > > In the long run this should be fixed globally. Yes, most likely more boards have the same problem. Reviewed-by: Fabio Estevam

Re: [PATCH v1] imx8qm-rom7720: fix broken boot caused by missing CONFIG_EVENT

2022-12-01 Thread Fabio Estevam
Hi Heinrich, On Tue, Nov 22, 2022 at 5:42 AM Oliver Graute wrote: > > since commit c5ef2025579e91f132cd3cead8ebe8b4cd5dd2b6 > its necessary to set CONFIG_EVENT for a successful boot of this board again > > Signed-off-by: Oliver Graute > CC: heinrich.schucha...@canonical.com > --- >

Re: [PATCH v2 0/8] imx8: switch missing boards to binman

2022-12-01 Thread Fabio Estevam
Hi Oliver, On Tue, Nov 22, 2022 at 11:24 AM Oliver Graute wrote: > On building the imx8qm_rom7720 board the CONFIG_SPL_BUILD define is > somehow always false. So I endup in a invalid image: > > Image 'main-section' is missing external blobs and is non-functional: spl > Image 'main-section' has

Re: [PATCH 1/1] configs: imx8mp_evk: revert to old ram settings

2022-11-30 Thread Fabio Estevam
> > Signed-off-by: Manoj Sai > Reported-by : Peter Bergin Reviewed-by: Fabio Estevam Stefano, please queue this one for 2023.01. Thanks

Re: [PATCH] usb: gadget: dfu: Fix check of transfer direction

2022-11-30 Thread Fabio Estevam
gned-off-by: Hugo SIMELIERE Reviewed-by: Fabio Estevam

Re: [PATCH] usb: gadget: dfu: Fix check of transfer direction

2022-11-30 Thread Fabio Estevam
Adding Marek and Sultan On Wed, Nov 30, 2022 at 3:55 PM wrote: > > From: Hugo SIMELIERE > > Commit fbce985e28eaca3af82afecc11961aadaf971a7e to fix CVE-2022-2347 > blocks DFU usb requests. > The verification of the transfer direction was done by an equality > but it is a bit mask. > >

Re: [PATCH] usb: gadget: dfu: Fix the unchecked length field

2022-11-29 Thread Fabio Estevam
Hi Sultan, On Tue, Nov 29, 2022 at 4:49 PM Sultan Khan wrote: > > While I haven't yet gotten around to trying DFU with this patch applied, my > guess as to the issue would be the checks of the form "if (ctrl-> > bRequestType == USB_DIR_OUT)" or "if (ctrl->bRequestType == USB_DIR_IN)". > The

Re: [PATCH] SPI: GD SPI: added Gigadevice part #s in the ids.c file

2022-11-21 Thread Fabio Estevam
On Mon, Nov 21, 2022 at 9:04 PM Victor Lim wrote: > > Updated the ids.c file with Gigadevice SPI NOR part #s. What exactly was updated? Please describe it here. > Signed-Off-by: Victor Lim > --- > drivers/mtd/spi/spi-nor-ids.c | 137 +++--- > 1 file changed, 92

Re: [PATCH 1/3] arm32: Fix relocation of env_addr if POSITION_INDEPENDENT=y

2022-11-20 Thread Fabio Estevam
On Sun, Nov 20, 2022 at 1:57 PM Pali Rohár wrote: > > Apply commit 534f0fbd6520 ("arm64: Fix relocation of env_addr if > POSITION_INDEPENDENT=y") also for 32-bit ARM. > > This change fixes crashing of U-Boot on ARMv7 (Omap3 / Cortex-A8) Nokia N900 > phone (real HW). Note that qemu emulator of

Re: [PATCH] Enforce buffer boundaries on RNDIS USB Gadget

2022-11-20 Thread Fabio Estevam
Szymon, On Thu, Nov 17, 2022 at 4:46 PM Szymon Heidrich wrote: > > Prevent access to arbitrary memory locations in gen_ndis_set_resp > via manipulation of buf->InformationBufferOffset. Lack of validation > of BufOffset could be exploited to dump arbitrary memory contents > via NDIS packet

Re: [PATCH v2 0/8] imx8: switch missing boards to binman

2022-11-18 Thread Fabio Estevam
Hi Oliver, On Fri, Nov 18, 2022 at 10:48 AM Oliver Graute wrote: > Ok, I can confirm it builds without the binary blobs with this changes. > I'll change it in patches accordingly Your series has already landed in master. Please send any incremental patches to address Marcel's feedback on top

Re: [PATCH] Prevent buffer overflow on USB control endpoint

2022-11-17 Thread Fabio Estevam
[Adding Lukasz and Marek] On Thu, Nov 17, 2022 at 6:50 AM Szymon Heidrich wrote: > > Assure that the control endpoint buffer of size USB_BUFSIZ (4096) > can not be overflown during handling of USB control transfer > requests with wLength greater than USB_BUFSIZ. > > Signed-off-by: Szymon

Re: USB Device buffer overflow

2022-11-16 Thread Fabio Estevam
Hi Szymon, [Adding Marek] On Wed, Nov 16, 2022 at 8:56 PM Szymon Heidrich wrote: > > Hello, > > Similar to CVE-2021-39685 affecting the Linux kernel U-Boot is vulnerable to > a buffer overflow > present in the USB Gadget stack. Handling of a control transfer request with > wLength larger than

Re: [PATCH 0/6] broken CVE fix (b85d130ea0ca)

2022-11-16 Thread Fabio Estevam
On Mon, Nov 14, 2022 at 10:04 AM Tom Rini wrote: > > On Mon, Nov 14, 2022 at 10:35:51AM +0100, Rasmus Villemoes wrote: > > On 14/10/2022 19.43, Rasmus Villemoes wrote: > > > tl;dr: b85d130ea0ca didn't fix the CVE(s), but did break tftp of > > > certain file sizes - which is somewhat lucky, since

Re: [PATCH 11/11] imx: mx6sabresd: select DM_SERIAL

2022-11-15 Thread Fabio Estevam
Hi Peng, On Tue, Nov 15, 2022 at 6:17 AM Peng Fan wrote: > > No, the SPL not use DM_SERIAL. For mx6sabresd, it supports 3 boards, > limited SRAM made is hard to enable the DM feature. setup_iomux_uart() is not called in SPL. It is called inside U-Boot proper.

Re: [PATCH v2 2/2] udoo_neo: Select DM_SERIAL and drop iomux board level init

2022-11-14 Thread Fabio Estevam
On Mon, Nov 14, 2022 at 5:53 PM Peter Robinson wrote: > > Convert to DM_SERIAL and drop the iomux board file > level init as it's handled as part of the DM serial > layer instead. > > Signed-off-by: Peter Robinson Reviewed-by: Fabio Estevam

Re: [PATCH v2 1/2] udoo_neo: Move to DM for REGULATOR/PMIC/I2C drivers

2022-11-14 Thread Fabio Estevam
On Mon, Nov 14, 2022 at 5:53 PM Peter Robinson wrote: > > This moves over the PMIC power init to DM and the associated i2c and > regulator bits. > > Signed-off-by: Peter Robinson Reviewed-by: Fabio Estevam

Re: [PATCH 2/2] udoo_neo: Select DM_SERIAL

2022-11-14 Thread Fabio Estevam
On Mon, Nov 14, 2022 at 2:51 PM Peter Robinson wrote: > Yes, I realised that, I was going to do a follow up patch like some of > the other conversions I'd seen, but I'm reviewing a few other bits > while I'm at it. It is OK to do that on incremental patches, thanks.

Re: [PATCH 11/11] imx: mx6sabresd: select DM_SERIAL

2022-11-14 Thread Fabio Estevam
Hi Peng, On Mon, Nov 7, 2022 at 4:14 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Select DM_SERIAL When converting to DM_SERIAL, please also remove setup_iomux_uart() from the board code.

Re: [PATCH 2/2] udoo_neo: Select DM_SERIAL

2022-11-14 Thread Fabio Estevam
On Mon, Nov 14, 2022 at 1:15 PM Peter Robinson wrote: > > The conversion to DM_SERIAL is mandatory, so select this > option. After converting it to DM_SERIAL, the setup_iomux_uart() could be removed. With that removed: Reviewed-by: Fabio Estevam

Re: [PATCH 1/2] udoo_neo: Move to DM for REGUALTOR/PMIC/I2C drivers

2022-11-14 Thread Fabio Estevam
t; +CONFIG_DM_I2C=y > CONFIG_DM_GPIO=y > +CONFIG_DM_MMC=y CONFIG_DM_MMC is selected by default. No need to have it in the defconfig. Reviewed-by: Fabio Estevam

Re: [PATCH v2 0/8] imx8: switch missing boards to binman

2022-11-11 Thread Fabio Estevam
On Fri, Nov 11, 2022 at 2:40 PM Fabio Estevam wrote: > I removed SPL support, which does not seems to be needed as the scufw > handles DDR init. > > I don't have access to an imx8qm/qxp board here. > > Could you try removing SPL support from your board and see if it boots >

Re: [PATCH v2 0/8] imx8: switch missing boards to binman

2022-11-11 Thread Fabio Estevam
Hi Oliver, On Fri, Nov 11, 2022 at 9:54 AM Oliver Graute wrote: > imx8mm_evk_defconfig > apalis-imx8_defconfig > > But where is the difference here? With the change below, the imx8qm_mek_defconfig builds without errors in the absence of the blobs: diff --git a/arch/arm/dts/imx8qm-u-boot.dtsi

Re: [PATCH v2 0/8] imx8: switch missing boards to binman

2022-11-09 Thread Fabio Estevam
Hi Oliver and Stefano, On Wed, Nov 9, 2022 at 1:19 PM Oliver Graute wrote: > For my imx8qm boards I need to manually place these imx firmware blobs with > expected names for sucessfull image creation. > > As I understood the CI creates somes fakes. But I don't know where this > is happening.

Re: [PATCH] dfu: bounds check USB upload and download sizes

2022-11-08 Thread Fabio Estevam
Hi Sultan, On Tue, Nov 8, 2022 at 9:22 PM Sultan Qasim Khan wrote: > > Also verify transfer directions match what is expected for the operation > type. Addresses memory corruption and disclosure vulnerability > CVE-2022-2347. > > Signed-off-by: Sultan Qasim Khan There was a submission already

Re: [PATCH v2 0/8] imx8: switch missing boards to binman

2022-11-08 Thread Fabio Estevam
Hi Oliver and Stefano, On Tue, Nov 8, 2022 at 1:43 PM Stefano Babic wrote: > I have tried to merge the series, but I get build errors, see: > > https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/519510 > > Could you take a look ? One problem I noticed is the missing CONFIG_TEXT_BASE

[PATCH] msc_sm2s_imx8mp: Convert to CONFIG_TEXT_BASE

2022-11-08 Thread Fabio Estevam
From: Fabio Estevam The conversion to CONFIG_TEXT_BASE was missed here. Convert it to fix a build error in CI. Signed-off-by: Fabio Estevam --- Stefano, This is against u-boot-imx, master-next branch. If you prefer to squash with the original commit, feel free to do it. configs

Re: u-boot-imx master-next CI failure

2022-11-08 Thread Fabio Estevam
Hi Tom, On Tue, Nov 8, 2022 at 11:34 AM Tom Rini wrote: > Yes, it's CONFIG_SYS_TEXT_BASE -> CONFIG_TEXT BASE and I found that just > by doing 'make msc_sm2s_imx8mp_config oldconfig' :) Excellent, thanks for the help!

Re: u-boot-imx master-next CI failure

2022-11-08 Thread Fabio Estevam
Hi Tom, On Tue, Nov 8, 2022 at 9:56 AM Tom Rini wrote: > The problem is with msc_sm2s_imx8mp. I figured this out by running a > ./tools/moveconfig.py -s and waiting to see what got stuck and reading > the resulting /tmp/tmp.../.config file. That's good information. Thanks for narrowing it down

u-boot-imx master-next CI failure

2022-11-08 Thread Fabio Estevam
Would you have any suggestions? Thanks, Fabio Estevam

Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

2022-11-08 Thread Fabio Estevam
so i'd say go for the revert; which reduces use of the fifo back to just the > first byte Thanks for investigating it. I have sent the revert. Regards, Fabio Estevam

[PATCH] Revert "serial: mxc: have putc use the TXFIFO"

2022-11-08 Thread Fabio Estevam
From: Fabio Estevam This reverts commit c7878a0483c59c48a730123bc0f4659fd40921bf. Since commit c7878a0483c5 ("serial: mxc: have putc use the TXFIFO"), serial console corruption can be seen when priting inside board_init(). Revert it to avoid the regression. Reported-by: Tim Harv

Re: [PATCH v5 0/8] arm: dts: imx: sync device trees with upstream linux kernel part 1

2022-11-07 Thread Fabio Estevam
pointed out by Giulio. > - Add Tim's tested-by. Thanks! For the series: Reviewed-by: Fabio Estevam Thanks

Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

2022-11-07 Thread Fabio Estevam
Hi Johannes and Grygorii, On Thu, Nov 3, 2022 at 8:14 AM Fabio Estevam wrote: > There is a typo here: it should be mxc_serial_putc() instead. > > No, it does not fix the issue. > > Not sure why you mentioned imx6. The issue can be reproduced on imx8mm as > well. Do you plan

Re: [PATCH v2 0/8] imx8: switch missing boards to binman

2022-11-04 Thread Fabio Estevam
tch to binman > imx: imx8qm: imx8qm_mek switch to binman > imx: imx8qxp: giedi switch to binman > imx: imx8qxp: deneb switch to binman > imx: imx8x: colibri: switch to binman > imx: imx8: apalis: switch to binman Great work, thanks. This series looks good to me: Reviewed-

Re: [PATCH v1] imx: imx8: apalis: switch to binman

2022-11-04 Thread Fabio Estevam
Hi Oliver, On Fri, Nov 4, 2022 at 9:39 AM Oliver Graute wrote: > > Can't all boards use the common the binman nodes from > > arch/arm/dts/imx8qm-u-boot.dtsi instead? > > I'am about to try that but I run into the following error: > > binman: Filename 'spl/u-boot-spl.bin' not found in input path

[PATCH v2 2/2] wandboard: Select DM_SERIAL

2022-11-04 Thread Fabio Estevam
From: Fabio Estevam The conversion to DM_SERIAL is mandatory, so select this option. Signed-off-by: Fabio Estevam --- Changes since v1: - None configs/wandboard_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/wandboard_defconfig b/configs/wandboard_defconfig index

[PATCH v2 1/2] wandboard: Pass mmc aliases

2022-11-04 Thread Fabio Estevam
From: Fabio Estevam Originally, the mmc aliases node was present in imx6qdl-wandboard.dtsi. After the sync with Linux in commit d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with linux"), the aliases node is gone as the upstream version does not have it. This causes a

Re: [PATCH] mx6cuboxi: migrate to DM_SERIAL

2022-11-04 Thread Fabio Estevam
Hi Baruch, On Thu, Nov 3, 2022 at 1:04 PM Baruch Siach wrote: > > Add the needed DT overrides to enable UART in SPL. > > Cc: Fabio Estevam > Signed-off-by: Baruch Siach Thanks for the conversion: Reviewed-by: Fabio Estevam

[PATCH 2/2] wandboard: Select DM_SERIAL

2022-11-04 Thread Fabio Estevam
From: Fabio Estevam The conversion to DM_SERIAL is mandatory, so select this option. Signed-off-by: Fabio Estevam --- configs/wandboard_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/wandboard_defconfig b/configs/wandboard_defconfig index 70b4cf9ffaa3..33d9db56e1cb

[PATCH] wandboard: Pass mmc aliases

2022-11-04 Thread Fabio Estevam
From: Fabio Estevam Originally, the mmc aliases node was present in imx6qdl-wandboard.dtsi. After the sync with Linux in commit d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with linux"), the aliases node is gone as the upstream version does not have it. This causes a

Re: DM_SERIAL for i.MX6 Hummingboard/Cubox-i

2022-11-03 Thread Fabio Estevam
Hi Baruch, On Thu, Nov 3, 2022 at 12:33 PM Baruch Siach wrote: > Without any u-boot,dm-pre-reloc or u-boot,dm-spl? I don't see any for > wandboard DT files in current master. Correct, just passing CONFIG_DM_SERIAL=y boots fine on wandboard. It does not have a imx6qdl-wandboard-u-boot.dtsi

Re: DM_SERIAL for i.MX6 Hummingboard/Cubox-i

2022-11-03 Thread Fabio Estevam
On Thu, Nov 3, 2022 at 11:28 AM Fabio Estevam wrote: > > Hi Baruch, > > On Thu, Nov 3, 2022 at 11:15 AM Fabio Estevam wrote: > > > Please try using u-boot,dm-spl for all nodes instead. > > In addition to using u-boot,dm-spl, please try calling > spl_early_

Re: DM_SERIAL for i.MX6 Hummingboard/Cubox-i

2022-11-03 Thread Fabio Estevam
Hi Baruch, On Thu, Nov 3, 2022 at 11:15 AM Fabio Estevam wrote: > Please try using u-boot,dm-spl for all nodes instead. In addition to using u-boot,dm-spl, please try calling spl_early_init() like done here: https://source.denx.de/u-boot/u-boot/-/commit/7cf388fa6977136dd2384bd746d237efc306c829

Re: DM_SERIAL for i.MX6 Hummingboard/Cubox-i

2022-11-03 Thread Fabio Estevam
Hi Baruch, On Thu, Nov 3, 2022 at 11:06 AM Baruch Siach wrote: > I tried this (see below) but no luck yet. The tbs2910 appears not to use > SPL. I might be missing an SPL driver. That's a good point. imx8mm_evk_defconfig has been converted to DM_SERIAL and it uses SPL. > + { > +

Re: DM_SERIAL for i.MX6 Hummingboard/Cubox-i

2022-11-03 Thread Fabio Estevam
t,dm-pre-reloc; > +}; Here you also need to pass , _uart1, and Please look at the following commit for reference: commit 8fbca1a8b9b02fbc40147401d9af764e07dc96af Author: Fabio Estevam Date: Tue Mar 15 17:47:05 2022 -0300 tbs2910: Convert to DM_SERIAL Conversion to DM_SERIAL i

Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

2022-11-03 Thread Fabio Estevam
On Thu, Nov 3, 2022 at 3:17 AM SCHNEIDER Johannes wrote: > > Hi all, > > flushing and waiting... maybe you're onto something: what if one printf races > another since it thinks considers its buffer handed to the FIFO as "done" a > bit too soon? > > might the below variation on "waiting for the

Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

2022-11-02 Thread Fabio Estevam
On Wed, Nov 2, 2022 at 2:24 PM Pali Rohár wrote: > Hello! This log just cleanly shows that UART TX FIFO is either broken or > something drops its content prior all bytes are properly transmitted. > Dropping HW TX FIFO is on most UARTs possible by resetting registers or > reconfiguring buadrate.

Re: [PATCH v1] imx: imx8: apalis: switch to binman

2022-11-02 Thread Fabio Estevam
On Wed, Nov 2, 2022 at 12:59 PM Oliver Graute wrote: Please add a commit log. > Signed-off-by: Oliver Graute > + { > + > + itb { > + filename = "u-boot.itb"; > + > + fit { > + description = "Configuration to load ATF before > U-Boot"; >

Re: [PATCH 0/8] imx8: switch missing boards to binman

2022-11-02 Thread Fabio Estevam
On Wed, Nov 2, 2022 at 12:57 PM Oliver Graute wrote: > > This patchsets switches the remaining imx8 boards to binman. > > Oliver Graute (8): > imx: imx8qm-rom7720: switch to binman > imx: imx8qm: cgtqmx8: switch to binman > imx: imx8qxp: imx8qxp_mek switch to binman > imx: imx8qm:

Re: [PATCH v6] imx: imx8qm: cgtqmx8: switch to binman

2022-11-02 Thread Fabio Estevam
On Wed, Nov 2, 2022 at 11:42 AM Oliver Graute wrote: > I have these boards in mind for missing binman support: > > imx8qm-rom7720, cgtqmx8, imx8qxp, imx8qm_mek, giedi, deneb, > colibri_imx8x, apalis_imx8 > > After checking arch/arm/mach-imx/imx8/Kconfig and > arch/arm/mach-imx/imx8m/Kconfig I

<    4   5   6   7   8   9   10   11   12   13   >