[...]
>
>>
>> > str = "Unknown";
>> >
>> > for (;;) {
>> > @@ -151,8 +151,7 @@ static int smbios_add_prop_si(struct smbios_ctx *ctx,
>> > const char *prop,
>> > const char *str;
>> >
>> > str = ofnode_read_string(ctx->node, prop);
>> > -
at
already parsing for tpm_event_log_addr, which is what TF-A fills in.
In the future we need to add the bloblist option.
- Tell you whether you need to replay it or not.
Thanks
/Ilias
> Thanks and regards,
> Raymond
>
> On Mon, 4 Dec 2023 at 12:52, Ilias Apalodimas
> wrote:
>>
>> On
Hi Tom,
On Wed, 22 Nov 2023 at 16:28, Tom Rini wrote:
>
> On Wed, Nov 22, 2023 at 07:44:09PM +0530, Sumit Garg wrote:
> > On Wed, 22 Nov 2023 at 19:31, Tom Rini wrote:
> > >
> > > On Wed, Nov 22, 2023 at 11:51:29AM +0530, Sumit Garg wrote:
> > > > Hi Caleb,
> > > >
> > > > On Tue, 21 Nov 2023
Hi Caleb,
Late to the party, but I'll respond to as much as I can
On Tue, 21 Nov 2023 at 19:09, Caleb Connolly wrote:
>
> Historically, Qualcomm boards in U-Boot have all had their own
> board/qualcomm/xyz directory, their own CONFIG_TARGET_XYZ option, their
> own hardcoded sysmap-xyz.c file,
Hi Simon,
On Wed, 6 Dec 2023 at 05:57, Simon Glass wrote:
>
> Hi Ilias,
>
> On Mon, 4 Dec 2023 at 23:22, Ilias Apalodimas
> wrote:
> >
> > Hi Simon,
> >
> > We did discuss this in OSFC but perhaps you forgot. The discussion
> > was based on the ma
Hello Akashi-san,
Thanks for taking a shot at the cleanup
On Tue, 21 Nov 2023 at 06:53, AKASHI Takahiro
wrote:
>
> Hi Heinrich,
>
> On Tue, Nov 21, 2023 at 04:31:40AM +0100, Heinrich Schuchardt wrote:
> > On 11/21/23 02:29, AKASHI Takahiro wrote:
> > > Replicate some code and re-organize
Hi Simon,
We did discuss this in OSFC but perhaps you forgot. The discussion
was based on the mail here [0].
On Tue, 5 Dec 2023 at 02:52, Simon Glass wrote:
>
> Hi Raymond,
>
> On Mon, 4 Dec 2023 at 12:25, Raymond Mao wrote:
> >
> > Hi Simon,
> >
> > When `OF_BOARD` is defined, the FDT should
},
> > { BLOBLISTT_TCPA_LOG, "TPM log space" },
> >- { BLOBLISTT_ACPI_TABLES, "ACPI tables for x86" },
> >+ { BLOBLISTT_ACPI_GNVS, "ACPI GNVS" },
>
> Thanks and regards,
> Raymond
>
> On Mon, 4 Dec 202
Hi Simon
On Sun, 3 Dec 2023 at 19:44, Simon Glass wrote:
>
> Hi Heinrich, Ilias,
>
> I had a bit of a look at how memory is allocated in EFI.
>
> I see that efi_memory_init() is called quite early in U-Boot. It
> sometimes allocates memory for a bounce buffer, placing it somewhere
> in memory.
otefi.c| 5 --
> lib/efi_loader/efi_load_initrd.c | 82 +---
> 2 files changed, 55 insertions(+), 32 deletions(-)
Reviewed-by: Ilias Apalodimas
Tested-by: Ilias Apalodimas
>
> diff --git a/cmd/bootefi.c b/cmd/bootefi.c
> index 4d7496
I just noticed that's fixed in path #12
On Mon, 4 Dec 2023 at 10:36, Ilias Apalodimas
wrote:
>
> On Mon, 27 Nov 2023 at 21:52, Raymond Mao wrote:
> >
> > From: Simon Glass
> >
> > There is no flags value in spec v0.9 so drop it.
> >
> >
* blobs can be altered after being created, this checksum is only valid
> + * when the bloblist is finalised before jumping to the next stage of
> boot.
> + * This is the value needed to make all chechksummed bytes sum to 0
typos checksummed and finalized
[...]
With the typos fixed
Reviewed-by: Ilias Apalodimas
On Mon, 27 Nov 2023 at 21:52, Raymond Mao wrote:
>
> From: Simon Glass
>
> There is no flags value in spec v0.9 so drop it.
>
> For now it is still present in the header, with an underscore, so that
> tests continue to pass.
Why? Can't we drop it overall?
Thanks
/Ilias
>
> Signed-off-by:
On Mon, 27 Nov 2023 at 21:52, Raymond Mao wrote:
>
> From: Simon Glass
>
> These values currently use a simple field. With spec v0.9 they have moved
> to a packed format. Convert most accesses to use functions, so this change
> can be accommodated.
I don't really understand how the commit
ude/bloblist.h
> @@ -74,7 +74,7 @@
> #include
>
> enum {
> - BLOBLIST_VERSION= 0,
> + BLOBLIST_VERSION= 1,
> BLOBLIST_MAGIC = 0x6ed0ff,
>
> BLOBLIST_ALIGN_LOG2 = 3,
> --
> 2.25.1
>
Reviewed-by: Ilias Apalodimas
75,7 @@
> >
> > enum {
> > BLOBLIST_VERSION= 0,
> > - BLOBLIST_MAGIC = 0xb00757a3,
> > + BLOBLIST_MAGIC = 0x6ed0ff,
> >
> > BLOBLIST_ALIGN_LOG2 = 3,
> > BLOBLIST_ALIGN = 1 << BLOBLIST_ALIGN_LOG2,
> > --
> > 2.25.1
> >
>
> Regards,
> Simon
>
> [1] https://github.com/FirmwareHandoff/firmware_handoff/pull/24
With this change
Reviewed-by: Ilias Apalodimas
Hi all,
[...]
> common/bloblist.c | 16 +---
> include/bloblist.h | 65 --
> test/bloblist.c| 4 +--
> 3 files changed, 48 insertions(+), 37 deletions(-)
>
> diff --git a/common/bloblist.c b/common/bloblist.c
> index
Akashi-san
On Mon, 4 Dec 2023 at 03:58, AKASHI Takahiro wrote:
>
> Hi Heinrich, Ilias
>
> On Tue, Nov 21, 2023 at 10:29:38AM +0900, AKASHI Takahiro wrote:
> > This patch set is motivated by the discussion[1] regarding
> > CONFIG_BOOTEFI_BOOTMGR option.
> >
> > At the end, bootefi.c will be
Hi Sean,
On Tue, Sep 12, 2023 at 02:47:25AM -0700, seanedm...@linux.microsoft.com wrote:
> From: Stephen Carlson
>
> This implementation of the rollback uclass driver allows existing TPM2
> devices declared in the device tree to be referenced for storing the OS
> anti-rollback counter, using
Hi Sean,
Apologies for the very late reply.
Simon, can you have a look since this is mostly the DM part?
On Tue, Sep 12, 2023 at 02:47:24AM -0700, seanedm...@linux.microsoft.com wrote:
> From: Stephen Carlson
>
> Rollback devices currently implement operations to store an OS
> anti-rollback
Hi Shantur
I have a few remarks on the architecture.
Up to now, we are supporting
1. Variables on a file
2. Variables on an RPMB
The reason those two are in different files is that we generally
expect to use different bootime services and few differences in
efi_variables_boot_exit_notify() and
Hi Simon,
[...]
> Changes since v1:
> > - Tokenize the DT node entry and use the appropriate value instead of
> > the entire string
> > - Removed Peters tested/reviewed-by tags due to the above
> > lib/smbios.c | 94 +---
> > 1 file changed, 90
Hi Simon,
On Thu, 30 Nov 2023 at 04:46, Simon Glass wrote:
> Hi Ilias,
>
> On Mon, 27 Nov 2023 at 10:11, Ilias Apalodimas
> wrote:
> >
> > If a value is not valid during the DT or SYSINFO parsing, we explicitly
> > set that to "Unknown Pro
a/lib/Kconfig
> > +++ b/lib/Kconfig
> > @@ -477,6 +477,13 @@ config VPL_TPM
> > for the low-level TPM interface, but only one TPM is supported
> at
> > a time by the TPM library.
> >
> > +config KASLR_RNG_SEED
> > + bool "Use RNG driver for KASLR random seed"
> > + depends on DM_RNG
> > + help
> > + This enables support for using the RNG driver as entropy
> source for
> > + KASLR seed populated in kernel's device tree.
> > +
> > endmenu
> >
> > menu "Android Verified Boot"
> > --
> > 2.42.0
> >
>
Reviewed-by: Ilias Apalodimas
Hi Heinrich,
On Wed, 29 Nov 2023 at 03:26, Heinrich Schuchardt wrote:
>
> On 11/28/23 20:10, Ilias Apalodimas wrote:
> > commit 239d59a65e20 ("efi_loader: reconnect drivers on failure")
> > tried to fix the UninstallProtocol interface which must reconnect
> &g
connection in efi_uninstall_protocol() were it belongs.
Fixes: commit 239d59a65e20 ("efi_loader: reconnect drivers on failure")
Signed-off-by: Ilias Apalodimas
---
Apologies for the fast resend, but since Heinrich reviewed it and
we want it in 2024.01 resending
Changes since v1:
- return ret instead of (ret
Hi Heinrich
On Tue, 28 Nov 2023 at 18:30, Heinrich Schuchardt wrote:
>
> On 28.11.23 16:45, Ilias Apalodimas wrote:
> > commit 239d59a65e20 ("efi_loader: reconnect drivers on failure")
> > tried to fix the UninstallProtocol interface which must reconnect
> &g
connection in efi_uninstall_protocol() were it belongs.
Fixes: commit 239d59a65e20 ("efi_loader: reconnect drivers on failure")
Signed-off-by: Ilias Apalodimas
---
Heinrich this is critical. Although it doesn't break anything on our normal
use cases it does break the ACS testing for SystemReady-IR
spberry Pi 4 Model B Rev 1.1
Version: Unknown
Serial Number: 1bb24ceb
UUID: 30303031-3030-3030-3061-613234636435
Wake-up Type: Reserved
SKU Number: Unknown
Family: Unknown
[...]
Signed-off-by: Ilias Apalodimas
---
Changes since v1:
- Tokeni
-up Type: Reserved
SKU Number: Unknown
Family: Unknown
[...]
Signed-off-by: Ilias Apalodimas
Reviewed-by: Peter Robinson
Tested-by: Peter Robinson
---
Changes since v1:
- None
lib/smbios.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/lib
is that model doesn't
always include the manufacturer despite the suggestions of the DT spec.
[0]
https://lore.kernel.org/u-boot/20220906134426.53748-1-ilias.apalodi...@linaro.org/
Ilias Apalodimas (2):
smbios: Simplify reporting of unknown values
smbios: Fallback to the default DT if sysinfo nodes
On Mon, 27 Nov 2023 at 11:31, Shantur Rathore wrote:
>
> Hi Ilias,
>
> On Mon, Nov 27, 2023 at 7:09 AM Ilias Apalodimas
> wrote:
> >
> > Hi Shantur
> >
> > Please don't send a v2 unless the v1 discussion has settled. It just
> > makes life ha
Hi Shantur
On Sun, 26 Nov 2023 at 12:33, Shantur Rathore wrote:
>
> Hi Peter,
>
> On Sat, Nov 25, 2023 at 6:19 AM Peter Robinson wrote:
> >
> > Hi Shantur,
> >
> > On Fri, Nov 24, 2023 at 11:55 PM Shantur Rathore wrote:
> > >
> > > Hi Ili
Hi Shantur
Please don't send a v2 unless the v1 discussion has settled. It just
makes life harder. I'll ignore v2 for now and respond here.
[...]
>
> >
> > > + if (ret)
> > > + goto error;
> > > +
> > > + ret = spi_flash_erase_dm(sfdev, CONFIG_EFI_VARIABLE_SF_OFFSET,
Hi Shantur
On Fri, 24 Nov 2023 at 18:51, Shantur Rathore wrote:
>
> Hi Heinrich,
>
> I am trying to work out how to enable the SetVariableRT service in
> U-Boot and came across your patch [1] which initially had the
> SetVariable RT service enabled in EFI but in the final patch this was
>
ething has changed on the patch
Thanks
/Ilias
>
>
>
> Sean
>
> On 2023-11-17 11:33 p.m., Ilias Apalodimas wrote:
>
> Hi Sean
> There are a few reviewed-by tags missing since v3/v4. Any reason you
> dropped those? The change log doesn't mention anything
>
> Thanks
>
rich Schuchardt
> Cc: Ilias Apalodimas
> ---
> include/efi_loader.h | 1 -
> lib/efi_loader/dtbdump.c | 1 -
> lib/efi_loader/efi_acpi.c | 1 -
> lib/efi_loader/efi_bootmgr.c | 1 -
> lib/efi_loader/efi_boott
Hi Tom,
The following changes since commit dca7a8958f8d0dbd53072caa4353353e062d80ca:
Merge tag 'v2024.01-rc3' into next (2023-11-20 09:19:50 -0500)
are available in the Git repository at:
https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm-next-22112023
for you to fetch changes
Hi Simon,
On Wed, 22 Nov 2023 at 00:10, Simon Glass wrote:
>
> Hi Heinrich,
>
> On Tue, 21 Nov 2023 at 10:17, Heinrich Schuchardt wrote:
> >
> > On 11/21/23 12:35, Simon Glass wrote:
> > > This allows testing of the exit_boot_services call, providing more
> > > coverage of the EFI bootmeth.
> >
Hi all,
On Wed, 22 Nov 2023 at 07:23, Sughosh Ganu wrote:
>
> hi Simon,
>
> On Wed, 22 Nov 2023 at 03:42, Simon Glass wrote:
> >
> > Hi Sughosh,
> >
> > On Tue, 21 Nov 2023 at 00:02, Sughosh Ganu wrote:
> > >
> > > Add support for specifying the parameters needed for capsule
> > > generation
Hi Shahtur
On Wed, 22 Nov 2023 at 01:58, Shantur Rathore wrote:
>
> Currently U-boot uses ESP as storage for EFI variables.
> Devices with SPI Flash are used for storing environment with this
> commit we allow EFI variables to be stored on SPI Flash.
>
> Signed-off-by: Shantur Rathore
> ---
>
>
6 months from now?
Mention that this fixes 53fab13a7 ("efi: Use the installed SMBIOS
tables") and keeps the x86 changes while reverting back to allocate
memory < 4GB
Other than that
Reviewed-by: Ilias Apalodimas
Tested-by: Ilias Apalodimas
Thanks
/Ilias
>
> Signed
Hi Simon,
On Tue, 21 Nov 2023 at 04:58, Simon Glass wrote:
>
> U-Boot typically sets up its malloc() pool near the top of memory. On
> ARM64 systems this can result in an SMBIOS table above 4GB which is
> not supported by SMBIOSv2.
>
> Work around this problem by automatically choosing an
Hi Simon
On Tue, 21 Nov 2023 at 04:17, Simon Glass wrote:
>
> Hi Heinrich,
>
> On Mon, 20 Nov 2023 at 19:11, Heinrich Schuchardt wrote:
> >
> > On 10/15/23 04:45, Simon Glass wrote:
> > > When the SMBIOS table is written to an address above 4GB a 32-bit table
> > > address is not large enough.
uot;, tab->table, guid_str,
> + printf("%p %pUl %s\n", tab->table, tab->guid.b,
> uuid_guid_get_str(tab->guid.b) ?: "(unknown)");
> }
> }
> --
> 2.42.0.869.gea05f2083d-goog
>
Reviewed-by: Ilias Apalodimas
r initializing the
> configuration.
> +E.g.
> +
> +.. code-block:: bash
> +
> +make qemu-riscv64_smode_defconfig acpi.config
> diff --git a/doc/board/emulation/index.rst b/doc/board/emulation/index.rst
> index 932c65adeb..d3d6b8f3d8 100644
> --- a/doc/board/emulation/i
eed to do this bypass, so adjust it to
> simply use the puts() function.
>
> Signed-off-by: Simon Glass
Reviewed-by: Ilias Apalodimas
> ---
>
> lib/efi_loader/efi_console.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/efi_loader/efi_
Hi Neil,
On Tue, 21 Nov 2023 at 16:43, Neil Armstrong wrote:
>
> On 21/11/2023 15:09, Tom Rini wrote:
> > On Tue, Nov 21, 2023 at 02:46:29PM +0100, Neil Armstrong wrote:
> >> On 21/11/2023 14:15, Tom Rini wrote:
> >>> On Tue, Nov 21, 2023 at 10:18:04AM +0100, Neil Armstrong wrote:
> Hi Tom,
ts, try
> > to use the RSDT table.
> >
> > Signed-off-by: Heinrich Schuchardt
> > ---
> > v2:
> > consider that map_sysmem(0, 0) != NULL
> > ---
> > lib/acpi/acpi.c | 20
> > 1 file changed, 16 insertions(+), 4 deletions(-)
>
> Reviewed-by: Simon Glass
Reviewed-by: Ilias Apalodimas
Hi Simon,
On Sat, 18 Nov 2023 at 23:06, Simon Glass wrote:
>
> Move the argument decoding to the caller, to avoid needing to pass the
> command-line arguments.
>
> Add a function comment while we are here.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Tom Rini
> ---
>
> (no changes since v1)
Reviewed-by: Tom Rini
Reviewed-by: Ilias Apalodimas
> ---
>
> (no changes since v1)
>
> env/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/env/mmc.c b/env/mmc.c
> index cb14bbb58f13..da84cddd74f0 100644
> --- a/env/mmc.c
> +++ b/e
Hi Simon,
On Sat, Nov 11, 2023 at 05:43:37PM -0700, Simon Glass wrote:
> Some of the Python tests are a pain because they don't reset the TPM
> state before each test. Driver model tests do this, so convert the
> tests to C.
The python tests restart u-boot though. The problem is a bit different
h *)buf);
> + dp = efi_dp_shorten(dp_volume);
> + if (!dp)
> + dp = dp_volume;
> + dp = efi_dp_append(dp, >dp);
> free(buf);
>
> return dp;
> --
> 2.40.1
>
Reviewed-by: Ilias Apalodimas
Hi Mark,
On Sun, 19 Nov 2023 at 19:38, Mark Kettenis wrote:
>
> > Date: Sat, 18 Nov 2023 23:52:11 +0100
> > From: Heinrich Schuchardt
>
> Hi Heinrich,
>
> > On 11/18/23 22:28, Shantur Rathore wrote:
> > > Hi Heinrich,
> > >
> > > On Fri, Nov 17, 2023 at 3:12 PM Heinrich Schuchardt
> > > wrote:
Hi Simon,
Thanks for looping me in
On Sat, 18 Nov 2023 at 19:11, Simon Glass wrote:
>
> +Ilias too as this involves a design decision
>
> Hi Shantur,
>
> On Fri, 17 Nov 2023 at 14:22, Shantur Rathore wrote:
> >
> > efi_set_bootdev is already called as part of tftp while doing dhcp_run()
>
> Is
Hi Tom,
The following changes since commit ae7ec8b0be41b59ef323f7531c0fe6745e8fef45:
Merge branch '2023-11-16-assorted-updates' into next (2023-11-17 08:38:05
-0500)
are available in the Git repository at:
https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/efi-next-18112023
for
On Thu, 16 Nov 2023 at 06:11, Simon Glass wrote:
>
> This function does not use its arguments. Drop them.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Tom Rini
> ---
Reviewed-by: Ilias Apalodimas
>
> (no changes since v1)
>
> boot/bootm.c | 5 ++---
> 1
On Thu, 16 Nov 2023 at 06:11, Simon Glass wrote:
>
> Add a dm/uclass-id.h to the bootdev header file, since it uses
> enum uclass_id
>
> Signed-off-by: Simon Glass
Reviewed-by: Ilias Apalodimas
> ---
>
> (no changes since v1)
>
> include/bootdev.h | 1 +
quired.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Tom Rini
> ---
Reviewed-by: Ilias Apalodimas
>
> (no changes since v1)
>
> board/freescale/common/vid.c | 2 +-
> board/xilinx/common/fru.c| 2 +-
> board/xilinx/versal/cmds.c | 2 +-
>
>
> (no changes since v1)
>
> arch/arm/cpu/u-boot.lds | 3 ---
> arch/x86/cpu/u-boot-64.lds | 4
> arch/x86/cpu/u-boot-spl.lds | 4
> arch/x86/cpu/u-boot.lds | 4
> 4 files changed, 15 deletions(-)
Reviewed-by: Ilias Apalodimas
>
> diff --git a/arc
Hi Heinrich
On Fri, 17 Nov 2023 at 01:08, Heinrich Schuchardt
wrote:
>
> The boot options created by eficonfig should use shortened device-paths to
> avoid problems if drives are enumerated in a different sequence.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> cmd/eficonfig.c | 1 +
> 1 file
Hi Sean
There are a few reviewed-by tags missing since v3/v4. Any reason you
dropped those? The change log doesn't mention anything
Thanks
/Ilias
On Fri, 17 Nov 2023 at 04:02, wrote:
>
> From: Dhananjay Phadke
>
> Add support for KASLR seed from the RNG device. Invokes dm_rng_read()
> API to
On Fri, 10 Nov 2023 at 15:12, Heinrich Schuchardt wrote:
>
>
>
> Am 10. November 2023 11:04:24 MEZ schrieb Ilias Apalodimas
> :
> >Hi Heinrich, Weizhao
> >
> >On Thu, 9 Nov 2023 at 15:57, Heinrich Schuchardt wrote:
> >>
> >> On 11/9/23 04
Hi Heinrich
On Mon, 13 Nov 2023 at 09:37, Heinrich Schuchardt wrote:
>
> On 11/7/23 18:36, Ilias Apalodimas wrote:
> > Looking back at the initrd storing functionality, we introduced three
> > functions, efi_dp_append_or_concatenate(), efi_dp_append/concat(). In
> >
1 file changed, 3 deletions(-)
> >
>
> Reviewed-by: Simon Glass
Reviewed-by: Ilias Apalodimas
Hi Heinrich, Weizhao
On Thu, 9 Nov 2023 at 15:57, Heinrich Schuchardt wrote:
>
> On 11/9/23 04:55, Weizhao Ouyang wrote:
> > Correct some UEFI variable error handing code paths.
> >
> > Signed-off-by: Weizhao Ouyang
> > ---
> > lib/efi_loader/efi_var_file.c | 1 +
> >
On Fri, 10 Nov 2023 at 06:27, Masahisa Kojima
wrote:
>
> This adds the description about HTTP Boot.
>
> Signed-off-by: Masahisa Kojima
> Reviewed-by: Ilias Apalodimas
> ---
> doc/develop/uefi/uefi.rst | 30 ++
> 1 file changed, 30 insertions
he ramdisk to the OS.
> For PE-COFF file case, this memory reservation is done
> in LoadImage Boot Service.
>
> Signed-off-by: Masahisa Kojima
> Reviewed-by: Ilias Apalodimas
> ---
[...]
> +
> +/**
> + * efi_bootmgr_image_return_notify() - return to efibootmgr callbac
FI_OUT_OF_RESOURCES;
> + goto err;
> + }
> +
> + ret = EFI_CALL(root->open(root, , default_file_name,
> + EFI_FILE_MODE_READ, 0));
> + efi_free_pool(default_file_name);
> + if (ret != EFI_SUCCESS)
> + goto err;
> +
> + EFI_CALL(f->close(f));\
This closes the file correctly, but the volume is still open. Don't we need
EFI_CALL(root->close(root) as well?
[...]
With the above fixed
Reviewed-by: Ilias Apalodimas
loading ISO image file
> > or EFI application through network. Currently HTTP is only supported.
> >
> > Signed-off-by: Masahisa Kojima
> > Acked-by: Ilias Apalodimas
> > ---
> > cmd/efidebug.c | 51
Kojima-san
[...]
> > > + * @dev: pointer to the UCLASS_BLK or UCLASS_PARTITION udevice
> > > + * @dp:pointer to default file device path
> > > + * Return: status code
> > > + */
> > > +static efi_status_t search_default_file(struct udevice *dev,
> > > +
Hi
I am late to the party but
[...]
> > I can't help to think that you like the FDT as a well understood and
> > flexible general purpose data structure. And it can indeed be used as a
> > configuration file, especially since you have the parser in your code
> > already - the FIT image is a good
() to efi_dp_concat(). This is far more
intuitive and the only adjustment that is needed is an extra boolean
argument on all callsites.
Signed-off-by: Ilias Apalodimas
---
Kojima-san, I think this might affect your EFI HTTP boot series.
I don't mind waiting for this and merging it after your
The result of efi_append_scrtm_version() is overwritten before anyone
checks its result. Check it and exit the function on failures
Addresses-Coverity-ID: 467399 Code maintainability issues (UNUSED_VALUE)
Fixes: commit 97707f12fdab ("tpm: Support boot measurements")
Signed-off
Hi Tom,
Thanks for the report.
Eddie, can you please check the TCG related ones?
Thanks
/Ilias
On Mon, 6 Nov 2023 at 22:27, Tom Rini wrote:
>
> Hey all,
>
> Here's the latest report. I _think_ I passed the right options to
> get_maintainer.pl such that it would only look far enough back in git
Kojima-san
On Mon, 6 Nov 2023 at 13:40, Masahisa Kojima wrote:
[...]
> +/**
> + * search_default_file() - search default file
> + *
> + * @dev: pointer to the UCLASS_BLK or UCLASS_PARTITION udevice
> + * @dp:pointer to default file device path
> + * Return: status code
se to copy any runtime variables, before booting an
OS.
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/Kconfig | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
index 4ccd26f94a93..0d024911b42e 100644
--- a/lib/
Hi all,
On Fri, 3 Nov 2023 at 21:17, Simon Glass wrote:
>
> Hi,
>
> On Mon, 23 Oct 2023 at 11:06, Mark Kettenis wrote:
> >
> > > Date: Mon, 23 Oct 2023 12:34:55 -0400
> > > From: Tom Rini
> > >
> > > On Mon, Oct 23, 2023 at 05:37:34PM +0200, Mark Kettenis wrote:
> > > > > From: Simon Glass
>
Hi Simon
On Fri, 3 Nov 2023 at 21:17, Simon Glass wrote:
>
> Hi,
>
> On Mon, 23 Oct 2023 at 11:06, Mark Kettenis wrote:
> >
> > > Date: Mon, 23 Oct 2023 12:34:55 -0400
> > > From: Tom Rini
> > >
> > > On Mon, Oct 23, 2023 at 05:37:34PM +0200, Mark Kettenis wrote:
> > > > > From: Simon Glass
>
Hi Kojima-san
> +
> +/**
> + * try_load_default_file() - try to load the default file
> + *
> + * Search the device having EFI_SIMPLE_FILE_SYSTEM_PROTOCOL,
> + * then try to load with the default boot file(e.g. EFI/BOOT/BOOTAA64.EFI).
> + *
> + * @devpointer to the
> EFI_EVENT_GROUP_RESET_SYSTEM;
> +/* event group return to efibootmgr */
> +const efi_guid_t efi_guid_event_group_return_to_efibootmgr =
> + EFI_EVENT_GROUP_RETURN_TO_EFIBOOTMGR;
> /* GUIDs of the Load File and Load File2 protocols */
> const efi_guid_t efi_guid_load_file_protocol = EFI_LOAD_FILE_PROTOCOL_GUID;
> const efi_guid_t efi_guid_load_file2_protocol = EFI_LOAD_FILE2_PROTOCOL_GUID;
> --
> 2.34.1
>
Now that we have the event we have touse it for loadfie2 in the future
Reviewed-by: Ilias Apalodimas
efi_bootmgr.c | 268 ++
> lib/efi_loader/efi_boottime.c | 7 +-
> lib/efi_loader/efi_disk.c | 18 ++
> lib/efi_loader/efi_setup.c| 7 +
> net/wget.c| 205 +-
> test/py/tests/test_efi_secboot/test_signed.py | 42 +--
> .../test_efi_secboot/test_signed_intca.py | 14 +-
> .../tests/test_efi_secboot/test_unsigned.py | 14 +-
> .../test_fs/test_squashfs/test_sqfs_ls.py | 6 +
> 20 files changed, 747 insertions(+), 62 deletions(-)
> create mode 100644 drivers/block/blkmap_helper.c
>
> --
> 2.34.1
>
For the series
Tested-by: Ilias Apalodimas
void *notify_context,
> - efi_guid_t *event_group,
> + const efi_guid_t *event_group,
> struct efi_event **event)
> {
> efi_status_t ret;
> --
> 2.34.1
>
Reviewed-by: Ilias Apalodimas
Thanks Simon,
Apart from a nit in patch#2 this looks good.
Pleas note that this doesn't apply on -master so please rebase
On Sun, 29 Oct 2023 at 06:28, Simon Glass wrote:
>
> This series is a starting point only. It tries to provide some direction
> for how the TPM tests should be run on real
;
> @@ -188,9 +169,6 @@ def test_tpm2_pcr_read(u_boot_console):
>
> Perform a PCR read of the 0th PCR. Must be zero.
> """
> -if is_sandbox(u_boot_console):
> -tpm2_sandbox_init(u_boot_console)
> -
> force_init(u_boot_console)
> ram = u_boot_utils.find_ram_base(u_boot_console)
>
> @@ -217,8 +195,6 @@ def test_tpm2_pcr_extend(u_boot_console):
> No authentication mechanism is used here, not protecting against packet
> replay, yet.
> """
> -if is_sandbox(u_boot_console):
> -tpm2_sandbox_init(u_boot_console)
> force_init(u_boot_console)
> ram = u_boot_utils.find_ram_base(u_boot_console)
>
> --
> 2.42.0.820.g83a721a137-goog
>
With this rebased on top of patch #2 & master
Reviewed-by: Ilias Apalodimas
Hi Simon,
Thanks for fixing this.
On Sun, 29 Oct 2023 at 06:28, Simon Glass wrote:
>
> Some of the Python tests are a pain because they don't reset the TPM
> state before each test. Driver model tests do this, so convert the
> tests to C.
>
> This means that these tests won't run on real
Hi Tom
On Sun, 29 Oct 2023 at 16:33, Tom Rini wrote:
>
> On Sun, Oct 29, 2023 at 05:28:13PM +1300, Simon Glass wrote:
>
> > Some of the Python tests are a pain because they don't reset the TPM
> > state before each test. Driver model tests do this, so convert the
> > tests to C.
> >
> > This
*recv_len = 12;
> memset(recvbuf, '\0', *recv_len);
> --
> 2.42.0.820.g83a721a137-goog
>
Reviewed-by: Ilias Apalodimas
Hi Simon
On Fri, Oct 27, 2023, 22:15 Simon Glass wrote:
> Hi Ilias,
>
> On Wed, 25 Oct 2023 at 18:23, Simon Glass wrote:
> >
> > Hi Ilias,
> >
> > On Wed, 25 Oct 2023 at 07:25, Ilias Apalodimas
> > wrote:
> > >
> > > commit 789e
Simon,
I've reviewed patch#2 which I had some concerns and it looks ok.
The series is assigned to me but you've reviewed the vast majority of the
patchset. Will you send ti via the -dm tree or shall I pick it up?
Thanks
/Ilias
On Tue, Sep 12, 2023 at 02:34:59PM -0700,
driver for KASLR random seed"
> + depends on DM_RNG
> + help
> + This enables support for using the RNG driver as entropy source for
> + KASLR seed populated in kernel's device tree.
> +
> endmenu
>
> menu "Android Verified Boot"
> --
> 2.40.0
>
Reviewed-by: Ilias Apalodimas
Akashi-san
On Thu, 26 Oct 2023 at 08:31, AKASHI Takahiro
wrote:
>
> Carve binary execution code out of do_bootefi_image().
Patch looks correct, but please update with the reasons for this.
Thanks
/Ilias
>
> Signed-off-by: AKASHI Takahiro
> ---
> cmd/bootefi.c | 46
++ b/lib/Kconfig
> @@ -74,6 +74,13 @@ config HAVE_PRIVATE_LIBGCC
> config LIB_UUID
> bool
>
> +config RANDOM_UUID
> + bool "GPT Random UUID generation"
> + select LIB_UUID
> + help
> + Enable the generation of partitions with random UUIDs if none
> + are provided.
> +
> config SPL_LIB_UUID
> depends on SPL
> bool
> --
> 2.34.1
>
Reviewed-by: Ilias Apalodimas
Akashi-san
On Fri, 27 Oct 2023 at 04:00, Tom Rini wrote:
>
> On Fri, Oct 27, 2023 at 09:25:44AM +0900, AKASHI Takahiro wrote:
> > On Thu, Oct 26, 2023 at 01:01:52PM +0200, Heinrich Schuchardt wrote:
> > > On 10/26/23 07:30, AKASHI Takahiro wrote:
> > > > Unfold do_bootefi_image() into
ox: Update for needed TPM2 capabilities
tpm: Support boot measurements
bootm: Support boot measurement
test: Add sandbox TPM boot measurement
doc: Add measured boot documentation
Ilias Apalodimas (3):
efi_loader: fix EFI_ENTRY point on get_active_pcr_banks
test: use a
Hi Heinrich
On Thu, 19 Oct 2023 at 21:22, Heinrich Schuchardt wrote:
>
> On 10/19/23 18:21, Eddie James wrote:
> > Briefly describe the feature and specify the requirements.
> >
> > Signed-off-by: Eddie James
> > Reviewed-by: Simon Glass
> > ---
> > Changes since v12:
> > - Add a bit of
On Fri, 27 Oct 2023 at 03:21, Masahisa Kojima
wrote:
>
> Hi Ilias,
>
> On Fri, 27 Oct 2023 at 03:58, Ilias Apalodimas
> wrote:
> >
> > On Wed, 25 Oct 2023 at 09:52, Masahisa Kojima
> > wrote:
> > >
> > > There are two kinds of NOR flas
Kojima-san,
Thanks the device path handling seems saner in this version.
On Wed, 25 Oct 2023 at 09:30, Masahisa Kojima
wrote:
>
> This supports to boot from the URI device path.
> When user selects the URI device path, bootmgr downloads
> the file using wget into the address specified by
7)) {
> + log_err("only http:// is supported\n");
> + return false;
> + }
> + str_copy = strdup(uri);
> + if (!str_copy)
> + return false;
> +
> + s = str_copy + strlen("http://;);
> + authority
; Write the FIP image to the Bank-0 & 1 at 6MB and 10MB offset.::
>
> - flash rawwrite 60 18
> - flash rawwrite a0 18
> + flash rawwrite 60 40
> + flash rawwrite a0 40
>>> Send SPI_NOR_NEWFIP.fd via XMODEM (Control-A S in minicom) <<
>
>flash rawwrite 50 1000
> --
> 2.34.1
>
Reviewed-by: Ilias Apalodimas
401 - 500 of 2169 matches
Mail list logo
