[U-Boot] [PATCH v2 11/19] net: Add default flags for common net env vars

2015-04-28 Thread Joe Hershberger
Check that the common network stack's env vars conform to the proper format for IP addresses. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v2: None include/env_flags.h | 12 +++- 1 file changed, 11 insertions(+), 1

[U-Boot] [PATCH v2 07/19] env: Add regex support to env_attrs

2015-04-28 Thread Joe Hershberger
Allow the features that use env_attrs to specify regexs for the name Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v2: -Added description to README README | 8 + common/env_attr.c | 85

[U-Boot] [PATCH v2 14/19] test: Return values from the asserts compatible with cmds

2015-04-28 Thread Joe Hershberger
The asserts are sometimes called from the context of the test command itself so make sure that a return that happens as a result of a failure is compatible with that command return. When called within a test, the return value is ignored. Signed-off-by: Joe Hershberger joe.hershber...@ni.com

[U-Boot] [PATCH v2 04/19] env: Fix return values in env_attr_lookup()

2015-04-28 Thread Joe Hershberger
This function returned numbers for error codes. Change them to error codes. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v2: None common/env_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[U-Boot] [PATCH v2 16/19] test: env: Add test for verifying env attrs

2015-04-28 Thread Joe Hershberger
Add a test of the env_attr_lookup() function. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v2: -New for version 2 test/env/Makefile | 1 + test/env/attr.c | 62 +++ 2 files changed, 63 insertions(+) create mode

[U-Boot] [PATCH v2 15/19] test: env: Add test framework for env

2015-04-28 Thread Joe Hershberger
Add a new test subcommand to the env command. This will run unit tests on the env code. This should be targetable to any device that supports the env features needed for the tests. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v2: -New for version 2 Makefile

[U-Boot] [PATCH] dm: core: Fix regression caused by c1d6f91

2015-04-28 Thread Joe Hershberger
tests started failing with a probe error -22 in the dm_test_children test. Test: dm_test_children test/dm/core.c:544, dm_test_children(): 0 == ret: Expected 0, got -22 This restores the original behavior which would avoid a probe on invalid device pointers. Signed-off-by: Joe Hershberger

Re: [U-Boot] [PATCH] dm: core: Fix regression caused by c1d6f91

2015-04-29 Thread Joe Hershberger
Hi Simon, On Wed, Apr 29, 2015 at 8:30 AM, Simon Glass s...@chromium.org wrote: Hi Joe, On 28 April 2015 at 22:14, Joe Hershberger joe.hershber...@ni.com wrote: The change to refactor these functions created a regression. commit c1d6f91952d0761f61b0f0f96e4c7aa32eee2788 Author: Przemyslaw

Re: [U-Boot] [PATCH v2] net/phy: refactor RTL8211F initialization

2015-04-27 Thread Joe Hershberger
On Fri, Apr 24, 2015 at 3:57 AM, Shengzhou Liu shengzhou@freescale.com wrote: RTL8211F needs to enalbe TXDLY for RGMII during phy initialization, so move it to rtl8211f_config for early initialization. Signed-off-by: Shengzhou Liu shengzhou@freescale.com cc: Joe Hershberger

Re: [U-Boot] [PATCH 09/11] net: Apply default format rules to all ethaddr

2015-04-27 Thread Joe Hershberger
Hi Simon, On Thu, Apr 23, 2015 at 11:34 PM, Simon Glass s...@chromium.org wrote: On 21 April 2015 at 16:02, Joe Hershberger joe.hershber...@ni.com wrote: Use a regular expression to apply the default formatting flags for all ethaddr env vars. Signed-off-by: Joe Hershberger joe.hershber

Re: [U-Boot] [PATCH 00/11] Improve env var handling for net stack

2015-04-27 Thread Joe Hershberger
On Mon, Apr 27, 2015 at 2:53 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On 27 April 2015 at 12:20, Joe Hershberger joe.hershber...@gmail.com wrote: Hi Simon, On Thu, Apr 23, 2015 at 11:32 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On 21 April 2015 at 16:02, Joe Hershberger

Re: [U-Boot] [PATCH 10/11] net: Use env callbacks for net variables

2015-04-27 Thread Joe Hershberger
Hi Simon, On Thu, Apr 23, 2015 at 11:34 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On 21 April 2015 at 16:02, Joe Hershberger joe.hershber...@ni.com wrote: Instead of checking for changes to the env each time we enter the net_loop, use the env callbacks to update the values

Re: [U-Boot] [VOTING REQUIRED] Re: U-Boot mini summit

2015-05-04 Thread Joe Hershberger
Hi Wolfgang, On Mon, May 4, 2015 at 10:31 AM, Wolfgang Denk w...@denx.de wrote: On Tue, 14 Apr 2015 Stefano Babic wrote: Hi everybody, there were some rumours about next U-Boot mini summit and why there is not yet a date. The reason is that we at DENX are thinking about, taking into

Re: [U-Boot] [RFC] FIT: use default configuration, if given configuration is not found

2015-05-04 Thread Joe Hershberger
Hi Yegor, On Mon, May 4, 2015 at 2:53 AM, yegorsli...@googlemail.com wrote: From: Yegor Yefremov yegorsli...@googlemail.com Signed-off-by: Yegor Yefremov yegorsli...@googlemail.com --- common/image-fit.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

Re: [U-Boot] [PATCH v3 00/26] Improve env var handling for net stack

2015-05-04 Thread Joe Hershberger
Hi Tom, On Sun, May 3, 2015 at 3:12 PM, Joe Hershberger joe.hershber...@ni.com wrote: This includes moving CONFIG_REGEX to Kconfig and adding support for regex to the env_attr lists (when CONFIG_REGEX is enabled). This allows ethaddrs to all be checked for access and format by default. Also

Re: [U-Boot] [PATCH v2 16/19] test: env: Add test for verifying env attrs

2015-05-03 Thread Joe Hershberger
Hi Simon, On Thu, Apr 30, 2015 at 10:46 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On 28 April 2015 at 23:51, Joe Hershberger joe.hershber...@ni.com wrote: Add a test of the env_attr_lookup() function. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v2: -New

[U-Boot] [PATCH v3 14/26] test: Generalize the unit test framework

2015-05-03 Thread Joe Hershberger
Separate the ability to define tests and assert status of test functions from the dm tests so they can be used more consistenly throughout all tests. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: -New

[U-Boot] [PATCH v3 15/26] test: Add a common unit test command

2015-05-03 Thread Joe Hershberger
Add a command that all other unit tests should be a sub-command of. Also include a command that will run all tests. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v3: -New for version 3 Changes in v2: None include/test/suites.h | 11 + test/Makefile | 1

[U-Boot] [PATCH v3 26/26] sandbox: Enable env unit tests

2015-05-03 Thread Joe Hershberger
Enable the new env unit tests on sandbox. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: -New for version 2 configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs

[U-Boot] [PATCH v3 08/26] env: Distinguish finer between source of env change

2015-05-03 Thread Joe Hershberger
of setenv() ). Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: None common/cmd_nvedit.c | 26 +++--- include/search.h| 2 ++ 2 files changed, 21 insertions(+), 7 deletions(-) diff

[U-Boot] [PATCH v3 16/26] test: Move the unit tests to their own menu

2015-05-03 Thread Joe Hershberger
Make all unit tests selectable as a menu of test suites instead of just sitting in the top-level menu individually. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v3: -New for version 3 Changes in v2: None test/Kconfig| 7 +-- test/dm/Kconfig | 3 +-- 2 files

[U-Boot] [PATCH v3 25/26] sandbox: Cleanup order and extra defines in defconfig

2015-05-03 Thread Joe Hershberger
The defconfigs should not be edited directly. They should be generated by editing the .config (through menuconfig or whatever) and then run make savedefconfig to have the Kconfig system generate a clean defconfig I did this for sandbox here with no actual changes. Signed-off-by: Joe Hershberger

[U-Boot] [PATCH v3 06/26] env: Allow env_attr_walk to pass a priv * to callback

2015-05-03 Thread Joe Hershberger
In some cases it can be helpful to have context in the callback about the calling situation. This is needed for following patches. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: None common/cmd_nvedit.c

[U-Boot] [PATCH v3 07/26] env: Add regex support to env_attrs

2015-05-03 Thread Joe Hershberger
Allow the features that use env_attrs to specify regexs for the name Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: -Added description to README README | 8 + common/env_attr.c

[U-Boot] [PATCH v3 21/26] test: env: Add test framework for env

2015-05-03 Thread Joe Hershberger
Add a new env subcommand to the ut command. This will run unit tests on the env code. This should be targetable to any device that supports the env features needed for the tests. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3

[U-Boot] [PATCH v3 24/26] test: dm: Move the dm tests over to the ut command

2015-05-03 Thread Joe Hershberger
Unify the command for running unit tests further by moving the dm test command over to ut dm. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v3: -New for version 3 Changes in v2: None arch/sandbox/Kconfig | 5 - include/dm/test.h | 11 --- include/test

[U-Boot] [PATCH v3 18/26] test: dm: eth: Handle failed test env cleanup

2015-05-03 Thread Joe Hershberger
Make sure that the env gets cleaned up after a test fails so that other tests aren't affected. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v3: -New for version 3 Changes in v2: None test/dm/eth.c | 79 +-- 1 file

[U-Boot] [PATCH v3 20/26] test: dm: Recover the driver model tree after tests

2015-05-03 Thread Joe Hershberger
Put the driver model for the system back into a good state after completing the DM testing. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v3: -New for version 3 Changes in v2: None test/dm/test-main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/test/dm/test

[U-Boot] [PATCH v3 04/26] env: Fix return values in env_attr_lookup()

2015-05-03 Thread Joe Hershberger
This function returned numbers for error codes. Change them to error codes. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: None common/env_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[U-Boot] [PATCH v3 22/26] test: env: Add test for verifying env attrs

2015-05-03 Thread Joe Hershberger
Add a test of the env_attr_lookup() function. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: -New for version 2 test/env/Makefile | 1 + test/env/attr.c | 62

[U-Boot] [PATCH v3 13/26] net: Handle ethaddr changes as an env callback

2015-05-03 Thread Joe Hershberger
the REGEX feature. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v3: -New for version 3 Changes in v2: None configs/sandbox_defconfig | 1 - include/env_callback.h| 3 +- net/Kconfig | 1 + net/eth.c | 83

[U-Boot] [PATCH v3 19/26] test: Return values from the asserts compatible with cmds

2015-05-03 Thread Joe Hershberger
The asserts are sometimes called from the context of the test command itself so make sure that a return that happens as a result of a failure is compatible with that command return. When called within a test, the return value is ignored. Signed-off-by: Joe Hershberger joe.hershber...@ni.com

[U-Boot] [PATCH v3 12/26] net: Remove duplicate bootfile syncing functionality

2015-05-03 Thread Joe Hershberger
The bootfile env var is already kept up to date by the callback in net.c so there is no need to poll it too. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v3: -New for version 3 Changes in v2: None net/eth.c | 12 1 file changed, 12 deletions(-) diff --git

[U-Boot] [PATCH v3 10/26] net: Use env callbacks for net variables

2015-05-03 Thread Joe Hershberger
Instead of checking for changes to the env each time we enter the net_loop, use the env callbacks to update the values of the variables. Don't update the variables when the source was programmatic, since the variables were the source of the new value. Signed-off-by: Joe Hershberger joe.hershber

[U-Boot] [PATCH v3 09/26] net: Apply default format rules to all ethaddr

2015-05-03 Thread Joe Hershberger
Use a regular expression to apply the default formatting flags for all ethaddr env vars. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: -Added comments about the use of .flags in the dm eth test include

[U-Boot] [PATCH v3 11/26] net: Add default flags for common net env vars

2015-05-03 Thread Joe Hershberger
Check that the common network stack's env vars conform to the proper format for IP addresses. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: None include/env_flags.h | 12 +++- 1 file changed, 11

Re: [U-Boot] [PATCH] dm: core: Fix regression caused by c1d6f91

2015-05-03 Thread Joe Hershberger
Hi Simon and Tom, On Fri, May 1, 2015 at 9:23 AM, Simon Glass s...@chromium.org wrote: Hi Tom, On 1 May 2015 at 07:38, Tom Rini tr...@konsulko.com wrote: On Thu, Apr 30, 2015 at 07:54:21PM -0600, Simon Glass wrote: --snip-- Now that the tests are running again, I'll resume checking

[U-Boot] [PATCH v3 17/26] test: dm: Don't bail on all tests if one test fails

2015-05-03 Thread Joe Hershberger
There's not much point in having a failure count if we always give up on the first failure. Also stop clearing the entire state between tests. Make sure that any failures are still passed out to the command line. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s

[U-Boot] [PATCH v3 05/26] env: Simplify the reverse_strstr() interface

2015-05-03 Thread Joe Hershberger
The logic to find the whole matching name was split needlessly between the reverse_strstr function and its caller. Fully contain it to make the interface for calling it more consistent. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v3: None Changes in v2: -Fix

[U-Boot] [PATCH v3 03/26] sandbox: Enable regex support

2015-05-03 Thread Joe Hershberger
Enable regex support on sandbox. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: None configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs

[U-Boot] [PATCH v3 23/26] test: env: Add a test of the new regex behavior for attrs

2015-05-03 Thread Joe Hershberger
The behavior of the env attrs depends on CONFIG_REGEX. Add an additional test if that variable is set. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: -New for version 2 test/env/attr.c | 27

[U-Boot] [PATCH v3 01/26] sandbox: Enable some ENV commands

2015-05-03 Thread Joe Hershberger
Enable some additional ENV commands in sandbox to aid in build testing and run testing. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: None include/configs/sandbox.h | 5 + 1 file changed, 5 insertions

[U-Boot] [PATCH v3 02/26] kconfig: Move REGEX to Kconfig

2015-05-03 Thread Joe Hershberger
Having this as a Kconfig allows it to be a dependent feature. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org Acked-by: Stefan Roese s...@denx.de --- Changes in v3: None Changes in v2: None configs/acadia_defconfig | 1 + configs

[U-Boot] [PATCH v3 00/26] Improve env var handling for net stack

2015-05-03 Thread Joe Hershberger
comments about the use of .flags in the dm eth test -Added description to README -Fix bisectability issue -Fix corner case in reverse_name_search() where searched starts with ' ' -New for version 2 -Simplified test for H_PROGRAMMATIC Joe Hershberger (26): sandbox: Enable some ENV commands kconfig

[U-Boot] Sandbox dm tests leave sandbox in a bad state

2015-04-30 Thread Joe Hershberger
Hi Simon, I tracked a segfault down to the entire DM being left torn down after the last test. This means anything that wants to use the DM is hosed. I'm seeing a segfault in the sandbox related to a driver name being NULL when running dm tree. I also noticed that the USB test dm_test_usb_flash

Re: [U-Boot] HUSH logical AND/OR expressions

2015-04-28 Thread Joe Hershberger
Hi Joakim, On Mon, Apr 27, 2015 at 8:39 AM, Joakim Tjernlund joakim.tjernl...@transmode.se wrote: Trying to get a better handle of HUSH shell expressions, this does not work as I expect: = false true || echo ECHO = false false || echo ECHO none prints ECHO, seems like a bug? I think it

Re: [U-Boot] HUSH logical AND/OR expressions

2015-04-28 Thread Joe Hershberger
Hi James, On Tue, Apr 28, 2015 at 1:19 PM, James Chargin jimccr...@gmail.com wrote: Dear Joe Hershberger, On 04/28/2015 11:00 AM, Joe Hershberger wrote: Hi Joakim, On Mon, Apr 27, 2015 at 8:39 AM, Joakim Tjernlund joakim.tjernl...@transmode.se wrote: Trying to get a better handle

Re: [U-Boot] [PATCH] use CONFIG_CMD_HOST to enable the host command

2015-04-27 Thread Joe Hershberger
-by: Joe Hershberger joe.hershber...@ni.com Patch is against the u-boot-x86/sandbox branch common/Makefile | 2 +- include/config_distro_bootcmd.h | 6 +++--- include/configs/sandbox.h | 2 ++ 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/common/Makefile b

Re: [U-Boot] HUSH logical AND/OR expressions

2015-04-28 Thread Joe Hershberger
Hi James, On Tue, Apr 28, 2015 at 2:13 PM, James Chargin jimccr...@gmail.com wrote: Dear Joe, On 04/28/2015 11:35 AM, Joe Hershberger wrote: Hi James, On Tue, Apr 28, 2015 at 1:19 PM, James Chargin jimccr...@gmail.com wrote: Dear Joe Hershberger, On 04/28/2015 11:00 AM, Joe

Re: [U-Boot] [PATCH 05/11] env: Simplify the reverse_strstr() interface

2015-04-27 Thread Joe Hershberger
Hi Simon, On Thu, Apr 23, 2015 at 11:34 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On 21 April 2015 at 16:02, Joe Hershberger joe.hershber...@ni.com wrote: The logic to find the whole matching name was split needlessly between the reverse_strstr function and its caller. Fully contain

Re: [U-Boot] [PATCH 00/11] Improve env var handling for net stack

2015-04-27 Thread Joe Hershberger
Hi Simon, On Thu, Apr 23, 2015 at 11:32 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On 21 April 2015 at 16:02, Joe Hershberger joe.hershber...@ni.com wrote: This includes moving CONFIG_REGEX to Kconfig and adding support for regex to the env_attr lists (when CONFIG_REGEX is enabled

Re: [U-Boot] [PATCH 05/11] env: Simplify the reverse_strstr() interface

2015-04-27 Thread Joe Hershberger
Hi Simon, On Mon, Apr 27, 2015 at 2:24 PM, Joe Hershberger joe.hershber...@gmail.com wrote: Hi Simon, On Thu, Apr 23, 2015 at 11:34 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On 21 April 2015 at 16:02, Joe Hershberger joe.hershber...@ni.com wrote: The logic to find the whole matching

Re: [U-Boot] [PATCH v3 18/26] test: dm: eth: Handle failed test env cleanup

2015-05-05 Thread Joe Hershberger
Hi Simon, On Tue, May 5, 2015 at 3:56 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On 3 May 2015 at 14:12, Joe Hershberger joe.hershber...@ni.com wrote: Make sure that the env gets cleaned up after a test fails so that other tests aren't affected. Signed-off-by: Joe Hershberger

Re: [U-Boot] [PATCH 1/2] Fix inconsistency of VERIFY defines in cmd_mem

2015-05-05 Thread Joe Hershberger
Hi Simon, On Tue, May 5, 2015 at 4:37 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On 5 May 2015 at 11:23, Joe Hershberger joe.hershber...@ni.com wrote: Introduced in change d20a40de9db07de1f1f06a79a4da1cdda5379b75 Roll crc32 into hash infrastructure Use a consistent define to enable

Re: [U-Boot] [WORKING PATCH 1/2] sandbox: Use defconfig to enable features

2015-05-07 Thread Joe Hershberger
Hi Simon, On Wed, May 6, 2015 at 5:00 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On 6 May 2015 at 11:54, Joe Hershberger joe.hershber...@ni.com wrote: Stop using the sandbox arch Kconfig to override defaults for config options. This is a bit of abuse and may be causing build problems

[U-Boot] [PATCH v4 15/26] test: Generalize the unit test framework

2015-05-07 Thread Joe Hershberger
Separate the ability to define tests and assert status of test functions from the dm tests so they can be used more consistenly throughout all tests. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None

[U-Boot] [PATCH v4 22/26] test: dm: Recover the driver model tree after tests

2015-05-07 Thread Joe Hershberger
Put the driver model for the system back into a good state after completing the DM testing. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Acked-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: -New for version 3 Changes in v2: None test/dm/test-main.c | 5

[U-Boot] [PATCH v4 17/26] test: dm: Move the dm tests over to the ut command

2015-05-07 Thread Joe Hershberger
Unify the command for running unit tests further by moving the dm test command over to ut dm. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Acked-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: -New for version 3 Changes in v2: None configs/sandbox_defconfig

[U-Boot] [PATCH v4 19/26] test: dm: Don't bail on all tests if one test fails

2015-05-07 Thread Joe Hershberger
There's not much point in having a failure count if we always give up on the first failure. Also stop clearing the entire state between tests. Make sure that any failures are still passed out to the command line. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s

[U-Boot] [PATCH v4 16/26] test: Add a common unit test command

2015-05-07 Thread Joe Hershberger
Add a command that all other unit tests should be a sub-command of. Also include a command that will run all tests. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Acked-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: -New for version 3 Changes in v2: None

[U-Boot] [PATCH v4 18/26] test: Move the unit tests to their own menu

2015-05-07 Thread Joe Hershberger
Make all unit tests selectable as a menu of test suites instead of just sitting in the top-level menu individually. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Acked-by: Simon Glass s...@chromium.org --- Changes in v4: -Fixed bisectability issue Changes in v3: -New for version 3

[U-Boot] [PATCH v4 20/26] test: dm: eth: Handle failed test env cleanup

2015-05-07 Thread Joe Hershberger
Make sure that the env gets cleaned up after a test fails so that other tests aren't affected. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v4: None Changes in v3: -New for version 3 Changes in v2: None test/dm/eth.c | 81

[U-Boot] [PATCH v4 21/26] test: Return values from the asserts compatible with cmds

2015-05-07 Thread Joe Hershberger
The asserts are sometimes called from the context of the test command itself so make sure that a return that happens as a result of a failure is compatible with that command return. When called within a test, the return value is ignored. Signed-off-by: Joe Hershberger joe.hershber...@ni.com

[U-Boot] [PATCH v4 23/26] test: env: Add test framework for env

2015-05-07 Thread Joe Hershberger
Add a new env subcommand to the ut command. This will run unit tests on the env code. This should be targetable to any device that supports the env features needed for the tests. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4

[U-Boot] buildman for sandbox

2015-05-07 Thread Joe Hershberger
Hi Simon, Is there a way to make buildman compile sandbox with a non-system tool chain? I've tried creating an alias from sandbox to i386 and removing the root entry. It then simply claims not to have a sandbox tool chain. Thanks, -Joe ___ U-Boot

[U-Boot] [PATCH v4 04/26] kconfig: Move REGEX to Kconfig

2015-05-07 Thread Joe Hershberger
Having this as a Kconfig allows it to be a dependent feature. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org Acked-by: Stefan Roese s...@denx.de --- Changes in v4: None Changes in v3: None Changes in v2: None configs/acadia_defconfig

[U-Boot] [PATCH v4 25/26] test: env: Add a test of the new regex behavior for attrs

2015-05-07 Thread Joe Hershberger
The behavior of the env attrs depends on CONFIG_REGEX. Add an additional test if that variable is set. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None Changes in v2: -New for version 2 test/env/attr.c

[U-Boot] [PATCH v4 26/26] sandbox: Enable env unit tests

2015-05-07 Thread Joe Hershberger
Enable the new env unit tests on sandbox. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None Changes in v2: -New for version 2 configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[U-Boot] [PATCH v4 24/26] test: env: Add test for verifying env attrs

2015-05-07 Thread Joe Hershberger
Add a test of the env_attr_lookup() function. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None Changes in v2: -New for version 2 test/env/Makefile | 1 + test/env/attr.c | 62

[U-Boot] [PATCH v4 09/26] env: Distinguish finer between source of env change

2015-05-07 Thread Joe Hershberger
of setenv() ). Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None Changes in v2: None common/cmd_nvedit.c | 26 +++--- include/search.h| 2 ++ 2 files changed, 21 insertions(+), 7

[U-Boot] [PATCH v4 05/26] env: Fix return values in env_attr_lookup()

2015-05-07 Thread Joe Hershberger
This function returned numbers for error codes. Change them to error codes. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None Changes in v2: None common/env_attr.c | 6 +++--- 1 file changed, 3

[U-Boot] [PATCH v4 08/26] env: Add regex support to env_attrs

2015-05-07 Thread Joe Hershberger
Allow the features that use env_attrs to specify regexs for the name Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None Changes in v2: -Added description to README README | 8

[U-Boot] [PATCH v4 06/26] env: Simplify the reverse_strstr() interface

2015-05-07 Thread Joe Hershberger
The logic to find the whole matching name was split needlessly between the reverse_strstr function and its caller. Fully contain it to make the interface for calling it more consistent. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v4: None Changes in v3: None Changes

[U-Boot] [PATCH v4 07/26] env: Allow env_attr_walk to pass a priv * to callback

2015-05-07 Thread Joe Hershberger
In some cases it can be helpful to have context in the callback about the calling situation. This is needed for following patches. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None Changes in v2: None

[U-Boot] [PATCH v4 12/26] net: Add default flags for common net env vars

2015-05-07 Thread Joe Hershberger
Check that the common network stack's env vars conform to the proper format for IP addresses. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None Changes in v2: None include/env_flags.h | 12

[U-Boot] [PATCH v4 10/26] net: Apply default format rules to all ethaddr

2015-05-07 Thread Joe Hershberger
Use a regular expression to apply the default formatting flags for all ethaddr env vars. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None Changes in v2: -Added comments about the use of .flags in the dm

[U-Boot] [PATCH v4 14/26] net: Handle ethaddr changes as an env callback

2015-05-07 Thread Joe Hershberger
the REGEX feature. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v4: None Changes in v3: -New for version 3 Changes in v2: None include/env_callback.h | 3 +- net/Kconfig| 1 + net/eth.c | 83 -- 3 files

[U-Boot] [PATCH v4 13/26] net: Remove duplicate bootfile syncing functionality

2015-05-07 Thread Joe Hershberger
The bootfile env var is already kept up to date by the callback in net.c so there is no need to poll it too. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v4: None Changes in v3: -New for version 3 Changes in v2: None net/eth.c | 12 1 file changed, 12

[U-Boot] [PATCH v4 11/26] net: Use env callbacks for net variables

2015-05-07 Thread Joe Hershberger
Instead of checking for changes to the env each time we enter the net_loop, use the env callbacks to update the values of the variables. Don't update the variables when the source was programmatic, since the variables were the source of the new value. Signed-off-by: Joe Hershberger joe.hershber

[U-Boot] [PATCH v4 00/26] Improve env var handling for net stack

2015-05-07 Thread Joe Hershberger
to ut subcommand -New for version 3 Changes in v2: -Added comments about the use of .flags in the dm eth test -Added description to README -Fix bisectability issue -Fix corner case in reverse_name_search() where searched starts with ' ' -New for version 2 -Simplified test for H_PROGRAMMATIC Joe

[U-Boot] [PATCH v4 03/26] sandbox: Enable some ENV commands

2015-05-07 Thread Joe Hershberger
Enable some additional ENV commands in sandbox to aid in build testing and run testing. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reviewed-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None Changes in v2: None include/configs/sandbox.h | 5 + 1 file

[U-Boot] [PATCH v4 02/26] sandbox: Use defconfig to enable features

2015-05-07 Thread Joe Hershberger
Stop using the sandbox arch Kconfig to override defaults for config options. This is a bit of abuse and may be causing build problems. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v4: -New for version 4 Changes in v3: None Changes in v2: None arch/sandbox/Kconfig

[U-Boot] [PATCH v4 01/26] sandbox: Cleanup order and extra defines in defconfig

2015-05-07 Thread Joe Hershberger
The defconfigs should not be edited directly. They should be generated by editing the .config (through menuconfig or whatever) and then run make savedefconfig to have the Kconfig system generate a clean defconfig I did this for sandbox here with no actual changes. Signed-off-by: Joe Hershberger

[U-Boot] [PATCH 3/5] moveconfig: Continue moving even if one board fails

2015-05-07 Thread Joe Hershberger
Some compilers are hard to come by or have so few boards they are not worth messing with for this tool. Provide a list that need manual intervention and continue moving the bulk of boards. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- tools/moveconfig.py | 29

[U-Boot] [PATCH 1/5] moveconfig: Actually build autoconf.mk

2015-05-07 Thread Joe Hershberger
The existing target won't actually build the needed .mk file that is expected by the rest of the script. It seems that silentoldconfig does not actually cause this to be built any longer. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- This patch is based on: Don't apply: tools: add

[U-Boot] [PATCH 5/5] moveconfig: Always run savedefconfig on the moved config

2015-05-07 Thread Joe Hershberger
This will ensure that the order of the defconfig entries will always match that of the Kconfig files. After one slightly painful (but still early in the process) pass over all boards, this should keep the defconfigs clean from here on. Signed-off-by: Joe Hershberger joe.hershber...@ni.com

[U-Boot] [PATCH 2/5] moveconfig: Add a mapping for the arc cross-compiler

2015-05-07 Thread Joe Hershberger
The arc architecture is supported by U-Boot, so add a mapping here for it as well. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- tools/moveconfig.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/moveconfig.py b/tools/moveconfig.py index 30dc4f6..c81f32c 100755

[U-Boot] [PATCH 4/5] moveconfig: Error if missing the include/autoconf.mk

2015-05-07 Thread Joe Hershberger
The main image autoconf.mk certainly had better exist. I'm not sure about SPL and TPL, but at least this one. Check for this and error if missing. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- tools/moveconfig.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[U-Boot] [WORKING PATCH 2/2] fixup! test: dm: eth: Handle failed test env cleanup

2015-05-06 Thread Joe Hershberger
Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- This fixes the one warning that was listed in your buildman output. For whatever reason my older gcc does not throw this warning. test/dm/eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/dm/eth.c b/test/dm

[U-Boot] [WORKING PATCH 1/2] sandbox: Use defconfig to enable features

2015-05-06 Thread Joe Hershberger
Stop using the sandbox arch Kconfig to override defaults for config options. This is a bit of abuse and may be causing build problems. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- The errors you are seeing are the result of CONFIG_UNIT_TEST not being defined. That should

Re: [U-Boot] [PATCH v3 18/26] test: dm: eth: Handle failed test env cleanup

2015-05-06 Thread Joe Hershberger
Hi Simon, On Wed, May 6, 2015 at 10:11 AM, Simon Glass s...@chromium.org wrote: Hi Joe, On 5 May 2015 at 17:39, Joe Hershberger joe.hershber...@gmail.com wrote: Hi Simon, On Tue, May 5, 2015 at 3:56 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On 3 May 2015 at 14:12, Joe Hershberger

[U-Boot] [PATCH 4/6] sh: Remove mpr2 board

2015-05-10 Thread Joe Hershberger
-linux-gcc: error: command line option '-m3' is not supported by this configuration Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Mark Jonas mark.jo...@de.bosch.com --- arch/sh/Kconfig| 5 -- board/mpr2/Kconfig | 9 --- board/mpr2/MAINTAINERS | 6 -- board

[U-Boot] [PATCH 1/6] sh: Remove rsk7264 board

2015-05-10 Thread Joe Hershberger
-linux-gcc: error: command line option '-m2a' is not supported by this configuration sh4-linux-gcc: error: command line option '-m2a-nofpu' is not supported by this configuration Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Phil Edworthy phil.edwor...@renesas.com --- arch/sh/Kconfig

[U-Boot] [PATCH 2/6] sh: Remove rsk7269 board

2015-05-10 Thread Joe Hershberger
-linux-gcc: error: command line option '-m2a' is not supported by this configuration sh4-linux-gcc: error: command line option '-m2a-nofpu' is not supported by this configuration Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- arch/sh/Kconfig | 5 - board

Re: [U-Boot] [PATCH 1/6] sh: Remove rsk7264 board

2015-05-10 Thread Joe Hershberger
Hi Masahiro-san, On Sun, May 10, 2015 at 8:38 PM, Masahiro Yamada yamada.masah...@socionext.com wrote: Hi. 2015-05-11 5:23 GMT+09:00 Joe Hershberger joe.hershber...@ni.com: Removing this board because it does not build with any tool-chain that we know of. The board fails to build

[U-Boot] [PATCH 5/6] sh: Remove ms7720se board

2015-05-10 Thread Joe Hershberger
-linux-gcc: error: command line option '-m3' is not supported by this configuration Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- arch/sh/Kconfig | 5 - arch/sh/include/asm/cpu_sh3.h| 2 - arch/sh/include

[U-Boot] [PATCH 0/6] Remove sh boards that we have no tool-chain for.

2015-05-10 Thread Joe Hershberger
These 6 boards are the last that cannot be built with a public configuration of tool-chains. Remove them. This includes the SH2 and SH3 cpus, which are the actual cause for not being able to build these boards. They can always be added back if the situation changes. Joe Hershberger (6): sh

[U-Boot] [PATCH 3/6] sh: Remove rsk7203 board

2015-05-10 Thread Joe Hershberger
-linux-gcc: error: command line option '-m2a' is not supported by this configuration sh4-linux-gcc: error: command line option '-m2a-nofpu' is not supported by this configuration Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Nobuhiro Iwamatsu iwamatsu.nobuh...@renesas.com Cc: Nobuhiro

[U-Boot] [PATCH 6/6] sh: Remove shmin board

2015-05-10 Thread Joe Hershberger
-linux-gcc: error: command line option '-m3' is not supported by this configuration Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Nobuhiro Iwamatsu iwamatsu.nobuh...@renesas.com Cc: Nobuhiro Iwamatsu iwama...@nigauri.org --- MAKEALL | 1 - README

Re: [U-Boot] [PATCH 02/24] dm: usb: Implement usb_detect_change() for driver model

2015-05-04 Thread Joe Hershberger
Hi Simon, On Mon, May 4, 2015 at 12:30 PM, Simon Glass s...@chromium.org wrote: Support this function with driver model also (CONFIG_DM_USB). Signed-off-by: Simon Glass s...@chromium.org --- drivers/usb/host/usb-uclass.c | 43 +++ 1 file changed,

<    8   9   10   11   12   13   14   15   16   17   >