[U-Boot] [PATCH v3 01/10] net: Remove volatile from net API

2012-05-15 Thread Joe Hershberger
Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Remove volatile from eth driver API - Not using global NetRxPacket (since not casting away volatile) Changes for v3: include/net.h | 25 + net

[U-Boot] [PATCH v3 04/10] net: cosmetic: eth.c checkpatch compliance

2012-05-15 Thread Joe Hershberger
Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split into smaller patches Changes for v3: net/eth.c | 67 +--- 1 files changed, 32 insertions(+), 35 deletions

[U-Boot] Pull request: u-boot-net/master

2012-05-15 Thread Joe Hershberger
The following changes since commit 0a6deb3251a68b5be640ab1b848ca67e906b75ce: Wolfgang Denk (1): Merge branch 'ag...@denx.de' of git://git.denx.de/u-boot-staging are available in the git repository at: git://git.denx.de/u-boot-net.git master Joe Hershberger (10): net: Remove

Re: [U-Boot] [PATCH 1/2 v2] net: punt bd-bi_ip_addr

2012-05-15 Thread Joe Hershberger
Hi Mike, On Wed, Apr 4, 2012 at 11:53 PM, Mike Frysinger vap...@gentoo.org wrote: This field gets read in one place (by bdinfo), and we can replace that with getenv(ipaddr).  After all, the bi_ip_addr field is kept up-to-date implicitly with the value of the ipaddr env var. Signed-off-by:

Re: [U-Boot] [PATCH 2/2 v2] net: move bootfile init into eth_initialize

2012-05-15 Thread Joe Hershberger
Hi Mike, On Wed, Apr 4, 2012 at 11:53 PM, Mike Frysinger vap...@gentoo.org wrote: All arches init this the same way, so move the logic into the core net code to avoid duplicating it everywhere else. Signed-off-by: Mike Frysinger vap...@gentoo.org --- v2        - rebased onto mainline  

Re: [U-Boot] [PATCH v5 4/5] net: add eth_setenv_enetaddr_by_index()

2012-05-15 Thread Joe Hershberger
Hi Michael, On Fri, May 11, 2012 at 5:50 PM, Michael Walle mich...@walle.cc wrote: Signed-off-by: Michael Walle mich...@walle.cc Cc: Joe Hershberger joe.hershber...@gmail.com ---  include/net.h |   16  net/eth.c     |   15 +++  2 files changed, 31 insertions

Re: [U-Boot] [PATCH v5 3/5] net: fix potential compiler warning

2012-05-15 Thread Joe Hershberger
Hi Michael, On Fri, May 11, 2012 at 5:50 PM, Michael Walle mich...@walle.cc wrote: Future compiler versions may generate a too many arguments for functions warning. Signed-off-by: Michael Walle mich...@walle.cc Cc: Joe Hershberger joe.hershber...@gmail.com ---  net/eth.c |   14

Re: [U-Boot] [PATCH v2 01/21] net: Remove CMD_PING where there's no CMD_NET

2012-05-16 Thread Joe Hershberger
Hi Simon, On Fri, Apr 20, 2012 at 9:47 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger joe.hershber...@ni.com wrote: diff --git a/include/configs/am3517_crane.h b/include/configs/am3517_crane.h index b0dd2f0..848e4ae 100644 --- a/include

Re: [U-Boot] [PATCH v2 03/21] net: Move MAC-seeded rand out of bootp.c

2012-05-16 Thread Joe Hershberger
Hi Simon, On Fri, Apr 20, 2012 at 9:54 PM, Simon Glass s...@chromium.org wrote: Hi Joe, On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger joe.hershber...@ni.com wrote: diff --git a/net/bootp.c b/net/bootp.c index d0a7da2..5949e77 100644 --- a/net/bootp.c +++ b/net/bootp.c @@ -12,6 +12,9

Re: [U-Boot] [PATCH v3 01/10] net: Remove volatile from net API

2012-05-21 Thread Joe Hershberger
Hi Wolfgang, On Mon, May 21, 2012 at 2:05 AM, Wolfgang Denk w...@denx.de wrote: Dear Joe Hershberger, In message 1337108353-28086-2-git-send-email-joe.hershber...@ni.com you wrote: Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com

[U-Boot] [PATCH 2/2] MAKEALL: Report boards with errors vs warnings

2012-05-21 Thread Joe Hershberger
In the summary, indicate which boards errored and which boards merely warned. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Andy Fleming aflem...@freescale.com --- MAKEALL | 26 -- 1 files changed, 20 insertions(+), 6 deletions(-) diff --git a/MAKEALL b

[U-Boot] [PATCH 1/2] MAKEALL: Fix error reporting for BUILD_NBUILDS==1

2012-05-21 Thread Joe Hershberger
This was broken by f588bb034d5d3a0417f45965f1aba4d4cf8a2893 Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Andy Fleming aflem...@freescale.com --- MAKEALL |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/MAKEALL b/MAKEALL index 05e2d90..b7fcae4 100755

[U-Boot] [PATCH] Fix unused variable compile warning

2012-05-21 Thread Joe Hershberger
In gcc 4.6 this warns. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Wolfgang Denk w...@denx.de --- common/cmd_nvedit.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index 5999cb8..2712002 100644 --- a/common

[U-Boot] [PATCH] davinci: Fix Ethernet driver interface warning

2012-05-21 Thread Joe Hershberger
Fixes: davinci_emac.c: In function 'davinci_emac_initialize': davinci_emac.c:796:12: warning: assignment from incompatible pointer type [enabled by default] Tested on da850_am18xxevm Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers

[U-Boot] [PATCH] net: Fix smc911x Ethernet driver warning

2012-05-21 Thread Joe Hershberger
Fix this warning: smc911x.c: In function 'smc911x_initialize': smc911x.c:288:12: warning: assignment from incompatible pointer type [enabled by default] Tested on omap3_overo Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net

Re: [U-Boot] [PATCH] net: Fix smc911x Ethernet driver warning

2012-05-21 Thread Joe Hershberger
Hi Anatolij, On Mon, May 21, 2012 at 1:11 PM, Anatolij Gustschin ag...@denx.de wrote: Hi Joe, On Mon, 21 May 2012 12:21:53 -0500 Joe Hershberger joe.hershber...@ni.com wrote: Fix this warning: smc911x.c: In function 'smc911x_initialize': smc911x.c:288:12: warning: assignment from

Re: [U-Boot] [PATCH v3 01/10] net: Remove volatile from net API

2012-05-21 Thread Joe Hershberger
Hi Wolfgang, On Mon, May 21, 2012 at 2:05 PM, Wolfgang Denk w...@denx.de wrote: Dear Joe Hershberger, In message CANr=Z=zimqvn2vxp0_kma76o091tjfu4ck6wvf7re3hefmo...@mail.gmail.com you wrote: While getting rid of volatile is a good thing in general, I am worried about the test scope

[U-Boot] [PATCH] ppc: Fix warning in TSEC Ethernet driver

2012-05-21 Thread Joe Hershberger
Fixes: tsec.c: In function 'tsec_initialize': tsec.c:638:12: warning: assignment from incompatible pointer type Tested on MPC8313e-RDB Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- drivers/net/tsec.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [U-Boot] [PATCH] davinci: Fix Ethernet driver interface warning

2012-05-21 Thread Joe Hershberger
Hi Tom, On Mon, May 21, 2012 at 10:54 AM, Joe Hershberger joe.hershber...@ni.com wrote: Fixes: davinci_emac.c: In function 'davinci_emac_initialize': davinci_emac.c:796:12: warning: assignment from incompatible pointer type [enabled by default] Tested on da850_am18xxevm Signed-off

Re: [U-Boot] [PATCH] davinci: Fix Ethernet driver interface warning

2012-05-21 Thread Joe Hershberger
On Mon, May 21, 2012 at 3:23 PM, Tom Rini tr...@ti.com wrote: On 05/21/2012 01:07 PM, Joe Hershberger wrote: Hi Tom, On Mon, May 21, 2012 at 10:54 AM, Joe Hershberger joe.hershber...@ni.com  wrote: Fixes: davinci_emac.c: In function 'davinci_emac_initialize': davinci_emac.c:796:12

Re: [U-Boot] [PATCH] drivers/net/smc911x.c: Fix GCC 4.6 warning

2012-05-21 Thread Joe Hershberger
On Sun, May 20, 2012 at 5:22 PM, Anatolij Gustschin ag...@denx.de wrote: smc911x.c: In function 'smc911x_initialize': smc911x.c:288:12: warning: assignment from incompatible pointer type [enabled by default] Signed-off-by: Anatolij Gustschin ag...@denx.de Applied, thanks. -Joe

Re: [U-Boot] [PATCH] drivers/usb/eth/smsc95xx.c: Fix GCC 4.6 warning

2012-05-21 Thread Joe Hershberger
On Sun, May 20, 2012 at 5:22 PM, Anatolij Gustschin ag...@denx.de wrote: Fix: smsc95xx.c: In function 'smsc95xx_eth_get_info': smsc95xx.c:869:12: warning: assignment from incompatible pointer type [enabled by default] Signed-off-by: Anatolij Gustschin ag...@denx.de Applied, thanks. -Joe

Re: [U-Boot] [PATCH] drivers/net/mpc5xxx_fec.c: Fix build warning

2012-05-21 Thread Joe Hershberger
On Mon, May 21, 2012 at 11:45 AM, Anatolij Gustschin ag...@denx.de wrote: On Mon, 21 May 2012 00:22:57 +0200 Anatolij Gustschin ag...@denx.de wrote: Fix: mpc5xxx_fec.c: In function 'mpc5xxx_fec_initialize': mpc5xxx_fec.c:920: warning: assignment from incompatible pointer type

Re: [U-Boot] [PATCH] arch/arm/cpu/ixp/npe/npe.c: Fix build warning

2012-05-21 Thread Joe Hershberger
On Sun, May 20, 2012 at 5:22 PM, Anatolij Gustschin ag...@denx.de wrote: Fix: npe.c: In function 'npe_initialize': npe.c:630:13: warning: assignment from incompatible pointer type Signed-off-by: Anatolij Gustschin ag...@denx.de Applied, thanks. -Joe

Re: [U-Boot] [PATCH] drivers/usb/eth/asix.c: Fix build warning

2012-05-21 Thread Joe Hershberger
On Sun, May 20, 2012 at 5:22 PM, Anatolij Gustschin ag...@denx.de wrote: Fix: asix.c: In function 'asix_eth_get_info': asix.c:629:12: warning: assignment from incompatible pointer type Signed-off-by: Anatolij Gustschin ag...@denx.de Applied, thanks. -Joe

Re: [U-Boot] [PATCH] Fix cmd_nvedit.c: warning: unused variable 'bd'

2012-05-21 Thread Joe Hershberger
On Mon, May 21, 2012 at 2:13 AM, Wolfgang Denk w...@denx.de wrote: Commit 50a47d0 net: punt bd-bi_ip_addr introduced a build warning. Fix it. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Mike Frysinger vap...@gentoo.org Applied, thanks. -Joe ___

Re: [U-Boot] [PATCH] MPC8xx: fix Remove volatile from net API aftermath

2012-05-21 Thread Joe Hershberger
: In function 'scc_initialize': scc.c:85:14: warning: assignment from incompatible pointer type [enabled by default] Fix these. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Joe Hershberger joe.hershber...@ni.com --- Joe,  I started fixing these issues when I realized that this is not just a few

Re: [U-Boot] [PATCH] drivers/net/mpc512x_fec.c: Fix build warning

2012-05-21 Thread Joe Hershberger
ag...@denx.de Cc: Joe Hershberger joe.hershber...@gmail.com Applied, thanks. -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] ppc: Fix warning in TSEC Ethernet driver

2012-05-21 Thread Joe Hershberger
On Mon, May 21, 2012 at 2:46 PM, Joe Hershberger joe.hershber...@ni.com wrote: Fixes: tsec.c: In function 'tsec_initialize': tsec.c:638:12: warning: assignment from incompatible pointer type Tested on MPC8313e-RDB Signed-off-by: Joe Hershberger joe.hershber...@ni.com Applied

Re: [U-Boot] [PATCH] drivers/net/4xx_enet.c: Fix build warning

2012-05-21 Thread Joe Hershberger
Gustschin ag...@denx.de Cc: Joe Hershberger joe.hershber...@gmail.com Applied, thanks. -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Fix cmd_nvedit.c: warning: unused variable 'bd'

2012-05-21 Thread Joe Hershberger
On Mon, May 21, 2012 at 4:55 PM, Wolfgang Denk w...@denx.de wrote: Dear Joe Hershberger, In message CANr=Z=bvyvdm_qoungpeuz0x4s1p4bzypbypu_p2grzvarn...@mail.gmail.com you wrote: On Mon, May 21, 2012 at 2:13 AM, Wolfgang Denk w...@denx.de wrote: Commit 50a47d0 net: punt bd-bi_ip_addr

Re: [U-Boot] [PATCH] Fix cmd_nvedit.c: warning: unused variable 'bd'

2012-05-21 Thread Joe Hershberger
Hi Wolfgang, On Mon, May 21, 2012 at 5:01 PM, Wolfgang Denk w...@denx.de wrote: Dear Joe Hershberger, In message CANr=Z=aDCq+E2yeDpPXLxtoRyN3G3tOs7v0h=q4_of_ybkh...@mail.gmail.com you wrote: On Mon, May 21, 2012 at 4:55 PM, Wolfgang Denk w...@denx.de wrote: Dear Joe Hershberger

[U-Boot] FYI: Warning on tegra builds

2012-05-21 Thread Joe Hershberger
Hi Tom, I'm seeing the following on tegra builds: Configuring for harmony board... textdata bss dec hex filename 1715624016 218244 393822 6025e /tmp/u-boot-build//harmony/u-boot ap20.c: In function 'init_pllx': ap20.c:81:18: warning: array subscript is above array

Re: [U-Boot] Warning on tegra builds

2012-05-21 Thread Joe Hershberger
Hi Tom, On Mon, May 21, 2012 at 6:25 PM, Tom Warren twar...@nvidia.com wrote: Joe, What repo/branch? I assume u-boot-tegra/master? I was building u-boot/master when I noticed this. What compiler/tools? I usually use either ELDK42 or GCC 4.4.1 and I don't see this.

[U-Boot] [PATCH] drivers/net/at91_emac.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: at91_emac.c: In function 'at91emac_register': at91_emac.c:524:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/at91_emac.c |3 +-- 1 files changed, 1 insertions

[U-Boot] [PATCH] drivers/net/cs8900.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: cs8900.c: In function 'cs8900_initialize': cs8900.c:326:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc Joe Hershberger joe.hershber...@gmail.com --- drivers/net/cs8900.c |3 +-- 1 files changed, 1 insertions(+), 2

[U-Boot] [PATCH] drivers/net/enc28j60.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: enc28j60.c: In function 'enc28j60_initialize': enc28j60.c:967:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/enc28j60.c |2 +- 1 files changed, 1 insertions

[U-Boot] [PATCH] drivers/net/eepro100.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
: note: expected 'uchar *' but argument is of type 'volatile u8 *' The use of a descriptor like this may mean DMA will update this at will Beware this may be a source of trouble on some boards Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com

[U-Boot] [PATCH] drivers/net/ks8695eth.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: ks8695eth.c: In function 'ks8695_eth_initialize': ks8695eth.c:236:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/ks8695eth.c |3 +-- 1 files changed, 1

[U-Boot] [PATCH] drivers/net/smc91111.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: smc9.c: In function 'smc9_initialize': smc9.c:1363:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/smc9.c |3 +-- 1 files changed, 1 insertions

[U-Boot] [PATCH] drivers/net/dm9000x.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: dm9000x.c: In function 'dm9000_initialize': dm9000x.c:636:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/dm9000x.c |3 +-- 1 files changed, 1 insertions(+), 2

[U-Boot] [PATCH] drivers/net/ftmac100.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: ftmac100.c: In function 'ftmac100_initialize': ftmac100.c:266:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/ftmac100.c |3 +-- 1 files changed, 1 insertions

[U-Boot] [PATCH] drivers/net/calxedaxgmac.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
'calxedaxgmac_initialize': calxedaxgmac.c:547:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/calxedaxgmac.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[U-Boot] [PATCH] drivers/net/lan91c96.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: lan91c96.c: In function 'lan91c96_initialize': lan91c96.c:811:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/lan91c96.c |4 ++-- 1 files changed, 2 insertions

[U-Boot] [PATCH] drivers/net/dnet.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: dnet.c: In function 'dnet_eth_initialize': dnet.c:380:15: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/dnet.c |3 +-- 1 files changed, 1 insertions(+), 2

[U-Boot] [PATCH] drivers/net/fec_mxc.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: fec_mxc.c: In function 'fec_probe': fec_mxc.c:926:13: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/fec_mxc.c |2 +- 1 files changed, 1 insertions(+), 1

[U-Boot] [PATCH] drivers/net/macb.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: macb.c: In function 'macb_eth_initialize': macb.c:564:15: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/macb.c |3 +-- 1 files changed, 1 insertions(+), 2

[U-Boot] [PATCH] drivers/net/armada100_fec.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: armada100_fec.c: In function 'armada100_fec_register': armada100_fec.c:723:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/armada100_fec.c |3 +-- 1 files

[U-Boot] [PATCH] drivers/net/dc2114x.c: Fix compile warning

2012-05-21 Thread Joe Hershberger
Fix this: dc2114x.c: In function 'dc21x4x_initialize': dc2114x.c:305:15: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/dc2114x.c |4 ++-- 1 files changed, 2 insertions

[U-Boot] [PATCH] drivers/qe/uec.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: uec.c: In function 'uec_initialize': uec.c:1404:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- drivers/qe/uec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/qe/uec.c b/drivers/qe

[U-Boot] [PATCH] drivers/net/natsemi.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: natsemi.c: In function 'natsemi_initialize': natsemi.c:338:13: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- drivers/net/natsemi.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net

[U-Boot] [PATCH] drivers/net/uli526x.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: uli526x.c: In function 'uli526x_initialize': uli526x.c:243:13: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- drivers/net/uli526x.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net

[U-Boot] [PATCH] arch/powerpc/cpu/mpc85xx/ether_fcc.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: ether_fcc.c: In function 'fec_initialize': ether_fcc.c:453:15: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- arch/powerpc/cpu/mpc85xx/ether_fcc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[U-Boot] [PATCH] arch/powerpc/cpu/mpc8220/fec.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- arch/powerpc/cpu/mpc8220/fec.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/cpu/mpc8220/fec.c b/arch/powerpc/cpu/mpc8220/fec.c index 2053fea

[U-Boot] [PATCH] board/esd/cpci405/cpci405.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
type 'long int', but argument 5 has type 'IPaddr_t' cpci405.c:737:4: warning: format '%ld' expects type 'long int', but argument 6 has type 'IPaddr_t' cpci405.c:700:8: warning: unused variable 'bd' Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- board/esd/cpci405/cpci405.c |7

[U-Boot] [PATCH] drivers/net/e1000.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: e1000.c: In function 'e1000_initialize': e1000.c:5264:13: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- drivers/net/e1000.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/e1000.c b

[U-Boot] [PATCH] arch/powerpc/cpu/mpc8260/ether_fcc.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: ether_fcc.c: In function 'fec_initialize': ether_fcc.c:390:15: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- arch/powerpc/cpu/mpc8260/ether_fcc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[U-Boot] [PATCH] drivers/net/rtl8139.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: rtl8139.c: In function 'rtl8139_initialize': rtl8139.c:234:13: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- drivers/net/rtl8139.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[U-Boot] [PATCH] drivers/net/fm/eth.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: eth.c: In function 'fm_eth_initialize': eth.c:651:12: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- drivers/net/fm/eth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/fm/eth.c b

[U-Boot] [PATCH] drivers/net/ns8382x.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: ns8382x.c: In function 'ns8382x_initialize': ns8382x.c:352:13: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- drivers/net/ns8382x.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net

[U-Boot] [PATCH] drivers/net/tsi108_eth.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
-off-by: Joe Hershberger joe.hershber...@ni.com --- drivers/net/tsi108_eth.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/net/tsi108_eth.c b/drivers/net/tsi108_eth.c index f100ec1..b2c1be5 100644 --- a/drivers/net/tsi108_eth.c +++ b/drivers/net

[U-Boot] [PATCH] net: Fix remaining API interface breakage

2012-05-22 Thread Joe Hershberger
-off-by: Joe Hershberger joe.hershber...@ni.com --- arch/mips/cpu/mips32/au1x00/au1x00_eth.c |3 ++- arch/powerpc/cpu/mpc8260/ether_scc.c |2 +- board/Marvell/db64360/mv_eth.c |3 +-- board/Marvell/db64460/mv_eth.c |3 +-- board/esd/cpci750/mv_eth.c

[U-Boot] [PATCH] net: Remove redefinitions of net.h functions

2012-05-22 Thread Joe Hershberger
Some copy/pasted drivers redefine functions defined in include/net.h. Remove these so that the definitions can be changed without error. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- board/Marvell/db64360/mv_eth.c |2 -- board

Re: [U-Boot] [PATCH v2 3/3] net: Work-around for brain-damaged Cisco equipment with arp-proxy

2012-05-22 Thread Joe Hershberger
Hi Simon, On Fri, Apr 20, 2012 at 9:44 PM, Simon Glass s...@chromium.org wrote: +#ifdef CONFIG_CMD_LINK_LOCAL +               /* +                * Work-around for brain-damaged Cisco equipment with +                *   arp-proxy enabled. +                * +                *   If the

[U-Boot] [PATCH] arch/powerpc/cpu/mpc8260/ether_scc.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: ether_scc.c: In function 'mpc82xx_scc_enet_initialize': ether_scc.c:377:14: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- arch/powerpc/cpu/mpc8260/ether_scc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[U-Boot] [PATCH] drivers/net/pcnet.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: pcnet.c: In function 'pcnet_initialize': pcnet.c:224:13: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- drivers/net/pcnet.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/pcnet.c b

[U-Boot] [PATCH] drivers/net/rtl8169.c: Fix compile warning

2012-05-22 Thread Joe Hershberger
Fix this: rtl8169.c: In function 'rtl8169_initialize': rtl8169.c:907:13: warning: assignment from incompatible pointer type Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- drivers/net/rtl8169.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net

[U-Boot] [PATCH v2] net: Fix remaining API interface breakage

2012-05-22 Thread Joe Hershberger
-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes for v2: - Include header changes missed before - Drop fixes contributed by Stephan Linz arch/mips/cpu/mips32/au1x00/au1x00_eth.c |3 ++- board/Marvell/db64360/mv_eth.c |3 +-- board/Marvell/db64360/mv_eth.h

[U-Boot] [PATCH v3 01/21] net: Remove CMD_PING where there's no CMD_NET

2012-05-23 Thread Joe Hershberger
Some boards claim to need ping, but don't support net. That makes no sense, and causes problems now that ping is in a separate file. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Separated from Move PING out of net.c

[U-Boot] [PATCH v3 18/21] net: cosmetic: Rename OPT_SIZE to OPT_FIELD_SIZE

2012-05-23 Thread Joe Hershberger
Clearer constant name. Also remove related BOOTP_SIZE which was unused and doesn't take into account VLAN packets. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split from Improve variable names and code readability

[U-Boot] [PATCH v3 15/21] net: cosmetic: Add a more explicit comment about 802.2

2012-05-23 Thread Joe Hershberger
Make the comment more accurate about the header including SNAP Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split from Improve variable names and code readability - Fixed comment indention Changes for v3

[U-Boot] [PATCH v3 02/21] net: Move MAC-seeded rand out of bootp.c

2012-05-23 Thread Joe Hershberger
Make the MAC-seeded random number generator available to /net in general. MAC-seeded rand will be needed by link-local as well, so give it an interface. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v3: - Lowercase hex

[U-Boot] [PATCH v3 20/21] net: cosmetic: Rename tmp to reply_ip_addr in arp.c

2012-05-23 Thread Joe Hershberger
Renamed for clarity Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split from Improve variable names and code readability Changes for v3: net/arp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

[U-Boot] [PATCH v3 05/21] net: Move ARP out of net.c

2012-05-23 Thread Joe Hershberger
Separate this functionality out of the net.c behemoth Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: Changes for v3: - Added a short commit message include/net.h |3 +- net/Makefile |1 + net/arp.c | 213

[U-Boot] [PATCH v3 17/21] net: cosmetic: Rename CDPHandler to cdp_receive

2012-05-23 Thread Joe Hershberger
This is not called as a handler, so don't name it that way Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split from Improve variable names and code readability Changes for v3: - Added a function comment - Renamed

[U-Boot] [PATCH v3 07/21] net: Move RARP receive logic out of net.c

2012-05-23 Thread Joe Hershberger
Separate this functionality out of the net.c behemoth Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Moved void to the same line as function - Eliminate CamelCase in new function name Changes for v3: - Removed

[U-Boot] [PATCH v3 14/21] net: cosmetic: Rename parameter len to payload_len

2012-05-23 Thread Joe Hershberger
This name more explicitly claims that it does not include the header size Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split from Improve variable names and code readability Changes for v3: - Documented arguments

[U-Boot] [PATCH v3 12/21] net: cosmetic: Un-typedef ARP_t

2012-05-23 Thread Joe Hershberger
Remove typedef and lower-case letters Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split apart from Un-typedef variables in net - Renamed structs from *_t to *_hdr since they are nolonger types Changes for v3

[U-Boot] [PATCH v3 09/21] net: cosmetic: Split struct ip_udp_hdr into ip_hdr

2012-05-23 Thread Joe Hershberger
Add a structure that only contains IP header fields to be used by functions that don't need UDP Rename IP_HDR_SIZE_NO_UDP to IP_HDR_SIZE Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split apart from Un-typedef

[U-Boot] [PATCH v3 21/21] net: cosmetic: Replace magic numbers in arp.c with constants

2012-05-23 Thread Joe Hershberger
Use field names and sizes when accessing ARP packets Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split from Improve variable names and code readability Changes for v3: include/net.h |6 ++ net/arp.c

[U-Boot] [PATCH v3 08/21] net: cosmetic: Un-typedef IP_t

2012-05-23 Thread Joe Hershberger
Rename IP header related things to IP_UDP. The existing definition of IP_t includes UDP header, so name it to accurately describe the structure. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split apart from Un-typedef

[U-Boot] [PATCH v3 19/21] net: cosmetic: Alphabetize includes in net.c

2012-05-23 Thread Joe Hershberger
Easier to find when alphabetized Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split from Improve variable names and code readability Changes for v3: - Slight adjustment to order as recommended by Simon net/net.c

[U-Boot] [PATCH v3 10/21] net: cosmetic: Un-typedef Ethernet_t

2012-05-23 Thread Joe Hershberger
Separate the Ethernet header from the 802 header. Base the size constants on the structs. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split apart from Un-typedef variables in net - Created a new E802_hdr struct

[U-Boot] [PATCH v3 06/21] net: Move PING out of net.c

2012-05-23 Thread Joe Hershberger
Separate this functionality out of the net.c behemoth Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Moved config fixes to a separate patch - Pushed #ifdef CONFIG_CMD_PING into header - Eliminated CamelCase

[U-Boot] [PATCH v3 13/21] net: cosmetic: Un-typedef ICMP_t

2012-05-23 Thread Joe Hershberger
Remove typedef and lower-case name Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split apart from Un-typedef variables in net - Renamed structs from *_t to *_hdr since they are nolonger types Changes for v3

[U-Boot] [PATCH v3 11/21] net: cosmetic: Un-typedef VLAN_Ethernet_t

2012-05-23 Thread Joe Hershberger
Eliminate the typedef and remove capital letters Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split apart from Un-typedef variables in net - Renamed structs from *_t to *_hdr since they are nolonger types Changes

[U-Boot] [PATCH v3 00/21] Network stack cosmetic improvements

2012-05-23 Thread Joe Hershberger
-series. This is a portion of the changes split from the series: Add link-local addressing support Joe Hershberger (21): net: Remove CMD_PING where there's no CMD_NET net: Move MAC-seeded rand out of bootp.c net: Move CDP out of net.c net: Encapsulate CDP packet identification net: Move ARP

[U-Boot] [PATCH v3 04/21] net: Encapsulate CDP packet identification

2012-05-23 Thread Joe Hershberger
Checking for CDP packets should be encapsulated, not copied code. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split from patch Move CDP out of net.c - Changed to static inline Changes for v3: - Added a function

[U-Boot] [PATCH v3 03/21] net: Move CDP out of net.c

2012-05-23 Thread Joe Hershberger
Separate this functionality out of the net.c behemoth Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Moved is_cdp_packet to a separate patch - Fixed blank newline at the end of cdp.h - Pushed #ifdef CONFIG_CMD_CDP

[U-Boot] [PATCH v3 16/21] net: cosmetic: Rename x to eth_proto

2012-05-23 Thread Joe Hershberger
x is a poor variable name Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split from Improve variable names and code readability Changes for v3: net/net.c | 24 1 files changed, 12 insertions

[U-Boot] [PATCH v3 03/18] net: Refactor packet length computations

2012-05-23 Thread Joe Hershberger
Save the length when it is computed instead of forgetting it and subtracting pointers to figure it out again. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: Changes for v3: - Rebased onto other changed patches net/arp.c

[U-Boot] [PATCH v3 07/18] net: Refactor to use NetSendPacket instead of eth_send directly

2012-05-23 Thread Joe Hershberger
Use this entry-point consistently across the net/ code Use a static inline function to preserve code size Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Change NetSendPacket into a static inline Changes for v3

[U-Boot] [PATCH v3 05/18] net: Move debug trace to point of action

2012-05-23 Thread Joe Hershberger
Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Split from Refactor bootp packet length computations Changes for v3: - Rebased onto other changed patches net/bootp.c |2 +- 1 files changed, 1 insertions(+), 1

[U-Boot] [PATCH v3 11/18] net: Don't write the serverip env var if configured not to

2012-05-23 Thread Joe Hershberger
Before this patch, bootp would not overwrite the value, but the value was still clobbered in the env Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Added a comment Changes for v3: - Rebased onto other changed patches

[U-Boot] [PATCH v3 00/18] Network stack refactoring

2012-05-23 Thread Joe Hershberger
on the Network stack cosmetic improvements patch-series. This is a portion of the changes split from the series: Add link-local addressing support Joe Hershberger (18): net: Refactor IP, UPD, and ICMP header writing functions net: Refactor NetSendUDPPacket to share more code net: Refactor packet length

[U-Boot] [PATCH v3 02/18] net: Refactor NetSendUDPPacket to share more code

2012-05-23 Thread Joe Hershberger
Share more of the code that is common between ARP vs not. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: Changes for v3: - Rebased onto other changed patches net/net.c | 44

[U-Boot] [PATCH v3 09/18] net: Refactor to separate the UDP handler from the ARP handler

2012-05-23 Thread Joe Hershberger
Call a built-in dummy if none is registered... don't require protocols to register a handler (eliminating dummies) NetConsole now uses the ARP handler when waiting on arp (instead of needing a #define hack in arp.c) Clear handlers at the end of net loop Signed-off-by: Joe Hershberger joe.hershber

[U-Boot] [PATCH v3 01/18] net: Refactor IP, UPD, and ICMP header writing functions

2012-05-23 Thread Joe Hershberger
ICMP (ping) was reimplementing IP header code... it now shares code. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Eliminate CamelCase in new functions Changes for v3: - Rebased onto other changed patches include

[U-Boot] [PATCH v3 06/18] net: Refactor ping receive handler

2012-05-23 Thread Joe Hershberger
There is no need to call through the handler... inline it Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: Changes for v3: - Rebased onto other changed patches net/ping.c | 18 ++ 1 files changed, 2

[U-Boot] [PATCH v3 10/18] net: Add net_update_ether() to handle ARP and Ping replies

2012-05-23 Thread Joe Hershberger
When the network is VLAN or SNAP, net_update_ether() will preserve the original Ethernet packet header and simply replace the src and dest MACs and the protocol Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: Changes for v3

<    1   2   3   4   5   6   7   8   9   10   >