[PATCH v1 3/6] net: mv88e61xx: Clear temporary structs before using them in get_phy_id()

2021-03-17 Thread Lukasz Majewski
Those automatically created structures can have random value. However, mv88e61xx driver assumes that those are zeroed. Signed-off-by: Lukasz Majewski --- drivers/net/phy/mv88e61xx.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/phy/mv88e61xx.c b/drivers/net/phy

[PATCH v1 4/6] net: mv88e61xx: Directly access the switch chip

2021-03-17 Thread Lukasz Majewski
The mv88e6020 is accessed in a direct way (i.e. with direct read and write to mdio bus). The only necessary indirection is required when accessing its PHY registers. Signed-off-by: Lukasz Majewski --- drivers/net/phy/mv88e61xx.c | 15 ++- 1 file changed, 10 insertions(+), 5

[PATCH v1 5/6] net: mv88e61xx: Set proper offset when R0_LED/ADDR4 is set on bootstrap

2021-03-17 Thread Lukasz Majewski
The mv88e61xx driver need to be adjusted to handle situation when switch MDIO addresses are switched by offset (0x10 in this case). Signed-off-by: Lukasz Majewski --- drivers/net/phy/mv88e61xx.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a

[PATCH v1 6/6] net: mv88e61xx: Reset switch PHYs when bootstrapped to !NO_CPU

2021-03-17 Thread Lukasz Majewski
of CONFIG Data1 (0x71) of Scratch and Misc register is read to check if 'no_cpu' and 'addr4' bits were set. Signed-off-by: Lukasz Majewski --- drivers/net/phy/mv88e61xx.c | 63 +++-- 1 file changed, 61 insertions(+), 2 deletions(-)

Re: [PATCH] dfu: dfu_sf: avoid double free of SPI device

2021-03-25 Thread Lukasz Majewski
gt; + list_for_each_entry(dfu, &dfu_list, list) { > > + if (dfu->data.sf.dev == dev) > > + dfu->data.sf.dev = NULL; > > + } > > + spi_flash_free(dev); > > + } > > } > > > > static s

Re: [PATCH] regulator: fix: enable gpio when requested

2020-04-28 Thread Lukasz Majewski
Hi Mark, > > Date: Tue, 28 Apr 2020 06:24:10 +0200 > > From: Lukasz Majewski > > Hi Lukasz, > > > Hi Mark, > > > > > The fix in commit b7adcdd073c0 has the side-effect that the > > > regulator will be disabled when requesting the relevan

[PATCH] imx: Update MTD partitions layout for display5 (i.MX6Q) board

2020-05-13 Thread Lukasz Majewski
This change updates the MTD partition layout on SPI-NOR memory for display5 board. Signed-off-by: Lukasz Majewski --- configs/display5_defconfig | 2 +- configs/display5_factory_defconfig | 2 +- include/configs/display5.h | 7 --- 3 files changed, 6 insertions(+), 5

Re: [PATCH] clk: Add more information to debug messages

2020-03-20 Thread Lukasz Majewski
gt; - debug("%s(clk=%p)\n", __func__, clk); > + debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name); > if (!clk_valid(clk)) > return 0; > ops = clk_dev_ops(clk->dev); > @@ -584,7 +586,7 @@ int clk_disable(

[RFT PATCH v1 4/5] usb: Provide code to handle spinup of USB usb devices (mostly HDDs)

2020-03-22 Thread Lukasz Majewski
]). Links: [1] - https://forum.doozan.com/read.php?3,35295,35295#msg-35295 [2] - https://www.dropbox.com/s/nrkrd1no63viuu8/uboot-bodhi-2016.05-timeoutTD.patch?dl=0 Signed-off-by: Lukasz Majewski [Unfortunately, the original patch [2] did not contain S-o-B from the original author - "rayvt

[RFT PATCH v1 0/5] usb: Improve robustness of ehci-hcd controller operation

2020-03-22 Thread Lukasz Majewski
ng - no error - pendrive [1] With the pendrive [2] I do observe that very often it is not recognized at all. Even more strange - there is a difference in the reliability of being recognized between identical pendrives (used one vs. just unboxed one). Lukasz Majewski (5): Revert "usb: ehci-hcd: K

[RFT PATCH v1 2/5] usb: Handle XACTERR error in DATA phase of USB storage

2020-03-22 Thread Lukasz Majewski
ks: [1] - https://forum.doozan.com/read.php?3,35295,35295#msg-35295 [2] - https://www.dropbox.com/s/nrkrd1no63viuu8/uboot-bodhi-2016.05-timeoutTD.patch?dl=0 Signed-off-by: Lukasz Majewski [Unfortunately, the original patch [2] did not contain S-o-B from the original author - "rayvt"] ---

[RFT PATCH v1 3/5] usb: Add some delay to wait for slow USB devices to be operational

2020-03-22 Thread Lukasz Majewski
pbox.com/s/nrkrd1no63viuu8/uboot-bodhi-2016.05-timeoutTD.patch?dl=0 Signed-off-by: Lukasz Majewski [Unfortunately, the original patch [2] did not contain S-o-B from the original author - "rayvt"] --- common/usb.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/c

[RFT PATCH v1 1/5] Revert "usb: ehci-hcd: Keep async schedule running"

2020-03-22 Thread Lukasz Majewski
This reverts commit 02b0e1a36c5bc20174299312556ec4e266872bd6. Signed-off-by: Lukasz Majewski --- drivers/usb/host/ehci-hcd.c | 51 ++--- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c

[RFT PATCH v1 5/5] usb: Handle QT_TOKEN_STATUS_XACTERR error when sending data

2020-03-22 Thread Lukasz Majewski
g-35295 [2] - https://www.dropbox.com/s/nrkrd1no63viuu8/uboot-bodhi-2016.05-timeoutTD.patch?dl=0 Signed-off-by: Lukasz Majewski [Unfortunately, the original patch [2] did not contain S-o-B from the original author - "rayvt"] --- drivers/usb/host/ehci-hcd.c | 27 ++-

Re: [RFT PATCH v1 1/5] Revert "usb: ehci-hcd: Keep async schedule running"

2020-03-22 Thread Lukasz Majewski
Hi Marek, > On 3/22/20 2:00 PM, Lukasz Majewski wrote: > > This reverts commit 02b0e1a36c5bc20174299312556ec4e266872bd6. > > > > Signed-off-by: Lukasz Majewski > > This patch lacks any and all explanation why this is being reverted. > The patch you are reve

Re: [RFT PATCH v1 2/5] usb: Handle XACTERR error in DATA phase of USB storage

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/22/20 2:00 PM, Lukasz Majewski wrote: > > This change brings support for handling XACTERR error during DATA > > phase of USB BBB (bulk) transmission. > > > > The fix is to clear stall'ed endpoint and reset recovery on the USB > > mass st

Re: [RFT PATCH v1 3/5] usb: Add some delay to wait for slow USB devices to be operational

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/22/20 2:00 PM, Lukasz Majewski wrote: > > This change provides some extra time for some slow (or degraded) > > USB devices to become fully operational. > > > > This code is the port to newest U-Boot of the fix from - "rayvt" > >

Re: [RFT PATCH v1 5/5] usb: Handle QT_TOKEN_STATUS_XACTERR error when sending data

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/22/20 2:00 PM, Lukasz Majewski wrote: > > This code adds check if QT_TOKEN_STATUS_XACTERR error occurred. > > When it is detected the token is reconfigured and transmission is > > retried. > > > > This code is the port to newest U-Boot of th

Re: [RFT PATCH v1 4/5] usb: Provide code to handle spinup of USB usb devices (mostly HDDs)

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/22/20 2:00 PM, Lukasz Majewski wrote: > [...] > > diff --git a/common/usb_storage.c b/common/usb_storage.c > > index 92e1e54d1c..3c2324fa1a 100644 > > --- a/common/usb_storage.c > > +++ b/common/usb_storage.c > > @@ -729,6 +729,7 @@ stat

Re: [RFT PATCH v1 1/5] Revert "usb: ehci-hcd: Keep async schedule running"

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/23/20 7:57 AM, Lukasz Majewski wrote: > > Hi Marek, > > Hi, > > >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: > >>> This reverts commit 02b0e1a36c5bc20174299312556ec4e266872bd6. > >>> > >>> Signed-off-

Re: [RFT PATCH v1 4/5] usb: Provide code to handle spinup of USB usb devices (mostly HDDs)

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/23/20 8:53 AM, Lukasz Majewski wrote: > > Hi Marek, > > Hi, > > >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: > >> [...] > >>> diff --git a/common/usb_storage.c b/common/usb_storage.c > >>> index 92e1e54d1c..3c

Re: [RFT PATCH v1 5/5] usb: Handle QT_TOKEN_STATUS_XACTERR error when sending data

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/23/20 8:18 AM, Lukasz Majewski wrote: > > Hi Marek, > > Hi, > > >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: > >>> This code adds check if QT_TOKEN_STATUS_XACTERR error occurred. > >>> When it is detected the toke

Re: [RFT PATCH v1 2/5] usb: Handle XACTERR error in DATA phase of USB storage

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/23/20 8:00 AM, Lukasz Majewski wrote: > > Hi Marek, > > > >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: > >>> This change brings support for handling XACTERR error during DATA > >>> phase of USB BBB (bulk) transmission. >

Re: [RFT PATCH v1 0/5] usb: Improve robustness of ehci-hcd controller operation

2020-03-23 Thread Lukasz Majewski
Hi Tom, > On Sun, Mar 22, 2020 at 02:00:26PM +0100, Lukasz Majewski wrote: > > > This patch set is rather a request for testing (and a starting > > point for the discussion), as it may improve the robustness of USB > > with some pendrives - and yes sacrifice some perform

Re: [RFT PATCH v1 1/5] Revert "usb: ehci-hcd: Keep async schedule running"

2020-03-24 Thread Lukasz Majewski
Hi Marek, > On 3/23/20 1:41 PM, Lukasz Majewski wrote: > > Hi Marek, > > Hi, > > >> On 3/23/20 7:57 AM, Lukasz Majewski wrote: > >>> Hi Marek, > >> > >> Hi, > >> > >>>> On 3/22/20 2:00 PM, Lukasz Majewsk

Re: [RFT PATCH v1 1/5] Revert "usb: ehci-hcd: Keep async schedule running"

2020-03-24 Thread Lukasz Majewski
Hi Marek, > On 3/24/20 8:06 AM, Lukasz Majewski wrote: > > Hi Marek, > > Hi, > > [...] > > >>>> You should probably figure out why this doesn't work first and > >>>> then add fixes on top. > >>> > >>

Re: [PATCH] fastboot: Fix overflow when calculating chunk size

2021-05-26 Thread Lukasz Majewski
;>   total_blocks += chunk_data_sz / > >> sparse_header->blk_sz; free(fill_buf); > >>   break; > >> @@ -253,7 +253,7 @@ int write_sparse_image(struct sparse_storage > >> *info, debug("Wrote %d blocks, expected to write %d

Re: [PATCH v1 1/6] net: mv88e61xx: Add support for checking addressing mode

2021-05-28 Thread Lukasz Majewski
Hi Joe, Tom, > On Wed, Mar 17, 2021 at 4:14 PM Lukasz Majewski wrote: > > > > Some Marvell switch devices are dual chip ones, like mv88e6020, > > which use direct MDIO addressing to access its ports' registers. > > Such approach allows connecting two such devic

Re: [PATCH v3] usb: dfu: Migrate CONFIG_SYS_DFU_DATA_BUF_SIZE and CONFIG_SYS_DFU_MAX_FILE_SIZE to Kconfig

2021-06-02 Thread Lukasz Majewski
to set these > configs in defconfig files than in config header files as they are a > part of the source code. > > Add Kconfig symbols, and update the defconfigs by using > tools/moveconfig.py script. Acked-by: Lukasz Majewski > > Suggested-by: Pratyush Yadav > Signed-o

Re: [Uboot-stm32] [PATCH] dfu: dfu_mtd: set max_buf_size to erasesize also for NOR devices

2021-06-07 Thread Lukasz Majewski
; - dfu->max_buf_size = has_pages ? mtd->erasesize : 0; > >> + dfu->max_buf_size = mtd->erasesize; > >> > >>st = strsep(&s, " "); > >>if (!strcmp(st, "raw")) { > >> > > Reviewed-by: Patrice Chot

[PATCH 1/2] i2c: pcf8575: Remove not used members of pcf8575_chip structure

2021-06-07 Thread Lukasz Majewski
Those members are not used anymore as ones from gpio_dev_priv structure (when DM_GPIO support is enabled) are used instead. Signed-off-by: Lukasz Majewski --- drivers/gpio/pcf8575_gpio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpio/pcf8575_gpio.c b/drivers/gpio

[PATCH 2/2] i2c: pcf8575: Add support for 8 bit I2C IO expanders (like pca8574)

2021-06-07 Thread Lukasz Majewski
functions have been removed as now we also sent 8 bit data. Signed-off-by: Lukasz Majewski --- drivers/gpio/pcf8575_gpio.c | 40 ++--- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/drivers/gpio/pcf8575_gpio.c b/drivers/gpio/pcf8575_gpio.

Re: [PATCH 3/6] clk: imx8mm: Add SPI clocks

2021-06-08 Thread Lukasz Majewski
posite("ecspi3", imx8mm_ecspi3_sels, > base + 0xc180)); + > + clk_dm(IMX8MM_CLK_ECSPI1_ROOT, > +imx_clk_gate4("ecspi1_root_clk", "ecspi1", base + > 0x4070, 0)); > + clk_dm(IMX8MM_CLK_ECSPI2_ROOT, > +imx_clk_gate4

Re: [PATCH v3 00/11] clk: k210: Rewrite K210 clock without CCF

2021-06-11 Thread Lukasz Majewski
rivers/clk/kendryte/Kconfig > delete mode 100644 drivers/clk/kendryte/Makefile > delete mode 100644 drivers/clk/kendryte/bypass.c > delete mode 100644 drivers/clk/kendryte/clk.c > delete mode 100644 drivers/clk/kendryte/pll.c > delete mode 100644 include/kendryte/bypass.h > delete mode 100644 include/kendryte/clk.h > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de pgpmpgvmM8CuY.pgp Description: OpenPGP digital signature

Re: [PATCH 00/16] usb: gadget: update

2021-01-23 Thread Lukasz Majewski
h | 123 ++ > > > drivers/usb/gadget/usbstring.c | 74 +- > > > include/linux/usb/composite.h | 71 ++ > > > include/linux/usb/gadget.h | 9 + > > > include/linux/utf.h | 75 ++ > > > 10 files changed, 734 insertions(+), 105 deletions(-) create > > > mode 100644 drivers/usb/gadget/u_os_desc.h create mode 100644 > > > include/linux/utf.h > > > > > > -- > > > 2.28.0 > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de pgpnRgrwjxOTN.pgp Description: OpenPGP digital signature

Re: [PATCH 1/4] fastboot: mmc: Add CONFIG_FASTBOOT_MMC_USER_SUPPORT

2021-01-23 Thread Lukasz Majewski
+--- > > 3 files changed, 24 insertions(+), 8 deletions(-) > > > > Gentle reminder, > > Any comments on this serie [1] > > [1] http://patchwork.ozlabs.org/project/uboot/list/?series=200509 > > Patrick Could you rebase this on top of current -master

Re: [RESEND 6/7] Revert "fastboot: Add default fastboot_set_reboot_flag implementation"

2021-01-23 Thread Lukasz Majewski
include/fastboot.h > +++ b/include/fastboot.h > @@ -52,15 +52,6 @@ enum fastboot_reboot_reason { > FASTBOOT_REBOOT_REASONS_COUNT > }; > > -/** > - * BCB boot commands > - */ > -static const char * const fastboot_boot_cmds[] = { > - [FASTBOOT_REBOOT_REASON_BOOTLOADER] = "boot

Re: [RESEND 7/7] fastboot: Implement generic fastboot_set_reboot_flag

2021-01-23 Thread Lukasz Majewski
n >= FASTBOOT_REBOOT_REASONS_COUNT) > + return -EINVAL; > + > + return > bcb_write_reboot_reason(CONFIG_FASTBOOT_FLASH_MMC_DEV, "misc", > boot_cmds[reason]); } > /** This patch causes build breaks when I run the CI on azzure. If it is still needed,

Re: [PATCH 3/4] usb: musb: Fix handling interrupts for EP0 and SET ADDRESS commmand

2021-01-23 Thread Lukasz Majewski
_irq(void) > if (intrtx) > musb_peri_tx(intrtx); > } else { > - if (MUSB_INTR_SOF & intrusb) { > + if (readw(&musbr->intrtx) & 0x1) { > u8 faddr; &

[GIT] Pull request: u-boot-dfu (23.01.2021)

2021-01-23 Thread Lukasz Majewski
Extend cmd: bcb - Fixes for fastboot and rockchip gadgets - dfu: Add SCRIPT and SKIP entities - dfu/thor: Add `dfu_alt_info` reinitialization from flashed script - u-boot: Reduce size of u-boot as usbd_device_* arrays are not exported The repository on Gitlab (master branch): https://gitlab.denx.

Re: [PATCH 3/4] usb: musb: Fix handling interrupts for EP0 and SET ADDRESS commmand

2021-01-23 Thread Lukasz Majewski
Hi Pali, > On Saturday 23 January 2021 16:16:11 Lukasz Majewski wrote: > > Hi Pali, > > > > > Interrupt for EP0 is indicated in intrtx register via first bit. > > > It is set for both RX and TX. First bit in intrrx register is > > > reserved a

[GIT] Pull request: u-boot-dfu (26.01.2021)

2021-01-26 Thread Lukasz Majewski
adget_ops Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de pgpm76jbQ3hiZ.pgp Description: OpenPGP digital signature

Re: [PATCH] fastboot: add UUU command UCmd and ACmd support

2021-01-27 Thread Lukasz Majewski
t;> * reboot_bootloader() - Sets reboot bootloader flag. > >>> * > >>> diff --git a/drivers/usb/gadget/f_fastboot.c > >>> b/drivers/usb/gadget/f_fastboot.c index d1d087e12b2..bf52d2505f4 > >>> 100644 --- a/drivers/usb/gadget/f_fastboot.c >

Re: [PATCH] fastboot: add UUU command UCmd and ACmd support

2021-01-31 Thread Lukasz Majewski
f_fastboot.c > >> +++ b/drivers/usb/gadget/f_fastboot.c > >> @@ -419,6 +419,18 @@ static void do_bootm_on_complete(struct > >> usb_ep *ep, struct usb_request *req) do_exit_on_complete(ep, req); > >> } > >> > >> +#if CONFIG_IS_ENABLED(FASTBOOT

Re: [PATCH v2 1/9] mmc: sandbox: Add support for writing

2021-01-31 Thread Lukasz Majewski
the same data > back */ ut_asserteq(512, dev_desc->blksz); > - memset(cmp, '\0', sizeof(cmp)); > - ut_asserteq(2, blk_dread(dev_desc, 0, 2, cmp)); > - ut_assertok(strcmp(cmp, "this is a test")); > + for (i = 0; i < sizeof(write); i++) > +

Re: [PATCH v2] fastboot: add UUU command UCmd and ACmd support

2021-02-04 Thread Lukasz Majewski
> +#if CONFIG_IS_ENABLED(FASTBOOT_UUU_SUPPORT) > + case FASTBOOT_COMMAND_ACMD: > + fastboot_func->in_req->complete = > do_acmd_complete; > + break; > +#endif > } > } > > diff --git a/include/fastboot.h b/incl

Re: [PATCH v4 8/9] fastboot: Allow u-boot-style partitions

2021-02-05 Thread Lukasz Majewski
get_part_info("0.0#test1", > &fb_dev_desc, > + &part_info, > response)); > + ut_asserteq(1, fastboot_mmc_get_part_info("0:1", > &fb_dev_desc, > + &

Re: [RESEND PATCH 01/16] serial: usbtty: Fix puts function

2021-02-06 Thread Lukasz Majewski
usbtty_puts("\r", 1); > - __usbtty_puts(str, n + 1); > + __usbtty_puts(str, n); > + __usbtty_puts("\r\n", 2); > str += (n + 1); > len -= (n + 1); >

Re: [RESEND PATCH 02/16] serial: usbtty: Send urb data in correct order

2021-02-06 Thread Lukasz Majewski
return -1; > @@ -878,6 +870,8 @@ static int write_buffer (circbuf_t * buf) >*/ > while (buf->size > 0) { > > + current_urb = next_urb (device_instance, > endpoint); + > dest = (char*)current_urb->buffer + &

Re: [RESEND PATCH 03/16] usb: musb: Fix compilation of gadget code

2021-02-06 Thread Lukasz Majewski
ers/usb/musb/built-in.o: in function `udc_startup_events': > u-boot/drivers/usb/musb/musb_udc.c: undefined reference to > `usbd_device_event_irq' arm-linux-gnueabi-ld.bfd: > u-boot/drivers/usb/musb/musb_udc.c: undefined reference to > `usbd_device_event_irq' arm-linux-gnueab

Re: [RESEND PATCH 04/16] usb: musb: Always clear the data toggle bit when configuring ep

2021-02-06 Thread Lukasz Majewski
On Fri, 5 Feb 2021 20:12:00 +0100 Pali Rohár wrote: > Without this patch it was done only when U-Boot was compiled with > MUSB Host Controller. But it is needed also for MUSB Device > Controller, otherwise Device Controller does not work. > Reviewed-by: Lukasz Majewski > Sign

Re: [RESEND PATCH 05/16] usb: musb: Fix configuring FIFO for endpoints

2021-02-06 Thread Lukasz Majewski
t possible. > > This patch is fixing calculation of start address and buffer size to > minimal value and ensure that it would not overlap with reserved EP0 > buffer. > > This issue caused loose of packets on USB bus in both directions and > basically usbtty was unusable. >

Re: [RESEND PATCH 06/16] usb: musb: Read value of PERI_RXCSR to 16bit variable

2021-02-06 Thread Lukasz Majewski
> { > u16 peri_rxcount; > - u8 peri_rxcsr = readw(&musbr->ep[ep].epN.rxcsr); > + u16 peri_rxcsr = readw(&musbr->ep[ep].epN.rxcsr); > > if (!(peri_rxcsr & MUSB_RXCSR_RXPKTRDY)) { > if (debug_level > 0) Reviewed-by: L

Re: [RESEND PATCH 07/16] usb: musb: Fix transmission of bigger buffers

2021-02-06 Thread Lukasz Majewski
kets are put into waiting queue. > > Implement function musb_peri_tx() which transmit checks when > endpoints are ready and continue transmitting of waiting queue. > > This patch fixes sending e.g. output of printenv command over usbtty > serial console. Reviewed-by: Lukasz Majew

Re: [RESEND PATCH 08/16] usb: musb: Fix receiving of bigger buffers

2021-02-06 Thread Lukasz Majewski
pending_intrrx that HW buffer was not fully > processed yet and next iteration is required after U-Boot allocate > space for reading HW buffer. > > This patch fixes receiving large usb buffers, e.g. file transfer via > Kermit protocol implemented by 'loadb' U-Boot command over

Re: [RESEND PATCH 09/16] usb: musb: Fix handling interrupts for EP0 and SET ADDRESS commmand

2021-02-06 Thread Lukasz Majewski
t; usb 1-1: Device not responding to setup address. > usb 1-1: Device not responding to setup address. > usb 1-1: device not accepting address 86, error -71 > > U-Boot was writing address to faddr register too early and did not > wait for correct interrupt after which shoul

Re: [RESEND PATCH 10/16] usb: musb: Ensure that we set musb dynamic FIFO buffer for every endpoint

2021-02-06 Thread Lukasz Majewski
pace between more endpoint cause data loss and > unexpected errors. > > This patch is fixing transmission of characters over usbtty serial > console and allow using of usbtty for debugging purposes on Nokia > N900. Reviewed-by: Lukasz Majewski > > Signed-off-by: Pali

Re: [RESEND PATCH 11/16] usb: gadget: Use dbg_ep0() macro instead of serial_printf()

2021-02-06 Thread Lukasz Majewski
On Fri, 5 Feb 2021 20:12:07 +0100 Pali Rohár wrote: > All debug messages from ep0.c except a few are printed by dbg_ep0() > macro. So for remaining few exception use also dbg_ep0() instead of > serial_printf(). Reviewed-by: Lukasz Majewski > > Signed-off-by: Pali Rohár >

Re: [RESEND PATCH 12/16] arm: omap3: Compile lowlevel_init() function only when it is used

2021-02-06 Thread Lukasz Majewski
nit) > ldr sp, SRAM_STACK > str ip, [sp]/* stash ip register */ > @@ -187,6 +190,7 @@ ENTRY(lowlevel_init) > b s_init > > ENDPROC(lowlevel_init) > +#endif > > /* the literal pools origin */ > .ltorg Reviewed-by: Lu

Re: [RESEND PATCH 13/16] arm: omap3: Compile s_init() function only when it is used

2021-02-06 Thread Lukasz Majewski
On Fri, 5 Feb 2021 20:12:09 +0100 Pali Rohár wrote: > Function s_init() is called only from lowlevel_init(). So compile it > only when function lowlevel_init() is compiled. > Reviewed-by: Lukasz Majewski > Signed-off-by: Pali Rohár > --- > arch/arm/mach-omap2/omap3/bo

Re: [RESEND PATCH 14/16] Nokia RX-51: Remove function set_muxconf_regs()

2021-02-06 Thread Lukasz Majewski
M0)) > /*d2d_dmare3*/\ > - MUX_VAL(CP(D2D_N3GTRST),(IEN | PTD | DIS | M0)) > /*d2d_n3gtrs*/\ > - MUX_VAL(CP(D2D_N3GTDI), (IEN | PTD | DIS | > M0)) /*d2d_n3gtdi*/\ > - MUX_VAL(CP(D2D_N3GTDO), (IEN | PTD | DIS | > M0)) /*d2d_n3gtdo*/\ > - MU

Re: [RESEND PATCH 15/16] Nokia RX-51: Move content of rx51.h to rx51.c

2021-02-06 Thread Lukasz Majewski
10xfb001202 > -#define ONENAND_GPMC_CONFIG2_RX510x0000 > -#define ONENAND_GPMC_CONFIG3_RX51 0x00020200 > -#define ONENAND_GPMC_CONFIG4_RX510x11001102 > -#define ONENAND_GPMC_CONFIG5_RX510x03101616 > -#define ONENAND_GPMC_CONFIG6_RX510x9006 > - > -#endif Revie

Re: [RESEND PATCH 16/16] Nokia RX-51: Enable usbtty serial console by default

2021-02-06 Thread Lukasz Majewski
"stdout=usbtty,serial,vga\0" \ > + "stderr=usbtty,serial,vga\0" \ > "slide=gpio input " __stringify(GPIO_SLIDE) "\0" \ > "switchmmc=mmc dev ${mmcnum}\0" \ > "kernaddr=0x82008000\0" \ > @@ -19

Re: [PATCH v4 8/9] fastboot: Allow u-boot-style partitions

2021-02-06 Thread Lukasz Majewski
Hi Sean, > On 2/5/21 9:46 AM, Lukasz Majewski wrote: > > Hi Sean, > > > >> This adds support for partitions of the form "dev.hwpart:part" and > >> "dev#partname". This allows one to flash to eMMC boot partitions > >> wi

Re: [RESEND v2 PATCH 00/16] Nokia RX-51: Fix USB TTY console and enable it

2021-02-08 Thread Lukasz Majewski
drivers/serial/usbtty.c | 16 +- > drivers/usb/gadget/ep0.c | 16 +- > drivers/usb/musb/musb_core.c | 12 +- > drivers/usb/musb/musb_udc.c | 61 ++-- > include/configs/nokia_rx51.h | 21 +- > 12 files changed

Re: [PATCH 06/25] arm: Remove mx28evk board

2021-02-09 Thread Lukasz Majewski
; \ > - "nand read ${fdt_addr} fdt 0x0008; " \ > - "bootz ${loadaddr} - ${fdt_addr}; " \ > - "else " \ > - "if test ${boot_fdt} = no; then " \ > -

[GIT] Pull request: u-boot-dfu (12.02.2021)

2021-02-12 Thread Lukasz Majewski
tion specifications Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de pgptD4kxEEexr.pgp Description: Ope

Re: [RESEND v2 PATCH 00/16] Nokia RX-51: Fix USB TTY console and enable it

2021-02-16 Thread Lukasz Majewski
Hi Pali, > On Monday 08 February 2021 23:34:06 Pali Rohár wrote: > > On Monday 08 February 2021 23:21:38 Pali Rohár wrote: > > > On Monday 08 February 2021 23:15:33 Lukasz Majewski wrote: > > > > Hi Pali, > > > > > > > > >

Re: [RESEND v2 PATCH 00/16] Nokia RX-51: Fix USB TTY console and enable it

2021-02-20 Thread Lukasz Majewski
On Fri, 19 Feb 2021 01:38:14 +0100 Pali Rohár wrote: > On Tuesday 16 February 2021 09:28:06 Lukasz Majewski wrote: > > Hi Pali, > > > > > On Monday 08 February 2021 23:34:06 Pali Rohár wrote: > > > > On Monday 08 February 2021 23:21:38 Pali Rohár wrote:

Re: [PATCH] Nokia RX-51: Enable CONFIG_CMD_BOOTD

2021-03-03 Thread Lukasz Majewski
] - > > >> https://dev.azure.com/u-boot/a1096300-2999-4ec4-a21a-4c22075e3771/_build/results?buildId=1816&view=logs&jobId=9a06d2a9-1498-5de0-2a01-be581d48ba67 > > >> > > > > > > Lokesh, could you please look at this patch? > > > > I do no

[PATCH] arm: Add extra boot device (UART) to run Ymodem u-boot.img boot on XEA (imx28)

2020-07-10 Thread Lukasz Majewski
pe u-boot.img Signed-off-by: Lukasz Majewski --- board/liebherr/xea/xea.c| 1 + configs/imx28_xea_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/board/liebherr/xea/xea.c b/board/liebherr/xea/xea.c index 8159f3a2d9..4062c6fb82 100644 --- a/board/liebherr/xea/xea.c +++ b/board

Re: [RFC] dfu: remove UPDATE_TFTP

2020-07-15 Thread Lukasz Majewski
eate an update file for > automatically > - replacing U-Boot image on a system. > - > - Assuming that an U-Boot image u-boot.bin is present in the current > working > - directory, and that the address given in the 'load' property in the > - 'update_uboot.its&

Re: [RFC] dfu: remove UPDATE_TFTP

2020-07-15 Thread Lukasz Majewski
Hi Heinrich, > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 15.07.20 13:24, Lukasz Majewski wrote: > > Hi Heinrich, > > > >> Using UPDATE_TFTP the firmware can be updated from tFTP by > >> writing to NOR flash. The same is possible by def

Re: [PATCH for v2020.10 1/1] cmd: drop fitupd command

2020-07-16 Thread Lukasz Majewski
Hi Heinrich, > On 17.06.20 11:29, Lukasz Majewski wrote: > > On Wed, 17 Jun 2020 11:09:03 +0200 > > Heinrich Schuchardt wrote: > > > >> The `fitupd' command is not used by any board. The `dfu tftp' > >> command provides the same capabilit

Re: [PATCH 1/1] x86: remove dead code in intel_clk_get_rate()

2020-02-16 Thread Lukasz Majewski
default: > return -ENODEV; > } > - > - return rate; > } > > static struct clk_ops intel_clk_ops = { > -- > 2.25.0 > Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfga

Re: [PATCH 1/1] clk: meson-g12a: missing break

2020-02-16 Thread Lukasz Majewski
= meson_pcie_pll_get_rate(clk); > + break; > case CLKID_VPU_0: > rate = meson_div_get_rate(clk, CLKID_VPU_0_DIV); > break; > -- > 2.25.0 > Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH

Re: [PATCH 1/1] clk: ICS8N3QV01 remove superfluous code

2020-02-16 Thread Lukasz Majewski
int fout, > uint *_mint, uint *_mfrac, uint n, foutiic, fvcoiic, mint; > u64 mfrac; > > - n = (221500U + fout / 2) / fout; > if (fout < 41700U) > n = 2 * ((221500U / 2 + fout / 2) / fout); > else > -- > 2.25.0 > Rev

Re: [PATCH 1/3] clk: imx: imx8mn: add enet clk

2020-02-20 Thread Lukasz Majewski
; 0x45e0, 0)); > +/* clks not needed in SPL stage */ > +#ifndef CONFIG_SPL_BUILD > + clk_dm(IMX8MN_CLK_ENET_REF, imx8m_clk_composite("enet_ref", > imx8mn_enet_ref_sels, base + 0xa980)); > + clk_dm(IMX8MN_CLK_ENET_TIMER, > imx8m_clk_composite("enet_timer", imx8m

Re: [PATCH 1/5] clk: imx: add i.IMXRT1020 clk driver

2020-02-20 Thread Lukasz Majewski
ine IMXRT1020_CLK_PLL3_PFD1_664_62M 9 > +#define IMXRT1020_CLK_PLL3_PFD2_508_24M 10 > +#define IMXRT1020_CLK_PLL3_PFD3_454_74M 11 > +#define IMXRT1020_CLK_PLL2_198M 12 > +#define IMXRT1020_CLK_PLL3_120M 13 > +#def

Re: [PATCH 2/5] Add i.MXRT1020 support

2020-02-20 Thread Lukasz Majewski
48..f28d52d3b7 100644 > --- a/arch/arm/mach-imx/imxrt/Kconfig > +++ b/arch/arm/mach-imx/imxrt/Kconfig > @@ -3,6 +3,10 @@ if ARCH_IMXRT > config IMXRT > bool > > +config IMXRT1020 > + bool > + select IMXRT > + > config IMXRT1050 > bool &

Re: [PATCH 3/5] ARM: dts: imxrt1020: add dtsi file

2020-02-20 Thread Lukasz Majewski
Hi Giulio, > Add dtsi file for i.MXRT1020. > Has this file been ported from Linux kernel? Or is it only available in U-Boot? Reviewed-by: Lukasz Majewski > Signed-off-by: Giulio Benetti > --- > arch/arm/dts/imxrt1020.dtsi | 133 > 1

Re: [PATCH 4/5] dt-bindings: pinctrl: add i.MXRT1020 pins definition

2020-02-20 Thread Lukasz Majewski
On Tue, 18 Feb 2020 20:02:54 +0100 Giulio Benetti wrote: > Add i.MXRT1020 pins definition. Are those definitions ported from Linux kernel? > > Signed-off-by: Giulio Benetti > --- > include/dt-bindings/pinctrl/pins-imxrt1020.h | 763 > +++ 1 file changed, 763 insertions(+) > c

Re: [PATCH 5/5] Add support for i.MXRT1020-EVK board

2020-02-20 Thread Lukasz Majewski
ON is not set > +CONFIG_OF_CONTROL=y > +CONFIG_SPL_OF_CONTROL=y > +CONFIG_DEFAULT_DEVICE_TREE="imxrt1020-evk" > +CONFIG_ENV_IS_NOWHERE=y > +CONFIG_ENV_IS_IN_MMC=y > +CONFIG_SYS_RELOC_GD_ENV_ADDR=y > +CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y > +CONFIG_TFTP_BLOCKSIZE=512 >

Re: [PATCH] usb: gadget: Handle SPL_* configs

2020-02-21 Thread Lukasz Majewski
Hi Nathan, > On Tue, 28 Jan 2020 at 20:26, Lukasz Majewski wrote: > > > > On Tue, 28 Jan 2020 17:50:03 +1000 > > Nathan Rossi wrote: > > > > > On Mon, 27 Jan 2020 at 22:51, Lukasz Majewski > > > wrote: > > > > > > > >

Re: [PATCH 1/3] clk: imx: imx8mn: add enet clk

2020-02-21 Thread Lukasz Majewski
Hi Alifer, > Hello Lukasz, > > > Why have you sent those patches twice? > > > > I'm sorry for that, I was just curious if you made a v2 :-) > the first time I sent this patch I forgot to send > to u-boot lists too, so I sent it again. > > Re

[GIT] Pull request: u-boot-dfu (21.02.2020)

2020-02-21 Thread Lukasz Majewski
two patches as FIXES. Travis-CI: https://travis-ci.org/lmajewski/u-boot-dfu/builds/653370363 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax:

[PATCH 0/3] clk: Fix ETH initialization on i.MX6Q boards using CCF

2020-02-24 Thread Lukasz Majewski
those clocks supported in CCF resulted in non-functional ETH. Lukasz Majewski (3): clk: imx6: Add definition for IMX6QDL_CLK_ENET clock clk: imx: Add support for pllv3 enet clock clk: imx6: Add definition for IMX6QDL_CLK_ENET_REF clock drivers/clk/imx/clk-imx6q.c | 8 dr

[PATCH 3/3] clk: imx6: Add definition for IMX6QDL_CLK_ENET_REF clock

2020-02-24 Thread Lukasz Majewski
ange models the simplest case when enet reference clock is generated from 'osc' clock. Signed-off-by: Lukasz Majewski --- drivers/clk/imx/clk-imx6q.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c index ace60ecec6

[PATCH 1/3] clk: imx6: Add definition for IMX6QDL_CLK_ENET clock

2020-02-24 Thread Lukasz Majewski
After commit 673f6597321d ("net: fec_mxc: support i.MX8M with CLK_CCF") all NXP boards, which are not IMX8 and in the same time are supporting CCF need to provide IMX6QDL_CLK_ENET. This change defines the missing clock in i.MX6Q's CCF. Signed-off-by: Lukasz Majewski --- driv

[PATCH 2/3] clk: imx: Add support for pllv3 enet clock

2020-02-24 Thread Lukasz Majewski
This code has been ported from Linux kernel v5.5.5 (tag) and has been adjusted to U-Boot's DM. It adds support for correct recognition of IMX_PLLV3_ENET flag in the clk-pllv3.c driver. Signed-off-by: Lukasz Majewski --- drivers/clk/imx/clk-pllv3.c | 25 + 1

Re: [U-Boot] [PATCH] usb: ehci-mx5: Fix bus enumeration for DM case

2020-02-24 Thread Lukasz Majewski
0; > > +} > > + > > static int ehci_usb_probe(struct udevice *dev) > > { > > struct usb_platdata *plat = dev_get_platdata(dev); > > @@ -362,6 +378,7 @@ U_BOOT_DRIVER(usb_mx5) = { > > .id = UCLASS_USB, > > .of_match = mx5_usb_ids, > > .ofdata_to_p

Re: [U-Boot] [PATCH] usb: ehci-mx5: Fix bus enumeration for DM case

2020-02-26 Thread Lukasz Majewski
Dear Marek, > On 2/24/20 4:28 PM, Lukasz Majewski wrote: > > Hi Marek, > > Hi, > > >> On Thu, 20 Jun 2019 22:53:58 +0200 > >> Marek Vasut wrote: > >> > >>> It is likely that the DM conversion of EHCI iMX5 driver was a > >>&g

Re: [PATCH 1/2] configs: migrate CONFIG_SET_DFU_ALT_INFO to defconfigs

2020-02-26 Thread Lukasz Majewski
Hi Patrick, > Move CONFIG_SET_DFU_ALT_INFO into Kconfig done by moveconfig.py. Thank you for the conversion. Acked-by: Lukasz Majewski > > Signed-off-by: Patrick Delaunay > --- > > configs/odroid-xu3_defconfig| 1 + > configs/odroid_defconfig

[PATCH] usb: ehci: Fix "EHCI timed out on TD - token=XXXX" error on ehci-hcd

2020-02-26 Thread Lukasz Majewski
69440 bytes read in 979 ms (16.4 MiB/s) With this patch: 16869440 bytes read in 1219 ms (13.2 MiB/s) Links: [1] - https://forum.doozan.com/read.php?3,35295,35295#msg-35295 [2] - https://www.dropbox.com/s/nrkrd1no63viuu8/uboot-bodhi-2016.05-timeoutTD.patch?dl=0 Signed-off-by: Lukasz Majewski [

[PATCH 0/4] imx: Fixes for i.MX53 based HSC|DDC boards

2020-02-26 Thread Lukasz Majewski
on top of SHA1: 133276f14acfbad4268acd19a70d3cda0a60b5e3 Lukasz Majewski (4): config: cosmetic: Cleanup of imx53 - HSC and DDC config file dts: imx: Add fixed-link property to HSC and DDC (imx53) devices config: imx: Enable CONFIG_PHY_FIXED on HSC and DDC i.MX53 boards imx: pmic: Set p

[PATCH 1/4] config: cosmetic: Cleanup of imx53 - HSC and DDC config file

2020-02-26 Thread Lukasz Majewski
This change was introduced after running make savedefconfig on newest master U-Boot (SHA1: 8e51bf746a11d7f67416859). Signed-off-by: Lukasz Majewski --- configs/kp_imx53_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/kp_imx53_defconfig b/configs

[PATCH 3/4] config: imx: Enable CONFIG_PHY_FIXED on HSC and DDC i.MX53 boards

2020-02-26 Thread Lukasz Majewski
ame U-Boot binary. Signed-off-by: Lukasz Majewski --- configs/kp_imx53_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/kp_imx53_defconfig b/configs/kp_imx53_defconfig index f29dec0161..096ba53236 100644 --- a/configs/kp_imx53_defconfig +++ b/configs/kp_imx53_defconfig @@ -

[PATCH 4/4] imx: pmic: Set proper pmic name for iMX53 HSC|DDC boards

2020-02-26 Thread Lukasz Majewski
After the commit 4213609cc7fb ("drivers: core: use strcmp when find device by name") the exact DTS node name for PMIC device must be provided. This patch fixes this issue by providing full DTS node name ('mc34708@8'). Signed-off-by: Lukasz Majewski --- board/k+p/kp_imx53/

[PATCH 2/4] dts: imx: Add fixed-link property to HSC and DDC (imx53) devices

2020-02-26 Thread Lukasz Majewski
d == 0 are not created in U-Boot anymore. This caused regression on HSC. To fix this problem - the fec's 'fixed-link' node has been introduced and the phy_id is not assessed anymore. This approach works on both boards. Signed-off-by: Lukasz Majewski --- arch/arm/dts/imx53-kp-u-boot

Re: [ANN] U-Boot v2020.04-rc3 released

2020-02-26 Thread Lukasz Majewski
;t make rc3. > > And I think this is coming via the USB tree perhaps? I've sent PR on last Friday (with Andy on CC): [GIT] Pull request: u-boot-dfu (21.02.2020) It shall be pulled by Marek soon to the u-boot-usb tree. > Or is it in the > clk part itself? Thanks! > Best

<    1   2   3   4   5   6   7   8   9   10   >