eanups
v2:
- add to buffalo vendor directory instead of Marvell
- add both boards to MAINTAINERS
- don't define values for feature macros
- use tab for vertical alignment
- remove static network configuration, instead introduce a rescue mode
- add some convenience scripts
- small cl
It's a PRNG using the simple and fast xorshift method.
Signed-off-by: Michael Walle
---
include/common.h |4
lib/Makefile |1 +
lib/rand.c | 43 +++
3 files changed, 48 insertions(+), 0 deletions(-)
create mode 100644 lib/r
To ease building the required u-boot image add the kwb image to the build
targets for the LS-CHLv2 and LS-XHL board.
Signed-off-by: Michael Walle
---
board/buffalo/lsxl/config.mk |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
create mode 100644 board/buffalo/lsxl/config.mk
diff
Add new function eth_random_enetaddr() to generate a locally administered
ethernet address.
Signed-off-by: Michael Walle
---
include/net.h | 15 +++
net/eth.c | 15 +++
2 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/include/net.h b/include/net.h
Signed-off-by: Michael Walle
---
include/net.h | 12
net/eth.c |8
2 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/include/net.h b/include/net.h
index 1fceb99..c57c6d8 100644
--- a/include/net.h
+++ b/include/net.h
@@ -118,6 +118,18 @@ extern int
This patch adds support for both the Linkstation Live (LS-CHLv2) and
Linkstation Pro (LS-XHL) by Buffalo.
Signed-off-by: Michael Walle
Cc: Prafulla Wadaskar
Cc: Wolfgang Denk
---
MAINTAINERS |5 +
board/buffalo/lsxl/Makefile | 50 ++
board/buffalo
Hi Mike,
Am Sonntag 01 April 2012, 21:34:26 schrieb Mike Frysinger:
> On Saturday 31 March 2012 08:38:33 Michael Walle wrote:
> > --- a/include/net.h
> > +++ b/include/net.h
> >
> > in emergency cases, where you need a working network connection to seti
>
> &quo
Before the actual initialization do a hard reset of the SATA port and the
connected device.
Signed-off-by: Michael Walle
Cc: Prafulla Wadaskar
---
drivers/block/mvsata_ide.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/drivers/block/mvsata_ide.c b/drivers
Hi,
i'm currently developing a BSP for the Buffalo LS-XHL (ARM based) and stumble
across the two LED APIs.
Is there any particular reason to have two different APIs? I guess an ARM BSP
has to support both? Eg. the 'classic status API' is used in cmd_ide.c for
example and the ARM one is used i
Hi Wolfgang,
Am Montag 02 Mai 2011, 22:36:22 schrieb Wolfgang Denk:
> Dear Michael Walle,
>
> In message <201105022219.58458.mich...@walle.cc> you wrote:
> > i'm currently developing a BSP for the Buffalo LS-XHL (ARM based) and
> > stumble across the two
Am Di, 3.05.2011, 00:45, schrieb Tom Warren:
> Signed-off-by: Tom Warren
> ---
> Changes in V2:
> - use 'gpio_pin' enum in gpio.h (Simon Glass review request)
> - change 'GPIO_PORT8' to 'GPIO_FULLPORT' (Simon Glass request)
> - change 'offset' to 'pin' globally
>
> arch/arm/incl
Am Montag 02 Mai 2011, 10:37:41 schrieb Prafulla Wadaskar:
> > -Original Message-
> > From: Michael Walle [mailto:mich...@walle.cc]
> > Sent: Monday, May 02, 2011 3:35 AM
> > To: u-boot@lists.denx.de
> > Cc: Michael Walle; Prafulla Wadaskar
> > Subject:
Hi Albert,
Am Dienstag 10 Mai 2011, 23:47:04 schrieben Sie:
> Hi Michael,
>
> Sorry for the delay. Busy period for me I'm afraid.
no problem ;)
> Le 09/05/2011 19:49, Michael Walle a écrit :
> > Am Montag 02 Mai 2011, 10:37:41 schrieb Prafulla Wadaskar:
>
Before the actual initialization do a hard reset of the SATA port and the
connected device.
changes v1->v2:
- add comment for udelay
Signed-off-by: Michael Walle
Cc: Prafulla Wadaskar
Cc: Albert Aribaud
---
drivers/block/mvsata_ide.c | 10 +-
1 files changed, 9 insertions(+)
Am Donnerstag 12 Mai 2011, 00:22:46 schrieb Michael Walle:
> Before the actual initialization do a hard reset of the SATA port and the
> connected device.
>
> changes v1->v2:
> - add comment for udelay
ping? :)
--
Michael
___
U-B
Am Freitag 21 Oktober 2011, 10:09:15 schrieben Sie:
> > -Original Message-
> > From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
> > On Behalf Of Michael Walle
> > Sent: Friday, October 07, 2011 3:53 AM
> > To: u-boot@lists.denx.de
>
Am Do, 27.10.2011, 11:12 schrieb Prafulla Wadaskar:
>> > If I understood it correctly,
>> > In current implementation, if only egiga1 device is enabled
>> on the board,
>> > then it will assign MAC address associated with environment
>> variable
>> > "ethaddr".
>> yes but the current mvgbe driver w
Signed-off-by: Michael Walle
Cc: Albert ARIBAUD
Cc: Prafulla Wadaskar
---
arch/arm/include/asm/arch-kirkwood/config.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/include/asm/arch-kirkwood/config.h
b/arch/arm/include/asm/arch-kirkwood/config.h
index
This patchset introduces a new element "index" within the eth_device
structure, which is populated by eth_register(). The second patch uses this
element to get the right name of the environment variable for the ethernet
hardware address.
___
U-Boot maili
Don't assume that the MAC address of egiga0 rsp. egiga1 is ethaddr rsp.
eth1addr. If there is only a egiga1 device, u-boot will enumerate it as
device 0. Instead use the correct index number stored within the eth_device
structure.
Signed-off-by: Michael Walle
Cc: Prafulla Wadaskar
---
dr
o get the
correct environment ethaddr name.
Signed-off-by: Michael Walle
Cc: Prafulla Wadaskar
Cc: Mike Frysinger
Cc: Wolfgang Denk
---
include/net.h |1 +
net/eth.c | 41 -
2 files changed, 13 insertions(+), 29 deletions(-)
diff --git a/in
Am Donnerstag 27 Oktober 2011, 23:31:35 schrieb Michael Walle:
> Instead of counting the device index everytime a functions needs it, store
> it in the eth_device struct. eth_register() keeps track of the indices and
> updates the device's index number. This simplifies some func
Am Do, 27.10.2011, 22:31 schrieb Michael Walle:
> Instead of counting the device index everytime a functions needs it, store
> it in the eth_device struct. eth_register() keeps track of the indices and
> updates the device's index number. This simplifies some functions
Am Donnerstag 03 November 2011, 19:10:57 schrieb Mike Frysinger:
> On Thursday 27 October 2011 17:31:36 Michael Walle wrote:
> > --- a/drivers/net/mvgbe.c
> > +++ b/drivers/net/mvgbe.c
> >
> > + /* Extract the MAC address from the environme
randomization is
needed.
All boards which have CONFIG_SKIP_LOCAL_MAC_RANDOMIZATION set (actually its
only one board, edminiv2) are converted to use CONFIG_ETHADDR. Please check
your boards whether you really need randomization support or the
CONFIG_ETHADDR macro is enough.
Signed-off-by: Michael Walle
Cc
Am Di, 8.11.2011, 14:57 schrieb Mike Frysinger:
> On Monday 07 November 2011 17:08:09 Michael Walle wrote:
>> drivers/net/mvgbe.c| 23 ---
>
> ACK to the changes to this file
>
>> --- a/include/configs/edminiv2.h
>> +++ b/include/con
Hi Wolfgang, Hi Mike,
Am Di, 8.11.2011, 16:17 schrieb Wolfgang Denk:
> Dear "Michael Walle",
>
> In message <89e599b8867346f857ae2f132e9717a3.squir...@ssl.serverraum.org>
> you wrote:
>>
>> >> +#define CONFIG_ETH_ADDR 02:50:43:00:00:01
>>
Am Dienstag 08 November 2011, 20:28:19 schrieb Wolfgang Denk:
> Dear "Michael Walle",
>
> In message <45fd92b472c944e2cb9ebb409488ccfc.squir...@ssl.serverraum.org>
you wrote:
> > If someone will mess up the environment, it is possible to clear it by
> > hold
Am Dienstag 08 November 2011, 21:49:49 schrieb Mike Frysinger:
> On Tuesday 08 November 2011 12:34:17 Michael Walle wrote:
> > Am Di, 8.11.2011, 16:17 schrieb Wolfgang Denk:
> > > Michael Walle wrote:
> > >> >> +#define CONFIG_ETH_ADDR 02:50:43:00:00:01
&g
Am Dienstag 08 November 2011, 23:52:56 schrieb Wolfgang Denk:
> > thanks for the hint, but there is only 512kb flash on this board (with
> > 64k sectors). I don't think there is enough room for a second copy of
> > the environment.
>
> You don't need a separate sector. How bis is your environment
Am Mi, 9.11.2011, 00:26 schrieb Michael Walle:
> atm there is the mvgbe driver:
> - which has a hardcoded mac address (or if enabled, a randomized mac
> address)
>and
> - touches the environment
oh and i've forgot to mention, that the driver is broken for b
>> atm there is the mvgbe driver:
>> - which has a hardcoded mac address (or if enabled, a randomized mac
>> address)
>>and
>> - touches the environment
>
> oh and i've forgot to mention, that the driver is broken for boards with
>
> #define CONFIG_MVGBE_PORTS {0,1}
>
> which is the reason w
Hi Wolfgang,
>> So was there any conclusion, now? Never touch mvgbe.c anymore?
> Let's remove this broken code.
This is exactly part of this patch ([PATCH] mvgbe: remove setting of
ethaddr within the driver). This part, while ACK'ed by Mike, was NAK'ed by
Prafulla.
--
Michael
Am Donnerstag 10 November 2011, 15:21:53 schrieb Simon Guinot:
> For this boards a random MAC address is used and the computation is
> performed by the driver mvgbe. If this code is simply removed, the
> network initialization for this boards will break.
Moving this feature into some common code w
Hi,
Does u-boot always follow the mach-types.h from upstream linux? Is there any
policy?
If thats true, it means, that
- every supported board in u-boot has to be supported in mainline linux,
too. because that is the basic requirement for an entry to stay in this
file.
- a device with de
Am Sonntag 13 November 2011, 01:32:03 schrieb Marek Vasut:
> > - every supported board in u-boot has to be supported in mainline linux,
> >
> >too. because that is the basic requirement for an entry to stay in
> >this file.
>
> No, you can define CONFIG_MACH_TYPE MACH_TYPE_SOMETHING and
Am Sonntag 13 November 2011, 17:18:27 schrieb Marek Vasut:
> > Am Sonntag 13 November 2011, 01:32:03 schrieb Marek Vasut:
> > > > - every supported board in u-boot has to be supported in mainline
> > > > linux,
> > > >
> > > >too. because that is the basic requirement for an entry to stay i
Am Sonntag 13 November 2011, 18:14:16 schrieb Marek Vasut:
> > Am Sonntag 13 November 2011, 17:18:27 schrieb Marek Vasut:
> > > > Am Sonntag 13 November 2011, 01:32:03 schrieb Marek Vasut:
> > > > > > - every supported board in u-boot has to be supported in
> > > > > > mainline linux,
> > > > > >
Hi Wolfgang,
Am Donnerstag 10 November 2011, 12:44:26 schrieb Wolfgang Denk:
> Dear Prafulla,
>
> In message <48935aa530a6457b76b9915a1fe7faf9.squir...@ssl.serverraum.org>
Michael Walle wrote:
> > >> So was there any conclusion, now? Never touch mvgbe.c anymore?
>
A network driver should not touch the environment at all. This patch fixes
this behaviour by removing the code for setting a default/randomized MAC
address.
Signed-off-by: Michael Walle
Acked-by: Mike Frysinger
Acked-by: Prafulla Wadaskar
Cc: Mike Frysinger
Cc: Prafulla Wadaskar
Cc: Valentin
Cc: Prafulla Wadaskar
Signed-off-by: Michael Walle
---
Changes v2:
- none
---
include/configs/lsxl.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h
index 2ae8a27..4ad5eb8 100644
--- a/include/configs/lsxl.h
+++ b/include/configs/lsxl.h
restore the behaviour of the original bootloader.
Cc: Prafulla Wadaskar
Cc: Tom Rini
Signed-off-by: Michael Walle
---
Changes v2:
- use CONFIG_CMD_FS_GENERIC and load commands (suggested by Tom Rini)
- use loadaddresses at offsets 8MB and 16MB, leaving ~8MB for the kernel
please note that
Am 2014-04-01 20:09, schrieb Michael Walle:
Move addresses for kernel, ramdisk and fdt blob to own variables. Add
dtb
blob loading to all existing boot scripts, dtb filenames were taken
from
vanilla kernel. Introduce new boot script bootcmd_legacy, which only
loads
a kernel and a ramdisk. Make
Am 2014-04-01 20:09, schrieb Michael Walle:
Move addresses for kernel, ramdisk and fdt blob to own variables. Add
dtb
blob loading to all existing boot scripts, dtb filenames were taken
from
vanilla kernel. Introduce new boot script bootcmd_legacy, which only
loads
a kernel and a ramdisk. Make
Am Samstag, 19. April 2014, 23:52:19 schrieb Michael Walle:
> Am 2014-04-01 20:09, schrieb Michael Walle:
> > Move addresses for kernel, ramdisk and fdt blob to own variables. Add
> > dtb
> > blob loading to all existing boot scripts, dtb filenames were taken
> > from
&g
Esp. while printing the environment the output is usually longer than 512
bytes. Instead of cutting the message, send multiple 512 bytes packets.
Signed-off-by: Michael Walle
---
drivers/net/netconsole.c | 15 +++
1 files changed, 11 insertions(+), 4 deletions(-)
diff --git a
The spi_init() function is missing. Add it.
Signed-off-by: Michael Walle
---
drivers/spi/kirkwood_spi.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
index a1c3070..8c35d5e 100644
--- a/drivers/spi
Call ide_init() in the board initialization if IDE support is compiled in.
Signed-off-by: Michael Walle
---
arch/arm/lib/board.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
index 705d4d2..9addab8 100644
--- a/arch/arm
Don't assume that the MAC address of egiga0 rsp. egiga1 is ethaddr rsp.
eth1addr. If there is only a egiga1 device, u-boot will enumerate it as
device 0 and therefore the MAC address is set with the environmen varibale
ethaddr.
Signed-off-by: Michael Walle
---
drivers/net/mvgbe.c |
Am Fr, 7.10.2011, 10:26 schrieb Prafulla Wadaskar:
>> -Original Message-
>> From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
>> On Behalf Of Michael Walle
>> Sent: Friday, October 07, 2011 3:53 AM
>> To: u-boot@lists.denx.de
>>
Am Freitag 07 Oktober 2011, 19:27:11 schrieb Mike Frysinger:
> On Thursday 06 October 2011 18:23:06 Michael Walle wrote:
> > --- a/arch/arm/lib/board.c
> > +++ b/arch/arm/lib/board.c
> >
> > +#if defined(CONFIG_CMD_IDE)
> > + puts ("IDE: ");
> >
Esp. while printing the environment the output is usually longer than 512
bytes. Instead of cutting the message, send multiple 512 bytes packets.
Signed-off-by: Michael Walle
---
drivers/net/netconsole.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers
Am Samstag 08 Oktober 2011, 00:53:13 schrieb Mike Frysinger:
> On Friday 07 October 2011 18:27:50 Michael Walle wrote:
> > Esp. while printing the environment the output is usually longer than 512
> > bytes. Instead of cutting the message, send multiple 512 bytes packets.
>
&
Am Freitag 07 Oktober 2011, 12:48:40 schrieb Michael Walle:
> Am Fr, 7.10.2011, 10:26 schrieb Prafulla Wadaskar:
> >> -Original Message-
> >> From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
> >> On Behalf Of Michael Walle
> >>
Am Freitag 07 Oktober 2011, 00:23:54 schrieb Michael Walle:
> The spi_init() function is missing. Add it.
>
> Signed-off-by: Michael Walle
> ---
> drivers/spi/kirkwood_spi.c |4
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/
Call ide_init() in the board initialization if IDE support is compiled in.
Signed-off-by: Michael Walle
---
changes in v2:
- style fix: remove whitespace before parenthesis
---
arch/arm/lib/board.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib
Hi Wolfgang,
Am Sonntag 16 Oktober 2011, 22:25:11 schrieb Wolfgang Denk:
> In message <201110162032.02236.mich...@walle.cc> you wrote:
> > > The spi_init() function is missing. Add it.
> > >
> > > Signed-off-by: Michael Walle
>
> ...
>
> >
Hi Prafulla,
Am Donnerstag 04 Oktober 2012, 18:54:25 schrieb Michael Walle:
> Instead of using the serverip we get from the DHCP server, implicitly use
> the broadcast address, which is automatically set when no ncip environment
> variable is set. That way it isn't necessary to
Hi Tom, Hi Prafulla,
Am Sonntag 04 November 2012, 19:49:59 schrieb Tom Rini:
> Hey all,
>
> With the official closing of the merge window just past us now, I've
> tagged v2013.01-rc1.
Wow that was fast ;)
Prafulla, Tom, can someone of you take care of the following patch:
http://patchwork.oz
Hi Joe,
Am 2015-05-04 21:55, schrieb Joe Hershberger:
diff --git a/board/buffalo/lsxl/lsxl.c b/board/buffalo/lsxl/lsxl.c
index 487875c..45dd788 100644
--- a/board/buffalo/lsxl/lsxl.c
+++ b/board/buffalo/lsxl/lsxl.c
@@ -230,16 +230,6 @@ static void rescue_mode(void)
uchar enetaddr[6];
gain, sorry for the noise :(
Acked-By: Michael Walle (for the lsxl board part)
-michael
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Synchronize it with the LS-XHL board.
Signed-off-by: Michael Walle
---
configs/lschlv2_defconfig | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/configs/lschlv2_defconfig b/configs/lschlv2_defconfig
index 23e68a00ea..f2763221a1 100644
--- a/configs
https://patchwork.ozlabs.org/patch/909973/
Signed-off-by: Michael Walle
Tested-by: Michael Walle
---
arch/arm/dts/kirkwood-lsxl.dtsi | 4
arch/arm/mach-kirkwood/include/mach/config.h | 1 -
configs/lschlv2_defconfig| 3 +++
configs/lsxhl_defc
Am 6. Juni 2018 11:38:56 MESZ schrieb Bastian Germann
:
>Signed-off-by: Bastian Germann
>---
> board/buffalo/lsxl/README | 17 -
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
>diff --git a/board/buffalo/lsxl/README b/board/buffalo/lsxl/README
>index ef5ed42880..3ede081776 100
Am 2018-06-07 11:07, schrieb Bastian Germann:
Hello Michael,
I tried to use the MTD layer but that did not work even though I set
the
flash in the Linux device tree read-write. I cannot remember the output
exactly as it is some time ago that I tried (with Debian).
Cheers,
Bastian
+ flashro
Hi Chris,
thanks for your efforts. This basically works for me on my Kirkwood
LSCHLv2 board. So you may add
Tested-by: Michael Walle
But there are some issues. See below.
[snip]
-#if defined(CONFIG_PHYLIB)
+#if defined(CONFIG_PHYLIB) || defined(CONFIG_DM_ETH)
+#if defined(CONFIG_DM_ETH
Am 2018-05-08 00:54, schrieb Chris Packham:
This matches the compatible string used by the Linux kernel. This will
allow u-boot to use the same device tree files.
This patch is still missing to make SPI on kirkwoods work. Is there
anything missing which prevents it from being applied?
-micha
phy-mode property to my dts ;) Will
post a patch for lsxl later.
Tested-by: Michael Walle
---
Changes in v3:
- select PHYLIB (thanks Michael)
- parse phy info from subnode
Changes in v2:
- create __mvgbe_phy_init and mvgbe_alloc_buffers helper functions
- move device tree reads to
Am 2018-11-05 10:58, schrieb Jagan Teki:
On Mon, May 7, 2018 at 2:40 PM Jagan Teki
wrote:
kirkwood now support dt along with platform data,
respective boards need to switch into dm for the same.
Signed-off-by: Jagan Teki
---
Changes for v3:
- rebased master
- Move kconfig option if DM_SPI
[CC Wolfgang because he's the ppc maintainer]
Hi,
I've build a powerpc64 cross compile toolchain with multilib support
(using http://crosstool-ng.org/). Eg. the default one is 64bit and you
can choose a 32 bit compile with "-m32". I can compile the bootloader
but linking fails with "libgcc no
Hi Tom, Uma and all,
there doesn't seem to be a dedicated filesystem maintainer, but I've
included the original committer for the ext4 write support.
I guess the ext4 write support does not work on big-endian machines. As
far as I see, almost no fields of the ext4 structures within the write
Am 2016-08-05 14:06, schrieb Michael Walle:
Hi Tom, Uma and all,
there doesn't seem to be a dedicated filesystem maintainer, but I've
included the original committer for the ext4 write support.
Hm, no Uma :(
: host mailin.samsung.com[203.254.224.12] said:
550 5.1.1 Recipie
Am 2016-08-05 14:06, schrieb Michael Walle:
there doesn't seem to be a dedicated filesystem maintainer, but I've
included the original committer for the ext4 write support.
I guess the ext4 write support does not work on big-endian machines.
As far as I see, almost no fields o
le32_to_cpu() must only convert the revision_level and not the boolean
result.
Signed-off-by: Michael Walle
---
fs/ext4/ext4_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c
index 4eb4e18..b00b84f 100644
--- a/fs/ext4
Instead of __{be,le}{16,32}_to_cpu use {be,le}{16,32}_to_cpu.
Signed-off-by: Michael Walle
---
fs/ext4/ext4_common.c | 90 +--
fs/ext4/ext4_write.c | 14
fs/ext4/ext4fs.c | 2 +-
include/ext_common.h | 4 +--
4 files changed, 55
Change all the types of ext2/4 fields to little endian types and all the
JBD fields to big endian types. Now we can use sparse (make C=1) to check
for statements where we need byteswaps.
Signed-off-by: Michael Walle
---
fs/ext4/ext4_journal.h | 40 +++
include/ext_common.h | 136
All fields were accessed directly instead of using the proper byte swap
functions. Thus, ext4 write support was only usable on little-endian
architectures. Fix this.
Signed-off-by: Michael Walle
---
Ok this patch is huge, please comment. I know, checkpatch fails because
there are longer lines
Am 2016-08-14 03:50, schrieb Stefan Bruens:
On Freitag, 12. August 2016 15:16:20 CEST Michael Walle wrote:
All fields were accessed directly instead of using the proper byte
swap
functions. Thus, ext4 write support was only usable on little-endian
architectures. Fix this.
Signed-off-by
Hi Stefan,
Am 2016-08-14 03:50, schrieb Stefan Bruens:
On Freitag, 12. August 2016 15:16:20 CEST Michael Walle wrote:
All fields were accessed directly instead of using the proper byte
swap
functions. Thus, ext4 write support was only usable on little-endian
architectures. Fix this.
Signed
From: Michael Walle
This patch series fixes write support on big-endianness architectures.
Changes:
v2:
- instead of INC_X/DEC_X macros, use inline functions per structure
field. Suggested by Stefan Brüns. (patch 0003)
- optimize "while (dir->direntlen)" loops. Sugges
Change all the types of ext2/4 fields to little endian types and all the
JBD fields to big endian types. Now we can use sparse (make C=1) to check
for statements where we need byteswaps.
Signed-off-by: Michael Walle
---
fs/ext4/ext4_journal.h | 40 +++
include/ext_common.h | 136
All fields were accessed directly instead of using the proper byte swap
functions. Thus, ext4 write support was only usable on little-endian
architectures. Fix this.
Signed-off-by: Michael Walle
Reviewed-by: Stefan Brüns
Tested-by: Stefan Brüns
---
fs/ext4/ext4_common.c | 277
Instead of __{be,le}{16,32}_to_cpu use {be,le}{16,32}_to_cpu.
Signed-off-by: Michael Walle
---
fs/ext4/ext4_common.c | 90 +--
fs/ext4/ext4_write.c | 14
fs/ext4/ext4fs.c | 2 +-
include/ext_common.h | 4 +--
4 files changed, 55
direntlen is always >= 8. Therefore, the loop condition is always true.
Signed-off-by: Michael Walle
Suggested-by: Stefan Brüns
---
fs/ext4/ext4_common.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c
index 4a00
le32_to_cpu() must only convert the revision_level and not the boolean
result.
Signed-off-by: Michael Walle
---
fs/ext4/ext4_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c
index 567350f..4a003cf 100644
--- a/fs/ext4
irentlen)" loops. Suggested by Stefan Brüns
(patch 0005)
Michael Walle (4):
ext4: change structure fields to __le/__be types
ext4: use kernel names for byte swaps
ext4: fix endianess problems in ext4 write support
ext4: fix wrong usage of le32_to_cpu()
fs/ext4/ext4_co
Change all the types of ext2/4 fields to little endian types and all the
JBD fields to big endian types. Now we can use sparse (make C=1) to check
for statements where we need byteswaps.
Signed-off-by: Michael Walle
---
fs/ext4/ext4_journal.h | 40 +++
include/ext_common.h | 136
Instead of __{be,le}{16,32}_to_cpu use {be,le}{16,32}_to_cpu.
Signed-off-by: Michael Walle
---
fs/ext4/ext4_common.c | 90 +--
fs/ext4/ext4_write.c | 14
fs/ext4/ext4fs.c | 2 +-
include/ext_common.h | 4 +--
4 files changed, 55
All fields were accessed directly instead of using the proper byte swap
functions. Thus, ext4 write support was only usable on little-endian
architectures. Fix this.
Signed-off-by: Michael Walle
Reviewed-by: Stefan Brüns
Tested-by: Stefan Brüns
---
fs/ext4/ext4_common.c | 277
le32_to_cpu() must only convert the revision_level and not the boolean
result.
Signed-off-by: Michael Walle
---
fs/ext4/ext4_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c
index 567350f..4a003cf 100644
--- a/fs/ext4
Am 2016-08-29 10:46, schrieb Michael Walle:
[..snip..]
@@ -149,10 +169,10 @@ static void delete_double_indirect_block(struct
ext2_inode *inode)
int i;
short status;
static int prev_bg_bmap_idx = -1;
- long int blknr;
+ uint32_t blknr;
int remainder
All fields were accessed directly instead of using the proper byte swap
functions. Thus, ext4 write support was only usable on little-endian
architectures. Fix this.
Signed-off-by: Michael Walle
---
Changes:
v4:
- convert "unsigned int" to __le32 pointer in
delete_{dou
Hi Chris,
Am 2019-03-13 08:47, schrieb Chris Packham:
Enable CONFIG_DM_USB and CONFIG_BLK.
Signed-off-by: Chris Packham
Reviewed-by: Stefan Roese
Tested-by: Michael Walle
works at least after I switch off the dcache, but that another issue ;)
Thanks,
-michael
---
Changes in v3: None
Both the network as well as the USB driver are not working with the
data cache enabled.
Signed-off-by: Michael Walle
---
include/configs/lsxl.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h
index 9d4be18413..728263910e 100644
--- a/include
Please note that this patchset depends on the following series:
https://patchwork.ozlabs.org/cover/1055937/
(ARM: kirkwood: migrate to DM_USB)
https://patchwork.ozlabs.org/patch/1054403/
(sata: sata_mv: Add DM support to enable CONFIG_BLK usage)
Michael Walle (4):
sata: sata_mv: use
Fix the worng include and offset macros.
Signed-off-by: Michael Walle
---
drivers/ata/sata_mv.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 87ea95f75d..b691107dc0 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers
This fixes a compile error on kirkwood.
Signed-off-by: Michael Walle
---
drivers/ata/sata_mv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index d13695d79e..87ea95f75d 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata
The kirkwood devices are compatible with this driver.
Signed-off-by: Michael Walle
---
drivers/ata/sata_mv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index b691107dc0..2a630d46c1 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata
Switch from legacy IDE driver to sata_mv driver.
Signed-off-by: Michael Walle
---
configs/lschlv2_defconfig | 4 ++--
configs/lsxhl_defconfig | 4 ++--
include/configs/lsxl.h| 23 ++-
3 files changed, 14 insertions(+), 17 deletions(-)
diff --git a/configs
Add a command to control the watchdog devices. This is useful if the
watchdog is rather long running (eg. seconds) and it should be
controlled by scripts. It is also handy during debugging.
Signed-off-by: Michael Walle
---
cmd/Kconfig | 6 +++
cmd/Makefile | 1 +
cmd/wdt.c| 174
601 - 700 of 1166 matches
Mail list logo