Re: [PATCH v2 1/2] firmware: zynqmp: Add support to access efuses

2024-05-29 Thread Michal Simek
On 5/15/24 14:41, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke Add functions to access efuses through PMU firmware interface. Signed-off-by: Lukas Funke --- (no changes since v1) drivers/firmware/firmware-zynqmp.c | 31 ++ include/zynqmp_firmwar

Re: [PATCH] xilinx: versal: Do not prioritize boot device if driver is not enabled

2024-05-29 Thread Michal Simek
On 5/10/24 08:22, Michal Simek wrote: From: Venkatesh Yadav Abbarapu SOC can boot out of the device which is not accessible from APU and running this is detected as a warning, as the device is not accessible.For example getting below warning when the boot mode is OSPI and OSPI is not

Re: [PATCH ] mtd: spi-nor: Add SPI_NOR_OCTAL_READ flag for mx66uw2g345gx0 flash part

2024-05-29 Thread Michal Simek
On 5/8/24 07:27, Prasad Kummari wrote: Added SPI_NOR_OCTAL_READ flag for Macronix mx66uw2g345gx0 2Gb(256MB) NOR Flash memory has been added. Initial testing was conducted on the I fixed this commit message. Versal NET board using SDR mode, which included basic erase, write, and read-back o

Re: [PATCH v2] xilinx: zynqmp: Allow multiboot environment write even in saved environment

2024-05-29 Thread Michal Simek
On 5/29/24 12:01, Kory Maincent wrote: Once the environment was saved, the current multiboot image information became unreachable. When dealing with firmware updates, this information is necessary alongside the saved environment to know the booted image. Move the multiboot environment set ope

Re: [PATCH] xilinx: zynqmp: Allow multiboot environment write even in saved environment

2024-05-28 Thread Michal Simek
On 5/28/24 17:11, Kory Maincent wrote: On Tue, 28 May 2024 16:53:42 +0200 Michal Simek wrote: On 5/28/24 16:36, Kory Maincent wrote: Once the environment was saved, we could not retrieve information about nit: use imperative mood. Ah indeed. the multiboot image used. When dealing

Re: [PATCH] xilinx: zynqmp: Allow multiboot environment write even in saved environment

2024-05-28 Thread Michal Simek
On 5/28/24 16:36, Kory Maincent wrote: Once the environment was saved, we could not retrieve information about nit: use imperative mood. the multiboot image used. When dealing with firmware updates, this information is necessary alongside the saved environment. what exactly are you tryin

Re: [PATCH v4] fdt: automatically add /chosen/kaslr-seed if DM_RNG is enabled

2024-05-27 Thread Michal Simek
ernel). It gets weeded out from the DTB that gets handed over via efi_install_fdt() as it would also mess up the measured boot DTB TPM measurements as well. Signed-off-by: Tim Harvey Cc: Michal Simek Cc: Andy Yan Cc: Akash Gajjar Cc: Ilias Apalodimas Cc: Simon Glass Cc: Patrick Delaunay C

Re: [PATCH] xilinx: Add option to load environment from outside of boot media

2024-05-27 Thread Michal Simek
On 5/22/24 19:47, Vasileios Amoiridis wrote: From: Vasileios Amoiridis Currently, if the environment is not in the current boot media, the env_get_location() is returning ENVL_UNKNOWN or ENVL_NOWHERE which is not true (i.e booting from FLASH with environment in eMMC). This commit adds an ext

Re: [PATCH v11 0/8] spi-nor: Add parallel and stacked memories support

2024-05-24 Thread Michal Simek
On 5/7/24 17:48, Tom Rini wrote: On Tue, May 07, 2024 at 04:15:14AM +, Abbarapu, Venkatesh wrote: + Tom Rini Do you have any comments for this series? Seems likely fine. Jagan, do you have time to put this in a PR for -next? Thanks. No reaction for quite a long time. Can you take it

Re: [PATCH v3 00/20] FWU: Add support for FWU metadata version 2

2024-05-24 Thread Michal Simek
, 216 deletions(-) create mode 100644 lib/fwu_updates/fwu_v1.c create mode 100644 lib/fwu_updates/fwu_v2.c I tested it on Kria and I can't see any issue that's why Tested-by: Michal Simek Thanks, Michal

Re: [PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver

2024-05-24 Thread Michal Simek
Hi Ilias, On 4/26/24 15:38, Michal Simek wrote: Hi, currently only DT way is supported and it is added directly to lib/smbios.c but I think DT and env is only one way how information can be found that's why this series is improving handling with using sysinfo driver which can be pla

Re: [PATCH v3] fdt: automatically add /chosen/kaslr-seed if DM_RNG is enabled

2024-05-22 Thread Michal Simek
st 22. 5. 2024 v 17:19 odesílatel Tim Harvey napsal: > > On Wed, May 22, 2024 at 12:47 AM Michal Simek wrote: > > > > > > > > On 5/21/24 22:59, Tim Harvey wrote: > > > If RANDOMIZE_BASE is enabled in the Linux kernel instructing it to > > > randomi

Re: [PATCH v3] fdt: automatically add /chosen/kaslr-seed if DM_RNG is enabled

2024-05-22 Thread Michal Simek
ernel). It gets weeded out from the DTB that gets handed over via efi_install_fdt() as it would also mess up the measured boot DTB TPM measurements as well. Signed-off-by: Tim Harvey Cc: Michal Simek Cc: Andy Yan Cc: Akash Gajjar Cc: Ilias Apalodimas Cc: Simon Glass Cc: Patrick Delaunay C

Re: [PATCH v3] fdt: automatically add /chosen/kaslr-seed if DM_RNG is enabled

2024-05-22 Thread Michal Simek
ernel). It gets weeded out from the DTB that gets handed over via efi_install_fdt() as it would also mess up the measured boot DTB TPM measurements as well. Signed-off-by: Tim Harvey Cc: Michal Simek Cc: Andy Yan Cc: Akash Gajjar Cc: Ilias Apalodimas Cc: Simon Glass Cc: Patrick Delaunay C

Re: [PATCH v2] fdt: automatically add /chosen/kaslr-seed if DM_RNG is enabled

2024-05-20 Thread Michal Simek
On 5/20/24 18:37, Tim Harvey wrote: On Mon, May 20, 2024 at 1:29 AM Michal Simek wrote: Hi Tim, On 5/16/24 17:58, Tim Harvey wrote: On Wed, May 15, 2024 at 1:50 PM Tim Harvey wrote: If RANDOMIZE_BASE is enabled in the Linux kernel instructing it to randomize the virtual address at

Re: [PATCH v2] fdt: automatically add /chosen/kaslr-seed if DM_RNG is enabled

2024-05-20 Thread Michal Simek
NING: could not set kaslr-seed %s.\n", fdt_strerror(err)); I have used debug messages to better track if error happens. I think it would be good if you can extend your code with it. Because if this fails people have to start tracking if issue is that there is RNG device or reading fails or issue with

[PATCH] xilinx: versal: Do not prioritize boot device if driver is not enabled

2024-05-09 Thread Michal Simek
-off-by: Venkatesh Yadav Abbarapu Signed-off-by: Michal Simek --- board/xilinx/versal/board.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/board/xilinx/versal/board.c b/board/xilinx/versal/board.c index 4f6d56119db1..f00605da7825 100644 --- a/board/xilinx/versal/board.c

Re: [PATCH v4] test/py: net_boot: Add test cases for net boot

2024-05-07 Thread Michal Simek
why the tests work in your case. > > > > > > > Hi, > > > > Yes, this case expects to have some default config in fit image as it > uses > > 'bootm ' command to boot, below change in fit image should work. > > > > configurations { > >

Re: [PATCH] clk: zynq: Fix EMIO clock use detection for gem0

2024-04-29 Thread Michal Simek
On 4/25/24 17:18, Ondřej Jirman wrote: On Thu, Apr 25, 2024 at 12:59:29PM GMT, Michal Simek wrote: Well, it doesn't help that the code is almost all refering to CLK_CTRL while actually accessing gem1_rclk_ctrl in the struct. In any case it can't detect the case when sourcing the

[PATCH 3/3] lib: smbios: Detect system properties via SYSINFO IDs

2024-04-26 Thread Michal Simek
introduce separate SYSINFO macros which can be used in sysinfo driver and passed to smbios structure. Signed-off-by: Michal Simek --- include/sysinfo.h | 9 + lib/smbios.c | 34 ++ 2 files changed, 35 insertions(+), 8 deletions(-) diff --git

[PATCH 1/3] xilinx: Enable SMBIOS command

2024-04-26 Thread Michal Simek
It is good to be aware what information is shared via smbios interface that's why enable it by default. Signed-off-by: Michal Simek --- configs/xilinx_versal_net_virt_defconfig | 1 + configs/xilinx_versal_virt_defconfig | 1 + configs/xilinx_zynqmp_kria_defconfig | 1 + co

[PATCH 2/3] lib: smbios: Let detect the system via sysinfo

2024-04-26 Thread Michal Simek
Currently code looks like that it sysinfo drivers are supported but actually none checking that system is detected. That's why call sysinfo_detect() to make sure that priv->detected in sysinfo uclass is setup hence information from driver can be passed to smbios. Signed-off-by: Mich

[PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver

2024-04-26 Thread Michal Simek
from smbios.c and put to sysinfo DT driver instead of implementing it directly in this generic file. Thanks, Michal Michal Simek (3): xilinx: Enable SMBIOS command lib: smbios: Let detect the system via sysinfo lib: smbios: Detect system properties via SYSINFO IDs co

Re: [PATCH] clk: zynq: Fix EMIO clock use detection for gem0

2024-04-25 Thread Michal Simek
On 4/25/24 10:23, Ondřej Jirman wrote: On Wed, Apr 24, 2024 at 04:34:05PM GMT, Michal Simek wrote: On 4/16/24 10:44, Ondřej Jirman wrote: From: Ondrej Jirman According to TRM, the bit that differentiates between MIO and EMIO clocks is bit 6. This resolves failure to set clock when using

Re: Capsule GUIDs and LVFS

2024-04-25 Thread Michal Simek
Hi, On 4/25/24 08:19, Ilias Apalodimas wrote: Hi, Richard maintains LVFS & fwupd, commonly used for firmware upgrades. We recently discussed the U-Boot status and supported devices since fwupd supports capsule updates. In order to be able to support capsule updates via LVFS manufacturers should

Re: [PATCH] clk: zynq: Fix EMIO clock use detection for gem0

2024-04-24 Thread Michal Simek
On 4/16/24 10:44, Ondřej Jirman wrote: From: Ondrej Jirman According to TRM, the bit that differentiates between MIO and EMIO clocks is bit 6. This resolves failure to set clock when using EMIO clock for ethernet. Not sure which TRM you are using but here https://docs.amd.com/r/en-US/ug58

Re: [PATCH v3 00/20] FWU: Add support for FWU metadata version 2

2024-04-24 Thread Michal Simek
On 3/22/24 11:57, Sughosh Ganu wrote: The following patch series adds support for version 2 of the FWU metadata. The version 2 metadata structure is defined in the latest revision of the FWU specification [1]. The earlier versions of these patches were migrating to a version 2 only support

Re: [PATCH v2 0/1] arch: zynqmp: Make zynqmp command more accessible.

2024-04-24 Thread Michal Simek
On 4/10/24 21:50, Charlie Johnston wrote: While working on a third-party board using a ZynqMP, I was unable to use the zynqmp command even with the proper config definitions. While that command appears tied to the architecture, it was being included based on the board selection instead. This

Re: [PATCH] xilinx: zynqmp: Clean up xilinx_zynqmp.h

2024-04-24 Thread Michal Simek
On 4/15/24 09:55, Michal Simek wrote: Options are moving to Kconfig by running sed and comments are staying in that's why do clean up and remove useless comments. Signed-off-by: Michal Simek --- include/configs/xilinx_zynqmp.h | 6 -- 1 file changed, 6 deletions(-) diff --

Re: [PATCH] xilinx: zynqmp: Clean up xilinx_zynqmp.h

2024-04-24 Thread Michal Simek
On 4/15/24 09:55, Michal Simek wrote: Options are moving to Kconfig by running sed and comments are staying in that's why do clean up and remove useless comments. Signed-off-by: Michal Simek --- include/configs/xilinx_zynqmp.h | 6 -- 1 file changed, 6 deletions(-) diff --

Re: [PATCH v2 5/5] common: Convert *.c/h from UTF-8 to ASCII enconfing

2024-04-17 Thread Michal Simek
On 4/16/24 18:19, Heinrich Schuchardt wrote: On 16.04.24 18:06, Tom Rini wrote: On Tue, Apr 16, 2024 at 08:55:19AM +0200, Michal Simek wrote: Convert UTF-8 chars to ASCII in cases where make sense. No Copyright or names are converted. Signed-off-by: Michal Simek Reviewed-by: Tom Rini

[PATCH v2 5/5] common: Convert *.c/h from UTF-8 to ASCII enconfing

2024-04-16 Thread Michal Simek
Convert UTF-8 chars to ASCII in cases where make sense. No Copyright or names are converted. Signed-off-by: Michal Simek --- Changes in v2: - New patch in series .../armv8/fsl-layerscape/fsl_lsch2_serdes.c | 2 +- .../armv8/fsl-layerscape/fsl_lsch3_serdes.c | 2 +- arch/arm/mach-imx

[PATCH v2 0/5] Kconfig: some cleanups

2024-04-16 Thread Michal Simek
2: - Describe temperature as deg C instead of just C - Update commit message to explain the reason - New patch in series Michal Simek (5): Kconfig: Remove trailing whitespace in its prompt Kconfig: Add missing quotes around source file Kconfig: Add missing quotes around default string value

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

2024-04-16 Thread Michal Simek
On 4/16/24 08:59, Francesco Dolcini wrote: On Tue, Apr 16, 2024 at 02:36:12AM +0200, Tom Rini wrote: On Mon, Apr 15, 2024 at 02:22:02PM +0200, Heinrich Schuchardt wrote: On 15.04.24 13:35, Michal Simek wrote: Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of

[PATCH v2 4/5] Kconfig: Make all Kconfig encoding ascii

2024-04-15 Thread Michal Simek
Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging. Based on discussion ASCII should be used in general with the exception of names. Signed-off-by: Michal Simek --- Changes in v2: - Describe temperature as deg C instead of just C - Update

[PATCH v2 3/5] Kconfig: Add missing quotes around default string value

2024-04-15 Thread Michal Simek
All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this: warning: style: quotes recommended around default value for string symbol EFI_VAR_SEED_FILE (defined at lib/efi_loader/Kconfig:130) Signed-off-by: Michal Simek Reviewed-by: Heinrich Schuchardt --- (no

[PATCH v2 2/5] Kconfig: Add missing quotes around source file

2024-04-15 Thread Michal Simek
All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this: drivers/crypto/Kconfig:9: warning: style: quotes recommended around 'drivers/crypto/nuvoton/Kconfig' in 'source drivers/crypto/nuvoton/Kconfig' Signed-off-by: Michal Simek --- (no chan

[PATCH v2 1/5] Kconfig: Remove trailing whitespace in its prompt

2024-04-15 Thread Michal Simek
All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this: warning: SPL_CLK_CCF (defined at drivers/clk/Kconfig:59) has leading or trailing whitespace in its prompt Signed-off-by: Michal Simek --- (no changes since v1) drivers/clk/Kconfig | 10

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

2024-04-15 Thread Michal Simek
On 4/16/24 02:36, Tom Rini wrote: On Mon, Apr 15, 2024 at 02:49:13PM +0200, Michal Simek wrote: On 4/15/24 14:22, Heinrich Schuchardt wrote: On 15.04.24 13:35, Michal Simek wrote: Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

2024-04-15 Thread Michal Simek
On 4/15/24 14:22, Heinrich Schuchardt wrote: On 15.04.24 13:35, Michal Simek wrote: Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging. Signed-off-by: Michal Simek --- There are other files which are using utf-8 enconding and pretty

Re: [PATCH 2/4] Kconfig: Add missing quotes around source file

2024-04-15 Thread Michal Simek
On 4/15/24 14:44, Heinrich Schuchardt wrote: On 15.04.24 13:35, Michal Simek wrote: All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this: drivers/crypto/Kconfig:9: warning: style: quotes recommended around 'drivers/crypto/nuvoton/Kconfig' in '

[PATCH 0/4] Kconfig: some cleanups

2024-04-15 Thread Michal Simek
fined at cmd/Kconfig:1994) warning: the choice symbol EFI_APP (defined at lib/efi/Kconfig:15) is selected by the following symbols, but select/imply has no effect on choice symbols - TARGET_EFI_APP32 (defined at board/efi/Kconfig:7) - TARGET_EFI_APP64 (defined at board/efi/Kconfig:16) Mi

[PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

2024-04-15 Thread Michal Simek
Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging. Signed-off-by: Michal Simek --- There are other files which are using utf-8 enconding and pretty much I think we should convert all of them because there is no reason to use utf-8 encoding

[PATCH 3/4] Kconfig: Add missing quotes around default string value

2024-04-15 Thread Michal Simek
All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this: warning: style: quotes recommended around default value for string symbol EFI_VAR_SEED_FILE (defined at lib/efi_loader/Kconfig:130) Signed-off-by: Michal Simek --- lib/efi_loader/Kconfig | 2 +- 1 file

[PATCH 2/4] Kconfig: Add missing quotes around source file

2024-04-15 Thread Michal Simek
All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this: drivers/crypto/Kconfig:9: warning: style: quotes recommended around 'drivers/crypto/nuvoton/Kconfig' in 'source drivers/crypto/nuvoton/Kconfig' Signed-off-by: Michal Simek --- arch/arm/

[PATCH 1/4] Kconfig: Remove trailing whitespace in its prompt

2024-04-15 Thread Michal Simek
All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this: warning: SPL_CLK_CCF (defined at drivers/clk/Kconfig:59) has leading or trailing whitespace in its prompt Signed-off-by: Michal Simek --- drivers/clk/Kconfig | 10 +- drivers/ddr/imx

[PATCH] Kconfig: Remove all default n options

2024-04-15 Thread Michal Simek
default n doesn't need to be specified. It is default option anyway. Similar changes have been done by commit 18370f14975c ("Kconfig: Remove all default n/no options"). Signed-off-by: Michal Simek --- boot/Kconfig | 1 - cmd/Kconfig | 2 -- 2 files changed, 3 deletions(-) di

[PATCH] xilinx: zynqmp: Clean up xilinx_zynqmp.h

2024-04-15 Thread Michal Simek
Options are moving to Kconfig by running sed and comments are staying in that's why do clean up and remove useless comments. Signed-off-by: Michal Simek --- include/configs/xilinx_zynqmp.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/configs/xilinx_zynqmp.h b/in

[PATCH] xilinx: Enable NVMEM framework for all platforms

2024-04-10 Thread Michal Simek
lt;1>; #size-cells = <1>; mac: mac-address@f0 { reg = <0xf0 6>; }; }; For getting it work above DT changes are required but also CONFIG_NVMEM should be enabled. That's why enable it by default in generic defconfigs to be able to use it directl

[GIT PULL] xilinx patches for v2024.07-rc1

2024-04-10 Thread Michal Simek
rt Lukas Funke (1): arm64: zynqmp: Add label to pmu fwnode Manikanta Guntupalli (1): arm64: zynqmp: dts: Add required properties for rs485 support for KD240 Michal Simek (15): arm64: zynqmp: Remove snps,enable_guctl1_ipd_quirk property riscv: mbv: Align addresses

Re: [PATCH] xilinx: common: Fix MAC address read from EEPROM

2024-04-10 Thread Michal Simek
offsetof(struct xilinx_legacy_format, eth_mac) && > + i < offsetof(struct xilinx_legacy_format, unused1)) { > + continue; > + } > + > + /* Remove all non printable chars */ > + if (byte < '!

Re: [PATCH v3 0/2] Introduce spl_soc_init() for SoC specific initialization

2024-04-10 Thread Michal Simek
Hi, On 4/8/24 14:59, Michal Simek wrote: On 3/27/24 13:11, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke Currently some vendors use spl_board_init() for their SoC specific initialization. This prohibits board developers from adding board init code using said function. This

Re: [PATCH 1/2] board: zynqmp: Move zynqmp commands from board/ to cmd/

2024-04-09 Thread Michal Simek
On 4/8/24 22:13, Charlie Johnston wrote: The zynqmp cmds.c is currently tied to the board but the commands contained within are more closely tied to the architecture. To allow usage of those commands when the architecture is ZynqMP but the board is not, this change moves the cmds into the cmd/

Re: [PATCH v2] configs: zynqmp_kria: Deactivate CONFIG_SPI_FLASH_BAR

2024-04-09 Thread Michal Simek
On 4/9/24 11:48, Tejas Bhumkar wrote: The Kria board features a recovery application that activates when the FW_EN button is pressed. Upon power-up flash operates in 3B mode, However, the recovery application changes it back to 4B mode. Currently, after a reset, u-boot activates CONFIG_SPI_FLA

Re: [PATCH v3 0/2] Introduce spl_soc_init() for SoC specific initialization

2024-04-08 Thread Michal Simek
On 3/27/24 13:11, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke Currently some vendors use spl_board_init() for their SoC specific initialization. This prohibits board developers from adding board init code using said function. This series introduces a new function in order to se

Re: [PATCH] soc: zynqmp: Add the IDcode for TEG variant

2024-04-04 Thread Michal Simek
On 4/2/24 16:23, Venkatesh Yadav Abbarapu wrote: ID code is added for zu3teg variant. Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/soc/soc_xilinx_zynqmp.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/soc/soc_xilinx_zynqmp.c b/drivers/soc/soc_xilinx_zynqmp.c i

Re: [PATCH v2 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-04-03 Thread Michal Simek
On 4/2/24 17:37, James Hilliard wrote: On Tue, Apr 2, 2024 at 6:41 AM Michal Simek wrote: On 4/1/24 01:28, James Hilliard wrote: There are situations where we may want to let U-Boot modify the FDT nand partitions for the kernel, such as when supporting multiple sizes of NAND chips

Re: [PATCH 0/3] Add support for jtag disable/enable and multiboot get/set for zynq

2024-04-02 Thread Michal Simek
Hi, On 3/28/24 10:01, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke This series adds support to enable/disable/lock the jtag interface from u-boot. This becomes handy if secure boot is used but debugging should be poissible for non-productions builds. The series also adds support

Re: [PATCH v3 2/2] arm64: zynq(mp): Rename spl_board_init() to spl_soc_init()

2024-04-02 Thread Michal Simek
L_SOC_INIT +void spl_soc_init(void) { preloader_console_init(); ps_mode_reset(MODE_RESET); Acked-by: Michal Simek Thanks, Michal

Re: [PATCH] arm64: dts: zynqmp: make hw-ecc as the default ecc mode

2024-04-02 Thread Michal Simek
On 3/25/24 10:50, Venkatesh Yadav Abbarapu wrote: Except for Linux no other component (i.e., u-boot, fsbl or BootRom) of the software stack supports software ecc engine. So, make hw-ecc as the default ecc mode. Update the same for mini u-boot nand configuration as well. Signed-off-by: Venkate

Re: [PATCH v2 2/2] arm64: zynqmp: Add MTD partition handling for dfu_alt_info generation

2024-04-02 Thread Michal Simek
On 3/22/24 13:09, Michal Simek wrote: Generate dfu_alt_info generation based on information from MTD partitions. mtd_found_part() is trying to identify MTD partition which code is running from. If partitions are not defined and location is not found it is going to previous behavior. Signed

Re: [PATCH v2 1/2] arm64: zynqmp: Generate desc when SPL_FS_LOAD_PAYLOAD_NAME is valid

2024-04-02 Thread Michal Simek
On 3/22/24 13:09, Michal Simek wrote: Generate description only when CONFIG_SPL_FS_LOAD_PAYLOAD_NAME is not empty. When name is empty there is no reason to generate description for it because it is not aligned with dfu rules. Signed-off-by: Michal Simek --- Changes in v2: - New patch is

Re: [PATCH] xilinx: Do not call private env_get_location() when !ENV_IS_NOWHERE

2024-04-02 Thread Michal Simek
On 3/22/24 12:43, Michal Simek wrote: Private function for finding out location of environment is not working when ENV_IS_NOWHERE is disabled. The reason is that current fallback is ENVL_UNKNOWN when CONFIG_ENV_IS_NOWHERE is not enabled. The code could be updated like this

Re: [PATCH] arm64: zynqmp: Describe DisplayPort connector for Kria

2024-04-02 Thread Michal Simek
On 3/21/24 16:54, Michal Simek wrote: From: Vishal Sagar Add a device tree node to describe the DisplayPort connector, and connect it to the DPSUB output. The patch was tested on kv260-revB/rev2 and also kr260-revB. Signed-off-by: Vishal Sagar Signed-off-by: Michal Simek --- arch/arm

Re: [PATCH v2 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-04-02 Thread Michal Simek
On 4/1/24 01:28, James Hilliard wrote: There are situations where we may want to let U-Boot modify the FDT nand partitions for the kernel, such as when supporting multiple sizes of NAND chips. Signed-off-by: James Hilliard --- Changes v1 -> v2: - move partition fixups to board/xilinx/comm

[PATCH 4/4] zlib: Remove incorrect ZLIB_VERSION

2024-03-27 Thread Michal Simek
not exact version that's why following the same style which has been used by Linux kernel where ZLIB_VERSION is completely removed. Signed-off-by: Michal Simek --- --- include/u-boot/zlib.h | 16 ++-- lib/gzip.c| 2 +- lib/zlib/deflate.c| 13 +++-- lib/

[PATCH 3/4] zlib: Port fix for CVE-2016-9841 to U-Boot

2024-03-27 Thread Michal Simek
ane variable which requires other changes which are also not the part of zlib. Commit 92faa8b10918 ("zlib: handle overflow while calculating available stream input size") is kept in inffast.c too not to break described case. Signed-off-by: Michal Simek --- The first attempt to fix this

[PATCH 2/4] zlib: Rename write variable to wnext (window write index)

2024-03-27 Thread Michal Simek
There is no particular patch/description which described the reason for this change but it was done as the part of zlib 1.2.3.5 release done by zlib commit d004b047838a ("zlib 1.2.3.5"). It is preparation for followup patch. Signed-off-by: Michal Simek --- lib/zlib/inff

[PATCH 1/4] zlib: Rename this variable to here (current decoding table entry)

2024-03-27 Thread Michal Simek
There is no particular patch/description which described the reason for this change but it was done as the part of zlib 1.2.3.5 release done by zlib commit 639be997883d ("zlib 1.2.3.3") It is preparation for followup patch. Signed-off-by: Michal Simek --- lib/zlib/inff

[PATCH 0/4] zlib: Address CVE-2016-9841

2024-03-27 Thread Michal Simek
x27;t use incorrect zlib version string. I tested it with and I can't see any issue. ./test/py/test.py --bd sandbox --build -s And gitlab CI is also not showing any issue. Thanks, Michal Michal Simek (4): zlib: Rename this variable to here (current decoding table entry) zlib: Re

Re: [PATCH] arm64: zynqmp: dts: Add required properties for rs485 support for KD240

2024-03-25 Thread Michal Simek
On 3/19/24 12:27, Michal Simek wrote: From: Manikanta Guntupalli Add "rts-gpios" and "linux,rs485-enabled-at-boot-time" properties to uartps node to support RS485 on KD240. Signed-off-by: Manikanta Guntupalli Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-sc

Re: [PATCH] arm64: zynqmp: Disable Tri-state for SDIO

2024-03-25 Thread Michal Simek
the following error: ZynqMP> mmc dev 1 Card did not respond to voltage select! : -110 To address this problem, configure the SDIO pins for output-enable to enable MMC detection. Signed-off-by: Michal Simek Signed-off-by: Tejas Bhumkar --- arch/arm/dts/zynqmp-sck-kv-g-revA.dtso | 1 + arch/

Re: [PATCH] arm64: zynqmp: Add bootcmd_usb4 variable

2024-03-25 Thread Michal Simek
On 3/20/24 12:24, Michal Simek wrote: From: Shubhangi Shrikrushna Mahalle Add "bootcmd_usb4" variable to boot through usb4 device. Signed-off-by: Shubhangi Shrikrushna Mahalle Signed-off-by: Michal Simek --- It should be the part of https://lore.kernel.org/r/2024030511025

Re: [PATCH] arm64: zynqmp: Also support JTAG as alternative boot mode

2024-03-25 Thread Michal Simek
On 3/20/24 12:18, Michal Simek wrote: if (reg >> BOOT_MODE_ALT_SHIFT) condition rules out alternative jtag boot mode which is 0. When 0 was used origin(HW) boot mode was used instead. That's why directly fill reg variable with requested boot mode and don't let code to read v

Re: [PATCH v2 24/24] dts: support building all dtb files for a specific vendor

2024-03-22 Thread Michal Simek
On 3/21/24 22:04, Caleb Connolly wrote: This adjusts OF_UPSTREAM to behave more like the kernel by allowing for all the devicetree files for a given vendor to be compiled. This is useful for Qualcomm in particular as most boards are supported by a single U-Boot build just provided with a diffe

Re: [PATCH v2 16/24] xlnx: drop dt-binding headers

2024-03-22 Thread Michal Simek
-#defineZYNQMP_RESET_PS_PL1 117 -#defineZYNQMP_RESET_PS_PL2 118 -#defineZYNQMP_RESET_PS_PL3 119 - -#endif Acked-by: Michal Simek Thanks, Michal

[PATCH v2 2/2] arm64: zynqmp: Add MTD partition handling for dfu_alt_info generation

2024-03-22 Thread Michal Simek
Generate dfu_alt_info generation based on information from MTD partitions. mtd_found_part() is trying to identify MTD partition which code is running from. If partitions are not defined and location is not found it is going to previous behavior. Signed-off-by: Michal Simek --- Changes in v2

[PATCH v2 1/2] arm64: zynqmp: Generate desc when SPL_FS_LOAD_PAYLOAD_NAME is valid

2024-03-22 Thread Michal Simek
Generate description only when CONFIG_SPL_FS_LOAD_PAYLOAD_NAME is not empty. When name is empty there is no reason to generate description for it because it is not aligned with dfu rules. Signed-off-by: Michal Simek --- Changes in v2: - New patch is series coming from discussion at https

Re: [PATCH] arm64: zynqmp: Add MTD partition handling for dfu_alt_info generation

2024-03-22 Thread Michal Simek
On 2/23/24 17:18, Michal Simek wrote: Generate dfu_alt_info generation based on information from MTD partitions. mtd_found_part() is trying to identify MTD partition which code is running from. If partitions are not defined and location is not found it is going to previous behavior. Signed

Re: [PATCH] arm64: zynqmp: Do not describe u-boot.itb if SPL is disabled

2024-03-22 Thread Michal Simek
On 2/23/24 17:18, Michal Simek wrote: There is no reason to describe u-boot.itb on system without SPL. Pretty much this is cover all systems which are using only boot.bin which contains all images inside. Signed-off-by: Michal Simek --- board/xilinx/common/board.c | 2 +- 1 file changed

Re: [PATCH] arm64: zynqmp: Do not setup default SPL options without SPL

2024-03-22 Thread Michal Simek
On 3/12/24 16:51, Michal Simek wrote: mach Kconfig file select some options independently of if SPL is actually enabled. It ends up in situation that SPL is disabled but symbols are still present in .config. That's why add SPL dependency for them but also group them with other SPL optio

Re: [PATCH] arm64: zynqmp: Also support JTAG as alternative boot mode

2024-03-22 Thread Michal Simek
On 3/21/24 17:20, Sean Anderson wrote: On 3/20/24 07:18, Michal Simek wrote: if (reg >> BOOT_MODE_ALT_SHIFT) condition rules out alternative jtag boot mode which is 0. When 0 was used origin(HW) boot mode was used instead. That's why directly fill reg variable with requested bo

[PATCH] xilinx: Do not call private env_get_location() when !ENV_IS_NOWHERE

2024-03-22 Thread Michal Simek
then weak env_get_location() is used which is going over env_locations[] and returning locations which are actually enabled in u-boot instance. Signed-off-by: Michal Simek --- board/xilinx/versal-net/board.c | 2 ++ board/xilinx/versal/board.c | 2 ++ board/xilinx/zynqmp/zynqmp.c| 2

Re: [PATCH 05/14] initcall: Adjust the failure message and return value

2024-03-22 Thread Michal Simek
072de8, 0 initcall failed at call 0802b14c (err=-19) And this is the problematic part. for (ptr = init_sequence; func = *ptr, !ret && func; ptr++) { Fix should be of course to get that if(ret) code back but maybe you want to see different solution. Thanks, Michal -- Michal Simek,

Re: [PATCH] scripts/Makefile.spl: Use 'sort' in SHRUNK_ARCH_DTB rule

2024-03-22 Thread Michal Simek
ir $(SHRUNK_ARCH_DTB)): > +$(sort $(dir $(SHRUNK_ARCH_DTB))): > $(shell [ -d $@ ] || mkdir -p $@) > > .SECONDEXPANSION: > -- > 2.34.1 > > The same issue also for zynqmp. Tested-by: Michal Simek Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D

[PATCH] arm64: zynqmp: Describe DisplayPort connector for Kria

2024-03-21 Thread Michal Simek
From: Vishal Sagar Add a device tree node to describe the DisplayPort connector, and connect it to the DPSUB output. The patch was tested on kv260-revB/rev2 and also kr260-revB. Signed-off-by: Vishal Sagar Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-sck-kr-g-revB.dtso | 20

Re: [PATCH 1/2] spl: Introduce architecture specific init function

2024-03-21 Thread Michal Simek
quot;arch->arm->mach-rockchip->rk3399->". > If we follow your proposed rule it should be: > arch->arm->mach-xilinx->zynq->. Maybe this is an idea for the next > cleanup round? > > Regarding the patch: > > I'd agree that the init code is not (cpu)a

Re: [PATCH] configs: zynqmp_kria: Deactivate CONFIG_SPI_FLASH_BAR

2024-03-21 Thread Michal Simek
On 3/21/24 10:25, Tejas Bhumkar wrote: Disable CONFIG_SPI_FLASH_BAR, which activates 4-byte opcodes. Can you please be more specific? There is a bigger story behind which should be also described. The issue which this patch is addressing is that when image recovery application is running U

[PATCH] arm64: zynqmp: Add bootcmd_usb4 variable

2024-03-20 Thread Michal Simek
From: Shubhangi Shrikrushna Mahalle Add "bootcmd_usb4" variable to boot through usb4 device. Signed-off-by: Shubhangi Shrikrushna Mahalle Signed-off-by: Michal Simek --- It should be the part of https://lore.kernel.org/r/20240305110256.153308-1-venkatesh.abbar...@amd.com --- bo

[PATCH] arm64: zynqmp: Also support JTAG as alternative boot mode

2024-03-20 Thread Michal Simek
ain unchanged. Signed-off-by: Michal Simek --- arch/arm/mach-zynqmp/spl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-zynqmp/spl.c b/arch/arm/mach-zynqmp/spl.c index 5af735aa5cef..979ff3aef6c2 100644 --- a/arch/arm/mach-zynqmp/spl.c +++ b/arch/arm/m

[PATCH] arm64: zynqmp: dts: Add required properties for rs485 support for KD240

2024-03-19 Thread Michal Simek
From: Manikanta Guntupalli Add "rts-gpios" and "linux,rs485-enabled-at-boot-time" properties to uartps node to support RS485 on KD240. Signed-off-by: Manikanta Guntupalli Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-sck-kd-g-revA.dtso | 2 ++ 1 file changed, 2

Re: [PATCH 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-03-18 Thread Michal Simek
On 3/18/24 17:17, James Hilliard wrote: On Mon, Mar 18, 2024 at 5:07 AM Michal Simek wrote: On 3/18/24 09:48, James Hilliard wrote: On Mon, Mar 18, 2024 at 2:26 AM Michal Simek wrote: On 3/15/24 20:25, James Hilliard wrote: There are situations where we may want to let U-Boot

Re: [PATCH 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-03-18 Thread Michal Simek
On 3/18/24 09:48, James Hilliard wrote: On Mon, Mar 18, 2024 at 2:26 AM Michal Simek wrote: On 3/15/24 20:25, James Hilliard wrote: There are situations where we may want to let U-Boot modify the FDT please use imperative mood. nand partitions for the kernel, such as when supporting

Re: [PATCH v2] net: phy: Factor out PHY GPIO reset code

2024-03-18 Thread Michal Simek
: Ramon Fried Signed-off-by: Marek Vasut --- Cc: Joe Hershberger Cc: Michal Simek Cc: Nishanth Menon Cc: Ramon Fried --- V2: - Fix am335x_evm build with OF_REAL disabled - Collect RB from Ramon --- drivers/net/phy/ethernet_id.c | 37 +++--- drivers/net/phy/phy.c

Re: [PATCH 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-03-18 Thread Michal Simek
ft_common_board_setup(void *blob, struct bd_info *bd); #endif /* BOARD_XILINX_COMMON_BOARD_H */ diff --git a/board/xilinx/mbv/board.c b/board/xilinx/mbv/board.c index ccf4395d6a..d8af1eaa90 100644 --- a/board/xilinx/mbv/board.c +++ b/board/xilinx/mbv/board.c @@ -5,7 +5,16 @@ * Michal Simek

Re: [PATCH] arm64: zynqmp: Do not describe u-boot.itb if SPL is disabled

2024-03-14 Thread Michal Simek
Hi, On 3/14/24 09:34, Ilias Apalodimas wrote: Hi Michal On Wed, 13 Mar 2024 at 09:01, Ilias Apalodimas wrote: On Wed, 13 Mar 2024 at 08:42, Michal Simek wrote: On 3/12/24 20:12, Ilias Apalodimas wrote: On Tue, 12 Mar 2024 at 17:55, Michal Simek wrote: On 3/12/24 07:14, Ilias

Re: [PATCH] arm64: zynqmp: Do not describe u-boot.itb if SPL is disabled

2024-03-12 Thread Michal Simek
On 3/12/24 20:12, Ilias Apalodimas wrote: On Tue, 12 Mar 2024 at 17:55, Michal Simek wrote: On 3/12/24 07:14, Ilias Apalodimas wrote: Hi Michal Apologies for the late reply On Wed, 6 Mar 2024 at 09:48, Michal Simek wrote: On 3/5/24 16:47, Ilias Apalodimas wrote: On Fri, Feb 23

Re: [PATCH] arm64: zynqmp: Do not describe u-boot.itb if SPL is disabled

2024-03-12 Thread Michal Simek
On 3/12/24 07:14, Ilias Apalodimas wrote: Hi Michal Apologies for the late reply On Wed, 6 Mar 2024 at 09:48, Michal Simek wrote: On 3/5/24 16:47, Ilias Apalodimas wrote: On Fri, Feb 23, 2024 at 05:18:42PM +0100, Michal Simek wrote: There is no reason to describe u-boot.itb on system

[PATCH] arm64: zynqmp: Do not setup default SPL options without SPL

2024-03-12 Thread Michal Simek
imply option. This should ensure the same behavior as default y. Also fixed SPL_ZYNQMP_PSU_INIT_ENABLED for the same. Signed-off-by: Michal Simek --- arch/arm/Kconfig | 8 arch/arm/mach-zynqmp/Kconfig | 27 ++- 2 files changed, 10 insertions(+), 25 dele

Re: [PATCH] arm64: zynqmp: Do not describe u-boot.itb if SPL is disabled

2024-03-12 Thread Michal Simek
On 3/12/24 13:29, Heinrich Schuchardt wrote: On 05.03.24 16:47, Ilias Apalodimas wrote: On Fri, Feb 23, 2024 at 05:18:42PM +0100, Michal Simek wrote: There is no reason to describe u-boot.itb on system without SPL. Pretty much this is cover all systems which are using only boot.bin which

<    1   2   3   4   5   6   7   8   9   10   >